{"action":"closed","number":9090,"pull_request":{"url":"https://api.github.com/repos/openlayers/openlayers/pulls/9090","id":241336959,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMzM2OTU5","html_url":"https://github.com/openlayers/openlayers/pull/9090","diff_url":"https://github.com/openlayers/openlayers/pull/9090.diff","patch_url":"https://github.com/openlayers/openlayers/pull/9090.patch","issue_url":"https://api.github.com/repos/openlayers/openlayers/issues/9090","number":9090,"state":"closed","locked":false,"title":"Add texture & color to the WebGL points renderer","user":{"login":"jahow","id":10629150,"node_id":"MDQ6VXNlcjEwNjI5MTUw","avatar_url":"https://avatars2.githubusercontent.com/u/10629150?v=4","gravatar_id":"","url":"https://api.github.com/users/jahow","html_url":"https://github.com/jahow","followers_url":"https://api.github.com/users/jahow/followers","following_url":"https://api.github.com/users/jahow/following{/other_user}","gists_url":"https://api.github.com/users/jahow/gists{/gist_id}","starred_url":"https://api.github.com/users/jahow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahow/subscriptions","organizations_url":"https://api.github.com/users/jahow/orgs","repos_url":"https://api.github.com/users/jahow/repos","events_url":"https://api.github.com/users/jahow/events{/privacy}","received_events_url":"https://api.github.com/users/jahow/received_events","type":"User","site_admin":false},"body":"This PR improves a bit the `ol/renderer/webgl/PointsLayer` class by adding the possibility to easily define a texture and change the color of points without writing custom shaders.\r\n\r\nAn example was added to showcase this, where a dataset of 80k points is rendered with variable icons and colors: https://592-4723248-gh.circle-artifacts.com/0/examples/icon-sprite-webgl.html\r\n\r\nI think that the WebGL points renderer is now pretty mature, I still have a few examples in mind using custom shaders though.","created_at":"2018-12-28T13:52:29Z","updated_at":"2018-12-30T05:12:12Z","closed_at":"2018-12-30T05:12:12Z","merged_at":"2018-12-30T05:12:12Z","merge_commit_sha":"511e580c76ecb6f3cd46e416e04d5c0351d80851","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openlayers/openlayers/pulls/9090/commits","review_comments_url":"https://api.github.com/repos/openlayers/openlayers/pulls/9090/comments","review_comment_url":"https://api.github.com/repos/openlayers/openlayers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openlayers/openlayers/issues/9090/comments","statuses_url":"https://api.github.com/repos/openlayers/openlayers/statuses/fad7c7edb1eded8cc7c3f8778aeaf913ece0a5b7","head":{"label":"jahow:add-webgl-points-example","ref":"add-webgl-points-example","sha":"fad7c7edb1eded8cc7c3f8778aeaf913ece0a5b7","user":{"login":"jahow","id":10629150,"node_id":"MDQ6VXNlcjEwNjI5MTUw","avatar_url":"https://avatars2.githubusercontent.com/u/10629150?v=4","gravatar_id":"","url":"https://api.github.com/users/jahow","html_url":"https://github.com/jahow","followers_url":"https://api.github.com/users/jahow/followers","following_url":"https://api.github.com/users/jahow/following{/other_user}","gists_url":"https://api.github.com/users/jahow/gists{/gist_id}","starred_url":"https://api.github.com/users/jahow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahow/subscriptions","organizations_url":"https://api.github.com/users/jahow/orgs","repos_url":"https://api.github.com/users/jahow/repos","events_url":"https://api.github.com/users/jahow/events{/privacy}","received_events_url":"https://api.github.com/users/jahow/received_events","type":"User","site_admin":false},"repo":{"id":120439217,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA0MzkyMTc=","name":"openlayers","full_name":"jahow/openlayers","private":false,"owner":{"login":"jahow","id":10629150,"node_id":"MDQ6VXNlcjEwNjI5MTUw","avatar_url":"https://avatars2.githubusercontent.com/u/10629150?v=4","gravatar_id":"","url":"https://api.github.com/users/jahow","html_url":"https://github.com/jahow","followers_url":"https://api.github.com/users/jahow/followers","following_url":"https://api.github.com/users/jahow/following{/other_user}","gists_url":"https://api.github.com/users/jahow/gists{/gist_id}","starred_url":"https://api.github.com/users/jahow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahow/subscriptions","organizations_url":"https://api.github.com/users/jahow/orgs","repos_url":"https://api.github.com/users/jahow/repos","events_url":"https://api.github.com/users/jahow/events{/privacy}","received_events_url":"https://api.github.com/users/jahow/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jahow/openlayers","description":"OpenLayers","fork":true,"url":"https://api.github.com/repos/jahow/openlayers","forks_url":"https://api.github.com/repos/jahow/openlayers/forks","keys_url":"https://api.github.com/repos/jahow/openlayers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jahow/openlayers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jahow/openlayers/teams","hooks_url":"https://api.github.com/repos/jahow/openlayers/hooks","issue_events_url":"https://api.github.com/repos/jahow/openlayers/issues/events{/number}","events_url":"https://api.github.com/repos/jahow/openlayers/events","assignees_url":"https://api.github.com/repos/jahow/openlayers/assignees{/user}","branches_url":"https://api.github.com/repos/jahow/openlayers/branches{/branch}","tags_url":"https://api.github.com/repos/jahow/openlayers/tags","blobs_url":"https://api.github.com/repos/jahow/openlayers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jahow/openlayers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jahow/openlayers/git/refs{/sha}","trees_url":"https://api.github.com/repos/jahow/openlayers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jahow/openlayers/statuses/{sha}","languages_url":"https://api.github.com/repos/jahow/openlayers/languages","stargazers_url":"https://api.github.com/repos/jahow/openlayers/stargazers","contributors_url":"https://api.github.com/repos/jahow/openlayers/contributors","subscribers_url":"https://api.github.com/repos/jahow/openlayers/subscribers","subscription_url":"https://api.github.com/repos/jahow/openlayers/subscription","commits_url":"https://api.github.com/repos/jahow/openlayers/commits{/sha}","git_commits_url":"https://api.github.com/repos/jahow/openlayers/git/commits{/sha}","comments_url":"https://api.github.com/repos/jahow/openlayers/comments{/number}","issue_comment_url":"https://api.github.com/repos/jahow/openlayers/issues/comments{/number}","contents_url":"https://api.github.com/repos/jahow/openlayers/contents/{+path}","compare_url":"https://api.github.com/repos/jahow/openlayers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jahow/openlayers/merges","archive_url":"https://api.github.com/repos/jahow/openlayers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jahow/openlayers/downloads","issues_url":"https://api.github.com/repos/jahow/openlayers/issues{/number}","pulls_url":"https://api.github.com/repos/jahow/openlayers/pulls{/number}","milestones_url":"https://api.github.com/repos/jahow/openlayers/milestones{/number}","notifications_url":"https://api.github.com/repos/jahow/openlayers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jahow/openlayers/labels{/name}","releases_url":"https://api.github.com/repos/jahow/openlayers/releases{/id}","deployments_url":"https://api.github.com/repos/jahow/openlayers/deployments","created_at":"2018-02-06T10:32:56Z","updated_at":"2018-02-06T10:33:02Z","pushed_at":"2018-12-28T15:25:06Z","git_url":"git://github.com/jahow/openlayers.git","ssh_url":"git@github.com:jahow/openlayers.git","clone_url":"https://github.com/jahow/openlayers.git","svn_url":"https://github.com/jahow/openlayers","homepage":"https://openlayers.org","size":78729,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openlayers:master","ref":"master","sha":"435ef3070cb5f4b99834402a7b20f6b736b9cc39","user":{"login":"openlayers","id":240579,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MDU3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/240579?v=4","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"repo":{"id":4723248,"node_id":"MDEwOlJlcG9zaXRvcnk0NzIzMjQ4","name":"openlayers","full_name":"openlayers/openlayers","private":false,"owner":{"login":"openlayers","id":240579,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MDU3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/240579?v=4","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openlayers/openlayers","description":"OpenLayers","fork":false,"url":"https://api.github.com/repos/openlayers/openlayers","forks_url":"https://api.github.com/repos/openlayers/openlayers/forks","keys_url":"https://api.github.com/repos/openlayers/openlayers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openlayers/openlayers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openlayers/openlayers/teams","hooks_url":"https://api.github.com/repos/openlayers/openlayers/hooks","issue_events_url":"https://api.github.com/repos/openlayers/openlayers/issues/events{/number}","events_url":"https://api.github.com/repos/openlayers/openlayers/events","assignees_url":"https://api.github.com/repos/openlayers/openlayers/assignees{/user}","branches_url":"https://api.github.com/repos/openlayers/openlayers/branches{/branch}","tags_url":"https://api.github.com/repos/openlayers/openlayers/tags","blobs_url":"https://api.github.com/repos/openlayers/openlayers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openlayers/openlayers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openlayers/openlayers/git/refs{/sha}","trees_url":"https://api.github.com/repos/openlayers/openlayers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openlayers/openlayers/statuses/{sha}","languages_url":"https://api.github.com/repos/openlayers/openlayers/languages","stargazers_url":"https://api.github.com/repos/openlayers/openlayers/stargazers","contributors_url":"https://api.github.com/repos/openlayers/openlayers/contributors","subscribers_url":"https://api.github.com/repos/openlayers/openlayers/subscribers","subscription_url":"https://api.github.com/repos/openlayers/openlayers/subscription","commits_url":"https://api.github.com/repos/openlayers/openlayers/commits{/sha}","git_commits_url":"https://api.github.com/repos/openlayers/openlayers/git/commits{/sha}","comments_url":"https://api.github.com/repos/openlayers/openlayers/comments{/number}","issue_comment_url":"https://api.github.com/repos/openlayers/openlayers/issues/comments{/number}","contents_url":"https://api.github.com/repos/openlayers/openlayers/contents/{+path}","compare_url":"https://api.github.com/repos/openlayers/openlayers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openlayers/openlayers/merges","archive_url":"https://api.github.com/repos/openlayers/openlayers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openlayers/openlayers/downloads","issues_url":"https://api.github.com/repos/openlayers/openlayers/issues{/number}","pulls_url":"https://api.github.com/repos/openlayers/openlayers/pulls{/number}","milestones_url":"https://api.github.com/repos/openlayers/openlayers/milestones{/number}","notifications_url":"https://api.github.com/repos/openlayers/openlayers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openlayers/openlayers/labels{/name}","releases_url":"https://api.github.com/repos/openlayers/openlayers/releases{/id}","deployments_url":"https://api.github.com/repos/openlayers/openlayers/deployments","created_at":"2012-06-20T06:53:59Z","updated_at":"2018-12-30T04:53:47Z","pushed_at":"2018-12-30T05:12:12Z","git_url":"git://github.com/openlayers/openlayers.git","ssh_url":"git@github.com:openlayers/openlayers.git","clone_url":"https://github.com/openlayers/openlayers.git","svn_url":"https://github.com/openlayers/openlayers","homepage":"https://openlayers.org","size":76419,"stargazers_count":4383,"watchers_count":4383,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1759,"mirror_url":null,"archived":false,"open_issues_count":621,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1759,"open_issues":621,"watchers":4383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openlayers/openlayers/pulls/9090"},"html":{"href":"https://github.com/openlayers/openlayers/pull/9090"},"issue":{"href":"https://api.github.com/repos/openlayers/openlayers/issues/9090"},"comments":{"href":"https://api.github.com/repos/openlayers/openlayers/issues/9090/comments"},"review_comments":{"href":"https://api.github.com/repos/openlayers/openlayers/pulls/9090/comments"},"review_comment":{"href":"https://api.github.com/repos/openlayers/openlayers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openlayers/openlayers/pulls/9090/commits"},"statuses":{"href":"https://api.github.com/repos/openlayers/openlayers/statuses/fad7c7edb1eded8cc7c3f8778aeaf913ece0a5b7"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tschaub","id":41094,"node_id":"MDQ6VXNlcjQxMDk0","avatar_url":"https://avatars0.githubusercontent.com/u/41094?v=4","gravatar_id":"","url":"https://api.github.com/users/tschaub","html_url":"https://github.com/tschaub","followers_url":"https://api.github.com/users/tschaub/followers","following_url":"https://api.github.com/users/tschaub/following{/other_user}","gists_url":"https://api.github.com/users/tschaub/gists{/gist_id}","starred_url":"https://api.github.com/users/tschaub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschaub/subscriptions","organizations_url":"https://api.github.com/users/tschaub/orgs","repos_url":"https://api.github.com/users/tschaub/repos","events_url":"https://api.github.com/users/tschaub/events{/privacy}","received_events_url":"https://api.github.com/users/tschaub/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":80578,"deletions":31,"changed_files":6}}
{"actor":{"display_login":"tschaub"}}