{"action":"created","comment":{"url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/comments/181351148","pull_request_review_id":111963604,"id":181351148,"diff_hunk":"@@ -26,11 +26,14 @@\n #include <gst/video/video-format.h>\n #include <gst/video/video-info.h>\n #include <wtf/MediaTime.h>\n+#include <wtf/Seconds.h>\n \n namespace WebCore {\n \n using GstEventSeqNum = uint32_t;\n class IntSize;\n+// NOTE: YouTube 2018 has tests that expect this to be >= 5s.\n+const WTF::Seconds GST_EME_LICENSE_KEY_RESPONSE_TIMEOUT = WTF::Seconds(6);","path":"Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h","position":11,"original_position":11,"commit_id":"371c62688f6637d3bff213712667daad0dbf75ef","original_commit_id":"371c62688f6637d3bff213712667daad0dbf75ef","user":{"login":"calvaris","id":1021526,"avatar_url":"https://avatars3.githubusercontent.com/u/1021526?v=4","gravatar_id":"","url":"https://api.github.com/users/calvaris","html_url":"https://github.com/calvaris","followers_url":"https://api.github.com/users/calvaris/followers","following_url":"https://api.github.com/users/calvaris/following{/other_user}","gists_url":"https://api.github.com/users/calvaris/gists{/gist_id}","starred_url":"https://api.github.com/users/calvaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvaris/subscriptions","organizations_url":"https://api.github.com/users/calvaris/orgs","repos_url":"https://api.github.com/users/calvaris/repos","events_url":"https://api.github.com/users/calvaris/events{/privacy}","received_events_url":"https://api.github.com/users/calvaris/received_events","type":"User","site_admin":false},"body":"I would add this to a GStreamerEMECommon.h file because it belongs only to EME. That file should be properly flagged.\r\n\r\nI won't oppose to have it here, but I'd request then you flag this for ENCRYPTED_MEDIA","created_at":"2018-04-13T10:43:52Z","updated_at":"2018-04-13T10:43:56Z","html_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/468#discussion_r181351148","pull_request_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/468","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/comments/181351148"},"html":{"href":"https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/468#discussion_r181351148"},"pull_request":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/468"}}},"pull_request":{"url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/468","id":180895236,"html_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/468","diff_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/468.diff","patch_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/468.patch","issue_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues/468","number":468,"state":"open","locked":false,"title":"[EME] Bump license delay timeouts","user":{"login":"charlie-ht","id":14251608,"avatar_url":"https://avatars2.githubusercontent.com/u/14251608?v=4","gravatar_id":"","url":"https://api.github.com/users/charlie-ht","html_url":"https://github.com/charlie-ht","followers_url":"https://api.github.com/users/charlie-ht/followers","following_url":"https://api.github.com/users/charlie-ht/following{/other_user}","gists_url":"https://api.github.com/users/charlie-ht/gists{/gist_id}","starred_url":"https://api.github.com/users/charlie-ht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlie-ht/subscriptions","organizations_url":"https://api.github.com/users/charlie-ht/orgs","repos_url":"https://api.github.com/users/charlie-ht/repos","events_url":"https://api.github.com/users/charlie-ht/events{/privacy}","received_events_url":"https://api.github.com/users/charlie-ht/received_events","type":"User","site_admin":false},"body":"These were hardcoded in the player base class and the decryptor elements. They\r\nhad already drifted apart due to this, so it makes sense to put all license key\r\ntimeouts in one place.\r\n\r\nYouTube 2018 has a test that forces the license key response to be delayed by 5\r\nseconds, so I increased the value to 6 in all places.\r\n\r\n* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:\r\n(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):\r\n(WebCore::MediaPlayerPrivateGStreamerBase::handleProtectionEvent):\r\n* platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:\r\n(webkitMediaCommonEncryptionDecryptTransformInPlace):\r\n* platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.h:","created_at":"2018-04-11T13:00:07Z","updated_at":"2018-04-13T10:43:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"046642733150afdb63407277259473bcfae48ffb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/468/commits","review_comments_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/468/comments","review_comment_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues/468/comments","statuses_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/statuses/371c62688f6637d3bff213712667daad0dbf75ef","head":{"label":"WebPlatformForEmbedded:cturner/license-delay-yt","ref":"cturner/license-delay-yt","sha":"371c62688f6637d3bff213712667daad0dbf75ef","user":{"login":"WebPlatformForEmbedded","id":26092996,"avatar_url":"https://avatars1.githubusercontent.com/u/26092996?v=4","gravatar_id":"","url":"https://api.github.com/users/WebPlatformForEmbedded","html_url":"https://github.com/WebPlatformForEmbedded","followers_url":"https://api.github.com/users/WebPlatformForEmbedded/followers","following_url":"https://api.github.com/users/WebPlatformForEmbedded/following{/other_user}","gists_url":"https://api.github.com/users/WebPlatformForEmbedded/gists{/gist_id}","starred_url":"https://api.github.com/users/WebPlatformForEmbedded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebPlatformForEmbedded/subscriptions","organizations_url":"https://api.github.com/users/WebPlatformForEmbedded/orgs","repos_url":"https://api.github.com/users/WebPlatformForEmbedded/repos","events_url":"https://api.github.com/users/WebPlatformForEmbedded/events{/privacy}","received_events_url":"https://api.github.com/users/WebPlatformForEmbedded/received_events","type":"Organization","site_admin":false},"repo":{"id":28195272,"name":"WPEWebKit","full_name":"WebPlatformForEmbedded/WPEWebKit","owner":{"login":"WebPlatformForEmbedded","id":26092996,"avatar_url":"https://avatars1.githubusercontent.com/u/26092996?v=4","gravatar_id":"","url":"https://api.github.com/users/WebPlatformForEmbedded","html_url":"https://github.com/WebPlatformForEmbedded","followers_url":"https://api.github.com/users/WebPlatformForEmbedded/followers","following_url":"https://api.github.com/users/WebPlatformForEmbedded/following{/other_user}","gists_url":"https://api.github.com/users/WebPlatformForEmbedded/gists{/gist_id}","starred_url":"https://api.github.com/users/WebPlatformForEmbedded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebPlatformForEmbedded/subscriptions","organizations_url":"https://api.github.com/users/WebPlatformForEmbedded/orgs","repos_url":"https://api.github.com/users/WebPlatformForEmbedded/repos","events_url":"https://api.github.com/users/WebPlatformForEmbedded/events{/privacy}","received_events_url":"https://api.github.com/users/WebPlatformForEmbedded/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit","description":"WPE WebKit port (downstream)","fork":true,"url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit","forks_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/forks","keys_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/teams","hooks_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/hooks","issue_events_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues/events{/number}","events_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/events","assignees_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/assignees{/user}","branches_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/branches{/branch}","tags_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/tags","blobs_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/statuses/{sha}","languages_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/languages","stargazers_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/stargazers","contributors_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/contributors","subscribers_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/subscribers","subscription_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/subscription","commits_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/contents/{+path}","compare_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/merges","archive_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/downloads","issues_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues{/number}","pulls_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls{/number}","milestones_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/milestones{/number}","notifications_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/labels{/name}","releases_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/releases{/id}","deployments_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/deployments","created_at":"2014-12-18T18:08:02Z","updated_at":"2018-04-12T22:06:19Z","pushed_at":"2018-04-13T10:37:27Z","git_url":"git://github.com/WebPlatformForEmbedded/WPEWebKit.git","ssh_url":"git@github.com:WebPlatformForEmbedded/WPEWebKit.git","clone_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit.git","svn_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit","homepage":"","size":7721056,"stargazers_count":72,"watchers_count":72,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":82,"license":null,"forks":58,"open_issues":82,"watchers":72,"default_branch":"master"}},"base":{"label":"WebPlatformForEmbedded:wpe-20170728","ref":"wpe-20170728","sha":"1056f7dda4759871bb582cd4e0a094c83cd5a37a","user":{"login":"WebPlatformForEmbedded","id":26092996,"avatar_url":"https://avatars1.githubusercontent.com/u/26092996?v=4","gravatar_id":"","url":"https://api.github.com/users/WebPlatformForEmbedded","html_url":"https://github.com/WebPlatformForEmbedded","followers_url":"https://api.github.com/users/WebPlatformForEmbedded/followers","following_url":"https://api.github.com/users/WebPlatformForEmbedded/following{/other_user}","gists_url":"https://api.github.com/users/WebPlatformForEmbedded/gists{/gist_id}","starred_url":"https://api.github.com/users/WebPlatformForEmbedded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebPlatformForEmbedded/subscriptions","organizations_url":"https://api.github.com/users/WebPlatformForEmbedded/orgs","repos_url":"https://api.github.com/users/WebPlatformForEmbedded/repos","events_url":"https://api.github.com/users/WebPlatformForEmbedded/events{/privacy}","received_events_url":"https://api.github.com/users/WebPlatformForEmbedded/received_events","type":"Organization","site_admin":false},"repo":{"id":28195272,"name":"WPEWebKit","full_name":"WebPlatformForEmbedded/WPEWebKit","owner":{"login":"WebPlatformForEmbedded","id":26092996,"avatar_url":"https://avatars1.githubusercontent.com/u/26092996?v=4","gravatar_id":"","url":"https://api.github.com/users/WebPlatformForEmbedded","html_url":"https://github.com/WebPlatformForEmbedded","followers_url":"https://api.github.com/users/WebPlatformForEmbedded/followers","following_url":"https://api.github.com/users/WebPlatformForEmbedded/following{/other_user}","gists_url":"https://api.github.com/users/WebPlatformForEmbedded/gists{/gist_id}","starred_url":"https://api.github.com/users/WebPlatformForEmbedded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebPlatformForEmbedded/subscriptions","organizations_url":"https://api.github.com/users/WebPlatformForEmbedded/orgs","repos_url":"https://api.github.com/users/WebPlatformForEmbedded/repos","events_url":"https://api.github.com/users/WebPlatformForEmbedded/events{/privacy}","received_events_url":"https://api.github.com/users/WebPlatformForEmbedded/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit","description":"WPE WebKit port (downstream)","fork":true,"url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit","forks_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/forks","keys_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/teams","hooks_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/hooks","issue_events_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues/events{/number}","events_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/events","assignees_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/assignees{/user}","branches_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/branches{/branch}","tags_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/tags","blobs_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/statuses/{sha}","languages_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/languages","stargazers_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/stargazers","contributors_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/contributors","subscribers_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/subscribers","subscription_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/subscription","commits_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/contents/{+path}","compare_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/merges","archive_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/downloads","issues_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues{/number}","pulls_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls{/number}","milestones_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/milestones{/number}","notifications_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/labels{/name}","releases_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/releases{/id}","deployments_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/deployments","created_at":"2014-12-18T18:08:02Z","updated_at":"2018-04-12T22:06:19Z","pushed_at":"2018-04-13T10:37:27Z","git_url":"git://github.com/WebPlatformForEmbedded/WPEWebKit.git","ssh_url":"git@github.com:WebPlatformForEmbedded/WPEWebKit.git","clone_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit.git","svn_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit","homepage":"","size":7721056,"stargazers_count":72,"watchers_count":72,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":82,"license":null,"forks":58,"open_issues":82,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/468"},"html":{"href":"https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/468"},"issue":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues/468"},"comments":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues/468/comments"},"review_comments":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/468/comments"},"review_comment":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/468/commits"},"statuses":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/statuses/371c62688f6637d3bff213712667daad0dbf75ef"}},"author_association":"NONE"}}
{"actor":{"display_login":"calvaris"}}