{"action":"created","comment":{"url":"https://api.github.com/repos/react-native-community/react-native-cli/pulls/comments/234593714","pull_request_review_id":176264763,"id":234593714,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDU5MzcxNA==","diff_hunk":"@@ -12,8 +12,8 @@ const launchChrome = require('../util/launchChrome');\n \n const {exec} = require('child_process');\n \n-function launchChromeDevTools(host, args = '') {\n-  var debuggerURL = 'http://' + host + '/debugger-ui' + args;\n+function launchChromeDevTools(host, port, args = '') {\n+  var debuggerURL = `http://${host}:${port}/debugger-ui${args}`;","path":"packages/local-cli/server/middleware/getDevToolsMiddleware.js","position":null,"original_position":7,"commit_id":"6a727c3567ac210c60e45a5ac71c05eb9a58c201","original_commit_id":"f6fa972d299277099ce453370bae6503fae7f7be","user":{"login":"grabbou","id":2464966,"node_id":"MDQ6VXNlcjI0NjQ5NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/2464966?v=4","gravatar_id":"","url":"https://api.github.com/users/grabbou","html_url":"https://github.com/grabbou","followers_url":"https://api.github.com/users/grabbou/followers","following_url":"https://api.github.com/users/grabbou/following{/other_user}","gists_url":"https://api.github.com/users/grabbou/gists{/gist_id}","starred_url":"https://api.github.com/users/grabbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grabbou/subscriptions","organizations_url":"https://api.github.com/users/grabbou/orgs","repos_url":"https://api.github.com/users/grabbou/repos","events_url":"https://api.github.com/users/grabbou/events{/privacy}","received_events_url":"https://api.github.com/users/grabbou/received_events","type":"User","site_admin":false},"body":"Oh, this \"suggested change\" is nice!","created_at":"2018-11-19T12:04:36Z","updated_at":"2018-11-19T12:04:36Z","html_url":"https://github.com/react-native-community/react-native-cli/pull/28#discussion_r234593714","pull_request_url":"https://api.github.com/repos/react-native-community/react-native-cli/pulls/28","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/react-native-community/react-native-cli/pulls/comments/234593714"},"html":{"href":"https://github.com/react-native-community/react-native-cli/pull/28#discussion_r234593714"},"pull_request":{"href":"https://api.github.com/repos/react-native-community/react-native-cli/pulls/28"}},"in_reply_to_id":234098633},"pull_request":{"url":"https://api.github.com/repos/react-native-community/react-native-cli/pulls/28","id":231245038,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjQ1MDM4","html_url":"https://github.com/react-native-community/react-native-cli/pull/28","diff_url":"https://github.com/react-native-community/react-native-cli/pull/28.diff","patch_url":"https://github.com/react-native-community/react-native-cli/pull/28.patch","issue_url":"https://api.github.com/repos/react-native-community/react-native-cli/issues/28","number":28,"state":"open","locked":false,"title":"fix: Fix opening dev tools","user":{"login":"Esemesek","id":9092510,"node_id":"MDQ6VXNlcjkwOTI1MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9092510?v=4","gravatar_id":"","url":"https://api.github.com/users/Esemesek","html_url":"https://github.com/Esemesek","followers_url":"https://api.github.com/users/Esemesek/followers","following_url":"https://api.github.com/users/Esemesek/following{/other_user}","gists_url":"https://api.github.com/users/Esemesek/gists{/gist_id}","starred_url":"https://api.github.com/users/Esemesek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esemesek/subscriptions","organizations_url":"https://api.github.com/users/Esemesek/orgs","repos_url":"https://api.github.com/users/Esemesek/repos","events_url":"https://api.github.com/users/Esemesek/events{/privacy}","received_events_url":"https://api.github.com/users/Esemesek/received_events","type":"User","site_admin":false},"body":"## The issue\r\nOpening `dev tools` was causing opening of `chrome` browser on a wrong URL.\r\n\r\n## Current behavior\r\nDev tools are opened on default `port` and `host`. Default `port` is `8081` and `host` is `localhost`.\r\nIf you want to change the default behavior, you can do it by providing `--host` and `--port` cmd arguments.\r\n","created_at":"2018-11-15T15:56:08Z","updated_at":"2018-11-19T12:04:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0be041e26a08d236ddd4e7272c9df4dbc54be78d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/react-native-community/react-native-cli/pulls/28/commits","review_comments_url":"https://api.github.com/repos/react-native-community/react-native-cli/pulls/28/comments","review_comment_url":"https://api.github.com/repos/react-native-community/react-native-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/react-native-community/react-native-cli/issues/28/comments","statuses_url":"https://api.github.com/repos/react-native-community/react-native-cli/statuses/6a727c3567ac210c60e45a5ac71c05eb9a58c201","head":{"label":"Esemesek:fix/opening-dev-tools","ref":"fix/opening-dev-tools","sha":"6a727c3567ac210c60e45a5ac71c05eb9a58c201","user":{"login":"Esemesek","id":9092510,"node_id":"MDQ6VXNlcjkwOTI1MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9092510?v=4","gravatar_id":"","url":"https://api.github.com/users/Esemesek","html_url":"https://github.com/Esemesek","followers_url":"https://api.github.com/users/Esemesek/followers","following_url":"https://api.github.com/users/Esemesek/following{/other_user}","gists_url":"https://api.github.com/users/Esemesek/gists{/gist_id}","starred_url":"https://api.github.com/users/Esemesek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esemesek/subscriptions","organizations_url":"https://api.github.com/users/Esemesek/orgs","repos_url":"https://api.github.com/users/Esemesek/repos","events_url":"https://api.github.com/users/Esemesek/events{/privacy}","received_events_url":"https://api.github.com/users/Esemesek/received_events","type":"User","site_admin":false},"repo":{"id":153932525,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM5MzI1MjU=","name":"react-native-cli","full_name":"Esemesek/react-native-cli","private":false,"owner":{"login":"Esemesek","id":9092510,"node_id":"MDQ6VXNlcjkwOTI1MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9092510?v=4","gravatar_id":"","url":"https://api.github.com/users/Esemesek","html_url":"https://github.com/Esemesek","followers_url":"https://api.github.com/users/Esemesek/followers","following_url":"https://api.github.com/users/Esemesek/following{/other_user}","gists_url":"https://api.github.com/users/Esemesek/gists{/gist_id}","starred_url":"https://api.github.com/users/Esemesek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esemesek/subscriptions","organizations_url":"https://api.github.com/users/Esemesek/orgs","repos_url":"https://api.github.com/users/Esemesek/repos","events_url":"https://api.github.com/users/Esemesek/events{/privacy}","received_events_url":"https://api.github.com/users/Esemesek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Esemesek/react-native-cli","description":"React Native command line tools","fork":true,"url":"https://api.github.com/repos/Esemesek/react-native-cli","forks_url":"https://api.github.com/repos/Esemesek/react-native-cli/forks","keys_url":"https://api.github.com/repos/Esemesek/react-native-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esemesek/react-native-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esemesek/react-native-cli/teams","hooks_url":"https://api.github.com/repos/Esemesek/react-native-cli/hooks","issue_events_url":"https://api.github.com/repos/Esemesek/react-native-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Esemesek/react-native-cli/events","assignees_url":"https://api.github.com/repos/Esemesek/react-native-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Esemesek/react-native-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Esemesek/react-native-cli/tags","blobs_url":"https://api.github.com/repos/Esemesek/react-native-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esemesek/react-native-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esemesek/react-native-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esemesek/react-native-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esemesek/react-native-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Esemesek/react-native-cli/languages","stargazers_url":"https://api.github.com/repos/Esemesek/react-native-cli/stargazers","contributors_url":"https://api.github.com/repos/Esemesek/react-native-cli/contributors","subscribers_url":"https://api.github.com/repos/Esemesek/react-native-cli/subscribers","subscription_url":"https://api.github.com/repos/Esemesek/react-native-cli/subscription","commits_url":"https://api.github.com/repos/Esemesek/react-native-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esemesek/react-native-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esemesek/react-native-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esemesek/react-native-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esemesek/react-native-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Esemesek/react-native-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esemesek/react-native-cli/merges","archive_url":"https://api.github.com/repos/Esemesek/react-native-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esemesek/react-native-cli/downloads","issues_url":"https://api.github.com/repos/Esemesek/react-native-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Esemesek/react-native-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Esemesek/react-native-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Esemesek/react-native-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esemesek/react-native-cli/labels{/name}","releases_url":"https://api.github.com/repos/Esemesek/react-native-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Esemesek/react-native-cli/deployments","created_at":"2018-10-20T17:48:55Z","updated_at":"2018-10-20T17:50:30Z","pushed_at":"2018-11-17T12:17:31Z","git_url":"git://github.com/Esemesek/react-native-cli.git","ssh_url":"git@github.com:Esemesek/react-native-cli.git","clone_url":"https://github.com/Esemesek/react-native-cli.git","svn_url":"https://github.com/Esemesek/react-native-cli","homepage":null,"size":3428,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"react-native-community:master","ref":"master","sha":"32c34e90513557af652068747da76c96e501f56a","user":{"login":"react-native-community","id":20269980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjY5OTgw","avatar_url":"https://avatars1.githubusercontent.com/u/20269980?v=4","gravatar_id":"","url":"https://api.github.com/users/react-native-community","html_url":"https://github.com/react-native-community","followers_url":"https://api.github.com/users/react-native-community/followers","following_url":"https://api.github.com/users/react-native-community/following{/other_user}","gists_url":"https://api.github.com/users/react-native-community/gists{/gist_id}","starred_url":"https://api.github.com/users/react-native-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-native-community/subscriptions","organizations_url":"https://api.github.com/users/react-native-community/orgs","repos_url":"https://api.github.com/users/react-native-community/repos","events_url":"https://api.github.com/users/react-native-community/events{/privacy}","received_events_url":"https://api.github.com/users/react-native-community/received_events","type":"Organization","site_admin":false},"repo":{"id":150330224,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAzMzAyMjQ=","name":"react-native-cli","full_name":"react-native-community/react-native-cli","private":false,"owner":{"login":"react-native-community","id":20269980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjY5OTgw","avatar_url":"https://avatars1.githubusercontent.com/u/20269980?v=4","gravatar_id":"","url":"https://api.github.com/users/react-native-community","html_url":"https://github.com/react-native-community","followers_url":"https://api.github.com/users/react-native-community/followers","following_url":"https://api.github.com/users/react-native-community/following{/other_user}","gists_url":"https://api.github.com/users/react-native-community/gists{/gist_id}","starred_url":"https://api.github.com/users/react-native-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-native-community/subscriptions","organizations_url":"https://api.github.com/users/react-native-community/orgs","repos_url":"https://api.github.com/users/react-native-community/repos","events_url":"https://api.github.com/users/react-native-community/events{/privacy}","received_events_url":"https://api.github.com/users/react-native-community/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/react-native-community/react-native-cli","description":"React Native command line tools","fork":false,"url":"https://api.github.com/repos/react-native-community/react-native-cli","forks_url":"https://api.github.com/repos/react-native-community/react-native-cli/forks","keys_url":"https://api.github.com/repos/react-native-community/react-native-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-native-community/react-native-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-native-community/react-native-cli/teams","hooks_url":"https://api.github.com/repos/react-native-community/react-native-cli/hooks","issue_events_url":"https://api.github.com/repos/react-native-community/react-native-cli/issues/events{/number}","events_url":"https://api.github.com/repos/react-native-community/react-native-cli/events","assignees_url":"https://api.github.com/repos/react-native-community/react-native-cli/assignees{/user}","branches_url":"https://api.github.com/repos/react-native-community/react-native-cli/branches{/branch}","tags_url":"https://api.github.com/repos/react-native-community/react-native-cli/tags","blobs_url":"https://api.github.com/repos/react-native-community/react-native-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-native-community/react-native-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-native-community/react-native-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-native-community/react-native-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-native-community/react-native-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/react-native-community/react-native-cli/languages","stargazers_url":"https://api.github.com/repos/react-native-community/react-native-cli/stargazers","contributors_url":"https://api.github.com/repos/react-native-community/react-native-cli/contributors","subscribers_url":"https://api.github.com/repos/react-native-community/react-native-cli/subscribers","subscription_url":"https://api.github.com/repos/react-native-community/react-native-cli/subscription","commits_url":"https://api.github.com/repos/react-native-community/react-native-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-native-community/react-native-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-native-community/react-native-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-native-community/react-native-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-native-community/react-native-cli/contents/{+path}","compare_url":"https://api.github.com/repos/react-native-community/react-native-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-native-community/react-native-cli/merges","archive_url":"https://api.github.com/repos/react-native-community/react-native-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-native-community/react-native-cli/downloads","issues_url":"https://api.github.com/repos/react-native-community/react-native-cli/issues{/number}","pulls_url":"https://api.github.com/repos/react-native-community/react-native-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/react-native-community/react-native-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/react-native-community/react-native-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-native-community/react-native-cli/labels{/name}","releases_url":"https://api.github.com/repos/react-native-community/react-native-cli/releases{/id}","deployments_url":"https://api.github.com/repos/react-native-community/react-native-cli/deployments","created_at":"2018-09-25T21:15:26Z","updated_at":"2018-11-09T21:47:05Z","pushed_at":"2018-11-17T12:17:32Z","git_url":"git://github.com/react-native-community/react-native-cli.git","ssh_url":"git@github.com:react-native-community/react-native-cli.git","clone_url":"https://github.com/react-native-community/react-native-cli.git","svn_url":"https://github.com/react-native-community/react-native-cli","homepage":null,"size":3415,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":15,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-native-community/react-native-cli/pulls/28"},"html":{"href":"https://github.com/react-native-community/react-native-cli/pull/28"},"issue":{"href":"https://api.github.com/repos/react-native-community/react-native-cli/issues/28"},"comments":{"href":"https://api.github.com/repos/react-native-community/react-native-cli/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/react-native-community/react-native-cli/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/react-native-community/react-native-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/react-native-community/react-native-cli/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/react-native-community/react-native-cli/statuses/6a727c3567ac210c60e45a5ac71c05eb9a58c201"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"grabbou"}}