{"action":"closed","number":59,"pull_request":{"url":"https://api.github.com/repos/flavray/avro-rs/pulls/59","id":240757075,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNzU3MDc1","html_url":"https://github.com/flavray/avro-rs/pull/59","diff_url":"https://github.com/flavray/avro-rs/pull/59.diff","patch_url":"https://github.com/flavray/avro-rs/pull/59.patch","issue_url":"https://api.github.com/repos/flavray/avro-rs/issues/59","number":59,"state":"closed","locked":false,"title":"Fix variable-length encoding for big i64 numbers","user":{"login":"bzikarsky","id":225374,"node_id":"MDQ6VXNlcjIyNTM3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/225374?v=4","gravatar_id":"","url":"https://api.github.com/users/bzikarsky","html_url":"https://github.com/bzikarsky","followers_url":"https://api.github.com/users/bzikarsky/followers","following_url":"https://api.github.com/users/bzikarsky/following{/other_user}","gists_url":"https://api.github.com/users/bzikarsky/gists{/gist_id}","starred_url":"https://api.github.com/users/bzikarsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzikarsky/subscriptions","organizations_url":"https://api.github.com/users/bzikarsky/orgs","repos_url":"https://api.github.com/users/bzikarsky/repos","events_url":"https://api.github.com/users/bzikarsky/events{/privacy}","received_events_url":"https://api.github.com/users/bzikarsky/received_events","type":"User","site_admin":false},"body":"`util::encode_variable(i64)` took a i64 but used both `>>` (which does an arithmetic shift for i64) and `>=`. Those operations don't work on numbers/bytes which are still zig-zag-encoded because a large zig-zag\r\nencoded number may have a leading `1`. This breaks `>=` as the number is assumed to be negative and also the right-shift will keep introducing new `1`s which leads to an infinite loop.\r\n\r\nReplacing the argument (and the callsites) with an u64 fixes those issues.\r\n\r\nTo make sure this does not regress in the future, tests for `i64::MAX` and `i64::MIN` have been added.","created_at":"2018-12-24T10:52:19Z","updated_at":"2018-12-24T12:12:03Z","closed_at":"2018-12-24T12:12:03Z","merged_at":"2018-12-24T12:12:03Z","merge_commit_sha":"9492d6c38a3ef6206ec0a82192a08a493864fe6a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flavray/avro-rs/pulls/59/commits","review_comments_url":"https://api.github.com/repos/flavray/avro-rs/pulls/59/comments","review_comment_url":"https://api.github.com/repos/flavray/avro-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flavray/avro-rs/issues/59/comments","statuses_url":"https://api.github.com/repos/flavray/avro-rs/statuses/0175550a57066d34daf83b04c7f262df82a5dcef","head":{"label":"bzikarsky:fix-variable-length-encoding","ref":"fix-variable-length-encoding","sha":"0175550a57066d34daf83b04c7f262df82a5dcef","user":{"login":"bzikarsky","id":225374,"node_id":"MDQ6VXNlcjIyNTM3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/225374?v=4","gravatar_id":"","url":"https://api.github.com/users/bzikarsky","html_url":"https://github.com/bzikarsky","followers_url":"https://api.github.com/users/bzikarsky/followers","following_url":"https://api.github.com/users/bzikarsky/following{/other_user}","gists_url":"https://api.github.com/users/bzikarsky/gists{/gist_id}","starred_url":"https://api.github.com/users/bzikarsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzikarsky/subscriptions","organizations_url":"https://api.github.com/users/bzikarsky/orgs","repos_url":"https://api.github.com/users/bzikarsky/repos","events_url":"https://api.github.com/users/bzikarsky/events{/privacy}","received_events_url":"https://api.github.com/users/bzikarsky/received_events","type":"User","site_admin":false},"repo":{"id":162923005,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI5MjMwMDU=","name":"avro-rs","full_name":"bzikarsky/avro-rs","private":false,"owner":{"login":"bzikarsky","id":225374,"node_id":"MDQ6VXNlcjIyNTM3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/225374?v=4","gravatar_id":"","url":"https://api.github.com/users/bzikarsky","html_url":"https://github.com/bzikarsky","followers_url":"https://api.github.com/users/bzikarsky/followers","following_url":"https://api.github.com/users/bzikarsky/following{/other_user}","gists_url":"https://api.github.com/users/bzikarsky/gists{/gist_id}","starred_url":"https://api.github.com/users/bzikarsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzikarsky/subscriptions","organizations_url":"https://api.github.com/users/bzikarsky/orgs","repos_url":"https://api.github.com/users/bzikarsky/repos","events_url":"https://api.github.com/users/bzikarsky/events{/privacy}","received_events_url":"https://api.github.com/users/bzikarsky/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bzikarsky/avro-rs","description":"Avro client library implementation in Rust","fork":true,"url":"https://api.github.com/repos/bzikarsky/avro-rs","forks_url":"https://api.github.com/repos/bzikarsky/avro-rs/forks","keys_url":"https://api.github.com/repos/bzikarsky/avro-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bzikarsky/avro-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bzikarsky/avro-rs/teams","hooks_url":"https://api.github.com/repos/bzikarsky/avro-rs/hooks","issue_events_url":"https://api.github.com/repos/bzikarsky/avro-rs/issues/events{/number}","events_url":"https://api.github.com/repos/bzikarsky/avro-rs/events","assignees_url":"https://api.github.com/repos/bzikarsky/avro-rs/assignees{/user}","branches_url":"https://api.github.com/repos/bzikarsky/avro-rs/branches{/branch}","tags_url":"https://api.github.com/repos/bzikarsky/avro-rs/tags","blobs_url":"https://api.github.com/repos/bzikarsky/avro-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bzikarsky/avro-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bzikarsky/avro-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bzikarsky/avro-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bzikarsky/avro-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/bzikarsky/avro-rs/languages","stargazers_url":"https://api.github.com/repos/bzikarsky/avro-rs/stargazers","contributors_url":"https://api.github.com/repos/bzikarsky/avro-rs/contributors","subscribers_url":"https://api.github.com/repos/bzikarsky/avro-rs/subscribers","subscription_url":"https://api.github.com/repos/bzikarsky/avro-rs/subscription","commits_url":"https://api.github.com/repos/bzikarsky/avro-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bzikarsky/avro-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bzikarsky/avro-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bzikarsky/avro-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bzikarsky/avro-rs/contents/{+path}","compare_url":"https://api.github.com/repos/bzikarsky/avro-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bzikarsky/avro-rs/merges","archive_url":"https://api.github.com/repos/bzikarsky/avro-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bzikarsky/avro-rs/downloads","issues_url":"https://api.github.com/repos/bzikarsky/avro-rs/issues{/number}","pulls_url":"https://api.github.com/repos/bzikarsky/avro-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/bzikarsky/avro-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/bzikarsky/avro-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bzikarsky/avro-rs/labels{/name}","releases_url":"https://api.github.com/repos/bzikarsky/avro-rs/releases{/id}","deployments_url":"https://api.github.com/repos/bzikarsky/avro-rs/deployments","created_at":"2018-12-23T20:49:10Z","updated_at":"2018-12-23T20:49:12Z","pushed_at":"2018-12-24T10:51:09Z","git_url":"git://github.com/bzikarsky/avro-rs.git","ssh_url":"git@github.com:bzikarsky/avro-rs.git","clone_url":"https://github.com/bzikarsky/avro-rs.git","svn_url":"https://github.com/bzikarsky/avro-rs","homepage":null,"size":211,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flavray:master","ref":"master","sha":"29f318b26332c0f23a5d60dd1ab2ab76713136ce","user":{"login":"flavray","id":4570851,"node_id":"MDQ6VXNlcjQ1NzA4NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/4570851?v=4","gravatar_id":"","url":"https://api.github.com/users/flavray","html_url":"https://github.com/flavray","followers_url":"https://api.github.com/users/flavray/followers","following_url":"https://api.github.com/users/flavray/following{/other_user}","gists_url":"https://api.github.com/users/flavray/gists{/gist_id}","starred_url":"https://api.github.com/users/flavray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flavray/subscriptions","organizations_url":"https://api.github.com/users/flavray/orgs","repos_url":"https://api.github.com/users/flavray/repos","events_url":"https://api.github.com/users/flavray/events{/privacy}","received_events_url":"https://api.github.com/users/flavray/received_events","type":"User","site_admin":false},"repo":{"id":113157901,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxNTc5MDE=","name":"avro-rs","full_name":"flavray/avro-rs","private":false,"owner":{"login":"flavray","id":4570851,"node_id":"MDQ6VXNlcjQ1NzA4NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/4570851?v=4","gravatar_id":"","url":"https://api.github.com/users/flavray","html_url":"https://github.com/flavray","followers_url":"https://api.github.com/users/flavray/followers","following_url":"https://api.github.com/users/flavray/following{/other_user}","gists_url":"https://api.github.com/users/flavray/gists{/gist_id}","starred_url":"https://api.github.com/users/flavray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flavray/subscriptions","organizations_url":"https://api.github.com/users/flavray/orgs","repos_url":"https://api.github.com/users/flavray/repos","events_url":"https://api.github.com/users/flavray/events{/privacy}","received_events_url":"https://api.github.com/users/flavray/received_events","type":"User","site_admin":false},"html_url":"https://github.com/flavray/avro-rs","description":"Avro client library implementation in Rust","fork":false,"url":"https://api.github.com/repos/flavray/avro-rs","forks_url":"https://api.github.com/repos/flavray/avro-rs/forks","keys_url":"https://api.github.com/repos/flavray/avro-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flavray/avro-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flavray/avro-rs/teams","hooks_url":"https://api.github.com/repos/flavray/avro-rs/hooks","issue_events_url":"https://api.github.com/repos/flavray/avro-rs/issues/events{/number}","events_url":"https://api.github.com/repos/flavray/avro-rs/events","assignees_url":"https://api.github.com/repos/flavray/avro-rs/assignees{/user}","branches_url":"https://api.github.com/repos/flavray/avro-rs/branches{/branch}","tags_url":"https://api.github.com/repos/flavray/avro-rs/tags","blobs_url":"https://api.github.com/repos/flavray/avro-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flavray/avro-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flavray/avro-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/flavray/avro-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flavray/avro-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/flavray/avro-rs/languages","stargazers_url":"https://api.github.com/repos/flavray/avro-rs/stargazers","contributors_url":"https://api.github.com/repos/flavray/avro-rs/contributors","subscribers_url":"https://api.github.com/repos/flavray/avro-rs/subscribers","subscription_url":"https://api.github.com/repos/flavray/avro-rs/subscription","commits_url":"https://api.github.com/repos/flavray/avro-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/flavray/avro-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/flavray/avro-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/flavray/avro-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/flavray/avro-rs/contents/{+path}","compare_url":"https://api.github.com/repos/flavray/avro-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flavray/avro-rs/merges","archive_url":"https://api.github.com/repos/flavray/avro-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flavray/avro-rs/downloads","issues_url":"https://api.github.com/repos/flavray/avro-rs/issues{/number}","pulls_url":"https://api.github.com/repos/flavray/avro-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/flavray/avro-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/flavray/avro-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flavray/avro-rs/labels{/name}","releases_url":"https://api.github.com/repos/flavray/avro-rs/releases{/id}","deployments_url":"https://api.github.com/repos/flavray/avro-rs/deployments","created_at":"2017-12-05T08:59:24Z","updated_at":"2018-12-23T04:17:13Z","pushed_at":"2018-12-24T12:12:03Z","git_url":"git://github.com/flavray/avro-rs.git","ssh_url":"git@github.com:flavray/avro-rs.git","clone_url":"https://github.com/flavray/avro-rs.git","svn_url":"https://github.com/flavray/avro-rs","homepage":null,"size":227,"stargazers_count":24,"watchers_count":24,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":3,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flavray/avro-rs/pulls/59"},"html":{"href":"https://github.com/flavray/avro-rs/pull/59"},"issue":{"href":"https://api.github.com/repos/flavray/avro-rs/issues/59"},"comments":{"href":"https://api.github.com/repos/flavray/avro-rs/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/flavray/avro-rs/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/flavray/avro-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flavray/avro-rs/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/flavray/avro-rs/statuses/0175550a57066d34daf83b04c7f262df82a5dcef"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"flavray","id":4570851,"node_id":"MDQ6VXNlcjQ1NzA4NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/4570851?v=4","gravatar_id":"","url":"https://api.github.com/users/flavray","html_url":"https://github.com/flavray","followers_url":"https://api.github.com/users/flavray/followers","following_url":"https://api.github.com/users/flavray/following{/other_user}","gists_url":"https://api.github.com/users/flavray/gists{/gist_id}","starred_url":"https://api.github.com/users/flavray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flavray/subscriptions","organizations_url":"https://api.github.com/users/flavray/orgs","repos_url":"https://api.github.com/users/flavray/repos","events_url":"https://api.github.com/users/flavray/events{/privacy}","received_events_url":"https://api.github.com/users/flavray/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"flavray"}}