{"action":"created","comment":{"url":"https://api.github.com/repos/htm-community/nupic.cpp/pulls/comments/243734213","pull_request_review_id":187589407,"id":243734213,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzczNDIxMw==","diff_hunk":"@@ -509,9 +505,28 @@ void TemporalMemory::activateCells(size_t activeColumnsSize,\n       }\n     }\n   }\n+  segmentsValid_ = false;\n }\n \n-void TemporalMemory::activateDendrites(bool learn) {\n+void TemporalMemory::activateDendrites(bool learn,\n+                                       const vector<UInt> &extraActive,\n+                                       const vector<UInt> &extraWinners)\n+{\n+  if( segmentsValid_ ) {\n+    NTA_CHECK( extraActive.empty() )  << \"tm.activateDendrites() already called\";","path":"src/nupic/algorithms/TemporalMemory.cpp","position":75,"original_position":75,"commit_id":"a78e876edf1796531d13f396df4b44ff99a89abf","original_commit_id":"a78e876edf1796531d13f396df4b44ff99a89abf","user":{"login":"breznak","id":2166111,"node_id":"MDQ6VXNlcjIxNjYxMTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2166111?v=4","gravatar_id":"","url":"https://api.github.com/users/breznak","html_url":"https://github.com/breznak","followers_url":"https://api.github.com/users/breznak/followers","following_url":"https://api.github.com/users/breznak/following{/other_user}","gists_url":"https://api.github.com/users/breznak/gists{/gist_id}","starred_url":"https://api.github.com/users/breznak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breznak/subscriptions","organizations_url":"https://api.github.com/users/breznak/orgs","repos_url":"https://api.github.com/users/breznak/repos","events_url":"https://api.github.com/users/breznak/events{/privacy}","received_events_url":"https://api.github.com/users/breznak/received_events","type":"User","site_admin":false},"body":"should we throw, or just NTA_INFO && return? ","created_at":"2018-12-22T11:30:36Z","updated_at":"2018-12-22T11:53:53Z","html_url":"https://github.com/htm-community/nupic.cpp/pull/180#discussion_r243734213","pull_request_url":"https://api.github.com/repos/htm-community/nupic.cpp/pulls/180","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/htm-community/nupic.cpp/pulls/comments/243734213"},"html":{"href":"https://github.com/htm-community/nupic.cpp/pull/180#discussion_r243734213"},"pull_request":{"href":"https://api.github.com/repos/htm-community/nupic.cpp/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/htm-community/nupic.cpp/pulls/180","id":239844115,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODQ0MTE1","html_url":"https://github.com/htm-community/nupic.cpp/pull/180","diff_url":"https://github.com/htm-community/nupic.cpp/pull/180.diff","patch_url":"https://github.com/htm-community/nupic.cpp/pull/180.patch","issue_url":"https://api.github.com/repos/htm-community/nupic.cpp/issues/180","number":180,"state":"open","locked":false,"title":"TM accept external predictive input - WIP","user":{"login":"ctrl-z-9000-times","id":19578795,"node_id":"MDQ6VXNlcjE5NTc4Nzk1","avatar_url":"https://avatars0.githubusercontent.com/u/19578795?v=4","gravatar_id":"","url":"https://api.github.com/users/ctrl-z-9000-times","html_url":"https://github.com/ctrl-z-9000-times","followers_url":"https://api.github.com/users/ctrl-z-9000-times/followers","following_url":"https://api.github.com/users/ctrl-z-9000-times/following{/other_user}","gists_url":"https://api.github.com/users/ctrl-z-9000-times/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrl-z-9000-times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrl-z-9000-times/subscriptions","organizations_url":"https://api.github.com/users/ctrl-z-9000-times/orgs","repos_url":"https://api.github.com/users/ctrl-z-9000-times/repos","events_url":"https://api.github.com/users/ctrl-z-9000-times/events{/privacy}","received_events_url":"https://api.github.com/users/ctrl-z-9000-times/received_events","type":"User","site_admin":false},"body":"Implements issue #88 \r\n\r\nIn order to make this work I needed to reorder the following two function calls:\r\n```\r\nTM::Compute() {\r\n  activateCells(activeColumnsSize, activeColumns, learn);\r\n  activateDendrites(learn);\r\n\r\n^ WAS | IS NOW v\r\n\r\n  activateDendrites(learn);\r\n  activateCells(activeColumnsSize, activeColumns, learn);\r\n}\r\n```\r\n\r\nI think that they were originally done in this order so that the after every compute cycle, the TM has valid predictions on hand.  This PR needs the calls done in the new order.  This breaks several unit tests, we will need to think about how to incorporate this PR without breaking API too badly.","created_at":"2018-12-19T13:55:22Z","updated_at":"2018-12-22T11:53:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa481833770fb012e4152e326f24c0027ec3ff3d","assignee":{"login":"ctrl-z-9000-times","id":19578795,"node_id":"MDQ6VXNlcjE5NTc4Nzk1","avatar_url":"https://avatars0.githubusercontent.com/u/19578795?v=4","gravatar_id":"","url":"https://api.github.com/users/ctrl-z-9000-times","html_url":"https://github.com/ctrl-z-9000-times","followers_url":"https://api.github.com/users/ctrl-z-9000-times/followers","following_url":"https://api.github.com/users/ctrl-z-9000-times/following{/other_user}","gists_url":"https://api.github.com/users/ctrl-z-9000-times/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrl-z-9000-times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrl-z-9000-times/subscriptions","organizations_url":"https://api.github.com/users/ctrl-z-9000-times/orgs","repos_url":"https://api.github.com/users/ctrl-z-9000-times/repos","events_url":"https://api.github.com/users/ctrl-z-9000-times/events{/privacy}","received_events_url":"https://api.github.com/users/ctrl-z-9000-times/received_events","type":"User","site_admin":false},"assignees":[{"login":"ctrl-z-9000-times","id":19578795,"node_id":"MDQ6VXNlcjE5NTc4Nzk1","avatar_url":"https://avatars0.githubusercontent.com/u/19578795?v=4","gravatar_id":"","url":"https://api.github.com/users/ctrl-z-9000-times","html_url":"https://github.com/ctrl-z-9000-times","followers_url":"https://api.github.com/users/ctrl-z-9000-times/followers","following_url":"https://api.github.com/users/ctrl-z-9000-times/following{/other_user}","gists_url":"https://api.github.com/users/ctrl-z-9000-times/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrl-z-9000-times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrl-z-9000-times/subscriptions","organizations_url":"https://api.github.com/users/ctrl-z-9000-times/orgs","repos_url":"https://api.github.com/users/ctrl-z-9000-times/repos","events_url":"https://api.github.com/users/ctrl-z-9000-times/events{/privacy}","received_events_url":"https://api.github.com/users/ctrl-z-9000-times/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":809892674,"node_id":"MDU6TGFiZWw4MDk4OTI2NzQ=","url":"https://api.github.com/repos/htm-community/nupic.cpp/labels/TM","name":"TM","color":"574cef","default":false},{"id":809177070,"node_id":"MDU6TGFiZWw4MDkxNzcwNzA=","url":"https://api.github.com/repos/htm-community/nupic.cpp/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/htm-community/nupic.cpp/pulls/180/commits","review_comments_url":"https://api.github.com/repos/htm-community/nupic.cpp/pulls/180/comments","review_comment_url":"https://api.github.com/repos/htm-community/nupic.cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htm-community/nupic.cpp/issues/180/comments","statuses_url":"https://api.github.com/repos/htm-community/nupic.cpp/statuses/a78e876edf1796531d13f396df4b44ff99a89abf","head":{"label":"ctrl-z-9000-times:tm-extra","ref":"tm-extra","sha":"a78e876edf1796531d13f396df4b44ff99a89abf","user":{"login":"ctrl-z-9000-times","id":19578795,"node_id":"MDQ6VXNlcjE5NTc4Nzk1","avatar_url":"https://avatars0.githubusercontent.com/u/19578795?v=4","gravatar_id":"","url":"https://api.github.com/users/ctrl-z-9000-times","html_url":"https://github.com/ctrl-z-9000-times","followers_url":"https://api.github.com/users/ctrl-z-9000-times/followers","following_url":"https://api.github.com/users/ctrl-z-9000-times/following{/other_user}","gists_url":"https://api.github.com/users/ctrl-z-9000-times/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrl-z-9000-times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrl-z-9000-times/subscriptions","organizations_url":"https://api.github.com/users/ctrl-z-9000-times/orgs","repos_url":"https://api.github.com/users/ctrl-z-9000-times/repos","events_url":"https://api.github.com/users/ctrl-z-9000-times/events{/privacy}","received_events_url":"https://api.github.com/users/ctrl-z-9000-times/received_events","type":"User","site_admin":false},"repo":{"id":156127245,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYxMjcyNDU=","name":"nupic.cpp","full_name":"ctrl-z-9000-times/nupic.cpp","private":false,"owner":{"login":"ctrl-z-9000-times","id":19578795,"node_id":"MDQ6VXNlcjE5NTc4Nzk1","avatar_url":"https://avatars0.githubusercontent.com/u/19578795?v=4","gravatar_id":"","url":"https://api.github.com/users/ctrl-z-9000-times","html_url":"https://github.com/ctrl-z-9000-times","followers_url":"https://api.github.com/users/ctrl-z-9000-times/followers","following_url":"https://api.github.com/users/ctrl-z-9000-times/following{/other_user}","gists_url":"https://api.github.com/users/ctrl-z-9000-times/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrl-z-9000-times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrl-z-9000-times/subscriptions","organizations_url":"https://api.github.com/users/ctrl-z-9000-times/orgs","repos_url":"https://api.github.com/users/ctrl-z-9000-times/repos","events_url":"https://api.github.com/users/ctrl-z-9000-times/events{/privacy}","received_events_url":"https://api.github.com/users/ctrl-z-9000-times/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ctrl-z-9000-times/nupic.cpp","description":"Community fork. Implementation of core NuPIC algorithms in C++ (under construction)","fork":true,"url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp","forks_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/forks","keys_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/teams","hooks_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/hooks","issue_events_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/issues/events{/number}","events_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/events","assignees_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/assignees{/user}","branches_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/branches{/branch}","tags_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/tags","blobs_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/languages","stargazers_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/stargazers","contributors_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/contributors","subscribers_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/subscribers","subscription_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/subscription","commits_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/contents/{+path}","compare_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/merges","archive_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/downloads","issues_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/issues{/number}","pulls_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/labels{/name}","releases_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/releases{/id}","deployments_url":"https://api.github.com/repos/ctrl-z-9000-times/nupic.cpp/deployments","created_at":"2018-11-04T21:33:18Z","updated_at":"2018-12-02T20:26:17Z","pushed_at":"2018-12-21T15:46:06Z","git_url":"git://github.com/ctrl-z-9000-times/nupic.cpp.git","ssh_url":"git@github.com:ctrl-z-9000-times/nupic.cpp.git","clone_url":"https://github.com/ctrl-z-9000-times/nupic.cpp.git","svn_url":"https://github.com/ctrl-z-9000-times/nupic.cpp","homepage":"http://numenta.org","size":294151,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htm-community:master","ref":"master","sha":"45f791b039e3e3d9a7e7d450c950fbe2877ce11b","user":{"login":"htm-community","id":8866221,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NjYyMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8866221?v=4","gravatar_id":"","url":"https://api.github.com/users/htm-community","html_url":"https://github.com/htm-community","followers_url":"https://api.github.com/users/htm-community/followers","following_url":"https://api.github.com/users/htm-community/following{/other_user}","gists_url":"https://api.github.com/users/htm-community/gists{/gist_id}","starred_url":"https://api.github.com/users/htm-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htm-community/subscriptions","organizations_url":"https://api.github.com/users/htm-community/orgs","repos_url":"https://api.github.com/users/htm-community/repos","events_url":"https://api.github.com/users/htm-community/events{/privacy}","received_events_url":"https://api.github.com/users/htm-community/received_events","type":"Organization","site_admin":false},"repo":{"id":118031881,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgwMzE4ODE=","name":"nupic.cpp","full_name":"htm-community/nupic.cpp","private":false,"owner":{"login":"htm-community","id":8866221,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NjYyMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8866221?v=4","gravatar_id":"","url":"https://api.github.com/users/htm-community","html_url":"https://github.com/htm-community","followers_url":"https://api.github.com/users/htm-community/followers","following_url":"https://api.github.com/users/htm-community/following{/other_user}","gists_url":"https://api.github.com/users/htm-community/gists{/gist_id}","starred_url":"https://api.github.com/users/htm-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htm-community/subscriptions","organizations_url":"https://api.github.com/users/htm-community/orgs","repos_url":"https://api.github.com/users/htm-community/repos","events_url":"https://api.github.com/users/htm-community/events{/privacy}","received_events_url":"https://api.github.com/users/htm-community/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htm-community/nupic.cpp","description":"Community fork. Implementation of core NuPIC algorithms in C++ (under construction)","fork":true,"url":"https://api.github.com/repos/htm-community/nupic.cpp","forks_url":"https://api.github.com/repos/htm-community/nupic.cpp/forks","keys_url":"https://api.github.com/repos/htm-community/nupic.cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htm-community/nupic.cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htm-community/nupic.cpp/teams","hooks_url":"https://api.github.com/repos/htm-community/nupic.cpp/hooks","issue_events_url":"https://api.github.com/repos/htm-community/nupic.cpp/issues/events{/number}","events_url":"https://api.github.com/repos/htm-community/nupic.cpp/events","assignees_url":"https://api.github.com/repos/htm-community/nupic.cpp/assignees{/user}","branches_url":"https://api.github.com/repos/htm-community/nupic.cpp/branches{/branch}","tags_url":"https://api.github.com/repos/htm-community/nupic.cpp/tags","blobs_url":"https://api.github.com/repos/htm-community/nupic.cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htm-community/nupic.cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htm-community/nupic.cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/htm-community/nupic.cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htm-community/nupic.cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/htm-community/nupic.cpp/languages","stargazers_url":"https://api.github.com/repos/htm-community/nupic.cpp/stargazers","contributors_url":"https://api.github.com/repos/htm-community/nupic.cpp/contributors","subscribers_url":"https://api.github.com/repos/htm-community/nupic.cpp/subscribers","subscription_url":"https://api.github.com/repos/htm-community/nupic.cpp/subscription","commits_url":"https://api.github.com/repos/htm-community/nupic.cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/htm-community/nupic.cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/htm-community/nupic.cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/htm-community/nupic.cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/htm-community/nupic.cpp/contents/{+path}","compare_url":"https://api.github.com/repos/htm-community/nupic.cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htm-community/nupic.cpp/merges","archive_url":"https://api.github.com/repos/htm-community/nupic.cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htm-community/nupic.cpp/downloads","issues_url":"https://api.github.com/repos/htm-community/nupic.cpp/issues{/number}","pulls_url":"https://api.github.com/repos/htm-community/nupic.cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/htm-community/nupic.cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/htm-community/nupic.cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htm-community/nupic.cpp/labels{/name}","releases_url":"https://api.github.com/repos/htm-community/nupic.cpp/releases{/id}","deployments_url":"https://api.github.com/repos/htm-community/nupic.cpp/deployments","created_at":"2018-01-18T20:03:28Z","updated_at":"2018-12-20T03:05:17Z","pushed_at":"2018-12-22T03:55:53Z","git_url":"git://github.com/htm-community/nupic.cpp.git","ssh_url":"git@github.com:htm-community/nupic.cpp.git","clone_url":"https://github.com/htm-community/nupic.cpp.git","svn_url":"https://github.com/htm-community/nupic.cpp","homepage":"http://numenta.org","size":287919,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":3,"open_issues":57,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htm-community/nupic.cpp/pulls/180"},"html":{"href":"https://github.com/htm-community/nupic.cpp/pull/180"},"issue":{"href":"https://api.github.com/repos/htm-community/nupic.cpp/issues/180"},"comments":{"href":"https://api.github.com/repos/htm-community/nupic.cpp/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/htm-community/nupic.cpp/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/htm-community/nupic.cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htm-community/nupic.cpp/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/htm-community/nupic.cpp/statuses/a78e876edf1796531d13f396df4b44ff99a89abf"}},"author_association":"NONE"}}
{"actor":{"display_login":"breznak"}}