{"action":"opened","number":3523,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3523","id":197256612,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MjU2NjEy","html_url":"https://github.com/jenkinsci/jenkins/pull/3523","diff_url":"https://github.com/jenkinsci/jenkins/pull/3523.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/3523.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/3523","number":3523,"state":"open","locked":false,"title":"[JENKINS-52164] Fix rename action for AbstractItems that don't define URL when including the actions taglib","user":{"login":"dwnusbaum","id":1068968,"node_id":"MDQ6VXNlcjEwNjg5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/1068968?v=4","gravatar_id":"","url":"https://api.github.com/users/dwnusbaum","html_url":"https://github.com/dwnusbaum","followers_url":"https://api.github.com/users/dwnusbaum/followers","following_url":"https://api.github.com/users/dwnusbaum/following{/other_user}","gists_url":"https://api.github.com/users/dwnusbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/dwnusbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwnusbaum/subscriptions","organizations_url":"https://api.github.com/users/dwnusbaum/orgs","repos_url":"https://api.github.com/users/dwnusbaum/repos","events_url":"https://api.github.com/users/dwnusbaum/events{/privacy}","received_events_url":"https://api.github.com/users/dwnusbaum/received_events","type":"User","site_admin":false},"body":"See [JENKINS-52164](https://issues.jenkins-ci.org/browse/JENKINS-52164).\r\n\r\nThis is a regression for any subclasses of `Job` that return `true` for `Job#isNameEditable` and do not define a variable named `url` containing the URL to the item in the Jelly file where they include `</lib/hudson:actions>`. However, I have not seen this issue reported, and it doesn't affect `WorkflowJob` which is the only subclass of `Job` but not `AbstractProject` that I could think of, so I don't know whether we want to treat it as a bug for users or developers.\r\n\r\n### Proposed changelog entries\r\n\r\n* Developer: Fix rename action so it can be used with subclasses of `AbstractItem` that do not define a variable named `url` containing the item's URL when including the actions tag library in a Jelly page.\r\n\r\n### Submitter checklist\r\n\r\n- [x] JIRA issue is well described\r\n- [x] Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). [Examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)\r\n      * Use the `Internal: ` prefix if the change has no user-visible impact (API, test frameworks, etc.)\r\n- [x] Appropriate autotests or explanation to why this change has no tests\r\n- [ ] For dependency updates: links to external changelogs and, if possible, full diffs\r\n\r\n<!-- For new API and extension points: Link to the reference implementation in open-source (or example in Javadoc) -->\r\n\r\n### Desired reviewers\r\n\r\n@reviewbybees @fcojfernandez \r\n","created_at":"2018-06-25T22:48:05Z","updated_at":"2018-06-25T22:48:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3523/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3523/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/3523/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/d8f55e385d8144b16b6e6095508834ca32bd8323","head":{"label":"dwnusbaum:JENKINS-52164","ref":"JENKINS-52164","sha":"d8f55e385d8144b16b6e6095508834ca32bd8323","user":{"login":"dwnusbaum","id":1068968,"node_id":"MDQ6VXNlcjEwNjg5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/1068968?v=4","gravatar_id":"","url":"https://api.github.com/users/dwnusbaum","html_url":"https://github.com/dwnusbaum","followers_url":"https://api.github.com/users/dwnusbaum/followers","following_url":"https://api.github.com/users/dwnusbaum/following{/other_user}","gists_url":"https://api.github.com/users/dwnusbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/dwnusbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwnusbaum/subscriptions","organizations_url":"https://api.github.com/users/dwnusbaum/orgs","repos_url":"https://api.github.com/users/dwnusbaum/repos","events_url":"https://api.github.com/users/dwnusbaum/events{/privacy}","received_events_url":"https://api.github.com/users/dwnusbaum/received_events","type":"User","site_admin":false},"repo":{"id":105895663,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4OTU2NjM=","name":"jenkins","full_name":"dwnusbaum/jenkins","owner":{"login":"dwnusbaum","id":1068968,"node_id":"MDQ6VXNlcjEwNjg5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/1068968?v=4","gravatar_id":"","url":"https://api.github.com/users/dwnusbaum","html_url":"https://github.com/dwnusbaum","followers_url":"https://api.github.com/users/dwnusbaum/followers","following_url":"https://api.github.com/users/dwnusbaum/following{/other_user}","gists_url":"https://api.github.com/users/dwnusbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/dwnusbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwnusbaum/subscriptions","organizations_url":"https://api.github.com/users/dwnusbaum/orgs","repos_url":"https://api.github.com/users/dwnusbaum/repos","events_url":"https://api.github.com/users/dwnusbaum/events{/privacy}","received_events_url":"https://api.github.com/users/dwnusbaum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwnusbaum/jenkins","description":"Jenkins automation server","fork":true,"url":"https://api.github.com/repos/dwnusbaum/jenkins","forks_url":"https://api.github.com/repos/dwnusbaum/jenkins/forks","keys_url":"https://api.github.com/repos/dwnusbaum/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwnusbaum/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwnusbaum/jenkins/teams","hooks_url":"https://api.github.com/repos/dwnusbaum/jenkins/hooks","issue_events_url":"https://api.github.com/repos/dwnusbaum/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/dwnusbaum/jenkins/events","assignees_url":"https://api.github.com/repos/dwnusbaum/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/dwnusbaum/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/dwnusbaum/jenkins/tags","blobs_url":"https://api.github.com/repos/dwnusbaum/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwnusbaum/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwnusbaum/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwnusbaum/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwnusbaum/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/dwnusbaum/jenkins/languages","stargazers_url":"https://api.github.com/repos/dwnusbaum/jenkins/stargazers","contributors_url":"https://api.github.com/repos/dwnusbaum/jenkins/contributors","subscribers_url":"https://api.github.com/repos/dwnusbaum/jenkins/subscribers","subscription_url":"https://api.github.com/repos/dwnusbaum/jenkins/subscription","commits_url":"https://api.github.com/repos/dwnusbaum/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwnusbaum/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwnusbaum/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwnusbaum/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwnusbaum/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/dwnusbaum/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwnusbaum/jenkins/merges","archive_url":"https://api.github.com/repos/dwnusbaum/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwnusbaum/jenkins/downloads","issues_url":"https://api.github.com/repos/dwnusbaum/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/dwnusbaum/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/dwnusbaum/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/dwnusbaum/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwnusbaum/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/dwnusbaum/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/dwnusbaum/jenkins/deployments","created_at":"2017-10-05T13:50:19Z","updated_at":"2018-06-05T20:55:07Z","pushed_at":"2018-06-25T22:29:26Z","git_url":"git://github.com/dwnusbaum/jenkins.git","ssh_url":"git@github.com:dwnusbaum/jenkins.git","clone_url":"https://github.com/dwnusbaum/jenkins.git","svn_url":"https://github.com/dwnusbaum/jenkins","homepage":"https://jenkins.io/","size":107841,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"22aa2e6e766074d11249893e3f35e0b99e20d3d0","user":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAzNjA3","name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins automation server","fork":false,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/jenkins/deployments","created_at":"2010-11-22T21:21:23Z","updated_at":"2018-06-25T22:40:16Z","pushed_at":"2018-06-25T22:24:28Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"https://jenkins.io/","size":108091,"stargazers_count":10483,"watchers_count":10483,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4551,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4551,"open_issues":87,"watchers":10483,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3523"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/3523"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/3523"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/3523/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3523/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3523/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/d8f55e385d8144b16b6e6095508834ca32bd8323"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":53,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"dwnusbaum"}}