{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/218202743","pull_request_review_id":156088775,"id":218202743,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODIwMjc0Mw==","diff_hunk":"@@ -98,6 +98,40 @@ compileScala.dependsOn(nativeLib)\n test.dependsOn(nativeLibTest)\n clean.dependsOn(nativeLibClean)\n \n+task testCppCodegen(type: Test) {\n+    useTestNG {}\n+    \n+    \n+    // Enable C++ codegen for tests\n+    environment HAIL_ENABLE_CPP_CODEGEN: '1'\n+\n+    filter {\n+        includeTestsMatching \"is.hail.nativecode.NativeCode\"\n+        includeTestsMatching \"is.hail.annotations.AnnotationsSuite.testReadWrite\"\n+        includeTestsMatching \"is.hail.annotations.UnsafeSuite\"\n+        includeTestsMatching \"is.hail.io.IndexSuite\"\n+        includeTestsMatching \"is.hail.vds.JoinSuite\"","path":"hail/build.gradle","position":16,"original_position":16,"commit_id":"f7c51175f5d9648ba6c2225f29a68493051d3f12","original_commit_id":"f7c51175f5d9648ba6c2225f29a68493051d3f12","user":{"login":"catoverdrive","id":19789871,"node_id":"MDQ6VXNlcjE5Nzg5ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/19789871?v=4","gravatar_id":"","url":"https://api.github.com/users/catoverdrive","html_url":"https://github.com/catoverdrive","followers_url":"https://api.github.com/users/catoverdrive/followers","following_url":"https://api.github.com/users/catoverdrive/following{/other_user}","gists_url":"https://api.github.com/users/catoverdrive/gists{/gist_id}","starred_url":"https://api.github.com/users/catoverdrive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catoverdrive/subscriptions","organizations_url":"https://api.github.com/users/catoverdrive/orgs","repos_url":"https://api.github.com/users/catoverdrive/repos","events_url":"https://api.github.com/users/catoverdrive/events{/privacy}","received_events_url":"https://api.github.com/users/catoverdrive/received_events","type":"User","site_admin":false},"body":"`TableIRSuite.testShuffleAndJoinDoesntMemoryLeak` probably works as a test. I think that would be fine unless/until we decide to test the shuffling more explicitly, which afaict we're not doing in Scala right now.","created_at":"2018-09-17T19:47:44Z","updated_at":"2018-09-17T19:47:44Z","html_url":"https://github.com/hail-is/hail/pull/4326#discussion_r218202743","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/4326","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/218202743"},"html":{"href":"https://github.com/hail-is/hail/pull/4326#discussion_r218202743"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4326"}},"in_reply_to_id":218170593},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/4326","id":215071772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDcxNzcy","html_url":"https://github.com/hail-is/hail/pull/4326","diff_url":"https://github.com/hail-is/hail/pull/4326.diff","patch_url":"https://github.com/hail-is/hail/pull/4326.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/4326","number":4326,"state":"open","locked":false,"title":"Cpp rowstore2","user":{"login":"rcownie","id":10273990,"node_id":"MDQ6VXNlcjEwMjczOTkw","avatar_url":"https://avatars3.githubusercontent.com/u/10273990?v=4","gravatar_id":"","url":"https://api.github.com/users/rcownie","html_url":"https://github.com/rcownie","followers_url":"https://api.github.com/users/rcownie/followers","following_url":"https://api.github.com/users/rcownie/following{/other_user}","gists_url":"https://api.github.com/users/rcownie/gists{/gist_id}","starred_url":"https://api.github.com/users/rcownie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcownie/subscriptions","organizations_url":"https://api.github.com/users/rcownie/orgs","repos_url":"https://api.github.com/users/rcownie/repos","events_url":"https://api.github.com/users/rcownie/events{/privacy}","received_events_url":"https://api.github.com/users/rcownie/received_events","type":"User","site_admin":false},"body":"RowStore.scala using Scala-generated C++\r\n\r\nIf environment \"HAIL_ENABLE_CPP_CODEGEN\" is defined, it uses the C++ decoder, otherwise\r\nthe bytecode CompiledPackDecoder\r\n\r\nbuild.gradle sets the environment so that \"test\" and \"testPython\" will use the C++ decoder.\r\n\r\nThe C++ decoder holds a JNI jobject referring to the InputBuffer, but uses it only for \r\nreadToEndOfBlock.  The basic-type decoding (normal or packed) is implemented in PackDecoder.h, with the different encodings as template specializations with no run-time overhead.\r\n","created_at":"2018-09-12T19:34:54Z","updated_at":"2018-09-17T19:47:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4698ce5fc6da1106824b9726d9cb447ae84d3a01","assignee":{"login":"catoverdrive","id":19789871,"node_id":"MDQ6VXNlcjE5Nzg5ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/19789871?v=4","gravatar_id":"","url":"https://api.github.com/users/catoverdrive","html_url":"https://github.com/catoverdrive","followers_url":"https://api.github.com/users/catoverdrive/followers","following_url":"https://api.github.com/users/catoverdrive/following{/other_user}","gists_url":"https://api.github.com/users/catoverdrive/gists{/gist_id}","starred_url":"https://api.github.com/users/catoverdrive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catoverdrive/subscriptions","organizations_url":"https://api.github.com/users/catoverdrive/orgs","repos_url":"https://api.github.com/users/catoverdrive/repos","events_url":"https://api.github.com/users/catoverdrive/events{/privacy}","received_events_url":"https://api.github.com/users/catoverdrive/received_events","type":"User","site_admin":false},"assignees":[{"login":"catoverdrive","id":19789871,"node_id":"MDQ6VXNlcjE5Nzg5ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/19789871?v=4","gravatar_id":"","url":"https://api.github.com/users/catoverdrive","html_url":"https://github.com/catoverdrive","followers_url":"https://api.github.com/users/catoverdrive/followers","following_url":"https://api.github.com/users/catoverdrive/following{/other_user}","gists_url":"https://api.github.com/users/catoverdrive/gists{/gist_id}","starred_url":"https://api.github.com/users/catoverdrive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catoverdrive/subscriptions","organizations_url":"https://api.github.com/users/catoverdrive/orgs","repos_url":"https://api.github.com/users/catoverdrive/repos","events_url":"https://api.github.com/users/catoverdrive/events{/privacy}","received_events_url":"https://api.github.com/users/catoverdrive/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/4326/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/4326/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/4326/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/f7c51175f5d9648ba6c2225f29a68493051d3f12","head":{"label":"rcownie:cpp_rowstore2","ref":"cpp_rowstore2","sha":"f7c51175f5d9648ba6c2225f29a68493051d3f12","user":{"login":"rcownie","id":10273990,"node_id":"MDQ6VXNlcjEwMjczOTkw","avatar_url":"https://avatars3.githubusercontent.com/u/10273990?v=4","gravatar_id":"","url":"https://api.github.com/users/rcownie","html_url":"https://github.com/rcownie","followers_url":"https://api.github.com/users/rcownie/followers","following_url":"https://api.github.com/users/rcownie/following{/other_user}","gists_url":"https://api.github.com/users/rcownie/gists{/gist_id}","starred_url":"https://api.github.com/users/rcownie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcownie/subscriptions","organizations_url":"https://api.github.com/users/rcownie/orgs","repos_url":"https://api.github.com/users/rcownie/repos","events_url":"https://api.github.com/users/rcownie/events{/privacy}","received_events_url":"https://api.github.com/users/rcownie/received_events","type":"User","site_admin":false},"repo":{"id":122372524,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIzNzI1MjQ=","name":"hail","full_name":"rcownie/hail","private":false,"owner":{"login":"rcownie","id":10273990,"node_id":"MDQ6VXNlcjEwMjczOTkw","avatar_url":"https://avatars3.githubusercontent.com/u/10273990?v=4","gravatar_id":"","url":"https://api.github.com/users/rcownie","html_url":"https://github.com/rcownie","followers_url":"https://api.github.com/users/rcownie/followers","following_url":"https://api.github.com/users/rcownie/following{/other_user}","gists_url":"https://api.github.com/users/rcownie/gists{/gist_id}","starred_url":"https://api.github.com/users/rcownie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcownie/subscriptions","organizations_url":"https://api.github.com/users/rcownie/orgs","repos_url":"https://api.github.com/users/rcownie/repos","events_url":"https://api.github.com/users/rcownie/events{/privacy}","received_events_url":"https://api.github.com/users/rcownie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rcownie/hail","description":"Scalable genomic data analysis.","fork":true,"url":"https://api.github.com/repos/rcownie/hail","forks_url":"https://api.github.com/repos/rcownie/hail/forks","keys_url":"https://api.github.com/repos/rcownie/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcownie/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcownie/hail/teams","hooks_url":"https://api.github.com/repos/rcownie/hail/hooks","issue_events_url":"https://api.github.com/repos/rcownie/hail/issues/events{/number}","events_url":"https://api.github.com/repos/rcownie/hail/events","assignees_url":"https://api.github.com/repos/rcownie/hail/assignees{/user}","branches_url":"https://api.github.com/repos/rcownie/hail/branches{/branch}","tags_url":"https://api.github.com/repos/rcownie/hail/tags","blobs_url":"https://api.github.com/repos/rcownie/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcownie/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcownie/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcownie/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcownie/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/rcownie/hail/languages","stargazers_url":"https://api.github.com/repos/rcownie/hail/stargazers","contributors_url":"https://api.github.com/repos/rcownie/hail/contributors","subscribers_url":"https://api.github.com/repos/rcownie/hail/subscribers","subscription_url":"https://api.github.com/repos/rcownie/hail/subscription","commits_url":"https://api.github.com/repos/rcownie/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcownie/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcownie/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcownie/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcownie/hail/contents/{+path}","compare_url":"https://api.github.com/repos/rcownie/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcownie/hail/merges","archive_url":"https://api.github.com/repos/rcownie/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcownie/hail/downloads","issues_url":"https://api.github.com/repos/rcownie/hail/issues{/number}","pulls_url":"https://api.github.com/repos/rcownie/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/rcownie/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/rcownie/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcownie/hail/labels{/name}","releases_url":"https://api.github.com/repos/rcownie/hail/releases{/id}","deployments_url":"https://api.github.com/repos/rcownie/hail/deployments","created_at":"2018-02-21T17:57:56Z","updated_at":"2018-09-13T17:05:41Z","pushed_at":"2018-09-14T20:22:19Z","git_url":"git://github.com/rcownie/hail.git","ssh_url":"git@github.com:rcownie/hail.git","clone_url":"https://github.com/rcownie/hail.git","svn_url":"https://github.com/rcownie/hail","homepage":"https://hail.is","size":53037,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"51961fa0ef802efc3d5a1c9f4b9016608a6c1199","user":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"node_id":"MDEwOlJlcG9zaXRvcnk0NTA2OTQ2Nw==","name":"hail","full_name":"hail-is/hail","private":false,"owner":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hail-is/hail","description":"Scalable genomic data analysis.","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2018-09-17T18:55:43Z","pushed_at":"2018-09-17T19:40:29Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":42448,"stargazers_count":368,"watchers_count":368,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":150,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":105,"open_issues":150,"watchers":368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4326"},"html":{"href":"https://github.com/hail-is/hail/pull/4326"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/4326"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/4326/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4326/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4326/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/f7c51175f5d9648ba6c2225f29a68493051d3f12"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"catoverdrive"}}