{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/3628","repository_url":"https://api.github.com/repos/ReactiveX/rxjs","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/3628/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/3628/comments","events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/3628/events","html_url":"https://github.com/ReactiveX/rxjs/pull/3628","id":319281541,"number":3628,"title":"feat(isObservable): adds recommended method for checking objects to see if they're RxJS 5+ Observables","user":{"login":"benlesh","id":1540597,"avatar_url":"https://avatars0.githubusercontent.com/u/1540597?v=4","gravatar_id":"","url":"https://api.github.com/users/benlesh","html_url":"https://github.com/benlesh","followers_url":"https://api.github.com/users/benlesh/followers","following_url":"https://api.github.com/users/benlesh/following{/other_user}","gists_url":"https://api.github.com/users/benlesh/gists{/gist_id}","starred_url":"https://api.github.com/users/benlesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlesh/subscriptions","organizations_url":"https://api.github.com/users/benlesh/orgs","repos_url":"https://api.github.com/users/benlesh/repos","events_url":"https://api.github.com/users/benlesh/events{/privacy}","received_events_url":"https://api.github.com/users/benlesh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-01T18:25:48Z","updated_at":"2018-05-01T19:05:16Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/3628","html_url":"https://github.com/ReactiveX/rxjs/pull/3628","diff_url":"https://github.com/ReactiveX/rxjs/pull/3628.diff","patch_url":"https://github.com/ReactiveX/rxjs/pull/3628.patch"},"body":"### Overview\r\n\r\nThere are a lot of ways to check to see of something is an Observable, none of them are great. This is an attempt to provide a recommended way to see of an Observable is, in fact, an RxJS (5+) Observable or not.\r\n\r\n- `instanceof` doesn't always work in node, as sometimes people have Observables from other copies of RxJS.\r\n- `typeof o.subscribe === 'function'` doesn't always work, because older versions of RxJS (<4) have different APIs that still use `subscribe`\r\n- I've seen `typeof o === 'object'` sort of checks to see if something is an Observable, which has obvious problems.\r\n\r\n### The goals of this addition:\r\n\r\n- Provide a library-blessed way to identify compatible observables\r\n- Provide a future-proof way to identify observables, as implementation details are likely to change in upcoming versions\r\n\r\n\r\n### Other things to note:\r\n\r\nthe type `ObservableLike<T>` is deprecated in favor of the name `InteropObservable<T>`."},"comment":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments/385759291","html_url":"https://github.com/ReactiveX/rxjs/pull/3628#issuecomment-385759291","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/3628","id":385759291,"user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars2.githubusercontent.com/u/1210596?v=4","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T19:05:16Z","updated_at":"2018-05-01T19:05:16Z","author_association":"MEMBER","body":"before reading any code, why this PR contains massive changes in pkg lock? codes doesn't seem to have any pkg changes."}}
{"actor":{"display_login":"kwonoj"}}