{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/eth-account/pulls/comments/224933806","pull_request_review_id":164432435,"id":224933806,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDkzMzgwNg==","diff_hunk":"@@ -97,6 +99,22 @@ def acct(request):\n     return Account\n \n \n+def test_eth_account_default_kdf():\n+    assert eth_account.account.defaultKDF == 'scrypt'\n+\n+\n+def test_eth_account_default_kdf_from_env():\n+    import importlib\n+    os.environ['ETH_ACCOUNT_KDF'] = 'pbkdf2'","path":"tests/core/test_accounts.py","position":25,"original_position":25,"commit_id":"d8ee9af6fd0467d2e25ea028c2ab6e2145d2dcfe","original_commit_id":"d8ee9af6fd0467d2e25ea028c2ab6e2145d2dcfe","user":{"login":"carver","id":205327,"node_id":"MDQ6VXNlcjIwNTMyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/205327?v=4","gravatar_id":"","url":"https://api.github.com/users/carver","html_url":"https://github.com/carver","followers_url":"https://api.github.com/users/carver/followers","following_url":"https://api.github.com/users/carver/following{/other_user}","gists_url":"https://api.github.com/users/carver/gists{/gist_id}","starred_url":"https://api.github.com/users/carver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carver/subscriptions","organizations_url":"https://api.github.com/users/carver/orgs","repos_url":"https://api.github.com/users/carver/repos","events_url":"https://api.github.com/users/carver/events{/privacy}","received_events_url":"https://api.github.com/users/carver/received_events","type":"User","site_admin":false},"body":"Weirdly the `setenv` method disappeared from recent docs. Here's an old copy with the reference: https://docs.pytest.org/en/3.0.0/monkeypatch.html","created_at":"2018-10-12T22:55:03Z","updated_at":"2018-10-12T22:55:03Z","html_url":"https://github.com/ethereum/eth-account/pull/38#discussion_r224933806","pull_request_url":"https://api.github.com/repos/ethereum/eth-account/pulls/38","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/eth-account/pulls/comments/224933806"},"html":{"href":"https://github.com/ethereum/eth-account/pull/38#discussion_r224933806"},"pull_request":{"href":"https://api.github.com/repos/ethereum/eth-account/pulls/38"}},"in_reply_to_id":224834398},"pull_request":{"url":"https://api.github.com/repos/ethereum/eth-account/pulls/38","id":222183566,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTgzNTY2","html_url":"https://github.com/ethereum/eth-account/pull/38","diff_url":"https://github.com/ethereum/eth-account/pull/38.diff","patch_url":"https://github.com/ethereum/eth-account/pull/38.patch","issue_url":"https://api.github.com/repos/ethereum/eth-account/issues/38","number":38,"state":"open","locked":false,"title":"Allow KDF to be provided for private key encryption","user":{"login":"stefanmendoza","id":6325996,"node_id":"MDQ6VXNlcjYzMjU5OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/6325996?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanmendoza","html_url":"https://github.com/stefanmendoza","followers_url":"https://api.github.com/users/stefanmendoza/followers","following_url":"https://api.github.com/users/stefanmendoza/following{/other_user}","gists_url":"https://api.github.com/users/stefanmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanmendoza/subscriptions","organizations_url":"https://api.github.com/users/stefanmendoza/orgs","repos_url":"https://api.github.com/users/stefanmendoza/repos","events_url":"https://api.github.com/users/stefanmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/stefanmendoza/received_events","type":"User","site_admin":false},"body":"## What was wrong?\r\n\r\nFixes #3 \r\nFixes #4 \r\n\r\n## How was it fixed?\r\n\r\n- Updated the `Account#encrypt` and `LocalAccount#encrypt` methods to take an optional 'kdf' parameter to be used when generating the encrypted keyfile (Issue #3)\r\n- Switched to using 'scrypt' as the default KDF for keyfile encryption instead of the 'pbkdf2' default from eth-keyfile (Issue #4). If the environment variable `ETH_ACCOUNT_KDF` is set, that will be used for the default KDF if none is provided when calling `Account#encrypt` or `LocalAccount#encrypt`\r\n\r\n#### Cute Animal Picture\r\n\r\n![put a cute animal picture link inside the parentheses](https://img-aws.ehowcdn.com/750x428p/s3-us-west-1.amazonaws.com/contentlab.studiod/getty/00b7ac219f6b444c84c520912db4a34b)\r\n","created_at":"2018-10-11T15:31:55Z","updated_at":"2018-10-12T22:55:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbad3d6c10c42c16fc5cc161fd5283634949279f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/eth-account/pulls/38/commits","review_comments_url":"https://api.github.com/repos/ethereum/eth-account/pulls/38/comments","review_comment_url":"https://api.github.com/repos/ethereum/eth-account/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/eth-account/issues/38/comments","statuses_url":"https://api.github.com/repos/ethereum/eth-account/statuses/d8ee9af6fd0467d2e25ea028c2ab6e2145d2dcfe","head":{"label":"stefanmendoza:issue-3-4","ref":"issue-3-4","sha":"d8ee9af6fd0467d2e25ea028c2ab6e2145d2dcfe","user":{"login":"stefanmendoza","id":6325996,"node_id":"MDQ6VXNlcjYzMjU5OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/6325996?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanmendoza","html_url":"https://github.com/stefanmendoza","followers_url":"https://api.github.com/users/stefanmendoza/followers","following_url":"https://api.github.com/users/stefanmendoza/following{/other_user}","gists_url":"https://api.github.com/users/stefanmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanmendoza/subscriptions","organizations_url":"https://api.github.com/users/stefanmendoza/orgs","repos_url":"https://api.github.com/users/stefanmendoza/repos","events_url":"https://api.github.com/users/stefanmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/stefanmendoza/received_events","type":"User","site_admin":false},"repo":{"id":151872714,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE4NzI3MTQ=","name":"eth-account","full_name":"stefanmendoza/eth-account","private":false,"owner":{"login":"stefanmendoza","id":6325996,"node_id":"MDQ6VXNlcjYzMjU5OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/6325996?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanmendoza","html_url":"https://github.com/stefanmendoza","followers_url":"https://api.github.com/users/stefanmendoza/followers","following_url":"https://api.github.com/users/stefanmendoza/following{/other_user}","gists_url":"https://api.github.com/users/stefanmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanmendoza/subscriptions","organizations_url":"https://api.github.com/users/stefanmendoza/orgs","repos_url":"https://api.github.com/users/stefanmendoza/repos","events_url":"https://api.github.com/users/stefanmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/stefanmendoza/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stefanmendoza/eth-account","description":"STUB","fork":true,"url":"https://api.github.com/repos/stefanmendoza/eth-account","forks_url":"https://api.github.com/repos/stefanmendoza/eth-account/forks","keys_url":"https://api.github.com/repos/stefanmendoza/eth-account/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanmendoza/eth-account/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanmendoza/eth-account/teams","hooks_url":"https://api.github.com/repos/stefanmendoza/eth-account/hooks","issue_events_url":"https://api.github.com/repos/stefanmendoza/eth-account/issues/events{/number}","events_url":"https://api.github.com/repos/stefanmendoza/eth-account/events","assignees_url":"https://api.github.com/repos/stefanmendoza/eth-account/assignees{/user}","branches_url":"https://api.github.com/repos/stefanmendoza/eth-account/branches{/branch}","tags_url":"https://api.github.com/repos/stefanmendoza/eth-account/tags","blobs_url":"https://api.github.com/repos/stefanmendoza/eth-account/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanmendoza/eth-account/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanmendoza/eth-account/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanmendoza/eth-account/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanmendoza/eth-account/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanmendoza/eth-account/languages","stargazers_url":"https://api.github.com/repos/stefanmendoza/eth-account/stargazers","contributors_url":"https://api.github.com/repos/stefanmendoza/eth-account/contributors","subscribers_url":"https://api.github.com/repos/stefanmendoza/eth-account/subscribers","subscription_url":"https://api.github.com/repos/stefanmendoza/eth-account/subscription","commits_url":"https://api.github.com/repos/stefanmendoza/eth-account/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanmendoza/eth-account/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanmendoza/eth-account/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanmendoza/eth-account/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefanmendoza/eth-account/contents/{+path}","compare_url":"https://api.github.com/repos/stefanmendoza/eth-account/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanmendoza/eth-account/merges","archive_url":"https://api.github.com/repos/stefanmendoza/eth-account/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanmendoza/eth-account/downloads","issues_url":"https://api.github.com/repos/stefanmendoza/eth-account/issues{/number}","pulls_url":"https://api.github.com/repos/stefanmendoza/eth-account/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanmendoza/eth-account/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanmendoza/eth-account/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanmendoza/eth-account/labels{/name}","releases_url":"https://api.github.com/repos/stefanmendoza/eth-account/releases{/id}","deployments_url":"https://api.github.com/repos/stefanmendoza/eth-account/deployments","created_at":"2018-10-06T19:05:11Z","updated_at":"2018-10-06T19:05:13Z","pushed_at":"2018-10-12T20:38:00Z","git_url":"git://github.com/stefanmendoza/eth-account.git","ssh_url":"git@github.com:stefanmendoza/eth-account.git","clone_url":"https://github.com/stefanmendoza/eth-account.git","svn_url":"https://github.com/stefanmendoza/eth-account","homepage":null,"size":174,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"3ac5aed090aadd5f791f13ec23809b5b68bc4f08","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":118818588,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MTg1ODg=","name":"eth-account","full_name":"ethereum/eth-account","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/eth-account","description":"Account abstraction library for web3.py","fork":false,"url":"https://api.github.com/repos/ethereum/eth-account","forks_url":"https://api.github.com/repos/ethereum/eth-account/forks","keys_url":"https://api.github.com/repos/ethereum/eth-account/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/eth-account/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/eth-account/teams","hooks_url":"https://api.github.com/repos/ethereum/eth-account/hooks","issue_events_url":"https://api.github.com/repos/ethereum/eth-account/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/eth-account/events","assignees_url":"https://api.github.com/repos/ethereum/eth-account/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/eth-account/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/eth-account/tags","blobs_url":"https://api.github.com/repos/ethereum/eth-account/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/eth-account/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/eth-account/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/eth-account/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/eth-account/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/eth-account/languages","stargazers_url":"https://api.github.com/repos/ethereum/eth-account/stargazers","contributors_url":"https://api.github.com/repos/ethereum/eth-account/contributors","subscribers_url":"https://api.github.com/repos/ethereum/eth-account/subscribers","subscription_url":"https://api.github.com/repos/ethereum/eth-account/subscription","commits_url":"https://api.github.com/repos/ethereum/eth-account/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/eth-account/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/eth-account/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/eth-account/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/eth-account/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/eth-account/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/eth-account/merges","archive_url":"https://api.github.com/repos/ethereum/eth-account/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/eth-account/downloads","issues_url":"https://api.github.com/repos/ethereum/eth-account/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/eth-account/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/eth-account/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/eth-account/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/eth-account/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/eth-account/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/eth-account/deployments","created_at":"2018-01-24T20:32:30Z","updated_at":"2018-10-12T20:35:54Z","pushed_at":"2018-10-12T20:35:52Z","git_url":"git://github.com/ethereum/eth-account.git","ssh_url":"git@github.com:ethereum/eth-account.git","clone_url":"https://github.com/ethereum/eth-account.git","svn_url":"https://github.com/ethereum/eth-account","homepage":"","size":176,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":11,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/eth-account/pulls/38"},"html":{"href":"https://github.com/ethereum/eth-account/pull/38"},"issue":{"href":"https://api.github.com/repos/ethereum/eth-account/issues/38"},"comments":{"href":"https://api.github.com/repos/ethereum/eth-account/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/eth-account/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/eth-account/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/eth-account/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/eth-account/statuses/d8ee9af6fd0467d2e25ea028c2ab6e2145d2dcfe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"carver"}}