{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/dbal/pulls/comments/185833775","pull_request_review_id":117303470,"id":185833775,"diff_hunk":"@@ -0,0 +1,311 @@\n+<?php\n+/*\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ *\n+ * This software consists of voluntary contributions made by many individuals\n+ * and is licensed under the MIT license. For more information, see\n+ * <http://www.doctrine-project.org>.\n+ */\n+\n+namespace Doctrine\\DBAL\\Platforms\\Keywords;\n+\n+/**\n+ * MySQL 8 reserved keywords list.\n+ *\n+ * @author Michele Locati <michele@locati.it>\n+ * @link   www.doctrine-project.org\n+ */\n+class MySQL8Keywords extends MySQL57Keywords","path":"lib/Doctrine/DBAL/Platforms/Keywords/MySQL8Keywords.php","position":28,"original_position":28,"commit_id":"34176c9d098a02c0f2d1581f7a5cdcb2d5d48e4e","original_commit_id":"34176c9d098a02c0f2d1581f7a5cdcb2d5d48e4e","user":{"login":"Majkl578","id":144181,"avatar_url":"https://avatars2.githubusercontent.com/u/144181?v=4","gravatar_id":"","url":"https://api.github.com/users/Majkl578","html_url":"https://github.com/Majkl578","followers_url":"https://api.github.com/users/Majkl578/followers","following_url":"https://api.github.com/users/Majkl578/following{/other_user}","gists_url":"https://api.github.com/users/Majkl578/gists{/gist_id}","starred_url":"https://api.github.com/users/Majkl578/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Majkl578/subscriptions","organizations_url":"https://api.github.com/users/Majkl578/orgs","repos_url":"https://api.github.com/users/Majkl578/repos","events_url":"https://api.github.com/users/Majkl578/events{/privacy}","received_events_url":"https://api.github.com/users/Majkl578/received_events","type":"User","site_admin":false},"body":"To follow similar naming pattern, this class should be named MySQL80Keywords.\r\nAlso if possible, should also only add new keywords (or remove removed ones), like here: https://github.com/doctrine/dbal/blob/9f3188ab3d56db6f6fc76c2ddf6b0b4aae06192f/lib/Doctrine/DBAL/Platforms/Keywords/PostgreSQL94Keywords.php#L49-L55","created_at":"2018-05-03T15:09:53Z","updated_at":"2018-05-03T15:19:52Z","html_url":"https://github.com/doctrine/dbal/pull/3128#discussion_r185833775","pull_request_url":"https://api.github.com/repos/doctrine/dbal/pulls/3128","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/comments/185833775"},"html":{"href":"https://github.com/doctrine/dbal/pull/3128#discussion_r185833775"},"pull_request":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3128"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/dbal/pulls/3128","id":185740110,"html_url":"https://github.com/doctrine/dbal/pull/3128","diff_url":"https://github.com/doctrine/dbal/pull/3128.diff","patch_url":"https://github.com/doctrine/dbal/pull/3128.patch","issue_url":"https://api.github.com/repos/doctrine/dbal/issues/3128","number":3128,"state":"open","locked":false,"title":"Add MySQL 8 reserved keywords","user":{"login":"mlocati","id":928116,"avatar_url":"https://avatars3.githubusercontent.com/u/928116?v=4","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"body":"MySQL 8 added a few reserved keywords.\r\nComparing https://dev.mysql.com/doc/refman/8.0/en/keywords.html with [MySQL57Keywords.php](https://github.com/doctrine/dbal/blob/e4af109a206352e27c1ddab0d438c8e5f3a80d1c/lib/Doctrine/DBAL/Platforms/Keywords/MySQL57Keywords.php) here's the list of the new keywords:\r\n\r\n- `ADMIN`\r\n- `CUBE`\r\n- `CUME_DIST`\r\n- `DENSE_RANK`\r\n- `EMPTY`\r\n- `EXCEPT`\r\n- `FIRST_VALUE`\r\n- `FUNCTION`\r\n- `GROUPING`\r\n- `GROUPS`\r\n- `JSON_TABLE`\r\n- `LAG`\r\n- `LAST_VALUE`\r\n- `LEAD`\r\n- `NTH_VALUE`\r\n- `NTILE`\r\n- `OF`\r\n- `OVER`\r\n- `PERCENT_RANK`\r\n- `PERSIST`\r\n- `PERSIST_ONLY`\r\n- `RANK`\r\n- `RECURSIVE`\r\n- `ROW`\r\n- `ROWS`\r\n- `ROW_NUMBER`\r\n- `SYSTEM`\r\n- `WINDOW`\r\n\r\nWhat should I write in the `@since` phodoc?\r\n\r\nPS: it would be nice to add this to the 2.5.x series, for projects using PHP older than 7.1","created_at":"2018-05-03T14:44:47Z","updated_at":"2018-05-03T15:19:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"107edd05aa602922220f0bf3a9a91c0817ede348","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/dbal/pulls/3128/commits","review_comments_url":"https://api.github.com/repos/doctrine/dbal/pulls/3128/comments","review_comment_url":"https://api.github.com/repos/doctrine/dbal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/dbal/issues/3128/comments","statuses_url":"https://api.github.com/repos/doctrine/dbal/statuses/34176c9d098a02c0f2d1581f7a5cdcb2d5d48e4e","head":{"label":"mlocati:mysql8-keywords","ref":"mysql8-keywords","sha":"34176c9d098a02c0f2d1581f7a5cdcb2d5d48e4e","user":{"login":"mlocati","id":928116,"avatar_url":"https://avatars3.githubusercontent.com/u/928116?v=4","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"repo":{"id":31774196,"name":"dbal","full_name":"mlocati/dbal","owner":{"login":"mlocati","id":928116,"avatar_url":"https://avatars3.githubusercontent.com/u/928116?v=4","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlocati/dbal","description":"Doctrine Database Abstraction Layer","fork":true,"url":"https://api.github.com/repos/mlocati/dbal","forks_url":"https://api.github.com/repos/mlocati/dbal/forks","keys_url":"https://api.github.com/repos/mlocati/dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlocati/dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlocati/dbal/teams","hooks_url":"https://api.github.com/repos/mlocati/dbal/hooks","issue_events_url":"https://api.github.com/repos/mlocati/dbal/issues/events{/number}","events_url":"https://api.github.com/repos/mlocati/dbal/events","assignees_url":"https://api.github.com/repos/mlocati/dbal/assignees{/user}","branches_url":"https://api.github.com/repos/mlocati/dbal/branches{/branch}","tags_url":"https://api.github.com/repos/mlocati/dbal/tags","blobs_url":"https://api.github.com/repos/mlocati/dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlocati/dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlocati/dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlocati/dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlocati/dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/mlocati/dbal/languages","stargazers_url":"https://api.github.com/repos/mlocati/dbal/stargazers","contributors_url":"https://api.github.com/repos/mlocati/dbal/contributors","subscribers_url":"https://api.github.com/repos/mlocati/dbal/subscribers","subscription_url":"https://api.github.com/repos/mlocati/dbal/subscription","commits_url":"https://api.github.com/repos/mlocati/dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlocati/dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlocati/dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlocati/dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlocati/dbal/contents/{+path}","compare_url":"https://api.github.com/repos/mlocati/dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlocati/dbal/merges","archive_url":"https://api.github.com/repos/mlocati/dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlocati/dbal/downloads","issues_url":"https://api.github.com/repos/mlocati/dbal/issues{/number}","pulls_url":"https://api.github.com/repos/mlocati/dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/mlocati/dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/mlocati/dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlocati/dbal/labels{/name}","releases_url":"https://api.github.com/repos/mlocati/dbal/releases{/id}","deployments_url":"https://api.github.com/repos/mlocati/dbal/deployments","created_at":"2015-03-06T14:58:14Z","updated_at":"2018-05-03T14:18:58Z","pushed_at":"2018-05-03T14:35:48Z","git_url":"git://github.com/mlocati/dbal.git","ssh_url":"git@github.com:mlocati/dbal.git","clone_url":"https://github.com/mlocati/dbal.git","svn_url":"https://github.com/mlocati/dbal","homepage":"http://www.doctrine-project.org/projects/dbal","size":22953,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"e4af109a206352e27c1ddab0d438c8e5f3a80d1c","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars3.githubusercontent.com/u/209254?v=4","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":677464,"name":"dbal","full_name":"doctrine/dbal","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars3.githubusercontent.com/u/209254?v=4","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/dbal","description":"Doctrine Database Abstraction Layer","fork":false,"url":"https://api.github.com/repos/doctrine/dbal","forks_url":"https://api.github.com/repos/doctrine/dbal/forks","keys_url":"https://api.github.com/repos/doctrine/dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/dbal/teams","hooks_url":"https://api.github.com/repos/doctrine/dbal/hooks","issue_events_url":"https://api.github.com/repos/doctrine/dbal/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/dbal/events","assignees_url":"https://api.github.com/repos/doctrine/dbal/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/dbal/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/dbal/tags","blobs_url":"https://api.github.com/repos/doctrine/dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/dbal/languages","stargazers_url":"https://api.github.com/repos/doctrine/dbal/stargazers","contributors_url":"https://api.github.com/repos/doctrine/dbal/contributors","subscribers_url":"https://api.github.com/repos/doctrine/dbal/subscribers","subscription_url":"https://api.github.com/repos/doctrine/dbal/subscription","commits_url":"https://api.github.com/repos/doctrine/dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/dbal/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/dbal/merges","archive_url":"https://api.github.com/repos/doctrine/dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/dbal/downloads","issues_url":"https://api.github.com/repos/doctrine/dbal/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/dbal/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/dbal/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/dbal/deployments","created_at":"2010-05-20T17:01:42Z","updated_at":"2018-05-03T14:48:26Z","pushed_at":"2018-05-03T14:44:48Z","git_url":"git://github.com/doctrine/dbal.git","ssh_url":"git@github.com:doctrine/dbal.git","clone_url":"https://github.com/doctrine/dbal.git","svn_url":"https://github.com/doctrine/dbal","homepage":"http://www.doctrine-project.org/projects/dbal","size":24083,"stargazers_count":2437,"watchers_count":2437,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":883,"mirror_url":null,"archived":false,"open_issues_count":402,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":883,"open_issues":402,"watchers":2437,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3128"},"html":{"href":"https://github.com/doctrine/dbal/pull/3128"},"issue":{"href":"https://api.github.com/repos/doctrine/dbal/issues/3128"},"comments":{"href":"https://api.github.com/repos/doctrine/dbal/issues/3128/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3128/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3128/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/dbal/statuses/34176c9d098a02c0f2d1581f7a5cdcb2d5d48e4e"}},"author_association":"NONE"}}
{"actor":{"display_login":"Majkl578"}}