{"action":"created","comment":{"url":"https://api.github.com/repos/marcoeilers/nagini/pulls/comments/175291942","pull_request_review_id":104800057,"id":175291942,"diff_hunk":"@@ -14,7 +14,7 @@ class JVM:\n \n     def __init__(self, classpath: str):\n         jpype.startJVM(jpype.getDefaultJVMPath(),\n-                       '-Djava.class.path=' + classpath, '-Xss128m')\n+                       '-Djava.class.path=' + classpath, '-Xss32m')","path":"src/nagini_translation/lib/jvmaccess.py","position":5,"original_position":5,"commit_id":"33b0df04ef26355d32c9418332cca9e990a00385","original_commit_id":"33b0df04ef26355d32c9418332cca9e990a00385","user":{"login":"marcoeilers","id":1490193,"avatar_url":"https://avatars2.githubusercontent.com/u/1490193?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoeilers","html_url":"https://github.com/marcoeilers","followers_url":"https://api.github.com/users/marcoeilers/followers","following_url":"https://api.github.com/users/marcoeilers/following{/other_user}","gists_url":"https://api.github.com/users/marcoeilers/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoeilers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoeilers/subscriptions","organizations_url":"https://api.github.com/users/marcoeilers/orgs","repos_url":"https://api.github.com/users/marcoeilers/repos","events_url":"https://api.github.com/users/marcoeilers/events{/privacy}","received_events_url":"https://api.github.com/users/marcoeilers/received_events","type":"User","site_admin":false},"body":"No, they'll just get a stack trace. But 32 MB is more than enough for all cases I've ever tried, and I sometimes get weird crashes with larger values, that's why I changed it.","created_at":"2018-03-18T14:58:34Z","updated_at":"2018-03-18T14:58:34Z","html_url":"https://github.com/marcoeilers/nagini/pull/109#discussion_r175291942","pull_request_url":"https://api.github.com/repos/marcoeilers/nagini/pulls/109","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/marcoeilers/nagini/pulls/comments/175291942"},"html":{"href":"https://github.com/marcoeilers/nagini/pull/109#discussion_r175291942"},"pull_request":{"href":"https://api.github.com/repos/marcoeilers/nagini/pulls/109"}},"in_reply_to_id":175048825},"pull_request":{"url":"https://api.github.com/repos/marcoeilers/nagini/pulls/109","id":173235247,"html_url":"https://github.com/marcoeilers/nagini/pull/109","diff_url":"https://github.com/marcoeilers/nagini/pull/109.diff","patch_url":"https://github.com/marcoeilers/nagini/pull/109.patch","issue_url":"https://api.github.com/repos/marcoeilers/nagini/issues/109","number":109,"state":"open","locked":false,"title":"Examples and fixes","user":{"login":"marcoeilers","id":1490193,"avatar_url":"https://avatars2.githubusercontent.com/u/1490193?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoeilers","html_url":"https://github.com/marcoeilers","followers_url":"https://api.github.com/users/marcoeilers/followers","following_url":"https://api.github.com/users/marcoeilers/following{/other_user}","gists_url":"https://api.github.com/users/marcoeilers/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoeilers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoeilers/subscriptions","organizations_url":"https://api.github.com/users/marcoeilers/orgs","repos_url":"https://api.github.com/users/marcoeilers/repos","events_url":"https://api.github.com/users/marcoeilers/events{/privacy}","received_events_url":"https://api.github.com/users/marcoeilers/received_events","type":"User","site_admin":false},"body":"Last pull request from the changes made in January, this one contains a lot of small things.\r\n\r\n- new ignore-global flag skip verifying top-level statements (i.e., the non-modular part of the verification)\r\n- when possible, we only put the JAR file of the used backend on the classpath, to avoid the Log4J warnings\r\n- activated regression tests for issues that have been fixed at some earlier point\r\n- various small bug fixes, small triggering improvements\r\n- examples from the CAV submission added to the test suite\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/marcoeilers/nagini/109)\n<!-- Reviewable:end -->\n","created_at":"2018-03-06T17:56:14Z","updated_at":"2018-03-18T14:58:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f1c7a52dee444a0a91b0e40d0d3a33595c1fd2b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/marcoeilers/nagini/pulls/109/commits","review_comments_url":"https://api.github.com/repos/marcoeilers/nagini/pulls/109/comments","review_comment_url":"https://api.github.com/repos/marcoeilers/nagini/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marcoeilers/nagini/issues/109/comments","statuses_url":"https://api.github.com/repos/marcoeilers/nagini/statuses/33b0df04ef26355d32c9418332cca9e990a00385","head":{"label":"marcoeilers:marcoeilers_examples_and_fixes","ref":"marcoeilers_examples_and_fixes","sha":"33b0df04ef26355d32c9418332cca9e990a00385","user":{"login":"marcoeilers","id":1490193,"avatar_url":"https://avatars2.githubusercontent.com/u/1490193?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoeilers","html_url":"https://github.com/marcoeilers","followers_url":"https://api.github.com/users/marcoeilers/followers","following_url":"https://api.github.com/users/marcoeilers/following{/other_user}","gists_url":"https://api.github.com/users/marcoeilers/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoeilers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoeilers/subscriptions","organizations_url":"https://api.github.com/users/marcoeilers/orgs","repos_url":"https://api.github.com/users/marcoeilers/repos","events_url":"https://api.github.com/users/marcoeilers/events{/privacy}","received_events_url":"https://api.github.com/users/marcoeilers/received_events","type":"User","site_admin":false},"repo":{"id":86726131,"name":"nagini","full_name":"marcoeilers/nagini","owner":{"login":"marcoeilers","id":1490193,"avatar_url":"https://avatars2.githubusercontent.com/u/1490193?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoeilers","html_url":"https://github.com/marcoeilers","followers_url":"https://api.github.com/users/marcoeilers/followers","following_url":"https://api.github.com/users/marcoeilers/following{/other_user}","gists_url":"https://api.github.com/users/marcoeilers/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoeilers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoeilers/subscriptions","organizations_url":"https://api.github.com/users/marcoeilers/orgs","repos_url":"https://api.github.com/users/marcoeilers/repos","events_url":"https://api.github.com/users/marcoeilers/events{/privacy}","received_events_url":"https://api.github.com/users/marcoeilers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcoeilers/nagini","description":"Nagini is a static verifier for Python 3, based on the Viper verification infrastructure.","fork":false,"url":"https://api.github.com/repos/marcoeilers/nagini","forks_url":"https://api.github.com/repos/marcoeilers/nagini/forks","keys_url":"https://api.github.com/repos/marcoeilers/nagini/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcoeilers/nagini/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcoeilers/nagini/teams","hooks_url":"https://api.github.com/repos/marcoeilers/nagini/hooks","issue_events_url":"https://api.github.com/repos/marcoeilers/nagini/issues/events{/number}","events_url":"https://api.github.com/repos/marcoeilers/nagini/events","assignees_url":"https://api.github.com/repos/marcoeilers/nagini/assignees{/user}","branches_url":"https://api.github.com/repos/marcoeilers/nagini/branches{/branch}","tags_url":"https://api.github.com/repos/marcoeilers/nagini/tags","blobs_url":"https://api.github.com/repos/marcoeilers/nagini/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcoeilers/nagini/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcoeilers/nagini/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcoeilers/nagini/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcoeilers/nagini/statuses/{sha}","languages_url":"https://api.github.com/repos/marcoeilers/nagini/languages","stargazers_url":"https://api.github.com/repos/marcoeilers/nagini/stargazers","contributors_url":"https://api.github.com/repos/marcoeilers/nagini/contributors","subscribers_url":"https://api.github.com/repos/marcoeilers/nagini/subscribers","subscription_url":"https://api.github.com/repos/marcoeilers/nagini/subscription","commits_url":"https://api.github.com/repos/marcoeilers/nagini/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcoeilers/nagini/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcoeilers/nagini/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcoeilers/nagini/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcoeilers/nagini/contents/{+path}","compare_url":"https://api.github.com/repos/marcoeilers/nagini/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcoeilers/nagini/merges","archive_url":"https://api.github.com/repos/marcoeilers/nagini/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcoeilers/nagini/downloads","issues_url":"https://api.github.com/repos/marcoeilers/nagini/issues{/number}","pulls_url":"https://api.github.com/repos/marcoeilers/nagini/pulls{/number}","milestones_url":"https://api.github.com/repos/marcoeilers/nagini/milestones{/number}","notifications_url":"https://api.github.com/repos/marcoeilers/nagini/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcoeilers/nagini/labels{/name}","releases_url":"https://api.github.com/repos/marcoeilers/nagini/releases{/id}","deployments_url":"https://api.github.com/repos/marcoeilers/nagini/deployments","created_at":"2017-03-30T16:45:34Z","updated_at":"2018-02-01T02:00:05Z","pushed_at":"2018-03-14T15:55:34Z","git_url":"git://github.com/marcoeilers/nagini.git","ssh_url":"git@github.com:marcoeilers/nagini.git","clone_url":"https://github.com/marcoeilers/nagini.git","svn_url":"https://github.com/marcoeilers/nagini","homepage":"","size":2226,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":19,"watchers":0,"default_branch":"master"}},"base":{"label":"marcoeilers:master","ref":"master","sha":"2ad12acfa49174837a44a85d8dbcc05fa93dd2d8","user":{"login":"marcoeilers","id":1490193,"avatar_url":"https://avatars2.githubusercontent.com/u/1490193?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoeilers","html_url":"https://github.com/marcoeilers","followers_url":"https://api.github.com/users/marcoeilers/followers","following_url":"https://api.github.com/users/marcoeilers/following{/other_user}","gists_url":"https://api.github.com/users/marcoeilers/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoeilers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoeilers/subscriptions","organizations_url":"https://api.github.com/users/marcoeilers/orgs","repos_url":"https://api.github.com/users/marcoeilers/repos","events_url":"https://api.github.com/users/marcoeilers/events{/privacy}","received_events_url":"https://api.github.com/users/marcoeilers/received_events","type":"User","site_admin":false},"repo":{"id":86726131,"name":"nagini","full_name":"marcoeilers/nagini","owner":{"login":"marcoeilers","id":1490193,"avatar_url":"https://avatars2.githubusercontent.com/u/1490193?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoeilers","html_url":"https://github.com/marcoeilers","followers_url":"https://api.github.com/users/marcoeilers/followers","following_url":"https://api.github.com/users/marcoeilers/following{/other_user}","gists_url":"https://api.github.com/users/marcoeilers/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoeilers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoeilers/subscriptions","organizations_url":"https://api.github.com/users/marcoeilers/orgs","repos_url":"https://api.github.com/users/marcoeilers/repos","events_url":"https://api.github.com/users/marcoeilers/events{/privacy}","received_events_url":"https://api.github.com/users/marcoeilers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcoeilers/nagini","description":"Nagini is a static verifier for Python 3, based on the Viper verification infrastructure.","fork":false,"url":"https://api.github.com/repos/marcoeilers/nagini","forks_url":"https://api.github.com/repos/marcoeilers/nagini/forks","keys_url":"https://api.github.com/repos/marcoeilers/nagini/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcoeilers/nagini/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcoeilers/nagini/teams","hooks_url":"https://api.github.com/repos/marcoeilers/nagini/hooks","issue_events_url":"https://api.github.com/repos/marcoeilers/nagini/issues/events{/number}","events_url":"https://api.github.com/repos/marcoeilers/nagini/events","assignees_url":"https://api.github.com/repos/marcoeilers/nagini/assignees{/user}","branches_url":"https://api.github.com/repos/marcoeilers/nagini/branches{/branch}","tags_url":"https://api.github.com/repos/marcoeilers/nagini/tags","blobs_url":"https://api.github.com/repos/marcoeilers/nagini/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcoeilers/nagini/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcoeilers/nagini/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcoeilers/nagini/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcoeilers/nagini/statuses/{sha}","languages_url":"https://api.github.com/repos/marcoeilers/nagini/languages","stargazers_url":"https://api.github.com/repos/marcoeilers/nagini/stargazers","contributors_url":"https://api.github.com/repos/marcoeilers/nagini/contributors","subscribers_url":"https://api.github.com/repos/marcoeilers/nagini/subscribers","subscription_url":"https://api.github.com/repos/marcoeilers/nagini/subscription","commits_url":"https://api.github.com/repos/marcoeilers/nagini/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcoeilers/nagini/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcoeilers/nagini/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcoeilers/nagini/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcoeilers/nagini/contents/{+path}","compare_url":"https://api.github.com/repos/marcoeilers/nagini/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcoeilers/nagini/merges","archive_url":"https://api.github.com/repos/marcoeilers/nagini/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcoeilers/nagini/downloads","issues_url":"https://api.github.com/repos/marcoeilers/nagini/issues{/number}","pulls_url":"https://api.github.com/repos/marcoeilers/nagini/pulls{/number}","milestones_url":"https://api.github.com/repos/marcoeilers/nagini/milestones{/number}","notifications_url":"https://api.github.com/repos/marcoeilers/nagini/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcoeilers/nagini/labels{/name}","releases_url":"https://api.github.com/repos/marcoeilers/nagini/releases{/id}","deployments_url":"https://api.github.com/repos/marcoeilers/nagini/deployments","created_at":"2017-03-30T16:45:34Z","updated_at":"2018-02-01T02:00:05Z","pushed_at":"2018-03-14T15:55:34Z","git_url":"git://github.com/marcoeilers/nagini.git","ssh_url":"git@github.com:marcoeilers/nagini.git","clone_url":"https://github.com/marcoeilers/nagini.git","svn_url":"https://github.com/marcoeilers/nagini","homepage":"","size":2226,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":19,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marcoeilers/nagini/pulls/109"},"html":{"href":"https://github.com/marcoeilers/nagini/pull/109"},"issue":{"href":"https://api.github.com/repos/marcoeilers/nagini/issues/109"},"comments":{"href":"https://api.github.com/repos/marcoeilers/nagini/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/marcoeilers/nagini/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/marcoeilers/nagini/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marcoeilers/nagini/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/marcoeilers/nagini/statuses/33b0df04ef26355d32c9418332cca9e990a00385"}},"author_association":"OWNER"}}
{"actor":{"display_login":"marcoeilers"}}