{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/30424","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/30424/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/30424/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/30424/events","html_url":"https://github.com/owncloud/core/pull/30424","id":295547637,"number":30424,"title":"[stable10] scroll in modals","user":{"login":"felixheidecke","id":12717530,"avatar_url":"https://avatars0.githubusercontent.com/u/12717530?v=4","gravatar_id":"","url":"https://api.github.com/users/felixheidecke","html_url":"https://github.com/felixheidecke","followers_url":"https://api.github.com/users/felixheidecke/followers","following_url":"https://api.github.com/users/felixheidecke/following{/other_user}","gists_url":"https://api.github.com/users/felixheidecke/gists{/gist_id}","starred_url":"https://api.github.com/users/felixheidecke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixheidecke/subscriptions","organizations_url":"https://api.github.com/users/felixheidecke/orgs","repos_url":"https://api.github.com/users/felixheidecke/repos","events_url":"https://api.github.com/users/felixheidecke/events{/privacy}","received_events_url":"https://api.github.com/users/felixheidecke/received_events","type":"User","site_admin":false},"labels":[{"id":12406434,"url":"https://api.github.com/repos/owncloud/core/labels/bug","name":"bug","color":"fc2929","default":true},{"id":12406436,"url":"https://api.github.com/repos/owncloud/core/labels/enhancement","name":"enhancement","color":"02e10c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-02-08T15:10:38Z","updated_at":"2018-02-12T10:37:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/30424","html_url":"https://github.com/owncloud/core/pull/30424","diff_url":"https://github.com/owncloud/core/pull/30424.diff","patch_url":"https://github.com/owncloud/core/pull/30424.patch"},"body":"## Description\r\nAllow scrolling in modals if the window height is less than the modal height.\r\n\r\n_Expected behavior:_\r\nIf a modals height is greater than the window height then its contents should be scrollable.\r\n\r\n_Actual behavior:_\r\nThe contents of the modal expand beyond the vertical space and the user is not able to interact/reach them.\r\n\r\n## How Has This Been Tested?\r\nVisual tests in Chrome, FF\r\n\r\n## Screenshots (if appropriate):\r\n![fireshot capture 20 - dateien - owncloud_ - http___192 168 21 18_8000_index php_apps_files_](https://user-images.githubusercontent.com/12717530/35564775-a215b218-05bb-11e8-8edb-4b7260f80306.png)\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/364884964","html_url":"https://github.com/owncloud/core/pull/30424#issuecomment-364884964","issue_url":"https://api.github.com/repos/owncloud/core/issues/30424","id":364884964,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-02-12T10:37:59Z","updated_at":"2018-02-12T10:37:59Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/owncloud/core/pull/30424?src=pr&el=h1) Report\n> Merging [#30424](https://codecov.io/gh/owncloud/core/pull/30424?src=pr&el=desc) into [stable10](https://codecov.io/gh/owncloud/core/commit/b3b0d2409f916e7f7026af4320a365be3b0b06ac?src=pr&el=desc) will **increase** coverage by `0.32%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/owncloud/core/pull/30424/graphs/tree.svg?width=650&height=150&src=pr&token=bvPvzqol8M)](https://codecov.io/gh/owncloud/core/pull/30424?src=pr&el=tree)\n\n```diff\n@@              Coverage Diff               @@\n##             stable10   #30424      +/-   ##\n==============================================\n+ Coverage       61.19%   61.52%   +0.32%     \n- Complexity      18088    18294     +206     \n==============================================\n  Files            1068     1069       +1     \n  Lines           60089    60887     +798     \n==============================================\n+ Hits            36774    37458     +684     \n- Misses          23315    23429     +114\n```\n\n\n| [Impacted Files](https://codecov.io/gh/owncloud/core/pull/30424?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [lib/private/User/User.php](https://codecov.io/gh/owncloud/core/pull/30424/diff?src=pr&el=tree#diff-bGliL3ByaXZhdGUvVXNlci9Vc2VyLnBocA==) | `82.62% <0%> (-0.61%)` | `87% <0%> (+24%)` | |\n| [settings/Panels/Admin/FileSharing.php](https://codecov.io/gh/owncloud/core/pull/30424/diff?src=pr&el=tree#diff-c2V0dGluZ3MvUGFuZWxzL0FkbWluL0ZpbGVTaGFyaW5nLnBocA==) | `100% <0%> (ø)` | `7% <0%> (+1%)` | :arrow_up: |\n| [settings/templates/panels/admin/filesharing.php](https://codecov.io/gh/owncloud/core/pull/30424/diff?src=pr&el=tree#diff-c2V0dGluZ3MvdGVtcGxhdGVzL3BhbmVscy9hZG1pbi9maWxlc2hhcmluZy5waHA=) | `100% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |\n| [core/js/config.php](https://codecov.io/gh/owncloud/core/pull/30424/diff?src=pr&el=tree#diff-Y29yZS9qcy9jb25maWcucGhw) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |\n| [core/Migrations/Version20180123131835.php](https://codecov.io/gh/owncloud/core/pull/30424/diff?src=pr&el=tree#diff-Y29yZS9NaWdyYXRpb25zL1ZlcnNpb24yMDE4MDEyMzEzMTgzNS5waHA=) | `0% <0%> (ø)` | `2% <0%> (?)` | |\n| [lib/private/Share20/Manager.php](https://codecov.io/gh/owncloud/core/pull/30424/diff?src=pr&el=tree#diff-bGliL3ByaXZhdGUvU2hhcmUyMC9NYW5hZ2VyLnBocA==) | `97.91% <0%> (+0.66%)` | `265% <0%> (+67%)` | :arrow_up: |\n| [lib/private/Files/Cache/Propagator.php](https://codecov.io/gh/owncloud/core/pull/30424/diff?src=pr&el=tree#diff-bGliL3ByaXZhdGUvRmlsZXMvQ2FjaGUvUHJvcGFnYXRvci5waHA=) | `98.7% <0%> (+1.29%)` | `16% <0%> (ø)` | :arrow_down: |\n| [lib/private/Log.php](https://codecov.io/gh/owncloud/core/pull/30424/diff?src=pr&el=tree#diff-bGliL3ByaXZhdGUvTG9nLnBocA==) | `80% <0%> (+3.45%)` | `40% <0%> (+4%)` | :arrow_up: |\n| [lib/private/legacy/util.php](https://codecov.io/gh/owncloud/core/pull/30424/diff?src=pr&el=tree#diff-bGliL3ByaXZhdGUvbGVnYWN5L3V0aWwucGhw) | `70.98% <0%> (+3.52%)` | `320% <0%> (+97%)` | :arrow_up: |\n| [lib/public/Util.php](https://codecov.io/gh/owncloud/core/pull/30424/diff?src=pr&el=tree#diff-bGliL3B1YmxpYy9VdGlsLnBocA==) | `62.5% <0%> (+5.43%)` | `88% <0%> (+11%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/owncloud/core/pull/30424?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/owncloud/core/pull/30424?src=pr&el=footer). Last update [b3b0d24...6753b55](https://codecov.io/gh/owncloud/core/pull/30424?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}