{"action":"created","comment":{"url":"https://api.github.com/repos/fimbullinter/wotan/pulls/comments/182412134","pull_request_review_id":113200516,"id":182412134,"diff_hunk":"@@ -0,0 +1,193 @@\n+export class Hello {\n+    private world: string;\n+constructor(world: string) {\n+this.world = world;}\n+}\n+\n+export class Hello extends World {\n+    private world: string;\n+constructor(world: string) {\n+        super();\n+this.world = world;\n+    }\n+}\n+\n+export class Welcome {\n+    private home: string;\n+constructor(home: string = 'mom!') {\n+this.home = home;}\n+}\n+\n+export class Hello {\n+    public hello: string;\n+    constructor(hello: string = 'mom!') {\n+        this.hello = hello;\n+    }\n+}\n+\n+export class Hello extends World {\n+    public hello: string;\n+    constructor(hello: string = 'mom!') {\n+        super();\n+        this.hello = hello;\n+    }\n+}\n+\n+/* Tests for multiple access modifiers */\n+export class Hello extends World {\n+    private readonly hello: string;\n+    constructor(hello: string = 'mom!') {\n+        super();\n+        this.hello = hello;\n+    }\n+}\n+\n+export class Hello extends World {\n+    private readonly hello: string;\n+constructor(hello: string = 'mom!') {\n+        super();\n+this.hello = hello;\n+    }\n+}\n+\n+class Foo {\n+    fizz: string;\n+    constructor(fizz: string) {\n+        this.fizz = fizz + ' buzz';\n+    }\n+}\n+\n+class Foo extends Bar {\n+    fizz: string;\n+    constructor(fizz: string) {\n+        super();\n+        this.fizz = fizz + ' buzz';\n+    }\n+}\n+\n+/* when-possible config should ignore this case because param is not the first thing to be assigned to the prop */\n+class Foo {\n+    fizz: string;\n+    constructor(fizz: string) {\n+        this.fizz = 'buzz';\n+        this.fizz = fizz;\n+    }\n+}\n+\n+class Foo {\n+    constructor() {}\n+}\n+\n+class Foo {\n+    constructor() { 'use strict'; }\n+}\n+\n+class Foo {\n+    private bar: string;\n+    private fizz: boolean;\n+constructor(bar: string,fizz: boolean) {\n+this.fizz = fizz;\n+        this.bar = bar;\n+    }\n+}\n+\n+class Foo {\n+    private bar: string;\n+    private fizz: boolean;\n+constructor(bar: string,fizz: boolean) {\n+this.fizz = fizz;\n+        this.bar = bar + 'fizz';\n+        this.bar = bar;\n+    }\n+}\n+\n+class Foo {\n+    private bar: string;\n+    private fizz?: boolean;\n+constructor(bar: string,fizz?: boolean) {\n+this.fizz = fizz;\n+        this.bar = bar + 'fizz';\n+        this.bar = bar;\n+    }\n+}\n+\n+/* Need to ignore directives */\n+class Foo extends Bar {\n+    private bar: string;\n+    private fizz?: string;\n+constructor(bar: string,fizz?: string) {\n+        'use strict';\n+        super();\n+this.fizz = fizz;\n+        this.bar = bar + 'fizz';\n+        this.bar = bar;\n+    }\n+}\n+\n+class Foo extends Bar {\n+    private bar: string;\n+    private fizz?: string;\n+constructor(bar,fizz?: string) {\n+        'use strict';\n+        super();\n+this.fizz = fizz;\n+        this.bar = bar;\n+    }\n+}\n+\n+class Foo {\n+    private bar: string;\n+    private fizz?: boolean;\n+constructor(bar: string,fizz?: boolean) {\n+        'use strict';\n+this.fizz = fizz;\n+        this.bar = bar;\n+    }\n+}\n+\n+/* When-possible ought to ignore this case */\n+export class AngularComponent {\n+    @Input() public data: any;\n+    constructor(data: any) {\n+        this.data = data;\n+    }\n+}\n+\n+export class AngularComponent {\n+    @Input() public data: any;\n+    private foo: string;\n+constructor(data: any,foo: string) {\n+this.foo = foo;\n+        this.data = data;\n+    }\n+}\n+\n+/* If rest params exist and mode is 'consistent,' all other params should be made into longhand props */\n+class RestParamClass {\n+    private a: string;\n+    public b: number;\n+constructor(a: string,b: number, ...c) {\n+this.b = b;\n+        this.a = a;\n+    }\n+}\n+\n+/* never mode should leave the decorator but copy the rest of the param to the class body */\n+class Car {\n+    public engine: Engine;\n+constructor(@Inject(\"MyEngine\")engine: Engine) {","path":"baselines/packages/mimir/test/parameter-properties/default/test.ts","position":178,"original_position":178,"commit_id":"c687d527911ee90a3ab14f0b1571077bea0203be","original_commit_id":"c687d527911ee90a3ab14f0b1571077bea0203be","user":{"login":"aervin","id":13973880,"avatar_url":"https://avatars0.githubusercontent.com/u/13973880?v=4","gravatar_id":"","url":"https://api.github.com/users/aervin","html_url":"https://github.com/aervin","followers_url":"https://api.github.com/users/aervin/followers","following_url":"https://api.github.com/users/aervin/following{/other_user}","gists_url":"https://api.github.com/users/aervin/gists{/gist_id}","starred_url":"https://api.github.com/users/aervin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aervin/subscriptions","organizations_url":"https://api.github.com/users/aervin/orgs","repos_url":"https://api.github.com/users/aervin/repos","events_url":"https://api.github.com/users/aervin/events{/privacy}","received_events_url":"https://api.github.com/users/aervin/received_events","type":"User","site_admin":false},"body":"I've got a patch for this on my local. Will check it in after the next iteration.","created_at":"2018-04-18T12:45:14Z","updated_at":"2018-04-18T12:45:15Z","html_url":"https://github.com/fimbullinter/wotan/pull/189#discussion_r182412134","pull_request_url":"https://api.github.com/repos/fimbullinter/wotan/pulls/189","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fimbullinter/wotan/pulls/comments/182412134"},"html":{"href":"https://github.com/fimbullinter/wotan/pull/189#discussion_r182412134"},"pull_request":{"href":"https://api.github.com/repos/fimbullinter/wotan/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/fimbullinter/wotan/pulls/189","id":181659848,"html_url":"https://github.com/fimbullinter/wotan/pull/189","diff_url":"https://github.com/fimbullinter/wotan/pull/189.diff","patch_url":"https://github.com/fimbullinter/wotan/pull/189.patch","issue_url":"https://api.github.com/repos/fimbullinter/wotan/issues/189","number":189,"state":"open","locked":false,"title":"new rule // parameter-properties","user":{"login":"aervin","id":13973880,"avatar_url":"https://avatars0.githubusercontent.com/u/13973880?v=4","gravatar_id":"","url":"https://api.github.com/users/aervin","html_url":"https://github.com/aervin","followers_url":"https://api.github.com/users/aervin/followers","following_url":"https://api.github.com/users/aervin/following{/other_user}","gists_url":"https://api.github.com/users/aervin/gists{/gist_id}","starred_url":"https://api.github.com/users/aervin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aervin/subscriptions","organizations_url":"https://api.github.com/users/aervin/orgs","repos_url":"https://api.github.com/users/aervin/repos","events_url":"https://api.github.com/users/aervin/events{/privacy}","received_events_url":"https://api.github.com/users/aervin/received_events","type":"User","site_admin":false},"body":"#### Checklist\r\n\r\n- [X] Fixes: #167 \r\n- [X] Added or updated tests / baselines\r\n- [ ] Documentation update\r\n","created_at":"2018-04-14T18:07:36Z","updated_at":"2018-04-18T12:45:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8da79cde9b31b8ff166811998f4d00b499641fd4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fimbullinter/wotan/pulls/189/commits","review_comments_url":"https://api.github.com/repos/fimbullinter/wotan/pulls/189/comments","review_comment_url":"https://api.github.com/repos/fimbullinter/wotan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fimbullinter/wotan/issues/189/comments","statuses_url":"https://api.github.com/repos/fimbullinter/wotan/statuses/c687d527911ee90a3ab14f0b1571077bea0203be","head":{"label":"aervin:param-props","ref":"param-props","sha":"c687d527911ee90a3ab14f0b1571077bea0203be","user":{"login":"aervin","id":13973880,"avatar_url":"https://avatars0.githubusercontent.com/u/13973880?v=4","gravatar_id":"","url":"https://api.github.com/users/aervin","html_url":"https://github.com/aervin","followers_url":"https://api.github.com/users/aervin/followers","following_url":"https://api.github.com/users/aervin/following{/other_user}","gists_url":"https://api.github.com/users/aervin/gists{/gist_id}","starred_url":"https://api.github.com/users/aervin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aervin/subscriptions","organizations_url":"https://api.github.com/users/aervin/orgs","repos_url":"https://api.github.com/users/aervin/repos","events_url":"https://api.github.com/users/aervin/events{/privacy}","received_events_url":"https://api.github.com/users/aervin/received_events","type":"User","site_admin":false},"repo":{"id":127985184,"name":"wotan","full_name":"aervin/wotan","owner":{"login":"aervin","id":13973880,"avatar_url":"https://avatars0.githubusercontent.com/u/13973880?v=4","gravatar_id":"","url":"https://api.github.com/users/aervin","html_url":"https://github.com/aervin","followers_url":"https://api.github.com/users/aervin/followers","following_url":"https://api.github.com/users/aervin/following{/other_user}","gists_url":"https://api.github.com/users/aervin/gists{/gist_id}","starred_url":"https://api.github.com/users/aervin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aervin/subscriptions","organizations_url":"https://api.github.com/users/aervin/orgs","repos_url":"https://api.github.com/users/aervin/repos","events_url":"https://api.github.com/users/aervin/events{/privacy}","received_events_url":"https://api.github.com/users/aervin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aervin/wotan","description":"Pluggable TypeScript and JavaScript linter","fork":true,"url":"https://api.github.com/repos/aervin/wotan","forks_url":"https://api.github.com/repos/aervin/wotan/forks","keys_url":"https://api.github.com/repos/aervin/wotan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aervin/wotan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aervin/wotan/teams","hooks_url":"https://api.github.com/repos/aervin/wotan/hooks","issue_events_url":"https://api.github.com/repos/aervin/wotan/issues/events{/number}","events_url":"https://api.github.com/repos/aervin/wotan/events","assignees_url":"https://api.github.com/repos/aervin/wotan/assignees{/user}","branches_url":"https://api.github.com/repos/aervin/wotan/branches{/branch}","tags_url":"https://api.github.com/repos/aervin/wotan/tags","blobs_url":"https://api.github.com/repos/aervin/wotan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aervin/wotan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aervin/wotan/git/refs{/sha}","trees_url":"https://api.github.com/repos/aervin/wotan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aervin/wotan/statuses/{sha}","languages_url":"https://api.github.com/repos/aervin/wotan/languages","stargazers_url":"https://api.github.com/repos/aervin/wotan/stargazers","contributors_url":"https://api.github.com/repos/aervin/wotan/contributors","subscribers_url":"https://api.github.com/repos/aervin/wotan/subscribers","subscription_url":"https://api.github.com/repos/aervin/wotan/subscription","commits_url":"https://api.github.com/repos/aervin/wotan/commits{/sha}","git_commits_url":"https://api.github.com/repos/aervin/wotan/git/commits{/sha}","comments_url":"https://api.github.com/repos/aervin/wotan/comments{/number}","issue_comment_url":"https://api.github.com/repos/aervin/wotan/issues/comments{/number}","contents_url":"https://api.github.com/repos/aervin/wotan/contents/{+path}","compare_url":"https://api.github.com/repos/aervin/wotan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aervin/wotan/merges","archive_url":"https://api.github.com/repos/aervin/wotan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aervin/wotan/downloads","issues_url":"https://api.github.com/repos/aervin/wotan/issues{/number}","pulls_url":"https://api.github.com/repos/aervin/wotan/pulls{/number}","milestones_url":"https://api.github.com/repos/aervin/wotan/milestones{/number}","notifications_url":"https://api.github.com/repos/aervin/wotan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aervin/wotan/labels{/name}","releases_url":"https://api.github.com/repos/aervin/wotan/releases{/id}","deployments_url":"https://api.github.com/repos/aervin/wotan/deployments","created_at":"2018-04-04T00:37:08Z","updated_at":"2018-04-14T15:08:09Z","pushed_at":"2018-04-18T12:38:50Z","git_url":"git://github.com/aervin/wotan.git","ssh_url":"git@github.com:aervin/wotan.git","clone_url":"https://github.com/aervin/wotan.git","svn_url":"https://github.com/aervin/wotan","homepage":null,"size":1089,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fimbullinter:master","ref":"master","sha":"ef32f24b66372ad4a11b7ef83c647eda14e20e43","user":{"login":"fimbullinter","id":35915981,"avatar_url":"https://avatars1.githubusercontent.com/u/35915981?v=4","gravatar_id":"","url":"https://api.github.com/users/fimbullinter","html_url":"https://github.com/fimbullinter","followers_url":"https://api.github.com/users/fimbullinter/followers","following_url":"https://api.github.com/users/fimbullinter/following{/other_user}","gists_url":"https://api.github.com/users/fimbullinter/gists{/gist_id}","starred_url":"https://api.github.com/users/fimbullinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fimbullinter/subscriptions","organizations_url":"https://api.github.com/users/fimbullinter/orgs","repos_url":"https://api.github.com/users/fimbullinter/repos","events_url":"https://api.github.com/users/fimbullinter/events{/privacy}","received_events_url":"https://api.github.com/users/fimbullinter/received_events","type":"Organization","site_admin":false},"repo":{"id":111957557,"name":"wotan","full_name":"fimbullinter/wotan","owner":{"login":"fimbullinter","id":35915981,"avatar_url":"https://avatars1.githubusercontent.com/u/35915981?v=4","gravatar_id":"","url":"https://api.github.com/users/fimbullinter","html_url":"https://github.com/fimbullinter","followers_url":"https://api.github.com/users/fimbullinter/followers","following_url":"https://api.github.com/users/fimbullinter/following{/other_user}","gists_url":"https://api.github.com/users/fimbullinter/gists{/gist_id}","starred_url":"https://api.github.com/users/fimbullinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fimbullinter/subscriptions","organizations_url":"https://api.github.com/users/fimbullinter/orgs","repos_url":"https://api.github.com/users/fimbullinter/repos","events_url":"https://api.github.com/users/fimbullinter/events{/privacy}","received_events_url":"https://api.github.com/users/fimbullinter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fimbullinter/wotan","description":"Pluggable TypeScript and JavaScript linter","fork":false,"url":"https://api.github.com/repos/fimbullinter/wotan","forks_url":"https://api.github.com/repos/fimbullinter/wotan/forks","keys_url":"https://api.github.com/repos/fimbullinter/wotan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fimbullinter/wotan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fimbullinter/wotan/teams","hooks_url":"https://api.github.com/repos/fimbullinter/wotan/hooks","issue_events_url":"https://api.github.com/repos/fimbullinter/wotan/issues/events{/number}","events_url":"https://api.github.com/repos/fimbullinter/wotan/events","assignees_url":"https://api.github.com/repos/fimbullinter/wotan/assignees{/user}","branches_url":"https://api.github.com/repos/fimbullinter/wotan/branches{/branch}","tags_url":"https://api.github.com/repos/fimbullinter/wotan/tags","blobs_url":"https://api.github.com/repos/fimbullinter/wotan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fimbullinter/wotan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fimbullinter/wotan/git/refs{/sha}","trees_url":"https://api.github.com/repos/fimbullinter/wotan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fimbullinter/wotan/statuses/{sha}","languages_url":"https://api.github.com/repos/fimbullinter/wotan/languages","stargazers_url":"https://api.github.com/repos/fimbullinter/wotan/stargazers","contributors_url":"https://api.github.com/repos/fimbullinter/wotan/contributors","subscribers_url":"https://api.github.com/repos/fimbullinter/wotan/subscribers","subscription_url":"https://api.github.com/repos/fimbullinter/wotan/subscription","commits_url":"https://api.github.com/repos/fimbullinter/wotan/commits{/sha}","git_commits_url":"https://api.github.com/repos/fimbullinter/wotan/git/commits{/sha}","comments_url":"https://api.github.com/repos/fimbullinter/wotan/comments{/number}","issue_comment_url":"https://api.github.com/repos/fimbullinter/wotan/issues/comments{/number}","contents_url":"https://api.github.com/repos/fimbullinter/wotan/contents/{+path}","compare_url":"https://api.github.com/repos/fimbullinter/wotan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fimbullinter/wotan/merges","archive_url":"https://api.github.com/repos/fimbullinter/wotan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fimbullinter/wotan/downloads","issues_url":"https://api.github.com/repos/fimbullinter/wotan/issues{/number}","pulls_url":"https://api.github.com/repos/fimbullinter/wotan/pulls{/number}","milestones_url":"https://api.github.com/repos/fimbullinter/wotan/milestones{/number}","notifications_url":"https://api.github.com/repos/fimbullinter/wotan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fimbullinter/wotan/labels{/name}","releases_url":"https://api.github.com/repos/fimbullinter/wotan/releases{/id}","deployments_url":"https://api.github.com/repos/fimbullinter/wotan/deployments","created_at":"2017-11-24T21:43:37Z","updated_at":"2018-04-18T04:50:01Z","pushed_at":"2018-04-18T12:38:51Z","git_url":"git://github.com/fimbullinter/wotan.git","ssh_url":"git@github.com:fimbullinter/wotan.git","clone_url":"https://github.com/fimbullinter/wotan.git","svn_url":"https://github.com/fimbullinter/wotan","homepage":null,"size":1058,"stargazers_count":24,"watchers_count":24,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":30,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fimbullinter/wotan/pulls/189"},"html":{"href":"https://github.com/fimbullinter/wotan/pull/189"},"issue":{"href":"https://api.github.com/repos/fimbullinter/wotan/issues/189"},"comments":{"href":"https://api.github.com/repos/fimbullinter/wotan/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/fimbullinter/wotan/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/fimbullinter/wotan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fimbullinter/wotan/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/fimbullinter/wotan/statuses/c687d527911ee90a3ab14f0b1571077bea0203be"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aervin"}}