{"action":"created","comment":{"url":"https://api.github.com/repos/istio/api/pulls/comments/211785841","pull_request_review_id":148282020,"id":211785841,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTc4NTg0MQ==","diff_hunk":"@@ -35,4 +37,6 @@ message CheckResult {\n   google.protobuf.Duration valid_duration = 2 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true];\n   // The number of uses for which this result can be considered valid.\n   int32 valid_use_count = 3;\n+  // Output attributes\n+  istio.mixer.v1.Attributes output_attributes = 4;","path":"mixer/adapter/model/v1beta1/check.proto","position":14,"original_position":14,"commit_id":"23b0002640134d61aab9fb95afdab850b266c1d0","original_commit_id":"23b0002640134d61aab9fb95afdab850b266c1d0","user":{"login":"douglas-reid","id":21148125,"node_id":"MDQ6VXNlcjIxMTQ4MTI1","avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false},"body":"Ah, yes. So, there is probably some refactoring that could enable reuse across templates. But, a naive way would mean different message per template. That's why it would be good to have *something* that these could be mapped back into (like the `attribute_bindings` for APAs) for standard processing.","created_at":"2018-08-21T22:59:58Z","updated_at":"2018-08-21T22:59:58Z","html_url":"https://github.com/istio/api/pull/618#discussion_r211785841","pull_request_url":"https://api.github.com/repos/istio/api/pulls/618","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/api/pulls/comments/211785841"},"html":{"href":"https://github.com/istio/api/pull/618#discussion_r211785841"},"pull_request":{"href":"https://api.github.com/repos/istio/api/pulls/618"}},"in_reply_to_id":211756925},"pull_request":{"url":"https://api.github.com/repos/istio/api/pulls/618","id":209940786,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5OTQwNzg2","html_url":"https://github.com/istio/api/pull/618","diff_url":"https://github.com/istio/api/pull/618.diff","patch_url":"https://github.com/istio/api/pull/618.patch","issue_url":"https://api.github.com/repos/istio/api/issues/618","number":618,"state":"open","locked":false,"title":"mixer: add output attributes to check adapters","user":{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"body":"Allow gRPC check adapters to return attributes.\r\n/assign @geeknoid \r\n/assign @mandarjog \r\n\r\nSigned-off-by: Kuat Yessenov <kuat@google.com>","created_at":"2018-08-21T20:07:14Z","updated_at":"2018-08-21T22:59:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55eb74a328b7f0ff22bb15ea4de614fb97711f5a","assignee":{"login":"geeknoid","id":22780957,"node_id":"MDQ6VXNlcjIyNzgwOTU3","avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false},"assignees":[{"login":"mandarjog","id":800375,"node_id":"MDQ6VXNlcjgwMDM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},{"login":"geeknoid","id":22780957,"node_id":"MDQ6VXNlcjIyNzgwOTU3","avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"frankbu","id":2752495,"node_id":"MDQ6VXNlcjI3NTI0OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2752495?v=4","gravatar_id":"","url":"https://api.github.com/users/frankbu","html_url":"https://github.com/frankbu","followers_url":"https://api.github.com/users/frankbu/followers","following_url":"https://api.github.com/users/frankbu/following{/other_user}","gists_url":"https://api.github.com/users/frankbu/gists{/gist_id}","starred_url":"https://api.github.com/users/frankbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankbu/subscriptions","organizations_url":"https://api.github.com/users/frankbu/orgs","repos_url":"https://api.github.com/users/frankbu/repos","events_url":"https://api.github.com/users/frankbu/events{/privacy}","received_events_url":"https://api.github.com/users/frankbu/received_events","type":"User","site_admin":false},{"login":"diemtvu","id":25132401,"node_id":"MDQ6VXNlcjI1MTMyNDAx","avatar_url":"https://avatars0.githubusercontent.com/u/25132401?v=4","gravatar_id":"","url":"https://api.github.com/users/diemtvu","html_url":"https://github.com/diemtvu","followers_url":"https://api.github.com/users/diemtvu/followers","following_url":"https://api.github.com/users/diemtvu/following{/other_user}","gists_url":"https://api.github.com/users/diemtvu/gists{/gist_id}","starred_url":"https://api.github.com/users/diemtvu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diemtvu/subscriptions","organizations_url":"https://api.github.com/users/diemtvu/orgs","repos_url":"https://api.github.com/users/diemtvu/repos","events_url":"https://api.github.com/users/diemtvu/events{/privacy}","received_events_url":"https://api.github.com/users/diemtvu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":717060039,"node_id":"MDU6TGFiZWw3MTcwNjAwMzk=","url":"https://api.github.com/repos/istio/api/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/api/pulls/618/commits","review_comments_url":"https://api.github.com/repos/istio/api/pulls/618/comments","review_comment_url":"https://api.github.com/repos/istio/api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/api/issues/618/comments","statuses_url":"https://api.github.com/repos/istio/api/statuses/23b0002640134d61aab9fb95afdab850b266c1d0","head":{"label":"kyessenov:rule_operations","ref":"rule_operations","sha":"23b0002640134d61aab9fb95afdab850b266c1d0","user":{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"repo":{"id":78696332,"node_id":"MDEwOlJlcG9zaXRvcnk3ODY5NjMzMg==","name":"api","full_name":"kyessenov/api","owner":{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyessenov/api","description":"API, Config Definitions and Standard Vocabulary definitions for the istio project","fork":true,"url":"https://api.github.com/repos/kyessenov/api","forks_url":"https://api.github.com/repos/kyessenov/api/forks","keys_url":"https://api.github.com/repos/kyessenov/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyessenov/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyessenov/api/teams","hooks_url":"https://api.github.com/repos/kyessenov/api/hooks","issue_events_url":"https://api.github.com/repos/kyessenov/api/issues/events{/number}","events_url":"https://api.github.com/repos/kyessenov/api/events","assignees_url":"https://api.github.com/repos/kyessenov/api/assignees{/user}","branches_url":"https://api.github.com/repos/kyessenov/api/branches{/branch}","tags_url":"https://api.github.com/repos/kyessenov/api/tags","blobs_url":"https://api.github.com/repos/kyessenov/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyessenov/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyessenov/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyessenov/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyessenov/api/statuses/{sha}","languages_url":"https://api.github.com/repos/kyessenov/api/languages","stargazers_url":"https://api.github.com/repos/kyessenov/api/stargazers","contributors_url":"https://api.github.com/repos/kyessenov/api/contributors","subscribers_url":"https://api.github.com/repos/kyessenov/api/subscribers","subscription_url":"https://api.github.com/repos/kyessenov/api/subscription","commits_url":"https://api.github.com/repos/kyessenov/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyessenov/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyessenov/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyessenov/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyessenov/api/contents/{+path}","compare_url":"https://api.github.com/repos/kyessenov/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyessenov/api/merges","archive_url":"https://api.github.com/repos/kyessenov/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyessenov/api/downloads","issues_url":"https://api.github.com/repos/kyessenov/api/issues{/number}","pulls_url":"https://api.github.com/repos/kyessenov/api/pulls{/number}","milestones_url":"https://api.github.com/repos/kyessenov/api/milestones{/number}","notifications_url":"https://api.github.com/repos/kyessenov/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyessenov/api/labels{/name}","releases_url":"https://api.github.com/repos/kyessenov/api/releases{/id}","deployments_url":"https://api.github.com/repos/kyessenov/api/deployments","created_at":"2017-01-12T01:29:41Z","updated_at":"2017-01-12T01:29:44Z","pushed_at":"2018-08-21T20:06:47Z","git_url":"git://github.com/kyessenov/api.git","ssh_url":"git@github.com:kyessenov/api.git","clone_url":"https://github.com/kyessenov/api.git","svn_url":"https://github.com/kyessenov/api","homepage":null,"size":4372,"stargazers_count":0,"watchers_count":0,"language":"Protocol Buffer","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"a3d84057e213e02e1c8384cb42ed29a2c27b5829","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":76586412,"node_id":"MDEwOlJlcG9zaXRvcnk3NjU4NjQxMg==","name":"api","full_name":"istio/api","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/api","description":"API, config and standard vocabulary definitions for the Istio project","fork":false,"url":"https://api.github.com/repos/istio/api","forks_url":"https://api.github.com/repos/istio/api/forks","keys_url":"https://api.github.com/repos/istio/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/api/teams","hooks_url":"https://api.github.com/repos/istio/api/hooks","issue_events_url":"https://api.github.com/repos/istio/api/issues/events{/number}","events_url":"https://api.github.com/repos/istio/api/events","assignees_url":"https://api.github.com/repos/istio/api/assignees{/user}","branches_url":"https://api.github.com/repos/istio/api/branches{/branch}","tags_url":"https://api.github.com/repos/istio/api/tags","blobs_url":"https://api.github.com/repos/istio/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/api/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/api/languages","stargazers_url":"https://api.github.com/repos/istio/api/stargazers","contributors_url":"https://api.github.com/repos/istio/api/contributors","subscribers_url":"https://api.github.com/repos/istio/api/subscribers","subscription_url":"https://api.github.com/repos/istio/api/subscription","commits_url":"https://api.github.com/repos/istio/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/api/contents/{+path}","compare_url":"https://api.github.com/repos/istio/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/api/merges","archive_url":"https://api.github.com/repos/istio/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/api/downloads","issues_url":"https://api.github.com/repos/istio/api/issues{/number}","pulls_url":"https://api.github.com/repos/istio/api/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/api/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/api/labels{/name}","releases_url":"https://api.github.com/repos/istio/api/releases{/id}","deployments_url":"https://api.github.com/repos/istio/api/deployments","created_at":"2016-12-15T18:47:13Z","updated_at":"2018-08-20T19:20:36Z","pushed_at":"2018-08-21T20:07:14Z","git_url":"git://github.com/istio/api.git","ssh_url":"git@github.com:istio/api.git","clone_url":"https://github.com/istio/api.git","svn_url":"https://github.com/istio/api","homepage":"","size":2907,"stargazers_count":80,"watchers_count":80,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":111,"open_issues":28,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/api/pulls/618"},"html":{"href":"https://github.com/istio/api/pull/618"},"issue":{"href":"https://api.github.com/repos/istio/api/issues/618"},"comments":{"href":"https://api.github.com/repos/istio/api/issues/618/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/api/pulls/618/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/api/pulls/618/commits"},"statuses":{"href":"https://api.github.com/repos/istio/api/statuses/23b0002640134d61aab9fb95afdab850b266c1d0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"douglas-reid"}}