{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/211315861","pull_request_review_id":147710536,"id":211315861,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTMxNTg2MQ==","diff_hunk":"@@ -61,6 +186,104 @@ in\n         wantedBy = [ \"default.target\" ];\n       };\n     };\n+\n+    environment.etc.\"geoclue/geoclue.conf\".text = ''\n+    # Configuration file for Geoclue\n+\n+    # Agent configuration options\n+    [agent]\n+\n+    # Whitelist of desktop IDs (without .desktop part) of all agents we recognise,\n+    # separated by a ';'.\n+    whitelist=${let whitelist = optional cfg.enableDemoAgent \"geoclue-demo-agent\" ++ singleton \"gnome-shell\" ++ cfg.extraWhitelistedAgents; in semiColon whitelist}\n+\n+    # Network NMEA source configuration options\n+    [network-nmea]\n+\n+    # Fetch location from NMEA sources on local network?\n+    enable=${tf cfg.enableNmea}\n+\n+    # WiFi source configuration options\n+    [wifi]\n+\n+    # URL to the wifi geolocation service. The key can currenty be anything, just\n+    # needs to be present but that is likely going to change in future.\n+    url=${cfg.geoProviderUrl}\n+\n+    # Submit data to Mozilla Location Service\n+    # If set to true, geoclue will automatically submit network data to Mozilla\n+    # each time it gets a GPS lock.\n+    #\n+    submit-data=${tf cfg.submitData}\n+\n+    # URL to submission API of Mozilla Location Service\n+    submission-url=${cfg.submissionUrl}\n+\n+    # A nickname to submit network data with. This is currently used for leaderboard:\n+    # https://location.services.mozilla.com/leaders\n+    # A nickname must be 2-32 characters long.\n+    submission-nick=${cfg.submissionNick}\n+\n+    # Application configuration options\n+    #\n+    # NOTE: Having an entry here for an application with allowed=true means that\n+    #       geoclue will not ask agent to authorize the application. This is to\n+    #       ensure that system components and applications with built-in\n+    #       authorization mechanism (e.g web browsers) do not have to be bound to\n+    #       agents.\n+    #\n+    #       If your application is denied access to location information and your\n+    #       operating system doesn't provide any mechanism to change that, it is\n+    #       likely a bug in your operation system (or geoclue). The solution is to\n+    #       report the issue with all details, rather than adding your application\n+    #       to this list.\n+    #\n+    # Format:\n+    #\n+    # # Desktop ID of application without .desktop part\n+    # [random-app]\n+    #\n+    # # Allowed access to location information?\n+    # allowed=true|false\n+    #\n+    # # Is application a system component?\n+    # system=true|false\n+    #\n+    # # List of UIDs of all users for which this application is allowed location\n+    # # info access, separate by ';'. Keep it empty for allowing it for all users.\n+    # users=\n+\n+    [gnome-datetime-panel]\n+    allowed=true\n+    system=true\n+    users=\n+\n+    [gnome-color-panel]\n+    allowed=true\n+    system=true\n+    users=\n+\n+    [org.gnome.Shell]","path":"nixos/modules/services/desktops/geoclue2.nix","position":240,"original_position":240,"commit_id":"b464d6a8607308b1f12e593ff71f8ada2fa1261a","original_commit_id":"b464d6a8607308b1f12e593ff71f8ada2fa1261a","user":{"login":"worldofpeace","id":28888242,"node_id":"MDQ6VXNlcjI4ODg4MjQy","avatar_url":"https://avatars0.githubusercontent.com/u/28888242?v=4","gravatar_id":"","url":"https://api.github.com/users/worldofpeace","html_url":"https://github.com/worldofpeace","followers_url":"https://api.github.com/users/worldofpeace/followers","following_url":"https://api.github.com/users/worldofpeace/following{/other_user}","gists_url":"https://api.github.com/users/worldofpeace/gists{/gist_id}","starred_url":"https://api.github.com/users/worldofpeace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worldofpeace/subscriptions","organizations_url":"https://api.github.com/users/worldofpeace/orgs","repos_url":"https://api.github.com/users/worldofpeace/repos","events_url":"https://api.github.com/users/worldofpeace/events{/privacy}","received_events_url":"https://api.github.com/users/worldofpeace/received_events","type":"User","site_admin":false},"body":"These are the defaults upstream. Though I feel the use of geoclue2 implies gnome does it not?","created_at":"2018-08-20T15:57:47Z","updated_at":"2018-08-20T15:57:47Z","html_url":"https://github.com/NixOS/nixpkgs/pull/45306#discussion_r211315861","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45306","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/211315861"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/45306#discussion_r211315861"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45306"}},"in_reply_to_id":211314359},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45306","id":209313906,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzEzOTA2","html_url":"https://github.com/NixOS/nixpkgs/pull/45306","diff_url":"https://github.com/NixOS/nixpkgs/pull/45306.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/45306.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45306","number":45306,"state":"open","locked":false,"title":"nixos/geoclue2: add ability to whitelist agents and append to config","user":{"login":"worldofpeace","id":28888242,"node_id":"MDQ6VXNlcjI4ODg4MjQy","avatar_url":"https://avatars0.githubusercontent.com/u/28888242?v=4","gravatar_id":"","url":"https://api.github.com/users/worldofpeace","html_url":"https://github.com/worldofpeace","followers_url":"https://api.github.com/users/worldofpeace/followers","following_url":"https://api.github.com/users/worldofpeace/following{/other_user}","gists_url":"https://api.github.com/users/worldofpeace/gists{/gist_id}","starred_url":"https://api.github.com/users/worldofpeace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worldofpeace/subscriptions","organizations_url":"https://api.github.com/users/worldofpeace/orgs","repos_url":"https://api.github.com/users/worldofpeace/repos","events_url":"https://api.github.com/users/worldofpeace/events{/privacy}","received_events_url":"https://api.github.com/users/worldofpeace/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\nNon-functioning [elementary geoclue2 agent](https://github.com/elementary/pantheon-agent-geoclue2)\r\n\r\nEventually we'd like something similar to [this](https://gitlab.freedesktop.org/geoclue/geoclue/issues/74) but I'm unsure also, as mentioned, if elementary should be adding their agent into `geoclue.conf` upstream.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\ncc @jtojnar\r\n\r\n","created_at":"2018-08-18T14:13:27Z","updated_at":"2018-08-20T15:57:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7f2531cd261062ade6ef268d0b7d507fc5fcef1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"node_id":"MDU6TGFiZWw2MDI2NTIxMg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"node_id":"MDU6TGFiZWwyOTAxMjI4ODQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45306/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45306/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45306/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/b464d6a8607308b1f12e593ff71f8ada2fa1261a","head":{"label":"worldofpeace:geoclue2-whitelisted-agents","ref":"geoclue2-whitelisted-agents","sha":"b464d6a8607308b1f12e593ff71f8ada2fa1261a","user":{"login":"worldofpeace","id":28888242,"node_id":"MDQ6VXNlcjI4ODg4MjQy","avatar_url":"https://avatars0.githubusercontent.com/u/28888242?v=4","gravatar_id":"","url":"https://api.github.com/users/worldofpeace","html_url":"https://github.com/worldofpeace","followers_url":"https://api.github.com/users/worldofpeace/followers","following_url":"https://api.github.com/users/worldofpeace/following{/other_user}","gists_url":"https://api.github.com/users/worldofpeace/gists{/gist_id}","starred_url":"https://api.github.com/users/worldofpeace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worldofpeace/subscriptions","organizations_url":"https://api.github.com/users/worldofpeace/orgs","repos_url":"https://api.github.com/users/worldofpeace/repos","events_url":"https://api.github.com/users/worldofpeace/events{/privacy}","received_events_url":"https://api.github.com/users/worldofpeace/received_events","type":"User","site_admin":false},"repo":{"id":135512384,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU1MTIzODQ=","name":"nixpkgs","full_name":"worldofpeace/nixpkgs","owner":{"login":"worldofpeace","id":28888242,"node_id":"MDQ6VXNlcjI4ODg4MjQy","avatar_url":"https://avatars0.githubusercontent.com/u/28888242?v=4","gravatar_id":"","url":"https://api.github.com/users/worldofpeace","html_url":"https://github.com/worldofpeace","followers_url":"https://api.github.com/users/worldofpeace/followers","following_url":"https://api.github.com/users/worldofpeace/following{/other_user}","gists_url":"https://api.github.com/users/worldofpeace/gists{/gist_id}","starred_url":"https://api.github.com/users/worldofpeace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worldofpeace/subscriptions","organizations_url":"https://api.github.com/users/worldofpeace/orgs","repos_url":"https://api.github.com/users/worldofpeace/repos","events_url":"https://api.github.com/users/worldofpeace/events{/privacy}","received_events_url":"https://api.github.com/users/worldofpeace/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/worldofpeace/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/worldofpeace/nixpkgs","forks_url":"https://api.github.com/repos/worldofpeace/nixpkgs/forks","keys_url":"https://api.github.com/repos/worldofpeace/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/worldofpeace/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/worldofpeace/nixpkgs/teams","hooks_url":"https://api.github.com/repos/worldofpeace/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/worldofpeace/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/worldofpeace/nixpkgs/events","assignees_url":"https://api.github.com/repos/worldofpeace/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/worldofpeace/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/worldofpeace/nixpkgs/tags","blobs_url":"https://api.github.com/repos/worldofpeace/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/worldofpeace/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/worldofpeace/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/worldofpeace/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/worldofpeace/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/worldofpeace/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/worldofpeace/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/worldofpeace/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/worldofpeace/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/worldofpeace/nixpkgs/subscription","commits_url":"https://api.github.com/repos/worldofpeace/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/worldofpeace/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/worldofpeace/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/worldofpeace/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/worldofpeace/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/worldofpeace/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/worldofpeace/nixpkgs/merges","archive_url":"https://api.github.com/repos/worldofpeace/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/worldofpeace/nixpkgs/downloads","issues_url":"https://api.github.com/repos/worldofpeace/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/worldofpeace/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/worldofpeace/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/worldofpeace/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/worldofpeace/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/worldofpeace/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/worldofpeace/nixpkgs/deployments","created_at":"2018-05-31T00:49:50Z","updated_at":"2018-08-16T22:18:38Z","pushed_at":"2018-08-20T15:35:45Z","git_url":"git://github.com/worldofpeace/nixpkgs.git","ssh_url":"git@github.com:worldofpeace/nixpkgs.git","clone_url":"https://github.com/worldofpeace/nixpkgs.git","svn_url":"https://github.com/worldofpeace/nixpkgs","homepage":null,"size":824071,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"63b06d02519369ca994703a212d3b504ac143660","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-08-20T15:49:50Z","pushed_at":"2018-08-20T15:56:03Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":839220,"stargazers_count":2708,"watchers_count":2708,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2959,"mirror_url":null,"archived":false,"open_issues_count":3162,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2959,"open_issues":3162,"watchers":2708,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45306"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/45306"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/45306"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/45306/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45306/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45306/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/b464d6a8607308b1f12e593ff71f8ada2fa1261a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"worldofpeace"}}