{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/171445334","pull_request_review_id":100297329,"id":171445334,"diff_hunk":"@@ -5192,18 +5192,25 @@ func WaitForPersistentVolumeClaimDeleted(c clientset.Interface, ns string, pvcNa\n \treturn fmt.Errorf(\"PersistentVolumeClaim %s is not removed from the system within %v\", pvcName, timeout)\n }\n \n-func GetClusterZones(c clientset.Interface) (sets.String, error) {\n+func GetClusterZones(c clientset.Interface) (sets.String, error, error) {\n+\tnotfoundPartNodes := []string{}\n \tnodes, err := c.CoreV1().Nodes().List(metav1.ListOptions{})\n \tif err != nil {\n-\t\treturn nil, fmt.Errorf(\"Error getting nodes while attempting to list cluster zones: %v\", err)\n+\t\treturn nil, fmt.Errorf(\"Error getting nodes while attempting to list cluster zones: %v\", err), nil\n \t}\n \n \t// collect values of zone label from all nodes\n \tzones := sets.NewString()\n \tfor _, node := range nodes.Items {\n \t\tif zone, found := node.Labels[kubeletapis.LabelZoneFailureDomain]; found {","path":"test/e2e/framework/util.go","position":25,"original_position":25,"commit_id":"260b5336e61b368f745e06b25bf508d0650abf55","original_commit_id":"260b5336e61b368f745e06b25bf508d0650abf55","user":{"login":"hanxiaoshuai","id":30897305,"avatar_url":"https://avatars3.githubusercontent.com/u/30897305?v=4","gravatar_id":"","url":"https://api.github.com/users/hanxiaoshuai","html_url":"https://github.com/hanxiaoshuai","followers_url":"https://api.github.com/users/hanxiaoshuai/followers","following_url":"https://api.github.com/users/hanxiaoshuai/following{/other_user}","gists_url":"https://api.github.com/users/hanxiaoshuai/gists{/gist_id}","starred_url":"https://api.github.com/users/hanxiaoshuai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanxiaoshuai/subscriptions","organizations_url":"https://api.github.com/users/hanxiaoshuai/orgs","repos_url":"https://api.github.com/users/hanxiaoshuai/repos","events_url":"https://api.github.com/users/hanxiaoshuai/events{/privacy}","received_events_url":"https://api.github.com/users/hanxiaoshuai/received_events","type":"User","site_admin":false},"body":"@verult In func getZoneNameForNode when zone is not found here, it will return error right now. In func GetClusterZones even PartNode zone not found, it will not return error. So I add an error for this case.","created_at":"2018-03-01T02:03:06Z","updated_at":"2018-03-01T02:03:06Z","html_url":"https://github.com/kubernetes/kubernetes/pull/60571#discussion_r171445334","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60571","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/171445334"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/60571#discussion_r171445334"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60571"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60571","id":171895586,"html_url":"https://github.com/kubernetes/kubernetes/pull/60571","diff_url":"https://github.com/kubernetes/kubernetes/pull/60571.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/60571.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60571","number":60571,"state":"open","locked":false,"title":"fix todo: Merge func getZoneNames with framework.GetClusterZones","user":{"login":"hanxiaoshuai","id":30897305,"avatar_url":"https://avatars3.githubusercontent.com/u/30897305?v=4","gravatar_id":"","url":"https://api.github.com/users/hanxiaoshuai","html_url":"https://github.com/hanxiaoshuai","followers_url":"https://api.github.com/users/hanxiaoshuai/followers","following_url":"https://api.github.com/users/hanxiaoshuai/following{/other_user}","gists_url":"https://api.github.com/users/hanxiaoshuai/gists{/gist_id}","starred_url":"https://api.github.com/users/hanxiaoshuai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanxiaoshuai/subscriptions","organizations_url":"https://api.github.com/users/hanxiaoshuai/orgs","repos_url":"https://api.github.com/users/hanxiaoshuai/repos","events_url":"https://api.github.com/users/hanxiaoshuai/events{/privacy}","received_events_url":"https://api.github.com/users/hanxiaoshuai/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nfix todo: Merge func getZoneNames with framework.GetClusterZones\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-02-28T09:20:33Z","updated_at":"2018-03-01T02:03:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"481e5cea9162daaf3fbd0748096a89bc42683cd2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fejta","id":940341,"avatar_url":"https://avatars2.githubusercontent.com/u/940341?v=4","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},{"login":"jeffvance","id":3076896,"avatar_url":"https://avatars3.githubusercontent.com/u/3076896?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffvance","html_url":"https://github.com/jeffvance","followers_url":"https://api.github.com/users/jeffvance/followers","following_url":"https://api.github.com/users/jeffvance/following{/other_user}","gists_url":"https://api.github.com/users/jeffvance/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffvance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffvance/subscriptions","organizations_url":"https://api.github.com/users/jeffvance/orgs","repos_url":"https://api.github.com/users/jeffvance/repos","events_url":"https://api.github.com/users/jeffvance/events{/privacy}","received_events_url":"https://api.github.com/users/jeffvance/received_events","type":"User","site_admin":false},{"login":"k82cn","id":18107181,"avatar_url":"https://avatars0.githubusercontent.com/u/18107181?v=4","gravatar_id":"","url":"https://api.github.com/users/k82cn","html_url":"https://github.com/k82cn","followers_url":"https://api.github.com/users/k82cn/followers","following_url":"https://api.github.com/users/k82cn/following{/other_user}","gists_url":"https://api.github.com/users/k82cn/gists{/gist_id}","starred_url":"https://api.github.com/users/k82cn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k82cn/subscriptions","organizations_url":"https://api.github.com/users/k82cn/orgs","repos_url":"https://api.github.com/users/k82cn/repos","events_url":"https://api.github.com/users/k82cn/events{/privacy}","received_events_url":"https://api.github.com/users/k82cn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60571/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60571/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60571/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/260b5336e61b368f745e06b25bf508d0650abf55","head":{"label":"hanxiaoshuai:fixtodo02281","ref":"fixtodo02281","sha":"260b5336e61b368f745e06b25bf508d0650abf55","user":{"login":"hanxiaoshuai","id":30897305,"avatar_url":"https://avatars3.githubusercontent.com/u/30897305?v=4","gravatar_id":"","url":"https://api.github.com/users/hanxiaoshuai","html_url":"https://github.com/hanxiaoshuai","followers_url":"https://api.github.com/users/hanxiaoshuai/followers","following_url":"https://api.github.com/users/hanxiaoshuai/following{/other_user}","gists_url":"https://api.github.com/users/hanxiaoshuai/gists{/gist_id}","starred_url":"https://api.github.com/users/hanxiaoshuai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanxiaoshuai/subscriptions","organizations_url":"https://api.github.com/users/hanxiaoshuai/orgs","repos_url":"https://api.github.com/users/hanxiaoshuai/repos","events_url":"https://api.github.com/users/hanxiaoshuai/events{/privacy}","received_events_url":"https://api.github.com/users/hanxiaoshuai/received_events","type":"User","site_admin":false},"repo":{"id":99979894,"name":"kubernetes","full_name":"hanxiaoshuai/kubernetes","owner":{"login":"hanxiaoshuai","id":30897305,"avatar_url":"https://avatars3.githubusercontent.com/u/30897305?v=4","gravatar_id":"","url":"https://api.github.com/users/hanxiaoshuai","html_url":"https://github.com/hanxiaoshuai","followers_url":"https://api.github.com/users/hanxiaoshuai/followers","following_url":"https://api.github.com/users/hanxiaoshuai/following{/other_user}","gists_url":"https://api.github.com/users/hanxiaoshuai/gists{/gist_id}","starred_url":"https://api.github.com/users/hanxiaoshuai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanxiaoshuai/subscriptions","organizations_url":"https://api.github.com/users/hanxiaoshuai/orgs","repos_url":"https://api.github.com/users/hanxiaoshuai/repos","events_url":"https://api.github.com/users/hanxiaoshuai/events{/privacy}","received_events_url":"https://api.github.com/users/hanxiaoshuai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hanxiaoshuai/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/hanxiaoshuai/kubernetes","forks_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/forks","keys_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/teams","hooks_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/events","assignees_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/tags","blobs_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/languages","stargazers_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/subscription","commits_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/merges","archive_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/downloads","issues_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/hanxiaoshuai/kubernetes/deployments","created_at":"2017-08-11T01:40:20Z","updated_at":"2017-08-11T01:41:01Z","pushed_at":"2018-03-01T01:48:51Z","git_url":"git://github.com/hanxiaoshuai/kubernetes.git","ssh_url":"git@github.com:hanxiaoshuai/kubernetes.git","clone_url":"https://github.com/hanxiaoshuai/kubernetes.git","svn_url":"https://github.com/hanxiaoshuai/kubernetes","homepage":"http://kubernetes.io","size":541347,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b1ef631e5971f649effd51905444c2eeee58e8b1","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-03-01T01:53:49Z","pushed_at":"2018-03-01T01:58:15Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":760254,"stargazers_count":33049,"watchers_count":33049,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11659,"mirror_url":null,"archived":false,"open_issues_count":3779,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11659,"open_issues":3779,"watchers":33049,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60571"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/60571"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/60571"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/60571/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60571/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60571/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/260b5336e61b368f745e06b25bf508d0650abf55"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hanxiaoshuai"}}