{"action":"created","comment":{"url":"https://api.github.com/repos/hastic/hastic-server/pulls/comments/239716875","pull_request_review_id":182577652,"id":239716875,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTcxNjg3NQ==","diff_hunk":"@@ -53,7 +53,8 @@ def detect(self, dataframe: pd.DataFrame, cache: Optional[models.ModelCache]) ->\n         newCache = detected['cache']\n \n         last_dataframe_time = dataframe.iloc[-1]['timestamp']\n-        last_detection_time = last_dataframe_time.value\n+        # TODO: convert from ns to ms more proper way (not dividing by 10^6)","path":"analytics/analytics/detectors/pattern_detector.py","position":5,"original_position":5,"commit_id":"8436d03ccf023aa8a640e69a25b717d9cc1e405d","original_commit_id":"8436d03ccf023aa8a640e69a25b717d9cc1e405d","user":{"login":"jonyrock","id":1022757,"node_id":"MDQ6VXNlcjEwMjI3NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1022757?v=4","gravatar_id":"","url":"https://api.github.com/users/jonyrock","html_url":"https://github.com/jonyrock","followers_url":"https://api.github.com/users/jonyrock/followers","following_url":"https://api.github.com/users/jonyrock/following{/other_user}","gists_url":"https://api.github.com/users/jonyrock/gists{/gist_id}","starred_url":"https://api.github.com/users/jonyrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonyrock/subscriptions","organizations_url":"https://api.github.com/users/jonyrock/orgs","repos_url":"https://api.github.com/users/jonyrock/repos","events_url":"https://api.github.com/users/jonyrock/events{/privacy}","received_events_url":"https://api.github.com/users/jonyrock/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n        # TODO: convert from nanoseconds to millisecond in a better way (not dividing by 10^6)\r\n```","created_at":"2018-12-07T07:43:46Z","updated_at":"2018-12-07T07:43:46Z","html_url":"https://github.com/hastic/hastic-server/pull/305#discussion_r239716875","pull_request_url":"https://api.github.com/repos/hastic/hastic-server/pulls/305","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hastic/hastic-server/pulls/comments/239716875"},"html":{"href":"https://github.com/hastic/hastic-server/pull/305#discussion_r239716875"},"pull_request":{"href":"https://api.github.com/repos/hastic/hastic-server/pulls/305"}}},"pull_request":{"url":"https://api.github.com/repos/hastic/hastic-server/pulls/305","id":236777344,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2Nzc3MzQ0","html_url":"https://github.com/hastic/hastic-server/pull/305","diff_url":"https://github.com/hastic/hastic-server/pull/305.diff","patch_url":"https://github.com/hastic/hastic-server/pull/305.patch","issue_url":"https://api.github.com/repos/hastic/hastic-server/issues/305","number":305,"state":"open","locked":false,"title":"DataPuller: wrong from and to #304","user":{"login":"rozetko","id":1989898,"node_id":"MDQ6VXNlcjE5ODk4OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1989898?v=4","gravatar_id":"","url":"https://api.github.com/users/rozetko","html_url":"https://github.com/rozetko","followers_url":"https://api.github.com/users/rozetko/followers","following_url":"https://api.github.com/users/rozetko/following{/other_user}","gists_url":"https://api.github.com/users/rozetko/gists{/gist_id}","starred_url":"https://api.github.com/users/rozetko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozetko/subscriptions","organizations_url":"https://api.github.com/users/rozetko/orgs","repos_url":"https://api.github.com/users/rozetko/repos","events_url":"https://api.github.com/users/rozetko/events{/privacy}","received_events_url":"https://api.github.com/users/rozetko/received_events","type":"User","site_admin":false},"body":"Fixes #304 \r\n\r\nConvert lastDetectionTime from ns to ms","created_at":"2018-12-07T07:28:08Z","updated_at":"2018-12-07T07:43:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abef51924ac9f048c3a11c9e92d41e1d181c30eb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hastic/hastic-server/pulls/305/commits","review_comments_url":"https://api.github.com/repos/hastic/hastic-server/pulls/305/comments","review_comment_url":"https://api.github.com/repos/hastic/hastic-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hastic/hastic-server/issues/305/comments","statuses_url":"https://api.github.com/repos/hastic/hastic-server/statuses/8436d03ccf023aa8a640e69a25b717d9cc1e405d","head":{"label":"hastic:datapuller-wrong-from-and-to","ref":"datapuller-wrong-from-and-to","sha":"8436d03ccf023aa8a640e69a25b717d9cc1e405d","user":{"login":"hastic","id":39477570,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDc3NTcw","avatar_url":"https://avatars0.githubusercontent.com/u/39477570?v=4","gravatar_id":"","url":"https://api.github.com/users/hastic","html_url":"https://github.com/hastic","followers_url":"https://api.github.com/users/hastic/followers","following_url":"https://api.github.com/users/hastic/following{/other_user}","gists_url":"https://api.github.com/users/hastic/gists{/gist_id}","starred_url":"https://api.github.com/users/hastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hastic/subscriptions","organizations_url":"https://api.github.com/users/hastic/orgs","repos_url":"https://api.github.com/users/hastic/repos","events_url":"https://api.github.com/users/hastic/events{/privacy}","received_events_url":"https://api.github.com/users/hastic/received_events","type":"Organization","site_admin":false},"repo":{"id":134279309,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQyNzkzMDk=","name":"hastic-server","full_name":"hastic/hastic-server","private":false,"owner":{"login":"hastic","id":39477570,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDc3NTcw","avatar_url":"https://avatars0.githubusercontent.com/u/39477570?v=4","gravatar_id":"","url":"https://api.github.com/users/hastic","html_url":"https://github.com/hastic","followers_url":"https://api.github.com/users/hastic/followers","following_url":"https://api.github.com/users/hastic/following{/other_user}","gists_url":"https://api.github.com/users/hastic/gists{/gist_id}","starred_url":"https://api.github.com/users/hastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hastic/subscriptions","organizations_url":"https://api.github.com/users/hastic/orgs","repos_url":"https://api.github.com/users/hastic/repos","events_url":"https://api.github.com/users/hastic/events{/privacy}","received_events_url":"https://api.github.com/users/hastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hastic/hastic-server","description":"Server for managing data for analytics ","fork":false,"url":"https://api.github.com/repos/hastic/hastic-server","forks_url":"https://api.github.com/repos/hastic/hastic-server/forks","keys_url":"https://api.github.com/repos/hastic/hastic-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hastic/hastic-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hastic/hastic-server/teams","hooks_url":"https://api.github.com/repos/hastic/hastic-server/hooks","issue_events_url":"https://api.github.com/repos/hastic/hastic-server/issues/events{/number}","events_url":"https://api.github.com/repos/hastic/hastic-server/events","assignees_url":"https://api.github.com/repos/hastic/hastic-server/assignees{/user}","branches_url":"https://api.github.com/repos/hastic/hastic-server/branches{/branch}","tags_url":"https://api.github.com/repos/hastic/hastic-server/tags","blobs_url":"https://api.github.com/repos/hastic/hastic-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hastic/hastic-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hastic/hastic-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/hastic/hastic-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hastic/hastic-server/statuses/{sha}","languages_url":"https://api.github.com/repos/hastic/hastic-server/languages","stargazers_url":"https://api.github.com/repos/hastic/hastic-server/stargazers","contributors_url":"https://api.github.com/repos/hastic/hastic-server/contributors","subscribers_url":"https://api.github.com/repos/hastic/hastic-server/subscribers","subscription_url":"https://api.github.com/repos/hastic/hastic-server/subscription","commits_url":"https://api.github.com/repos/hastic/hastic-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/hastic/hastic-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/hastic/hastic-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/hastic/hastic-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/hastic/hastic-server/contents/{+path}","compare_url":"https://api.github.com/repos/hastic/hastic-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hastic/hastic-server/merges","archive_url":"https://api.github.com/repos/hastic/hastic-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hastic/hastic-server/downloads","issues_url":"https://api.github.com/repos/hastic/hastic-server/issues{/number}","pulls_url":"https://api.github.com/repos/hastic/hastic-server/pulls{/number}","milestones_url":"https://api.github.com/repos/hastic/hastic-server/milestones{/number}","notifications_url":"https://api.github.com/repos/hastic/hastic-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hastic/hastic-server/labels{/name}","releases_url":"https://api.github.com/repos/hastic/hastic-server/releases{/id}","deployments_url":"https://api.github.com/repos/hastic/hastic-server/deployments","created_at":"2018-05-21T14:19:25Z","updated_at":"2018-12-07T07:42:10Z","pushed_at":"2018-12-07T07:42:08Z","git_url":"git://github.com/hastic/hastic-server.git","ssh_url":"git@github.com:hastic/hastic-server.git","clone_url":"https://github.com/hastic/hastic-server.git","svn_url":"https://github.com/hastic/hastic-server","homepage":null,"size":2462,"stargazers_count":70,"watchers_count":70,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":76,"watchers":70,"default_branch":"master"}},"base":{"label":"hastic:master","ref":"master","sha":"77fbde6fa34409fc0e87577f1397a8301bfb765e","user":{"login":"hastic","id":39477570,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDc3NTcw","avatar_url":"https://avatars0.githubusercontent.com/u/39477570?v=4","gravatar_id":"","url":"https://api.github.com/users/hastic","html_url":"https://github.com/hastic","followers_url":"https://api.github.com/users/hastic/followers","following_url":"https://api.github.com/users/hastic/following{/other_user}","gists_url":"https://api.github.com/users/hastic/gists{/gist_id}","starred_url":"https://api.github.com/users/hastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hastic/subscriptions","organizations_url":"https://api.github.com/users/hastic/orgs","repos_url":"https://api.github.com/users/hastic/repos","events_url":"https://api.github.com/users/hastic/events{/privacy}","received_events_url":"https://api.github.com/users/hastic/received_events","type":"Organization","site_admin":false},"repo":{"id":134279309,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQyNzkzMDk=","name":"hastic-server","full_name":"hastic/hastic-server","private":false,"owner":{"login":"hastic","id":39477570,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDc3NTcw","avatar_url":"https://avatars0.githubusercontent.com/u/39477570?v=4","gravatar_id":"","url":"https://api.github.com/users/hastic","html_url":"https://github.com/hastic","followers_url":"https://api.github.com/users/hastic/followers","following_url":"https://api.github.com/users/hastic/following{/other_user}","gists_url":"https://api.github.com/users/hastic/gists{/gist_id}","starred_url":"https://api.github.com/users/hastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hastic/subscriptions","organizations_url":"https://api.github.com/users/hastic/orgs","repos_url":"https://api.github.com/users/hastic/repos","events_url":"https://api.github.com/users/hastic/events{/privacy}","received_events_url":"https://api.github.com/users/hastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hastic/hastic-server","description":"Server for managing data for analytics ","fork":false,"url":"https://api.github.com/repos/hastic/hastic-server","forks_url":"https://api.github.com/repos/hastic/hastic-server/forks","keys_url":"https://api.github.com/repos/hastic/hastic-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hastic/hastic-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hastic/hastic-server/teams","hooks_url":"https://api.github.com/repos/hastic/hastic-server/hooks","issue_events_url":"https://api.github.com/repos/hastic/hastic-server/issues/events{/number}","events_url":"https://api.github.com/repos/hastic/hastic-server/events","assignees_url":"https://api.github.com/repos/hastic/hastic-server/assignees{/user}","branches_url":"https://api.github.com/repos/hastic/hastic-server/branches{/branch}","tags_url":"https://api.github.com/repos/hastic/hastic-server/tags","blobs_url":"https://api.github.com/repos/hastic/hastic-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hastic/hastic-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hastic/hastic-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/hastic/hastic-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hastic/hastic-server/statuses/{sha}","languages_url":"https://api.github.com/repos/hastic/hastic-server/languages","stargazers_url":"https://api.github.com/repos/hastic/hastic-server/stargazers","contributors_url":"https://api.github.com/repos/hastic/hastic-server/contributors","subscribers_url":"https://api.github.com/repos/hastic/hastic-server/subscribers","subscription_url":"https://api.github.com/repos/hastic/hastic-server/subscription","commits_url":"https://api.github.com/repos/hastic/hastic-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/hastic/hastic-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/hastic/hastic-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/hastic/hastic-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/hastic/hastic-server/contents/{+path}","compare_url":"https://api.github.com/repos/hastic/hastic-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hastic/hastic-server/merges","archive_url":"https://api.github.com/repos/hastic/hastic-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hastic/hastic-server/downloads","issues_url":"https://api.github.com/repos/hastic/hastic-server/issues{/number}","pulls_url":"https://api.github.com/repos/hastic/hastic-server/pulls{/number}","milestones_url":"https://api.github.com/repos/hastic/hastic-server/milestones{/number}","notifications_url":"https://api.github.com/repos/hastic/hastic-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hastic/hastic-server/labels{/name}","releases_url":"https://api.github.com/repos/hastic/hastic-server/releases{/id}","deployments_url":"https://api.github.com/repos/hastic/hastic-server/deployments","created_at":"2018-05-21T14:19:25Z","updated_at":"2018-12-07T07:42:10Z","pushed_at":"2018-12-07T07:42:08Z","git_url":"git://github.com/hastic/hastic-server.git","ssh_url":"git@github.com:hastic/hastic-server.git","clone_url":"https://github.com/hastic/hastic-server.git","svn_url":"https://github.com/hastic/hastic-server","homepage":null,"size":2462,"stargazers_count":70,"watchers_count":70,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":76,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hastic/hastic-server/pulls/305"},"html":{"href":"https://github.com/hastic/hastic-server/pull/305"},"issue":{"href":"https://api.github.com/repos/hastic/hastic-server/issues/305"},"comments":{"href":"https://api.github.com/repos/hastic/hastic-server/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/hastic/hastic-server/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/hastic/hastic-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hastic/hastic-server/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/hastic/hastic-server/statuses/8436d03ccf023aa8a640e69a25b717d9cc1e405d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jonyrock"}}