{"action":"created","issue":{"url":"https://api.github.com/repos/NYPL/dgx-patron-creator-service/issues/21","repository_url":"https://api.github.com/repos/NYPL/dgx-patron-creator-service","labels_url":"https://api.github.com/repos/NYPL/dgx-patron-creator-service/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/NYPL/dgx-patron-creator-service/issues/21/comments","events_url":"https://api.github.com/repos/NYPL/dgx-patron-creator-service/issues/21/events","html_url":"https://github.com/NYPL/dgx-patron-creator-service/pull/21","id":350612275,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDIxOTY2","number":21,"title":"Fix bug with returning incorrect 503 response MLN-188","user":{"login":"LucasCioffi","id":1825103,"node_id":"MDQ6VXNlcjE4MjUxMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1825103?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasCioffi","html_url":"https://github.com/LucasCioffi","followers_url":"https://api.github.com/users/LucasCioffi/followers","following_url":"https://api.github.com/users/LucasCioffi/following{/other_user}","gists_url":"https://api.github.com/users/LucasCioffi/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasCioffi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasCioffi/subscriptions","organizations_url":"https://api.github.com/users/LucasCioffi/orgs","repos_url":"https://api.github.com/users/LucasCioffi/repos","events_url":"https://api.github.com/users/LucasCioffi/events{/privacy}","received_events_url":"https://api.github.com/users/LucasCioffi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-14T21:55:44Z","updated_at":"2018-08-15T16:47:26Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/NYPL/dgx-patron-creator-service/pulls/21","html_url":"https://github.com/NYPL/dgx-patron-creator-service/pull/21","diff_url":"https://github.com/NYPL/dgx-patron-creator-service/pull/21.diff","patch_url":"https://github.com/NYPL/dgx-patron-creator-service/pull/21.patch"},"body":"Previously the Patron Creator Service returned a 503 to the API consumer, saying the ILS was unavailable, when it should have returned a 400 if it was given incorrect JSON.\r\n\r\nHere's the new, correct response that it returns when the patronCodes are misformatted:\r\n```\r\n{\"status_code_from_ils\"=>400, \"type\"=>\"\", \"message\"=>{\"code\"=>115, \"specificCode\"=>0, \"httpStatus\"=>400, \"name\"=>\"Invalid JSON\", \"description\"=>\"Invalid JSON : field(s) unknown : patronCodes.\"}, \"detail\"=>{\"title\"=>\"\", \"debug\"=>{}}, \"level\"=>\"Error\", \"level_code\"=>3, \"timestamp\"=>\"2018-08-14T15:12:58-04:00\"}\r\n```"},"comment":{"url":"https://api.github.com/repos/NYPL/dgx-patron-creator-service/issues/comments/413259496","html_url":"https://github.com/NYPL/dgx-patron-creator-service/pull/21#issuecomment-413259496","issue_url":"https://api.github.com/repos/NYPL/dgx-patron-creator-service/issues/21","id":413259496,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzI1OTQ5Ng==","user":{"login":"LucasCioffi","id":1825103,"node_id":"MDQ6VXNlcjE4MjUxMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1825103?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasCioffi","html_url":"https://github.com/LucasCioffi","followers_url":"https://api.github.com/users/LucasCioffi/followers","following_url":"https://api.github.com/users/LucasCioffi/following{/other_user}","gists_url":"https://api.github.com/users/LucasCioffi/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasCioffi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasCioffi/subscriptions","organizations_url":"https://api.github.com/users/LucasCioffi/orgs","repos_url":"https://api.github.com/users/LucasCioffi/repos","events_url":"https://api.github.com/users/LucasCioffi/events{/privacy}","received_events_url":"https://api.github.com/users/LucasCioffi/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T16:47:26Z","updated_at":"2018-08-15T16:47:26Z","author_association":"COLLABORATOR","body":"@daryanypl @nnat425 this is the PR with the most priority, because it helps us do end-to-end testing from the form to the MailListener with the latest data the form is sending over."}}
{"actor":{"display_login":"LucasCioffi"}}