{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/235712507","pull_request_review_id":177640528,"id":235712507,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTcxMjUwNw==","diff_hunk":"@@ -0,0 +1,21 @@\n+#!/usr/bin/env bash\n+\n+set -e\n+\n+cd frontend\n+\n+if [ `uname` != \"FreeBSD\" ]; then\n+  . $CEPH_ROOT/build/src/pybind/mgr/dashboard/node-env/bin/activate ||\n+  echo 'Info: missing node-env'\n+fi\n+\n+npm run i18n\n+\n+count=`git status | grep \"messages.xlf\" -c`","path":"src/pybind/mgr/dashboard/run-frontend-i18n.sh","position":14,"original_position":14,"commit_id":"bb4329b1816f280ef325ba7b603f8ea4535f3c1e","original_commit_id":"bb4329b1816f280ef325ba7b603f8ea4535f3c1e","user":{"login":"LenzGr","id":263427,"node_id":"MDQ6VXNlcjI2MzQyNw==","avatar_url":"https://avatars3.githubusercontent.com/u/263427?v=4","gravatar_id":"","url":"https://api.github.com/users/LenzGr","html_url":"https://github.com/LenzGr","followers_url":"https://api.github.com/users/LenzGr/followers","following_url":"https://api.github.com/users/LenzGr/following{/other_user}","gists_url":"https://api.github.com/users/LenzGr/gists{/gist_id}","starred_url":"https://api.github.com/users/LenzGr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LenzGr/subscriptions","organizations_url":"https://api.github.com/users/LenzGr/orgs","repos_url":"https://api.github.com/users/LenzGr/repos","events_url":"https://api.github.com/users/LenzGr/events{/privacy}","received_events_url":"https://api.github.com/users/LenzGr/received_events","type":"User","site_admin":false},"body":"This looks somewhat brittle. Wouldn't it be better to use git to check the modification status of this file directly, e.g. via `git status -s messages.xlf`","created_at":"2018-11-22T12:43:56Z","updated_at":"2018-11-22T12:43:56Z","html_url":"https://github.com/ceph/ceph/pull/25179#discussion_r235712507","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/25179","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/235712507"},"html":{"href":"https://github.com/ceph/ceph/pull/25179#discussion_r235712507"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25179"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/25179","id":232253678,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMjUzNjc4","html_url":"https://github.com/ceph/ceph/pull/25179","diff_url":"https://github.com/ceph/ceph/pull/25179.diff","patch_url":"https://github.com/ceph/ceph/pull/25179.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/25179","number":25179,"state":"open","locked":false,"title":"mgr/dashboard: Add i18n validation script","user":{"login":"tspmelo","id":399326,"node_id":"MDQ6VXNlcjM5OTMyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/399326?v=4","gravatar_id":"","url":"https://api.github.com/users/tspmelo","html_url":"https://github.com/tspmelo","followers_url":"https://api.github.com/users/tspmelo/followers","following_url":"https://api.github.com/users/tspmelo/following{/other_user}","gists_url":"https://api.github.com/users/tspmelo/gists{/gist_id}","starred_url":"https://api.github.com/users/tspmelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspmelo/subscriptions","organizations_url":"https://api.github.com/users/tspmelo/orgs","repos_url":"https://api.github.com/users/tspmelo/repos","events_url":"https://api.github.com/users/tspmelo/events{/privacy}","received_events_url":"https://api.github.com/users/tspmelo/received_events","type":"User","site_admin":false},"body":"This will check if there are new strings and ask the developer to commit those.\r\n\r\n`Signed-off-by: Tiago Melo <tmelo@suse.com>`","created_at":"2018-11-20T09:55:26Z","updated_at":"2018-11-22T12:43:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3592c68e7413da2ea8ddbf9279b8d37e093e38b4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":199293022,"node_id":"MDU6TGFiZWwxOTkyOTMwMjI=","url":"https://api.github.com/repos/ceph/ceph/labels/build/ops","name":"build/ops","color":"fcff00","default":false},{"id":850326757,"node_id":"MDU6TGFiZWw4NTAzMjY3NTc=","url":"https://api.github.com/repos/ceph/ceph/labels/dashboard","name":"dashboard","color":"68a2c1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/25179/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/25179/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/25179/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/bb4329b1816f280ef325ba7b603f8ea4535f3c1e","head":{"label":"tspmelo:wip-check-i18n","ref":"wip-check-i18n","sha":"bb4329b1816f280ef325ba7b603f8ea4535f3c1e","user":{"login":"tspmelo","id":399326,"node_id":"MDQ6VXNlcjM5OTMyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/399326?v=4","gravatar_id":"","url":"https://api.github.com/users/tspmelo","html_url":"https://github.com/tspmelo","followers_url":"https://api.github.com/users/tspmelo/followers","following_url":"https://api.github.com/users/tspmelo/following{/other_user}","gists_url":"https://api.github.com/users/tspmelo/gists{/gist_id}","starred_url":"https://api.github.com/users/tspmelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspmelo/subscriptions","organizations_url":"https://api.github.com/users/tspmelo/orgs","repos_url":"https://api.github.com/users/tspmelo/repos","events_url":"https://api.github.com/users/tspmelo/events{/privacy}","received_events_url":"https://api.github.com/users/tspmelo/received_events","type":"User","site_admin":false},"repo":{"id":116847827,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4NDc4Mjc=","name":"ceph","full_name":"tspmelo/ceph","private":false,"owner":{"login":"tspmelo","id":399326,"node_id":"MDQ6VXNlcjM5OTMyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/399326?v=4","gravatar_id":"","url":"https://api.github.com/users/tspmelo","html_url":"https://github.com/tspmelo","followers_url":"https://api.github.com/users/tspmelo/followers","following_url":"https://api.github.com/users/tspmelo/following{/other_user}","gists_url":"https://api.github.com/users/tspmelo/gists{/gist_id}","starred_url":"https://api.github.com/users/tspmelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspmelo/subscriptions","organizations_url":"https://api.github.com/users/tspmelo/orgs","repos_url":"https://api.github.com/users/tspmelo/repos","events_url":"https://api.github.com/users/tspmelo/events{/privacy}","received_events_url":"https://api.github.com/users/tspmelo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tspmelo/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/tspmelo/ceph","forks_url":"https://api.github.com/repos/tspmelo/ceph/forks","keys_url":"https://api.github.com/repos/tspmelo/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tspmelo/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tspmelo/ceph/teams","hooks_url":"https://api.github.com/repos/tspmelo/ceph/hooks","issue_events_url":"https://api.github.com/repos/tspmelo/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/tspmelo/ceph/events","assignees_url":"https://api.github.com/repos/tspmelo/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/tspmelo/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/tspmelo/ceph/tags","blobs_url":"https://api.github.com/repos/tspmelo/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tspmelo/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tspmelo/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/tspmelo/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tspmelo/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/tspmelo/ceph/languages","stargazers_url":"https://api.github.com/repos/tspmelo/ceph/stargazers","contributors_url":"https://api.github.com/repos/tspmelo/ceph/contributors","subscribers_url":"https://api.github.com/repos/tspmelo/ceph/subscribers","subscription_url":"https://api.github.com/repos/tspmelo/ceph/subscription","commits_url":"https://api.github.com/repos/tspmelo/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/tspmelo/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/tspmelo/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/tspmelo/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/tspmelo/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/tspmelo/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tspmelo/ceph/merges","archive_url":"https://api.github.com/repos/tspmelo/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tspmelo/ceph/downloads","issues_url":"https://api.github.com/repos/tspmelo/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/tspmelo/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/tspmelo/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/tspmelo/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tspmelo/ceph/labels{/name}","releases_url":"https://api.github.com/repos/tspmelo/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/tspmelo/ceph/deployments","created_at":"2018-01-09T17:26:17Z","updated_at":"2018-11-05T12:25:21Z","pushed_at":"2018-11-22T11:39:36Z","git_url":"git://github.com/tspmelo/ceph.git","ssh_url":"git@github.com:tspmelo/ceph.git","clone_url":"https://github.com/tspmelo/ceph.git","svn_url":"https://github.com/tspmelo/ceph","homepage":"http://ceph.com","size":324082,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"c881d63a6946ce55835c57c96ad99315668e5ed4","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-11-22T09:55:41Z","pushed_at":"2018-11-22T12:10:14Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":333933,"stargazers_count":5294,"watchers_count":5294,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2793,"mirror_url":null,"archived":false,"open_issues_count":624,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2793,"open_issues":624,"watchers":5294,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25179"},"html":{"href":"https://github.com/ceph/ceph/pull/25179"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/25179"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/25179/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25179/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25179/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/bb4329b1816f280ef325ba7b603f8ea4535f3c1e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"LenzGr"}}