{"action":"created","comment":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/214349652","pull_request_review_id":151389775,"id":214349652,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDM0OTY1Mg==","diff_hunk":"@@ -88,9 +98,35 @@ void AboutWindow::set_version_string()\n             .arg(Appleseed::get_lib_compilation_date())\n             .arg(Appleseed::get_lib_compilation_time())\n             .arg(Compiler::get_compiler_name())\n-            .arg(Compiler::get_compiler_version());\n-\n-    m_ui->label_version_string->setText(version_string);\n+            .arg(Compiler::get_compiler_version()));\n+\n+    LibraryVersionArray versions = ThirdParties::get_versions();\n+    versions.push_back(APIStringPair(\"Qt\", QT_VERSION_STR));\n+\n+    // Create a vector of indices into `versions` to allow enumerating libraries in sorted order.\n+    vector<size_t> versions_indices(versions.size());\n+    for (size_t i = 0, e = versions.size(); i < e; ++i)\n+        versions_indices[i] = i;\n+    sort(\n+        versions_indices.begin(),\n+        versions_indices.end(),\n+        [&versions](const size_t lhs, const size_t rhs)\n+        {\n+            return strcmp(versions[lhs].m_first.c_str(), versions[rhs].m_first.c_str()) < 0;\n+        });","path":"src/appleseed.studio/help/about/aboutwindow.cpp","position":69,"original_position":69,"commit_id":"89c366d67d290a68c8d5922a5920111b5cc964f8","original_commit_id":"89c366d67d290a68c8d5922a5920111b5cc964f8","user":{"login":"dictoon","id":321290,"node_id":"MDQ6VXNlcjMyMTI5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/321290?v=4","gravatar_id":"","url":"https://api.github.com/users/dictoon","html_url":"https://github.com/dictoon","followers_url":"https://api.github.com/users/dictoon/followers","following_url":"https://api.github.com/users/dictoon/following{/other_user}","gists_url":"https://api.github.com/users/dictoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dictoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dictoon/subscriptions","organizations_url":"https://api.github.com/users/dictoon/orgs","repos_url":"https://api.github.com/users/dictoon/repos","events_url":"https://api.github.com/users/dictoon/events{/privacy}","received_events_url":"https://api.github.com/users/dictoon/received_events","type":"User","site_admin":false},"body":"`ThirdParties::get_versions()` returns a sorted list, but since I then append Qt to that list, the list needs to be sorted. I don't see any other option at the moment, except if one knows how to call `std::sort()` on a custom container such as `foundation::APIArray` which only provides index-based access.","created_at":"2018-08-31T13:17:00Z","updated_at":"2018-08-31T13:17:00Z","html_url":"https://github.com/appleseedhq/appleseed/pull/2186#discussion_r214349652","pull_request_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2186","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/214349652"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/2186#discussion_r214349652"},"pull_request":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2186"}},"in_reply_to_id":214348709},"pull_request":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2186","id":212373381,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMzczMzgx","html_url":"https://github.com/appleseedhq/appleseed/pull/2186","diff_url":"https://github.com/appleseedhq/appleseed/pull/2186.diff","patch_url":"https://github.com/appleseedhq/appleseed/pull/2186.patch","issue_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/2186","number":2186,"state":"open","locked":false,"title":"Add third party libraries versions to appleseed.studio's About dialog","user":{"login":"dictoon","id":321290,"node_id":"MDQ6VXNlcjMyMTI5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/321290?v=4","gravatar_id":"","url":"https://api.github.com/users/dictoon","html_url":"https://github.com/dictoon","followers_url":"https://api.github.com/users/dictoon/followers","following_url":"https://api.github.com/users/dictoon/following{/other_user}","gists_url":"https://api.github.com/users/dictoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dictoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dictoon/subscriptions","organizations_url":"https://api.github.com/users/dictoon/orgs","repos_url":"https://api.github.com/users/dictoon/repos","events_url":"https://api.github.com/users/dictoon/events{/privacy}","received_events_url":"https://api.github.com/users/dictoon/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-31T12:51:15Z","updated_at":"2018-08-31T13:17:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db4dc1f770b605e01068e61bff18bbcf1b6aef13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2186/commits","review_comments_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2186/comments","review_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/2186/comments","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/89c366d67d290a68c8d5922a5920111b5cc964f8","head":{"label":"dictoon:master","ref":"master","sha":"89c366d67d290a68c8d5922a5920111b5cc964f8","user":{"login":"dictoon","id":321290,"node_id":"MDQ6VXNlcjMyMTI5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/321290?v=4","gravatar_id":"","url":"https://api.github.com/users/dictoon","html_url":"https://github.com/dictoon","followers_url":"https://api.github.com/users/dictoon/followers","following_url":"https://api.github.com/users/dictoon/following{/other_user}","gists_url":"https://api.github.com/users/dictoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dictoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dictoon/subscriptions","organizations_url":"https://api.github.com/users/dictoon/orgs","repos_url":"https://api.github.com/users/dictoon/repos","events_url":"https://api.github.com/users/dictoon/events{/privacy}","received_events_url":"https://api.github.com/users/dictoon/received_events","type":"User","site_admin":false},"repo":{"id":4123945,"node_id":"MDEwOlJlcG9zaXRvcnk0MTIzOTQ1","name":"appleseed","full_name":"dictoon/appleseed","owner":{"login":"dictoon","id":321290,"node_id":"MDQ6VXNlcjMyMTI5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/321290?v=4","gravatar_id":"","url":"https://api.github.com/users/dictoon","html_url":"https://github.com/dictoon","followers_url":"https://api.github.com/users/dictoon/followers","following_url":"https://api.github.com/users/dictoon/following{/other_user}","gists_url":"https://api.github.com/users/dictoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dictoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dictoon/subscriptions","organizations_url":"https://api.github.com/users/dictoon/orgs","repos_url":"https://api.github.com/users/dictoon/repos","events_url":"https://api.github.com/users/dictoon/events{/privacy}","received_events_url":"https://api.github.com/users/dictoon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dictoon/appleseed","description":"appleseed is a modern, physically-based production renderer.","fork":true,"url":"https://api.github.com/repos/dictoon/appleseed","forks_url":"https://api.github.com/repos/dictoon/appleseed/forks","keys_url":"https://api.github.com/repos/dictoon/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dictoon/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dictoon/appleseed/teams","hooks_url":"https://api.github.com/repos/dictoon/appleseed/hooks","issue_events_url":"https://api.github.com/repos/dictoon/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/dictoon/appleseed/events","assignees_url":"https://api.github.com/repos/dictoon/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/dictoon/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/dictoon/appleseed/tags","blobs_url":"https://api.github.com/repos/dictoon/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dictoon/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dictoon/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/dictoon/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dictoon/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/dictoon/appleseed/languages","stargazers_url":"https://api.github.com/repos/dictoon/appleseed/stargazers","contributors_url":"https://api.github.com/repos/dictoon/appleseed/contributors","subscribers_url":"https://api.github.com/repos/dictoon/appleseed/subscribers","subscription_url":"https://api.github.com/repos/dictoon/appleseed/subscription","commits_url":"https://api.github.com/repos/dictoon/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/dictoon/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/dictoon/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/dictoon/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/dictoon/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/dictoon/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dictoon/appleseed/merges","archive_url":"https://api.github.com/repos/dictoon/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dictoon/appleseed/downloads","issues_url":"https://api.github.com/repos/dictoon/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/dictoon/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/dictoon/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/dictoon/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dictoon/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/dictoon/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/dictoon/appleseed/deployments","created_at":"2012-04-24T11:33:54Z","updated_at":"2018-08-31T12:50:48Z","pushed_at":"2018-08-31T12:50:45Z","git_url":"git://github.com/dictoon/appleseed.git","ssh_url":"git@github.com:dictoon/appleseed.git","clone_url":"https://github.com/dictoon/appleseed.git","svn_url":"https://github.com/dictoon/appleseed","homepage":"http://appleseedhq.net/","size":1260289,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"appleseedhq:master","ref":"master","sha":"4e34eb22986c51f946d6b8d79736d84ca1ec31af","user":{"login":"appleseedhq","id":6373510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNzM1MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":753784,"node_id":"MDEwOlJlcG9zaXRvcnk3NTM3ODQ=","name":"appleseed","full_name":"appleseedhq/appleseed","owner":{"login":"appleseedhq","id":6373510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNzM1MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appleseedhq/appleseed","description":"A modern open source rendering engine for animation and visual effects","fork":false,"url":"https://api.github.com/repos/appleseedhq/appleseed","forks_url":"https://api.github.com/repos/appleseedhq/appleseed/forks","keys_url":"https://api.github.com/repos/appleseedhq/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleseedhq/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleseedhq/appleseed/teams","hooks_url":"https://api.github.com/repos/appleseedhq/appleseed/hooks","issue_events_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/appleseedhq/appleseed/events","assignees_url":"https://api.github.com/repos/appleseedhq/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/appleseedhq/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/appleseedhq/appleseed/tags","blobs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleseedhq/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleseedhq/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/appleseedhq/appleseed/languages","stargazers_url":"https://api.github.com/repos/appleseedhq/appleseed/stargazers","contributors_url":"https://api.github.com/repos/appleseedhq/appleseed/contributors","subscribers_url":"https://api.github.com/repos/appleseedhq/appleseed/subscribers","subscription_url":"https://api.github.com/repos/appleseedhq/appleseed/subscription","commits_url":"https://api.github.com/repos/appleseedhq/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleseedhq/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/appleseedhq/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/appleseedhq/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleseedhq/appleseed/merges","archive_url":"https://api.github.com/repos/appleseedhq/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleseedhq/appleseed/downloads","issues_url":"https://api.github.com/repos/appleseedhq/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/appleseedhq/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/appleseedhq/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleseedhq/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/appleseedhq/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/appleseedhq/appleseed/deployments","created_at":"2010-07-02T16:33:51Z","updated_at":"2018-08-31T02:31:01Z","pushed_at":"2018-08-31T12:51:15Z","git_url":"git://github.com/appleseedhq/appleseed.git","ssh_url":"git@github.com:appleseedhq/appleseed.git","clone_url":"https://github.com/appleseedhq/appleseed.git","svn_url":"https://github.com/appleseedhq/appleseed","homepage":"https://appleseedhq.net/","size":1260211,"stargazers_count":1047,"watchers_count":1047,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":193,"mirror_url":null,"archived":false,"open_issues_count":350,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":193,"open_issues":350,"watchers":1047,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2186"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/2186"},"issue":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/2186"},"comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/2186/comments"},"review_comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2186/comments"},"review_comment":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2186/commits"},"statuses":{"href":"https://api.github.com/repos/appleseedhq/appleseed/statuses/89c366d67d290a68c8d5922a5920111b5cc964f8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dictoon"}}