{"action":"created","comment":{"url":"https://api.github.com/repos/cloudtools/stacker/pulls/comments/192571067","pull_request_review_id":125377518,"id":192571067,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjU3MTA2Nw==","diff_hunk":"@@ -119,9 +122,9 @@ def test_downstream():\n \n @with_setup(start_with_graph)\n def test_all_downstreams():\n-    assert dag.all_downstreams('a') == ['c', 'b', 'd']\n-    assert dag.all_downstreams('b') == ['d']\n-    assert dag.all_downstreams('d') == []\n+    assert set(dag.all_downstreams('a')) == set(['c', 'b', 'd'])","path":"stacker/tests/test_dag.py","position":15,"original_position":15,"commit_id":"71857c4eb6f927099abe4bd4f36479aaa95502c1","original_commit_id":"71857c4eb6f927099abe4bd4f36479aaa95502c1","user":{"login":"xiaket","id":171967,"node_id":"MDQ6VXNlcjE3MTk2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/171967?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaket","html_url":"https://github.com/xiaket","followers_url":"https://api.github.com/users/xiaket/followers","following_url":"https://api.github.com/users/xiaket/following{/other_user}","gists_url":"https://api.github.com/users/xiaket/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaket/subscriptions","organizations_url":"https://api.github.com/users/xiaket/orgs","repos_url":"https://api.github.com/users/xiaket/repos","events_url":"https://api.github.com/users/xiaket/events{/privacy}","received_events_url":"https://api.github.com/users/xiaket/received_events","type":"User","site_admin":false},"body":"Yeah, you are right, this change was made when I was running the test code and I do have seen `dag.all_downstreams('a')` turned into `['b', 'c', 'd']`, which failed the test. I apologize because I haven't dug deep enough to see what's going on and used `set` to mute the failure.\r\n\r\nI'll look into this.","created_at":"2018-06-02T21:37:46Z","updated_at":"2018-06-02T21:37:46Z","html_url":"https://github.com/cloudtools/stacker/pull/600#discussion_r192571067","pull_request_url":"https://api.github.com/repos/cloudtools/stacker/pulls/600","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cloudtools/stacker/pulls/comments/192571067"},"html":{"href":"https://github.com/cloudtools/stacker/pull/600#discussion_r192571067"},"pull_request":{"href":"https://api.github.com/repos/cloudtools/stacker/pulls/600"}},"in_reply_to_id":192564487},"pull_request":{"url":"https://api.github.com/repos/cloudtools/stacker/pulls/600","id":189195841,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MTk1ODQx","html_url":"https://github.com/cloudtools/stacker/pull/600","diff_url":"https://github.com/cloudtools/stacker/pull/600.diff","patch_url":"https://github.com/cloudtools/stacker/pull/600.patch","issue_url":"https://api.github.com/repos/cloudtools/stacker/issues/600","number":600,"state":"open","locked":false,"title":"Python3 support","user":{"login":"xiaket","id":171967,"node_id":"MDQ6VXNlcjE3MTk2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/171967?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaket","html_url":"https://github.com/xiaket","followers_url":"https://api.github.com/users/xiaket/followers","following_url":"https://api.github.com/users/xiaket/following{/other_user}","gists_url":"https://api.github.com/users/xiaket/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaket/subscriptions","organizations_url":"https://api.github.com/users/xiaket/orgs","repos_url":"https://api.github.com/users/xiaket/repos","events_url":"https://api.github.com/users/xiaket/events{/privacy}","received_events_url":"https://api.github.com/users/xiaket/received_events","type":"User","site_admin":false},"body":"Hi everyone, \r\n\r\nThis is at this stage an **EARLY EXPERIMENTAL** PR for python3 support. All unit tests passed locally both in Python 2.7.14 and 3.6.5.\r\n\r\nI've utilized [future](http://python-future.org) do the stupid changes, and it's part of the stacker code base now. In future, if we want to drop python2 support, we can simply remove it from our code base.\r\n\r\nTo make it easier to run the tests in 2 environments, I've created two virtual environments and they are managed by a bash script embedded in this PR. Here's a little help for the script(`manage`) here:\r\n\r\nTo run a linting test for python2: `./manage lint2` (or `./manage l2` for short)\r\nTo run a nose test for python3: `./manage nose3` (or `./manage n3` for short)\r\nTo run everything: `./manage run`\r\n\r\nIt's a handy tool created to make the development easier. Technically, it should not be a part of this PR, but for now, I decide to let it in so you do not have to set up a test environment.\r\n\r\nThis is a huge PR, I've tried my best to make each commit atomic, and I hope I've explained the rationale for the change in the commit message. If you have any questions, just leave a message here or shoot me a message on Slack. Thanks.","created_at":"2018-05-19T16:35:08Z","updated_at":"2018-06-02T21:37:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"051d902a2036a612ac52ebeaf4ebc84632df5f0d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudtools/stacker/pulls/600/commits","review_comments_url":"https://api.github.com/repos/cloudtools/stacker/pulls/600/comments","review_comment_url":"https://api.github.com/repos/cloudtools/stacker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudtools/stacker/issues/600/comments","statuses_url":"https://api.github.com/repos/cloudtools/stacker/statuses/71857c4eb6f927099abe4bd4f36479aaa95502c1","head":{"label":"xiaket:python3","ref":"python3","sha":"71857c4eb6f927099abe4bd4f36479aaa95502c1","user":{"login":"xiaket","id":171967,"node_id":"MDQ6VXNlcjE3MTk2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/171967?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaket","html_url":"https://github.com/xiaket","followers_url":"https://api.github.com/users/xiaket/followers","following_url":"https://api.github.com/users/xiaket/following{/other_user}","gists_url":"https://api.github.com/users/xiaket/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaket/subscriptions","organizations_url":"https://api.github.com/users/xiaket/orgs","repos_url":"https://api.github.com/users/xiaket/repos","events_url":"https://api.github.com/users/xiaket/events{/privacy}","received_events_url":"https://api.github.com/users/xiaket/received_events","type":"User","site_admin":false},"repo":{"id":109092289,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkwOTIyODk=","name":"stacker","full_name":"xiaket/stacker","owner":{"login":"xiaket","id":171967,"node_id":"MDQ6VXNlcjE3MTk2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/171967?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaket","html_url":"https://github.com/xiaket","followers_url":"https://api.github.com/users/xiaket/followers","following_url":"https://api.github.com/users/xiaket/following{/other_user}","gists_url":"https://api.github.com/users/xiaket/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaket/subscriptions","organizations_url":"https://api.github.com/users/xiaket/orgs","repos_url":"https://api.github.com/users/xiaket/repos","events_url":"https://api.github.com/users/xiaket/events{/privacy}","received_events_url":"https://api.github.com/users/xiaket/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiaket/stacker","description":"An AWS CloudFormation Stack orchestrator/manager.","fork":true,"url":"https://api.github.com/repos/xiaket/stacker","forks_url":"https://api.github.com/repos/xiaket/stacker/forks","keys_url":"https://api.github.com/repos/xiaket/stacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiaket/stacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiaket/stacker/teams","hooks_url":"https://api.github.com/repos/xiaket/stacker/hooks","issue_events_url":"https://api.github.com/repos/xiaket/stacker/issues/events{/number}","events_url":"https://api.github.com/repos/xiaket/stacker/events","assignees_url":"https://api.github.com/repos/xiaket/stacker/assignees{/user}","branches_url":"https://api.github.com/repos/xiaket/stacker/branches{/branch}","tags_url":"https://api.github.com/repos/xiaket/stacker/tags","blobs_url":"https://api.github.com/repos/xiaket/stacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiaket/stacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiaket/stacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiaket/stacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiaket/stacker/statuses/{sha}","languages_url":"https://api.github.com/repos/xiaket/stacker/languages","stargazers_url":"https://api.github.com/repos/xiaket/stacker/stargazers","contributors_url":"https://api.github.com/repos/xiaket/stacker/contributors","subscribers_url":"https://api.github.com/repos/xiaket/stacker/subscribers","subscription_url":"https://api.github.com/repos/xiaket/stacker/subscription","commits_url":"https://api.github.com/repos/xiaket/stacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiaket/stacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiaket/stacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiaket/stacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiaket/stacker/contents/{+path}","compare_url":"https://api.github.com/repos/xiaket/stacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiaket/stacker/merges","archive_url":"https://api.github.com/repos/xiaket/stacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiaket/stacker/downloads","issues_url":"https://api.github.com/repos/xiaket/stacker/issues{/number}","pulls_url":"https://api.github.com/repos/xiaket/stacker/pulls{/number}","milestones_url":"https://api.github.com/repos/xiaket/stacker/milestones{/number}","notifications_url":"https://api.github.com/repos/xiaket/stacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiaket/stacker/labels{/name}","releases_url":"https://api.github.com/repos/xiaket/stacker/releases{/id}","deployments_url":"https://api.github.com/repos/xiaket/stacker/deployments","created_at":"2017-11-01T05:49:43Z","updated_at":"2018-05-17T23:04:33Z","pushed_at":"2018-05-28T03:38:13Z","git_url":"git://github.com/xiaket/stacker.git","ssh_url":"git@github.com:xiaket/stacker.git","clone_url":"https://github.com/xiaket/stacker.git","svn_url":"https://github.com/xiaket/stacker","homepage":"http://stacker.readthedocs.io/en/stable/","size":1853,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudtools:master","ref":"master","sha":"1884913f15089dcec6fc17deabb2154c0d2effc0","user":{"login":"cloudtools","id":3028687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjg2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/3028687?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudtools","html_url":"https://github.com/cloudtools","followers_url":"https://api.github.com/users/cloudtools/followers","following_url":"https://api.github.com/users/cloudtools/following{/other_user}","gists_url":"https://api.github.com/users/cloudtools/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudtools/subscriptions","organizations_url":"https://api.github.com/users/cloudtools/orgs","repos_url":"https://api.github.com/users/cloudtools/repos","events_url":"https://api.github.com/users/cloudtools/events{/privacy}","received_events_url":"https://api.github.com/users/cloudtools/received_events","type":"Organization","site_admin":false},"repo":{"id":28885080,"node_id":"MDEwOlJlcG9zaXRvcnkyODg4NTA4MA==","name":"stacker","full_name":"cloudtools/stacker","owner":{"login":"cloudtools","id":3028687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjg2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/3028687?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudtools","html_url":"https://github.com/cloudtools","followers_url":"https://api.github.com/users/cloudtools/followers","following_url":"https://api.github.com/users/cloudtools/following{/other_user}","gists_url":"https://api.github.com/users/cloudtools/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudtools/subscriptions","organizations_url":"https://api.github.com/users/cloudtools/orgs","repos_url":"https://api.github.com/users/cloudtools/repos","events_url":"https://api.github.com/users/cloudtools/events{/privacy}","received_events_url":"https://api.github.com/users/cloudtools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudtools/stacker","description":"An AWS CloudFormation Stack orchestrator/manager.","fork":false,"url":"https://api.github.com/repos/cloudtools/stacker","forks_url":"https://api.github.com/repos/cloudtools/stacker/forks","keys_url":"https://api.github.com/repos/cloudtools/stacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudtools/stacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudtools/stacker/teams","hooks_url":"https://api.github.com/repos/cloudtools/stacker/hooks","issue_events_url":"https://api.github.com/repos/cloudtools/stacker/issues/events{/number}","events_url":"https://api.github.com/repos/cloudtools/stacker/events","assignees_url":"https://api.github.com/repos/cloudtools/stacker/assignees{/user}","branches_url":"https://api.github.com/repos/cloudtools/stacker/branches{/branch}","tags_url":"https://api.github.com/repos/cloudtools/stacker/tags","blobs_url":"https://api.github.com/repos/cloudtools/stacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudtools/stacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudtools/stacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudtools/stacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudtools/stacker/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudtools/stacker/languages","stargazers_url":"https://api.github.com/repos/cloudtools/stacker/stargazers","contributors_url":"https://api.github.com/repos/cloudtools/stacker/contributors","subscribers_url":"https://api.github.com/repos/cloudtools/stacker/subscribers","subscription_url":"https://api.github.com/repos/cloudtools/stacker/subscription","commits_url":"https://api.github.com/repos/cloudtools/stacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudtools/stacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudtools/stacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudtools/stacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudtools/stacker/contents/{+path}","compare_url":"https://api.github.com/repos/cloudtools/stacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudtools/stacker/merges","archive_url":"https://api.github.com/repos/cloudtools/stacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudtools/stacker/downloads","issues_url":"https://api.github.com/repos/cloudtools/stacker/issues{/number}","pulls_url":"https://api.github.com/repos/cloudtools/stacker/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudtools/stacker/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudtools/stacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudtools/stacker/labels{/name}","releases_url":"https://api.github.com/repos/cloudtools/stacker/releases{/id}","deployments_url":"https://api.github.com/repos/cloudtools/stacker/deployments","created_at":"2015-01-06T21:46:05Z","updated_at":"2018-06-02T19:12:59Z","pushed_at":"2018-06-02T19:12:55Z","git_url":"git://github.com/cloudtools/stacker.git","ssh_url":"git@github.com:cloudtools/stacker.git","clone_url":"https://github.com/cloudtools/stacker.git","svn_url":"https://github.com/cloudtools/stacker","homepage":"http://stacker.readthedocs.io/en/stable/","size":1764,"stargazers_count":349,"watchers_count":349,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":97,"open_issues":56,"watchers":349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudtools/stacker/pulls/600"},"html":{"href":"https://github.com/cloudtools/stacker/pull/600"},"issue":{"href":"https://api.github.com/repos/cloudtools/stacker/issues/600"},"comments":{"href":"https://api.github.com/repos/cloudtools/stacker/issues/600/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudtools/stacker/pulls/600/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudtools/stacker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudtools/stacker/pulls/600/commits"},"statuses":{"href":"https://api.github.com/repos/cloudtools/stacker/statuses/71857c4eb6f927099abe4bd4f36479aaa95502c1"}},"author_association":"NONE"}}
{"actor":{"display_login":"xiaket"}}