{"action":"opened","number":1056,"pull_request":{"url":"https://api.github.com/repos/potatolondon/djangae/pulls/1056","id":190063578,"html_url":"https://github.com/potatolondon/djangae/pull/1056","diff_url":"https://github.com/potatolondon/djangae/pull/1056.diff","patch_url":"https://github.com/potatolondon/djangae/pull/1056.patch","issue_url":"https://api.github.com/repos/potatolondon/djangae/issues/1056","number":1056,"state":"open","locked":false,"title":"1055 import error","user":{"login":"davidwtbuxton","id":334087,"avatar_url":"https://avatars2.githubusercontent.com/u/334087?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwtbuxton","html_url":"https://github.com/davidwtbuxton","followers_url":"https://api.github.com/users/davidwtbuxton/followers","following_url":"https://api.github.com/users/davidwtbuxton/following{/other_user}","gists_url":"https://api.github.com/users/davidwtbuxton/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwtbuxton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwtbuxton/subscriptions","organizations_url":"https://api.github.com/users/davidwtbuxton/orgs","repos_url":"https://api.github.com/users/davidwtbuxton/repos","events_url":"https://api.github.com/users/davidwtbuxton/events{/privacy}","received_events_url":"https://api.github.com/users/davidwtbuxton/received_events","type":"User","site_admin":false},"body":"Fixes #1055 .\r\n\r\nThe current logic allows one to have the SDK tools (dev_appserver.py, etc.)\r\non one's $PATH, and then Djangae works out where the SDK is installed and\r\nadds it to sys.path, after which it is OK to import things from the SDK\r\nmodules.\r\n\r\nBut that got broke because `./manage.py runserver` indirectly loads this\r\nmodule, which was pulling in things from the SDK. If you don't have the\r\nSDK already already on sys.path, this would result in ImportError.\r\n\r\nThis fix moves the SDK imports inside the function (and adds comments which may or may not prevent this bug happening again).","created_at":"2018-05-23T18:20:24Z","updated_at":"2018-05-23T18:20:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/potatolondon/djangae/pulls/1056/commits","review_comments_url":"https://api.github.com/repos/potatolondon/djangae/pulls/1056/comments","review_comment_url":"https://api.github.com/repos/potatolondon/djangae/pulls/comments{/number}","comments_url":"https://api.github.com/repos/potatolondon/djangae/issues/1056/comments","statuses_url":"https://api.github.com/repos/potatolondon/djangae/statuses/b24b374f4281fcf123f2ff538d8693b9abdcf52c","head":{"label":"davidwtbuxton:1055-import-error","ref":"1055-import-error","sha":"b24b374f4281fcf123f2ff538d8693b9abdcf52c","user":{"login":"davidwtbuxton","id":334087,"avatar_url":"https://avatars2.githubusercontent.com/u/334087?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwtbuxton","html_url":"https://github.com/davidwtbuxton","followers_url":"https://api.github.com/users/davidwtbuxton/followers","following_url":"https://api.github.com/users/davidwtbuxton/following{/other_user}","gists_url":"https://api.github.com/users/davidwtbuxton/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwtbuxton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwtbuxton/subscriptions","organizations_url":"https://api.github.com/users/davidwtbuxton/orgs","repos_url":"https://api.github.com/users/davidwtbuxton/repos","events_url":"https://api.github.com/users/davidwtbuxton/events{/privacy}","received_events_url":"https://api.github.com/users/davidwtbuxton/received_events","type":"User","site_admin":false},"repo":{"id":27314948,"name":"djangae","full_name":"davidwtbuxton/djangae","owner":{"login":"davidwtbuxton","id":334087,"avatar_url":"https://avatars2.githubusercontent.com/u/334087?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwtbuxton","html_url":"https://github.com/davidwtbuxton","followers_url":"https://api.github.com/users/davidwtbuxton/followers","following_url":"https://api.github.com/users/davidwtbuxton/following{/other_user}","gists_url":"https://api.github.com/users/davidwtbuxton/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwtbuxton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwtbuxton/subscriptions","organizations_url":"https://api.github.com/users/davidwtbuxton/orgs","repos_url":"https://api.github.com/users/davidwtbuxton/repos","events_url":"https://api.github.com/users/davidwtbuxton/events{/privacy}","received_events_url":"https://api.github.com/users/davidwtbuxton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidwtbuxton/djangae","description":"The best way to run Django on Google App Engine","fork":true,"url":"https://api.github.com/repos/davidwtbuxton/djangae","forks_url":"https://api.github.com/repos/davidwtbuxton/djangae/forks","keys_url":"https://api.github.com/repos/davidwtbuxton/djangae/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidwtbuxton/djangae/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidwtbuxton/djangae/teams","hooks_url":"https://api.github.com/repos/davidwtbuxton/djangae/hooks","issue_events_url":"https://api.github.com/repos/davidwtbuxton/djangae/issues/events{/number}","events_url":"https://api.github.com/repos/davidwtbuxton/djangae/events","assignees_url":"https://api.github.com/repos/davidwtbuxton/djangae/assignees{/user}","branches_url":"https://api.github.com/repos/davidwtbuxton/djangae/branches{/branch}","tags_url":"https://api.github.com/repos/davidwtbuxton/djangae/tags","blobs_url":"https://api.github.com/repos/davidwtbuxton/djangae/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidwtbuxton/djangae/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidwtbuxton/djangae/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidwtbuxton/djangae/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidwtbuxton/djangae/statuses/{sha}","languages_url":"https://api.github.com/repos/davidwtbuxton/djangae/languages","stargazers_url":"https://api.github.com/repos/davidwtbuxton/djangae/stargazers","contributors_url":"https://api.github.com/repos/davidwtbuxton/djangae/contributors","subscribers_url":"https://api.github.com/repos/davidwtbuxton/djangae/subscribers","subscription_url":"https://api.github.com/repos/davidwtbuxton/djangae/subscription","commits_url":"https://api.github.com/repos/davidwtbuxton/djangae/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidwtbuxton/djangae/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidwtbuxton/djangae/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidwtbuxton/djangae/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidwtbuxton/djangae/contents/{+path}","compare_url":"https://api.github.com/repos/davidwtbuxton/djangae/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidwtbuxton/djangae/merges","archive_url":"https://api.github.com/repos/davidwtbuxton/djangae/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidwtbuxton/djangae/downloads","issues_url":"https://api.github.com/repos/davidwtbuxton/djangae/issues{/number}","pulls_url":"https://api.github.com/repos/davidwtbuxton/djangae/pulls{/number}","milestones_url":"https://api.github.com/repos/davidwtbuxton/djangae/milestones{/number}","notifications_url":"https://api.github.com/repos/davidwtbuxton/djangae/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidwtbuxton/djangae/labels{/name}","releases_url":"https://api.github.com/repos/davidwtbuxton/djangae/releases{/id}","deployments_url":"https://api.github.com/repos/davidwtbuxton/djangae/deployments","created_at":"2014-11-29T21:03:01Z","updated_at":"2018-05-18T16:35:26Z","pushed_at":"2018-05-23T18:18:07Z","git_url":"git://github.com/davidwtbuxton/djangae.git","ssh_url":"git@github.com:davidwtbuxton/djangae.git","clone_url":"https://github.com/davidwtbuxton/djangae.git","svn_url":"https://github.com/davidwtbuxton/djangae","homepage":"","size":4715,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"potatolondon:master","ref":"master","sha":"e919366864971a2501059bf32c658970f97d2005","user":{"login":"potatolondon","id":779847,"avatar_url":"https://avatars1.githubusercontent.com/u/779847?v=4","gravatar_id":"","url":"https://api.github.com/users/potatolondon","html_url":"https://github.com/potatolondon","followers_url":"https://api.github.com/users/potatolondon/followers","following_url":"https://api.github.com/users/potatolondon/following{/other_user}","gists_url":"https://api.github.com/users/potatolondon/gists{/gist_id}","starred_url":"https://api.github.com/users/potatolondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potatolondon/subscriptions","organizations_url":"https://api.github.com/users/potatolondon/orgs","repos_url":"https://api.github.com/users/potatolondon/repos","events_url":"https://api.github.com/users/potatolondon/events{/privacy}","received_events_url":"https://api.github.com/users/potatolondon/received_events","type":"Organization","site_admin":false},"repo":{"id":10217788,"name":"djangae","full_name":"potatolondon/djangae","owner":{"login":"potatolondon","id":779847,"avatar_url":"https://avatars1.githubusercontent.com/u/779847?v=4","gravatar_id":"","url":"https://api.github.com/users/potatolondon","html_url":"https://github.com/potatolondon","followers_url":"https://api.github.com/users/potatolondon/followers","following_url":"https://api.github.com/users/potatolondon/following{/other_user}","gists_url":"https://api.github.com/users/potatolondon/gists{/gist_id}","starred_url":"https://api.github.com/users/potatolondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potatolondon/subscriptions","organizations_url":"https://api.github.com/users/potatolondon/orgs","repos_url":"https://api.github.com/users/potatolondon/repos","events_url":"https://api.github.com/users/potatolondon/events{/privacy}","received_events_url":"https://api.github.com/users/potatolondon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/potatolondon/djangae","description":"The best way to run Django on Google App Engine","fork":false,"url":"https://api.github.com/repos/potatolondon/djangae","forks_url":"https://api.github.com/repos/potatolondon/djangae/forks","keys_url":"https://api.github.com/repos/potatolondon/djangae/keys{/key_id}","collaborators_url":"https://api.github.com/repos/potatolondon/djangae/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/potatolondon/djangae/teams","hooks_url":"https://api.github.com/repos/potatolondon/djangae/hooks","issue_events_url":"https://api.github.com/repos/potatolondon/djangae/issues/events{/number}","events_url":"https://api.github.com/repos/potatolondon/djangae/events","assignees_url":"https://api.github.com/repos/potatolondon/djangae/assignees{/user}","branches_url":"https://api.github.com/repos/potatolondon/djangae/branches{/branch}","tags_url":"https://api.github.com/repos/potatolondon/djangae/tags","blobs_url":"https://api.github.com/repos/potatolondon/djangae/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/potatolondon/djangae/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/potatolondon/djangae/git/refs{/sha}","trees_url":"https://api.github.com/repos/potatolondon/djangae/git/trees{/sha}","statuses_url":"https://api.github.com/repos/potatolondon/djangae/statuses/{sha}","languages_url":"https://api.github.com/repos/potatolondon/djangae/languages","stargazers_url":"https://api.github.com/repos/potatolondon/djangae/stargazers","contributors_url":"https://api.github.com/repos/potatolondon/djangae/contributors","subscribers_url":"https://api.github.com/repos/potatolondon/djangae/subscribers","subscription_url":"https://api.github.com/repos/potatolondon/djangae/subscription","commits_url":"https://api.github.com/repos/potatolondon/djangae/commits{/sha}","git_commits_url":"https://api.github.com/repos/potatolondon/djangae/git/commits{/sha}","comments_url":"https://api.github.com/repos/potatolondon/djangae/comments{/number}","issue_comment_url":"https://api.github.com/repos/potatolondon/djangae/issues/comments{/number}","contents_url":"https://api.github.com/repos/potatolondon/djangae/contents/{+path}","compare_url":"https://api.github.com/repos/potatolondon/djangae/compare/{base}...{head}","merges_url":"https://api.github.com/repos/potatolondon/djangae/merges","archive_url":"https://api.github.com/repos/potatolondon/djangae/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/potatolondon/djangae/downloads","issues_url":"https://api.github.com/repos/potatolondon/djangae/issues{/number}","pulls_url":"https://api.github.com/repos/potatolondon/djangae/pulls{/number}","milestones_url":"https://api.github.com/repos/potatolondon/djangae/milestones{/number}","notifications_url":"https://api.github.com/repos/potatolondon/djangae/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/potatolondon/djangae/labels{/name}","releases_url":"https://api.github.com/repos/potatolondon/djangae/releases{/id}","deployments_url":"https://api.github.com/repos/potatolondon/djangae/deployments","created_at":"2013-05-22T10:55:55Z","updated_at":"2018-05-21T16:28:07Z","pushed_at":"2018-05-18T14:52:20Z","git_url":"git://github.com/potatolondon/djangae.git","ssh_url":"git@github.com:potatolondon/djangae.git","clone_url":"https://github.com/potatolondon/djangae.git","svn_url":"https://github.com/potatolondon/djangae","homepage":"http://djangae.org","size":4894,"stargazers_count":482,"watchers_count":482,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":117,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":117,"open_issues":89,"watchers":482,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/potatolondon/djangae/pulls/1056"},"html":{"href":"https://github.com/potatolondon/djangae/pull/1056"},"issue":{"href":"https://api.github.com/repos/potatolondon/djangae/issues/1056"},"comments":{"href":"https://api.github.com/repos/potatolondon/djangae/issues/1056/comments"},"review_comments":{"href":"https://api.github.com/repos/potatolondon/djangae/pulls/1056/comments"},"review_comment":{"href":"https://api.github.com/repos/potatolondon/djangae/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/potatolondon/djangae/pulls/1056/commits"},"statuses":{"href":"https://api.github.com/repos/potatolondon/djangae/statuses/b24b374f4281fcf123f2ff538d8693b9abdcf52c"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":13,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"davidwtbuxton"}}