{"action":"created","issue":{"url":"https://api.github.com/repos/kelektiv/node-uuid/issues/288","repository_url":"https://api.github.com/repos/kelektiv/node-uuid","labels_url":"https://api.github.com/repos/kelektiv/node-uuid/issues/288/labels{/name}","comments_url":"https://api.github.com/repos/kelektiv/node-uuid/issues/288/comments","events_url":"https://api.github.com/repos/kelektiv/node-uuid/issues/288/events","html_url":"https://github.com/kelektiv/node-uuid/pull/288","id":349705178,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzU3Mzgz","number":288,"title":"fix: add TypeScript defaults support","user":{"login":"shellscape","id":76371,"node_id":"MDQ6VXNlcjc2Mzcx","avatar_url":"https://avatars1.githubusercontent.com/u/76371?v=4","gravatar_id":"","url":"https://api.github.com/users/shellscape","html_url":"https://github.com/shellscape","followers_url":"https://api.github.com/users/shellscape/followers","following_url":"https://api.github.com/users/shellscape/following{/other_user}","gists_url":"https://api.github.com/users/shellscape/gists{/gist_id}","starred_url":"https://api.github.com/users/shellscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shellscape/subscriptions","organizations_url":"https://api.github.com/users/shellscape/orgs","repos_url":"https://api.github.com/users/shellscape/repos","events_url":"https://api.github.com/users/shellscape/events{/privacy}","received_events_url":"https://api.github.com/users/shellscape/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-11T04:36:23Z","updated_at":"2018-08-11T18:13:58Z","closed_at":"2018-08-11T16:37:57Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kelektiv/node-uuid/pulls/288","html_url":"https://github.com/kelektiv/node-uuid/pull/288","diff_url":"https://github.com/kelektiv/node-uuid/pull/288.diff","patch_url":"https://github.com/kelektiv/node-uuid/pull/288.patch"},"body":"This PR adds a simple `module.exports.default` line to each of the version files.  When the following `tsconfig.json` values are used:\r\n\r\n```json\r\n    \"module\": \"commonjs\",\r\n    \"target\": \"es6\"\r\n```\r\n\r\nAnd `esModuleInterop` is `false`, TypeScript will compile the uuid-consuming file with the assumption that `module.exports.defaults` exists. One might argue that this change is not needed, but `esModuleInterop` can really screw things up when using the compilation result in certain bundlers. Several other widely used CJS modules have also added this tiny bit of compatibility with no ill-effect."},"comment":{"url":"https://api.github.com/repos/kelektiv/node-uuid/issues/comments/412292469","html_url":"https://github.com/kelektiv/node-uuid/pull/288#issuecomment-412292469","issue_url":"https://api.github.com/repos/kelektiv/node-uuid/issues/288","id":412292469,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjI5MjQ2OQ==","user":{"login":"johnnyreilly","id":1010525,"node_id":"MDQ6VXNlcjEwMTA1MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1010525?v=4","gravatar_id":"","url":"https://api.github.com/users/johnnyreilly","html_url":"https://github.com/johnnyreilly","followers_url":"https://api.github.com/users/johnnyreilly/followers","following_url":"https://api.github.com/users/johnnyreilly/following{/other_user}","gists_url":"https://api.github.com/users/johnnyreilly/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnyreilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnyreilly/subscriptions","organizations_url":"https://api.github.com/users/johnnyreilly/orgs","repos_url":"https://api.github.com/users/johnnyreilly/repos","events_url":"https://api.github.com/users/johnnyreilly/events{/privacy}","received_events_url":"https://api.github.com/users/johnnyreilly/received_events","type":"User","site_admin":false},"created_at":"2018-08-11T18:13:58Z","updated_at":"2018-08-11T18:13:58Z","author_association":"NONE","body":"Hey @broofa,\r\n\r\nTypeScript user here!  Thanks for your mighty fine library.\r\n\r\n> My policy is to keep this module free of app/tool/framework-specific code\r\n\r\nI completely appreciate that you have a policy and why. Changes like this shouldn't be something that you arbitrarily add. That said, I'd say there's a large audience of people who'd be super grateful if you were willing to take this PR.\r\n\r\nAs @shellscape says:\r\n\r\n> Several other widely used CJS modules have also added this tiny bit of compatibility with no ill-effect.\r\n\r\nWould it help to convince you if he was to list some examples just so know this isn't a flash in the pan amend? Rather something that's being generally adopted and hence more likely to make you reconsider?\r\n\r\nObviously it's your joint and you get to decide; Your house, your rules and all that. But I wanted to check if you're open at all to this option. \r\n\r\nThanks for your work!"}}
{"actor":{"display_login":"johnnyreilly"}}