{"action":"created","comment":{"url":"https://api.github.com/repos/divio/djangocms-versioning-filer/pulls/comments/226206607","pull_request_review_id":165970683,"id":226206607,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjIwNjYwNw==","diff_hunk":"@@ -12,10 +12,7 @@ def inner(self):\n         current_filename = self.instance.file.name.split('/')[-1]\n         cleaned_data = func(self)\n         file = cleaned_data.get('file')\n-        if (\n-            file and\n-            file.name.split('/')[-1] != current_filename\n-        ):\n+        if file and file.name.split('/')[-1].lower() != current_filename.lower():","path":"djangocms_versioning_filer/monkeypatch/admin/fileadmin.py","position":8,"original_position":8,"commit_id":"2c642940a04708a614dd265be606f78ff6ff86dd","original_commit_id":"2c642940a04708a614dd265be606f78ff6ff86dd","user":{"login":"toffi9","id":10218190,"node_id":"MDQ6VXNlcjEwMjE4MTkw","avatar_url":"https://avatars0.githubusercontent.com/u/10218190?v=4","gravatar_id":"","url":"https://api.github.com/users/toffi9","html_url":"https://github.com/toffi9","followers_url":"https://api.github.com/users/toffi9/followers","following_url":"https://api.github.com/users/toffi9/following{/other_user}","gists_url":"https://api.github.com/users/toffi9/gists{/gist_id}","starred_url":"https://api.github.com/users/toffi9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toffi9/subscriptions","organizations_url":"https://api.github.com/users/toffi9/orgs","repos_url":"https://api.github.com/users/toffi9/repos","events_url":"https://api.github.com/users/toffi9/events{/privacy}","received_events_url":"https://api.github.com/users/toffi9/received_events","type":"User","site_admin":false},"body":"default upload_to function is doing slugify on name and it's changing it to lowercase. As I remember Mac/Windows are case insensitive with file naming.","created_at":"2018-10-18T08:11:11Z","updated_at":"2018-10-18T08:11:12Z","html_url":"https://github.com/divio/djangocms-versioning-filer/pull/11#discussion_r226206607","pull_request_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/pulls/11","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/divio/djangocms-versioning-filer/pulls/comments/226206607"},"html":{"href":"https://github.com/divio/djangocms-versioning-filer/pull/11#discussion_r226206607"},"pull_request":{"href":"https://api.github.com/repos/divio/djangocms-versioning-filer/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/divio/djangocms-versioning-filer/pulls/11","id":223252945,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMjUyOTQ1","html_url":"https://github.com/divio/djangocms-versioning-filer/pull/11","diff_url":"https://github.com/divio/djangocms-versioning-filer/pull/11.diff","patch_url":"https://github.com/divio/djangocms-versioning-filer/pull/11.patch","issue_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/issues/11","number":11,"state":"open","locked":false,"title":"Add unit tests","user":{"login":"toffi9","id":10218190,"node_id":"MDQ6VXNlcjEwMjE4MTkw","avatar_url":"https://avatars0.githubusercontent.com/u/10218190?v=4","gravatar_id":"","url":"https://api.github.com/users/toffi9","html_url":"https://github.com/toffi9","followers_url":"https://api.github.com/users/toffi9/followers","following_url":"https://api.github.com/users/toffi9/following{/other_user}","gists_url":"https://api.github.com/users/toffi9/gists{/gist_id}","starred_url":"https://api.github.com/users/toffi9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toffi9/subscriptions","organizations_url":"https://api.github.com/users/toffi9/orgs","repos_url":"https://api.github.com/users/toffi9/repos","events_url":"https://api.github.com/users/toffi9/events{/privacy}","received_events_url":"https://api.github.com/users/toffi9/received_events","type":"User","site_admin":false},"body":"```\r\nName                                                             Stmts   Miss Branch BrPart  Cover   Missing\r\n------------------------------------------------------------------------------------------------------------\r\ndjangocms_versioning_filer/__init__.py                               2      0      0      0   100%\r\ndjangocms_versioning_filer/cms_config.py                            48      0     10      1    98%   54->exit\r\ndjangocms_versioning_filer/fields/__init__.py                        2      0      0      0   100%\r\ndjangocms_versioning_filer/fields/file.py                           91     12     16      5    80%   34, 40-47, 49, 55, 75-76, 82-83, 30->34, 37->48, 48->49,\r\n52->55, 56->62\r\ndjangocms_versioning_filer/fields/image.py                          14      0      0      0   100%\r\ndjangocms_versioning_filer/helpers.py                                7      0      0      0   100%\r\ndjangocms_versioning_filer/models.py                                32      5      2      0    79%   58-71\r\ndjangocms_versioning_filer/monkeypatch/__init__.py                   3      0      0      0   100%\r\ndjangocms_versioning_filer/monkeypatch/admin/__init__.py             4      0      0      0   100%\r\ndjangocms_versioning_filer/monkeypatch/admin/clipboardadmin.py      69     14     24      7    73%   32-33, 37, 44, 86-91, 104-105, 126-135, 28->36, 36->37, 3\r\n9->44, 47->56, 59->126, 82->86, 99->107\r\ndjangocms_versioning_filer/monkeypatch/admin/fileadmin.py           22      0      4      1    96%   31->exit\r\ndjangocms_versioning_filer/monkeypatch/admin/folderadmin.py        153     37     56     10    72%   44-53, 55, 66-69, 110-114, 126-127, 157-162, 168-175, 191\r\n, 202-205, 252, 43->44, 54->55, 65->66, 109->110, 125->126, 146->149, 156->157, 166->168, 181->187, 187->191\r\ndjangocms_versioning_filer/monkeypatch/admin/imageadmin.py          10      1      2      1    83%   14, 13->14\r\ndjangocms_versioning_filer/monkeypatch/models.py                     9      0      0      0   100%\r\ndjangocms_versioning_filer/monkeypatch/views.py                     12      1      2      1    86%   14, 13->14\r\ndjangocms_versioning_filer/plugins/__init__.py                       0      0      0      0   100%\r\ndjangocms_versioning_filer/plugins/audio/__init__.py                 1      0      0      0   100%\r\ndjangocms_versioning_filer/plugins/audio/cms_plugins.py             18      0      0      0   100%\r\ndjangocms_versioning_filer/plugins/audio/models.py                  51     10     16      4    73%   40-42, 54, 63, 68, 101-104, 46->exit, 50->54, 61->63, 108\r\n->exit\r\ndjangocms_versioning_filer/plugins/file/__init__.py                  1      0      0      0   100%\r\ndjangocms_versioning_filer/plugins/file/cms_plugins.py              11      0      0      0   100%\r\ndjangocms_versioning_filer/plugins/file/models.py                   40      6     12      4    77%   73-75, 84, 87, 92, 79->exit, 83->84, 85->87, 97->100\r\ndjangocms_versioning_filer/plugins/picture/__init__.py               1      0      0      0   100%\r\ndjangocms_versioning_filer/plugins/picture/cms_plugins.py           18      0      0      0   100%\r\ndjangocms_versioning_filer/plugins/picture/models.py                10      0      2      0   100%\r\ndjangocms_versioning_filer/plugins/video/__init__.py                 1      0      0      0   100%\r\ndjangocms_versioning_filer/plugins/video/cms_plugins.py             31      0      0      0   100%\r\ndjangocms_versioning_filer/plugins/video/models.py                  57     11     14      4    73%   76, 102-104, 113, 121, 126, 159-162, 108->exit, 112->113,\r\n 119->121, 166->exit\r\n------------------------------------------------------------------------------------------------------------\r\nTOTAL                                                              718     97    160     38    81%","created_at":"2018-10-16T13:35:59Z","updated_at":"2018-10-18T08:11:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e05e9b8afa5bf2f7b1695c47b317506c38fff24","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chaosk","id":99521,"node_id":"MDQ6VXNlcjk5NTIx","avatar_url":"https://avatars2.githubusercontent.com/u/99521?v=4","gravatar_id":"","url":"https://api.github.com/users/chaosk","html_url":"https://github.com/chaosk","followers_url":"https://api.github.com/users/chaosk/followers","following_url":"https://api.github.com/users/chaosk/following{/other_user}","gists_url":"https://api.github.com/users/chaosk/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosk/subscriptions","organizations_url":"https://api.github.com/users/chaosk/orgs","repos_url":"https://api.github.com/users/chaosk/repos","events_url":"https://api.github.com/users/chaosk/events{/privacy}","received_events_url":"https://api.github.com/users/chaosk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/pulls/11/commits","review_comments_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/pulls/11/comments","review_comment_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/issues/11/comments","statuses_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/statuses/2c642940a04708a614dd265be606f78ff6ff86dd","head":{"label":"toffi9:add-missing-unit-tests","ref":"add-missing-unit-tests","sha":"2c642940a04708a614dd265be606f78ff6ff86dd","user":{"login":"toffi9","id":10218190,"node_id":"MDQ6VXNlcjEwMjE4MTkw","avatar_url":"https://avatars0.githubusercontent.com/u/10218190?v=4","gravatar_id":"","url":"https://api.github.com/users/toffi9","html_url":"https://github.com/toffi9","followers_url":"https://api.github.com/users/toffi9/followers","following_url":"https://api.github.com/users/toffi9/following{/other_user}","gists_url":"https://api.github.com/users/toffi9/gists{/gist_id}","starred_url":"https://api.github.com/users/toffi9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toffi9/subscriptions","organizations_url":"https://api.github.com/users/toffi9/orgs","repos_url":"https://api.github.com/users/toffi9/repos","events_url":"https://api.github.com/users/toffi9/events{/privacy}","received_events_url":"https://api.github.com/users/toffi9/received_events","type":"User","site_admin":false},"repo":{"id":150739069,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA3MzkwNjk=","name":"djangocms-versioning-filer","full_name":"toffi9/djangocms-versioning-filer","private":false,"owner":{"login":"toffi9","id":10218190,"node_id":"MDQ6VXNlcjEwMjE4MTkw","avatar_url":"https://avatars0.githubusercontent.com/u/10218190?v=4","gravatar_id":"","url":"https://api.github.com/users/toffi9","html_url":"https://github.com/toffi9","followers_url":"https://api.github.com/users/toffi9/followers","following_url":"https://api.github.com/users/toffi9/following{/other_user}","gists_url":"https://api.github.com/users/toffi9/gists{/gist_id}","starred_url":"https://api.github.com/users/toffi9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toffi9/subscriptions","organizations_url":"https://api.github.com/users/toffi9/orgs","repos_url":"https://api.github.com/users/toffi9/repos","events_url":"https://api.github.com/users/toffi9/events{/privacy}","received_events_url":"https://api.github.com/users/toffi9/received_events","type":"User","site_admin":false},"html_url":"https://github.com/toffi9/djangocms-versioning-filer","description":null,"fork":true,"url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer","forks_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/forks","keys_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/teams","hooks_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/hooks","issue_events_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/issues/events{/number}","events_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/events","assignees_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/assignees{/user}","branches_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/branches{/branch}","tags_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/tags","blobs_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/git/refs{/sha}","trees_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/statuses/{sha}","languages_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/languages","stargazers_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/stargazers","contributors_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/contributors","subscribers_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/subscribers","subscription_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/subscription","commits_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/commits{/sha}","git_commits_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/git/commits{/sha}","comments_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/comments{/number}","issue_comment_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/issues/comments{/number}","contents_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/contents/{+path}","compare_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/merges","archive_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/downloads","issues_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/issues{/number}","pulls_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/pulls{/number}","milestones_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/milestones{/number}","notifications_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/labels{/name}","releases_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/releases{/id}","deployments_url":"https://api.github.com/repos/toffi9/djangocms-versioning-filer/deployments","created_at":"2018-09-28T12:43:27Z","updated_at":"2018-09-28T12:43:29Z","pushed_at":"2018-10-17T22:09:33Z","git_url":"git://github.com/toffi9/djangocms-versioning-filer.git","ssh_url":"git@github.com:toffi9/djangocms-versioning-filer.git","clone_url":"https://github.com/toffi9/djangocms-versioning-filer.git","svn_url":"https://github.com/toffi9/djangocms-versioning-filer","homepage":null,"size":69,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"divio:master","ref":"master","sha":"c0eb1a20153d4e9ead6fe5ea6a571ac6fe7f5a1a","user":{"login":"divio","id":117904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzkwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/117904?v=4","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"repo":{"id":150715892,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA3MTU4OTI=","name":"djangocms-versioning-filer","full_name":"divio/djangocms-versioning-filer","private":false,"owner":{"login":"divio","id":117904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzkwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/117904?v=4","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/divio/djangocms-versioning-filer","description":null,"fork":false,"url":"https://api.github.com/repos/divio/djangocms-versioning-filer","forks_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/forks","keys_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/teams","hooks_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/hooks","issue_events_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/issues/events{/number}","events_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/events","assignees_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/assignees{/user}","branches_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/branches{/branch}","tags_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/tags","blobs_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/git/refs{/sha}","trees_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/statuses/{sha}","languages_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/languages","stargazers_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/stargazers","contributors_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/contributors","subscribers_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/subscribers","subscription_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/subscription","commits_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/commits{/sha}","git_commits_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/git/commits{/sha}","comments_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/comments{/number}","issue_comment_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/issues/comments{/number}","contents_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/contents/{+path}","compare_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/merges","archive_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/downloads","issues_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/issues{/number}","pulls_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/pulls{/number}","milestones_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/milestones{/number}","notifications_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/labels{/name}","releases_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/releases{/id}","deployments_url":"https://api.github.com/repos/divio/djangocms-versioning-filer/deployments","created_at":"2018-09-28T09:18:50Z","updated_at":"2018-10-17T12:21:28Z","pushed_at":"2018-10-17T22:09:34Z","git_url":"git://github.com/divio/djangocms-versioning-filer.git","ssh_url":"git@github.com:divio/djangocms-versioning-filer.git","clone_url":"https://github.com/divio/djangocms-versioning-filer.git","svn_url":"https://github.com/divio/djangocms-versioning-filer","homepage":null,"size":69,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/divio/djangocms-versioning-filer/pulls/11"},"html":{"href":"https://github.com/divio/djangocms-versioning-filer/pull/11"},"issue":{"href":"https://api.github.com/repos/divio/djangocms-versioning-filer/issues/11"},"comments":{"href":"https://api.github.com/repos/divio/djangocms-versioning-filer/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/divio/djangocms-versioning-filer/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/divio/djangocms-versioning-filer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/divio/djangocms-versioning-filer/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/divio/djangocms-versioning-filer/statuses/2c642940a04708a614dd265be606f78ff6ff86dd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"toffi9"}}