{"action":"created","issue":{"url":"https://api.github.com/repos/RolandPheasant/DynamicData/issues/120","repository_url":"https://api.github.com/repos/RolandPheasant/DynamicData","labels_url":"https://api.github.com/repos/RolandPheasant/DynamicData/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/RolandPheasant/DynamicData/issues/120/comments","events_url":"https://api.github.com/repos/RolandPheasant/DynamicData/issues/120/events","html_url":"https://github.com/RolandPheasant/DynamicData/pull/120","id":328494615,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDE1NDYw","number":120,"title":"Avoid unnecessary tolist calls (performance optimization)","user":{"login":"onliner10","id":4688431,"node_id":"MDQ6VXNlcjQ2ODg0MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/4688431?v=4","gravatar_id":"","url":"https://api.github.com/users/onliner10","html_url":"https://github.com/onliner10","followers_url":"https://api.github.com/users/onliner10/followers","following_url":"https://api.github.com/users/onliner10/following{/other_user}","gists_url":"https://api.github.com/users/onliner10/gists{/gist_id}","starred_url":"https://api.github.com/users/onliner10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onliner10/subscriptions","organizations_url":"https://api.github.com/users/onliner10/orgs","repos_url":"https://api.github.com/users/onliner10/repos","events_url":"https://api.github.com/users/onliner10/events{/privacy}","received_events_url":"https://api.github.com/users/onliner10/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-01T12:05:12Z","updated_at":"2018-06-02T07:38:19Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/RolandPheasant/DynamicData/pulls/120","html_url":"https://github.com/RolandPheasant/DynamicData/pull/120","diff_url":"https://github.com/RolandPheasant/DynamicData/pull/120.diff","patch_url":"https://github.com/RolandPheasant/DynamicData/pull/120.patch"},"body":"While playing around with profiler I noticed a lot of CPU spikes and memory allocations were caused by toList calls in KeyValueCollection constructor. After I made the list Lazy I was able to reduce my test case run time almost 3 times ( I'll also try to submit PR for my benchmarks, soon)"},"comment":{"url":"https://api.github.com/repos/RolandPheasant/DynamicData/issues/comments/394066763","html_url":"https://github.com/RolandPheasant/DynamicData/pull/120#issuecomment-394066763","issue_url":"https://api.github.com/repos/RolandPheasant/DynamicData/issues/120","id":394066763,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDA2Njc2Mw==","user":{"login":"RolandPheasant","id":9879866,"node_id":"MDQ6VXNlcjk4Nzk4NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/9879866?v=4","gravatar_id":"","url":"https://api.github.com/users/RolandPheasant","html_url":"https://github.com/RolandPheasant","followers_url":"https://api.github.com/users/RolandPheasant/followers","following_url":"https://api.github.com/users/RolandPheasant/following{/other_user}","gists_url":"https://api.github.com/users/RolandPheasant/gists{/gist_id}","starred_url":"https://api.github.com/users/RolandPheasant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RolandPheasant/subscriptions","organizations_url":"https://api.github.com/users/RolandPheasant/orgs","repos_url":"https://api.github.com/users/RolandPheasant/repos","events_url":"https://api.github.com/users/RolandPheasant/events{/privacy}","received_events_url":"https://api.github.com/users/RolandPheasant/received_events","type":"User","site_admin":false},"created_at":"2018-06-02T07:38:19Z","updated_at":"2018-06-02T07:38:19Z","author_association":"OWNER","body":"Yes. Also a minor semantic improvement would be to pass ```Func<List<T>>``` into the constructor so the lock need not be exposed outside the sort class."}}
{"actor":{"display_login":"RolandPheasant"}}