{"action":"closed","number":486,"pull_request":{"url":"https://api.github.com/repos/FTL13/New-FTL13/pulls/486","id":227594867,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NTk0ODY3","html_url":"https://github.com/FTL13/New-FTL13/pull/486","diff_url":"https://github.com/FTL13/New-FTL13/pull/486.diff","patch_url":"https://github.com/FTL13/New-FTL13/pull/486.patch","issue_url":"https://api.github.com/repos/FTL13/New-FTL13/issues/486","number":486,"state":"closed","locked":false,"title":"[MIRROR] Streamlines beacon types","user":{"login":"Lunokhod-Bot","id":29014172,"node_id":"MDQ6VXNlcjI5MDE0MTcy","avatar_url":"https://avatars3.githubusercontent.com/u/29014172?v=4","gravatar_id":"","url":"https://api.github.com/users/Lunokhod-Bot","html_url":"https://github.com/Lunokhod-Bot","followers_url":"https://api.github.com/users/Lunokhod-Bot/followers","following_url":"https://api.github.com/users/Lunokhod-Bot/following{/other_user}","gists_url":"https://api.github.com/users/Lunokhod-Bot/gists{/gist_id}","starred_url":"https://api.github.com/users/Lunokhod-Bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lunokhod-Bot/subscriptions","organizations_url":"https://api.github.com/users/Lunokhod-Bot/orgs","repos_url":"https://api.github.com/users/Lunokhod-Bot/repos","events_url":"https://api.github.com/users/Lunokhod-Bot/events{/privacy}","received_events_url":"https://api.github.com/users/Lunokhod-Bot/received_events","type":"User","site_admin":false},"body":"Original PR: https://github.com/tgstation/tgstation/pull/41192\n--------------------\n### Purpose: \r\nStreamlines the beacons since they do the same thing. As you can see if you want to add a beacon all you have to do now is define it and change `generate_display_names()`. Compare old `herobeacon` to new `choice_beacon/hero`!\r\n\r\n### Features: \r\nAll beacon variants now use the droppod feature. It's more realistic than poofing items and tbh cute.\r\nAll beacon variants now buzz if you fail to use the item.\r\nThe Holy Beacon now praises the gods when you spawn something in.\r\nFixes #40991\r\n\r\n### Performance/Maintainability:\r\n- Much easier to add these types of beacons now without needless copy-paste.\r\n- `display_names` was removed from the object and is now temporarily kept in the proc that called them. since it now is a list shared by all choice_beacon types it has lost its static nature.\r\n- Slightly more procs than previously but this is mainly due to holybeacon having the extra checks and post-spawning feedback tally. Hopefully this modularity can be exploited more. If there's a better way let me know.\r\n\r\n\r\n","created_at":"2018-11-01T11:52:54Z","updated_at":"2018-11-01T19:49:05Z","closed_at":"2018-11-01T19:49:04Z","merged_at":"2018-11-01T19:49:04Z","merge_commit_sha":"34457d46c40c72f89cbb66a71e46c577af4ff508","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1065230003,"node_id":"MDU6TGFiZWwxMDY1MjMwMDAz","url":"https://api.github.com/repos/FTL13/New-FTL13/labels/Upstream%20PR%20Merged","name":"Upstream PR Merged","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/FTL13/New-FTL13/pulls/486/commits","review_comments_url":"https://api.github.com/repos/FTL13/New-FTL13/pulls/486/comments","review_comment_url":"https://api.github.com/repos/FTL13/New-FTL13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FTL13/New-FTL13/issues/486/comments","statuses_url":"https://api.github.com/repos/FTL13/New-FTL13/statuses/9e4d9ae41df498024a3135d88142332290f7d56d","head":{"label":"FTL13:upstream-merge-41192","ref":"upstream-merge-41192","sha":"9e4d9ae41df498024a3135d88142332290f7d56d","user":{"login":"FTL13","id":20245467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjQ1NDY3","avatar_url":"https://avatars0.githubusercontent.com/u/20245467?v=4","gravatar_id":"","url":"https://api.github.com/users/FTL13","html_url":"https://github.com/FTL13","followers_url":"https://api.github.com/users/FTL13/followers","following_url":"https://api.github.com/users/FTL13/following{/other_user}","gists_url":"https://api.github.com/users/FTL13/gists{/gist_id}","starred_url":"https://api.github.com/users/FTL13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTL13/subscriptions","organizations_url":"https://api.github.com/users/FTL13/orgs","repos_url":"https://api.github.com/users/FTL13/repos","events_url":"https://api.github.com/users/FTL13/events{/privacy}","received_events_url":"https://api.github.com/users/FTL13/received_events","type":"Organization","site_admin":false},"repo":{"id":147595186,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1OTUxODY=","name":"New-FTL13","full_name":"FTL13/New-FTL13","private":false,"owner":{"login":"FTL13","id":20245467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjQ1NDY3","avatar_url":"https://avatars0.githubusercontent.com/u/20245467?v=4","gravatar_id":"","url":"https://api.github.com/users/FTL13","html_url":"https://github.com/FTL13","followers_url":"https://api.github.com/users/FTL13/followers","following_url":"https://api.github.com/users/FTL13/following{/other_user}","gists_url":"https://api.github.com/users/FTL13/gists{/gist_id}","starred_url":"https://api.github.com/users/FTL13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTL13/subscriptions","organizations_url":"https://api.github.com/users/FTL13/orgs","repos_url":"https://api.github.com/users/FTL13/repos","events_url":"https://api.github.com/users/FTL13/events{/privacy}","received_events_url":"https://api.github.com/users/FTL13/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FTL13/New-FTL13","description":"FTL13 re-imagined, with cupholders and such.","fork":false,"url":"https://api.github.com/repos/FTL13/New-FTL13","forks_url":"https://api.github.com/repos/FTL13/New-FTL13/forks","keys_url":"https://api.github.com/repos/FTL13/New-FTL13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FTL13/New-FTL13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FTL13/New-FTL13/teams","hooks_url":"https://api.github.com/repos/FTL13/New-FTL13/hooks","issue_events_url":"https://api.github.com/repos/FTL13/New-FTL13/issues/events{/number}","events_url":"https://api.github.com/repos/FTL13/New-FTL13/events","assignees_url":"https://api.github.com/repos/FTL13/New-FTL13/assignees{/user}","branches_url":"https://api.github.com/repos/FTL13/New-FTL13/branches{/branch}","tags_url":"https://api.github.com/repos/FTL13/New-FTL13/tags","blobs_url":"https://api.github.com/repos/FTL13/New-FTL13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FTL13/New-FTL13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FTL13/New-FTL13/git/refs{/sha}","trees_url":"https://api.github.com/repos/FTL13/New-FTL13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FTL13/New-FTL13/statuses/{sha}","languages_url":"https://api.github.com/repos/FTL13/New-FTL13/languages","stargazers_url":"https://api.github.com/repos/FTL13/New-FTL13/stargazers","contributors_url":"https://api.github.com/repos/FTL13/New-FTL13/contributors","subscribers_url":"https://api.github.com/repos/FTL13/New-FTL13/subscribers","subscription_url":"https://api.github.com/repos/FTL13/New-FTL13/subscription","commits_url":"https://api.github.com/repos/FTL13/New-FTL13/commits{/sha}","git_commits_url":"https://api.github.com/repos/FTL13/New-FTL13/git/commits{/sha}","comments_url":"https://api.github.com/repos/FTL13/New-FTL13/comments{/number}","issue_comment_url":"https://api.github.com/repos/FTL13/New-FTL13/issues/comments{/number}","contents_url":"https://api.github.com/repos/FTL13/New-FTL13/contents/{+path}","compare_url":"https://api.github.com/repos/FTL13/New-FTL13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FTL13/New-FTL13/merges","archive_url":"https://api.github.com/repos/FTL13/New-FTL13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FTL13/New-FTL13/downloads","issues_url":"https://api.github.com/repos/FTL13/New-FTL13/issues{/number}","pulls_url":"https://api.github.com/repos/FTL13/New-FTL13/pulls{/number}","milestones_url":"https://api.github.com/repos/FTL13/New-FTL13/milestones{/number}","notifications_url":"https://api.github.com/repos/FTL13/New-FTL13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FTL13/New-FTL13/labels{/name}","releases_url":"https://api.github.com/repos/FTL13/New-FTL13/releases{/id}","deployments_url":"https://api.github.com/repos/FTL13/New-FTL13/deployments","created_at":"2018-09-06T00:30:50Z","updated_at":"2018-11-01T19:48:56Z","pushed_at":"2018-11-01T19:49:05Z","git_url":"git://github.com/FTL13/New-FTL13.git","ssh_url":"git@github.com:FTL13/New-FTL13.git","clone_url":"https://github.com/FTL13/New-FTL13.git","svn_url":"https://github.com/FTL13/New-FTL13","homepage":null,"size":1216609,"stargazers_count":4,"watchers_count":4,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":8,"open_issues":11,"watchers":4,"default_branch":"master"}},"base":{"label":"FTL13:master","ref":"master","sha":"624a6f40c2be1c623a56a8c0c979fffb6637e289","user":{"login":"FTL13","id":20245467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjQ1NDY3","avatar_url":"https://avatars0.githubusercontent.com/u/20245467?v=4","gravatar_id":"","url":"https://api.github.com/users/FTL13","html_url":"https://github.com/FTL13","followers_url":"https://api.github.com/users/FTL13/followers","following_url":"https://api.github.com/users/FTL13/following{/other_user}","gists_url":"https://api.github.com/users/FTL13/gists{/gist_id}","starred_url":"https://api.github.com/users/FTL13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTL13/subscriptions","organizations_url":"https://api.github.com/users/FTL13/orgs","repos_url":"https://api.github.com/users/FTL13/repos","events_url":"https://api.github.com/users/FTL13/events{/privacy}","received_events_url":"https://api.github.com/users/FTL13/received_events","type":"Organization","site_admin":false},"repo":{"id":147595186,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1OTUxODY=","name":"New-FTL13","full_name":"FTL13/New-FTL13","private":false,"owner":{"login":"FTL13","id":20245467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMjQ1NDY3","avatar_url":"https://avatars0.githubusercontent.com/u/20245467?v=4","gravatar_id":"","url":"https://api.github.com/users/FTL13","html_url":"https://github.com/FTL13","followers_url":"https://api.github.com/users/FTL13/followers","following_url":"https://api.github.com/users/FTL13/following{/other_user}","gists_url":"https://api.github.com/users/FTL13/gists{/gist_id}","starred_url":"https://api.github.com/users/FTL13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTL13/subscriptions","organizations_url":"https://api.github.com/users/FTL13/orgs","repos_url":"https://api.github.com/users/FTL13/repos","events_url":"https://api.github.com/users/FTL13/events{/privacy}","received_events_url":"https://api.github.com/users/FTL13/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FTL13/New-FTL13","description":"FTL13 re-imagined, with cupholders and such.","fork":false,"url":"https://api.github.com/repos/FTL13/New-FTL13","forks_url":"https://api.github.com/repos/FTL13/New-FTL13/forks","keys_url":"https://api.github.com/repos/FTL13/New-FTL13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FTL13/New-FTL13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FTL13/New-FTL13/teams","hooks_url":"https://api.github.com/repos/FTL13/New-FTL13/hooks","issue_events_url":"https://api.github.com/repos/FTL13/New-FTL13/issues/events{/number}","events_url":"https://api.github.com/repos/FTL13/New-FTL13/events","assignees_url":"https://api.github.com/repos/FTL13/New-FTL13/assignees{/user}","branches_url":"https://api.github.com/repos/FTL13/New-FTL13/branches{/branch}","tags_url":"https://api.github.com/repos/FTL13/New-FTL13/tags","blobs_url":"https://api.github.com/repos/FTL13/New-FTL13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FTL13/New-FTL13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FTL13/New-FTL13/git/refs{/sha}","trees_url":"https://api.github.com/repos/FTL13/New-FTL13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FTL13/New-FTL13/statuses/{sha}","languages_url":"https://api.github.com/repos/FTL13/New-FTL13/languages","stargazers_url":"https://api.github.com/repos/FTL13/New-FTL13/stargazers","contributors_url":"https://api.github.com/repos/FTL13/New-FTL13/contributors","subscribers_url":"https://api.github.com/repos/FTL13/New-FTL13/subscribers","subscription_url":"https://api.github.com/repos/FTL13/New-FTL13/subscription","commits_url":"https://api.github.com/repos/FTL13/New-FTL13/commits{/sha}","git_commits_url":"https://api.github.com/repos/FTL13/New-FTL13/git/commits{/sha}","comments_url":"https://api.github.com/repos/FTL13/New-FTL13/comments{/number}","issue_comment_url":"https://api.github.com/repos/FTL13/New-FTL13/issues/comments{/number}","contents_url":"https://api.github.com/repos/FTL13/New-FTL13/contents/{+path}","compare_url":"https://api.github.com/repos/FTL13/New-FTL13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FTL13/New-FTL13/merges","archive_url":"https://api.github.com/repos/FTL13/New-FTL13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FTL13/New-FTL13/downloads","issues_url":"https://api.github.com/repos/FTL13/New-FTL13/issues{/number}","pulls_url":"https://api.github.com/repos/FTL13/New-FTL13/pulls{/number}","milestones_url":"https://api.github.com/repos/FTL13/New-FTL13/milestones{/number}","notifications_url":"https://api.github.com/repos/FTL13/New-FTL13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FTL13/New-FTL13/labels{/name}","releases_url":"https://api.github.com/repos/FTL13/New-FTL13/releases{/id}","deployments_url":"https://api.github.com/repos/FTL13/New-FTL13/deployments","created_at":"2018-09-06T00:30:50Z","updated_at":"2018-11-01T19:48:56Z","pushed_at":"2018-11-01T19:49:05Z","git_url":"git://github.com/FTL13/New-FTL13.git","ssh_url":"git@github.com:FTL13/New-FTL13.git","clone_url":"https://github.com/FTL13/New-FTL13.git","svn_url":"https://github.com/FTL13/New-FTL13","homepage":null,"size":1216609,"stargazers_count":4,"watchers_count":4,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":8,"open_issues":11,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FTL13/New-FTL13/pulls/486"},"html":{"href":"https://github.com/FTL13/New-FTL13/pull/486"},"issue":{"href":"https://api.github.com/repos/FTL13/New-FTL13/issues/486"},"comments":{"href":"https://api.github.com/repos/FTL13/New-FTL13/issues/486/comments"},"review_comments":{"href":"https://api.github.com/repos/FTL13/New-FTL13/pulls/486/comments"},"review_comment":{"href":"https://api.github.com/repos/FTL13/New-FTL13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FTL13/New-FTL13/pulls/486/commits"},"statuses":{"href":"https://api.github.com/repos/FTL13/New-FTL13/statuses/9e4d9ae41df498024a3135d88142332290f7d56d"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"TMTIME","id":29457447,"node_id":"MDQ6VXNlcjI5NDU3NDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/29457447?v=4","gravatar_id":"","url":"https://api.github.com/users/TMTIME","html_url":"https://github.com/TMTIME","followers_url":"https://api.github.com/users/TMTIME/followers","following_url":"https://api.github.com/users/TMTIME/following{/other_user}","gists_url":"https://api.github.com/users/TMTIME/gists{/gist_id}","starred_url":"https://api.github.com/users/TMTIME/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TMTIME/subscriptions","organizations_url":"https://api.github.com/users/TMTIME/orgs","repos_url":"https://api.github.com/users/TMTIME/repos","events_url":"https://api.github.com/users/TMTIME/events{/privacy}","received_events_url":"https://api.github.com/users/TMTIME/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":99,"deletions":95,"changed_files":7}}
{"actor":{"display_login":"TMTIME"}}