{"action":"closed","number":24959,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/24959","id":202267147,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjY3MTQ3","html_url":"https://github.com/angular/angular/pull/24959","diff_url":"https://github.com/angular/angular/pull/24959.diff","patch_url":"https://github.com/angular/angular/pull/24959.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/24959","number":24959,"state":"closed","locked":false,"title":"feat(router): warn if navigation triggered outside Angular zone","user":{"login":"trotyl","id":6059170,"node_id":"MDQ6VXNlcjYwNTkxNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6059170?v=4","gravatar_id":"","url":"https://api.github.com/users/trotyl","html_url":"https://github.com/trotyl","followers_url":"https://api.github.com/users/trotyl/followers","following_url":"https://api.github.com/users/trotyl/following{/other_user}","gists_url":"https://api.github.com/users/trotyl/gists{/gist_id}","starred_url":"https://api.github.com/users/trotyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trotyl/subscriptions","organizations_url":"https://api.github.com/users/trotyl/orgs","repos_url":"https://api.github.com/users/trotyl/repos","events_url":"https://api.github.com/users/trotyl/events{/privacy}","received_events_url":"https://api.github.com/users/trotyl/received_events","type":"User","site_admin":false},"body":"closes #15770, closes #15946, closes #24728\r\n\r\n## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[ ] Bugfix\r\n[x] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] angular.io application / infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\n\r\nIssue Number: #24728\r\n\r\n\r\n## What is the new behavior?\r\n\r\nProduce a warning when router navigation triggered outside Angular zone with NgZone enabled on dev mode.\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information\r\n","created_at":"2018-07-18T14:11:54Z","updated_at":"2018-09-05T16:36:36Z","closed_at":"2018-09-05T16:36:36Z","merged_at":null,"merge_commit_sha":"d756d8045a41df8cdda00a3285232fb16dc668bc","assignee":{"login":"jasonaden","id":516168,"node_id":"MDQ6VXNlcjUxNjE2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/516168?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonaden","html_url":"https://github.com/jasonaden","followers_url":"https://api.github.com/users/jasonaden/followers","following_url":"https://api.github.com/users/jasonaden/following{/other_user}","gists_url":"https://api.github.com/users/jasonaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonaden/subscriptions","organizations_url":"https://api.github.com/users/jasonaden/orgs","repos_url":"https://api.github.com/users/jasonaden/repos","events_url":"https://api.github.com/users/jasonaden/events{/privacy}","received_events_url":"https://api.github.com/users/jasonaden/received_events","type":"User","site_admin":false},"assignees":[{"login":"jasonaden","id":516168,"node_id":"MDQ6VXNlcjUxNjE2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/516168?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonaden","html_url":"https://github.com/jasonaden","followers_url":"https://api.github.com/users/jasonaden/followers","following_url":"https://api.github.com/users/jasonaden/following{/other_user}","gists_url":"https://api.github.com/users/jasonaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonaden/subscriptions","organizations_url":"https://api.github.com/users/jasonaden/orgs","repos_url":"https://api.github.com/users/jasonaden/repos","events_url":"https://api.github.com/users/jasonaden/events{/privacy}","received_events_url":"https://api.github.com/users/jasonaden/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":133556520,"node_id":"MDU6TGFiZWwxMzM1NTY1MjA=","url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20merge","name":"PR action: merge","color":"99ff66","default":false},{"id":655699838,"node_id":"MDU6TGFiZWw2NTU2OTk4Mzg=","url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master%20&%20patch","name":"PR target: master & patch","color":"5319e7","default":false},{"id":149476251,"node_id":"MDU6TGFiZWwxNDk0NzYyNTE=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":375500771,"node_id":"MDU6TGFiZWwzNzU1MDA3NzE=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20router","name":"comp: router","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/24959/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/24959/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/24959/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/f84cc03ef42db925e3769a3ec95caa0a9f5d3986","head":{"label":"trotyl:router-warn-out-zone","ref":"router-warn-out-zone","sha":"f84cc03ef42db925e3769a3ec95caa0a9f5d3986","user":{"login":"trotyl","id":6059170,"node_id":"MDQ6VXNlcjYwNTkxNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6059170?v=4","gravatar_id":"","url":"https://api.github.com/users/trotyl","html_url":"https://github.com/trotyl","followers_url":"https://api.github.com/users/trotyl/followers","following_url":"https://api.github.com/users/trotyl/following{/other_user}","gists_url":"https://api.github.com/users/trotyl/gists{/gist_id}","starred_url":"https://api.github.com/users/trotyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trotyl/subscriptions","organizations_url":"https://api.github.com/users/trotyl/orgs","repos_url":"https://api.github.com/users/trotyl/repos","events_url":"https://api.github.com/users/trotyl/events{/privacy}","received_events_url":"https://api.github.com/users/trotyl/received_events","type":"User","site_admin":false},"repo":{"id":51300790,"node_id":"MDEwOlJlcG9zaXRvcnk1MTMwMDc5MA==","name":"angular","full_name":"trotyl/angular","owner":{"login":"trotyl","id":6059170,"node_id":"MDQ6VXNlcjYwNTkxNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6059170?v=4","gravatar_id":"","url":"https://api.github.com/users/trotyl","html_url":"https://github.com/trotyl","followers_url":"https://api.github.com/users/trotyl/followers","following_url":"https://api.github.com/users/trotyl/following{/other_user}","gists_url":"https://api.github.com/users/trotyl/gists{/gist_id}","starred_url":"https://api.github.com/users/trotyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trotyl/subscriptions","organizations_url":"https://api.github.com/users/trotyl/orgs","repos_url":"https://api.github.com/users/trotyl/repos","events_url":"https://api.github.com/users/trotyl/events{/privacy}","received_events_url":"https://api.github.com/users/trotyl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trotyl/angular","description":null,"fork":true,"url":"https://api.github.com/repos/trotyl/angular","forks_url":"https://api.github.com/repos/trotyl/angular/forks","keys_url":"https://api.github.com/repos/trotyl/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trotyl/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trotyl/angular/teams","hooks_url":"https://api.github.com/repos/trotyl/angular/hooks","issue_events_url":"https://api.github.com/repos/trotyl/angular/issues/events{/number}","events_url":"https://api.github.com/repos/trotyl/angular/events","assignees_url":"https://api.github.com/repos/trotyl/angular/assignees{/user}","branches_url":"https://api.github.com/repos/trotyl/angular/branches{/branch}","tags_url":"https://api.github.com/repos/trotyl/angular/tags","blobs_url":"https://api.github.com/repos/trotyl/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trotyl/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trotyl/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/trotyl/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trotyl/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/trotyl/angular/languages","stargazers_url":"https://api.github.com/repos/trotyl/angular/stargazers","contributors_url":"https://api.github.com/repos/trotyl/angular/contributors","subscribers_url":"https://api.github.com/repos/trotyl/angular/subscribers","subscription_url":"https://api.github.com/repos/trotyl/angular/subscription","commits_url":"https://api.github.com/repos/trotyl/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/trotyl/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/trotyl/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/trotyl/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/trotyl/angular/contents/{+path}","compare_url":"https://api.github.com/repos/trotyl/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trotyl/angular/merges","archive_url":"https://api.github.com/repos/trotyl/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trotyl/angular/downloads","issues_url":"https://api.github.com/repos/trotyl/angular/issues{/number}","pulls_url":"https://api.github.com/repos/trotyl/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/trotyl/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/trotyl/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trotyl/angular/labels{/name}","releases_url":"https://api.github.com/repos/trotyl/angular/releases{/id}","deployments_url":"https://api.github.com/repos/trotyl/angular/deployments","created_at":"2016-02-08T13:56:08Z","updated_at":"2018-08-14T07:08:58Z","pushed_at":"2018-09-05T16:33:27Z","git_url":"git://github.com/trotyl/angular.git","ssh_url":"git@github.com:trotyl/angular.git","clone_url":"https://github.com/trotyl/angular.git","svn_url":"https://github.com/trotyl/angular","homepage":"https://angular.io","size":217469,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"234661b3d619f428007bbed4631474a5a50191d3","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE5NTMzOQ==","name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-09-05T16:29:42Z","pushed_at":"2018-09-05T16:35:23Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":85557,"stargazers_count":40305,"watchers_count":40305,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9849,"mirror_url":null,"archived":false,"open_issues_count":2451,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9849,"open_issues":2451,"watchers":40305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/24959"},"html":{"href":"https://github.com/angular/angular/pull/24959"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/24959"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/24959/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/24959/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/24959/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/f84cc03ef42db925e3769a3ec95caa0a9f5d3986"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":61,"deletions":4,"changed_files":3}}
{"actor":{"display_login":"mhevery"}}