{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/dmd/pulls/comments/192974217","pull_request_review_id":125851023,"id":192974217,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjk3NDIxNw==","diff_hunk":"@@ -124,12 +125,24 @@ private final class CppMangleVisitor : Visitor\n \n     /******\n      * See if `p` exists in components[]\n+     *\n+     * Note that components can contains `null` entry,","path":"src/dmd/cppmangle.d","position":13,"original_position":13,"commit_id":"281c4f135a7e6c5723ff3210ec32abe215c5d4af","original_commit_id":"281c4f135a7e6c5723ff3210ec32abe215c5d4af","user":{"login":"RazvanN7","id":22907766,"node_id":"MDQ6VXNlcjIyOTA3NzY2","avatar_url":"https://avatars2.githubusercontent.com/u/22907766?v=4","gravatar_id":"","url":"https://api.github.com/users/RazvanN7","html_url":"https://github.com/RazvanN7","followers_url":"https://api.github.com/users/RazvanN7/followers","following_url":"https://api.github.com/users/RazvanN7/following{/other_user}","gists_url":"https://api.github.com/users/RazvanN7/gists{/gist_id}","starred_url":"https://api.github.com/users/RazvanN7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RazvanN7/subscriptions","organizations_url":"https://api.github.com/users/RazvanN7/orgs","repos_url":"https://api.github.com/users/RazvanN7/repos","events_url":"https://api.github.com/users/RazvanN7/events{/privacy}","received_events_url":"https://api.github.com/users/RazvanN7/received_events","type":"User","site_admin":false},"body":"can **contain** `null` **entries**","created_at":"2018-06-05T07:39:01Z","updated_at":"2018-06-05T07:45:32Z","html_url":"https://github.com/dlang/dmd/pull/8332#discussion_r192974217","pull_request_url":"https://api.github.com/repos/dlang/dmd/pulls/8332","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments/192974217"},"html":{"href":"https://github.com/dlang/dmd/pull/8332#discussion_r192974217"},"pull_request":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8332"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/8332","id":192567607,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTY3NjA3","html_url":"https://github.com/dlang/dmd/pull/8332","diff_url":"https://github.com/dlang/dmd/pull/8332.diff","patch_url":"https://github.com/dlang/dmd/pull/8332.patch","issue_url":"https://api.github.com/repos/dlang/dmd/issues/8332","number":8332,"state":"open","locked":false,"title":" Fix issue 18922: No substitutions for C++ namespaces in different module/file","user":{"login":"Geod24","id":2180215,"node_id":"MDQ6VXNlcjIxODAyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2180215?v=4","gravatar_id":"","url":"https://api.github.com/users/Geod24","html_url":"https://github.com/Geod24","followers_url":"https://api.github.com/users/Geod24/followers","following_url":"https://api.github.com/users/Geod24/following{/other_user}","gists_url":"https://api.github.com/users/Geod24/gists{/gist_id}","starred_url":"https://api.github.com/users/Geod24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geod24/subscriptions","organizations_url":"https://api.github.com/users/Geod24/orgs","repos_url":"https://api.github.com/users/Geod24/repos","events_url":"https://api.github.com/users/Geod24/events{/privacy}","received_events_url":"https://api.github.com/users/Geod24/received_events","type":"User","site_admin":false},"body":"```\r\nDMD was just comparing the object by their reference instead of their string value.\r\nObviously when a namespace is declared in another module, the reference is different.\r\n```\r\n\r\nThere are two other small refactors in this PR, which can be taken out at will.\r\nBut since they are different commits, they shouldn't be a problem either for `git revert` or reviewers (juse review commit by commit and/or ignore whitespace).\r\n\r\nAlso tested it on a large C++ project I am porting to D (on Linux x64).","created_at":"2018-06-05T01:22:22Z","updated_at":"2018-06-05T07:45:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8146f70f96d6695a24b526c3a726e9be5e18a870","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ibuclaw","id":397929,"node_id":"MDQ6VXNlcjM5NzkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/397929?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":537492633,"node_id":"MDU6TGFiZWw1Mzc0OTI2MzM=","url":"https://api.github.com/repos/dlang/dmd/labels/Bug%20Fix","name":"Bug Fix","color":"0052cc","default":false},{"id":876579237,"node_id":"MDU6TGFiZWw4NzY1NzkyMzc=","url":"https://api.github.com/repos/dlang/dmd/labels/Vision","name":"Vision","color":"aafc07","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/dmd/pulls/8332/commits","review_comments_url":"https://api.github.com/repos/dlang/dmd/pulls/8332/comments","review_comment_url":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/8332/comments","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/281c4f135a7e6c5723ff3210ec32abe215c5d4af","head":{"label":"Geod24:fix18922","ref":"fix18922","sha":"281c4f135a7e6c5723ff3210ec32abe215c5d4af","user":{"login":"Geod24","id":2180215,"node_id":"MDQ6VXNlcjIxODAyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2180215?v=4","gravatar_id":"","url":"https://api.github.com/users/Geod24","html_url":"https://github.com/Geod24","followers_url":"https://api.github.com/users/Geod24/followers","following_url":"https://api.github.com/users/Geod24/following{/other_user}","gists_url":"https://api.github.com/users/Geod24/gists{/gist_id}","starred_url":"https://api.github.com/users/Geod24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geod24/subscriptions","organizations_url":"https://api.github.com/users/Geod24/orgs","repos_url":"https://api.github.com/users/Geod24/repos","events_url":"https://api.github.com/users/Geod24/events{/privacy}","received_events_url":"https://api.github.com/users/Geod24/received_events","type":"User","site_admin":false},"repo":{"id":13699152,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5OTE1Mg==","name":"dmd","full_name":"Geod24/dmd","owner":{"login":"Geod24","id":2180215,"node_id":"MDQ6VXNlcjIxODAyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2180215?v=4","gravatar_id":"","url":"https://api.github.com/users/Geod24","html_url":"https://github.com/Geod24","followers_url":"https://api.github.com/users/Geod24/followers","following_url":"https://api.github.com/users/Geod24/following{/other_user}","gists_url":"https://api.github.com/users/Geod24/gists{/gist_id}","starred_url":"https://api.github.com/users/Geod24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geod24/subscriptions","organizations_url":"https://api.github.com/users/Geod24/orgs","repos_url":"https://api.github.com/users/Geod24/repos","events_url":"https://api.github.com/users/Geod24/events{/privacy}","received_events_url":"https://api.github.com/users/Geod24/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Geod24/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/Geod24/dmd","forks_url":"https://api.github.com/repos/Geod24/dmd/forks","keys_url":"https://api.github.com/repos/Geod24/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Geod24/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Geod24/dmd/teams","hooks_url":"https://api.github.com/repos/Geod24/dmd/hooks","issue_events_url":"https://api.github.com/repos/Geod24/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/Geod24/dmd/events","assignees_url":"https://api.github.com/repos/Geod24/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/Geod24/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/Geod24/dmd/tags","blobs_url":"https://api.github.com/repos/Geod24/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Geod24/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Geod24/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Geod24/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Geod24/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/Geod24/dmd/languages","stargazers_url":"https://api.github.com/repos/Geod24/dmd/stargazers","contributors_url":"https://api.github.com/repos/Geod24/dmd/contributors","subscribers_url":"https://api.github.com/repos/Geod24/dmd/subscribers","subscription_url":"https://api.github.com/repos/Geod24/dmd/subscription","commits_url":"https://api.github.com/repos/Geod24/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Geod24/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Geod24/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Geod24/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Geod24/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/Geod24/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Geod24/dmd/merges","archive_url":"https://api.github.com/repos/Geod24/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Geod24/dmd/downloads","issues_url":"https://api.github.com/repos/Geod24/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/Geod24/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/Geod24/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/Geod24/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Geod24/dmd/labels{/name}","releases_url":"https://api.github.com/repos/Geod24/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/Geod24/dmd/deployments","created_at":"2013-10-19T10:08:56Z","updated_at":"2018-05-31T09:14:22Z","pushed_at":"2018-06-05T03:43:54Z","git_url":"git://github.com/Geod24/dmd.git","ssh_url":"git@github.com:Geod24/dmd.git","clone_url":"https://github.com/Geod24/dmd.git","svn_url":"https://github.com/Geod24/dmd","homepage":"dlang.org","size":85126,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"70298baffc21ef8b9a548ba9d0c5c7053f3a2b23","user":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3MDcw","name":"dmd","full_name":"dlang/dmd","owner":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/dlang/dmd","forks_url":"https://api.github.com/repos/dlang/dmd/forks","keys_url":"https://api.github.com/repos/dlang/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dmd/teams","hooks_url":"https://api.github.com/repos/dlang/dmd/hooks","issue_events_url":"https://api.github.com/repos/dlang/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dmd/events","assignees_url":"https://api.github.com/repos/dlang/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dmd/tags","blobs_url":"https://api.github.com/repos/dlang/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dmd/languages","stargazers_url":"https://api.github.com/repos/dlang/dmd/stargazers","contributors_url":"https://api.github.com/repos/dlang/dmd/contributors","subscribers_url":"https://api.github.com/repos/dlang/dmd/subscribers","subscription_url":"https://api.github.com/repos/dlang/dmd/subscription","commits_url":"https://api.github.com/repos/dlang/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dmd/merges","archive_url":"https://api.github.com/repos/dlang/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dmd/downloads","issues_url":"https://api.github.com/repos/dlang/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dmd/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dmd/deployments","created_at":"2011-01-15T06:53:53Z","updated_at":"2018-06-05T06:04:49Z","pushed_at":"2018-06-05T07:23:28Z","git_url":"git://github.com/dlang/dmd.git","ssh_url":"git@github.com:dlang/dmd.git","clone_url":"https://github.com/dlang/dmd.git","svn_url":"https://github.com/dlang/dmd","homepage":"dlang.org","size":89786,"stargazers_count":1798,"watchers_count":1798,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":450,"mirror_url":null,"archived":false,"open_issues_count":131,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":450,"open_issues":131,"watchers":1798,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8332"},"html":{"href":"https://github.com/dlang/dmd/pull/8332"},"issue":{"href":"https://api.github.com/repos/dlang/dmd/issues/8332"},"comments":{"href":"https://api.github.com/repos/dlang/dmd/issues/8332/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8332/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8332/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dmd/statuses/281c4f135a7e6c5723ff3210ec32abe215c5d4af"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RazvanN7"}}