{"action":"created","comment":{"url":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls/comments/166219499","pull_request_review_id":94259958,"id":166219499,"diff_hunk":"@@ -47,11 +47,11 @@ def zfits_event_source(\n \n     loaded_telescopes = []\n \n-    for event in protozfitsreader.ZFile(url):\n-        if max_events is not None and event.event_id > max_events:\n+    for event_counter, event in enumerate(protozfitsreader.ZFile(url)):\n+        if max_events is not None and event_counter > max_events:\n             break\n \n-        data.r0.event_id = event.event_id\n+        data.r0.event_id = event_counter","path":"digicampipe/io/zfits.py","position":11,"original_position":11,"commit_id":"64d3e697e63da201c93a79149f7bead8b4a62fbb","original_commit_id":"64d3e697e63da201c93a79149f7bead8b4a62fbb","user":{"login":"calispac","id":23462345,"avatar_url":"https://avatars0.githubusercontent.com/u/23462345?v=4","gravatar_id":"","url":"https://api.github.com/users/calispac","html_url":"https://github.com/calispac","followers_url":"https://api.github.com/users/calispac/followers","following_url":"https://api.github.com/users/calispac/following{/other_user}","gists_url":"https://api.github.com/users/calispac/gists{/gist_id}","starred_url":"https://api.github.com/users/calispac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calispac/subscriptions","organizations_url":"https://api.github.com/users/calispac/orgs","repos_url":"https://api.github.com/users/calispac/repos","events_url":"https://api.github.com/users/calispac/events{/privacy}","received_events_url":"https://api.github.com/users/calispac/received_events","type":"User","site_admin":false},"body":"I think it is supposed to be like this\r\n\r\n```python\r\nclass R0Container(Container):\r\n    array_event_id = Field(-1, \"Array event identification number\")\r\n    tel = Field(Map(R0CameraContainer), \"map of tel_id to R0CameraContainer\")\r\n\r\nclass R0CameraContainer(Container):\r\n    camera_event_id = Field(int, 'Camera event identification number')\r\n```","created_at":"2018-02-06T08:42:53Z","updated_at":"2018-02-06T08:42:53Z","html_url":"https://github.com/cta-sst-1m/digicampipe/pull/104#discussion_r166219499","pull_request_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls/104","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls/comments/166219499"},"html":{"href":"https://github.com/cta-sst-1m/digicampipe/pull/104#discussion_r166219499"},"pull_request":{"href":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls/104"}},"in_reply_to_id":166215635},"pull_request":{"url":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls/104","id":167152001,"html_url":"https://github.com/cta-sst-1m/digicampipe/pull/104","diff_url":"https://github.com/cta-sst-1m/digicampipe/pull/104.diff","patch_url":"https://github.com/cta-sst-1m/digicampipe/pull/104.patch","issue_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues/104","number":104,"state":"closed","locked":false,"title":"Protozfitsreader issues","user":{"login":"dneise","id":8200858,"avatar_url":"https://avatars2.githubusercontent.com/u/8200858?v=4","gravatar_id":"","url":"https://api.github.com/users/dneise","html_url":"https://github.com/dneise","followers_url":"https://api.github.com/users/dneise/followers","following_url":"https://api.github.com/users/dneise/following{/other_user}","gists_url":"https://api.github.com/users/dneise/gists{/gist_id}","starred_url":"https://api.github.com/users/dneise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneise/subscriptions","organizations_url":"https://api.github.com/users/dneise/orgs","repos_url":"https://api.github.com/users/dneise/repos","events_url":"https://api.github.com/users/dneise/events{/privacy}","received_events_url":"https://api.github.com/users/dneise/received_events","type":"User","site_admin":false},"body":"working on #102 \r\n\r\nwhich is basically discussed here:\r\nhttps://github.com/cta-sst-1m/protozfitsreader/pull/10","created_at":"2018-02-05T14:03:41Z","updated_at":"2018-02-06T08:42:53Z","closed_at":"2018-02-06T08:37:19Z","merged_at":"2018-02-06T08:37:19Z","merge_commit_sha":"b97fe082bd49348cef037f64cdab4738dbecd7d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls/104/commits","review_comments_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls/104/comments","review_comment_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues/104/comments","statuses_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/statuses/64d3e697e63da201c93a79149f7bead8b4a62fbb","head":{"label":"cta-sst-1m:protozfitsreader_issues","ref":"protozfitsreader_issues","sha":"64d3e697e63da201c93a79149f7bead8b4a62fbb","user":{"login":"cta-sst-1m","id":33890847,"avatar_url":"https://avatars3.githubusercontent.com/u/33890847?v=4","gravatar_id":"","url":"https://api.github.com/users/cta-sst-1m","html_url":"https://github.com/cta-sst-1m","followers_url":"https://api.github.com/users/cta-sst-1m/followers","following_url":"https://api.github.com/users/cta-sst-1m/following{/other_user}","gists_url":"https://api.github.com/users/cta-sst-1m/gists{/gist_id}","starred_url":"https://api.github.com/users/cta-sst-1m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cta-sst-1m/subscriptions","organizations_url":"https://api.github.com/users/cta-sst-1m/orgs","repos_url":"https://api.github.com/users/cta-sst-1m/repos","events_url":"https://api.github.com/users/cta-sst-1m/events{/privacy}","received_events_url":"https://api.github.com/users/cta-sst-1m/received_events","type":"Organization","site_admin":false},"repo":{"id":102357407,"name":"digicampipe","full_name":"cta-sst-1m/digicampipe","owner":{"login":"cta-sst-1m","id":33890847,"avatar_url":"https://avatars3.githubusercontent.com/u/33890847?v=4","gravatar_id":"","url":"https://api.github.com/users/cta-sst-1m","html_url":"https://github.com/cta-sst-1m","followers_url":"https://api.github.com/users/cta-sst-1m/followers","following_url":"https://api.github.com/users/cta-sst-1m/following{/other_user}","gists_url":"https://api.github.com/users/cta-sst-1m/gists{/gist_id}","starred_url":"https://api.github.com/users/cta-sst-1m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cta-sst-1m/subscriptions","organizations_url":"https://api.github.com/users/cta-sst-1m/orgs","repos_url":"https://api.github.com/users/cta-sst-1m/repos","events_url":"https://api.github.com/users/cta-sst-1m/events{/privacy}","received_events_url":"https://api.github.com/users/cta-sst-1m/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cta-sst-1m/digicampipe","description":"DigiCam pipeline based on ctapipe","fork":false,"url":"https://api.github.com/repos/cta-sst-1m/digicampipe","forks_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/forks","keys_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/teams","hooks_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/hooks","issue_events_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues/events{/number}","events_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/events","assignees_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/assignees{/user}","branches_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/branches{/branch}","tags_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/tags","blobs_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/git/refs{/sha}","trees_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/statuses/{sha}","languages_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/languages","stargazers_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/stargazers","contributors_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/contributors","subscribers_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/subscribers","subscription_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/subscription","commits_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/commits{/sha}","git_commits_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/git/commits{/sha}","comments_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/comments{/number}","issue_comment_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues/comments{/number}","contents_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/contents/{+path}","compare_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/merges","archive_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/downloads","issues_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues{/number}","pulls_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls{/number}","milestones_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/milestones{/number}","notifications_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/labels{/name}","releases_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/releases{/id}","deployments_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/deployments","created_at":"2017-09-04T12:09:44Z","updated_at":"2018-01-22T12:32:16Z","pushed_at":"2018-02-06T08:37:25Z","git_url":"git://github.com/cta-sst-1m/digicampipe.git","ssh_url":"git@github.com:cta-sst-1m/digicampipe.git","clone_url":"https://github.com/cta-sst-1m/digicampipe.git","svn_url":"https://github.com/cta-sst-1m/digicampipe","homepage":null,"size":148544,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":19,"watchers":0,"default_branch":"master"}},"base":{"label":"cta-sst-1m:master","ref":"master","sha":"f28d88083cbeb7c823905a862ec83197040a6aac","user":{"login":"cta-sst-1m","id":33890847,"avatar_url":"https://avatars3.githubusercontent.com/u/33890847?v=4","gravatar_id":"","url":"https://api.github.com/users/cta-sst-1m","html_url":"https://github.com/cta-sst-1m","followers_url":"https://api.github.com/users/cta-sst-1m/followers","following_url":"https://api.github.com/users/cta-sst-1m/following{/other_user}","gists_url":"https://api.github.com/users/cta-sst-1m/gists{/gist_id}","starred_url":"https://api.github.com/users/cta-sst-1m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cta-sst-1m/subscriptions","organizations_url":"https://api.github.com/users/cta-sst-1m/orgs","repos_url":"https://api.github.com/users/cta-sst-1m/repos","events_url":"https://api.github.com/users/cta-sst-1m/events{/privacy}","received_events_url":"https://api.github.com/users/cta-sst-1m/received_events","type":"Organization","site_admin":false},"repo":{"id":102357407,"name":"digicampipe","full_name":"cta-sst-1m/digicampipe","owner":{"login":"cta-sst-1m","id":33890847,"avatar_url":"https://avatars3.githubusercontent.com/u/33890847?v=4","gravatar_id":"","url":"https://api.github.com/users/cta-sst-1m","html_url":"https://github.com/cta-sst-1m","followers_url":"https://api.github.com/users/cta-sst-1m/followers","following_url":"https://api.github.com/users/cta-sst-1m/following{/other_user}","gists_url":"https://api.github.com/users/cta-sst-1m/gists{/gist_id}","starred_url":"https://api.github.com/users/cta-sst-1m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cta-sst-1m/subscriptions","organizations_url":"https://api.github.com/users/cta-sst-1m/orgs","repos_url":"https://api.github.com/users/cta-sst-1m/repos","events_url":"https://api.github.com/users/cta-sst-1m/events{/privacy}","received_events_url":"https://api.github.com/users/cta-sst-1m/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cta-sst-1m/digicampipe","description":"DigiCam pipeline based on ctapipe","fork":false,"url":"https://api.github.com/repos/cta-sst-1m/digicampipe","forks_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/forks","keys_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/teams","hooks_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/hooks","issue_events_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues/events{/number}","events_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/events","assignees_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/assignees{/user}","branches_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/branches{/branch}","tags_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/tags","blobs_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/git/refs{/sha}","trees_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/statuses/{sha}","languages_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/languages","stargazers_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/stargazers","contributors_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/contributors","subscribers_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/subscribers","subscription_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/subscription","commits_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/commits{/sha}","git_commits_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/git/commits{/sha}","comments_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/comments{/number}","issue_comment_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues/comments{/number}","contents_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/contents/{+path}","compare_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/merges","archive_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/downloads","issues_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues{/number}","pulls_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls{/number}","milestones_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/milestones{/number}","notifications_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/labels{/name}","releases_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/releases{/id}","deployments_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/deployments","created_at":"2017-09-04T12:09:44Z","updated_at":"2018-01-22T12:32:16Z","pushed_at":"2018-02-06T08:37:25Z","git_url":"git://github.com/cta-sst-1m/digicampipe.git","ssh_url":"git@github.com:cta-sst-1m/digicampipe.git","clone_url":"https://github.com/cta-sst-1m/digicampipe.git","svn_url":"https://github.com/cta-sst-1m/digicampipe","homepage":null,"size":148544,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":19,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls/104"},"html":{"href":"https://github.com/cta-sst-1m/digicampipe/pull/104"},"issue":{"href":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues/104"},"comments":{"href":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/cta-sst-1m/digicampipe/statuses/64d3e697e63da201c93a79149f7bead8b4a62fbb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"calispac"}}