{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/174836637","pull_request_review_id":104267118,"id":174836637,"diff_hunk":"@@ -576,7 +578,8 @@ import '$testUrl' as test;\n \n void main() {\n   print('$_kStartTimeoutTimerMessage');\n-  String server = Uri.decodeComponent('$encodedWebsocketUrl');\n+  String serverPort = Platform.environment['SERVER_PORT'];\n+  String server = Uri.decodeComponent('$encodedWebsocketUrl:$serverPort');","path":"packages/flutter_tools/lib/src/test/flutter_platform.dart","position":null,"original_position":48,"commit_id":"034295bae4977271b5cfbd24519c43659c135bdd","original_commit_id":"072b30f4676f3b066ff1529cce7db2d80eb37866","user":{"login":"keertip","id":2192312,"avatar_url":"https://avatars2.githubusercontent.com/u/2192312?v=4","gravatar_id":"","url":"https://api.github.com/users/keertip","html_url":"https://github.com/keertip","followers_url":"https://api.github.com/users/keertip/followers","following_url":"https://api.github.com/users/keertip/following{/other_user}","gists_url":"https://api.github.com/users/keertip/gists{/gist_id}","starred_url":"https://api.github.com/users/keertip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keertip/subscriptions","organizations_url":"https://api.github.com/users/keertip/orgs","repos_url":"https://api.github.com/users/keertip/repos","events_url":"https://api.github.com/users/keertip/events{/privacy}","received_events_url":"https://api.github.com/users/keertip/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-03-15T15:59:52Z","updated_at":"2018-03-15T15:59:52Z","html_url":"https://github.com/flutter/flutter/pull/15535#discussion_r174836637","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/15535","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/174836637"},"html":{"href":"https://github.com/flutter/flutter/pull/15535#discussion_r174836637"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/15535"}},"in_reply_to_id":174832699},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/15535","id":175104468,"html_url":"https://github.com/flutter/flutter/pull/15535","diff_url":"https://github.com/flutter/flutter/pull/15535.diff","patch_url":"https://github.com/flutter/flutter/pull/15535.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/15535","number":15535,"state":"open","locked":false,"title":"Do not encode the server port in the test file","user":{"login":"keertip","id":2192312,"avatar_url":"https://avatars2.githubusercontent.com/u/2192312?v=4","gravatar_id":"","url":"https://api.github.com/users/keertip","html_url":"https://github.com/keertip","followers_url":"https://api.github.com/users/keertip/followers","following_url":"https://api.github.com/users/keertip/following{/other_user}","gists_url":"https://api.github.com/users/keertip/gists{/gist_id}","starred_url":"https://api.github.com/users/keertip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keertip/subscriptions","organizations_url":"https://api.github.com/users/keertip/orgs","repos_url":"https://api.github.com/users/keertip/repos","events_url":"https://api.github.com/users/keertip/events{/privacy}","received_events_url":"https://api.github.com/users/keertip/received_events","type":"User","site_admin":false},"body":"Remove the encoding the port information for the web socket connection at test file generation time,  instead set it as an environment variable. This allows for the test file to be created and kernel generated without any test harness specific information.","created_at":"2018-03-14T22:39:20Z","updated_at":"2018-03-15T15:59:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"849f705a3cba9903737c75df0ab89cc793f9092c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/15535/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/15535/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/15535/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/034295bae4977271b5cfbd24519c43659c135bdd","head":{"label":"keertip:flutter_tests","ref":"flutter_tests","sha":"034295bae4977271b5cfbd24519c43659c135bdd","user":{"login":"keertip","id":2192312,"avatar_url":"https://avatars2.githubusercontent.com/u/2192312?v=4","gravatar_id":"","url":"https://api.github.com/users/keertip","html_url":"https://github.com/keertip","followers_url":"https://api.github.com/users/keertip/followers","following_url":"https://api.github.com/users/keertip/following{/other_user}","gists_url":"https://api.github.com/users/keertip/gists{/gist_id}","starred_url":"https://api.github.com/users/keertip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keertip/subscriptions","organizations_url":"https://api.github.com/users/keertip/orgs","repos_url":"https://api.github.com/users/keertip/repos","events_url":"https://api.github.com/users/keertip/events{/privacy}","received_events_url":"https://api.github.com/users/keertip/received_events","type":"User","site_admin":false},"repo":{"id":87237015,"name":"flutter","full_name":"keertip/flutter","owner":{"login":"keertip","id":2192312,"avatar_url":"https://avatars2.githubusercontent.com/u/2192312?v=4","gravatar_id":"","url":"https://api.github.com/users/keertip","html_url":"https://github.com/keertip","followers_url":"https://api.github.com/users/keertip/followers","following_url":"https://api.github.com/users/keertip/following{/other_user}","gists_url":"https://api.github.com/users/keertip/gists{/gist_id}","starred_url":"https://api.github.com/users/keertip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keertip/subscriptions","organizations_url":"https://api.github.com/users/keertip/orgs","repos_url":"https://api.github.com/users/keertip/repos","events_url":"https://api.github.com/users/keertip/events{/privacy}","received_events_url":"https://api.github.com/users/keertip/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keertip/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":true,"url":"https://api.github.com/repos/keertip/flutter","forks_url":"https://api.github.com/repos/keertip/flutter/forks","keys_url":"https://api.github.com/repos/keertip/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keertip/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keertip/flutter/teams","hooks_url":"https://api.github.com/repos/keertip/flutter/hooks","issue_events_url":"https://api.github.com/repos/keertip/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/keertip/flutter/events","assignees_url":"https://api.github.com/repos/keertip/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/keertip/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/keertip/flutter/tags","blobs_url":"https://api.github.com/repos/keertip/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keertip/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keertip/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/keertip/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keertip/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/keertip/flutter/languages","stargazers_url":"https://api.github.com/repos/keertip/flutter/stargazers","contributors_url":"https://api.github.com/repos/keertip/flutter/contributors","subscribers_url":"https://api.github.com/repos/keertip/flutter/subscribers","subscription_url":"https://api.github.com/repos/keertip/flutter/subscription","commits_url":"https://api.github.com/repos/keertip/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/keertip/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/keertip/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/keertip/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/keertip/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/keertip/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keertip/flutter/merges","archive_url":"https://api.github.com/repos/keertip/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keertip/flutter/downloads","issues_url":"https://api.github.com/repos/keertip/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/keertip/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/keertip/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/keertip/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keertip/flutter/labels{/name}","releases_url":"https://api.github.com/repos/keertip/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/keertip/flutter/deployments","created_at":"2017-04-04T21:31:13Z","updated_at":"2017-09-11T16:51:06Z","pushed_at":"2018-03-15T15:59:37Z","git_url":"git://github.com/keertip/flutter.git","ssh_url":"git@github.com:keertip/flutter.git","clone_url":"https://github.com/keertip/flutter.git","svn_url":"https://github.com/keertip/flutter","homepage":"https://flutter.io","size":35817,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"b6cca3923adbd5ba29a304d8a8ba7c2d17f5ad8a","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-03-15T15:54:12Z","pushed_at":"2018-03-15T15:59:39Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":35839,"stargazers_count":18718,"watchers_count":18718,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1493,"mirror_url":null,"archived":false,"open_issues_count":2552,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1493,"open_issues":2552,"watchers":18718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/15535"},"html":{"href":"https://github.com/flutter/flutter/pull/15535"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/15535"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/15535/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/15535/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/15535/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/034295bae4977271b5cfbd24519c43659c135bdd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"keertip"}}