{"action":"created","issue":{"url":"https://api.github.com/repos/pulp-platform/ariane/issues/90","repository_url":"https://api.github.com/repos/pulp-platform/ariane","labels_url":"https://api.github.com/repos/pulp-platform/ariane/issues/90/labels{/name}","comments_url":"https://api.github.com/repos/pulp-platform/ariane/issues/90/comments","events_url":"https://api.github.com/repos/pulp-platform/ariane/issues/90/events","html_url":"https://github.com/pulp-platform/ariane/pull/90","id":355658711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTM2MTky","number":90,"title":"Small changes into the Ariane","user":{"login":"lvcargnini","id":106595,"node_id":"MDQ6VXNlcjEwNjU5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/106595?v=4","gravatar_id":"","url":"https://api.github.com/users/lvcargnini","html_url":"https://github.com/lvcargnini","followers_url":"https://api.github.com/users/lvcargnini/followers","following_url":"https://api.github.com/users/lvcargnini/following{/other_user}","gists_url":"https://api.github.com/users/lvcargnini/gists{/gist_id}","starred_url":"https://api.github.com/users/lvcargnini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvcargnini/subscriptions","organizations_url":"https://api.github.com/users/lvcargnini/orgs","repos_url":"https://api.github.com/users/lvcargnini/repos","events_url":"https://api.github.com/users/lvcargnini/events{/privacy}","received_events_url":"https://api.github.com/users/lvcargnini/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"msfschaffner","id":41358501,"node_id":"MDQ6VXNlcjQxMzU4NTAx","avatar_url":"https://avatars1.githubusercontent.com/u/41358501?v=4","gravatar_id":"","url":"https://api.github.com/users/msfschaffner","html_url":"https://github.com/msfschaffner","followers_url":"https://api.github.com/users/msfschaffner/followers","following_url":"https://api.github.com/users/msfschaffner/following{/other_user}","gists_url":"https://api.github.com/users/msfschaffner/gists{/gist_id}","starred_url":"https://api.github.com/users/msfschaffner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msfschaffner/subscriptions","organizations_url":"https://api.github.com/users/msfschaffner/orgs","repos_url":"https://api.github.com/users/msfschaffner/repos","events_url":"https://api.github.com/users/msfschaffner/events{/privacy}","received_events_url":"https://api.github.com/users/msfschaffner/received_events","type":"User","site_admin":false},"assignees":[{"login":"msfschaffner","id":41358501,"node_id":"MDQ6VXNlcjQxMzU4NTAx","avatar_url":"https://avatars1.githubusercontent.com/u/41358501?v=4","gravatar_id":"","url":"https://api.github.com/users/msfschaffner","html_url":"https://github.com/msfschaffner","followers_url":"https://api.github.com/users/msfschaffner/followers","following_url":"https://api.github.com/users/msfschaffner/following{/other_user}","gists_url":"https://api.github.com/users/msfschaffner/gists{/gist_id}","starred_url":"https://api.github.com/users/msfschaffner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msfschaffner/subscriptions","organizations_url":"https://api.github.com/users/msfschaffner/orgs","repos_url":"https://api.github.com/users/msfschaffner/repos","events_url":"https://api.github.com/users/msfschaffner/events{/privacy}","received_events_url":"https://api.github.com/users/msfschaffner/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-08-30T16:18:58Z","updated_at":"2018-08-30T17:26:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/pulp-platform/ariane/pulls/90","html_url":"https://github.com/pulp-platform/ariane/pull/90","diff_url":"https://github.com/pulp-platform/ariane/pull/90.diff","patch_url":"https://github.com/pulp-platform/ariane/pull/90.patch"},"body":"I spread some modules from the frontend into multiple files, just for the organization of the design, instead of a single file containing multiple modules I place each module in its file.\r\n\r\nAlso, I added four modules, one it is a generic that IC flows and FPGA flows translate into an asynchronous DFF. Also added a register model based on it. Added two generic SRAM modules, that on FPGA will be translated into its counterpart on BRAM automatically.  Needs to be improved to support both IC and FPGA flows, for it works on FPGA,  on ASIC it creates a sea of DFFs.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pulp-platform/ariane/issues/comments/417400872","html_url":"https://github.com/pulp-platform/ariane/pull/90#issuecomment-417400872","issue_url":"https://api.github.com/repos/pulp-platform/ariane/issues/90","id":417400872,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzQwMDg3Mg==","user":{"login":"zarubaf","id":199415,"node_id":"MDQ6VXNlcjE5OTQxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/199415?v=4","gravatar_id":"","url":"https://api.github.com/users/zarubaf","html_url":"https://github.com/zarubaf","followers_url":"https://api.github.com/users/zarubaf/followers","following_url":"https://api.github.com/users/zarubaf/following{/other_user}","gists_url":"https://api.github.com/users/zarubaf/gists{/gist_id}","starred_url":"https://api.github.com/users/zarubaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarubaf/subscriptions","organizations_url":"https://api.github.com/users/zarubaf/orgs","repos_url":"https://api.github.com/users/zarubaf/repos","events_url":"https://api.github.com/users/zarubaf/events{/privacy}","received_events_url":"https://api.github.com/users/zarubaf/received_events","type":"User","site_admin":false},"created_at":"2018-08-30T17:26:46Z","updated_at":"2018-08-30T17:26:46Z","author_association":"MEMBER","body":"Thanks.\r\n\r\nI am okay with pulling out the modules as separate files. At a certain point in the future we might need to add some sub-folders. Furthermore I think we need to adapt the `src_files.yml` and the `Bender.yml` to also list the new sources. (If you want you can make a new PR with only those changes + listing them in the two files).\r\n\r\nFor the FPGA part I am adding @msfschaffner as a reviewer he actually having similar efforts right now and we do already have BRAM genrating SRAMs in the ariane_next branch (might want to take a look at the `fpga_support` subrepo). Lets try to reduce duplicate files and efforts as much as possible. "}}
{"actor":{"display_login":"zarubaf"}}