{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/sockeye/pulls/comments/190216892","pull_request_review_id":122547503,"id":190216892,"diff_hunk":"@@ -0,0 +1,12 @@\n+# Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.","path":"test/integration/image_captioning/__init__.py","position":1,"original_position":1,"commit_id":"4b28ad2745fe58789d7edfce730196890aa34914","original_commit_id":"4b28ad2745fe58789d7edfce730196890aa34914","user":{"login":"lorisbaz","id":9000459,"avatar_url":"https://avatars3.githubusercontent.com/u/9000459?v=4","gravatar_id":"","url":"https://api.github.com/users/lorisbaz","html_url":"https://github.com/lorisbaz","followers_url":"https://api.github.com/users/lorisbaz/followers","following_url":"https://api.github.com/users/lorisbaz/following{/other_user}","gists_url":"https://api.github.com/users/lorisbaz/gists{/gist_id}","starred_url":"https://api.github.com/users/lorisbaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorisbaz/subscriptions","organizations_url":"https://api.github.com/users/lorisbaz/orgs","repos_url":"https://api.github.com/users/lorisbaz/repos","events_url":"https://api.github.com/users/lorisbaz/events{/privacy}","received_events_url":"https://api.github.com/users/lorisbaz/received_events","type":"User","site_admin":false},"body":"About `2-conv-layer-*` files, I did not use temp files because those files were reused by 3 tests. So I do not need to create them every time. \r\n\r\nI will use temp files for all the ones you listed above.","created_at":"2018-05-23T11:51:07Z","updated_at":"2018-05-23T11:51:07Z","html_url":"https://github.com/awslabs/sockeye/pull/390#discussion_r190216892","pull_request_url":"https://api.github.com/repos/awslabs/sockeye/pulls/390","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/sockeye/pulls/comments/190216892"},"html":{"href":"https://github.com/awslabs/sockeye/pull/390#discussion_r190216892"},"pull_request":{"href":"https://api.github.com/repos/awslabs/sockeye/pulls/390"}},"in_reply_to_id":190186553},"pull_request":{"url":"https://api.github.com/repos/awslabs/sockeye/pulls/390","id":187415863,"html_url":"https://github.com/awslabs/sockeye/pull/390","diff_url":"https://github.com/awslabs/sockeye/pull/390.diff","patch_url":"https://github.com/awslabs/sockeye/pull/390.patch","issue_url":"https://api.github.com/repos/awslabs/sockeye/issues/390","number":390,"state":"open","locked":false,"title":"Introducing the image captioning module","user":{"login":"lorisbaz","id":9000459,"avatar_url":"https://avatars3.githubusercontent.com/u/9000459?v=4","gravatar_id":"","url":"https://api.github.com/users/lorisbaz","html_url":"https://github.com/lorisbaz","followers_url":"https://api.github.com/users/lorisbaz/followers","following_url":"https://api.github.com/users/lorisbaz/following{/other_user}","gists_url":"https://api.github.com/users/lorisbaz/gists{/gist_id}","starred_url":"https://api.github.com/users/lorisbaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorisbaz/subscriptions","organizations_url":"https://api.github.com/users/lorisbaz/orgs","repos_url":"https://api.github.com/users/lorisbaz/repos","events_url":"https://api.github.com/users/lorisbaz/events{/privacy}","received_events_url":"https://api.github.com/users/lorisbaz/received_events","type":"User","site_admin":false},"body":"Introducing the image captioning module. Type of models supported: ConvNet encoder - Sockeye NMT decoders\r\n\r\nFeatures:\r\n\r\n-   Image encoder that extracts features using preetrained nets: `image_captioning.encoder`\r\n-   Feature extraction script to dump features to disk `image_captioning.extract_features`\r\n-   Pass-through embedding, since we do not need it for images\r\n-   Image-text iterator that loads features on the fly during training with the option of loading all to memory: `image_captioning.data_io`\r\n-   Training and inference pipelines for image captioning: `image_captioning.train`, `image_captioning.inference` and `image_captioning.captioner`\r\n-   README with instructions on how to use the image captioning module: `image_captioning/README.md`\r\n-   Visualization script that loads images and captions (prediction+ground truth) and display them: `image_captioning.visualize`\r\n\r\n(description of the change)\r\n\r\n#### Pull Request Checklist ##\r\n- [x] Changes are complete (if posting work-in-progress code, prefix your pull request title with '[WIP]'\r\nuntil you can check this box.\r\n- [x] Unit tests pass (`pytest`)\r\n- [x] Were system tests modified? If so did you run these at least 5 times to account for the variation across runs? - Not modified!\r\n- [x] System tests pass (`pytest test/system`)\r\n- [x] Passed code style checking (`./style-check.sh`)\r\n- [x] You have considered writing a test\r\n- [x] Updated major/minor version in `sockeye/__init__.py`. Major version bump if this is a backwards incompatible change.\r\n- [x] Updated CHANGELOG.md\r\n\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n\r\n","created_at":"2018-05-11T09:45:03Z","updated_at":"2018-05-23T11:51:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b869ced728dd5163ed93a161e60932a8bef73d7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tdomhan","id":363737,"avatar_url":"https://avatars1.githubusercontent.com/u/363737?v=4","gravatar_id":"","url":"https://api.github.com/users/tdomhan","html_url":"https://github.com/tdomhan","followers_url":"https://api.github.com/users/tdomhan/followers","following_url":"https://api.github.com/users/tdomhan/following{/other_user}","gists_url":"https://api.github.com/users/tdomhan/gists{/gist_id}","starred_url":"https://api.github.com/users/tdomhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdomhan/subscriptions","organizations_url":"https://api.github.com/users/tdomhan/orgs","repos_url":"https://api.github.com/users/tdomhan/repos","events_url":"https://api.github.com/users/tdomhan/events{/privacy}","received_events_url":"https://api.github.com/users/tdomhan/received_events","type":"User","site_admin":false},{"login":"mjdenkowski","id":636653,"avatar_url":"https://avatars3.githubusercontent.com/u/636653?v=4","gravatar_id":"","url":"https://api.github.com/users/mjdenkowski","html_url":"https://github.com/mjdenkowski","followers_url":"https://api.github.com/users/mjdenkowski/followers","following_url":"https://api.github.com/users/mjdenkowski/following{/other_user}","gists_url":"https://api.github.com/users/mjdenkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mjdenkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjdenkowski/subscriptions","organizations_url":"https://api.github.com/users/mjdenkowski/orgs","repos_url":"https://api.github.com/users/mjdenkowski/repos","events_url":"https://api.github.com/users/mjdenkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mjdenkowski/received_events","type":"User","site_admin":false},{"login":"davvil","id":683589,"avatar_url":"https://avatars0.githubusercontent.com/u/683589?v=4","gravatar_id":"","url":"https://api.github.com/users/davvil","html_url":"https://github.com/davvil","followers_url":"https://api.github.com/users/davvil/followers","following_url":"https://api.github.com/users/davvil/following{/other_user}","gists_url":"https://api.github.com/users/davvil/gists{/gist_id}","starred_url":"https://api.github.com/users/davvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davvil/subscriptions","organizations_url":"https://api.github.com/users/davvil/orgs","repos_url":"https://api.github.com/users/davvil/repos","events_url":"https://api.github.com/users/davvil/events{/privacy}","received_events_url":"https://api.github.com/users/davvil/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":837948970,"url":"https://api.github.com/repos/awslabs/sockeye/labels/feature","name":"feature","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/sockeye/pulls/390/commits","review_comments_url":"https://api.github.com/repos/awslabs/sockeye/pulls/390/comments","review_comment_url":"https://api.github.com/repos/awslabs/sockeye/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/sockeye/issues/390/comments","statuses_url":"https://api.github.com/repos/awslabs/sockeye/statuses/4b28ad2745fe58789d7edfce730196890aa34914","head":{"label":"lorisbaz:image_captioning","ref":"image_captioning","sha":"4b28ad2745fe58789d7edfce730196890aa34914","user":{"login":"lorisbaz","id":9000459,"avatar_url":"https://avatars3.githubusercontent.com/u/9000459?v=4","gravatar_id":"","url":"https://api.github.com/users/lorisbaz","html_url":"https://github.com/lorisbaz","followers_url":"https://api.github.com/users/lorisbaz/followers","following_url":"https://api.github.com/users/lorisbaz/following{/other_user}","gists_url":"https://api.github.com/users/lorisbaz/gists{/gist_id}","starred_url":"https://api.github.com/users/lorisbaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorisbaz/subscriptions","organizations_url":"https://api.github.com/users/lorisbaz/orgs","repos_url":"https://api.github.com/users/lorisbaz/repos","events_url":"https://api.github.com/users/lorisbaz/events{/privacy}","received_events_url":"https://api.github.com/users/lorisbaz/received_events","type":"User","site_admin":false},"repo":{"id":120324635,"name":"sockeye","full_name":"lorisbaz/sockeye","owner":{"login":"lorisbaz","id":9000459,"avatar_url":"https://avatars3.githubusercontent.com/u/9000459?v=4","gravatar_id":"","url":"https://api.github.com/users/lorisbaz","html_url":"https://github.com/lorisbaz","followers_url":"https://api.github.com/users/lorisbaz/followers","following_url":"https://api.github.com/users/lorisbaz/following{/other_user}","gists_url":"https://api.github.com/users/lorisbaz/gists{/gist_id}","starred_url":"https://api.github.com/users/lorisbaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorisbaz/subscriptions","organizations_url":"https://api.github.com/users/lorisbaz/orgs","repos_url":"https://api.github.com/users/lorisbaz/repos","events_url":"https://api.github.com/users/lorisbaz/events{/privacy}","received_events_url":"https://api.github.com/users/lorisbaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lorisbaz/sockeye","description":"Sequence-to-sequence framework with a focus on Neural Machine Translation based on Apache MXNet","fork":true,"url":"https://api.github.com/repos/lorisbaz/sockeye","forks_url":"https://api.github.com/repos/lorisbaz/sockeye/forks","keys_url":"https://api.github.com/repos/lorisbaz/sockeye/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lorisbaz/sockeye/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lorisbaz/sockeye/teams","hooks_url":"https://api.github.com/repos/lorisbaz/sockeye/hooks","issue_events_url":"https://api.github.com/repos/lorisbaz/sockeye/issues/events{/number}","events_url":"https://api.github.com/repos/lorisbaz/sockeye/events","assignees_url":"https://api.github.com/repos/lorisbaz/sockeye/assignees{/user}","branches_url":"https://api.github.com/repos/lorisbaz/sockeye/branches{/branch}","tags_url":"https://api.github.com/repos/lorisbaz/sockeye/tags","blobs_url":"https://api.github.com/repos/lorisbaz/sockeye/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lorisbaz/sockeye/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lorisbaz/sockeye/git/refs{/sha}","trees_url":"https://api.github.com/repos/lorisbaz/sockeye/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lorisbaz/sockeye/statuses/{sha}","languages_url":"https://api.github.com/repos/lorisbaz/sockeye/languages","stargazers_url":"https://api.github.com/repos/lorisbaz/sockeye/stargazers","contributors_url":"https://api.github.com/repos/lorisbaz/sockeye/contributors","subscribers_url":"https://api.github.com/repos/lorisbaz/sockeye/subscribers","subscription_url":"https://api.github.com/repos/lorisbaz/sockeye/subscription","commits_url":"https://api.github.com/repos/lorisbaz/sockeye/commits{/sha}","git_commits_url":"https://api.github.com/repos/lorisbaz/sockeye/git/commits{/sha}","comments_url":"https://api.github.com/repos/lorisbaz/sockeye/comments{/number}","issue_comment_url":"https://api.github.com/repos/lorisbaz/sockeye/issues/comments{/number}","contents_url":"https://api.github.com/repos/lorisbaz/sockeye/contents/{+path}","compare_url":"https://api.github.com/repos/lorisbaz/sockeye/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lorisbaz/sockeye/merges","archive_url":"https://api.github.com/repos/lorisbaz/sockeye/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lorisbaz/sockeye/downloads","issues_url":"https://api.github.com/repos/lorisbaz/sockeye/issues{/number}","pulls_url":"https://api.github.com/repos/lorisbaz/sockeye/pulls{/number}","milestones_url":"https://api.github.com/repos/lorisbaz/sockeye/milestones{/number}","notifications_url":"https://api.github.com/repos/lorisbaz/sockeye/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lorisbaz/sockeye/labels{/name}","releases_url":"https://api.github.com/repos/lorisbaz/sockeye/releases{/id}","deployments_url":"https://api.github.com/repos/lorisbaz/sockeye/deployments","created_at":"2018-02-05T15:40:30Z","updated_at":"2018-05-11T08:08:53Z","pushed_at":"2018-05-23T08:10:25Z","git_url":"git://github.com/lorisbaz/sockeye.git","ssh_url":"git@github.com:lorisbaz/sockeye.git","clone_url":"https://github.com/lorisbaz/sockeye.git","svn_url":"https://github.com/lorisbaz/sockeye","homepage":"","size":5881,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"fea3d599807484329c4edb1c9f4e2dea0f50b92c","user":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":93721432,"name":"sockeye","full_name":"awslabs/sockeye","owner":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/sockeye","description":"Sequence-to-sequence framework with a focus on Neural Machine Translation based on Apache MXNet","fork":false,"url":"https://api.github.com/repos/awslabs/sockeye","forks_url":"https://api.github.com/repos/awslabs/sockeye/forks","keys_url":"https://api.github.com/repos/awslabs/sockeye/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/sockeye/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/sockeye/teams","hooks_url":"https://api.github.com/repos/awslabs/sockeye/hooks","issue_events_url":"https://api.github.com/repos/awslabs/sockeye/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/sockeye/events","assignees_url":"https://api.github.com/repos/awslabs/sockeye/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/sockeye/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/sockeye/tags","blobs_url":"https://api.github.com/repos/awslabs/sockeye/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/sockeye/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/sockeye/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/sockeye/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/sockeye/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/sockeye/languages","stargazers_url":"https://api.github.com/repos/awslabs/sockeye/stargazers","contributors_url":"https://api.github.com/repos/awslabs/sockeye/contributors","subscribers_url":"https://api.github.com/repos/awslabs/sockeye/subscribers","subscription_url":"https://api.github.com/repos/awslabs/sockeye/subscription","commits_url":"https://api.github.com/repos/awslabs/sockeye/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/sockeye/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/sockeye/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/sockeye/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/sockeye/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/sockeye/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/sockeye/merges","archive_url":"https://api.github.com/repos/awslabs/sockeye/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/sockeye/downloads","issues_url":"https://api.github.com/repos/awslabs/sockeye/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/sockeye/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/sockeye/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/sockeye/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/sockeye/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/sockeye/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/sockeye/deployments","created_at":"2017-06-08T07:44:30Z","updated_at":"2018-05-23T08:14:23Z","pushed_at":"2018-05-23T08:55:16Z","git_url":"git://github.com/awslabs/sockeye.git","ssh_url":"git@github.com:awslabs/sockeye.git","clone_url":"https://github.com/awslabs/sockeye.git","svn_url":"https://github.com/awslabs/sockeye","homepage":"","size":5769,"stargazers_count":515,"watchers_count":515,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":143,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":143,"open_issues":13,"watchers":515,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/sockeye/pulls/390"},"html":{"href":"https://github.com/awslabs/sockeye/pull/390"},"issue":{"href":"https://api.github.com/repos/awslabs/sockeye/issues/390"},"comments":{"href":"https://api.github.com/repos/awslabs/sockeye/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/sockeye/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/sockeye/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/sockeye/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/sockeye/statuses/4b28ad2745fe58789d7edfce730196890aa34914"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lorisbaz"}}