{"action":"closed","number":284,"pull_request":{"url":"https://api.github.com/repos/G-Node/python-odml/pulls/284","id":184365159,"html_url":"https://github.com/G-Node/python-odml/pull/284","diff_url":"https://github.com/G-Node/python-odml/pull/284.diff","patch_url":"https://github.com/G-Node/python-odml/pull/284.patch","issue_url":"https://api.github.com/repos/G-Node/python-odml/issues/284","number":284,"state":"closed","locked":false,"title":"Refactor required attribute handling","user":{"login":"mpsonntag","id":9533513,"avatar_url":"https://avatars2.githubusercontent.com/u/9533513?v=4","gravatar_id":"","url":"https://api.github.com/users/mpsonntag","html_url":"https://github.com/mpsonntag","followers_url":"https://api.github.com/users/mpsonntag/followers","following_url":"https://api.github.com/users/mpsonntag/following{/other_user}","gists_url":"https://api.github.com/users/mpsonntag/gists{/gist_id}","starred_url":"https://api.github.com/users/mpsonntag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpsonntag/subscriptions","organizations_url":"https://api.github.com/users/mpsonntag/orgs","repos_url":"https://api.github.com/users/mpsonntag/repos","events_url":"https://api.github.com/users/mpsonntag/events{/privacy}","received_events_url":"https://api.github.com/users/mpsonntag/received_events","type":"User","site_admin":false},"body":"This PR mainly refactors how required attributes of `Section` and `Property` are handled.\r\n- Required attributes of odML entities in `format.py` where changed: `Section.name`, `Section.type` and `Property.name` are the only attributes set to be required for their respective odML entites. Closes #240.\r\n- `Section` and `Property` `name` can now be `None` on initialization. If this is the case, the entities' `id` values is used as `name` value.\r\n- Hardcoded checks for existing `name` attributes in the XML Parser are removed. Only attributes set as required in `format` are now used to check for missing required odML entity attributes. Close #241.\r\n- The `name` attribute of a `Section` or a `Property` can now only be rewritten, if there is no sibling with the same name on the same hierarchical level. Closes #283.\r\n- Various unused codebits where removed from the XML Parser.\r\n","created_at":"2018-04-26T14:46:25Z","updated_at":"2018-04-26T16:42:51Z","closed_at":"2018-04-26T16:42:51Z","merged_at":"2018-04-26T16:42:51Z","merge_commit_sha":"c7418544c681b41971e2df3d6efaf766939fa179","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/G-Node/python-odml/pulls/284/commits","review_comments_url":"https://api.github.com/repos/G-Node/python-odml/pulls/284/comments","review_comment_url":"https://api.github.com/repos/G-Node/python-odml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/G-Node/python-odml/issues/284/comments","statuses_url":"https://api.github.com/repos/G-Node/python-odml/statuses/37bcae9f4e18d4a71fccacfb791f8d0b3551db7e","head":{"label":"mpsonntag:formatUpdate","ref":"formatUpdate","sha":"37bcae9f4e18d4a71fccacfb791f8d0b3551db7e","user":{"login":"mpsonntag","id":9533513,"avatar_url":"https://avatars2.githubusercontent.com/u/9533513?v=4","gravatar_id":"","url":"https://api.github.com/users/mpsonntag","html_url":"https://github.com/mpsonntag","followers_url":"https://api.github.com/users/mpsonntag/followers","following_url":"https://api.github.com/users/mpsonntag/following{/other_user}","gists_url":"https://api.github.com/users/mpsonntag/gists{/gist_id}","starred_url":"https://api.github.com/users/mpsonntag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpsonntag/subscriptions","organizations_url":"https://api.github.com/users/mpsonntag/orgs","repos_url":"https://api.github.com/users/mpsonntag/repos","events_url":"https://api.github.com/users/mpsonntag/events{/privacy}","received_events_url":"https://api.github.com/users/mpsonntag/received_events","type":"User","site_admin":false},"repo":{"id":58469362,"name":"python-odml","full_name":"mpsonntag/python-odml","owner":{"login":"mpsonntag","id":9533513,"avatar_url":"https://avatars2.githubusercontent.com/u/9533513?v=4","gravatar_id":"","url":"https://api.github.com/users/mpsonntag","html_url":"https://github.com/mpsonntag","followers_url":"https://api.github.com/users/mpsonntag/followers","following_url":"https://api.github.com/users/mpsonntag/following{/other_user}","gists_url":"https://api.github.com/users/mpsonntag/gists{/gist_id}","starred_url":"https://api.github.com/users/mpsonntag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpsonntag/subscriptions","organizations_url":"https://api.github.com/users/mpsonntag/orgs","repos_url":"https://api.github.com/users/mpsonntag/repos","events_url":"https://api.github.com/users/mpsonntag/events{/privacy}","received_events_url":"https://api.github.com/users/mpsonntag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpsonntag/python-odml","description":"odML libraries and editor","fork":true,"url":"https://api.github.com/repos/mpsonntag/python-odml","forks_url":"https://api.github.com/repos/mpsonntag/python-odml/forks","keys_url":"https://api.github.com/repos/mpsonntag/python-odml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpsonntag/python-odml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpsonntag/python-odml/teams","hooks_url":"https://api.github.com/repos/mpsonntag/python-odml/hooks","issue_events_url":"https://api.github.com/repos/mpsonntag/python-odml/issues/events{/number}","events_url":"https://api.github.com/repos/mpsonntag/python-odml/events","assignees_url":"https://api.github.com/repos/mpsonntag/python-odml/assignees{/user}","branches_url":"https://api.github.com/repos/mpsonntag/python-odml/branches{/branch}","tags_url":"https://api.github.com/repos/mpsonntag/python-odml/tags","blobs_url":"https://api.github.com/repos/mpsonntag/python-odml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpsonntag/python-odml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpsonntag/python-odml/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpsonntag/python-odml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpsonntag/python-odml/statuses/{sha}","languages_url":"https://api.github.com/repos/mpsonntag/python-odml/languages","stargazers_url":"https://api.github.com/repos/mpsonntag/python-odml/stargazers","contributors_url":"https://api.github.com/repos/mpsonntag/python-odml/contributors","subscribers_url":"https://api.github.com/repos/mpsonntag/python-odml/subscribers","subscription_url":"https://api.github.com/repos/mpsonntag/python-odml/subscription","commits_url":"https://api.github.com/repos/mpsonntag/python-odml/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpsonntag/python-odml/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpsonntag/python-odml/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpsonntag/python-odml/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpsonntag/python-odml/contents/{+path}","compare_url":"https://api.github.com/repos/mpsonntag/python-odml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpsonntag/python-odml/merges","archive_url":"https://api.github.com/repos/mpsonntag/python-odml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpsonntag/python-odml/downloads","issues_url":"https://api.github.com/repos/mpsonntag/python-odml/issues{/number}","pulls_url":"https://api.github.com/repos/mpsonntag/python-odml/pulls{/number}","milestones_url":"https://api.github.com/repos/mpsonntag/python-odml/milestones{/number}","notifications_url":"https://api.github.com/repos/mpsonntag/python-odml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpsonntag/python-odml/labels{/name}","releases_url":"https://api.github.com/repos/mpsonntag/python-odml/releases{/id}","deployments_url":"https://api.github.com/repos/mpsonntag/python-odml/deployments","created_at":"2016-05-10T14:42:39Z","updated_at":"2018-04-26T07:35:59Z","pushed_at":"2018-04-26T14:27:03Z","git_url":"git://github.com/mpsonntag/python-odml.git","ssh_url":"git@github.com:mpsonntag/python-odml.git","clone_url":"https://github.com/mpsonntag/python-odml.git","svn_url":"https://github.com/mpsonntag/python-odml","homepage":"http://www.g-node.org/projects/odml","size":2251,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"G-Node:master","ref":"master","sha":"bc4bade4c93e0d5cb3ab8c0fb427fcf3c0ed96e1","user":{"login":"G-Node","id":574778,"avatar_url":"https://avatars3.githubusercontent.com/u/574778?v=4","gravatar_id":"","url":"https://api.github.com/users/G-Node","html_url":"https://github.com/G-Node","followers_url":"https://api.github.com/users/G-Node/followers","following_url":"https://api.github.com/users/G-Node/following{/other_user}","gists_url":"https://api.github.com/users/G-Node/gists{/gist_id}","starred_url":"https://api.github.com/users/G-Node/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/G-Node/subscriptions","organizations_url":"https://api.github.com/users/G-Node/orgs","repos_url":"https://api.github.com/users/G-Node/repos","events_url":"https://api.github.com/users/G-Node/events{/privacy}","received_events_url":"https://api.github.com/users/G-Node/received_events","type":"Organization","site_admin":false},"repo":{"id":2288970,"name":"python-odml","full_name":"G-Node/python-odml","owner":{"login":"G-Node","id":574778,"avatar_url":"https://avatars3.githubusercontent.com/u/574778?v=4","gravatar_id":"","url":"https://api.github.com/users/G-Node","html_url":"https://github.com/G-Node","followers_url":"https://api.github.com/users/G-Node/followers","following_url":"https://api.github.com/users/G-Node/following{/other_user}","gists_url":"https://api.github.com/users/G-Node/gists{/gist_id}","starred_url":"https://api.github.com/users/G-Node/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/G-Node/subscriptions","organizations_url":"https://api.github.com/users/G-Node/orgs","repos_url":"https://api.github.com/users/G-Node/repos","events_url":"https://api.github.com/users/G-Node/events{/privacy}","received_events_url":"https://api.github.com/users/G-Node/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/G-Node/python-odml","description":"odML libraries","fork":false,"url":"https://api.github.com/repos/G-Node/python-odml","forks_url":"https://api.github.com/repos/G-Node/python-odml/forks","keys_url":"https://api.github.com/repos/G-Node/python-odml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/G-Node/python-odml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/G-Node/python-odml/teams","hooks_url":"https://api.github.com/repos/G-Node/python-odml/hooks","issue_events_url":"https://api.github.com/repos/G-Node/python-odml/issues/events{/number}","events_url":"https://api.github.com/repos/G-Node/python-odml/events","assignees_url":"https://api.github.com/repos/G-Node/python-odml/assignees{/user}","branches_url":"https://api.github.com/repos/G-Node/python-odml/branches{/branch}","tags_url":"https://api.github.com/repos/G-Node/python-odml/tags","blobs_url":"https://api.github.com/repos/G-Node/python-odml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/G-Node/python-odml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/G-Node/python-odml/git/refs{/sha}","trees_url":"https://api.github.com/repos/G-Node/python-odml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/G-Node/python-odml/statuses/{sha}","languages_url":"https://api.github.com/repos/G-Node/python-odml/languages","stargazers_url":"https://api.github.com/repos/G-Node/python-odml/stargazers","contributors_url":"https://api.github.com/repos/G-Node/python-odml/contributors","subscribers_url":"https://api.github.com/repos/G-Node/python-odml/subscribers","subscription_url":"https://api.github.com/repos/G-Node/python-odml/subscription","commits_url":"https://api.github.com/repos/G-Node/python-odml/commits{/sha}","git_commits_url":"https://api.github.com/repos/G-Node/python-odml/git/commits{/sha}","comments_url":"https://api.github.com/repos/G-Node/python-odml/comments{/number}","issue_comment_url":"https://api.github.com/repos/G-Node/python-odml/issues/comments{/number}","contents_url":"https://api.github.com/repos/G-Node/python-odml/contents/{+path}","compare_url":"https://api.github.com/repos/G-Node/python-odml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/G-Node/python-odml/merges","archive_url":"https://api.github.com/repos/G-Node/python-odml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/G-Node/python-odml/downloads","issues_url":"https://api.github.com/repos/G-Node/python-odml/issues{/number}","pulls_url":"https://api.github.com/repos/G-Node/python-odml/pulls{/number}","milestones_url":"https://api.github.com/repos/G-Node/python-odml/milestones{/number}","notifications_url":"https://api.github.com/repos/G-Node/python-odml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/G-Node/python-odml/labels{/name}","releases_url":"https://api.github.com/repos/G-Node/python-odml/releases{/id}","deployments_url":"https://api.github.com/repos/G-Node/python-odml/deployments","created_at":"2011-08-29T14:35:09Z","updated_at":"2018-04-26T07:34:08Z","pushed_at":"2018-04-26T16:42:51Z","git_url":"git://github.com/G-Node/python-odml.git","ssh_url":"git@github.com:G-Node/python-odml.git","clone_url":"https://github.com/G-Node/python-odml.git","svn_url":"https://github.com/G-Node/python-odml","homepage":"http://www.g-node.org/projects/odml","size":2217,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":17,"open_issues":52,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/G-Node/python-odml/pulls/284"},"html":{"href":"https://github.com/G-Node/python-odml/pull/284"},"issue":{"href":"https://api.github.com/repos/G-Node/python-odml/issues/284"},"comments":{"href":"https://api.github.com/repos/G-Node/python-odml/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/G-Node/python-odml/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/G-Node/python-odml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/G-Node/python-odml/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/G-Node/python-odml/statuses/37bcae9f4e18d4a71fccacfb791f8d0b3551db7e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jgrewe","id":772522,"avatar_url":"https://avatars2.githubusercontent.com/u/772522?v=4","gravatar_id":"","url":"https://api.github.com/users/jgrewe","html_url":"https://github.com/jgrewe","followers_url":"https://api.github.com/users/jgrewe/followers","following_url":"https://api.github.com/users/jgrewe/following{/other_user}","gists_url":"https://api.github.com/users/jgrewe/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrewe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrewe/subscriptions","organizations_url":"https://api.github.com/users/jgrewe/orgs","repos_url":"https://api.github.com/users/jgrewe/repos","events_url":"https://api.github.com/users/jgrewe/events{/privacy}","received_events_url":"https://api.github.com/users/jgrewe/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":14,"additions":130,"deletions":56,"changed_files":7}}
{"actor":{"display_login":"jgrewe"}}