{"action":"created","comment":{"url":"https://api.github.com/repos/dwarvesf/yggdrasil/pulls/comments/218805190","pull_request_review_id":156822742,"id":218805190,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODgwNTE5MA==","diff_hunk":"@@ -50,7 +50,9 @@ func main() {\n \t\ts = service.Service{\n \t\t\tUserService: middlewares.Compose(\n \t\t\t\tuser.NewPGService(pgdb),\n+\t\t\t\tuser.ValidationMiddleware(),\n \t\t\t).(user.Service),\n+\t\t\tSecretKey: os.Getenv(\"SECRECT\"),","path":"identity/cmd/server/main.go","position":15,"original_position":15,"commit_id":"857b91f16a2016a11ecdcffa8e601787348d261f","original_commit_id":"857b91f16a2016a11ecdcffa8e601787348d261f","user":{"login":"huynguyenh","id":23558573,"node_id":"MDQ6VXNlcjIzNTU4NTcz","avatar_url":"https://avatars3.githubusercontent.com/u/23558573?v=4","gravatar_id":"","url":"https://api.github.com/users/huynguyenh","html_url":"https://github.com/huynguyenh","followers_url":"https://api.github.com/users/huynguyenh/followers","following_url":"https://api.github.com/users/huynguyenh/following{/other_user}","gists_url":"https://api.github.com/users/huynguyenh/gists{/gist_id}","starred_url":"https://api.github.com/users/huynguyenh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huynguyenh/subscriptions","organizations_url":"https://api.github.com/users/huynguyenh/orgs","repos_url":"https://api.github.com/users/huynguyenh/repos","events_url":"https://api.github.com/users/huynguyenh/events{/privacy}","received_events_url":"https://api.github.com/users/huynguyenh/received_events","type":"User","site_admin":false},"body":"Sao chỗ này SecretKey lại act như là 1 service ?\n\nservice là khi nó có declare 1 cái interface, mw, database. Nên đừng có lưu global variable vô service, khi nào cần xài thì cứ os.Getenv() thôi","created_at":"2018-09-19T13:35:30Z","updated_at":"2018-09-19T13:35:30Z","html_url":"https://github.com/dwarvesf/yggdrasil/pull/15#discussion_r218805190","pull_request_url":"https://api.github.com/repos/dwarvesf/yggdrasil/pulls/15","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dwarvesf/yggdrasil/pulls/comments/218805190"},"html":{"href":"https://github.com/dwarvesf/yggdrasil/pull/15#discussion_r218805190"},"pull_request":{"href":"https://api.github.com/repos/dwarvesf/yggdrasil/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/dwarvesf/yggdrasil/pulls/15","id":216388279,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2Mzg4Mjc5","html_url":"https://github.com/dwarvesf/yggdrasil/pull/15","diff_url":"https://github.com/dwarvesf/yggdrasil/pull/15.diff","patch_url":"https://github.com/dwarvesf/yggdrasil/pull/15.patch","issue_url":"https://api.github.com/repos/dwarvesf/yggdrasil/issues/15","number":15,"state":"open","locked":false,"title":"[Feature] Feature/identity","user":{"login":"LuanNgoMinh","id":17127595,"node_id":"MDQ6VXNlcjE3MTI3NTk1","avatar_url":"https://avatars2.githubusercontent.com/u/17127595?v=4","gravatar_id":"","url":"https://api.github.com/users/LuanNgoMinh","html_url":"https://github.com/LuanNgoMinh","followers_url":"https://api.github.com/users/LuanNgoMinh/followers","following_url":"https://api.github.com/users/LuanNgoMinh/following{/other_user}","gists_url":"https://api.github.com/users/LuanNgoMinh/gists{/gist_id}","starred_url":"https://api.github.com/users/LuanNgoMinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuanNgoMinh/subscriptions","organizations_url":"https://api.github.com/users/LuanNgoMinh/orgs","repos_url":"https://api.github.com/users/LuanNgoMinh/repos","events_url":"https://api.github.com/users/LuanNgoMinh/events{/privacy}","received_events_url":"https://api.github.com/users/LuanNgoMinh/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-18T17:38:48Z","updated_at":"2018-09-19T13:35:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dwarvesf/yggdrasil/pulls/15/commits","review_comments_url":"https://api.github.com/repos/dwarvesf/yggdrasil/pulls/15/comments","review_comment_url":"https://api.github.com/repos/dwarvesf/yggdrasil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dwarvesf/yggdrasil/issues/15/comments","statuses_url":"https://api.github.com/repos/dwarvesf/yggdrasil/statuses/857b91f16a2016a11ecdcffa8e601787348d261f","head":{"label":"dwarvesf:feature/identity","ref":"feature/identity","sha":"857b91f16a2016a11ecdcffa8e601787348d261f","user":{"login":"dwarvesf","id":10388449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzg4NDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/10388449?v=4","gravatar_id":"","url":"https://api.github.com/users/dwarvesf","html_url":"https://github.com/dwarvesf","followers_url":"https://api.github.com/users/dwarvesf/followers","following_url":"https://api.github.com/users/dwarvesf/following{/other_user}","gists_url":"https://api.github.com/users/dwarvesf/gists{/gist_id}","starred_url":"https://api.github.com/users/dwarvesf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwarvesf/subscriptions","organizations_url":"https://api.github.com/users/dwarvesf/orgs","repos_url":"https://api.github.com/users/dwarvesf/repos","events_url":"https://api.github.com/users/dwarvesf/events{/privacy}","received_events_url":"https://api.github.com/users/dwarvesf/received_events","type":"Organization","site_admin":false},"repo":{"id":146863522,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4NjM1MjI=","name":"yggdrasil","full_name":"dwarvesf/yggdrasil","private":false,"owner":{"login":"dwarvesf","id":10388449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzg4NDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/10388449?v=4","gravatar_id":"","url":"https://api.github.com/users/dwarvesf","html_url":"https://github.com/dwarvesf","followers_url":"https://api.github.com/users/dwarvesf/followers","following_url":"https://api.github.com/users/dwarvesf/following{/other_user}","gists_url":"https://api.github.com/users/dwarvesf/gists{/gist_id}","starred_url":"https://api.github.com/users/dwarvesf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwarvesf/subscriptions","organizations_url":"https://api.github.com/users/dwarvesf/orgs","repos_url":"https://api.github.com/users/dwarvesf/repos","events_url":"https://api.github.com/users/dwarvesf/events{/privacy}","received_events_url":"https://api.github.com/users/dwarvesf/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dwarvesf/yggdrasil","description":"The business service mesh written in Go","fork":false,"url":"https://api.github.com/repos/dwarvesf/yggdrasil","forks_url":"https://api.github.com/repos/dwarvesf/yggdrasil/forks","keys_url":"https://api.github.com/repos/dwarvesf/yggdrasil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwarvesf/yggdrasil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwarvesf/yggdrasil/teams","hooks_url":"https://api.github.com/repos/dwarvesf/yggdrasil/hooks","issue_events_url":"https://api.github.com/repos/dwarvesf/yggdrasil/issues/events{/number}","events_url":"https://api.github.com/repos/dwarvesf/yggdrasil/events","assignees_url":"https://api.github.com/repos/dwarvesf/yggdrasil/assignees{/user}","branches_url":"https://api.github.com/repos/dwarvesf/yggdrasil/branches{/branch}","tags_url":"https://api.github.com/repos/dwarvesf/yggdrasil/tags","blobs_url":"https://api.github.com/repos/dwarvesf/yggdrasil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwarvesf/yggdrasil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwarvesf/yggdrasil/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwarvesf/yggdrasil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwarvesf/yggdrasil/statuses/{sha}","languages_url":"https://api.github.com/repos/dwarvesf/yggdrasil/languages","stargazers_url":"https://api.github.com/repos/dwarvesf/yggdrasil/stargazers","contributors_url":"https://api.github.com/repos/dwarvesf/yggdrasil/contributors","subscribers_url":"https://api.github.com/repos/dwarvesf/yggdrasil/subscribers","subscription_url":"https://api.github.com/repos/dwarvesf/yggdrasil/subscription","commits_url":"https://api.github.com/repos/dwarvesf/yggdrasil/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwarvesf/yggdrasil/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwarvesf/yggdrasil/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwarvesf/yggdrasil/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwarvesf/yggdrasil/contents/{+path}","compare_url":"https://api.github.com/repos/dwarvesf/yggdrasil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwarvesf/yggdrasil/merges","archive_url":"https://api.github.com/repos/dwarvesf/yggdrasil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwarvesf/yggdrasil/downloads","issues_url":"https://api.github.com/repos/dwarvesf/yggdrasil/issues{/number}","pulls_url":"https://api.github.com/repos/dwarvesf/yggdrasil/pulls{/number}","milestones_url":"https://api.github.com/repos/dwarvesf/yggdrasil/milestones{/number}","notifications_url":"https://api.github.com/repos/dwarvesf/yggdrasil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwarvesf/yggdrasil/labels{/name}","releases_url":"https://api.github.com/repos/dwarvesf/yggdrasil/releases{/id}","deployments_url":"https://api.github.com/repos/dwarvesf/yggdrasil/deployments","created_at":"2018-08-31T08:23:43Z","updated_at":"2018-09-18T08:18:31Z","pushed_at":"2018-09-19T07:53:37Z","git_url":"git://github.com/dwarvesf/yggdrasil.git","ssh_url":"git@github.com:dwarvesf/yggdrasil.git","clone_url":"https://github.com/dwarvesf/yggdrasil.git","svn_url":"https://github.com/dwarvesf/yggdrasil","homepage":"","size":36778,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":5,"default_branch":"develop"}},"base":{"label":"dwarvesf:develop","ref":"develop","sha":"b73728dd8fadd5043fe91aec98e68d0a133b2cf3","user":{"login":"dwarvesf","id":10388449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzg4NDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/10388449?v=4","gravatar_id":"","url":"https://api.github.com/users/dwarvesf","html_url":"https://github.com/dwarvesf","followers_url":"https://api.github.com/users/dwarvesf/followers","following_url":"https://api.github.com/users/dwarvesf/following{/other_user}","gists_url":"https://api.github.com/users/dwarvesf/gists{/gist_id}","starred_url":"https://api.github.com/users/dwarvesf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwarvesf/subscriptions","organizations_url":"https://api.github.com/users/dwarvesf/orgs","repos_url":"https://api.github.com/users/dwarvesf/repos","events_url":"https://api.github.com/users/dwarvesf/events{/privacy}","received_events_url":"https://api.github.com/users/dwarvesf/received_events","type":"Organization","site_admin":false},"repo":{"id":146863522,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4NjM1MjI=","name":"yggdrasil","full_name":"dwarvesf/yggdrasil","private":false,"owner":{"login":"dwarvesf","id":10388449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzg4NDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/10388449?v=4","gravatar_id":"","url":"https://api.github.com/users/dwarvesf","html_url":"https://github.com/dwarvesf","followers_url":"https://api.github.com/users/dwarvesf/followers","following_url":"https://api.github.com/users/dwarvesf/following{/other_user}","gists_url":"https://api.github.com/users/dwarvesf/gists{/gist_id}","starred_url":"https://api.github.com/users/dwarvesf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwarvesf/subscriptions","organizations_url":"https://api.github.com/users/dwarvesf/orgs","repos_url":"https://api.github.com/users/dwarvesf/repos","events_url":"https://api.github.com/users/dwarvesf/events{/privacy}","received_events_url":"https://api.github.com/users/dwarvesf/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dwarvesf/yggdrasil","description":"The business service mesh written in Go","fork":false,"url":"https://api.github.com/repos/dwarvesf/yggdrasil","forks_url":"https://api.github.com/repos/dwarvesf/yggdrasil/forks","keys_url":"https://api.github.com/repos/dwarvesf/yggdrasil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwarvesf/yggdrasil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwarvesf/yggdrasil/teams","hooks_url":"https://api.github.com/repos/dwarvesf/yggdrasil/hooks","issue_events_url":"https://api.github.com/repos/dwarvesf/yggdrasil/issues/events{/number}","events_url":"https://api.github.com/repos/dwarvesf/yggdrasil/events","assignees_url":"https://api.github.com/repos/dwarvesf/yggdrasil/assignees{/user}","branches_url":"https://api.github.com/repos/dwarvesf/yggdrasil/branches{/branch}","tags_url":"https://api.github.com/repos/dwarvesf/yggdrasil/tags","blobs_url":"https://api.github.com/repos/dwarvesf/yggdrasil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwarvesf/yggdrasil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwarvesf/yggdrasil/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwarvesf/yggdrasil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwarvesf/yggdrasil/statuses/{sha}","languages_url":"https://api.github.com/repos/dwarvesf/yggdrasil/languages","stargazers_url":"https://api.github.com/repos/dwarvesf/yggdrasil/stargazers","contributors_url":"https://api.github.com/repos/dwarvesf/yggdrasil/contributors","subscribers_url":"https://api.github.com/repos/dwarvesf/yggdrasil/subscribers","subscription_url":"https://api.github.com/repos/dwarvesf/yggdrasil/subscription","commits_url":"https://api.github.com/repos/dwarvesf/yggdrasil/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwarvesf/yggdrasil/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwarvesf/yggdrasil/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwarvesf/yggdrasil/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwarvesf/yggdrasil/contents/{+path}","compare_url":"https://api.github.com/repos/dwarvesf/yggdrasil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwarvesf/yggdrasil/merges","archive_url":"https://api.github.com/repos/dwarvesf/yggdrasil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwarvesf/yggdrasil/downloads","issues_url":"https://api.github.com/repos/dwarvesf/yggdrasil/issues{/number}","pulls_url":"https://api.github.com/repos/dwarvesf/yggdrasil/pulls{/number}","milestones_url":"https://api.github.com/repos/dwarvesf/yggdrasil/milestones{/number}","notifications_url":"https://api.github.com/repos/dwarvesf/yggdrasil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwarvesf/yggdrasil/labels{/name}","releases_url":"https://api.github.com/repos/dwarvesf/yggdrasil/releases{/id}","deployments_url":"https://api.github.com/repos/dwarvesf/yggdrasil/deployments","created_at":"2018-08-31T08:23:43Z","updated_at":"2018-09-18T08:18:31Z","pushed_at":"2018-09-19T07:53:37Z","git_url":"git://github.com/dwarvesf/yggdrasil.git","ssh_url":"git@github.com:dwarvesf/yggdrasil.git","clone_url":"https://github.com/dwarvesf/yggdrasil.git","svn_url":"https://github.com/dwarvesf/yggdrasil","homepage":"","size":36778,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dwarvesf/yggdrasil/pulls/15"},"html":{"href":"https://github.com/dwarvesf/yggdrasil/pull/15"},"issue":{"href":"https://api.github.com/repos/dwarvesf/yggdrasil/issues/15"},"comments":{"href":"https://api.github.com/repos/dwarvesf/yggdrasil/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/dwarvesf/yggdrasil/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/dwarvesf/yggdrasil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dwarvesf/yggdrasil/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/dwarvesf/yggdrasil/statuses/857b91f16a2016a11ecdcffa8e601787348d261f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"huynguyenh"}}