{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments/197259805","pull_request_review_id":130971277,"id":197259805,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzI1OTgwNQ==","diff_hunk":"@@ -201,39 +201,15 @@ describe('Client', function () {\n     });\n   });\n \n-  describe('#invokeModuleMethod', function() {\n-    /*Tests_SRS_NODE_IOTHUB_CLIENT_18_001: [The `invokeModuleMethod` shall throw a `ReferenceError` if `deviceId` or `methodId` is falsy. ]*/\n-    [undefined, null, ''].forEach(function(badArg) {\n-      it('throws if deviceId is ' + badArg, function() {\n-        var client = new Client({}, {});\n-        assert.throws(function() {\n-          client.invokeModuleMethod(badArg, 'moduleId', { }, 42, function() {});\n-        }, ReferenceError);\n-      });\n-    });\n-\n-    /*Tests_SRS_NODE_IOTHUB_CLIENT_18_001: [The `invokeModuleMethod` shall throw a `ReferenceError` if `deviceId` or `methodId` is falsy. ]*/\n-    [undefined, null, ''].forEach(function(badArg) {\n-      it('throws if moduleId is ' + badArg, function() {\n-        var client = new Client({}, {});\n-        assert.throws(function() {\n-          client.invokeModuleMethod('deviceId', badArg, {}, 42, function() {});\n-        }, ReferenceError);\n-      });\n-    });\n-  });\n-\n   [\n-    { name: 'invokeDeviceMethod', functionUnderTest: function(client, param, callback) { client.invokeDeviceMethod('deviceId', param, callback); } },\n-    { name: 'invokeModuleMethod', functionUnderTest: function(client, param, callback) { client.invokeModuleMethod('deviceId', 'moduleId', param, callback); } },\n+    { functionUnderTest: function(client, param, callback) { client.invokeDeviceMethod('deviceId', param, callback); } },\n+    { functionUnderTest: function(client, param, callback) { client.invokeDeviceMethod('deviceId', 'moduleId', param, callback); } },\n   ].forEach(function(testConfig) {\n-    describe('#' + testConfig.name, function() {\n+    describe('#invokeDeviceMethod', function() {\n       /*Tests_SRS_NODE_IOTHUB_CLIENT_16_009: [The `invokeDeviceMethod` method shall initialize a new instance of `DeviceMethod` with the `methodName` and `timeout` values passed in the arguments.]*/\n       /*Tests_SRS_NODE_IOTHUB_CLIENT_16_010: [The `invokeDeviceMethod` method shall use the newly created instance of `DeviceMethod` to invoke the method with the `payload` argument on the device specified with the `deviceid` argument .]*/\n       /*Tests_SRS_NODE_IOTHUB_CLIENT_16_013: [The `invokeDeviceMethod` method shall call the `done` callback with a `null` first argument, the result of the method execution in the second argument, and the transport-specific response object as a third argument.]*/\n-      /*Tests_SRS_NODE_IOTHUB_CLIENT_18_002: [The `invokeModuleMethod` method shall initialize a new `DeviceMethod` instance with `methodParams` values passed in the arguments. ]*/\n-      /*Tests_SRS_NODE_IOTHUB_CLIENT_18_003: [The `invokeModuleMethod` method shall call `invokeOnModule` on the new `DeviceMethod` instance. ]*/\n-      /*Tests_SRS_NODE_IOTHUB_CLIENT_18_005: [The `invokeModuleMethod` method shall call the `done` callback with a `null` first argument, the result of the method execution in the second argument, and the transport-specific response object as a third argument. ]*/\n+      /*Tests_SRS_NODE_IOTHUB_CLIENT_18_003: [If `moduleIdOrMethodParams` is a string the `invokeDeviceMethod` method shall call `invokeOnModule` on the new `DeviceMethod` instance. ]*/","path":"service/test/_client_test.js","position":40,"original_position":40,"commit_id":"49d1945d7a52a8572e26a3b35263141760475fe1","original_commit_id":"60e2f21063d6fe89afaa72a55ceeb3b2bf34c723","user":{"login":"anthonyvercolano","id":9854568,"node_id":"MDQ6VXNlcjk4NTQ1Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/9854568?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonyvercolano","html_url":"https://github.com/anthonyvercolano","followers_url":"https://api.github.com/users/anthonyvercolano/followers","following_url":"https://api.github.com/users/anthonyvercolano/following{/other_user}","gists_url":"https://api.github.com/users/anthonyvercolano/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonyvercolano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonyvercolano/subscriptions","organizations_url":"https://api.github.com/users/anthonyvercolano/orgs","repos_url":"https://api.github.com/users/anthonyvercolano/repos","events_url":"https://api.github.com/users/anthonyvercolano/events{/privacy}","received_events_url":"https://api.github.com/users/anthonyvercolano/received_events","type":"User","site_admin":false},"body":"You have a requirement that says  invokeOnModule.  I don't see an invocation of invokeOnModule\r\n\r\n---\r\nIn reply to: [197259039](https://github.com/Azure/azure-iot-sdk-node/pull/325#discussion_r197259039) [](ancestors = 197259039,197173487)","created_at":"2018-06-21T20:02:53Z","updated_at":"2018-06-21T20:02:53Z","html_url":"https://github.com/Azure/azure-iot-sdk-node/pull/325#discussion_r197259805","pull_request_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/325","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments/197259805"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-node/pull/325#discussion_r197259805"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/325"}},"in_reply_to_id":197173487},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/325","id":196341836,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MzQxODM2","html_url":"https://github.com/Azure/azure-iot-sdk-node/pull/325","diff_url":"https://github.com/Azure/azure-iot-sdk-node/pull/325.diff","patch_url":"https://github.com/Azure/azure-iot-sdk-node/pull/325.patch","issue_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/325","number":325,"state":"open","locked":false,"title":"fix(service): Fold invokeModuleMethod into invokeDeviceMethod","user":{"login":"pierreca","id":4979572,"node_id":"MDQ6VXNlcjQ5Nzk1NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/4979572?v=4","gravatar_id":"","url":"https://api.github.com/users/pierreca","html_url":"https://github.com/pierreca","followers_url":"https://api.github.com/users/pierreca/followers","following_url":"https://api.github.com/users/pierreca/following{/other_user}","gists_url":"https://api.github.com/users/pierreca/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreca/subscriptions","organizations_url":"https://api.github.com/users/pierreca/orgs","repos_url":"https://api.github.com/users/pierreca/repos","events_url":"https://api.github.com/users/pierreca/events{/privacy}","received_events_url":"https://api.github.com/users/pierreca/received_events","type":"User","site_admin":false},"body":"During the API review it was decided that there would be no invokeModuleMethod on the service client and instead the invokeDeviceMethod would be overloaded to also address the case of modules.","created_at":"2018-06-21T05:47:31Z","updated_at":"2018-06-21T20:02:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25c720115f0702ad3673067f6b54353967aa4b5a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/325/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/325/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/325/comments","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/49d1945d7a52a8572e26a3b35263141760475fe1","head":{"label":"pierreca:rename-invokemodulemethod","ref":"rename-invokemodulemethod","sha":"49d1945d7a52a8572e26a3b35263141760475fe1","user":{"login":"pierreca","id":4979572,"node_id":"MDQ6VXNlcjQ5Nzk1NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/4979572?v=4","gravatar_id":"","url":"https://api.github.com/users/pierreca","html_url":"https://github.com/pierreca","followers_url":"https://api.github.com/users/pierreca/followers","following_url":"https://api.github.com/users/pierreca/following{/other_user}","gists_url":"https://api.github.com/users/pierreca/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreca/subscriptions","organizations_url":"https://api.github.com/users/pierreca/orgs","repos_url":"https://api.github.com/users/pierreca/repos","events_url":"https://api.github.com/users/pierreca/events{/privacy}","received_events_url":"https://api.github.com/users/pierreca/received_events","type":"User","site_admin":false},"repo":{"id":74415504,"node_id":"MDEwOlJlcG9zaXRvcnk3NDQxNTUwNA==","name":"azure-iot-sdk-node","full_name":"pierreca/azure-iot-sdk-node","owner":{"login":"pierreca","id":4979572,"node_id":"MDQ6VXNlcjQ5Nzk1NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/4979572?v=4","gravatar_id":"","url":"https://api.github.com/users/pierreca","html_url":"https://github.com/pierreca","followers_url":"https://api.github.com/users/pierreca/followers","following_url":"https://api.github.com/users/pierreca/following{/other_user}","gists_url":"https://api.github.com/users/pierreca/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreca/subscriptions","organizations_url":"https://api.github.com/users/pierreca/orgs","repos_url":"https://api.github.com/users/pierreca/repos","events_url":"https://api.github.com/users/pierreca/events{/privacy}","received_events_url":"https://api.github.com/users/pierreca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pierreca/azure-iot-sdk-node","description":"A Node.js SDK for connecting devices to Microsoft Azure IoT services","fork":true,"url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node","forks_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/forks","keys_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/teams","hooks_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/hooks","issue_events_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/issues/events{/number}","events_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/events","assignees_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/assignees{/user}","branches_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/branches{/branch}","tags_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/tags","blobs_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/statuses/{sha}","languages_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/languages","stargazers_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/stargazers","contributors_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/contributors","subscribers_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/subscribers","subscription_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/subscription","commits_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/contents/{+path}","compare_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/merges","archive_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/downloads","issues_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/issues{/number}","pulls_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/pulls{/number}","milestones_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/milestones{/number}","notifications_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/labels{/name}","releases_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/releases{/id}","deployments_url":"https://api.github.com/repos/pierreca/azure-iot-sdk-node/deployments","created_at":"2016-11-21T23:36:25Z","updated_at":"2018-06-08T00:36:09Z","pushed_at":"2018-06-21T20:01:03Z","git_url":"git://github.com/pierreca/azure-iot-sdk-node.git","ssh_url":"git@github.com:pierreca/azure-iot-sdk-node.git","clone_url":"https://github.com/pierreca/azure-iot-sdk-node.git","svn_url":"https://github.com/pierreca/azure-iot-sdk-node","homepage":null,"size":42824,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:modules-preview","ref":"modules-preview","sha":"042381068d3aead472b30231260a8bae3e3c08e1","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":70935002,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkzNTAwMg==","name":"azure-iot-sdk-node","full_name":"Azure/azure-iot-sdk-node","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-iot-sdk-node","description":"A Node.js SDK for connecting devices to Microsoft Azure IoT services","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node","forks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/deployments","created_at":"2016-10-14T18:03:43Z","updated_at":"2018-06-21T02:59:30Z","pushed_at":"2018-06-21T20:01:07Z","git_url":"git://github.com/Azure/azure-iot-sdk-node.git","ssh_url":"git@github.com:Azure/azure-iot-sdk-node.git","clone_url":"https://github.com/Azure/azure-iot-sdk-node.git","svn_url":"https://github.com/Azure/azure-iot-sdk-node","homepage":"https://docs.microsoft.com/en-us/azure/iot-hub/","size":43833,"stargazers_count":103,"watchers_count":103,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":92,"open_issues":12,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/325"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-node/pull/325"},"issue":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/325"},"comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/325/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/325/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/325/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/49d1945d7a52a8572e26a3b35263141760475fe1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"anthonyvercolano"}}