{"action":"closed","number":50,"pull_request":{"url":"https://api.github.com/repos/kuzzleio/sdk-cpp/pulls/50","id":240702392,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNzAyMzky","html_url":"https://github.com/kuzzleio/sdk-cpp/pull/50","diff_url":"https://github.com/kuzzleio/sdk-cpp/pull/50.diff","patch_url":"https://github.com/kuzzleio/sdk-cpp/pull/50.patch","issue_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/issues/50","number":50,"state":"closed","locked":false,"title":"KZL-972 - Use multi signatures instead of default arguments","user":{"login":"Aschen","id":4447392,"node_id":"MDQ6VXNlcjQ0NDczOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/4447392?v=4","gravatar_id":"","url":"https://api.github.com/users/Aschen","html_url":"https://github.com/Aschen","followers_url":"https://api.github.com/users/Aschen/followers","following_url":"https://api.github.com/users/Aschen/following{/other_user}","gists_url":"https://api.github.com/users/Aschen/gists{/gist_id}","starred_url":"https://api.github.com/users/Aschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aschen/subscriptions","organizations_url":"https://api.github.com/users/Aschen/orgs","repos_url":"https://api.github.com/users/Aschen/repos","events_url":"https://api.github.com/users/Aschen/events{/privacy}","received_events_url":"https://api.github.com/users/Aschen/received_events","type":"User","site_admin":false},"body":"## What does this PR do ?\r\n\r\nUse multi signature methods instead of having default arguments.  \r\nAll methods takes a `const query_options&` instead of a `query_options*`. Same for `room_options`, `kuzzle_request` and `options`.\r\n\r\nDocumentation: https://github.com/kuzzleio/documentation-V2/pull/206\r\n\r\n### How should this be manually tested?\r\n\r\n  - Step 1 : Run tests\r\n\r\n### Other changes\r\n\r\n - Add const qualifier in SearchResult","created_at":"2018-12-23T21:55:22Z","updated_at":"2019-01-03T10:58:35Z","closed_at":"2019-01-03T10:58:35Z","merged_at":"2019-01-03T10:58:35Z","merge_commit_sha":"93f42fa4b98e6ddbd25cbe4aae3798ef3eeeec1c","assignee":{"login":"Aschen","id":4447392,"node_id":"MDQ6VXNlcjQ0NDczOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/4447392?v=4","gravatar_id":"","url":"https://api.github.com/users/Aschen","html_url":"https://github.com/Aschen","followers_url":"https://api.github.com/users/Aschen/followers","following_url":"https://api.github.com/users/Aschen/following{/other_user}","gists_url":"https://api.github.com/users/Aschen/gists{/gist_id}","starred_url":"https://api.github.com/users/Aschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aschen/subscriptions","organizations_url":"https://api.github.com/users/Aschen/orgs","repos_url":"https://api.github.com/users/Aschen/repos","events_url":"https://api.github.com/users/Aschen/events{/privacy}","received_events_url":"https://api.github.com/users/Aschen/received_events","type":"User","site_admin":false},"assignees":[{"login":"Aschen","id":4447392,"node_id":"MDQ6VXNlcjQ0NDczOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/4447392?v=4","gravatar_id":"","url":"https://api.github.com/users/Aschen","html_url":"https://github.com/Aschen","followers_url":"https://api.github.com/users/Aschen/followers","following_url":"https://api.github.com/users/Aschen/following{/other_user}","gists_url":"https://api.github.com/users/Aschen/gists{/gist_id}","starred_url":"https://api.github.com/users/Aschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aschen/subscriptions","organizations_url":"https://api.github.com/users/Aschen/orgs","repos_url":"https://api.github.com/users/Aschen/repos","events_url":"https://api.github.com/users/Aschen/events{/privacy}","received_events_url":"https://api.github.com/users/Aschen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1047920102,"node_id":"MDU6TGFiZWwxMDQ3OTIwMTAy","url":"https://api.github.com/repos/kuzzleio/sdk-cpp/labels/changelog:enhancements","name":"changelog:enhancements","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/pulls/50/commits","review_comments_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/pulls/50/comments","review_comment_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/issues/50/comments","statuses_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/statuses/686f8a6ae827cbbc6c340a297e9e05c7a9e25d0b","head":{"label":"kuzzleio:KZL-972-use-multi-sig-instead-default-arg","ref":"KZL-972-use-multi-sig-instead-default-arg","sha":"686f8a6ae827cbbc6c340a297e9e05c7a9e25d0b","user":{"login":"kuzzleio","id":12933347,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTMzMzQ3","avatar_url":"https://avatars1.githubusercontent.com/u/12933347?v=4","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"repo":{"id":147641963,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc2NDE5NjM=","name":"sdk-cpp","full_name":"kuzzleio/sdk-cpp","private":false,"owner":{"login":"kuzzleio","id":12933347,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTMzMzQ3","avatar_url":"https://avatars1.githubusercontent.com/u/12933347?v=4","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kuzzleio/sdk-cpp","description":"Official C++ SDK for Kuzzle http://docs.kuzzle.io/sdk-reference","fork":false,"url":"https://api.github.com/repos/kuzzleio/sdk-cpp","forks_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/forks","keys_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/teams","hooks_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/hooks","issue_events_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/events","assignees_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/tags","blobs_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/languages","stargazers_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/stargazers","contributors_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/contributors","subscribers_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/subscribers","subscription_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/subscription","commits_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/merges","archive_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/downloads","issues_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/labels{/name}","releases_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/deployments","created_at":"2018-09-06T08:27:05Z","updated_at":"2018-12-14T15:30:21Z","pushed_at":"2019-01-03T10:58:35Z","git_url":"git://github.com/kuzzleio/sdk-cpp.git","ssh_url":"git@github.com:kuzzleio/sdk-cpp.git","clone_url":"https://github.com/kuzzleio/sdk-cpp.git","svn_url":"https://github.com/kuzzleio/sdk-cpp","homepage":null,"size":223,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"kuzzleio:1-dev","ref":"1-dev","sha":"477477866ff5981a8e3bfb3f608edb501b17b2e1","user":{"login":"kuzzleio","id":12933347,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTMzMzQ3","avatar_url":"https://avatars1.githubusercontent.com/u/12933347?v=4","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"repo":{"id":147641963,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc2NDE5NjM=","name":"sdk-cpp","full_name":"kuzzleio/sdk-cpp","private":false,"owner":{"login":"kuzzleio","id":12933347,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTMzMzQ3","avatar_url":"https://avatars1.githubusercontent.com/u/12933347?v=4","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kuzzleio/sdk-cpp","description":"Official C++ SDK for Kuzzle http://docs.kuzzle.io/sdk-reference","fork":false,"url":"https://api.github.com/repos/kuzzleio/sdk-cpp","forks_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/forks","keys_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/teams","hooks_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/hooks","issue_events_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/events","assignees_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/tags","blobs_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/languages","stargazers_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/stargazers","contributors_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/contributors","subscribers_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/subscribers","subscription_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/subscription","commits_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/merges","archive_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/downloads","issues_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/labels{/name}","releases_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/kuzzleio/sdk-cpp/deployments","created_at":"2018-09-06T08:27:05Z","updated_at":"2018-12-14T15:30:21Z","pushed_at":"2019-01-03T10:58:35Z","git_url":"git://github.com/kuzzleio/sdk-cpp.git","ssh_url":"git@github.com:kuzzleio/sdk-cpp.git","clone_url":"https://github.com/kuzzleio/sdk-cpp.git","svn_url":"https://github.com/kuzzleio/sdk-cpp","homepage":null,"size":223,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kuzzleio/sdk-cpp/pulls/50"},"html":{"href":"https://github.com/kuzzleio/sdk-cpp/pull/50"},"issue":{"href":"https://api.github.com/repos/kuzzleio/sdk-cpp/issues/50"},"comments":{"href":"https://api.github.com/repos/kuzzleio/sdk-cpp/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/kuzzleio/sdk-cpp/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/kuzzleio/sdk-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kuzzleio/sdk-cpp/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/kuzzleio/sdk-cpp/statuses/686f8a6ae827cbbc6c340a297e9e05c7a9e25d0b"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Aschen","id":4447392,"node_id":"MDQ6VXNlcjQ0NDczOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/4447392?v=4","gravatar_id":"","url":"https://api.github.com/users/Aschen","html_url":"https://github.com/Aschen","followers_url":"https://api.github.com/users/Aschen/followers","following_url":"https://api.github.com/users/Aschen/following{/other_user}","gists_url":"https://api.github.com/users/Aschen/gists{/gist_id}","starred_url":"https://api.github.com/users/Aschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aschen/subscriptions","organizations_url":"https://api.github.com/users/Aschen/orgs","repos_url":"https://api.github.com/users/Aschen/repos","events_url":"https://api.github.com/users/Aschen/events{/privacy}","received_events_url":"https://api.github.com/users/Aschen/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":10,"additions":914,"deletions":275,"changed_files":23}}
{"actor":{"display_login":"Aschen"}}