{"action":"created","comment":{"url":"https://api.github.com/repos/ska-sa/katportalclient/pulls/comments/180009969","pull_request_review_id":110354524,"id":180009969,"diff_hunk":"@@ -896,6 +896,7 @@ def test_sensor_history_multiple_sensors_valid_times(self):\n \n         histories = yield self._portal_client.sensors_histories(\n             sensor_name_filter, start_time_sec=0, end_time_sec=time.time())\n+        print('histories == {}'.format(histories))","path":"katportalclient/test/test_client.py","position":125,"original_position":24,"commit_id":"4121f14858e72ec1a2754adde16d22e16c5ee9cc","original_commit_id":"4121f14858e72ec1a2754adde16d22e16c5ee9cc","user":{"login":"ajoubertza","id":20420754,"avatar_url":"https://avatars2.githubusercontent.com/u/20420754?v=4","gravatar_id":"","url":"https://api.github.com/users/ajoubertza","html_url":"https://github.com/ajoubertza","followers_url":"https://api.github.com/users/ajoubertza/followers","following_url":"https://api.github.com/users/ajoubertza/following{/other_user}","gists_url":"https://api.github.com/users/ajoubertza/gists{/gist_id}","starred_url":"https://api.github.com/users/ajoubertza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajoubertza/subscriptions","organizations_url":"https://api.github.com/users/ajoubertza/orgs","repos_url":"https://api.github.com/users/ajoubertza/repos","events_url":"https://api.github.com/users/ajoubertza/events{/privacy}","received_events_url":"https://api.github.com/users/ajoubertza/received_events","type":"User","site_admin":false},"body":"Are these print statements just for debugging and will be removed once that is complete?","created_at":"2018-04-09T07:41:20Z","updated_at":"2018-04-09T07:41:26Z","html_url":"https://github.com/ska-sa/katportalclient/pull/31#discussion_r180009969","pull_request_url":"https://api.github.com/repos/ska-sa/katportalclient/pulls/31","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ska-sa/katportalclient/pulls/comments/180009969"},"html":{"href":"https://github.com/ska-sa/katportalclient/pull/31#discussion_r180009969"},"pull_request":{"href":"https://api.github.com/repos/ska-sa/katportalclient/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/ska-sa/katportalclient/pulls/31","id":174935387,"html_url":"https://github.com/ska-sa/katportalclient/pull/31","diff_url":"https://github.com/ska-sa/katportalclient/pull/31.diff","patch_url":"https://github.com/ska-sa/katportalclient/pull/31.patch","issue_url":"https://api.github.com/repos/ska-sa/katportalclient/issues/31","number":31,"state":"open","locked":false,"title":"Feature/new katstore integration","user":{"login":"tockards","id":11752923,"avatar_url":"https://avatars0.githubusercontent.com/u/11752923?v=4","gravatar_id":"","url":"https://api.github.com/users/tockards","html_url":"https://github.com/tockards","followers_url":"https://api.github.com/users/tockards/followers","following_url":"https://api.github.com/users/tockards/following{/other_user}","gists_url":"https://api.github.com/users/tockards/gists{/gist_id}","starred_url":"https://api.github.com/users/tockards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tockards/subscriptions","organizations_url":"https://api.github.com/users/tockards/orgs","repos_url":"https://api.github.com/users/tockards/repos","events_url":"https://api.github.com/users/tockards/events{/privacy}","received_events_url":"https://api.github.com/users/tockards/received_events","type":"User","site_admin":false},"body":"- removed state and uuid related code\r\n- removed websocket initiation and other code related to old katstore. \r\n","created_at":"2018-03-14T12:10:36Z","updated_at":"2018-04-09T07:41:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11f9f67d6b10501be68fa86385053eb95643b532","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":442516030,"url":"https://api.github.com/repos/ska-sa/katportalclient/labels/do%20not%20merge%20yet","name":"do not merge yet","color":"eb6420","default":false},{"id":866953896,"url":"https://api.github.com/repos/ska-sa/katportalclient/labels/feature","name":"feature","color":"cc7059","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ska-sa/katportalclient/pulls/31/commits","review_comments_url":"https://api.github.com/repos/ska-sa/katportalclient/pulls/31/comments","review_comment_url":"https://api.github.com/repos/ska-sa/katportalclient/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ska-sa/katportalclient/issues/31/comments","statuses_url":"https://api.github.com/repos/ska-sa/katportalclient/statuses/4121f14858e72ec1a2754adde16d22e16c5ee9cc","head":{"label":"ska-sa:feature/new-katstore-integration","ref":"feature/new-katstore-integration","sha":"4121f14858e72ec1a2754adde16d22e16c5ee9cc","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":42626533,"name":"katportalclient","full_name":"ska-sa/katportalclient","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/katportalclient","description":"Websocket client for use with katportal PubSub","fork":false,"url":"https://api.github.com/repos/ska-sa/katportalclient","forks_url":"https://api.github.com/repos/ska-sa/katportalclient/forks","keys_url":"https://api.github.com/repos/ska-sa/katportalclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/katportalclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/katportalclient/teams","hooks_url":"https://api.github.com/repos/ska-sa/katportalclient/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/katportalclient/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/katportalclient/events","assignees_url":"https://api.github.com/repos/ska-sa/katportalclient/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/katportalclient/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/katportalclient/tags","blobs_url":"https://api.github.com/repos/ska-sa/katportalclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/katportalclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/katportalclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/katportalclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/katportalclient/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/katportalclient/languages","stargazers_url":"https://api.github.com/repos/ska-sa/katportalclient/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/katportalclient/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/katportalclient/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/katportalclient/subscription","commits_url":"https://api.github.com/repos/ska-sa/katportalclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/katportalclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/katportalclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/katportalclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/katportalclient/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/katportalclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/katportalclient/merges","archive_url":"https://api.github.com/repos/ska-sa/katportalclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/katportalclient/downloads","issues_url":"https://api.github.com/repos/ska-sa/katportalclient/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/katportalclient/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/katportalclient/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/katportalclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/katportalclient/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/katportalclient/releases{/id}","deployments_url":"https://api.github.com/repos/ska-sa/katportalclient/deployments","created_at":"2015-09-17T01:42:53Z","updated_at":"2018-04-03T12:48:27Z","pushed_at":"2018-04-09T07:22:42Z","git_url":"git://github.com/ska-sa/katportalclient.git","ssh_url":"git@github.com:ska-sa/katportalclient.git","clone_url":"https://github.com/ska-sa/katportalclient.git","svn_url":"https://github.com/ska-sa/katportalclient","homepage":null,"size":478,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"ska-sa:master","ref":"master","sha":"0b39f428ee4487112c2c8eeb3714fe2db11cd7cb","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":42626533,"name":"katportalclient","full_name":"ska-sa/katportalclient","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/katportalclient","description":"Websocket client for use with katportal PubSub","fork":false,"url":"https://api.github.com/repos/ska-sa/katportalclient","forks_url":"https://api.github.com/repos/ska-sa/katportalclient/forks","keys_url":"https://api.github.com/repos/ska-sa/katportalclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/katportalclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/katportalclient/teams","hooks_url":"https://api.github.com/repos/ska-sa/katportalclient/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/katportalclient/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/katportalclient/events","assignees_url":"https://api.github.com/repos/ska-sa/katportalclient/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/katportalclient/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/katportalclient/tags","blobs_url":"https://api.github.com/repos/ska-sa/katportalclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/katportalclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/katportalclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/katportalclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/katportalclient/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/katportalclient/languages","stargazers_url":"https://api.github.com/repos/ska-sa/katportalclient/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/katportalclient/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/katportalclient/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/katportalclient/subscription","commits_url":"https://api.github.com/repos/ska-sa/katportalclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/katportalclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/katportalclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/katportalclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/katportalclient/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/katportalclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/katportalclient/merges","archive_url":"https://api.github.com/repos/ska-sa/katportalclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/katportalclient/downloads","issues_url":"https://api.github.com/repos/ska-sa/katportalclient/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/katportalclient/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/katportalclient/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/katportalclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/katportalclient/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/katportalclient/releases{/id}","deployments_url":"https://api.github.com/repos/ska-sa/katportalclient/deployments","created_at":"2015-09-17T01:42:53Z","updated_at":"2018-04-03T12:48:27Z","pushed_at":"2018-04-09T07:22:42Z","git_url":"git://github.com/ska-sa/katportalclient.git","ssh_url":"git@github.com:ska-sa/katportalclient.git","clone_url":"https://github.com/ska-sa/katportalclient.git","svn_url":"https://github.com/ska-sa/katportalclient","homepage":null,"size":478,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ska-sa/katportalclient/pulls/31"},"html":{"href":"https://github.com/ska-sa/katportalclient/pull/31"},"issue":{"href":"https://api.github.com/repos/ska-sa/katportalclient/issues/31"},"comments":{"href":"https://api.github.com/repos/ska-sa/katportalclient/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/ska-sa/katportalclient/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/ska-sa/katportalclient/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ska-sa/katportalclient/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/ska-sa/katportalclient/statuses/4121f14858e72ec1a2754adde16d22e16c5ee9cc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ajoubertza"}}