{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/186965664","pull_request_review_id":118647072,"id":186965664,"diff_hunk":"@@ -124,7 +124,7 @@ pub fn maybe_print_constraints_for<'a, 'gcx, 'tcx>(\n struct ConstraintGraph<'a, 'gcx: 'a+'tcx, 'tcx: 'a> {\n     graph_name: String,\n     region_rels: &'a RegionRelations<'a, 'gcx, 'tcx>,\n-    map: &'a BTreeMap<Constraint<'tcx>, SubregionOrigin<'tcx>>,\n+    map: &'a LazyBTreeMap<Constraint<'tcx>, SubregionOrigin<'tcx>>,","path":"src/librustc/infer/lexical_region_resolve/graphviz.rs","position":18,"original_position":18,"commit_id":"b0f3003a3595f488062318a47bb5ef09622b3591","original_commit_id":"b0f3003a3595f488062318a47bb5ef09622b3591","user":{"login":"michaelwoerister","id":1825894,"avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false},"body":"Yes, `Constraint` just seems to have a derived `Ord` implementation, so the order might not be important. I don't know this code though.","created_at":"2018-05-09T08:19:24Z","updated_at":"2018-05-09T08:19:24Z","html_url":"https://github.com/rust-lang/rust/pull/50491#discussion_r186965664","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/50491","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/186965664"},"html":{"href":"https://github.com/rust-lang/rust/pull/50491#discussion_r186965664"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/50491"}},"in_reply_to_id":186755315},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/50491","id":186249901,"html_url":"https://github.com/rust-lang/rust/pull/50491","diff_url":"https://github.com/rust-lang/rust/pull/50491.diff","patch_url":"https://github.com/rust-lang/rust/pull/50491.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/50491","number":50491,"state":"open","locked":false,"title":"Use LazyBTreeMap for region constraints.","user":{"login":"nnethercote","id":1940286,"avatar_url":"https://avatars1.githubusercontent.com/u/1940286?v=4","gravatar_id":"","url":"https://api.github.com/users/nnethercote","html_url":"https://github.com/nnethercote","followers_url":"https://api.github.com/users/nnethercote/followers","following_url":"https://api.github.com/users/nnethercote/following{/other_user}","gists_url":"https://api.github.com/users/nnethercote/gists{/gist_id}","starred_url":"https://api.github.com/users/nnethercote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnethercote/subscriptions","organizations_url":"https://api.github.com/users/nnethercote/orgs","repos_url":"https://api.github.com/users/nnethercote/repos","events_url":"https://api.github.com/users/nnethercote/events{/privacy}","received_events_url":"https://api.github.com/users/nnethercote/received_events","type":"User","site_admin":false},"body":"Because a lot of these BTreeMaps don't get anything inserted into them.\r\n\r\nIn the most extreme case, this halves the number of total bytes\r\nallocated for a debug build of tuple-stress, from 2.2GB to 1.1GB. That\r\nreduction in turn speeds up runs of many benchmarks, the best by 3%.","created_at":"2018-05-07T03:53:16Z","updated_at":"2018-05-09T08:19:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dd737e847bc214fb64f7a1efc1f540baaa3a43c","assignee":{"login":"estebank","id":1606434,"avatar_url":"https://avatars2.githubusercontent.com/u/1606434?v=4","gravatar_id":"","url":"https://api.github.com/users/estebank","html_url":"https://github.com/estebank","followers_url":"https://api.github.com/users/estebank/followers","following_url":"https://api.github.com/users/estebank/following{/other_user}","gists_url":"https://api.github.com/users/estebank/gists{/gist_id}","starred_url":"https://api.github.com/users/estebank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estebank/subscriptions","organizations_url":"https://api.github.com/users/estebank/orgs","repos_url":"https://api.github.com/users/estebank/repos","events_url":"https://api.github.com/users/estebank/events{/privacy}","received_events_url":"https://api.github.com/users/estebank/received_events","type":"User","site_admin":false},"assignees":[{"login":"estebank","id":1606434,"avatar_url":"https://avatars2.githubusercontent.com/u/1606434?v=4","gravatar_id":"","url":"https://api.github.com/users/estebank","html_url":"https://github.com/estebank","followers_url":"https://api.github.com/users/estebank/followers","following_url":"https://api.github.com/users/estebank/following{/other_user}","gists_url":"https://api.github.com/users/estebank/gists{/gist_id}","starred_url":"https://api.github.com/users/estebank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estebank/subscriptions","organizations_url":"https://api.github.com/users/estebank/orgs","repos_url":"https://api.github.com/users/estebank/repos","events_url":"https://api.github.com/users/estebank/events{/privacy}","received_events_url":"https://api.github.com/users/estebank/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583426710,"url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/50491/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/50491/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/50491/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/b0f3003a3595f488062318a47bb5ef09622b3591","head":{"label":"nnethercote:LazyBTree-more","ref":"LazyBTree-more","sha":"b0f3003a3595f488062318a47bb5ef09622b3591","user":{"login":"nnethercote","id":1940286,"avatar_url":"https://avatars1.githubusercontent.com/u/1940286?v=4","gravatar_id":"","url":"https://api.github.com/users/nnethercote","html_url":"https://github.com/nnethercote","followers_url":"https://api.github.com/users/nnethercote/followers","following_url":"https://api.github.com/users/nnethercote/following{/other_user}","gists_url":"https://api.github.com/users/nnethercote/gists{/gist_id}","starred_url":"https://api.github.com/users/nnethercote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnethercote/subscriptions","organizations_url":"https://api.github.com/users/nnethercote/orgs","repos_url":"https://api.github.com/users/nnethercote/repos","events_url":"https://api.github.com/users/nnethercote/events{/privacy}","received_events_url":"https://api.github.com/users/nnethercote/received_events","type":"User","site_admin":false},"repo":{"id":21260858,"name":"rust","full_name":"nnethercote/rust","owner":{"login":"nnethercote","id":1940286,"avatar_url":"https://avatars1.githubusercontent.com/u/1940286?v=4","gravatar_id":"","url":"https://api.github.com/users/nnethercote","html_url":"https://github.com/nnethercote","followers_url":"https://api.github.com/users/nnethercote/followers","following_url":"https://api.github.com/users/nnethercote/following{/other_user}","gists_url":"https://api.github.com/users/nnethercote/gists{/gist_id}","starred_url":"https://api.github.com/users/nnethercote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnethercote/subscriptions","organizations_url":"https://api.github.com/users/nnethercote/orgs","repos_url":"https://api.github.com/users/nnethercote/repos","events_url":"https://api.github.com/users/nnethercote/events{/privacy}","received_events_url":"https://api.github.com/users/nnethercote/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nnethercote/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/nnethercote/rust","forks_url":"https://api.github.com/repos/nnethercote/rust/forks","keys_url":"https://api.github.com/repos/nnethercote/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nnethercote/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nnethercote/rust/teams","hooks_url":"https://api.github.com/repos/nnethercote/rust/hooks","issue_events_url":"https://api.github.com/repos/nnethercote/rust/issues/events{/number}","events_url":"https://api.github.com/repos/nnethercote/rust/events","assignees_url":"https://api.github.com/repos/nnethercote/rust/assignees{/user}","branches_url":"https://api.github.com/repos/nnethercote/rust/branches{/branch}","tags_url":"https://api.github.com/repos/nnethercote/rust/tags","blobs_url":"https://api.github.com/repos/nnethercote/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nnethercote/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nnethercote/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/nnethercote/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nnethercote/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/nnethercote/rust/languages","stargazers_url":"https://api.github.com/repos/nnethercote/rust/stargazers","contributors_url":"https://api.github.com/repos/nnethercote/rust/contributors","subscribers_url":"https://api.github.com/repos/nnethercote/rust/subscribers","subscription_url":"https://api.github.com/repos/nnethercote/rust/subscription","commits_url":"https://api.github.com/repos/nnethercote/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/nnethercote/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/nnethercote/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/nnethercote/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/nnethercote/rust/contents/{+path}","compare_url":"https://api.github.com/repos/nnethercote/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nnethercote/rust/merges","archive_url":"https://api.github.com/repos/nnethercote/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nnethercote/rust/downloads","issues_url":"https://api.github.com/repos/nnethercote/rust/issues{/number}","pulls_url":"https://api.github.com/repos/nnethercote/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/nnethercote/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/nnethercote/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nnethercote/rust/labels{/name}","releases_url":"https://api.github.com/repos/nnethercote/rust/releases{/id}","deployments_url":"https://api.github.com/repos/nnethercote/rust/deployments","created_at":"2014-06-27T01:56:48Z","updated_at":"2018-05-06T01:10:47Z","pushed_at":"2018-05-08T23:17:17Z","git_url":"git://github.com/nnethercote/rust.git","ssh_url":"git@github.com:nnethercote/rust.git","clone_url":"https://github.com/nnethercote/rust.git","svn_url":"https://github.com/nnethercote/rust","homepage":"http://www.rust-lang.org","size":368132,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"700165d7aeba7fbba79bcc322e010137ae70b46a","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-05-09T07:56:35Z","pushed_at":"2018-05-09T07:36:10Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":372734,"stargazers_count":28121,"watchers_count":28121,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4899,"mirror_url":null,"archived":false,"open_issues_count":3754,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4899,"open_issues":3754,"watchers":28121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/50491"},"html":{"href":"https://github.com/rust-lang/rust/pull/50491"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/50491"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/50491/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/50491/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/50491/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/b0f3003a3595f488062318a47bb5ef09622b3591"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"michaelwoerister"}}