{"action":"closed","number":613,"pull_request":{"url":"https://api.github.com/repos/opentable/sous/pulls/613","id":172375757,"html_url":"https://github.com/opentable/sous/pull/613","diff_url":"https://github.com/opentable/sous/pull/613.diff","patch_url":"https://github.com/opentable/sous/pull/613.patch","issue_url":"https://api.github.com/repos/opentable/sous/issues/613","number":613,"state":"closed","locked":false,"title":"Fixed all-deploys","user":{"login":"nyarly","id":127548,"avatar_url":"https://avatars2.githubusercontent.com/u/127548?v=4","gravatar_id":"","url":"https://api.github.com/users/nyarly","html_url":"https://github.com/nyarly","followers_url":"https://api.github.com/users/nyarly/followers","following_url":"https://api.github.com/users/nyarly/following{/other_user}","gists_url":"https://api.github.com/users/nyarly/gists{/gist_id}","starred_url":"https://api.github.com/users/nyarly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyarly/subscriptions","organizations_url":"https://api.github.com/users/nyarly/orgs","repos_url":"https://api.github.com/users/nyarly/repos","events_url":"https://api.github.com/users/nyarly/events{/privacy}","received_events_url":"https://api.github.com/users/nyarly/received_events","type":"User","site_admin":false},"body":"The /all-deploy-queues endpoint was trying to serialize a map[sous.DeploymentID]int.\nThis was a problem because DeploymentID is a struct - which Go allows as map keys,\nbut JSON does not allow as object field names. There was the further issue that,\nif simply converted to strings, clients would need to reconstruct the DeploymentID\nto retrieve the specific queue.\n\nTherefore, the structure of the response JSON changed. It returns an object keyed\nby deploymentID strings, but where the values are objects with the full DeploymentID\nincluded.\n\nThe change in the data structure meant that the tests needed to be overhauled,\nand I wound up unrolling the complex table test driver.\n\nTo facilitate debugging, I refined the logging in the restful package to ensure\nthat we get logging of HTTP exchanges in some corner cases.","created_at":"2018-03-01T22:45:55Z","updated_at":"2018-03-02T18:52:14Z","closed_at":"2018-03-02T18:52:14Z","merged_at":"2018-03-02T18:52:14Z","merge_commit_sha":"b19a1a72178de0b888523586f4d643ef96e43e1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opentable/sous/pulls/613/commits","review_comments_url":"https://api.github.com/repos/opentable/sous/pulls/613/comments","review_comment_url":"https://api.github.com/repos/opentable/sous/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentable/sous/issues/613/comments","statuses_url":"https://api.github.com/repos/opentable/sous/statuses/d32a44e79671a9f9b2e90877706c894e90a73cd9","head":{"label":"opentable:all_queues_trunc","ref":"all_queues_trunc","sha":"d32a44e79671a9f9b2e90877706c894e90a73cd9","user":{"login":"opentable","id":2653541,"avatar_url":"https://avatars0.githubusercontent.com/u/2653541?v=4","gravatar_id":"","url":"https://api.github.com/users/opentable","html_url":"https://github.com/opentable","followers_url":"https://api.github.com/users/opentable/followers","following_url":"https://api.github.com/users/opentable/following{/other_user}","gists_url":"https://api.github.com/users/opentable/gists{/gist_id}","starred_url":"https://api.github.com/users/opentable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentable/subscriptions","organizations_url":"https://api.github.com/users/opentable/orgs","repos_url":"https://api.github.com/users/opentable/repos","events_url":"https://api.github.com/users/opentable/events{/privacy}","received_events_url":"https://api.github.com/users/opentable/received_events","type":"Organization","site_admin":false},"repo":{"id":43084873,"name":"sous","full_name":"opentable/sous","owner":{"login":"opentable","id":2653541,"avatar_url":"https://avatars0.githubusercontent.com/u/2653541?v=4","gravatar_id":"","url":"https://api.github.com/users/opentable","html_url":"https://github.com/opentable","followers_url":"https://api.github.com/users/opentable/followers","following_url":"https://api.github.com/users/opentable/following{/other_user}","gists_url":"https://api.github.com/users/opentable/gists{/gist_id}","starred_url":"https://api.github.com/users/opentable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentable/subscriptions","organizations_url":"https://api.github.com/users/opentable/orgs","repos_url":"https://api.github.com/users/opentable/repos","events_url":"https://api.github.com/users/opentable/events{/privacy}","received_events_url":"https://api.github.com/users/opentable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentable/sous","description":"Tools for building, testing, deploying Docker containers","fork":false,"url":"https://api.github.com/repos/opentable/sous","forks_url":"https://api.github.com/repos/opentable/sous/forks","keys_url":"https://api.github.com/repos/opentable/sous/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentable/sous/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentable/sous/teams","hooks_url":"https://api.github.com/repos/opentable/sous/hooks","issue_events_url":"https://api.github.com/repos/opentable/sous/issues/events{/number}","events_url":"https://api.github.com/repos/opentable/sous/events","assignees_url":"https://api.github.com/repos/opentable/sous/assignees{/user}","branches_url":"https://api.github.com/repos/opentable/sous/branches{/branch}","tags_url":"https://api.github.com/repos/opentable/sous/tags","blobs_url":"https://api.github.com/repos/opentable/sous/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentable/sous/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentable/sous/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentable/sous/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentable/sous/statuses/{sha}","languages_url":"https://api.github.com/repos/opentable/sous/languages","stargazers_url":"https://api.github.com/repos/opentable/sous/stargazers","contributors_url":"https://api.github.com/repos/opentable/sous/contributors","subscribers_url":"https://api.github.com/repos/opentable/sous/subscribers","subscription_url":"https://api.github.com/repos/opentable/sous/subscription","commits_url":"https://api.github.com/repos/opentable/sous/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentable/sous/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentable/sous/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentable/sous/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentable/sous/contents/{+path}","compare_url":"https://api.github.com/repos/opentable/sous/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentable/sous/merges","archive_url":"https://api.github.com/repos/opentable/sous/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentable/sous/downloads","issues_url":"https://api.github.com/repos/opentable/sous/issues{/number}","pulls_url":"https://api.github.com/repos/opentable/sous/pulls{/number}","milestones_url":"https://api.github.com/repos/opentable/sous/milestones{/number}","notifications_url":"https://api.github.com/repos/opentable/sous/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentable/sous/labels{/name}","releases_url":"https://api.github.com/repos/opentable/sous/releases{/id}","deployments_url":"https://api.github.com/repos/opentable/sous/deployments","created_at":"2015-09-24T18:22:46Z","updated_at":"2018-01-11T20:03:41Z","pushed_at":"2018-03-02T18:52:14Z","git_url":"git://github.com/opentable/sous.git","ssh_url":"git@github.com:opentable/sous.git","clone_url":"https://github.com/opentable/sous.git","svn_url":"https://github.com/opentable/sous","homepage":"","size":15829,"stargazers_count":43,"watchers_count":43,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":18,"open_issues":3,"watchers":43,"default_branch":"master"}},"base":{"label":"opentable:master","ref":"master","sha":"d80d94f255ffa43455b6882bcee093972358fe01","user":{"login":"opentable","id":2653541,"avatar_url":"https://avatars0.githubusercontent.com/u/2653541?v=4","gravatar_id":"","url":"https://api.github.com/users/opentable","html_url":"https://github.com/opentable","followers_url":"https://api.github.com/users/opentable/followers","following_url":"https://api.github.com/users/opentable/following{/other_user}","gists_url":"https://api.github.com/users/opentable/gists{/gist_id}","starred_url":"https://api.github.com/users/opentable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentable/subscriptions","organizations_url":"https://api.github.com/users/opentable/orgs","repos_url":"https://api.github.com/users/opentable/repos","events_url":"https://api.github.com/users/opentable/events{/privacy}","received_events_url":"https://api.github.com/users/opentable/received_events","type":"Organization","site_admin":false},"repo":{"id":43084873,"name":"sous","full_name":"opentable/sous","owner":{"login":"opentable","id":2653541,"avatar_url":"https://avatars0.githubusercontent.com/u/2653541?v=4","gravatar_id":"","url":"https://api.github.com/users/opentable","html_url":"https://github.com/opentable","followers_url":"https://api.github.com/users/opentable/followers","following_url":"https://api.github.com/users/opentable/following{/other_user}","gists_url":"https://api.github.com/users/opentable/gists{/gist_id}","starred_url":"https://api.github.com/users/opentable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentable/subscriptions","organizations_url":"https://api.github.com/users/opentable/orgs","repos_url":"https://api.github.com/users/opentable/repos","events_url":"https://api.github.com/users/opentable/events{/privacy}","received_events_url":"https://api.github.com/users/opentable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentable/sous","description":"Tools for building, testing, deploying Docker containers","fork":false,"url":"https://api.github.com/repos/opentable/sous","forks_url":"https://api.github.com/repos/opentable/sous/forks","keys_url":"https://api.github.com/repos/opentable/sous/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentable/sous/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentable/sous/teams","hooks_url":"https://api.github.com/repos/opentable/sous/hooks","issue_events_url":"https://api.github.com/repos/opentable/sous/issues/events{/number}","events_url":"https://api.github.com/repos/opentable/sous/events","assignees_url":"https://api.github.com/repos/opentable/sous/assignees{/user}","branches_url":"https://api.github.com/repos/opentable/sous/branches{/branch}","tags_url":"https://api.github.com/repos/opentable/sous/tags","blobs_url":"https://api.github.com/repos/opentable/sous/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentable/sous/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentable/sous/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentable/sous/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentable/sous/statuses/{sha}","languages_url":"https://api.github.com/repos/opentable/sous/languages","stargazers_url":"https://api.github.com/repos/opentable/sous/stargazers","contributors_url":"https://api.github.com/repos/opentable/sous/contributors","subscribers_url":"https://api.github.com/repos/opentable/sous/subscribers","subscription_url":"https://api.github.com/repos/opentable/sous/subscription","commits_url":"https://api.github.com/repos/opentable/sous/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentable/sous/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentable/sous/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentable/sous/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentable/sous/contents/{+path}","compare_url":"https://api.github.com/repos/opentable/sous/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentable/sous/merges","archive_url":"https://api.github.com/repos/opentable/sous/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentable/sous/downloads","issues_url":"https://api.github.com/repos/opentable/sous/issues{/number}","pulls_url":"https://api.github.com/repos/opentable/sous/pulls{/number}","milestones_url":"https://api.github.com/repos/opentable/sous/milestones{/number}","notifications_url":"https://api.github.com/repos/opentable/sous/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentable/sous/labels{/name}","releases_url":"https://api.github.com/repos/opentable/sous/releases{/id}","deployments_url":"https://api.github.com/repos/opentable/sous/deployments","created_at":"2015-09-24T18:22:46Z","updated_at":"2018-01-11T20:03:41Z","pushed_at":"2018-03-02T18:52:14Z","git_url":"git://github.com/opentable/sous.git","ssh_url":"git@github.com:opentable/sous.git","clone_url":"https://github.com/opentable/sous.git","svn_url":"https://github.com/opentable/sous","homepage":"","size":15829,"stargazers_count":43,"watchers_count":43,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":18,"open_issues":3,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentable/sous/pulls/613"},"html":{"href":"https://github.com/opentable/sous/pull/613"},"issue":{"href":"https://api.github.com/repos/opentable/sous/issues/613"},"comments":{"href":"https://api.github.com/repos/opentable/sous/issues/613/comments"},"review_comments":{"href":"https://api.github.com/repos/opentable/sous/pulls/613/comments"},"review_comment":{"href":"https://api.github.com/repos/opentable/sous/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentable/sous/pulls/613/commits"},"statuses":{"href":"https://api.github.com/repos/opentable/sous/statuses/d32a44e79671a9f9b2e90877706c894e90a73cd9"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nyarly","id":127548,"avatar_url":"https://avatars2.githubusercontent.com/u/127548?v=4","gravatar_id":"","url":"https://api.github.com/users/nyarly","html_url":"https://github.com/nyarly","followers_url":"https://api.github.com/users/nyarly/followers","following_url":"https://api.github.com/users/nyarly/following{/other_user}","gists_url":"https://api.github.com/users/nyarly/gists{/gist_id}","starred_url":"https://api.github.com/users/nyarly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyarly/subscriptions","organizations_url":"https://api.github.com/users/nyarly/orgs","repos_url":"https://api.github.com/users/nyarly/repos","events_url":"https://api.github.com/users/nyarly/events{/privacy}","received_events_url":"https://api.github.com/users/nyarly/received_events","type":"User","site_admin":false},"comments":1,"review_comments":12,"maintainer_can_modify":false,"commits":9,"additions":193,"deletions":151,"changed_files":9}}
{"actor":{"display_login":"nyarly"}}