{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63866","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63866/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63866/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63866/events","html_url":"https://github.com/kubernetes/kubernetes/pull/63866","id":323243222,"number":63866,"title":" kubeadm: Remove the `.CloudProvider` and `.PrivilegedPods` configuration option","user":{"login":"luxas","id":5442475,"avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":451459590,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubeadm","name":"area/kubeadm","color":"0052cc","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":354968448,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-action-required","name":"release-note-action-required","color":"c2e0c6","default":false},{"id":173494222,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":253451093,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-15T14:28:12Z","updated_at":"2018-05-15T15:09:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63866","html_url":"https://github.com/kubernetes/kubernetes/pull/63866","diff_url":"https://github.com/kubernetes/kubernetes/pull/63866.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/63866.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nRemoves the `.CloudProvider` option, it has been experimental for a long time. People should now use external cloud providers, which is beta in v1.11. Most importantly, you can get the exact same behavior in the API by utilizing the `.*ExtraArgs` and `.*ExtraVolumes` fields.\r\nRemoves `.PrivilegedPods` as that serves a super small edge case with the legacy cloud provider, and only for openstack.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nPart of https://github.com/kubernetes/community/pull/2131\r\n\r\n**Special notes for your reviewer**:\r\nDepends on PRs:\r\n - [ ] #63799\r\n - [ ] #63788\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n[action required] In the new v1alpha2 kubeadm Configuration API, the `.CloudProvider` and `.PrivilegedPods` fields don't exist anymore. Instead, you should use the out-of-tree cloud provider implementations which are beta in v1.11. If you must use the legacy in-tree cloud providers, you can rearrange your config like this:\r\n---\r\nkind: MasterConfiguration\r\napiVersion: kubeadm.k8s.io/v1alpha2\r\napiServerExtraArgs:\r\n  cloud-provider: \"{cloud}\"\r\n  cloud-config: \"{path}\"\r\napiServerExtraVolumes:\r\n- name: cloud\r\n  hostPath: \"{path}\"\r\n  mountPath: \"{path}\"\r\ncontrollerManagerExtraArgs:\r\n  cloud-provider: \"{cloud}\"\r\n  cloud-config: \"{path}\"\r\ncontrollerManagerExtraVolumes:\r\n- name: cloud\r\n  hostPath: \"{path}\"\r\n  mountPath: \"{path}\"\r\n---\r\n```\r\n@kubernetes/sig-cluster-lifecycle-pr-reviews @dims @liztio "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/389202626","html_url":"https://github.com/kubernetes/kubernetes/pull/63866#issuecomment-389202626","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63866","id":389202626,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-05-15T15:09:50Z","updated_at":"2018-05-15T15:09:50Z","author_association":"COLLABORATOR","body":"@luxas: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-bazel-test | 7dac0a3fb2ee6b33ff0b2c4b5cc9cd95c2df3e30 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63866/pull-kubernetes-bazel-test/44807/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-typecheck | 7dac0a3fb2ee6b33ff0b2c4b5cc9cd95c2df3e30 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63866/pull-kubernetes-typecheck/9838/) | `/test pull-kubernetes-typecheck`\npull-kubernetes-verify | 7dac0a3fb2ee6b33ff0b2c4b5cc9cd95c2df3e30 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63866/pull-kubernetes-verify/90892/) | `/test pull-kubernetes-verify`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/63866). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/luxas). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}