{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/comments/189752130","pull_request_review_id":121991756,"id":189752130,"diff_hunk":"@@ -0,0 +1,355 @@\n+#include \"pch.h\"\n+\n+#include \"android_http_request.h\"\n+\n+#include <httpClient/httpClient.h>\n+\n+/* static */ JavaVM* HttpRequest::s_javaVM = nullptr;\n+/* static */ jclass HttpRequest::s_httpRequestClass = nullptr;\n+/* static */ jclass HttpRequest::s_httpResponseClass = nullptr;\n+\n+/* static */ HRESULT HttpRequest::InitializeJavaEnvironment(JavaVM* javaVM) \n+{\n+    s_javaVM = javaVM;","path":"Source/HTTP/Android/android_http_request.cpp","position":13,"original_position":13,"commit_id":"bc7815a9e563ef5b2a91ac0116675e648427267a","original_commit_id":"bc7815a9e563ef5b2a91ac0116675e648427267a","user":{"login":"lubeltra","id":23346905,"avatar_url":"https://avatars1.githubusercontent.com/u/23346905?v=4","gravatar_id":"","url":"https://api.github.com/users/lubeltra","html_url":"https://github.com/lubeltra","followers_url":"https://api.github.com/users/lubeltra/followers","following_url":"https://api.github.com/users/lubeltra/following{/other_user}","gists_url":"https://api.github.com/users/lubeltra/gists{/gist_id}","starred_url":"https://api.github.com/users/lubeltra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lubeltra/subscriptions","organizations_url":"https://api.github.com/users/lubeltra/orgs","repos_url":"https://api.github.com/users/lubeltra/repos","events_url":"https://api.github.com/users/lubeltra/events{/privacy}","received_events_url":"https://api.github.com/users/lubeltra/received_events","type":"User","site_admin":false},"body":">javaVM [](start = 15, length = 6)\r\n\r\nassert non null","created_at":"2018-05-22T00:55:30Z","updated_at":"2018-05-22T00:55:30Z","html_url":"https://github.com/Microsoft/libHttpClient/pull/165#discussion_r189752130","pull_request_url":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/165","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/comments/189752130"},"html":{"href":"https://github.com/Microsoft/libHttpClient/pull/165#discussion_r189752130"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/165"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/165","id":189519153,"html_url":"https://github.com/Microsoft/libHttpClient/pull/165","diff_url":"https://github.com/Microsoft/libHttpClient/pull/165.diff","patch_url":"https://github.com/Microsoft/libHttpClient/pull/165.patch","issue_url":"https://api.github.com/repos/Microsoft/libHttpClient/issues/165","number":165,"state":"open","locked":false,"title":"Initial Android HTTP implementation","user":{"login":"shanelile","id":29309184,"avatar_url":"https://avatars3.githubusercontent.com/u/29309184?v=4","gravatar_id":"","url":"https://api.github.com/users/shanelile","html_url":"https://github.com/shanelile","followers_url":"https://api.github.com/users/shanelile/followers","following_url":"https://api.github.com/users/shanelile/following{/other_user}","gists_url":"https://api.github.com/users/shanelile/gists{/gist_id}","starred_url":"https://api.github.com/users/shanelile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanelile/subscriptions","organizations_url":"https://api.github.com/users/shanelile/orgs","repos_url":"https://api.github.com/users/shanelile/repos","events_url":"https://api.github.com/users/shanelile/events{/privacy}","received_events_url":"https://api.github.com/users/shanelile/received_events","type":"User","site_admin":false},"body":"This is the initial stab at a basic Android HTTP implemention for libHttpClient. It includes a new androidproj with a simple wrapper around OkHttp and enough entry points to manage extracting the data we need from hc_call and then populating the response. I've verified that basic calls work by integrating into our test XAL app and getting far enough to request a D token. This raises some questions but I felt the context of the pull request would make it easier to understand the motivations behind them and I'll add them inline.","created_at":"2018-05-22T00:18:58Z","updated_at":"2018-05-22T00:55:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af377a177abca14f650fcfd45f39a48067e5759a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/165/commits","review_comments_url":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/165/comments","review_comment_url":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/libHttpClient/issues/165/comments","statuses_url":"https://api.github.com/repos/Microsoft/libHttpClient/statuses/bc7815a9e563ef5b2a91ac0116675e648427267a","head":{"label":"shanelile:shanel/android_http","ref":"shanel/android_http","sha":"bc7815a9e563ef5b2a91ac0116675e648427267a","user":{"login":"shanelile","id":29309184,"avatar_url":"https://avatars3.githubusercontent.com/u/29309184?v=4","gravatar_id":"","url":"https://api.github.com/users/shanelile","html_url":"https://github.com/shanelile","followers_url":"https://api.github.com/users/shanelile/followers","following_url":"https://api.github.com/users/shanelile/following{/other_user}","gists_url":"https://api.github.com/users/shanelile/gists{/gist_id}","starred_url":"https://api.github.com/users/shanelile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanelile/subscriptions","organizations_url":"https://api.github.com/users/shanelile/orgs","repos_url":"https://api.github.com/users/shanelile/repos","events_url":"https://api.github.com/users/shanelile/events{/privacy}","received_events_url":"https://api.github.com/users/shanelile/received_events","type":"User","site_admin":false},"repo":{"id":125540043,"name":"libHttpClient","full_name":"shanelile/libHttpClient","owner":{"login":"shanelile","id":29309184,"avatar_url":"https://avatars3.githubusercontent.com/u/29309184?v=4","gravatar_id":"","url":"https://api.github.com/users/shanelile","html_url":"https://github.com/shanelile","followers_url":"https://api.github.com/users/shanelile/followers","following_url":"https://api.github.com/users/shanelile/following{/other_user}","gists_url":"https://api.github.com/users/shanelile/gists{/gist_id}","starred_url":"https://api.github.com/users/shanelile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanelile/subscriptions","organizations_url":"https://api.github.com/users/shanelile/orgs","repos_url":"https://api.github.com/users/shanelile/repos","events_url":"https://api.github.com/users/shanelile/events{/privacy}","received_events_url":"https://api.github.com/users/shanelile/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shanelile/libHttpClient","description":"libHttpClient is still under construction and is not ready to use.   You can review the goals below to see what shape the project will have in its final form. If you want to contribute on the project, please talk to us to avoid overlap.","fork":true,"url":"https://api.github.com/repos/shanelile/libHttpClient","forks_url":"https://api.github.com/repos/shanelile/libHttpClient/forks","keys_url":"https://api.github.com/repos/shanelile/libHttpClient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shanelile/libHttpClient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shanelile/libHttpClient/teams","hooks_url":"https://api.github.com/repos/shanelile/libHttpClient/hooks","issue_events_url":"https://api.github.com/repos/shanelile/libHttpClient/issues/events{/number}","events_url":"https://api.github.com/repos/shanelile/libHttpClient/events","assignees_url":"https://api.github.com/repos/shanelile/libHttpClient/assignees{/user}","branches_url":"https://api.github.com/repos/shanelile/libHttpClient/branches{/branch}","tags_url":"https://api.github.com/repos/shanelile/libHttpClient/tags","blobs_url":"https://api.github.com/repos/shanelile/libHttpClient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shanelile/libHttpClient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shanelile/libHttpClient/git/refs{/sha}","trees_url":"https://api.github.com/repos/shanelile/libHttpClient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shanelile/libHttpClient/statuses/{sha}","languages_url":"https://api.github.com/repos/shanelile/libHttpClient/languages","stargazers_url":"https://api.github.com/repos/shanelile/libHttpClient/stargazers","contributors_url":"https://api.github.com/repos/shanelile/libHttpClient/contributors","subscribers_url":"https://api.github.com/repos/shanelile/libHttpClient/subscribers","subscription_url":"https://api.github.com/repos/shanelile/libHttpClient/subscription","commits_url":"https://api.github.com/repos/shanelile/libHttpClient/commits{/sha}","git_commits_url":"https://api.github.com/repos/shanelile/libHttpClient/git/commits{/sha}","comments_url":"https://api.github.com/repos/shanelile/libHttpClient/comments{/number}","issue_comment_url":"https://api.github.com/repos/shanelile/libHttpClient/issues/comments{/number}","contents_url":"https://api.github.com/repos/shanelile/libHttpClient/contents/{+path}","compare_url":"https://api.github.com/repos/shanelile/libHttpClient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shanelile/libHttpClient/merges","archive_url":"https://api.github.com/repos/shanelile/libHttpClient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shanelile/libHttpClient/downloads","issues_url":"https://api.github.com/repos/shanelile/libHttpClient/issues{/number}","pulls_url":"https://api.github.com/repos/shanelile/libHttpClient/pulls{/number}","milestones_url":"https://api.github.com/repos/shanelile/libHttpClient/milestones{/number}","notifications_url":"https://api.github.com/repos/shanelile/libHttpClient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shanelile/libHttpClient/labels{/name}","releases_url":"https://api.github.com/repos/shanelile/libHttpClient/releases{/id}","deployments_url":"https://api.github.com/repos/shanelile/libHttpClient/deployments","created_at":"2018-03-16T16:08:02Z","updated_at":"2018-05-15T18:11:52Z","pushed_at":"2018-05-22T00:16:41Z","git_url":"git://github.com/shanelile/libHttpClient.git","ssh_url":"git@github.com:shanelile/libHttpClient.git","clone_url":"https://github.com/shanelile/libHttpClient.git","svn_url":"https://github.com/shanelile/libHttpClient","homepage":null,"size":2693,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"edef23ddc7e5ec47ebcf61f68705ed964319a223","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":93995266,"name":"libHttpClient","full_name":"Microsoft/libHttpClient","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/libHttpClient","description":"libHttpClient provides a platform abstraction layer for HTTP and WebSocket, and is designed for use by the Microsoft Xbox Live Service API (XSAPI) [https://github.com/Microsoft/xbox-live-api].  If you want to contribute to the project, please talk to us to avoid overlap.","fork":false,"url":"https://api.github.com/repos/Microsoft/libHttpClient","forks_url":"https://api.github.com/repos/Microsoft/libHttpClient/forks","keys_url":"https://api.github.com/repos/Microsoft/libHttpClient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/libHttpClient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/libHttpClient/teams","hooks_url":"https://api.github.com/repos/Microsoft/libHttpClient/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/libHttpClient/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/libHttpClient/events","assignees_url":"https://api.github.com/repos/Microsoft/libHttpClient/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/libHttpClient/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/libHttpClient/tags","blobs_url":"https://api.github.com/repos/Microsoft/libHttpClient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/libHttpClient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/libHttpClient/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/libHttpClient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/libHttpClient/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/libHttpClient/languages","stargazers_url":"https://api.github.com/repos/Microsoft/libHttpClient/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/libHttpClient/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/libHttpClient/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/libHttpClient/subscription","commits_url":"https://api.github.com/repos/Microsoft/libHttpClient/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/libHttpClient/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/libHttpClient/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/libHttpClient/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/libHttpClient/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/libHttpClient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/libHttpClient/merges","archive_url":"https://api.github.com/repos/Microsoft/libHttpClient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/libHttpClient/downloads","issues_url":"https://api.github.com/repos/Microsoft/libHttpClient/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/libHttpClient/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/libHttpClient/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/libHttpClient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/libHttpClient/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/libHttpClient/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/libHttpClient/deployments","created_at":"2017-06-11T09:45:05Z","updated_at":"2018-05-18T08:47:59Z","pushed_at":"2018-05-22T00:36:46Z","git_url":"git://github.com/Microsoft/libHttpClient.git","ssh_url":"git@github.com:Microsoft/libHttpClient.git","clone_url":"https://github.com/Microsoft/libHttpClient.git","svn_url":"https://github.com/Microsoft/libHttpClient","homepage":"","size":2595,"stargazers_count":62,"watchers_count":62,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":24,"open_issues":1,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/165"},"html":{"href":"https://github.com/Microsoft/libHttpClient/pull/165"},"issue":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/issues/165"},"comments":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/statuses/bc7815a9e563ef5b2a91ac0116675e648427267a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lubeltra"}}