{"action":"created","comment":{"url":"https://api.github.com/repos/coq/coq/pulls/comments/201919472","pull_request_review_id":136513894,"id":201919472,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTkxOTQ3Mg==","diff_hunk":"@@ -0,0 +1,32 @@\n+Set Warnings \"+deprecated\".\n+\n+#[deprecated(since = \"8.8\", note = \"Use idtac instead\")]\n+Ltac foo x := idtac.\n+\n+Goal True.\n+Fail (foo true).\n+Abort.\n+\n+Fail Ltac bar := foo.\n+Fail Tactic Notation \"bar\" := foo.\n+\n+#[deprecated(since = \"8.8\", note = \"Use idtac instead\")]\n+Tactic Notation \"bar\" := idtac.\n+\n+Goal True.\n+Fail bar.\n+Abort.\n+\n+(* Fail Ltac zar := bar. *)\n+\n+Set Warnings \"-deprecated\".\n+\n+Ltac zar := foo.\n+Ltac zarzar := bar.\n+\n+Set Warnings \"+deprecated\".\n+\n+Goal True.\n+zar x.\n+zarzar.","path":"test-suite/success/LtacDeprecation.v","position":31,"original_position":31,"commit_id":"b3e25e51e6232b405a185d1db8d634502b23815f","original_commit_id":"94629e3e8e5ba6fdce7a1ff06ef10e1e15a7ef97","user":{"login":"maximedenes","id":647105,"node_id":"MDQ6VXNlcjY0NzEwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false},"body":"Now fixed.","created_at":"2018-07-12T06:13:58Z","updated_at":"2018-07-12T06:13:58Z","html_url":"https://github.com/coq/coq/pull/7907#discussion_r201919472","pull_request_url":"https://api.github.com/repos/coq/coq/pulls/7907","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/comments/201919472"},"html":{"href":"https://github.com/coq/coq/pull/7907#discussion_r201919472"},"pull_request":{"href":"https://api.github.com/repos/coq/coq/pulls/7907"}},"in_reply_to_id":201255041},"pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/7907","id":196904948,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTA0OTQ4","html_url":"https://github.com/coq/coq/pull/7907","diff_url":"https://github.com/coq/coq/pull/7907.diff","patch_url":"https://github.com/coq/coq/pull/7907.patch","issue_url":"https://api.github.com/repos/coq/coq/issues/7907","number":7907,"state":"open","locked":false,"title":"Tactic deprecation machinery","user":{"login":"maximedenes","id":647105,"node_id":"MDQ6VXNlcjY0NzEwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false},"body":"We make it possible to deprecate tactics defined by `Ltac`, `Tactic\r\nNotation` or ML.\r\n\r\nFor the first two variants, we anticipate the syntax of attributes:\r\n`#[deprecated(since = \"XX\", note = \"YY\")]`\r\n\r\nIn ML, the syntax is:\r\n\r\n```\r\nlet reflexivity_depr =\r\n  let open CWarnings in\r\n  { since = \"8.5\"; note = \"Use admit instead.\" }\r\n\r\nTACTIC EXTEND reflexivity DEPRECATED reflexivity_depr\r\n  [ \"reflexivity\" ] -> [ Tactics.intros_reflexivity ]\r\nEND\r\n```\r\n\r\nA warning is shown at the point where the tactic is used (either\r\na direct call or when defining another tactic):\r\n\r\nTactic `foo` is deprecated since XX. YY\r\n\r\nYY is typically meant to be \"Use bar instead.\".\r\n\r\n- [X] Added / updated test-suite\r\n- [x] Corresponding documentation was added / updated (including any warning and error messages added / removed / modified).\r\n- [x] Entry added in CHANGES.","created_at":"2018-06-23T14:34:30Z","updated_at":"2018-07-12T06:13:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bc8018128f38f09e9e5202d9e021aea2b2f4743","assignee":{"login":"ppedrot","id":1202327,"node_id":"MDQ6VXNlcjEyMDIzMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1202327?v=4","gravatar_id":"","url":"https://api.github.com/users/ppedrot","html_url":"https://github.com/ppedrot","followers_url":"https://api.github.com/users/ppedrot/followers","following_url":"https://api.github.com/users/ppedrot/following{/other_user}","gists_url":"https://api.github.com/users/ppedrot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppedrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppedrot/subscriptions","organizations_url":"https://api.github.com/users/ppedrot/orgs","repos_url":"https://api.github.com/users/ppedrot/repos","events_url":"https://api.github.com/users/ppedrot/events{/privacy}","received_events_url":"https://api.github.com/users/ppedrot/received_events","type":"User","site_admin":false},"assignees":[{"login":"ppedrot","id":1202327,"node_id":"MDQ6VXNlcjEyMDIzMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1202327?v=4","gravatar_id":"","url":"https://api.github.com/users/ppedrot","html_url":"https://github.com/ppedrot","followers_url":"https://api.github.com/users/ppedrot/followers","following_url":"https://api.github.com/users/ppedrot/following{/other_user}","gists_url":"https://api.github.com/users/ppedrot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppedrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppedrot/subscriptions","organizations_url":"https://api.github.com/users/ppedrot/orgs","repos_url":"https://api.github.com/users/ppedrot/repos","events_url":"https://api.github.com/users/ppedrot/events{/privacy}","received_events_url":"https://api.github.com/users/ppedrot/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":485986179,"node_id":"MDU6TGFiZWw0ODU5ODYxNzk=","url":"https://api.github.com/repos/coq/coq/labels/kind:%20feature","name":"kind: feature","color":"0e8a16","default":false},{"id":698064744,"node_id":"MDU6TGFiZWw2OTgwNjQ3NDQ=","url":"https://api.github.com/repos/coq/coq/labels/part:%20tactics","name":"part: tactics","color":"dddddd","default":false}],"milestone":{"url":"https://api.github.com/repos/coq/coq/milestones/7","html_url":"https://github.com/coq/coq/milestone/7","labels_url":"https://api.github.com/repos/coq/coq/milestones/7/labels","id":2647743,"node_id":"MDk6TWlsZXN0b25lMjY0Nzc0Mw==","number":7,"title":"8.9+beta1","description":"The date of the feature freeze has not been announced yet.","creator":{"login":"Zimmi48","id":1108325,"node_id":"MDQ6VXNlcjExMDgzMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1108325?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimmi48","html_url":"https://github.com/Zimmi48","followers_url":"https://api.github.com/users/Zimmi48/followers","following_url":"https://api.github.com/users/Zimmi48/following{/other_user}","gists_url":"https://api.github.com/users/Zimmi48/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimmi48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimmi48/subscriptions","organizations_url":"https://api.github.com/users/Zimmi48/orgs","repos_url":"https://api.github.com/users/Zimmi48/repos","events_url":"https://api.github.com/users/Zimmi48/events{/privacy}","received_events_url":"https://api.github.com/users/Zimmi48/received_events","type":"User","site_admin":false},"open_issues":122,"closed_issues":322,"state":"open","created_at":"2017-07-18T15:03:25Z","updated_at":"2018-07-11T16:10:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/coq/coq/pulls/7907/commits","review_comments_url":"https://api.github.com/repos/coq/coq/pulls/7907/comments","review_comment_url":"https://api.github.com/repos/coq/coq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coq/coq/issues/7907/comments","statuses_url":"https://api.github.com/repos/coq/coq/statuses/b3e25e51e6232b405a185d1db8d634502b23815f","head":{"label":"maximedenes:ltac-deprecation","ref":"ltac-deprecation","sha":"b3e25e51e6232b405a185d1db8d634502b23815f","user":{"login":"maximedenes","id":647105,"node_id":"MDQ6VXNlcjY0NzEwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false},"repo":{"id":15363052,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2MzA1Mg==","name":"coq","full_name":"maximedenes/coq","owner":{"login":"maximedenes","id":647105,"node_id":"MDQ6VXNlcjY0NzEwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maximedenes/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":true,"url":"https://api.github.com/repos/maximedenes/coq","forks_url":"https://api.github.com/repos/maximedenes/coq/forks","keys_url":"https://api.github.com/repos/maximedenes/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maximedenes/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maximedenes/coq/teams","hooks_url":"https://api.github.com/repos/maximedenes/coq/hooks","issue_events_url":"https://api.github.com/repos/maximedenes/coq/issues/events{/number}","events_url":"https://api.github.com/repos/maximedenes/coq/events","assignees_url":"https://api.github.com/repos/maximedenes/coq/assignees{/user}","branches_url":"https://api.github.com/repos/maximedenes/coq/branches{/branch}","tags_url":"https://api.github.com/repos/maximedenes/coq/tags","blobs_url":"https://api.github.com/repos/maximedenes/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maximedenes/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maximedenes/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/maximedenes/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maximedenes/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/maximedenes/coq/languages","stargazers_url":"https://api.github.com/repos/maximedenes/coq/stargazers","contributors_url":"https://api.github.com/repos/maximedenes/coq/contributors","subscribers_url":"https://api.github.com/repos/maximedenes/coq/subscribers","subscription_url":"https://api.github.com/repos/maximedenes/coq/subscription","commits_url":"https://api.github.com/repos/maximedenes/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/maximedenes/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/maximedenes/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/maximedenes/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/maximedenes/coq/contents/{+path}","compare_url":"https://api.github.com/repos/maximedenes/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maximedenes/coq/merges","archive_url":"https://api.github.com/repos/maximedenes/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maximedenes/coq/downloads","issues_url":"https://api.github.com/repos/maximedenes/coq/issues{/number}","pulls_url":"https://api.github.com/repos/maximedenes/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/maximedenes/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/maximedenes/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maximedenes/coq/labels{/name}","releases_url":"https://api.github.com/repos/maximedenes/coq/releases{/id}","deployments_url":"https://api.github.com/repos/maximedenes/coq/deployments","created_at":"2013-12-21T17:52:21Z","updated_at":"2018-05-25T12:57:12Z","pushed_at":"2018-07-11T15:28:26Z","git_url":"git://github.com/maximedenes/coq.git","ssh_url":"git@github.com:maximedenes/coq.git","clone_url":"https://github.com/maximedenes/coq.git","svn_url":"https://github.com/maximedenes/coq","homepage":"http://coq.inria.fr/","size":101656,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"coq:master","ref":"master","sha":"bd0a681350b1bc8947d6d7603dc6a9759f0c7897","user":{"login":"coq","id":621198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTE5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"repo":{"id":1377159,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3MTU5","name":"coq","full_name":"coq/coq","owner":{"login":"coq","id":621198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTE5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coq/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":false,"url":"https://api.github.com/repos/coq/coq","forks_url":"https://api.github.com/repos/coq/coq/forks","keys_url":"https://api.github.com/repos/coq/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coq/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coq/coq/teams","hooks_url":"https://api.github.com/repos/coq/coq/hooks","issue_events_url":"https://api.github.com/repos/coq/coq/issues/events{/number}","events_url":"https://api.github.com/repos/coq/coq/events","assignees_url":"https://api.github.com/repos/coq/coq/assignees{/user}","branches_url":"https://api.github.com/repos/coq/coq/branches{/branch}","tags_url":"https://api.github.com/repos/coq/coq/tags","blobs_url":"https://api.github.com/repos/coq/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coq/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coq/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/coq/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coq/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/coq/coq/languages","stargazers_url":"https://api.github.com/repos/coq/coq/stargazers","contributors_url":"https://api.github.com/repos/coq/coq/contributors","subscribers_url":"https://api.github.com/repos/coq/coq/subscribers","subscription_url":"https://api.github.com/repos/coq/coq/subscription","commits_url":"https://api.github.com/repos/coq/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/coq/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/coq/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/coq/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/coq/coq/contents/{+path}","compare_url":"https://api.github.com/repos/coq/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coq/coq/merges","archive_url":"https://api.github.com/repos/coq/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coq/coq/downloads","issues_url":"https://api.github.com/repos/coq/coq/issues{/number}","pulls_url":"https://api.github.com/repos/coq/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/coq/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/coq/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coq/coq/labels{/name}","releases_url":"https://api.github.com/repos/coq/coq/releases{/id}","deployments_url":"https://api.github.com/repos/coq/coq/deployments","created_at":"2011-02-17T05:49:37Z","updated_at":"2018-07-11T12:37:51Z","pushed_at":"2018-07-11T18:36:03Z","git_url":"git://github.com/coq/coq.git","ssh_url":"git@github.com:coq/coq.git","clone_url":"https://github.com/coq/coq.git","svn_url":"https://github.com/coq/coq","homepage":"https://coq.inria.fr/","size":113180,"stargazers_count":1316,"watchers_count":1316,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":260,"mirror_url":null,"archived":false,"open_issues_count":1675,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":260,"open_issues":1675,"watchers":1316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/7907"},"html":{"href":"https://github.com/coq/coq/pull/7907"},"issue":{"href":"https://api.github.com/repos/coq/coq/issues/7907"},"comments":{"href":"https://api.github.com/repos/coq/coq/issues/7907/comments"},"review_comments":{"href":"https://api.github.com/repos/coq/coq/pulls/7907/comments"},"review_comment":{"href":"https://api.github.com/repos/coq/coq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coq/coq/pulls/7907/commits"},"statuses":{"href":"https://api.github.com/repos/coq/coq/statuses/b3e25e51e6232b405a185d1db8d634502b23815f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"maximedenes"}}