{"action":"created","comment":{"url":"https://api.github.com/repos/line/armeria/pulls/comments/231388208","pull_request_review_id":172347281,"id":231388208,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTM4ODIwOA==","diff_hunk":"@@ -0,0 +1,80 @@\n+.. _`Spring Boot Reference Guide`: https://docs.spring.io/spring-boot/docs/current/reference/html/\n+.. _`armeria-examples`: https://github.com/line/armeria-examples\n+\n+.. _advanced-spring-webflux-integration:\n+\n+Using Armeria as a web server of a reactive Spring application\n+==============================================================\n+\n+A user can use Armeria as a web server of his or her reactive Spring application by adding\n+`spring-boot-webflux-starter` to the dependencies.\n+\n+For Maven:\n+\n+.. code-block:: xml\n+\n+    <dependency>\n+        <groupId>com.linecorp.armeria</groupId>\n+        <artifactId>spring-boot-webflux-starter</artifactId>\n+    </dependency>\n+\n+For Gradle:\n+\n+.. code-block:: groovy\n+\n+    dependencies {\n+        compile 'com.linecorp.armeria:spring-boot-webflux-starter'","path":"site/src/sphinx/advanced-spring-webflux-integration.rst","position":26,"original_position":26,"commit_id":"23a1d32b0c8ec40a1e52b1884f697359c366dedc","original_commit_id":"23a1d32b0c8ec40a1e52b1884f697359c366dedc","user":{"login":"trustin","id":173918,"node_id":"MDQ6VXNlcjE3MzkxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/173918?v=4","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"body":"version?","created_at":"2018-11-07T06:02:56Z","updated_at":"2018-11-07T06:06:05Z","html_url":"https://github.com/line/armeria/pull/1326#discussion_r231388208","pull_request_url":"https://api.github.com/repos/line/armeria/pulls/1326","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/comments/231388208"},"html":{"href":"https://github.com/line/armeria/pull/1326#discussion_r231388208"},"pull_request":{"href":"https://api.github.com/repos/line/armeria/pulls/1326"}}},"pull_request":{"url":"https://api.github.com/repos/line/armeria/pulls/1326","id":206923410,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2OTIzNDEw","html_url":"https://github.com/line/armeria/pull/1326","diff_url":"https://github.com/line/armeria/pull/1326.diff","patch_url":"https://github.com/line/armeria/pull/1326.patch","issue_url":"https://api.github.com/repos/line/armeria/issues/1326","number":1326,"state":"open","locked":false,"title":"Add ArmeriaWebServer which can be a reactive web server for Spring Boot application","user":{"login":"hyangtack","id":8417787,"node_id":"MDQ6VXNlcjg0MTc3ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/8417787?v=4","gravatar_id":"","url":"https://api.github.com/users/hyangtack","html_url":"https://github.com/hyangtack","followers_url":"https://api.github.com/users/hyangtack/followers","following_url":"https://api.github.com/users/hyangtack/following{/other_user}","gists_url":"https://api.github.com/users/hyangtack/gists{/gist_id}","starred_url":"https://api.github.com/users/hyangtack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyangtack/subscriptions","organizations_url":"https://api.github.com/users/hyangtack/orgs","repos_url":"https://api.github.com/users/hyangtack/repos","events_url":"https://api.github.com/users/hyangtack/events{/privacy}","received_events_url":"https://api.github.com/users/hyangtack/received_events","type":"User","site_admin":false},"body":"Motivation:\r\nSpring Boot provides a way to add a custom web server, so it would be helpful to let our Spring user have Armeria web server using `armeria-spring-boot-starter`.\r\n\r\nModifications:\r\n- Add `ArmeriaWebServer` and its factory to `boot-webflux-autoconfigure`.\r\n  - Common classes are copied from `boot-autoconfigure` to `boot-webflux-autoconfigure/gen-src` before building the module.\r\n- Add `boot-webflux-starter`.\r\n- Add ArmeriaClientHttpConnector which is used when creating WebClient.\r\n- Add a document how to configure Armeria as a web server of a reactive Spring application.\r\n\r\nResult:\r\n- A user can start a reactive Armeria server with spring properties.","created_at":"2018-08-08T08:01:35Z","updated_at":"2018-11-07T06:06:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd1cf4c1f8403dd8dc13d053bbc1b847da9025c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":287373881,"node_id":"MDU6TGFiZWwyODczNzM4ODE=","url":"https://api.github.com/repos/line/armeria/labels/new-feature","name":"new-feature","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/line/armeria/pulls/1326/commits","review_comments_url":"https://api.github.com/repos/line/armeria/pulls/1326/comments","review_comment_url":"https://api.github.com/repos/line/armeria/pulls/comments{/number}","comments_url":"https://api.github.com/repos/line/armeria/issues/1326/comments","statuses_url":"https://api.github.com/repos/line/armeria/statuses/23a1d32b0c8ec40a1e52b1884f697359c366dedc","head":{"label":"hyangtack:feature/spring_web_server","ref":"feature/spring_web_server","sha":"23a1d32b0c8ec40a1e52b1884f697359c366dedc","user":{"login":"hyangtack","id":8417787,"node_id":"MDQ6VXNlcjg0MTc3ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/8417787?v=4","gravatar_id":"","url":"https://api.github.com/users/hyangtack","html_url":"https://github.com/hyangtack","followers_url":"https://api.github.com/users/hyangtack/followers","following_url":"https://api.github.com/users/hyangtack/following{/other_user}","gists_url":"https://api.github.com/users/hyangtack/gists{/gist_id}","starred_url":"https://api.github.com/users/hyangtack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyangtack/subscriptions","organizations_url":"https://api.github.com/users/hyangtack/orgs","repos_url":"https://api.github.com/users/hyangtack/repos","events_url":"https://api.github.com/users/hyangtack/events{/privacy}","received_events_url":"https://api.github.com/users/hyangtack/received_events","type":"User","site_admin":false},"repo":{"id":48430251,"node_id":"MDEwOlJlcG9zaXRvcnk0ODQzMDI1MQ==","name":"armeria","full_name":"hyangtack/armeria","private":false,"owner":{"login":"hyangtack","id":8417787,"node_id":"MDQ6VXNlcjg0MTc3ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/8417787?v=4","gravatar_id":"","url":"https://api.github.com/users/hyangtack","html_url":"https://github.com/hyangtack","followers_url":"https://api.github.com/users/hyangtack/followers","following_url":"https://api.github.com/users/hyangtack/following{/other_user}","gists_url":"https://api.github.com/users/hyangtack/gists{/gist_id}","starred_url":"https://api.github.com/users/hyangtack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyangtack/subscriptions","organizations_url":"https://api.github.com/users/hyangtack/orgs","repos_url":"https://api.github.com/users/hyangtack/repos","events_url":"https://api.github.com/users/hyangtack/events{/privacy}","received_events_url":"https://api.github.com/users/hyangtack/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hyangtack/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":true,"url":"https://api.github.com/repos/hyangtack/armeria","forks_url":"https://api.github.com/repos/hyangtack/armeria/forks","keys_url":"https://api.github.com/repos/hyangtack/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyangtack/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyangtack/armeria/teams","hooks_url":"https://api.github.com/repos/hyangtack/armeria/hooks","issue_events_url":"https://api.github.com/repos/hyangtack/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/hyangtack/armeria/events","assignees_url":"https://api.github.com/repos/hyangtack/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/hyangtack/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/hyangtack/armeria/tags","blobs_url":"https://api.github.com/repos/hyangtack/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyangtack/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyangtack/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyangtack/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyangtack/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/hyangtack/armeria/languages","stargazers_url":"https://api.github.com/repos/hyangtack/armeria/stargazers","contributors_url":"https://api.github.com/repos/hyangtack/armeria/contributors","subscribers_url":"https://api.github.com/repos/hyangtack/armeria/subscribers","subscription_url":"https://api.github.com/repos/hyangtack/armeria/subscription","commits_url":"https://api.github.com/repos/hyangtack/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyangtack/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyangtack/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyangtack/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyangtack/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/hyangtack/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyangtack/armeria/merges","archive_url":"https://api.github.com/repos/hyangtack/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyangtack/armeria/downloads","issues_url":"https://api.github.com/repos/hyangtack/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/hyangtack/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/hyangtack/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/hyangtack/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyangtack/armeria/labels{/name}","releases_url":"https://api.github.com/repos/hyangtack/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/hyangtack/armeria/deployments","created_at":"2015-12-22T12:16:46Z","updated_at":"2016-02-18T10:05:21Z","pushed_at":"2018-11-06T09:32:43Z","git_url":"git://github.com/hyangtack/armeria.git","ssh_url":"git@github.com:hyangtack/armeria.git","clone_url":"https://github.com/hyangtack/armeria.git","svn_url":"https://github.com/hyangtack/armeria","homepage":"http://line.github.io/armeria/","size":52912,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"line:master","ref":"master","sha":"a1d77d69797cbc2627ba56e319e84fcb0589d721","user":{"login":"line","id":13128444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI4NDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/13128444?v=4","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"repo":{"id":46251204,"node_id":"MDEwOlJlcG9zaXRvcnk0NjI1MTIwNA==","name":"armeria","full_name":"line/armeria","private":false,"owner":{"login":"line","id":13128444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTI4NDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/13128444?v=4","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/line/armeria","description":"Asynchronous RPC/REST library built on top of Java 8, Netty, HTTP/2, Thrift and gRPC","fork":false,"url":"https://api.github.com/repos/line/armeria","forks_url":"https://api.github.com/repos/line/armeria/forks","keys_url":"https://api.github.com/repos/line/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/line/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/line/armeria/teams","hooks_url":"https://api.github.com/repos/line/armeria/hooks","issue_events_url":"https://api.github.com/repos/line/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/line/armeria/events","assignees_url":"https://api.github.com/repos/line/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/line/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/line/armeria/tags","blobs_url":"https://api.github.com/repos/line/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/line/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/line/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/line/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/line/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/line/armeria/languages","stargazers_url":"https://api.github.com/repos/line/armeria/stargazers","contributors_url":"https://api.github.com/repos/line/armeria/contributors","subscribers_url":"https://api.github.com/repos/line/armeria/subscribers","subscription_url":"https://api.github.com/repos/line/armeria/subscription","commits_url":"https://api.github.com/repos/line/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/line/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/line/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/line/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/line/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/line/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/line/armeria/merges","archive_url":"https://api.github.com/repos/line/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/line/armeria/downloads","issues_url":"https://api.github.com/repos/line/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/line/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/line/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/line/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/line/armeria/labels{/name}","releases_url":"https://api.github.com/repos/line/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/line/armeria/deployments","created_at":"2015-11-16T04:04:01Z","updated_at":"2018-11-07T02:03:58Z","pushed_at":"2018-11-07T01:12:19Z","git_url":"git://github.com/line/armeria.git","ssh_url":"git@github.com:line/armeria.git","clone_url":"https://github.com/line/armeria.git","svn_url":"https://github.com/line/armeria","homepage":"https://line.github.io/armeria/","size":56534,"stargazers_count":1471,"watchers_count":1471,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":317,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":317,"open_issues":114,"watchers":1471,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/1326"},"html":{"href":"https://github.com/line/armeria/pull/1326"},"issue":{"href":"https://api.github.com/repos/line/armeria/issues/1326"},"comments":{"href":"https://api.github.com/repos/line/armeria/issues/1326/comments"},"review_comments":{"href":"https://api.github.com/repos/line/armeria/pulls/1326/comments"},"review_comment":{"href":"https://api.github.com/repos/line/armeria/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/line/armeria/pulls/1326/commits"},"statuses":{"href":"https://api.github.com/repos/line/armeria/statuses/23a1d32b0c8ec40a1e52b1884f697359c366dedc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"trustin"}}