{"action":"created","comment":{"url":"https://api.github.com/repos/adobe/xdm/pulls/comments/185967480","pull_request_review_id":117467788,"id":185967480,"diff_hunk":"@@ -0,0 +1,102 @@\n+{\n+  \"meta:license\": [\n+    \"Copyright 2018 Adobe Systems Incorporated. All rights reserved.\",\n+    \"This work is licensed under a Creative Commons Attribution 4.0 International (CC BY 4.0) license\",\n+    \"you may not use this file except in compliance with the License. You may obtain a copy\",\n+    \"of the License at https://creativecommons.org/licenses/by/4.0/\"\n+  ],\n+  \"$id\": \"https://ns.adobe.com/xdm/context/viewability-details\",\n+  \"$schema\": \"http://json-schema.org/draft-06/schema#\",\n+  \"title\": \"Viewability Details\",\n+  \"type\": \"object\",\n+  \"description\": \"Browser or app settings measured at runtime describing the viewability of an advertisement or content associated with each page load.\",\n+  \"definitions\": {\n+    \"viewabilityDetails\": {\n+      \"properties\": {\n+        \"xdm:adUnitDepth\": {\n+          \"title\": \"Ad Unit Depth\",\n+          \"type\": \"integer\",\n+          \"description\":\n+          \"Publishers may embed ad units inside containers/iFrames in order limit the ad's access solely to the code of the page. This describes how many 'containers' or iFrames the ad unit is displayed inside of.\",\n+          \"minimum\": 0\n+        },\n+        \"xdm:viewportHeight\": {\n+          \"title\": \"Viewport Height\",\n+          \"type\": \"integer\",\n+          \"description\":\n+          \"The number of vertical pixels of the window the ad is displayed in, measured at runtime.\",\n+          \"minimum\": 0\n+\n+        },\n+        \"xdm:viewportWidth\": {\n+          \"title\": \"Viewport Width\",\n+          \"type\": \"integer\",\n+          \"description\":\n+          \"The number of horizontal pixels of the window the ad is displayed in, measured at runtime.\",\n+          \"minimum\": 0\n+        },\n+        \"xdm:adHeight\": {\n+          \"title\": \"Ad Height\",\n+          \"type\": \"integer\",\n+          \"description\":\n+          \"The number of vertical pixels of the player, measured at runtime. This can be larger than the size of the ad if the player has extra controls or thumbnails.\",\n+          \"minimum\": 0\n+        },\n+        \"xdm:adWidth\": {\n+          \"title\": \"Ad Width\",\n+          \"type\": \"integer\",\n+          \"description\":\n+          \"The number of horizontal pixels of the player, measured at runtime. This can be larger than the size of the ad if the player has extra controls or thumbnails.\",","path":"schemas/context/viewability-details.schema.json","position":null,"original_position":49,"commit_id":"f71a6ebe059ccbde606bb5e0ed0ef93d883bea59","original_commit_id":"ad406f3753f2bdf5787ed10520cdcc849a1064ae","user":{"login":"lrosenthol","id":5074741,"avatar_url":"https://avatars2.githubusercontent.com/u/5074741?v=4","gravatar_id":"","url":"https://api.github.com/users/lrosenthol","html_url":"https://github.com/lrosenthol","followers_url":"https://api.github.com/users/lrosenthol/followers","following_url":"https://api.github.com/users/lrosenthol/following{/other_user}","gists_url":"https://api.github.com/users/lrosenthol/gists{/gist_id}","starred_url":"https://api.github.com/users/lrosenthol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrosenthol/subscriptions","organizations_url":"https://api.github.com/users/lrosenthol/orgs","repos_url":"https://api.github.com/users/lrosenthol/repos","events_url":"https://api.github.com/users/lrosenthol/events{/privacy}","received_events_url":"https://api.github.com/users/lrosenthol/received_events","type":"User","site_admin":false},"body":"The correct standard is the CSS View module, which identifies the measurement as CSS Pixels (https://www.w3.org/TR/cssom-view-1/#css-pixels).  So let's go ahead and use that correct terminology and then I'm good. Thanks!","created_at":"2018-05-04T00:03:57Z","updated_at":"2018-05-04T00:03:57Z","html_url":"https://github.com/adobe/xdm/pull/281#discussion_r185967480","pull_request_url":"https://api.github.com/repos/adobe/xdm/pulls/281","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/adobe/xdm/pulls/comments/185967480"},"html":{"href":"https://github.com/adobe/xdm/pull/281#discussion_r185967480"},"pull_request":{"href":"https://api.github.com/repos/adobe/xdm/pulls/281"}},"in_reply_to_id":185580907},"pull_request":{"url":"https://api.github.com/repos/adobe/xdm/pulls/281","id":184479652,"html_url":"https://github.com/adobe/xdm/pull/281","diff_url":"https://github.com/adobe/xdm/pull/281.diff","patch_url":"https://github.com/adobe/xdm/pull/281.patch","issue_url":"https://api.github.com/repos/adobe/xdm/issues/281","number":281,"state":"open","locked":false,"title":"Feature 264 - Viewability: Implement viewability schema","user":{"login":"gabebarcelos-adobe","id":38364679,"avatar_url":"https://avatars1.githubusercontent.com/u/38364679?v=4","gravatar_id":"","url":"https://api.github.com/users/gabebarcelos-adobe","html_url":"https://github.com/gabebarcelos-adobe","followers_url":"https://api.github.com/users/gabebarcelos-adobe/followers","following_url":"https://api.github.com/users/gabebarcelos-adobe/following{/other_user}","gists_url":"https://api.github.com/users/gabebarcelos-adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/gabebarcelos-adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabebarcelos-adobe/subscriptions","organizations_url":"https://api.github.com/users/gabebarcelos-adobe/orgs","repos_url":"https://api.github.com/users/gabebarcelos-adobe/repos","events_url":"https://api.github.com/users/gabebarcelos-adobe/events{/privacy}","received_events_url":"https://api.github.com/users/gabebarcelos-adobe/received_events","type":"User","site_admin":false},"body":"PR to add viewability schema to core ExperienceEvent. This is related to open issue #264.\r\n@kstreeter  @cdegroot-adobe ","created_at":"2018-04-26T22:22:12Z","updated_at":"2018-05-04T00:03:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f1fed9f1ce77e33f052c1567c4bf2692b13febc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adobe/xdm/pulls/281/commits","review_comments_url":"https://api.github.com/repos/adobe/xdm/pulls/281/comments","review_comment_url":"https://api.github.com/repos/adobe/xdm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adobe/xdm/issues/281/comments","statuses_url":"https://api.github.com/repos/adobe/xdm/statuses/f71a6ebe059ccbde606bb5e0ed0ef93d883bea59","head":{"label":"gabebarcelos-adobe:feature-264-viewability","ref":"feature-264-viewability","sha":"f71a6ebe059ccbde606bb5e0ed0ef93d883bea59","user":{"login":"gabebarcelos-adobe","id":38364679,"avatar_url":"https://avatars1.githubusercontent.com/u/38364679?v=4","gravatar_id":"","url":"https://api.github.com/users/gabebarcelos-adobe","html_url":"https://github.com/gabebarcelos-adobe","followers_url":"https://api.github.com/users/gabebarcelos-adobe/followers","following_url":"https://api.github.com/users/gabebarcelos-adobe/following{/other_user}","gists_url":"https://api.github.com/users/gabebarcelos-adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/gabebarcelos-adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabebarcelos-adobe/subscriptions","organizations_url":"https://api.github.com/users/gabebarcelos-adobe/orgs","repos_url":"https://api.github.com/users/gabebarcelos-adobe/repos","events_url":"https://api.github.com/users/gabebarcelos-adobe/events{/privacy}","received_events_url":"https://api.github.com/users/gabebarcelos-adobe/received_events","type":"User","site_admin":false},"repo":{"id":129456599,"name":"xdm","full_name":"gabebarcelos-adobe/xdm","owner":{"login":"gabebarcelos-adobe","id":38364679,"avatar_url":"https://avatars1.githubusercontent.com/u/38364679?v=4","gravatar_id":"","url":"https://api.github.com/users/gabebarcelos-adobe","html_url":"https://github.com/gabebarcelos-adobe","followers_url":"https://api.github.com/users/gabebarcelos-adobe/followers","following_url":"https://api.github.com/users/gabebarcelos-adobe/following{/other_user}","gists_url":"https://api.github.com/users/gabebarcelos-adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/gabebarcelos-adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabebarcelos-adobe/subscriptions","organizations_url":"https://api.github.com/users/gabebarcelos-adobe/orgs","repos_url":"https://api.github.com/users/gabebarcelos-adobe/repos","events_url":"https://api.github.com/users/gabebarcelos-adobe/events{/privacy}","received_events_url":"https://api.github.com/users/gabebarcelos-adobe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabebarcelos-adobe/xdm","description":"Experience Data Model","fork":true,"url":"https://api.github.com/repos/gabebarcelos-adobe/xdm","forks_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/forks","keys_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/teams","hooks_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/hooks","issue_events_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/issues/events{/number}","events_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/events","assignees_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/assignees{/user}","branches_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/branches{/branch}","tags_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/tags","blobs_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/statuses/{sha}","languages_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/languages","stargazers_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/stargazers","contributors_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/contributors","subscribers_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/subscribers","subscription_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/subscription","commits_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/contents/{+path}","compare_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/merges","archive_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/downloads","issues_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/issues{/number}","pulls_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/pulls{/number}","milestones_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/milestones{/number}","notifications_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/labels{/name}","releases_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/releases{/id}","deployments_url":"https://api.github.com/repos/gabebarcelos-adobe/xdm/deployments","created_at":"2018-04-13T21:45:42Z","updated_at":"2018-04-26T19:46:38Z","pushed_at":"2018-05-03T22:38:39Z","git_url":"git://github.com/gabebarcelos-adobe/xdm.git","ssh_url":"git@github.com:gabebarcelos-adobe/xdm.git","clone_url":"https://github.com/gabebarcelos-adobe/xdm.git","svn_url":"https://github.com/gabebarcelos-adobe/xdm","homepage":"","size":3706,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adobe:master","ref":"master","sha":"5a92cb35a3d6fdf663807f921b14d5c877e74b26","user":{"login":"adobe","id":476009,"avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"repo":{"id":113054321,"name":"xdm","full_name":"adobe/xdm","owner":{"login":"adobe","id":476009,"avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe/xdm","description":"Experience Data Model","fork":false,"url":"https://api.github.com/repos/adobe/xdm","forks_url":"https://api.github.com/repos/adobe/xdm/forks","keys_url":"https://api.github.com/repos/adobe/xdm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe/xdm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe/xdm/teams","hooks_url":"https://api.github.com/repos/adobe/xdm/hooks","issue_events_url":"https://api.github.com/repos/adobe/xdm/issues/events{/number}","events_url":"https://api.github.com/repos/adobe/xdm/events","assignees_url":"https://api.github.com/repos/adobe/xdm/assignees{/user}","branches_url":"https://api.github.com/repos/adobe/xdm/branches{/branch}","tags_url":"https://api.github.com/repos/adobe/xdm/tags","blobs_url":"https://api.github.com/repos/adobe/xdm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe/xdm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe/xdm/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe/xdm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe/xdm/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe/xdm/languages","stargazers_url":"https://api.github.com/repos/adobe/xdm/stargazers","contributors_url":"https://api.github.com/repos/adobe/xdm/contributors","subscribers_url":"https://api.github.com/repos/adobe/xdm/subscribers","subscription_url":"https://api.github.com/repos/adobe/xdm/subscription","commits_url":"https://api.github.com/repos/adobe/xdm/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe/xdm/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe/xdm/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe/xdm/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe/xdm/contents/{+path}","compare_url":"https://api.github.com/repos/adobe/xdm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe/xdm/merges","archive_url":"https://api.github.com/repos/adobe/xdm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe/xdm/downloads","issues_url":"https://api.github.com/repos/adobe/xdm/issues{/number}","pulls_url":"https://api.github.com/repos/adobe/xdm/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe/xdm/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe/xdm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe/xdm/labels{/name}","releases_url":"https://api.github.com/repos/adobe/xdm/releases{/id}","deployments_url":"https://api.github.com/repos/adobe/xdm/deployments","created_at":"2017-12-04T14:40:24Z","updated_at":"2018-05-03T19:01:50Z","pushed_at":"2018-05-03T23:03:33Z","git_url":"git://github.com/adobe/xdm.git","ssh_url":"git@github.com:adobe/xdm.git","clone_url":"https://github.com/adobe/xdm.git","svn_url":"https://github.com/adobe/xdm","homepage":"","size":3776,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0"},"forks":40,"open_issues":80,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adobe/xdm/pulls/281"},"html":{"href":"https://github.com/adobe/xdm/pull/281"},"issue":{"href":"https://api.github.com/repos/adobe/xdm/issues/281"},"comments":{"href":"https://api.github.com/repos/adobe/xdm/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/adobe/xdm/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/adobe/xdm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adobe/xdm/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/adobe/xdm/statuses/f71a6ebe059ccbde606bb5e0ed0ef93d883bea59"}},"author_association":"NONE"}}
{"actor":{"display_login":"lrosenthol"}}