{"action":"created","issue":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/5167","repository_url":"https://api.github.com/repos/xamarin/xamarin-macios","labels_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/5167/labels{/name}","comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/5167/comments","events_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/5167/events","html_url":"https://github.com/xamarin/xamarin-macios/pull/5167","id":383274987,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNzg0OTQw","number":5167,"title":"Add 'NoBindingEmbedding' style binding project support","user":{"login":"chamons","id":6392201,"node_id":"MDQ6VXNlcjYzOTIyMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6392201?v=4","gravatar_id":"","url":"https://api.github.com/users/chamons","html_url":"https://github.com/chamons","followers_url":"https://api.github.com/users/chamons/followers","following_url":"https://api.github.com/users/chamons/following{/other_user}","gists_url":"https://api.github.com/users/chamons/gists{/gist_id}","starred_url":"https://api.github.com/users/chamons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chamons/subscriptions","organizations_url":"https://api.github.com/users/chamons/orgs","repos_url":"https://api.github.com/users/chamons/repos","events_url":"https://api.github.com/users/chamons/events{/privacy}","received_events_url":"https://api.github.com/users/chamons/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":35,"created_at":"2018-11-21T20:05:46Z","updated_at":"2018-12-12T01:14:34Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/5167","html_url":"https://github.com/xamarin/xamarin-macios/pull/5167","diff_url":"https://github.com/xamarin/xamarin-macios/pull/5167.diff","patch_url":"https://github.com/xamarin/xamarin-macios/pull/5167.patch"},"body":"- Existing binding projects embed the native libraries within the assembly as managed resource\r\n- This does not scale well and has performance implications\r\n- This PR creates a new property, `NoBindingEmbedding` which when true processes the building and consumption of binding projects differently.\r\n- Existing binding projects are not affected, they will continue as is\r\n- As this is a large change, with a lot of logic in msbuild, I've broken it into many commits with detailed descriptions, and a few have additional comments.\r\n- I've written a full XM test suite and ported a subset to iOS. Since iOS only supports checked in projects, and I didn't want to make the existing situation worse by adding more, I only wrote tests that could use the existing test projects.\r\n   - When we complete some form of msbuild testing reform, we'll revisit these tests.\r\n- I know not many people are familiar with msbuild, so please feel **super extra** free to ask questions.\r\n\r\n**Reviewers:** Given the large number of changes, please review commit by commit."},"comment":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/comments/446424262","html_url":"https://github.com/xamarin/xamarin-macios/pull/5167#issuecomment-446424262","issue_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/5167","id":446424262,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjQyNDI2Mg==","user":{"login":"monojenkins","id":11610122,"node_id":"MDQ6VXNlcjExNjEwMTIy","avatar_url":"https://avatars0.githubusercontent.com/u/11610122?v=4","gravatar_id":"","url":"https://api.github.com/users/monojenkins","html_url":"https://github.com/monojenkins","followers_url":"https://api.github.com/users/monojenkins/followers","following_url":"https://api.github.com/users/monojenkins/following{/other_user}","gists_url":"https://api.github.com/users/monojenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/monojenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monojenkins/subscriptions","organizations_url":"https://api.github.com/users/monojenkins/orgs","repos_url":"https://api.github.com/users/monojenkins/repos","events_url":"https://api.github.com/users/monojenkins/events{/privacy}","received_events_url":"https://api.github.com/users/monojenkins/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T01:14:34Z","updated_at":"2018-12-12T01:14:34Z","author_association":"COLLABORATOR","body":"Build success\n✅ [Build succeeded](https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/8846//console)\n✅ [API Diff (from stable)](https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/8846//API_20diff_20_28from_20stable_29)\nℹ️ [API Diff (from PR only)](https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/8846//API_20diff_20_28PR_20only_29) (please review changes)\n✅ [Generator Diff](https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/8846//Generator_20Diff) (no change)\n✅ [Test run succeeded](https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/8846//Test_20Report)\n"}}
{"actor":{"display_login":"monojenkins"}}