{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70074","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70074/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70074/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70074/events","html_url":"https://github.com/kubernetes/kubernetes/pull/70074","id":372401242,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTkzOTM1","number":70074,"title":"fix a little bug on validating the nodeleaseDurationSeconds","user":{"login":"Pingan2017","id":29810925,"node_id":"MDQ6VXNlcjI5ODEwOTI1","avatar_url":"https://avatars1.githubusercontent.com/u/29810925?v=4","gravatar_id":"","url":"https://api.github.com/users/Pingan2017","html_url":"https://github.com/Pingan2017","followers_url":"https://api.github.com/users/Pingan2017/followers","following_url":"https://api.github.com/users/Pingan2017/following{/other_user}","gists_url":"https://api.github.com/users/Pingan2017/gists{/gist_id}","starred_url":"https://api.github.com/users/Pingan2017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pingan2017/subscriptions","organizations_url":"https://api.github.com/users/Pingan2017/orgs","repos_url":"https://api.github.com/users/Pingan2017/repos","events_url":"https://api.github.com/users/Pingan2017/events{/privacy}","received_events_url":"https://api.github.com/users/Pingan2017/received_events","type":"User","site_admin":false},"labels":[{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":573014062,"node_id":"MDU6TGFiZWw1NzMwMTQwNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":617149945,"node_id":"MDU6TGFiZWw2MTcxNDk5NDU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-sig","name":"needs-sig","color":"ededed","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450793,"node_id":"MDU6TGFiZWwyNTM0NTA3OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-22T05:52:34Z","updated_at":"2018-10-22T05:52:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70074","html_url":"https://github.com/kubernetes/kubernetes/pull/70074","diff_url":"https://github.com/kubernetes/kubernetes/pull/70074.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/70074.patch"},"body":"**What type of PR is this?**\r\n/kind bug\r\n\r\n**What this PR does / why we need it**:\r\nit is valid to set nodeleaseDurationSeconds=0 . if nodeleaseDurationSeconds=0, it will be change to 40 as default.\r\nhttps://github.com/kubernetes/kubernetes/blob/7cbb9995189c5ecc8182da29cd0e30188c911401/pkg/kubelet/apis/config/v1beta1/defaults.go#L113-L115\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. \r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/431745745","html_url":"https://github.com/kubernetes/kubernetes/pull/70074#issuecomment-431745745","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70074","id":431745745,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTc0NTc0NQ==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-10-22T05:52:54Z","updated_at":"2018-10-22T05:52:54Z","author_association":"CONTRIBUTOR","body":"Hi @Pingan2017. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"k8s-ci-robot"}}