{"action":"created","issue":{"url":"https://api.github.com/repos/topolik/liferay-portal/issues/534","repository_url":"https://api.github.com/repos/topolik/liferay-portal","labels_url":"https://api.github.com/repos/topolik/liferay-portal/issues/534/labels{/name}","comments_url":"https://api.github.com/repos/topolik/liferay-portal/issues/534/comments","events_url":"https://api.github.com/repos/topolik/liferay-portal/issues/534/events","html_url":"https://github.com/topolik/liferay-portal/pull/534","id":329574658,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNzk3Njg2","number":534,"title":"Peer review?","user":{"login":"stian-sigvartsen","id":12467295,"node_id":"MDQ6VXNlcjEyNDY3Mjk1","avatar_url":"https://avatars2.githubusercontent.com/u/12467295?v=4","gravatar_id":"","url":"https://api.github.com/users/stian-sigvartsen","html_url":"https://github.com/stian-sigvartsen","followers_url":"https://api.github.com/users/stian-sigvartsen/followers","following_url":"https://api.github.com/users/stian-sigvartsen/following{/other_user}","gists_url":"https://api.github.com/users/stian-sigvartsen/gists{/gist_id}","starred_url":"https://api.github.com/users/stian-sigvartsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stian-sigvartsen/subscriptions","organizations_url":"https://api.github.com/users/stian-sigvartsen/orgs","repos_url":"https://api.github.com/users/stian-sigvartsen/repos","events_url":"https://api.github.com/users/stian-sigvartsen/events{/privacy}","received_events_url":"https://api.github.com/users/stian-sigvartsen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-05T18:31:06Z","updated_at":"2018-06-05T18:31:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/topolik/liferay-portal/pulls/534","html_url":"https://github.com/topolik/liferay-portal/pull/534","diff_url":"https://github.com/topolik/liferay-portal/pull/534.diff","patch_url":"https://github.com/topolik/liferay-portal/pull/534.patch"},"body":"Please can you peer review c48f7f1 ?\r\n\r\nIt's a fix for \"CAN BE\" not showing checked when rendering \"assign scopes\".\r\n\r\nIt also adds a new \"sticky\" scopeAliases JavaScript feature that remembers which application owned scopeAliases were previously assigned to the app, or the user has explicitly selected since the page was loaded.\r\n\r\nThis means if they subsequently select and then deselect all the related global scopeAliases, then the application owned scopeAlias checkbox remains checked. Should be good UX hopefully.\r\n\r\nThis new feature actually also fixes the \"CAN BE\" bug, which is why I did it really :)\r\n\r\n---\r\n\r\nAdditionally - we have talked previously that if users select a global scope like \"everything.readonly\", which implies \"blogs.read\" for example, then we should also persist the latter. I have added this, also in the same commit.\r\n\r\nNote: this logic is so far only implemented for the \"CAN BE\" scopeAliases. In future we can do it for global scopes too. i.e. \"everything\" implies \"everything.readonly\"\r\n\r\n/cc @csierra"},"comment":{"url":"https://api.github.com/repos/topolik/liferay-portal/issues/comments/394813953","html_url":"https://github.com/topolik/liferay-portal/pull/534#issuecomment-394813953","issue_url":"https://api.github.com/repos/topolik/liferay-portal/issues/534","id":394813953,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDgxMzk1Mw==","user":{"login":"liferay-continuous-integration","id":4502793,"node_id":"MDQ6VXNlcjQ1MDI3OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/4502793?v=4","gravatar_id":"","url":"https://api.github.com/users/liferay-continuous-integration","html_url":"https://github.com/liferay-continuous-integration","followers_url":"https://api.github.com/users/liferay-continuous-integration/followers","following_url":"https://api.github.com/users/liferay-continuous-integration/following{/other_user}","gists_url":"https://api.github.com/users/liferay-continuous-integration/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay-continuous-integration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay-continuous-integration/subscriptions","organizations_url":"https://api.github.com/users/liferay-continuous-integration/orgs","repos_url":"https://api.github.com/users/liferay-continuous-integration/repos","events_url":"https://api.github.com/users/liferay-continuous-integration/events{/privacy}","received_events_url":"https://api.github.com/users/liferay-continuous-integration/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T18:31:09Z","updated_at":"2018-06-05T18:31:09Z","author_association":"COLLABORATOR","body":"To conserve resources, the PR Tester does not automatically run for every pull.\n\nIf your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.\n\nIf your pull was never tested, comment &quot;ci:test&quot; to run the PR Tester for this pull."}}
{"actor":{"display_login":"liferay-continuous-integration"}}