{"action":"created","comment":{"url":"https://api.github.com/repos/aeternity/epoch/pulls/comments/172128999","pull_request_review_id":101092685,"id":172128999,"diff_hunk":"@@ -239,7 +239,7 @@ def send_tokens_to_user(user, test_settings, internal_api, external_api):\n     spend_tx_obj = SpendTx(\n         recipient_pubkey=test_settings[user][\"pubkey\"],\n         amount=test_settings[user][\"amount\"],\n-        fee=test_settings[user][\"amount\"])\n+        fee=test_settings[user][\"fee\"])","path":"py/tests/integration/test_unsigned_tx.py","position":5,"original_position":5,"commit_id":"3f66e5adec60869b9ee93a3bfc96fe602b2d4922","original_commit_id":"3f66e5adec60869b9ee93a3bfc96fe602b2d4922","user":{"login":"lucafavatella","id":1344255,"avatar_url":"https://avatars0.githubusercontent.com/u/1344255?v=4","gravatar_id":"","url":"https://api.github.com/users/lucafavatella","html_url":"https://github.com/lucafavatella","followers_url":"https://api.github.com/users/lucafavatella/followers","following_url":"https://api.github.com/users/lucafavatella/following{/other_user}","gists_url":"https://api.github.com/users/lucafavatella/gists{/gist_id}","starred_url":"https://api.github.com/users/lucafavatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucafavatella/subscriptions","organizations_url":"https://api.github.com/users/lucafavatella/orgs","repos_url":"https://api.github.com/users/lucafavatella/repos","events_url":"https://api.github.com/users/lucafavatella/events{/privacy}","received_events_url":"https://api.github.com/users/lucafavatella/received_events","type":"User","site_admin":false},"body":"Well spotted.","created_at":"2018-03-05T09:30:44Z","updated_at":"2018-03-05T09:30:44Z","html_url":"https://github.com/aeternity/epoch/pull/822#discussion_r172128999","pull_request_url":"https://api.github.com/repos/aeternity/epoch/pulls/822","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/comments/172128999"},"html":{"href":"https://github.com/aeternity/epoch/pull/822#discussion_r172128999"},"pull_request":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/822"}}},"pull_request":{"url":"https://api.github.com/repos/aeternity/epoch/pulls/822","id":172793712,"html_url":"https://github.com/aeternity/epoch/pull/822","diff_url":"https://github.com/aeternity/epoch/pull/822.diff","patch_url":"https://github.com/aeternity/epoch/pull/822.patch","issue_url":"https://api.github.com/repos/aeternity/epoch/issues/822","number":822,"state":"open","locked":false,"title":"Python UAT: Alice sends tokens to bob.aet","user":{"login":"velzevur","id":4035918,"avatar_url":"https://avatars3.githubusercontent.com/u/4035918?v=4","gravatar_id":"","url":"https://api.github.com/users/velzevur","html_url":"https://github.com/velzevur","followers_url":"https://api.github.com/users/velzevur/followers","following_url":"https://api.github.com/users/velzevur/following{/other_user}","gists_url":"https://api.github.com/users/velzevur/gists{/gist_id}","starred_url":"https://api.github.com/users/velzevur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/velzevur/subscriptions","organizations_url":"https://api.github.com/users/velzevur/orgs","repos_url":"https://api.github.com/users/velzevur/repos","events_url":"https://api.github.com/users/velzevur/events{/privacy}","received_events_url":"https://api.github.com/users/velzevur/received_events","type":"User","site_admin":false},"body":"[Pivotal story](https://www.pivotaltracker.com/story/show/154277512)\r\nUAT test to verify that Bob can register a name, using this name Alice can resolve Bob's address and send tokens to that address.\r\n\r\nTest steps:\r\n1. Setup\r\n1.1 Generate pub-priv pair and public address for Alice and Bob\r\n1.2 Node is started, miner mines some blocks and sends tokens to Alice and Bob (so both of them have accounts in the chain and tokens to spend)\r\n2. Bob registers the name `bob.aet`\r\n2.1 Using a `salt` and the name, Bob prepares a `commitement_hash`.\r\n2.2 Bob prepares a `aens_preclaim_tx`, signes it and posts it to the node. Waits a couple of blocks so it is included. Bob has a `name_hash`\r\n2.3 Using the `salt` from 2.1 and the `name_hash` of 2.2, Bob prepares a `aens_claim_tx`, signes it and posts it to the node. Waits a couple of blocks so it is included. Bob now has registered the name but it still doesn't have any address related to it.\r\n2.4 Bob prepares `aens_update_tx` in which he sets his address in the `pointers`, signes it and posts it to the node. Waits a couple of blocks so it is included.\r\n2.5 Bob validates his name is in the nameservice\r\n3. Alice sends to bob.aet\r\n3.1 Alice resolves the name and gets Bob's address from the `pointers` attached to that name\r\n3.2 Alice sends tokens to that address\r\n4. Validation\r\n4.1 Alice's balance is updated\r\n4.1 Bob's balance is updated\r\n","created_at":"2018-03-05T07:40:00Z","updated_at":"2018-03-05T09:30:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16421acc94e9812660af557192243350c54d3f9d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hanssv","id":86615,"avatar_url":"https://avatars2.githubusercontent.com/u/86615?v=4","gravatar_id":"","url":"https://api.github.com/users/hanssv","html_url":"https://github.com/hanssv","followers_url":"https://api.github.com/users/hanssv/followers","following_url":"https://api.github.com/users/hanssv/following{/other_user}","gists_url":"https://api.github.com/users/hanssv/gists{/gist_id}","starred_url":"https://api.github.com/users/hanssv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanssv/subscriptions","organizations_url":"https://api.github.com/users/hanssv/orgs","repos_url":"https://api.github.com/users/hanssv/repos","events_url":"https://api.github.com/users/hanssv/events{/privacy}","received_events_url":"https://api.github.com/users/hanssv/received_events","type":"User","site_admin":false},{"login":"sennui","id":16958765,"avatar_url":"https://avatars3.githubusercontent.com/u/16958765?v=4","gravatar_id":"","url":"https://api.github.com/users/sennui","html_url":"https://github.com/sennui","followers_url":"https://api.github.com/users/sennui/followers","following_url":"https://api.github.com/users/sennui/following{/other_user}","gists_url":"https://api.github.com/users/sennui/gists{/gist_id}","starred_url":"https://api.github.com/users/sennui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sennui/subscriptions","organizations_url":"https://api.github.com/users/sennui/orgs","repos_url":"https://api.github.com/users/sennui/repos","events_url":"https://api.github.com/users/sennui/events{/privacy}","received_events_url":"https://api.github.com/users/sennui/received_events","type":"User","site_admin":false},{"login":"zp-sd","id":28924437,"avatar_url":"https://avatars1.githubusercontent.com/u/28924437?v=4","gravatar_id":"","url":"https://api.github.com/users/zp-sd","html_url":"https://github.com/zp-sd","followers_url":"https://api.github.com/users/zp-sd/followers","following_url":"https://api.github.com/users/zp-sd/following{/other_user}","gists_url":"https://api.github.com/users/zp-sd/gists{/gist_id}","starred_url":"https://api.github.com/users/zp-sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zp-sd/subscriptions","organizations_url":"https://api.github.com/users/zp-sd/orgs","repos_url":"https://api.github.com/users/zp-sd/repos","events_url":"https://api.github.com/users/zp-sd/events{/privacy}","received_events_url":"https://api.github.com/users/zp-sd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aeternity/epoch/pulls/822/commits","review_comments_url":"https://api.github.com/repos/aeternity/epoch/pulls/822/comments","review_comment_url":"https://api.github.com/repos/aeternity/epoch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aeternity/epoch/issues/822/comments","statuses_url":"https://api.github.com/repos/aeternity/epoch/statuses/3f66e5adec60869b9ee93a3bfc96fe602b2d4922","head":{"label":"aeternity:PT-154277512_UAT_nameservice_spend","ref":"PT-154277512_UAT_nameservice_spend","sha":"3f66e5adec60869b9ee93a3bfc96fe602b2d4922","user":{"login":"aeternity","id":21989234,"avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":99802036,"name":"epoch","full_name":"aeternity/epoch","owner":{"login":"aeternity","id":21989234,"avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aeternity/epoch","description":"æternity testnet: solving scalability problems by making sense of state-channels ","fork":false,"url":"https://api.github.com/repos/aeternity/epoch","forks_url":"https://api.github.com/repos/aeternity/epoch/forks","keys_url":"https://api.github.com/repos/aeternity/epoch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/epoch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/epoch/teams","hooks_url":"https://api.github.com/repos/aeternity/epoch/hooks","issue_events_url":"https://api.github.com/repos/aeternity/epoch/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/epoch/events","assignees_url":"https://api.github.com/repos/aeternity/epoch/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/epoch/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/epoch/tags","blobs_url":"https://api.github.com/repos/aeternity/epoch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/epoch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/epoch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/epoch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/epoch/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/epoch/languages","stargazers_url":"https://api.github.com/repos/aeternity/epoch/stargazers","contributors_url":"https://api.github.com/repos/aeternity/epoch/contributors","subscribers_url":"https://api.github.com/repos/aeternity/epoch/subscribers","subscription_url":"https://api.github.com/repos/aeternity/epoch/subscription","commits_url":"https://api.github.com/repos/aeternity/epoch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/epoch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/epoch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/epoch/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/epoch/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/epoch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/epoch/merges","archive_url":"https://api.github.com/repos/aeternity/epoch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/epoch/downloads","issues_url":"https://api.github.com/repos/aeternity/epoch/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/epoch/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/epoch/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/epoch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/epoch/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/epoch/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/epoch/deployments","created_at":"2017-08-09T11:44:30Z","updated_at":"2018-03-05T03:22:09Z","pushed_at":"2018-03-05T09:24:32Z","git_url":"git://github.com/aeternity/epoch.git","ssh_url":"git@github.com:aeternity/epoch.git","clone_url":"https://github.com/aeternity/epoch.git","svn_url":"https://github.com/aeternity/epoch","homepage":"http://www.aeternity.com","size":4939,"stargazers_count":348,"watchers_count":348,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":54,"open_issues":10,"watchers":348,"default_branch":"master"}},"base":{"label":"aeternity:master","ref":"master","sha":"b3dd4c0b4ea6ed73d8096f7782cbe6f7d886a545","user":{"login":"aeternity","id":21989234,"avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":99802036,"name":"epoch","full_name":"aeternity/epoch","owner":{"login":"aeternity","id":21989234,"avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aeternity/epoch","description":"æternity testnet: solving scalability problems by making sense of state-channels ","fork":false,"url":"https://api.github.com/repos/aeternity/epoch","forks_url":"https://api.github.com/repos/aeternity/epoch/forks","keys_url":"https://api.github.com/repos/aeternity/epoch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/epoch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/epoch/teams","hooks_url":"https://api.github.com/repos/aeternity/epoch/hooks","issue_events_url":"https://api.github.com/repos/aeternity/epoch/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/epoch/events","assignees_url":"https://api.github.com/repos/aeternity/epoch/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/epoch/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/epoch/tags","blobs_url":"https://api.github.com/repos/aeternity/epoch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/epoch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/epoch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/epoch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/epoch/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/epoch/languages","stargazers_url":"https://api.github.com/repos/aeternity/epoch/stargazers","contributors_url":"https://api.github.com/repos/aeternity/epoch/contributors","subscribers_url":"https://api.github.com/repos/aeternity/epoch/subscribers","subscription_url":"https://api.github.com/repos/aeternity/epoch/subscription","commits_url":"https://api.github.com/repos/aeternity/epoch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/epoch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/epoch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/epoch/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/epoch/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/epoch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/epoch/merges","archive_url":"https://api.github.com/repos/aeternity/epoch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/epoch/downloads","issues_url":"https://api.github.com/repos/aeternity/epoch/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/epoch/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/epoch/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/epoch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/epoch/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/epoch/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/epoch/deployments","created_at":"2017-08-09T11:44:30Z","updated_at":"2018-03-05T03:22:09Z","pushed_at":"2018-03-05T09:24:32Z","git_url":"git://github.com/aeternity/epoch.git","ssh_url":"git@github.com:aeternity/epoch.git","clone_url":"https://github.com/aeternity/epoch.git","svn_url":"https://github.com/aeternity/epoch","homepage":"http://www.aeternity.com","size":4939,"stargazers_count":348,"watchers_count":348,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":54,"open_issues":10,"watchers":348,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/822"},"html":{"href":"https://github.com/aeternity/epoch/pull/822"},"issue":{"href":"https://api.github.com/repos/aeternity/epoch/issues/822"},"comments":{"href":"https://api.github.com/repos/aeternity/epoch/issues/822/comments"},"review_comments":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/822/comments"},"review_comment":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/822/commits"},"statuses":{"href":"https://api.github.com/repos/aeternity/epoch/statuses/3f66e5adec60869b9ee93a3bfc96fe602b2d4922"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lucafavatella"}}