{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments/165724844","pull_request_review_id":93715096,"id":165724844,"diff_hunk":"@@ -0,0 +1,10 @@\n+load(\"//bazel:api_build_system.bzl\", \"api_proto_library\")\n+\n+licenses([\"notice\"])  # Apache 2\n+\n+api_proto_library(\n+    name = \"mongo_proxy\",\n+    srcs = [\"mongo_proxy.proto\"],\n+    visibility = [\"//envoy:friends\"],","path":"envoy/config/filter/network/mongo_proxy/v2/BUILD","position":null,"original_position":8,"commit_id":"434bbd171d88b2d7b98cc080fa03423a962a65e3","original_commit_id":"25725416e6ebe2e691fe79f59266e215bbcf584c","user":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"body":"I changed it just `//docs` in the last update.","created_at":"2018-02-02T18:40:13Z","updated_at":"2018-02-02T18:40:13Z","html_url":"https://github.com/envoyproxy/data-plane-api/pull/452#discussion_r165724844","pull_request_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/452","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments/165724844"},"html":{"href":"https://github.com/envoyproxy/data-plane-api/pull/452#discussion_r165724844"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/452"}},"in_reply_to_id":165558807},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/452","id":166350395,"html_url":"https://github.com/envoyproxy/data-plane-api/pull/452","diff_url":"https://github.com/envoyproxy/data-plane-api/pull/452.diff","patch_url":"https://github.com/envoyproxy/data-plane-api/pull/452.patch","issue_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/452","number":452,"state":"open","locked":false,"title":"Move envoy.api.v2 core protos to envoy.api.v2.core and organize filters","user":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"body":"There are several main changes in this PR:\r\n1. Create `envoy.api.v2.core` packages to break circular dependencies from xDS on to subpackages on to base protos.\r\n2. Create individual packages for each filter and add independent versioning to each filter.\r\n3. Add visibility constraints to prevent formation of dependency cycles.\r\n4. Add `gogoproto` annotations to improve go code generation.\r\n\r\nAfter moving xDS service definitions and top-level resource protos back to envoy.core.api.v2, cycles were created, since the second-level definitions depend on base protobuf definitions, and are in turn included from xDS; however xDS and base definitions are in the same package.\r\n\r\nThe solution is to split the base protos into another package, `envoy.api.v2.core`. That eliminates dependency cycles (validated using go-control-plane).\r\n\r\nAdded a few gogoproto annotations to improve golang code generation.","created_at":"2018-01-31T19:13:31Z","updated_at":"2018-02-02T18:40:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"987af6cd370b7733f2b6125ab62bc30f668627eb","assignee":{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"assignees":[{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/452/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/452/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/452/comments","statuses_url":"https://api.github.com/repos/envoyproxy/data-plane-api/statuses/434bbd171d88b2d7b98cc080fa03423a962a65e3","head":{"label":"kyessenov:control_plane","ref":"control_plane","sha":"434bbd171d88b2d7b98cc080fa03423a962a65e3","user":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"repo":{"id":90907816,"name":"envoy-api","full_name":"kyessenov/envoy-api","owner":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyessenov/envoy-api","description":"Envoy REST/proto API definitions","fork":true,"url":"https://api.github.com/repos/kyessenov/envoy-api","forks_url":"https://api.github.com/repos/kyessenov/envoy-api/forks","keys_url":"https://api.github.com/repos/kyessenov/envoy-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyessenov/envoy-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyessenov/envoy-api/teams","hooks_url":"https://api.github.com/repos/kyessenov/envoy-api/hooks","issue_events_url":"https://api.github.com/repos/kyessenov/envoy-api/issues/events{/number}","events_url":"https://api.github.com/repos/kyessenov/envoy-api/events","assignees_url":"https://api.github.com/repos/kyessenov/envoy-api/assignees{/user}","branches_url":"https://api.github.com/repos/kyessenov/envoy-api/branches{/branch}","tags_url":"https://api.github.com/repos/kyessenov/envoy-api/tags","blobs_url":"https://api.github.com/repos/kyessenov/envoy-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyessenov/envoy-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyessenov/envoy-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyessenov/envoy-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyessenov/envoy-api/statuses/{sha}","languages_url":"https://api.github.com/repos/kyessenov/envoy-api/languages","stargazers_url":"https://api.github.com/repos/kyessenov/envoy-api/stargazers","contributors_url":"https://api.github.com/repos/kyessenov/envoy-api/contributors","subscribers_url":"https://api.github.com/repos/kyessenov/envoy-api/subscribers","subscription_url":"https://api.github.com/repos/kyessenov/envoy-api/subscription","commits_url":"https://api.github.com/repos/kyessenov/envoy-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyessenov/envoy-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyessenov/envoy-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyessenov/envoy-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyessenov/envoy-api/contents/{+path}","compare_url":"https://api.github.com/repos/kyessenov/envoy-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyessenov/envoy-api/merges","archive_url":"https://api.github.com/repos/kyessenov/envoy-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyessenov/envoy-api/downloads","issues_url":"https://api.github.com/repos/kyessenov/envoy-api/issues{/number}","pulls_url":"https://api.github.com/repos/kyessenov/envoy-api/pulls{/number}","milestones_url":"https://api.github.com/repos/kyessenov/envoy-api/milestones{/number}","notifications_url":"https://api.github.com/repos/kyessenov/envoy-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyessenov/envoy-api/labels{/name}","releases_url":"https://api.github.com/repos/kyessenov/envoy-api/releases{/id}","deployments_url":"https://api.github.com/repos/kyessenov/envoy-api/deployments","created_at":"2017-05-10T20:58:41Z","updated_at":"2017-10-23T23:39:14Z","pushed_at":"2018-02-02T18:38:16Z","git_url":"git://github.com/kyessenov/envoy-api.git","ssh_url":"git@github.com:kyessenov/envoy-api.git","clone_url":"https://github.com/kyessenov/envoy-api.git","svn_url":"https://github.com/kyessenov/envoy-api","homepage":null,"size":1199,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"a07a36853e698d5fee7b011d7abd1dcb87eda45e","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":90675549,"name":"data-plane-api","full_name":"envoyproxy/data-plane-api","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/data-plane-api","description":"Envoy REST/proto API definitions","fork":false,"url":"https://api.github.com/repos/envoyproxy/data-plane-api","forks_url":"https://api.github.com/repos/envoyproxy/data-plane-api/forks","keys_url":"https://api.github.com/repos/envoyproxy/data-plane-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/data-plane-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/data-plane-api/teams","hooks_url":"https://api.github.com/repos/envoyproxy/data-plane-api/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/data-plane-api/events","assignees_url":"https://api.github.com/repos/envoyproxy/data-plane-api/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/data-plane-api/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/data-plane-api/tags","blobs_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/data-plane-api/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/data-plane-api/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/data-plane-api/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/data-plane-api/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/data-plane-api/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/data-plane-api/subscription","commits_url":"https://api.github.com/repos/envoyproxy/data-plane-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/data-plane-api/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/data-plane-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/data-plane-api/merges","archive_url":"https://api.github.com/repos/envoyproxy/data-plane-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/data-plane-api/downloads","issues_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/data-plane-api/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/data-plane-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/data-plane-api/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/data-plane-api/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/deployments","created_at":"2017-05-08T21:50:29Z","updated_at":"2018-02-01T04:37:40Z","pushed_at":"2018-02-02T18:38:17Z","git_url":"git://github.com/envoyproxy/data-plane-api.git","ssh_url":"git@github.com:envoyproxy/data-plane-api.git","clone_url":"https://github.com/envoyproxy/data-plane-api.git","svn_url":"https://github.com/envoyproxy/data-plane-api","homepage":null,"size":1092,"stargazers_count":77,"watchers_count":77,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":81,"open_issues":18,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/452"},"html":{"href":"https://github.com/envoyproxy/data-plane-api/pull/452"},"issue":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/452"},"comments":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/452/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/452/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/452/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/statuses/434bbd171d88b2d7b98cc080fa03423a962a65e3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kyessenov"}}