{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/21808","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/21808/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/21808/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/21808/events","html_url":"https://github.com/mantidproject/mantid/pull/21808","id":299078923,"number":21808,"title":"Improve workspace names for time sliced data","user":{"login":"gemmaguest","id":12895056,"avatar_url":"https://avatars2.githubusercontent.com/u/12895056?v=4","gravatar_id":"","url":"https://api.github.com/users/gemmaguest","html_url":"https://github.com/gemmaguest","followers_url":"https://api.github.com/users/gemmaguest/followers","following_url":"https://api.github.com/users/gemmaguest/following{/other_user}","gists_url":"https://api.github.com/users/gemmaguest/gists{/gist_id}","starred_url":"https://api.github.com/users/gemmaguest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemmaguest/subscriptions","organizations_url":"https://api.github.com/users/gemmaguest/orgs","repos_url":"https://api.github.com/users/gemmaguest/repos","events_url":"https://api.github.com/users/gemmaguest/events{/privacy}","received_events_url":"https://api.github.com/users/gemmaguest/received_events","type":"User","site_admin":false},"labels":[{"id":172782247,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20GUI","name":"Component: GUI","color":"009800","default":false},{"id":40342862,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Reflectometry","name":"Component: Reflectometry","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"edwardb96","id":8405233,"avatar_url":"https://avatars3.githubusercontent.com/u/8405233?v=4","gravatar_id":"","url":"https://api.github.com/users/edwardb96","html_url":"https://github.com/edwardb96","followers_url":"https://api.github.com/users/edwardb96/followers","following_url":"https://api.github.com/users/edwardb96/following{/other_user}","gists_url":"https://api.github.com/users/edwardb96/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardb96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardb96/subscriptions","organizations_url":"https://api.github.com/users/edwardb96/orgs","repos_url":"https://api.github.com/users/edwardb96/repos","events_url":"https://api.github.com/users/edwardb96/events{/privacy}","received_events_url":"https://api.github.com/users/edwardb96/received_events","type":"User","site_admin":false},"assignees":[{"login":"edwardb96","id":8405233,"avatar_url":"https://avatars3.githubusercontent.com/u/8405233?v=4","gravatar_id":"","url":"https://api.github.com/users/edwardb96","html_url":"https://github.com/edwardb96","followers_url":"https://api.github.com/users/edwardb96/followers","following_url":"https://api.github.com/users/edwardb96/following{/other_user}","gists_url":"https://api.github.com/users/edwardb96/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardb96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardb96/subscriptions","organizations_url":"https://api.github.com/users/edwardb96/orgs","repos_url":"https://api.github.com/users/edwardb96/repos","events_url":"https://api.github.com/users/edwardb96/events{/privacy}","received_events_url":"https://api.github.com/users/edwardb96/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/65","html_url":"https://github.com/mantidproject/mantid/milestone/65","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/65/labels","id":2590252,"number":65,"title":"Release 3.12","description":"Code Freeze:  23rd Feb\r\nBeta Test: 28th Feb - 14th March","creator":{"login":"NickDraper","id":1017173,"avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":44,"closed_issues":948,"state":"open","created_at":"2017-06-19T08:22:22Z","updated_at":"2018-03-06T10:39:58Z","due_on":"2018-03-19T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-02-21T18:29:14Z","updated_at":"2018-03-06T11:27:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/21808","html_url":"https://github.com/mantidproject/mantid/pull/21808","diff_url":"https://github.com/mantidproject/mantid/pull/21808.diff","patch_url":"https://github.com/mantidproject/mantid/pull/21808.patch"},"body":"Improve output workspace names for time sliced data to include the time period rather than just a slice index.\r\n\r\n**To test:**\r\n\r\n- Open the ISIS Reflectometry GUI\r\n- Enter two rows in the same group with run number 13460 and 13462. Set instrument to INTER.\r\n- On the Event tab, select the second radio button and set the time slice to 500 secs\r\n- On the runs tab, process the group.\r\n- You should get 3 slices for run 13460 and 5 for 13462.\r\n- Check that there are stitched workspaces for the first 3 slices.\r\n- Check that you can plot all rows for the group from the GUI. It should plot all 3 for the first run and all 5 for the second.\r\n- Check that you can plot the group. It should plot the 3 stitched workspaces.\r\n\r\nRefs #21004 (partial fix)\r\n\r\n**Release Notes** \r\n*Added to the release notes*\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [ ] Are the unit tests small and test the class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] Do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/370751202","html_url":"https://github.com/mantidproject/mantid/pull/21808#issuecomment-370751202","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/21808","id":370751202,"user":{"login":"gemmaguest","id":12895056,"avatar_url":"https://avatars2.githubusercontent.com/u/12895056?v=4","gravatar_id":"","url":"https://api.github.com/users/gemmaguest","html_url":"https://github.com/gemmaguest","followers_url":"https://api.github.com/users/gemmaguest/followers","following_url":"https://api.github.com/users/gemmaguest/following{/other_user}","gists_url":"https://api.github.com/users/gemmaguest/gists{/gist_id}","starred_url":"https://api.github.com/users/gemmaguest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemmaguest/subscriptions","organizations_url":"https://api.github.com/users/gemmaguest/orgs","repos_url":"https://api.github.com/users/gemmaguest/repos","events_url":"https://api.github.com/users/gemmaguest/events{/privacy}","received_events_url":"https://api.github.com/users/gemmaguest/received_events","type":"User","site_admin":false},"created_at":"2018-03-06T11:27:00Z","updated_at":"2018-03-06T11:27:00Z","author_association":"CONTRIBUTOR","body":"@edwardb96 Some better runs to test with (that give sensible plots) are `46088` and `46089`. You'll need the new INTER IDF though. With 500 sec slices you get 2 slices for the first run and 5 for the second."}}
{"actor":{"display_login":"gemmaguest"}}