{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/23075","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/23075/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/23075/comments","events_url":"https://api.github.com/repos/apache/spark/issues/23075/events","html_url":"https://github.com/apache/spark/pull/23075","id":381919159,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzYyODA3","number":23075,"title":"[SPARK-26084][SQL] Fixes unresolved AggregateExpression.references exception","user":{"login":"ssimeonov","id":491953,"node_id":"MDQ6VXNlcjQ5MTk1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/491953?v=4","gravatar_id":"","url":"https://api.github.com/users/ssimeonov","html_url":"https://github.com/ssimeonov","followers_url":"https://api.github.com/users/ssimeonov/followers","following_url":"https://api.github.com/users/ssimeonov/following{/other_user}","gists_url":"https://api.github.com/users/ssimeonov/gists{/gist_id}","starred_url":"https://api.github.com/users/ssimeonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssimeonov/subscriptions","organizations_url":"https://api.github.com/users/ssimeonov/orgs","repos_url":"https://api.github.com/users/ssimeonov/repos","events_url":"https://api.github.com/users/ssimeonov/events{/privacy}","received_events_url":"https://api.github.com/users/ssimeonov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-18T01:43:50Z","updated_at":"2018-11-18T12:13:15Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/23075","html_url":"https://github.com/apache/spark/pull/23075","diff_url":"https://github.com/apache/spark/pull/23075.diff","patch_url":"https://github.com/apache/spark/pull/23075.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nThis PR fixes an exception in `AggregateExpression.references` called on unresolved expressions. It implements the solution proposed in [SPARK-26084](https://issues.apache.org/jira/browse/SPARK-26084), a minor refactoring that removes the unnecessary dependence on `AttributeSet.toSeq`, which requires expression IDs and, therefore, can only execute successfully for resolved expressions.\r\n\r\nThe refactored implementation is both simpler and faster, eliminating the conversion of a `Set` to a\r\n`Seq` and back to `Set`.\r\n\r\n## How was this patch tested?\r\n\r\nLocal tests pass. I added no new tests as (a) the new behavior has no failing case and (b) this is a simple refactoring.\r\n\r\n@hvanhovell \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/439688313","html_url":"https://github.com/apache/spark/pull/23075#issuecomment-439688313","issue_url":"https://api.github.com/repos/apache/spark/issues/23075","id":439688313,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTY4ODMxMw==","user":{"login":"MaxGekk","id":1580697,"node_id":"MDQ6VXNlcjE1ODA2OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1580697?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxGekk","html_url":"https://github.com/MaxGekk","followers_url":"https://api.github.com/users/MaxGekk/followers","following_url":"https://api.github.com/users/MaxGekk/following{/other_user}","gists_url":"https://api.github.com/users/MaxGekk/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxGekk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxGekk/subscriptions","organizations_url":"https://api.github.com/users/MaxGekk/orgs","repos_url":"https://api.github.com/users/MaxGekk/repos","events_url":"https://api.github.com/users/MaxGekk/events{/privacy}","received_events_url":"https://api.github.com/users/MaxGekk/received_events","type":"User","site_admin":false},"created_at":"2018-11-18T12:13:15Z","updated_at":"2018-11-18T12:13:15Z","author_association":"CONTRIBUTOR","body":"Would you mind to add a test for case which you described in JIRA ticket?"}}
{"actor":{"display_login":"MaxGekk"}}