{"action":"created","issue":{"url":"https://api.github.com/repos/OData/odata.net/issues/1242","repository_url":"https://api.github.com/repos/OData/odata.net","labels_url":"https://api.github.com/repos/OData/odata.net/issues/1242/labels{/name}","comments_url":"https://api.github.com/repos/OData/odata.net/issues/1242/comments","events_url":"https://api.github.com/repos/OData/odata.net/issues/1242/events","html_url":"https://github.com/OData/odata.net/pull/1242","id":355796195,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMjQzMjky","number":1242,"title":"Fix issue #1181, refactor for the json string escaping in JsonValueUt…","user":{"login":"xuzhg","id":9426627,"node_id":"MDQ6VXNlcjk0MjY2Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/9426627?v=4","gravatar_id":"","url":"https://api.github.com/users/xuzhg","html_url":"https://github.com/xuzhg","followers_url":"https://api.github.com/users/xuzhg/followers","following_url":"https://api.github.com/users/xuzhg/following{/other_user}","gists_url":"https://api.github.com/users/xuzhg/gists{/gist_id}","starred_url":"https://api.github.com/users/xuzhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuzhg/subscriptions","organizations_url":"https://api.github.com/users/xuzhg/orgs","repos_url":"https://api.github.com/users/xuzhg/repos","events_url":"https://api.github.com/users/xuzhg/events{/privacy}","received_events_url":"https://api.github.com/users/xuzhg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-08-31T00:08:35Z","updated_at":"2018-09-05T08:40:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/OData/odata.net/pulls/1242","html_url":"https://github.com/OData/odata.net/pull/1242","diff_url":"https://github.com/OData/odata.net/pull/1242.diff","patch_url":"https://github.com/OData/odata.net/pull/1242.patch"},"body":"…ils class\r\n\r\n<!-- markdownlint-disable MD002 MD041 -->\r\n\r\n### Issues\r\n\r\n*This pull request fixes issue #1181.*\r\n\r\n### Description\r\n\r\n\r\nAdd configuration option for the ODataMessageWriterSetting using the new added `ODataStringEscapeOption`, internally, the JsonValueUtils will use the escape setting to write the string value.\r\n\r\nBy default, we use \"EscapeNonAscii\" option to make sure without breaking change for the default behavior. \r\n\r\n### Checklist (Uncheck if it is not completed)\r\n\r\n- [x] *Test cases added*\r\n- [x] *Build and test with one-click build and test script passed*\r\n\r\n### Additional work necessary\r\n\r\n*If documentation update is needed, please add \"Docs Needed\" label to the issue and provide details about the required document change in the issue.*\r\n"},"comment":{"url":"https://api.github.com/repos/OData/odata.net/issues/comments/418648552","html_url":"https://github.com/OData/odata.net/pull/1242#issuecomment-418648552","issue_url":"https://api.github.com/repos/OData/odata.net/issues/1242","id":418648552,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODY0ODU1Mg==","user":{"login":"igor-moskvitin","id":11612097,"node_id":"MDQ6VXNlcjExNjEyMDk3","avatar_url":"https://avatars2.githubusercontent.com/u/11612097?v=4","gravatar_id":"","url":"https://api.github.com/users/igor-moskvitin","html_url":"https://github.com/igor-moskvitin","followers_url":"https://api.github.com/users/igor-moskvitin/followers","following_url":"https://api.github.com/users/igor-moskvitin/following{/other_user}","gists_url":"https://api.github.com/users/igor-moskvitin/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-moskvitin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-moskvitin/subscriptions","organizations_url":"https://api.github.com/users/igor-moskvitin/orgs","repos_url":"https://api.github.com/users/igor-moskvitin/repos","events_url":"https://api.github.com/users/igor-moskvitin/events{/privacy}","received_events_url":"https://api.github.com/users/igor-moskvitin/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T08:40:20Z","updated_at":"2018-09-05T08:40:20Z","author_association":"NONE","body":"@biaol-odata [rfc 7159](https://tools.ietf.org/html/rfc7159#page-8) specify that `..Any character MAY BE escaped..` but not `should be escaped`. \r\n[ecma-international](http://www.ecma-international.org/publications/files/ECMA-ST/ECMA-404.pdf) points the same. Even a picture, that you posted says - `any`, but not `all`.\r\nI think that if [Json.NET](https://www.newtonsoft.com) provide options for configuring this behaviour, OData can provide the same. Otherwise we had some extra traffic when its no needed."}}
{"actor":{"display_login":"igor-moskvitin"}}