{"action":"created","comment":{"url":"https://api.github.com/repos/erickinnear/base-drafts/pulls/comments/209790911","pull_request_review_id":145873670,"id":209790911,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTc5MDkxMQ==","diff_hunk":"@@ -3192,6 +3234,48 @@ zero-length Destination Connection ID MUST treat receipt of a NEW_CONNECTION_ID\n frame as a connection error of type PROTOCOL_VIOLATION.\n \n \n+## CONNECTION_ID_FINISHED Frame {#frame-connection-id-finished}\n+\n+An endpoint sends a CONNECTION_ID_FINISHED frame (type=0x1b) to indicate that it\n+will no longer use a connection ID that was issued by its peer.  This also\n+serves as a request to the peer to send additional connection IDs for future use\n+(see {{connection-id}}).  New connection IDs can be delivered via the\n+NEW_CONNECTION_ID frame ({{frame-new-connection-id}}).\n+\n+The CONNECTION_ID_FINISHED frame is as follows:\n+\n+~~~\n+ 0                   1                   2                   3\n+ 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1\n++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n+|   Length (8)  |          Connection ID (32..144)            ...\n++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n+~~~\n+\n+The fields are:\n+\n+Length:\n+\n+: An 8-bit unsigned integer containing the length of the connection ID.  Values\n+  less than 4 and greater than 18 are invalid and MUST be treated as a\n+  connection error of type PROTOCOL_VIOLATION.","path":"draft-ietf-quic-transport.md","position":259,"original_position":259,"commit_id":"3157757fa1e3a00929d3fa6eedea47841ea97016","original_commit_id":"3157757fa1e3a00929d3fa6eedea47841ea97016","user":{"login":"ekr","id":1111457,"node_id":"MDQ6VXNlcjExMTE0NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1111457?v=4","gravatar_id":"","url":"https://api.github.com/users/ekr","html_url":"https://github.com/ekr","followers_url":"https://api.github.com/users/ekr/followers","following_url":"https://api.github.com/users/ekr/following{/other_user}","gists_url":"https://api.github.com/users/ekr/gists{/gist_id}","starred_url":"https://api.github.com/users/ekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekr/subscriptions","organizations_url":"https://api.github.com/users/ekr/orgs","repos_url":"https://api.github.com/users/ekr/repos","events_url":"https://api.github.com/users/ekr/events{/privacy}","received_events_url":"https://api.github.com/users/ekr/received_events","type":"User","site_admin":false},"body":"Well, the text below on line 3274 requires this.","created_at":"2018-08-13T23:35:05Z","updated_at":"2018-08-13T23:35:11Z","html_url":"https://github.com/erickinnear/base-drafts/pull/4#discussion_r209790911","pull_request_url":"https://api.github.com/repos/erickinnear/base-drafts/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/erickinnear/base-drafts/pulls/comments/209790911"},"html":{"href":"https://github.com/erickinnear/base-drafts/pull/4#discussion_r209790911"},"pull_request":{"href":"https://api.github.com/repos/erickinnear/base-drafts/pulls/4"}},"in_reply_to_id":209771299},"pull_request":{"url":"https://api.github.com/repos/erickinnear/base-drafts/pulls/4","id":207550945,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTUwOTQ1","html_url":"https://github.com/erickinnear/base-drafts/pull/4","diff_url":"https://github.com/erickinnear/base-drafts/pull/4.diff","patch_url":"https://github.com/erickinnear/base-drafts/pull/4.patch","issue_url":"https://api.github.com/repos/erickinnear/base-drafts/issues/4","number":4,"state":"open","locked":false,"title":"Initial Connection ID text","user":{"login":"erickinnear","id":32474881,"node_id":"MDQ6VXNlcjMyNDc0ODgx","avatar_url":"https://avatars2.githubusercontent.com/u/32474881?v=4","gravatar_id":"","url":"https://api.github.com/users/erickinnear","html_url":"https://github.com/erickinnear","followers_url":"https://api.github.com/users/erickinnear/followers","following_url":"https://api.github.com/users/erickinnear/following{/other_user}","gists_url":"https://api.github.com/users/erickinnear/gists{/gist_id}","starred_url":"https://api.github.com/users/erickinnear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erickinnear/subscriptions","organizations_url":"https://api.github.com/users/erickinnear/orgs","repos_url":"https://api.github.com/users/erickinnear/repos","events_url":"https://api.github.com/users/erickinnear/events{/privacy}","received_events_url":"https://api.github.com/users/erickinnear/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-10T09:10:06Z","updated_at":"2018-08-13T23:35:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78144c3291868db4729b4bf050566ab5812e997a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/erickinnear/base-drafts/pulls/4/commits","review_comments_url":"https://api.github.com/repos/erickinnear/base-drafts/pulls/4/comments","review_comment_url":"https://api.github.com/repos/erickinnear/base-drafts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/erickinnear/base-drafts/issues/4/comments","statuses_url":"https://api.github.com/repos/erickinnear/base-drafts/statuses/3157757fa1e3a00929d3fa6eedea47841ea97016","head":{"label":"erickinnear:conn_id","ref":"conn_id","sha":"3157757fa1e3a00929d3fa6eedea47841ea97016","user":{"login":"erickinnear","id":32474881,"node_id":"MDQ6VXNlcjMyNDc0ODgx","avatar_url":"https://avatars2.githubusercontent.com/u/32474881?v=4","gravatar_id":"","url":"https://api.github.com/users/erickinnear","html_url":"https://github.com/erickinnear","followers_url":"https://api.github.com/users/erickinnear/followers","following_url":"https://api.github.com/users/erickinnear/following{/other_user}","gists_url":"https://api.github.com/users/erickinnear/gists{/gist_id}","starred_url":"https://api.github.com/users/erickinnear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erickinnear/subscriptions","organizations_url":"https://api.github.com/users/erickinnear/orgs","repos_url":"https://api.github.com/users/erickinnear/repos","events_url":"https://api.github.com/users/erickinnear/events{/privacy}","received_events_url":"https://api.github.com/users/erickinnear/received_events","type":"User","site_admin":false},"repo":{"id":113015254,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMwMTUyNTQ=","name":"base-drafts","full_name":"erickinnear/base-drafts","owner":{"login":"erickinnear","id":32474881,"node_id":"MDQ6VXNlcjMyNDc0ODgx","avatar_url":"https://avatars2.githubusercontent.com/u/32474881?v=4","gravatar_id":"","url":"https://api.github.com/users/erickinnear","html_url":"https://github.com/erickinnear","followers_url":"https://api.github.com/users/erickinnear/followers","following_url":"https://api.github.com/users/erickinnear/following{/other_user}","gists_url":"https://api.github.com/users/erickinnear/gists{/gist_id}","starred_url":"https://api.github.com/users/erickinnear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erickinnear/subscriptions","organizations_url":"https://api.github.com/users/erickinnear/orgs","repos_url":"https://api.github.com/users/erickinnear/repos","events_url":"https://api.github.com/users/erickinnear/events{/privacy}","received_events_url":"https://api.github.com/users/erickinnear/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erickinnear/base-drafts","description":" Internet-Drafts that make up the base QUIC specification","fork":true,"url":"https://api.github.com/repos/erickinnear/base-drafts","forks_url":"https://api.github.com/repos/erickinnear/base-drafts/forks","keys_url":"https://api.github.com/repos/erickinnear/base-drafts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erickinnear/base-drafts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erickinnear/base-drafts/teams","hooks_url":"https://api.github.com/repos/erickinnear/base-drafts/hooks","issue_events_url":"https://api.github.com/repos/erickinnear/base-drafts/issues/events{/number}","events_url":"https://api.github.com/repos/erickinnear/base-drafts/events","assignees_url":"https://api.github.com/repos/erickinnear/base-drafts/assignees{/user}","branches_url":"https://api.github.com/repos/erickinnear/base-drafts/branches{/branch}","tags_url":"https://api.github.com/repos/erickinnear/base-drafts/tags","blobs_url":"https://api.github.com/repos/erickinnear/base-drafts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erickinnear/base-drafts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erickinnear/base-drafts/git/refs{/sha}","trees_url":"https://api.github.com/repos/erickinnear/base-drafts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erickinnear/base-drafts/statuses/{sha}","languages_url":"https://api.github.com/repos/erickinnear/base-drafts/languages","stargazers_url":"https://api.github.com/repos/erickinnear/base-drafts/stargazers","contributors_url":"https://api.github.com/repos/erickinnear/base-drafts/contributors","subscribers_url":"https://api.github.com/repos/erickinnear/base-drafts/subscribers","subscription_url":"https://api.github.com/repos/erickinnear/base-drafts/subscription","commits_url":"https://api.github.com/repos/erickinnear/base-drafts/commits{/sha}","git_commits_url":"https://api.github.com/repos/erickinnear/base-drafts/git/commits{/sha}","comments_url":"https://api.github.com/repos/erickinnear/base-drafts/comments{/number}","issue_comment_url":"https://api.github.com/repos/erickinnear/base-drafts/issues/comments{/number}","contents_url":"https://api.github.com/repos/erickinnear/base-drafts/contents/{+path}","compare_url":"https://api.github.com/repos/erickinnear/base-drafts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erickinnear/base-drafts/merges","archive_url":"https://api.github.com/repos/erickinnear/base-drafts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erickinnear/base-drafts/downloads","issues_url":"https://api.github.com/repos/erickinnear/base-drafts/issues{/number}","pulls_url":"https://api.github.com/repos/erickinnear/base-drafts/pulls{/number}","milestones_url":"https://api.github.com/repos/erickinnear/base-drafts/milestones{/number}","notifications_url":"https://api.github.com/repos/erickinnear/base-drafts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erickinnear/base-drafts/labels{/name}","releases_url":"https://api.github.com/repos/erickinnear/base-drafts/releases{/id}","deployments_url":"https://api.github.com/repos/erickinnear/base-drafts/deployments","created_at":"2017-12-04T08:22:25Z","updated_at":"2018-08-09T00:09:44Z","pushed_at":"2018-08-10T09:10:06Z","git_url":"git://github.com/erickinnear/base-drafts.git","ssh_url":"git@github.com:erickinnear/base-drafts.git","clone_url":"https://github.com/erickinnear/base-drafts.git","svn_url":"https://github.com/erickinnear/base-drafts","homepage":"https://quicwg.github.io/","size":34635,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"erickinnear:master","ref":"master","sha":"67ae7e9859f2be65e5621eecc2e25823dfc69510","user":{"login":"erickinnear","id":32474881,"node_id":"MDQ6VXNlcjMyNDc0ODgx","avatar_url":"https://avatars2.githubusercontent.com/u/32474881?v=4","gravatar_id":"","url":"https://api.github.com/users/erickinnear","html_url":"https://github.com/erickinnear","followers_url":"https://api.github.com/users/erickinnear/followers","following_url":"https://api.github.com/users/erickinnear/following{/other_user}","gists_url":"https://api.github.com/users/erickinnear/gists{/gist_id}","starred_url":"https://api.github.com/users/erickinnear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erickinnear/subscriptions","organizations_url":"https://api.github.com/users/erickinnear/orgs","repos_url":"https://api.github.com/users/erickinnear/repos","events_url":"https://api.github.com/users/erickinnear/events{/privacy}","received_events_url":"https://api.github.com/users/erickinnear/received_events","type":"User","site_admin":false},"repo":{"id":113015254,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMwMTUyNTQ=","name":"base-drafts","full_name":"erickinnear/base-drafts","owner":{"login":"erickinnear","id":32474881,"node_id":"MDQ6VXNlcjMyNDc0ODgx","avatar_url":"https://avatars2.githubusercontent.com/u/32474881?v=4","gravatar_id":"","url":"https://api.github.com/users/erickinnear","html_url":"https://github.com/erickinnear","followers_url":"https://api.github.com/users/erickinnear/followers","following_url":"https://api.github.com/users/erickinnear/following{/other_user}","gists_url":"https://api.github.com/users/erickinnear/gists{/gist_id}","starred_url":"https://api.github.com/users/erickinnear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erickinnear/subscriptions","organizations_url":"https://api.github.com/users/erickinnear/orgs","repos_url":"https://api.github.com/users/erickinnear/repos","events_url":"https://api.github.com/users/erickinnear/events{/privacy}","received_events_url":"https://api.github.com/users/erickinnear/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erickinnear/base-drafts","description":" Internet-Drafts that make up the base QUIC specification","fork":true,"url":"https://api.github.com/repos/erickinnear/base-drafts","forks_url":"https://api.github.com/repos/erickinnear/base-drafts/forks","keys_url":"https://api.github.com/repos/erickinnear/base-drafts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erickinnear/base-drafts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erickinnear/base-drafts/teams","hooks_url":"https://api.github.com/repos/erickinnear/base-drafts/hooks","issue_events_url":"https://api.github.com/repos/erickinnear/base-drafts/issues/events{/number}","events_url":"https://api.github.com/repos/erickinnear/base-drafts/events","assignees_url":"https://api.github.com/repos/erickinnear/base-drafts/assignees{/user}","branches_url":"https://api.github.com/repos/erickinnear/base-drafts/branches{/branch}","tags_url":"https://api.github.com/repos/erickinnear/base-drafts/tags","blobs_url":"https://api.github.com/repos/erickinnear/base-drafts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erickinnear/base-drafts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erickinnear/base-drafts/git/refs{/sha}","trees_url":"https://api.github.com/repos/erickinnear/base-drafts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erickinnear/base-drafts/statuses/{sha}","languages_url":"https://api.github.com/repos/erickinnear/base-drafts/languages","stargazers_url":"https://api.github.com/repos/erickinnear/base-drafts/stargazers","contributors_url":"https://api.github.com/repos/erickinnear/base-drafts/contributors","subscribers_url":"https://api.github.com/repos/erickinnear/base-drafts/subscribers","subscription_url":"https://api.github.com/repos/erickinnear/base-drafts/subscription","commits_url":"https://api.github.com/repos/erickinnear/base-drafts/commits{/sha}","git_commits_url":"https://api.github.com/repos/erickinnear/base-drafts/git/commits{/sha}","comments_url":"https://api.github.com/repos/erickinnear/base-drafts/comments{/number}","issue_comment_url":"https://api.github.com/repos/erickinnear/base-drafts/issues/comments{/number}","contents_url":"https://api.github.com/repos/erickinnear/base-drafts/contents/{+path}","compare_url":"https://api.github.com/repos/erickinnear/base-drafts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erickinnear/base-drafts/merges","archive_url":"https://api.github.com/repos/erickinnear/base-drafts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erickinnear/base-drafts/downloads","issues_url":"https://api.github.com/repos/erickinnear/base-drafts/issues{/number}","pulls_url":"https://api.github.com/repos/erickinnear/base-drafts/pulls{/number}","milestones_url":"https://api.github.com/repos/erickinnear/base-drafts/milestones{/number}","notifications_url":"https://api.github.com/repos/erickinnear/base-drafts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erickinnear/base-drafts/labels{/name}","releases_url":"https://api.github.com/repos/erickinnear/base-drafts/releases{/id}","deployments_url":"https://api.github.com/repos/erickinnear/base-drafts/deployments","created_at":"2017-12-04T08:22:25Z","updated_at":"2018-08-09T00:09:44Z","pushed_at":"2018-08-10T09:10:06Z","git_url":"git://github.com/erickinnear/base-drafts.git","ssh_url":"git@github.com:erickinnear/base-drafts.git","clone_url":"https://github.com/erickinnear/base-drafts.git","svn_url":"https://github.com/erickinnear/base-drafts","homepage":"https://quicwg.github.io/","size":34635,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/erickinnear/base-drafts/pulls/4"},"html":{"href":"https://github.com/erickinnear/base-drafts/pull/4"},"issue":{"href":"https://api.github.com/repos/erickinnear/base-drafts/issues/4"},"comments":{"href":"https://api.github.com/repos/erickinnear/base-drafts/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/erickinnear/base-drafts/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/erickinnear/base-drafts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/erickinnear/base-drafts/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/erickinnear/base-drafts/statuses/3157757fa1e3a00929d3fa6eedea47841ea97016"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ekr"}}