{"action":"closed","issue":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/4924","repository_url":"https://api.github.com/repos/envoyproxy/envoy","labels_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4924/labels{/name}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4924/comments","events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4924/events","html_url":"https://github.com/envoyproxy/envoy/issues/4924","id":375748262,"node_id":"MDU6SXNzdWUzNzU3NDgyNjI=","number":4924,"title":"Not to send x-forwarded-for header for AsyncClient","user":{"login":"qiwzhang","id":11790727,"node_id":"MDQ6VXNlcjExNzkwNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"labels":[{"id":620444894,"node_id":"MDU6TGFiZWw2MjA0NDQ4OTQ=","url":"https://api.github.com/repos/envoyproxy/envoy/labels/design%20proposal","name":"design proposal","color":"c5def5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-31T00:20:55Z","updated_at":"2018-10-31T15:50:27Z","closed_at":"2018-10-31T15:50:27Z","author_association":"CONTRIBUTOR","body":"*Title*: Not to send x-forwarded-for header for AsyncClient\r\n\r\n*Description*:\r\n\r\nThe referred code is [here](https://github.com/envoyproxy/envoy/blob/master/source/common/http/async_client_impl.cc#L125)\r\n\r\nX-FORWARDED-FOR is supposedly to be added for a forwarded request. But AsyncClient is for the requests originated by Envoy, not forwarded.   So it should not be added.\r\n\r\nBackground.  We are trying to fetch access token from GCP metadata server by using AsyncClient.\r\nBut if X-FORWARDED-FOR is added,  GCP metadata server  rejects it.\r\n\r\n [GCP metaddata server](https://cloud.google.com/compute/docs/storing-retrieving-metadata)\r\n\r\n"}}
{"actor":{"display_login":"qiwzhang"}}