{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/229858445","pull_request_review_id":170460880,"id":229858445,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTg1ODQ0NQ==","diff_hunk":"@@ -396,6 +425,32 @@ class _DraggableState<T> extends State<Draggable<T>> {\n   }\n }\n \n+/// Represents the details when a specific pointer event occurred on\n+/// the [Draggable].\n+///\n+/// This includes the [Velocity] at which the pointer was moving and [Offset]\n+/// when the draggable event occurred, and whether its [DragTarget] accepted it.\n+///\n+/// Also, this is the Details object for callbacks that use [DragEndCallback].\n+class DraggableDetails {\n+  DraggableDetails._({","path":"packages/flutter/lib/src/widgets/drag_target.dart","position":83,"original_position":83,"commit_id":"a8d422a60646e0fc9d84a32435b3d5a50b084504","original_commit_id":"a8d422a60646e0fc9d84a32435b3d5a50b084504","user":{"login":"Hixie","id":551196,"node_id":"MDQ6VXNlcjU1MTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"why only a private constructor?","created_at":"2018-10-31T20:36:56Z","updated_at":"2018-10-31T20:36:56Z","html_url":"https://github.com/flutter/flutter/pull/22267#discussion_r229858445","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/22267","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/229858445"},"html":{"href":"https://github.com/flutter/flutter/pull/22267#discussion_r229858445"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/22267"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/22267","id":218047784,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDQ3Nzg0","html_url":"https://github.com/flutter/flutter/pull/22267","diff_url":"https://github.com/flutter/flutter/pull/22267.diff","patch_url":"https://github.com/flutter/flutter/pull/22267.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/22267","number":22267,"state":"open","locked":false,"title":"Added support for passing in velocity and offset into Draggable.onDragCompleted","user":{"login":"diegotori","id":1844568,"node_id":"MDQ6VXNlcjE4NDQ1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1844568?v=4","gravatar_id":"","url":"https://api.github.com/users/diegotori","html_url":"https://github.com/diegotori","followers_url":"https://api.github.com/users/diegotori/followers","following_url":"https://api.github.com/users/diegotori/following{/other_user}","gists_url":"https://api.github.com/users/diegotori/gists{/gist_id}","starred_url":"https://api.github.com/users/diegotori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegotori/subscriptions","organizations_url":"https://api.github.com/users/diegotori/orgs","repos_url":"https://api.github.com/users/diegotori/repos","events_url":"https://api.github.com/users/diegotori/events{/privacy}","received_events_url":"https://api.github.com/users/diegotori/received_events","type":"User","site_admin":false},"body":"Addresses issue #20258. Also slightly modified related unit tests as per the method signature change.\r\n\r\nNote that this may be a **breaking change**, due to the addition of parameters to the method signature. I can most certainly make them optional upon request so that it doesn't end up breaking the API this close to release.\r\n\r\nIf that is not advisable, then we can leave it as is, since one can `_` the parameters when declaring it, thus throwing them away on demand.","created_at":"2018-09-25T16:43:39Z","updated_at":"2018-10-31T20:36:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dde9a0e74422e4f6b268d78c95e38fbbdf19ab8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/22267/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/22267/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/22267/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/a8d422a60646e0fc9d84a32435b3d5a50b084504","head":{"label":"diegotori:draggable_ondragcompleted_velocity_offset","ref":"draggable_ondragcompleted_velocity_offset","sha":"a8d422a60646e0fc9d84a32435b3d5a50b084504","user":{"login":"diegotori","id":1844568,"node_id":"MDQ6VXNlcjE4NDQ1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1844568?v=4","gravatar_id":"","url":"https://api.github.com/users/diegotori","html_url":"https://github.com/diegotori","followers_url":"https://api.github.com/users/diegotori/followers","following_url":"https://api.github.com/users/diegotori/following{/other_user}","gists_url":"https://api.github.com/users/diegotori/gists{/gist_id}","starred_url":"https://api.github.com/users/diegotori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegotori/subscriptions","organizations_url":"https://api.github.com/users/diegotori/orgs","repos_url":"https://api.github.com/users/diegotori/repos","events_url":"https://api.github.com/users/diegotori/events{/privacy}","received_events_url":"https://api.github.com/users/diegotori/received_events","type":"User","site_admin":false},"repo":{"id":150180583,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxODA1ODM=","name":"flutter","full_name":"diegotori/flutter","private":false,"owner":{"login":"diegotori","id":1844568,"node_id":"MDQ6VXNlcjE4NDQ1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1844568?v=4","gravatar_id":"","url":"https://api.github.com/users/diegotori","html_url":"https://github.com/diegotori","followers_url":"https://api.github.com/users/diegotori/followers","following_url":"https://api.github.com/users/diegotori/following{/other_user}","gists_url":"https://api.github.com/users/diegotori/gists{/gist_id}","starred_url":"https://api.github.com/users/diegotori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegotori/subscriptions","organizations_url":"https://api.github.com/users/diegotori/orgs","repos_url":"https://api.github.com/users/diegotori/repos","events_url":"https://api.github.com/users/diegotori/events{/privacy}","received_events_url":"https://api.github.com/users/diegotori/received_events","type":"User","site_admin":false},"html_url":"https://github.com/diegotori/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/diegotori/flutter","forks_url":"https://api.github.com/repos/diegotori/flutter/forks","keys_url":"https://api.github.com/repos/diegotori/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diegotori/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diegotori/flutter/teams","hooks_url":"https://api.github.com/repos/diegotori/flutter/hooks","issue_events_url":"https://api.github.com/repos/diegotori/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/diegotori/flutter/events","assignees_url":"https://api.github.com/repos/diegotori/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/diegotori/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/diegotori/flutter/tags","blobs_url":"https://api.github.com/repos/diegotori/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diegotori/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diegotori/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/diegotori/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diegotori/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/diegotori/flutter/languages","stargazers_url":"https://api.github.com/repos/diegotori/flutter/stargazers","contributors_url":"https://api.github.com/repos/diegotori/flutter/contributors","subscribers_url":"https://api.github.com/repos/diegotori/flutter/subscribers","subscription_url":"https://api.github.com/repos/diegotori/flutter/subscription","commits_url":"https://api.github.com/repos/diegotori/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/diegotori/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/diegotori/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/diegotori/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/diegotori/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/diegotori/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diegotori/flutter/merges","archive_url":"https://api.github.com/repos/diegotori/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diegotori/flutter/downloads","issues_url":"https://api.github.com/repos/diegotori/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/diegotori/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/diegotori/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/diegotori/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diegotori/flutter/labels{/name}","releases_url":"https://api.github.com/repos/diegotori/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/diegotori/flutter/deployments","created_at":"2018-09-24T23:22:59Z","updated_at":"2018-10-11T21:32:31Z","pushed_at":"2018-10-12T14:56:54Z","git_url":"git://github.com/diegotori/flutter.git","ssh_url":"git@github.com:diegotori/flutter.git","clone_url":"https://github.com/diegotori/flutter.git","svn_url":"https://github.com/diegotori/flutter","homepage":"https://flutter.io","size":48583,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"3b68ae8422bf4789bdefffb8de0520b78400a55f","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-10-31T20:35:57Z","pushed_at":"2018-10-31T20:32:23Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":49619,"stargazers_count":40284,"watchers_count":40284,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3973,"mirror_url":null,"archived":false,"open_issues_count":4205,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3973,"open_issues":4205,"watchers":40284,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/22267"},"html":{"href":"https://github.com/flutter/flutter/pull/22267"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/22267"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/22267/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/22267/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/22267/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/a8d422a60646e0fc9d84a32435b3d5a50b084504"}},"author_association":"NONE"}}
{"actor":{"display_login":"Hixie"}}