{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/218771491","pull_request_review_id":156779840,"id":218771491,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODc3MTQ5MQ==","diff_hunk":"@@ -156,9 +181,11 @@ public static StreamExecutionEnvironment createStreamExecutionEnvironment(\n         throw new IllegalArgumentException(\"The checkpoint interval must be positive\");\n       }\n       flinkStreamEnv.enableCheckpointing(checkpointInterval, options.getCheckpointingMode());\n-      flinkStreamEnv\n-          .getCheckpointConfig()\n-          .setCheckpointTimeout(options.getCheckpointTimeoutMillis());\n+      if (options.getCheckpointTimeoutMillis() != -1) {","path":"runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java","position":90,"original_position":90,"commit_id":"1c0c66275b13f1dec43df329157ab1628abb481b","original_commit_id":"2c13e4f7e2cce4c0713e93e4b30128a90a39f720","user":{"login":"mxm","id":837221,"node_id":"MDQ6VXNlcjgzNzIyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/837221?v=4","gravatar_id":"","url":"https://api.github.com/users/mxm","html_url":"https://github.com/mxm","followers_url":"https://api.github.com/users/mxm/followers","following_url":"https://api.github.com/users/mxm/following{/other_user}","gists_url":"https://api.github.com/users/mxm/gists{/gist_id}","starred_url":"https://api.github.com/users/mxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxm/subscriptions","organizations_url":"https://api.github.com/users/mxm/orgs","repos_url":"https://api.github.com/users/mxm/repos","events_url":"https://api.github.com/users/mxm/events{/privacy}","received_events_url":"https://api.github.com/users/mxm/received_events","type":"User","site_admin":false},"body":"-1 in Flink means disabled. Anything else should be applied, even other negative numbers which will raise an exception.","created_at":"2018-09-19T11:47:08Z","updated_at":"2018-09-19T11:47:08Z","html_url":"https://github.com/apache/beam/pull/6426#discussion_r218771491","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/6426","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/218771491"},"html":{"href":"https://github.com/apache/beam/pull/6426#discussion_r218771491"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/6426"}},"in_reply_to_id":218574267},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/6426","id":216334116,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MzM0MTE2","html_url":"https://github.com/apache/beam/pull/6426","diff_url":"https://github.com/apache/beam/pull/6426.diff","patch_url":"https://github.com/apache/beam/pull/6426.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/6426","number":6426,"state":"open","locked":false,"title":"[BEAM-3089] Fix default values in FlinkPipelineOptions / Add tests","user":{"login":"mxm","id":837221,"node_id":"MDQ6VXNlcjgzNzIyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/837221?v=4","gravatar_id":"","url":"https://api.github.com/users/mxm","html_url":"https://github.com/mxm","followers_url":"https://api.github.com/users/mxm/followers","following_url":"https://api.github.com/users/mxm/following{/other_user}","gists_url":"https://api.github.com/users/mxm/gists{/gist_id}","starred_url":"https://api.github.com/users/mxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxm/subscriptions","organizations_url":"https://api.github.com/users/mxm/orgs","repos_url":"https://api.github.com/users/mxm/repos","events_url":"https://api.github.com/users/mxm/events{/privacy}","received_events_url":"https://api.github.com/users/mxm/received_events","type":"User","site_admin":false},"body":"[BEAM-3089] Use Flink cluster parallelism if no parallelism provided\r\n\r\n- The Flink Runner didn't pick up the parallelism from the Flink command-line if\r\nprovided there.\r\n\r\n- A warning is printed if the parallelism can't be inferred and we fall back to\r\n  parallelism of 1 (which is also current behavior).\r\n\r\n- Local tests can now also use a parallelism > 1 which might help for test coverage.\r\n\r\n- Further, tests verify as much from the current behavior as possible.\r\n\r\n- [BEAM-3089] Add test for FlinkExecutionEnvironments\r\n- Revert default checkpointing mode to EXACTLY_ONCE\r\n- Use default for checkpoint timeout\r\n- [BEAM-3089] Test default values of FlinkPipelineOptions\r\n- Set default master url to [auto] \r\n\r\nPost-Commit Tests Status (on master branch)\r\n------------------------------------------------------------------------------------------------\r\n\r\nLang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark\r\n--- | --- | --- | --- | --- | --- | --- | ---\r\nGo | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---\r\nJava | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)\r\nPython | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | ---\r\n\r\n\r\n\r\n\r\n","created_at":"2018-09-18T14:42:36Z","updated_at":"2018-09-19T11:47:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5ba4e673c584ab04f64a6631c835587da231164","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tweise","id":263695,"node_id":"MDQ6VXNlcjI2MzY5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/263695?v=4","gravatar_id":"","url":"https://api.github.com/users/tweise","html_url":"https://github.com/tweise","followers_url":"https://api.github.com/users/tweise/followers","following_url":"https://api.github.com/users/tweise/following{/other_user}","gists_url":"https://api.github.com/users/tweise/gists{/gist_id}","starred_url":"https://api.github.com/users/tweise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweise/subscriptions","organizations_url":"https://api.github.com/users/tweise/orgs","repos_url":"https://api.github.com/users/tweise/repos","events_url":"https://api.github.com/users/tweise/events{/privacy}","received_events_url":"https://api.github.com/users/tweise/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/6426/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/6426/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/6426/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/1c0c66275b13f1dec43df329157ab1628abb481b","head":{"label":"mxm:BEAM-3089","ref":"BEAM-3089","sha":"1c0c66275b13f1dec43df329157ab1628abb481b","user":{"login":"mxm","id":837221,"node_id":"MDQ6VXNlcjgzNzIyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/837221?v=4","gravatar_id":"","url":"https://api.github.com/users/mxm","html_url":"https://github.com/mxm","followers_url":"https://api.github.com/users/mxm/followers","following_url":"https://api.github.com/users/mxm/following{/other_user}","gists_url":"https://api.github.com/users/mxm/gists{/gist_id}","starred_url":"https://api.github.com/users/mxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxm/subscriptions","organizations_url":"https://api.github.com/users/mxm/orgs","repos_url":"https://api.github.com/users/mxm/repos","events_url":"https://api.github.com/users/mxm/events{/privacy}","received_events_url":"https://api.github.com/users/mxm/received_events","type":"User","site_admin":false},"repo":{"id":52998913,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjk5ODkxMw==","name":"beam","full_name":"mxm/beam","private":false,"owner":{"login":"mxm","id":837221,"node_id":"MDQ6VXNlcjgzNzIyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/837221?v=4","gravatar_id":"","url":"https://api.github.com/users/mxm","html_url":"https://github.com/mxm","followers_url":"https://api.github.com/users/mxm/followers","following_url":"https://api.github.com/users/mxm/following{/other_user}","gists_url":"https://api.github.com/users/mxm/gists{/gist_id}","starred_url":"https://api.github.com/users/mxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxm/subscriptions","organizations_url":"https://api.github.com/users/mxm/orgs","repos_url":"https://api.github.com/users/mxm/repos","events_url":"https://api.github.com/users/mxm/events{/privacy}","received_events_url":"https://api.github.com/users/mxm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mxm/beam","description":"Mirror of Apache Beam","fork":true,"url":"https://api.github.com/repos/mxm/beam","forks_url":"https://api.github.com/repos/mxm/beam/forks","keys_url":"https://api.github.com/repos/mxm/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxm/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxm/beam/teams","hooks_url":"https://api.github.com/repos/mxm/beam/hooks","issue_events_url":"https://api.github.com/repos/mxm/beam/issues/events{/number}","events_url":"https://api.github.com/repos/mxm/beam/events","assignees_url":"https://api.github.com/repos/mxm/beam/assignees{/user}","branches_url":"https://api.github.com/repos/mxm/beam/branches{/branch}","tags_url":"https://api.github.com/repos/mxm/beam/tags","blobs_url":"https://api.github.com/repos/mxm/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxm/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxm/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxm/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxm/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/mxm/beam/languages","stargazers_url":"https://api.github.com/repos/mxm/beam/stargazers","contributors_url":"https://api.github.com/repos/mxm/beam/contributors","subscribers_url":"https://api.github.com/repos/mxm/beam/subscribers","subscription_url":"https://api.github.com/repos/mxm/beam/subscription","commits_url":"https://api.github.com/repos/mxm/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxm/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxm/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxm/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxm/beam/contents/{+path}","compare_url":"https://api.github.com/repos/mxm/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxm/beam/merges","archive_url":"https://api.github.com/repos/mxm/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxm/beam/downloads","issues_url":"https://api.github.com/repos/mxm/beam/issues{/number}","pulls_url":"https://api.github.com/repos/mxm/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/mxm/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/mxm/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxm/beam/labels{/name}","releases_url":"https://api.github.com/repos/mxm/beam/releases{/id}","deployments_url":"https://api.github.com/repos/mxm/beam/deployments","created_at":"2016-03-02T21:48:54Z","updated_at":"2018-08-15T10:11:24Z","pushed_at":"2018-09-19T11:46:48Z","git_url":"git://github.com/mxm/beam.git","ssh_url":"git@github.com:mxm/beam.git","clone_url":"https://github.com/mxm/beam.git","svn_url":"https://github.com/mxm/beam","homepage":"","size":96386,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"46f0a02c06aa625640a62aa024deb2d711f1f0f0","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkwNDI0NQ==","name":"beam","full_name":"apache/beam","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2018-09-19T09:00:27Z","pushed_at":"2018-09-19T11:46:50Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"https://beam.apache.org","size":102198,"stargazers_count":2159,"watchers_count":2159,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1338,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1338,"open_issues":84,"watchers":2159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/6426"},"html":{"href":"https://github.com/apache/beam/pull/6426"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/6426"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/6426/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/6426/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/6426/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/1c0c66275b13f1dec43df329157ab1628abb481b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mxm"}}