{"action":"created","comment":{"url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/pulls/comments/186062633","pull_request_review_id":117580201,"id":186062633,"diff_hunk":"@@ -725,93 +733,119 @@ public InterpreterResult interpret(String[] lines, InterpreterContext context) {\n     }\n   }\n \n+  private void addDeployedJars() {\n+    if (snappyGlobalLoader != null) {\n+      URL[] allUrls = snappyGlobalLoader.getURLs();\n+      if (addedURLS == null || (addedURLS.length != allUrls.length)) {\n+        List<URL> added = new ArrayList<>();\n+        for (URL url : allUrls) {\n+          try {\n+            sc.addJar(url.getFile());\n+            added.add(url);\n+          } catch (Throwable t) {\n+            // ignore may be previously added\n+          }\n+        }\n+        addedURLS = added.toArray();","path":"src/main/java/org/apache/zeppelin/interpreter/SnappyDataZeppelinInterpreter.java","position":39,"original_position":39,"commit_id":"22f1c20a2ebf4bc3fa1abc19cb74753afd046175","original_commit_id":"22f1c20a2ebf4bc3fa1abc19cb74753afd046175","user":{"login":"kneeraj","id":1151021,"avatar_url":"https://avatars3.githubusercontent.com/u/1151021?v=4","gravatar_id":"","url":"https://api.github.com/users/kneeraj","html_url":"https://github.com/kneeraj","followers_url":"https://api.github.com/users/kneeraj/followers","following_url":"https://api.github.com/users/kneeraj/following{/other_user}","gists_url":"https://api.github.com/users/kneeraj/gists{/gist_id}","starred_url":"https://api.github.com/users/kneeraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kneeraj/subscriptions","organizations_url":"https://api.github.com/users/kneeraj/orgs","repos_url":"https://api.github.com/users/kneeraj/repos","events_url":"https://api.github.com/users/kneeraj/events{/privacy}","received_events_url":"https://api.github.com/users/kneeraj/received_events","type":"User","site_admin":false},"body":"Added urls is kind of a cache to see whether we have already added all the jars or not. There can be a case where a deployment has happened after the interpreter has come up in which case it needs to add the jars again. Otherwise it is not required. ","created_at":"2018-05-04T12:08:52Z","updated_at":"2018-05-04T12:08:52Z","html_url":"https://github.com/SnappyDataInc/zeppelin-interpreter/pull/16#discussion_r186062633","pull_request_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/pulls/16","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/pulls/comments/186062633"},"html":{"href":"https://github.com/SnappyDataInc/zeppelin-interpreter/pull/16#discussion_r186062633"},"pull_request":{"href":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/pulls/16"}},"in_reply_to_id":186047000},"pull_request":{"url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/pulls/16","id":185911122,"html_url":"https://github.com/SnappyDataInc/zeppelin-interpreter/pull/16","diff_url":"https://github.com/SnappyDataInc/zeppelin-interpreter/pull/16.diff","patch_url":"https://github.com/SnappyDataInc/zeppelin-interpreter/pull/16.patch","issue_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/issues/16","number":16,"state":"open","locked":false,"title":"SNAP-2297","user":{"login":"kneeraj","id":1151021,"avatar_url":"https://avatars3.githubusercontent.com/u/1151021?v=4","gravatar_id":"","url":"https://api.github.com/users/kneeraj","html_url":"https://github.com/kneeraj","followers_url":"https://api.github.com/users/kneeraj/followers","following_url":"https://api.github.com/users/kneeraj/following{/other_user}","gists_url":"https://api.github.com/users/kneeraj/gists{/gist_id}","starred_url":"https://api.github.com/users/kneeraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kneeraj/subscriptions","organizations_url":"https://api.github.com/users/kneeraj/orgs","repos_url":"https://api.github.com/users/kneeraj/repos","events_url":"https://api.github.com/users/kneeraj/events{/privacy}","received_events_url":"https://api.github.com/users/kneeraj/received_events","type":"User","site_admin":false},"body":"Changes to make Snappydata zeppelin interpreters to work with deployed packages","created_at":"2018-05-04T07:38:37Z","updated_at":"2018-05-04T12:08:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d284312af7a7ce5aff35b131ea4391e44b32b069","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rishitesh","id":793775,"avatar_url":"https://avatars0.githubusercontent.com/u/793775?v=4","gravatar_id":"","url":"https://api.github.com/users/rishitesh","html_url":"https://github.com/rishitesh","followers_url":"https://api.github.com/users/rishitesh/followers","following_url":"https://api.github.com/users/rishitesh/following{/other_user}","gists_url":"https://api.github.com/users/rishitesh/gists{/gist_id}","starred_url":"https://api.github.com/users/rishitesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rishitesh/subscriptions","organizations_url":"https://api.github.com/users/rishitesh/orgs","repos_url":"https://api.github.com/users/rishitesh/repos","events_url":"https://api.github.com/users/rishitesh/events{/privacy}","received_events_url":"https://api.github.com/users/rishitesh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/pulls/16/commits","review_comments_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/pulls/16/comments","review_comment_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/issues/16/comments","statuses_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/statuses/22f1c20a2ebf4bc3fa1abc19cb74753afd046175","head":{"label":"SnappyDataInc:SNAP-2297","ref":"SNAP-2297","sha":"22f1c20a2ebf4bc3fa1abc19cb74753afd046175","user":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":66356923,"name":"zeppelin-interpreter","full_name":"SnappyDataInc/zeppelin-interpreter","owner":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SnappyDataInc/zeppelin-interpreter","description":"Snappydata interpreter for Apache Zeppelin","fork":false,"url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter","forks_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/forks","keys_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/teams","hooks_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/hooks","issue_events_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/issues/events{/number}","events_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/events","assignees_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/assignees{/user}","branches_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/branches{/branch}","tags_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/tags","blobs_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/statuses/{sha}","languages_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/languages","stargazers_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/stargazers","contributors_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/contributors","subscribers_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/subscribers","subscription_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/subscription","commits_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/contents/{+path}","compare_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/merges","archive_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/downloads","issues_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/issues{/number}","pulls_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/pulls{/number}","milestones_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/milestones{/number}","notifications_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/labels{/name}","releases_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/releases{/id}","deployments_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/deployments","created_at":"2016-08-23T10:21:47Z","updated_at":"2017-09-28T18:46:25Z","pushed_at":"2018-05-04T07:38:38Z","git_url":"git://github.com/SnappyDataInc/zeppelin-interpreter.git","ssh_url":"git@github.com:SnappyDataInc/zeppelin-interpreter.git","clone_url":"https://github.com/SnappyDataInc/zeppelin-interpreter.git","svn_url":"https://github.com/SnappyDataInc/zeppelin-interpreter","homepage":null,"size":1057,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"SnappyDataInc:master","ref":"master","sha":"341e40c7b371643dda41b9faca5f291dd81b0213","user":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":66356923,"name":"zeppelin-interpreter","full_name":"SnappyDataInc/zeppelin-interpreter","owner":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SnappyDataInc/zeppelin-interpreter","description":"Snappydata interpreter for Apache Zeppelin","fork":false,"url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter","forks_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/forks","keys_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/teams","hooks_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/hooks","issue_events_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/issues/events{/number}","events_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/events","assignees_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/assignees{/user}","branches_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/branches{/branch}","tags_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/tags","blobs_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/statuses/{sha}","languages_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/languages","stargazers_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/stargazers","contributors_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/contributors","subscribers_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/subscribers","subscription_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/subscription","commits_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/contents/{+path}","compare_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/merges","archive_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/downloads","issues_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/issues{/number}","pulls_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/pulls{/number}","milestones_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/milestones{/number}","notifications_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/labels{/name}","releases_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/releases{/id}","deployments_url":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/deployments","created_at":"2016-08-23T10:21:47Z","updated_at":"2017-09-28T18:46:25Z","pushed_at":"2018-05-04T07:38:38Z","git_url":"git://github.com/SnappyDataInc/zeppelin-interpreter.git","ssh_url":"git@github.com:SnappyDataInc/zeppelin-interpreter.git","clone_url":"https://github.com/SnappyDataInc/zeppelin-interpreter.git","svn_url":"https://github.com/SnappyDataInc/zeppelin-interpreter","homepage":null,"size":1057,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/pulls/16"},"html":{"href":"https://github.com/SnappyDataInc/zeppelin-interpreter/pull/16"},"issue":{"href":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/issues/16"},"comments":{"href":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/SnappyDataInc/zeppelin-interpreter/statuses/22f1c20a2ebf4bc3fa1abc19cb74753afd046175"}},"author_association":"NONE"}}
{"actor":{"display_login":"kneeraj"}}