{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/38372","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/38372/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/38372/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/38372/events","html_url":"https://github.com/NixOS/nixpkgs/pull/38372","id":310759750,"number":38372,"title":"acme service: generate a CA for self-signed certificate","user":{"login":"abbradar","id":1174810,"avatar_url":"https://avatars0.githubusercontent.com/u/1174810?v=4","gravatar_id":"","url":"https://api.github.com/users/abbradar","html_url":"https://github.com/abbradar","followers_url":"https://api.github.com/users/abbradar/followers","following_url":"https://api.github.com/users/abbradar/following{/other_user}","gists_url":"https://api.github.com/users/abbradar/gists{/gist_id}","starred_url":"https://api.github.com/users/abbradar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abbradar/subscriptions","organizations_url":"https://api.github.com/users/abbradar/orgs","repos_url":"https://api.github.com/users/abbradar/repos","events_url":"https://api.github.com/users/abbradar/events{/privacy}","received_events_url":"https://api.github.com/users/abbradar/received_events","type":"User","site_admin":false},"labels":[{"id":6314750,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/0.kind:%20bug","name":"0.kind: bug","color":"84b6eb","default":false},{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NixOS/nixpkgs/milestones/12","html_url":"https://github.com/NixOS/nixpkgs/milestone/12","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones/12/labels","id":2670947,"number":12,"title":"18.03","description":"Nixpkgs/NixOS 18.03 stable release.\r\n\r\nRelease managers are @fpletz and @vcunat.","creator":{"login":"edolstra","id":1148549,"avatar_url":"https://avatars0.githubusercontent.com/u/1148549?v=4","gravatar_id":"","url":"https://api.github.com/users/edolstra","html_url":"https://github.com/edolstra","followers_url":"https://api.github.com/users/edolstra/followers","following_url":"https://api.github.com/users/edolstra/following{/other_user}","gists_url":"https://api.github.com/users/edolstra/gists{/gist_id}","starred_url":"https://api.github.com/users/edolstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edolstra/subscriptions","organizations_url":"https://api.github.com/users/edolstra/orgs","repos_url":"https://api.github.com/users/edolstra/repos","events_url":"https://api.github.com/users/edolstra/events{/privacy}","received_events_url":"https://api.github.com/users/edolstra/received_events","type":"User","site_admin":false},"open_issues":62,"closed_issues":114,"state":"open","created_at":"2017-07-31T10:37:50Z","updated_at":"2018-04-10T23:48:04Z","due_on":"2018-03-29T07:00:00Z","closed_at":null},"comments":7,"created_at":"2018-04-03T09:28:37Z","updated_at":"2018-04-11T04:49:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/38372","html_url":"https://github.com/NixOS/nixpkgs/pull/38372","diff_url":"https://github.com/NixOS/nixpkgs/pull/38372.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/38372.patch"},"body":"###### Motivation for this change\r\n\r\nThis is needed because simp_le expects two certificates in fullchain.pem, leading to error:\r\n\r\n> Not enough PEM encoded messages were found in fullchain.pem; at least 2 were expected, found 1.\r\n\r\nWe now create a CA and sign the key with it instead, providing correct fullchain.pem.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\ncc @vcunat @fpletz -- this is a potentially serious release issue. `security.acme` with `fullchain.pem` (e.g. nginx's `enableACME`) doesn't work at all on new servers now.\r\n\r\nTested on a fresh server with clean `/var/lib/acme` using nginx's `enableACME`."},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/380326174","html_url":"https://github.com/NixOS/nixpkgs/pull/38372#issuecomment-380326174","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/38372","id":380326174,"user":{"login":"wmertens","id":54934,"avatar_url":"https://avatars2.githubusercontent.com/u/54934?v=4","gravatar_id":"","url":"https://api.github.com/users/wmertens","html_url":"https://github.com/wmertens","followers_url":"https://api.github.com/users/wmertens/followers","following_url":"https://api.github.com/users/wmertens/following{/other_user}","gists_url":"https://api.github.com/users/wmertens/gists{/gist_id}","starred_url":"https://api.github.com/users/wmertens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmertens/subscriptions","organizations_url":"https://api.github.com/users/wmertens/orgs","repos_url":"https://api.github.com/users/wmertens/repos","events_url":"https://api.github.com/users/wmertens/events{/privacy}","received_events_url":"https://api.github.com/users/wmertens/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T04:49:09Z","updated_at":"2018-04-11T04:49:09Z","author_association":"CONTRIBUTOR","body":"The test error seems to be\r\n\r\n```\r\n/nix/store/aj9rz4k3xvg8q9fzqfnb0q123707zp0n-builder: line 1: .attrs.sh: No such file or directory\r\n```\r\n\r\n...which seems unrelated.\r\n\r\nThe changes look good to me."}}
{"actor":{"display_login":"wmertens"}}