{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/227048488","pull_request_review_id":167002072,"id":227048488,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzA0ODQ4OA==","diff_hunk":"@@ -0,0 +1,103 @@\n+/*\n+ * Licensed to Elasticsearch B.V. under one or more contributor\n+ * license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright\n+ * ownership. Elasticsearch B.V. licenses this file to you under\n+ * the Apache License, Version 2.0 (the \"License\"); you may\n+ * not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+export function dependenciesVisitorsGenerator(dependenciesAcc) {","path":"src/dev/build/tasks/nodejs_modules/code_parser/visitors.js","position":27,"original_position":20,"commit_id":"cac7c9ef15fbb386da83249960ea953f789823b2","original_commit_id":"b5aef06ea6329a5ea5917fd7f0d9f0f0fad984cb","user":{"login":"mistic","id":4440734,"node_id":"MDQ6VXNlcjQ0NDA3MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4440734?v=4","gravatar_id":"","url":"https://api.github.com/users/mistic","html_url":"https://github.com/mistic","followers_url":"https://api.github.com/users/mistic/followers","following_url":"https://api.github.com/users/mistic/following{/other_user}","gists_url":"https://api.github.com/users/mistic/gists{/gist_id}","starred_url":"https://api.github.com/users/mistic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistic/subscriptions","organizations_url":"https://api.github.com/users/mistic/orgs","repos_url":"https://api.github.com/users/mistic/repos","events_url":"https://api.github.com/users/mistic/events{/privacy}","received_events_url":"https://api.github.com/users/mistic/received_events","type":"User","site_admin":false},"body":"done!","created_at":"2018-10-22T16:41:10Z","updated_at":"2018-10-22T16:41:11Z","html_url":"https://github.com/elastic/kibana/pull/22618#discussion_r227048488","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/22618","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/227048488"},"html":{"href":"https://github.com/elastic/kibana/pull/22618#discussion_r227048488"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22618"}},"in_reply_to_id":225708746},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/22618","id":212555782,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTU1Nzgy","html_url":"https://github.com/elastic/kibana/pull/22618","diff_url":"https://github.com/elastic/kibana/pull/22618.diff","patch_url":"https://github.com/elastic/kibana/pull/22618.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/22618","number":22618,"state":"open","locked":false,"title":"Create vendor dll for the client modules","user":{"login":"mistic","id":4440734,"node_id":"MDQ6VXNlcjQ0NDA3MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4440734?v=4","gravatar_id":"","url":"https://api.github.com/users/mistic","html_url":"https://github.com/mistic","followers_url":"https://api.github.com/users/mistic/followers","following_url":"https://api.github.com/users/mistic/following{/other_user}","gists_url":"https://api.github.com/users/mistic/gists{/gist_id}","starred_url":"https://api.github.com/users/mistic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistic/subscriptions","organizations_url":"https://api.github.com/users/mistic/orgs","repos_url":"https://api.github.com/users/mistic/repos","events_url":"https://api.github.com/users/mistic/events{/privacy}","received_events_url":"https://api.github.com/users/mistic/received_events","type":"User","site_admin":false},"body":"This PR gives kibana the ability of use webpack dlls for the used `node_modules` by the client. It has a lot of positive sides including for example the ability to just delete every node_module already bundled into the dll from our final distribution `node_modules` path (but there are a lot of others).\r\n\r\nAll the work stages, goals/benefits and results are listed in the following issue https://github.com/elastic/kibana/issues/20749. Please take a look in order to get more info. \r\n\r\nI just need to assure the need for tests into this work as this is mostly something into the foundation of our build (just like the webpack itself) so our CI will fail if anything changes, but besides that part, I really think this is already finished!\r\n\r\n(I think we would need a cache invalidation mechanism for the dlls during development, but I believe the @spalger on https://github.com/elastic/kibana/pull/20506#pullrequestreview-161662852 can be extended to work with this PR perfectly. I have already made my suggestions there).\r\n\r\nI wanna thanks to everyone that help me through this journey specially to @spalger, @tylersmalley and ofc my sweet @elastic/kibana-operations team.","created_at":"2018-09-01T17:12:06Z","updated_at":"2018-10-22T16:41:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76c8d79654fb8577c550b545b23cf230ba0f61e1","assignee":{"login":"mistic","id":4440734,"node_id":"MDQ6VXNlcjQ0NDA3MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4440734?v=4","gravatar_id":"","url":"https://api.github.com/users/mistic","html_url":"https://github.com/mistic","followers_url":"https://api.github.com/users/mistic/followers","following_url":"https://api.github.com/users/mistic/following{/other_user}","gists_url":"https://api.github.com/users/mistic/gists{/gist_id}","starred_url":"https://api.github.com/users/mistic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistic/subscriptions","organizations_url":"https://api.github.com/users/mistic/orgs","repos_url":"https://api.github.com/users/mistic/repos","events_url":"https://api.github.com/users/mistic/events{/privacy}","received_events_url":"https://api.github.com/users/mistic/received_events","type":"User","site_admin":false},"assignees":[{"login":"mistic","id":4440734,"node_id":"MDQ6VXNlcjQ0NDA3MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4440734?v=4","gravatar_id":"","url":"https://api.github.com/users/mistic","html_url":"https://github.com/mistic","followers_url":"https://api.github.com/users/mistic/followers","following_url":"https://api.github.com/users/mistic/following{/other_user}","gists_url":"https://api.github.com/users/mistic/gists{/gist_id}","starred_url":"https://api.github.com/users/mistic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistic/subscriptions","organizations_url":"https://api.github.com/users/mistic/orgs","repos_url":"https://api.github.com/users/mistic/repos","events_url":"https://api.github.com/users/mistic/events{/privacy}","received_events_url":"https://api.github.com/users/mistic/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tylersmalley","id":40265,"node_id":"MDQ6VXNlcjQwMjY1","avatar_url":"https://avatars2.githubusercontent.com/u/40265?v=4","gravatar_id":"","url":"https://api.github.com/users/tylersmalley","html_url":"https://github.com/tylersmalley","followers_url":"https://api.github.com/users/tylersmalley/followers","following_url":"https://api.github.com/users/tylersmalley/following{/other_user}","gists_url":"https://api.github.com/users/tylersmalley/gists{/gist_id}","starred_url":"https://api.github.com/users/tylersmalley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylersmalley/subscriptions","organizations_url":"https://api.github.com/users/tylersmalley/orgs","repos_url":"https://api.github.com/users/tylersmalley/repos","events_url":"https://api.github.com/users/tylersmalley/events{/privacy}","received_events_url":"https://api.github.com/users/tylersmalley/received_events","type":"User","site_admin":false},{"login":"jbudz","id":3143860,"node_id":"MDQ6VXNlcjMxNDM4NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/3143860?v=4","gravatar_id":"","url":"https://api.github.com/users/jbudz","html_url":"https://github.com/jbudz","followers_url":"https://api.github.com/users/jbudz/followers","following_url":"https://api.github.com/users/jbudz/following{/other_user}","gists_url":"https://api.github.com/users/jbudz/gists{/gist_id}","starred_url":"https://api.github.com/users/jbudz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbudz/subscriptions","organizations_url":"https://api.github.com/users/jbudz/orgs","repos_url":"https://api.github.com/users/jbudz/repos","events_url":"https://api.github.com/users/jbudz/events{/privacy}","received_events_url":"https://api.github.com/users/jbudz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":470241342,"node_id":"MDU6TGFiZWw0NzAyNDEzNDI=","url":"https://api.github.com/repos/elastic/kibana/labels/:Operations","name":":Operations","color":"fef2c0","default":false},{"id":135307740,"node_id":"MDU6TGFiZWwxMzUzMDc3NDA=","url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"0052cc","default":false},{"id":912973198,"node_id":"MDU6TGFiZWw5MTI5NzMxOTg=","url":"https://api.github.com/repos/elastic/kibana/labels/v6.5.0","name":"v6.5.0","color":"ffffff","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/22618/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/22618/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/22618/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/cac7c9ef15fbb386da83249960ea953f789823b2","head":{"label":"mistic:optimizer-spike-single-process-v3","ref":"optimizer-spike-single-process-v3","sha":"cac7c9ef15fbb386da83249960ea953f789823b2","user":{"login":"mistic","id":4440734,"node_id":"MDQ6VXNlcjQ0NDA3MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4440734?v=4","gravatar_id":"","url":"https://api.github.com/users/mistic","html_url":"https://github.com/mistic","followers_url":"https://api.github.com/users/mistic/followers","following_url":"https://api.github.com/users/mistic/following{/other_user}","gists_url":"https://api.github.com/users/mistic/gists{/gist_id}","starred_url":"https://api.github.com/users/mistic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistic/subscriptions","organizations_url":"https://api.github.com/users/mistic/orgs","repos_url":"https://api.github.com/users/mistic/repos","events_url":"https://api.github.com/users/mistic/events{/privacy}","received_events_url":"https://api.github.com/users/mistic/received_events","type":"User","site_admin":false},"repo":{"id":133453229,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NTMyMjk=","name":"kibana","full_name":"mistic/kibana","private":false,"owner":{"login":"mistic","id":4440734,"node_id":"MDQ6VXNlcjQ0NDA3MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4440734?v=4","gravatar_id":"","url":"https://api.github.com/users/mistic","html_url":"https://github.com/mistic","followers_url":"https://api.github.com/users/mistic/followers","following_url":"https://api.github.com/users/mistic/following{/other_user}","gists_url":"https://api.github.com/users/mistic/gists{/gist_id}","starred_url":"https://api.github.com/users/mistic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistic/subscriptions","organizations_url":"https://api.github.com/users/mistic/orgs","repos_url":"https://api.github.com/users/mistic/repos","events_url":"https://api.github.com/users/mistic/events{/privacy}","received_events_url":"https://api.github.com/users/mistic/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mistic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/mistic/kibana","forks_url":"https://api.github.com/repos/mistic/kibana/forks","keys_url":"https://api.github.com/repos/mistic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mistic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mistic/kibana/teams","hooks_url":"https://api.github.com/repos/mistic/kibana/hooks","issue_events_url":"https://api.github.com/repos/mistic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/mistic/kibana/events","assignees_url":"https://api.github.com/repos/mistic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/mistic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/mistic/kibana/tags","blobs_url":"https://api.github.com/repos/mistic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mistic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mistic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/mistic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mistic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/mistic/kibana/languages","stargazers_url":"https://api.github.com/repos/mistic/kibana/stargazers","contributors_url":"https://api.github.com/repos/mistic/kibana/contributors","subscribers_url":"https://api.github.com/repos/mistic/kibana/subscribers","subscription_url":"https://api.github.com/repos/mistic/kibana/subscription","commits_url":"https://api.github.com/repos/mistic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/mistic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/mistic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/mistic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/mistic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/mistic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mistic/kibana/merges","archive_url":"https://api.github.com/repos/mistic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mistic/kibana/downloads","issues_url":"https://api.github.com/repos/mistic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/mistic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/mistic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/mistic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mistic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/mistic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/mistic/kibana/deployments","created_at":"2018-05-15T03:20:14Z","updated_at":"2018-10-19T12:42:16Z","pushed_at":"2018-10-21T01:47:32Z","git_url":"git://github.com/mistic/kibana.git","ssh_url":"git@github.com:mistic/kibana.git","clone_url":"https://github.com/mistic/kibana.git","svn_url":"https://github.com/mistic/kibana","homepage":"https://www.elastic.co/products/kibana","size":467026,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"da26fcbcce285079b41019bd924ec6bb7d93ffce","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-10-22T16:20:40Z","pushed_at":"2018-10-22T16:35:38Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":552225,"stargazers_count":10297,"watchers_count":10297,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4004,"mirror_url":null,"archived":false,"open_issues_count":3639,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4004,"open_issues":3639,"watchers":10297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22618"},"html":{"href":"https://github.com/elastic/kibana/pull/22618"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/22618"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/22618/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22618/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22618/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/cac7c9ef15fbb386da83249960ea953f789823b2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mistic"}}