{"action":"created","comment":{"url":"https://api.github.com/repos/JedWatson/react-select/pulls/comments/175311266","pull_request_review_id":104818536,"id":175311266,"diff_hunk":"@@ -335,10 +335,14 @@ export default class Select extends Component<Props, State> {\n   }\n   onMenuClose() {\n     this.onInputChange('', { action: 'menu-close' });\n-    this.props.onMenuClose();\n+    if (this.props.onMenuClose) {\n+      this.props.onMenuClose();\n+    }\n   }\n   onInputChange(newValue: string, actionMeta: InputActionMeta) {\n-    this.props.onInputChange(newValue, actionMeta);\n+    if (this.props.onInputChange) {","path":"src/Select.js","position":27,"original_position":27,"commit_id":"dcd670da0a6f7772ba90ad0772a5631410d10e37","original_commit_id":"dcd670da0a6f7772ba90ad0772a5631410d10e37","user":{"login":"ajaymathur","id":9667784,"avatar_url":"https://avatars1.githubusercontent.com/u/9667784?v=4","gravatar_id":"","url":"https://api.github.com/users/ajaymathur","html_url":"https://github.com/ajaymathur","followers_url":"https://api.github.com/users/ajaymathur/followers","following_url":"https://api.github.com/users/ajaymathur/following{/other_user}","gists_url":"https://api.github.com/users/ajaymathur/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaymathur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaymathur/subscriptions","organizations_url":"https://api.github.com/users/ajaymathur/orgs","repos_url":"https://api.github.com/users/ajaymathur/repos","events_url":"https://api.github.com/users/ajaymathur/events{/privacy}","received_events_url":"https://api.github.com/users/ajaymathur/received_events","type":"User","site_admin":false},"body":"added these guards to not beak the component in case these are not provided","created_at":"2018-03-19T00:19:39Z","updated_at":"2018-03-19T00:19:39Z","html_url":"https://github.com/JedWatson/react-select/pull/2436#discussion_r175311266","pull_request_url":"https://api.github.com/repos/JedWatson/react-select/pulls/2436","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/JedWatson/react-select/pulls/comments/175311266"},"html":{"href":"https://github.com/JedWatson/react-select/pull/2436#discussion_r175311266"},"pull_request":{"href":"https://api.github.com/repos/JedWatson/react-select/pulls/2436"}}},"pull_request":{"url":"https://api.github.com/repos/JedWatson/react-select/pulls/2436","id":174836480,"html_url":"https://github.com/JedWatson/react-select/pull/2436","diff_url":"https://github.com/JedWatson/react-select/pull/2436.diff","patch_url":"https://github.com/JedWatson/react-select/pull/2436.patch","issue_url":"https://api.github.com/repos/JedWatson/react-select/issues/2436","number":2436,"state":"open","locked":false,"title":"[V2] WIP-test cases","user":{"login":"ajaymathur","id":9667784,"avatar_url":"https://avatars1.githubusercontent.com/u/9667784?v=4","gravatar_id":"","url":"https://api.github.com/users/ajaymathur","html_url":"https://github.com/ajaymathur","followers_url":"https://api.github.com/users/ajaymathur/followers","following_url":"https://api.github.com/users/ajaymathur/following{/other_user}","gists_url":"https://api.github.com/users/ajaymathur/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaymathur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaymathur/subscriptions","organizations_url":"https://api.github.com/users/ajaymathur/orgs","repos_url":"https://api.github.com/users/ajaymathur/repos","events_url":"https://api.github.com/users/ajaymathur/events{/privacy}","received_events_url":"https://api.github.com/users/ajaymathur/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-14T02:06:40Z","updated_at":"2018-03-19T00:19:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"950fb6d371d567b8347033a4d55aa59013abd69c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":436631517,"url":"https://api.github.com/repos/JedWatson/react-select/labels/v2","name":"v2","color":"666666","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/JedWatson/react-select/pulls/2436/commits","review_comments_url":"https://api.github.com/repos/JedWatson/react-select/pulls/2436/comments","review_comment_url":"https://api.github.com/repos/JedWatson/react-select/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JedWatson/react-select/issues/2436/comments","statuses_url":"https://api.github.com/repos/JedWatson/react-select/statuses/dcd670da0a6f7772ba90ad0772a5631410d10e37","head":{"label":"ajaymathur:amathur/test-casee","ref":"amathur/test-casee","sha":"dcd670da0a6f7772ba90ad0772a5631410d10e37","user":{"login":"ajaymathur","id":9667784,"avatar_url":"https://avatars1.githubusercontent.com/u/9667784?v=4","gravatar_id":"","url":"https://api.github.com/users/ajaymathur","html_url":"https://github.com/ajaymathur","followers_url":"https://api.github.com/users/ajaymathur/followers","following_url":"https://api.github.com/users/ajaymathur/following{/other_user}","gists_url":"https://api.github.com/users/ajaymathur/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaymathur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaymathur/subscriptions","organizations_url":"https://api.github.com/users/ajaymathur/orgs","repos_url":"https://api.github.com/users/ajaymathur/repos","events_url":"https://api.github.com/users/ajaymathur/events{/privacy}","received_events_url":"https://api.github.com/users/ajaymathur/received_events","type":"User","site_admin":false},"repo":{"id":125140571,"name":"react-select","full_name":"ajaymathur/react-select","owner":{"login":"ajaymathur","id":9667784,"avatar_url":"https://avatars1.githubusercontent.com/u/9667784?v=4","gravatar_id":"","url":"https://api.github.com/users/ajaymathur","html_url":"https://github.com/ajaymathur","followers_url":"https://api.github.com/users/ajaymathur/followers","following_url":"https://api.github.com/users/ajaymathur/following{/other_user}","gists_url":"https://api.github.com/users/ajaymathur/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaymathur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaymathur/subscriptions","organizations_url":"https://api.github.com/users/ajaymathur/orgs","repos_url":"https://api.github.com/users/ajaymathur/repos","events_url":"https://api.github.com/users/ajaymathur/events{/privacy}","received_events_url":"https://api.github.com/users/ajaymathur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajaymathur/react-select","description":"A Select control built with and for React JS","fork":true,"url":"https://api.github.com/repos/ajaymathur/react-select","forks_url":"https://api.github.com/repos/ajaymathur/react-select/forks","keys_url":"https://api.github.com/repos/ajaymathur/react-select/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajaymathur/react-select/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajaymathur/react-select/teams","hooks_url":"https://api.github.com/repos/ajaymathur/react-select/hooks","issue_events_url":"https://api.github.com/repos/ajaymathur/react-select/issues/events{/number}","events_url":"https://api.github.com/repos/ajaymathur/react-select/events","assignees_url":"https://api.github.com/repos/ajaymathur/react-select/assignees{/user}","branches_url":"https://api.github.com/repos/ajaymathur/react-select/branches{/branch}","tags_url":"https://api.github.com/repos/ajaymathur/react-select/tags","blobs_url":"https://api.github.com/repos/ajaymathur/react-select/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajaymathur/react-select/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajaymathur/react-select/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajaymathur/react-select/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajaymathur/react-select/statuses/{sha}","languages_url":"https://api.github.com/repos/ajaymathur/react-select/languages","stargazers_url":"https://api.github.com/repos/ajaymathur/react-select/stargazers","contributors_url":"https://api.github.com/repos/ajaymathur/react-select/contributors","subscribers_url":"https://api.github.com/repos/ajaymathur/react-select/subscribers","subscription_url":"https://api.github.com/repos/ajaymathur/react-select/subscription","commits_url":"https://api.github.com/repos/ajaymathur/react-select/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajaymathur/react-select/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajaymathur/react-select/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajaymathur/react-select/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajaymathur/react-select/contents/{+path}","compare_url":"https://api.github.com/repos/ajaymathur/react-select/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajaymathur/react-select/merges","archive_url":"https://api.github.com/repos/ajaymathur/react-select/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajaymathur/react-select/downloads","issues_url":"https://api.github.com/repos/ajaymathur/react-select/issues{/number}","pulls_url":"https://api.github.com/repos/ajaymathur/react-select/pulls{/number}","milestones_url":"https://api.github.com/repos/ajaymathur/react-select/milestones{/number}","notifications_url":"https://api.github.com/repos/ajaymathur/react-select/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajaymathur/react-select/labels{/name}","releases_url":"https://api.github.com/repos/ajaymathur/react-select/releases{/id}","deployments_url":"https://api.github.com/repos/ajaymathur/react-select/deployments","created_at":"2018-03-14T02:02:03Z","updated_at":"2018-03-14T02:02:06Z","pushed_at":"2018-03-19T00:16:33Z","git_url":"git://github.com/ajaymathur/react-select.git","ssh_url":"git@github.com:ajaymathur/react-select.git","clone_url":"https://github.com/ajaymathur/react-select.git","svn_url":"https://github.com/ajaymathur/react-select","homepage":"http://jedwatson.github.io/react-select/","size":11913,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JedWatson:v2","ref":"v2","sha":"bf30b095a3a523cf8192f2fa817a28d752d9f039","user":{"login":"JedWatson","id":872310,"avatar_url":"https://avatars3.githubusercontent.com/u/872310?v=4","gravatar_id":"","url":"https://api.github.com/users/JedWatson","html_url":"https://github.com/JedWatson","followers_url":"https://api.github.com/users/JedWatson/followers","following_url":"https://api.github.com/users/JedWatson/following{/other_user}","gists_url":"https://api.github.com/users/JedWatson/gists{/gist_id}","starred_url":"https://api.github.com/users/JedWatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JedWatson/subscriptions","organizations_url":"https://api.github.com/users/JedWatson/orgs","repos_url":"https://api.github.com/users/JedWatson/repos","events_url":"https://api.github.com/users/JedWatson/events{/privacy}","received_events_url":"https://api.github.com/users/JedWatson/received_events","type":"User","site_admin":false},"repo":{"id":23338716,"name":"react-select","full_name":"JedWatson/react-select","owner":{"login":"JedWatson","id":872310,"avatar_url":"https://avatars3.githubusercontent.com/u/872310?v=4","gravatar_id":"","url":"https://api.github.com/users/JedWatson","html_url":"https://github.com/JedWatson","followers_url":"https://api.github.com/users/JedWatson/followers","following_url":"https://api.github.com/users/JedWatson/following{/other_user}","gists_url":"https://api.github.com/users/JedWatson/gists{/gist_id}","starred_url":"https://api.github.com/users/JedWatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JedWatson/subscriptions","organizations_url":"https://api.github.com/users/JedWatson/orgs","repos_url":"https://api.github.com/users/JedWatson/repos","events_url":"https://api.github.com/users/JedWatson/events{/privacy}","received_events_url":"https://api.github.com/users/JedWatson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JedWatson/react-select","description":"A Select control built with and for React JS","fork":false,"url":"https://api.github.com/repos/JedWatson/react-select","forks_url":"https://api.github.com/repos/JedWatson/react-select/forks","keys_url":"https://api.github.com/repos/JedWatson/react-select/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JedWatson/react-select/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JedWatson/react-select/teams","hooks_url":"https://api.github.com/repos/JedWatson/react-select/hooks","issue_events_url":"https://api.github.com/repos/JedWatson/react-select/issues/events{/number}","events_url":"https://api.github.com/repos/JedWatson/react-select/events","assignees_url":"https://api.github.com/repos/JedWatson/react-select/assignees{/user}","branches_url":"https://api.github.com/repos/JedWatson/react-select/branches{/branch}","tags_url":"https://api.github.com/repos/JedWatson/react-select/tags","blobs_url":"https://api.github.com/repos/JedWatson/react-select/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JedWatson/react-select/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JedWatson/react-select/git/refs{/sha}","trees_url":"https://api.github.com/repos/JedWatson/react-select/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JedWatson/react-select/statuses/{sha}","languages_url":"https://api.github.com/repos/JedWatson/react-select/languages","stargazers_url":"https://api.github.com/repos/JedWatson/react-select/stargazers","contributors_url":"https://api.github.com/repos/JedWatson/react-select/contributors","subscribers_url":"https://api.github.com/repos/JedWatson/react-select/subscribers","subscription_url":"https://api.github.com/repos/JedWatson/react-select/subscription","commits_url":"https://api.github.com/repos/JedWatson/react-select/commits{/sha}","git_commits_url":"https://api.github.com/repos/JedWatson/react-select/git/commits{/sha}","comments_url":"https://api.github.com/repos/JedWatson/react-select/comments{/number}","issue_comment_url":"https://api.github.com/repos/JedWatson/react-select/issues/comments{/number}","contents_url":"https://api.github.com/repos/JedWatson/react-select/contents/{+path}","compare_url":"https://api.github.com/repos/JedWatson/react-select/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JedWatson/react-select/merges","archive_url":"https://api.github.com/repos/JedWatson/react-select/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JedWatson/react-select/downloads","issues_url":"https://api.github.com/repos/JedWatson/react-select/issues{/number}","pulls_url":"https://api.github.com/repos/JedWatson/react-select/pulls{/number}","milestones_url":"https://api.github.com/repos/JedWatson/react-select/milestones{/number}","notifications_url":"https://api.github.com/repos/JedWatson/react-select/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JedWatson/react-select/labels{/name}","releases_url":"https://api.github.com/repos/JedWatson/react-select/releases{/id}","deployments_url":"https://api.github.com/repos/JedWatson/react-select/deployments","created_at":"2014-08-26T04:27:45Z","updated_at":"2018-03-18T17:45:21Z","pushed_at":"2018-03-19T00:16:39Z","git_url":"git://github.com/JedWatson/react-select.git","ssh_url":"git@github.com:JedWatson/react-select.git","clone_url":"https://github.com/JedWatson/react-select.git","svn_url":"https://github.com/JedWatson/react-select","homepage":"http://jedwatson.github.io/react-select/","size":11944,"stargazers_count":10828,"watchers_count":10828,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2407,"mirror_url":null,"archived":false,"open_issues_count":875,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2407,"open_issues":875,"watchers":10828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JedWatson/react-select/pulls/2436"},"html":{"href":"https://github.com/JedWatson/react-select/pull/2436"},"issue":{"href":"https://api.github.com/repos/JedWatson/react-select/issues/2436"},"comments":{"href":"https://api.github.com/repos/JedWatson/react-select/issues/2436/comments"},"review_comments":{"href":"https://api.github.com/repos/JedWatson/react-select/pulls/2436/comments"},"review_comment":{"href":"https://api.github.com/repos/JedWatson/react-select/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JedWatson/react-select/pulls/2436/commits"},"statuses":{"href":"https://api.github.com/repos/JedWatson/react-select/statuses/dcd670da0a6f7772ba90ad0772a5631410d10e37"}},"author_association":"NONE"}}
{"actor":{"display_login":"ajaymathur"}}