{"action":"created","issue":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3381","repository_url":"https://api.github.com/repos/input-output-hk/cardano-sl","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3381/labels{/name}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3381/comments","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3381/events","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3381","id":349543399,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NjM0MDcy","number":3381,"title":"[CBR-305] SafeCopy instances for InDb types","user":{"login":"k0001","id":3302,"node_id":"MDQ6VXNlcjMzMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/3302?v=4","gravatar_id":"","url":"https://api.github.com/users/k0001","html_url":"https://github.com/k0001","followers_url":"https://api.github.com/users/k0001/followers","following_url":"https://api.github.com/users/k0001/following{/other_user}","gists_url":"https://api.github.com/users/k0001/gists{/gist_id}","starred_url":"https://api.github.com/users/k0001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k0001/subscriptions","organizations_url":"https://api.github.com/users/k0001/orgs","repos_url":"https://api.github.com/users/k0001/repos","events_url":"https://api.github.com/users/k0001/events{/privacy}","received_events_url":"https://api.github.com/users/k0001/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-10T14:44:34Z","updated_at":"2018-08-23T07:10:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3381","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3381","diff_url":"https://github.com/input-output-hk/cardano-sl/pull/3381.diff","patch_url":"https://github.com/input-output-hk/cardano-sl/pull/3381.patch"},"body":"Some things to keep in mind:\r\n\r\n* Round-trip QuickCheck tests are missing.\r\n\r\n* The basic approach to defining instances for types wrapped in `InDb` is described in the code:\r\n\r\n   > -- Notice that when serializing and deserializing, a type like `InDb foo` will\r\n   > -- distribute `InDb` among the non-primitive types that make up `foo`. This\r\n   > -- choice doesn't show up in the types. \r\n\r\n* There are a lot of redundant type signatures. This is deliberate, so that changing the definition of a datatype in the future triggers a type-checker error if possible. "},"comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments/415314920","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3381#issuecomment-415314920","issue_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3381","id":415314920,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTMxNDkyMA==","user":{"login":"edsko","id":935288,"node_id":"MDQ6VXNlcjkzNTI4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/935288?v=4","gravatar_id":"","url":"https://api.github.com/users/edsko","html_url":"https://github.com/edsko","followers_url":"https://api.github.com/users/edsko/followers","following_url":"https://api.github.com/users/edsko/following{/other_user}","gists_url":"https://api.github.com/users/edsko/gists{/gist_id}","starred_url":"https://api.github.com/users/edsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsko/subscriptions","organizations_url":"https://api.github.com/users/edsko/orgs","repos_url":"https://api.github.com/users/edsko/repos","events_url":"https://api.github.com/users/edsko/events{/privacy}","received_events_url":"https://api.github.com/users/edsko/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T07:10:03Z","updated_at":"2018-08-23T07:10:03Z","author_association":"CONTRIBUTOR","body":"Fixed the tests. Are now going to rebase, then force push."}}
{"actor":{"display_login":"edsko"}}