{"action":"closed","number":40,"pull_request":{"url":"https://api.github.com/repos/next-step/java-ladder/pulls/40","id":233020505,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDIwNTA1","html_url":"https://github.com/next-step/java-ladder/pull/40","diff_url":"https://github.com/next-step/java-ladder/pull/40.diff","patch_url":"https://github.com/next-step/java-ladder/pull/40.patch","issue_url":"https://api.github.com/repos/next-step/java-ladder/issues/40","number":40,"state":"closed","locked":false,"title":"Step1 사다리게임 구현","user":{"login":"soulduse","id":11257459,"node_id":"MDQ6VXNlcjExMjU3NDU5","avatar_url":"https://avatars1.githubusercontent.com/u/11257459?v=4","gravatar_id":"","url":"https://api.github.com/users/soulduse","html_url":"https://github.com/soulduse","followers_url":"https://api.github.com/users/soulduse/followers","following_url":"https://api.github.com/users/soulduse/following{/other_user}","gists_url":"https://api.github.com/users/soulduse/gists{/gist_id}","starred_url":"https://api.github.com/users/soulduse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soulduse/subscriptions","organizations_url":"https://api.github.com/users/soulduse/orgs","repos_url":"https://api.github.com/users/soulduse/repos","events_url":"https://api.github.com/users/soulduse/events{/privacy}","received_events_url":"https://api.github.com/users/soulduse/received_events","type":"User","site_admin":false},"body":"## 문제를 보고 든 생각\r\n막상 바로 구현하려니 잘안되서, 어떻게하면 좋을지 설계하고, 고민하는데 이틀이 걸렸습니다 😢 \r\n보기엔 간단해보이는데 막상 구현하려니 어떻게 구현하면 좋을지 막막함을 느꼈습니다.\r\n\r\n## 진행하면서 어려웠던점\r\n- 작은 부분부터 보이지 않고 큰 부분을 덩어리채로 해결하려고해서 진도 빼기가 쉽지 않았음.\r\n- 코드를 짜다보면 나도모르게 프로덕트 코드를 먼저 작성하게 됨.\r\n- 알고리즘 사고가 부족한 느낌을 느낌.\r\n- 도저히 떠오르지 않는 설계는 다른 분들의 PR을 참고하게 되었는데, 최대한 안보고 하려고 참느라 고생.\r\n\r\n## 구현하고 난 후 느낀점\r\n수련이 많이 필요함을 느끼는 과제였습니다. (설계, 알고리즘, 테스트)\r\n테스트 코드 부터 짜려고 의식적으로 노력했지만 잘 안되서 TDD와 단위테스트 작성을 번갈아가면서\r\n진행하였습니다. 꾸준히 의식적인 학습을 할 수 있도록 노력 해야되겠다는 생각이 들었습니다.","created_at":"2018-11-22T15:45:32Z","updated_at":"2018-11-22T23:18:31Z","closed_at":"2018-11-22T23:18:31Z","merged_at":"2018-11-22T23:18:31Z","merge_commit_sha":"a440a7ad3271a905f529bbd2004d05bb7ce3b154","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/next-step/java-ladder/pulls/40/commits","review_comments_url":"https://api.github.com/repos/next-step/java-ladder/pulls/40/comments","review_comment_url":"https://api.github.com/repos/next-step/java-ladder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/next-step/java-ladder/issues/40/comments","statuses_url":"https://api.github.com/repos/next-step/java-ladder/statuses/ee82ee6fee8a64caed45f0fef3150d431ee1e77b","head":{"label":"soulduse:step1","ref":"step1","sha":"ee82ee6fee8a64caed45f0fef3150d431ee1e77b","user":{"login":"soulduse","id":11257459,"node_id":"MDQ6VXNlcjExMjU3NDU5","avatar_url":"https://avatars1.githubusercontent.com/u/11257459?v=4","gravatar_id":"","url":"https://api.github.com/users/soulduse","html_url":"https://github.com/soulduse","followers_url":"https://api.github.com/users/soulduse/followers","following_url":"https://api.github.com/users/soulduse/following{/other_user}","gists_url":"https://api.github.com/users/soulduse/gists{/gist_id}","starred_url":"https://api.github.com/users/soulduse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soulduse/subscriptions","organizations_url":"https://api.github.com/users/soulduse/orgs","repos_url":"https://api.github.com/users/soulduse/repos","events_url":"https://api.github.com/users/soulduse/events{/privacy}","received_events_url":"https://api.github.com/users/soulduse/received_events","type":"User","site_admin":false},"repo":{"id":158395752,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgzOTU3NTI=","name":"java-ladder","full_name":"soulduse/java-ladder","private":false,"owner":{"login":"soulduse","id":11257459,"node_id":"MDQ6VXNlcjExMjU3NDU5","avatar_url":"https://avatars1.githubusercontent.com/u/11257459?v=4","gravatar_id":"","url":"https://api.github.com/users/soulduse","html_url":"https://github.com/soulduse","followers_url":"https://api.github.com/users/soulduse/followers","following_url":"https://api.github.com/users/soulduse/following{/other_user}","gists_url":"https://api.github.com/users/soulduse/gists{/gist_id}","starred_url":"https://api.github.com/users/soulduse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soulduse/subscriptions","organizations_url":"https://api.github.com/users/soulduse/orgs","repos_url":"https://api.github.com/users/soulduse/repos","events_url":"https://api.github.com/users/soulduse/events{/privacy}","received_events_url":"https://api.github.com/users/soulduse/received_events","type":"User","site_admin":false},"html_url":"https://github.com/soulduse/java-ladder","description":"사다리 타기 구현을 위한 저장소","fork":true,"url":"https://api.github.com/repos/soulduse/java-ladder","forks_url":"https://api.github.com/repos/soulduse/java-ladder/forks","keys_url":"https://api.github.com/repos/soulduse/java-ladder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soulduse/java-ladder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soulduse/java-ladder/teams","hooks_url":"https://api.github.com/repos/soulduse/java-ladder/hooks","issue_events_url":"https://api.github.com/repos/soulduse/java-ladder/issues/events{/number}","events_url":"https://api.github.com/repos/soulduse/java-ladder/events","assignees_url":"https://api.github.com/repos/soulduse/java-ladder/assignees{/user}","branches_url":"https://api.github.com/repos/soulduse/java-ladder/branches{/branch}","tags_url":"https://api.github.com/repos/soulduse/java-ladder/tags","blobs_url":"https://api.github.com/repos/soulduse/java-ladder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soulduse/java-ladder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soulduse/java-ladder/git/refs{/sha}","trees_url":"https://api.github.com/repos/soulduse/java-ladder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soulduse/java-ladder/statuses/{sha}","languages_url":"https://api.github.com/repos/soulduse/java-ladder/languages","stargazers_url":"https://api.github.com/repos/soulduse/java-ladder/stargazers","contributors_url":"https://api.github.com/repos/soulduse/java-ladder/contributors","subscribers_url":"https://api.github.com/repos/soulduse/java-ladder/subscribers","subscription_url":"https://api.github.com/repos/soulduse/java-ladder/subscription","commits_url":"https://api.github.com/repos/soulduse/java-ladder/commits{/sha}","git_commits_url":"https://api.github.com/repos/soulduse/java-ladder/git/commits{/sha}","comments_url":"https://api.github.com/repos/soulduse/java-ladder/comments{/number}","issue_comment_url":"https://api.github.com/repos/soulduse/java-ladder/issues/comments{/number}","contents_url":"https://api.github.com/repos/soulduse/java-ladder/contents/{+path}","compare_url":"https://api.github.com/repos/soulduse/java-ladder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soulduse/java-ladder/merges","archive_url":"https://api.github.com/repos/soulduse/java-ladder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soulduse/java-ladder/downloads","issues_url":"https://api.github.com/repos/soulduse/java-ladder/issues{/number}","pulls_url":"https://api.github.com/repos/soulduse/java-ladder/pulls{/number}","milestones_url":"https://api.github.com/repos/soulduse/java-ladder/milestones{/number}","notifications_url":"https://api.github.com/repos/soulduse/java-ladder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soulduse/java-ladder/labels{/name}","releases_url":"https://api.github.com/repos/soulduse/java-ladder/releases{/id}","deployments_url":"https://api.github.com/repos/soulduse/java-ladder/deployments","created_at":"2018-11-20T13:42:10Z","updated_at":"2018-11-20T13:42:12Z","pushed_at":"2018-11-22T15:40:27Z","git_url":"git://github.com/soulduse/java-ladder.git","ssh_url":"git@github.com:soulduse/java-ladder.git","clone_url":"https://github.com/soulduse/java-ladder.git","svn_url":"https://github.com/soulduse/java-ladder","homepage":"","size":187,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"next-step:soulduse","ref":"soulduse","sha":"d561aafd5f9d196d1ab0516d4ff0452a3ba53bbf","user":{"login":"next-step","id":25274995,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mjc0OTk1","avatar_url":"https://avatars0.githubusercontent.com/u/25274995?v=4","gravatar_id":"","url":"https://api.github.com/users/next-step","html_url":"https://github.com/next-step","followers_url":"https://api.github.com/users/next-step/followers","following_url":"https://api.github.com/users/next-step/following{/other_user}","gists_url":"https://api.github.com/users/next-step/gists{/gist_id}","starred_url":"https://api.github.com/users/next-step/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/next-step/subscriptions","organizations_url":"https://api.github.com/users/next-step/orgs","repos_url":"https://api.github.com/users/next-step/repos","events_url":"https://api.github.com/users/next-step/events{/privacy}","received_events_url":"https://api.github.com/users/next-step/received_events","type":"Organization","site_admin":false},"repo":{"id":154407726,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ0MDc3MjY=","name":"java-ladder","full_name":"next-step/java-ladder","private":false,"owner":{"login":"next-step","id":25274995,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mjc0OTk1","avatar_url":"https://avatars0.githubusercontent.com/u/25274995?v=4","gravatar_id":"","url":"https://api.github.com/users/next-step","html_url":"https://github.com/next-step","followers_url":"https://api.github.com/users/next-step/followers","following_url":"https://api.github.com/users/next-step/following{/other_user}","gists_url":"https://api.github.com/users/next-step/gists{/gist_id}","starred_url":"https://api.github.com/users/next-step/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/next-step/subscriptions","organizations_url":"https://api.github.com/users/next-step/orgs","repos_url":"https://api.github.com/users/next-step/repos","events_url":"https://api.github.com/users/next-step/events{/privacy}","received_events_url":"https://api.github.com/users/next-step/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/next-step/java-ladder","description":"사다리 타기 구현을 위한 저장소","fork":false,"url":"https://api.github.com/repos/next-step/java-ladder","forks_url":"https://api.github.com/repos/next-step/java-ladder/forks","keys_url":"https://api.github.com/repos/next-step/java-ladder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/next-step/java-ladder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/next-step/java-ladder/teams","hooks_url":"https://api.github.com/repos/next-step/java-ladder/hooks","issue_events_url":"https://api.github.com/repos/next-step/java-ladder/issues/events{/number}","events_url":"https://api.github.com/repos/next-step/java-ladder/events","assignees_url":"https://api.github.com/repos/next-step/java-ladder/assignees{/user}","branches_url":"https://api.github.com/repos/next-step/java-ladder/branches{/branch}","tags_url":"https://api.github.com/repos/next-step/java-ladder/tags","blobs_url":"https://api.github.com/repos/next-step/java-ladder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/next-step/java-ladder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/next-step/java-ladder/git/refs{/sha}","trees_url":"https://api.github.com/repos/next-step/java-ladder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/next-step/java-ladder/statuses/{sha}","languages_url":"https://api.github.com/repos/next-step/java-ladder/languages","stargazers_url":"https://api.github.com/repos/next-step/java-ladder/stargazers","contributors_url":"https://api.github.com/repos/next-step/java-ladder/contributors","subscribers_url":"https://api.github.com/repos/next-step/java-ladder/subscribers","subscription_url":"https://api.github.com/repos/next-step/java-ladder/subscription","commits_url":"https://api.github.com/repos/next-step/java-ladder/commits{/sha}","git_commits_url":"https://api.github.com/repos/next-step/java-ladder/git/commits{/sha}","comments_url":"https://api.github.com/repos/next-step/java-ladder/comments{/number}","issue_comment_url":"https://api.github.com/repos/next-step/java-ladder/issues/comments{/number}","contents_url":"https://api.github.com/repos/next-step/java-ladder/contents/{+path}","compare_url":"https://api.github.com/repos/next-step/java-ladder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/next-step/java-ladder/merges","archive_url":"https://api.github.com/repos/next-step/java-ladder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/next-step/java-ladder/downloads","issues_url":"https://api.github.com/repos/next-step/java-ladder/issues{/number}","pulls_url":"https://api.github.com/repos/next-step/java-ladder/pulls{/number}","milestones_url":"https://api.github.com/repos/next-step/java-ladder/milestones{/number}","notifications_url":"https://api.github.com/repos/next-step/java-ladder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/next-step/java-ladder/labels{/name}","releases_url":"https://api.github.com/repos/next-step/java-ladder/releases{/id}","deployments_url":"https://api.github.com/repos/next-step/java-ladder/deployments","created_at":"2018-10-23T23:02:58Z","updated_at":"2018-10-23T23:17:52Z","pushed_at":"2018-11-22T23:18:31Z","git_url":"git://github.com/next-step/java-ladder.git","ssh_url":"git@github.com:next-step/java-ladder.git","clone_url":"https://github.com/next-step/java-ladder.git","svn_url":"https://github.com/next-step/java-ladder","homepage":"","size":271,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":19,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/next-step/java-ladder/pulls/40"},"html":{"href":"https://github.com/next-step/java-ladder/pull/40"},"issue":{"href":"https://api.github.com/repos/next-step/java-ladder/issues/40"},"comments":{"href":"https://api.github.com/repos/next-step/java-ladder/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/next-step/java-ladder/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/next-step/java-ladder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/next-step/java-ladder/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/next-step/java-ladder/statuses/ee82ee6fee8a64caed45f0fef3150d431ee1e77b"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"javajigi","id":520500,"node_id":"MDQ6VXNlcjUyMDUwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/520500?v=4","gravatar_id":"","url":"https://api.github.com/users/javajigi","html_url":"https://github.com/javajigi","followers_url":"https://api.github.com/users/javajigi/followers","following_url":"https://api.github.com/users/javajigi/following{/other_user}","gists_url":"https://api.github.com/users/javajigi/gists{/gist_id}","starred_url":"https://api.github.com/users/javajigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javajigi/subscriptions","organizations_url":"https://api.github.com/users/javajigi/orgs","repos_url":"https://api.github.com/users/javajigi/repos","events_url":"https://api.github.com/users/javajigi/events{/privacy}","received_events_url":"https://api.github.com/users/javajigi/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":301,"deletions":1,"changed_files":17}}
{"actor":{"display_login":"javajigi"}}