{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/211096860","pull_request_review_id":147452192,"id":211096860,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA5Njg2MA==","diff_hunk":"@@ -92,12 +98,17 @@ static void hwm_sleep_until_next_timer(void)\n \t\t/* LCOV_EXCL_STOP */\n \t}\n \n-\tif (signaled_end || (simu_time > end_of_time)) {\n+\t_SAFE_CALL(pthread_mutex_lock(&exit_mutex));\n+\tif (signaled_end || (simu_time > end_of_time) || hwm_exit_request) {\n+\t\tint exit_code = hwm_exit_request ? hwm_exit_code : 0;","path":"boards/posix/native_posix/hw_models_top.c","position":33,"original_position":33,"commit_id":"e3352d50a21eb690980e76d23ebaaa902ecc3269","original_commit_id":"e3352d50a21eb690980e76d23ebaaa902ecc3269","user":{"login":"aescolar","id":32480799,"node_id":"MDQ6VXNlcjMyNDgwNzk5","avatar_url":"https://avatars0.githubusercontent.com/u/32480799?v=4","gravatar_id":"","url":"https://api.github.com/users/aescolar","html_url":"https://github.com/aescolar","followers_url":"https://api.github.com/users/aescolar/followers","following_url":"https://api.github.com/users/aescolar/following{/other_user}","gists_url":"https://api.github.com/users/aescolar/gists{/gist_id}","starred_url":"https://api.github.com/users/aescolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aescolar/subscriptions","organizations_url":"https://api.github.com/users/aescolar/orgs","repos_url":"https://api.github.com/users/aescolar/repos","events_url":"https://api.github.com/users/aescolar/events{/privacy}","received_events_url":"https://api.github.com/users/aescolar/received_events","type":"User","site_admin":false},"body":"Minor: `hwm_exit_code` is 0 unless it was set differently in `hwm_main_loop_exit` (with `hwm_exit_request`). So you may as well have `int exit_code = hwm_exit_code;` (without the if), and add a comment instead if you feel its needed.","created_at":"2018-08-19T09:10:49Z","updated_at":"2018-08-19T09:54:22Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9149#discussion_r211096860","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9149","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/211096860"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/9149#discussion_r211096860"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9149"}}},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9149","id":204337385,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MzM3Mzg1","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9149","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9149.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9149.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9149","number":9149,"state":"open","locked":false,"title":" [DNM][RFC] SDL based display emulation driver","user":{"login":"vanwinkeljan","id":1586475,"node_id":"MDQ6VXNlcjE1ODY0NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1586475?v=4","gravatar_id":"","url":"https://api.github.com/users/vanwinkeljan","html_url":"https://github.com/vanwinkeljan","followers_url":"https://api.github.com/users/vanwinkeljan/followers","following_url":"https://api.github.com/users/vanwinkeljan/following{/other_user}","gists_url":"https://api.github.com/users/vanwinkeljan/gists{/gist_id}","starred_url":"https://api.github.com/users/vanwinkeljan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanwinkeljan/subscriptions","organizations_url":"https://api.github.com/users/vanwinkeljan/orgs","repos_url":"https://api.github.com/users/vanwinkeljan/repos","events_url":"https://api.github.com/users/vanwinkeljan/events{/privacy}","received_events_url":"https://api.github.com/users/vanwinkeljan/received_events","type":"User","site_admin":false},"body":"This driver introduces an emulated LCD display for the native POSIX board.\r\nThe emulated display driver makes use of SDL2 to render the displays frame\r\nbuffer into a dedicated desktop window.\r\n\r\nNote that only the last 2 commits are applicable for this pull request, the remaining 5 commits are part of open pull request where this one is depending on.\r\n\r\nBellow is a screenshot of the LVGL sample build and running for native_posix board:\r\n![sdl_display_driver](https://user-images.githubusercontent.com/1586475/43304139-2ca1d3f6-9173-11e8-9555-d77a9667a2c6.png)\r\n\r\n\r\n","created_at":"2018-07-27T06:04:59Z","updated_at":"2018-08-19T09:54:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"932b4c7ac49fa718092284dfa4ca94719552d5c8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nashif","id":180017,"node_id":"MDQ6VXNlcjE4MDAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":807706246,"node_id":"MDU6TGFiZWw4MDc3MDYyNDY=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/DNM","name":"DNM","color":"b60205","default":false},{"id":1010375198,"node_id":"MDU6TGFiZWwxMDEwMzc1MTk4","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20Display","name":"area: Display","color":"2fb5c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9149/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9149/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9149/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/e3352d50a21eb690980e76d23ebaaa902ecc3269","head":{"label":"vanwinkeljan:sdl_display","ref":"sdl_display","sha":"e3352d50a21eb690980e76d23ebaaa902ecc3269","user":{"login":"vanwinkeljan","id":1586475,"node_id":"MDQ6VXNlcjE1ODY0NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1586475?v=4","gravatar_id":"","url":"https://api.github.com/users/vanwinkeljan","html_url":"https://github.com/vanwinkeljan","followers_url":"https://api.github.com/users/vanwinkeljan/followers","following_url":"https://api.github.com/users/vanwinkeljan/following{/other_user}","gists_url":"https://api.github.com/users/vanwinkeljan/gists{/gist_id}","starred_url":"https://api.github.com/users/vanwinkeljan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanwinkeljan/subscriptions","organizations_url":"https://api.github.com/users/vanwinkeljan/orgs","repos_url":"https://api.github.com/users/vanwinkeljan/repos","events_url":"https://api.github.com/users/vanwinkeljan/events{/privacy}","received_events_url":"https://api.github.com/users/vanwinkeljan/received_events","type":"User","site_admin":false},"repo":{"id":102777565,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3Nzc1NjU=","name":"zephyr","full_name":"vanwinkeljan/zephyr","owner":{"login":"vanwinkeljan","id":1586475,"node_id":"MDQ6VXNlcjE1ODY0NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1586475?v=4","gravatar_id":"","url":"https://api.github.com/users/vanwinkeljan","html_url":"https://github.com/vanwinkeljan","followers_url":"https://api.github.com/users/vanwinkeljan/followers","following_url":"https://api.github.com/users/vanwinkeljan/following{/other_user}","gists_url":"https://api.github.com/users/vanwinkeljan/gists{/gist_id}","starred_url":"https://api.github.com/users/vanwinkeljan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanwinkeljan/subscriptions","organizations_url":"https://api.github.com/users/vanwinkeljan/orgs","repos_url":"https://api.github.com/users/vanwinkeljan/repos","events_url":"https://api.github.com/users/vanwinkeljan/events{/privacy}","received_events_url":"https://api.github.com/users/vanwinkeljan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vanwinkeljan/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/vanwinkeljan/zephyr","forks_url":"https://api.github.com/repos/vanwinkeljan/zephyr/forks","keys_url":"https://api.github.com/repos/vanwinkeljan/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanwinkeljan/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanwinkeljan/zephyr/teams","hooks_url":"https://api.github.com/repos/vanwinkeljan/zephyr/hooks","issue_events_url":"https://api.github.com/repos/vanwinkeljan/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/vanwinkeljan/zephyr/events","assignees_url":"https://api.github.com/repos/vanwinkeljan/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/vanwinkeljan/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/vanwinkeljan/zephyr/tags","blobs_url":"https://api.github.com/repos/vanwinkeljan/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanwinkeljan/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanwinkeljan/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanwinkeljan/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanwinkeljan/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/vanwinkeljan/zephyr/languages","stargazers_url":"https://api.github.com/repos/vanwinkeljan/zephyr/stargazers","contributors_url":"https://api.github.com/repos/vanwinkeljan/zephyr/contributors","subscribers_url":"https://api.github.com/repos/vanwinkeljan/zephyr/subscribers","subscription_url":"https://api.github.com/repos/vanwinkeljan/zephyr/subscription","commits_url":"https://api.github.com/repos/vanwinkeljan/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanwinkeljan/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanwinkeljan/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanwinkeljan/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanwinkeljan/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/vanwinkeljan/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanwinkeljan/zephyr/merges","archive_url":"https://api.github.com/repos/vanwinkeljan/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanwinkeljan/zephyr/downloads","issues_url":"https://api.github.com/repos/vanwinkeljan/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/vanwinkeljan/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/vanwinkeljan/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/vanwinkeljan/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanwinkeljan/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/vanwinkeljan/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/vanwinkeljan/zephyr/deployments","created_at":"2017-09-07T19:30:18Z","updated_at":"2018-07-26T19:30:09Z","pushed_at":"2018-08-18T20:56:16Z","git_url":"git://github.com/vanwinkeljan/zephyr.git","ssh_url":"git@github.com:vanwinkeljan/zephyr.git","clone_url":"https://github.com/vanwinkeljan/zephyr.git","svn_url":"https://github.com/vanwinkeljan/zephyr","homepage":"http://zephyrproject.org/doc","size":125802,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"wip"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"ca12b3f7d414ac1b45d4c13e51fc9253187afd1e","user":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc3MTQyNQ==","name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-08-18T21:23:03Z","pushed_at":"2018-08-18T21:22:12Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":128324,"stargazers_count":1094,"watchers_count":1094,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":753,"mirror_url":null,"archived":false,"open_issues_count":1000,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":753,"open_issues":1000,"watchers":1094,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9149"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/9149"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9149"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9149/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9149/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9149/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/e3352d50a21eb690980e76d23ebaaa902ecc3269"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aescolar"}}