{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonarqube/pulls/comments/172846091","pull_request_review_id":101932024,"id":172846091,"diff_hunk":"@@ -0,0 +1,53 @@\n+sonarqube {\n+  properties {\n+    property 'sonar.projectName', \"${projectTitle} :: Core\"\n+  }\n+}\n+\n+configurations {\n+  includeInResources\n+}\n+\n+dependencies {\n+  compileOnly 'com.google.code.findbugs:jsr305'\n+  compile 'commons-codec:commons-codec'\n+  compile 'org.apache.commons:commons-csv'\n+  compile 'org.picocontainer:picocontainer'\n+  compile 'com.google.protobuf:protobuf-java'\n+  compile 'org.codehaus.sonar:sonar-classloader'\n+  compile project(path: ':sonar-plugin-api', configuration: 'shadow')\n+  compile 'org.sonarsource.update-center:sonar-update-center-common'\n+  compile 'org.slf4j:slf4j-api'\n+  compile 'ch.qos.logback:logback-classic'\n+  compile 'ch.qos.logback:logback-core'\n+\n+  includeInResources project(path: ':sonar-plugin-api-deps', configuration: 'shadow')\n+\n+  testCompile 'junit:junit'\n+  testCompile 'org.assertj:assertj-core'\n+  testCompile 'com.tngtech.java:junit-dataprovider'\n+  testCompile 'org.mockito:mockito-core'\n+  testCompile project(':sonar-testing-harness')\n+  testCompile 'org.simpleframework:simple:4.1.21'","path":"sonar-core/build.gradle","position":31,"original_position":31,"commit_id":"f477614b055d6a82842c87be93f3fda84e7f7f14","original_commit_id":"f477614b055d6a82842c87be93f3fda84e7f7f14","user":{"login":"drautureau-sonarsource","id":19146731,"avatar_url":"https://avatars3.githubusercontent.com/u/19146731?v=4","gravatar_id":"","url":"https://api.github.com/users/drautureau-sonarsource","html_url":"https://github.com/drautureau-sonarsource","followers_url":"https://api.github.com/users/drautureau-sonarsource/followers","following_url":"https://api.github.com/users/drautureau-sonarsource/following{/other_user}","gists_url":"https://api.github.com/users/drautureau-sonarsource/gists{/gist_id}","starred_url":"https://api.github.com/users/drautureau-sonarsource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drautureau-sonarsource/subscriptions","organizations_url":"https://api.github.com/users/drautureau-sonarsource/orgs","repos_url":"https://api.github.com/users/drautureau-sonarsource/repos","events_url":"https://api.github.com/users/drautureau-sonarsource/events{/privacy}","received_events_url":"https://api.github.com/users/drautureau-sonarsource/received_events","type":"User","site_admin":false},"body":"No good reason. It is used only in this subprojects, but let's follow best practice : use `dependencyManagment`!\r\nI am fixing it","created_at":"2018-03-07T13:49:35Z","updated_at":"2018-03-07T13:49:35Z","html_url":"https://github.com/SonarSource/sonarqube/pull/3105#discussion_r172846091","pull_request_url":"https://api.github.com/repos/SonarSource/sonarqube/pulls/3105","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonarqube/pulls/comments/172846091"},"html":{"href":"https://github.com/SonarSource/sonarqube/pull/3105#discussion_r172846091"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonarqube/pulls/3105"}},"in_reply_to_id":172827627},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonarqube/pulls/3105","id":171663110,"html_url":"https://github.com/SonarSource/sonarqube/pull/3105","diff_url":"https://github.com/SonarSource/sonarqube/pull/3105.diff","patch_url":"https://github.com/SonarSource/sonarqube/pull/3105.patch","issue_url":"https://api.github.com/repos/SonarSource/sonarqube/issues/3105","number":3105,"state":"open","locked":false,"title":"Use Gradle instead of Maven","user":{"login":"drautureau-sonarsource","id":19146731,"avatar_url":"https://avatars3.githubusercontent.com/u/19146731?v=4","gravatar_id":"","url":"https://api.github.com/users/drautureau-sonarsource","html_url":"https://github.com/drautureau-sonarsource","followers_url":"https://api.github.com/users/drautureau-sonarsource/followers","following_url":"https://api.github.com/users/drautureau-sonarsource/following{/other_user}","gists_url":"https://api.github.com/users/drautureau-sonarsource/gists{/gist_id}","starred_url":"https://api.github.com/users/drautureau-sonarsource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drautureau-sonarsource/subscriptions","organizations_url":"https://api.github.com/users/drautureau-sonarsource/orgs","repos_url":"https://api.github.com/users/drautureau-sonarsource/repos","events_url":"https://api.github.com/users/drautureau-sonarsource/events{/privacy}","received_events_url":"https://api.github.com/users/drautureau-sonarsource/received_events","type":"User","site_admin":false},"body":"What still needs to be done:\r\n* apply Java plugin only for Java projects (may be done later on)\r\n* check of license headers (will be done later on)\r\n","created_at":"2018-02-27T13:32:49Z","updated_at":"2018-03-07T13:49:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30d6d0d7f23cd34139b5e6e7dfc3d44a65a67aa1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonarqube/pulls/3105/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonarqube/pulls/3105/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonarqube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sonarqube/issues/3105/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonarqube/statuses/f477614b055d6a82842c87be93f3fda84e7f7f14","head":{"label":"SonarSource:feature/dr/gradle","ref":"feature/dr/gradle","sha":"f477614b055d6a82842c87be93f3fda84e7f7f14","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":1222504,"name":"sonarqube","full_name":"SonarSource/sonarqube","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonarqube","description":"Continuous Code Quality","fork":false,"url":"https://api.github.com/repos/SonarSource/sonarqube","forks_url":"https://api.github.com/repos/SonarSource/sonarqube/forks","keys_url":"https://api.github.com/repos/SonarSource/sonarqube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonarqube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonarqube/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonarqube/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonarqube/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonarqube/events","assignees_url":"https://api.github.com/repos/SonarSource/sonarqube/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonarqube/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonarqube/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonarqube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonarqube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonarqube/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonarqube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonarqube/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonarqube/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonarqube/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonarqube/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonarqube/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonarqube/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonarqube/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonarqube/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonarqube/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonarqube/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonarqube/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonarqube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonarqube/merges","archive_url":"https://api.github.com/repos/SonarSource/sonarqube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonarqube/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonarqube/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonarqube/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonarqube/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonarqube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonarqube/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonarqube/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sonarqube/deployments","created_at":"2011-01-05T11:05:17Z","updated_at":"2018-03-07T12:04:31Z","pushed_at":"2018-03-07T13:38:48Z","git_url":"git://github.com/SonarSource/sonarqube.git","ssh_url":"git@github.com:SonarSource/sonarqube.git","clone_url":"https://github.com/SonarSource/sonarqube.git","svn_url":"https://github.com/SonarSource/sonarqube","homepage":"http://www.sonarqube.org","size":274786,"stargazers_count":2463,"watchers_count":2463,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":805,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":805,"open_issues":24,"watchers":2463,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"59c992d35dc045d829ef82a592e2576e98873467","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":1222504,"name":"sonarqube","full_name":"SonarSource/sonarqube","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonarqube","description":"Continuous Code Quality","fork":false,"url":"https://api.github.com/repos/SonarSource/sonarqube","forks_url":"https://api.github.com/repos/SonarSource/sonarqube/forks","keys_url":"https://api.github.com/repos/SonarSource/sonarqube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonarqube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonarqube/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonarqube/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonarqube/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonarqube/events","assignees_url":"https://api.github.com/repos/SonarSource/sonarqube/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonarqube/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonarqube/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonarqube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonarqube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonarqube/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonarqube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonarqube/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonarqube/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonarqube/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonarqube/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonarqube/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonarqube/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonarqube/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonarqube/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonarqube/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonarqube/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonarqube/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonarqube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonarqube/merges","archive_url":"https://api.github.com/repos/SonarSource/sonarqube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonarqube/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonarqube/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonarqube/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonarqube/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonarqube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonarqube/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonarqube/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sonarqube/deployments","created_at":"2011-01-05T11:05:17Z","updated_at":"2018-03-07T12:04:31Z","pushed_at":"2018-03-07T13:38:48Z","git_url":"git://github.com/SonarSource/sonarqube.git","ssh_url":"git@github.com:SonarSource/sonarqube.git","clone_url":"https://github.com/SonarSource/sonarqube.git","svn_url":"https://github.com/SonarSource/sonarqube","homepage":"http://www.sonarqube.org","size":274786,"stargazers_count":2463,"watchers_count":2463,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":805,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":805,"open_issues":24,"watchers":2463,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonarqube/pulls/3105"},"html":{"href":"https://github.com/SonarSource/sonarqube/pull/3105"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonarqube/issues/3105"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonarqube/issues/3105/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonarqube/pulls/3105/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonarqube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonarqube/pulls/3105/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonarqube/statuses/f477614b055d6a82842c87be93f3fda84e7f7f14"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"drautureau-sonarsource"}}