{"action":"created","issue":{"url":"https://api.github.com/repos/shopware/shopware/issues/1878","repository_url":"https://api.github.com/repos/shopware/shopware","labels_url":"https://api.github.com/repos/shopware/shopware/issues/1878/labels{/name}","comments_url":"https://api.github.com/repos/shopware/shopware/issues/1878/comments","events_url":"https://api.github.com/repos/shopware/shopware/issues/1878/events","html_url":"https://github.com/shopware/shopware/pull/1878","id":379077510,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NjI4MTMw","number":1878,"title":"Readonly attributes in Backend","user":{"login":"pascalheidman-bedarf","id":25795962,"node_id":"MDQ6VXNlcjI1Nzk1OTYy","avatar_url":"https://avatars1.githubusercontent.com/u/25795962?v=4","gravatar_id":"","url":"https://api.github.com/users/pascalheidman-bedarf","html_url":"https://github.com/pascalheidman-bedarf","followers_url":"https://api.github.com/users/pascalheidman-bedarf/followers","following_url":"https://api.github.com/users/pascalheidman-bedarf/following{/other_user}","gists_url":"https://api.github.com/users/pascalheidman-bedarf/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalheidman-bedarf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalheidman-bedarf/subscriptions","organizations_url":"https://api.github.com/users/pascalheidman-bedarf/orgs","repos_url":"https://api.github.com/users/pascalheidman-bedarf/repos","events_url":"https://api.github.com/users/pascalheidman-bedarf/events{/privacy}","received_events_url":"https://api.github.com/users/pascalheidman-bedarf/received_events","type":"User","site_admin":false},"labels":[{"id":571966309,"node_id":"MDU6TGFiZWw1NzE5NjYzMDk=","url":"https://api.github.com/repos/shopware/shopware/labels/Incomplete","name":"Incomplete","color":"cccccc","default":false},{"id":318046718,"node_id":"MDU6TGFiZWwzMTgwNDY3MTg=","url":"https://api.github.com/repos/shopware/shopware/labels/Scheduled","name":"Scheduled","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":{"login":"Pmuckel","id":9824141,"node_id":"MDQ6VXNlcjk4MjQxNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/9824141?v=4","gravatar_id":"","url":"https://api.github.com/users/Pmuckel","html_url":"https://github.com/Pmuckel","followers_url":"https://api.github.com/users/Pmuckel/followers","following_url":"https://api.github.com/users/Pmuckel/following{/other_user}","gists_url":"https://api.github.com/users/Pmuckel/gists{/gist_id}","starred_url":"https://api.github.com/users/Pmuckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pmuckel/subscriptions","organizations_url":"https://api.github.com/users/Pmuckel/orgs","repos_url":"https://api.github.com/users/Pmuckel/repos","events_url":"https://api.github.com/users/Pmuckel/events{/privacy}","received_events_url":"https://api.github.com/users/Pmuckel/received_events","type":"User","site_admin":false},"assignees":[{"login":"Pmuckel","id":9824141,"node_id":"MDQ6VXNlcjk4MjQxNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/9824141?v=4","gravatar_id":"","url":"https://api.github.com/users/Pmuckel","html_url":"https://github.com/Pmuckel","followers_url":"https://api.github.com/users/Pmuckel/followers","following_url":"https://api.github.com/users/Pmuckel/following{/other_user}","gists_url":"https://api.github.com/users/Pmuckel/gists{/gist_id}","starred_url":"https://api.github.com/users/Pmuckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pmuckel/subscriptions","organizations_url":"https://api.github.com/users/Pmuckel/orgs","repos_url":"https://api.github.com/users/Pmuckel/repos","events_url":"https://api.github.com/users/Pmuckel/events{/privacy}","received_events_url":"https://api.github.com/users/Pmuckel/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2018-11-09T09:04:06Z","updated_at":"2018-11-29T14:57:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/shopware/shopware/pulls/1878","html_url":"https://github.com/shopware/shopware/pull/1878","diff_url":"https://github.com/shopware/shopware/pull/1878.diff","patch_url":"https://github.com/shopware/shopware/pull/1878.patch"},"body":"### 1. Why is this change necessary?\r\nSometimes you want to add a attribute that should not be editable for your users but still visible in backend. This allows to make that attribute be readonly.\r\n\r\n### 2. What does this change do, exactly?\r\nAdding a new attribute configuration option that marks that attribute as readonly. This setting is then used to disable the input field in extjs. Therefore changes by code are of course still possible\r\n\r\n### 3. Describe each step to reproduce the issue or behaviour.\r\n\r\n### 4. Please link to the relevant issues (if any).\r\nPR https://github.com/shopware/shopware/pull/1645\r\nhttps://issues.shopware.com/issues/SW-21676\r\n\r\n### 5. Which documentation changes (if any) need to be made because of this PR?\r\nNew option \"readonly\" for attribute cru(d).\r\n\r\n### 6. Checklist\r\n\r\n- [ ] I have written tests and verified that they fail without my change\r\n- [x] I have squashed any insignificant commits\r\n- [ ] This change has comments for package types, values, functions, and non-obvious lines of code\r\n- [x] I have read the contribution requirements and fulfil them."},"comment":{"url":"https://api.github.com/repos/shopware/shopware/issues/comments/442863242","html_url":"https://github.com/shopware/shopware/pull/1878#issuecomment-442863242","issue_url":"https://api.github.com/repos/shopware/shopware/issues/1878","id":442863242,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mjg2MzI0Mg==","user":{"login":"pascalheidman-bedarf","id":25795962,"node_id":"MDQ6VXNlcjI1Nzk1OTYy","avatar_url":"https://avatars1.githubusercontent.com/u/25795962?v=4","gravatar_id":"","url":"https://api.github.com/users/pascalheidman-bedarf","html_url":"https://github.com/pascalheidman-bedarf","followers_url":"https://api.github.com/users/pascalheidman-bedarf/followers","following_url":"https://api.github.com/users/pascalheidman-bedarf/following{/other_user}","gists_url":"https://api.github.com/users/pascalheidman-bedarf/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalheidman-bedarf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalheidman-bedarf/subscriptions","organizations_url":"https://api.github.com/users/pascalheidman-bedarf/orgs","repos_url":"https://api.github.com/users/pascalheidman-bedarf/repos","events_url":"https://api.github.com/users/pascalheidman-bedarf/events{/privacy}","received_events_url":"https://api.github.com/users/pascalheidman-bedarf/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T14:57:29Z","updated_at":"2018-11-29T14:57:29Z","author_association":"CONTRIBUTOR","body":"@shopwareBot the 5.6 branch isn't up to date is it?\r\n\r\nNeither my local repo nor github find any missing commits and this would explain why `shopware/engine/Shopware/Controllers/Backend/Analytics.php` always fails in Travis CI"}}
{"actor":{"display_login":"pascalheidman-bedarf"}}