{"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/navi/pulls/comments/232308552","pull_request_review_id":173482304,"id":232308552,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjMwODU1Mg==","diff_hunk":"@@ -0,0 +1,56 @@\n+/**\n+ * Copyright 2018, Yahoo Holdings Inc.\n+ * Licensed under the terms of the MIT license. See accompanying LICENSE.md file for terms.\n+ *\n+ * Usage:\n+ *   {{filter-values/date\n+ *       filter=filter\n+ *       request=request\n+ *       onUpdateFilter=(action 'update')\n+ *   }}\n+ */\n+import Component from '@ember/component';\n+import Moment from 'moment';\n+import layout from '../../templates/components/filter-values/date';\n+import { computed, get } from '@ember/object';\n+\n+export default Component.extend({\n+  layout,\n+\n+  /**\n+   * @property {Array} classNames\n+   */\n+  classNames: ['date'],\n+\n+  /**\n+   * @property {Moment} selectedDate - local moment set by date picker\n+   */\n+  selectedDate: null,","path":"packages/reports/addon/components/filter-values/date.js","position":28,"original_position":28,"commit_id":"25aee366d5ba81fd2b317c25eb8b705b1f1fb341","original_commit_id":"25aee366d5ba81fd2b317c25eb8b705b1f1fb341","user":{"login":"mattgraham1995","id":23023478,"node_id":"MDQ6VXNlcjIzMDIzNDc4","avatar_url":"https://avatars1.githubusercontent.com/u/23023478?v=4","gravatar_id":"","url":"https://api.github.com/users/mattgraham1995","html_url":"https://github.com/mattgraham1995","followers_url":"https://api.github.com/users/mattgraham1995/followers","following_url":"https://api.github.com/users/mattgraham1995/following{/other_user}","gists_url":"https://api.github.com/users/mattgraham1995/gists{/gist_id}","starred_url":"https://api.github.com/users/mattgraham1995/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattgraham1995/subscriptions","organizations_url":"https://api.github.com/users/mattgraham1995/orgs","repos_url":"https://api.github.com/users/mattgraham1995/repos","events_url":"https://api.github.com/users/mattgraham1995/events{/privacy}","received_events_url":"https://api.github.com/users/mattgraham1995/received_events","type":"User","site_admin":false},"body":"Should it be considered private if its passed down to a child component?","created_at":"2018-11-09T16:16:42Z","updated_at":"2018-11-09T16:16:42Z","html_url":"https://github.com/yahoo/navi/pull/254#discussion_r232308552","pull_request_url":"https://api.github.com/repos/yahoo/navi/pulls/254","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yahoo/navi/pulls/comments/232308552"},"html":{"href":"https://github.com/yahoo/navi/pull/254#discussion_r232308552"},"pull_request":{"href":"https://api.github.com/repos/yahoo/navi/pulls/254"}},"in_reply_to_id":232052883},"pull_request":{"url":"https://api.github.com/repos/yahoo/navi/pulls/254","id":228068308,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDY4MzA4","html_url":"https://github.com/yahoo/navi/pull/254","diff_url":"https://github.com/yahoo/navi/pull/254.diff","patch_url":"https://github.com/yahoo/navi/pull/254.patch","issue_url":"https://api.github.com/repos/yahoo/navi/issues/254","number":254,"state":"open","locked":false,"title":"Update: Add date filter value for selecting single date","user":{"login":"mattgraham1995","id":23023478,"node_id":"MDQ6VXNlcjIzMDIzNDc4","avatar_url":"https://avatars1.githubusercontent.com/u/23023478?v=4","gravatar_id":"","url":"https://api.github.com/users/mattgraham1995","html_url":"https://github.com/mattgraham1995","followers_url":"https://api.github.com/users/mattgraham1995/followers","following_url":"https://api.github.com/users/mattgraham1995/following{/other_user}","gists_url":"https://api.github.com/users/mattgraham1995/gists{/gist_id}","starred_url":"https://api.github.com/users/mattgraham1995/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattgraham1995/subscriptions","organizations_url":"https://api.github.com/users/mattgraham1995/orgs","repos_url":"https://api.github.com/users/mattgraham1995/repos","events_url":"https://api.github.com/users/mattgraham1995/events{/privacy}","received_events_url":"https://api.github.com/users/mattgraham1995/received_events","type":"User","site_admin":false},"body":"Splitting up PR #253 \r\n\r\n![screen shot 2018-11-02 at 11 24 40 am](https://user-images.githubusercontent.com/23023478/47942386-be710d80-debf-11e8-9986-2dacf80eaea1.png)\r\n\r\nSingle date selection filter value","created_at":"2018-11-02T21:53:24Z","updated_at":"2018-11-09T16:16:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"babc834256c59bf31a97ef030f513fbd15805ad4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/navi/pulls/254/commits","review_comments_url":"https://api.github.com/repos/yahoo/navi/pulls/254/comments","review_comment_url":"https://api.github.com/repos/yahoo/navi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/navi/issues/254/comments","statuses_url":"https://api.github.com/repos/yahoo/navi/statuses/25aee366d5ba81fd2b317c25eb8b705b1f1fb341","head":{"label":"yahoo:dateFilterValue","ref":"dateFilterValue","sha":"25aee366d5ba81fd2b317c25eb8b705b1f1fb341","user":{"login":"yahoo","id":16574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":101244961,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNDQ5NjE=","name":"navi","full_name":"yahoo/navi","private":false,"owner":{"login":"yahoo","id":16574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yahoo/navi","description":"Navi is a production quality analytics reporting UI with out of the box support for Fili.","fork":false,"url":"https://api.github.com/repos/yahoo/navi","forks_url":"https://api.github.com/repos/yahoo/navi/forks","keys_url":"https://api.github.com/repos/yahoo/navi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/navi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/navi/teams","hooks_url":"https://api.github.com/repos/yahoo/navi/hooks","issue_events_url":"https://api.github.com/repos/yahoo/navi/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/navi/events","assignees_url":"https://api.github.com/repos/yahoo/navi/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/navi/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/navi/tags","blobs_url":"https://api.github.com/repos/yahoo/navi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/navi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/navi/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/navi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/navi/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/navi/languages","stargazers_url":"https://api.github.com/repos/yahoo/navi/stargazers","contributors_url":"https://api.github.com/repos/yahoo/navi/contributors","subscribers_url":"https://api.github.com/repos/yahoo/navi/subscribers","subscription_url":"https://api.github.com/repos/yahoo/navi/subscription","commits_url":"https://api.github.com/repos/yahoo/navi/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/navi/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/navi/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/navi/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/navi/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/navi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/navi/merges","archive_url":"https://api.github.com/repos/yahoo/navi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/navi/downloads","issues_url":"https://api.github.com/repos/yahoo/navi/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/navi/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/navi/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/navi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/navi/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/navi/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/navi/deployments","created_at":"2017-08-24T02:24:36Z","updated_at":"2018-11-08T20:22:19Z","pushed_at":"2018-11-09T03:28:14Z","git_url":"git://github.com/yahoo/navi.git","ssh_url":"git@github.com:yahoo/navi.git","clone_url":"https://github.com/yahoo/navi.git","svn_url":"https://github.com/yahoo/navi","homepage":"https://yahoo.github.io/navi","size":4658,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":83,"watchers":23,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"7a4068a7a55074d6390e44dc18ce26e758ca32a4","user":{"login":"yahoo","id":16574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":101244961,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNDQ5NjE=","name":"navi","full_name":"yahoo/navi","private":false,"owner":{"login":"yahoo","id":16574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yahoo/navi","description":"Navi is a production quality analytics reporting UI with out of the box support for Fili.","fork":false,"url":"https://api.github.com/repos/yahoo/navi","forks_url":"https://api.github.com/repos/yahoo/navi/forks","keys_url":"https://api.github.com/repos/yahoo/navi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/navi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/navi/teams","hooks_url":"https://api.github.com/repos/yahoo/navi/hooks","issue_events_url":"https://api.github.com/repos/yahoo/navi/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/navi/events","assignees_url":"https://api.github.com/repos/yahoo/navi/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/navi/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/navi/tags","blobs_url":"https://api.github.com/repos/yahoo/navi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/navi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/navi/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/navi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/navi/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/navi/languages","stargazers_url":"https://api.github.com/repos/yahoo/navi/stargazers","contributors_url":"https://api.github.com/repos/yahoo/navi/contributors","subscribers_url":"https://api.github.com/repos/yahoo/navi/subscribers","subscription_url":"https://api.github.com/repos/yahoo/navi/subscription","commits_url":"https://api.github.com/repos/yahoo/navi/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/navi/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/navi/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/navi/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/navi/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/navi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/navi/merges","archive_url":"https://api.github.com/repos/yahoo/navi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/navi/downloads","issues_url":"https://api.github.com/repos/yahoo/navi/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/navi/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/navi/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/navi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/navi/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/navi/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/navi/deployments","created_at":"2017-08-24T02:24:36Z","updated_at":"2018-11-08T20:22:19Z","pushed_at":"2018-11-09T03:28:14Z","git_url":"git://github.com/yahoo/navi.git","ssh_url":"git@github.com:yahoo/navi.git","clone_url":"https://github.com/yahoo/navi.git","svn_url":"https://github.com/yahoo/navi","homepage":"https://yahoo.github.io/navi","size":4658,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":83,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/navi/pulls/254"},"html":{"href":"https://github.com/yahoo/navi/pull/254"},"issue":{"href":"https://api.github.com/repos/yahoo/navi/issues/254"},"comments":{"href":"https://api.github.com/repos/yahoo/navi/issues/254/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/navi/pulls/254/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/navi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/navi/pulls/254/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/navi/statuses/25aee366d5ba81fd2b317c25eb8b705b1f1fb341"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mattgraham1995"}}