{"action":"opened","number":36357,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/36357","id":169814308,"html_url":"https://github.com/ansible/ansible/pull/36357","diff_url":"https://github.com/ansible/ansible/pull/36357.diff","patch_url":"https://github.com/ansible/ansible/pull/36357.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/36357","number":36357,"state":"open","locked":false,"title":"[WIP] Generalize loading vars files from dir (fixes #14248 and #11639)","user":{"login":"agaffney","id":825875,"avatar_url":"https://avatars2.githubusercontent.com/u/825875?v=4","gravatar_id":"","url":"https://api.github.com/users/agaffney","html_url":"https://github.com/agaffney","followers_url":"https://api.github.com/users/agaffney/followers","following_url":"https://api.github.com/users/agaffney/following{/other_user}","gists_url":"https://api.github.com/users/agaffney/gists{/gist_id}","starred_url":"https://api.github.com/users/agaffney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agaffney/subscriptions","organizations_url":"https://api.github.com/users/agaffney/orgs","repos_url":"https://api.github.com/users/agaffney/repos","events_url":"https://api.github.com/users/agaffney/events{/privacy}","received_events_url":"https://api.github.com/users/agaffney/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nThis commit moves code to look for vars files/dirs to a common place and uses it for loading role defaults/vars. This allows things such as `defaults/main` or `vars/main` being a directory in a role, allowing splitting of defaults/vars into multiple files.\r\n\r\nThis fixes #14248 and #11639.\r\n\r\n##### ISSUE TYPE\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\nvars loading\r\n\r\n##### ANSIBLE VERSION\r\nN/A\r\n\r\n##### ADDITIONAL INFORMATION\r\nN/A","created_at":"2018-02-18T04:22:37Z","updated_at":"2018-02-18T04:22:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/36357/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/36357/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/36357/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/d3776abbf314f9370b88c60bfbdebd6291362c75","head":{"label":"agaffney:role_defaults_vars_dirs","ref":"role_defaults_vars_dirs","sha":"d3776abbf314f9370b88c60bfbdebd6291362c75","user":{"login":"agaffney","id":825875,"avatar_url":"https://avatars2.githubusercontent.com/u/825875?v=4","gravatar_id":"","url":"https://api.github.com/users/agaffney","html_url":"https://github.com/agaffney","followers_url":"https://api.github.com/users/agaffney/followers","following_url":"https://api.github.com/users/agaffney/following{/other_user}","gists_url":"https://api.github.com/users/agaffney/gists{/gist_id}","starred_url":"https://api.github.com/users/agaffney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agaffney/subscriptions","organizations_url":"https://api.github.com/users/agaffney/orgs","repos_url":"https://api.github.com/users/agaffney/repos","events_url":"https://api.github.com/users/agaffney/events{/privacy}","received_events_url":"https://api.github.com/users/agaffney/received_events","type":"User","site_admin":false},"repo":{"id":48208523,"name":"ansible","full_name":"agaffney/ansible","owner":{"login":"agaffney","id":825875,"avatar_url":"https://avatars2.githubusercontent.com/u/825875?v=4","gravatar_id":"","url":"https://api.github.com/users/agaffney","html_url":"https://github.com/agaffney","followers_url":"https://api.github.com/users/agaffney/followers","following_url":"https://api.github.com/users/agaffney/following{/other_user}","gists_url":"https://api.github.com/users/agaffney/gists{/gist_id}","starred_url":"https://api.github.com/users/agaffney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agaffney/subscriptions","organizations_url":"https://api.github.com/users/agaffney/orgs","repos_url":"https://api.github.com/users/agaffney/repos","events_url":"https://api.github.com/users/agaffney/events{/privacy}","received_events_url":"https://api.github.com/users/agaffney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agaffney/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/agaffney/ansible","forks_url":"https://api.github.com/repos/agaffney/ansible/forks","keys_url":"https://api.github.com/repos/agaffney/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agaffney/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agaffney/ansible/teams","hooks_url":"https://api.github.com/repos/agaffney/ansible/hooks","issue_events_url":"https://api.github.com/repos/agaffney/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/agaffney/ansible/events","assignees_url":"https://api.github.com/repos/agaffney/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/agaffney/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/agaffney/ansible/tags","blobs_url":"https://api.github.com/repos/agaffney/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agaffney/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agaffney/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/agaffney/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agaffney/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/agaffney/ansible/languages","stargazers_url":"https://api.github.com/repos/agaffney/ansible/stargazers","contributors_url":"https://api.github.com/repos/agaffney/ansible/contributors","subscribers_url":"https://api.github.com/repos/agaffney/ansible/subscribers","subscription_url":"https://api.github.com/repos/agaffney/ansible/subscription","commits_url":"https://api.github.com/repos/agaffney/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/agaffney/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/agaffney/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/agaffney/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/agaffney/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/agaffney/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agaffney/ansible/merges","archive_url":"https://api.github.com/repos/agaffney/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agaffney/ansible/downloads","issues_url":"https://api.github.com/repos/agaffney/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/agaffney/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/agaffney/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/agaffney/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agaffney/ansible/labels{/name}","releases_url":"https://api.github.com/repos/agaffney/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/agaffney/ansible/deployments","created_at":"2015-12-18T01:54:26Z","updated_at":"2016-06-19T19:16:50Z","pushed_at":"2018-02-18T04:18:22Z","git_url":"git://github.com/agaffney/ansible.git","ssh_url":"git@github.com:agaffney/ansible.git","clone_url":"https://github.com/agaffney/ansible.git","svn_url":"https://github.com/agaffney/ansible","homepage":"http://ansible.com/","size":101375,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"591695932e74c546ba33c0f2e1a15c4c156fdd37","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-02-18T02:28:45Z","pushed_at":"2018-02-18T03:31:14Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":115155,"stargazers_count":28496,"watchers_count":28496,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10280,"mirror_url":null,"archived":false,"open_issues_count":4706,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":10280,"open_issues":4706,"watchers":28496,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36357"},"html":{"href":"https://github.com/ansible/ansible/pull/36357"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/36357"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/36357/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36357/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36357/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/d3776abbf314f9370b88c60bfbdebd6291362c75"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":74,"deletions":82,"changed_files":3}}
{"actor":{"display_login":"agaffney"}}