{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/224598145","pull_request_review_id":163927837,"id":224598145,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDU5ODE0NQ==","diff_hunk":"@@ -135,16 +135,52 @@ void ofi_cmap_del_handle(struct util_cmap_handle *handle)\n \tcmap->release(&cmap->lock);\n }\n \n+static inline int\n+util_cmap_check_and_realloc_handles_table(struct util_cmap *cmap, fi_addr_t fi_addr)\n+{\n+\tint ret = FI_SUCCESS;\n+\n+\tif (OFI_LIKELY(fi_addr < cmap->num_allocated))\n+\t\treturn ret;\n+\n+\twhile (fi_addr >= cmap->num_allocated) {\n+\t\tstruct util_cmap_handle **handles_av_new =\n+\t\t\t\trealloc(cmap->handles_av,\n+\t\t\t\t\t(cmap->av->count +\n+\t\t\t\t\t cmap->num_allocated) *\n+\t\t\t\t\tsizeof(*cmap->handles_av));\n+\t\tif (OFI_LIKELY(*handles_av_new != NULL)) {\n+\t\t\tcmap->handles_av = cmap->handles_av;","path":"prov/util/src/util_cmap.c","position":153,"original_position":19,"commit_id":"0b2b952fef117dd447ce89dc99c0b0fbac0b3b4d","original_commit_id":"f4e082e966c43b196a0ae22a5b35263ee4af3ed9","user":{"login":"a-ilango","id":8547674,"node_id":"MDQ6VXNlcjg1NDc2NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8547674?v=4","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"body":"Shouldn't the RHS be handles_av_new?","created_at":"2018-10-11T20:44:35Z","updated_at":"2018-10-11T20:48:58Z","html_url":"https://github.com/ofiwg/libfabric/pull/4502#discussion_r224598145","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4502","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/224598145"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/4502#discussion_r224598145"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4502"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4502","id":221477152,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNDc3MTUy","html_url":"https://github.com/ofiwg/libfabric/pull/4502","diff_url":"https://github.com/ofiwg/libfabric/pull/4502.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/4502.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/4502","number":4502,"state":"open","locked":false,"title":" util/av: Re-implement AV","user":{"login":"dmitrygladkov","id":11650339,"node_id":"MDQ6VXNlcjExNjUwMzM5","avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrygladkov","html_url":"https://github.com/dmitrygladkov","followers_url":"https://api.github.com/users/dmitrygladkov/followers","following_url":"https://api.github.com/users/dmitrygladkov/following{/other_user}","gists_url":"https://api.github.com/users/dmitrygladkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrygladkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrygladkov/subscriptions","organizations_url":"https://api.github.com/users/dmitrygladkov/orgs","repos_url":"https://api.github.com/users/dmitrygladkov/repos","events_url":"https://api.github.com/users/dmitrygladkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrygladkov/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-09T15:06:52Z","updated_at":"2018-10-11T20:48:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e27e067ed7cd45a4c308a9f7c6a2c675d84611d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"aingerson","id":10183414,"node_id":"MDQ6VXNlcjEwMTgzNDE0","avatar_url":"https://avatars0.githubusercontent.com/u/10183414?v=4","gravatar_id":"","url":"https://api.github.com/users/aingerson","html_url":"https://github.com/aingerson","followers_url":"https://api.github.com/users/aingerson/followers","following_url":"https://api.github.com/users/aingerson/following{/other_user}","gists_url":"https://api.github.com/users/aingerson/gists{/gist_id}","starred_url":"https://api.github.com/users/aingerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aingerson/subscriptions","organizations_url":"https://api.github.com/users/aingerson/orgs","repos_url":"https://api.github.com/users/aingerson/repos","events_url":"https://api.github.com/users/aingerson/events{/privacy}","received_events_url":"https://api.github.com/users/aingerson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4502/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4502/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/4502/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/0b2b952fef117dd447ce89dc99c0b0fbac0b3b4d","head":{"label":"dmitrygladkov:util_av","ref":"util_av","sha":"0b2b952fef117dd447ce89dc99c0b0fbac0b3b4d","user":{"login":"dmitrygladkov","id":11650339,"node_id":"MDQ6VXNlcjExNjUwMzM5","avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrygladkov","html_url":"https://github.com/dmitrygladkov","followers_url":"https://api.github.com/users/dmitrygladkov/followers","following_url":"https://api.github.com/users/dmitrygladkov/following{/other_user}","gists_url":"https://api.github.com/users/dmitrygladkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrygladkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrygladkov/subscriptions","organizations_url":"https://api.github.com/users/dmitrygladkov/orgs","repos_url":"https://api.github.com/users/dmitrygladkov/repos","events_url":"https://api.github.com/users/dmitrygladkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrygladkov/received_events","type":"User","site_admin":false},"repo":{"id":80634217,"node_id":"MDEwOlJlcG9zaXRvcnk4MDYzNDIxNw==","name":"libfabric","full_name":"dmitrygladkov/libfabric","private":false,"owner":{"login":"dmitrygladkov","id":11650339,"node_id":"MDQ6VXNlcjExNjUwMzM5","avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrygladkov","html_url":"https://github.com/dmitrygladkov","followers_url":"https://api.github.com/users/dmitrygladkov/followers","following_url":"https://api.github.com/users/dmitrygladkov/following{/other_user}","gists_url":"https://api.github.com/users/dmitrygladkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrygladkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrygladkov/subscriptions","organizations_url":"https://api.github.com/users/dmitrygladkov/orgs","repos_url":"https://api.github.com/users/dmitrygladkov/repos","events_url":"https://api.github.com/users/dmitrygladkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrygladkov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dmitrygladkov/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/dmitrygladkov/libfabric","forks_url":"https://api.github.com/repos/dmitrygladkov/libfabric/forks","keys_url":"https://api.github.com/repos/dmitrygladkov/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmitrygladkov/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmitrygladkov/libfabric/teams","hooks_url":"https://api.github.com/repos/dmitrygladkov/libfabric/hooks","issue_events_url":"https://api.github.com/repos/dmitrygladkov/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/dmitrygladkov/libfabric/events","assignees_url":"https://api.github.com/repos/dmitrygladkov/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/dmitrygladkov/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/dmitrygladkov/libfabric/tags","blobs_url":"https://api.github.com/repos/dmitrygladkov/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmitrygladkov/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmitrygladkov/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmitrygladkov/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmitrygladkov/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/dmitrygladkov/libfabric/languages","stargazers_url":"https://api.github.com/repos/dmitrygladkov/libfabric/stargazers","contributors_url":"https://api.github.com/repos/dmitrygladkov/libfabric/contributors","subscribers_url":"https://api.github.com/repos/dmitrygladkov/libfabric/subscribers","subscription_url":"https://api.github.com/repos/dmitrygladkov/libfabric/subscription","commits_url":"https://api.github.com/repos/dmitrygladkov/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmitrygladkov/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmitrygladkov/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmitrygladkov/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmitrygladkov/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/dmitrygladkov/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmitrygladkov/libfabric/merges","archive_url":"https://api.github.com/repos/dmitrygladkov/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmitrygladkov/libfabric/downloads","issues_url":"https://api.github.com/repos/dmitrygladkov/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/dmitrygladkov/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/dmitrygladkov/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/dmitrygladkov/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmitrygladkov/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/dmitrygladkov/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/dmitrygladkov/libfabric/deployments","created_at":"2017-02-01T15:37:30Z","updated_at":"2018-08-22T07:42:23Z","pushed_at":"2018-10-11T13:01:24Z","git_url":"git://github.com/dmitrygladkov/libfabric.git","ssh_url":"git@github.com:dmitrygladkov/libfabric.git","clone_url":"https://github.com/dmitrygladkov/libfabric.git","svn_url":"https://github.com/dmitrygladkov/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":22913,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"2832bb3628a5e7aa2a34cb4e2612a794460ddbcb","user":{"login":"ofiwg","id":8459445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NTk0NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk5NjA5Nw==","name":"libfabric","full_name":"ofiwg/libfabric","private":false,"owner":{"login":"ofiwg","id":8459445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NTk0NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/ofiwg/libfabric/deployments","created_at":"2014-08-15T16:45:53Z","updated_at":"2018-10-11T16:35:42Z","pushed_at":"2018-10-11T20:18:50Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://libfabric.org/","size":22808,"stargazers_count":159,"watchers_count":159,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":151,"open_issues":125,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4502"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/4502"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/4502"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/4502/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4502/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4502/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/0b2b952fef117dd447ce89dc99c0b0fbac0b3b4d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"a-ilango"}}