{"action":"created","comment":{"url":"https://api.github.com/repos/betaflight/betaflight/pulls/comments/232619649","pull_request_review_id":173853709,"id":232619649,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjYxOTY0OQ==","diff_hunk":"@@ -310,11 +310,13 @@ void init(void)\n     }\n #endif\n \n+    systemClockSetHSEValue(systemConfig()->hseMhz * 1000000U);\n+\n #ifdef USE_OVERCLOCK\n     OverclockRebootIfNecessary(systemConfig()->cpu_overclock);\n #endif\n \n-    delay(100);\n+    delay(100); // XXX What is this for? Is it necessary?","path":"src/main/fc/init.c","position":11,"original_position":11,"commit_id":"e073912e09c9f61272f2aa7ebc5572031181368d","original_commit_id":"e073912e09c9f61272f2aa7ebc5572031181368d","user":{"login":"mikeller","id":4742747,"node_id":"MDQ6VXNlcjQ3NDI3NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/4742747?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeller","html_url":"https://github.com/mikeller","followers_url":"https://api.github.com/users/mikeller/followers","following_url":"https://api.github.com/users/mikeller/following{/other_user}","gists_url":"https://api.github.com/users/mikeller/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeller/subscriptions","organizations_url":"https://api.github.com/users/mikeller/orgs","repos_url":"https://api.github.com/users/mikeller/repos","events_url":"https://api.github.com/users/mikeller/events{/privacy}","received_events_url":"https://api.github.com/users/mikeller/received_events","type":"User","site_admin":false},"body":"Apparently from multiwii: https://github.com/betaflight/betaflight/commit/d262c6e66c7862441c5a7e52248f4daf7ae12e2f#diff-ff21857f2bc5cf1319f56862a3aac350R111\r\n\r\nCan I propose we remove it and forget it was ever there?","created_at":"2018-11-12T11:15:42Z","updated_at":"2018-11-12T11:15:43Z","html_url":"https://github.com/betaflight/betaflight/pull/7081#discussion_r232619649","pull_request_url":"https://api.github.com/repos/betaflight/betaflight/pulls/7081","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/comments/232619649"},"html":{"href":"https://github.com/betaflight/betaflight/pull/7081#discussion_r232619649"},"pull_request":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/7081"}}},"pull_request":{"url":"https://api.github.com/repos/betaflight/betaflight/pulls/7081","id":230025339,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMDI1MzM5","html_url":"https://github.com/betaflight/betaflight/pull/7081","diff_url":"https://github.com/betaflight/betaflight/pull/7081.diff","patch_url":"https://github.com/betaflight/betaflight/pull/7081.patch","issue_url":"https://api.github.com/repos/betaflight/betaflight/issues/7081","number":7081,"state":"open","locked":false,"title":"[F4] System clock refactor to support unknown HSE crystal frequency","user":{"login":"jflyper","id":14850998,"node_id":"MDQ6VXNlcjE0ODUwOTk4","avatar_url":"https://avatars0.githubusercontent.com/u/14850998?v=4","gravatar_id":"","url":"https://api.github.com/users/jflyper","html_url":"https://github.com/jflyper","followers_url":"https://api.github.com/users/jflyper/followers","following_url":"https://api.github.com/users/jflyper/following{/other_user}","gists_url":"https://api.github.com/users/jflyper/gists{/gist_id}","starred_url":"https://api.github.com/users/jflyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jflyper/subscriptions","organizations_url":"https://api.github.com/users/jflyper/orgs","repos_url":"https://api.github.com/users/jflyper/repos","events_url":"https://api.github.com/users/jflyper/events{/privacy}","received_events_url":"https://api.github.com/users/jflyper/received_events","type":"User","site_admin":false},"body":"An experimental system clock initialization that gives partial solution to #7069.\r\n\r\n`SetSysClock` will resort to HSI sourced PLL until CLI variable `system_hse_mhz` variable is set to a non-zero value. Upon the first reboot after the variable is set to reflect the actual board Xtal frequency, the board will reboot to move to HSE sourced PLL.\r\n","created_at":"2018-11-12T05:55:02Z","updated_at":"2018-11-12T11:15:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66590c21298608aa74663d83d826f12504bf6c5b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":330919548,"node_id":"MDU6TGFiZWwzMzA5MTk1NDg=","url":"https://api.github.com/repos/betaflight/betaflight/labels/For%20Discussion","name":"For Discussion","color":"bfe5bf","default":false},{"id":392819447,"node_id":"MDU6TGFiZWwzOTI4MTk0NDc=","url":"https://api.github.com/repos/betaflight/betaflight/labels/In%20Development","name":"In Development","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/betaflight/betaflight/pulls/7081/commits","review_comments_url":"https://api.github.com/repos/betaflight/betaflight/pulls/7081/comments","review_comment_url":"https://api.github.com/repos/betaflight/betaflight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/betaflight/betaflight/issues/7081/comments","statuses_url":"https://api.github.com/repos/betaflight/betaflight/statuses/e073912e09c9f61272f2aa7ebc5572031181368d","head":{"label":"jflyper:bfdev-clockworks","ref":"bfdev-clockworks","sha":"e073912e09c9f61272f2aa7ebc5572031181368d","user":{"login":"jflyper","id":14850998,"node_id":"MDQ6VXNlcjE0ODUwOTk4","avatar_url":"https://avatars0.githubusercontent.com/u/14850998?v=4","gravatar_id":"","url":"https://api.github.com/users/jflyper","html_url":"https://github.com/jflyper","followers_url":"https://api.github.com/users/jflyper/followers","following_url":"https://api.github.com/users/jflyper/following{/other_user}","gists_url":"https://api.github.com/users/jflyper/gists{/gist_id}","starred_url":"https://api.github.com/users/jflyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jflyper/subscriptions","organizations_url":"https://api.github.com/users/jflyper/orgs","repos_url":"https://api.github.com/users/jflyper/repos","events_url":"https://api.github.com/users/jflyper/events{/privacy}","received_events_url":"https://api.github.com/users/jflyper/received_events","type":"User","site_admin":false},"repo":{"id":128154418,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxNTQ0MTg=","name":"betaflight","full_name":"jflyper/betaflight","private":false,"owner":{"login":"jflyper","id":14850998,"node_id":"MDQ6VXNlcjE0ODUwOTk4","avatar_url":"https://avatars0.githubusercontent.com/u/14850998?v=4","gravatar_id":"","url":"https://api.github.com/users/jflyper","html_url":"https://github.com/jflyper","followers_url":"https://api.github.com/users/jflyper/followers","following_url":"https://api.github.com/users/jflyper/following{/other_user}","gists_url":"https://api.github.com/users/jflyper/gists{/gist_id}","starred_url":"https://api.github.com/users/jflyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jflyper/subscriptions","organizations_url":"https://api.github.com/users/jflyper/orgs","repos_url":"https://api.github.com/users/jflyper/repos","events_url":"https://api.github.com/users/jflyper/events{/privacy}","received_events_url":"https://api.github.com/users/jflyper/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jflyper/betaflight","description":"Open Source Flight Controller Firmware","fork":true,"url":"https://api.github.com/repos/jflyper/betaflight","forks_url":"https://api.github.com/repos/jflyper/betaflight/forks","keys_url":"https://api.github.com/repos/jflyper/betaflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jflyper/betaflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jflyper/betaflight/teams","hooks_url":"https://api.github.com/repos/jflyper/betaflight/hooks","issue_events_url":"https://api.github.com/repos/jflyper/betaflight/issues/events{/number}","events_url":"https://api.github.com/repos/jflyper/betaflight/events","assignees_url":"https://api.github.com/repos/jflyper/betaflight/assignees{/user}","branches_url":"https://api.github.com/repos/jflyper/betaflight/branches{/branch}","tags_url":"https://api.github.com/repos/jflyper/betaflight/tags","blobs_url":"https://api.github.com/repos/jflyper/betaflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jflyper/betaflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jflyper/betaflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/jflyper/betaflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jflyper/betaflight/statuses/{sha}","languages_url":"https://api.github.com/repos/jflyper/betaflight/languages","stargazers_url":"https://api.github.com/repos/jflyper/betaflight/stargazers","contributors_url":"https://api.github.com/repos/jflyper/betaflight/contributors","subscribers_url":"https://api.github.com/repos/jflyper/betaflight/subscribers","subscription_url":"https://api.github.com/repos/jflyper/betaflight/subscription","commits_url":"https://api.github.com/repos/jflyper/betaflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/jflyper/betaflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/jflyper/betaflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/jflyper/betaflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/jflyper/betaflight/contents/{+path}","compare_url":"https://api.github.com/repos/jflyper/betaflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jflyper/betaflight/merges","archive_url":"https://api.github.com/repos/jflyper/betaflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jflyper/betaflight/downloads","issues_url":"https://api.github.com/repos/jflyper/betaflight/issues{/number}","pulls_url":"https://api.github.com/repos/jflyper/betaflight/pulls{/number}","milestones_url":"https://api.github.com/repos/jflyper/betaflight/milestones{/number}","notifications_url":"https://api.github.com/repos/jflyper/betaflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jflyper/betaflight/labels{/name}","releases_url":"https://api.github.com/repos/jflyper/betaflight/releases{/id}","deployments_url":"https://api.github.com/repos/jflyper/betaflight/deployments","created_at":"2018-04-05T03:27:13Z","updated_at":"2018-10-14T18:42:08Z","pushed_at":"2018-11-12T10:53:28Z","git_url":"git://github.com/jflyper/betaflight.git","ssh_url":"git@github.com:jflyper/betaflight.git","clone_url":"https://github.com/jflyper/betaflight.git","svn_url":"https://github.com/jflyper/betaflight","homepage":"","size":251091,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"betaflight:master","ref":"master","sha":"91c4a496a7e5dffc36268a6f79ca66489d01ed87","user":{"login":"betaflight","id":19597933,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk3OTMz","avatar_url":"https://avatars1.githubusercontent.com/u/19597933?v=4","gravatar_id":"","url":"https://api.github.com/users/betaflight","html_url":"https://github.com/betaflight","followers_url":"https://api.github.com/users/betaflight/followers","following_url":"https://api.github.com/users/betaflight/following{/other_user}","gists_url":"https://api.github.com/users/betaflight/gists{/gist_id}","starred_url":"https://api.github.com/users/betaflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betaflight/subscriptions","organizations_url":"https://api.github.com/users/betaflight/orgs","repos_url":"https://api.github.com/users/betaflight/repos","events_url":"https://api.github.com/users/betaflight/events{/privacy}","received_events_url":"https://api.github.com/users/betaflight/received_events","type":"Organization","site_admin":false},"repo":{"id":37060852,"node_id":"MDEwOlJlcG9zaXRvcnkzNzA2MDg1Mg==","name":"betaflight","full_name":"betaflight/betaflight","private":false,"owner":{"login":"betaflight","id":19597933,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk3OTMz","avatar_url":"https://avatars1.githubusercontent.com/u/19597933?v=4","gravatar_id":"","url":"https://api.github.com/users/betaflight","html_url":"https://github.com/betaflight","followers_url":"https://api.github.com/users/betaflight/followers","following_url":"https://api.github.com/users/betaflight/following{/other_user}","gists_url":"https://api.github.com/users/betaflight/gists{/gist_id}","starred_url":"https://api.github.com/users/betaflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betaflight/subscriptions","organizations_url":"https://api.github.com/users/betaflight/orgs","repos_url":"https://api.github.com/users/betaflight/repos","events_url":"https://api.github.com/users/betaflight/events{/privacy}","received_events_url":"https://api.github.com/users/betaflight/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/betaflight/betaflight","description":"Open Source Flight Controller Firmware","fork":false,"url":"https://api.github.com/repos/betaflight/betaflight","forks_url":"https://api.github.com/repos/betaflight/betaflight/forks","keys_url":"https://api.github.com/repos/betaflight/betaflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betaflight/betaflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betaflight/betaflight/teams","hooks_url":"https://api.github.com/repos/betaflight/betaflight/hooks","issue_events_url":"https://api.github.com/repos/betaflight/betaflight/issues/events{/number}","events_url":"https://api.github.com/repos/betaflight/betaflight/events","assignees_url":"https://api.github.com/repos/betaflight/betaflight/assignees{/user}","branches_url":"https://api.github.com/repos/betaflight/betaflight/branches{/branch}","tags_url":"https://api.github.com/repos/betaflight/betaflight/tags","blobs_url":"https://api.github.com/repos/betaflight/betaflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betaflight/betaflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betaflight/betaflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/betaflight/betaflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betaflight/betaflight/statuses/{sha}","languages_url":"https://api.github.com/repos/betaflight/betaflight/languages","stargazers_url":"https://api.github.com/repos/betaflight/betaflight/stargazers","contributors_url":"https://api.github.com/repos/betaflight/betaflight/contributors","subscribers_url":"https://api.github.com/repos/betaflight/betaflight/subscribers","subscription_url":"https://api.github.com/repos/betaflight/betaflight/subscription","commits_url":"https://api.github.com/repos/betaflight/betaflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/betaflight/betaflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/betaflight/betaflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/betaflight/betaflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/betaflight/betaflight/contents/{+path}","compare_url":"https://api.github.com/repos/betaflight/betaflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betaflight/betaflight/merges","archive_url":"https://api.github.com/repos/betaflight/betaflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betaflight/betaflight/downloads","issues_url":"https://api.github.com/repos/betaflight/betaflight/issues{/number}","pulls_url":"https://api.github.com/repos/betaflight/betaflight/pulls{/number}","milestones_url":"https://api.github.com/repos/betaflight/betaflight/milestones{/number}","notifications_url":"https://api.github.com/repos/betaflight/betaflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betaflight/betaflight/labels{/name}","releases_url":"https://api.github.com/repos/betaflight/betaflight/releases{/id}","deployments_url":"https://api.github.com/repos/betaflight/betaflight/deployments","created_at":"2015-06-08T10:37:44Z","updated_at":"2018-11-12T09:13:14Z","pushed_at":"2018-11-12T10:53:31Z","git_url":"git://github.com/betaflight/betaflight.git","ssh_url":"git@github.com:betaflight/betaflight.git","clone_url":"https://github.com/betaflight/betaflight.git","svn_url":"https://github.com/betaflight/betaflight","homepage":"","size":233467,"stargazers_count":2163,"watchers_count":2163,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1056,"mirror_url":null,"archived":false,"open_issues_count":202,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1056,"open_issues":202,"watchers":2163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/7081"},"html":{"href":"https://github.com/betaflight/betaflight/pull/7081"},"issue":{"href":"https://api.github.com/repos/betaflight/betaflight/issues/7081"},"comments":{"href":"https://api.github.com/repos/betaflight/betaflight/issues/7081/comments"},"review_comments":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/7081/comments"},"review_comment":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/7081/commits"},"statuses":{"href":"https://api.github.com/repos/betaflight/betaflight/statuses/e073912e09c9f61272f2aa7ebc5572031181368d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mikeller"}}