{"action":"created","issue":{"url":"https://api.github.com/repos/flatpak/flatpak/issues/1431","repository_url":"https://api.github.com/repos/flatpak/flatpak","labels_url":"https://api.github.com/repos/flatpak/flatpak/issues/1431/labels{/name}","comments_url":"https://api.github.com/repos/flatpak/flatpak/issues/1431/comments","events_url":"https://api.github.com/repos/flatpak/flatpak/issues/1431/events","html_url":"https://github.com/flatpak/flatpak/issues/1431","id":298228619,"number":1431,"title":"Build failure with P2P enabled","user":{"login":"alexlarsson","id":990736,"avatar_url":"https://avatars2.githubusercontent.com/u/990736?v=4","gravatar_id":"","url":"https://api.github.com/users/alexlarsson","html_url":"https://github.com/alexlarsson","followers_url":"https://api.github.com/users/alexlarsson/followers","following_url":"https://api.github.com/users/alexlarsson/following{/other_user}","gists_url":"https://api.github.com/users/alexlarsson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlarsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlarsson/subscriptions","organizations_url":"https://api.github.com/users/alexlarsson/orgs","repos_url":"https://api.github.com/users/alexlarsson/repos","events_url":"https://api.github.com/users/alexlarsson/events{/privacy}","received_events_url":"https://api.github.com/users/alexlarsson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-19T10:38:48Z","updated_at":"2018-02-19T10:53:14Z","closed_at":null,"author_association":"OWNER","body":"Master with FLATPAK_ENABLE_P2P fails to build with:\r\n\r\n```\r\n../common/flatpak-dir.c: In function ‘flatpak_dir_find_latest_rev’:\r\n../common/flatpak-dir.c:2031:11: error: ‘checksum_or_latest’ undeclared (first use in this function)\r\n       if (checksum_or_latest != NULL)\r\n           ^\r\n../common/flatpak-dir.c:2031:11: note: each undeclared identifier is reported only once for each function it appears in\r\n```\r\n\r\nI didn't follow this closely, whats the right thing here @pwithnall @mwleeds ?"},"comment":{"url":"https://api.github.com/repos/flatpak/flatpak/issues/comments/366654244","html_url":"https://github.com/flatpak/flatpak/issues/1431#issuecomment-366654244","issue_url":"https://api.github.com/repos/flatpak/flatpak/issues/1431","id":366654244,"user":{"login":"pwithnall","id":53172,"avatar_url":"https://avatars2.githubusercontent.com/u/53172?v=4","gravatar_id":"","url":"https://api.github.com/users/pwithnall","html_url":"https://github.com/pwithnall","followers_url":"https://api.github.com/users/pwithnall/followers","following_url":"https://api.github.com/users/pwithnall/following{/other_user}","gists_url":"https://api.github.com/users/pwithnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwithnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwithnall/subscriptions","organizations_url":"https://api.github.com/users/pwithnall/orgs","repos_url":"https://api.github.com/users/pwithnall/repos","events_url":"https://api.github.com/users/pwithnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwithnall/received_events","type":"User","site_admin":false},"created_at":"2018-02-19T10:53:14Z","updated_at":"2018-02-19T10:53:14Z","author_association":"COLLABORATOR","body":"This was PR #1314 and, looking back at the code, I’m not sure how it built and passed the pre-merge tests. `checksum_or_latest` is not defined in that scope, and it doesn’t look like it was defined at the time that PR was merged.\r\n\r\n@mwleeds, what’s going on here? Does `flatpak_dir_find_latest_rev()` need to be passed a `checksum_or_latest` argument by its caller?"}}
{"actor":{"display_login":"pwithnall"}}