{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/184558419","pull_request_review_id":115781246,"id":184558419,"diff_hunk":"@@ -20,18 +20,35 @@ export class Text implements Node {\n   visit<Result>(visitor: Visitor<Result>): Result { return visitor.visitText(this); }\n }\n \n+export class I18nText implements Node {\n+  constructor(public value: string, public meta: I18nMeta, public sourceSpan: ParseSourceSpan) {}\n+  visit<Result>(visitor: I18nVisitor<Result>): Result { return visitor.visitI18nText(this); }\n+}\n+\n export class BoundText implements Node {\n   constructor(public value: AST, public sourceSpan: ParseSourceSpan) {}\n   visit<Result>(visitor: Visitor<Result>): Result { return visitor.visitBoundText(this); }\n }\n \n+export class I18nBoundText implements Node {\n+  constructor(public value: AST, public meta: I18nMeta, public sourceSpan: ParseSourceSpan) {}\n+  visit<Result>(visitor: I18nVisitor<Result>): Result { return visitor.visitI18nBoundText(this); }\n+}\n+\n export class TextAttribute implements Node {\n   constructor(\n       public name: string, public value: string, public sourceSpan: ParseSourceSpan,\n       public valueSpan?: ParseSourceSpan) {}\n   visit<Result>(visitor: Visitor<Result>): Result { return visitor.visitAttribute(this); }\n }\n \n+export class I18nTextAttribute implements Node {\n+  constructor(\n+      public name: string, public value: string, public meta: I18nMeta,\n+      public sourceSpan: ParseSourceSpan, public valueSpan?: ParseSourceSpan) {}\n+  visit<Result>(visitor: I18nVisitor<Result>): Result { return visitor.visitI18nAttribute(this); }","path":"packages/compiler/src/render3/r3_ast.ts","position":30,"original_position":30,"commit_id":"d91252d1a672760796608739818859483f529fca","original_commit_id":"d91252d1a672760796608739818859483f529fca","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars0.githubusercontent.com/u/248818?v=4","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"body":"should be `visitI18nTextAttribute` (I rename the `visitITextAttribute` in a pending PR)","created_at":"2018-04-26T23:29:01Z","updated_at":"2018-04-26T23:29:01Z","html_url":"https://github.com/angular/angular/pull/22931#discussion_r184558419","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/22931","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/184558419"},"html":{"href":"https://github.com/angular/angular/pull/22931#discussion_r184558419"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/22931"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/22931","id":176840183,"html_url":"https://github.com/angular/angular/pull/22931","diff_url":"https://github.com/angular/angular/pull/22931.diff","patch_url":"https://github.com/angular/angular/pull/22931.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/22931","number":22931,"state":"open","locked":false,"title":"[ivy] i18n extraction","user":{"login":"ocombe","id":265378,"avatar_url":"https://avatars0.githubusercontent.com/u/265378?v=4","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"body":"## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[x] Feature\r\n```\r\n\r\n## What is the current behavior?\r\nCannot run ng-xi18n with ivy\r\n\r\n\r\n## What is the new behavior?\r\nCan use ng-xi18n with ivy\r\n\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[x] No\r\n```\r\n\r\n\r\n## Other information\r\nBlocked until https://github.com/angular/angular/pull/22654 is merged.\r\nOnly review the last commit (feat(compiler-cli): i18n extraction with render3)","created_at":"2018-03-22T16:41:36Z","updated_at":"2018-04-26T23:29:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75be3db21831cb1929fc165000c3898badad5a78","assignee":{"login":"vicb","id":248818,"avatar_url":"https://avatars0.githubusercontent.com/u/248818?v=4","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"assignees":[{"login":"vicb","id":248818,"avatar_url":"https://avatars0.githubusercontent.com/u/248818?v=4","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":217962760,"url":"https://api.github.com/repos/angular/angular/labels/PR%20state:%20blocked","name":"PR state: blocked","color":"e11d21","default":false},{"id":660621334,"url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master-only","name":"PR target: master-only","color":"5319e7","default":false},{"id":149476251,"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":251048427,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20i18n","name":"comp: i18n","color":"c7def8","default":false},{"id":799860804,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20ivy","name":"comp: ivy","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/22931/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/22931/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/22931/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/d91252d1a672760796608739818859483f529fca","head":{"label":"ocombe:feat/ivy/ng-xi18n","ref":"feat/ivy/ng-xi18n","sha":"d91252d1a672760796608739818859483f529fca","user":{"login":"ocombe","id":265378,"avatar_url":"https://avatars0.githubusercontent.com/u/265378?v=4","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"repo":{"id":82280177,"name":"angular","full_name":"ocombe/angular","owner":{"login":"ocombe","id":265378,"avatar_url":"https://avatars0.githubusercontent.com/u/265378?v=4","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ocombe/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/ocombe/angular","forks_url":"https://api.github.com/repos/ocombe/angular/forks","keys_url":"https://api.github.com/repos/ocombe/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocombe/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocombe/angular/teams","hooks_url":"https://api.github.com/repos/ocombe/angular/hooks","issue_events_url":"https://api.github.com/repos/ocombe/angular/issues/events{/number}","events_url":"https://api.github.com/repos/ocombe/angular/events","assignees_url":"https://api.github.com/repos/ocombe/angular/assignees{/user}","branches_url":"https://api.github.com/repos/ocombe/angular/branches{/branch}","tags_url":"https://api.github.com/repos/ocombe/angular/tags","blobs_url":"https://api.github.com/repos/ocombe/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocombe/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocombe/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocombe/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocombe/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/ocombe/angular/languages","stargazers_url":"https://api.github.com/repos/ocombe/angular/stargazers","contributors_url":"https://api.github.com/repos/ocombe/angular/contributors","subscribers_url":"https://api.github.com/repos/ocombe/angular/subscribers","subscription_url":"https://api.github.com/repos/ocombe/angular/subscription","commits_url":"https://api.github.com/repos/ocombe/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocombe/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocombe/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocombe/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocombe/angular/contents/{+path}","compare_url":"https://api.github.com/repos/ocombe/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocombe/angular/merges","archive_url":"https://api.github.com/repos/ocombe/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocombe/angular/downloads","issues_url":"https://api.github.com/repos/ocombe/angular/issues{/number}","pulls_url":"https://api.github.com/repos/ocombe/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/ocombe/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/ocombe/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocombe/angular/labels{/name}","releases_url":"https://api.github.com/repos/ocombe/angular/releases{/id}","deployments_url":"https://api.github.com/repos/ocombe/angular/deployments","created_at":"2017-02-17T09:26:18Z","updated_at":"2018-04-26T08:56:14Z","pushed_at":"2018-04-26T16:44:48Z","git_url":"git://github.com/ocombe/angular.git","ssh_url":"git@github.com:ocombe/angular.git","clone_url":"https://github.com/ocombe/angular.git","svn_url":"https://github.com/ocombe/angular","homepage":"https://angular.io","size":453860,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"1a44a0b4a87767236f6eea07deca5e4d8789572f","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-04-26T23:19:53Z","pushed_at":"2018-04-26T22:53:04Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":79575,"stargazers_count":35534,"watchers_count":35534,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8652,"mirror_url":null,"archived":false,"open_issues_count":2314,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8652,"open_issues":2314,"watchers":35534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/22931"},"html":{"href":"https://github.com/angular/angular/pull/22931"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/22931"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/22931/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/22931/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/22931/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/d91252d1a672760796608739818859483f529fca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vicb"}}