{"action":"closed","number":233,"pull_request":{"url":"https://api.github.com/repos/openSUSE/umoci/pulls/233","id":175034115,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc1MDM0MTE1","html_url":"https://github.com/openSUSE/umoci/pull/233","diff_url":"https://github.com/openSUSE/umoci/pull/233.diff","patch_url":"https://github.com/openSUSE/umoci/pull/233.patch","issue_url":"https://api.github.com/repos/openSUSE/umoci/issues/233","number":233,"state":"closed","locked":false,"title":"*: switch from \"compress/gzip\" to more optimal library","user":{"login":"cyphar","id":2888411,"node_id":"MDQ6VXNlcjI4ODg0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2888411?v=4","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"body":"One of the largest resource hogs in umoci is compression-related, and [it\r\nturns out][1] that Go's ordinary gzip implementation is nowhere near as\r\nfast as other modern gzip implementations. In order to help our users\r\nget more efficient builds, switch to a \"pure-Go\" implementation which\r\nhas x64-specific optimisations. We cannot use zlib wrappers like [vitess][2]\r\nbecause of issues with \"os/user\" and static compilation (so we wouldn't\r\nbe able to release binaries).\r\n\r\nThis very simplified benchmark shows the positive difference when\r\nswitching libraries (using \"tensorflow/tensorflow:latest\" as the image\r\nbase):\r\n\r\n  % time umoci unpack --image tensorflow:latest bundle # before\r\n  39.03user 7.58system 0:45.16elapsed\r\n  % time umoci unpack --image tensorflow:latest bundle # after\r\n  40.89user 7.99system 0:34.89elapsed\r\n\r\nBut the real benefit is when it comes to compression and repacking (in\r\nthis benchmark the changes were installing FireFox and doing a repo\r\nrefresh):\r\n\r\n  % time umoci repack --image tensorflow:latest bundle # before\r\n  78.54user 13.71system 1:26.66elapsed\r\n  % time umoci repack --image tensorflow:latest bundle # after\r\n  53.11user 4.87system 0:36.75elapsed\r\n\r\nThat's almost 3x faster, just by having a more optimised compression\r\nlibrary!\r\n\r\n[1]: golang/go#23154\r\n[2]: https://github.com/vitessio/vitess/tree/v2.2/go/cgzip\r\n\r\nCloses #225\r\nSigned-off-by: Aleksa Sarai <asarai@suse.de>","created_at":"2018-03-14T17:41:55Z","updated_at":"2018-08-03T10:34:11Z","closed_at":"2018-08-03T10:34:11Z","merged_at":"2018-08-03T10:34:11Z","merge_commit_sha":"25e50d38685b6e9ee9f07f56e9e2d32935722445","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/openSUSE/umoci/milestones/11","html_url":"https://github.com/openSUSE/umoci/milestone/11","labels_url":"https://api.github.com/repos/openSUSE/umoci/milestones/11/labels","id":3178597,"node_id":"MDk6TWlsZXN0b25lMzE3ODU5Nw==","number":11,"title":"0.4.1","description":"","creator":{"login":"cyphar","id":2888411,"node_id":"MDQ6VXNlcjI4ODg0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2888411?v=4","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":5,"state":"open","created_at":"2018-03-12T10:16:38Z","updated_at":"2018-08-03T10:34:11Z","due_on":"2018-05-11T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/openSUSE/umoci/pulls/233/commits","review_comments_url":"https://api.github.com/repos/openSUSE/umoci/pulls/233/comments","review_comment_url":"https://api.github.com/repos/openSUSE/umoci/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openSUSE/umoci/issues/233/comments","statuses_url":"https://api.github.com/repos/openSUSE/umoci/statuses/25e50d38685b6e9ee9f07f56e9e2d32935722445","head":{"label":"cyphar:cgzip-migration","ref":"cgzip-migration","sha":"25e50d38685b6e9ee9f07f56e9e2d32935722445","user":{"login":"cyphar","id":2888411,"node_id":"MDQ6VXNlcjI4ODg0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2888411?v=4","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"repo":{"id":94469645,"node_id":"MDEwOlJlcG9zaXRvcnk5NDQ2OTY0NQ==","name":"umoci","full_name":"cyphar/umoci","owner":{"login":"cyphar","id":2888411,"node_id":"MDQ6VXNlcjI4ODg0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2888411?v=4","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyphar/umoci","description":"umoci modifies Open Container images","fork":true,"url":"https://api.github.com/repos/cyphar/umoci","forks_url":"https://api.github.com/repos/cyphar/umoci/forks","keys_url":"https://api.github.com/repos/cyphar/umoci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyphar/umoci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyphar/umoci/teams","hooks_url":"https://api.github.com/repos/cyphar/umoci/hooks","issue_events_url":"https://api.github.com/repos/cyphar/umoci/issues/events{/number}","events_url":"https://api.github.com/repos/cyphar/umoci/events","assignees_url":"https://api.github.com/repos/cyphar/umoci/assignees{/user}","branches_url":"https://api.github.com/repos/cyphar/umoci/branches{/branch}","tags_url":"https://api.github.com/repos/cyphar/umoci/tags","blobs_url":"https://api.github.com/repos/cyphar/umoci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyphar/umoci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyphar/umoci/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyphar/umoci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyphar/umoci/statuses/{sha}","languages_url":"https://api.github.com/repos/cyphar/umoci/languages","stargazers_url":"https://api.github.com/repos/cyphar/umoci/stargazers","contributors_url":"https://api.github.com/repos/cyphar/umoci/contributors","subscribers_url":"https://api.github.com/repos/cyphar/umoci/subscribers","subscription_url":"https://api.github.com/repos/cyphar/umoci/subscription","commits_url":"https://api.github.com/repos/cyphar/umoci/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyphar/umoci/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyphar/umoci/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyphar/umoci/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyphar/umoci/contents/{+path}","compare_url":"https://api.github.com/repos/cyphar/umoci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyphar/umoci/merges","archive_url":"https://api.github.com/repos/cyphar/umoci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyphar/umoci/downloads","issues_url":"https://api.github.com/repos/cyphar/umoci/issues{/number}","pulls_url":"https://api.github.com/repos/cyphar/umoci/pulls{/number}","milestones_url":"https://api.github.com/repos/cyphar/umoci/milestones{/number}","notifications_url":"https://api.github.com/repos/cyphar/umoci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyphar/umoci/labels{/name}","releases_url":"https://api.github.com/repos/cyphar/umoci/releases{/id}","deployments_url":"https://api.github.com/repos/cyphar/umoci/deployments","created_at":"2017-06-15T18:54:53Z","updated_at":"2017-12-13T06:25:38Z","pushed_at":"2018-08-03T09:12:13Z","git_url":"git://github.com/cyphar/umoci.git","ssh_url":"git@github.com:cyphar/umoci.git","clone_url":"https://github.com/cyphar/umoci.git","svn_url":"https://github.com/cyphar/umoci","homepage":"https://www.cyphar.com/blog/post/umoci-new-oci-image-tool","size":3255,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"openSUSE:master","ref":"master","sha":"29f590a257fd57c411ec9c604c4c9add7466458e","user":{"login":"openSUSE","id":623819,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMzgxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/623819?v=4","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":72283469,"node_id":"MDEwOlJlcG9zaXRvcnk3MjI4MzQ2OQ==","name":"umoci","full_name":"openSUSE/umoci","owner":{"login":"openSUSE","id":623819,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMzgxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/623819?v=4","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openSUSE/umoci","description":"umoci modifies Open Container images","fork":false,"url":"https://api.github.com/repos/openSUSE/umoci","forks_url":"https://api.github.com/repos/openSUSE/umoci/forks","keys_url":"https://api.github.com/repos/openSUSE/umoci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openSUSE/umoci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openSUSE/umoci/teams","hooks_url":"https://api.github.com/repos/openSUSE/umoci/hooks","issue_events_url":"https://api.github.com/repos/openSUSE/umoci/issues/events{/number}","events_url":"https://api.github.com/repos/openSUSE/umoci/events","assignees_url":"https://api.github.com/repos/openSUSE/umoci/assignees{/user}","branches_url":"https://api.github.com/repos/openSUSE/umoci/branches{/branch}","tags_url":"https://api.github.com/repos/openSUSE/umoci/tags","blobs_url":"https://api.github.com/repos/openSUSE/umoci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openSUSE/umoci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openSUSE/umoci/git/refs{/sha}","trees_url":"https://api.github.com/repos/openSUSE/umoci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openSUSE/umoci/statuses/{sha}","languages_url":"https://api.github.com/repos/openSUSE/umoci/languages","stargazers_url":"https://api.github.com/repos/openSUSE/umoci/stargazers","contributors_url":"https://api.github.com/repos/openSUSE/umoci/contributors","subscribers_url":"https://api.github.com/repos/openSUSE/umoci/subscribers","subscription_url":"https://api.github.com/repos/openSUSE/umoci/subscription","commits_url":"https://api.github.com/repos/openSUSE/umoci/commits{/sha}","git_commits_url":"https://api.github.com/repos/openSUSE/umoci/git/commits{/sha}","comments_url":"https://api.github.com/repos/openSUSE/umoci/comments{/number}","issue_comment_url":"https://api.github.com/repos/openSUSE/umoci/issues/comments{/number}","contents_url":"https://api.github.com/repos/openSUSE/umoci/contents/{+path}","compare_url":"https://api.github.com/repos/openSUSE/umoci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openSUSE/umoci/merges","archive_url":"https://api.github.com/repos/openSUSE/umoci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openSUSE/umoci/downloads","issues_url":"https://api.github.com/repos/openSUSE/umoci/issues{/number}","pulls_url":"https://api.github.com/repos/openSUSE/umoci/pulls{/number}","milestones_url":"https://api.github.com/repos/openSUSE/umoci/milestones{/number}","notifications_url":"https://api.github.com/repos/openSUSE/umoci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openSUSE/umoci/labels{/name}","releases_url":"https://api.github.com/repos/openSUSE/umoci/releases{/id}","deployments_url":"https://api.github.com/repos/openSUSE/umoci/deployments","created_at":"2016-10-29T12:27:34Z","updated_at":"2018-08-02T22:58:29Z","pushed_at":"2018-08-03T10:34:09Z","git_url":"git://github.com/openSUSE/umoci.git","ssh_url":"git@github.com:openSUSE/umoci.git","clone_url":"https://github.com/openSUSE/umoci.git","svn_url":"https://github.com/openSUSE/umoci","homepage":"https://umo.ci/","size":5108,"stargazers_count":135,"watchers_count":135,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":35,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openSUSE/umoci/pulls/233"},"html":{"href":"https://github.com/openSUSE/umoci/pull/233"},"issue":{"href":"https://api.github.com/repos/openSUSE/umoci/issues/233"},"comments":{"href":"https://api.github.com/repos/openSUSE/umoci/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/openSUSE/umoci/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/openSUSE/umoci/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openSUSE/umoci/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/openSUSE/umoci/statuses/25e50d38685b6e9ee9f07f56e9e2d32935722445"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cyphar","id":2888411,"node_id":"MDQ6VXNlcjI4ODg0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2888411?v=4","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"comments":19,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9057,"deletions":2,"changed_files":42}}
{"actor":{"display_login":"cyphar"}}