{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/comments/176193606","pull_request_review_id":105854253,"id":176193606,"diff_hunk":"@@ -412,19 +412,14 @@ def mesos_cpu_metrics_provider(\n \n             if system_paasta_config.get_filter_bogus_mesos_cputime_enabled():\n                 # It is unlikely that the cputime consumed by a task is greater than the CPU limits\n-                # that we enforce (plus 10% of margin). This is a bug in Mesos (tracked in PAASTA-13510)\n-                cpu_burst_allowance = (\n-                    1.10 *","path":"paasta_tools/autoscaling/autoscaling_service_lib.py","position":6,"original_position":6,"commit_id":"9e88a18cf7d5b2236319b7263856a701fdd5671b","original_commit_id":"cb90e0754e0d18205da6efcdda2e215da458c887","user":{"login":"matfra","id":4550821,"avatar_url":"https://avatars2.githubusercontent.com/u/4550821?v=4","gravatar_id":"","url":"https://api.github.com/users/matfra","html_url":"https://github.com/matfra","followers_url":"https://api.github.com/users/matfra/followers","following_url":"https://api.github.com/users/matfra/following{/other_user}","gists_url":"https://api.github.com/users/matfra/gists{/gist_id}","starred_url":"https://api.github.com/users/matfra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matfra/subscriptions","organizations_url":"https://api.github.com/users/matfra/orgs","repos_url":"https://api.github.com/users/matfra/repos","events_url":"https://api.github.com/users/matfra/events{/privacy}","received_events_url":"https://api.github.com/users/matfra/received_events","type":"User","site_admin":false},"body":"OK I added it back","created_at":"2018-03-21T18:31:28Z","updated_at":"2018-03-21T18:31:28Z","html_url":"https://github.com/Yelp/paasta/pull/1771#discussion_r176193606","pull_request_url":"https://api.github.com/repos/Yelp/paasta/pulls/1771","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments/176193606"},"html":{"href":"https://github.com/Yelp/paasta/pull/1771#discussion_r176193606"},"pull_request":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1771"}},"in_reply_to_id":176169151},"pull_request":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/1771","id":176362708,"html_url":"https://github.com/Yelp/paasta/pull/1771","diff_url":"https://github.com/Yelp/paasta/pull/1771.diff","patch_url":"https://github.com/Yelp/paasta/pull/1771.patch","issue_url":"https://api.github.com/repos/Yelp/paasta/issues/1771","number":1771,"state":"open","locked":false,"title":"Fix Bogus CPU value filter","user":{"login":"matfra","id":4550821,"avatar_url":"https://avatars2.githubusercontent.com/u/4550821?v=4","gravatar_id":"","url":"https://api.github.com/users/matfra","html_url":"https://github.com/matfra","followers_url":"https://api.github.com/users/matfra/followers","following_url":"https://api.github.com/users/matfra/following{/other_user}","gists_url":"https://api.github.com/users/matfra/gists{/gist_id}","starred_url":"https://api.github.com/users/matfra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matfra/subscriptions","organizations_url":"https://api.github.com/users/matfra/orgs","repos_url":"https://api.github.com/users/matfra/repos","events_url":"https://api.github.com/users/matfra/events{/privacy}","received_events_url":"https://api.github.com/users/matfra/received_events","type":"User","site_admin":false},"body":"The previous filter only worked properly with service declaring one CPU. It didn't take into account the fact that we use and store a normalized CPU usage\r\n\r\nThis implementation of the filter compare the CPU usage of tasks according to their own limit with the burst limit that we enforce.\r\nI added tests and detailled tables to make sure the logic works","created_at":"2018-03-21T01:10:31Z","updated_at":"2018-03-21T18:31:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"321187f31dd3e85dd2d6ab818f3b7084cba6b9e8","assignee":{"login":"matfra","id":4550821,"avatar_url":"https://avatars2.githubusercontent.com/u/4550821?v=4","gravatar_id":"","url":"https://api.github.com/users/matfra","html_url":"https://github.com/matfra","followers_url":"https://api.github.com/users/matfra/followers","following_url":"https://api.github.com/users/matfra/following{/other_user}","gists_url":"https://api.github.com/users/matfra/gists{/gist_id}","starred_url":"https://api.github.com/users/matfra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matfra/subscriptions","organizations_url":"https://api.github.com/users/matfra/orgs","repos_url":"https://api.github.com/users/matfra/repos","events_url":"https://api.github.com/users/matfra/events{/privacy}","received_events_url":"https://api.github.com/users/matfra/received_events","type":"User","site_admin":false},"assignees":[{"login":"matfra","id":4550821,"avatar_url":"https://avatars2.githubusercontent.com/u/4550821?v=4","gravatar_id":"","url":"https://api.github.com/users/matfra","html_url":"https://github.com/matfra","followers_url":"https://api.github.com/users/matfra/followers","following_url":"https://api.github.com/users/matfra/following{/other_user}","gists_url":"https://api.github.com/users/matfra/gists{/gist_id}","starred_url":"https://api.github.com/users/matfra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matfra/subscriptions","organizations_url":"https://api.github.com/users/matfra/orgs","repos_url":"https://api.github.com/users/matfra/repos","events_url":"https://api.github.com/users/matfra/events{/privacy}","received_events_url":"https://api.github.com/users/matfra/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars0.githubusercontent.com/u/370205?v=4","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":295506239,"url":"https://api.github.com/repos/Yelp/paasta/labels/in%20review","name":"in review","color":"eac04b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/paasta/pulls/1771/commits","review_comments_url":"https://api.github.com/repos/Yelp/paasta/pulls/1771/comments","review_comment_url":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/paasta/issues/1771/comments","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/9e88a18cf7d5b2236319b7263856a701fdd5671b","head":{"label":"Yelp:fix_bogus_cpu_filter","ref":"fix_bogus_cpu_filter","sha":"9e88a18cf7d5b2236319b7263856a701fdd5671b","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"name":"paasta","full_name":"Yelp/paasta","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/paasta/deployments","created_at":"2015-10-26T21:35:53Z","updated_at":"2018-03-21T12:31:06Z","pushed_at":"2018-03-21T18:31:10Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":55569,"stargazers_count":1196,"watchers_count":1196,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":150,"open_issues":96,"watchers":1196,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"8319ab2c88d01a6fcf7d462f2d231121607d6e69","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"name":"paasta","full_name":"Yelp/paasta","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/paasta/deployments","created_at":"2015-10-26T21:35:53Z","updated_at":"2018-03-21T12:31:06Z","pushed_at":"2018-03-21T18:31:10Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":55569,"stargazers_count":1196,"watchers_count":1196,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":150,"open_issues":96,"watchers":1196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1771"},"html":{"href":"https://github.com/Yelp/paasta/pull/1771"},"issue":{"href":"https://api.github.com/repos/Yelp/paasta/issues/1771"},"comments":{"href":"https://api.github.com/repos/Yelp/paasta/issues/1771/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1771/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1771/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/paasta/statuses/9e88a18cf7d5b2236319b7263856a701fdd5671b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"matfra"}}