{"action":"closed","number":34670,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/34670","id":237501344,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NTAxMzQ0","html_url":"https://github.com/rails/rails/pull/34670","diff_url":"https://github.com/rails/rails/pull/34670.diff","patch_url":"https://github.com/rails/rails/pull/34670.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/34670","number":34670,"state":"closed","locked":false,"title":"Prepend module in ActiveStorage overview","user":{"login":"sambostock","id":8219340,"node_id":"MDQ6VXNlcjgyMTkzNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/8219340?v=4","gravatar_id":"","url":"https://api.github.com/users/sambostock","html_url":"https://github.com/sambostock","followers_url":"https://api.github.com/users/sambostock/followers","following_url":"https://api.github.com/users/sambostock/following{/other_user}","gists_url":"https://api.github.com/users/sambostock/gists{/gist_id}","starred_url":"https://api.github.com/users/sambostock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambostock/subscriptions","organizations_url":"https://api.github.com/users/sambostock/orgs","repos_url":"https://api.github.com/users/sambostock/repos","events_url":"https://api.github.com/users/sambostock/events{/privacy}","received_events_url":"https://api.github.com/users/sambostock/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\n<!-- Provide a general description of the code changes in your pull\r\nrequest... were there any bugs you had fixed? If so, mention them. If\r\nthese bugs have open GitHub issues, be sure to tag them here as well,\r\nto keep the conversation linked together. -->\r\n\r\nThis updates the ActiveStorage overview documentation to prepend a module onto `IntegrationTest`, rather than straight overriding the `after_teardown` method, as per [this discussion with @rafaelfranca in #34619](https://github.com/rails/rails/pull/34619#discussion_r238882327)","created_at":"2018-12-10T23:26:46Z","updated_at":"2018-12-11T00:03:30Z","closed_at":"2018-12-11T00:03:30Z","merged_at":"2018-12-11T00:03:30Z","merge_commit_sha":"cb714c3687f6b0cf13bb4a0655d7b648e37239d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":150377,"node_id":"MDU6TGFiZWwxNTAzNzc=","url":"https://api.github.com/repos/rails/rails/labels/docs","name":"docs","color":"02d7e1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/34670/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/34670/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/34670/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/f2935b399be87d7acfc6067a73cfe11e7d4bbdec","head":{"label":"sambostock:prepend-module-in-active-storage-overview","ref":"prepend-module-in-active-storage-overview","sha":"f2935b399be87d7acfc6067a73cfe11e7d4bbdec","user":{"login":"sambostock","id":8219340,"node_id":"MDQ6VXNlcjgyMTkzNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/8219340?v=4","gravatar_id":"","url":"https://api.github.com/users/sambostock","html_url":"https://github.com/sambostock","followers_url":"https://api.github.com/users/sambostock/followers","following_url":"https://api.github.com/users/sambostock/following{/other_user}","gists_url":"https://api.github.com/users/sambostock/gists{/gist_id}","starred_url":"https://api.github.com/users/sambostock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambostock/subscriptions","organizations_url":"https://api.github.com/users/sambostock/orgs","repos_url":"https://api.github.com/users/sambostock/repos","events_url":"https://api.github.com/users/sambostock/events{/privacy}","received_events_url":"https://api.github.com/users/sambostock/received_events","type":"User","site_admin":false},"repo":{"id":41779351,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc3OTM1MQ==","name":"rails","full_name":"sambostock/rails","private":false,"owner":{"login":"sambostock","id":8219340,"node_id":"MDQ6VXNlcjgyMTkzNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/8219340?v=4","gravatar_id":"","url":"https://api.github.com/users/sambostock","html_url":"https://github.com/sambostock","followers_url":"https://api.github.com/users/sambostock/followers","following_url":"https://api.github.com/users/sambostock/following{/other_user}","gists_url":"https://api.github.com/users/sambostock/gists{/gist_id}","starred_url":"https://api.github.com/users/sambostock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambostock/subscriptions","organizations_url":"https://api.github.com/users/sambostock/orgs","repos_url":"https://api.github.com/users/sambostock/repos","events_url":"https://api.github.com/users/sambostock/events{/privacy}","received_events_url":"https://api.github.com/users/sambostock/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sambostock/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/sambostock/rails","forks_url":"https://api.github.com/repos/sambostock/rails/forks","keys_url":"https://api.github.com/repos/sambostock/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sambostock/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sambostock/rails/teams","hooks_url":"https://api.github.com/repos/sambostock/rails/hooks","issue_events_url":"https://api.github.com/repos/sambostock/rails/issues/events{/number}","events_url":"https://api.github.com/repos/sambostock/rails/events","assignees_url":"https://api.github.com/repos/sambostock/rails/assignees{/user}","branches_url":"https://api.github.com/repos/sambostock/rails/branches{/branch}","tags_url":"https://api.github.com/repos/sambostock/rails/tags","blobs_url":"https://api.github.com/repos/sambostock/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sambostock/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sambostock/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/sambostock/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sambostock/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/sambostock/rails/languages","stargazers_url":"https://api.github.com/repos/sambostock/rails/stargazers","contributors_url":"https://api.github.com/repos/sambostock/rails/contributors","subscribers_url":"https://api.github.com/repos/sambostock/rails/subscribers","subscription_url":"https://api.github.com/repos/sambostock/rails/subscription","commits_url":"https://api.github.com/repos/sambostock/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/sambostock/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/sambostock/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/sambostock/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/sambostock/rails/contents/{+path}","compare_url":"https://api.github.com/repos/sambostock/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sambostock/rails/merges","archive_url":"https://api.github.com/repos/sambostock/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sambostock/rails/downloads","issues_url":"https://api.github.com/repos/sambostock/rails/issues{/number}","pulls_url":"https://api.github.com/repos/sambostock/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/sambostock/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/sambostock/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sambostock/rails/labels{/name}","releases_url":"https://api.github.com/repos/sambostock/rails/releases{/id}","deployments_url":"https://api.github.com/repos/sambostock/rails/deployments","created_at":"2015-09-02T04:12:59Z","updated_at":"2018-12-04T22:05:42Z","pushed_at":"2018-12-10T23:27:30Z","git_url":"git://github.com/sambostock/rails.git","ssh_url":"git@github.com:sambostock/rails.git","clone_url":"https://github.com/sambostock/rails.git","svn_url":"https://github.com/sambostock/rails","homepage":"http://rubyonrails.org","size":168629,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"d92331e3b78c4b3175b6a4430801632ff19b0bfc","user":{"login":"rails","id":4223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"node_id":"MDEwOlJlcG9zaXRvcnk4NTE0","name":"rails","full_name":"rails/rails","private":false,"owner":{"login":"rails","id":4223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2018-12-10T23:47:42Z","pushed_at":"2018-12-11T00:03:30Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"https://rubyonrails.org","size":168766,"stargazers_count":41596,"watchers_count":41596,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16816,"mirror_url":null,"archived":false,"open_issues_count":1020,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16816,"open_issues":1020,"watchers":41596,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/34670"},"html":{"href":"https://github.com/rails/rails/pull/34670"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/34670"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/34670/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/34670/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/34670/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/f2935b399be87d7acfc6067a73cfe11e7d4bbdec"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rafaelfranca","id":47848,"node_id":"MDQ6VXNlcjQ3ODQ4","avatar_url":"https://avatars3.githubusercontent.com/u/47848?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"rafaelfranca"}}