{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/174365517","pull_request_review_id":103706097,"id":174365517,"diff_hunk":"@@ -51,19 +52,19 @@\n \n     ReadableByteChannel open() throws IOException\n     {\n-        Optional<PagedFile> existingMapping = pageCache.getExistingMapping( file );\n-        if ( existingMapping.isPresent() )\n+        boolean isDefaultFileSystem = pageCache.getCachedFileSystem() instanceof DefaultFileSystemAbstraction;\n+        if ( !isDefaultFileSystem )","path":"enterprise/causal-clustering/src/main/java/org/neo4j/causalclustering/catchup/storecopy/StoreResource.java","position":15,"original_position":15,"commit_id":"642755c4d3f4ff304961c121ea6068b11b497e5f","original_commit_id":"642755c4d3f4ff304961c121ea6068b11b497e5f","user":{"login":"klaren","id":798957,"avatar_url":"https://avatars0.githubusercontent.com/u/798957?v=4","gravatar_id":"","url":"https://api.github.com/users/klaren","html_url":"https://github.com/klaren","followers_url":"https://api.github.com/users/klaren/followers","following_url":"https://api.github.com/users/klaren/following{/other_user}","gists_url":"https://api.github.com/users/klaren/gists{/gist_id}","starred_url":"https://api.github.com/users/klaren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaren/subscriptions","organizations_url":"https://api.github.com/users/klaren/orgs","repos_url":"https://api.github.com/users/klaren/repos","events_url":"https://api.github.com/users/klaren/events{/privacy}","received_events_url":"https://api.github.com/users/klaren/received_events","type":"User","site_admin":false},"body":"This is sadly the only way I found to get rid of the otherwise duplicate code. Current contract with the `pageCache.getExistingMapping()` is that if `isPresent()` is true, you have to call `close()` on the object inside the optional.","created_at":"2018-03-14T06:51:58Z","updated_at":"2018-03-14T06:51:58Z","html_url":"https://github.com/neo4j/neo4j/pull/11231#discussion_r174365517","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11231","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/174365517"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11231#discussion_r174365517"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11231"}},"in_reply_to_id":174240472},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/11231","id":174604060,"html_url":"https://github.com/neo4j/neo4j/pull/11231","diff_url":"https://github.com/neo4j/neo4j/pull/11231.diff","patch_url":"https://github.com/neo4j/neo4j/pull/11231.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/11231","number":11231,"state":"open","locked":false,"title":"Do backup through FileSystemAbstraction if applicable ","user":{"login":"klaren","id":798957,"avatar_url":"https://avatars0.githubusercontent.com/u/798957?v=4","gravatar_id":"","url":"https://api.github.com/users/klaren","html_url":"https://github.com/klaren","followers_url":"https://api.github.com/users/klaren/followers","following_url":"https://api.github.com/users/klaren/following{/other_user}","gists_url":"https://api.github.com/users/klaren/gists{/gist_id}","starred_url":"https://api.github.com/users/klaren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaren/subscriptions","organizations_url":"https://api.github.com/users/klaren/orgs","repos_url":"https://api.github.com/users/klaren/repos","events_url":"https://api.github.com/users/klaren/events{/privacy}","received_events_url":"https://api.github.com/users/klaren/received_events","type":"User","site_admin":false},"body":"Doing backup through the page cache was a necessary change to support block devices, however, this introduced an overhead in cases where it wasn't necessary. This commit will revert the behavior to the old way of doing things unless the underlying filesystem is not the default one, i.e. block device file system.","created_at":"2018-03-13T09:44:10Z","updated_at":"2018-03-14T06:51:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b6459fc463424f5db9657146c7715caab44fba8","assignee":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars2.githubusercontent.com/u/12656787?v=4","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"assignees":[{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars2.githubusercontent.com/u/12656787?v=4","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":556879276,"url":"https://api.github.com/repos/neo4j/neo4j/labels/3.3","name":"3.3","color":"FF7256","default":false},{"id":647068085,"url":"https://api.github.com/repos/neo4j/neo4j/labels/team-kernel","name":"team-kernel","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11231/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11231/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/11231/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/642755c4d3f4ff304961c121ea6068b11b497e5f","head":{"label":"klaren:3.3-backup-no-pc","ref":"3.3-backup-no-pc","sha":"642755c4d3f4ff304961c121ea6068b11b497e5f","user":{"login":"klaren","id":798957,"avatar_url":"https://avatars0.githubusercontent.com/u/798957?v=4","gravatar_id":"","url":"https://api.github.com/users/klaren","html_url":"https://github.com/klaren","followers_url":"https://api.github.com/users/klaren/followers","following_url":"https://api.github.com/users/klaren/following{/other_user}","gists_url":"https://api.github.com/users/klaren/gists{/gist_id}","starred_url":"https://api.github.com/users/klaren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaren/subscriptions","organizations_url":"https://api.github.com/users/klaren/orgs","repos_url":"https://api.github.com/users/klaren/repos","events_url":"https://api.github.com/users/klaren/events{/privacy}","received_events_url":"https://api.github.com/users/klaren/received_events","type":"User","site_admin":false},"repo":{"id":90008939,"name":"neo4j","full_name":"klaren/neo4j","owner":{"login":"klaren","id":798957,"avatar_url":"https://avatars0.githubusercontent.com/u/798957?v=4","gravatar_id":"","url":"https://api.github.com/users/klaren","html_url":"https://github.com/klaren","followers_url":"https://api.github.com/users/klaren/followers","following_url":"https://api.github.com/users/klaren/following{/other_user}","gists_url":"https://api.github.com/users/klaren/gists{/gist_id}","starred_url":"https://api.github.com/users/klaren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaren/subscriptions","organizations_url":"https://api.github.com/users/klaren/orgs","repos_url":"https://api.github.com/users/klaren/repos","events_url":"https://api.github.com/users/klaren/events{/privacy}","received_events_url":"https://api.github.com/users/klaren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/klaren/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/klaren/neo4j","forks_url":"https://api.github.com/repos/klaren/neo4j/forks","keys_url":"https://api.github.com/repos/klaren/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klaren/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klaren/neo4j/teams","hooks_url":"https://api.github.com/repos/klaren/neo4j/hooks","issue_events_url":"https://api.github.com/repos/klaren/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/klaren/neo4j/events","assignees_url":"https://api.github.com/repos/klaren/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/klaren/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/klaren/neo4j/tags","blobs_url":"https://api.github.com/repos/klaren/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klaren/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klaren/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/klaren/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klaren/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/klaren/neo4j/languages","stargazers_url":"https://api.github.com/repos/klaren/neo4j/stargazers","contributors_url":"https://api.github.com/repos/klaren/neo4j/contributors","subscribers_url":"https://api.github.com/repos/klaren/neo4j/subscribers","subscription_url":"https://api.github.com/repos/klaren/neo4j/subscription","commits_url":"https://api.github.com/repos/klaren/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/klaren/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/klaren/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/klaren/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/klaren/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/klaren/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klaren/neo4j/merges","archive_url":"https://api.github.com/repos/klaren/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klaren/neo4j/downloads","issues_url":"https://api.github.com/repos/klaren/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/klaren/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/klaren/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/klaren/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klaren/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/klaren/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/klaren/neo4j/deployments","created_at":"2017-05-02T08:22:41Z","updated_at":"2017-05-02T08:23:12Z","pushed_at":"2018-03-13T15:46:10Z","git_url":"git://github.com/klaren/neo4j.git","ssh_url":"git@github.com:klaren/neo4j.git","clone_url":"https://github.com/klaren/neo4j.git","svn_url":"https://github.com/klaren/neo4j","homepage":"http://neo4j.com","size":391567,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.4"}},"base":{"label":"neo4j:3.3","ref":"3.3","sha":"6a326c06ed1e5e390ff4a4a29e757b257b3644a0","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2018-03-14T06:50:10Z","pushed_at":"2018-03-14T06:49:59Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":393841,"stargazers_count":4814,"watchers_count":4814,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1301,"mirror_url":null,"archived":false,"open_issues_count":332,"license":null,"forks":1301,"open_issues":332,"watchers":4814,"default_branch":"3.4"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11231"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11231"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11231"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11231/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11231/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11231/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/642755c4d3f4ff304961c121ea6068b11b497e5f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"klaren"}}