{"action":"created","comment":{"url":"https://api.github.com/repos/softdevteam/hwtracer/pulls/comments/177439418","pull_request_review_id":107308748,"id":177439418,"diff_hunk":"@@ -99,6 +101,32 @@ fn fetch_libipt() {\n     env::set_current_dir(&Path::new(\"..\")).unwrap();\n }\n \n+// Checks if the CPU supports Intel Processor Trace.\n+// We use this to decide whether to run the perf_pt backend tests. Although this would be better as\n+// a runtime check, it's OK since we won't distribute the test binary.","path":"build.rs","position":15,"original_position":15,"commit_id":"1d4326e18887bdd1522530e16ec1712a9d51ee45","original_commit_id":"1d4326e18887bdd1522530e16ec1712a9d51ee45","user":{"login":"vext01","id":604955,"avatar_url":"https://avatars2.githubusercontent.com/u/604955?v=4","gravatar_id":"","url":"https://api.github.com/users/vext01","html_url":"https://github.com/vext01","followers_url":"https://api.github.com/users/vext01/followers","following_url":"https://api.github.com/users/vext01/following{/other_user}","gists_url":"https://api.github.com/users/vext01/gists{/gist_id}","starred_url":"https://api.github.com/users/vext01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vext01/subscriptions","organizations_url":"https://api.github.com/users/vext01/orgs","repos_url":"https://api.github.com/users/vext01/repos","events_url":"https://api.github.com/users/vext01/events{/privacy}","received_events_url":"https://api.github.com/users/vext01/received_events","type":"User","site_admin":false},"body":"We could collapse it into one, but it would mean that we can't distribute binaries if the build system has no PT on the chip.","created_at":"2018-03-27T14:12:59Z","updated_at":"2018-03-27T14:12:59Z","html_url":"https://github.com/softdevteam/hwtracer/pull/52#discussion_r177439418","pull_request_url":"https://api.github.com/repos/softdevteam/hwtracer/pulls/52","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/softdevteam/hwtracer/pulls/comments/177439418"},"html":{"href":"https://github.com/softdevteam/hwtracer/pull/52#discussion_r177439418"},"pull_request":{"href":"https://api.github.com/repos/softdevteam/hwtracer/pulls/52"}},"in_reply_to_id":177431748},"pull_request":{"url":"https://api.github.com/repos/softdevteam/hwtracer/pulls/52","id":176860904,"html_url":"https://github.com/softdevteam/hwtracer/pull/52","diff_url":"https://github.com/softdevteam/hwtracer/pull/52.diff","patch_url":"https://github.com/softdevteam/hwtracer/pull/52.patch","issue_url":"https://api.github.com/repos/softdevteam/hwtracer/issues/52","number":52,"state":"open","locked":false,"title":"Use a macro to skip tests if the CPU doesn't talk PT.","user":{"login":"vext01","id":604955,"avatar_url":"https://avatars2.githubusercontent.com/u/604955?v=4","gravatar_id":"","url":"https://api.github.com/users/vext01","html_url":"https://github.com/vext01","followers_url":"https://api.github.com/users/vext01/followers","following_url":"https://api.github.com/users/vext01/following{/other_user}","gists_url":"https://api.github.com/users/vext01/gists{/gist_id}","starred_url":"https://api.github.com/users/vext01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vext01/subscriptions","organizations_url":"https://api.github.com/users/vext01/orgs","repos_url":"https://api.github.com/users/vext01/repos","events_url":"https://api.github.com/users/vext01/events{/privacy}","received_events_url":"https://api.github.com/users/vext01/received_events","type":"User","site_admin":false},"body":"Simplifies the tests a fair amount. Looks good?","created_at":"2018-03-22T17:53:42Z","updated_at":"2018-03-27T14:12:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6d0f0cb36c83c00d3278754a8fbefd628718753","assignee":{"login":"ltratt","id":20318,"avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"assignees":[{"login":"ltratt","id":20318,"avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/softdevteam/hwtracer/pulls/52/commits","review_comments_url":"https://api.github.com/repos/softdevteam/hwtracer/pulls/52/comments","review_comment_url":"https://api.github.com/repos/softdevteam/hwtracer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/softdevteam/hwtracer/issues/52/comments","statuses_url":"https://api.github.com/repos/softdevteam/hwtracer/statuses/1d4326e18887bdd1522530e16ec1712a9d51ee45","head":{"label":"softdevteam:pt-detect-macro2","ref":"pt-detect-macro2","sha":"1d4326e18887bdd1522530e16ec1712a9d51ee45","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":111116225,"name":"hwtracer","full_name":"softdevteam/hwtracer","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/hwtracer","description":"Trace a program using CPU tracer technology.","fork":false,"url":"https://api.github.com/repos/softdevteam/hwtracer","forks_url":"https://api.github.com/repos/softdevteam/hwtracer/forks","keys_url":"https://api.github.com/repos/softdevteam/hwtracer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/hwtracer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/hwtracer/teams","hooks_url":"https://api.github.com/repos/softdevteam/hwtracer/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/hwtracer/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/hwtracer/events","assignees_url":"https://api.github.com/repos/softdevteam/hwtracer/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/hwtracer/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/hwtracer/tags","blobs_url":"https://api.github.com/repos/softdevteam/hwtracer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/hwtracer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/hwtracer/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/hwtracer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/hwtracer/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/hwtracer/languages","stargazers_url":"https://api.github.com/repos/softdevteam/hwtracer/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/hwtracer/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/hwtracer/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/hwtracer/subscription","commits_url":"https://api.github.com/repos/softdevteam/hwtracer/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/hwtracer/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/hwtracer/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/hwtracer/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/hwtracer/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/hwtracer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/hwtracer/merges","archive_url":"https://api.github.com/repos/softdevteam/hwtracer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/hwtracer/downloads","issues_url":"https://api.github.com/repos/softdevteam/hwtracer/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/hwtracer/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/hwtracer/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/hwtracer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/hwtracer/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/hwtracer/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/hwtracer/deployments","created_at":"2017-11-17T15:03:17Z","updated_at":"2018-03-22T17:11:48Z","pushed_at":"2018-03-27T13:41:14Z","git_url":"git://github.com/softdevteam/hwtracer.git","ssh_url":"git@github.com:softdevteam/hwtracer.git","clone_url":"https://github.com/softdevteam/hwtracer.git","svn_url":"https://github.com/softdevteam/hwtracer","homepage":"","size":117,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"softdevteam:master","ref":"master","sha":"ff5b79bbab6f394e7c194cadbdc5544f085f5d78","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":111116225,"name":"hwtracer","full_name":"softdevteam/hwtracer","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/hwtracer","description":"Trace a program using CPU tracer technology.","fork":false,"url":"https://api.github.com/repos/softdevteam/hwtracer","forks_url":"https://api.github.com/repos/softdevteam/hwtracer/forks","keys_url":"https://api.github.com/repos/softdevteam/hwtracer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/hwtracer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/hwtracer/teams","hooks_url":"https://api.github.com/repos/softdevteam/hwtracer/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/hwtracer/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/hwtracer/events","assignees_url":"https://api.github.com/repos/softdevteam/hwtracer/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/hwtracer/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/hwtracer/tags","blobs_url":"https://api.github.com/repos/softdevteam/hwtracer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/hwtracer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/hwtracer/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/hwtracer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/hwtracer/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/hwtracer/languages","stargazers_url":"https://api.github.com/repos/softdevteam/hwtracer/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/hwtracer/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/hwtracer/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/hwtracer/subscription","commits_url":"https://api.github.com/repos/softdevteam/hwtracer/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/hwtracer/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/hwtracer/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/hwtracer/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/hwtracer/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/hwtracer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/hwtracer/merges","archive_url":"https://api.github.com/repos/softdevteam/hwtracer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/hwtracer/downloads","issues_url":"https://api.github.com/repos/softdevteam/hwtracer/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/hwtracer/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/hwtracer/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/hwtracer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/hwtracer/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/hwtracer/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/hwtracer/deployments","created_at":"2017-11-17T15:03:17Z","updated_at":"2018-03-22T17:11:48Z","pushed_at":"2018-03-27T13:41:14Z","git_url":"git://github.com/softdevteam/hwtracer.git","ssh_url":"git@github.com:softdevteam/hwtracer.git","clone_url":"https://github.com/softdevteam/hwtracer.git","svn_url":"https://github.com/softdevteam/hwtracer","homepage":"","size":117,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/softdevteam/hwtracer/pulls/52"},"html":{"href":"https://github.com/softdevteam/hwtracer/pull/52"},"issue":{"href":"https://api.github.com/repos/softdevteam/hwtracer/issues/52"},"comments":{"href":"https://api.github.com/repos/softdevteam/hwtracer/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/softdevteam/hwtracer/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/softdevteam/hwtracer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/softdevteam/hwtracer/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/softdevteam/hwtracer/statuses/1d4326e18887bdd1522530e16ec1712a9d51ee45"}},"author_association":"OWNER"}}
{"actor":{"display_login":"vext01"}}