{"action":"closed","number":518,"pull_request":{"url":"https://api.github.com/repos/gcarq/freqtrade/pulls/518","id":169704277,"html_url":"https://github.com/gcarq/freqtrade/pull/518","diff_url":"https://github.com/gcarq/freqtrade/pull/518.diff","patch_url":"https://github.com/gcarq/freqtrade/pull/518.patch","issue_url":"https://api.github.com/repos/gcarq/freqtrade/issues/518","number":518,"state":"closed","locked":false,"title":"Cleaning up backtesting/hyperopt","user":{"login":"vertti","id":557751,"avatar_url":"https://avatars0.githubusercontent.com/u/557751?v=4","gravatar_id":"","url":"https://api.github.com/users/vertti","html_url":"https://github.com/vertti","followers_url":"https://api.github.com/users/vertti/followers","following_url":"https://api.github.com/users/vertti/following{/other_user}","gists_url":"https://api.github.com/users/vertti/gists{/gist_id}","starred_url":"https://api.github.com/users/vertti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertti/subscriptions","organizations_url":"https://api.github.com/users/vertti/orgs","repos_url":"https://api.github.com/users/vertti/repos","events_url":"https://api.github.com/users/vertti/events{/privacy}","received_events_url":"https://api.github.com/users/vertti/received_events","type":"User","site_admin":false},"body":"Few fixes and refactorings to Hyperopt and backtesting to make the results match between them:\r\n\r\n- change realistic simulation to default to false and allow enabling it from both hyperopt and backtesting with `--realistic-simulation`\r\n- combine CLI flags that are shared by both hyperopt and backtesting\r\n- make CLI flags available to the optimizer in hyperopt\r\n- use `--spaces` flag properly in hyperopt instead of hacky guessing from `params`\r\n- fix that backtest ignored the given stoploss\r\n\r\nAfter this PR, the call to backtest is quite different from Hyperopt than it is from backtesting.py, but these cleanups are necessary prework.\r\n","created_at":"2018-02-16T19:18:06Z","updated_at":"2018-02-18T08:18:01Z","closed_at":"2018-02-18T08:18:01Z","merged_at":"2018-02-18T08:18:01Z","merge_commit_sha":"35c51c73f713bfdb81bd84721f3dceab0c19e819","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gcarq/freqtrade/pulls/518/commits","review_comments_url":"https://api.github.com/repos/gcarq/freqtrade/pulls/518/comments","review_comment_url":"https://api.github.com/repos/gcarq/freqtrade/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gcarq/freqtrade/issues/518/comments","statuses_url":"https://api.github.com/repos/gcarq/freqtrade/statuses/fac122891f91d89ec29565f572abe6241c23ea35","head":{"label":"gcarq:cleaning_up_backtesting","ref":"cleaning_up_backtesting","sha":"fac122891f91d89ec29565f572abe6241c23ea35","user":{"login":"gcarq","id":4720529,"avatar_url":"https://avatars3.githubusercontent.com/u/4720529?v=4","gravatar_id":"","url":"https://api.github.com/users/gcarq","html_url":"https://github.com/gcarq","followers_url":"https://api.github.com/users/gcarq/followers","following_url":"https://api.github.com/users/gcarq/following{/other_user}","gists_url":"https://api.github.com/users/gcarq/gists{/gist_id}","starred_url":"https://api.github.com/users/gcarq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcarq/subscriptions","organizations_url":"https://api.github.com/users/gcarq/orgs","repos_url":"https://api.github.com/users/gcarq/repos","events_url":"https://api.github.com/users/gcarq/events{/privacy}","received_events_url":"https://api.github.com/users/gcarq/received_events","type":"User","site_admin":false},"repo":{"id":91629816,"name":"freqtrade","full_name":"gcarq/freqtrade","owner":{"login":"gcarq","id":4720529,"avatar_url":"https://avatars3.githubusercontent.com/u/4720529?v=4","gravatar_id":"","url":"https://api.github.com/users/gcarq","html_url":"https://github.com/gcarq","followers_url":"https://api.github.com/users/gcarq/followers","following_url":"https://api.github.com/users/gcarq/following{/other_user}","gists_url":"https://api.github.com/users/gcarq/gists{/gist_id}","starred_url":"https://api.github.com/users/gcarq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcarq/subscriptions","organizations_url":"https://api.github.com/users/gcarq/orgs","repos_url":"https://api.github.com/users/gcarq/repos","events_url":"https://api.github.com/users/gcarq/events{/privacy}","received_events_url":"https://api.github.com/users/gcarq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gcarq/freqtrade","description":"Simple High Frequency Trading Bot for crypto currencies","fork":false,"url":"https://api.github.com/repos/gcarq/freqtrade","forks_url":"https://api.github.com/repos/gcarq/freqtrade/forks","keys_url":"https://api.github.com/repos/gcarq/freqtrade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcarq/freqtrade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcarq/freqtrade/teams","hooks_url":"https://api.github.com/repos/gcarq/freqtrade/hooks","issue_events_url":"https://api.github.com/repos/gcarq/freqtrade/issues/events{/number}","events_url":"https://api.github.com/repos/gcarq/freqtrade/events","assignees_url":"https://api.github.com/repos/gcarq/freqtrade/assignees{/user}","branches_url":"https://api.github.com/repos/gcarq/freqtrade/branches{/branch}","tags_url":"https://api.github.com/repos/gcarq/freqtrade/tags","blobs_url":"https://api.github.com/repos/gcarq/freqtrade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcarq/freqtrade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcarq/freqtrade/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcarq/freqtrade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcarq/freqtrade/statuses/{sha}","languages_url":"https://api.github.com/repos/gcarq/freqtrade/languages","stargazers_url":"https://api.github.com/repos/gcarq/freqtrade/stargazers","contributors_url":"https://api.github.com/repos/gcarq/freqtrade/contributors","subscribers_url":"https://api.github.com/repos/gcarq/freqtrade/subscribers","subscription_url":"https://api.github.com/repos/gcarq/freqtrade/subscription","commits_url":"https://api.github.com/repos/gcarq/freqtrade/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcarq/freqtrade/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcarq/freqtrade/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcarq/freqtrade/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcarq/freqtrade/contents/{+path}","compare_url":"https://api.github.com/repos/gcarq/freqtrade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcarq/freqtrade/merges","archive_url":"https://api.github.com/repos/gcarq/freqtrade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcarq/freqtrade/downloads","issues_url":"https://api.github.com/repos/gcarq/freqtrade/issues{/number}","pulls_url":"https://api.github.com/repos/gcarq/freqtrade/pulls{/number}","milestones_url":"https://api.github.com/repos/gcarq/freqtrade/milestones{/number}","notifications_url":"https://api.github.com/repos/gcarq/freqtrade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcarq/freqtrade/labels{/name}","releases_url":"https://api.github.com/repos/gcarq/freqtrade/releases{/id}","deployments_url":"https://api.github.com/repos/gcarq/freqtrade/deployments","created_at":"2017-05-17T23:48:53Z","updated_at":"2018-02-18T06:34:30Z","pushed_at":"2018-02-18T08:18:01Z","git_url":"git://github.com/gcarq/freqtrade.git","ssh_url":"git@github.com:gcarq/freqtrade.git","clone_url":"https://github.com/gcarq/freqtrade.git","svn_url":"https://github.com/gcarq/freqtrade","homepage":null,"size":23269,"stargazers_count":551,"watchers_count":551,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":187,"open_issues":71,"watchers":551,"default_branch":"develop"}},"base":{"label":"gcarq:develop","ref":"develop","sha":"028700d86f130d5c3cbfef4e422dc701340f58c9","user":{"login":"gcarq","id":4720529,"avatar_url":"https://avatars3.githubusercontent.com/u/4720529?v=4","gravatar_id":"","url":"https://api.github.com/users/gcarq","html_url":"https://github.com/gcarq","followers_url":"https://api.github.com/users/gcarq/followers","following_url":"https://api.github.com/users/gcarq/following{/other_user}","gists_url":"https://api.github.com/users/gcarq/gists{/gist_id}","starred_url":"https://api.github.com/users/gcarq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcarq/subscriptions","organizations_url":"https://api.github.com/users/gcarq/orgs","repos_url":"https://api.github.com/users/gcarq/repos","events_url":"https://api.github.com/users/gcarq/events{/privacy}","received_events_url":"https://api.github.com/users/gcarq/received_events","type":"User","site_admin":false},"repo":{"id":91629816,"name":"freqtrade","full_name":"gcarq/freqtrade","owner":{"login":"gcarq","id":4720529,"avatar_url":"https://avatars3.githubusercontent.com/u/4720529?v=4","gravatar_id":"","url":"https://api.github.com/users/gcarq","html_url":"https://github.com/gcarq","followers_url":"https://api.github.com/users/gcarq/followers","following_url":"https://api.github.com/users/gcarq/following{/other_user}","gists_url":"https://api.github.com/users/gcarq/gists{/gist_id}","starred_url":"https://api.github.com/users/gcarq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcarq/subscriptions","organizations_url":"https://api.github.com/users/gcarq/orgs","repos_url":"https://api.github.com/users/gcarq/repos","events_url":"https://api.github.com/users/gcarq/events{/privacy}","received_events_url":"https://api.github.com/users/gcarq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gcarq/freqtrade","description":"Simple High Frequency Trading Bot for crypto currencies","fork":false,"url":"https://api.github.com/repos/gcarq/freqtrade","forks_url":"https://api.github.com/repos/gcarq/freqtrade/forks","keys_url":"https://api.github.com/repos/gcarq/freqtrade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcarq/freqtrade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcarq/freqtrade/teams","hooks_url":"https://api.github.com/repos/gcarq/freqtrade/hooks","issue_events_url":"https://api.github.com/repos/gcarq/freqtrade/issues/events{/number}","events_url":"https://api.github.com/repos/gcarq/freqtrade/events","assignees_url":"https://api.github.com/repos/gcarq/freqtrade/assignees{/user}","branches_url":"https://api.github.com/repos/gcarq/freqtrade/branches{/branch}","tags_url":"https://api.github.com/repos/gcarq/freqtrade/tags","blobs_url":"https://api.github.com/repos/gcarq/freqtrade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcarq/freqtrade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcarq/freqtrade/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcarq/freqtrade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcarq/freqtrade/statuses/{sha}","languages_url":"https://api.github.com/repos/gcarq/freqtrade/languages","stargazers_url":"https://api.github.com/repos/gcarq/freqtrade/stargazers","contributors_url":"https://api.github.com/repos/gcarq/freqtrade/contributors","subscribers_url":"https://api.github.com/repos/gcarq/freqtrade/subscribers","subscription_url":"https://api.github.com/repos/gcarq/freqtrade/subscription","commits_url":"https://api.github.com/repos/gcarq/freqtrade/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcarq/freqtrade/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcarq/freqtrade/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcarq/freqtrade/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcarq/freqtrade/contents/{+path}","compare_url":"https://api.github.com/repos/gcarq/freqtrade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcarq/freqtrade/merges","archive_url":"https://api.github.com/repos/gcarq/freqtrade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcarq/freqtrade/downloads","issues_url":"https://api.github.com/repos/gcarq/freqtrade/issues{/number}","pulls_url":"https://api.github.com/repos/gcarq/freqtrade/pulls{/number}","milestones_url":"https://api.github.com/repos/gcarq/freqtrade/milestones{/number}","notifications_url":"https://api.github.com/repos/gcarq/freqtrade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcarq/freqtrade/labels{/name}","releases_url":"https://api.github.com/repos/gcarq/freqtrade/releases{/id}","deployments_url":"https://api.github.com/repos/gcarq/freqtrade/deployments","created_at":"2017-05-17T23:48:53Z","updated_at":"2018-02-18T06:34:30Z","pushed_at":"2018-02-18T08:18:01Z","git_url":"git://github.com/gcarq/freqtrade.git","ssh_url":"git@github.com:gcarq/freqtrade.git","clone_url":"https://github.com/gcarq/freqtrade.git","svn_url":"https://github.com/gcarq/freqtrade","homepage":null,"size":23269,"stargazers_count":551,"watchers_count":551,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":187,"open_issues":71,"watchers":551,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gcarq/freqtrade/pulls/518"},"html":{"href":"https://github.com/gcarq/freqtrade/pull/518"},"issue":{"href":"https://api.github.com/repos/gcarq/freqtrade/issues/518"},"comments":{"href":"https://api.github.com/repos/gcarq/freqtrade/issues/518/comments"},"review_comments":{"href":"https://api.github.com/repos/gcarq/freqtrade/pulls/518/comments"},"review_comment":{"href":"https://api.github.com/repos/gcarq/freqtrade/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gcarq/freqtrade/pulls/518/commits"},"statuses":{"href":"https://api.github.com/repos/gcarq/freqtrade/statuses/fac122891f91d89ec29565f572abe6241c23ea35"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"shusso","id":590002,"avatar_url":"https://avatars0.githubusercontent.com/u/590002?v=4","gravatar_id":"","url":"https://api.github.com/users/shusso","html_url":"https://github.com/shusso","followers_url":"https://api.github.com/users/shusso/followers","following_url":"https://api.github.com/users/shusso/following{/other_user}","gists_url":"https://api.github.com/users/shusso/gists{/gist_id}","starred_url":"https://api.github.com/users/shusso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shusso/subscriptions","organizations_url":"https://api.github.com/users/shusso/orgs","repos_url":"https://api.github.com/users/shusso/repos","events_url":"https://api.github.com/users/shusso/events{/privacy}","received_events_url":"https://api.github.com/users/shusso/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":60,"deletions":69,"changed_files":3}}
{"actor":{"display_login":"shusso"}}