{"action":"created","comment":{"url":"https://api.github.com/repos/wmde/wikibase-docker/pulls/comments/190629429","pull_request_review_id":123046933,"id":190629429,"diff_hunk":"@@ -12,6 +12,7 @@ env:\n  - IMAGE_PATH=wdqs-proxy/latest/\n \n script:\n+ - bash ./$IMAGE_PATH/.travis/lint.sh","path":".travis.yml","position":4,"original_position":4,"commit_id":"63283eb66cd56b0c45cbc38a1015dd66552e36ad","original_commit_id":"2f4d497e7e8e612d3d68b004f4972b2de026ff6d","user":{"login":"tarrow","id":7353563,"avatar_url":"https://avatars1.githubusercontent.com/u/7353563?v=4","gravatar_id":"","url":"https://api.github.com/users/tarrow","html_url":"https://github.com/tarrow","followers_url":"https://api.github.com/users/tarrow/followers","following_url":"https://api.github.com/users/tarrow/following{/other_user}","gists_url":"https://api.github.com/users/tarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/tarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarrow/subscriptions","organizations_url":"https://api.github.com/users/tarrow/orgs","repos_url":"https://api.github.com/users/tarrow/repos","events_url":"https://api.github.com/users/tarrow/events{/privacy}","received_events_url":"https://api.github.com/users/tarrow/received_events","type":"User","site_admin":false},"body":"Sure, I've tweaked it so it runs all the lint.sh scripts in prebuild.\r\n\r\nI've kept the lint.sh script separate because I think we'll want to put other linters than docker in there.","created_at":"2018-05-24T15:25:37Z","updated_at":"2018-05-24T15:25:37Z","html_url":"https://github.com/wmde/wikibase-docker/pull/26#discussion_r190629429","pull_request_url":"https://api.github.com/repos/wmde/wikibase-docker/pulls/26","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wmde/wikibase-docker/pulls/comments/190629429"},"html":{"href":"https://github.com/wmde/wikibase-docker/pull/26#discussion_r190629429"},"pull_request":{"href":"https://api.github.com/repos/wmde/wikibase-docker/pulls/26"}},"in_reply_to_id":190241734},"pull_request":{"url":"https://api.github.com/repos/wmde/wikibase-docker/pulls/26","id":189904623,"html_url":"https://github.com/wmde/wikibase-docker/pull/26","diff_url":"https://github.com/wmde/wikibase-docker/pull/26.diff","patch_url":"https://github.com/wmde/wikibase-docker/pull/26.patch","issue_url":"https://api.github.com/repos/wmde/wikibase-docker/issues/26","number":26,"state":"open","locked":false,"title":"Make Travis lint Dockerfiles with hadolint","user":{"login":"tarrow","id":7353563,"avatar_url":"https://avatars1.githubusercontent.com/u/7353563?v=4","gravatar_id":"","url":"https://api.github.com/users/tarrow","html_url":"https://github.com/tarrow","followers_url":"https://api.github.com/users/tarrow/followers","following_url":"https://api.github.com/users/tarrow/following{/other_user}","gists_url":"https://api.github.com/users/tarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/tarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarrow/subscriptions","organizations_url":"https://api.github.com/users/tarrow/orgs","repos_url":"https://api.github.com/users/tarrow/repos","events_url":"https://api.github.com/users/tarrow/events{/privacy}","received_events_url":"https://api.github.com/users/tarrow/received_events","type":"User","site_admin":false},"body":"Using the dockerized hadolint and fixing up small changes to the docker files to make them pass linting\r\n\r\nMostly changing `cd` to WORKDIR and pinning versions","created_at":"2018-05-23T09:08:52Z","updated_at":"2018-05-24T15:25:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efe8c99b32ddad1176f6135036690556b86f45df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wmde/wikibase-docker/pulls/26/commits","review_comments_url":"https://api.github.com/repos/wmde/wikibase-docker/pulls/26/comments","review_comment_url":"https://api.github.com/repos/wmde/wikibase-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wmde/wikibase-docker/issues/26/comments","statuses_url":"https://api.github.com/repos/wmde/wikibase-docker/statuses/63283eb66cd56b0c45cbc38a1015dd66552e36ad","head":{"label":"tarrow:docker-linter","ref":"docker-linter","sha":"63283eb66cd56b0c45cbc38a1015dd66552e36ad","user":{"login":"tarrow","id":7353563,"avatar_url":"https://avatars1.githubusercontent.com/u/7353563?v=4","gravatar_id":"","url":"https://api.github.com/users/tarrow","html_url":"https://github.com/tarrow","followers_url":"https://api.github.com/users/tarrow/followers","following_url":"https://api.github.com/users/tarrow/following{/other_user}","gists_url":"https://api.github.com/users/tarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/tarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarrow/subscriptions","organizations_url":"https://api.github.com/users/tarrow/orgs","repos_url":"https://api.github.com/users/tarrow/repos","events_url":"https://api.github.com/users/tarrow/events{/privacy}","received_events_url":"https://api.github.com/users/tarrow/received_events","type":"User","site_admin":false},"repo":{"id":130184407,"name":"wikibase-docker","full_name":"tarrow/wikibase-docker","owner":{"login":"tarrow","id":7353563,"avatar_url":"https://avatars1.githubusercontent.com/u/7353563?v=4","gravatar_id":"","url":"https://api.github.com/users/tarrow","html_url":"https://github.com/tarrow","followers_url":"https://api.github.com/users/tarrow/followers","following_url":"https://api.github.com/users/tarrow/following{/other_user}","gists_url":"https://api.github.com/users/tarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/tarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarrow/subscriptions","organizations_url":"https://api.github.com/users/tarrow/orgs","repos_url":"https://api.github.com/users/tarrow/repos","events_url":"https://api.github.com/users/tarrow/events{/privacy}","received_events_url":"https://api.github.com/users/tarrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tarrow/wikibase-docker","description":"Docker images and compose file for Wikibase and the query service","fork":true,"url":"https://api.github.com/repos/tarrow/wikibase-docker","forks_url":"https://api.github.com/repos/tarrow/wikibase-docker/forks","keys_url":"https://api.github.com/repos/tarrow/wikibase-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tarrow/wikibase-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tarrow/wikibase-docker/teams","hooks_url":"https://api.github.com/repos/tarrow/wikibase-docker/hooks","issue_events_url":"https://api.github.com/repos/tarrow/wikibase-docker/issues/events{/number}","events_url":"https://api.github.com/repos/tarrow/wikibase-docker/events","assignees_url":"https://api.github.com/repos/tarrow/wikibase-docker/assignees{/user}","branches_url":"https://api.github.com/repos/tarrow/wikibase-docker/branches{/branch}","tags_url":"https://api.github.com/repos/tarrow/wikibase-docker/tags","blobs_url":"https://api.github.com/repos/tarrow/wikibase-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tarrow/wikibase-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tarrow/wikibase-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/tarrow/wikibase-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tarrow/wikibase-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/tarrow/wikibase-docker/languages","stargazers_url":"https://api.github.com/repos/tarrow/wikibase-docker/stargazers","contributors_url":"https://api.github.com/repos/tarrow/wikibase-docker/contributors","subscribers_url":"https://api.github.com/repos/tarrow/wikibase-docker/subscribers","subscription_url":"https://api.github.com/repos/tarrow/wikibase-docker/subscription","commits_url":"https://api.github.com/repos/tarrow/wikibase-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/tarrow/wikibase-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/tarrow/wikibase-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/tarrow/wikibase-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/tarrow/wikibase-docker/contents/{+path}","compare_url":"https://api.github.com/repos/tarrow/wikibase-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tarrow/wikibase-docker/merges","archive_url":"https://api.github.com/repos/tarrow/wikibase-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tarrow/wikibase-docker/downloads","issues_url":"https://api.github.com/repos/tarrow/wikibase-docker/issues{/number}","pulls_url":"https://api.github.com/repos/tarrow/wikibase-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/tarrow/wikibase-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/tarrow/wikibase-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tarrow/wikibase-docker/labels{/name}","releases_url":"https://api.github.com/repos/tarrow/wikibase-docker/releases{/id}","deployments_url":"https://api.github.com/repos/tarrow/wikibase-docker/deployments","created_at":"2018-04-19T08:31:57Z","updated_at":"2018-05-08T11:17:04Z","pushed_at":"2018-05-24T15:24:06Z","git_url":"git://github.com/tarrow/wikibase-docker.git","ssh_url":"git@github.com:tarrow/wikibase-docker.git","clone_url":"https://github.com/tarrow/wikibase-docker.git","svn_url":"https://github.com/tarrow/wikibase-docker","homepage":"","size":124,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wmde:master","ref":"master","sha":"b3d5280fd13871c068851e84caab5115962cfad8","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars1.githubusercontent.com/u/664724?v=4","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":92411765,"name":"wikibase-docker","full_name":"wmde/wikibase-docker","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars1.githubusercontent.com/u/664724?v=4","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/wikibase-docker","description":"Docker images and compose file for Wikibase and the query service","fork":false,"url":"https://api.github.com/repos/wmde/wikibase-docker","forks_url":"https://api.github.com/repos/wmde/wikibase-docker/forks","keys_url":"https://api.github.com/repos/wmde/wikibase-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/wikibase-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/wikibase-docker/teams","hooks_url":"https://api.github.com/repos/wmde/wikibase-docker/hooks","issue_events_url":"https://api.github.com/repos/wmde/wikibase-docker/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/wikibase-docker/events","assignees_url":"https://api.github.com/repos/wmde/wikibase-docker/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/wikibase-docker/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/wikibase-docker/tags","blobs_url":"https://api.github.com/repos/wmde/wikibase-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/wikibase-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/wikibase-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/wikibase-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/wikibase-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/wikibase-docker/languages","stargazers_url":"https://api.github.com/repos/wmde/wikibase-docker/stargazers","contributors_url":"https://api.github.com/repos/wmde/wikibase-docker/contributors","subscribers_url":"https://api.github.com/repos/wmde/wikibase-docker/subscribers","subscription_url":"https://api.github.com/repos/wmde/wikibase-docker/subscription","commits_url":"https://api.github.com/repos/wmde/wikibase-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/wikibase-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/wikibase-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/wikibase-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/wikibase-docker/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/wikibase-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/wikibase-docker/merges","archive_url":"https://api.github.com/repos/wmde/wikibase-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/wikibase-docker/downloads","issues_url":"https://api.github.com/repos/wmde/wikibase-docker/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/wikibase-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/wikibase-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/wikibase-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/wikibase-docker/labels{/name}","releases_url":"https://api.github.com/repos/wmde/wikibase-docker/releases{/id}","deployments_url":"https://api.github.com/repos/wmde/wikibase-docker/deployments","created_at":"2017-05-25T14:30:21Z","updated_at":"2018-05-19T14:18:27Z","pushed_at":"2018-05-24T15:24:07Z","git_url":"git://github.com/wmde/wikibase-docker.git","ssh_url":"git@github.com:wmde/wikibase-docker.git","clone_url":"https://github.com/wmde/wikibase-docker.git","svn_url":"https://github.com/wmde/wikibase-docker","homepage":"","size":97,"stargazers_count":45,"watchers_count":45,"language":"Shell","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":10,"open_issues":6,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wmde/wikibase-docker/pulls/26"},"html":{"href":"https://github.com/wmde/wikibase-docker/pull/26"},"issue":{"href":"https://api.github.com/repos/wmde/wikibase-docker/issues/26"},"comments":{"href":"https://api.github.com/repos/wmde/wikibase-docker/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/wmde/wikibase-docker/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/wmde/wikibase-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wmde/wikibase-docker/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/wmde/wikibase-docker/statuses/63283eb66cd56b0c45cbc38a1015dd66552e36ad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tarrow"}}