{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/168905493","pull_request_review_id":97358053,"id":168905493,"diff_hunk":"@@ -1579,8 +1579,14 @@ namespace VectorTools\n                 const Quadrature<dim-1>        &q_boundary,\n                 const bool                      project_to_boundary_first)\n   {\n+#ifdef _MSC_VER\n+    Assert(false, \n+           ExcMessage(\"Please specify the mapping explicitly \"\n+                      \"when building with MSVC!\"));    ","path":"include/deal.II/numerics/vector_tools.templates.h","position":null,"original_position":7,"commit_id":"7e999dfea7d14e467c597b6379dc4f3f3c6846a1","original_commit_id":"db833af6f6346746921c266d322b89f076da4797","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars2.githubusercontent.com/u/7504421?v=4","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"Shame. But I'd say let's go with it. If at one point we have things working on a regular basis and with a regular tester, we can think of a better way.\r\n\r\nUnless, of course, you want to try the obvious alternative\r\n```\r\n#ifdef _MSC_VER\r\n static MappingQ1<dim,spacedim> mapping;\r\n project(mapping, dof, constraints, quadrature, function, vec,\r\n             enforce_zero_boundary, q_boundary, project_to_boundary_first);\r\n#else\r\n```\r\nand see whether that works.","created_at":"2018-02-17T01:08:49Z","updated_at":"2018-02-17T01:08:49Z","html_url":"https://github.com/dealii/dealii/pull/5907#discussion_r168905493","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/5907","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/168905493"},"html":{"href":"https://github.com/dealii/dealii/pull/5907#discussion_r168905493"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/5907"}},"in_reply_to_id":168648289},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/5907","id":169519069,"html_url":"https://github.com/dealii/dealii/pull/5907","diff_url":"https://github.com/dealii/dealii/pull/5907.diff","patch_url":"https://github.com/dealii/dealii/pull/5907.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/5907","number":5907,"state":"open","locked":false,"title":"Fix some warnings and errors reported by MSVC","user":{"login":"masterleinad","id":2423533,"avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false},"body":"These changes allow to compile using Visual Studio 2017 again. \r\n\r\n- `parameter_acceptor.h`: `ParameterAcceptor::prm` was not found specifying the class name\r\n- `grid_tools.h`: missing `Cache::active_cell_iterator` were reported\r\n- `grid_tools.h`: Using `GeometryInfo<structdim>::vertices_per_cell` in a lambda wasn't possible.\r\n- `tria_base.cc`: `fill_level_ghost_owners` was only declared but not defined for `DEAL_II_WITH_MPI=OFF`\r\n- `fe_values.cc`: `internal::make_shape_function_to_row_table` wasn't found in namespace `FEValuesView` without the additional `dealii::` prefix\r\n- `manifold.cc`: using round brackets for initialization of ` std::array` objects were not allowed\r\n- `multigrid.h`: MSVC didn't compile the class with the \"deprecated\" attribute. At other places this didn't pose any problem.\r\n- `vector_tools.templates.h`: we hit an ICE in the version of `VectorTools::project` without `Mapping` parameter","created_at":"2018-02-16T00:01:25Z","updated_at":"2018-02-17T01:08:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ce8880ebd4f05627f3a43fdc1cd098333087fff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/5907/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/5907/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/5907/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/7e999dfea7d14e467c597b6379dc4f3f3c6846a1","head":{"label":"masterleinad:fix_msvc","ref":"fix_msvc","sha":"7e999dfea7d14e467c597b6379dc4f3f3c6846a1","user":{"login":"masterleinad","id":2423533,"avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false},"repo":{"id":22077233,"name":"dealii","full_name":"masterleinad/dealii","owner":{"login":"masterleinad","id":2423533,"avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/masterleinad/dealii","description":null,"fork":true,"url":"https://api.github.com/repos/masterleinad/dealii","forks_url":"https://api.github.com/repos/masterleinad/dealii/forks","keys_url":"https://api.github.com/repos/masterleinad/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/masterleinad/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/masterleinad/dealii/teams","hooks_url":"https://api.github.com/repos/masterleinad/dealii/hooks","issue_events_url":"https://api.github.com/repos/masterleinad/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/masterleinad/dealii/events","assignees_url":"https://api.github.com/repos/masterleinad/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/masterleinad/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/masterleinad/dealii/tags","blobs_url":"https://api.github.com/repos/masterleinad/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/masterleinad/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/masterleinad/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/masterleinad/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/masterleinad/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/masterleinad/dealii/languages","stargazers_url":"https://api.github.com/repos/masterleinad/dealii/stargazers","contributors_url":"https://api.github.com/repos/masterleinad/dealii/contributors","subscribers_url":"https://api.github.com/repos/masterleinad/dealii/subscribers","subscription_url":"https://api.github.com/repos/masterleinad/dealii/subscription","commits_url":"https://api.github.com/repos/masterleinad/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/masterleinad/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/masterleinad/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/masterleinad/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/masterleinad/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/masterleinad/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/masterleinad/dealii/merges","archive_url":"https://api.github.com/repos/masterleinad/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/masterleinad/dealii/downloads","issues_url":"https://api.github.com/repos/masterleinad/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/masterleinad/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/masterleinad/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/masterleinad/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/masterleinad/dealii/labels{/name}","releases_url":"https://api.github.com/repos/masterleinad/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/masterleinad/dealii/deployments","created_at":"2014-07-21T19:26:56Z","updated_at":"2016-02-19T17:20:17Z","pushed_at":"2018-02-16T14:58:35Z","git_url":"git://github.com/masterleinad/dealii.git","ssh_url":"git@github.com:masterleinad/dealii.git","clone_url":"https://github.com/masterleinad/dealii.git","svn_url":"https://github.com/masterleinad/dealii","homepage":null,"size":181731,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"8ffbd7e891145fd89e66f21d1337b492550519fd","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars3.githubusercontent.com/u/7506070?v=4","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars3.githubusercontent.com/u/7506070?v=4","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2018-02-15T00:42:49Z","pushed_at":"2018-02-16T22:22:15Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":179942,"stargazers_count":308,"watchers_count":308,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":280,"mirror_url":null,"archived":false,"open_issues_count":231,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":280,"open_issues":231,"watchers":308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/5907"},"html":{"href":"https://github.com/dealii/dealii/pull/5907"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/5907"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/5907/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/5907/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/5907/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/7e999dfea7d14e467c597b6379dc4f3f3c6846a1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bangerth"}}