{"action":"created","issue":{"url":"https://api.github.com/repos/binarylogic/authlogic/issues/608","repository_url":"https://api.github.com/repos/binarylogic/authlogic","labels_url":"https://api.github.com/repos/binarylogic/authlogic/issues/608/labels{/name}","comments_url":"https://api.github.com/repos/binarylogic/authlogic/issues/608/comments","events_url":"https://api.github.com/repos/binarylogic/authlogic/issues/608/events","html_url":"https://github.com/binarylogic/authlogic/issues/608","id":328343249,"node_id":"MDU6SXNzdWUzMjgzNDMyNDk=","number":608,"title":"Minor Cookie improvements","user":{"login":"lawrencepit","id":115,"node_id":"MDQ6VXNlcjExNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/115?v=4","gravatar_id":"","url":"https://api.github.com/users/lawrencepit","html_url":"https://github.com/lawrencepit","followers_url":"https://api.github.com/users/lawrencepit/followers","following_url":"https://api.github.com/users/lawrencepit/following{/other_user}","gists_url":"https://api.github.com/users/lawrencepit/gists{/gist_id}","starred_url":"https://api.github.com/users/lawrencepit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lawrencepit/subscriptions","organizations_url":"https://api.github.com/users/lawrencepit/orgs","repos_url":"https://api.github.com/users/lawrencepit/repos","events_url":"https://api.github.com/users/lawrencepit/events{/privacy}","received_events_url":"https://api.github.com/users/lawrencepit/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-01T00:45:05Z","updated_at":"2018-07-29T04:58:59Z","closed_at":"2018-07-29T04:58:59Z","author_association":"CONTRIBUTOR","body":"https://github.com/binarylogic/authlogic/blob/83267f84712ae6d814a42bc0eef1848296d07c5a/lib/authlogic/session/cookies.rb#L244\r\n\r\nI think that line should be `if sign_cookie?` instead.\r\n\r\n```\r\n        def save_cookie\r\n          if sign_cookie?\r\n            controller.cookies.signed[cookie_key] = generate_cookie_for_saving\r\n          else\r\n            controller.cookies[cookie_key] = generate_cookie_for_saving\r\n          end\r\n        end\r\n```\r\n\r\nsimplify as:\r\n\r\n```\r\n        def save_cookie\r\n          cookie_jar[cookie_key] = generate_cookie_for_saving\r\n        end\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/binarylogic/authlogic/issues/comments/408652142","html_url":"https://github.com/binarylogic/authlogic/issues/608#issuecomment-408652142","issue_url":"https://api.github.com/repos/binarylogic/authlogic/issues/608","id":408652142,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODY1MjE0Mg==","user":{"login":"jaredbeck","id":380809,"node_id":"MDQ6VXNlcjM4MDgwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/380809?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredbeck","html_url":"https://github.com/jaredbeck","followers_url":"https://api.github.com/users/jaredbeck/followers","following_url":"https://api.github.com/users/jaredbeck/following{/other_user}","gists_url":"https://api.github.com/users/jaredbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredbeck/subscriptions","organizations_url":"https://api.github.com/users/jaredbeck/orgs","repos_url":"https://api.github.com/users/jaredbeck/repos","events_url":"https://api.github.com/users/jaredbeck/events{/privacy}","received_events_url":"https://api.github.com/users/jaredbeck/received_events","type":"User","site_admin":false},"created_at":"2018-07-29T04:58:59Z","updated_at":"2018-07-29T04:58:59Z","author_association":"COLLABORATOR","body":"Thanks, please make PR."}}
{"actor":{"display_login":"jaredbeck"}}