{"action":"created","issue":{"url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1141","repository_url":"https://api.github.com/repos/input-output-hk/daedalus","labels_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1141/labels{/name}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1141/comments","events_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1141/events","html_url":"https://github.com/input-output-hk/daedalus/pull/1141","id":373454868,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzgxMDMw","number":1141,"title":"[DEVOPS-1109] cli argument to inhibit console log: --log-console-off","user":{"login":"CodiePP","id":14063171,"node_id":"MDQ6VXNlcjE0MDYzMTcx","avatar_url":"https://avatars0.githubusercontent.com/u/14063171?v=4","gravatar_id":"","url":"https://api.github.com/users/CodiePP","html_url":"https://github.com/CodiePP","followers_url":"https://api.github.com/users/CodiePP/followers","following_url":"https://api.github.com/users/CodiePP/following{/other_user}","gists_url":"https://api.github.com/users/CodiePP/gists{/gist_id}","starred_url":"https://api.github.com/users/CodiePP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodiePP/subscriptions","organizations_url":"https://api.github.com/users/CodiePP/orgs","repos_url":"https://api.github.com/users/CodiePP/repos","events_url":"https://api.github.com/users/CodiePP/events{/privacy}","received_events_url":"https://api.github.com/users/CodiePP/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"CodiePP","id":14063171,"node_id":"MDQ6VXNlcjE0MDYzMTcx","avatar_url":"https://avatars0.githubusercontent.com/u/14063171?v=4","gravatar_id":"","url":"https://api.github.com/users/CodiePP","html_url":"https://github.com/CodiePP","followers_url":"https://api.github.com/users/CodiePP/followers","following_url":"https://api.github.com/users/CodiePP/following{/other_user}","gists_url":"https://api.github.com/users/CodiePP/gists{/gist_id}","starred_url":"https://api.github.com/users/CodiePP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodiePP/subscriptions","organizations_url":"https://api.github.com/users/CodiePP/orgs","repos_url":"https://api.github.com/users/CodiePP/repos","events_url":"https://api.github.com/users/CodiePP/events{/privacy}","received_events_url":"https://api.github.com/users/CodiePP/received_events","type":"User","site_admin":false},"assignees":[{"login":"CodiePP","id":14063171,"node_id":"MDQ6VXNlcjE0MDYzMTcx","avatar_url":"https://avatars0.githubusercontent.com/u/14063171?v=4","gravatar_id":"","url":"https://api.github.com/users/CodiePP","html_url":"https://github.com/CodiePP","followers_url":"https://api.github.com/users/CodiePP/followers","following_url":"https://api.github.com/users/CodiePP/following{/other_user}","gists_url":"https://api.github.com/users/CodiePP/gists{/gist_id}","starred_url":"https://api.github.com/users/CodiePP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodiePP/subscriptions","organizations_url":"https://api.github.com/users/CodiePP/orgs","repos_url":"https://api.github.com/users/CodiePP/repos","events_url":"https://api.github.com/users/CodiePP/events{/privacy}","received_events_url":"https://api.github.com/users/CodiePP/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-10-24T12:23:30Z","updated_at":"2018-10-24T12:33:06Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1141","html_url":"https://github.com/input-output-hk/daedalus/pull/1141","diff_url":"https://github.com/input-output-hk/daedalus/pull/1141.diff","patch_url":"https://github.com/input-output-hk/daedalus/pull/1141.patch"},"body":"Signed-off-by: Alexander Diemand <codieplusplus@apax.net>\r\n\r\nThis PR adds the `--log-console-off` cli argument that the node will not log to stdout.\r\n\r\nYT: DEVOPS-1109\r\ncardano-sl PR: https://github.com/input-output-hk/cardano-sl/pull/3785\r\n---\r\n\r\n## Review Checklist:\r\n\r\n### Basics\r\n\r\n- [x] PR is updated to the most recent version of target branch (and there are no conflicts)\r\n- [~] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes\r\n- [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub\r\n- [ ] Automated tests: All acceptance tests are passing (`yarn run test`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds)\r\n- [ ] There are no *flow* errors or warnings (`yarn run flow:test`)\r\n- [ ] There are no *lint* errors or warnings (`yarn run lint`)\r\n- [ ] Text changes are proofread and approved (Jane Wild)\r\n- [ ] There are no missing translations (running `yarn run manage:translations` produces no changes)\r\n- [ ] UI changes look good in all themes (Alexander Rukin)\r\n- [ ] Storybook works and no stories are broken (`yarn run storybook`)\r\n- [ ] In case of dependency changes `yarn.lock` file is updated\r\n\r\n### Code Quality\r\n- [ ] Important parts of the code are properly documented and commented\r\n- [ ] Code is properly typed with flow\r\n- [ ] React components are split-up enough to avoid unnecessary re-rendering\r\n- [ ] Any code that only works in Electron is neatly separated from components\r\n\r\n### Testing\r\n- [ ] New feature / change is covered by acceptance tests\r\n- [ ] All existing acceptance tests are still up-to-date\r\n- [ ] New feature / change is covered by Daedalus Testing scenario\r\n- [ ] All existing Daedalus Testing scenarios are still up-to-date\r\n\r\n### After Review:\r\n- [x] Merge PR\r\n- [x] Delete source branch\r\n- [x] Move ticket to `done` on the Youtrack board\r\n"},"comment":{"url":"https://api.github.com/repos/input-output-hk/daedalus/issues/comments/432636324","html_url":"https://github.com/input-output-hk/daedalus/pull/1141#issuecomment-432636324","issue_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1141","id":432636324,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjYzNjMyNA==","user":{"login":"CodiePP","id":14063171,"node_id":"MDQ6VXNlcjE0MDYzMTcx","avatar_url":"https://avatars0.githubusercontent.com/u/14063171?v=4","gravatar_id":"","url":"https://api.github.com/users/CodiePP","html_url":"https://github.com/CodiePP","followers_url":"https://api.github.com/users/CodiePP/followers","following_url":"https://api.github.com/users/CodiePP/following{/other_user}","gists_url":"https://api.github.com/users/CodiePP/gists{/gist_id}","starred_url":"https://api.github.com/users/CodiePP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodiePP/subscriptions","organizations_url":"https://api.github.com/users/CodiePP/orgs","repos_url":"https://api.github.com/users/CodiePP/repos","events_url":"https://api.github.com/users/CodiePP/events{/privacy}","received_events_url":"https://api.github.com/users/CodiePP/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T12:33:06Z","updated_at":"2018-10-24T12:33:06Z","author_association":"COLLABORATOR","body":"this output file was once removed in PR  #1027 "}}
{"actor":{"display_login":"CodiePP"}}