{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments/184882519","pull_request_review_id":116165982,"id":184882519,"diff_hunk":"@@ -113,9 +113,18 @@ cgroup_manager = \"{{ .CgroupManager }}\"\n # hooks_dir_path is the oci hooks directory for automatically executed hooks\n hooks_dir_path = \"{{ .HooksDirPath }}\"\n \n-# default_mounts is the mounts list to be mounted for the container when created\n-default_mounts = [\n-{{ range $mount := .DefaultMounts }}{{ printf \"\\t%q, \\n\" $mount }}{{ end }}]\n+# CRI-O reads its default mounts from the following two files:\n+# 1) /etc/containers/mounts.conf - this is the override file, where users can\n+# either add in their own default mounts, or override the default mounts shipped\n+# with the package.\n+# 2) /usr/share/containers/mounts.conf - this is the default file read for mounts.\n+# If you want CRI-O to read from a different, specific mounts file, you can change\n+# the default_mounts_file path right below. Note, if this is done, CRI-O will only add\n+# mounts it finds in this file.\n+\n+# default_mounts_file is the file path holding the default mounts to be mounted for the\n+# container when created.\n+# default_mounts_file = \"{{ .DefaultMountsFile }}\"","path":"cmd/crio/config.go","position":18,"original_position":18,"commit_id":"c5a89db5f3f49dc8e62640c22cc077107fd05ea1","original_commit_id":"c5a89db5f3f49dc8e62640c22cc077107fd05ea1","user":{"login":"runcom","id":849915,"avatar_url":"https://avatars2.githubusercontent.com/u/849915?v=4","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"body":"This is a breaking change as well, we need to support old and new and deprecate the old one so people have time to migrate. Basically, when they use the old one, we print a log so that they can later do the switch","created_at":"2018-04-29T13:06:41Z","updated_at":"2018-04-29T13:07:40Z","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/1537#discussion_r184882519","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/1537","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments/184882519"},"html":{"href":"https://github.com/kubernetes-incubator/cri-o/pull/1537#discussion_r184882519"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/1537"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/1537","id":184646034,"html_url":"https://github.com/kubernetes-incubator/cri-o/pull/1537","diff_url":"https://github.com/kubernetes-incubator/cri-o/pull/1537.diff","patch_url":"https://github.com/kubernetes-incubator/cri-o/pull/1537.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1537","number":1537,"state":"open","locked":false,"title":"Add FIPS mode secret and vendor in libpod/pkg/secret","user":{"login":"umohnani8","id":29377163,"avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false},"body":"Update cri-o to use the secrets package from libpod/pkg/secret,\r\nwhich also brings in support for FIPS mode secret.\r\nIf the host is in FIPS mode (i.e /etc/system-fips exists) /run/secrets/system-fips\r\nis created in the container so that the container can also run in FIPS mode.\r\n\r\nSigned-off-by: umohnani8 <umohnani@redhat.com>","created_at":"2018-04-27T14:55:17Z","updated_at":"2018-04-29T13:07:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fdc460bc2cd4b6558f235f27991b5be6b19ffef","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mrunalp","id":53798,"avatar_url":"https://avatars1.githubusercontent.com/u/53798?v=4","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":484626496,"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false},{"id":678105882,"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/labels/size/XL","name":"size/XL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/1537/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/1537/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1537/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/statuses/c5a89db5f3f49dc8e62640c22cc077107fd05ea1","head":{"label":"umohnani8:fips","ref":"fips","sha":"c5a89db5f3f49dc8e62640c22cc077107fd05ea1","user":{"login":"umohnani8","id":29377163,"avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false},"repo":{"id":94122280,"name":"cri-o","full_name":"umohnani8/cri-o","owner":{"login":"umohnani8","id":29377163,"avatar_url":"https://avatars0.githubusercontent.com/u/29377163?v=4","gravatar_id":"","url":"https://api.github.com/users/umohnani8","html_url":"https://github.com/umohnani8","followers_url":"https://api.github.com/users/umohnani8/followers","following_url":"https://api.github.com/users/umohnani8/following{/other_user}","gists_url":"https://api.github.com/users/umohnani8/gists{/gist_id}","starred_url":"https://api.github.com/users/umohnani8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umohnani8/subscriptions","organizations_url":"https://api.github.com/users/umohnani8/orgs","repos_url":"https://api.github.com/users/umohnani8/repos","events_url":"https://api.github.com/users/umohnani8/events{/privacy}","received_events_url":"https://api.github.com/users/umohnani8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/umohnani8/cri-o","description":"Open Container Initiative-based implementation of Kubernetes Container Runtime Interface","fork":true,"url":"https://api.github.com/repos/umohnani8/cri-o","forks_url":"https://api.github.com/repos/umohnani8/cri-o/forks","keys_url":"https://api.github.com/repos/umohnani8/cri-o/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umohnani8/cri-o/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umohnani8/cri-o/teams","hooks_url":"https://api.github.com/repos/umohnani8/cri-o/hooks","issue_events_url":"https://api.github.com/repos/umohnani8/cri-o/issues/events{/number}","events_url":"https://api.github.com/repos/umohnani8/cri-o/events","assignees_url":"https://api.github.com/repos/umohnani8/cri-o/assignees{/user}","branches_url":"https://api.github.com/repos/umohnani8/cri-o/branches{/branch}","tags_url":"https://api.github.com/repos/umohnani8/cri-o/tags","blobs_url":"https://api.github.com/repos/umohnani8/cri-o/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umohnani8/cri-o/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umohnani8/cri-o/git/refs{/sha}","trees_url":"https://api.github.com/repos/umohnani8/cri-o/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umohnani8/cri-o/statuses/{sha}","languages_url":"https://api.github.com/repos/umohnani8/cri-o/languages","stargazers_url":"https://api.github.com/repos/umohnani8/cri-o/stargazers","contributors_url":"https://api.github.com/repos/umohnani8/cri-o/contributors","subscribers_url":"https://api.github.com/repos/umohnani8/cri-o/subscribers","subscription_url":"https://api.github.com/repos/umohnani8/cri-o/subscription","commits_url":"https://api.github.com/repos/umohnani8/cri-o/commits{/sha}","git_commits_url":"https://api.github.com/repos/umohnani8/cri-o/git/commits{/sha}","comments_url":"https://api.github.com/repos/umohnani8/cri-o/comments{/number}","issue_comment_url":"https://api.github.com/repos/umohnani8/cri-o/issues/comments{/number}","contents_url":"https://api.github.com/repos/umohnani8/cri-o/contents/{+path}","compare_url":"https://api.github.com/repos/umohnani8/cri-o/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umohnani8/cri-o/merges","archive_url":"https://api.github.com/repos/umohnani8/cri-o/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umohnani8/cri-o/downloads","issues_url":"https://api.github.com/repos/umohnani8/cri-o/issues{/number}","pulls_url":"https://api.github.com/repos/umohnani8/cri-o/pulls{/number}","milestones_url":"https://api.github.com/repos/umohnani8/cri-o/milestones{/number}","notifications_url":"https://api.github.com/repos/umohnani8/cri-o/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umohnani8/cri-o/labels{/name}","releases_url":"https://api.github.com/repos/umohnani8/cri-o/releases{/id}","deployments_url":"https://api.github.com/repos/umohnani8/cri-o/deployments","created_at":"2017-06-12T17:25:43Z","updated_at":"2017-06-12T17:25:45Z","pushed_at":"2018-04-27T19:17:33Z","git_url":"git://github.com/umohnani8/cri-o.git","ssh_url":"git@github.com:umohnani8/cri-o.git","clone_url":"https://github.com/umohnani8/cri-o.git","svn_url":"https://github.com/umohnani8/cri-o","homepage":"","size":46273,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"c971f7b94933ee6801ece599198c63bdfae04892","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":67828134,"name":"cri-o","full_name":"kubernetes-incubator/cri-o","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/cri-o","description":"Open Container Initiative-based implementation of Kubernetes Container Runtime Interface","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/cri-o","forks_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/deployments","created_at":"2016-09-09T19:56:31Z","updated_at":"2018-04-28T09:02:44Z","pushed_at":"2018-04-27T19:17:34Z","git_url":"git://github.com/kubernetes-incubator/cri-o.git","ssh_url":"git@github.com:kubernetes-incubator/cri-o.git","clone_url":"https://github.com/kubernetes-incubator/cri-o.git","svn_url":"https://github.com/kubernetes-incubator/cri-o","homepage":"","size":42668,"stargazers_count":1052,"watchers_count":1052,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":204,"open_issues":81,"watchers":1052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/1537"},"html":{"href":"https://github.com/kubernetes-incubator/cri-o/pull/1537"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1537"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1537/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/1537/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/1537/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/statuses/c5a89db5f3f49dc8e62640c22cc077107fd05ea1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"runcom"}}