{"action":"created","comment":{"url":"https://api.github.com/repos/worldsibu/convector/pulls/comments/240938969","pull_request_review_id":184082515,"id":240938969,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDkzODk2OQ==","diff_hunk":"@@ -32,12 +32,15 @@\n     \"lint\": \"tslint --fix -c '../../tslint.json' -p './tsconfig.json'\"\n   },\n   \"peerDependencies\": {\n-    \"fabric-ca-client\": \">=1.1.2\",\n-    \"fabric-client\": \">=1.1.2\"\n+    \"fabric-ca-client\": \">=1.3.0\",\n+    \"fabric-client\": \">=1.3.0\"\n   },\n   \"dependencies\": {\n     \"@worldsibu/convector-common-fabric-helper\": \"1.2.0\",\n+    \"@theledger/fabric-chaincode-utils\": \"^4.0.0\",\n     \"commander\": \"^2.16.0\",\n+    \"fabric-ca-client\": \"^1.3.0\",\n+    \"fabric-client\": \"^1.3.0\",","path":"@worldsibu/convector-tool-dev-env/package.json","position":14,"original_position":14,"commit_id":"41ed2178da1d16ca0184a910ebac387aaa265223","original_commit_id":"41ed2178da1d16ca0184a910ebac387aaa265223","user":{"login":"diestrin","id":909327,"node_id":"MDQ6VXNlcjkwOTMyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/909327?v=4","gravatar_id":"","url":"https://api.github.com/users/diestrin","html_url":"https://github.com/diestrin","followers_url":"https://api.github.com/users/diestrin/followers","following_url":"https://api.github.com/users/diestrin/following{/other_user}","gists_url":"https://api.github.com/users/diestrin/gists{/gist_id}","starred_url":"https://api.github.com/users/diestrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diestrin/subscriptions","organizations_url":"https://api.github.com/users/diestrin/orgs","repos_url":"https://api.github.com/users/diestrin/repos","events_url":"https://api.github.com/users/diestrin/events{/privacy}","received_events_url":"https://api.github.com/users/diestrin/received_events","type":"User","site_admin":false},"body":"Let's use `~1.3.0` here, since `^` covers `1.x.x`. We have had errors because of this in the past.","created_at":"2018-12-12T09:35:29Z","updated_at":"2018-12-12T09:41:09Z","html_url":"https://github.com/worldsibu/convector/pull/23#discussion_r240938969","pull_request_url":"https://api.github.com/repos/worldsibu/convector/pulls/23","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/worldsibu/convector/pulls/comments/240938969"},"html":{"href":"https://github.com/worldsibu/convector/pull/23#discussion_r240938969"},"pull_request":{"href":"https://api.github.com/repos/worldsibu/convector/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/worldsibu/convector/pulls/23","id":237236909,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MjM2OTA5","html_url":"https://github.com/worldsibu/convector/pull/23","diff_url":"https://github.com/worldsibu/convector/pull/23.diff","patch_url":"https://github.com/worldsibu/convector/pull/23.patch","issue_url":"https://api.github.com/repos/worldsibu/convector/issues/23","number":23,"state":"open","locked":false,"title":"upgrade of convector-dev-env to Hyperledger Fabric 1.3","user":{"login":"xcottos","id":6748804,"node_id":"MDQ6VXNlcjY3NDg4MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6748804?v=4","gravatar_id":"","url":"https://api.github.com/users/xcottos","html_url":"https://github.com/xcottos","followers_url":"https://api.github.com/users/xcottos/followers","following_url":"https://api.github.com/users/xcottos/following{/other_user}","gists_url":"https://api.github.com/users/xcottos/gists{/gist_id}","starred_url":"https://api.github.com/users/xcottos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcottos/subscriptions","organizations_url":"https://api.github.com/users/xcottos/orgs","repos_url":"https://api.github.com/users/xcottos/repos","events_url":"https://api.github.com/users/xcottos/events{/privacy}","received_events_url":"https://api.github.com/users/xcottos/received_events","type":"User","site_admin":false},"body":"this is the upgrade of convector-dev-env to Hyperledger Fabric 1.3\r\n\r\nplease double check if it's all ok\r\n\r\nthere's the grpc deprecation warning\r\n\r\nremember to change the fabric-client and fabric-ca-client versions in the package.json of the client project","created_at":"2018-12-10T08:39:43Z","updated_at":"2018-12-12T09:41:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73cc687bbef2202eeb96489d1c95a783ed0932f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/worldsibu/convector/pulls/23/commits","review_comments_url":"https://api.github.com/repos/worldsibu/convector/pulls/23/comments","review_comment_url":"https://api.github.com/repos/worldsibu/convector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/worldsibu/convector/issues/23/comments","statuses_url":"https://api.github.com/repos/worldsibu/convector/statuses/41ed2178da1d16ca0184a910ebac387aaa265223","head":{"label":"xcottos:develop","ref":"develop","sha":"41ed2178da1d16ca0184a910ebac387aaa265223","user":{"login":"xcottos","id":6748804,"node_id":"MDQ6VXNlcjY3NDg4MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6748804?v=4","gravatar_id":"","url":"https://api.github.com/users/xcottos","html_url":"https://github.com/xcottos","followers_url":"https://api.github.com/users/xcottos/followers","following_url":"https://api.github.com/users/xcottos/following{/other_user}","gists_url":"https://api.github.com/users/xcottos/gists{/gist_id}","starred_url":"https://api.github.com/users/xcottos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcottos/subscriptions","organizations_url":"https://api.github.com/users/xcottos/orgs","repos_url":"https://api.github.com/users/xcottos/repos","events_url":"https://api.github.com/users/xcottos/events{/privacy}","received_events_url":"https://api.github.com/users/xcottos/received_events","type":"User","site_admin":false},"repo":{"id":161067256,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEwNjcyNTY=","name":"convector","full_name":"xcottos/convector","private":false,"owner":{"login":"xcottos","id":6748804,"node_id":"MDQ6VXNlcjY3NDg4MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6748804?v=4","gravatar_id":"","url":"https://api.github.com/users/xcottos","html_url":"https://github.com/xcottos","followers_url":"https://api.github.com/users/xcottos/followers","following_url":"https://api.github.com/users/xcottos/following{/other_user}","gists_url":"https://api.github.com/users/xcottos/gists{/gist_id}","starred_url":"https://api.github.com/users/xcottos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcottos/subscriptions","organizations_url":"https://api.github.com/users/xcottos/orgs","repos_url":"https://api.github.com/users/xcottos/repos","events_url":"https://api.github.com/users/xcottos/events{/privacy}","received_events_url":"https://api.github.com/users/xcottos/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xcottos/convector","description":"Smart Contract Systems the easy way. Open source development framework. Documentation https://worldsibu.github.io/convector/","fork":true,"url":"https://api.github.com/repos/xcottos/convector","forks_url":"https://api.github.com/repos/xcottos/convector/forks","keys_url":"https://api.github.com/repos/xcottos/convector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xcottos/convector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xcottos/convector/teams","hooks_url":"https://api.github.com/repos/xcottos/convector/hooks","issue_events_url":"https://api.github.com/repos/xcottos/convector/issues/events{/number}","events_url":"https://api.github.com/repos/xcottos/convector/events","assignees_url":"https://api.github.com/repos/xcottos/convector/assignees{/user}","branches_url":"https://api.github.com/repos/xcottos/convector/branches{/branch}","tags_url":"https://api.github.com/repos/xcottos/convector/tags","blobs_url":"https://api.github.com/repos/xcottos/convector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xcottos/convector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xcottos/convector/git/refs{/sha}","trees_url":"https://api.github.com/repos/xcottos/convector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xcottos/convector/statuses/{sha}","languages_url":"https://api.github.com/repos/xcottos/convector/languages","stargazers_url":"https://api.github.com/repos/xcottos/convector/stargazers","contributors_url":"https://api.github.com/repos/xcottos/convector/contributors","subscribers_url":"https://api.github.com/repos/xcottos/convector/subscribers","subscription_url":"https://api.github.com/repos/xcottos/convector/subscription","commits_url":"https://api.github.com/repos/xcottos/convector/commits{/sha}","git_commits_url":"https://api.github.com/repos/xcottos/convector/git/commits{/sha}","comments_url":"https://api.github.com/repos/xcottos/convector/comments{/number}","issue_comment_url":"https://api.github.com/repos/xcottos/convector/issues/comments{/number}","contents_url":"https://api.github.com/repos/xcottos/convector/contents/{+path}","compare_url":"https://api.github.com/repos/xcottos/convector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xcottos/convector/merges","archive_url":"https://api.github.com/repos/xcottos/convector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xcottos/convector/downloads","issues_url":"https://api.github.com/repos/xcottos/convector/issues{/number}","pulls_url":"https://api.github.com/repos/xcottos/convector/pulls{/number}","milestones_url":"https://api.github.com/repos/xcottos/convector/milestones{/number}","notifications_url":"https://api.github.com/repos/xcottos/convector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xcottos/convector/labels{/name}","releases_url":"https://api.github.com/repos/xcottos/convector/releases{/id}","deployments_url":"https://api.github.com/repos/xcottos/convector/deployments","created_at":"2018-12-09T18:08:09Z","updated_at":"2018-12-10T16:43:09Z","pushed_at":"2018-12-10T16:43:07Z","git_url":"git://github.com/xcottos/convector.git","ssh_url":"git@github.com:xcottos/convector.git","clone_url":"https://github.com/xcottos/convector.git","svn_url":"https://github.com/xcottos/convector","homepage":"https://worldsibu.io/convector/","size":34826,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"worldsibu:develop","ref":"develop","sha":"eddc39acb5885a40a923a3f326a868bd2b00ff91","user":{"login":"worldsibu","id":31822975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODIyOTc1","avatar_url":"https://avatars0.githubusercontent.com/u/31822975?v=4","gravatar_id":"","url":"https://api.github.com/users/worldsibu","html_url":"https://github.com/worldsibu","followers_url":"https://api.github.com/users/worldsibu/followers","following_url":"https://api.github.com/users/worldsibu/following{/other_user}","gists_url":"https://api.github.com/users/worldsibu/gists{/gist_id}","starred_url":"https://api.github.com/users/worldsibu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worldsibu/subscriptions","organizations_url":"https://api.github.com/users/worldsibu/orgs","repos_url":"https://api.github.com/users/worldsibu/repos","events_url":"https://api.github.com/users/worldsibu/events{/privacy}","received_events_url":"https://api.github.com/users/worldsibu/received_events","type":"Organization","site_admin":false},"repo":{"id":139272525,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkyNzI1MjU=","name":"convector","full_name":"worldsibu/convector","private":false,"owner":{"login":"worldsibu","id":31822975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODIyOTc1","avatar_url":"https://avatars0.githubusercontent.com/u/31822975?v=4","gravatar_id":"","url":"https://api.github.com/users/worldsibu","html_url":"https://github.com/worldsibu","followers_url":"https://api.github.com/users/worldsibu/followers","following_url":"https://api.github.com/users/worldsibu/following{/other_user}","gists_url":"https://api.github.com/users/worldsibu/gists{/gist_id}","starred_url":"https://api.github.com/users/worldsibu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worldsibu/subscriptions","organizations_url":"https://api.github.com/users/worldsibu/orgs","repos_url":"https://api.github.com/users/worldsibu/repos","events_url":"https://api.github.com/users/worldsibu/events{/privacy}","received_events_url":"https://api.github.com/users/worldsibu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/worldsibu/convector","description":"Smart Contract Systems the easy way. Open source development framework. Documentation https://worldsibu.github.io/convector/","fork":false,"url":"https://api.github.com/repos/worldsibu/convector","forks_url":"https://api.github.com/repos/worldsibu/convector/forks","keys_url":"https://api.github.com/repos/worldsibu/convector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/worldsibu/convector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/worldsibu/convector/teams","hooks_url":"https://api.github.com/repos/worldsibu/convector/hooks","issue_events_url":"https://api.github.com/repos/worldsibu/convector/issues/events{/number}","events_url":"https://api.github.com/repos/worldsibu/convector/events","assignees_url":"https://api.github.com/repos/worldsibu/convector/assignees{/user}","branches_url":"https://api.github.com/repos/worldsibu/convector/branches{/branch}","tags_url":"https://api.github.com/repos/worldsibu/convector/tags","blobs_url":"https://api.github.com/repos/worldsibu/convector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/worldsibu/convector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/worldsibu/convector/git/refs{/sha}","trees_url":"https://api.github.com/repos/worldsibu/convector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/worldsibu/convector/statuses/{sha}","languages_url":"https://api.github.com/repos/worldsibu/convector/languages","stargazers_url":"https://api.github.com/repos/worldsibu/convector/stargazers","contributors_url":"https://api.github.com/repos/worldsibu/convector/contributors","subscribers_url":"https://api.github.com/repos/worldsibu/convector/subscribers","subscription_url":"https://api.github.com/repos/worldsibu/convector/subscription","commits_url":"https://api.github.com/repos/worldsibu/convector/commits{/sha}","git_commits_url":"https://api.github.com/repos/worldsibu/convector/git/commits{/sha}","comments_url":"https://api.github.com/repos/worldsibu/convector/comments{/number}","issue_comment_url":"https://api.github.com/repos/worldsibu/convector/issues/comments{/number}","contents_url":"https://api.github.com/repos/worldsibu/convector/contents/{+path}","compare_url":"https://api.github.com/repos/worldsibu/convector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/worldsibu/convector/merges","archive_url":"https://api.github.com/repos/worldsibu/convector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/worldsibu/convector/downloads","issues_url":"https://api.github.com/repos/worldsibu/convector/issues{/number}","pulls_url":"https://api.github.com/repos/worldsibu/convector/pulls{/number}","milestones_url":"https://api.github.com/repos/worldsibu/convector/milestones{/number}","notifications_url":"https://api.github.com/repos/worldsibu/convector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/worldsibu/convector/labels{/name}","releases_url":"https://api.github.com/repos/worldsibu/convector/releases{/id}","deployments_url":"https://api.github.com/repos/worldsibu/convector/deployments","created_at":"2018-06-30T18:54:08Z","updated_at":"2018-12-10T06:46:50Z","pushed_at":"2018-12-10T16:43:08Z","git_url":"git://github.com/worldsibu/convector.git","ssh_url":"git@github.com:worldsibu/convector.git","clone_url":"https://github.com/worldsibu/convector.git","svn_url":"https://github.com/worldsibu/convector","homepage":"https://worldsibu.io/convector/","size":6921,"stargazers_count":42,"watchers_count":42,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":12,"watchers":42,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/worldsibu/convector/pulls/23"},"html":{"href":"https://github.com/worldsibu/convector/pull/23"},"issue":{"href":"https://api.github.com/repos/worldsibu/convector/issues/23"},"comments":{"href":"https://api.github.com/repos/worldsibu/convector/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/worldsibu/convector/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/worldsibu/convector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/worldsibu/convector/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/worldsibu/convector/statuses/41ed2178da1d16ca0184a910ebac387aaa265223"}},"author_association":"NONE"}}
{"actor":{"display_login":"diestrin"}}