{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/comments/167062013","pull_request_review_id":95226564,"id":167062013,"diff_hunk":"@@ -1,142 +0,0 @@\n-#define LOG_MEMORY_PERF_COUNTERS \n-using System;\n-using System.Threading.Tasks;\n-using Microsoft.Extensions.Logging;\n-using Orleans.Statistics;\n-\n-namespace Orleans.Runtime\n-{\n-    internal class ClientTableStatistics : IClientPerformanceMetrics, IDisposable","path":"src/Orleans.Core/Statistics/ClientTableStatistics.cs","position":9,"original_position":9,"commit_id":"715a6695c21c61505881e58a805ebb91ad4e86d9","original_commit_id":"715a6695c21c61505881e58a805ebb91ad4e86d9","user":{"login":"xiazen","id":20803801,"avatar_url":"https://avatars3.githubusercontent.com/u/20803801?v=4","gravatar_id":"","url":"https://api.github.com/users/xiazen","html_url":"https://github.com/xiazen","followers_url":"https://api.github.com/users/xiazen/followers","following_url":"https://api.github.com/users/xiazen/following{/other_user}","gists_url":"https://api.github.com/users/xiazen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiazen/subscriptions","organizations_url":"https://api.github.com/users/xiazen/orgs","repos_url":"https://api.github.com/users/xiazen/repos","events_url":"https://api.github.com/users/xiazen/events{/privacy}","received_events_url":"https://api.github.com/users/xiazen/received_events","type":"User","site_admin":false},"body":"why is this removed? isn't this statistics, not metrics? ","created_at":"2018-02-08T20:46:06Z","updated_at":"2018-02-08T20:46:06Z","html_url":"https://github.com/dotnet/orleans/pull/3988#discussion_r167062013","pull_request_url":"https://api.github.com/repos/dotnet/orleans/pulls/3988","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments/167062013"},"html":{"href":"https://github.com/dotnet/orleans/pull/3988#discussion_r167062013"},"pull_request":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3988"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/3988","id":167957743,"html_url":"https://github.com/dotnet/orleans/pull/3988","diff_url":"https://github.com/dotnet/orleans/pull/3988.diff","patch_url":"https://github.com/dotnet/orleans/pull/3988.patch","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/3988","number":3988,"state":"open","locked":false,"title":"Remove metrics publishers","user":{"login":"ReubenBond","id":203839,"avatar_url":"https://avatars1.githubusercontent.com/u/203839?v=4","gravatar_id":"","url":"https://api.github.com/users/ReubenBond","html_url":"https://github.com/ReubenBond","followers_url":"https://api.github.com/users/ReubenBond/followers","following_url":"https://api.github.com/users/ReubenBond/following{/other_user}","gists_url":"https://api.github.com/users/ReubenBond/gists{/gist_id}","starred_url":"https://api.github.com/users/ReubenBond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReubenBond/subscriptions","organizations_url":"https://api.github.com/users/ReubenBond/orgs","repos_url":"https://api.github.com/users/ReubenBond/repos","events_url":"https://api.github.com/users/ReubenBond/events{/privacy}","received_events_url":"https://api.github.com/users/ReubenBond/received_events","type":"User","site_admin":false},"body":"This partially addresses #3976\r\n\r\nSnapshots of current system behavior are published using various interfaces. This removes that publishing mechanism.","created_at":"2018-02-08T12:25:24Z","updated_at":"2018-02-08T20:46:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e5c52a596c05b8be65c64afe637e48508ca05bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/orleans/pulls/3988/commits","review_comments_url":"https://api.github.com/repos/dotnet/orleans/pulls/3988/comments","review_comment_url":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/3988/comments","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/715a6695c21c61505881e58a805ebb91ad4e86d9","head":{"label":"ReubenBond:remove-metrics-publishers","ref":"remove-metrics-publishers","sha":"715a6695c21c61505881e58a805ebb91ad4e86d9","user":{"login":"ReubenBond","id":203839,"avatar_url":"https://avatars1.githubusercontent.com/u/203839?v=4","gravatar_id":"","url":"https://api.github.com/users/ReubenBond","html_url":"https://github.com/ReubenBond","followers_url":"https://api.github.com/users/ReubenBond/followers","following_url":"https://api.github.com/users/ReubenBond/following{/other_user}","gists_url":"https://api.github.com/users/ReubenBond/gists{/gist_id}","starred_url":"https://api.github.com/users/ReubenBond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReubenBond/subscriptions","organizations_url":"https://api.github.com/users/ReubenBond/orgs","repos_url":"https://api.github.com/users/ReubenBond/repos","events_url":"https://api.github.com/users/ReubenBond/events{/privacy}","received_events_url":"https://api.github.com/users/ReubenBond/received_events","type":"User","site_admin":false},"repo":{"id":30130910,"name":"orleans","full_name":"ReubenBond/orleans","owner":{"login":"ReubenBond","id":203839,"avatar_url":"https://avatars1.githubusercontent.com/u/203839?v=4","gravatar_id":"","url":"https://api.github.com/users/ReubenBond","html_url":"https://github.com/ReubenBond","followers_url":"https://api.github.com/users/ReubenBond/followers","following_url":"https://api.github.com/users/ReubenBond/following{/other_user}","gists_url":"https://api.github.com/users/ReubenBond/gists{/gist_id}","starred_url":"https://api.github.com/users/ReubenBond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReubenBond/subscriptions","organizations_url":"https://api.github.com/users/ReubenBond/orgs","repos_url":"https://api.github.com/users/ReubenBond/repos","events_url":"https://api.github.com/users/ReubenBond/events{/privacy}","received_events_url":"https://api.github.com/users/ReubenBond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ReubenBond/orleans","description":"Repo for Orleans - Distributed Actor Model","fork":true,"url":"https://api.github.com/repos/ReubenBond/orleans","forks_url":"https://api.github.com/repos/ReubenBond/orleans/forks","keys_url":"https://api.github.com/repos/ReubenBond/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReubenBond/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReubenBond/orleans/teams","hooks_url":"https://api.github.com/repos/ReubenBond/orleans/hooks","issue_events_url":"https://api.github.com/repos/ReubenBond/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/ReubenBond/orleans/events","assignees_url":"https://api.github.com/repos/ReubenBond/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/ReubenBond/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/ReubenBond/orleans/tags","blobs_url":"https://api.github.com/repos/ReubenBond/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReubenBond/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReubenBond/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReubenBond/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReubenBond/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/ReubenBond/orleans/languages","stargazers_url":"https://api.github.com/repos/ReubenBond/orleans/stargazers","contributors_url":"https://api.github.com/repos/ReubenBond/orleans/contributors","subscribers_url":"https://api.github.com/repos/ReubenBond/orleans/subscribers","subscription_url":"https://api.github.com/repos/ReubenBond/orleans/subscription","commits_url":"https://api.github.com/repos/ReubenBond/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReubenBond/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReubenBond/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReubenBond/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReubenBond/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/ReubenBond/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReubenBond/orleans/merges","archive_url":"https://api.github.com/repos/ReubenBond/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReubenBond/orleans/downloads","issues_url":"https://api.github.com/repos/ReubenBond/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/ReubenBond/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/ReubenBond/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/ReubenBond/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReubenBond/orleans/labels{/name}","releases_url":"https://api.github.com/repos/ReubenBond/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/ReubenBond/orleans/deployments","created_at":"2015-02-01T00:06:08Z","updated_at":"2016-10-31T01:45:02Z","pushed_at":"2018-02-08T12:27:42Z","git_url":"git://github.com/ReubenBond/orleans.git","ssh_url":"git@github.com:ReubenBond/orleans.git","clone_url":"https://github.com/ReubenBond/orleans.git","svn_url":"https://github.com/ReubenBond/orleans","homepage":"","size":43880,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"863b07b764c84f4ba9be1ce389bac6eaf79330a1","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28232663,"name":"orleans","full_name":"dotnet/orleans","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":false,"url":"https://api.github.com/repos/dotnet/orleans","forks_url":"https://api.github.com/repos/dotnet/orleans/forks","keys_url":"https://api.github.com/repos/dotnet/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/orleans/teams","hooks_url":"https://api.github.com/repos/dotnet/orleans/hooks","issue_events_url":"https://api.github.com/repos/dotnet/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/orleans/events","assignees_url":"https://api.github.com/repos/dotnet/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/orleans/tags","blobs_url":"https://api.github.com/repos/dotnet/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/orleans/languages","stargazers_url":"https://api.github.com/repos/dotnet/orleans/stargazers","contributors_url":"https://api.github.com/repos/dotnet/orleans/contributors","subscribers_url":"https://api.github.com/repos/dotnet/orleans/subscribers","subscription_url":"https://api.github.com/repos/dotnet/orleans/subscription","commits_url":"https://api.github.com/repos/dotnet/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/orleans/merges","archive_url":"https://api.github.com/repos/dotnet/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/orleans/downloads","issues_url":"https://api.github.com/repos/dotnet/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/orleans/deployments","created_at":"2014-12-19T14:32:50Z","updated_at":"2018-02-07T13:20:28Z","pushed_at":"2018-02-08T20:34:52Z","git_url":"git://github.com/dotnet/orleans.git","ssh_url":"git@github.com:dotnet/orleans.git","clone_url":"https://github.com/dotnet/orleans.git","svn_url":"https://github.com/dotnet/orleans","homepage":"http://dotnet.github.io/orleans","size":44780,"stargazers_count":3546,"watchers_count":3546,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":873,"mirror_url":null,"archived":false,"open_issues_count":327,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":873,"open_issues":327,"watchers":3546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3988"},"html":{"href":"https://github.com/dotnet/orleans/pull/3988"},"issue":{"href":"https://api.github.com/repos/dotnet/orleans/issues/3988"},"comments":{"href":"https://api.github.com/repos/dotnet/orleans/issues/3988/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3988/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3988/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/orleans/statuses/715a6695c21c61505881e58a805ebb91ad4e86d9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xiazen"}}