{"action":"created","issue":{"url":"https://api.github.com/repos/dkpro/dkpro-jwpl/issues/184","repository_url":"https://api.github.com/repos/dkpro/dkpro-jwpl","labels_url":"https://api.github.com/repos/dkpro/dkpro-jwpl/issues/184/labels{/name}","comments_url":"https://api.github.com/repos/dkpro/dkpro-jwpl/issues/184/comments","events_url":"https://api.github.com/repos/dkpro/dkpro-jwpl/issues/184/events","html_url":"https://github.com/dkpro/dkpro-jwpl/pull/184","id":341629781,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzIyNjcz","number":184,"title":"#183 - Raise test coverage of 'Category' (api) class to at least 75% (line & branch)","user":{"login":"mawiesne","id":20473513,"node_id":"MDQ6VXNlcjIwNDczNTEz","avatar_url":"https://avatars1.githubusercontent.com/u/20473513?v=4","gravatar_id":"","url":"https://api.github.com/users/mawiesne","html_url":"https://github.com/mawiesne","followers_url":"https://api.github.com/users/mawiesne/followers","following_url":"https://api.github.com/users/mawiesne/following{/other_user}","gists_url":"https://api.github.com/users/mawiesne/gists{/gist_id}","starred_url":"https://api.github.com/users/mawiesne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mawiesne/subscriptions","organizations_url":"https://api.github.com/users/mawiesne/orgs","repos_url":"https://api.github.com/users/mawiesne/repos","events_url":"https://api.github.com/users/mawiesne/events{/privacy}","received_events_url":"https://api.github.com/users/mawiesne/received_events","type":"User","site_admin":false},"labels":[{"id":982938278,"node_id":"MDU6TGFiZWw5ODI5MzgyNzg=","url":"https://api.github.com/repos/dkpro/dkpro-jwpl/labels/test","name":"test","color":"62e0be","default":false},{"id":242725907,"node_id":"MDU6TGFiZWwyNDI3MjU5MDc=","url":"https://api.github.com/repos/dkpro/dkpro-jwpl/labels/%F0%9F%86%95Enhancement","name":"🆕Enhancement","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"mawiesne","id":20473513,"node_id":"MDQ6VXNlcjIwNDczNTEz","avatar_url":"https://avatars1.githubusercontent.com/u/20473513?v=4","gravatar_id":"","url":"https://api.github.com/users/mawiesne","html_url":"https://github.com/mawiesne","followers_url":"https://api.github.com/users/mawiesne/followers","following_url":"https://api.github.com/users/mawiesne/following{/other_user}","gists_url":"https://api.github.com/users/mawiesne/gists{/gist_id}","starred_url":"https://api.github.com/users/mawiesne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mawiesne/subscriptions","organizations_url":"https://api.github.com/users/mawiesne/orgs","repos_url":"https://api.github.com/users/mawiesne/repos","events_url":"https://api.github.com/users/mawiesne/events{/privacy}","received_events_url":"https://api.github.com/users/mawiesne/received_events","type":"User","site_admin":false},"assignees":[{"login":"mawiesne","id":20473513,"node_id":"MDQ6VXNlcjIwNDczNTEz","avatar_url":"https://avatars1.githubusercontent.com/u/20473513?v=4","gravatar_id":"","url":"https://api.github.com/users/mawiesne","html_url":"https://github.com/mawiesne","followers_url":"https://api.github.com/users/mawiesne/followers","following_url":"https://api.github.com/users/mawiesne/following{/other_user}","gists_url":"https://api.github.com/users/mawiesne/gists{/gist_id}","starred_url":"https://api.github.com/users/mawiesne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mawiesne/subscriptions","organizations_url":"https://api.github.com/users/mawiesne/orgs","repos_url":"https://api.github.com/users/mawiesne/repos","events_url":"https://api.github.com/users/mawiesne/events{/privacy}","received_events_url":"https://api.github.com/users/mawiesne/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dkpro/dkpro-jwpl/milestones/2","html_url":"https://github.com/dkpro/dkpro-jwpl/milestone/2","labels_url":"https://api.github.com/repos/dkpro/dkpro-jwpl/milestones/2/labels","id":2151670,"node_id":"MDk6TWlsZXN0b25lMjE1MTY3MA==","number":2,"title":"1.2.0","description":"","creator":{"login":"reckart","id":1410238,"node_id":"MDQ6VXNlcjE0MTAyMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1410238?v=4","gravatar_id":"","url":"https://api.github.com/users/reckart","html_url":"https://github.com/reckart","followers_url":"https://api.github.com/users/reckart/followers","following_url":"https://api.github.com/users/reckart/following{/other_user}","gists_url":"https://api.github.com/users/reckart/gists{/gist_id}","starred_url":"https://api.github.com/users/reckart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reckart/subscriptions","organizations_url":"https://api.github.com/users/reckart/orgs","repos_url":"https://api.github.com/users/reckart/repos","events_url":"https://api.github.com/users/reckart/events{/privacy}","received_events_url":"https://api.github.com/users/reckart/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":24,"state":"open","created_at":"2016-11-22T14:59:34Z","updated_at":"2018-07-17T12:38:46Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-07-16T18:35:40Z","updated_at":"2018-07-17T12:43:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dkpro/dkpro-jwpl/pulls/184","html_url":"https://github.com/dkpro/dkpro-jwpl/pull/184","diff_url":"https://github.com/dkpro/dkpro-jwpl/pull/184.diff","patch_url":"https://github.com/dkpro/dkpro-jwpl/pull/184.patch"},"body":"- Adds several test cases in `CategoryTest` which lifts the coverage for class Page to\r\n 98% (line), 86% (branch) -> checked via JaCoCo report of API testsuite run.\r\n- Adds test cases for `CategoryTitleComparator` and `PageTitleComparator`.\r\n- Bonus: Adds new `MetaDataTest` class with 89% line coverage.\r\n- Removes deprecated method `Set<Page> getPages()` from `Category` class as nobody used it any way.\r\n- Removes dead code (commented and unused/untested) from `Category`.\r\n- Reduces code duplication in `Category`: getArticleIds() vs. __getPages().\r\n- Improves some JavaDoc here and there.\r\n- Fixes several misspellings throughout the whole code base of the term _occured_ which should read as _occurred_ (double r).\r\n\r\nThis addition of tests helps us to sleep well when things get changed in core parts of the API.\r\n\r\nPlease review and merge this PR."},"comment":{"url":"https://api.github.com/repos/dkpro/dkpro-jwpl/issues/comments/405568400","html_url":"https://github.com/dkpro/dkpro-jwpl/pull/184#issuecomment-405568400","issue_url":"https://api.github.com/repos/dkpro/dkpro-jwpl/issues/184","id":405568400,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTU2ODQwMA==","user":{"login":"ukp-svc-jenkins","id":30810440,"node_id":"MDQ6VXNlcjMwODEwNDQw","avatar_url":"https://avatars2.githubusercontent.com/u/30810440?v=4","gravatar_id":"","url":"https://api.github.com/users/ukp-svc-jenkins","html_url":"https://github.com/ukp-svc-jenkins","followers_url":"https://api.github.com/users/ukp-svc-jenkins/followers","following_url":"https://api.github.com/users/ukp-svc-jenkins/following{/other_user}","gists_url":"https://api.github.com/users/ukp-svc-jenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/ukp-svc-jenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukp-svc-jenkins/subscriptions","organizations_url":"https://api.github.com/users/ukp-svc-jenkins/orgs","repos_url":"https://api.github.com/users/ukp-svc-jenkins/repos","events_url":"https://api.github.com/users/ukp-svc-jenkins/events{/privacy}","received_events_url":"https://api.github.com/users/ukp-svc-jenkins/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T12:43:10Z","updated_at":"2018-07-17T12:43:10Z","author_association":"NONE","body":"[![23% (+1.01%) vs master 22%](https://zoidberg.ukp.informatik.tu-darmstadt.de/jenkins//coverage-status-icon/?coverage=0.2274&masterCoverage=0.2173)](https://zoidberg.ukp.informatik.tu-darmstadt.de:443/jenkins/job/JWPL%20(GitHub)%20(PR%20builder)/36/)"}}
{"actor":{"display_login":"ukp-svc-jenkins"}}