{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/186472593","pull_request_review_id":118056889,"id":186472593,"diff_hunk":"@@ -87,33 +88,38 @@ rollbackToil txun = do\n processTx ::\n        (HasTxpConfiguration, HasConfiguration)\n     => BlockVersionData\n+    -> Set Address\n     -> EpochIndex\n     -> (TxId, TxAux)\n     -> ExceptT ToilVerFailure LocalToilM TxUndo\n-processTx bvd curEpoch tx@(id, aux) = do\n+processTx bvd blacklist curEpoch tx@(id, aux) = do\n     whenM (lift $ hasTx id) $ throwError ToilKnown\n     whenM ((>= memPoolLimitTx) <$> lift memPoolSize) $\n         throwError (ToilOverwhelmed memPoolLimitTx)\n-    undo <- mapExceptT utxoMToLocalToilM $ verifyAndApplyTx bvd curEpoch True tx\n+    undo <- mapExceptT utxoMToLocalToilM $ verifyAndApplyTx bvd blacklist curEpoch True tx\n     undo <$ lift (putTxWithUndo id aux undo)\n \n -- | Get rid of invalid transactions.\n -- All valid transactions will be added to mem pool and applied to utxo.\n normalizeToil ::\n        (HasTxpConfiguration, HasConfiguration)\n     => BlockVersionData\n+    -> Set Address\n     -> EpochIndex\n     -> [(TxId, TxAux)]\n     -> LocalToilM ()\n-normalizeToil bvd curEpoch txs = mapM_ normalize ordered\n+normalizeToil bvd blacklist curEpoch txs = mapM_ normalize ordered\n   where\n+    -- If there is a cycle in the tx list, topsortTxs returns Nothing.\n+    -- Why is that not an error? And if its not an error, why bother\n+    -- top-sorting them anyway?","path":"txp/Pos/Txp/Toil/Logic.hs","position":47,"original_position":47,"commit_id":"7bc9bfee03f78fc6f936e5768a9def7b3ab0779a","original_commit_id":"827f5a03f727a7d602659576fd611ce414379c4a","user":{"login":"parsonsmatt","id":7310112,"avatar_url":"https://avatars1.githubusercontent.com/u/7310112?v=4","gravatar_id":"","url":"https://api.github.com/users/parsonsmatt","html_url":"https://github.com/parsonsmatt","followers_url":"https://api.github.com/users/parsonsmatt/followers","following_url":"https://api.github.com/users/parsonsmatt/following{/other_user}","gists_url":"https://api.github.com/users/parsonsmatt/gists{/gist_id}","starred_url":"https://api.github.com/users/parsonsmatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parsonsmatt/subscriptions","organizations_url":"https://api.github.com/users/parsonsmatt/orgs","repos_url":"https://api.github.com/users/parsonsmatt/repos","events_url":"https://api.github.com/users/parsonsmatt/events{/privacy}","received_events_url":"https://api.github.com/users/parsonsmatt/received_events","type":"User","site_admin":false},"body":"Yeah I'm just throwing out wild guesses","created_at":"2018-05-07T16:18:31Z","updated_at":"2018-05-07T16:18:31Z","html_url":"https://github.com/input-output-hk/cardano-sl/pull/2871#discussion_r186472593","pull_request_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2871","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/186472593"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/2871#discussion_r186472593"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2871"}},"in_reply_to_id":186205193},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2871","id":185952447,"html_url":"https://github.com/input-output-hk/cardano-sl/pull/2871","diff_url":"https://github.com/input-output-hk/cardano-sl/pull/2871.diff","patch_url":"https://github.com/input-output-hk/cardano-sl/pull/2871.patch","issue_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2871","number":2871,"state":"open","locked":false,"title":"WIP","user":{"login":"erikd","id":307277,"avatar_url":"https://avatars0.githubusercontent.com/u/307277?v=4","gravatar_id":"","url":"https://api.github.com/users/erikd","html_url":"https://github.com/erikd","followers_url":"https://api.github.com/users/erikd/followers","following_url":"https://api.github.com/users/erikd/following{/other_user}","gists_url":"https://api.github.com/users/erikd/gists{/gist_id}","starred_url":"https://api.github.com/users/erikd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikd/subscriptions","organizations_url":"https://api.github.com/users/erikd/orgs","repos_url":"https://api.github.com/users/erikd/repos","events_url":"https://api.github.com/users/erikd/events{/privacy}","received_events_url":"https://api.github.com/users/erikd/received_events","type":"User","site_admin":false},"body":"WIP on the blacklist.\r\n","created_at":"2018-05-04T11:02:44Z","updated_at":"2018-05-07T16:18:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"540f8eb714c837a3aa147e93b685cc041f877bf1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"akegalj","id":2461951,"avatar_url":"https://avatars0.githubusercontent.com/u/2461951?v=4","gravatar_id":"","url":"https://api.github.com/users/akegalj","html_url":"https://github.com/akegalj","followers_url":"https://api.github.com/users/akegalj/followers","following_url":"https://api.github.com/users/akegalj/following{/other_user}","gists_url":"https://api.github.com/users/akegalj/gists{/gist_id}","starred_url":"https://api.github.com/users/akegalj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akegalj/subscriptions","organizations_url":"https://api.github.com/users/akegalj/orgs","repos_url":"https://api.github.com/users/akegalj/repos","events_url":"https://api.github.com/users/akegalj/events{/privacy}","received_events_url":"https://api.github.com/users/akegalj/received_events","type":"User","site_admin":false},{"login":"denisshevchenko","id":5082435,"avatar_url":"https://avatars1.githubusercontent.com/u/5082435?v=4","gravatar_id":"","url":"https://api.github.com/users/denisshevchenko","html_url":"https://github.com/denisshevchenko","followers_url":"https://api.github.com/users/denisshevchenko/followers","following_url":"https://api.github.com/users/denisshevchenko/following{/other_user}","gists_url":"https://api.github.com/users/denisshevchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/denisshevchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisshevchenko/subscriptions","organizations_url":"https://api.github.com/users/denisshevchenko/orgs","repos_url":"https://api.github.com/users/denisshevchenko/repos","events_url":"https://api.github.com/users/denisshevchenko/events{/privacy}","received_events_url":"https://api.github.com/users/denisshevchenko/received_events","type":"User","site_admin":false},{"login":"ksaric","id":6264437,"avatar_url":"https://avatars0.githubusercontent.com/u/6264437?v=4","gravatar_id":"","url":"https://api.github.com/users/ksaric","html_url":"https://github.com/ksaric","followers_url":"https://api.github.com/users/ksaric/followers","following_url":"https://api.github.com/users/ksaric/following{/other_user}","gists_url":"https://api.github.com/users/ksaric/gists{/gist_id}","starred_url":"https://api.github.com/users/ksaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksaric/subscriptions","organizations_url":"https://api.github.com/users/ksaric/orgs","repos_url":"https://api.github.com/users/ksaric/repos","events_url":"https://api.github.com/users/ksaric/events{/privacy}","received_events_url":"https://api.github.com/users/ksaric/received_events","type":"User","site_admin":false},{"login":"adinapoli-iohk","id":29383371,"avatar_url":"https://avatars3.githubusercontent.com/u/29383371?v=4","gravatar_id":"","url":"https://api.github.com/users/adinapoli-iohk","html_url":"https://github.com/adinapoli-iohk","followers_url":"https://api.github.com/users/adinapoli-iohk/followers","following_url":"https://api.github.com/users/adinapoli-iohk/following{/other_user}","gists_url":"https://api.github.com/users/adinapoli-iohk/gists{/gist_id}","starred_url":"https://api.github.com/users/adinapoli-iohk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adinapoli-iohk/subscriptions","organizations_url":"https://api.github.com/users/adinapoli-iohk/orgs","repos_url":"https://api.github.com/users/adinapoli-iohk/repos","events_url":"https://api.github.com/users/adinapoli-iohk/events{/privacy}","received_events_url":"https://api.github.com/users/adinapoli-iohk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":531518701,"url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels/wip","name":"wip","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2871/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2871/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2871/comments","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/7bc9bfee03f78fc6f936e5768a9def7b3ab0779a","head":{"label":"input-output-hk:erikd/CDEC-271","ref":"erikd/CDEC-271","sha":"7bc9bfee03f78fc6f936e5768a9def7b3ab0779a","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"Cryptographic currency implementing Ouroboros PoS protocol","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2018-05-07T14:05:53Z","pushed_at":"2018-05-07T16:16:08Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"git@github.com:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":90133,"stargazers_count":2488,"watchers_count":2488,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":381,"mirror_url":null,"archived":false,"open_issues_count":159,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":381,"open_issues":159,"watchers":2488,"default_branch":"develop"}},"base":{"label":"input-output-hk:develop","ref":"develop","sha":"ad52f601934d541729f654aed8bb78b47c5bb8df","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"Cryptographic currency implementing Ouroboros PoS protocol","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2018-05-07T14:05:53Z","pushed_at":"2018-05-07T16:16:08Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"git@github.com:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":90133,"stargazers_count":2488,"watchers_count":2488,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":381,"mirror_url":null,"archived":false,"open_issues_count":159,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":381,"open_issues":159,"watchers":2488,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2871"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/2871"},"issue":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2871"},"comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2871/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2871/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2871/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/7bc9bfee03f78fc6f936e5768a9def7b3ab0779a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"parsonsmatt"}}