{"action":"created","comment":{"url":"https://api.github.com/repos/pf4j/pf4j/pulls/comments/196712908","pull_request_review_id":130314270,"id":196712908,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjcxMjkwOA==","diff_hunk":"@@ -316,16 +320,7 @@ public void startPlugins() {\n         for (PluginWrapper pluginWrapper : resolvedPlugins) {\n             PluginState pluginState = pluginWrapper.getPluginState();\n             if ((PluginState.DISABLED != pluginState) && (PluginState.STARTED != pluginState)) {\n-                try {\n-                    log.info(\"Start plugin '{}'\", getPluginLabel(pluginWrapper.getDescriptor()));\n-                    pluginWrapper.getPlugin().start();\n-                    pluginWrapper.setPluginState(PluginState.STARTED);\n-                    startedPlugins.add(pluginWrapper);\n-\n-                    firePluginStateEvent(new PluginStateEvent(this, pluginWrapper, pluginState));\n-                } catch (Exception e) {\n-                    log.error(e.getMessage(), e);\n-                }\n+                tryStartPlugin(pluginWrapper, pluginWrapper.getDescriptor(), pluginState);","path":"pf4j/src/main/java/org/pf4j/AbstractPluginManager.java","position":44,"original_position":44,"commit_id":"870a8dcb1c969d9a7e44219294b450123d91b413","original_commit_id":"870a8dcb1c969d9a7e44219294b450123d91b413","user":{"login":"decebals","id":1248311,"node_id":"MDQ6VXNlcjEyNDgzMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1248311?v=4","gravatar_id":"","url":"https://api.github.com/users/decebals","html_url":"https://github.com/decebals","followers_url":"https://api.github.com/users/decebals/followers","following_url":"https://api.github.com/users/decebals/following{/other_user}","gists_url":"https://api.github.com/users/decebals/gists{/gist_id}","starred_url":"https://api.github.com/users/decebals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decebals/subscriptions","organizations_url":"https://api.github.com/users/decebals/orgs","repos_url":"https://api.github.com/users/decebals/repos","events_url":"https://api.github.com/users/decebals/events{/privacy}","received_events_url":"https://api.github.com/users/decebals/received_events","type":"User","site_admin":false},"body":"this is a mechanic extraction. it's enough to pass only the pluginWrapper","created_at":"2018-06-20T09:46:27Z","updated_at":"2018-06-20T09:48:48Z","html_url":"https://github.com/pf4j/pf4j/pull/225#discussion_r196712908","pull_request_url":"https://api.github.com/repos/pf4j/pf4j/pulls/225","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pf4j/pf4j/pulls/comments/196712908"},"html":{"href":"https://github.com/pf4j/pf4j/pull/225#discussion_r196712908"},"pull_request":{"href":"https://api.github.com/repos/pf4j/pf4j/pulls/225"}}},"pull_request":{"url":"https://api.github.com/repos/pf4j/pf4j/pulls/225","id":195503748,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NTAzNzQ4","html_url":"https://github.com/pf4j/pf4j/pull/225","diff_url":"https://github.com/pf4j/pf4j/pull/225.diff","patch_url":"https://github.com/pf4j/pf4j/pull/225.patch","issue_url":"https://api.github.com/repos/pf4j/pf4j/issues/225","number":225,"state":"open","locked":false,"title":"Refactor by extracting several methods.","user":{"login":"A4Vision","id":20503353,"node_id":"MDQ6VXNlcjIwNTAzMzUz","avatar_url":"https://avatars2.githubusercontent.com/u/20503353?v=4","gravatar_id":"","url":"https://api.github.com/users/A4Vision","html_url":"https://github.com/A4Vision","followers_url":"https://api.github.com/users/A4Vision/followers","following_url":"https://api.github.com/users/A4Vision/following{/other_user}","gists_url":"https://api.github.com/users/A4Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/A4Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/A4Vision/subscriptions","organizations_url":"https://api.github.com/users/A4Vision/orgs","repos_url":"https://api.github.com/users/A4Vision/repos","events_url":"https://api.github.com/users/A4Vision/events{/privacy}","received_events_url":"https://api.github.com/users/A4Vision/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-18T12:06:43Z","updated_at":"2018-06-20T09:48:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6cad4674c052296714af7bf248a05435af602c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pf4j/pf4j/pulls/225/commits","review_comments_url":"https://api.github.com/repos/pf4j/pf4j/pulls/225/comments","review_comment_url":"https://api.github.com/repos/pf4j/pf4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pf4j/pf4j/issues/225/comments","statuses_url":"https://api.github.com/repos/pf4j/pf4j/statuses/870a8dcb1c969d9a7e44219294b450123d91b413","head":{"label":"A4Vision:master","ref":"master","sha":"870a8dcb1c969d9a7e44219294b450123d91b413","user":{"login":"A4Vision","id":20503353,"node_id":"MDQ6VXNlcjIwNTAzMzUz","avatar_url":"https://avatars2.githubusercontent.com/u/20503353?v=4","gravatar_id":"","url":"https://api.github.com/users/A4Vision","html_url":"https://github.com/A4Vision","followers_url":"https://api.github.com/users/A4Vision/followers","following_url":"https://api.github.com/users/A4Vision/following{/other_user}","gists_url":"https://api.github.com/users/A4Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/A4Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/A4Vision/subscriptions","organizations_url":"https://api.github.com/users/A4Vision/orgs","repos_url":"https://api.github.com/users/A4Vision/repos","events_url":"https://api.github.com/users/A4Vision/events{/privacy}","received_events_url":"https://api.github.com/users/A4Vision/received_events","type":"User","site_admin":false},"repo":{"id":137746832,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3NDY4MzI=","name":"pf4j","full_name":"A4Vision/pf4j","owner":{"login":"A4Vision","id":20503353,"node_id":"MDQ6VXNlcjIwNTAzMzUz","avatar_url":"https://avatars2.githubusercontent.com/u/20503353?v=4","gravatar_id":"","url":"https://api.github.com/users/A4Vision","html_url":"https://github.com/A4Vision","followers_url":"https://api.github.com/users/A4Vision/followers","following_url":"https://api.github.com/users/A4Vision/following{/other_user}","gists_url":"https://api.github.com/users/A4Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/A4Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/A4Vision/subscriptions","organizations_url":"https://api.github.com/users/A4Vision/orgs","repos_url":"https://api.github.com/users/A4Vision/repos","events_url":"https://api.github.com/users/A4Vision/events{/privacy}","received_events_url":"https://api.github.com/users/A4Vision/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/A4Vision/pf4j","description":"Plugin Framework for Java (PF4J)","fork":true,"url":"https://api.github.com/repos/A4Vision/pf4j","forks_url":"https://api.github.com/repos/A4Vision/pf4j/forks","keys_url":"https://api.github.com/repos/A4Vision/pf4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/A4Vision/pf4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/A4Vision/pf4j/teams","hooks_url":"https://api.github.com/repos/A4Vision/pf4j/hooks","issue_events_url":"https://api.github.com/repos/A4Vision/pf4j/issues/events{/number}","events_url":"https://api.github.com/repos/A4Vision/pf4j/events","assignees_url":"https://api.github.com/repos/A4Vision/pf4j/assignees{/user}","branches_url":"https://api.github.com/repos/A4Vision/pf4j/branches{/branch}","tags_url":"https://api.github.com/repos/A4Vision/pf4j/tags","blobs_url":"https://api.github.com/repos/A4Vision/pf4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/A4Vision/pf4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/A4Vision/pf4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/A4Vision/pf4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/A4Vision/pf4j/statuses/{sha}","languages_url":"https://api.github.com/repos/A4Vision/pf4j/languages","stargazers_url":"https://api.github.com/repos/A4Vision/pf4j/stargazers","contributors_url":"https://api.github.com/repos/A4Vision/pf4j/contributors","subscribers_url":"https://api.github.com/repos/A4Vision/pf4j/subscribers","subscription_url":"https://api.github.com/repos/A4Vision/pf4j/subscription","commits_url":"https://api.github.com/repos/A4Vision/pf4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/A4Vision/pf4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/A4Vision/pf4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/A4Vision/pf4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/A4Vision/pf4j/contents/{+path}","compare_url":"https://api.github.com/repos/A4Vision/pf4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/A4Vision/pf4j/merges","archive_url":"https://api.github.com/repos/A4Vision/pf4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/A4Vision/pf4j/downloads","issues_url":"https://api.github.com/repos/A4Vision/pf4j/issues{/number}","pulls_url":"https://api.github.com/repos/A4Vision/pf4j/pulls{/number}","milestones_url":"https://api.github.com/repos/A4Vision/pf4j/milestones{/number}","notifications_url":"https://api.github.com/repos/A4Vision/pf4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/A4Vision/pf4j/labels{/name}","releases_url":"https://api.github.com/repos/A4Vision/pf4j/releases{/id}","deployments_url":"https://api.github.com/repos/A4Vision/pf4j/deployments","created_at":"2018-06-18T12:05:17Z","updated_at":"2018-06-18T12:06:03Z","pushed_at":"2018-06-18T12:06:01Z","git_url":"git://github.com/A4Vision/pf4j.git","ssh_url":"git@github.com:A4Vision/pf4j.git","clone_url":"https://github.com/A4Vision/pf4j.git","svn_url":"https://github.com/A4Vision/pf4j","homepage":"","size":910,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pf4j:master","ref":"master","sha":"c421a3b4e02822d65252b868ecbef3d1a0b09fd8","user":{"login":"pf4j","id":25959549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1OTU5NTQ5","avatar_url":"https://avatars3.githubusercontent.com/u/25959549?v=4","gravatar_id":"","url":"https://api.github.com/users/pf4j","html_url":"https://github.com/pf4j","followers_url":"https://api.github.com/users/pf4j/followers","following_url":"https://api.github.com/users/pf4j/following{/other_user}","gists_url":"https://api.github.com/users/pf4j/gists{/gist_id}","starred_url":"https://api.github.com/users/pf4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pf4j/subscriptions","organizations_url":"https://api.github.com/users/pf4j/orgs","repos_url":"https://api.github.com/users/pf4j/repos","events_url":"https://api.github.com/users/pf4j/events{/privacy}","received_events_url":"https://api.github.com/users/pf4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6157458,"node_id":"MDEwOlJlcG9zaXRvcnk2MTU3NDU4","name":"pf4j","full_name":"pf4j/pf4j","owner":{"login":"pf4j","id":25959549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1OTU5NTQ5","avatar_url":"https://avatars3.githubusercontent.com/u/25959549?v=4","gravatar_id":"","url":"https://api.github.com/users/pf4j","html_url":"https://github.com/pf4j","followers_url":"https://api.github.com/users/pf4j/followers","following_url":"https://api.github.com/users/pf4j/following{/other_user}","gists_url":"https://api.github.com/users/pf4j/gists{/gist_id}","starred_url":"https://api.github.com/users/pf4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pf4j/subscriptions","organizations_url":"https://api.github.com/users/pf4j/orgs","repos_url":"https://api.github.com/users/pf4j/repos","events_url":"https://api.github.com/users/pf4j/events{/privacy}","received_events_url":"https://api.github.com/users/pf4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pf4j/pf4j","description":"Plugin Framework for Java (PF4J)","fork":false,"url":"https://api.github.com/repos/pf4j/pf4j","forks_url":"https://api.github.com/repos/pf4j/pf4j/forks","keys_url":"https://api.github.com/repos/pf4j/pf4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pf4j/pf4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pf4j/pf4j/teams","hooks_url":"https://api.github.com/repos/pf4j/pf4j/hooks","issue_events_url":"https://api.github.com/repos/pf4j/pf4j/issues/events{/number}","events_url":"https://api.github.com/repos/pf4j/pf4j/events","assignees_url":"https://api.github.com/repos/pf4j/pf4j/assignees{/user}","branches_url":"https://api.github.com/repos/pf4j/pf4j/branches{/branch}","tags_url":"https://api.github.com/repos/pf4j/pf4j/tags","blobs_url":"https://api.github.com/repos/pf4j/pf4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pf4j/pf4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pf4j/pf4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/pf4j/pf4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pf4j/pf4j/statuses/{sha}","languages_url":"https://api.github.com/repos/pf4j/pf4j/languages","stargazers_url":"https://api.github.com/repos/pf4j/pf4j/stargazers","contributors_url":"https://api.github.com/repos/pf4j/pf4j/contributors","subscribers_url":"https://api.github.com/repos/pf4j/pf4j/subscribers","subscription_url":"https://api.github.com/repos/pf4j/pf4j/subscription","commits_url":"https://api.github.com/repos/pf4j/pf4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/pf4j/pf4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/pf4j/pf4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/pf4j/pf4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/pf4j/pf4j/contents/{+path}","compare_url":"https://api.github.com/repos/pf4j/pf4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pf4j/pf4j/merges","archive_url":"https://api.github.com/repos/pf4j/pf4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pf4j/pf4j/downloads","issues_url":"https://api.github.com/repos/pf4j/pf4j/issues{/number}","pulls_url":"https://api.github.com/repos/pf4j/pf4j/pulls{/number}","milestones_url":"https://api.github.com/repos/pf4j/pf4j/milestones{/number}","notifications_url":"https://api.github.com/repos/pf4j/pf4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pf4j/pf4j/labels{/name}","releases_url":"https://api.github.com/repos/pf4j/pf4j/releases{/id}","deployments_url":"https://api.github.com/repos/pf4j/pf4j/deployments","created_at":"2012-10-10T13:10:32Z","updated_at":"2018-06-18T04:49:25Z","pushed_at":"2018-06-18T12:06:44Z","git_url":"git://github.com/pf4j/pf4j.git","ssh_url":"git@github.com:pf4j/pf4j.git","clone_url":"https://github.com/pf4j/pf4j.git","svn_url":"https://github.com/pf4j/pf4j","homepage":"","size":898,"stargazers_count":713,"watchers_count":713,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":229,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":229,"open_issues":18,"watchers":713,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pf4j/pf4j/pulls/225"},"html":{"href":"https://github.com/pf4j/pf4j/pull/225"},"issue":{"href":"https://api.github.com/repos/pf4j/pf4j/issues/225"},"comments":{"href":"https://api.github.com/repos/pf4j/pf4j/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/pf4j/pf4j/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/pf4j/pf4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pf4j/pf4j/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/pf4j/pf4j/statuses/870a8dcb1c969d9a7e44219294b450123d91b413"}},"author_association":"NONE"}}
{"actor":{"display_login":"decebals"}}