{"action":"created","issue":{"url":"https://api.github.com/repos/EtienneLamoureux/TQVaultAE/issues/98","repository_url":"https://api.github.com/repos/EtienneLamoureux/TQVaultAE","labels_url":"https://api.github.com/repos/EtienneLamoureux/TQVaultAE/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/EtienneLamoureux/TQVaultAE/issues/98/comments","events_url":"https://api.github.com/repos/EtienneLamoureux/TQVaultAE/issues/98/events","html_url":"https://github.com/EtienneLamoureux/TQVaultAE/pull/98","id":379502092,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTM4NzAz","number":98,"title":"Refactor : improved perf at launch, cleaned up some code","user":{"login":"KenAlin","id":12164749,"node_id":"MDQ6VXNlcjEyMTY0NzQ5","avatar_url":"https://avatars1.githubusercontent.com/u/12164749?v=4","gravatar_id":"","url":"https://api.github.com/users/KenAlin","html_url":"https://github.com/KenAlin","followers_url":"https://api.github.com/users/KenAlin/followers","following_url":"https://api.github.com/users/KenAlin/following{/other_user}","gists_url":"https://api.github.com/users/KenAlin/gists{/gist_id}","starred_url":"https://api.github.com/users/KenAlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KenAlin/subscriptions","organizations_url":"https://api.github.com/users/KenAlin/orgs","repos_url":"https://api.github.com/users/KenAlin/repos","events_url":"https://api.github.com/users/KenAlin/events{/privacy}","received_events_url":"https://api.github.com/users/KenAlin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-11T08:37:35Z","updated_at":"2018-11-11T21:56:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/EtienneLamoureux/TQVaultAE/pulls/98","html_url":"https://github.com/EtienneLamoureux/TQVaultAE/pull/98","diff_url":"https://github.com/EtienneLamoureux/TQVaultAE/pull/98.diff","patch_url":"https://github.com/EtienneLamoureux/TQVaultAE/pull/98.patch"},"body":"Hi,\r\n\r\nThis PR contains two commit.\r\n\r\n* **[Refactor] Replaced try/catch(KeyNotFoundEception) with if (ContainsKey)**\r\n  * Some `try/catch(KeyNotFoundEception)` block are replaced by `if (array.containsKey)/else` blocks. This will greatly improve perfs at launch.\r\n\r\n* **[Refactor] Removed references to old TQ save path, trash and TQVaultMon**\r\n  * With AE, all characters are \"Immortal Throne by default\". This mean it's possible to simplify some methods !\r\n  * Removed references to [trash panel](https://blog-imgs-96-origin.fc2.com/k/e/i/keibro2/2016101002293376b.jpg). This feature was removed long ago. (The screenshot bring back some memories, for sure ! 😄)\r\n  * Removed various unused pieces of code.\r\n\r\nThat's still a pleasure to contribute to TQVault, even if TQ is an old game, it's awesome to see that this project is still active !"},"comment":{"url":"https://api.github.com/repos/EtienneLamoureux/TQVaultAE/issues/comments/437708704","html_url":"https://github.com/EtienneLamoureux/TQVaultAE/pull/98#issuecomment-437708704","issue_url":"https://api.github.com/repos/EtienneLamoureux/TQVaultAE/issues/98","id":437708704,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzcwODcwNA==","user":{"login":"NorthFury","id":1131490,"node_id":"MDQ6VXNlcjExMzE0OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1131490?v=4","gravatar_id":"","url":"https://api.github.com/users/NorthFury","html_url":"https://github.com/NorthFury","followers_url":"https://api.github.com/users/NorthFury/followers","following_url":"https://api.github.com/users/NorthFury/following{/other_user}","gists_url":"https://api.github.com/users/NorthFury/gists{/gist_id}","starred_url":"https://api.github.com/users/NorthFury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NorthFury/subscriptions","organizations_url":"https://api.github.com/users/NorthFury/orgs","repos_url":"https://api.github.com/users/NorthFury/repos","events_url":"https://api.github.com/users/NorthFury/events{/privacy}","received_events_url":"https://api.github.com/users/NorthFury/received_events","type":"User","site_admin":false},"created_at":"2018-11-11T21:56:40Z","updated_at":"2018-11-11T21:56:40Z","author_association":"COLLABORATOR","body":"In regards to removing the check for the existence of the Immortal Throne expansion, at first I thought that it may still be useful for people having old saving games. I stand corrected because those saves will be automatically converted the first time they are loaded in the most recent version of TQ.\r\n\r\nI agree that relying on exceptions is far more costly in terms of performance. This is a nice fix.\r\nI would have expected to be very rare that the keys are not found. Can you notice a significant improvement in startup time? Once you confirm this I'll approve and merge the PR."}}
{"actor":{"display_login":"NorthFury"}}