{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/logstash/issues/10247","repository_url":"https://api.github.com/repos/elastic/logstash","labels_url":"https://api.github.com/repos/elastic/logstash/issues/10247/labels{/name}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/10247/comments","events_url":"https://api.github.com/repos/elastic/logstash/issues/10247/events","html_url":"https://github.com/elastic/logstash/pull/10247","id":395414673,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxODc0MzQ2","number":10247,"title":"Resolve compiler warnings for jruby_9_2 branch","user":{"login":"yaauie","id":210924,"node_id":"MDQ6VXNlcjIxMDkyNA==","avatar_url":"https://avatars1.githubusercontent.com/u/210924?v=4","gravatar_id":"","url":"https://api.github.com/users/yaauie","html_url":"https://github.com/yaauie","followers_url":"https://api.github.com/users/yaauie/followers","following_url":"https://api.github.com/users/yaauie/following{/other_user}","gists_url":"https://api.github.com/users/yaauie/gists{/gist_id}","starred_url":"https://api.github.com/users/yaauie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaauie/subscriptions","organizations_url":"https://api.github.com/users/yaauie/orgs","repos_url":"https://api.github.com/users/yaauie/repos","events_url":"https://api.github.com/users/yaauie/events{/privacy}","received_events_url":"https://api.github.com/users/yaauie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-01-02T23:31:19Z","updated_at":"2019-01-03T15:16:32Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/10247","html_url":"https://github.com/elastic/logstash/pull/10247","diff_url":"https://github.com/elastic/logstash/pull/10247.diff","patch_url":"https://github.com/elastic/logstash/pull/10247.patch"},"body":"_#10244 added `-werror` flag, and this PR addresses the fall-out after the `jruby_9_2` branch was rebased on top of that work_\r\n\r\n***\r\n\r\nThere are 3 types of compiler warnings that are either resolved or suppressed:\r\n\r\n1. Rawtypes: In JRuby 9.2, `RubyArray` is a generic, so references throughout\r\n   our codebase to the now \"raw\" type trigger warnings. In most cases we cannot\r\n   actually resolve the issue, since the JRuby-provided methods for creating\r\n   `RubyArray`s still return the raw type, so these have been suppressed.\r\n\r\n2. Deprecations:\r\n   - `RubyString#intern19()` -> `RubyString#intern()`\r\n   - `RubyString#downcase19(ThreadContext)` -> `RubyString#downcase(ThreadContext)`\r\n   - `NativeException`: remove import & reference directly; suppress usage\r\n     warnings\r\n   - `RaiseException()`: migrate to equivalent non-deprecated methods wherever\r\n     possible; in some cases where we are using this in conjunction with the\r\n     also-deprecated `NativeException` to preserve java stacktraces, there\r\n     seems to be no non-deprecated path forward, so these cases have been\r\n     suppressed.\r\n\r\n3. Redundant Casts\r\n   - Resolved"},"comment":{"url":"https://api.github.com/repos/elastic/logstash/issues/comments/451173093","html_url":"https://github.com/elastic/logstash/pull/10247#issuecomment-451173093","issue_url":"https://api.github.com/repos/elastic/logstash/issues/10247","id":451173093,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTE3MzA5Mw==","user":{"login":"danhermann","id":22777892,"node_id":"MDQ6VXNlcjIyNzc3ODky","avatar_url":"https://avatars0.githubusercontent.com/u/22777892?v=4","gravatar_id":"","url":"https://api.github.com/users/danhermann","html_url":"https://github.com/danhermann","followers_url":"https://api.github.com/users/danhermann/followers","following_url":"https://api.github.com/users/danhermann/following{/other_user}","gists_url":"https://api.github.com/users/danhermann/gists{/gist_id}","starred_url":"https://api.github.com/users/danhermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhermann/subscriptions","organizations_url":"https://api.github.com/users/danhermann/orgs","repos_url":"https://api.github.com/users/danhermann/repos","events_url":"https://api.github.com/users/danhermann/events{/privacy}","received_events_url":"https://api.github.com/users/danhermann/received_events","type":"User","site_admin":false},"created_at":"2019-01-03T15:16:32Z","updated_at":"2019-01-03T15:16:32Z","author_association":"MEMBER","body":"@yaauie, looks good apart from the IDEA-specific annotations. It really is unfortunate that normal use of core JRuby classes such as `RubyArray` trigger compiler warnings, but I guess there's little that can be done about that."}}
{"actor":{"display_login":"danhermann"}}