{"action":"created","issue":{"url":"https://api.github.com/repos/flutter/website/issues/1915","repository_url":"https://api.github.com/repos/flutter/website","labels_url":"https://api.github.com/repos/flutter/website/issues/1915/labels{/name}","comments_url":"https://api.github.com/repos/flutter/website/issues/1915/comments","events_url":"https://api.github.com/repos/flutter/website/issues/1915/events","html_url":"https://github.com/flutter/website/issues/1915","id":388205337,"node_id":"MDU6SXNzdWUzODgyMDUzMzc=","number":1915,"title":"Make Flutter Docs Microsoft Edge Friendly","user":{"login":"zoechi","id":405837,"node_id":"MDQ6VXNlcjQwNTgzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/405837?v=4","gravatar_id":"","url":"https://api.github.com/users/zoechi","html_url":"https://github.com/zoechi","followers_url":"https://api.github.com/users/zoechi/followers","following_url":"https://api.github.com/users/zoechi/following{/other_user}","gists_url":"https://api.github.com/users/zoechi/gists{/gist_id}","starred_url":"https://api.github.com/users/zoechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoechi/subscriptions","organizations_url":"https://api.github.com/users/zoechi/orgs","repos_url":"https://api.github.com/users/zoechi/repos","events_url":"https://api.github.com/users/zoechi/events{/privacy}","received_events_url":"https://api.github.com/users/zoechi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-06T13:05:04Z","updated_at":"2018-12-06T17:11:33Z","closed_at":null,"author_association":"NONE","body":"@bramvbilsen commented on [Sat Apr 21 2018](https://github.com/flutter/flutter/issues/16849)\n\nCurrently, the documentation website for Flutter([https://docs.flutter.io/](https://docs.flutter.io/)) does not work well on Microsoft Edge. Call me crazy, but I actually really enjoy Edge as a web browser. And it is inconvenient that I have to have two web browsers open just to browse the docs.\r\nAnyways, whether you like Edge or not, searching in the docs (via the search bar) leads to the following error page:\r\n![capture](https://user-images.githubusercontent.com/16825392/39088535-33eaf896-45b4-11e8-8de8-59706d8b13ff.PNG)\r\nThis should not happen.\r\n\n\n---\n\n@Hixie commented on [Sun Apr 22 2018](https://github.com/flutter/flutter/issues/16849#issuecomment-383358977)\n\nProbably a bug in Edge?\n\n---\n\n@bramvbilsen commented on [Sun Apr 22 2018](https://github.com/flutter/flutter/issues/16849#issuecomment-383359216)\n\nI can't think of any other website that has this behavior on Edge.\n\n---\n\n@miyoyo commented on [Sun Apr 22 2018](https://github.com/flutter/flutter/issues/16849#issuecomment-383408538)\n\nThis URL doesn't work on chrome either.\r\n\r\nYour url is https://docs.flutter.io/flutter/widgets/widgets/Text-class.html , whereas it should be https://docs.flutter.io/flutter/widgets/Text-class.html\n\n---\n\n@bramvbilsen commented on [Mon Apr 23 2018](https://github.com/flutter/flutter/issues/16849#issuecomment-383420160)\n\nDidn't even notice that! I guess that is the problem then, the search URL doesn't get created properly on Edge 😪\n\n---\n\n@miyoyo commented on [Mon Apr 23 2018](https://github.com/flutter/flutter/issues/16849#issuecomment-383574026)\n\nBehaviour is caused because of this\r\n![applicationframehost_2018-04-23_15-12-53](https://user-images.githubusercontent.com/3525610/39128730-d840bd04-4708-11e8-868e-aa781551f2f5.png)\r\nWhich calls a script (script.js) which does this:\r\n![Script](https://i.imgur.com/FL7QxWM.png)\r\n\r\nI'm not sure why chrome keeps the \"/flutter/\" and cuts everything else after that, but edge just changes the top level element\r\n\r\nSo either edge implements it correctly and chrome is wrong, both are wrong or there is some javascript magic I'm not aware of that keeps the \"/flutter/\" in the URL\r\n\r\nEDIT:\r\nI forgot to say that chrome has the same values as edge in the javascript\r\n![Chrome](https://i.imgur.com/XQeJAU5.png)\n\n---\n\n@Hixie commented on [Mon Apr 23 2018](https://github.com/flutter/flutter/issues/16849#issuecomment-383676251)\n\nEdge is wrong. \r\n\r\nSetting `window.location` goes through this: https://html.spec.whatwg.org/#dom-location-href\r\nThis refers to the base URL set here: https://html.spec.whatwg.org/#script-settings-for-window-objects\r\n...which, if you follow it through, is the document's URL.\r\n\r\nSo setting window.location should parse the URL relative to the document's URL, which means the\r\n`/widgets/` should remain.\n\n---\n\n@bramvbilsen commented on [Fri Apr 27 2018](https://github.com/flutter/flutter/issues/16849#issuecomment-385081058)\n\nNot sure why \"widgets\" was in the url twice, but I tried searching again and it generated this url: [https://docs.flutter.io/flutter/widgets/foundation/Listenable-class.html](url)\r\nI'm getting the same error page.\n\n---\n\n@bramvbilsen commented on [Fri Apr 27 2018](https://github.com/flutter/flutter/issues/16849#issuecomment-385083502)\n\nI did some more testing and noticed the following behavior:\r\n\r\n- Searching `Listenable` from [https://docs.flutter.io/](https://docs.flutter.io/) leads me to [https://docs.flutter.io/foundation/Listenable-class.html](https://docs.flutter.io/foundation/Listenable-class.html)\r\n- Searching from [https://docs.flutter.io/flutter/widgets/Text-class.html](https://docs.flutter.io/flutter/widgets/Text-class.html) leads me to [https://docs.flutter.io/flutter/widgets/foundation/Listenable-class.html](https://docs.flutter.io/flutter/widgets/foundation/Listenable-class.html)\n\n---\n\n@Hixie commented on [Tue May 01 2018](https://github.com/flutter/flutter/issues/16849#issuecomment-385589383)\n\nOn Edge, or in every browser?\n\n---\n\n@bramvbilsen commented on [Tue May 01 2018](https://github.com/flutter/flutter/issues/16849#issuecomment-385647279)\n\nJust Edge 😥\n\n---\n\n@escamoteur commented on [Fri May 04 2018](https://github.com/flutter/flutter/issues/16849#issuecomment-386572456)\n\nEven if Edge is wrong this throws a bad light on Flutter if user use Edge\n\n---\n\n@bramvbilsen commented on [Fri May 04 2018](https://github.com/flutter/flutter/issues/16849#issuecomment-386590131)\n\nExactly, the user shouldn't have to worry about the browser (s)he uses.\n\n---\n\n@Hixie commented on [Sat May 05 2018](https://github.com/flutter/flutter/issues/16849#issuecomment-386755234)\n\nSure, I'm just trying to figure out what kind of issue we should be looking for though when fixing it.\n\n"},"comment":{"url":"https://api.github.com/repos/flutter/website/issues/comments/444951357","html_url":"https://github.com/flutter/website/issues/1915#issuecomment-444951357","issue_url":"https://api.github.com/repos/flutter/website/issues/1915","id":444951357,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDk1MTM1Nw==","user":{"login":"kwalrath","id":2164483,"node_id":"MDQ6VXNlcjIxNjQ0ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/2164483?v=4","gravatar_id":"","url":"https://api.github.com/users/kwalrath","html_url":"https://github.com/kwalrath","followers_url":"https://api.github.com/users/kwalrath/followers","following_url":"https://api.github.com/users/kwalrath/following{/other_user}","gists_url":"https://api.github.com/users/kwalrath/gists{/gist_id}","starred_url":"https://api.github.com/users/kwalrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwalrath/subscriptions","organizations_url":"https://api.github.com/users/kwalrath/orgs","repos_url":"https://api.github.com/users/kwalrath/repos","events_url":"https://api.github.com/users/kwalrath/events{/privacy}","received_events_url":"https://api.github.com/users/kwalrath/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T17:11:33Z","updated_at":"2018-12-06T17:11:33Z","author_association":"CONTRIBUTOR","body":"Is this still an issue in the new website?"}}
{"actor":{"display_login":"kwalrath"}}