{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/installer/issues/34","repository_url":"https://api.github.com/repos/openshift/installer","labels_url":"https://api.github.com/repos/openshift/installer/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/openshift/installer/issues/34/comments","events_url":"https://api.github.com/repos/openshift/installer/issues/34/events","html_url":"https://github.com/openshift/installer/pull/34","id":339288638,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTgwMTY3","number":34,"title":"scripts/maintenance: Assorted cleanup (stderr output, drop --workspace-dir, etc.)","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-09T02:53:51Z","updated_at":"2018-07-09T02:53:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/34","html_url":"https://github.com/openshift/installer/pull/34","diff_url":"https://github.com/openshift/installer/pull/34.diff","patch_url":"https://github.com/openshift/installer/pull/34.patch"},"body":"This pull request makes a series of mostly-orthogonal pivots to `scripts/maintenance/*.sh`.  If it makes review easier, I can file individual PRs for each commit.  There are additional details and motivation for each pivot in the associated commit message, but basically I've:\n\n* Fixed unrecognized-option handling.  Now it prints the unrecognized option and exits nonzero.\n* Added missing-dependency checks to the `*-aws.sh` scripts.  Now all three scripts will print the missing command to stderr (at least on Bash 4.4; [POSIX doesn't get specific about stderr for `command`][1]).\n* Written all error messages to stderr.  We used to write them to stdout.\n* Dropped an unecessary `-e` from `tag-route53-hosted-zones.sh`'s `echo` calls.\n* Dropped an unused `--workspace-dir` (you can now get similar control with `$TMPDIR`) and fixed `--config-file`, `--exclude-file`, and `--tag-file` handling.  Previously content supplied by those `--*-file` options was not visible from the container.\n\nI haven't fully tested these changes, and it looks like only `tag-aws.sh` is consumed by our CI, so it would be good if someone with access to a dev system could put the adjusted scripts through their paces before this lands (and that's assuming the changes sound appealing ;).\n\n[1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/command.html"},"comment":{"url":"https://api.github.com/repos/openshift/installer/issues/comments/403345598","html_url":"https://github.com/openshift/installer/pull/34#issuecomment-403345598","issue_url":"https://api.github.com/repos/openshift/installer/issues/34","id":403345598,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzM0NTU5OA==","user":{"login":"coreosbot","id":6148850,"node_id":"MDQ6VXNlcjYxNDg4NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6148850?v=4","gravatar_id":"","url":"https://api.github.com/users/coreosbot","html_url":"https://github.com/coreosbot","followers_url":"https://api.github.com/users/coreosbot/followers","following_url":"https://api.github.com/users/coreosbot/following{/other_user}","gists_url":"https://api.github.com/users/coreosbot/gists{/gist_id}","starred_url":"https://api.github.com/users/coreosbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreosbot/subscriptions","organizations_url":"https://api.github.com/users/coreosbot/orgs","repos_url":"https://api.github.com/users/coreosbot/repos","events_url":"https://api.github.com/users/coreosbot/events{/privacy}","received_events_url":"https://api.github.com/users/coreosbot/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T02:53:54Z","updated_at":"2018-07-09T02:53:54Z","author_association":"NONE","body":"Can one of the admins verify this patch?"}}
{"actor":{"display_login":"coreosbot"}}