{"action":"created","comment":{"url":"https://api.github.com/repos/rpherbig/dr-scripts/pulls/comments/213712225","pull_request_review_id":150604102,"id":213712225,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzcxMjIyNQ==","diff_hunk":"@@ -1998,6 +2013,177 @@ class TrainerProcess\n     DRRoom.dead_npcs.size > dead_count\n   end\n \n+  def check_heavens(game_state)\n+    @equipment_manager.stow_weapon(game_state.weapon_name)\n+    echo \"Getting telescope\"\n+    case DRC.bput(\"get my telescope\",\"You get a\", \"You need a free hand to pick that up.\", \"You are already holding that.\")\n+    when \"You get a\"\n+      determine_time\n+    when \"You need a free hand to pick that up.\"\n+      quick_retry\n+    when \"You are already holding that.\"\n+      determine_time\n+    end\n+  end\n+\n+  def determine_time\n+    echo \"Determining time\"\n+    case DRC.bput(\"time\",\"it is dawn\", \"morning\", \"midday\", \"noon\", \"afternoon\", \"dusk\", \"sunset\", \"evening\", \"midnight\", \"night\", \"almost dawn\", \"approaching sunrise\")\n+    when \"it is dawn\"","path":"combat-trainer.lic","position":42,"original_position":42,"commit_id":"de9fc095b2284a96d421c6d51103f3f564243fcf","original_commit_id":"de9fc095b2284a96d421c6d51103f3f564243fcf","user":{"login":"rpherbig","id":1181607,"node_id":"MDQ6VXNlcjExODE2MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1181607?v=4","gravatar_id":"","url":"https://api.github.com/users/rpherbig","html_url":"https://github.com/rpherbig","followers_url":"https://api.github.com/users/rpherbig/followers","following_url":"https://api.github.com/users/rpherbig/following{/other_user}","gists_url":"https://api.github.com/users/rpherbig/gists{/gist_id}","starred_url":"https://api.github.com/users/rpherbig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpherbig/subscriptions","organizations_url":"https://api.github.com/users/rpherbig/orgs","repos_url":"https://api.github.com/users/rpherbig/repos","events_url":"https://api.github.com/users/rpherbig/events{/privacy}","received_events_url":"https://api.github.com/users/rpherbig/received_events","type":"User","site_admin":false},"body":"💡 You could merge a lot of these `whens`:\r\n```ruby\r\ncase ...\r\nwhen \"it is dawn\", \"morning\"\r\n    day_center\r\nwhen \"sunset\", \"evening\"\r\n...\r\n```","created_at":"2018-08-29T14:55:58Z","updated_at":"2018-08-29T14:55:59Z","html_url":"https://github.com/rpherbig/dr-scripts/pull/3097#discussion_r213712225","pull_request_url":"https://api.github.com/repos/rpherbig/dr-scripts/pulls/3097","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/rpherbig/dr-scripts/pulls/comments/213712225"},"html":{"href":"https://github.com/rpherbig/dr-scripts/pull/3097#discussion_r213712225"},"pull_request":{"href":"https://api.github.com/repos/rpherbig/dr-scripts/pulls/3097"}}},"pull_request":{"url":"https://api.github.com/repos/rpherbig/dr-scripts/pulls/3097","id":211444049,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNDQ0MDQ5","html_url":"https://github.com/rpherbig/dr-scripts/pull/3097","diff_url":"https://github.com/rpherbig/dr-scripts/pull/3097.diff","patch_url":"https://github.com/rpherbig/dr-scripts/pull/3097.patch","issue_url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/3097","number":3097,"state":"open","locked":false,"title":"Combat astrology and walking astrology support","user":{"login":"BastionWT","id":22065719,"node_id":"MDQ6VXNlcjIyMDY1NzE5","avatar_url":"https://avatars2.githubusercontent.com/u/22065719?v=4","gravatar_id":"","url":"https://api.github.com/users/BastionWT","html_url":"https://github.com/BastionWT","followers_url":"https://api.github.com/users/BastionWT/followers","following_url":"https://api.github.com/users/BastionWT/following{/other_user}","gists_url":"https://api.github.com/users/BastionWT/gists{/gist_id}","starred_url":"https://api.github.com/users/BastionWT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BastionWT/subscriptions","organizations_url":"https://api.github.com/users/BastionWT/orgs","repos_url":"https://api.github.com/users/BastionWT/repos","events_url":"https://api.github.com/users/BastionWT/events{/privacy}","received_events_url":"https://api.github.com/users/BastionWT/received_events","type":"User","site_admin":false},"body":"This pull request includes two things:\r\n1. Changes to combat-trainer.lic\r\n2. Adding walkingastro.lic\r\n\r\nCombat-trainer changes include repurposing the training_ability Astro: XXX to observe either the Sun (day) or the Heart constellation (night) on that timer. It will continue to do so until the Survival prediction pool is full (observation messaging), at which point it will check the Astrology skill's exp. If under 25, it will align to the Survival skill designated in the user's setup.yaml (astrology_prediction_skills: -> Survival), or default to \"survival\" as the base.yaml setting and predict the future.\r\n\r\nWakingastro does the same things as mentioned above, but outside of combat, similar to the newly included ;play script. It is meant to be run as a background process, and will time out intentionally when certain scripts are in-process.\r\n\r\nBoth scripts assume the usage of a telescope. Both scripts assume PG is up. Walkingastro assumes the usage of a telescope case. The latter will be adjusted in a subsequent pull.\r\n\r\nWanted to get this out there for further testing. In the last day that this has been running, I've had to run ;astrology a single time. combat-trainer and walkingastro have kept Astrology moving constantly.","created_at":"2018-08-28T14:31:18Z","updated_at":"2018-08-29T14:55:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f0f0e9b9f729d0fa52f049566405b5c16ab4c4e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rpherbig/dr-scripts/pulls/3097/commits","review_comments_url":"https://api.github.com/repos/rpherbig/dr-scripts/pulls/3097/comments","review_comment_url":"https://api.github.com/repos/rpherbig/dr-scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/3097/comments","statuses_url":"https://api.github.com/repos/rpherbig/dr-scripts/statuses/de9fc095b2284a96d421c6d51103f3f564243fcf","head":{"label":"BastionWT:combatastro","ref":"combatastro","sha":"de9fc095b2284a96d421c6d51103f3f564243fcf","user":{"login":"BastionWT","id":22065719,"node_id":"MDQ6VXNlcjIyMDY1NzE5","avatar_url":"https://avatars2.githubusercontent.com/u/22065719?v=4","gravatar_id":"","url":"https://api.github.com/users/BastionWT","html_url":"https://github.com/BastionWT","followers_url":"https://api.github.com/users/BastionWT/followers","following_url":"https://api.github.com/users/BastionWT/following{/other_user}","gists_url":"https://api.github.com/users/BastionWT/gists{/gist_id}","starred_url":"https://api.github.com/users/BastionWT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BastionWT/subscriptions","organizations_url":"https://api.github.com/users/BastionWT/orgs","repos_url":"https://api.github.com/users/BastionWT/repos","events_url":"https://api.github.com/users/BastionWT/events{/privacy}","received_events_url":"https://api.github.com/users/BastionWT/received_events","type":"User","site_admin":false},"repo":{"id":142927457,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5Mjc0NTc=","name":"dr-scripts","full_name":"BastionWT/dr-scripts","owner":{"login":"BastionWT","id":22065719,"node_id":"MDQ6VXNlcjIyMDY1NzE5","avatar_url":"https://avatars2.githubusercontent.com/u/22065719?v=4","gravatar_id":"","url":"https://api.github.com/users/BastionWT","html_url":"https://github.com/BastionWT","followers_url":"https://api.github.com/users/BastionWT/followers","following_url":"https://api.github.com/users/BastionWT/following{/other_user}","gists_url":"https://api.github.com/users/BastionWT/gists{/gist_id}","starred_url":"https://api.github.com/users/BastionWT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BastionWT/subscriptions","organizations_url":"https://api.github.com/users/BastionWT/orgs","repos_url":"https://api.github.com/users/BastionWT/repos","events_url":"https://api.github.com/users/BastionWT/events{/privacy}","received_events_url":"https://api.github.com/users/BastionWT/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BastionWT/dr-scripts","description":"A series of Lich (https://lichproject.org/) scripts for use in DragonRealms (http://www.play.net/dr/). Donations are welcome (http://www.paypal.me/rcuhljr)!","fork":true,"url":"https://api.github.com/repos/BastionWT/dr-scripts","forks_url":"https://api.github.com/repos/BastionWT/dr-scripts/forks","keys_url":"https://api.github.com/repos/BastionWT/dr-scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BastionWT/dr-scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BastionWT/dr-scripts/teams","hooks_url":"https://api.github.com/repos/BastionWT/dr-scripts/hooks","issue_events_url":"https://api.github.com/repos/BastionWT/dr-scripts/issues/events{/number}","events_url":"https://api.github.com/repos/BastionWT/dr-scripts/events","assignees_url":"https://api.github.com/repos/BastionWT/dr-scripts/assignees{/user}","branches_url":"https://api.github.com/repos/BastionWT/dr-scripts/branches{/branch}","tags_url":"https://api.github.com/repos/BastionWT/dr-scripts/tags","blobs_url":"https://api.github.com/repos/BastionWT/dr-scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BastionWT/dr-scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BastionWT/dr-scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/BastionWT/dr-scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BastionWT/dr-scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/BastionWT/dr-scripts/languages","stargazers_url":"https://api.github.com/repos/BastionWT/dr-scripts/stargazers","contributors_url":"https://api.github.com/repos/BastionWT/dr-scripts/contributors","subscribers_url":"https://api.github.com/repos/BastionWT/dr-scripts/subscribers","subscription_url":"https://api.github.com/repos/BastionWT/dr-scripts/subscription","commits_url":"https://api.github.com/repos/BastionWT/dr-scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/BastionWT/dr-scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/BastionWT/dr-scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/BastionWT/dr-scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/BastionWT/dr-scripts/contents/{+path}","compare_url":"https://api.github.com/repos/BastionWT/dr-scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BastionWT/dr-scripts/merges","archive_url":"https://api.github.com/repos/BastionWT/dr-scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BastionWT/dr-scripts/downloads","issues_url":"https://api.github.com/repos/BastionWT/dr-scripts/issues{/number}","pulls_url":"https://api.github.com/repos/BastionWT/dr-scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/BastionWT/dr-scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/BastionWT/dr-scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BastionWT/dr-scripts/labels{/name}","releases_url":"https://api.github.com/repos/BastionWT/dr-scripts/releases{/id}","deployments_url":"https://api.github.com/repos/BastionWT/dr-scripts/deployments","created_at":"2018-07-30T20:57:47Z","updated_at":"2018-07-30T20:57:49Z","pushed_at":"2018-08-29T04:00:20Z","git_url":"git://github.com/BastionWT/dr-scripts.git","ssh_url":"git@github.com:BastionWT/dr-scripts.git","clone_url":"https://github.com/BastionWT/dr-scripts.git","svn_url":"https://github.com/BastionWT/dr-scripts","homepage":"","size":9970,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rpherbig:master","ref":"master","sha":"5963989565d0e07f0939c9f5de6f9740bbb130d0","user":{"login":"rpherbig","id":1181607,"node_id":"MDQ6VXNlcjExODE2MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1181607?v=4","gravatar_id":"","url":"https://api.github.com/users/rpherbig","html_url":"https://github.com/rpherbig","followers_url":"https://api.github.com/users/rpherbig/followers","following_url":"https://api.github.com/users/rpherbig/following{/other_user}","gists_url":"https://api.github.com/users/rpherbig/gists{/gist_id}","starred_url":"https://api.github.com/users/rpherbig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpherbig/subscriptions","organizations_url":"https://api.github.com/users/rpherbig/orgs","repos_url":"https://api.github.com/users/rpherbig/repos","events_url":"https://api.github.com/users/rpherbig/events{/privacy}","received_events_url":"https://api.github.com/users/rpherbig/received_events","type":"User","site_admin":false},"repo":{"id":44390324,"node_id":"MDEwOlJlcG9zaXRvcnk0NDM5MDMyNA==","name":"dr-scripts","full_name":"rpherbig/dr-scripts","owner":{"login":"rpherbig","id":1181607,"node_id":"MDQ6VXNlcjExODE2MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1181607?v=4","gravatar_id":"","url":"https://api.github.com/users/rpherbig","html_url":"https://github.com/rpherbig","followers_url":"https://api.github.com/users/rpherbig/followers","following_url":"https://api.github.com/users/rpherbig/following{/other_user}","gists_url":"https://api.github.com/users/rpherbig/gists{/gist_id}","starred_url":"https://api.github.com/users/rpherbig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpherbig/subscriptions","organizations_url":"https://api.github.com/users/rpherbig/orgs","repos_url":"https://api.github.com/users/rpherbig/repos","events_url":"https://api.github.com/users/rpherbig/events{/privacy}","received_events_url":"https://api.github.com/users/rpherbig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rpherbig/dr-scripts","description":"A series of Lich (https://lichproject.org/) scripts for use in DragonRealms (http://www.play.net/dr/). Donations are welcome (http://www.paypal.me/rcuhljr)!","fork":false,"url":"https://api.github.com/repos/rpherbig/dr-scripts","forks_url":"https://api.github.com/repos/rpherbig/dr-scripts/forks","keys_url":"https://api.github.com/repos/rpherbig/dr-scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpherbig/dr-scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpherbig/dr-scripts/teams","hooks_url":"https://api.github.com/repos/rpherbig/dr-scripts/hooks","issue_events_url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/events{/number}","events_url":"https://api.github.com/repos/rpherbig/dr-scripts/events","assignees_url":"https://api.github.com/repos/rpherbig/dr-scripts/assignees{/user}","branches_url":"https://api.github.com/repos/rpherbig/dr-scripts/branches{/branch}","tags_url":"https://api.github.com/repos/rpherbig/dr-scripts/tags","blobs_url":"https://api.github.com/repos/rpherbig/dr-scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpherbig/dr-scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpherbig/dr-scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpherbig/dr-scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpherbig/dr-scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/rpherbig/dr-scripts/languages","stargazers_url":"https://api.github.com/repos/rpherbig/dr-scripts/stargazers","contributors_url":"https://api.github.com/repos/rpherbig/dr-scripts/contributors","subscribers_url":"https://api.github.com/repos/rpherbig/dr-scripts/subscribers","subscription_url":"https://api.github.com/repos/rpherbig/dr-scripts/subscription","commits_url":"https://api.github.com/repos/rpherbig/dr-scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpherbig/dr-scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpherbig/dr-scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpherbig/dr-scripts/contents/{+path}","compare_url":"https://api.github.com/repos/rpherbig/dr-scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpherbig/dr-scripts/merges","archive_url":"https://api.github.com/repos/rpherbig/dr-scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpherbig/dr-scripts/downloads","issues_url":"https://api.github.com/repos/rpherbig/dr-scripts/issues{/number}","pulls_url":"https://api.github.com/repos/rpherbig/dr-scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/rpherbig/dr-scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/rpherbig/dr-scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpherbig/dr-scripts/labels{/name}","releases_url":"https://api.github.com/repos/rpherbig/dr-scripts/releases{/id}","deployments_url":"https://api.github.com/repos/rpherbig/dr-scripts/deployments","created_at":"2015-10-16T14:28:28Z","updated_at":"2018-08-29T14:54:49Z","pushed_at":"2018-08-29T14:54:44Z","git_url":"git://github.com/rpherbig/dr-scripts.git","ssh_url":"git@github.com:rpherbig/dr-scripts.git","clone_url":"https://github.com/rpherbig/dr-scripts.git","svn_url":"https://github.com/rpherbig/dr-scripts","homepage":"","size":9881,"stargazers_count":28,"watchers_count":28,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":349,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":84,"open_issues":349,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rpherbig/dr-scripts/pulls/3097"},"html":{"href":"https://github.com/rpherbig/dr-scripts/pull/3097"},"issue":{"href":"https://api.github.com/repos/rpherbig/dr-scripts/issues/3097"},"comments":{"href":"https://api.github.com/repos/rpherbig/dr-scripts/issues/3097/comments"},"review_comments":{"href":"https://api.github.com/repos/rpherbig/dr-scripts/pulls/3097/comments"},"review_comment":{"href":"https://api.github.com/repos/rpherbig/dr-scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rpherbig/dr-scripts/pulls/3097/commits"},"statuses":{"href":"https://api.github.com/repos/rpherbig/dr-scripts/statuses/de9fc095b2284a96d421c6d51103f3f564243fcf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rpherbig"}}