{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/239881708","pull_request_review_id":182789958,"id":239881708,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTg4MTcwOA==","diff_hunk":"@@ -96,6 +127,7 @@ private StringEscapeCharacterFormatDefinition()\n         [Name(ClassificationTypeNames.ClassName)]\n         [Order(After = PredefinedClassificationTypeNames.Identifier)]\n         [Order(After = PredefinedClassificationTypeNames.Keyword)]\n+        [Order(Before = ClassificationTypeNames.StaticSymbol)]","path":"src/EditorFeatures/Core.Wpf/Classification/ClassificationTypeFormatDefinitions.cs","position":42,"original_position":42,"commit_id":"adb08de5a79f43e2e8a9d9b6f2bbe4dd2180b4e1","original_commit_id":"3b6c713440beaf5ca8e204fed787c4dadd1413cd","user":{"login":"JoeRobich","id":611219,"node_id":"MDQ6VXNlcjYxMTIxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/611219?v=4","gravatar_id":"","url":"https://api.github.com/users/JoeRobich","html_url":"https://github.com/JoeRobich","followers_url":"https://api.github.com/users/JoeRobich/followers","following_url":"https://api.github.com/users/JoeRobich/following{/other_user}","gists_url":"https://api.github.com/users/JoeRobich/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeRobich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeRobich/subscriptions","organizations_url":"https://api.github.com/users/JoeRobich/orgs","repos_url":"https://api.github.com/users/JoeRobich/repos","events_url":"https://api.github.com/users/JoeRobich/events{/privacy}","received_events_url":"https://api.github.com/users/JoeRobich/received_events","type":"User","site_admin":false},"body":"The static classification is ordered last so that it trumps any styling given to the specific identifier types. Currently we are limiting the static style to being either bold or not","created_at":"2018-12-07T17:14:10Z","updated_at":"2018-12-07T17:14:10Z","html_url":"https://github.com/dotnet/roslyn/pull/31231#discussion_r239881708","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/31231","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/239881708"},"html":{"href":"https://github.com/dotnet/roslyn/pull/31231#discussion_r239881708"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/31231"}},"in_reply_to_id":239676261},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/31231","id":231694469,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjk0NDY5","html_url":"https://github.com/dotnet/roslyn/pull/31231","diff_url":"https://github.com/dotnet/roslyn/pull/31231.diff","patch_url":"https://github.com/dotnet/roslyn/pull/31231.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/31231","number":31231,"state":"open","locked":false,"title":"Add new classifications","user":{"login":"JoeRobich","id":611219,"node_id":"MDQ6VXNlcjYxMTIxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/611219?v=4","gravatar_id":"","url":"https://api.github.com/users/JoeRobich","html_url":"https://github.com/JoeRobich","followers_url":"https://api.github.com/users/JoeRobich/followers","following_url":"https://api.github.com/users/JoeRobich/following{/other_user}","gists_url":"https://api.github.com/users/JoeRobich/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeRobich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeRobich/subscriptions","organizations_url":"https://api.github.com/users/JoeRobich/orgs","repos_url":"https://api.github.com/users/JoeRobich/repos","events_url":"https://api.github.com/users/JoeRobich/events{/privacy}","received_events_url":"https://api.github.com/users/JoeRobich/received_events","type":"User","site_admin":false},"body":"This PR introduces new classifications for 4 concepts\r\n- Symbol Kinds\r\n- Operator Overloads\r\n- Control Keywords\r\n- Static Symbols\r\n\r\n## Symbol Kinds\r\nMost of the classifications have already been added but never exposed to users via `ClassifiationFormatDefinitions`. In this PR I add `ClassificationFormatDefinitions` for the classifications added in https://github.com/dotnet/roslyn/pull/25126 as well as new classifications for Namespace name and Label name.\r\n•\tUser Symbols - Field Name\r\n•\tUser Symbols - Enum Member Name\r\n•\tUser Symbols - Constant Name\r\n•\tUser Symbols - Local Name\r\n•\tUser Symbols - Parameter Name\r\n•\tUser Symbols - Method Name\r\n•\tUser Symbols - Extension Method Name\r\n•\tUser Symbols - Property Name\r\n•\tUser Symbols - Event Name\r\n•\tUser Symbols - Namespace Name\r\n•\tUser Symbols - Label Name\r\n\r\n## Operator Overloads \r\nRequested in https://github.com/dotnet/roslyn/issues/29492. This classification sematically classifies overloaded operators.\r\n•\tOperator - Overload\r\n\r\n## Control Keywords\r\nRequested in https://github.com/dotnet/roslyn/issues/18810. This classification syntactically classifies control keywords\r\n•\tKeyword - Control\r\n\r\n## Static Symbols\r\nThis classification would visually inform developers that a Symbol was static. This classification is additive in that it is an additional tag that static symbols are given in addition to their identifier type. This allows for Static Symbols to be configured to be Bold and Field Names to be Orange and the editor will render Static Fields in Bold Orange.\r\n•\tSymbol - Static\r\n\r\n\r\n","created_at":"2018-11-17T00:59:37Z","updated_at":"2018-12-07T17:14:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f66c0a49182e94d7638f30805565b545d4833014","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"roslyn-compiler","id":1803172,"node_id":"MDQ6VGVhbTE4MDMxNzI=","slug":"roslyn-compiler","description":"Roslyn Compiler Team","privacy":"closed","url":"https://api.github.com/teams/1803172","members_url":"https://api.github.com/teams/1803172/members{/member}","repositories_url":"https://api.github.com/teams/1803172/repos","permission":"pull"}],"labels":[{"id":166377917,"node_id":"MDU6TGFiZWwxNjYzNzc5MTc=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/31231/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/31231/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/31231/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/adb08de5a79f43e2e8a9d9b6f2bbe4dd2180b4e1","head":{"label":"JoeRobich:add-new-classifications","ref":"add-new-classifications","sha":"adb08de5a79f43e2e8a9d9b6f2bbe4dd2180b4e1","user":{"login":"JoeRobich","id":611219,"node_id":"MDQ6VXNlcjYxMTIxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/611219?v=4","gravatar_id":"","url":"https://api.github.com/users/JoeRobich","html_url":"https://github.com/JoeRobich","followers_url":"https://api.github.com/users/JoeRobich/followers","following_url":"https://api.github.com/users/JoeRobich/following{/other_user}","gists_url":"https://api.github.com/users/JoeRobich/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeRobich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeRobich/subscriptions","organizations_url":"https://api.github.com/users/JoeRobich/orgs","repos_url":"https://api.github.com/users/JoeRobich/repos","events_url":"https://api.github.com/users/JoeRobich/events{/privacy}","received_events_url":"https://api.github.com/users/JoeRobich/received_events","type":"User","site_admin":false},"repo":{"id":143078388,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNzgzODg=","name":"roslyn","full_name":"JoeRobich/roslyn","private":false,"owner":{"login":"JoeRobich","id":611219,"node_id":"MDQ6VXNlcjYxMTIxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/611219?v=4","gravatar_id":"","url":"https://api.github.com/users/JoeRobich","html_url":"https://github.com/JoeRobich","followers_url":"https://api.github.com/users/JoeRobich/followers","following_url":"https://api.github.com/users/JoeRobich/following{/other_user}","gists_url":"https://api.github.com/users/JoeRobich/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeRobich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeRobich/subscriptions","organizations_url":"https://api.github.com/users/JoeRobich/orgs","repos_url":"https://api.github.com/users/JoeRobich/repos","events_url":"https://api.github.com/users/JoeRobich/events{/privacy}","received_events_url":"https://api.github.com/users/JoeRobich/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JoeRobich/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/JoeRobich/roslyn","forks_url":"https://api.github.com/repos/JoeRobich/roslyn/forks","keys_url":"https://api.github.com/repos/JoeRobich/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoeRobich/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoeRobich/roslyn/teams","hooks_url":"https://api.github.com/repos/JoeRobich/roslyn/hooks","issue_events_url":"https://api.github.com/repos/JoeRobich/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/JoeRobich/roslyn/events","assignees_url":"https://api.github.com/repos/JoeRobich/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/JoeRobich/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/JoeRobich/roslyn/tags","blobs_url":"https://api.github.com/repos/JoeRobich/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoeRobich/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoeRobich/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoeRobich/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoeRobich/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/JoeRobich/roslyn/languages","stargazers_url":"https://api.github.com/repos/JoeRobich/roslyn/stargazers","contributors_url":"https://api.github.com/repos/JoeRobich/roslyn/contributors","subscribers_url":"https://api.github.com/repos/JoeRobich/roslyn/subscribers","subscription_url":"https://api.github.com/repos/JoeRobich/roslyn/subscription","commits_url":"https://api.github.com/repos/JoeRobich/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoeRobich/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoeRobich/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoeRobich/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoeRobich/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/JoeRobich/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoeRobich/roslyn/merges","archive_url":"https://api.github.com/repos/JoeRobich/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoeRobich/roslyn/downloads","issues_url":"https://api.github.com/repos/JoeRobich/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/JoeRobich/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/JoeRobich/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/JoeRobich/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoeRobich/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/JoeRobich/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/JoeRobich/roslyn/deployments","created_at":"2018-07-31T23:00:58Z","updated_at":"2018-07-31T23:01:46Z","pushed_at":"2018-12-07T01:49:28Z","git_url":"git://github.com/JoeRobich/roslyn.git","ssh_url":"git@github.com:JoeRobich/roslyn.git","clone_url":"https://github.com/JoeRobich/roslyn.git","svn_url":"https://github.com/JoeRobich/roslyn","homepage":"","size":450143,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f55a4ce4d054d5148595f71ca7441f68f9eb3527","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/roslyn","description":"The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-12-07T15:39:43Z","pushed_at":"2018-12-07T15:28:56Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/","size":498733,"stargazers_count":10454,"watchers_count":10454,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2489,"mirror_url":null,"archived":false,"open_issues_count":5484,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2489,"open_issues":5484,"watchers":10454,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/31231"},"html":{"href":"https://github.com/dotnet/roslyn/pull/31231"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/31231"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/31231/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/31231/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/31231/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/adb08de5a79f43e2e8a9d9b6f2bbe4dd2180b4e1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"JoeRobich"}}