{"action":"created","issue":{"url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/452","repository_url":"https://api.github.com/repos/micrometer-metrics/micrometer","labels_url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/452/labels{/name}","comments_url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/452/comments","events_url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/452/events","html_url":"https://github.com/micrometer-metrics/micrometer/issues/452","id":298968407,"number":452,"title":"NaN for tomcatServletRequest metrics export to Graphite","user":{"login":"mpaluchowski","id":727642,"avatar_url":"https://avatars1.githubusercontent.com/u/727642?v=4","gravatar_id":"","url":"https://api.github.com/users/mpaluchowski","html_url":"https://github.com/mpaluchowski","followers_url":"https://api.github.com/users/mpaluchowski/followers","following_url":"https://api.github.com/users/mpaluchowski/following{/other_user}","gists_url":"https://api.github.com/users/mpaluchowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mpaluchowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpaluchowski/subscriptions","organizations_url":"https://api.github.com/users/mpaluchowski/orgs","repos_url":"https://api.github.com/users/mpaluchowski/repos","events_url":"https://api.github.com/users/mpaluchowski/events{/privacy}","received_events_url":"https://api.github.com/users/mpaluchowski/received_events","type":"User","site_admin":false},"labels":[{"id":580980793,"url":"https://api.github.com/repos/micrometer-metrics/micrometer/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/micrometer-metrics/micrometer/milestones/23","html_url":"https://github.com/micrometer-metrics/micrometer/milestone/23","labels_url":"https://api.github.com/repos/micrometer-metrics/micrometer/milestones/23/labels","id":3133106,"number":23,"title":"1.0.1","description":null,"creator":{"login":"jkschneider","id":1697736,"avatar_url":"https://avatars2.githubusercontent.com/u/1697736?v=4","gravatar_id":"","url":"https://api.github.com/users/jkschneider","html_url":"https://github.com/jkschneider","followers_url":"https://api.github.com/users/jkschneider/followers","following_url":"https://api.github.com/users/jkschneider/following{/other_user}","gists_url":"https://api.github.com/users/jkschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/jkschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkschneider/subscriptions","organizations_url":"https://api.github.com/users/jkschneider/orgs","repos_url":"https://api.github.com/users/jkschneider/repos","events_url":"https://api.github.com/users/jkschneider/events{/privacy}","received_events_url":"https://api.github.com/users/jkschneider/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":2,"state":"open","created_at":"2018-02-21T14:21:18Z","updated_at":"2018-02-21T22:20:48Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-02-21T13:24:55Z","updated_at":"2018-02-21T22:32:15Z","closed_at":null,"author_association":"NONE","body":"We're seeing errors with Micrometer 1.0.0 exporting Tomcat metrics to Graphite, on Spring Boot 1.5.10. Here's the output from Graphite's Carbon logs:\r\n\r\n```\r\n[2018-02-21T12:27:37.437+0100] INFO [tcp] parse failed {\"error\": \"bad message: \\\"services.bp.file-storage.dev.all.file-storage-4289024796-e8bq3.tomcatServletRequest.name.default.mean NaN 1519212457\\\\n\\\"\", \"peer\": \"10.149.18.190:37792\"}\r\n[2018-02-21T12:27:37.437+0100] INFO [tcp] parse failed {\"error\": \"bad message: \\\"services.bp.file-storage.dev.all.file-storage-4289024796-e8bq3.tomcatServletRequest.name.default.p50 NaN 1519212457\\\\n\\\"\", \"peer\": \"10.149.18.190:37792\"}\r\n```\r\n\r\nIt's only for the `tomcatServletRequest.name.default.p50` and `tomcatServletRequest.name.default.mean` metrics. Others in the namespace export without errors.\r\n\r\nOut configuration is:\r\n\r\n```yaml\r\nmanagement.metrics.export.graphite.protocol=plaintext\r\nmanagement.metrics.export.graphite.step=PT10S\r\n```\r\n\r\nand beyond we have a custom implementation of `HierarchicalNameMapper`, that adds the prefix of `storage.dev.all...`.\r\n\r\nIs that a bug? Any idea what could be causing it?"},"comment":{"url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/comments/367499571","html_url":"https://github.com/micrometer-metrics/micrometer/issues/452#issuecomment-367499571","issue_url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/452","id":367499571,"user":{"login":"jkschneider","id":1697736,"avatar_url":"https://avatars2.githubusercontent.com/u/1697736?v=4","gravatar_id":"","url":"https://api.github.com/users/jkschneider","html_url":"https://github.com/jkschneider","followers_url":"https://api.github.com/users/jkschneider/followers","following_url":"https://api.github.com/users/jkschneider/following{/other_user}","gists_url":"https://api.github.com/users/jkschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/jkschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkschneider/subscriptions","organizations_url":"https://api.github.com/users/jkschneider/orgs","repos_url":"https://api.github.com/users/jkschneider/repos","events_url":"https://api.github.com/users/jkschneider/events{/privacy}","received_events_url":"https://api.github.com/users/jkschneider/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T22:32:15Z","updated_at":"2018-02-21T22:32:15Z","author_association":"CONTRIBUTOR","body":"Looks like we need to shunt `FunctionTimer` mean and percentiles to 0 when there are no samples coming in (divide by 0 results in an NaN here I think). However, `Gauge`s produce NaN when the object they are sampling becomes `null` as a feature, so perhaps we want to NOT ship any NaN Gauge to Graphite.\r\n\r\nWould you mind sharing your carbon configuration?\r\n\r\nWhen I push NaN producing gauges to Graphite, they don't appear in the catalog of metrics (as expected), but there is no error in the carbon logs. Trying to see what you see."}}
{"actor":{"display_login":"jkschneider"}}