{"action":"created","comment":{"url":"https://api.github.com/repos/abseil/googletest/pulls/comments/239129491","pull_request_review_id":181837188,"id":239129491,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTEyOTQ5MQ==","diff_hunk":"@@ -44,6 +50,9 @@ matrix:\n       env: BUILD_TYPE=Release VERBOSE=1 CXX_FLAGS=-std=c++11\n       if: type != pull_request\n \n+before_install:","path":".travis.yml","position":17,"original_position":17,"commit_id":"2c8ab3f18b2ed9fdc1742ec60b6e34248d04efe3","original_commit_id":"2c8ab3f18b2ed9fdc1742ec60b6e34248d04efe3","user":{"login":"ciband","id":18743679,"node_id":"MDQ6VXNlcjE4NzQzNjc5","avatar_url":"https://avatars3.githubusercontent.com/u/18743679?v=4","gravatar_id":"","url":"https://api.github.com/users/ciband","html_url":"https://github.com/ciband","followers_url":"https://api.github.com/users/ciband/followers","following_url":"https://api.github.com/users/ciband/following{/other_user}","gists_url":"https://api.github.com/users/ciband/gists{/gist_id}","starred_url":"https://api.github.com/users/ciband/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciband/subscriptions","organizations_url":"https://api.github.com/users/ciband/orgs","repos_url":"https://api.github.com/users/ciband/repos","events_url":"https://api.github.com/users/ciband/events{/privacy}","received_events_url":"https://api.github.com/users/ciband/received_events","type":"User","site_admin":false},"body":"It would apply to all builds.  I can look at applying only to PIO.  I am not sure why I need it.  The other builds execute scripts out of the ci directory without the explicit +x.  I would prefer to do it that way but my Travis CI skills are not advanced.\r\n\r\nAny ideas there?","created_at":"2018-12-05T16:06:24Z","updated_at":"2018-12-05T16:06:25Z","html_url":"https://github.com/abseil/googletest/pull/2000#discussion_r239129491","pull_request_url":"https://api.github.com/repos/abseil/googletest/pulls/2000","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/abseil/googletest/pulls/comments/239129491"},"html":{"href":"https://github.com/abseil/googletest/pull/2000#discussion_r239129491"},"pull_request":{"href":"https://api.github.com/repos/abseil/googletest/pulls/2000"}},"in_reply_to_id":239121717},"pull_request":{"url":"https://api.github.com/repos/abseil/googletest/pulls/2000","id":236037588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MDM3NTg4","html_url":"https://github.com/abseil/googletest/pull/2000","diff_url":"https://github.com/abseil/googletest/pull/2000.diff","patch_url":"https://github.com/abseil/googletest/pull/2000.patch","issue_url":"https://api.github.com/repos/abseil/googletest/issues/2000","number":2000,"state":"open","locked":false,"title":"Issue #1659: Add Support for PlatformIO and Arduino","user":{"login":"ciband","id":18743679,"node_id":"MDQ6VXNlcjE4NzQzNjc5","avatar_url":"https://avatars3.githubusercontent.com/u/18743679?v=4","gravatar_id":"","url":"https://api.github.com/users/ciband","html_url":"https://github.com/ciband","followers_url":"https://api.github.com/users/ciband/followers","following_url":"https://api.github.com/users/ciband/following{/other_user}","gists_url":"https://api.github.com/users/ciband/gists{/gist_id}","starred_url":"https://api.github.com/users/ciband/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciband/subscriptions","organizations_url":"https://api.github.com/users/ciband/orgs","repos_url":"https://api.github.com/users/ciband/repos","events_url":"https://api.github.com/users/ciband/events{/privacy}","received_events_url":"https://api.github.com/users/ciband/received_events","type":"User","site_admin":false},"body":"This is an initial effort to add PlatformIO/Arduino support to GTest and GMock.\r\n\r\nThis PR is not meant to be a final version, just the starting point to the discussion to gain feedback.\r\n\r\nIs this general approach sound and what changes would you like to see?\r\n\r\nI would like to target ESP8266 and ESP32 boards initially.\r\n\r\nThis would ultimately also be registered in the PIO Library Manager.\r\n\r\nFixes #1659 \r\n\r\nThank you.","created_at":"2018-12-05T03:48:01Z","updated_at":"2018-12-05T16:06:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d8519eab6b9058aec9636ac49b19545dbdf08e1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1005990523,"node_id":"MDU6TGFiZWwxMDA1OTkwNTIz","url":"https://api.github.com/repos/abseil/googletest/labels/cla:%20yes","name":"cla: yes","color":"8bed95","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/abseil/googletest/pulls/2000/commits","review_comments_url":"https://api.github.com/repos/abseil/googletest/pulls/2000/comments","review_comment_url":"https://api.github.com/repos/abseil/googletest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/abseil/googletest/issues/2000/comments","statuses_url":"https://api.github.com/repos/abseil/googletest/statuses/2c8ab3f18b2ed9fdc1742ec60b6e34248d04efe3","head":{"label":"ciband:feat/add_support_platformio","ref":"feat/add_support_platformio","sha":"2c8ab3f18b2ed9fdc1742ec60b6e34248d04efe3","user":{"login":"ciband","id":18743679,"node_id":"MDQ6VXNlcjE4NzQzNjc5","avatar_url":"https://avatars3.githubusercontent.com/u/18743679?v=4","gravatar_id":"","url":"https://api.github.com/users/ciband","html_url":"https://github.com/ciband","followers_url":"https://api.github.com/users/ciband/followers","following_url":"https://api.github.com/users/ciband/following{/other_user}","gists_url":"https://api.github.com/users/ciband/gists{/gist_id}","starred_url":"https://api.github.com/users/ciband/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciband/subscriptions","organizations_url":"https://api.github.com/users/ciband/orgs","repos_url":"https://api.github.com/users/ciband/repos","events_url":"https://api.github.com/users/ciband/events{/privacy}","received_events_url":"https://api.github.com/users/ciband/received_events","type":"User","site_admin":false},"repo":{"id":160404158,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA0MDQxNTg=","name":"googletest","full_name":"ciband/googletest","private":false,"owner":{"login":"ciband","id":18743679,"node_id":"MDQ6VXNlcjE4NzQzNjc5","avatar_url":"https://avatars3.githubusercontent.com/u/18743679?v=4","gravatar_id":"","url":"https://api.github.com/users/ciband","html_url":"https://github.com/ciband","followers_url":"https://api.github.com/users/ciband/followers","following_url":"https://api.github.com/users/ciband/following{/other_user}","gists_url":"https://api.github.com/users/ciband/gists{/gist_id}","starred_url":"https://api.github.com/users/ciband/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciband/subscriptions","organizations_url":"https://api.github.com/users/ciband/orgs","repos_url":"https://api.github.com/users/ciband/repos","events_url":"https://api.github.com/users/ciband/events{/privacy}","received_events_url":"https://api.github.com/users/ciband/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ciband/googletest","description":"Google Test","fork":true,"url":"https://api.github.com/repos/ciband/googletest","forks_url":"https://api.github.com/repos/ciband/googletest/forks","keys_url":"https://api.github.com/repos/ciband/googletest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciband/googletest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciband/googletest/teams","hooks_url":"https://api.github.com/repos/ciband/googletest/hooks","issue_events_url":"https://api.github.com/repos/ciband/googletest/issues/events{/number}","events_url":"https://api.github.com/repos/ciband/googletest/events","assignees_url":"https://api.github.com/repos/ciband/googletest/assignees{/user}","branches_url":"https://api.github.com/repos/ciband/googletest/branches{/branch}","tags_url":"https://api.github.com/repos/ciband/googletest/tags","blobs_url":"https://api.github.com/repos/ciband/googletest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciband/googletest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciband/googletest/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciband/googletest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciband/googletest/statuses/{sha}","languages_url":"https://api.github.com/repos/ciband/googletest/languages","stargazers_url":"https://api.github.com/repos/ciband/googletest/stargazers","contributors_url":"https://api.github.com/repos/ciband/googletest/contributors","subscribers_url":"https://api.github.com/repos/ciband/googletest/subscribers","subscription_url":"https://api.github.com/repos/ciband/googletest/subscription","commits_url":"https://api.github.com/repos/ciband/googletest/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciband/googletest/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciband/googletest/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciband/googletest/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciband/googletest/contents/{+path}","compare_url":"https://api.github.com/repos/ciband/googletest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciband/googletest/merges","archive_url":"https://api.github.com/repos/ciband/googletest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciband/googletest/downloads","issues_url":"https://api.github.com/repos/ciband/googletest/issues{/number}","pulls_url":"https://api.github.com/repos/ciband/googletest/pulls{/number}","milestones_url":"https://api.github.com/repos/ciband/googletest/milestones{/number}","notifications_url":"https://api.github.com/repos/ciband/googletest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciband/googletest/labels{/name}","releases_url":"https://api.github.com/repos/ciband/googletest/releases{/id}","deployments_url":"https://api.github.com/repos/ciband/googletest/deployments","created_at":"2018-12-04T18:51:55Z","updated_at":"2018-12-04T18:51:58Z","pushed_at":"2018-12-05T03:44:39Z","git_url":"git://github.com/ciband/googletest.git","ssh_url":"git@github.com:ciband/googletest.git","clone_url":"https://github.com/ciband/googletest.git","svn_url":"https://github.com/ciband/googletest","homepage":"","size":5486,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"abseil:master","ref":"master","sha":"fe14e3030737509c2b9f9adad80ff56f80e988a2","user":{"login":"abseil","id":26718316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NzE4MzE2","avatar_url":"https://avatars3.githubusercontent.com/u/26718316?v=4","gravatar_id":"","url":"https://api.github.com/users/abseil","html_url":"https://github.com/abseil","followers_url":"https://api.github.com/users/abseil/followers","following_url":"https://api.github.com/users/abseil/following{/other_user}","gists_url":"https://api.github.com/users/abseil/gists{/gist_id}","starred_url":"https://api.github.com/users/abseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abseil/subscriptions","organizations_url":"https://api.github.com/users/abseil/orgs","repos_url":"https://api.github.com/users/abseil/repos","events_url":"https://api.github.com/users/abseil/events{/privacy}","received_events_url":"https://api.github.com/users/abseil/received_events","type":"Organization","site_admin":false},"repo":{"id":39840932,"node_id":"MDEwOlJlcG9zaXRvcnkzOTg0MDkzMg==","name":"googletest","full_name":"abseil/googletest","private":false,"owner":{"login":"abseil","id":26718316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NzE4MzE2","avatar_url":"https://avatars3.githubusercontent.com/u/26718316?v=4","gravatar_id":"","url":"https://api.github.com/users/abseil","html_url":"https://github.com/abseil","followers_url":"https://api.github.com/users/abseil/followers","following_url":"https://api.github.com/users/abseil/following{/other_user}","gists_url":"https://api.github.com/users/abseil/gists{/gist_id}","starred_url":"https://api.github.com/users/abseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abseil/subscriptions","organizations_url":"https://api.github.com/users/abseil/orgs","repos_url":"https://api.github.com/users/abseil/repos","events_url":"https://api.github.com/users/abseil/events{/privacy}","received_events_url":"https://api.github.com/users/abseil/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/abseil/googletest","description":"Google Test","fork":false,"url":"https://api.github.com/repos/abseil/googletest","forks_url":"https://api.github.com/repos/abseil/googletest/forks","keys_url":"https://api.github.com/repos/abseil/googletest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abseil/googletest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abseil/googletest/teams","hooks_url":"https://api.github.com/repos/abseil/googletest/hooks","issue_events_url":"https://api.github.com/repos/abseil/googletest/issues/events{/number}","events_url":"https://api.github.com/repos/abseil/googletest/events","assignees_url":"https://api.github.com/repos/abseil/googletest/assignees{/user}","branches_url":"https://api.github.com/repos/abseil/googletest/branches{/branch}","tags_url":"https://api.github.com/repos/abseil/googletest/tags","blobs_url":"https://api.github.com/repos/abseil/googletest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abseil/googletest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abseil/googletest/git/refs{/sha}","trees_url":"https://api.github.com/repos/abseil/googletest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abseil/googletest/statuses/{sha}","languages_url":"https://api.github.com/repos/abseil/googletest/languages","stargazers_url":"https://api.github.com/repos/abseil/googletest/stargazers","contributors_url":"https://api.github.com/repos/abseil/googletest/contributors","subscribers_url":"https://api.github.com/repos/abseil/googletest/subscribers","subscription_url":"https://api.github.com/repos/abseil/googletest/subscription","commits_url":"https://api.github.com/repos/abseil/googletest/commits{/sha}","git_commits_url":"https://api.github.com/repos/abseil/googletest/git/commits{/sha}","comments_url":"https://api.github.com/repos/abseil/googletest/comments{/number}","issue_comment_url":"https://api.github.com/repos/abseil/googletest/issues/comments{/number}","contents_url":"https://api.github.com/repos/abseil/googletest/contents/{+path}","compare_url":"https://api.github.com/repos/abseil/googletest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abseil/googletest/merges","archive_url":"https://api.github.com/repos/abseil/googletest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abseil/googletest/downloads","issues_url":"https://api.github.com/repos/abseil/googletest/issues{/number}","pulls_url":"https://api.github.com/repos/abseil/googletest/pulls{/number}","milestones_url":"https://api.github.com/repos/abseil/googletest/milestones{/number}","notifications_url":"https://api.github.com/repos/abseil/googletest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abseil/googletest/labels{/name}","releases_url":"https://api.github.com/repos/abseil/googletest/releases{/id}","deployments_url":"https://api.github.com/repos/abseil/googletest/deployments","created_at":"2015-07-28T15:07:53Z","updated_at":"2018-12-05T15:07:56Z","pushed_at":"2018-12-05T03:48:02Z","git_url":"git://github.com/abseil/googletest.git","ssh_url":"git@github.com:abseil/googletest.git","clone_url":"https://github.com/abseil/googletest.git","svn_url":"https://github.com/abseil/googletest","homepage":"","size":5759,"stargazers_count":9974,"watchers_count":9974,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4206,"mirror_url":null,"archived":false,"open_issues_count":151,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":4206,"open_issues":151,"watchers":9974,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/abseil/googletest/pulls/2000"},"html":{"href":"https://github.com/abseil/googletest/pull/2000"},"issue":{"href":"https://api.github.com/repos/abseil/googletest/issues/2000"},"comments":{"href":"https://api.github.com/repos/abseil/googletest/issues/2000/comments"},"review_comments":{"href":"https://api.github.com/repos/abseil/googletest/pulls/2000/comments"},"review_comment":{"href":"https://api.github.com/repos/abseil/googletest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/abseil/googletest/pulls/2000/commits"},"statuses":{"href":"https://api.github.com/repos/abseil/googletest/statuses/2c8ab3f18b2ed9fdc1742ec60b6e34248d04efe3"}},"author_association":"NONE"}}
{"actor":{"display_login":"ciband"}}