{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/204941086","pull_request_review_id":140114464,"id":204941086,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDk0MTA4Ng==","diff_hunk":"@@ -2317,11 +2405,55 @@ func (m *Machine) IsLocked() (bool, error) {\n \treturn true, nil\n }\n \n+func (m *Machine) isUpgradeSeriesPrepareComplete() (bool, error) {\n+\tlock, err := m.getUpgradeSeriesLock()\n+\tif err != nil {\n+\t\treturn false, err\n+\t}\n+\treturn lock.PrepareStatus == model.MachineSeriesUpgradeComplete, nil\n+}\n+\n // UpdateOperation returns a model operation that will update the machine.\n func (m *Machine) UpdateOperation() *UpdateMachineOperation {\n \treturn &UpdateMachineOperation{m: &Machine{st: m.st, doc: m.doc}}\n }\n \n+func (m *Machine) getUnitIndex(unitName string, status model.UnitSeriesUpgradeStatus) (int, error) {","path":"state/machine.go","position":198,"original_position":197,"commit_id":"2617c9fa6ffe5e0b8f5937891b326eac4605ae18","original_commit_id":"cd6de050b0d39809b8b2e3722c19cfd1bbfb3dd2","user":{"login":"ExternalReality","id":1026081,"node_id":"MDQ6VXNlcjEwMjYwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1026081?v=4","gravatar_id":"","url":"https://api.github.com/users/ExternalReality","html_url":"https://github.com/ExternalReality","followers_url":"https://api.github.com/users/ExternalReality/followers","following_url":"https://api.github.com/users/ExternalReality/following{/other_user}","gists_url":"https://api.github.com/users/ExternalReality/gists{/gist_id}","starred_url":"https://api.github.com/users/ExternalReality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExternalReality/subscriptions","organizations_url":"https://api.github.com/users/ExternalReality/orgs","repos_url":"https://api.github.com/users/ExternalReality/repos","events_url":"https://api.github.com/users/ExternalReality/events{/privacy}","received_events_url":"https://api.github.com/users/ExternalReality/received_events","type":"User","site_admin":false},"body":"This is going away really soon.","created_at":"2018-07-24T23:19:13Z","updated_at":"2018-07-24T23:19:14Z","html_url":"https://github.com/juju/juju/pull/8956#discussion_r204941086","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/8956","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/204941086"},"html":{"href":"https://github.com/juju/juju/pull/8956#discussion_r204941086"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/8956"}},"in_reply_to_id":204741712},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/8956","id":202873979,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODczOTc5","html_url":"https://github.com/juju/juju/pull/8956","diff_url":"https://github.com/juju/juju/pull/8956.diff","patch_url":"https://github.com/juju/juju/pull/8956.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/8956","number":8956,"state":"open","locked":false,"title":"Transition lock to post upgrade statuses on `juju upgrade-series` complete.","user":{"login":"ExternalReality","id":1026081,"node_id":"MDQ6VXNlcjEwMjYwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1026081?v=4","gravatar_id":"","url":"https://api.github.com/users/ExternalReality","html_url":"https://github.com/ExternalReality","followers_url":"https://api.github.com/users/ExternalReality/followers","following_url":"https://api.github.com/users/ExternalReality/following{/other_user}","gists_url":"https://api.github.com/users/ExternalReality/gists{/gist_id}","starred_url":"https://api.github.com/users/ExternalReality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExternalReality/subscriptions","organizations_url":"https://api.github.com/users/ExternalReality/orgs","repos_url":"https://api.github.com/users/ExternalReality/repos","events_url":"https://api.github.com/users/ExternalReality/events{/privacy}","received_events_url":"https://api.github.com/users/ExternalReality/received_events","type":"User","site_admin":false},"body":"Complete series hook should fire upon completion command `juju upgrade series complete <machine>`. \r\n","created_at":"2018-07-20T14:56:04Z","updated_at":"2018-07-24T23:19:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2c2d88a6077d4613e70696a2707036174ee1851","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jameinel","id":202877,"node_id":"MDQ6VXNlcjIwMjg3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/202877?v=4","gravatar_id":"","url":"https://api.github.com/users/jameinel","html_url":"https://github.com/jameinel","followers_url":"https://api.github.com/users/jameinel/followers","following_url":"https://api.github.com/users/jameinel/following{/other_user}","gists_url":"https://api.github.com/users/jameinel/gists{/gist_id}","starred_url":"https://api.github.com/users/jameinel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameinel/subscriptions","organizations_url":"https://api.github.com/users/jameinel/orgs","repos_url":"https://api.github.com/users/jameinel/repos","events_url":"https://api.github.com/users/jameinel/events{/privacy}","received_events_url":"https://api.github.com/users/jameinel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/8956/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/8956/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/8956/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/2617c9fa6ffe5e0b8f5937891b326eac4605ae18","head":{"label":"ExternalReality:fire_post_series_upgrade_hook","ref":"fire_post_series_upgrade_hook","sha":"2617c9fa6ffe5e0b8f5937891b326eac4605ae18","user":{"login":"ExternalReality","id":1026081,"node_id":"MDQ6VXNlcjEwMjYwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1026081?v=4","gravatar_id":"","url":"https://api.github.com/users/ExternalReality","html_url":"https://github.com/ExternalReality","followers_url":"https://api.github.com/users/ExternalReality/followers","following_url":"https://api.github.com/users/ExternalReality/following{/other_user}","gists_url":"https://api.github.com/users/ExternalReality/gists{/gist_id}","starred_url":"https://api.github.com/users/ExternalReality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExternalReality/subscriptions","organizations_url":"https://api.github.com/users/ExternalReality/orgs","repos_url":"https://api.github.com/users/ExternalReality/repos","events_url":"https://api.github.com/users/ExternalReality/events{/privacy}","received_events_url":"https://api.github.com/users/ExternalReality/received_events","type":"User","site_admin":false},"repo":{"id":82218532,"node_id":"MDEwOlJlcG9zaXRvcnk4MjIxODUzMg==","name":"juju","full_name":"ExternalReality/juju","owner":{"login":"ExternalReality","id":1026081,"node_id":"MDQ6VXNlcjEwMjYwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1026081?v=4","gravatar_id":"","url":"https://api.github.com/users/ExternalReality","html_url":"https://github.com/ExternalReality","followers_url":"https://api.github.com/users/ExternalReality/followers","following_url":"https://api.github.com/users/ExternalReality/following{/other_user}","gists_url":"https://api.github.com/users/ExternalReality/gists{/gist_id}","starred_url":"https://api.github.com/users/ExternalReality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExternalReality/subscriptions","organizations_url":"https://api.github.com/users/ExternalReality/orgs","repos_url":"https://api.github.com/users/ExternalReality/repos","events_url":"https://api.github.com/users/ExternalReality/events{/privacy}","received_events_url":"https://api.github.com/users/ExternalReality/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ExternalReality/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/ExternalReality/juju","forks_url":"https://api.github.com/repos/ExternalReality/juju/forks","keys_url":"https://api.github.com/repos/ExternalReality/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ExternalReality/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ExternalReality/juju/teams","hooks_url":"https://api.github.com/repos/ExternalReality/juju/hooks","issue_events_url":"https://api.github.com/repos/ExternalReality/juju/issues/events{/number}","events_url":"https://api.github.com/repos/ExternalReality/juju/events","assignees_url":"https://api.github.com/repos/ExternalReality/juju/assignees{/user}","branches_url":"https://api.github.com/repos/ExternalReality/juju/branches{/branch}","tags_url":"https://api.github.com/repos/ExternalReality/juju/tags","blobs_url":"https://api.github.com/repos/ExternalReality/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ExternalReality/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ExternalReality/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/ExternalReality/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ExternalReality/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/ExternalReality/juju/languages","stargazers_url":"https://api.github.com/repos/ExternalReality/juju/stargazers","contributors_url":"https://api.github.com/repos/ExternalReality/juju/contributors","subscribers_url":"https://api.github.com/repos/ExternalReality/juju/subscribers","subscription_url":"https://api.github.com/repos/ExternalReality/juju/subscription","commits_url":"https://api.github.com/repos/ExternalReality/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/ExternalReality/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/ExternalReality/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/ExternalReality/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/ExternalReality/juju/contents/{+path}","compare_url":"https://api.github.com/repos/ExternalReality/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ExternalReality/juju/merges","archive_url":"https://api.github.com/repos/ExternalReality/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ExternalReality/juju/downloads","issues_url":"https://api.github.com/repos/ExternalReality/juju/issues{/number}","pulls_url":"https://api.github.com/repos/ExternalReality/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/ExternalReality/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/ExternalReality/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ExternalReality/juju/labels{/name}","releases_url":"https://api.github.com/repos/ExternalReality/juju/releases{/id}","deployments_url":"https://api.github.com/repos/ExternalReality/juju/deployments","created_at":"2017-02-16T19:36:01Z","updated_at":"2017-02-16T19:36:14Z","pushed_at":"2018-07-24T23:17:29Z","git_url":"git://github.com/ExternalReality/juju.git","ssh_url":"git@github.com:ExternalReality/juju.git","clone_url":"https://github.com/ExternalReality/juju.git","svn_url":"https://github.com/ExternalReality/juju","homepage":"juju.ubuntu.com","size":214548,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"juju:develop","ref":"develop","sha":"da947253e4719613835166cf0f0317eb3bdc2413","user":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ0NTk0Nw==","name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2018-07-24T17:42:47Z","pushed_at":"2018-07-24T23:17:31Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":214615,"stargazers_count":1188,"watchers_count":1188,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":273,"open_issues":22,"watchers":1188,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/8956"},"html":{"href":"https://github.com/juju/juju/pull/8956"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/8956"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/8956/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/8956/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/8956/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/2617c9fa6ffe5e0b8f5937891b326eac4605ae18"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ExternalReality"}}