{"action":"opened","number":8159,"pull_request":{"url":"https://api.github.com/repos/spack/spack/pulls/8159","id":188496938,"html_url":"https://github.com/spack/spack/pull/8159","diff_url":"https://github.com/spack/spack/pull/8159.diff","patch_url":"https://github.com/spack/spack/pull/8159.patch","issue_url":"https://api.github.com/repos/spack/spack/issues/8159","number":8159,"state":"open","locked":false,"title":"nco: Find NetCDF","user":{"login":"citibeth","id":1924215,"avatar_url":"https://avatars1.githubusercontent.com/u/1924215?v=4","gravatar_id":"","url":"https://api.github.com/users/citibeth","html_url":"https://github.com/citibeth","followers_url":"https://api.github.com/users/citibeth/followers","following_url":"https://api.github.com/users/citibeth/following{/other_user}","gists_url":"https://api.github.com/users/citibeth/gists{/gist_id}","starred_url":"https://api.github.com/users/citibeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citibeth/subscriptions","organizations_url":"https://api.github.com/users/citibeth/orgs","repos_url":"https://api.github.com/users/citibeth/repos","events_url":"https://api.github.com/users/citibeth/events{/privacy}","received_events_url":"https://api.github.com/users/citibeth/received_events","type":"User","site_admin":false},"body":"Previously, `nco` was not able to find Spack-installed NetCDF; presumably relying on system-installed NetCDF instead.  If no system-installed NetCDF, this resulted in the error below.  This PR fixes the problem.\r\n\r\n\r\n```\r\n==> Installing nco\r\n==> Using cached archive: /gpfsm/dnb53/rpfische/spack6/var/spack/cache/nco/nco-4.6.7.tar.gz\r\n==> Staging archive: /gpfsm/dnb53/rpfische/spack6/var/spack/stage/nco-4.6.7-cmbb6euq3cyv25t6t47cu6snbfbrthqz/4.6.7.tar.gz\r\n==> Created stage in /gpfsm/dnb53/rpfische/spack6/var/spack/stage/nco-4.6.7-cmbb6euq3cyv25t6t47cu6snbfbrthqz\r\n==> Applied patch NUL-0-NULL.patch\r\n==> Building nco [AutotoolsPackage]\r\n==> Executing phase: 'autoreconf'\r\n==> Executing phase: 'configure'\r\n==> Error: ProcessError: Command exited with status 1:\r\n    '/gpfsm/dnb53/rpfische/spack6/var/spack/stage/nco-4.6.7-cmbb6euq3cyv25t6t47cu6snbfbrthqz/nco-4.6.7/configure' '--prefix=/gpfsm/dnb53/rpfische/spack6/opt/spack/linux-suse_linux11-x86_64/gcc-5.3.0/nco-4.6.7-cmbb6euq3cyv25t6t47cu6snbfbrthqz' '--disable-doc'\r\n\r\n2 errors found in build log:\r\n     168    ################################\r\n     169    checking for /opt/local/include/netcdf.h... no\r\n     170    checking for /opt/local/lib/libnetcdf.a... no\r\n     171    checking netcdf.h usability... no\r\n     172    checking netcdf.h presence... no\r\n     173    checking for netcdf.h... no\r\n  >> 174    configure: error: in `/tmp/rpfische/spack-stage/spack-stage-2Gmopq/nco-4.6.7':\r\n  >> 175    configure: error: cannot find netCDF header\r\n     176    See `config.log' for more details\r\n\r\nSee build log for details:\r\n```\r\n\r\nNote features and influential env variables for the NetCDF build:\r\n\r\n```\r\nOptional Features:\r\n  --disable-option-checking  ignore unrecognized --enable/--with options\r\n  --disable-FEATURE       do not include FEATURE (same as --enable-FEATURE=no)\r\n  --enable-FEATURE[=ARG]  include FEATURE [ARG=yes]\r\n  --enable-silent-rules   less verbose build output (undo: \"make V=1\")\r\n  --disable-silent-rules  verbose build output (undo: \"make V=0\")\r\n  --enable-dependency-tracking\r\n                          do not reject slow dependency extractors\r\n  --disable-dependency-tracking\r\n                          speeds up one-time build\r\n  --enable-shared[=PKGS]  build shared libraries [default=yes]\r\n  --enable-static[=PKGS]  build static libraries [default=yes]\r\n  --enable-fast-install[=PKGS]\r\n                          optimize for fast installation [default=yes]\r\n  --disable-libtool-lock  avoid locking (might break parallel builds)\r\n  --enable-maintainer-mode\r\n                          enable make rules and dependencies not useful (and\r\n                          sometimes confusing) to the casual installer\r\n  --disable-largefile     omit support for large files\r\n  --enable-netcdf4        Enable netCDF Version 4 features (same as\r\n                          enable-netcdf-4) [[default=yes]]\r\n  --enable-netcdf-4       Enable netCDF Version 4 features (same as\r\n                          enable-netcdf4) [[default=yes]]\r\n  --enable-openmp         Build NCO with OpenMP [[default=yes]]\r\n  --disable-openmp        do not use OpenMP\r\n  --enable-dap            Build DAP-enabled NCO with netCDF-provided DAP\r\n                          [[default=yes]]\r\n  --enable-ncoxx          Build libnco++ and ncap2 (same as enable-ncap2)\r\n                          [[default=yes]]\r\n  --enable-ncap2          Build ncap2 and libnco++ (same as enable-ncoxx)\r\n                          [[default=yes]]\r\n  --enable-mpi            Build NCO for Message Passing Interface (NB: Do not\r\n                          use, this is not yet supported) [[default=no]]\r\n  --enable-fortran        Use Fortran arithmetic (deprecated) [[default=no]]\r\n  --enable-i18n           Internationalization (i18n) support (WARNING:\r\n                          Experimental, for future use) [[default=no]]\r\n  --enable-nco_cplusplus  Build NCO C++ interface library [[default=yes]]\r\n  --enable-esmf           Build-in ESMF support for integrated (instead of\r\n                          off-line) regridding. WARNING: Development code =\r\n                          Unsupported (and not necessary for regridding!\r\n                          Dragons lurk here.) [[default=no]]\r\n  --enable-gsl            Build-in GSL support if possible [[default=yes]]\r\n  --enable-regex          Allow extended regular expressions [[default=yes]]\r\n  --enable-udunits        Build-in UDUnits support if possible [[default=no]]\r\n  --enable-udunits2       Build-in UDUnits2 support if possible\r\n                          [[default=yes]]\r\n  --enable-debug-custom   Activate all known, helpful compile-time and\r\n                          run-time debugging checks such as pedantic warnings,\r\n                          bounds checking (slowest execution). Automatically\r\n                          activates --enable-debug-symbols. [[default=no]]\r\n  --enable-debug-symbols  Debugging symbols: Produce symbols for debuggers\r\n                          (e.g., dbx, gdb) [[default=no]]\r\n  --enable-optimize-custom\r\n                          Activate all known, helpful switches for fastest\r\n                          possible run-time performance (slowest compilation)\r\n                          [[default=no]]\r\n  --enable-doc            Build/install NCO TexInfo-based documentation (info\r\n                          hierarchy and PDF/HTML Users Guide)[[default=yes]]\r\n\r\nOptional Packages:\r\n  --with-PACKAGE[=ARG]    use PACKAGE [ARG=yes]\r\n  --without-PACKAGE       do not use PACKAGE (same as --with-PACKAGE=no)\r\n  --with-pic[=PKGS]       try to use only PIC/non-PIC objects [default=use\r\n                          both]\r\n  --with-gnu-ld           assume the C compiler uses GNU ld [default=no]\r\n  --with-sysroot=DIR Search for dependent libraries within DIR\r\n                        (or the compiler's sysroot if not specified).\r\n\r\nSome influential environment variables:\r\n  CC          C compiler command\r\n  CFLAGS      C compiler flags\r\n  LDFLAGS     linker flags, e.g. -L<lib dir> if you have libraries in a\r\n              nonstandard directory <lib dir>\r\n  LIBS        libraries to pass to the linker, e.g. -l<library>\r\n  CPPFLAGS    (Objective) C/C++ preprocessor flags, e.g. -I<include dir> if\r\n              you have headers in a nonstandard directory <include dir>\r\n  CXX         C++ compiler command\r\n  CXXFLAGS    C++ compiler flags\r\n  CPP         C preprocessor\r\n  CXXCPP      C++ preprocessor\r\n  YACC        The `Yet Another Compiler Compiler' implementation to use.\r\n              Defaults to the first program found out of: `bison -y', `byacc',\r\n              `yacc'.\r\n  YFLAGS      The list of arguments that will be passed by default to $YACC.\r\n              This script will default YFLAGS to the empty string to avoid a\r\n              default value of `-d' given by some make applications.\r\n  NETCDF_INC  Location of netCDF headers (compile-time)\r\n  NETCDF_LIB  Location of netCDF library (compile-time)\r\n  NETCDF_ROOT Root of netCDF4 installation (compile-time)\r\n  ANTLR_ROOT  Location of ANTLR version 2.7.x installation (compile-time)\r\n  I18N_SHARE  Root of internationalization (i18n) locale directories\r\n              (run-time)\r\n  ESMF_INC    Location of ESMF headers (compile-time)\r\n  ESMF_LIB    Location of ESMF library (compile-time)\r\n  UDUNITS2_PATH\r\n              Root directory of UDUnits2 (normally contains bin, include, lib,\r\n              share subdirectories)\r\n```\r\n","created_at":"2018-05-16T16:52:43Z","updated_at":"2018-05-16T16:52:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spack/spack/pulls/8159/commits","review_comments_url":"https://api.github.com/repos/spack/spack/pulls/8159/comments","review_comment_url":"https://api.github.com/repos/spack/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spack/spack/issues/8159/comments","statuses_url":"https://api.github.com/repos/spack/spack/statuses/4ce09cfaf8cb50c9054e73ef6c96dc7be1f7d6e0","head":{"label":"citibeth:efischer/180516-FixNCO","ref":"efischer/180516-FixNCO","sha":"4ce09cfaf8cb50c9054e73ef6c96dc7be1f7d6e0","user":{"login":"citibeth","id":1924215,"avatar_url":"https://avatars1.githubusercontent.com/u/1924215?v=4","gravatar_id":"","url":"https://api.github.com/users/citibeth","html_url":"https://github.com/citibeth","followers_url":"https://api.github.com/users/citibeth/followers","following_url":"https://api.github.com/users/citibeth/following{/other_user}","gists_url":"https://api.github.com/users/citibeth/gists{/gist_id}","starred_url":"https://api.github.com/users/citibeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citibeth/subscriptions","organizations_url":"https://api.github.com/users/citibeth/orgs","repos_url":"https://api.github.com/users/citibeth/repos","events_url":"https://api.github.com/users/citibeth/events{/privacy}","received_events_url":"https://api.github.com/users/citibeth/received_events","type":"User","site_admin":false},"repo":{"id":52844713,"name":"spack","full_name":"citibeth/spack","owner":{"login":"citibeth","id":1924215,"avatar_url":"https://avatars1.githubusercontent.com/u/1924215?v=4","gravatar_id":"","url":"https://api.github.com/users/citibeth","html_url":"https://github.com/citibeth","followers_url":"https://api.github.com/users/citibeth/followers","following_url":"https://api.github.com/users/citibeth/following{/other_user}","gists_url":"https://api.github.com/users/citibeth/gists{/gist_id}","starred_url":"https://api.github.com/users/citibeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citibeth/subscriptions","organizations_url":"https://api.github.com/users/citibeth/orgs","repos_url":"https://api.github.com/users/citibeth/repos","events_url":"https://api.github.com/users/citibeth/events{/privacy}","received_events_url":"https://api.github.com/users/citibeth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/citibeth/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/citibeth/spack","forks_url":"https://api.github.com/repos/citibeth/spack/forks","keys_url":"https://api.github.com/repos/citibeth/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citibeth/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citibeth/spack/teams","hooks_url":"https://api.github.com/repos/citibeth/spack/hooks","issue_events_url":"https://api.github.com/repos/citibeth/spack/issues/events{/number}","events_url":"https://api.github.com/repos/citibeth/spack/events","assignees_url":"https://api.github.com/repos/citibeth/spack/assignees{/user}","branches_url":"https://api.github.com/repos/citibeth/spack/branches{/branch}","tags_url":"https://api.github.com/repos/citibeth/spack/tags","blobs_url":"https://api.github.com/repos/citibeth/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citibeth/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citibeth/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/citibeth/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citibeth/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/citibeth/spack/languages","stargazers_url":"https://api.github.com/repos/citibeth/spack/stargazers","contributors_url":"https://api.github.com/repos/citibeth/spack/contributors","subscribers_url":"https://api.github.com/repos/citibeth/spack/subscribers","subscription_url":"https://api.github.com/repos/citibeth/spack/subscription","commits_url":"https://api.github.com/repos/citibeth/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/citibeth/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/citibeth/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/citibeth/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/citibeth/spack/contents/{+path}","compare_url":"https://api.github.com/repos/citibeth/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citibeth/spack/merges","archive_url":"https://api.github.com/repos/citibeth/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citibeth/spack/downloads","issues_url":"https://api.github.com/repos/citibeth/spack/issues{/number}","pulls_url":"https://api.github.com/repos/citibeth/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/citibeth/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/citibeth/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citibeth/spack/labels{/name}","releases_url":"https://api.github.com/repos/citibeth/spack/releases{/id}","deployments_url":"https://api.github.com/repos/citibeth/spack/deployments","created_at":"2016-03-01T03:21:53Z","updated_at":"2016-03-01T03:21:54Z","pushed_at":"2018-05-16T16:50:47Z","git_url":"git://github.com/citibeth/spack.git","ssh_url":"git@github.com:citibeth/spack.git","clone_url":"https://github.com/citibeth/spack.git","svn_url":"https://github.com/citibeth/spack","homepage":"http://llnl.github.io/spack","size":39086,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"spack:develop","ref":"develop","sha":"218e32991d1aa064548de06df7e1e1b0cdb31e24","user":{"login":"spack","id":25539161,"avatar_url":"https://avatars2.githubusercontent.com/u/25539161?v=4","gravatar_id":"","url":"https://api.github.com/users/spack","html_url":"https://github.com/spack","followers_url":"https://api.github.com/users/spack/followers","following_url":"https://api.github.com/users/spack/following{/other_user}","gists_url":"https://api.github.com/users/spack/gists{/gist_id}","starred_url":"https://api.github.com/users/spack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spack/subscriptions","organizations_url":"https://api.github.com/users/spack/orgs","repos_url":"https://api.github.com/users/spack/repos","events_url":"https://api.github.com/users/spack/events{/privacy}","received_events_url":"https://api.github.com/users/spack/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"spack/spack","owner":{"login":"spack","id":25539161,"avatar_url":"https://avatars2.githubusercontent.com/u/25539161?v=4","gravatar_id":"","url":"https://api.github.com/users/spack","html_url":"https://github.com/spack","followers_url":"https://api.github.com/users/spack/followers","following_url":"https://api.github.com/users/spack/following{/other_user}","gists_url":"https://api.github.com/users/spack/gists{/gist_id}","starred_url":"https://api.github.com/users/spack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spack/subscriptions","organizations_url":"https://api.github.com/users/spack/orgs","repos_url":"https://api.github.com/users/spack/repos","events_url":"https://api.github.com/users/spack/events{/privacy}","received_events_url":"https://api.github.com/users/spack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spack/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/spack/spack","forks_url":"https://api.github.com/repos/spack/spack/forks","keys_url":"https://api.github.com/repos/spack/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spack/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spack/spack/teams","hooks_url":"https://api.github.com/repos/spack/spack/hooks","issue_events_url":"https://api.github.com/repos/spack/spack/issues/events{/number}","events_url":"https://api.github.com/repos/spack/spack/events","assignees_url":"https://api.github.com/repos/spack/spack/assignees{/user}","branches_url":"https://api.github.com/repos/spack/spack/branches{/branch}","tags_url":"https://api.github.com/repos/spack/spack/tags","blobs_url":"https://api.github.com/repos/spack/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spack/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spack/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/spack/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spack/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/spack/spack/languages","stargazers_url":"https://api.github.com/repos/spack/spack/stargazers","contributors_url":"https://api.github.com/repos/spack/spack/contributors","subscribers_url":"https://api.github.com/repos/spack/spack/subscribers","subscription_url":"https://api.github.com/repos/spack/spack/subscription","commits_url":"https://api.github.com/repos/spack/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/spack/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/spack/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/spack/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/spack/spack/contents/{+path}","compare_url":"https://api.github.com/repos/spack/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spack/spack/merges","archive_url":"https://api.github.com/repos/spack/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spack/spack/downloads","issues_url":"https://api.github.com/repos/spack/spack/issues{/number}","pulls_url":"https://api.github.com/repos/spack/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/spack/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/spack/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spack/spack/labels{/name}","releases_url":"https://api.github.com/repos/spack/spack/releases{/id}","deployments_url":"https://api.github.com/repos/spack/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2018-05-16T03:11:11Z","pushed_at":"2018-05-16T16:47:21Z","git_url":"git://github.com/spack/spack.git","ssh_url":"git@github.com:spack/spack.git","clone_url":"https://github.com/spack/spack.git","svn_url":"https://github.com/spack/spack","homepage":"https://spack.io","size":39264,"stargazers_count":554,"watchers_count":554,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":429,"mirror_url":null,"archived":false,"open_issues_count":941,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":429,"open_issues":941,"watchers":554,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/spack/spack/pulls/8159"},"html":{"href":"https://github.com/spack/spack/pull/8159"},"issue":{"href":"https://api.github.com/repos/spack/spack/issues/8159"},"comments":{"href":"https://api.github.com/repos/spack/spack/issues/8159/comments"},"review_comments":{"href":"https://api.github.com/repos/spack/spack/pulls/8159/comments"},"review_comment":{"href":"https://api.github.com/repos/spack/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spack/spack/pulls/8159/commits"},"statuses":{"href":"https://api.github.com/repos/spack/spack/statuses/4ce09cfaf8cb50c9054e73ef6c96dc7be1f7d6e0"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"citibeth"}}