{"action":"created","issue":{"url":"https://api.github.com/repos/redhat-developer/odo/issues/1123","repository_url":"https://api.github.com/repos/redhat-developer/odo","labels_url":"https://api.github.com/repos/redhat-developer/odo/issues/1123/labels{/name}","comments_url":"https://api.github.com/repos/redhat-developer/odo/issues/1123/comments","events_url":"https://api.github.com/repos/redhat-developer/odo/issues/1123/events","html_url":"https://github.com/redhat-developer/odo/pull/1123","id":389742015,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NjYxNTcw","number":1123,"title":"Unlink service that was deleted","user":{"login":"geoand","id":4374975,"node_id":"MDQ6VXNlcjQzNzQ5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4374975?v=4","gravatar_id":"","url":"https://api.github.com/users/geoand","html_url":"https://github.com/geoand","followers_url":"https://api.github.com/users/geoand/followers","following_url":"https://api.github.com/users/geoand/following{/other_user}","gists_url":"https://api.github.com/users/geoand/gists{/gist_id}","starred_url":"https://api.github.com/users/geoand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoand/subscriptions","organizations_url":"https://api.github.com/users/geoand/orgs","repos_url":"https://api.github.com/users/geoand/repos","events_url":"https://api.github.com/users/geoand/events{/privacy}","received_events_url":"https://api.github.com/users/geoand/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-12-11T12:30:08Z","updated_at":"2018-12-20T14:54:53Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/redhat-developer/odo/pulls/1123","html_url":"https://github.com/redhat-developer/odo/pull/1123","diff_url":"https://github.com/redhat-developer/odo/pull/1123.diff","patch_url":"https://github.com/redhat-developer/odo/pull/1123.patch"},"body":"## What is the purpose of this change? What does it change?\r\nWhen a service is deleted (`odo service delete ...`) then we need to \"links\" that have been created in the DeploymentConfig of components that were linked to the service (via `odo link ...`)\r\n\r\n## Was the change discussed in an issue?\r\nFixes: #1094\r\n\r\n## How to test changes?\r\nThe following scenario should cover everything: \r\n\r\nCreate the components\r\n```\r\nodo create nodejs frontend\r\nodo create python backend\r\n```\r\n\r\nCreate the service\r\n\r\n```\r\nodo service create postgresql-persistent\r\n```\r\n\r\nCreate a link from the frontend to the backend\r\n\r\n```\r\nodo link backend --component frontend\r\n```\r\n\r\nCreate a link from backend to the database\r\n\r\n```\r\nodo link postgresql-persistent -w\r\n```\r\n\r\nBoth components should now have a single `envFrom` value in their DC.\r\n\r\nWe now delete the service\r\n\r\n```\r\nodo service delete postgresql-persistent -f\r\n```\r\n\r\nNow the frontend service should not have been touched while the backend service should no longer have an `envFrom` value in it's DC"},"comment":{"url":"https://api.github.com/repos/redhat-developer/odo/issues/comments/449024879","html_url":"https://github.com/redhat-developer/odo/pull/1123#issuecomment-449024879","issue_url":"https://api.github.com/repos/redhat-developer/odo/issues/1123","id":449024879,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTAyNDg3OQ==","user":{"login":"geoand","id":4374975,"node_id":"MDQ6VXNlcjQzNzQ5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4374975?v=4","gravatar_id":"","url":"https://api.github.com/users/geoand","html_url":"https://github.com/geoand","followers_url":"https://api.github.com/users/geoand/followers","following_url":"https://api.github.com/users/geoand/following{/other_user}","gists_url":"https://api.github.com/users/geoand/gists{/gist_id}","starred_url":"https://api.github.com/users/geoand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoand/subscriptions","organizations_url":"https://api.github.com/users/geoand/orgs","repos_url":"https://api.github.com/users/geoand/repos","events_url":"https://api.github.com/users/geoand/events{/privacy}","received_events_url":"https://api.github.com/users/geoand/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T14:54:53Z","updated_at":"2018-12-20T14:54:53Z","author_association":"COLLABORATOR","body":"> @geoand Integration test scenario looks promising. However I have few questions on [codecov](https://github.com/redhat-developer/odo/pull/1123#issuecomment-446187961) bot.\r\n> \r\n> This bot runs the coverage on unit test right ? If I am wrong correct me. The reports looks color full to eye but if you see the percentage numbers does not look good. Is it something we should worry about ? Can it be improved to a better percentage ?\r\n> \r\n> These are just questions and not necessarily need to be addressed in the pr.\r\n\r\nThose are very good questions!\r\n\r\nUnfortunately I don't have the answers :(\r\n@kadel @cdrage do you have more info about this?"}}
{"actor":{"display_login":"geoand"}}