{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/polkadot/pulls/comments/195772433","pull_request_review_id":129207715,"id":195772433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTc3MjQzMw==","diff_hunk":"@@ -433,15 +484,7 @@ impl<B, E> Service<B, E>\n \t\tlet barrier = ::std::sync::Arc::new(Barrier::new(2));\n \t\ton_demand.map(|on_demand| on_demand.set_service_link(Arc::downgrade(&network)));\n \n-\t\tlet mut maybe_stats = ws::ClientBuilder::new(\"ws://127.0.0.1:1024\").ok()\n-\t\t\t.and_then(|mut x| x.connect_insecure().ok());\n-\t\tif let Some(ref mut stats) = maybe_stats {\n-\t\t\tlet msg = format!(\"{{\\\"_type\\\": \\\"init\\\", \\\"version\\\": \\\"{}\\\", \\\"chain\\\": \\\"{:?}\\\", \\\"best\\\": {}}}\",\n-\t\t\t\tcrate_version!(),\n-\t\t\t\tconfig.chain_spec,\n-\t\t\t\tbest_header.number);\n-\t\t\tlet _ = stats.send_message(&ws::Message::text(msg));\n-\t\t}\n+\t\tslog_info!(SLOG_ROOT, \"Starting version {version} (height is {best})\", version = crate_version!(), best = best_header.number; \"chain\" => format!(\"{:?}\", config.chain_spec));","path":"polkadot/service/src/lib.rs","position":null,"original_position":90,"commit_id":"9fe81446e79e5fb39432d28f4504cf635faf8390","original_commit_id":"2dcd073b3875a9c957d46c46026565d6b90118fb","user":{"login":"jacogr","id":1424473,"node_id":"MDQ6VXNlcjE0MjQ0NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1424473?v=4","gravatar_id":"","url":"https://api.github.com/users/jacogr","html_url":"https://github.com/jacogr","followers_url":"https://api.github.com/users/jacogr/followers","following_url":"https://api.github.com/users/jacogr/following{/other_user}","gists_url":"https://api.github.com/users/jacogr/gists{/gist_id}","starred_url":"https://api.github.com/users/jacogr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacogr/subscriptions","organizations_url":"https://api.github.com/users/jacogr/orgs","repos_url":"https://api.github.com/users/jacogr/repos","events_url":"https://api.github.com/users/jacogr/events{/privacy}","received_events_url":"https://api.github.com/users/jacogr/received_events","type":"User","site_admin":false},"body":"It would probably make sense to get the binary name in addition to the actual version in here as well, so we allow for multiple implementations to report to the same endpoint.","created_at":"2018-06-15T15:12:09Z","updated_at":"2018-06-15T15:12:09Z","html_url":"https://github.com/paritytech/polkadot/pull/217#discussion_r195772433","pull_request_url":"https://api.github.com/repos/paritytech/polkadot/pulls/217","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/comments/195772433"},"html":{"href":"https://github.com/paritytech/polkadot/pull/217#discussion_r195772433"},"pull_request":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/paritytech/polkadot/pulls/217","id":194844191,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0ODQ0MTkx","html_url":"https://github.com/paritytech/polkadot/pull/217","diff_url":"https://github.com/paritytech/polkadot/pull/217.diff","patch_url":"https://github.com/paritytech/polkadot/pull/217.patch","issue_url":"https://api.github.com/repos/paritytech/polkadot/issues/217","number":217,"state":"open","locked":false,"title":"Structured logging to Websockets endpoint","user":{"login":"gavofyork","id":138296,"node_id":"MDQ6VXNlcjEzODI5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/138296?v=4","gravatar_id":"","url":"https://api.github.com/users/gavofyork","html_url":"https://github.com/gavofyork","followers_url":"https://api.github.com/users/gavofyork/followers","following_url":"https://api.github.com/users/gavofyork/following{/other_user}","gists_url":"https://api.github.com/users/gavofyork/gists{/gist_id}","starred_url":"https://api.github.com/users/gavofyork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavofyork/subscriptions","organizations_url":"https://api.github.com/users/gavofyork/orgs","repos_url":"https://api.github.com/users/gavofyork/repos","events_url":"https://api.github.com/users/gavofyork/events{/privacy}","received_events_url":"https://api.github.com/users/gavofyork/received_events","type":"User","site_admin":false},"body":"Closes #90\r\n\r\nUse `polkadot --name \"My node's name!\" -t --telemetry-url ws(s)://endpoint.server.org/whatever`\r\n\r\nStill todo:\r\n\r\n- [x] CLI configurable server address\r\n- [x] Auto-reconnect\r\n- [x] Slog front-end\r\n- [x] Human-readable node name\r\n- [ ] Additional logging points:\r\n  - [ ] `consensus/next-round`\r\n  - [ ] `transaction-pool/{submit, import, cull}`\r\n  - [ ] `network/{connect, disconnect}`","created_at":"2018-06-14T10:15:46Z","updated_at":"2018-06-15T15:12:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a3d2f213c7eb20625577e5e1fa0878c8426c63e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":746560614,"node_id":"MDU6TGFiZWw3NDY1NjA2MTQ=","url":"https://api.github.com/repos/paritytech/polkadot/labels/A3-inprogress","name":"A3-inprogress","color":"DBC6F8","default":false}],"milestone":{"url":"https://api.github.com/repos/paritytech/polkadot/milestones/2","html_url":"https://github.com/paritytech/polkadot/milestone/2","labels_url":"https://api.github.com/repos/paritytech/polkadot/milestones/2/labels","id":3249701,"node_id":"MDk6TWlsZXN0b25lMzI0OTcwMQ==","number":2,"title":"PoC-2 (Co-finalisation)","description":"- Initial parachain consensus.\r\n- Basic parachain STF/validity function.\r\n- Libp2p?\r\n- Lightclient for parachains?","creator":{"login":"gavofyork","id":138296,"node_id":"MDQ6VXNlcjEzODI5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/138296?v=4","gravatar_id":"","url":"https://api.github.com/users/gavofyork","html_url":"https://github.com/gavofyork","followers_url":"https://api.github.com/users/gavofyork/followers","following_url":"https://api.github.com/users/gavofyork/following{/other_user}","gists_url":"https://api.github.com/users/gavofyork/gists{/gist_id}","starred_url":"https://api.github.com/users/gavofyork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavofyork/subscriptions","organizations_url":"https://api.github.com/users/gavofyork/orgs","repos_url":"https://api.github.com/users/gavofyork/repos","events_url":"https://api.github.com/users/gavofyork/events{/privacy}","received_events_url":"https://api.github.com/users/gavofyork/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":5,"state":"open","created_at":"2018-04-07T16:09:20Z","updated_at":"2018-06-14T10:54:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/paritytech/polkadot/pulls/217/commits","review_comments_url":"https://api.github.com/repos/paritytech/polkadot/pulls/217/comments","review_comment_url":"https://api.github.com/repos/paritytech/polkadot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/polkadot/issues/217/comments","statuses_url":"https://api.github.com/repos/paritytech/polkadot/statuses/9fe81446e79e5fb39432d28f4504cf635faf8390","head":{"label":"paritytech:gav-slogging","ref":"gav-slogging","sha":"9fe81446e79e5fb39432d28f4504cf635faf8390","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":109872620,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk4NzI2MjA=","name":"polkadot","full_name":"paritytech/polkadot","owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/polkadot","description":"Polkadot Node Implementation","fork":false,"url":"https://api.github.com/repos/paritytech/polkadot","forks_url":"https://api.github.com/repos/paritytech/polkadot/forks","keys_url":"https://api.github.com/repos/paritytech/polkadot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/polkadot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/polkadot/teams","hooks_url":"https://api.github.com/repos/paritytech/polkadot/hooks","issue_events_url":"https://api.github.com/repos/paritytech/polkadot/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/polkadot/events","assignees_url":"https://api.github.com/repos/paritytech/polkadot/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/polkadot/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/polkadot/tags","blobs_url":"https://api.github.com/repos/paritytech/polkadot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/polkadot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/polkadot/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/polkadot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/polkadot/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/polkadot/languages","stargazers_url":"https://api.github.com/repos/paritytech/polkadot/stargazers","contributors_url":"https://api.github.com/repos/paritytech/polkadot/contributors","subscribers_url":"https://api.github.com/repos/paritytech/polkadot/subscribers","subscription_url":"https://api.github.com/repos/paritytech/polkadot/subscription","commits_url":"https://api.github.com/repos/paritytech/polkadot/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/polkadot/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/polkadot/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/polkadot/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/polkadot/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/polkadot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/polkadot/merges","archive_url":"https://api.github.com/repos/paritytech/polkadot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/polkadot/downloads","issues_url":"https://api.github.com/repos/paritytech/polkadot/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/polkadot/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/polkadot/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/polkadot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/polkadot/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/polkadot/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/polkadot/deployments","created_at":"2017-11-07T18:08:53Z","updated_at":"2018-06-15T10:10:09Z","pushed_at":"2018-06-15T14:58:16Z","git_url":"git://github.com/paritytech/polkadot.git","ssh_url":"git@github.com:paritytech/polkadot.git","clone_url":"https://github.com/paritytech/polkadot.git","svn_url":"https://github.com/paritytech/polkadot","homepage":null,"size":26923,"stargazers_count":220,"watchers_count":220,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":43,"watchers":220,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"4760b35fd2e1535c53715ae6c868f0f523c9419b","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":109872620,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk4NzI2MjA=","name":"polkadot","full_name":"paritytech/polkadot","owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/polkadot","description":"Polkadot Node Implementation","fork":false,"url":"https://api.github.com/repos/paritytech/polkadot","forks_url":"https://api.github.com/repos/paritytech/polkadot/forks","keys_url":"https://api.github.com/repos/paritytech/polkadot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/polkadot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/polkadot/teams","hooks_url":"https://api.github.com/repos/paritytech/polkadot/hooks","issue_events_url":"https://api.github.com/repos/paritytech/polkadot/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/polkadot/events","assignees_url":"https://api.github.com/repos/paritytech/polkadot/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/polkadot/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/polkadot/tags","blobs_url":"https://api.github.com/repos/paritytech/polkadot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/polkadot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/polkadot/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/polkadot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/polkadot/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/polkadot/languages","stargazers_url":"https://api.github.com/repos/paritytech/polkadot/stargazers","contributors_url":"https://api.github.com/repos/paritytech/polkadot/contributors","subscribers_url":"https://api.github.com/repos/paritytech/polkadot/subscribers","subscription_url":"https://api.github.com/repos/paritytech/polkadot/subscription","commits_url":"https://api.github.com/repos/paritytech/polkadot/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/polkadot/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/polkadot/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/polkadot/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/polkadot/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/polkadot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/polkadot/merges","archive_url":"https://api.github.com/repos/paritytech/polkadot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/polkadot/downloads","issues_url":"https://api.github.com/repos/paritytech/polkadot/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/polkadot/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/polkadot/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/polkadot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/polkadot/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/polkadot/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/polkadot/deployments","created_at":"2017-11-07T18:08:53Z","updated_at":"2018-06-15T10:10:09Z","pushed_at":"2018-06-15T14:58:16Z","git_url":"git://github.com/paritytech/polkadot.git","ssh_url":"git@github.com:paritytech/polkadot.git","clone_url":"https://github.com/paritytech/polkadot.git","svn_url":"https://github.com/paritytech/polkadot","homepage":null,"size":26923,"stargazers_count":220,"watchers_count":220,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":43,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/217"},"html":{"href":"https://github.com/paritytech/polkadot/pull/217"},"issue":{"href":"https://api.github.com/repos/paritytech/polkadot/issues/217"},"comments":{"href":"https://api.github.com/repos/paritytech/polkadot/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/polkadot/statuses/9fe81446e79e5fb39432d28f4504cf635faf8390"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jacogr"}}