{"action":"created","issue":{"url":"https://api.github.com/repos/PHPfox-Official/phpfox-v4-issues/issues/2305","repository_url":"https://api.github.com/repos/PHPfox-Official/phpfox-v4-issues","labels_url":"https://api.github.com/repos/PHPfox-Official/phpfox-v4-issues/issues/2305/labels{/name}","comments_url":"https://api.github.com/repos/PHPfox-Official/phpfox-v4-issues/issues/2305/comments","events_url":"https://api.github.com/repos/PHPfox-Official/phpfox-v4-issues/issues/2305/events","html_url":"https://github.com/PHPfox-Official/phpfox-v4-issues/issues/2305","id":337706616,"node_id":"MDU6SXNzdWUzMzc3MDY2MTY=","number":2305,"title":"single device login has wrong version number  $this->version = '4.2.0'; install.php file","user":{"login":"spirogg","id":17736688,"node_id":"MDQ6VXNlcjE3NzM2Njg4","avatar_url":"https://avatars1.githubusercontent.com/u/17736688?v=4","gravatar_id":"","url":"https://api.github.com/users/spirogg","html_url":"https://github.com/spirogg","followers_url":"https://api.github.com/users/spirogg/followers","following_url":"https://api.github.com/users/spirogg/following{/other_user}","gists_url":"https://api.github.com/users/spirogg/gists{/gist_id}","starred_url":"https://api.github.com/users/spirogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spirogg/subscriptions","organizations_url":"https://api.github.com/users/spirogg/orgs","repos_url":"https://api.github.com/users/spirogg/repos","events_url":"https://api.github.com/users/spirogg/events{/privacy}","received_events_url":"https://api.github.com/users/spirogg/received_events","type":"User","site_admin":false},"labels":[{"id":186339521,"node_id":"MDU6TGFiZWwxODYzMzk1MjE=","url":"https://api.github.com/repos/PHPfox-Official/phpfox-v4-issues/labels/Bug","name":"Bug","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-03T00:36:01Z","updated_at":"2018-07-06T03:00:58Z","closed_at":null,"author_association":"NONE","body":"\r\n\r\n----------------------------------------\r\n\r\n## What happened?\r\n\r\nI keep seeing the upgrade button for the app > single dvice login after uploading to new install. \r\nseems you might of forgot to update version number in install.php to 4.2.2\r\n... protected function setName()\r\n    {\r\n        $this->name = 'Single Device Login';\r\n    }\r\n\r\n    protected function setVersion()\r\n    {\r\n        $this->version = '4.2.0';\r\n    }\r\n\r\n## Steps to reproduce:\r\n1. i uploaded from apps >> files>>Single Device Login the new 4.2.2 app from store\r\n2. after wards clear cache. \r\n3. still shows we have an upgrade to Single Device Login. I think in code you forgot to update file (install.php) to 4.2.2 \r\n\r\n## What is expected?\r\n...Single Device Login app install.php file needs to have version number added to correct version 4.2.2 i still see version 4.2.0 when i look at install.php file \r\n\r\nprotected function setName()\r\n    {\r\n        $this->name = 'Single Device Login';\r\n    }\r\n\r\n    protected function setVersion()\r\n    {\r\n        $this->version = '4.2.0';\r\n    }\r\n\r\n## Browsers and Devices tested\r\n(Example: Chrome on iPhone X, Safari on Macbook, Miscrosoft Edge on Windown 10, Firefox on Ubuntu 16.04, ...)\r\nchrome\r\n## Server information\r\n(Example: CentOS 7, php 7.1 apache)\r\nphp7.1\r\n...\r\n\r\n## phpFox version\r\n(Example: phpFox 4.6.0)\r\n\r\n...4.6.1.b4\r\n\r\n## Screenshots\r\n...\r\n"},"comment":{"url":"https://api.github.com/repos/PHPfox-Official/phpfox-v4-issues/issues/comments/402911492","html_url":"https://github.com/PHPfox-Official/phpfox-v4-issues/issues/2305#issuecomment-402911492","issue_url":"https://api.github.com/repos/PHPfox-Official/phpfox-v4-issues/issues/2305","id":402911492,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjkxMTQ5Mg==","user":{"login":"neil96","id":15936115,"node_id":"MDQ6VXNlcjE1OTM2MTE1","avatar_url":"https://avatars0.githubusercontent.com/u/15936115?v=4","gravatar_id":"","url":"https://api.github.com/users/neil96","html_url":"https://github.com/neil96","followers_url":"https://api.github.com/users/neil96/followers","following_url":"https://api.github.com/users/neil96/following{/other_user}","gists_url":"https://api.github.com/users/neil96/gists{/gist_id}","starred_url":"https://api.github.com/users/neil96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neil96/subscriptions","organizations_url":"https://api.github.com/users/neil96/orgs","repos_url":"https://api.github.com/users/neil96/repos","events_url":"https://api.github.com/users/neil96/events{/privacy}","received_events_url":"https://api.github.com/users/neil96/received_events","type":"User","site_admin":false},"created_at":"2018-07-06T03:00:58Z","updated_at":"2018-07-06T03:00:58Z","author_association":"MEMBER","body":"Sorry, this is my mistake, I will correct it soon."}}
{"actor":{"display_login":"neil96"}}