{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman-infra/pulls/comments/183746621","pull_request_review_id":114802854,"id":183746621,"diff_hunk":"@@ -0,0 +1,76 @@\n+#!/bin/bash -xe","path":"puppet/modules/jenkins_job_builder/files/theforeman.org/scripts/systest.shell_template","position":1,"original_position":1,"commit_id":"f345a91d4936c995d1f471cbdeacc44169247ce2","original_commit_id":"ba5e15554847ca9dd217db64db41b9283e19ba7f","user":{"login":"ekohl","id":155810,"avatar_url":"https://avatars0.githubusercontent.com/u/155810?v=4","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"body":"It is weird that `!include-raw` still applies a template over it. The docs suggest `!include-raw-escape` would escape it for you while still being a plain shell script in the repo. Could you try that?","created_at":"2018-04-24T14:15:09Z","updated_at":"2018-04-24T14:15:09Z","html_url":"https://github.com/theforeman/foreman-infra/pull/569#discussion_r183746621","pull_request_url":"https://api.github.com/repos/theforeman/foreman-infra/pulls/569","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman-infra/pulls/comments/183746621"},"html":{"href":"https://github.com/theforeman/foreman-infra/pull/569#discussion_r183746621"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman-infra/pulls/569"}},"in_reply_to_id":178862774},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman-infra/pulls/569","id":178423197,"html_url":"https://github.com/theforeman/foreman-infra/pull/569","diff_url":"https://github.com/theforeman/foreman-infra/pull/569.diff","patch_url":"https://github.com/theforeman/foreman-infra/pull/569.patch","issue_url":"https://api.github.com/repos/theforeman/foreman-infra/issues/569","number":569,"state":"open","locked":false,"title":"refactor systest family of jobs","user":{"login":"komidore64","id":1020555,"avatar_url":"https://avatars1.githubusercontent.com/u/1020555?v=4","gravatar_id":"","url":"https://api.github.com/users/komidore64","html_url":"https://github.com/komidore64","followers_url":"https://api.github.com/users/komidore64/followers","following_url":"https://api.github.com/users/komidore64/following{/other_user}","gists_url":"https://api.github.com/users/komidore64/gists{/gist_id}","starred_url":"https://api.github.com/users/komidore64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/komidore64/subscriptions","organizations_url":"https://api.github.com/users/komidore64/orgs","repos_url":"https://api.github.com/users/komidore64/repos","events_url":"https://api.github.com/users/komidore64/events{/privacy}","received_events_url":"https://api.github.com/users/komidore64/received_events","type":"User","site_admin":false},"body":"`systest_foreman` was triggered as a subjob for a handful [1] of other jenkins jobs. It made more sense to share a JJB builder to lessen the amount of job-chains that exist on ci.tfm.org.\r\n\r\n1. The systest shell blob has been refactored to use builder macros. I renamed it to `systest.shell_template` in an attempt to clarify that it is no longer runnable as a standalone shell script.\r\n\r\n1. `systest_*` jobs have been refactored to use the new `systest` builder and have been renamed to `*_systest` (`<entity>-<action>` style).\r\n\r\n1. `release_nightly_test_deb` and `release_test` now use the `systest` builder rather than triggering a `systest_foreman` subjob.\r\n\r\n1. `systest_foreman_hammer_nightly` has been converted to JJB.\r\n\r\n1. `systest_foreman` has been removed.\r\n\r\n## TODO items for when this is merged\r\n\r\n### remove from jenkins\r\n\r\n- [ ] [systest_foreman_hammer_nightly](http://ci.theforeman.org/job/systest_foreman_hammer_nightly)\r\n- [ ] [systest_foreman_mysql](http://ci.theforeman.org/job/systest_foreman_mysql)\r\n- [ ] [systest_foreman_puppet_nightly](http://ci.theforeman.org/job/systest_foreman_puppet_nightly)\r\n- [ ] [systest_foreman_puppet_pc1](http://ci.theforeman.org/job/systest_foreman_puppet_pc1)\r\n- [ ] [systest_foreman_umask_077](http://ci.theforeman.org/job/systest_foreman_umask_077)\r\n- [ ] [systest_foreman](http://ci.theforeman.org/job/systest_foreman)\r\n\r\n---\r\n\r\n[1]:\r\n- release_nightly_test_deb\r\n- release_test\r\n- systest_foreman_hammer_nightly\r\n- systest_foreman_mysql\r\n- systest_foreman_puppet_nightly\r\n- systest_foreman_puppet_pc1\r\n- systest_foreman_umask_077","created_at":"2018-03-29T19:43:39Z","updated_at":"2018-04-24T14:15:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2453676c52d7575c49d92769e5e460814af57c82","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman-infra/pulls/569/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman-infra/pulls/569/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman-infra/issues/569/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman-infra/statuses/f345a91d4936c995d1f471cbdeacc44169247ce2","head":{"label":"komidore64:systest-family-refactor","ref":"systest-family-refactor","sha":"f345a91d4936c995d1f471cbdeacc44169247ce2","user":{"login":"komidore64","id":1020555,"avatar_url":"https://avatars1.githubusercontent.com/u/1020555?v=4","gravatar_id":"","url":"https://api.github.com/users/komidore64","html_url":"https://github.com/komidore64","followers_url":"https://api.github.com/users/komidore64/followers","following_url":"https://api.github.com/users/komidore64/following{/other_user}","gists_url":"https://api.github.com/users/komidore64/gists{/gist_id}","starred_url":"https://api.github.com/users/komidore64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/komidore64/subscriptions","organizations_url":"https://api.github.com/users/komidore64/orgs","repos_url":"https://api.github.com/users/komidore64/repos","events_url":"https://api.github.com/users/komidore64/events{/privacy}","received_events_url":"https://api.github.com/users/komidore64/received_events","type":"User","site_admin":false},"repo":{"id":18176081,"name":"foreman-infra","full_name":"komidore64/foreman-infra","owner":{"login":"komidore64","id":1020555,"avatar_url":"https://avatars1.githubusercontent.com/u/1020555?v=4","gravatar_id":"","url":"https://api.github.com/users/komidore64","html_url":"https://github.com/komidore64","followers_url":"https://api.github.com/users/komidore64/followers","following_url":"https://api.github.com/users/komidore64/following{/other_user}","gists_url":"https://api.github.com/users/komidore64/gists{/gist_id}","starred_url":"https://api.github.com/users/komidore64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/komidore64/subscriptions","organizations_url":"https://api.github.com/users/komidore64/orgs","repos_url":"https://api.github.com/users/komidore64/repos","events_url":"https://api.github.com/users/komidore64/events{/privacy}","received_events_url":"https://api.github.com/users/komidore64/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/komidore64/foreman-infra","description":"Puppet modules and scripts to manage Foreman project infrastructure","fork":true,"url":"https://api.github.com/repos/komidore64/foreman-infra","forks_url":"https://api.github.com/repos/komidore64/foreman-infra/forks","keys_url":"https://api.github.com/repos/komidore64/foreman-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/komidore64/foreman-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/komidore64/foreman-infra/teams","hooks_url":"https://api.github.com/repos/komidore64/foreman-infra/hooks","issue_events_url":"https://api.github.com/repos/komidore64/foreman-infra/issues/events{/number}","events_url":"https://api.github.com/repos/komidore64/foreman-infra/events","assignees_url":"https://api.github.com/repos/komidore64/foreman-infra/assignees{/user}","branches_url":"https://api.github.com/repos/komidore64/foreman-infra/branches{/branch}","tags_url":"https://api.github.com/repos/komidore64/foreman-infra/tags","blobs_url":"https://api.github.com/repos/komidore64/foreman-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/komidore64/foreman-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/komidore64/foreman-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/komidore64/foreman-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/komidore64/foreman-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/komidore64/foreman-infra/languages","stargazers_url":"https://api.github.com/repos/komidore64/foreman-infra/stargazers","contributors_url":"https://api.github.com/repos/komidore64/foreman-infra/contributors","subscribers_url":"https://api.github.com/repos/komidore64/foreman-infra/subscribers","subscription_url":"https://api.github.com/repos/komidore64/foreman-infra/subscription","commits_url":"https://api.github.com/repos/komidore64/foreman-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/komidore64/foreman-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/komidore64/foreman-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/komidore64/foreman-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/komidore64/foreman-infra/contents/{+path}","compare_url":"https://api.github.com/repos/komidore64/foreman-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/komidore64/foreman-infra/merges","archive_url":"https://api.github.com/repos/komidore64/foreman-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/komidore64/foreman-infra/downloads","issues_url":"https://api.github.com/repos/komidore64/foreman-infra/issues{/number}","pulls_url":"https://api.github.com/repos/komidore64/foreman-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/komidore64/foreman-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/komidore64/foreman-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/komidore64/foreman-infra/labels{/name}","releases_url":"https://api.github.com/repos/komidore64/foreman-infra/releases{/id}","deployments_url":"https://api.github.com/repos/komidore64/foreman-infra/deployments","created_at":"2014-03-27T13:08:15Z","updated_at":"2018-04-23T17:22:14Z","pushed_at":"2018-04-23T21:25:32Z","git_url":"git://github.com/komidore64/foreman-infra.git","ssh_url":"git@github.com:komidore64/foreman-infra.git","clone_url":"https://github.com/komidore64/foreman-infra.git","svn_url":"https://github.com/komidore64/foreman-infra","homepage":"","size":1709,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"72a60a7c66c7ad749e094b5e09b1eaaaf46520ac","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":5750224,"name":"foreman-infra","full_name":"theforeman/foreman-infra","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman-infra","description":"Puppet modules and scripts to manage Foreman project infrastructure","fork":false,"url":"https://api.github.com/repos/theforeman/foreman-infra","forks_url":"https://api.github.com/repos/theforeman/foreman-infra/forks","keys_url":"https://api.github.com/repos/theforeman/foreman-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman-infra/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman-infra/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman-infra/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman-infra/events","assignees_url":"https://api.github.com/repos/theforeman/foreman-infra/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman-infra/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman-infra/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman-infra/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman-infra/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman-infra/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman-infra/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman-infra/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman-infra/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman-infra/merges","archive_url":"https://api.github.com/repos/theforeman/foreman-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman-infra/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman-infra/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman-infra/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman-infra/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman-infra/deployments","created_at":"2012-09-10T13:51:02Z","updated_at":"2018-04-22T00:16:09Z","pushed_at":"2018-04-24T13:32:21Z","git_url":"git://github.com/theforeman/foreman-infra.git","ssh_url":"git@github.com:theforeman/foreman-infra.git","clone_url":"https://github.com/theforeman/foreman-infra.git","svn_url":"https://github.com/theforeman/foreman-infra","homepage":"","size":1691,"stargazers_count":13,"watchers_count":13,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":30,"license":null,"forks":37,"open_issues":30,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman-infra/pulls/569"},"html":{"href":"https://github.com/theforeman/foreman-infra/pull/569"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman-infra/issues/569"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman-infra/issues/569/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman-infra/pulls/569/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman-infra/pulls/569/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman-infra/statuses/f345a91d4936c995d1f471cbdeacc44169247ce2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ekohl"}}