{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/22974","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22974/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22974/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22974/events","html_url":"https://github.com/cms-sw/cmssw/pull/22974","id":314646235,"number":22974,"title":"Update the ADC->fC table, simplify the charge reconstruction algorith…","user":{"login":"jkunkle","id":5137887,"avatar_url":"https://avatars1.githubusercontent.com/u/5137887?v=4","gravatar_id":"","url":"https://api.github.com/users/jkunkle","html_url":"https://github.com/jkunkle","followers_url":"https://api.github.com/users/jkunkle/followers","following_url":"https://api.github.com/users/jkunkle/following{/other_user}","gists_url":"https://api.github.com/users/jkunkle/gists{/gist_id}","starred_url":"https://api.github.com/users/jkunkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkunkle/subscriptions","organizations_url":"https://api.github.com/users/jkunkle/orgs","repos_url":"https://api.github.com/users/jkunkle/repos","events_url":"https://api.github.com/users/jkunkle/events{/privacy}","received_events_url":"https://api.github.com/users/jkunkle/received_events","type":"User","site_admin":false},"labels":[{"id":52881179,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04","default":false},{"id":673935056,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-pending","name":"code-checks-pending","color":"fbca04","default":false},{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":56131152,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":56,"closed_issues":187,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-04-24T10:07:40Z","due_on":null,"closed_at":null},"comments":27,"created_at":"2018-04-16T13:16:30Z","updated_at":"2018-04-24T11:15:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22974","html_url":"https://github.com/cms-sw/cmssw/pull/22974","diff_url":"https://github.com/cms-sw/cmssw/pull/22974.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/22974.patch"},"body":"Updates to enable the HCAL laser monitoring.  With this change, I take the opportunity to make a simplification of the code which performs the laser monitoring charge reconstruction.  We have implemented the lasermon system in firmware rather than hardware.  This means that we can remove the complicated matching algorithm because the firmware guarantees fixed latency between channels (the hardware implementation did not).  The relevant changes are, \r\n\r\n- RecoMET/METProducers/src/HcalNoiseInfoProducer.cc : Update the adc->fC table to use qie10 ADCs\r\n- RecoMET/METProducers/src/HcalNoiseInfoProducer.cc : Update the reconstruction algorithm to simply take the first N samples of each channel where N is a new configurable parameter, laserMonitorSamples_.\r\n- RecoMET/METProducers/src/HcalNoiseInfoProducer.cc : Integrate the charge using a simple peak finding algorithm rather than integrating the whole readout\r\n-RecoMET/METFilters/plugins/HcalLaserEventFilter.cc - enable the laser filtering and update the threshold to 5000\r\n\r\nThe above changes have been tested with a recent global run for consistency against the old method and that the changes propagate to the Met filter\r\n\r\n@deguio @mariadalfonso "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/383894421","html_url":"https://github.com/cms-sw/cmssw/pull/22974#issuecomment-383894421","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22974","id":383894421,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T11:15:45Z","updated_at":"2018-04-24T11:15:45Z","author_association":"CONTRIBUTOR","body":"The code-checks are being triggered in jenkins."}}
{"actor":{"display_login":"cmsbuild"}}