{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/236564341","pull_request_review_id":178659933,"id":236564341,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjU2NDM0MQ==","diff_hunk":"@@ -286,6 +287,14 @@ func (d *Discovery) refresh() (tg *targetgroup.Group, err error) {\n \t\t\t\treturn\n \t\t\t}\n \n+\t\t\t// We check if the virtual machine has been deallocated/stopped.","path":"discovery/azure/azure.go","position":12,"original_position":12,"commit_id":"76dbdf97c8943fb90c0372df95fc78033e256b05","original_commit_id":"76dbdf97c8943fb90c0372df95fc78033e256b05","user":{"login":"simonpasquier","id":2587585,"node_id":"MDQ6VXNlcjI1ODc1ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/2587585?v=4","gravatar_id":"","url":"https://api.github.com/users/simonpasquier","html_url":"https://github.com/simonpasquier","followers_url":"https://api.github.com/users/simonpasquier/followers","following_url":"https://api.github.com/users/simonpasquier/following{/other_user}","gists_url":"https://api.github.com/users/simonpasquier/gists{/gist_id}","starred_url":"https://api.github.com/users/simonpasquier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonpasquier/subscriptions","organizations_url":"https://api.github.com/users/simonpasquier/orgs","repos_url":"https://api.github.com/users/simonpasquier/repos","events_url":"https://api.github.com/users/simonpasquier/events{/privacy}","received_events_url":"https://api.github.com/users/simonpasquier/received_events","type":"User","site_admin":false},"body":"Please remove `stopped`.","created_at":"2018-11-27T08:43:21Z","updated_at":"2018-11-27T08:44:01Z","html_url":"https://github.com/prometheus/prometheus/pull/4908#discussion_r236564341","pull_request_url":"https://api.github.com/repos/prometheus/prometheus/pulls/4908","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/236564341"},"html":{"href":"https://github.com/prometheus/prometheus/pull/4908#discussion_r236564341"},"pull_request":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4908"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/4908","id":233477072,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNDc3MDcy","html_url":"https://github.com/prometheus/prometheus/pull/4908","diff_url":"https://github.com/prometheus/prometheus/pull/4908.diff","patch_url":"https://github.com/prometheus/prometheus/pull/4908.patch","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/4908","number":4908,"state":"open","locked":false,"title":"add logic to check if an azure VM is deallocated or not","user":{"login":"tariq1890","id":2658224,"node_id":"MDQ6VXNlcjI2NTgyMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2658224?v=4","gravatar_id":"","url":"https://api.github.com/users/tariq1890","html_url":"https://github.com/tariq1890","followers_url":"https://api.github.com/users/tariq1890/followers","following_url":"https://api.github.com/users/tariq1890/following{/other_user}","gists_url":"https://api.github.com/users/tariq1890/gists{/gist_id}","starred_url":"https://api.github.com/users/tariq1890/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tariq1890/subscriptions","organizations_url":"https://api.github.com/users/tariq1890/orgs","repos_url":"https://api.github.com/users/tariq1890/repos","events_url":"https://api.github.com/users/tariq1890/events{/privacy}","received_events_url":"https://api.github.com/users/tariq1890/received_events","type":"User","site_admin":false},"body":"This PR contains the verified method to confirm if an Azure VM has been deallocated or not through azure-sdk-for-go.\r\n\r\n@brian-brazil FYI\r\n\r\n","created_at":"2018-11-26T08:46:15Z","updated_at":"2018-11-27T08:44:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"534efe5f7e07291699233faf5471805da88dd71d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/prometheus/pulls/4908/commits","review_comments_url":"https://api.github.com/repos/prometheus/prometheus/pulls/4908/comments","review_comment_url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/4908/comments","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/76dbdf97c8943fb90c0372df95fc78033e256b05","head":{"label":"tariq1890:skip_az_dealloc","ref":"skip_az_dealloc","sha":"76dbdf97c8943fb90c0372df95fc78033e256b05","user":{"login":"tariq1890","id":2658224,"node_id":"MDQ6VXNlcjI2NTgyMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2658224?v=4","gravatar_id":"","url":"https://api.github.com/users/tariq1890","html_url":"https://github.com/tariq1890","followers_url":"https://api.github.com/users/tariq1890/followers","following_url":"https://api.github.com/users/tariq1890/following{/other_user}","gists_url":"https://api.github.com/users/tariq1890/gists{/gist_id}","starred_url":"https://api.github.com/users/tariq1890/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tariq1890/subscriptions","organizations_url":"https://api.github.com/users/tariq1890/orgs","repos_url":"https://api.github.com/users/tariq1890/repos","events_url":"https://api.github.com/users/tariq1890/events{/privacy}","received_events_url":"https://api.github.com/users/tariq1890/received_events","type":"User","site_admin":false},"repo":{"id":143634517,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2MzQ1MTc=","name":"prometheus","full_name":"tariq1890/prometheus","private":false,"owner":{"login":"tariq1890","id":2658224,"node_id":"MDQ6VXNlcjI2NTgyMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2658224?v=4","gravatar_id":"","url":"https://api.github.com/users/tariq1890","html_url":"https://github.com/tariq1890","followers_url":"https://api.github.com/users/tariq1890/followers","following_url":"https://api.github.com/users/tariq1890/following{/other_user}","gists_url":"https://api.github.com/users/tariq1890/gists{/gist_id}","starred_url":"https://api.github.com/users/tariq1890/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tariq1890/subscriptions","organizations_url":"https://api.github.com/users/tariq1890/orgs","repos_url":"https://api.github.com/users/tariq1890/repos","events_url":"https://api.github.com/users/tariq1890/events{/privacy}","received_events_url":"https://api.github.com/users/tariq1890/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tariq1890/prometheus","description":"The Prometheus monitoring system and time series database.","fork":true,"url":"https://api.github.com/repos/tariq1890/prometheus","forks_url":"https://api.github.com/repos/tariq1890/prometheus/forks","keys_url":"https://api.github.com/repos/tariq1890/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tariq1890/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tariq1890/prometheus/teams","hooks_url":"https://api.github.com/repos/tariq1890/prometheus/hooks","issue_events_url":"https://api.github.com/repos/tariq1890/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/tariq1890/prometheus/events","assignees_url":"https://api.github.com/repos/tariq1890/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/tariq1890/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/tariq1890/prometheus/tags","blobs_url":"https://api.github.com/repos/tariq1890/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tariq1890/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tariq1890/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/tariq1890/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tariq1890/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/tariq1890/prometheus/languages","stargazers_url":"https://api.github.com/repos/tariq1890/prometheus/stargazers","contributors_url":"https://api.github.com/repos/tariq1890/prometheus/contributors","subscribers_url":"https://api.github.com/repos/tariq1890/prometheus/subscribers","subscription_url":"https://api.github.com/repos/tariq1890/prometheus/subscription","commits_url":"https://api.github.com/repos/tariq1890/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/tariq1890/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/tariq1890/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/tariq1890/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/tariq1890/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/tariq1890/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tariq1890/prometheus/merges","archive_url":"https://api.github.com/repos/tariq1890/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tariq1890/prometheus/downloads","issues_url":"https://api.github.com/repos/tariq1890/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/tariq1890/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/tariq1890/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/tariq1890/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tariq1890/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/tariq1890/prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/tariq1890/prometheus/deployments","created_at":"2018-08-05T17:40:08Z","updated_at":"2018-11-05T18:40:23Z","pushed_at":"2018-11-26T21:44:48Z","git_url":"git://github.com/tariq1890/prometheus.git","ssh_url":"git@github.com:tariq1890/prometheus.git","clone_url":"https://github.com/tariq1890/prometheus.git","svn_url":"https://github.com/tariq1890/prometheus","homepage":"https://prometheus.io/","size":44114,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"d2f0f54d68bb3463339a29179ee794acbe3d4cf2","user":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":6838921,"node_id":"MDEwOlJlcG9zaXRvcnk2ODM4OTIx","name":"prometheus","full_name":"prometheus/prometheus","private":false,"owner":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prometheus/prometheus","description":"The Prometheus monitoring system and time series database.","fork":false,"url":"https://api.github.com/repos/prometheus/prometheus","forks_url":"https://api.github.com/repos/prometheus/prometheus/forks","keys_url":"https://api.github.com/repos/prometheus/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/prometheus/teams","hooks_url":"https://api.github.com/repos/prometheus/prometheus/hooks","issue_events_url":"https://api.github.com/repos/prometheus/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/prometheus/events","assignees_url":"https://api.github.com/repos/prometheus/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/prometheus/tags","blobs_url":"https://api.github.com/repos/prometheus/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/prometheus/languages","stargazers_url":"https://api.github.com/repos/prometheus/prometheus/stargazers","contributors_url":"https://api.github.com/repos/prometheus/prometheus/contributors","subscribers_url":"https://api.github.com/repos/prometheus/prometheus/subscribers","subscription_url":"https://api.github.com/repos/prometheus/prometheus/subscription","commits_url":"https://api.github.com/repos/prometheus/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/prometheus/merges","archive_url":"https://api.github.com/repos/prometheus/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/prometheus/downloads","issues_url":"https://api.github.com/repos/prometheus/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/prometheus/deployments","created_at":"2012-11-24T11:14:12Z","updated_at":"2018-11-27T08:30:33Z","pushed_at":"2018-11-27T08:05:27Z","git_url":"git://github.com/prometheus/prometheus.git","ssh_url":"git@github.com:prometheus/prometheus.git","clone_url":"https://github.com/prometheus/prometheus.git","svn_url":"https://github.com/prometheus/prometheus","homepage":"https://prometheus.io/","size":45080,"stargazers_count":20376,"watchers_count":20376,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2776,"mirror_url":null,"archived":false,"open_issues_count":331,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2776,"open_issues":331,"watchers":20376,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4908"},"html":{"href":"https://github.com/prometheus/prometheus/pull/4908"},"issue":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/4908"},"comments":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/4908/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4908/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4908/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/prometheus/statuses/76dbdf97c8943fb90c0372df95fc78033e256b05"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"simonpasquier"}}