{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/175943857","pull_request_review_id":105488437,"id":175943857,"diff_hunk":"@@ -574,3 +578,412 @@ func TestLoadBalancerWrongTierResourceDeletion(t *testing.T) {\n \t_, err = gce.GetRegionAddress(lbName, region)\n \tassert.True(t, isNotFound(err))\n }\n+\n+func TestEnsureExternalLoadBalancerFailsIfInvalidNetworkTier(t *testing.T) {\n+\tgce, err := fakeGCECloud()\n+\trequire.NoError(t, err)\n+\n+\tnodes, err := createAndInsertNodes(gce, []string{nodeName})\n+\trequire.NoError(t, err)\n+\n+\t// Enable the cloud.NetworkTiers feature\n+\tgce.AlphaFeatureGate.features[AlphaFeatureNetworkTiers] = true\n+\twrongTier := \"SupremeLuxury\"\n+\tapiService.Annotations = map[string]string{NetworkTierAnnotationKey: wrongTier}\n+\n+\t_, err = gce.ensureExternalLoadBalancer(clusterName, clusterID, apiService, nil, nodes)\n+\trequire.Error(t, err)\n+\tassert.EqualError(t, err, fmt.Sprintf(\"unsupported network tier: %q\", wrongTier))\n+}\n+\n+func TestEnsureExternalLoadBalancerFailsWithNoNodes(t *testing.T) {\n+\tgce, err := fakeGCECloud()\n+\trequire.NoError(t, err)\n+\n+\t_, err = gce.ensureExternalLoadBalancer(clusterName, clusterID, apiService, nil, []*v1.Node{})\n+\trequire.Error(t, err)\n+\tassert.EqualError(t, err, \"Cannot EnsureLoadBalancer() with no hosts\")\n+}\n+\n+func TestForwardingRuleNeedsUpdate(t *testing.T) {\n+\tgce, err := fakeGCECloud()\n+\trequire.NoError(t, err)\n+\tstatus, err := createExternalLoadBalancer(gce)\n+\trequire.NotNil(t, status)\n+\trequire.NoError(t, err)\n+\n+\tlbName := cloudprovider.GetLoadBalancerName(apiService)\n+\tipAddr := status.Ingress[0].IP\n+\n+\t// When the loadBalancerIP does not equal the FwdRule IP address.\n+\texists, needsUpdate, ipAddress, err := gce.forwardingRuleNeedsUpdate(lbName, region, \"1.2.3.4\", apiService.Spec.Ports)\n+\tassert.True(t, exists)\n+\tassert.True(t, needsUpdate)\n+\tassert.Equal(t, ipAddr, ipAddress)\n+\tassert.NoError(t, err)\n+\n+\t// When loadBalancerPortRange returns an error.\n+\texists, needsUpdate, ipAddress, err = gce.forwardingRuleNeedsUpdate(lbName, region, apiService.Spec.LoadBalancerIP, []v1.ServicePort{})\n+\tassert.True(t, exists)\n+\tassert.False(t, needsUpdate)\n+\tassert.Empty(t, ipAddress)\n+\tassert.NotNil(t, err)\n+\n+\t// When portRange != the forwardingRule port range.\n+\twrongPorts := []v1.ServicePort{apiService.Spec.Ports[0]}\n+\twrongPorts[0].Port = wrongPorts[0].Port + 1\n+\texists, needsUpdate, ipAddress, err = gce.forwardingRuleNeedsUpdate(lbName, region, apiService.Spec.LoadBalancerIP, wrongPorts)\n+\tassert.True(t, exists)\n+\tassert.True(t, needsUpdate)\n+\tassert.Equal(t, ipAddr, ipAddress)\n+\tassert.NoError(t, err)\n+\n+\t// When the ports protocol does not equal the ForwardingRuel IP Protocol.\n+\twrongPorts = []v1.ServicePort{apiService.Spec.Ports[0]}\n+\twrongPorts[0].Protocol = v1.ProtocolUDP\n+\texists, needsUpdate, ipAddress, err = gce.forwardingRuleNeedsUpdate(lbName, region, apiService.Spec.LoadBalancerIP, wrongPorts)\n+\tassert.True(t, exists)\n+\tassert.True(t, needsUpdate)\n+\tassert.Equal(t, ipAddr, ipAddress)\n+\tassert.NoError(t, err)\n+\n+\t// Basic workflow.\n+\texists, needsUpdate, ipAddress, err = gce.forwardingRuleNeedsUpdate(lbName, region, apiService.Spec.LoadBalancerIP, apiService.Spec.Ports)","path":"pkg/cloudprovider/providers/gce/gce_loadbalancer_external_test.go","position":97,"original_position":97,"commit_id":"c35de8a25e433e5ad039d352b4d72028c9564460","original_commit_id":"c35de8a25e433e5ad039d352b4d72028c9564460","user":{"login":"MrHohn","id":8681801,"avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false},"body":"Many cases in this function seems possible to be tested with the same workflow, could we implement the test with a testcase struct? Something similar to below test func:\r\nhttps://github.com/kubernetes/kubernetes/blob/f6eed81f211d929592ddb236535f306a277ff372/pkg/proxy/service_test.go#L97-L102","created_at":"2018-03-20T22:34:01Z","updated_at":"2018-03-20T22:40:20Z","html_url":"https://github.com/kubernetes/kubernetes/pull/61300#discussion_r175943857","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61300","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/175943857"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/61300#discussion_r175943857"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61300"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61300","id":175634876,"html_url":"https://github.com/kubernetes/kubernetes/pull/61300","diff_url":"https://github.com/kubernetes/kubernetes/pull/61300.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/61300.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61300","number":61300,"state":"open","locked":false,"title":"Unittests for external load balancer firewall unauthorized errors when XPN is on.","user":{"login":"grayluck","id":4760200,"avatar_url":"https://avatars3.githubusercontent.com/u/4760200?v=4","gravatar_id":"","url":"https://api.github.com/users/grayluck","html_url":"https://github.com/grayluck","followers_url":"https://api.github.com/users/grayluck/followers","following_url":"https://api.github.com/users/grayluck/following{/other_user}","gists_url":"https://api.github.com/users/grayluck/gists{/gist_id}","starred_url":"https://api.github.com/users/grayluck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayluck/subscriptions","organizations_url":"https://api.github.com/users/grayluck/orgs","repos_url":"https://api.github.com/users/grayluck/repos","events_url":"https://api.github.com/users/grayluck/events{/privacy}","received_events_url":"https://api.github.com/users/grayluck/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nTest cases to ensure the system doesn't crash when firewall manipulation failed because of unauthorized requests. \r\n\r\n<!--\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes # \r\n\r\n**Special notes for your reviewer**:\r\n-->\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-03-16T20:12:24Z","updated_at":"2018-03-20T22:40:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcfeee377b16908f2c1316bdd477c9c195b2170d","assignee":{"login":"MrHohn","id":8681801,"avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false},"assignees":[{"login":"MrHohn","id":8681801,"avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"brendandburns","id":5751682,"avatar_url":"https://avatars2.githubusercontent.com/u/5751682?v=4","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61300/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61300/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61300/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c35de8a25e433e5ad039d352b4d72028c9564460","head":{"label":"grayluck:gce-lb-test","ref":"gce-lb-test","sha":"c35de8a25e433e5ad039d352b4d72028c9564460","user":{"login":"grayluck","id":4760200,"avatar_url":"https://avatars3.githubusercontent.com/u/4760200?v=4","gravatar_id":"","url":"https://api.github.com/users/grayluck","html_url":"https://github.com/grayluck","followers_url":"https://api.github.com/users/grayluck/followers","following_url":"https://api.github.com/users/grayluck/following{/other_user}","gists_url":"https://api.github.com/users/grayluck/gists{/gist_id}","starred_url":"https://api.github.com/users/grayluck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayluck/subscriptions","organizations_url":"https://api.github.com/users/grayluck/orgs","repos_url":"https://api.github.com/users/grayluck/repos","events_url":"https://api.github.com/users/grayluck/events{/privacy}","received_events_url":"https://api.github.com/users/grayluck/received_events","type":"User","site_admin":false},"repo":{"id":124442305,"name":"kubernetes","full_name":"grayluck/kubernetes","owner":{"login":"grayluck","id":4760200,"avatar_url":"https://avatars3.githubusercontent.com/u/4760200?v=4","gravatar_id":"","url":"https://api.github.com/users/grayluck","html_url":"https://github.com/grayluck","followers_url":"https://api.github.com/users/grayluck/followers","following_url":"https://api.github.com/users/grayluck/following{/other_user}","gists_url":"https://api.github.com/users/grayluck/gists{/gist_id}","starred_url":"https://api.github.com/users/grayluck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayluck/subscriptions","organizations_url":"https://api.github.com/users/grayluck/orgs","repos_url":"https://api.github.com/users/grayluck/repos","events_url":"https://api.github.com/users/grayluck/events{/privacy}","received_events_url":"https://api.github.com/users/grayluck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grayluck/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/grayluck/kubernetes","forks_url":"https://api.github.com/repos/grayluck/kubernetes/forks","keys_url":"https://api.github.com/repos/grayluck/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grayluck/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grayluck/kubernetes/teams","hooks_url":"https://api.github.com/repos/grayluck/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/grayluck/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/grayluck/kubernetes/events","assignees_url":"https://api.github.com/repos/grayluck/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/grayluck/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/grayluck/kubernetes/tags","blobs_url":"https://api.github.com/repos/grayluck/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grayluck/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grayluck/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/grayluck/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grayluck/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/grayluck/kubernetes/languages","stargazers_url":"https://api.github.com/repos/grayluck/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/grayluck/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/grayluck/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/grayluck/kubernetes/subscription","commits_url":"https://api.github.com/repos/grayluck/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/grayluck/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/grayluck/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/grayluck/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/grayluck/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/grayluck/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grayluck/kubernetes/merges","archive_url":"https://api.github.com/repos/grayluck/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grayluck/kubernetes/downloads","issues_url":"https://api.github.com/repos/grayluck/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/grayluck/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/grayluck/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/grayluck/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grayluck/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/grayluck/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/grayluck/kubernetes/deployments","created_at":"2018-03-08T20:07:39Z","updated_at":"2018-03-16T20:40:57Z","pushed_at":"2018-03-20T22:32:09Z","git_url":"git://github.com/grayluck/kubernetes.git","ssh_url":"git@github.com:grayluck/kubernetes.git","clone_url":"https://github.com/grayluck/kubernetes.git","svn_url":"https://github.com/grayluck/kubernetes","homepage":"http://kubernetes.io","size":545742,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"ca02c11887c65431af85f809606527be7f08062d","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-03-20T22:39:02Z","pushed_at":"2018-03-20T22:38:41Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":765380,"stargazers_count":33971,"watchers_count":33971,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12049,"mirror_url":null,"archived":false,"open_issues_count":3531,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12049,"open_issues":3531,"watchers":33971,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61300"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/61300"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/61300"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/61300/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61300/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61300/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c35de8a25e433e5ad039d352b4d72028c9564460"}},"author_association":"NONE"}}
{"actor":{"display_login":"MrHohn"}}