{"action":"created","issue":{"url":"https://api.github.com/repos/PX4/Devguide/issues/457","repository_url":"https://api.github.com/repos/PX4/Devguide","labels_url":"https://api.github.com/repos/PX4/Devguide/issues/457/labels{/name}","comments_url":"https://api.github.com/repos/PX4/Devguide/issues/457/comments","events_url":"https://api.github.com/repos/PX4/Devguide/issues/457/events","html_url":"https://github.com/PX4/Devguide/pull/457","id":295911255,"number":457,"title":"Added further description to flight modes","user":{"login":"barzanisar","id":26625030,"avatar_url":"https://avatars3.githubusercontent.com/u/26625030?v=4","gravatar_id":"","url":"https://api.github.com/users/barzanisar","html_url":"https://github.com/barzanisar","followers_url":"https://api.github.com/users/barzanisar/followers","following_url":"https://api.github.com/users/barzanisar/following{/other_user}","gists_url":"https://api.github.com/users/barzanisar/gists{/gist_id}","starred_url":"https://api.github.com/users/barzanisar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barzanisar/subscriptions","organizations_url":"https://api.github.com/users/barzanisar/orgs","repos_url":"https://api.github.com/users/barzanisar/repos","events_url":"https://api.github.com/users/barzanisar/events{/privacy}","received_events_url":"https://api.github.com/users/barzanisar/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-09T15:36:45Z","updated_at":"2018-02-23T00:49:46Z","closed_at":"2018-02-23T00:32:59Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/PX4/Devguide/pulls/457","html_url":"https://github.com/PX4/Devguide/pull/457","diff_url":"https://github.com/PX4/Devguide/pull/457.diff","patch_url":"https://github.com/PX4/Devguide/pull/457.patch"},"body":"Added further description to flight modes for ease of understanding to new users."},"comment":{"url":"https://api.github.com/repos/PX4/Devguide/issues/comments/367873311","html_url":"https://github.com/PX4/Devguide/pull/457#issuecomment-367873311","issue_url":"https://api.github.com/repos/PX4/Devguide/issues/457","id":367873311,"user":{"login":"hamishwillee","id":5368500,"avatar_url":"https://avatars2.githubusercontent.com/u/5368500?v=4","gravatar_id":"","url":"https://api.github.com/users/hamishwillee","html_url":"https://github.com/hamishwillee","followers_url":"https://api.github.com/users/hamishwillee/followers","following_url":"https://api.github.com/users/hamishwillee/following{/other_user}","gists_url":"https://api.github.com/users/hamishwillee/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishwillee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishwillee/subscriptions","organizations_url":"https://api.github.com/users/hamishwillee/orgs","repos_url":"https://api.github.com/users/hamishwillee/repos","events_url":"https://api.github.com/users/hamishwillee/events{/privacy}","received_events_url":"https://api.github.com/users/hamishwillee/received_events","type":"User","site_admin":false},"created_at":"2018-02-23T00:49:46Z","updated_at":"2018-02-23T00:49:46Z","author_association":"COLLABORATOR","body":"It looks like all comments have been addressed, so I have merged this. Thanks @barzanisar \r\n\r\n>> @bkueng in https://docs.px4.io/en/flight_modes/ I found that for fixed wing aircrafts, the state of ACRO mode decides whether to switch to Stabilised mode or Manual mode. And from the Dev guide's flight mode evaluation diagram I understood the following, so correct me if I am wrong:\r\n\r\n> This is incorrect (outdated) and needs to be updated. There is now a separate acro mode for fixed-wing: the user controls the vehicle's body rates and the controller stabilizes the rates (all 3 axis: roll, pitch & yaw).\r\n(whereas stabilize will level out and do the coordinated turns, so stabilize the attitude angles)\r\n\r\n@bkueng @barzanisar  Can you confirm what needs to be done here? \r\n\r\n1. I think most of the  https://dev.px4.io/en/concept/flight_modes.html section on FW is correct but still needs to addition of a FW ACRO section - e.g.  \r\n```\r\n* **Fixed wing aircraft/ rovers / boats:** \r\n  * **MANUAL:** T...\r\n  * **STABILIZED:** ...\r\n> **Acro**:  the pilot controls the vehicle's body rates and the controller stabilizes the rates (all 3 axis: roll, pitch & yaw).\r\n```\r\n- Is that correct?\r\n- @barzanisar If so, could you add a PR and make the docs consistent.\r\n\r\n2. Same text should migrate to [PX4 User Guide > Flight Modes](https://docs.px4.io/en/flight_modes/) in section on Manual Modes fixed wing. My understanding of the above is that this still incorrectly documents a relationship between stabilised and ACRO modes. Correct?\r\n3. Does the diagram need to change: https://dev.px4.io/en/concept/flight_modes.html#flight-mode-evaluation-diagram - if so how?"}}
{"actor":{"display_login":"hamishwillee"}}