{"action":"closed","number":711,"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/711","id":171025050,"html_url":"https://github.com/jaegertracing/jaeger/pull/711","diff_url":"https://github.com/jaegertracing/jaeger/pull/711.diff","patch_url":"https://github.com/jaegertracing/jaeger/pull/711.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/711","number":711,"state":"closed","locked":false,"title":"Wait group should add before the goroutine creating","user":{"login":"oiooj","id":2253095,"avatar_url":"https://avatars3.githubusercontent.com/u/2253095?v=4","gravatar_id":"","url":"https://api.github.com/users/oiooj","html_url":"https://github.com/oiooj","followers_url":"https://api.github.com/users/oiooj/followers","following_url":"https://api.github.com/users/oiooj/following{/other_user}","gists_url":"https://api.github.com/users/oiooj/gists{/gist_id}","starred_url":"https://api.github.com/users/oiooj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oiooj/subscriptions","organizations_url":"https://api.github.com/users/oiooj/orgs","repos_url":"https://api.github.com/users/oiooj/repos","events_url":"https://api.github.com/users/oiooj/events{/privacy}","received_events_url":"https://api.github.com/users/oiooj/received_events","type":"User","site_admin":false},"body":"The calls to Add should execute before the statement creating the\r\ngoroutine or other event to be waited for.\r\n\r\nSigned-off-by: kun <oiooj@qq.com>","created_at":"2018-02-23T14:16:47Z","updated_at":"2018-02-23T15:48:20Z","closed_at":"2018-02-23T15:48:20Z","merged_at":"2018-02-23T15:48:19Z","merge_commit_sha":"e2f11500ce0062de5d4a39d7e2f7f20cd714c177","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vprithvi","id":833009,"avatar_url":"https://avatars0.githubusercontent.com/u/833009?v=4","gravatar_id":"","url":"https://api.github.com/users/vprithvi","html_url":"https://github.com/vprithvi","followers_url":"https://api.github.com/users/vprithvi/followers","following_url":"https://api.github.com/users/vprithvi/following{/other_user}","gists_url":"https://api.github.com/users/vprithvi/gists{/gist_id}","starred_url":"https://api.github.com/users/vprithvi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vprithvi/subscriptions","organizations_url":"https://api.github.com/users/vprithvi/orgs","repos_url":"https://api.github.com/users/vprithvi/repos","events_url":"https://api.github.com/users/vprithvi/events{/privacy}","received_events_url":"https://api.github.com/users/vprithvi/received_events","type":"User","site_admin":false},{"login":"yurishkuro","id":3523016,"avatar_url":"https://avatars2.githubusercontent.com/u/3523016?v=4","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/711/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/711/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/711/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger/statuses/9b6e8800b48b9fafced7c002965c5783831e350c","head":{"label":"oiooj:pr-wg","ref":"pr-wg","sha":"9b6e8800b48b9fafced7c002965c5783831e350c","user":{"login":"oiooj","id":2253095,"avatar_url":"https://avatars3.githubusercontent.com/u/2253095?v=4","gravatar_id":"","url":"https://api.github.com/users/oiooj","html_url":"https://github.com/oiooj","followers_url":"https://api.github.com/users/oiooj/followers","following_url":"https://api.github.com/users/oiooj/following{/other_user}","gists_url":"https://api.github.com/users/oiooj/gists{/gist_id}","starred_url":"https://api.github.com/users/oiooj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oiooj/subscriptions","organizations_url":"https://api.github.com/users/oiooj/orgs","repos_url":"https://api.github.com/users/oiooj/repos","events_url":"https://api.github.com/users/oiooj/events{/privacy}","received_events_url":"https://api.github.com/users/oiooj/received_events","type":"User","site_admin":false},"repo":{"id":120262640,"name":"jaeger","full_name":"oiooj/jaeger","owner":{"login":"oiooj","id":2253095,"avatar_url":"https://avatars3.githubusercontent.com/u/2253095?v=4","gravatar_id":"","url":"https://api.github.com/users/oiooj","html_url":"https://github.com/oiooj","followers_url":"https://api.github.com/users/oiooj/followers","following_url":"https://api.github.com/users/oiooj/following{/other_user}","gists_url":"https://api.github.com/users/oiooj/gists{/gist_id}","starred_url":"https://api.github.com/users/oiooj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oiooj/subscriptions","organizations_url":"https://api.github.com/users/oiooj/orgs","repos_url":"https://api.github.com/users/oiooj/repos","events_url":"https://api.github.com/users/oiooj/events{/privacy}","received_events_url":"https://api.github.com/users/oiooj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oiooj/jaeger","description":"CNCF Jaeger, a Distributed Tracing System","fork":true,"url":"https://api.github.com/repos/oiooj/jaeger","forks_url":"https://api.github.com/repos/oiooj/jaeger/forks","keys_url":"https://api.github.com/repos/oiooj/jaeger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oiooj/jaeger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oiooj/jaeger/teams","hooks_url":"https://api.github.com/repos/oiooj/jaeger/hooks","issue_events_url":"https://api.github.com/repos/oiooj/jaeger/issues/events{/number}","events_url":"https://api.github.com/repos/oiooj/jaeger/events","assignees_url":"https://api.github.com/repos/oiooj/jaeger/assignees{/user}","branches_url":"https://api.github.com/repos/oiooj/jaeger/branches{/branch}","tags_url":"https://api.github.com/repos/oiooj/jaeger/tags","blobs_url":"https://api.github.com/repos/oiooj/jaeger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oiooj/jaeger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oiooj/jaeger/git/refs{/sha}","trees_url":"https://api.github.com/repos/oiooj/jaeger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oiooj/jaeger/statuses/{sha}","languages_url":"https://api.github.com/repos/oiooj/jaeger/languages","stargazers_url":"https://api.github.com/repos/oiooj/jaeger/stargazers","contributors_url":"https://api.github.com/repos/oiooj/jaeger/contributors","subscribers_url":"https://api.github.com/repos/oiooj/jaeger/subscribers","subscription_url":"https://api.github.com/repos/oiooj/jaeger/subscription","commits_url":"https://api.github.com/repos/oiooj/jaeger/commits{/sha}","git_commits_url":"https://api.github.com/repos/oiooj/jaeger/git/commits{/sha}","comments_url":"https://api.github.com/repos/oiooj/jaeger/comments{/number}","issue_comment_url":"https://api.github.com/repos/oiooj/jaeger/issues/comments{/number}","contents_url":"https://api.github.com/repos/oiooj/jaeger/contents/{+path}","compare_url":"https://api.github.com/repos/oiooj/jaeger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oiooj/jaeger/merges","archive_url":"https://api.github.com/repos/oiooj/jaeger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oiooj/jaeger/downloads","issues_url":"https://api.github.com/repos/oiooj/jaeger/issues{/number}","pulls_url":"https://api.github.com/repos/oiooj/jaeger/pulls{/number}","milestones_url":"https://api.github.com/repos/oiooj/jaeger/milestones{/number}","notifications_url":"https://api.github.com/repos/oiooj/jaeger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oiooj/jaeger/labels{/name}","releases_url":"https://api.github.com/repos/oiooj/jaeger/releases{/id}","deployments_url":"https://api.github.com/repos/oiooj/jaeger/deployments","created_at":"2018-02-05T06:11:33Z","updated_at":"2018-02-05T06:11:36Z","pushed_at":"2018-02-23T14:21:44Z","git_url":"git://github.com/oiooj/jaeger.git","ssh_url":"git@github.com:oiooj/jaeger.git","clone_url":"https://github.com/oiooj/jaeger.git","svn_url":"https://github.com/oiooj/jaeger","homepage":"http://jaegertracing.io/","size":2637,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"b1d39bb4f15ea207aabe775e7a950993dbb7e84c","user":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":56342508,"name":"jaeger","full_name":"jaegertracing/jaeger","owner":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jaegertracing/jaeger","description":"CNCF Jaeger, a Distributed Tracing System","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger","forks_url":"https://api.github.com/repos/jaegertracing/jaeger/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger/deployments","created_at":"2016-04-15T18:49:02Z","updated_at":"2018-02-23T15:31:19Z","pushed_at":"2018-02-23T15:48:19Z","git_url":"git://github.com/jaegertracing/jaeger.git","ssh_url":"git@github.com:jaegertracing/jaeger.git","clone_url":"https://github.com/jaegertracing/jaeger.git","svn_url":"https://github.com/jaegertracing/jaeger","homepage":"http://jaegertracing.io/","size":2639,"stargazers_count":4024,"watchers_count":4024,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":313,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":313,"open_issues":140,"watchers":4024,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/711"},"html":{"href":"https://github.com/jaegertracing/jaeger/pull/711"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger/issues/711"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger/issues/711/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/711/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/711/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger/statuses/9b6e8800b48b9fafced7c002965c5783831e350c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"black-adder","id":791791,"avatar_url":"https://avatars1.githubusercontent.com/u/791791?v=4","gravatar_id":"","url":"https://api.github.com/users/black-adder","html_url":"https://github.com/black-adder","followers_url":"https://api.github.com/users/black-adder/followers","following_url":"https://api.github.com/users/black-adder/following{/other_user}","gists_url":"https://api.github.com/users/black-adder/gists{/gist_id}","starred_url":"https://api.github.com/users/black-adder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/black-adder/subscriptions","organizations_url":"https://api.github.com/users/black-adder/orgs","repos_url":"https://api.github.com/users/black-adder/repos","events_url":"https://api.github.com/users/black-adder/events{/privacy}","received_events_url":"https://api.github.com/users/black-adder/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"black-adder"}}