{"action":"created","comment":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/comments/214306406","pull_request_review_id":151334809,"id":214306406,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDMwNjQwNg==","diff_hunk":"@@ -35,6 +35,11 @@\n #define FRR_NO_CFG_PID_DRY\t\t(1 << 3)\n #define FRR_NO_ZCLIENT\t\t(1 << 4)\n \n+enum frr_ret {","path":"lib/libfrr.h","position":4,"original_position":4,"commit_id":"a356e37d08a1312bda6ca11d6945f5d62b48762a","original_commit_id":"a356e37d08a1312bda6ca11d6945f5d62b48762a","user":{"login":"eqvinox","id":1715611,"node_id":"MDQ6VXNlcjE3MTU2MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1715611?v=4","gravatar_id":"","url":"https://api.github.com/users/eqvinox","html_url":"https://github.com/eqvinox","followers_url":"https://api.github.com/users/eqvinox/followers","following_url":"https://api.github.com/users/eqvinox/following{/other_user}","gists_url":"https://api.github.com/users/eqvinox/gists{/gist_id}","starred_url":"https://api.github.com/users/eqvinox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eqvinox/subscriptions","organizations_url":"https://api.github.com/users/eqvinox/orgs","repos_url":"https://api.github.com/users/eqvinox/repos","events_url":"https://api.github.com/users/eqvinox/events{/privacy}","received_events_url":"https://api.github.com/users/eqvinox/received_events","type":"User","site_admin":false},"body":"Please remove this enum. \"0 means OK\" is standard procedure for any function returning `int`.","created_at":"2018-08-31T10:09:14Z","updated_at":"2018-08-31T10:16:09Z","html_url":"https://github.com/FRRouting/frr/pull/2952#discussion_r214306406","pull_request_url":"https://api.github.com/repos/FRRouting/frr/pulls/2952","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/comments/214306406"},"html":{"href":"https://github.com/FRRouting/frr/pull/2952#discussion_r214306406"},"pull_request":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/2952"}}},"pull_request":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/2952","id":212295365,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMjk1MzY1","html_url":"https://github.com/FRRouting/frr/pull/2952","diff_url":"https://github.com/FRRouting/frr/pull/2952.diff","patch_url":"https://github.com/FRRouting/frr/pull/2952.patch","issue_url":"https://api.github.com/repos/FRRouting/frr/issues/2952","number":2952,"state":"open","locked":false,"title":"lib: Ensure FRR has appropriate error messages for when it detects being run a second time (#2680)","user":{"login":"bisdhdh","id":7814685,"node_id":"MDQ6VXNlcjc4MTQ2ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/7814685?v=4","gravatar_id":"","url":"https://api.github.com/users/bisdhdh","html_url":"https://github.com/bisdhdh","followers_url":"https://api.github.com/users/bisdhdh/followers","following_url":"https://api.github.com/users/bisdhdh/following{/other_user}","gists_url":"https://api.github.com/users/bisdhdh/gists{/gist_id}","starred_url":"https://api.github.com/users/bisdhdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bisdhdh/subscriptions","organizations_url":"https://api.github.com/users/bisdhdh/orgs","repos_url":"https://api.github.com/users/bisdhdh/repos","events_url":"https://api.github.com/users/bisdhdh/events{/privacy}","received_events_url":"https://api.github.com/users/bisdhdh/received_events","type":"User","site_admin":false},"body":"\r\nSolution :\r\nThe following procedures would be performed :\r\n1. Verify if the pid file for each daemon is present or not. If the file is not present, that means the\r\n   daemon is getting instantiated for the first time. So let it go ahead.\r\n   If the file is present proceed to point ‘2’.\r\n2. Try fetching the properties of the pid file\r\n3. If it has RW lock, that means one instance of this the daemon is already running.\r\n   So stop moving ahead and do exit() else let it go ahead. Please note all above procedure happen at\r\n   the initial state of daemon’s instantiation, much before it starts any session with other\r\n   process/allocates resources etc.. and this verification do not have any impact of any\r\n   operations done later, if the verification succeeds.\r\n\r\nSigned-off-by: bisdhdh <sadhub@vmware.com>","created_at":"2018-08-31T07:20:09Z","updated_at":"2018-08-31T10:16:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1b558e2573b8b09c5fbaae99039d35bd2124f08","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FRRouting/frr/pulls/2952/commits","review_comments_url":"https://api.github.com/repos/FRRouting/frr/pulls/2952/comments","review_comment_url":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FRRouting/frr/issues/2952/comments","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/a356e37d08a1312bda6ca11d6945f5d62b48762a","head":{"label":"bisdhdh:biswajitfrrVM1","ref":"biswajitfrrVM1","sha":"a356e37d08a1312bda6ca11d6945f5d62b48762a","user":{"login":"bisdhdh","id":7814685,"node_id":"MDQ6VXNlcjc4MTQ2ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/7814685?v=4","gravatar_id":"","url":"https://api.github.com/users/bisdhdh","html_url":"https://github.com/bisdhdh","followers_url":"https://api.github.com/users/bisdhdh/followers","following_url":"https://api.github.com/users/bisdhdh/following{/other_user}","gists_url":"https://api.github.com/users/bisdhdh/gists{/gist_id}","starred_url":"https://api.github.com/users/bisdhdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bisdhdh/subscriptions","organizations_url":"https://api.github.com/users/bisdhdh/orgs","repos_url":"https://api.github.com/users/bisdhdh/repos","events_url":"https://api.github.com/users/bisdhdh/events{/privacy}","received_events_url":"https://api.github.com/users/bisdhdh/received_events","type":"User","site_admin":false},"repo":{"id":143128031,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxMjgwMzE=","name":"frr","full_name":"bisdhdh/frr","owner":{"login":"bisdhdh","id":7814685,"node_id":"MDQ6VXNlcjc4MTQ2ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/7814685?v=4","gravatar_id":"","url":"https://api.github.com/users/bisdhdh","html_url":"https://github.com/bisdhdh","followers_url":"https://api.github.com/users/bisdhdh/followers","following_url":"https://api.github.com/users/bisdhdh/following{/other_user}","gists_url":"https://api.github.com/users/bisdhdh/gists{/gist_id}","starred_url":"https://api.github.com/users/bisdhdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bisdhdh/subscriptions","organizations_url":"https://api.github.com/users/bisdhdh/orgs","repos_url":"https://api.github.com/users/bisdhdh/repos","events_url":"https://api.github.com/users/bisdhdh/events{/privacy}","received_events_url":"https://api.github.com/users/bisdhdh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bisdhdh/frr","description":"The FRRouting Protocol Suite","fork":true,"url":"https://api.github.com/repos/bisdhdh/frr","forks_url":"https://api.github.com/repos/bisdhdh/frr/forks","keys_url":"https://api.github.com/repos/bisdhdh/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bisdhdh/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bisdhdh/frr/teams","hooks_url":"https://api.github.com/repos/bisdhdh/frr/hooks","issue_events_url":"https://api.github.com/repos/bisdhdh/frr/issues/events{/number}","events_url":"https://api.github.com/repos/bisdhdh/frr/events","assignees_url":"https://api.github.com/repos/bisdhdh/frr/assignees{/user}","branches_url":"https://api.github.com/repos/bisdhdh/frr/branches{/branch}","tags_url":"https://api.github.com/repos/bisdhdh/frr/tags","blobs_url":"https://api.github.com/repos/bisdhdh/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bisdhdh/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bisdhdh/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/bisdhdh/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bisdhdh/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/bisdhdh/frr/languages","stargazers_url":"https://api.github.com/repos/bisdhdh/frr/stargazers","contributors_url":"https://api.github.com/repos/bisdhdh/frr/contributors","subscribers_url":"https://api.github.com/repos/bisdhdh/frr/subscribers","subscription_url":"https://api.github.com/repos/bisdhdh/frr/subscription","commits_url":"https://api.github.com/repos/bisdhdh/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/bisdhdh/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/bisdhdh/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/bisdhdh/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/bisdhdh/frr/contents/{+path}","compare_url":"https://api.github.com/repos/bisdhdh/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bisdhdh/frr/merges","archive_url":"https://api.github.com/repos/bisdhdh/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bisdhdh/frr/downloads","issues_url":"https://api.github.com/repos/bisdhdh/frr/issues{/number}","pulls_url":"https://api.github.com/repos/bisdhdh/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/bisdhdh/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/bisdhdh/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bisdhdh/frr/labels{/name}","releases_url":"https://api.github.com/repos/bisdhdh/frr/releases{/id}","deployments_url":"https://api.github.com/repos/bisdhdh/frr/deployments","created_at":"2018-08-01T08:37:35Z","updated_at":"2018-08-31T06:50:02Z","pushed_at":"2018-08-31T07:19:10Z","git_url":"git://github.com/bisdhdh/frr.git","ssh_url":"git@github.com:bisdhdh/frr.git","clone_url":"https://github.com/bisdhdh/frr.git","svn_url":"https://github.com/bisdhdh/frr","homepage":"https://frrouting.org/","size":44772,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FRRouting:master","ref":"master","sha":"5c724747c122cf7be0dcded9af6b88b31bf5f6c6","user":{"login":"FRRouting","id":24592672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTkyNjcy","avatar_url":"https://avatars1.githubusercontent.com/u/24592672?v=4","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"repo":{"id":76599439,"node_id":"MDEwOlJlcG9zaXRvcnk3NjU5OTQzOQ==","name":"frr","full_name":"FRRouting/frr","owner":{"login":"FRRouting","id":24592672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTkyNjcy","avatar_url":"https://avatars1.githubusercontent.com/u/24592672?v=4","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FRRouting/frr","description":"The FRRouting Protocol Suite","fork":false,"url":"https://api.github.com/repos/FRRouting/frr","forks_url":"https://api.github.com/repos/FRRouting/frr/forks","keys_url":"https://api.github.com/repos/FRRouting/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FRRouting/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FRRouting/frr/teams","hooks_url":"https://api.github.com/repos/FRRouting/frr/hooks","issue_events_url":"https://api.github.com/repos/FRRouting/frr/issues/events{/number}","events_url":"https://api.github.com/repos/FRRouting/frr/events","assignees_url":"https://api.github.com/repos/FRRouting/frr/assignees{/user}","branches_url":"https://api.github.com/repos/FRRouting/frr/branches{/branch}","tags_url":"https://api.github.com/repos/FRRouting/frr/tags","blobs_url":"https://api.github.com/repos/FRRouting/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FRRouting/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FRRouting/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/FRRouting/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/FRRouting/frr/languages","stargazers_url":"https://api.github.com/repos/FRRouting/frr/stargazers","contributors_url":"https://api.github.com/repos/FRRouting/frr/contributors","subscribers_url":"https://api.github.com/repos/FRRouting/frr/subscribers","subscription_url":"https://api.github.com/repos/FRRouting/frr/subscription","commits_url":"https://api.github.com/repos/FRRouting/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/FRRouting/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/FRRouting/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/FRRouting/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/FRRouting/frr/contents/{+path}","compare_url":"https://api.github.com/repos/FRRouting/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FRRouting/frr/merges","archive_url":"https://api.github.com/repos/FRRouting/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FRRouting/frr/downloads","issues_url":"https://api.github.com/repos/FRRouting/frr/issues{/number}","pulls_url":"https://api.github.com/repos/FRRouting/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/FRRouting/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/FRRouting/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FRRouting/frr/labels{/name}","releases_url":"https://api.github.com/repos/FRRouting/frr/releases{/id}","deployments_url":"https://api.github.com/repos/FRRouting/frr/deployments","created_at":"2016-12-15T21:56:38Z","updated_at":"2018-08-31T09:29:34Z","pushed_at":"2018-08-31T09:29:29Z","git_url":"git://github.com/FRRouting/frr.git","ssh_url":"git@github.com:FRRouting/frr.git","clone_url":"https://github.com/FRRouting/frr.git","svn_url":"https://github.com/FRRouting/frr","homepage":"https://frrouting.org/","size":44831,"stargazers_count":619,"watchers_count":619,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":247,"mirror_url":null,"archived":false,"open_issues_count":283,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":247,"open_issues":283,"watchers":619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/2952"},"html":{"href":"https://github.com/FRRouting/frr/pull/2952"},"issue":{"href":"https://api.github.com/repos/FRRouting/frr/issues/2952"},"comments":{"href":"https://api.github.com/repos/FRRouting/frr/issues/2952/comments"},"review_comments":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/2952/comments"},"review_comment":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/2952/commits"},"statuses":{"href":"https://api.github.com/repos/FRRouting/frr/statuses/a356e37d08a1312bda6ca11d6945f5d62b48762a"}},"author_association":"NONE"}}
{"actor":{"display_login":"eqvinox"}}