{"action":"created","comment":{"url":"https://api.github.com/repos/apache/wicket/pulls/comments/220426844","pull_request_review_id":158831580,"id":220426844,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDQyNjg0NA==","diff_hunk":"@@ -2301,6 +2302,10 @@\n \t\t\t\t\tonDrag = jQuery.noop;\n \t\t\t\t}\n \n+\t\t\t\tif (typeof(settings) !== \"undefined\" && settings.stopDragOnCssSelector) {","path":"wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js","position":17,"original_position":17,"commit_id":"ac9447692235035c4eec94280a72018a6b987190","original_commit_id":"ac9447692235035c4eec94280a72018a6b987190","user":{"login":"solomax","id":3870591,"node_id":"MDQ6VXNlcjM4NzA1OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3870591?v=4","gravatar_id":"","url":"https://api.github.com/users/solomax","html_url":"https://github.com/solomax","followers_url":"https://api.github.com/users/solomax/followers","following_url":"https://api.github.com/users/solomax/following{/other_user}","gists_url":"https://api.github.com/users/solomax/gists{/gist_id}","starred_url":"https://api.github.com/users/solomax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solomax/subscriptions","organizations_url":"https://api.github.com/users/solomax/orgs","repos_url":"https://api.github.com/users/solomax/repos","events_url":"https://api.github.com/users/solomax/events{/privacy}","received_events_url":"https://api.github.com/users/solomax/received_events","type":"User","site_admin":false},"body":"According to the code `settings` should be `object`\r\nMaybe it would be better to change this line to be\r\n`typeof(settings) === 'object'` ?","created_at":"2018-09-26T04:59:02Z","updated_at":"2018-09-26T04:59:02Z","html_url":"https://github.com/apache/wicket/pull/294#discussion_r220426844","pull_request_url":"https://api.github.com/repos/apache/wicket/pulls/294","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/wicket/pulls/comments/220426844"},"html":{"href":"https://github.com/apache/wicket/pull/294#discussion_r220426844"},"pull_request":{"href":"https://api.github.com/repos/apache/wicket/pulls/294"}}},"pull_request":{"url":"https://api.github.com/repos/apache/wicket/pulls/294","id":218179610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTc5NjEw","html_url":"https://github.com/apache/wicket/pull/294","diff_url":"https://github.com/apache/wicket/pull/294.diff","patch_url":"https://github.com/apache/wicket/pull/294.patch","issue_url":"https://api.github.com/repos/apache/wicket/issues/294","number":294,"state":"open","locked":false,"title":"WICKET-5552 fix modal mousedown and make modal more extendable","user":{"login":"andruhon","id":1694497,"node_id":"MDQ6VXNlcjE2OTQ0OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1694497?v=4","gravatar_id":"","url":"https://api.github.com/users/andruhon","html_url":"https://github.com/andruhon","followers_url":"https://api.github.com/users/andruhon/followers","following_url":"https://api.github.com/users/andruhon/following{/other_user}","gists_url":"https://api.github.com/users/andruhon/gists{/gist_id}","starred_url":"https://api.github.com/users/andruhon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andruhon/subscriptions","organizations_url":"https://api.github.com/users/andruhon/orgs","repos_url":"https://api.github.com/users/andruhon/repos","events_url":"https://api.github.com/users/andruhon/events{/privacy}","received_events_url":"https://api.github.com/users/andruhon/received_events","type":"User","site_admin":false},"body":"Demo to reproduce the issue https://github.com/andruhon/wicket-modal-mousedown-issue\r\n\r\nDemo using 9.0.0-SNAPSHOT from maven local to demonstrate the fix:\r\nhttps://github.com/andruhon/wicket-modal-mousedown-issue/tree/fix-WICKET-5552","created_at":"2018-09-26T03:35:32Z","updated_at":"2018-09-26T04:59:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddd7ebe882bc25768c0ba09397a25b5b318d9070","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/wicket/pulls/294/commits","review_comments_url":"https://api.github.com/repos/apache/wicket/pulls/294/comments","review_comment_url":"https://api.github.com/repos/apache/wicket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/wicket/issues/294/comments","statuses_url":"https://api.github.com/repos/apache/wicket/statuses/ac9447692235035c4eec94280a72018a6b987190","head":{"label":"andruhon:WICKET-5552-fix-modal-mousedown-and-make-it-more-extendable","ref":"WICKET-5552-fix-modal-mousedown-and-make-it-more-extendable","sha":"ac9447692235035c4eec94280a72018a6b987190","user":{"login":"andruhon","id":1694497,"node_id":"MDQ6VXNlcjE2OTQ0OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1694497?v=4","gravatar_id":"","url":"https://api.github.com/users/andruhon","html_url":"https://github.com/andruhon","followers_url":"https://api.github.com/users/andruhon/followers","following_url":"https://api.github.com/users/andruhon/following{/other_user}","gists_url":"https://api.github.com/users/andruhon/gists{/gist_id}","starred_url":"https://api.github.com/users/andruhon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andruhon/subscriptions","organizations_url":"https://api.github.com/users/andruhon/orgs","repos_url":"https://api.github.com/users/andruhon/repos","events_url":"https://api.github.com/users/andruhon/events{/privacy}","received_events_url":"https://api.github.com/users/andruhon/received_events","type":"User","site_admin":false},"repo":{"id":147263990,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcyNjM5OTA=","name":"wicket","full_name":"andruhon/wicket","private":false,"owner":{"login":"andruhon","id":1694497,"node_id":"MDQ6VXNlcjE2OTQ0OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1694497?v=4","gravatar_id":"","url":"https://api.github.com/users/andruhon","html_url":"https://github.com/andruhon","followers_url":"https://api.github.com/users/andruhon/followers","following_url":"https://api.github.com/users/andruhon/following{/other_user}","gists_url":"https://api.github.com/users/andruhon/gists{/gist_id}","starred_url":"https://api.github.com/users/andruhon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andruhon/subscriptions","organizations_url":"https://api.github.com/users/andruhon/orgs","repos_url":"https://api.github.com/users/andruhon/repos","events_url":"https://api.github.com/users/andruhon/events{/privacy}","received_events_url":"https://api.github.com/users/andruhon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andruhon/wicket","description":"Mirror of Apache Wicket","fork":true,"url":"https://api.github.com/repos/andruhon/wicket","forks_url":"https://api.github.com/repos/andruhon/wicket/forks","keys_url":"https://api.github.com/repos/andruhon/wicket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andruhon/wicket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andruhon/wicket/teams","hooks_url":"https://api.github.com/repos/andruhon/wicket/hooks","issue_events_url":"https://api.github.com/repos/andruhon/wicket/issues/events{/number}","events_url":"https://api.github.com/repos/andruhon/wicket/events","assignees_url":"https://api.github.com/repos/andruhon/wicket/assignees{/user}","branches_url":"https://api.github.com/repos/andruhon/wicket/branches{/branch}","tags_url":"https://api.github.com/repos/andruhon/wicket/tags","blobs_url":"https://api.github.com/repos/andruhon/wicket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andruhon/wicket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andruhon/wicket/git/refs{/sha}","trees_url":"https://api.github.com/repos/andruhon/wicket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andruhon/wicket/statuses/{sha}","languages_url":"https://api.github.com/repos/andruhon/wicket/languages","stargazers_url":"https://api.github.com/repos/andruhon/wicket/stargazers","contributors_url":"https://api.github.com/repos/andruhon/wicket/contributors","subscribers_url":"https://api.github.com/repos/andruhon/wicket/subscribers","subscription_url":"https://api.github.com/repos/andruhon/wicket/subscription","commits_url":"https://api.github.com/repos/andruhon/wicket/commits{/sha}","git_commits_url":"https://api.github.com/repos/andruhon/wicket/git/commits{/sha}","comments_url":"https://api.github.com/repos/andruhon/wicket/comments{/number}","issue_comment_url":"https://api.github.com/repos/andruhon/wicket/issues/comments{/number}","contents_url":"https://api.github.com/repos/andruhon/wicket/contents/{+path}","compare_url":"https://api.github.com/repos/andruhon/wicket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andruhon/wicket/merges","archive_url":"https://api.github.com/repos/andruhon/wicket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andruhon/wicket/downloads","issues_url":"https://api.github.com/repos/andruhon/wicket/issues{/number}","pulls_url":"https://api.github.com/repos/andruhon/wicket/pulls{/number}","milestones_url":"https://api.github.com/repos/andruhon/wicket/milestones{/number}","notifications_url":"https://api.github.com/repos/andruhon/wicket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andruhon/wicket/labels{/name}","releases_url":"https://api.github.com/repos/andruhon/wicket/releases{/id}","deployments_url":"https://api.github.com/repos/andruhon/wicket/deployments","created_at":"2018-09-03T23:44:45Z","updated_at":"2018-09-03T23:45:00Z","pushed_at":"2018-09-26T03:39:49Z","git_url":"git://github.com/andruhon/wicket.git","ssh_url":"git@github.com:andruhon/wicket.git","clone_url":"https://github.com/andruhon/wicket.git","svn_url":"https://github.com/andruhon/wicket","homepage":null,"size":122002,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"584b7f6a20aa1ac2aaa3751c3e45283f481d1bcf","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":206412,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY0MTI=","name":"wicket","full_name":"apache/wicket","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/wicket","description":"Mirror of Apache Wicket","fork":false,"url":"https://api.github.com/repos/apache/wicket","forks_url":"https://api.github.com/repos/apache/wicket/forks","keys_url":"https://api.github.com/repos/apache/wicket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/wicket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/wicket/teams","hooks_url":"https://api.github.com/repos/apache/wicket/hooks","issue_events_url":"https://api.github.com/repos/apache/wicket/issues/events{/number}","events_url":"https://api.github.com/repos/apache/wicket/events","assignees_url":"https://api.github.com/repos/apache/wicket/assignees{/user}","branches_url":"https://api.github.com/repos/apache/wicket/branches{/branch}","tags_url":"https://api.github.com/repos/apache/wicket/tags","blobs_url":"https://api.github.com/repos/apache/wicket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/wicket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/wicket/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/wicket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/wicket/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/wicket/languages","stargazers_url":"https://api.github.com/repos/apache/wicket/stargazers","contributors_url":"https://api.github.com/repos/apache/wicket/contributors","subscribers_url":"https://api.github.com/repos/apache/wicket/subscribers","subscription_url":"https://api.github.com/repos/apache/wicket/subscription","commits_url":"https://api.github.com/repos/apache/wicket/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/wicket/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/wicket/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/wicket/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/wicket/contents/{+path}","compare_url":"https://api.github.com/repos/apache/wicket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/wicket/merges","archive_url":"https://api.github.com/repos/apache/wicket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/wicket/downloads","issues_url":"https://api.github.com/repos/apache/wicket/issues{/number}","pulls_url":"https://api.github.com/repos/apache/wicket/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/wicket/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/wicket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/wicket/labels{/name}","releases_url":"https://api.github.com/repos/apache/wicket/releases{/id}","deployments_url":"https://api.github.com/repos/apache/wicket/deployments","created_at":"2009-05-21T01:51:51Z","updated_at":"2018-09-25T17:12:27Z","pushed_at":"2018-09-26T03:39:51Z","git_url":"git://github.com/apache/wicket.git","ssh_url":"git@github.com:apache/wicket.git","clone_url":"https://github.com/apache/wicket.git","svn_url":"https://github.com/apache/wicket","homepage":null,"size":122162,"stargazers_count":440,"watchers_count":440,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":311,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":311,"open_issues":14,"watchers":440,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/wicket/pulls/294"},"html":{"href":"https://github.com/apache/wicket/pull/294"},"issue":{"href":"https://api.github.com/repos/apache/wicket/issues/294"},"comments":{"href":"https://api.github.com/repos/apache/wicket/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/wicket/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/wicket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/wicket/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/apache/wicket/statuses/ac9447692235035c4eec94280a72018a6b987190"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"solomax"}}