{"action":"created","issue":{"url":"https://api.github.com/repos/ScorexFoundation/Scorex/issues/197","repository_url":"https://api.github.com/repos/ScorexFoundation/Scorex","labels_url":"https://api.github.com/repos/ScorexFoundation/Scorex/issues/197/labels{/name}","comments_url":"https://api.github.com/repos/ScorexFoundation/Scorex/issues/197/comments","events_url":"https://api.github.com/repos/ScorexFoundation/Scorex/issues/197/events","html_url":"https://github.com/ScorexFoundation/Scorex/issues/197","id":301662076,"number":197,"title":"Replace Enumerations by Case Objects","user":{"login":"ceilican","id":1809436,"avatar_url":"https://avatars1.githubusercontent.com/u/1809436?v=4","gravatar_id":"","url":"https://api.github.com/users/ceilican","html_url":"https://github.com/ceilican","followers_url":"https://api.github.com/users/ceilican/followers","following_url":"https://api.github.com/users/ceilican/following{/other_user}","gists_url":"https://api.github.com/users/ceilican/gists{/gist_id}","starred_url":"https://api.github.com/users/ceilican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceilican/subscriptions","organizations_url":"https://api.github.com/users/ceilican/orgs","repos_url":"https://api.github.com/users/ceilican/repos","events_url":"https://api.github.com/users/ceilican/events{/privacy}","received_events_url":"https://api.github.com/users/ceilican/received_events","type":"User","site_admin":false},"labels":[{"id":399711535,"url":"https://api.github.com/repos/ScorexFoundation/Scorex/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-02T05:59:17Z","updated_at":"2018-03-13T23:42:08Z","closed_at":null,"author_association":"COLLABORATOR","body":"Scorex has 4 Enumeration objects: `CommunicationState`, `EventType`, `ModifiersSemanticValidity` and `HistoryComparisonResult`. I think it would be more elegant to implement them with case objects instead. Like this:\r\n\r\nInstead of:\r\n\r\n```\r\n  object EventType extends Enumeration {\r\n    val Handshaked: EventType.Value = Value(1)\r\n    val Disconnected: EventType.Value = Value(2)\r\n  }\r\n```\r\n\r\nWe would do:\r\n\r\n```\r\nsealed trait EventType\r\ncase object Handshaked extends EventType\r\ncase object Disconnected extends EventType\r\n```\r\n\r\n@kushti: what do you think?\r\n"},"comment":{"url":"https://api.github.com/repos/ScorexFoundation/Scorex/issues/comments/372856290","html_url":"https://github.com/ScorexFoundation/Scorex/issues/197#issuecomment-372856290","issue_url":"https://api.github.com/repos/ScorexFoundation/Scorex/issues/197","id":372856290,"user":{"login":"ceilican","id":1809436,"avatar_url":"https://avatars1.githubusercontent.com/u/1809436?v=4","gravatar_id":"","url":"https://api.github.com/users/ceilican","html_url":"https://github.com/ceilican","followers_url":"https://api.github.com/users/ceilican/followers","following_url":"https://api.github.com/users/ceilican/following{/other_user}","gists_url":"https://api.github.com/users/ceilican/gists{/gist_id}","starred_url":"https://api.github.com/users/ceilican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceilican/subscriptions","organizations_url":"https://api.github.com/users/ceilican/orgs","repos_url":"https://api.github.com/users/ceilican/repos","events_url":"https://api.github.com/users/ceilican/events{/privacy}","received_events_url":"https://api.github.com/users/ceilican/received_events","type":"User","site_admin":false},"created_at":"2018-03-13T23:42:08Z","updated_at":"2018-03-13T23:42:08Z","author_association":"COLLABORATOR","body":"@EzequielPostan , I have already done most of it in #203 .  There is only one enumeration remaining, but it would be useful to decide what to do with #202 before eliminating it."}}
{"actor":{"display_login":"ceilican"}}