{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/191552219","pull_request_review_id":124146704,"id":191552219,"diff_hunk":"@@ -30,13 +30,14 @@\n import re  # do not remove, used in imported file.py functions\n import string  # do not remove, used in imported file.py functions\n import sys  # do not remove, used in imported file.py functions\n-import io  # do not remove, used in imported file.py functions\n+import fileinput  # do not remove, used in imported file.py functions","path":"salt/modules/win_file.py","position":5,"original_position":5,"commit_id":"1522f5e0e29f533577e9820c6881e27face5607f","original_commit_id":"1522f5e0e29f533577e9820c6881e27face5607f","user":{"login":"twangboy","id":9383935,"avatar_url":"https://avatars3.githubusercontent.com/u/9383935?v=4","gravatar_id":"","url":"https://api.github.com/users/twangboy","html_url":"https://github.com/twangboy","followers_url":"https://api.github.com/users/twangboy/followers","following_url":"https://api.github.com/users/twangboy/following{/other_user}","gists_url":"https://api.github.com/users/twangboy/gists{/gist_id}","starred_url":"https://api.github.com/users/twangboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twangboy/subscriptions","organizations_url":"https://api.github.com/users/twangboy/orgs","repos_url":"https://api.github.com/users/twangboy/repos","events_url":"https://api.github.com/users/twangboy/events{/privacy}","received_events_url":"https://api.github.com/users/twangboy/received_events","type":"User","site_admin":false},"body":"Please add back `import io`","created_at":"2018-05-29T19:52:13Z","updated_at":"2018-05-29T19:52:24Z","html_url":"https://github.com/saltstack/salt/pull/47876#discussion_r191552219","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/47876","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/191552219"},"html":{"href":"https://github.com/saltstack/salt/pull/47876#discussion_r191552219"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47876"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/47876","id":191248311,"html_url":"https://github.com/saltstack/salt/pull/47876","diff_url":"https://github.com/saltstack/salt/pull/47876.diff","patch_url":"https://github.com/saltstack/salt/pull/47876.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/47876","number":47876,"state":"open","locked":false,"title":"Add file read windows","user":{"login":"doesitblend","id":31517589,"avatar_url":"https://avatars1.githubusercontent.com/u/31517589?v=4","gravatar_id":"","url":"https://api.github.com/users/doesitblend","html_url":"https://github.com/doesitblend","followers_url":"https://api.github.com/users/doesitblend/followers","following_url":"https://api.github.com/users/doesitblend/following{/other_user}","gists_url":"https://api.github.com/users/doesitblend/gists{/gist_id}","starred_url":"https://api.github.com/users/doesitblend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doesitblend/subscriptions","organizations_url":"https://api.github.com/users/doesitblend/orgs","repos_url":"https://api.github.com/users/doesitblend/repos","events_url":"https://api.github.com/users/doesitblend/events{/privacy}","received_events_url":"https://api.github.com/users/doesitblend/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nAdds the `file.read` function to the `win_file.py` module\r\n\r\n### Related Issue\r\nhttps://github.com/saltstack/salt/issues/45520\r\n\r\n### Previous Behavior\r\n```\r\n[root@localhost]# salt '*' file.read \"C:\\\\salt\\\\conf\\\\minion\"\r\nwin2016-2:\r\n    ----------\r\n    file.read:\r\n        'file.read' is not available.\r\n```\r\n### New Behavior\r\n```\r\n[root@localhost _modules]# salt '*' myfile.read \"C:\\\\salt\\\\conf\\\\minion\"\r\nwin2016-2:\r\n    master: 192.168.60.10\r\n    log_level_logfile: debug\r\n    startup_states: highstate\r\n```\r\n\r\n### Tests written?\r\n\r\nNo\r\n\r\n### Commits signed with GPG?\r\n\r\nNo\r\n","created_at":"2018-05-29T19:35:04Z","updated_at":"2018-05-29T19:52:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6682eb742d90f606c7f9831999ecc5726eb916c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/47876/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/47876/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/47876/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/1522f5e0e29f533577e9820c6881e27face5607f","head":{"label":"doesitblend:add-file-read-windows","ref":"add-file-read-windows","sha":"1522f5e0e29f533577e9820c6881e27face5607f","user":{"login":"doesitblend","id":31517589,"avatar_url":"https://avatars1.githubusercontent.com/u/31517589?v=4","gravatar_id":"","url":"https://api.github.com/users/doesitblend","html_url":"https://github.com/doesitblend","followers_url":"https://api.github.com/users/doesitblend/followers","following_url":"https://api.github.com/users/doesitblend/following{/other_user}","gists_url":"https://api.github.com/users/doesitblend/gists{/gist_id}","starred_url":"https://api.github.com/users/doesitblend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doesitblend/subscriptions","organizations_url":"https://api.github.com/users/doesitblend/orgs","repos_url":"https://api.github.com/users/doesitblend/repos","events_url":"https://api.github.com/users/doesitblend/events{/privacy}","received_events_url":"https://api.github.com/users/doesitblend/received_events","type":"User","site_admin":false},"repo":{"id":102151996,"name":"salt","full_name":"doesitblend/salt","owner":{"login":"doesitblend","id":31517589,"avatar_url":"https://avatars1.githubusercontent.com/u/31517589?v=4","gravatar_id":"","url":"https://api.github.com/users/doesitblend","html_url":"https://github.com/doesitblend","followers_url":"https://api.github.com/users/doesitblend/followers","following_url":"https://api.github.com/users/doesitblend/following{/other_user}","gists_url":"https://api.github.com/users/doesitblend/gists{/gist_id}","starred_url":"https://api.github.com/users/doesitblend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doesitblend/subscriptions","organizations_url":"https://api.github.com/users/doesitblend/orgs","repos_url":"https://api.github.com/users/doesitblend/repos","events_url":"https://api.github.com/users/doesitblend/events{/privacy}","received_events_url":"https://api.github.com/users/doesitblend/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/doesitblend/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":true,"url":"https://api.github.com/repos/doesitblend/salt","forks_url":"https://api.github.com/repos/doesitblend/salt/forks","keys_url":"https://api.github.com/repos/doesitblend/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doesitblend/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doesitblend/salt/teams","hooks_url":"https://api.github.com/repos/doesitblend/salt/hooks","issue_events_url":"https://api.github.com/repos/doesitblend/salt/issues/events{/number}","events_url":"https://api.github.com/repos/doesitblend/salt/events","assignees_url":"https://api.github.com/repos/doesitblend/salt/assignees{/user}","branches_url":"https://api.github.com/repos/doesitblend/salt/branches{/branch}","tags_url":"https://api.github.com/repos/doesitblend/salt/tags","blobs_url":"https://api.github.com/repos/doesitblend/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doesitblend/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doesitblend/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/doesitblend/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doesitblend/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/doesitblend/salt/languages","stargazers_url":"https://api.github.com/repos/doesitblend/salt/stargazers","contributors_url":"https://api.github.com/repos/doesitblend/salt/contributors","subscribers_url":"https://api.github.com/repos/doesitblend/salt/subscribers","subscription_url":"https://api.github.com/repos/doesitblend/salt/subscription","commits_url":"https://api.github.com/repos/doesitblend/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/doesitblend/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/doesitblend/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/doesitblend/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/doesitblend/salt/contents/{+path}","compare_url":"https://api.github.com/repos/doesitblend/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doesitblend/salt/merges","archive_url":"https://api.github.com/repos/doesitblend/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doesitblend/salt/downloads","issues_url":"https://api.github.com/repos/doesitblend/salt/issues{/number}","pulls_url":"https://api.github.com/repos/doesitblend/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/doesitblend/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/doesitblend/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doesitblend/salt/labels{/name}","releases_url":"https://api.github.com/repos/doesitblend/salt/releases{/id}","deployments_url":"https://api.github.com/repos/doesitblend/salt/deployments","created_at":"2017-09-01T20:49:29Z","updated_at":"2017-09-01T20:49:47Z","pushed_at":"2018-05-29T19:30:53Z","git_url":"git://github.com/doesitblend/salt.git","ssh_url":"git@github.com:doesitblend/salt.git","clone_url":"https://github.com/doesitblend/salt.git","svn_url":"https://github.com/doesitblend/salt","homepage":"https://repo.saltstack.com/","size":175222,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:2018.3","ref":"2018.3","sha":"61561a8279b7b153a5ee38de90c0eafe6ef9db03","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2018-05-29T19:27:05Z","pushed_at":"2018-05-29T19:45:44Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":403660,"stargazers_count":8884,"watchers_count":8884,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4169,"mirror_url":null,"archived":false,"open_issues_count":3352,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4169,"open_issues":3352,"watchers":8884,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47876"},"html":{"href":"https://github.com/saltstack/salt/pull/47876"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/47876"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/47876/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47876/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47876/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/1522f5e0e29f533577e9820c6881e27face5607f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"twangboy"}}