{"action":"created","issue":{"url":"https://api.github.com/repos/fszlin/certes/issues/175","repository_url":"https://api.github.com/repos/fszlin/certes","labels_url":"https://api.github.com/repos/fszlin/certes/issues/175/labels{/name}","comments_url":"https://api.github.com/repos/fszlin/certes/issues/175/comments","events_url":"https://api.github.com/repos/fszlin/certes/issues/175/events","html_url":"https://github.com/fszlin/certes/pull/175","id":390703028,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDA4NzUz","number":175,"title":"Fix json order being ignored due to custom ContractResolver","user":{"login":"webprofusion-chrisc","id":2445502,"node_id":"MDQ6VXNlcjI0NDU1MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/2445502?v=4","gravatar_id":"","url":"https://api.github.com/users/webprofusion-chrisc","html_url":"https://github.com/webprofusion-chrisc","followers_url":"https://api.github.com/users/webprofusion-chrisc/followers","following_url":"https://api.github.com/users/webprofusion-chrisc/following{/other_user}","gists_url":"https://api.github.com/users/webprofusion-chrisc/gists{/gist_id}","starred_url":"https://api.github.com/users/webprofusion-chrisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webprofusion-chrisc/subscriptions","organizations_url":"https://api.github.com/users/webprofusion-chrisc/orgs","repos_url":"https://api.github.com/users/webprofusion-chrisc/repos","events_url":"https://api.github.com/users/webprofusion-chrisc/events{/privacy}","received_events_url":"https://api.github.com/users/webprofusion-chrisc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-13T14:27:46Z","updated_at":"2018-12-14T08:31:55Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/fszlin/certes/pulls/175","html_url":"https://github.com/fszlin/certes/pull/175","diff_url":"https://github.com/fszlin/certes/pull/175.diff","patch_url":"https://github.com/fszlin/certes/pull/175.patch"},"body":"## Description\r\n\r\nIn some regions (such as Latvian) the default sort order of reflected properties are different while serializing to JSON. PR #174 partly addressed this order issue for account key serialization but neglected to test the custom JsonSerializerSettings used when actually creating key Thumbprints, which in turn overrides the ContractResolver and ignores the explicit json property order attribute in the JsonWebKey objects. This change ~~removes~~ replaces the custom ContractResolver (so that the default will be used, with added camelCasing as the default).\r\n\r\n## Checklist\r\n\r\n- [X] All tests are passing\r\n- [X] New tests were created to address changes in pr (and tests are passing)\r\n- [X] Updated README and/or documentation, if necessary\r\n"},"comment":{"url":"https://api.github.com/repos/fszlin/certes/issues/comments/447253206","html_url":"https://github.com/fszlin/certes/pull/175#issuecomment-447253206","issue_url":"https://api.github.com/repos/fszlin/certes/issues/175","id":447253206,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzI1MzIwNg==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-12-14T08:31:55Z","updated_at":"2018-12-14T08:31:55Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/fszlin/certes/pull/175?src=pr&el=h1) Report\n> Merging [#175](https://codecov.io/gh/fszlin/certes/pull/175?src=pr&el=desc) into [master](https://codecov.io/gh/fszlin/certes/commit/7f6eae653a911b8a1984c5ef895912b16c346628?src=pr&el=desc) will **decrease** coverage by `0.12%`.\n> The diff coverage is `100%`.\n\n\n```diff\n@@            Coverage Diff             @@\n##           master     #175      +/-   ##\n==========================================\n- Coverage   95.22%   95.09%   -0.13%     \n==========================================\n  Files         103      103              \n  Lines        2344     2346       +2     \n  Branches      256      256              \n==========================================\n- Hits         2232     2231       -1     \n- Misses         57       60       +3     \n  Partials       55       55\n```\n"}}
{"actor":{"display_login":"codecov"}}