{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/cluster-machine-approver/pulls/comments/243133661","pull_request_review_id":186820909,"id":243133661,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzEzMzY2MQ==","diff_hunk":"@@ -0,0 +1,34 @@\n+apiVersion: rbac.authorization.k8s.io/v1\n+kind: Role\n+metadata:\n+  name: machine-approver\n+  namespace: openshift-cluster-machine-approver\n+rules:\n+- apiGroups:\n+  - \"\"\n+  resources:\n+  - pods","path":"manifests/0000_51_machine-approver-04-role.yaml","position":10,"original_position":10,"commit_id":"53f034311714027af1deb00e2a78082da7ca0af0","original_commit_id":"8a9c55b2fe4ca9b4ce878c688a8ad5133718ed50","user":{"login":"enj","id":7001223,"node_id":"MDQ6VXNlcjcwMDEyMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/7001223?v=4","gravatar_id":"","url":"https://api.github.com/users/enj","html_url":"https://github.com/enj","followers_url":"https://api.github.com/users/enj/followers","following_url":"https://api.github.com/users/enj/following{/other_user}","gists_url":"https://api.github.com/users/enj/gists{/gist_id}","starred_url":"https://api.github.com/users/enj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enj/subscriptions","organizations_url":"https://api.github.com/users/enj/orgs","repos_url":"https://api.github.com/users/enj/repos","events_url":"https://api.github.com/users/enj/events{/privacy}","received_events_url":"https://api.github.com/users/enj/received_events","type":"User","site_admin":false},"body":"Are all these required because of the controller command's default behavior?","created_at":"2018-12-20T01:41:48Z","updated_at":"2018-12-20T01:41:48Z","html_url":"https://github.com/openshift/cluster-machine-approver/pull/8#discussion_r243133661","pull_request_url":"https://api.github.com/repos/openshift/cluster-machine-approver/pulls/8","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-machine-approver/pulls/comments/243133661"},"html":{"href":"https://github.com/openshift/cluster-machine-approver/pull/8#discussion_r243133661"},"pull_request":{"href":"https://api.github.com/repos/openshift/cluster-machine-approver/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/cluster-machine-approver/pulls/8","id":239869295,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODY5Mjk1","html_url":"https://github.com/openshift/cluster-machine-approver/pull/8","diff_url":"https://github.com/openshift/cluster-machine-approver/pull/8.diff","patch_url":"https://github.com/openshift/cluster-machine-approver/pull/8.patch","issue_url":"https://api.github.com/repos/openshift/cluster-machine-approver/issues/8","number":8,"state":"open","locked":false,"title":"Operator restructure","user":{"login":"mrogers950","id":3697177,"node_id":"MDQ6VXNlcjM2OTcxNzc=","avatar_url":"https://avatars3.githubusercontent.com/u/3697177?v=4","gravatar_id":"","url":"https://api.github.com/users/mrogers950","html_url":"https://github.com/mrogers950","followers_url":"https://api.github.com/users/mrogers950/followers","following_url":"https://api.github.com/users/mrogers950/following{/other_user}","gists_url":"https://api.github.com/users/mrogers950/gists{/gist_id}","starred_url":"https://api.github.com/users/mrogers950/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrogers950/subscriptions","organizations_url":"https://api.github.com/users/mrogers950/orgs","repos_url":"https://api.github.com/users/mrogers950/repos","events_url":"https://api.github.com/users/mrogers950/events{/privacy}","received_events_url":"https://api.github.com/users/mrogers950/received_events","type":"User","site_admin":false},"body":"Use the cluster-osin-operator repo layout and boilerplate (with minor modifications).\r\n@openshift/sig-auth ","created_at":"2018-12-19T15:09:30Z","updated_at":"2018-12-20T01:41:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a82d15f61ce9e502af19408237c3f74a8f335ef4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sjenning","id":493891,"node_id":"MDQ6VXNlcjQ5Mzg5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/493891?v=4","gravatar_id":"","url":"https://api.github.com/users/sjenning","html_url":"https://github.com/sjenning","followers_url":"https://api.github.com/users/sjenning/followers","following_url":"https://api.github.com/users/sjenning/following{/other_user}","gists_url":"https://api.github.com/users/sjenning/gists{/gist_id}","starred_url":"https://api.github.com/users/sjenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjenning/subscriptions","organizations_url":"https://api.github.com/users/sjenning/orgs","repos_url":"https://api.github.com/users/sjenning/repos","events_url":"https://api.github.com/users/sjenning/events{/privacy}","received_events_url":"https://api.github.com/users/sjenning/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1129196663,"node_id":"MDU6TGFiZWwxMTI5MTk2NjYz","url":"https://api.github.com/repos/openshift/cluster-machine-approver/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1129199762,"node_id":"MDU6TGFiZWwxMTI5MTk5NzYy","url":"https://api.github.com/repos/openshift/cluster-machine-approver/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/cluster-machine-approver/pulls/8/commits","review_comments_url":"https://api.github.com/repos/openshift/cluster-machine-approver/pulls/8/comments","review_comment_url":"https://api.github.com/repos/openshift/cluster-machine-approver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/cluster-machine-approver/issues/8/comments","statuses_url":"https://api.github.com/repos/openshift/cluster-machine-approver/statuses/53f034311714027af1deb00e2a78082da7ca0af0","head":{"label":"mrogers950:refactor","ref":"refactor","sha":"53f034311714027af1deb00e2a78082da7ca0af0","user":{"login":"mrogers950","id":3697177,"node_id":"MDQ6VXNlcjM2OTcxNzc=","avatar_url":"https://avatars3.githubusercontent.com/u/3697177?v=4","gravatar_id":"","url":"https://api.github.com/users/mrogers950","html_url":"https://github.com/mrogers950","followers_url":"https://api.github.com/users/mrogers950/followers","following_url":"https://api.github.com/users/mrogers950/following{/other_user}","gists_url":"https://api.github.com/users/mrogers950/gists{/gist_id}","starred_url":"https://api.github.com/users/mrogers950/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrogers950/subscriptions","organizations_url":"https://api.github.com/users/mrogers950/orgs","repos_url":"https://api.github.com/users/mrogers950/repos","events_url":"https://api.github.com/users/mrogers950/events{/privacy}","received_events_url":"https://api.github.com/users/mrogers950/received_events","type":"User","site_admin":false},"repo":{"id":162156315,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIxNTYzMTU=","name":"cluster-machine-approver","full_name":"mrogers950/cluster-machine-approver","private":false,"owner":{"login":"mrogers950","id":3697177,"node_id":"MDQ6VXNlcjM2OTcxNzc=","avatar_url":"https://avatars3.githubusercontent.com/u/3697177?v=4","gravatar_id":"","url":"https://api.github.com/users/mrogers950","html_url":"https://github.com/mrogers950","followers_url":"https://api.github.com/users/mrogers950/followers","following_url":"https://api.github.com/users/mrogers950/following{/other_user}","gists_url":"https://api.github.com/users/mrogers950/gists{/gist_id}","starred_url":"https://api.github.com/users/mrogers950/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrogers950/subscriptions","organizations_url":"https://api.github.com/users/mrogers950/orgs","repos_url":"https://api.github.com/users/mrogers950/repos","events_url":"https://api.github.com/users/mrogers950/events{/privacy}","received_events_url":"https://api.github.com/users/mrogers950/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mrogers950/cluster-machine-approver","description":"The cluster-machine-approver validates and approves CSRs for nodes attempting to join the cluster.","fork":true,"url":"https://api.github.com/repos/mrogers950/cluster-machine-approver","forks_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/forks","keys_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/teams","hooks_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/hooks","issue_events_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/issues/events{/number}","events_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/events","assignees_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/assignees{/user}","branches_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/branches{/branch}","tags_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/tags","blobs_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/statuses/{sha}","languages_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/languages","stargazers_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/stargazers","contributors_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/contributors","subscribers_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/subscribers","subscription_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/subscription","commits_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/contents/{+path}","compare_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/merges","archive_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/downloads","issues_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/issues{/number}","pulls_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/pulls{/number}","milestones_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/milestones{/number}","notifications_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/labels{/name}","releases_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/releases{/id}","deployments_url":"https://api.github.com/repos/mrogers950/cluster-machine-approver/deployments","created_at":"2018-12-17T16:04:41Z","updated_at":"2018-12-17T16:04:44Z","pushed_at":"2018-12-19T22:51:02Z","git_url":"git://github.com/mrogers950/cluster-machine-approver.git","ssh_url":"git@github.com:mrogers950/cluster-machine-approver.git","clone_url":"https://github.com/mrogers950/cluster-machine-approver.git","svn_url":"https://github.com/mrogers950/cluster-machine-approver","homepage":null,"size":18824,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"17a9b3eb1da3b5db69dbb2ce6528c59bc2df5aa1","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":157590985,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc1OTA5ODU=","name":"cluster-machine-approver","full_name":"openshift/cluster-machine-approver","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/cluster-machine-approver","description":"The cluster-machine-approver validates and approves CSRs for nodes attempting to join the cluster.","fork":false,"url":"https://api.github.com/repos/openshift/cluster-machine-approver","forks_url":"https://api.github.com/repos/openshift/cluster-machine-approver/forks","keys_url":"https://api.github.com/repos/openshift/cluster-machine-approver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/cluster-machine-approver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/cluster-machine-approver/teams","hooks_url":"https://api.github.com/repos/openshift/cluster-machine-approver/hooks","issue_events_url":"https://api.github.com/repos/openshift/cluster-machine-approver/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/cluster-machine-approver/events","assignees_url":"https://api.github.com/repos/openshift/cluster-machine-approver/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/cluster-machine-approver/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/cluster-machine-approver/tags","blobs_url":"https://api.github.com/repos/openshift/cluster-machine-approver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/cluster-machine-approver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/cluster-machine-approver/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/cluster-machine-approver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/cluster-machine-approver/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/cluster-machine-approver/languages","stargazers_url":"https://api.github.com/repos/openshift/cluster-machine-approver/stargazers","contributors_url":"https://api.github.com/repos/openshift/cluster-machine-approver/contributors","subscribers_url":"https://api.github.com/repos/openshift/cluster-machine-approver/subscribers","subscription_url":"https://api.github.com/repos/openshift/cluster-machine-approver/subscription","commits_url":"https://api.github.com/repos/openshift/cluster-machine-approver/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/cluster-machine-approver/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/cluster-machine-approver/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/cluster-machine-approver/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/cluster-machine-approver/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/cluster-machine-approver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/cluster-machine-approver/merges","archive_url":"https://api.github.com/repos/openshift/cluster-machine-approver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/cluster-machine-approver/downloads","issues_url":"https://api.github.com/repos/openshift/cluster-machine-approver/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/cluster-machine-approver/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/cluster-machine-approver/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/cluster-machine-approver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/cluster-machine-approver/labels{/name}","releases_url":"https://api.github.com/repos/openshift/cluster-machine-approver/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/cluster-machine-approver/deployments","created_at":"2018-11-14T18:12:50Z","updated_at":"2018-11-27T18:00:45Z","pushed_at":"2018-12-19T22:51:04Z","git_url":"git://github.com/openshift/cluster-machine-approver.git","ssh_url":"git@github.com:openshift/cluster-machine-approver.git","clone_url":"https://github.com/openshift/cluster-machine-approver.git","svn_url":"https://github.com/openshift/cluster-machine-approver","homepage":null,"size":11849,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-machine-approver/pulls/8"},"html":{"href":"https://github.com/openshift/cluster-machine-approver/pull/8"},"issue":{"href":"https://api.github.com/repos/openshift/cluster-machine-approver/issues/8"},"comments":{"href":"https://api.github.com/repos/openshift/cluster-machine-approver/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/cluster-machine-approver/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/cluster-machine-approver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/cluster-machine-approver/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/cluster-machine-approver/statuses/53f034311714027af1deb00e2a78082da7ca0af0"}},"author_association":"NONE"}}
{"actor":{"display_login":"enj"}}