{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/pulls/comments/228552896","pull_request_review_id":168856903,"id":228552896,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODU1Mjg5Ng==","diff_hunk":"@@ -299,7 +299,7 @@ def awslogs_handler(event, context):\n                     structured_line = merge_dicts(log, {\"lambda\": {\"arn\": arn}})\n                     # 5. We add the function name as tag\n                     metadata[DD_CUSTOM_TAGS] = (\n-                        metadata[DD_CUSTOM_TAGS] + \",functionname:\" + functioname\n+                        metadata[DD_CUSTOM_TAGS] + \",functionname:\" + functioname.lower()","path":"aws/logs_monitoring/lambda_function.py","position":5,"original_position":5,"commit_id":"44d0f157993a87295865e02866d4825613ae4b91","original_commit_id":"44d0f157993a87295865e02866d4825613ae4b91","user":{"login":"achntrl","id":6985756,"node_id":"MDQ6VXNlcjY5ODU3NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6985756?v=4","gravatar_id":"","url":"https://api.github.com/users/achntrl","html_url":"https://github.com/achntrl","followers_url":"https://api.github.com/users/achntrl/followers","following_url":"https://api.github.com/users/achntrl/following{/other_user}","gists_url":"https://api.github.com/users/achntrl/gists{/gist_id}","starred_url":"https://api.github.com/users/achntrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achntrl/subscriptions","organizations_url":"https://api.github.com/users/achntrl/orgs","repos_url":"https://api.github.com/users/achntrl/repos","events_url":"https://api.github.com/users/achntrl/events{/privacy}","received_events_url":"https://api.github.com/users/achntrl/received_events","type":"User","site_admin":false},"body":"You might want to put at line 290\r\n\r\n```\r\nfunctioname = loggroupsplit[1].lower()\r\n```\r\n\r\nbecause `functioname` is used twice","created_at":"2018-10-26T14:42:11Z","updated_at":"2018-10-26T14:42:11Z","html_url":"https://github.com/DataDog/datadog-serverless-functions/pull/7#discussion_r228552896","pull_request_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/pulls/7","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-serverless-functions/pulls/comments/228552896"},"html":{"href":"https://github.com/DataDog/datadog-serverless-functions/pull/7#discussion_r228552896"},"pull_request":{"href":"https://api.github.com/repos/DataDog/datadog-serverless-functions/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/pulls/7","id":226042853,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDQyODUz","html_url":"https://github.com/DataDog/datadog-serverless-functions/pull/7","diff_url":"https://github.com/DataDog/datadog-serverless-functions/pull/7.diff","patch_url":"https://github.com/DataDog/datadog-serverless-functions/pull/7.patch","issue_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/issues/7","number":7,"state":"open","locked":false,"title":"Lowercase functionname tag","user":{"login":"NBParis","id":26930812,"node_id":"MDQ6VXNlcjI2OTMwODEy","avatar_url":"https://avatars1.githubusercontent.com/u/26930812?v=4","gravatar_id":"","url":"https://api.github.com/users/NBParis","html_url":"https://github.com/NBParis","followers_url":"https://api.github.com/users/NBParis/followers","following_url":"https://api.github.com/users/NBParis/following{/other_user}","gists_url":"https://api.github.com/users/NBParis/gists{/gist_id}","starred_url":"https://api.github.com/users/NBParis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NBParis/subscriptions","organizations_url":"https://api.github.com/users/NBParis/orgs","repos_url":"https://api.github.com/users/NBParis/repos","events_url":"https://api.github.com/users/NBParis/events{/privacy}","received_events_url":"https://api.github.com/users/NBParis/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nThe `functionname` tag that is set on metric is lowercase, so we need to do the same on the logs.\r\n\r\n### Motivation\r\n\r\nMaking sure that the link between logs and metrics can be easily done\r\n\r\n### Additional Notes\r\n\r\nAnything else we should know when reviewing?\r\n","created_at":"2018-10-26T10:03:46Z","updated_at":"2018-10-26T14:42:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"393ded426426b908249dd5e60c29b36180f890ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/pulls/7/commits","review_comments_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/pulls/7/comments","review_comment_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/issues/7/comments","statuses_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/statuses/44d0f157993a87295865e02866d4825613ae4b91","head":{"label":"DataDog:nils/log-lowercase-function-name","ref":"nils/log-lowercase-function-name","sha":"44d0f157993a87295865e02866d4825613ae4b91","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":154291566,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQyOTE1NjY=","name":"datadog-serverless-functions","full_name":"DataDog/datadog-serverless-functions","private":false,"owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataDog/datadog-serverless-functions","description":"Repo of serverless functions that process streams and send data to datadog","fork":false,"url":"https://api.github.com/repos/DataDog/datadog-serverless-functions","forks_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/deployments","created_at":"2018-10-23T08:30:16Z","updated_at":"2018-10-26T08:13:38Z","pushed_at":"2018-10-26T10:03:47Z","git_url":"git://github.com/DataDog/datadog-serverless-functions.git","ssh_url":"git@github.com:DataDog/datadog-serverless-functions.git","clone_url":"https://github.com/DataDog/datadog-serverless-functions.git","svn_url":"https://github.com/DataDog/datadog-serverless-functions","homepage":null,"size":146,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"d92f09533f7e3ac21e83af97d4afa83bd4ae4fcf","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":154291566,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQyOTE1NjY=","name":"datadog-serverless-functions","full_name":"DataDog/datadog-serverless-functions","private":false,"owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataDog/datadog-serverless-functions","description":"Repo of serverless functions that process streams and send data to datadog","fork":false,"url":"https://api.github.com/repos/DataDog/datadog-serverless-functions","forks_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-serverless-functions/deployments","created_at":"2018-10-23T08:30:16Z","updated_at":"2018-10-26T08:13:38Z","pushed_at":"2018-10-26T10:03:47Z","git_url":"git://github.com/DataDog/datadog-serverless-functions.git","ssh_url":"git@github.com:DataDog/datadog-serverless-functions.git","clone_url":"https://github.com/DataDog/datadog-serverless-functions.git","svn_url":"https://github.com/DataDog/datadog-serverless-functions","homepage":null,"size":146,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-serverless-functions/pulls/7"},"html":{"href":"https://github.com/DataDog/datadog-serverless-functions/pull/7"},"issue":{"href":"https://api.github.com/repos/DataDog/datadog-serverless-functions/issues/7"},"comments":{"href":"https://api.github.com/repos/DataDog/datadog-serverless-functions/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/datadog-serverless-functions/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/datadog-serverless-functions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/datadog-serverless-functions/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/datadog-serverless-functions/statuses/44d0f157993a87295865e02866d4825613ae4b91"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"achntrl"}}