{"action":"created","comment":{"url":"https://api.github.com/repos/improbable-research/keanu/pulls/comments/208311360","pull_request_review_id":144094878,"id":208311360,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODMxMTM2MA==","diff_hunk":"@@ -116,10 +123,10 @@ private double optimize(List<Vertex> outputVertices) {\n         bayesianNetwork.cascadeObservations();\n \n         FitnessFunctionWithGradient fitnessFunction = new FitnessFunctionWithGradient(\n-            outputVertices,\n+            Probabilistic.filter(outputVertices),","path":"keanu-project/src/main/java/io/improbable/keanu/algorithms/variational/optimizer/gradient/GradientOptimizer.java","position":34,"original_position":34,"commit_id":"8a8fc65dbe8c599aaca7e50310abc11b74a7a654","original_commit_id":"65122458e67d446eb476336db9f03ac016bb2d46","user":{"login":"migwellian","id":1508452,"node_id":"MDQ6VXNlcjE1MDg0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1508452?v=4","gravatar_id":"","url":"https://api.github.com/users/migwellian","html_url":"https://github.com/migwellian","followers_url":"https://api.github.com/users/migwellian/followers","following_url":"https://api.github.com/users/migwellian/following{/other_user}","gists_url":"https://api.github.com/users/migwellian/gists{/gist_id}","starred_url":"https://api.github.com/users/migwellian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/migwellian/subscriptions","organizations_url":"https://api.github.com/users/migwellian/orgs","repos_url":"https://api.github.com/users/migwellian/repos","events_url":"https://api.github.com/users/migwellian/events{/privacy}","received_events_url":"https://api.github.com/users/migwellian/received_events","type":"User","site_admin":false},"body":"Oh yeah, I forgot: In my previous PR I changed `Distribution.filter` to `Distribution.keepOnlyDifferentiableVertices` so I will similarly rename this one to `Probabilistic.keepOnlyProbabilisticVertices`","created_at":"2018-08-07T17:08:09Z","updated_at":"2018-08-07T17:08:09Z","html_url":"https://github.com/improbable-research/keanu/pull/153#discussion_r208311360","pull_request_url":"https://api.github.com/repos/improbable-research/keanu/pulls/153","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/comments/208311360"},"html":{"href":"https://github.com/improbable-research/keanu/pull/153#discussion_r208311360"},"pull_request":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/153"}},"in_reply_to_id":208195993},"pull_request":{"url":"https://api.github.com/repos/improbable-research/keanu/pulls/153","id":206076768,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDc2NzY4","html_url":"https://github.com/improbable-research/keanu/pull/153","diff_url":"https://github.com/improbable-research/keanu/pull/153.diff","patch_url":"https://github.com/improbable-research/keanu/pull/153.patch","issue_url":"https://api.github.com/repos/improbable-research/keanu/issues/153","number":153,"state":"open","locked":false,"title":"Feature/probabilistic","user":{"login":"migwellian","id":1508452,"node_id":"MDQ6VXNlcjE1MDg0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1508452?v=4","gravatar_id":"","url":"https://api.github.com/users/migwellian","html_url":"https://github.com/migwellian","followers_url":"https://api.github.com/users/migwellian/followers","following_url":"https://api.github.com/users/migwellian/following{/other_user}","gists_url":"https://api.github.com/users/migwellian/gists{/gist_id}","starred_url":"https://api.github.com/users/migwellian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/migwellian/subscriptions","organizations_url":"https://api.github.com/users/migwellian/orgs","repos_url":"https://api.github.com/users/migwellian/repos","events_url":"https://api.github.com/users/migwellian/events{/privacy}","received_events_url":"https://api.github.com/users/migwellian/received_events","type":"User","site_admin":false},"body":"* Created a `Probabilistic` interface, deleted the `Probabilistic*` and `NonProbabilistic*` abstract classes\r\n* pulled out an `Observable` interface, with the logic that Non-Probabilistic Integer or Double vertices are not observable\r\n* to calculate master P, you add all the Probabilistic vertices' logProbs, and early out (Negative Infinity) if any of the observed Non-Probabilistic vertices don't match their observation\r\n* also pulled out a ValueUpdater class, because the behaviour for updating one's value is common to all Probabilistic vertices\r\n* deleted the methods `logPdf` and `logPmf` - just always call it `logProb`","created_at":"2018-08-03T16:14:41Z","updated_at":"2018-08-07T17:08:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68b8768e5b6db0e5f28349c4ba7345b2ec152c4d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/improbable-research/keanu/pulls/153/commits","review_comments_url":"https://api.github.com/repos/improbable-research/keanu/pulls/153/comments","review_comment_url":"https://api.github.com/repos/improbable-research/keanu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/improbable-research/keanu/issues/153/comments","statuses_url":"https://api.github.com/repos/improbable-research/keanu/statuses/8a8fc65dbe8c599aaca7e50310abc11b74a7a654","head":{"label":"improbable-research:feature/probabilistic","ref":"feature/probabilistic","sha":"8a8fc65dbe8c599aaca7e50310abc11b74a7a654","user":{"login":"improbable-research","id":37903994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTAzOTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37903994?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-research","html_url":"https://github.com/improbable-research","followers_url":"https://api.github.com/users/improbable-research/followers","following_url":"https://api.github.com/users/improbable-research/following{/other_user}","gists_url":"https://api.github.com/users/improbable-research/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-research/subscriptions","organizations_url":"https://api.github.com/users/improbable-research/orgs","repos_url":"https://api.github.com/users/improbable-research/repos","events_url":"https://api.github.com/users/improbable-research/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-research/received_events","type":"Organization","site_admin":false},"repo":{"id":128393918,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgzOTM5MTg=","name":"keanu","full_name":"improbable-research/keanu","owner":{"login":"improbable-research","id":37903994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTAzOTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37903994?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-research","html_url":"https://github.com/improbable-research","followers_url":"https://api.github.com/users/improbable-research/followers","following_url":"https://api.github.com/users/improbable-research/following{/other_user}","gists_url":"https://api.github.com/users/improbable-research/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-research/subscriptions","organizations_url":"https://api.github.com/users/improbable-research/orgs","repos_url":"https://api.github.com/users/improbable-research/repos","events_url":"https://api.github.com/users/improbable-research/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-research/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/improbable-research/keanu","description":"A probabilistic approach from an Improbabilistic company","fork":false,"url":"https://api.github.com/repos/improbable-research/keanu","forks_url":"https://api.github.com/repos/improbable-research/keanu/forks","keys_url":"https://api.github.com/repos/improbable-research/keanu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/improbable-research/keanu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/improbable-research/keanu/teams","hooks_url":"https://api.github.com/repos/improbable-research/keanu/hooks","issue_events_url":"https://api.github.com/repos/improbable-research/keanu/issues/events{/number}","events_url":"https://api.github.com/repos/improbable-research/keanu/events","assignees_url":"https://api.github.com/repos/improbable-research/keanu/assignees{/user}","branches_url":"https://api.github.com/repos/improbable-research/keanu/branches{/branch}","tags_url":"https://api.github.com/repos/improbable-research/keanu/tags","blobs_url":"https://api.github.com/repos/improbable-research/keanu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/improbable-research/keanu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/improbable-research/keanu/git/refs{/sha}","trees_url":"https://api.github.com/repos/improbable-research/keanu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/improbable-research/keanu/statuses/{sha}","languages_url":"https://api.github.com/repos/improbable-research/keanu/languages","stargazers_url":"https://api.github.com/repos/improbable-research/keanu/stargazers","contributors_url":"https://api.github.com/repos/improbable-research/keanu/contributors","subscribers_url":"https://api.github.com/repos/improbable-research/keanu/subscribers","subscription_url":"https://api.github.com/repos/improbable-research/keanu/subscription","commits_url":"https://api.github.com/repos/improbable-research/keanu/commits{/sha}","git_commits_url":"https://api.github.com/repos/improbable-research/keanu/git/commits{/sha}","comments_url":"https://api.github.com/repos/improbable-research/keanu/comments{/number}","issue_comment_url":"https://api.github.com/repos/improbable-research/keanu/issues/comments{/number}","contents_url":"https://api.github.com/repos/improbable-research/keanu/contents/{+path}","compare_url":"https://api.github.com/repos/improbable-research/keanu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/improbable-research/keanu/merges","archive_url":"https://api.github.com/repos/improbable-research/keanu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/improbable-research/keanu/downloads","issues_url":"https://api.github.com/repos/improbable-research/keanu/issues{/number}","pulls_url":"https://api.github.com/repos/improbable-research/keanu/pulls{/number}","milestones_url":"https://api.github.com/repos/improbable-research/keanu/milestones{/number}","notifications_url":"https://api.github.com/repos/improbable-research/keanu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/improbable-research/keanu/labels{/name}","releases_url":"https://api.github.com/repos/improbable-research/keanu/releases{/id}","deployments_url":"https://api.github.com/repos/improbable-research/keanu/deployments","created_at":"2018-04-06T12:48:36Z","updated_at":"2018-08-07T11:37:29Z","pushed_at":"2018-08-07T15:24:08Z","git_url":"git://github.com/improbable-research/keanu.git","ssh_url":"git@github.com:improbable-research/keanu.git","clone_url":"https://github.com/improbable-research/keanu.git","svn_url":"https://github.com/improbable-research/keanu","homepage":"","size":3779,"stargazers_count":75,"watchers_count":75,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":12,"watchers":75,"default_branch":"develop"}},"base":{"label":"improbable-research:develop","ref":"develop","sha":"76321ae33d324839de75f18885df5363ab6f6b01","user":{"login":"improbable-research","id":37903994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTAzOTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37903994?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-research","html_url":"https://github.com/improbable-research","followers_url":"https://api.github.com/users/improbable-research/followers","following_url":"https://api.github.com/users/improbable-research/following{/other_user}","gists_url":"https://api.github.com/users/improbable-research/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-research/subscriptions","organizations_url":"https://api.github.com/users/improbable-research/orgs","repos_url":"https://api.github.com/users/improbable-research/repos","events_url":"https://api.github.com/users/improbable-research/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-research/received_events","type":"Organization","site_admin":false},"repo":{"id":128393918,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgzOTM5MTg=","name":"keanu","full_name":"improbable-research/keanu","owner":{"login":"improbable-research","id":37903994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTAzOTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37903994?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-research","html_url":"https://github.com/improbable-research","followers_url":"https://api.github.com/users/improbable-research/followers","following_url":"https://api.github.com/users/improbable-research/following{/other_user}","gists_url":"https://api.github.com/users/improbable-research/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-research/subscriptions","organizations_url":"https://api.github.com/users/improbable-research/orgs","repos_url":"https://api.github.com/users/improbable-research/repos","events_url":"https://api.github.com/users/improbable-research/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-research/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/improbable-research/keanu","description":"A probabilistic approach from an Improbabilistic company","fork":false,"url":"https://api.github.com/repos/improbable-research/keanu","forks_url":"https://api.github.com/repos/improbable-research/keanu/forks","keys_url":"https://api.github.com/repos/improbable-research/keanu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/improbable-research/keanu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/improbable-research/keanu/teams","hooks_url":"https://api.github.com/repos/improbable-research/keanu/hooks","issue_events_url":"https://api.github.com/repos/improbable-research/keanu/issues/events{/number}","events_url":"https://api.github.com/repos/improbable-research/keanu/events","assignees_url":"https://api.github.com/repos/improbable-research/keanu/assignees{/user}","branches_url":"https://api.github.com/repos/improbable-research/keanu/branches{/branch}","tags_url":"https://api.github.com/repos/improbable-research/keanu/tags","blobs_url":"https://api.github.com/repos/improbable-research/keanu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/improbable-research/keanu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/improbable-research/keanu/git/refs{/sha}","trees_url":"https://api.github.com/repos/improbable-research/keanu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/improbable-research/keanu/statuses/{sha}","languages_url":"https://api.github.com/repos/improbable-research/keanu/languages","stargazers_url":"https://api.github.com/repos/improbable-research/keanu/stargazers","contributors_url":"https://api.github.com/repos/improbable-research/keanu/contributors","subscribers_url":"https://api.github.com/repos/improbable-research/keanu/subscribers","subscription_url":"https://api.github.com/repos/improbable-research/keanu/subscription","commits_url":"https://api.github.com/repos/improbable-research/keanu/commits{/sha}","git_commits_url":"https://api.github.com/repos/improbable-research/keanu/git/commits{/sha}","comments_url":"https://api.github.com/repos/improbable-research/keanu/comments{/number}","issue_comment_url":"https://api.github.com/repos/improbable-research/keanu/issues/comments{/number}","contents_url":"https://api.github.com/repos/improbable-research/keanu/contents/{+path}","compare_url":"https://api.github.com/repos/improbable-research/keanu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/improbable-research/keanu/merges","archive_url":"https://api.github.com/repos/improbable-research/keanu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/improbable-research/keanu/downloads","issues_url":"https://api.github.com/repos/improbable-research/keanu/issues{/number}","pulls_url":"https://api.github.com/repos/improbable-research/keanu/pulls{/number}","milestones_url":"https://api.github.com/repos/improbable-research/keanu/milestones{/number}","notifications_url":"https://api.github.com/repos/improbable-research/keanu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/improbable-research/keanu/labels{/name}","releases_url":"https://api.github.com/repos/improbable-research/keanu/releases{/id}","deployments_url":"https://api.github.com/repos/improbable-research/keanu/deployments","created_at":"2018-04-06T12:48:36Z","updated_at":"2018-08-07T11:37:29Z","pushed_at":"2018-08-07T15:24:08Z","git_url":"git://github.com/improbable-research/keanu.git","ssh_url":"git@github.com:improbable-research/keanu.git","clone_url":"https://github.com/improbable-research/keanu.git","svn_url":"https://github.com/improbable-research/keanu","homepage":"","size":3779,"stargazers_count":75,"watchers_count":75,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":12,"watchers":75,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/153"},"html":{"href":"https://github.com/improbable-research/keanu/pull/153"},"issue":{"href":"https://api.github.com/repos/improbable-research/keanu/issues/153"},"comments":{"href":"https://api.github.com/repos/improbable-research/keanu/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/improbable-research/keanu/statuses/8a8fc65dbe8c599aaca7e50310abc11b74a7a654"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"migwellian"}}