{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/pulls/19","id":218786544,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4Nzg2NTQ0","html_url":"https://github.com/UVOT-data-analysis/uvot-mosaic/pull/19","diff_url":"https://github.com/UVOT-data-analysis/uvot-mosaic/pull/19.diff","patch_url":"https://github.com/UVOT-data-analysis/uvot-mosaic/pull/19.patch","issue_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/issues/19","number":19,"state":"closed","locked":false,"title":"code to do manual scattered light corrections","user":{"login":"lea-hagen","id":32465297,"node_id":"MDQ6VXNlcjMyNDY1Mjk3","avatar_url":"https://avatars0.githubusercontent.com/u/32465297?v=4","gravatar_id":"","url":"https://api.github.com/users/lea-hagen","html_url":"https://github.com/lea-hagen","followers_url":"https://api.github.com/users/lea-hagen/followers","following_url":"https://api.github.com/users/lea-hagen/following{/other_user}","gists_url":"https://api.github.com/users/lea-hagen/gists{/gist_id}","starred_url":"https://api.github.com/users/lea-hagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lea-hagen/subscriptions","organizations_url":"https://api.github.com/users/lea-hagen/orgs","repos_url":"https://api.github.com/users/lea-hagen/repos","events_url":"https://api.github.com/users/lea-hagen/events{/privacy}","received_events_url":"https://api.github.com/users/lea-hagen/received_events","type":"User","site_admin":false},"body":"This adds an interactive tool to do scattered light (SL) corrections.  The current method is to fiddle with a couple parameters that affect the stretch of the SL images from Fig 20 in [Breeveld+10](http://adsabs.harvard.edu/abs/2010MNRAS.406.1687B).  Counts images (before/after the SL correction) pop up so you can evaluate progress.  The final parameters get saved into text files, which are read in at the end to create final corrected sky (counts) images.  There's a new flag in `offset_mosaic` to tell whether to use the standard or SL-corrected images.\r\n\r\nAlso corrected the SL creation process in `uvot_deep`, in which the SL image may have dimensions that are wrong by 1 pixel (similar to some LSS images).  The solution is the same as #7.","created_at":"2018-09-27T20:56:30Z","updated_at":"2018-09-27T21:00:58Z","closed_at":"2018-09-27T21:00:58Z","merged_at":"2018-09-27T21:00:58Z","merge_commit_sha":"1229757b4685d6010d9a26f6469ba7c6fabcd2ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/pulls/19/commits","review_comments_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/pulls/19/comments","review_comment_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/issues/19/comments","statuses_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/statuses/e5cf9d2a00a92d1dabfff4a0689e959eb15d1cb3","head":{"label":"lea-hagen:sl_manual","ref":"sl_manual","sha":"e5cf9d2a00a92d1dabfff4a0689e959eb15d1cb3","user":{"login":"lea-hagen","id":32465297,"node_id":"MDQ6VXNlcjMyNDY1Mjk3","avatar_url":"https://avatars0.githubusercontent.com/u/32465297?v=4","gravatar_id":"","url":"https://api.github.com/users/lea-hagen","html_url":"https://github.com/lea-hagen","followers_url":"https://api.github.com/users/lea-hagen/followers","following_url":"https://api.github.com/users/lea-hagen/following{/other_user}","gists_url":"https://api.github.com/users/lea-hagen/gists{/gist_id}","starred_url":"https://api.github.com/users/lea-hagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lea-hagen/subscriptions","organizations_url":"https://api.github.com/users/lea-hagen/orgs","repos_url":"https://api.github.com/users/lea-hagen/repos","events_url":"https://api.github.com/users/lea-hagen/events{/privacy}","received_events_url":"https://api.github.com/users/lea-hagen/received_events","type":"User","site_admin":false},"repo":{"id":140485905,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0ODU5MDU=","name":"uvot-mosaic","full_name":"lea-hagen/uvot-mosaic","private":false,"owner":{"login":"lea-hagen","id":32465297,"node_id":"MDQ6VXNlcjMyNDY1Mjk3","avatar_url":"https://avatars0.githubusercontent.com/u/32465297?v=4","gravatar_id":"","url":"https://api.github.com/users/lea-hagen","html_url":"https://github.com/lea-hagen","followers_url":"https://api.github.com/users/lea-hagen/followers","following_url":"https://api.github.com/users/lea-hagen/following{/other_user}","gists_url":"https://api.github.com/users/lea-hagen/gists{/gist_id}","starred_url":"https://api.github.com/users/lea-hagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lea-hagen/subscriptions","organizations_url":"https://api.github.com/users/lea-hagen/orgs","repos_url":"https://api.github.com/users/lea-hagen/repos","events_url":"https://api.github.com/users/lea-hagen/events{/privacy}","received_events_url":"https://api.github.com/users/lea-hagen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lea-hagen/uvot-mosaic","description":"Create a calibrated mosaic of UVOT images","fork":true,"url":"https://api.github.com/repos/lea-hagen/uvot-mosaic","forks_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/forks","keys_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/teams","hooks_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/hooks","issue_events_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/issues/events{/number}","events_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/events","assignees_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/assignees{/user}","branches_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/branches{/branch}","tags_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/tags","blobs_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/git/refs{/sha}","trees_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/statuses/{sha}","languages_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/languages","stargazers_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/stargazers","contributors_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/contributors","subscribers_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/subscribers","subscription_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/subscription","commits_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/commits{/sha}","git_commits_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/git/commits{/sha}","comments_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/comments{/number}","issue_comment_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/issues/comments{/number}","contents_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/contents/{+path}","compare_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/merges","archive_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/downloads","issues_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/issues{/number}","pulls_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/pulls{/number}","milestones_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/milestones{/number}","notifications_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/labels{/name}","releases_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/releases{/id}","deployments_url":"https://api.github.com/repos/lea-hagen/uvot-mosaic/deployments","created_at":"2018-07-10T20:49:48Z","updated_at":"2018-08-28T15:44:32Z","pushed_at":"2018-09-27T20:48:44Z","git_url":"git://github.com/lea-hagen/uvot-mosaic.git","ssh_url":"git@github.com:lea-hagen/uvot-mosaic.git","clone_url":"https://github.com/lea-hagen/uvot-mosaic.git","svn_url":"https://github.com/lea-hagen/uvot-mosaic","homepage":null,"size":67,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UVOT-data-analysis:master","ref":"master","sha":"2916fc38d56d6bec87d45be5a83906c3cb25f7c8","user":{"login":"UVOT-data-analysis","id":41086272,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDg2Mjcy","avatar_url":"https://avatars1.githubusercontent.com/u/41086272?v=4","gravatar_id":"","url":"https://api.github.com/users/UVOT-data-analysis","html_url":"https://github.com/UVOT-data-analysis","followers_url":"https://api.github.com/users/UVOT-data-analysis/followers","following_url":"https://api.github.com/users/UVOT-data-analysis/following{/other_user}","gists_url":"https://api.github.com/users/UVOT-data-analysis/gists{/gist_id}","starred_url":"https://api.github.com/users/UVOT-data-analysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UVOT-data-analysis/subscriptions","organizations_url":"https://api.github.com/users/UVOT-data-analysis/orgs","repos_url":"https://api.github.com/users/UVOT-data-analysis/repos","events_url":"https://api.github.com/users/UVOT-data-analysis/events{/privacy}","received_events_url":"https://api.github.com/users/UVOT-data-analysis/received_events","type":"Organization","site_admin":false},"repo":{"id":127925679,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc5MjU2Nzk=","name":"uvot-mosaic","full_name":"UVOT-data-analysis/uvot-mosaic","private":false,"owner":{"login":"UVOT-data-analysis","id":41086272,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDg2Mjcy","avatar_url":"https://avatars1.githubusercontent.com/u/41086272?v=4","gravatar_id":"","url":"https://api.github.com/users/UVOT-data-analysis","html_url":"https://github.com/UVOT-data-analysis","followers_url":"https://api.github.com/users/UVOT-data-analysis/followers","following_url":"https://api.github.com/users/UVOT-data-analysis/following{/other_user}","gists_url":"https://api.github.com/users/UVOT-data-analysis/gists{/gist_id}","starred_url":"https://api.github.com/users/UVOT-data-analysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UVOT-data-analysis/subscriptions","organizations_url":"https://api.github.com/users/UVOT-data-analysis/orgs","repos_url":"https://api.github.com/users/UVOT-data-analysis/repos","events_url":"https://api.github.com/users/UVOT-data-analysis/events{/privacy}","received_events_url":"https://api.github.com/users/UVOT-data-analysis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UVOT-data-analysis/uvot-mosaic","description":"Create a calibrated mosaic of UVOT images","fork":false,"url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic","forks_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/forks","keys_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/teams","hooks_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/hooks","issue_events_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/issues/events{/number}","events_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/events","assignees_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/assignees{/user}","branches_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/branches{/branch}","tags_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/tags","blobs_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/git/refs{/sha}","trees_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/statuses/{sha}","languages_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/languages","stargazers_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/stargazers","contributors_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/contributors","subscribers_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/subscribers","subscription_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/subscription","commits_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/commits{/sha}","git_commits_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/git/commits{/sha}","comments_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/comments{/number}","issue_comment_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/issues/comments{/number}","contents_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/contents/{+path}","compare_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/merges","archive_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/downloads","issues_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/issues{/number}","pulls_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/pulls{/number}","milestones_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/milestones{/number}","notifications_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/labels{/name}","releases_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/releases{/id}","deployments_url":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/deployments","created_at":"2018-04-03T15:01:34Z","updated_at":"2018-09-14T15:43:39Z","pushed_at":"2018-09-27T21:00:58Z","git_url":"git://github.com/UVOT-data-analysis/uvot-mosaic.git","ssh_url":"git@github.com:UVOT-data-analysis/uvot-mosaic.git","clone_url":"https://github.com/UVOT-data-analysis/uvot-mosaic.git","svn_url":"https://github.com/UVOT-data-analysis/uvot-mosaic","homepage":null,"size":64,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/pulls/19"},"html":{"href":"https://github.com/UVOT-data-analysis/uvot-mosaic/pull/19"},"issue":{"href":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/issues/19"},"comments":{"href":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/UVOT-data-analysis/uvot-mosaic/statuses/e5cf9d2a00a92d1dabfff4a0689e959eb15d1cb3"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lea-hagen","id":32465297,"node_id":"MDQ6VXNlcjMyNDY1Mjk3","avatar_url":"https://avatars0.githubusercontent.com/u/32465297?v=4","gravatar_id":"","url":"https://api.github.com/users/lea-hagen","html_url":"https://github.com/lea-hagen","followers_url":"https://api.github.com/users/lea-hagen/followers","following_url":"https://api.github.com/users/lea-hagen/following{/other_user}","gists_url":"https://api.github.com/users/lea-hagen/gists{/gist_id}","starred_url":"https://api.github.com/users/lea-hagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lea-hagen/subscriptions","organizations_url":"https://api.github.com/users/lea-hagen/orgs","repos_url":"https://api.github.com/users/lea-hagen/repos","events_url":"https://api.github.com/users/lea-hagen/events{/privacy}","received_events_url":"https://api.github.com/users/lea-hagen/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":8,"additions":422,"deletions":24,"changed_files":3}}
{"actor":{"display_login":"lea-hagen"}}