{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/7900","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/7900/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/7900/comments","events_url":"https://api.github.com/repos/istio/istio/issues/7900/events","html_url":"https://github.com/istio/istio/pull/7900","id":350344544,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MjE2NzY4","number":7900,"title":"Let \"pilot_grpc_address\" take over param DiscoveryAddress in WriteBootstrap","user":{"login":"lichuqiang","id":12265352,"node_id":"MDQ6VXNlcjEyMjY1MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":644159920,"node_id":"MDU6TGFiZWw2NDQxNTk5MjA=","url":"https://api.github.com/repos/istio/istio/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-14T09:15:25Z","updated_at":"2018-08-14T09:15:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/7900","html_url":"https://github.com/istio/istio/pull/7900","diff_url":"https://github.com/istio/istio/pull/7900.diff","patch_url":"https://github.com/istio/istio/pull/7900.patch"},"body":"It is kind of ugly to hard code the pilot ports here,\r\nand since the generated opts \"pilot_address\" is not used any more, I think it reasonable to Let \"pilot_grpc_address\" reuse the DiscoveryAddress param."},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/412808181","html_url":"https://github.com/istio/istio/pull/7900#issuecomment-412808181","issue_url":"https://api.github.com/repos/istio/istio/issues/7900","id":412808181,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjgwODE4MQ==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T09:15:39Z","updated_at":"2018-08-14T09:15:39Z","author_association":"COLLABORATOR","body":"Hi @lichuqiang. Thanks for your PR.\n\nI'm waiting for a [istio](https://github.com/orgs/istio/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://github.com/orgs/istio/people) to skip this step.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"istio-testing"}}