{"action":"created","comment":{"url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/pulls/comments/233989171","pull_request_review_id":175531053,"id":233989171,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzk4OTE3MQ==","diff_hunk":"@@ -111,47 +124,117 @@ TEST(FileName, isQuestionMarksNoExtensionVersioned) {\n   QString test = \"/testy/mc/test/face/test??????\";\n   FileName file(test);\n   \n-  EXPECT_EQ(true, file.isVersioned());\n+  EXPECT_TRUE(file.isVersioned());\n }\n \n TEST(FileName, isQuestionMarksExtensionVersioned) {\n   QString test = \"/testy/mc/test/face/test??????.cub\";\n   FileName file(test);\n   \n-  EXPECT_EQ(true, file.isVersioned());\n+  EXPECT_TRUE(file.isVersioned());\n }\n \n TEST(FileName, isDDMMMYYYVersioned) {\n   QString test = \"/testy/mc/test/face/test{ddMMMyyyy}..cub\";\n   FileName file(test);\n   \n-  EXPECT_EQ(true, file.isVersioned());\n+  EXPECT_TRUE(file.isVersioned());\n }\n \n-//TODO Waiting for GMock\n+TEST(FileName, HighestVersion) {\n+  std::ofstream fileStream;\n+  fileStream.open(\"test000001.cub\");\n+  fileStream << \"test\";\n+  fileStream.close();\n+  fileStream.open(\"test000002.cub\");\n+  fileStream << \"test\";\n+  fileStream.close();\n+  \n+  FileName file(\"test??????.cub\");\n+  EXPECT_EQ(\"./test000002.cub\", file.highestVersion().expanded());\n+  remove(\"test000001.cub\");\n+  remove(\"test000002.cub\");\n+  \n+}","path":"isis/tests/FileNameTests.cpp","position":97,"original_position":97,"commit_id":"8cd3c27f6e6843aa37c5eea32ef2c36695cd2f6a","original_commit_id":"8cd3c27f6e6843aa37c5eea32ef2c36695cd2f6a","user":{"login":"jessemapel","id":22942817,"node_id":"MDQ6VXNlcjIyOTQyODE3","avatar_url":"https://avatars3.githubusercontent.com/u/22942817?v=4","gravatar_id":"","url":"https://api.github.com/users/jessemapel","html_url":"https://github.com/jessemapel","followers_url":"https://api.github.com/users/jessemapel/followers","following_url":"https://api.github.com/users/jessemapel/following{/other_user}","gists_url":"https://api.github.com/users/jessemapel/gists{/gist_id}","starred_url":"https://api.github.com/users/jessemapel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessemapel/subscriptions","organizations_url":"https://api.github.com/users/jessemapel/orgs","repos_url":"https://api.github.com/users/jessemapel/repos","events_url":"https://api.github.com/users/jessemapel/events{/privacy}","received_events_url":"https://api.github.com/users/jessemapel/received_events","type":"User","site_admin":false},"body":"If you run into an exception during this test, the files won't get cleaned up. You can use a fixture's setup and teardown methods to setup the files and ensure that they get removed even if the test doesn't run to completion.","created_at":"2018-11-15T20:03:18Z","updated_at":"2018-11-15T20:06:04Z","html_url":"https://github.com/USGS-Astrogeology/ISIS3/pull/568#discussion_r233989171","pull_request_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/pulls/568","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/pulls/comments/233989171"},"html":{"href":"https://github.com/USGS-Astrogeology/ISIS3/pull/568#discussion_r233989171"},"pull_request":{"href":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/pulls/568"}}},"pull_request":{"url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/pulls/568","id":231303715,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzAzNzE1","html_url":"https://github.com/USGS-Astrogeology/ISIS3/pull/568","diff_url":"https://github.com/USGS-Astrogeology/ISIS3/pull/568.diff","patch_url":"https://github.com/USGS-Astrogeology/ISIS3/pull/568.patch","issue_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/issues/568","number":568,"state":"open","locked":false,"title":"FileName gtest conversion","user":{"login":"makaylas","id":11697891,"node_id":"MDQ6VXNlcjExNjk3ODkx","avatar_url":"https://avatars1.githubusercontent.com/u/11697891?v=4","gravatar_id":"","url":"https://api.github.com/users/makaylas","html_url":"https://github.com/makaylas","followers_url":"https://api.github.com/users/makaylas/followers","following_url":"https://api.github.com/users/makaylas/following{/other_user}","gists_url":"https://api.github.com/users/makaylas/gists{/gist_id}","starred_url":"https://api.github.com/users/makaylas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makaylas/subscriptions","organizations_url":"https://api.github.com/users/makaylas/orgs","repos_url":"https://api.github.com/users/makaylas/repos","events_url":"https://api.github.com/users/makaylas/events{/privacy}","received_events_url":"https://api.github.com/users/makaylas/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-15T19:12:49Z","updated_at":"2018-11-15T20:06:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ef4db23122deaa8d936227c1c7f9a8eaf97f405","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/pulls/568/commits","review_comments_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/pulls/568/comments","review_comment_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/issues/568/comments","statuses_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/statuses/8cd3c27f6e6843aa37c5eea32ef2c36695cd2f6a","head":{"label":"makaylas:testing","ref":"testing","sha":"8cd3c27f6e6843aa37c5eea32ef2c36695cd2f6a","user":{"login":"makaylas","id":11697891,"node_id":"MDQ6VXNlcjExNjk3ODkx","avatar_url":"https://avatars1.githubusercontent.com/u/11697891?v=4","gravatar_id":"","url":"https://api.github.com/users/makaylas","html_url":"https://github.com/makaylas","followers_url":"https://api.github.com/users/makaylas/followers","following_url":"https://api.github.com/users/makaylas/following{/other_user}","gists_url":"https://api.github.com/users/makaylas/gists{/gist_id}","starred_url":"https://api.github.com/users/makaylas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makaylas/subscriptions","organizations_url":"https://api.github.com/users/makaylas/orgs","repos_url":"https://api.github.com/users/makaylas/repos","events_url":"https://api.github.com/users/makaylas/events{/privacy}","received_events_url":"https://api.github.com/users/makaylas/received_events","type":"User","site_admin":false},"repo":{"id":118663553,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg2NjM1NTM=","name":"ISIS3","full_name":"makaylas/ISIS3","private":false,"owner":{"login":"makaylas","id":11697891,"node_id":"MDQ6VXNlcjExNjk3ODkx","avatar_url":"https://avatars1.githubusercontent.com/u/11697891?v=4","gravatar_id":"","url":"https://api.github.com/users/makaylas","html_url":"https://github.com/makaylas","followers_url":"https://api.github.com/users/makaylas/followers","following_url":"https://api.github.com/users/makaylas/following{/other_user}","gists_url":"https://api.github.com/users/makaylas/gists{/gist_id}","starred_url":"https://api.github.com/users/makaylas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makaylas/subscriptions","organizations_url":"https://api.github.com/users/makaylas/orgs","repos_url":"https://api.github.com/users/makaylas/repos","events_url":"https://api.github.com/users/makaylas/events{/privacy}","received_events_url":"https://api.github.com/users/makaylas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/makaylas/ISIS3","description":null,"fork":true,"url":"https://api.github.com/repos/makaylas/ISIS3","forks_url":"https://api.github.com/repos/makaylas/ISIS3/forks","keys_url":"https://api.github.com/repos/makaylas/ISIS3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/makaylas/ISIS3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/makaylas/ISIS3/teams","hooks_url":"https://api.github.com/repos/makaylas/ISIS3/hooks","issue_events_url":"https://api.github.com/repos/makaylas/ISIS3/issues/events{/number}","events_url":"https://api.github.com/repos/makaylas/ISIS3/events","assignees_url":"https://api.github.com/repos/makaylas/ISIS3/assignees{/user}","branches_url":"https://api.github.com/repos/makaylas/ISIS3/branches{/branch}","tags_url":"https://api.github.com/repos/makaylas/ISIS3/tags","blobs_url":"https://api.github.com/repos/makaylas/ISIS3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/makaylas/ISIS3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/makaylas/ISIS3/git/refs{/sha}","trees_url":"https://api.github.com/repos/makaylas/ISIS3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/makaylas/ISIS3/statuses/{sha}","languages_url":"https://api.github.com/repos/makaylas/ISIS3/languages","stargazers_url":"https://api.github.com/repos/makaylas/ISIS3/stargazers","contributors_url":"https://api.github.com/repos/makaylas/ISIS3/contributors","subscribers_url":"https://api.github.com/repos/makaylas/ISIS3/subscribers","subscription_url":"https://api.github.com/repos/makaylas/ISIS3/subscription","commits_url":"https://api.github.com/repos/makaylas/ISIS3/commits{/sha}","git_commits_url":"https://api.github.com/repos/makaylas/ISIS3/git/commits{/sha}","comments_url":"https://api.github.com/repos/makaylas/ISIS3/comments{/number}","issue_comment_url":"https://api.github.com/repos/makaylas/ISIS3/issues/comments{/number}","contents_url":"https://api.github.com/repos/makaylas/ISIS3/contents/{+path}","compare_url":"https://api.github.com/repos/makaylas/ISIS3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/makaylas/ISIS3/merges","archive_url":"https://api.github.com/repos/makaylas/ISIS3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/makaylas/ISIS3/downloads","issues_url":"https://api.github.com/repos/makaylas/ISIS3/issues{/number}","pulls_url":"https://api.github.com/repos/makaylas/ISIS3/pulls{/number}","milestones_url":"https://api.github.com/repos/makaylas/ISIS3/milestones{/number}","notifications_url":"https://api.github.com/repos/makaylas/ISIS3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/makaylas/ISIS3/labels{/name}","releases_url":"https://api.github.com/repos/makaylas/ISIS3/releases{/id}","deployments_url":"https://api.github.com/repos/makaylas/ISIS3/deployments","created_at":"2018-01-23T20:12:00Z","updated_at":"2018-11-09T19:39:55Z","pushed_at":"2018-11-13T20:56:08Z","git_url":"git://github.com/makaylas/ISIS3.git","ssh_url":"git@github.com:makaylas/ISIS3.git","clone_url":"https://github.com/makaylas/ISIS3.git","svn_url":"https://github.com/makaylas/ISIS3","homepage":null,"size":158039,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"USGS-Astrogeology:testing","ref":"testing","sha":"6bf151a41cbbd14381cce9cd98af16c5d592b270","user":{"login":"USGS-Astrogeology","id":8268981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNjg5ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/8268981?v=4","gravatar_id":"","url":"https://api.github.com/users/USGS-Astrogeology","html_url":"https://github.com/USGS-Astrogeology","followers_url":"https://api.github.com/users/USGS-Astrogeology/followers","following_url":"https://api.github.com/users/USGS-Astrogeology/following{/other_user}","gists_url":"https://api.github.com/users/USGS-Astrogeology/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-Astrogeology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-Astrogeology/subscriptions","organizations_url":"https://api.github.com/users/USGS-Astrogeology/orgs","repos_url":"https://api.github.com/users/USGS-Astrogeology/repos","events_url":"https://api.github.com/users/USGS-Astrogeology/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-Astrogeology/received_events","type":"Organization","site_admin":false},"repo":{"id":118655870,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg2NTU4NzA=","name":"ISIS3","full_name":"USGS-Astrogeology/ISIS3","private":false,"owner":{"login":"USGS-Astrogeology","id":8268981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNjg5ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/8268981?v=4","gravatar_id":"","url":"https://api.github.com/users/USGS-Astrogeology","html_url":"https://github.com/USGS-Astrogeology","followers_url":"https://api.github.com/users/USGS-Astrogeology/followers","following_url":"https://api.github.com/users/USGS-Astrogeology/following{/other_user}","gists_url":"https://api.github.com/users/USGS-Astrogeology/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-Astrogeology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-Astrogeology/subscriptions","organizations_url":"https://api.github.com/users/USGS-Astrogeology/orgs","repos_url":"https://api.github.com/users/USGS-Astrogeology/repos","events_url":"https://api.github.com/users/USGS-Astrogeology/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-Astrogeology/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/USGS-Astrogeology/ISIS3","description":"Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.","fork":false,"url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3","forks_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/forks","keys_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/teams","hooks_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/hooks","issue_events_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/issues/events{/number}","events_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/events","assignees_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/assignees{/user}","branches_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/branches{/branch}","tags_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/tags","blobs_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/git/refs{/sha}","trees_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/statuses/{sha}","languages_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/languages","stargazers_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/stargazers","contributors_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/contributors","subscribers_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/subscribers","subscription_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/subscription","commits_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/commits{/sha}","git_commits_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/git/commits{/sha}","comments_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/comments{/number}","issue_comment_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/issues/comments{/number}","contents_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/contents/{+path}","compare_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/merges","archive_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/downloads","issues_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/issues{/number}","pulls_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/pulls{/number}","milestones_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/milestones{/number}","notifications_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/labels{/name}","releases_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/releases{/id}","deployments_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/deployments","created_at":"2018-01-23T19:05:43Z","updated_at":"2018-11-15T15:45:33Z","pushed_at":"2018-11-15T19:37:08Z","git_url":"git://github.com/USGS-Astrogeology/ISIS3.git","ssh_url":"git@github.com:USGS-Astrogeology/ISIS3.git","clone_url":"https://github.com/USGS-Astrogeology/ISIS3.git","svn_url":"https://github.com/USGS-Astrogeology/ISIS3","homepage":"https://isis.astrogeology.usgs.gov","size":165258,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":30,"license":null,"forks":28,"open_issues":30,"watchers":12,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/pulls/568"},"html":{"href":"https://github.com/USGS-Astrogeology/ISIS3/pull/568"},"issue":{"href":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/issues/568"},"comments":{"href":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/issues/568/comments"},"review_comments":{"href":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/pulls/568/comments"},"review_comment":{"href":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/pulls/568/commits"},"statuses":{"href":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/statuses/8cd3c27f6e6843aa37c5eea32ef2c36695cd2f6a"}},"author_association":"NONE"}}
{"actor":{"display_login":"jessemapel"}}