{"action":"created","comment":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/comments/168083671","pull_request_review_id":96392522,"id":168083671,"diff_hunk":"@@ -68,6 +68,8 @@ def __init__(self, inLayer, outDb, outUri, parent=None):\n         # updates of UI\n         self.setupWorkingMode(self.mode)\n         self.cboSchema.currentIndexChanged.connect(self.populateTables)\n+        self.widgetSourceSrid.setOptionVisible(QgsProjectionSelectionWidget.CrsNotSet, True)","path":"python/plugins/db_manager/dlg_import_vector.py","position":13,"original_position":13,"commit_id":"02518f7a94d64c87f7270783c5cdfa3c8cede1f6","original_commit_id":"db8ab3e4b362a1a8c327da2747da3b8221fc7487","user":{"login":"Fanevanjanahary","id":12623986,"avatar_url":"https://avatars2.githubusercontent.com/u/12623986?v=4","gravatar_id":"","url":"https://api.github.com/users/Fanevanjanahary","html_url":"https://github.com/Fanevanjanahary","followers_url":"https://api.github.com/users/Fanevanjanahary/followers","following_url":"https://api.github.com/users/Fanevanjanahary/following{/other_user}","gists_url":"https://api.github.com/users/Fanevanjanahary/gists{/gist_id}","starred_url":"https://api.github.com/users/Fanevanjanahary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fanevanjanahary/subscriptions","organizations_url":"https://api.github.com/users/Fanevanjanahary/orgs","repos_url":"https://api.github.com/users/Fanevanjanahary/repos","events_url":"https://api.github.com/users/Fanevanjanahary/events{/privacy}","received_events_url":"https://api.github.com/users/Fanevanjanahary/received_events","type":"User","site_admin":false},"body":"I agree but I did this to hide the \"invalid projection\" when the check-box is unchecked ","created_at":"2018-02-14T06:05:23Z","updated_at":"2018-02-14T06:05:23Z","html_url":"https://github.com/qgis/QGIS/pull/6335#discussion_r168083671","pull_request_url":"https://api.github.com/repos/qgis/QGIS/pulls/6335","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments/168083671"},"html":{"href":"https://github.com/qgis/QGIS/pull/6335#discussion_r168083671"},"pull_request":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/6335"}},"in_reply_to_id":167973021},"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/6335","id":168871082,"html_url":"https://github.com/qgis/QGIS/pull/6335","diff_url":"https://github.com/qgis/QGIS/pull/6335.diff","patch_url":"https://github.com/qgis/QGIS/pull/6335.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/6335","number":6335,"state":"open","locked":false,"title":"use crs widget picker in db_manager","user":{"login":"Fanevanjanahary","id":12623986,"avatar_url":"https://avatars2.githubusercontent.com/u/12623986?v=4","gravatar_id":"","url":"https://api.github.com/users/Fanevanjanahary","html_url":"https://github.com/Fanevanjanahary","followers_url":"https://api.github.com/users/Fanevanjanahary/followers","following_url":"https://api.github.com/users/Fanevanjanahary/following{/other_user}","gists_url":"https://api.github.com/users/Fanevanjanahary/gists{/gist_id}","starred_url":"https://api.github.com/users/Fanevanjanahary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fanevanjanahary/subscriptions","organizations_url":"https://api.github.com/users/Fanevanjanahary/orgs","repos_url":"https://api.github.com/users/Fanevanjanahary/repos","events_url":"https://api.github.com/users/Fanevanjanahary/events{/privacy}","received_events_url":"https://api.github.com/users/Fanevanjanahary/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\n* Use CRS widget instead of QLineEdit for CRS in vector import dialog\r\n* Review tab order in this dialog\r\n\r\nBefore:\r\n![before](https://user-images.githubusercontent.com/12623986/36157315-8fd00ee8-10ea-11e8-94bd-76d8ed857489.png)\r\n\r\nAfter:\r\n![after](https://user-images.githubusercontent.com/12623986/36157319-9311f99a-10ea-11e8-9686-24955f91891e.png)\r\n\r\n## Checklist\r\n\r\n> Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.\r\n\r\n- [x] Commit messages are descriptive and explain the rationale for changes\r\n- [ ] Commits which fix bugs include `fixes #11111` in the commit message next to the description\r\n- [ ] Commits which add new features are tagged with `[FEATURE]` in the commit message\r\n- [ ] Commits which change the UI or existing user workflows are tagged with `[needs-docs]` in the commit message and containt sufficient information in the commit message to be documented\r\n- [x] I have read the [QGIS Coding Standards](https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html) and this PR complies with them\r\n- [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)\r\n- [ ] New unit tests have been added for core changes\r\n- [x] I have run [the `scripts/prepare-commit.sh` script](https://github.com/qgis/QGIS/blob/master/.github/CONTRIBUTE.md#contributing-to-qgis) before each commit\r\n","created_at":"2018-02-13T15:14:01Z","updated_at":"2018-02-14T06:05:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44773598784febb04705d3b15338e94af8888969","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/6335/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/6335/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/6335/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/02518f7a94d64c87f7270783c5cdfa3c8cede1f6","head":{"label":"Fanevanjanahary:crs_widget","ref":"crs_widget","sha":"02518f7a94d64c87f7270783c5cdfa3c8cede1f6","user":{"login":"Fanevanjanahary","id":12623986,"avatar_url":"https://avatars2.githubusercontent.com/u/12623986?v=4","gravatar_id":"","url":"https://api.github.com/users/Fanevanjanahary","html_url":"https://github.com/Fanevanjanahary","followers_url":"https://api.github.com/users/Fanevanjanahary/followers","following_url":"https://api.github.com/users/Fanevanjanahary/following{/other_user}","gists_url":"https://api.github.com/users/Fanevanjanahary/gists{/gist_id}","starred_url":"https://api.github.com/users/Fanevanjanahary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fanevanjanahary/subscriptions","organizations_url":"https://api.github.com/users/Fanevanjanahary/orgs","repos_url":"https://api.github.com/users/Fanevanjanahary/repos","events_url":"https://api.github.com/users/Fanevanjanahary/events{/privacy}","received_events_url":"https://api.github.com/users/Fanevanjanahary/received_events","type":"User","site_admin":false},"repo":{"id":121371355,"name":"QGIS","full_name":"Fanevanjanahary/QGIS","owner":{"login":"Fanevanjanahary","id":12623986,"avatar_url":"https://avatars2.githubusercontent.com/u/12623986?v=4","gravatar_id":"","url":"https://api.github.com/users/Fanevanjanahary","html_url":"https://github.com/Fanevanjanahary","followers_url":"https://api.github.com/users/Fanevanjanahary/followers","following_url":"https://api.github.com/users/Fanevanjanahary/following{/other_user}","gists_url":"https://api.github.com/users/Fanevanjanahary/gists{/gist_id}","starred_url":"https://api.github.com/users/Fanevanjanahary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fanevanjanahary/subscriptions","organizations_url":"https://api.github.com/users/Fanevanjanahary/orgs","repos_url":"https://api.github.com/users/Fanevanjanahary/repos","events_url":"https://api.github.com/users/Fanevanjanahary/events{/privacy}","received_events_url":"https://api.github.com/users/Fanevanjanahary/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fanevanjanahary/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/Fanevanjanahary/QGIS","forks_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/forks","keys_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/teams","hooks_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/hooks","issue_events_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/events","assignees_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/tags","blobs_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/languages","stargazers_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/stargazers","contributors_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/contributors","subscribers_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/subscribers","subscription_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/subscription","commits_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/merges","archive_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/downloads","issues_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/Fanevanjanahary/QGIS/deployments","created_at":"2018-02-13T10:51:09Z","updated_at":"2018-02-13T10:51:44Z","pushed_at":"2018-02-14T05:59:16Z","git_url":"git://github.com/Fanevanjanahary/QGIS.git","ssh_url":"git@github.com:Fanevanjanahary/QGIS.git","clone_url":"https://github.com/Fanevanjanahary/QGIS.git","svn_url":"https://github.com/Fanevanjanahary/QGIS","homepage":"http://qgis.org","size":1358154,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"231dae31240c17c690aebb9f235c10e02b3fd51e","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2018-02-12T14:38:47Z","pushed_at":"2018-02-14T05:59:18Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1358228,"stargazers_count":1801,"watchers_count":1801,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1200,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1200,"open_issues":117,"watchers":1801,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/6335"},"html":{"href":"https://github.com/qgis/QGIS/pull/6335"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/6335"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/6335/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/6335/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/6335/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/02518f7a94d64c87f7270783c5cdfa3c8cede1f6"}},"author_association":"NONE"}}
{"actor":{"display_login":"Fanevanjanahary"}}