{"action":"created","comment":{"url":"https://api.github.com/repos/nmstate/nmstate/pulls/comments/204506552","pull_request_review_id":139596399,"id":204506552,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDUwNjU1Mg==","diff_hunk":"@@ -0,0 +1,106 @@\n+#\n+# Copyright 2018 Red Hat, Inc.\n+#\n+# This program is free software: you can redistribute it and/or modify\n+# it under the terms of the GNU General Public License as published by\n+# the Free Software Foundation, either version 2 of the License, or\n+# (at your option) any later version.\n+#\n+# This program is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License\n+# along with this program.  If not, see <https://www.gnu.org/licenses/>.\n+#\n+\n+import logging\n+\n+try:\n+    import dbus                         # pylint: disable=import-error\n+except ImportError:\n+    # dbus is set to None to indicate that checkpoint is not available\n+    dbus = None\n+\n+\n+DBUS_STD_PROPERTIES_IFNAME = 'org.freedesktop.DBus.Properties'\n+\n+_nmdbus_manager = None\n+\n+\n+def has_checkpoint_capability():\n+    return dbus is not None","path":"libnmstate/nm/checkpoint.py","position":33,"original_position":33,"commit_id":"38340efa436b01095f1bfd1feed21cc9115a8188","original_commit_id":"38340efa436b01095f1bfd1feed21cc9115a8188","user":{"login":"EdDev","id":9546119,"node_id":"MDQ6VXNlcjk1NDYxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9546119?v=4","gravatar_id":"","url":"https://api.github.com/users/EdDev","html_url":"https://github.com/EdDev","followers_url":"https://api.github.com/users/EdDev/followers","following_url":"https://api.github.com/users/EdDev/following{/other_user}","gists_url":"https://api.github.com/users/EdDev/gists{/gist_id}","starred_url":"https://api.github.com/users/EdDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdDev/subscriptions","organizations_url":"https://api.github.com/users/EdDev/orgs","repos_url":"https://api.github.com/users/EdDev/repos","events_url":"https://api.github.com/users/EdDev/events{/privacy}","received_events_url":"https://api.github.com/users/EdDev/received_events","type":"User","site_admin":false},"body":"Currently the checkpoint implementation is implemented using dbus directly and not libnm. This will probably change after Centos/RHEL 7.6 is released.\r\nTherefore, checkpoint is available if the system has python-dbus there.\r\ndbus is not a capability, that is an implementation detail of checkpoint.","created_at":"2018-07-23T18:21:32Z","updated_at":"2018-07-23T18:21:33Z","html_url":"https://github.com/nmstate/nmstate/pull/50#discussion_r204506552","pull_request_url":"https://api.github.com/repos/nmstate/nmstate/pulls/50","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nmstate/nmstate/pulls/comments/204506552"},"html":{"href":"https://github.com/nmstate/nmstate/pull/50#discussion_r204506552"},"pull_request":{"href":"https://api.github.com/repos/nmstate/nmstate/pulls/50"}},"in_reply_to_id":204450709},"pull_request":{"url":"https://api.github.com/repos/nmstate/nmstate/pulls/50","id":203058098,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDU4MDk4","html_url":"https://github.com/nmstate/nmstate/pull/50","diff_url":"https://github.com/nmstate/nmstate/pull/50.diff","patch_url":"https://github.com/nmstate/nmstate/pull/50.patch","issue_url":"https://api.github.com/repos/nmstate/nmstate/issues/50","number":50,"state":"open","locked":false,"title":"Transaction support","user":{"login":"EdDev","id":9546119,"node_id":"MDQ6VXNlcjk1NDYxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9546119?v=4","gravatar_id":"","url":"https://api.github.com/users/EdDev","html_url":"https://github.com/EdDev","followers_url":"https://api.github.com/users/EdDev/followers","following_url":"https://api.github.com/users/EdDev/following{/other_user}","gists_url":"https://api.github.com/users/EdDev/gists{/gist_id}","starred_url":"https://api.github.com/users/EdDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdDev/subscriptions","organizations_url":"https://api.github.com/users/EdDev/orgs","repos_url":"https://api.github.com/users/EdDev/repos","events_url":"https://api.github.com/users/EdDev/events{/privacy}","received_events_url":"https://api.github.com/users/EdDev/received_events","type":"User","site_admin":false},"body":"Use NM checkpoint feature to implement transactions.\r\n\r\nBased on #47 ","created_at":"2018-07-22T13:51:25Z","updated_at":"2018-07-23T18:21:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b01049dac781a97894f0ca941fcb571b3f6c9ee","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tyll","id":197720,"node_id":"MDQ6VXNlcjE5NzcyMA==","avatar_url":"https://avatars2.githubusercontent.com/u/197720?v=4","gravatar_id":"","url":"https://api.github.com/users/tyll","html_url":"https://github.com/tyll","followers_url":"https://api.github.com/users/tyll/followers","following_url":"https://api.github.com/users/tyll/following{/other_user}","gists_url":"https://api.github.com/users/tyll/gists{/gist_id}","starred_url":"https://api.github.com/users/tyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyll/subscriptions","organizations_url":"https://api.github.com/users/tyll/orgs","repos_url":"https://api.github.com/users/tyll/repos","events_url":"https://api.github.com/users/tyll/events{/privacy}","received_events_url":"https://api.github.com/users/tyll/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nmstate/nmstate/pulls/50/commits","review_comments_url":"https://api.github.com/repos/nmstate/nmstate/pulls/50/comments","review_comment_url":"https://api.github.com/repos/nmstate/nmstate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nmstate/nmstate/issues/50/comments","statuses_url":"https://api.github.com/repos/nmstate/nmstate/statuses/38340efa436b01095f1bfd1feed21cc9115a8188","head":{"label":"EdDev:transaction-support","ref":"transaction-support","sha":"38340efa436b01095f1bfd1feed21cc9115a8188","user":{"login":"EdDev","id":9546119,"node_id":"MDQ6VXNlcjk1NDYxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9546119?v=4","gravatar_id":"","url":"https://api.github.com/users/EdDev","html_url":"https://github.com/EdDev","followers_url":"https://api.github.com/users/EdDev/followers","following_url":"https://api.github.com/users/EdDev/following{/other_user}","gists_url":"https://api.github.com/users/EdDev/gists{/gist_id}","starred_url":"https://api.github.com/users/EdDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdDev/subscriptions","organizations_url":"https://api.github.com/users/EdDev/orgs","repos_url":"https://api.github.com/users/EdDev/repos","events_url":"https://api.github.com/users/EdDev/events{/privacy}","received_events_url":"https://api.github.com/users/EdDev/received_events","type":"User","site_admin":false},"repo":{"id":133216954,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMyMTY5NTQ=","name":"nmstate","full_name":"EdDev/nmstate","owner":{"login":"EdDev","id":9546119,"node_id":"MDQ6VXNlcjk1NDYxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9546119?v=4","gravatar_id":"","url":"https://api.github.com/users/EdDev","html_url":"https://github.com/EdDev","followers_url":"https://api.github.com/users/EdDev/followers","following_url":"https://api.github.com/users/EdDev/following{/other_user}","gists_url":"https://api.github.com/users/EdDev/gists{/gist_id}","starred_url":"https://api.github.com/users/EdDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdDev/subscriptions","organizations_url":"https://api.github.com/users/EdDev/orgs","repos_url":"https://api.github.com/users/EdDev/repos","events_url":"https://api.github.com/users/EdDev/events{/privacy}","received_events_url":"https://api.github.com/users/EdDev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EdDev/nmstate","description":null,"fork":true,"url":"https://api.github.com/repos/EdDev/nmstate","forks_url":"https://api.github.com/repos/EdDev/nmstate/forks","keys_url":"https://api.github.com/repos/EdDev/nmstate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EdDev/nmstate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EdDev/nmstate/teams","hooks_url":"https://api.github.com/repos/EdDev/nmstate/hooks","issue_events_url":"https://api.github.com/repos/EdDev/nmstate/issues/events{/number}","events_url":"https://api.github.com/repos/EdDev/nmstate/events","assignees_url":"https://api.github.com/repos/EdDev/nmstate/assignees{/user}","branches_url":"https://api.github.com/repos/EdDev/nmstate/branches{/branch}","tags_url":"https://api.github.com/repos/EdDev/nmstate/tags","blobs_url":"https://api.github.com/repos/EdDev/nmstate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EdDev/nmstate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EdDev/nmstate/git/refs{/sha}","trees_url":"https://api.github.com/repos/EdDev/nmstate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EdDev/nmstate/statuses/{sha}","languages_url":"https://api.github.com/repos/EdDev/nmstate/languages","stargazers_url":"https://api.github.com/repos/EdDev/nmstate/stargazers","contributors_url":"https://api.github.com/repos/EdDev/nmstate/contributors","subscribers_url":"https://api.github.com/repos/EdDev/nmstate/subscribers","subscription_url":"https://api.github.com/repos/EdDev/nmstate/subscription","commits_url":"https://api.github.com/repos/EdDev/nmstate/commits{/sha}","git_commits_url":"https://api.github.com/repos/EdDev/nmstate/git/commits{/sha}","comments_url":"https://api.github.com/repos/EdDev/nmstate/comments{/number}","issue_comment_url":"https://api.github.com/repos/EdDev/nmstate/issues/comments{/number}","contents_url":"https://api.github.com/repos/EdDev/nmstate/contents/{+path}","compare_url":"https://api.github.com/repos/EdDev/nmstate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EdDev/nmstate/merges","archive_url":"https://api.github.com/repos/EdDev/nmstate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EdDev/nmstate/downloads","issues_url":"https://api.github.com/repos/EdDev/nmstate/issues{/number}","pulls_url":"https://api.github.com/repos/EdDev/nmstate/pulls{/number}","milestones_url":"https://api.github.com/repos/EdDev/nmstate/milestones{/number}","notifications_url":"https://api.github.com/repos/EdDev/nmstate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EdDev/nmstate/labels{/name}","releases_url":"https://api.github.com/repos/EdDev/nmstate/releases{/id}","deployments_url":"https://api.github.com/repos/EdDev/nmstate/deployments","created_at":"2018-05-13T07:58:22Z","updated_at":"2018-06-09T05:32:45Z","pushed_at":"2018-07-23T18:12:20Z","git_url":"git://github.com/EdDev/nmstate.git","ssh_url":"git@github.com:EdDev/nmstate.git","clone_url":"https://github.com/EdDev/nmstate.git","svn_url":"https://github.com/EdDev/nmstate","homepage":null,"size":124,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nmstate:master","ref":"master","sha":"2576ba638aac8b348576181182e539a0580baf20","user":{"login":"nmstate","id":39068239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDY4MjM5","avatar_url":"https://avatars0.githubusercontent.com/u/39068239?v=4","gravatar_id":"","url":"https://api.github.com/users/nmstate","html_url":"https://github.com/nmstate","followers_url":"https://api.github.com/users/nmstate/followers","following_url":"https://api.github.com/users/nmstate/following{/other_user}","gists_url":"https://api.github.com/users/nmstate/gists{/gist_id}","starred_url":"https://api.github.com/users/nmstate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmstate/subscriptions","organizations_url":"https://api.github.com/users/nmstate/orgs","repos_url":"https://api.github.com/users/nmstate/repos","events_url":"https://api.github.com/users/nmstate/events{/privacy}","received_events_url":"https://api.github.com/users/nmstate/received_events","type":"Organization","site_admin":false},"repo":{"id":132556280,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI1NTYyODA=","name":"nmstate","full_name":"nmstate/nmstate","owner":{"login":"nmstate","id":39068239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDY4MjM5","avatar_url":"https://avatars0.githubusercontent.com/u/39068239?v=4","gravatar_id":"","url":"https://api.github.com/users/nmstate","html_url":"https://github.com/nmstate","followers_url":"https://api.github.com/users/nmstate/followers","following_url":"https://api.github.com/users/nmstate/following{/other_user}","gists_url":"https://api.github.com/users/nmstate/gists{/gist_id}","starred_url":"https://api.github.com/users/nmstate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmstate/subscriptions","organizations_url":"https://api.github.com/users/nmstate/orgs","repos_url":"https://api.github.com/users/nmstate/repos","events_url":"https://api.github.com/users/nmstate/events{/privacy}","received_events_url":"https://api.github.com/users/nmstate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nmstate/nmstate","description":"A declarative network manager API for hosts","fork":false,"url":"https://api.github.com/repos/nmstate/nmstate","forks_url":"https://api.github.com/repos/nmstate/nmstate/forks","keys_url":"https://api.github.com/repos/nmstate/nmstate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmstate/nmstate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmstate/nmstate/teams","hooks_url":"https://api.github.com/repos/nmstate/nmstate/hooks","issue_events_url":"https://api.github.com/repos/nmstate/nmstate/issues/events{/number}","events_url":"https://api.github.com/repos/nmstate/nmstate/events","assignees_url":"https://api.github.com/repos/nmstate/nmstate/assignees{/user}","branches_url":"https://api.github.com/repos/nmstate/nmstate/branches{/branch}","tags_url":"https://api.github.com/repos/nmstate/nmstate/tags","blobs_url":"https://api.github.com/repos/nmstate/nmstate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmstate/nmstate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmstate/nmstate/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmstate/nmstate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmstate/nmstate/statuses/{sha}","languages_url":"https://api.github.com/repos/nmstate/nmstate/languages","stargazers_url":"https://api.github.com/repos/nmstate/nmstate/stargazers","contributors_url":"https://api.github.com/repos/nmstate/nmstate/contributors","subscribers_url":"https://api.github.com/repos/nmstate/nmstate/subscribers","subscription_url":"https://api.github.com/repos/nmstate/nmstate/subscription","commits_url":"https://api.github.com/repos/nmstate/nmstate/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmstate/nmstate/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmstate/nmstate/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmstate/nmstate/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmstate/nmstate/contents/{+path}","compare_url":"https://api.github.com/repos/nmstate/nmstate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmstate/nmstate/merges","archive_url":"https://api.github.com/repos/nmstate/nmstate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmstate/nmstate/downloads","issues_url":"https://api.github.com/repos/nmstate/nmstate/issues{/number}","pulls_url":"https://api.github.com/repos/nmstate/nmstate/pulls{/number}","milestones_url":"https://api.github.com/repos/nmstate/nmstate/milestones{/number}","notifications_url":"https://api.github.com/repos/nmstate/nmstate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmstate/nmstate/labels{/name}","releases_url":"https://api.github.com/repos/nmstate/nmstate/releases{/id}","deployments_url":"https://api.github.com/repos/nmstate/nmstate/deployments","created_at":"2018-05-08T05:02:22Z","updated_at":"2018-07-23T17:00:42Z","pushed_at":"2018-07-23T18:12:21Z","git_url":"git://github.com/nmstate/nmstate.git","ssh_url":"git@github.com:nmstate/nmstate.git","clone_url":"https://github.com/nmstate/nmstate.git","svn_url":"https://github.com/nmstate/nmstate","homepage":"https://nmstate.github.io","size":104,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":3,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nmstate/nmstate/pulls/50"},"html":{"href":"https://github.com/nmstate/nmstate/pull/50"},"issue":{"href":"https://api.github.com/repos/nmstate/nmstate/issues/50"},"comments":{"href":"https://api.github.com/repos/nmstate/nmstate/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/nmstate/nmstate/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/nmstate/nmstate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nmstate/nmstate/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/nmstate/nmstate/statuses/38340efa436b01095f1bfd1feed21cc9115a8188"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"EdDev"}}