{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/pulls/comments/199943797","pull_request_review_id":134162099,"id":199943797,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTk0Mzc5Nw==","diff_hunk":"@@ -169,5 +183,10 @@ private static void ValidateInput(ref string input)\n                 throw new InvalidInputException($\"Input '{input}' contains invalid characters.\");\n             }\n         }\n+\n+        private static IEnumerable<SqlParameter> ConvertToSqlParameters(string name, string[] values)","path":"Services/Helpers/QueryBuilder.cs","position":193,"original_position":193,"commit_id":"5adce1600ce9b44d09afa52a6965dee624233df7","original_commit_id":"5adce1600ce9b44d09afa52a6965dee624233df7","user":{"login":"zhang-hua","id":2011059,"node_id":"MDQ6VXNlcjIwMTEwNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2011059?v=4","gravatar_id":"","url":"https://api.github.com/users/zhang-hua","html_url":"https://github.com/zhang-hua","followers_url":"https://api.github.com/users/zhang-hua/followers","following_url":"https://api.github.com/users/zhang-hua/following{/other_user}","gists_url":"https://api.github.com/users/zhang-hua/gists{/gist_id}","starred_url":"https://api.github.com/users/zhang-hua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhang-hua/subscriptions","organizations_url":"https://api.github.com/users/zhang-hua/orgs","repos_url":"https://api.github.com/users/zhang-hua/repos","events_url":"https://api.github.com/users/zhang-hua/events{/privacy}","received_events_url":"https://api.github.com/users/zhang-hua/received_events","type":"User","site_admin":false},"body":"yep. good suggestion.","created_at":"2018-07-03T20:40:44Z","updated_at":"2018-07-03T20:40:44Z","html_url":"https://github.com/Azure/device-telemetry-dotnet/pull/89#discussion_r199943797","pull_request_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/pulls/89","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/device-telemetry-dotnet/pulls/comments/199943797"},"html":{"href":"https://github.com/Azure/device-telemetry-dotnet/pull/89#discussion_r199943797"},"pull_request":{"href":"https://api.github.com/repos/Azure/device-telemetry-dotnet/pulls/89"}},"in_reply_to_id":199943163},"pull_request":{"url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/pulls/89","id":198825300,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODI1MzAw","html_url":"https://github.com/Azure/device-telemetry-dotnet/pull/89","diff_url":"https://github.com/Azure/device-telemetry-dotnet/pull/89.diff","patch_url":"https://github.com/Azure/device-telemetry-dotnet/pull/89.patch","issue_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/issues/89","number":89,"state":"open","locked":false,"title":"Fix bug of query builder","user":{"login":"zhang-hua","id":2011059,"node_id":"MDQ6VXNlcjIwMTEwNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2011059?v=4","gravatar_id":"","url":"https://api.github.com/users/zhang-hua","html_url":"https://github.com/zhang-hua","followers_url":"https://api.github.com/users/zhang-hua/followers","following_url":"https://api.github.com/users/zhang-hua/following{/other_user}","gists_url":"https://api.github.com/users/zhang-hua/gists{/gist_id}","starred_url":"https://api.github.com/users/zhang-hua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhang-hua/subscriptions","organizations_url":"https://api.github.com/users/zhang-hua/orgs","repos_url":"https://api.github.com/users/zhang-hua/repos","events_url":"https://api.github.com/users/zhang-hua/events{/privacy}","received_events_url":"https://api.github.com/users/zhang-hua/received_events","type":"User","site_admin":false},"body":"* Fix input validation of null id property\r\n* Fix `IN` clause\r\n* Add more Unit Tests\r\n\r\n# Type of change? <!-- [x] all the boxes that apply -->\r\n\r\n- [x] Bug fix\r\n- [ ] New feature\r\n- [ ] Enhancement\r\n- [ ] Breaking change (breaks backward compatibility)\r\n\r\n# Description, Context, Motivation <!-- Please help us reviewing your PR -->\r\n\r\n...\r\n\r\n**Checklist:**\r\n\r\n- [x] All tests passed\r\n- [x] The code follows the code style and conventions of this project\r\n- [ ] The change requires a change to the documentation\r\n- [ ] I have updated the documentation accordingly\r\n","created_at":"2018-07-03T01:08:26Z","updated_at":"2018-07-03T20:40:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e75da4bb03ba5e966d3f64528d2e7639818acc8f","assignee":{"login":"zhang-hua","id":2011059,"node_id":"MDQ6VXNlcjIwMTEwNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2011059?v=4","gravatar_id":"","url":"https://api.github.com/users/zhang-hua","html_url":"https://github.com/zhang-hua","followers_url":"https://api.github.com/users/zhang-hua/followers","following_url":"https://api.github.com/users/zhang-hua/following{/other_user}","gists_url":"https://api.github.com/users/zhang-hua/gists{/gist_id}","starred_url":"https://api.github.com/users/zhang-hua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhang-hua/subscriptions","organizations_url":"https://api.github.com/users/zhang-hua/orgs","repos_url":"https://api.github.com/users/zhang-hua/repos","events_url":"https://api.github.com/users/zhang-hua/events{/privacy}","received_events_url":"https://api.github.com/users/zhang-hua/received_events","type":"User","site_admin":false},"assignees":[{"login":"zhang-hua","id":2011059,"node_id":"MDQ6VXNlcjIwMTEwNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2011059?v=4","gravatar_id":"","url":"https://api.github.com/users/zhang-hua","html_url":"https://github.com/zhang-hua","followers_url":"https://api.github.com/users/zhang-hua/followers","following_url":"https://api.github.com/users/zhang-hua/following{/other_user}","gists_url":"https://api.github.com/users/zhang-hua/gists{/gist_id}","starred_url":"https://api.github.com/users/zhang-hua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhang-hua/subscriptions","organizations_url":"https://api.github.com/users/zhang-hua/orgs","repos_url":"https://api.github.com/users/zhang-hua/repos","events_url":"https://api.github.com/users/zhang-hua/events{/privacy}","received_events_url":"https://api.github.com/users/zhang-hua/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/pulls/89/commits","review_comments_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/pulls/89/comments","review_comment_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/issues/89/comments","statuses_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/statuses/5adce1600ce9b44d09afa52a6965dee624233df7","head":{"label":"Azure:bug_querybuilder","ref":"bug_querybuilder","sha":"5adce1600ce9b44d09afa52a6965dee624233df7","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":94933957,"node_id":"MDEwOlJlcG9zaXRvcnk5NDkzMzk1Nw==","name":"device-telemetry-dotnet","full_name":"Azure/device-telemetry-dotnet","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/device-telemetry-dotnet","description":"Device telemetry implementation in .NET for PCS","fork":false,"url":"https://api.github.com/repos/Azure/device-telemetry-dotnet","forks_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/forks","keys_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/teams","hooks_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/events","assignees_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/tags","blobs_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/languages","stargazers_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/subscription","commits_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/merges","archive_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/downloads","issues_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/deployments","created_at":"2017-06-20T20:51:02Z","updated_at":"2018-06-30T05:00:33Z","pushed_at":"2018-07-03T01:44:04Z","git_url":"git://github.com/Azure/device-telemetry-dotnet.git","ssh_url":"git@github.com:Azure/device-telemetry-dotnet.git","clone_url":"https://github.com/Azure/device-telemetry-dotnet.git","svn_url":"https://github.com/Azure/device-telemetry-dotnet","homepage":null,"size":292,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":14,"watchers":4,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"fea01682a6b3f23aefc481489082c1863bd78527","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":94933957,"node_id":"MDEwOlJlcG9zaXRvcnk5NDkzMzk1Nw==","name":"device-telemetry-dotnet","full_name":"Azure/device-telemetry-dotnet","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/device-telemetry-dotnet","description":"Device telemetry implementation in .NET for PCS","fork":false,"url":"https://api.github.com/repos/Azure/device-telemetry-dotnet","forks_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/forks","keys_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/teams","hooks_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/events","assignees_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/tags","blobs_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/languages","stargazers_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/subscription","commits_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/merges","archive_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/downloads","issues_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/device-telemetry-dotnet/deployments","created_at":"2017-06-20T20:51:02Z","updated_at":"2018-06-30T05:00:33Z","pushed_at":"2018-07-03T01:44:04Z","git_url":"git://github.com/Azure/device-telemetry-dotnet.git","ssh_url":"git@github.com:Azure/device-telemetry-dotnet.git","clone_url":"https://github.com/Azure/device-telemetry-dotnet.git","svn_url":"https://github.com/Azure/device-telemetry-dotnet","homepage":null,"size":292,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":14,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/device-telemetry-dotnet/pulls/89"},"html":{"href":"https://github.com/Azure/device-telemetry-dotnet/pull/89"},"issue":{"href":"https://api.github.com/repos/Azure/device-telemetry-dotnet/issues/89"},"comments":{"href":"https://api.github.com/repos/Azure/device-telemetry-dotnet/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/device-telemetry-dotnet/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/device-telemetry-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/device-telemetry-dotnet/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/device-telemetry-dotnet/statuses/5adce1600ce9b44d09afa52a6965dee624233df7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"zhang-hua"}}