{"action":"created","comment":{"url":"https://api.github.com/repos/aeternity/elixir-node/pulls/comments/181597613","pull_request_review_id":112251117,"id":181597613,"diff_hunk":"@@ -76,7 +76,10 @@ defmodule AecoreChainstateTest do\n   def apply_txs_on_state!(txs, chainstate, block_height) do\n     txs\n     |> Enum.reduce(chainstate, fn tx, chainstate ->\n-      Chainstate.apply_transaction_on_state!(tx, chainstate, block_height)\n+      case Chainstate.apply_transaction_on_state(tx, chainstate, block_height) do\n+        {:ok, new_state} -> new_state\n+        {:error, _reason} -> chainstate","path":"apps/aecore/test/aecore_chain_state_test.exs","position":7,"original_position":7,"commit_id":"73f685fcbf43615d9d6b43f8b68d07fa8c0d94cc","original_commit_id":"73f685fcbf43615d9d6b43f8b68d07fa8c0d94cc","user":{"login":"cytadela8","id":3736271,"avatar_url":"https://avatars0.githubusercontent.com/u/3736271?v=4","gravatar_id":"","url":"https://api.github.com/users/cytadela8","html_url":"https://github.com/cytadela8","followers_url":"https://api.github.com/users/cytadela8/followers","following_url":"https://api.github.com/users/cytadela8/following{/other_user}","gists_url":"https://api.github.com/users/cytadela8/gists{/gist_id}","starred_url":"https://api.github.com/users/cytadela8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cytadela8/subscriptions","organizations_url":"https://api.github.com/users/cytadela8/orgs","repos_url":"https://api.github.com/users/cytadela8/repos","events_url":"https://api.github.com/users/cytadela8/events{/privacy}","received_events_url":"https://api.github.com/users/cytadela8/received_events","type":"User","site_admin":false},"body":"We should probably fail the test or report some error in `{:error, _}` case ","created_at":"2018-04-15T21:24:29Z","updated_at":"2018-04-15T21:28:39Z","html_url":"https://github.com/aeternity/elixir-node/pull/343#discussion_r181597613","pull_request_url":"https://api.github.com/repos/aeternity/elixir-node/pulls/343","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aeternity/elixir-node/pulls/comments/181597613"},"html":{"href":"https://github.com/aeternity/elixir-node/pull/343#discussion_r181597613"},"pull_request":{"href":"https://api.github.com/repos/aeternity/elixir-node/pulls/343"}}},"pull_request":{"url":"https://api.github.com/repos/aeternity/elixir-node/pulls/343","id":180565244,"html_url":"https://github.com/aeternity/elixir-node/pull/343","diff_url":"https://github.com/aeternity/elixir-node/pull/343.diff","patch_url":"https://github.com/aeternity/elixir-node/pull/343.patch","issue_url":"https://api.github.com/repos/aeternity/elixir-node/issues/343","number":343,"state":"open","locked":false,"title":"[GH-#329] Removed try/catch statements and refactored error handiling","user":{"login":"gspasov","id":25534303,"avatar_url":"https://avatars3.githubusercontent.com/u/25534303?v=4","gravatar_id":"","url":"https://api.github.com/users/gspasov","html_url":"https://github.com/gspasov","followers_url":"https://api.github.com/users/gspasov/followers","following_url":"https://api.github.com/users/gspasov/following{/other_user}","gists_url":"https://api.github.com/users/gspasov/gists{/gist_id}","starred_url":"https://api.github.com/users/gspasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gspasov/subscriptions","organizations_url":"https://api.github.com/users/gspasov/orgs","repos_url":"https://api.github.com/users/gspasov/repos","events_url":"https://api.github.com/users/gspasov/events{/privacy}","received_events_url":"https://api.github.com/users/gspasov/received_events","type":"User","site_admin":false},"body":"resolves #329 ","created_at":"2018-04-10T11:04:00Z","updated_at":"2018-04-15T21:28:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91aa256ebc8a319307e235b56631c630998cf04f","assignee":{"login":"gspasov","id":25534303,"avatar_url":"https://avatars3.githubusercontent.com/u/25534303?v=4","gravatar_id":"","url":"https://api.github.com/users/gspasov","html_url":"https://github.com/gspasov","followers_url":"https://api.github.com/users/gspasov/followers","following_url":"https://api.github.com/users/gspasov/following{/other_user}","gists_url":"https://api.github.com/users/gspasov/gists{/gist_id}","starred_url":"https://api.github.com/users/gspasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gspasov/subscriptions","organizations_url":"https://api.github.com/users/gspasov/orgs","repos_url":"https://api.github.com/users/gspasov/repos","events_url":"https://api.github.com/users/gspasov/events{/privacy}","received_events_url":"https://api.github.com/users/gspasov/received_events","type":"User","site_admin":false},"assignees":[{"login":"gspasov","id":25534303,"avatar_url":"https://avatars3.githubusercontent.com/u/25534303?v=4","gravatar_id":"","url":"https://api.github.com/users/gspasov","html_url":"https://github.com/gspasov","followers_url":"https://api.github.com/users/gspasov/followers","following_url":"https://api.github.com/users/gspasov/following{/other_user}","gists_url":"https://api.github.com/users/gspasov/gists{/gist_id}","starred_url":"https://api.github.com/users/gspasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gspasov/subscriptions","organizations_url":"https://api.github.com/users/gspasov/orgs","repos_url":"https://api.github.com/users/gspasov/repos","events_url":"https://api.github.com/users/gspasov/events{/privacy}","received_events_url":"https://api.github.com/users/gspasov/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"meivantodorov","id":12221083,"avatar_url":"https://avatars2.githubusercontent.com/u/12221083?v=4","gravatar_id":"","url":"https://api.github.com/users/meivantodorov","html_url":"https://github.com/meivantodorov","followers_url":"https://api.github.com/users/meivantodorov/followers","following_url":"https://api.github.com/users/meivantodorov/following{/other_user}","gists_url":"https://api.github.com/users/meivantodorov/gists{/gist_id}","starred_url":"https://api.github.com/users/meivantodorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meivantodorov/subscriptions","organizations_url":"https://api.github.com/users/meivantodorov/orgs","repos_url":"https://api.github.com/users/meivantodorov/repos","events_url":"https://api.github.com/users/meivantodorov/events{/privacy}","received_events_url":"https://api.github.com/users/meivantodorov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":686148098,"url":"https://api.github.com/repos/aeternity/elixir-node/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":864476826,"url":"https://api.github.com/repos/aeternity/elixir-node/labels/non-spec","name":"non-spec","color":"b2ff47","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aeternity/elixir-node/pulls/343/commits","review_comments_url":"https://api.github.com/repos/aeternity/elixir-node/pulls/343/comments","review_comment_url":"https://api.github.com/repos/aeternity/elixir-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aeternity/elixir-node/issues/343/comments","statuses_url":"https://api.github.com/repos/aeternity/elixir-node/statuses/73f685fcbf43615d9d6b43f8b68d07fa8c0d94cc","head":{"label":"aeternity:GH-329","ref":"GH-329","sha":"73f685fcbf43615d9d6b43f8b68d07fa8c0d94cc","user":{"login":"aeternity","id":21989234,"avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":102751238,"name":"elixir-node","full_name":"aeternity/elixir-node","owner":{"login":"aeternity","id":21989234,"avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aeternity/elixir-node","description":"Elixir full node implementation of the aeternity specification","fork":false,"url":"https://api.github.com/repos/aeternity/elixir-node","forks_url":"https://api.github.com/repos/aeternity/elixir-node/forks","keys_url":"https://api.github.com/repos/aeternity/elixir-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/elixir-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/elixir-node/teams","hooks_url":"https://api.github.com/repos/aeternity/elixir-node/hooks","issue_events_url":"https://api.github.com/repos/aeternity/elixir-node/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/elixir-node/events","assignees_url":"https://api.github.com/repos/aeternity/elixir-node/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/elixir-node/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/elixir-node/tags","blobs_url":"https://api.github.com/repos/aeternity/elixir-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/elixir-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/elixir-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/elixir-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/elixir-node/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/elixir-node/languages","stargazers_url":"https://api.github.com/repos/aeternity/elixir-node/stargazers","contributors_url":"https://api.github.com/repos/aeternity/elixir-node/contributors","subscribers_url":"https://api.github.com/repos/aeternity/elixir-node/subscribers","subscription_url":"https://api.github.com/repos/aeternity/elixir-node/subscription","commits_url":"https://api.github.com/repos/aeternity/elixir-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/elixir-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/elixir-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/elixir-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/elixir-node/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/elixir-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/elixir-node/merges","archive_url":"https://api.github.com/repos/aeternity/elixir-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/elixir-node/downloads","issues_url":"https://api.github.com/repos/aeternity/elixir-node/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/elixir-node/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/elixir-node/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/elixir-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/elixir-node/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/elixir-node/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/elixir-node/deployments","created_at":"2017-09-07T15:04:18Z","updated_at":"2018-04-15T20:39:46Z","pushed_at":"2018-04-15T20:39:42Z","git_url":"git://github.com/aeternity/elixir-node.git","ssh_url":"git@github.com:aeternity/elixir-node.git","clone_url":"https://github.com/aeternity/elixir-node.git","svn_url":"https://github.com/aeternity/elixir-node","homepage":"","size":2549,"stargazers_count":123,"watchers_count":123,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":24,"open_issues":26,"watchers":123,"default_branch":"master"}},"base":{"label":"aeternity:master","ref":"master","sha":"03880f4a5ab5fa25ad0033809827618e4be1d500","user":{"login":"aeternity","id":21989234,"avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":102751238,"name":"elixir-node","full_name":"aeternity/elixir-node","owner":{"login":"aeternity","id":21989234,"avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aeternity/elixir-node","description":"Elixir full node implementation of the aeternity specification","fork":false,"url":"https://api.github.com/repos/aeternity/elixir-node","forks_url":"https://api.github.com/repos/aeternity/elixir-node/forks","keys_url":"https://api.github.com/repos/aeternity/elixir-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/elixir-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/elixir-node/teams","hooks_url":"https://api.github.com/repos/aeternity/elixir-node/hooks","issue_events_url":"https://api.github.com/repos/aeternity/elixir-node/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/elixir-node/events","assignees_url":"https://api.github.com/repos/aeternity/elixir-node/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/elixir-node/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/elixir-node/tags","blobs_url":"https://api.github.com/repos/aeternity/elixir-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/elixir-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/elixir-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/elixir-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/elixir-node/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/elixir-node/languages","stargazers_url":"https://api.github.com/repos/aeternity/elixir-node/stargazers","contributors_url":"https://api.github.com/repos/aeternity/elixir-node/contributors","subscribers_url":"https://api.github.com/repos/aeternity/elixir-node/subscribers","subscription_url":"https://api.github.com/repos/aeternity/elixir-node/subscription","commits_url":"https://api.github.com/repos/aeternity/elixir-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/elixir-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/elixir-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/elixir-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/elixir-node/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/elixir-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/elixir-node/merges","archive_url":"https://api.github.com/repos/aeternity/elixir-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/elixir-node/downloads","issues_url":"https://api.github.com/repos/aeternity/elixir-node/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/elixir-node/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/elixir-node/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/elixir-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/elixir-node/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/elixir-node/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/elixir-node/deployments","created_at":"2017-09-07T15:04:18Z","updated_at":"2018-04-15T20:39:46Z","pushed_at":"2018-04-15T20:39:42Z","git_url":"git://github.com/aeternity/elixir-node.git","ssh_url":"git@github.com:aeternity/elixir-node.git","clone_url":"https://github.com/aeternity/elixir-node.git","svn_url":"https://github.com/aeternity/elixir-node","homepage":"","size":2549,"stargazers_count":123,"watchers_count":123,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":24,"open_issues":26,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aeternity/elixir-node/pulls/343"},"html":{"href":"https://github.com/aeternity/elixir-node/pull/343"},"issue":{"href":"https://api.github.com/repos/aeternity/elixir-node/issues/343"},"comments":{"href":"https://api.github.com/repos/aeternity/elixir-node/issues/343/comments"},"review_comments":{"href":"https://api.github.com/repos/aeternity/elixir-node/pulls/343/comments"},"review_comment":{"href":"https://api.github.com/repos/aeternity/elixir-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aeternity/elixir-node/pulls/343/commits"},"statuses":{"href":"https://api.github.com/repos/aeternity/elixir-node/statuses/73f685fcbf43615d9d6b43f8b68d07fa8c0d94cc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cytadela8"}}