{"action":"created","comment":{"url":"https://api.github.com/repos/NewMotion/ocpp/pulls/comments/215609317","pull_request_review_id":152909253,"id":215609317,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTYwOTMxNw==","diff_hunk":"@@ -478,6 +488,15 @@ object SerializationV16 extends SerializationCommon {\n     )\n   }\n \n+  private implicit class RichDataTransferStatus(dataTransferStatus: messages.DataTransferStatus) {\n+    def toV16: String = dataTransferStatus.name\n+  }\n+\n+  private implicit class RichV16DataTransferStatus(self: String) {\n+    def fromV16: messages.DataTransferStatus = messages.DataTransferStatus.withName(self).get","path":"ocpp-json/src/main/scala/com/thenewmotion/ocpp/json/v16/SerializationV16.scala","position":26,"original_position":26,"commit_id":"054a091406f501ae25798a52bb25badee4386aac","original_commit_id":"ab7c5645bae0cf0245914cd2d55beaf67124ad29","user":{"login":"reinierl","id":3717697,"node_id":"MDQ6VXNlcjM3MTc2OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3717697?v=4","gravatar_id":"","url":"https://api.github.com/users/reinierl","html_url":"https://github.com/reinierl","followers_url":"https://api.github.com/users/reinierl/followers","following_url":"https://api.github.com/users/reinierl/following{/other_user}","gists_url":"https://api.github.com/users/reinierl/gists{/gist_id}","starred_url":"https://api.github.com/users/reinierl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reinierl/subscriptions","organizations_url":"https://api.github.com/users/reinierl/orgs","repos_url":"https://api.github.com/users/reinierl/repos","events_url":"https://api.github.com/users/reinierl/events{/privacy}","received_events_url":"https://api.github.com/users/reinierl/received_events","type":"User","site_admin":false},"body":"Aren't you calling .get here on an `Option` that is created from untrusted network input?","created_at":"2018-09-06T12:41:23Z","updated_at":"2018-09-06T12:41:24Z","html_url":"https://github.com/NewMotion/ocpp/pull/21#discussion_r215609317","pull_request_url":"https://api.github.com/repos/NewMotion/ocpp/pulls/21","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NewMotion/ocpp/pulls/comments/215609317"},"html":{"href":"https://github.com/NewMotion/ocpp/pull/21#discussion_r215609317"},"pull_request":{"href":"https://api.github.com/repos/NewMotion/ocpp/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/NewMotion/ocpp/pulls/21","id":167446490,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY3NDQ2NDkw","html_url":"https://github.com/NewMotion/ocpp/pull/21","diff_url":"https://github.com/NewMotion/ocpp/pull/21.diff","patch_url":"https://github.com/NewMotion/ocpp/pull/21.patch","issue_url":"https://api.github.com/repos/NewMotion/ocpp/issues/21","number":21,"state":"closed","locked":false,"title":"TNM-5694 Implement support for DataTransfer message","user":{"login":"gertjana","id":496555,"node_id":"MDQ6VXNlcjQ5NjU1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/496555?v=4","gravatar_id":"","url":"https://api.github.com/users/gertjana","html_url":"https://github.com/gertjana","followers_url":"https://api.github.com/users/gertjana/followers","following_url":"https://api.github.com/users/gertjana/following{/other_user}","gists_url":"https://api.github.com/users/gertjana/gists{/gist_id}","starred_url":"https://api.github.com/users/gertjana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gertjana/subscriptions","organizations_url":"https://api.github.com/users/gertjana/orgs","repos_url":"https://api.github.com/users/gertjana/repos","events_url":"https://api.github.com/users/gertjana/events{/privacy}","received_events_url":"https://api.github.com/users/gertjana/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-06T15:31:51Z","updated_at":"2018-09-06T12:41:24Z","closed_at":"2018-02-07T08:32:21Z","merged_at":"2018-02-07T08:32:21Z","merge_commit_sha":"14c625da27b8b1b37946cae93ab20930bace38b9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NewMotion/ocpp/pulls/21/commits","review_comments_url":"https://api.github.com/repos/NewMotion/ocpp/pulls/21/comments","review_comment_url":"https://api.github.com/repos/NewMotion/ocpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NewMotion/ocpp/issues/21/comments","statuses_url":"https://api.github.com/repos/NewMotion/ocpp/statuses/054a091406f501ae25798a52bb25badee4386aac","head":{"label":"NewMotion:TNM-5694","ref":"TNM-5694","sha":"054a091406f501ae25798a52bb25badee4386aac","user":{"login":"NewMotion","id":799802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5OTgwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/799802?v=4","gravatar_id":"","url":"https://api.github.com/users/NewMotion","html_url":"https://github.com/NewMotion","followers_url":"https://api.github.com/users/NewMotion/followers","following_url":"https://api.github.com/users/NewMotion/following{/other_user}","gists_url":"https://api.github.com/users/NewMotion/gists{/gist_id}","starred_url":"https://api.github.com/users/NewMotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NewMotion/subscriptions","organizations_url":"https://api.github.com/users/NewMotion/orgs","repos_url":"https://api.github.com/users/NewMotion/repos","events_url":"https://api.github.com/users/NewMotion/events{/privacy}","received_events_url":"https://api.github.com/users/NewMotion/received_events","type":"Organization","site_admin":false},"repo":{"id":5255704,"node_id":"MDEwOlJlcG9zaXRvcnk1MjU1NzA0","name":"ocpp","full_name":"NewMotion/ocpp","owner":{"login":"NewMotion","id":799802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5OTgwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/799802?v=4","gravatar_id":"","url":"https://api.github.com/users/NewMotion","html_url":"https://github.com/NewMotion","followers_url":"https://api.github.com/users/NewMotion/followers","following_url":"https://api.github.com/users/NewMotion/following{/other_user}","gists_url":"https://api.github.com/users/NewMotion/gists{/gist_id}","starred_url":"https://api.github.com/users/NewMotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NewMotion/subscriptions","organizations_url":"https://api.github.com/users/NewMotion/orgs","repos_url":"https://api.github.com/users/NewMotion/repos","events_url":"https://api.github.com/users/NewMotion/events{/privacy}","received_events_url":"https://api.github.com/users/NewMotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NewMotion/ocpp","description":"Open Charge Point Protocol","fork":false,"url":"https://api.github.com/repos/NewMotion/ocpp","forks_url":"https://api.github.com/repos/NewMotion/ocpp/forks","keys_url":"https://api.github.com/repos/NewMotion/ocpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NewMotion/ocpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NewMotion/ocpp/teams","hooks_url":"https://api.github.com/repos/NewMotion/ocpp/hooks","issue_events_url":"https://api.github.com/repos/NewMotion/ocpp/issues/events{/number}","events_url":"https://api.github.com/repos/NewMotion/ocpp/events","assignees_url":"https://api.github.com/repos/NewMotion/ocpp/assignees{/user}","branches_url":"https://api.github.com/repos/NewMotion/ocpp/branches{/branch}","tags_url":"https://api.github.com/repos/NewMotion/ocpp/tags","blobs_url":"https://api.github.com/repos/NewMotion/ocpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NewMotion/ocpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NewMotion/ocpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/NewMotion/ocpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NewMotion/ocpp/statuses/{sha}","languages_url":"https://api.github.com/repos/NewMotion/ocpp/languages","stargazers_url":"https://api.github.com/repos/NewMotion/ocpp/stargazers","contributors_url":"https://api.github.com/repos/NewMotion/ocpp/contributors","subscribers_url":"https://api.github.com/repos/NewMotion/ocpp/subscribers","subscription_url":"https://api.github.com/repos/NewMotion/ocpp/subscription","commits_url":"https://api.github.com/repos/NewMotion/ocpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/NewMotion/ocpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/NewMotion/ocpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/NewMotion/ocpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/NewMotion/ocpp/contents/{+path}","compare_url":"https://api.github.com/repos/NewMotion/ocpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NewMotion/ocpp/merges","archive_url":"https://api.github.com/repos/NewMotion/ocpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NewMotion/ocpp/downloads","issues_url":"https://api.github.com/repos/NewMotion/ocpp/issues{/number}","pulls_url":"https://api.github.com/repos/NewMotion/ocpp/pulls{/number}","milestones_url":"https://api.github.com/repos/NewMotion/ocpp/milestones{/number}","notifications_url":"https://api.github.com/repos/NewMotion/ocpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NewMotion/ocpp/labels{/name}","releases_url":"https://api.github.com/repos/NewMotion/ocpp/releases{/id}","deployments_url":"https://api.github.com/repos/NewMotion/ocpp/deployments","created_at":"2012-08-01T06:14:34Z","updated_at":"2018-09-06T10:59:26Z","pushed_at":"2018-09-06T10:59:29Z","git_url":"git://github.com/NewMotion/ocpp.git","ssh_url":"git@github.com:NewMotion/ocpp.git","clone_url":"https://github.com/NewMotion/ocpp.git","svn_url":"https://github.com/NewMotion/ocpp","homepage":"","size":2425,"stargazers_count":40,"watchers_count":40,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":21,"open_issues":1,"watchers":40,"default_branch":"master"}},"base":{"label":"NewMotion:master","ref":"master","sha":"677e53c05ede002ff1f3189c8443af0b9845bfc1","user":{"login":"NewMotion","id":799802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5OTgwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/799802?v=4","gravatar_id":"","url":"https://api.github.com/users/NewMotion","html_url":"https://github.com/NewMotion","followers_url":"https://api.github.com/users/NewMotion/followers","following_url":"https://api.github.com/users/NewMotion/following{/other_user}","gists_url":"https://api.github.com/users/NewMotion/gists{/gist_id}","starred_url":"https://api.github.com/users/NewMotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NewMotion/subscriptions","organizations_url":"https://api.github.com/users/NewMotion/orgs","repos_url":"https://api.github.com/users/NewMotion/repos","events_url":"https://api.github.com/users/NewMotion/events{/privacy}","received_events_url":"https://api.github.com/users/NewMotion/received_events","type":"Organization","site_admin":false},"repo":{"id":5255704,"node_id":"MDEwOlJlcG9zaXRvcnk1MjU1NzA0","name":"ocpp","full_name":"NewMotion/ocpp","owner":{"login":"NewMotion","id":799802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5OTgwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/799802?v=4","gravatar_id":"","url":"https://api.github.com/users/NewMotion","html_url":"https://github.com/NewMotion","followers_url":"https://api.github.com/users/NewMotion/followers","following_url":"https://api.github.com/users/NewMotion/following{/other_user}","gists_url":"https://api.github.com/users/NewMotion/gists{/gist_id}","starred_url":"https://api.github.com/users/NewMotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NewMotion/subscriptions","organizations_url":"https://api.github.com/users/NewMotion/orgs","repos_url":"https://api.github.com/users/NewMotion/repos","events_url":"https://api.github.com/users/NewMotion/events{/privacy}","received_events_url":"https://api.github.com/users/NewMotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NewMotion/ocpp","description":"Open Charge Point Protocol","fork":false,"url":"https://api.github.com/repos/NewMotion/ocpp","forks_url":"https://api.github.com/repos/NewMotion/ocpp/forks","keys_url":"https://api.github.com/repos/NewMotion/ocpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NewMotion/ocpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NewMotion/ocpp/teams","hooks_url":"https://api.github.com/repos/NewMotion/ocpp/hooks","issue_events_url":"https://api.github.com/repos/NewMotion/ocpp/issues/events{/number}","events_url":"https://api.github.com/repos/NewMotion/ocpp/events","assignees_url":"https://api.github.com/repos/NewMotion/ocpp/assignees{/user}","branches_url":"https://api.github.com/repos/NewMotion/ocpp/branches{/branch}","tags_url":"https://api.github.com/repos/NewMotion/ocpp/tags","blobs_url":"https://api.github.com/repos/NewMotion/ocpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NewMotion/ocpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NewMotion/ocpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/NewMotion/ocpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NewMotion/ocpp/statuses/{sha}","languages_url":"https://api.github.com/repos/NewMotion/ocpp/languages","stargazers_url":"https://api.github.com/repos/NewMotion/ocpp/stargazers","contributors_url":"https://api.github.com/repos/NewMotion/ocpp/contributors","subscribers_url":"https://api.github.com/repos/NewMotion/ocpp/subscribers","subscription_url":"https://api.github.com/repos/NewMotion/ocpp/subscription","commits_url":"https://api.github.com/repos/NewMotion/ocpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/NewMotion/ocpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/NewMotion/ocpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/NewMotion/ocpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/NewMotion/ocpp/contents/{+path}","compare_url":"https://api.github.com/repos/NewMotion/ocpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NewMotion/ocpp/merges","archive_url":"https://api.github.com/repos/NewMotion/ocpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NewMotion/ocpp/downloads","issues_url":"https://api.github.com/repos/NewMotion/ocpp/issues{/number}","pulls_url":"https://api.github.com/repos/NewMotion/ocpp/pulls{/number}","milestones_url":"https://api.github.com/repos/NewMotion/ocpp/milestones{/number}","notifications_url":"https://api.github.com/repos/NewMotion/ocpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NewMotion/ocpp/labels{/name}","releases_url":"https://api.github.com/repos/NewMotion/ocpp/releases{/id}","deployments_url":"https://api.github.com/repos/NewMotion/ocpp/deployments","created_at":"2012-08-01T06:14:34Z","updated_at":"2018-09-06T10:59:26Z","pushed_at":"2018-09-06T10:59:29Z","git_url":"git://github.com/NewMotion/ocpp.git","ssh_url":"git@github.com:NewMotion/ocpp.git","clone_url":"https://github.com/NewMotion/ocpp.git","svn_url":"https://github.com/NewMotion/ocpp","homepage":"","size":2425,"stargazers_count":40,"watchers_count":40,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":21,"open_issues":1,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NewMotion/ocpp/pulls/21"},"html":{"href":"https://github.com/NewMotion/ocpp/pull/21"},"issue":{"href":"https://api.github.com/repos/NewMotion/ocpp/issues/21"},"comments":{"href":"https://api.github.com/repos/NewMotion/ocpp/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/NewMotion/ocpp/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/NewMotion/ocpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NewMotion/ocpp/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/NewMotion/ocpp/statuses/054a091406f501ae25798a52bb25badee4386aac"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"reinierl"}}