{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/comments/168127589","pull_request_review_id":96442047,"id":168127589,"diff_hunk":"@@ -19,6 +19,8 @@ export class CheckCountryConstraint implements ValidatorConstraintInterface {\n   async validate (value: any | string, args?: ValidationArguments): Promise<boolean> {\n     if (value === undefined || value === null || value === '') {\n       return true\n+    } else if (value.toUpperCase().startsWith('IM')) {","path":"src/main/app/forms/validation/validators/isCountrySupported.ts","position":4,"original_position":4,"commit_id":"26b17cac1c939e1e7781b0fb2cad5a9411ddb7b8","original_commit_id":"a8698dfa5ea93fcbf0464ea6363aaf8beb1e3cfd","user":{"login":"geek-soft","id":1724691,"avatar_url":"https://avatars0.githubusercontent.com/u/1724691?v=4","gravatar_id":"","url":"https://api.github.com/users/geek-soft","html_url":"https://github.com/geek-soft","followers_url":"https://api.github.com/users/geek-soft/followers","following_url":"https://api.github.com/users/geek-soft/following{/other_user}","gists_url":"https://api.github.com/users/geek-soft/gists{/gist_id}","starred_url":"https://api.github.com/users/geek-soft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geek-soft/subscriptions","organizations_url":"https://api.github.com/users/geek-soft/orgs","repos_url":"https://api.github.com/users/geek-soft/repos","events_url":"https://api.github.com/users/geek-soft/events{/privacy}","received_events_url":"https://api.github.com/users/geek-soft/received_events","type":"User","site_admin":false},"body":"The implementation is not very readable. Can you extract 'IM' into collection that states what post codes are blacklisted. Variable name will hopefully give us more context.\r\n\r\nAlso use regular `if` instead of `else if` since previous statement returns early.","created_at":"2018-02-14T10:08:12Z","updated_at":"2018-02-14T10:08:48Z","html_url":"https://github.com/hmcts/cmc-citizen-frontend/pull/372#discussion_r168127589","pull_request_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/372","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/comments/168127589"},"html":{"href":"https://github.com/hmcts/cmc-citizen-frontend/pull/372#discussion_r168127589"},"pull_request":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/372"}},"in_reply_to_id":167876699},"pull_request":{"url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/372","id":168832091,"html_url":"https://github.com/hmcts/cmc-citizen-frontend/pull/372","diff_url":"https://github.com/hmcts/cmc-citizen-frontend/pull/372.diff","patch_url":"https://github.com/hmcts/cmc-citizen-frontend/pull/372.patch","issue_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/372","number":372,"state":"open","locked":false,"title":"ROC-3054 Check country","user":{"login":"robertparkinson","id":8955824,"avatar_url":"https://avatars3.githubusercontent.com/u/8955824?v=4","gravatar_id":"","url":"https://api.github.com/users/robertparkinson","html_url":"https://github.com/robertparkinson","followers_url":"https://api.github.com/users/robertparkinson/followers","following_url":"https://api.github.com/users/robertparkinson/following{/other_user}","gists_url":"https://api.github.com/users/robertparkinson/gists{/gist_id}","starred_url":"https://api.github.com/users/robertparkinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertparkinson/subscriptions","organizations_url":"https://api.github.com/users/robertparkinson/orgs","repos_url":"https://api.github.com/users/robertparkinson/repos","events_url":"https://api.github.com/users/robertparkinson/events{/privacy}","received_events_url":"https://api.github.com/users/robertparkinson/received_events","type":"User","site_admin":false},"body":"### JIRA link\r\nhttps://tools.hmcts.net/jira/browse/ROC-3054\r\n\r\n### Change description\r\nDo not allow Isle of Man postcodes\r\n\r\n### Work checklist\r\n\r\n- [x] Unit tests added where applicable\r\n- [ ] Route tests added for new pages\r\n- [ ] New pages included in a11y tests\r\n- [ ] Task list and task completeness checks updated\r\n- [ ] Check and send page updated\r\n- [ ] Routes, page content and page flows of new features are toggled \r\n- [ ] UI changes look good on mobile\r\n- [ ] Required Google Analytics events are being sent \r\n\r\n### Developer self-QA run statement\r\n\r\n- [x] I have clicked through the running application to see if all changes I made actually work.\r\n\r\n### Does this PR introduce a breaking change?\r\n\r\n- [ ] Yes\r\n- [x] No\r\n","created_at":"2018-02-13T12:29:33Z","updated_at":"2018-02-14T10:08:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"440edfb492f4f87393d56fb66110c5c6be51c862","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/372/commits","review_comments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/372/comments","review_comment_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/372/comments","statuses_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/statuses/26b17cac1c939e1e7781b0fb2cad5a9411ddb7b8","head":{"label":"hmcts:feature/ROC-3054-check-country","ref":"feature/ROC-3054-check-country","sha":"26b17cac1c939e1e7781b0fb2cad5a9411ddb7b8","user":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":100393203,"name":"cmc-citizen-frontend","full_name":"hmcts/cmc-citizen-frontend","owner":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/cmc-citizen-frontend","description":"Citizen frontend application for Civil Money Claims","fork":false,"url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend","forks_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/forks","keys_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/teams","hooks_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/events","assignees_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/tags","blobs_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/languages","stargazers_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/subscription","commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/merges","archive_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/downloads","issues_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/deployments","created_at":"2017-08-15T15:44:48Z","updated_at":"2017-11-05T14:28:24Z","pushed_at":"2018-02-14T08:29:13Z","git_url":"git://github.com/hmcts/cmc-citizen-frontend.git","ssh_url":"git@github.com:hmcts/cmc-citizen-frontend.git","clone_url":"https://github.com/hmcts/cmc-citizen-frontend.git","svn_url":"https://github.com/hmcts/cmc-citizen-frontend","homepage":"","size":2287,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":8,"watchers":1,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"640e911ec22c90225574b1a3b8745cc5603cf110","user":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":100393203,"name":"cmc-citizen-frontend","full_name":"hmcts/cmc-citizen-frontend","owner":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/cmc-citizen-frontend","description":"Citizen frontend application for Civil Money Claims","fork":false,"url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend","forks_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/forks","keys_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/teams","hooks_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/events","assignees_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/tags","blobs_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/languages","stargazers_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/subscription","commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/merges","archive_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/downloads","issues_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/deployments","created_at":"2017-08-15T15:44:48Z","updated_at":"2017-11-05T14:28:24Z","pushed_at":"2018-02-14T08:29:13Z","git_url":"git://github.com/hmcts/cmc-citizen-frontend.git","ssh_url":"git@github.com:hmcts/cmc-citizen-frontend.git","clone_url":"https://github.com/hmcts/cmc-citizen-frontend.git","svn_url":"https://github.com/hmcts/cmc-citizen-frontend","homepage":"","size":2287,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/372"},"html":{"href":"https://github.com/hmcts/cmc-citizen-frontend/pull/372"},"issue":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/372"},"comments":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/372/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/372/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/372/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/statuses/26b17cac1c939e1e7781b0fb2cad5a9411ddb7b8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"geek-soft"}}