{"action":"opened","number":3405,"pull_request":{"url":"https://api.github.com/repos/matrix-org/synapse/pulls/3405","id":195371718,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzcxNzE4","html_url":"https://github.com/matrix-org/synapse/pull/3405","diff_url":"https://github.com/matrix-org/synapse/pull/3405.diff","patch_url":"https://github.com/matrix-org/synapse/pull/3405.patch","issue_url":"https://api.github.com/repos/matrix-org/synapse/issues/3405","number":3405,"state":"open","locked":false,"title":"fix the check for whether `is_url` to match all the other ones in codebase","user":{"login":"t3chguy","id":2403652,"node_id":"MDQ6VXNlcjI0MDM2NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2403652?v=4","gravatar_id":"","url":"https://api.github.com/users/t3chguy","html_url":"https://github.com/t3chguy","followers_url":"https://api.github.com/users/t3chguy/followers","following_url":"https://api.github.com/users/t3chguy/following{/other_user}","gists_url":"https://api.github.com/users/t3chguy/gists{/gist_id}","starred_url":"https://api.github.com/users/t3chguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t3chguy/subscriptions","organizations_url":"https://api.github.com/users/t3chguy/orgs","repos_url":"https://api.github.com/users/t3chguy/repos","events_url":"https://api.github.com/users/t3chguy/events{/privacy}","received_events_url":"https://api.github.com/users/t3chguy/received_events","type":"User","site_admin":false},"body":"as this one did not check whether the value was a string and only checked its existence whereas the other two checked for both\r\n\r\n### Fixes https://github.com/vector-im/riot-web/issues/6250","created_at":"2018-06-17T10:42:03Z","updated_at":"2018-06-17T10:42:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/matrix-org/synapse/pulls/3405/commits","review_comments_url":"https://api.github.com/repos/matrix-org/synapse/pulls/3405/comments","review_comment_url":"https://api.github.com/repos/matrix-org/synapse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-org/synapse/issues/3405/comments","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/c7e2c01248426f7e59ecda14ac42e20ae2b70ee4","head":{"label":"t3chguy:t3chguy/fix_contains-url_filtering","ref":"t3chguy/fix_contains-url_filtering","sha":"c7e2c01248426f7e59ecda14ac42e20ae2b70ee4","user":{"login":"t3chguy","id":2403652,"node_id":"MDQ6VXNlcjI0MDM2NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2403652?v=4","gravatar_id":"","url":"https://api.github.com/users/t3chguy","html_url":"https://github.com/t3chguy","followers_url":"https://api.github.com/users/t3chguy/followers","following_url":"https://api.github.com/users/t3chguy/following{/other_user}","gists_url":"https://api.github.com/users/t3chguy/gists{/gist_id}","starred_url":"https://api.github.com/users/t3chguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t3chguy/subscriptions","organizations_url":"https://api.github.com/users/t3chguy/orgs","repos_url":"https://api.github.com/users/t3chguy/repos","events_url":"https://api.github.com/users/t3chguy/events{/privacy}","received_events_url":"https://api.github.com/users/t3chguy/received_events","type":"User","site_admin":false},"repo":{"id":96349326,"node_id":"MDEwOlJlcG9zaXRvcnk5NjM0OTMyNg==","name":"synapse","full_name":"t3chguy/synapse","owner":{"login":"t3chguy","id":2403652,"node_id":"MDQ6VXNlcjI0MDM2NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2403652?v=4","gravatar_id":"","url":"https://api.github.com/users/t3chguy","html_url":"https://github.com/t3chguy","followers_url":"https://api.github.com/users/t3chguy/followers","following_url":"https://api.github.com/users/t3chguy/following{/other_user}","gists_url":"https://api.github.com/users/t3chguy/gists{/gist_id}","starred_url":"https://api.github.com/users/t3chguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t3chguy/subscriptions","organizations_url":"https://api.github.com/users/t3chguy/orgs","repos_url":"https://api.github.com/users/t3chguy/repos","events_url":"https://api.github.com/users/t3chguy/events{/privacy}","received_events_url":"https://api.github.com/users/t3chguy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/t3chguy/synapse","description":"Synapse: Matrix reference homeserver","fork":true,"url":"https://api.github.com/repos/t3chguy/synapse","forks_url":"https://api.github.com/repos/t3chguy/synapse/forks","keys_url":"https://api.github.com/repos/t3chguy/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/t3chguy/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/t3chguy/synapse/teams","hooks_url":"https://api.github.com/repos/t3chguy/synapse/hooks","issue_events_url":"https://api.github.com/repos/t3chguy/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/t3chguy/synapse/events","assignees_url":"https://api.github.com/repos/t3chguy/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/t3chguy/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/t3chguy/synapse/tags","blobs_url":"https://api.github.com/repos/t3chguy/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/t3chguy/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/t3chguy/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/t3chguy/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/t3chguy/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/t3chguy/synapse/languages","stargazers_url":"https://api.github.com/repos/t3chguy/synapse/stargazers","contributors_url":"https://api.github.com/repos/t3chguy/synapse/contributors","subscribers_url":"https://api.github.com/repos/t3chguy/synapse/subscribers","subscription_url":"https://api.github.com/repos/t3chguy/synapse/subscription","commits_url":"https://api.github.com/repos/t3chguy/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/t3chguy/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/t3chguy/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/t3chguy/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/t3chguy/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/t3chguy/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/t3chguy/synapse/merges","archive_url":"https://api.github.com/repos/t3chguy/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/t3chguy/synapse/downloads","issues_url":"https://api.github.com/repos/t3chguy/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/t3chguy/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/t3chguy/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/t3chguy/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/t3chguy/synapse/labels{/name}","releases_url":"https://api.github.com/repos/t3chguy/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/t3chguy/synapse/deployments","created_at":"2017-07-05T18:27:48Z","updated_at":"2017-07-05T18:27:52Z","pushed_at":"2018-06-17T10:41:56Z","git_url":"git://github.com/t3chguy/synapse.git","ssh_url":"git@github.com:t3chguy/synapse.git","clone_url":"https://github.com/t3chguy/synapse.git","svn_url":"https://github.com/t3chguy/synapse","homepage":"http://matrix.org","size":17830,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matrix-org:develop","ref":"develop","sha":"ccfdaf68be5ffb179a81abf4cc44ec13e6984a60","user":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":22844864,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg0NDg2NA==","name":"synapse","full_name":"matrix-org/synapse","owner":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/synapse","description":"Synapse: Matrix reference homeserver","fork":false,"url":"https://api.github.com/repos/matrix-org/synapse","forks_url":"https://api.github.com/repos/matrix-org/synapse/forks","keys_url":"https://api.github.com/repos/matrix-org/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/synapse/teams","hooks_url":"https://api.github.com/repos/matrix-org/synapse/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/synapse/events","assignees_url":"https://api.github.com/repos/matrix-org/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/synapse/tags","blobs_url":"https://api.github.com/repos/matrix-org/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/synapse/languages","stargazers_url":"https://api.github.com/repos/matrix-org/synapse/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/synapse/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/synapse/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/synapse/subscription","commits_url":"https://api.github.com/repos/matrix-org/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/synapse/merges","archive_url":"https://api.github.com/repos/matrix-org/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/synapse/downloads","issues_url":"https://api.github.com/repos/matrix-org/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/synapse/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/synapse/deployments","created_at":"2014-08-11T15:51:42Z","updated_at":"2018-06-17T05:34:11Z","pushed_at":"2018-06-16T20:25:11Z","git_url":"git://github.com/matrix-org/synapse.git","ssh_url":"git@github.com:matrix-org/synapse.git","clone_url":"https://github.com/matrix-org/synapse.git","svn_url":"https://github.com/matrix-org/synapse","homepage":"http://matrix.org","size":19698,"stargazers_count":3016,"watchers_count":3016,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":421,"mirror_url":null,"archived":false,"open_issues_count":888,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":421,"open_issues":888,"watchers":3016,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/3405"},"html":{"href":"https://github.com/matrix-org/synapse/pull/3405"},"issue":{"href":"https://api.github.com/repos/matrix-org/synapse/issues/3405"},"comments":{"href":"https://api.github.com/repos/matrix-org/synapse/issues/3405/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/3405/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/3405/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-org/synapse/statuses/c7e2c01248426f7e59ecda14ac42e20ae2b70ee4"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":6,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"t3chguy"}}