{"action":"created","comment":{"url":"https://api.github.com/repos/git/git/pulls/comments/198064100","pull_request_review_id":131923168,"id":198064100,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODA2NDEwMA==","diff_hunk":"@@ -52,6 +57,13 @@ struct rebase_options {\n \tint preserve_merges;\n \tconst char *upstream_name;\n \tconst char *state_dir;\n+\tstruct commit *upstream;","path":"builtin/rebase.c","position":null,"original_position":16,"commit_id":"b2fc54872f2bce5e460f4a73cae16b8b1330ea80","original_commit_id":"b2fc54872f2bce5e460f4a73cae16b8b1330ea80","user":{"login":"dscho","id":127790,"node_id":"MDQ6VXNlcjEyNzc5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/127790?v=4","gravatar_id":"","url":"https://api.github.com/users/dscho","html_url":"https://github.com/dscho","followers_url":"https://api.github.com/users/dscho/followers","following_url":"https://api.github.com/users/dscho/following{/other_user}","gists_url":"https://api.github.com/users/dscho/gists{/gist_id}","starred_url":"https://api.github.com/users/dscho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscho/subscriptions","organizations_url":"https://api.github.com/users/dscho/orgs","repos_url":"https://api.github.com/users/dscho/repos","events_url":"https://api.github.com/users/dscho/events{/privacy}","received_events_url":"https://api.github.com/users/dscho/received_events","type":"User","site_admin":false},"body":"Most of these fields are grouped sensibly, more or less. But `upstream` should \"cuddle\" with `upstream_name`.\r\n\r\nIn general, I would like to keep the fields in groups that make some kind of sense, like: internal fields, i.e. fields with settings that will not be handed down to the rebase backend via the `env` array first (right now, there is only `type`). Then the variables that will be handed to the backend, maybe in some sort of order (intuitively, I would put `state_dir` first because it is kinda real low-level, then the revision-related variables, then options such as `root`).\r\n\r\nWhat do you think @prertik?","created_at":"2018-06-26T08:55:58Z","updated_at":"2018-06-26T08:55:58Z","html_url":"https://github.com/git/git/pull/505#discussion_r198064100","pull_request_url":"https://api.github.com/repos/git/git/pulls/505","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/git/git/pulls/comments/198064100"},"html":{"href":"https://github.com/git/git/pull/505#discussion_r198064100"},"pull_request":{"href":"https://api.github.com/repos/git/git/pulls/505"}}},"pull_request":{"url":"https://api.github.com/repos/git/git/pulls/505","id":193839476,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODM5NDc2","html_url":"https://github.com/git/git/pull/505","diff_url":"https://github.com/git/git/pull/505.diff","patch_url":"https://github.com/git/git/pull/505.patch","issue_url":"https://api.github.com/repos/git/git/issues/505","number":505,"state":"open","locked":false,"title":"WIP: rebase-builtin","user":{"login":"prertik","id":12194950,"node_id":"MDQ6VXNlcjEyMTk0OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/12194950?v=4","gravatar_id":"","url":"https://api.github.com/users/prertik","html_url":"https://github.com/prertik","followers_url":"https://api.github.com/users/prertik/followers","following_url":"https://api.github.com/users/prertik/following{/other_user}","gists_url":"https://api.github.com/users/prertik/gists{/gist_id}","starred_url":"https://api.github.com/users/prertik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prertik/subscriptions","organizations_url":"https://api.github.com/users/prertik/orgs","repos_url":"https://api.github.com/users/prertik/repos","events_url":"https://api.github.com/users/prertik/events{/privacy}","received_events_url":"https://api.github.com/users/prertik/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2018-06-10T18:23:52Z","updated_at":"2018-06-26T08:55:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b632a4f9b63c0a7a73e7534b66462f0c3190e36f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/git/git/pulls/505/commits","review_comments_url":"https://api.github.com/repos/git/git/pulls/505/comments","review_comment_url":"https://api.github.com/repos/git/git/pulls/comments{/number}","comments_url":"https://api.github.com/repos/git/git/issues/505/comments","statuses_url":"https://api.github.com/repos/git/git/statuses/b2fc54872f2bce5e460f4a73cae16b8b1330ea80","head":{"label":"prertik:wip-rebase","ref":"wip-rebase","sha":"b2fc54872f2bce5e460f4a73cae16b8b1330ea80","user":{"login":"prertik","id":12194950,"node_id":"MDQ6VXNlcjEyMTk0OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/12194950?v=4","gravatar_id":"","url":"https://api.github.com/users/prertik","html_url":"https://github.com/prertik","followers_url":"https://api.github.com/users/prertik/followers","following_url":"https://api.github.com/users/prertik/following{/other_user}","gists_url":"https://api.github.com/users/prertik/gists{/gist_id}","starred_url":"https://api.github.com/users/prertik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prertik/subscriptions","organizations_url":"https://api.github.com/users/prertik/orgs","repos_url":"https://api.github.com/users/prertik/repos","events_url":"https://api.github.com/users/prertik/events{/privacy}","received_events_url":"https://api.github.com/users/prertik/received_events","type":"User","site_admin":false},"repo":{"id":133445158,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NDUxNTg=","name":"git","full_name":"prertik/git","owner":{"login":"prertik","id":12194950,"node_id":"MDQ6VXNlcjEyMTk0OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/12194950?v=4","gravatar_id":"","url":"https://api.github.com/users/prertik","html_url":"https://github.com/prertik","followers_url":"https://api.github.com/users/prertik/followers","following_url":"https://api.github.com/users/prertik/following{/other_user}","gists_url":"https://api.github.com/users/prertik/gists{/gist_id}","starred_url":"https://api.github.com/users/prertik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prertik/subscriptions","organizations_url":"https://api.github.com/users/prertik/orgs","repos_url":"https://api.github.com/users/prertik/repos","events_url":"https://api.github.com/users/prertik/events{/privacy}","received_events_url":"https://api.github.com/users/prertik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prertik/git","description":"Git Source Code Mirror - This is a publish-only repository and all pull requests are ignored. Please follow Documentation/SubmittingPatches procedure for any of your improvements.","fork":true,"url":"https://api.github.com/repos/prertik/git","forks_url":"https://api.github.com/repos/prertik/git/forks","keys_url":"https://api.github.com/repos/prertik/git/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prertik/git/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prertik/git/teams","hooks_url":"https://api.github.com/repos/prertik/git/hooks","issue_events_url":"https://api.github.com/repos/prertik/git/issues/events{/number}","events_url":"https://api.github.com/repos/prertik/git/events","assignees_url":"https://api.github.com/repos/prertik/git/assignees{/user}","branches_url":"https://api.github.com/repos/prertik/git/branches{/branch}","tags_url":"https://api.github.com/repos/prertik/git/tags","blobs_url":"https://api.github.com/repos/prertik/git/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prertik/git/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prertik/git/git/refs{/sha}","trees_url":"https://api.github.com/repos/prertik/git/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prertik/git/statuses/{sha}","languages_url":"https://api.github.com/repos/prertik/git/languages","stargazers_url":"https://api.github.com/repos/prertik/git/stargazers","contributors_url":"https://api.github.com/repos/prertik/git/contributors","subscribers_url":"https://api.github.com/repos/prertik/git/subscribers","subscription_url":"https://api.github.com/repos/prertik/git/subscription","commits_url":"https://api.github.com/repos/prertik/git/commits{/sha}","git_commits_url":"https://api.github.com/repos/prertik/git/git/commits{/sha}","comments_url":"https://api.github.com/repos/prertik/git/comments{/number}","issue_comment_url":"https://api.github.com/repos/prertik/git/issues/comments{/number}","contents_url":"https://api.github.com/repos/prertik/git/contents/{+path}","compare_url":"https://api.github.com/repos/prertik/git/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prertik/git/merges","archive_url":"https://api.github.com/repos/prertik/git/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prertik/git/downloads","issues_url":"https://api.github.com/repos/prertik/git/issues{/number}","pulls_url":"https://api.github.com/repos/prertik/git/pulls{/number}","milestones_url":"https://api.github.com/repos/prertik/git/milestones{/number}","notifications_url":"https://api.github.com/repos/prertik/git/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prertik/git/labels{/name}","releases_url":"https://api.github.com/repos/prertik/git/releases{/id}","deployments_url":"https://api.github.com/repos/prertik/git/deployments","created_at":"2018-05-15T02:02:49Z","updated_at":"2018-06-14T13:17:25Z","pushed_at":"2018-06-26T08:41:53Z","git_url":"git://github.com/prertik/git.git","ssh_url":"git@github.com:prertik/git.git","clone_url":"https://github.com/prertik/git.git","svn_url":"https://github.com/prertik/git","homepage":"","size":92985,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"git:master","ref":"master","sha":"ed843436dd4924c10669820cc73daf50f0b4dabd","user":{"login":"git","id":18133,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTMz","avatar_url":"https://avatars2.githubusercontent.com/u/18133?v=4","gravatar_id":"","url":"https://api.github.com/users/git","html_url":"https://github.com/git","followers_url":"https://api.github.com/users/git/followers","following_url":"https://api.github.com/users/git/following{/other_user}","gists_url":"https://api.github.com/users/git/gists{/gist_id}","starred_url":"https://api.github.com/users/git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/git/subscriptions","organizations_url":"https://api.github.com/users/git/orgs","repos_url":"https://api.github.com/users/git/repos","events_url":"https://api.github.com/users/git/events{/privacy}","received_events_url":"https://api.github.com/users/git/received_events","type":"Organization","site_admin":false},"repo":{"id":36502,"node_id":"MDEwOlJlcG9zaXRvcnkzNjUwMg==","name":"git","full_name":"git/git","owner":{"login":"git","id":18133,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTMz","avatar_url":"https://avatars2.githubusercontent.com/u/18133?v=4","gravatar_id":"","url":"https://api.github.com/users/git","html_url":"https://github.com/git","followers_url":"https://api.github.com/users/git/followers","following_url":"https://api.github.com/users/git/following{/other_user}","gists_url":"https://api.github.com/users/git/gists{/gist_id}","starred_url":"https://api.github.com/users/git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/git/subscriptions","organizations_url":"https://api.github.com/users/git/orgs","repos_url":"https://api.github.com/users/git/repos","events_url":"https://api.github.com/users/git/events{/privacy}","received_events_url":"https://api.github.com/users/git/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/git/git","description":"Git Source Code Mirror - This is a publish-only repository and all pull requests are ignored. Please follow Documentation/SubmittingPatches procedure for any of your improvements.","fork":false,"url":"https://api.github.com/repos/git/git","forks_url":"https://api.github.com/repos/git/git/forks","keys_url":"https://api.github.com/repos/git/git/keys{/key_id}","collaborators_url":"https://api.github.com/repos/git/git/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/git/git/teams","hooks_url":"https://api.github.com/repos/git/git/hooks","issue_events_url":"https://api.github.com/repos/git/git/issues/events{/number}","events_url":"https://api.github.com/repos/git/git/events","assignees_url":"https://api.github.com/repos/git/git/assignees{/user}","branches_url":"https://api.github.com/repos/git/git/branches{/branch}","tags_url":"https://api.github.com/repos/git/git/tags","blobs_url":"https://api.github.com/repos/git/git/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/git/git/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/git/git/git/refs{/sha}","trees_url":"https://api.github.com/repos/git/git/git/trees{/sha}","statuses_url":"https://api.github.com/repos/git/git/statuses/{sha}","languages_url":"https://api.github.com/repos/git/git/languages","stargazers_url":"https://api.github.com/repos/git/git/stargazers","contributors_url":"https://api.github.com/repos/git/git/contributors","subscribers_url":"https://api.github.com/repos/git/git/subscribers","subscription_url":"https://api.github.com/repos/git/git/subscription","commits_url":"https://api.github.com/repos/git/git/commits{/sha}","git_commits_url":"https://api.github.com/repos/git/git/git/commits{/sha}","comments_url":"https://api.github.com/repos/git/git/comments{/number}","issue_comment_url":"https://api.github.com/repos/git/git/issues/comments{/number}","contents_url":"https://api.github.com/repos/git/git/contents/{+path}","compare_url":"https://api.github.com/repos/git/git/compare/{base}...{head}","merges_url":"https://api.github.com/repos/git/git/merges","archive_url":"https://api.github.com/repos/git/git/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/git/git/downloads","issues_url":"https://api.github.com/repos/git/git/issues{/number}","pulls_url":"https://api.github.com/repos/git/git/pulls{/number}","milestones_url":"https://api.github.com/repos/git/git/milestones{/number}","notifications_url":"https://api.github.com/repos/git/git/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/git/git/labels{/name}","releases_url":"https://api.github.com/repos/git/git/releases{/id}","deployments_url":"https://api.github.com/repos/git/git/deployments","created_at":"2008-07-23T14:21:26Z","updated_at":"2018-06-26T08:35:26Z","pushed_at":"2018-06-26T08:41:58Z","git_url":"git://github.com/git/git.git","ssh_url":"git@github.com:git/git.git","clone_url":"https://github.com/git/git.git","svn_url":"https://github.com/git/git","homepage":"","size":100957,"stargazers_count":23027,"watchers_count":23027,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13362,"mirror_url":null,"archived":false,"open_issues_count":146,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13362,"open_issues":146,"watchers":23027,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/git/git/pulls/505"},"html":{"href":"https://github.com/git/git/pull/505"},"issue":{"href":"https://api.github.com/repos/git/git/issues/505"},"comments":{"href":"https://api.github.com/repos/git/git/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/git/git/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/git/git/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/git/git/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/git/git/statuses/b2fc54872f2bce5e460f4a73cae16b8b1330ea80"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dscho"}}