{"action":"opened","issue":{"url":"https://api.github.com/repos/publiclab/plots2/issues/3194","repository_url":"https://api.github.com/repos/publiclab/plots2","labels_url":"https://api.github.com/repos/publiclab/plots2/issues/3194/labels{/name}","comments_url":"https://api.github.com/repos/publiclab/plots2/issues/3194/comments","events_url":"https://api.github.com/repos/publiclab/plots2/issues/3194/events","html_url":"https://github.com/publiclab/plots2/issues/3194","id":347205817,"node_id":"MDU6SXNzdWUzNDcyMDU4MTc=","number":3194,"title":"Tagging input appearing without logging in","user":{"login":"derek-allen","id":40677825,"node_id":"MDQ6VXNlcjQwNjc3ODI1","avatar_url":"https://avatars0.githubusercontent.com/u/40677825?v=4","gravatar_id":"","url":"https://api.github.com/users/derek-allen","html_url":"https://github.com/derek-allen","followers_url":"https://api.github.com/users/derek-allen/followers","following_url":"https://api.github.com/users/derek-allen/following{/other_user}","gists_url":"https://api.github.com/users/derek-allen/gists{/gist_id}","starred_url":"https://api.github.com/users/derek-allen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derek-allen/subscriptions","organizations_url":"https://api.github.com/users/derek-allen/orgs","repos_url":"https://api.github.com/users/derek-allen/repos","events_url":"https://api.github.com/users/derek-allen/events{/privacy}","received_events_url":"https://api.github.com/users/derek-allen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-02T23:12:27Z","updated_at":"2018-08-02T23:12:27Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The tagging input is appearing on the sidebar even when you aren't logged in. [Here's an example](https://publiclab.org/notes/warren/08-02-2018/use-image-sequencer-for-ndvi-plant-analysis-with-a-modified-mini-sport-camera).\r\n![tagging-logged-out](https://user-images.githubusercontent.com/40677825/43615350-d86bccb0-967c-11e8-8eb3-1ea8f79f15b8.png)\r\n\r\nThis is the logic deciding whether the input appears.\r\nhttps://github.com/publiclab/plots2/blob/116db0cbaa8df72ea6cdb5e5115bff9eb5d6ee03/app/views/tag/_tagging.html.erb#L43\r\n\r\nI believe the parent :profile inequality comparison is what is causing this. This is always true and thus displaying the input outside of the case for the profile view, here.\r\n\r\nhttps://github.com/publiclab/plots2/blob/116db0cbaa8df72ea6cdb5e5115bff9eb5d6ee03/app/views/users/profile.html.erb#L127\r\n\r\nEven then, I don't see a use for this comparison, because the desired behavior still checks out (if you are logged in and this is your content OR you are an admin, you can add tags).\r\n\r\nIt seems like a simple fix, and might be a good candidate for first time contributions."}}
{"actor":{"display_login":"derek-allen"}}