{"action":"closed","number":808,"pull_request":{"url":"https://api.github.com/repos/tidyverse/readr/pulls/808","id":173040959,"html_url":"https://github.com/tidyverse/readr/pull/808","diff_url":"https://github.com/tidyverse/readr/pull/808.diff","patch_url":"https://github.com/tidyverse/readr/pull/808.patch","issue_url":"https://api.github.com/repos/tidyverse/readr/issues/808","number":808,"state":"closed","locked":false,"title":"Tweak language for na parameter","user":{"login":"kwstat","id":484260,"avatar_url":"https://avatars3.githubusercontent.com/u/484260?v=4","gravatar_id":"","url":"https://api.github.com/users/kwstat","html_url":"https://github.com/kwstat","followers_url":"https://api.github.com/users/kwstat/followers","following_url":"https://api.github.com/users/kwstat/following{/other_user}","gists_url":"https://api.github.com/users/kwstat/gists{/gist_id}","starred_url":"https://api.github.com/users/kwstat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwstat/subscriptions","organizations_url":"https://api.github.com/users/kwstat/orgs","repos_url":"https://api.github.com/users/kwstat/repos","events_url":"https://api.github.com/users/kwstat/events{/privacy}","received_events_url":"https://api.github.com/users/kwstat/received_events","type":"User","site_admin":false},"body":"Current wording says \"Character vector of strings to use for missing values.\"  To me, this sounds like these will be INSERTED in place of missing values, so I changed the text to \"to interpret as missing values\". \r\n\r\nFor what it's worth, read.csv uses 'na.strings', which is documented as \"a character vector of strings which are to be interpreted as NA values\".\r\n\r\nAlso, would it be worthwhile to caution the user that \"NA\" strings (North America, Sodium, etc) will be turned into missing values?","created_at":"2018-03-06T02:20:26Z","updated_at":"2018-03-09T15:23:42Z","closed_at":"2018-03-09T15:23:41Z","merged_at":"2018-03-09T15:23:41Z","merge_commit_sha":"f75ab8b06dd876f339b82d49722c05751ebd768d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tidyverse/readr/pulls/808/commits","review_comments_url":"https://api.github.com/repos/tidyverse/readr/pulls/808/comments","review_comment_url":"https://api.github.com/repos/tidyverse/readr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tidyverse/readr/issues/808/comments","statuses_url":"https://api.github.com/repos/tidyverse/readr/statuses/1c3e09bc6d4ae54c1e2cfbd07adcdba06d60b7ab","head":{"label":"kwstat:patch-1","ref":"patch-1","sha":"1c3e09bc6d4ae54c1e2cfbd07adcdba06d60b7ab","user":{"login":"kwstat","id":484260,"avatar_url":"https://avatars3.githubusercontent.com/u/484260?v=4","gravatar_id":"","url":"https://api.github.com/users/kwstat","html_url":"https://github.com/kwstat","followers_url":"https://api.github.com/users/kwstat/followers","following_url":"https://api.github.com/users/kwstat/following{/other_user}","gists_url":"https://api.github.com/users/kwstat/gists{/gist_id}","starred_url":"https://api.github.com/users/kwstat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwstat/subscriptions","organizations_url":"https://api.github.com/users/kwstat/orgs","repos_url":"https://api.github.com/users/kwstat/repos","events_url":"https://api.github.com/users/kwstat/events{/privacy}","received_events_url":"https://api.github.com/users/kwstat/received_events","type":"User","site_admin":false},"repo":{"id":124007133,"name":"readr","full_name":"kwstat/readr","owner":{"login":"kwstat","id":484260,"avatar_url":"https://avatars3.githubusercontent.com/u/484260?v=4","gravatar_id":"","url":"https://api.github.com/users/kwstat","html_url":"https://github.com/kwstat","followers_url":"https://api.github.com/users/kwstat/followers","following_url":"https://api.github.com/users/kwstat/following{/other_user}","gists_url":"https://api.github.com/users/kwstat/gists{/gist_id}","starred_url":"https://api.github.com/users/kwstat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwstat/subscriptions","organizations_url":"https://api.github.com/users/kwstat/orgs","repos_url":"https://api.github.com/users/kwstat/repos","events_url":"https://api.github.com/users/kwstat/events{/privacy}","received_events_url":"https://api.github.com/users/kwstat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwstat/readr","description":"Read flat files (csv, tsv, fwf) into R","fork":true,"url":"https://api.github.com/repos/kwstat/readr","forks_url":"https://api.github.com/repos/kwstat/readr/forks","keys_url":"https://api.github.com/repos/kwstat/readr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwstat/readr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwstat/readr/teams","hooks_url":"https://api.github.com/repos/kwstat/readr/hooks","issue_events_url":"https://api.github.com/repos/kwstat/readr/issues/events{/number}","events_url":"https://api.github.com/repos/kwstat/readr/events","assignees_url":"https://api.github.com/repos/kwstat/readr/assignees{/user}","branches_url":"https://api.github.com/repos/kwstat/readr/branches{/branch}","tags_url":"https://api.github.com/repos/kwstat/readr/tags","blobs_url":"https://api.github.com/repos/kwstat/readr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwstat/readr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwstat/readr/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwstat/readr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwstat/readr/statuses/{sha}","languages_url":"https://api.github.com/repos/kwstat/readr/languages","stargazers_url":"https://api.github.com/repos/kwstat/readr/stargazers","contributors_url":"https://api.github.com/repos/kwstat/readr/contributors","subscribers_url":"https://api.github.com/repos/kwstat/readr/subscribers","subscription_url":"https://api.github.com/repos/kwstat/readr/subscription","commits_url":"https://api.github.com/repos/kwstat/readr/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwstat/readr/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwstat/readr/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwstat/readr/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwstat/readr/contents/{+path}","compare_url":"https://api.github.com/repos/kwstat/readr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwstat/readr/merges","archive_url":"https://api.github.com/repos/kwstat/readr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwstat/readr/downloads","issues_url":"https://api.github.com/repos/kwstat/readr/issues{/number}","pulls_url":"https://api.github.com/repos/kwstat/readr/pulls{/number}","milestones_url":"https://api.github.com/repos/kwstat/readr/milestones{/number}","notifications_url":"https://api.github.com/repos/kwstat/readr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwstat/readr/labels{/name}","releases_url":"https://api.github.com/repos/kwstat/readr/releases{/id}","deployments_url":"https://api.github.com/repos/kwstat/readr/deployments","created_at":"2018-03-06T02:15:22Z","updated_at":"2018-03-06T02:15:24Z","pushed_at":"2018-03-06T02:19:38Z","git_url":"git://github.com/kwstat/readr.git","ssh_url":"git@github.com:kwstat/readr.git","clone_url":"https://github.com/kwstat/readr.git","svn_url":"https://github.com/kwstat/readr","homepage":"readr.tidyverse.org","size":2392,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tidyverse:master","ref":"master","sha":"2e1fa9a6abba7ec2ba9b0ae85969717ba05d5337","user":{"login":"tidyverse","id":22032646,"avatar_url":"https://avatars2.githubusercontent.com/u/22032646?v=4","gravatar_id":"","url":"https://api.github.com/users/tidyverse","html_url":"https://github.com/tidyverse","followers_url":"https://api.github.com/users/tidyverse/followers","following_url":"https://api.github.com/users/tidyverse/following{/other_user}","gists_url":"https://api.github.com/users/tidyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/tidyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidyverse/subscriptions","organizations_url":"https://api.github.com/users/tidyverse/orgs","repos_url":"https://api.github.com/users/tidyverse/repos","events_url":"https://api.github.com/users/tidyverse/events{/privacy}","received_events_url":"https://api.github.com/users/tidyverse/received_events","type":"Organization","site_admin":false},"repo":{"id":11663980,"name":"readr","full_name":"tidyverse/readr","owner":{"login":"tidyverse","id":22032646,"avatar_url":"https://avatars2.githubusercontent.com/u/22032646?v=4","gravatar_id":"","url":"https://api.github.com/users/tidyverse","html_url":"https://github.com/tidyverse","followers_url":"https://api.github.com/users/tidyverse/followers","following_url":"https://api.github.com/users/tidyverse/following{/other_user}","gists_url":"https://api.github.com/users/tidyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/tidyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidyverse/subscriptions","organizations_url":"https://api.github.com/users/tidyverse/orgs","repos_url":"https://api.github.com/users/tidyverse/repos","events_url":"https://api.github.com/users/tidyverse/events{/privacy}","received_events_url":"https://api.github.com/users/tidyverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tidyverse/readr","description":"Read flat files (csv, tsv, fwf) into R","fork":false,"url":"https://api.github.com/repos/tidyverse/readr","forks_url":"https://api.github.com/repos/tidyverse/readr/forks","keys_url":"https://api.github.com/repos/tidyverse/readr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidyverse/readr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidyverse/readr/teams","hooks_url":"https://api.github.com/repos/tidyverse/readr/hooks","issue_events_url":"https://api.github.com/repos/tidyverse/readr/issues/events{/number}","events_url":"https://api.github.com/repos/tidyverse/readr/events","assignees_url":"https://api.github.com/repos/tidyverse/readr/assignees{/user}","branches_url":"https://api.github.com/repos/tidyverse/readr/branches{/branch}","tags_url":"https://api.github.com/repos/tidyverse/readr/tags","blobs_url":"https://api.github.com/repos/tidyverse/readr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidyverse/readr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidyverse/readr/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidyverse/readr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidyverse/readr/statuses/{sha}","languages_url":"https://api.github.com/repos/tidyverse/readr/languages","stargazers_url":"https://api.github.com/repos/tidyverse/readr/stargazers","contributors_url":"https://api.github.com/repos/tidyverse/readr/contributors","subscribers_url":"https://api.github.com/repos/tidyverse/readr/subscribers","subscription_url":"https://api.github.com/repos/tidyverse/readr/subscription","commits_url":"https://api.github.com/repos/tidyverse/readr/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidyverse/readr/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidyverse/readr/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidyverse/readr/issues/comments{/number}","contents_url":"https://api.github.com/repos/tidyverse/readr/contents/{+path}","compare_url":"https://api.github.com/repos/tidyverse/readr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidyverse/readr/merges","archive_url":"https://api.github.com/repos/tidyverse/readr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidyverse/readr/downloads","issues_url":"https://api.github.com/repos/tidyverse/readr/issues{/number}","pulls_url":"https://api.github.com/repos/tidyverse/readr/pulls{/number}","milestones_url":"https://api.github.com/repos/tidyverse/readr/milestones{/number}","notifications_url":"https://api.github.com/repos/tidyverse/readr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidyverse/readr/labels{/name}","releases_url":"https://api.github.com/repos/tidyverse/readr/releases{/id}","deployments_url":"https://api.github.com/repos/tidyverse/readr/deployments","created_at":"2013-07-25T15:28:22Z","updated_at":"2018-03-09T14:20:43Z","pushed_at":"2018-03-09T15:23:41Z","git_url":"git://github.com/tidyverse/readr.git","ssh_url":"git@github.com:tidyverse/readr.git","clone_url":"https://github.com/tidyverse/readr.git","svn_url":"https://github.com/tidyverse/readr","homepage":"readr.tidyverse.org","size":2357,"stargazers_count":588,"watchers_count":588,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":171,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":171,"open_issues":83,"watchers":588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tidyverse/readr/pulls/808"},"html":{"href":"https://github.com/tidyverse/readr/pull/808"},"issue":{"href":"https://api.github.com/repos/tidyverse/readr/issues/808"},"comments":{"href":"https://api.github.com/repos/tidyverse/readr/issues/808/comments"},"review_comments":{"href":"https://api.github.com/repos/tidyverse/readr/pulls/808/comments"},"review_comment":{"href":"https://api.github.com/repos/tidyverse/readr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tidyverse/readr/pulls/808/commits"},"statuses":{"href":"https://api.github.com/repos/tidyverse/readr/statuses/1c3e09bc6d4ae54c1e2cfbd07adcdba06d60b7ab"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jimhester","id":205275,"avatar_url":"https://avatars3.githubusercontent.com/u/205275?v=4","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"jimhester"}}