{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3370","repository_url":"https://api.github.com/repos/OpenMS/OpenMS","labels_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3370/labels{/name}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3370/comments","events_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3370/events","html_url":"https://github.com/OpenMS/OpenMS/pull/3370","id":312114889,"number":3370,"title":"[FEATURE] Additional scores for OpenSWATH","user":{"login":"grosenberger","id":4172900,"avatar_url":"https://avatars0.githubusercontent.com/u/4172900?v=4","gravatar_id":"","url":"https://api.github.com/users/grosenberger","html_url":"https://github.com/grosenberger","followers_url":"https://api.github.com/users/grosenberger/followers","following_url":"https://api.github.com/users/grosenberger/following{/other_user}","gists_url":"https://api.github.com/users/grosenberger/gists{/gist_id}","starred_url":"https://api.github.com/users/grosenberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosenberger/subscriptions","organizations_url":"https://api.github.com/users/grosenberger/orgs","repos_url":"https://api.github.com/users/grosenberger/repos","events_url":"https://api.github.com/users/grosenberger/events{/privacy}","received_events_url":"https://api.github.com/users/grosenberger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-04-06T20:55:10Z","updated_at":"2018-04-26T22:11:32Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/3370","html_url":"https://github.com/OpenMS/OpenMS/pull/3370","diff_url":"https://github.com/OpenMS/OpenMS/pull/3370.diff","patch_url":"https://github.com/OpenMS/OpenMS/pull/3370.patch"},"body":"This PR proposes a set of new scores for OpenSWATH/IPF. The implementation is based on [MIToolkit](https://github.com/Craigacp/MIToolbox), a small C++/Matlab toolkit released under the 3-clause BSD license that provides commonly used metrics from information theory.\r\n\r\nTo make these functions available in OpenSWATH, I suggest two alternative options:\r\n- Adding MIToolbox to ``OpenMS/contrib``. I have implemented such a solution [here](https://github.com/grosenberger/contrib/tree/feature/mitoolbox).\r\n- Adding MIToolbox directly to ``OpenSwathAlgo`` (this PR).\r\n\r\nThe benefit of the ``contrib`` approach is of course better modularity. On the other hand, this increases the maintenance efforts for all platforms agains. Further, MIToolbox is super small, so the overhead of directlu integrating this within ``OpenSwathAlgo`` would be minimal.\r\n\r\nWhich option is preferred by the core developers?"},"comment":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/comments/384804785","html_url":"https://github.com/OpenMS/OpenMS/pull/3370#issuecomment-384804785","issue_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3370","id":384804785,"user":{"login":"hroest","id":464014,"avatar_url":"https://avatars0.githubusercontent.com/u/464014?v=4","gravatar_id":"","url":"https://api.github.com/users/hroest","html_url":"https://github.com/hroest","followers_url":"https://api.github.com/users/hroest/followers","following_url":"https://api.github.com/users/hroest/following{/other_user}","gists_url":"https://api.github.com/users/hroest/gists{/gist_id}","starred_url":"https://api.github.com/users/hroest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hroest/subscriptions","organizations_url":"https://api.github.com/users/hroest/orgs","repos_url":"https://api.github.com/users/hroest/repos","events_url":"https://api.github.com/users/hroest/events{/privacy}","received_events_url":"https://api.github.com/users/hroest/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T22:11:32Z","updated_at":"2018-04-26T22:11:32Z","author_association":"CONTRIBUTOR","body":"I just tested it and on my Linux computer and on travis it builds, so that cannot be the issue. "}}
{"actor":{"display_login":"hroest"}}