{"action":"created","comment":{"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/comments/169487406","pull_request_review_id":98021553,"id":169487406,"diff_hunk":"@@ -21,18 +35,25 @@\n \n @ExtendWith(RestExtension.class)\n class CpcApiAcceptance {\n-\n \tprivate static final String CPC_UNPROCESSED_FILES_API_PATH = \"/cpc/unprocessed-files\";\n \tprivate static final String CPC_FILE_API_PATH = \"/cpc/file/\";\n \tprivate static final String PROGRAM_NAME_XPATH = \"/*[local-name() = 'ClinicalDocument' and namespace-uri() = 'urn:hl7-org:v3']\"\n \t\t+ \"/./*[local-name() = 'informationRecipient' and namespace-uri() = 'urn:hl7-org:v3']\"\n \t\t+ \"/*[local-name() = 'intendedRecipient' and namespace-uri() = 'urn:hl7-org:v3']\"\n \t\t+ \"/*[local-name() = 'id' and namespace-uri() = 'urn:hl7-org:v3'][@root='2.16.840.1.113883.3.249.7']/@extension\";\n \tprivate static final String CPC_PLUS_PROGRAM_NAME = \"CPCPLUS\";\n-\tprivate static final String NOT_A_CPC_FILE = \"beed7ed4-107c-400f-b0de-0c60abc54344\";\n+\tprivate static AmazonDynamoDB dynamoClient = AmazonDynamoDBClientBuilder.standard().build();\n+\tprivate static DynamoDBMapper mapper;\n+\tprivate static AWSKMS kmsClient = AWSKMSClientBuilder.defaultClient();\n \n \t@BeforeAll\n-\tstatic void createUnprocessedItem() {\n+\tstatic void setUp() {\n+\t\tString kmsKey = \"arn:aws:kms:us-east-1:850094054452:key/8b19f7e9-b58c-4b7a-8162-e01809a8a2e9\";","path":"rest-api/src/test/java/gov/cms/qpp/conversion/api/acceptance/CpcApiAcceptance.java","position":49,"original_position":49,"commit_id":"6a7134b991e73dc38d4bdef04271e5682e126981","original_commit_id":"3996e20a1d63fed8e463ab806cac3271249061ed","user":{"login":"saquino0827","id":26700499,"avatar_url":"https://avatars3.githubusercontent.com/u/26700499?v=4","gravatar_id":"","url":"https://api.github.com/users/saquino0827","html_url":"https://github.com/saquino0827","followers_url":"https://api.github.com/users/saquino0827/followers","following_url":"https://api.github.com/users/saquino0827/following{/other_user}","gists_url":"https://api.github.com/users/saquino0827/gists{/gist_id}","starred_url":"https://api.github.com/users/saquino0827/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saquino0827/subscriptions","organizations_url":"https://api.github.com/users/saquino0827/orgs","repos_url":"https://api.github.com/users/saquino0827/repos","events_url":"https://api.github.com/users/saquino0827/events{/privacy}","received_events_url":"https://api.github.com/users/saquino0827/received_events","type":"User","site_admin":false},"body":"I feel like this can be handled better in the light deployment. Instead of setting up another kms key on our AWS account for local testing.","created_at":"2018-02-20T22:54:27Z","updated_at":"2018-02-20T22:54:27Z","html_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/622#discussion_r169487406","pull_request_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/622","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/comments/169487406"},"html":{"href":"https://github.com/CMSgov/qpp-conversion-tool/pull/622#discussion_r169487406"},"pull_request":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/622"}},"in_reply_to_id":169343886},"pull_request":{"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/622","id":170025061,"html_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/622","diff_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/622.diff","patch_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/622.patch","issue_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/622","number":622,"state":"open","locked":false,"title":"Add date filter to CPC+ endpoints","user":{"login":"saquino0827","id":26700499,"avatar_url":"https://avatars3.githubusercontent.com/u/26700499?v=4","gravatar_id":"","url":"https://api.github.com/users/saquino0827","html_url":"https://github.com/saquino0827","followers_url":"https://api.github.com/users/saquino0827/followers","following_url":"https://api.github.com/users/saquino0827/following{/other_user}","gists_url":"https://api.github.com/users/saquino0827/gists{/gist_id}","starred_url":"https://api.github.com/users/saquino0827/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saquino0827/subscriptions","organizations_url":"https://api.github.com/users/saquino0827/orgs","repos_url":"https://api.github.com/users/saquino0827/repos","events_url":"https://api.github.com/users/saquino0827/events{/privacy}","received_events_url":"https://api.github.com/users/saquino0827/received_events","type":"User","site_admin":false},"body":"### Information\r\n- QPPCT-663\r\n\r\n### Changes proposed in this PR:\r\n- Add date filter to CPC+ endpoint.\r\n- Clean up acceptance tests to start with a clean dynamo db and s3 bucket.\r\n\r\n### Checklist \r\n- [x] All JUnit tests pass (`mvn clean verify`).\r\n- [x] New unit tests written to cover new functionality.\r\n- [x] Added and updated JavaDocs for non-test classes and methods.\r\n- [x] No local design debt. Do you feel that something is \"ugly\" after your changes?\r\n- [n/a] Updated documentation (`README.md`, etc.) depending if the changes require it.\r\n","created_at":"2018-02-19T18:08:34Z","updated_at":"2018-02-20T22:54:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cb841c943b8ae9a06a82269978edc144c4bc810","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sfradkin","id":1021145,"avatar_url":"https://avatars1.githubusercontent.com/u/1021145?v=4","gravatar_id":"","url":"https://api.github.com/users/sfradkin","html_url":"https://github.com/sfradkin","followers_url":"https://api.github.com/users/sfradkin/followers","following_url":"https://api.github.com/users/sfradkin/following{/other_user}","gists_url":"https://api.github.com/users/sfradkin/gists{/gist_id}","starred_url":"https://api.github.com/users/sfradkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfradkin/subscriptions","organizations_url":"https://api.github.com/users/sfradkin/orgs","repos_url":"https://api.github.com/users/sfradkin/repos","events_url":"https://api.github.com/users/sfradkin/events{/privacy}","received_events_url":"https://api.github.com/users/sfradkin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/622/commits","review_comments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/622/comments","review_comment_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/622/comments","statuses_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/statuses/6a7134b991e73dc38d4bdef04271e5682e126981","head":{"label":"CMSgov:story-663","ref":"story-663","sha":"6a7134b991e73dc38d4bdef04271e5682e126981","user":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"repo":{"id":86107810,"name":"qpp-conversion-tool","full_name":"CMSgov/qpp-conversion-tool","owner":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CMSgov/qpp-conversion-tool","description":"Conversion tool for QPP, particularly focused on QRDA3 -> QPP, built by Flexion. ","fork":false,"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool","forks_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/forks","keys_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/teams","hooks_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/hooks","issue_events_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/events{/number}","events_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/events","assignees_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/assignees{/user}","branches_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/branches{/branch}","tags_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/tags","blobs_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/languages","stargazers_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/stargazers","contributors_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/contributors","subscribers_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/subscribers","subscription_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/subscription","commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/contents/{+path}","compare_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/merges","archive_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/downloads","issues_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues{/number}","pulls_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/labels{/name}","releases_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/releases{/id}","deployments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/deployments","created_at":"2017-03-24T20:26:32Z","updated_at":"2018-01-05T21:55:12Z","pushed_at":"2018-02-20T21:16:07Z","git_url":"git://github.com/CMSgov/qpp-conversion-tool.git","ssh_url":"git@github.com:CMSgov/qpp-conversion-tool.git","clone_url":"https://github.com/CMSgov/qpp-conversion-tool.git","svn_url":"https://github.com/CMSgov/qpp-conversion-tool","homepage":null,"size":22503,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0"},"forks":11,"open_issues":4,"watchers":6,"default_branch":"develop"}},"base":{"label":"CMSgov:develop","ref":"develop","sha":"c18f8f976a4053368400e2aed829354e7c10a3a0","user":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"repo":{"id":86107810,"name":"qpp-conversion-tool","full_name":"CMSgov/qpp-conversion-tool","owner":{"login":"CMSgov","id":3209407,"avatar_url":"https://avatars3.githubusercontent.com/u/3209407?v=4","gravatar_id":"","url":"https://api.github.com/users/CMSgov","html_url":"https://github.com/CMSgov","followers_url":"https://api.github.com/users/CMSgov/followers","following_url":"https://api.github.com/users/CMSgov/following{/other_user}","gists_url":"https://api.github.com/users/CMSgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CMSgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMSgov/subscriptions","organizations_url":"https://api.github.com/users/CMSgov/orgs","repos_url":"https://api.github.com/users/CMSgov/repos","events_url":"https://api.github.com/users/CMSgov/events{/privacy}","received_events_url":"https://api.github.com/users/CMSgov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CMSgov/qpp-conversion-tool","description":"Conversion tool for QPP, particularly focused on QRDA3 -> QPP, built by Flexion. ","fork":false,"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool","forks_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/forks","keys_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/teams","hooks_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/hooks","issue_events_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/events{/number}","events_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/events","assignees_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/assignees{/user}","branches_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/branches{/branch}","tags_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/tags","blobs_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/languages","stargazers_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/stargazers","contributors_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/contributors","subscribers_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/subscribers","subscription_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/subscription","commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/contents/{+path}","compare_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/merges","archive_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/downloads","issues_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues{/number}","pulls_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/labels{/name}","releases_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/releases{/id}","deployments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/deployments","created_at":"2017-03-24T20:26:32Z","updated_at":"2018-01-05T21:55:12Z","pushed_at":"2018-02-20T21:16:07Z","git_url":"git://github.com/CMSgov/qpp-conversion-tool.git","ssh_url":"git@github.com:CMSgov/qpp-conversion-tool.git","clone_url":"https://github.com/CMSgov/qpp-conversion-tool.git","svn_url":"https://github.com/CMSgov/qpp-conversion-tool","homepage":null,"size":22503,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0"},"forks":11,"open_issues":4,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/622"},"html":{"href":"https://github.com/CMSgov/qpp-conversion-tool/pull/622"},"issue":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/622"},"comments":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/622/comments"},"review_comments":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/622/comments"},"review_comment":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/622/commits"},"statuses":{"href":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/statuses/6a7134b991e73dc38d4bdef04271e5682e126981"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"saquino0827"}}