{"action":"created","comment":{"url":"https://api.github.com/repos/igniterealtime/Smack/pulls/comments/205941938","pull_request_review_id":141315790,"id":205941938,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTk0MTkzOA==","diff_hunk":"@@ -0,0 +1,38 @@\n+/**\n+ *\n+ * Copyright 2017 Miguel Hincapie.","path":"smack-experimental/src/main/java/org/jivesoftware/smackx/chat_markers/ChatMarkersListener.java","position":3,"original_position":3,"commit_id":"5f884641fc98678f8bcd5910a42923fb26e84ba1","original_commit_id":"5f884641fc98678f8bcd5910a42923fb26e84ba1","user":{"login":"vanitasvitae","id":7854206,"node_id":"MDQ6VXNlcjc4NTQyMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/7854206?v=4","gravatar_id":"","url":"https://api.github.com/users/vanitasvitae","html_url":"https://github.com/vanitasvitae","followers_url":"https://api.github.com/users/vanitasvitae/followers","following_url":"https://api.github.com/users/vanitasvitae/following{/other_user}","gists_url":"https://api.github.com/users/vanitasvitae/gists{/gist_id}","starred_url":"https://api.github.com/users/vanitasvitae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanitasvitae/subscriptions","organizations_url":"https://api.github.com/users/vanitasvitae/orgs","repos_url":"https://api.github.com/users/vanitasvitae/repos","events_url":"https://api.github.com/users/vanitasvitae/events{/privacy}","received_events_url":"https://api.github.com/users/vanitasvitae/received_events","type":"User","site_admin":false},"body":"We're already in 2018, aren't we? :smile:","created_at":"2018-07-28T12:19:12Z","updated_at":"2018-07-28T12:39:23Z","html_url":"https://github.com/igniterealtime/Smack/pull/256#discussion_r205941938","pull_request_url":"https://api.github.com/repos/igniterealtime/Smack/pulls/256","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/igniterealtime/Smack/pulls/comments/205941938"},"html":{"href":"https://github.com/igniterealtime/Smack/pull/256#discussion_r205941938"},"pull_request":{"href":"https://api.github.com/repos/igniterealtime/Smack/pulls/256"}}},"pull_request":{"url":"https://api.github.com/repos/igniterealtime/Smack/pulls/256","id":204545160,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTQ1MTYw","html_url":"https://github.com/igniterealtime/Smack/pull/256","diff_url":"https://github.com/igniterealtime/Smack/pull/256.diff","patch_url":"https://github.com/igniterealtime/Smack/pull/256.patch","issue_url":"https://api.github.com/repos/igniterealtime/Smack/issues/256","number":256,"state":"open","locked":false,"title":"XEP-0333 Improvement","user":{"login":"miguelhincapie","id":8630030,"node_id":"MDQ6VXNlcjg2MzAwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8630030?v=4","gravatar_id":"","url":"https://api.github.com/users/miguelhincapie","html_url":"https://github.com/miguelhincapie","followers_url":"https://api.github.com/users/miguelhincapie/followers","following_url":"https://api.github.com/users/miguelhincapie/following{/other_user}","gists_url":"https://api.github.com/users/miguelhincapie/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelhincapie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelhincapie/subscriptions","organizations_url":"https://api.github.com/users/miguelhincapie/orgs","repos_url":"https://api.github.com/users/miguelhincapie/repos","events_url":"https://api.github.com/users/miguelhincapie/events{/privacy}","received_events_url":"https://api.github.com/users/miguelhincapie/received_events","type":"User","site_admin":false},"body":"In order to be able to use `ChatMarkersManager` following same pattern/architecture like `ChatStateManager` or `ChatManager` (version 2), some improvement needs to be done in the XEP-0333 implementation.\r\n\r\nThe goal of this improvement was obtain an `interface` to be implemented like `IncomingChatMessageListener` or `ChatStateListener`. For that, an interface was created (`ChatMarkersListener`), an enum (`ChatMarkersState`) and 2 files modified (`ChatMarkersElements` and `ChatMarkersManager`). For more details, please read commits description.\r\n\r\nThe changes done in `ChatMarkersManager` were done trying to mimic `ChatStateManager` and `ChatManager`.\r\n\r\nThose changes has been implemented successfully in an app (I can't say the name :/).\r\n\r\nAny suggestion is welcome.","created_at":"2018-07-27T21:34:38Z","updated_at":"2018-07-28T12:39:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96639ccc8a082d74274e92873c8ec4221ac2caec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/igniterealtime/Smack/pulls/256/commits","review_comments_url":"https://api.github.com/repos/igniterealtime/Smack/pulls/256/comments","review_comment_url":"https://api.github.com/repos/igniterealtime/Smack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/igniterealtime/Smack/issues/256/comments","statuses_url":"https://api.github.com/repos/igniterealtime/Smack/statuses/5f884641fc98678f8bcd5910a42923fb26e84ba1","head":{"label":"miguelhincapie:XEP-0333-Improvement","ref":"XEP-0333-Improvement","sha":"5f884641fc98678f8bcd5910a42923fb26e84ba1","user":{"login":"miguelhincapie","id":8630030,"node_id":"MDQ6VXNlcjg2MzAwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8630030?v=4","gravatar_id":"","url":"https://api.github.com/users/miguelhincapie","html_url":"https://github.com/miguelhincapie","followers_url":"https://api.github.com/users/miguelhincapie/followers","following_url":"https://api.github.com/users/miguelhincapie/following{/other_user}","gists_url":"https://api.github.com/users/miguelhincapie/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelhincapie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelhincapie/subscriptions","organizations_url":"https://api.github.com/users/miguelhincapie/orgs","repos_url":"https://api.github.com/users/miguelhincapie/repos","events_url":"https://api.github.com/users/miguelhincapie/events{/privacy}","received_events_url":"https://api.github.com/users/miguelhincapie/received_events","type":"User","site_admin":false},"repo":{"id":142210992,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIyMTA5OTI=","name":"Smack","full_name":"miguelhincapie/Smack","owner":{"login":"miguelhincapie","id":8630030,"node_id":"MDQ6VXNlcjg2MzAwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8630030?v=4","gravatar_id":"","url":"https://api.github.com/users/miguelhincapie","html_url":"https://github.com/miguelhincapie","followers_url":"https://api.github.com/users/miguelhincapie/followers","following_url":"https://api.github.com/users/miguelhincapie/following{/other_user}","gists_url":"https://api.github.com/users/miguelhincapie/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelhincapie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelhincapie/subscriptions","organizations_url":"https://api.github.com/users/miguelhincapie/orgs","repos_url":"https://api.github.com/users/miguelhincapie/repos","events_url":"https://api.github.com/users/miguelhincapie/events{/privacy}","received_events_url":"https://api.github.com/users/miguelhincapie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miguelhincapie/Smack","description":"A modular and portable open source XMPP client library written in Java for Android and Java (SE) VMs","fork":true,"url":"https://api.github.com/repos/miguelhincapie/Smack","forks_url":"https://api.github.com/repos/miguelhincapie/Smack/forks","keys_url":"https://api.github.com/repos/miguelhincapie/Smack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miguelhincapie/Smack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miguelhincapie/Smack/teams","hooks_url":"https://api.github.com/repos/miguelhincapie/Smack/hooks","issue_events_url":"https://api.github.com/repos/miguelhincapie/Smack/issues/events{/number}","events_url":"https://api.github.com/repos/miguelhincapie/Smack/events","assignees_url":"https://api.github.com/repos/miguelhincapie/Smack/assignees{/user}","branches_url":"https://api.github.com/repos/miguelhincapie/Smack/branches{/branch}","tags_url":"https://api.github.com/repos/miguelhincapie/Smack/tags","blobs_url":"https://api.github.com/repos/miguelhincapie/Smack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miguelhincapie/Smack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miguelhincapie/Smack/git/refs{/sha}","trees_url":"https://api.github.com/repos/miguelhincapie/Smack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miguelhincapie/Smack/statuses/{sha}","languages_url":"https://api.github.com/repos/miguelhincapie/Smack/languages","stargazers_url":"https://api.github.com/repos/miguelhincapie/Smack/stargazers","contributors_url":"https://api.github.com/repos/miguelhincapie/Smack/contributors","subscribers_url":"https://api.github.com/repos/miguelhincapie/Smack/subscribers","subscription_url":"https://api.github.com/repos/miguelhincapie/Smack/subscription","commits_url":"https://api.github.com/repos/miguelhincapie/Smack/commits{/sha}","git_commits_url":"https://api.github.com/repos/miguelhincapie/Smack/git/commits{/sha}","comments_url":"https://api.github.com/repos/miguelhincapie/Smack/comments{/number}","issue_comment_url":"https://api.github.com/repos/miguelhincapie/Smack/issues/comments{/number}","contents_url":"https://api.github.com/repos/miguelhincapie/Smack/contents/{+path}","compare_url":"https://api.github.com/repos/miguelhincapie/Smack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miguelhincapie/Smack/merges","archive_url":"https://api.github.com/repos/miguelhincapie/Smack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miguelhincapie/Smack/downloads","issues_url":"https://api.github.com/repos/miguelhincapie/Smack/issues{/number}","pulls_url":"https://api.github.com/repos/miguelhincapie/Smack/pulls{/number}","milestones_url":"https://api.github.com/repos/miguelhincapie/Smack/milestones{/number}","notifications_url":"https://api.github.com/repos/miguelhincapie/Smack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miguelhincapie/Smack/labels{/name}","releases_url":"https://api.github.com/repos/miguelhincapie/Smack/releases{/id}","deployments_url":"https://api.github.com/repos/miguelhincapie/Smack/deployments","created_at":"2018-07-24T20:43:38Z","updated_at":"2018-07-24T20:43:44Z","pushed_at":"2018-07-27T21:44:03Z","git_url":"git://github.com/miguelhincapie/Smack.git","ssh_url":"git@github.com:miguelhincapie/Smack.git","clone_url":"https://github.com/miguelhincapie/Smack.git","svn_url":"https://github.com/miguelhincapie/Smack","homepage":"https://igniterealtime.org/projects/smack/","size":27633,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"igniterealtime:master","ref":"master","sha":"c4c15c3e0a8926c1a360a95ffd2caed83f2e4539","user":{"login":"igniterealtime","id":5991032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTEwMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5991032?v=4","gravatar_id":"","url":"https://api.github.com/users/igniterealtime","html_url":"https://github.com/igniterealtime","followers_url":"https://api.github.com/users/igniterealtime/followers","following_url":"https://api.github.com/users/igniterealtime/following{/other_user}","gists_url":"https://api.github.com/users/igniterealtime/gists{/gist_id}","starred_url":"https://api.github.com/users/igniterealtime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igniterealtime/subscriptions","organizations_url":"https://api.github.com/users/igniterealtime/orgs","repos_url":"https://api.github.com/users/igniterealtime/repos","events_url":"https://api.github.com/users/igniterealtime/events{/privacy}","received_events_url":"https://api.github.com/users/igniterealtime/received_events","type":"Organization","site_admin":false},"repo":{"id":16477702,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ3NzcwMg==","name":"Smack","full_name":"igniterealtime/Smack","owner":{"login":"igniterealtime","id":5991032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTEwMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5991032?v=4","gravatar_id":"","url":"https://api.github.com/users/igniterealtime","html_url":"https://github.com/igniterealtime","followers_url":"https://api.github.com/users/igniterealtime/followers","following_url":"https://api.github.com/users/igniterealtime/following{/other_user}","gists_url":"https://api.github.com/users/igniterealtime/gists{/gist_id}","starred_url":"https://api.github.com/users/igniterealtime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igniterealtime/subscriptions","organizations_url":"https://api.github.com/users/igniterealtime/orgs","repos_url":"https://api.github.com/users/igniterealtime/repos","events_url":"https://api.github.com/users/igniterealtime/events{/privacy}","received_events_url":"https://api.github.com/users/igniterealtime/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/igniterealtime/Smack","description":"A modular and portable open source XMPP client library written in Java for Android and Java (SE) VMs","fork":false,"url":"https://api.github.com/repos/igniterealtime/Smack","forks_url":"https://api.github.com/repos/igniterealtime/Smack/forks","keys_url":"https://api.github.com/repos/igniterealtime/Smack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igniterealtime/Smack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igniterealtime/Smack/teams","hooks_url":"https://api.github.com/repos/igniterealtime/Smack/hooks","issue_events_url":"https://api.github.com/repos/igniterealtime/Smack/issues/events{/number}","events_url":"https://api.github.com/repos/igniterealtime/Smack/events","assignees_url":"https://api.github.com/repos/igniterealtime/Smack/assignees{/user}","branches_url":"https://api.github.com/repos/igniterealtime/Smack/branches{/branch}","tags_url":"https://api.github.com/repos/igniterealtime/Smack/tags","blobs_url":"https://api.github.com/repos/igniterealtime/Smack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igniterealtime/Smack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igniterealtime/Smack/git/refs{/sha}","trees_url":"https://api.github.com/repos/igniterealtime/Smack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igniterealtime/Smack/statuses/{sha}","languages_url":"https://api.github.com/repos/igniterealtime/Smack/languages","stargazers_url":"https://api.github.com/repos/igniterealtime/Smack/stargazers","contributors_url":"https://api.github.com/repos/igniterealtime/Smack/contributors","subscribers_url":"https://api.github.com/repos/igniterealtime/Smack/subscribers","subscription_url":"https://api.github.com/repos/igniterealtime/Smack/subscription","commits_url":"https://api.github.com/repos/igniterealtime/Smack/commits{/sha}","git_commits_url":"https://api.github.com/repos/igniterealtime/Smack/git/commits{/sha}","comments_url":"https://api.github.com/repos/igniterealtime/Smack/comments{/number}","issue_comment_url":"https://api.github.com/repos/igniterealtime/Smack/issues/comments{/number}","contents_url":"https://api.github.com/repos/igniterealtime/Smack/contents/{+path}","compare_url":"https://api.github.com/repos/igniterealtime/Smack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igniterealtime/Smack/merges","archive_url":"https://api.github.com/repos/igniterealtime/Smack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igniterealtime/Smack/downloads","issues_url":"https://api.github.com/repos/igniterealtime/Smack/issues{/number}","pulls_url":"https://api.github.com/repos/igniterealtime/Smack/pulls{/number}","milestones_url":"https://api.github.com/repos/igniterealtime/Smack/milestones{/number}","notifications_url":"https://api.github.com/repos/igniterealtime/Smack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igniterealtime/Smack/labels{/name}","releases_url":"https://api.github.com/repos/igniterealtime/Smack/releases{/id}","deployments_url":"https://api.github.com/repos/igniterealtime/Smack/deployments","created_at":"2014-02-03T11:36:51Z","updated_at":"2018-07-28T10:58:06Z","pushed_at":"2018-07-28T10:58:03Z","git_url":"git://github.com/igniterealtime/Smack.git","ssh_url":"git@github.com:igniterealtime/Smack.git","clone_url":"https://github.com/igniterealtime/Smack.git","svn_url":"https://github.com/igniterealtime/Smack","homepage":"https://igniterealtime.org/projects/smack/","size":27644,"stargazers_count":1757,"watchers_count":1757,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":713,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":713,"open_issues":11,"watchers":1757,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/igniterealtime/Smack/pulls/256"},"html":{"href":"https://github.com/igniterealtime/Smack/pull/256"},"issue":{"href":"https://api.github.com/repos/igniterealtime/Smack/issues/256"},"comments":{"href":"https://api.github.com/repos/igniterealtime/Smack/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/igniterealtime/Smack/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/igniterealtime/Smack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/igniterealtime/Smack/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/igniterealtime/Smack/statuses/5f884641fc98678f8bcd5910a42923fb26e84ba1"}},"author_association":"NONE"}}
{"actor":{"display_login":"vanitasvitae"}}