{"action":"created","issue":{"url":"https://api.github.com/repos/spotify/gordon/issues/21","repository_url":"https://api.github.com/repos/spotify/gordon","labels_url":"https://api.github.com/repos/spotify/gordon/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/spotify/gordon/issues/21/comments","events_url":"https://api.github.com/repos/spotify/gordon/issues/21/events","html_url":"https://github.com/spotify/gordon/pull/21","id":329490746,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNzMzNTk5","number":21,"title":"Update plugin_loader to load metrics plugin; Add FFWD metrics plugin","user":{"login":"matt0bi","id":33331579,"node_id":"MDQ6VXNlcjMzMzMxNTc5","avatar_url":"https://avatars3.githubusercontent.com/u/33331579?v=4","gravatar_id":"","url":"https://api.github.com/users/matt0bi","html_url":"https://github.com/matt0bi","followers_url":"https://api.github.com/users/matt0bi/followers","following_url":"https://api.github.com/users/matt0bi/following{/other_user}","gists_url":"https://api.github.com/users/matt0bi/gists{/gist_id}","starred_url":"https://api.github.com/users/matt0bi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt0bi/subscriptions","organizations_url":"https://api.github.com/users/matt0bi/orgs","repos_url":"https://api.github.com/users/matt0bi/repos","events_url":"https://api.github.com/users/matt0bi/events{/privacy}","received_events_url":"https://api.github.com/users/matt0bi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-05T14:45:58Z","updated_at":"2018-06-05T15:02:04Z","closed_at":"2018-06-05T15:02:04Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/spotify/gordon/pulls/21","html_url":"https://github.com/spotify/gordon/pull/21","diff_url":"https://github.com/spotify/gordon/pull/21.diff","patch_url":"https://github.com/spotify/gordon/pull/21.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines <https://github.com/spotify/gordon/blob/master/CONTRIBUTING.rst>\r\n2. If the PR is unfinished, please prefix the subject line with [WIP], [DRAFT], or [RFC].\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThis PR updates the plugin loader to pick and load a metrics and to pass it to all the other plugins. It also implements a simple FFWD-compatible metrics plugin that adheres to the IMetricRelay interface and which can be used to push metrics to FFWD. \r\n\r\n**Which issue(s) this PR fixes** \r\n<!-- optional; in `fixes #<issue number>, fixes #<issue_number>, ...` format, will close the issue(s) when PR gets merged: -->\r\nN/A\r\n\r\n**Special notes for your reviewer**:\r\n\r\nThe FFWD plugin is included by default in order to avoid creating another repository. Since FFWD is our current choice for metrics, it makes sense if we include and support it as part of Gordon. Because users select the metrics plugin through the configuration file, including it doesn't mean users are forced to use FFWD.\r\n\r\nThe FFWD plugin doesn't use or depend on [aioshumway](https://github.com/spotify/aioshumway/). We opted for this in order to break away from the shumway interface, which we wouldn't use in any way apart from the `MetricRelay.emit` method, and to have one less dependency, which also affords us more flexibility. \r\n\r\nThis PR doesn't include the default metrics plugin, which, instead of emitting metrics, will log them to stdout. The next PR will. \r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, start the release note with the string \"action required: \".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nEnable plugin loader to load metrics plugin.\r\nAdd FFWD-compatible metrics plugin.\r\n```\r\n\r\n@spotify/alf "},"comment":{"url":"https://api.github.com/repos/spotify/gordon/issues/comments/394743386","html_url":"https://github.com/spotify/gordon/pull/21#issuecomment-394743386","issue_url":"https://api.github.com/repos/spotify/gordon/issues/21","id":394743386,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDc0MzM4Ng==","user":{"login":"matt0bi","id":33331579,"node_id":"MDQ6VXNlcjMzMzMxNTc5","avatar_url":"https://avatars3.githubusercontent.com/u/33331579?v=4","gravatar_id":"","url":"https://api.github.com/users/matt0bi","html_url":"https://github.com/matt0bi","followers_url":"https://api.github.com/users/matt0bi/followers","following_url":"https://api.github.com/users/matt0bi/following{/other_user}","gists_url":"https://api.github.com/users/matt0bi/gists{/gist_id}","starred_url":"https://api.github.com/users/matt0bi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt0bi/subscriptions","organizations_url":"https://api.github.com/users/matt0bi/orgs","repos_url":"https://api.github.com/users/matt0bi/repos","events_url":"https://api.github.com/users/matt0bi/events{/privacy}","received_events_url":"https://api.github.com/users/matt0bi/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T15:02:04Z","updated_at":"2018-06-05T15:02:04Z","author_association":"CONTRIBUTOR","body":"Closing in order to to make a new PR (#22) that adheres to our branch naming flow."}}
{"actor":{"display_login":"matt0bi"}}