{"action":"created","comment":{"url":"https://api.github.com/repos/iFixit/pipe-to-graphite/pulls/comments/191240592","pull_request_review_id":123775092,"id":191240592,"diff_hunk":"@@ -1,5 +1,9 @@\n #!/bin/bash\n argument=\"$1\"\n+\n+IP_ADDR=$(hostname -I | sed 's/ /\\n/g' | grep '10\\.')\n+CLEAN_IP_ADDR=$(echo \"$IP_ADDR\" | sed 's/\\./-/g')","path":"scripts/memcache-stats.sh","position":5,"original_position":5,"commit_id":"b26d123d235a6868a18955f0767dd8500f07b97f","original_commit_id":"b26d123d235a6868a18955f0767dd8500f07b97f","user":{"login":"danielbeardsley","id":26855,"avatar_url":"https://avatars3.githubusercontent.com/u/26855?v=4","gravatar_id":"","url":"https://api.github.com/users/danielbeardsley","html_url":"https://github.com/danielbeardsley","followers_url":"https://api.github.com/users/danielbeardsley/followers","following_url":"https://api.github.com/users/danielbeardsley/following{/other_user}","gists_url":"https://api.github.com/users/danielbeardsley/gists{/gist_id}","starred_url":"https://api.github.com/users/danielbeardsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielbeardsley/subscriptions","organizations_url":"https://api.github.com/users/danielbeardsley/orgs","repos_url":"https://api.github.com/users/danielbeardsley/repos","events_url":"https://api.github.com/users/danielbeardsley/events{/privacy}","received_events_url":"https://api.github.com/users/danielbeardsley/received_events","type":"User","site_admin":false},"body":"One more :-)\r\n\r\n```\r\nhostname -I | grep -oP \"\\b10(\\.\\d]+){3}\"\r\n```\r\nYours would match `101.` and `1012345` ...","created_at":"2018-05-28T16:12:35Z","updated_at":"2018-05-28T16:12:35Z","html_url":"https://github.com/iFixit/pipe-to-graphite/pull/16#discussion_r191240592","pull_request_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/pulls/16","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/iFixit/pipe-to-graphite/pulls/comments/191240592"},"html":{"href":"https://github.com/iFixit/pipe-to-graphite/pull/16#discussion_r191240592"},"pull_request":{"href":"https://api.github.com/repos/iFixit/pipe-to-graphite/pulls/16"}},"in_reply_to_id":191030891},"pull_request":{"url":"https://api.github.com/repos/iFixit/pipe-to-graphite/pulls/16","id":190664913,"html_url":"https://github.com/iFixit/pipe-to-graphite/pull/16","diff_url":"https://github.com/iFixit/pipe-to-graphite/pull/16.diff","patch_url":"https://github.com/iFixit/pipe-to-graphite/pull/16.patch","issue_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/issues/16","number":16,"state":"open","locked":false,"title":"Add IP address to the memcached script","user":{"login":"djmetzle","id":6876047,"avatar_url":"https://avatars0.githubusercontent.com/u/6876047?v=4","gravatar_id":"","url":"https://api.github.com/users/djmetzle","html_url":"https://github.com/djmetzle","followers_url":"https://api.github.com/users/djmetzle/followers","following_url":"https://api.github.com/users/djmetzle/following{/other_user}","gists_url":"https://api.github.com/users/djmetzle/gists{/gist_id}","starred_url":"https://api.github.com/users/djmetzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmetzle/subscriptions","organizations_url":"https://api.github.com/users/djmetzle/orgs","repos_url":"https://api.github.com/users/djmetzle/repos","events_url":"https://api.github.com/users/djmetzle/events{/privacy}","received_events_url":"https://api.github.com/users/djmetzle/received_events","type":"User","site_admin":false},"body":"We want to take the memcached stats with an IP address in graphite.\n\nWe will no longer be running a single global instance of memcached. That\nmeans we need a way to distinguish the running instances. Using the\ninstance's IP address is a simple distinction.\n\nNot that we \"clean\" the IP address to use dashes, no dots. Dots are the\nseparator for graphite stats.\n\nQA\n---\n\nRun the script on cominor to see the expected output. As the name\nsuggests, it will `piped-to-graphite`.\n\nCC @danielbeardsley\n\nRef: https://github.com/iFixit/server-templates/issues/1916","created_at":"2018-05-25T18:34:27Z","updated_at":"2018-05-28T16:12:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9dde93dde752fcbca39d4d9dff7e62e0c78e354c","assignee":{"login":"djmetzle","id":6876047,"avatar_url":"https://avatars0.githubusercontent.com/u/6876047?v=4","gravatar_id":"","url":"https://api.github.com/users/djmetzle","html_url":"https://github.com/djmetzle","followers_url":"https://api.github.com/users/djmetzle/followers","following_url":"https://api.github.com/users/djmetzle/following{/other_user}","gists_url":"https://api.github.com/users/djmetzle/gists{/gist_id}","starred_url":"https://api.github.com/users/djmetzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmetzle/subscriptions","organizations_url":"https://api.github.com/users/djmetzle/orgs","repos_url":"https://api.github.com/users/djmetzle/repos","events_url":"https://api.github.com/users/djmetzle/events{/privacy}","received_events_url":"https://api.github.com/users/djmetzle/received_events","type":"User","site_admin":false},"assignees":[{"login":"djmetzle","id":6876047,"avatar_url":"https://avatars0.githubusercontent.com/u/6876047?v=4","gravatar_id":"","url":"https://api.github.com/users/djmetzle","html_url":"https://github.com/djmetzle","followers_url":"https://api.github.com/users/djmetzle/followers","following_url":"https://api.github.com/users/djmetzle/following{/other_user}","gists_url":"https://api.github.com/users/djmetzle/gists{/gist_id}","starred_url":"https://api.github.com/users/djmetzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmetzle/subscriptions","organizations_url":"https://api.github.com/users/djmetzle/orgs","repos_url":"https://api.github.com/users/djmetzle/repos","events_url":"https://api.github.com/users/djmetzle/events{/privacy}","received_events_url":"https://api.github.com/users/djmetzle/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":944898467,"url":"https://api.github.com/repos/iFixit/pipe-to-graphite/labels/r-no-notes","name":"r-no-notes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/pulls/16/commits","review_comments_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/pulls/16/comments","review_comment_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/issues/16/comments","statuses_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/statuses/b26d123d235a6868a18955f0767dd8500f07b97f","head":{"label":"iFixit:ip-tag-memcached-stats","ref":"ip-tag-memcached-stats","sha":"b26d123d235a6868a18955f0767dd8500f07b97f","user":{"login":"iFixit","id":318148,"avatar_url":"https://avatars1.githubusercontent.com/u/318148?v=4","gravatar_id":"","url":"https://api.github.com/users/iFixit","html_url":"https://github.com/iFixit","followers_url":"https://api.github.com/users/iFixit/followers","following_url":"https://api.github.com/users/iFixit/following{/other_user}","gists_url":"https://api.github.com/users/iFixit/gists{/gist_id}","starred_url":"https://api.github.com/users/iFixit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iFixit/subscriptions","organizations_url":"https://api.github.com/users/iFixit/orgs","repos_url":"https://api.github.com/users/iFixit/repos","events_url":"https://api.github.com/users/iFixit/events{/privacy}","received_events_url":"https://api.github.com/users/iFixit/received_events","type":"Organization","site_admin":false},"repo":{"id":5310728,"name":"pipe-to-graphite","full_name":"iFixit/pipe-to-graphite","owner":{"login":"iFixit","id":318148,"avatar_url":"https://avatars1.githubusercontent.com/u/318148?v=4","gravatar_id":"","url":"https://api.github.com/users/iFixit","html_url":"https://github.com/iFixit","followers_url":"https://api.github.com/users/iFixit/followers","following_url":"https://api.github.com/users/iFixit/following{/other_user}","gists_url":"https://api.github.com/users/iFixit/gists{/gist_id}","starred_url":"https://api.github.com/users/iFixit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iFixit/subscriptions","organizations_url":"https://api.github.com/users/iFixit/orgs","repos_url":"https://api.github.com/users/iFixit/repos","events_url":"https://api.github.com/users/iFixit/events{/privacy}","received_events_url":"https://api.github.com/users/iFixit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iFixit/pipe-to-graphite","description":"Easily send the output of any script or command to Graphite at regular intervals","fork":false,"url":"https://api.github.com/repos/iFixit/pipe-to-graphite","forks_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/forks","keys_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/teams","hooks_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/hooks","issue_events_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/issues/events{/number}","events_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/events","assignees_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/assignees{/user}","branches_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/branches{/branch}","tags_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/tags","blobs_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/git/refs{/sha}","trees_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/statuses/{sha}","languages_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/languages","stargazers_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/stargazers","contributors_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/contributors","subscribers_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/subscribers","subscription_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/subscription","commits_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/commits{/sha}","git_commits_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/git/commits{/sha}","comments_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/comments{/number}","issue_comment_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/issues/comments{/number}","contents_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/contents/{+path}","compare_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/merges","archive_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/downloads","issues_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/issues{/number}","pulls_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/pulls{/number}","milestones_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/milestones{/number}","notifications_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/labels{/name}","releases_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/releases{/id}","deployments_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/deployments","created_at":"2012-08-06T06:15:49Z","updated_at":"2018-05-25T18:31:45Z","pushed_at":"2018-05-25T18:34:28Z","git_url":"git://github.com/iFixit/pipe-to-graphite.git","ssh_url":"git@github.com:iFixit/pipe-to-graphite.git","clone_url":"https://github.com/iFixit/pipe-to-graphite.git","svn_url":"https://github.com/iFixit/pipe-to-graphite","homepage":null,"size":24,"stargazers_count":68,"watchers_count":68,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":13,"open_issues":3,"watchers":68,"default_branch":"master"}},"base":{"label":"iFixit:master","ref":"master","sha":"2fd27586c52f5990fb2b2b412292cd5759882b81","user":{"login":"iFixit","id":318148,"avatar_url":"https://avatars1.githubusercontent.com/u/318148?v=4","gravatar_id":"","url":"https://api.github.com/users/iFixit","html_url":"https://github.com/iFixit","followers_url":"https://api.github.com/users/iFixit/followers","following_url":"https://api.github.com/users/iFixit/following{/other_user}","gists_url":"https://api.github.com/users/iFixit/gists{/gist_id}","starred_url":"https://api.github.com/users/iFixit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iFixit/subscriptions","organizations_url":"https://api.github.com/users/iFixit/orgs","repos_url":"https://api.github.com/users/iFixit/repos","events_url":"https://api.github.com/users/iFixit/events{/privacy}","received_events_url":"https://api.github.com/users/iFixit/received_events","type":"Organization","site_admin":false},"repo":{"id":5310728,"name":"pipe-to-graphite","full_name":"iFixit/pipe-to-graphite","owner":{"login":"iFixit","id":318148,"avatar_url":"https://avatars1.githubusercontent.com/u/318148?v=4","gravatar_id":"","url":"https://api.github.com/users/iFixit","html_url":"https://github.com/iFixit","followers_url":"https://api.github.com/users/iFixit/followers","following_url":"https://api.github.com/users/iFixit/following{/other_user}","gists_url":"https://api.github.com/users/iFixit/gists{/gist_id}","starred_url":"https://api.github.com/users/iFixit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iFixit/subscriptions","organizations_url":"https://api.github.com/users/iFixit/orgs","repos_url":"https://api.github.com/users/iFixit/repos","events_url":"https://api.github.com/users/iFixit/events{/privacy}","received_events_url":"https://api.github.com/users/iFixit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iFixit/pipe-to-graphite","description":"Easily send the output of any script or command to Graphite at regular intervals","fork":false,"url":"https://api.github.com/repos/iFixit/pipe-to-graphite","forks_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/forks","keys_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/teams","hooks_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/hooks","issue_events_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/issues/events{/number}","events_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/events","assignees_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/assignees{/user}","branches_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/branches{/branch}","tags_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/tags","blobs_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/git/refs{/sha}","trees_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/statuses/{sha}","languages_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/languages","stargazers_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/stargazers","contributors_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/contributors","subscribers_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/subscribers","subscription_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/subscription","commits_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/commits{/sha}","git_commits_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/git/commits{/sha}","comments_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/comments{/number}","issue_comment_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/issues/comments{/number}","contents_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/contents/{+path}","compare_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/merges","archive_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/downloads","issues_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/issues{/number}","pulls_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/pulls{/number}","milestones_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/milestones{/number}","notifications_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/labels{/name}","releases_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/releases{/id}","deployments_url":"https://api.github.com/repos/iFixit/pipe-to-graphite/deployments","created_at":"2012-08-06T06:15:49Z","updated_at":"2018-05-25T18:31:45Z","pushed_at":"2018-05-25T18:34:28Z","git_url":"git://github.com/iFixit/pipe-to-graphite.git","ssh_url":"git@github.com:iFixit/pipe-to-graphite.git","clone_url":"https://github.com/iFixit/pipe-to-graphite.git","svn_url":"https://github.com/iFixit/pipe-to-graphite","homepage":null,"size":24,"stargazers_count":68,"watchers_count":68,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":13,"open_issues":3,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iFixit/pipe-to-graphite/pulls/16"},"html":{"href":"https://github.com/iFixit/pipe-to-graphite/pull/16"},"issue":{"href":"https://api.github.com/repos/iFixit/pipe-to-graphite/issues/16"},"comments":{"href":"https://api.github.com/repos/iFixit/pipe-to-graphite/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/iFixit/pipe-to-graphite/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/iFixit/pipe-to-graphite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iFixit/pipe-to-graphite/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/iFixit/pipe-to-graphite/statuses/b26d123d235a6868a18955f0767dd8500f07b97f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"danielbeardsley"}}