{"action":"created","issue":{"url":"https://api.github.com/repos/ExpediaDotCom/haystack-idl/issues/31","repository_url":"https://api.github.com/repos/ExpediaDotCom/haystack-idl","labels_url":"https://api.github.com/repos/ExpediaDotCom/haystack-idl/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/ExpediaDotCom/haystack-idl/issues/31/comments","events_url":"https://api.github.com/repos/ExpediaDotCom/haystack-idl/issues/31/events","html_url":"https://github.com/ExpediaDotCom/haystack-idl/issues/31","id":360697241,"node_id":"MDU6SXNzdWUzNjA2OTcyNDE=","number":31,"title":"Clarify span.serviceName","user":{"login":"adriancole","id":64215,"node_id":"MDQ6VXNlcjY0MjE1","avatar_url":"https://avatars2.githubusercontent.com/u/64215?v=4","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-17T00:59:08Z","updated_at":"2018-12-05T06:11:30Z","closed_at":null,"author_association":"NONE","body":"I think the service name in haystack is the same as zipkin.localEndpoint.serviceName, but wanted to clarify. For example, if you concat the relevant parts of localEndpoint with serviceName in [zipkin's proto](https://github.com/openzipkin/zipkin-api/blob/master/zipkin.proto), you'd get:\r\n\r\n```proto\r\n  // Lower-case label of the node that recorded this span in in the service\r\n  // graph, such as \"favstar\". Leave absent if unknown.\r\n  //\r\n  // This is a primary label for trace lookup and aggregation, so it should be\r\n // intuitive and consistent. Many use a name from service discovery.\r\n```\r\n\r\nI looked and seems consistent as Tracer in haystack java client's use of service looks exactly like Brave. Can you clarify this is the case?\r\n\r\nhttps://github.com/ExpediaDotCom/haystack-idl/blob/master/proto/span.proto#L30"},"comment":{"url":"https://api.github.com/repos/ExpediaDotCom/haystack-idl/issues/comments/444371120","html_url":"https://github.com/ExpediaDotCom/haystack-idl/issues/31#issuecomment-444371120","issue_url":"https://api.github.com/repos/ExpediaDotCom/haystack-idl/issues/31","id":444371120,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDM3MTEyMA==","user":{"login":"ashishagg","id":4974230,"node_id":"MDQ6VXNlcjQ5NzQyMzA=","avatar_url":"https://avatars3.githubusercontent.com/u/4974230?v=4","gravatar_id":"","url":"https://api.github.com/users/ashishagg","html_url":"https://github.com/ashishagg","followers_url":"https://api.github.com/users/ashishagg/followers","following_url":"https://api.github.com/users/ashishagg/following{/other_user}","gists_url":"https://api.github.com/users/ashishagg/gists{/gist_id}","starred_url":"https://api.github.com/users/ashishagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashishagg/subscriptions","organizations_url":"https://api.github.com/users/ashishagg/orgs","repos_url":"https://api.github.com/users/ashishagg/repos","events_url":"https://api.github.com/users/ashishagg/events{/privacy}","received_events_url":"https://api.github.com/users/ashishagg/received_events","type":"User","site_admin":false},"created_at":"2018-12-05T06:11:30Z","updated_at":"2018-12-05T06:11:30Z","author_association":"CONTRIBUTOR","body":"Yes, service name in our span's definition is same as zipkin.localEndpoint.serviceName. \r\nWe are yet to add remote service name in our definitions."}}
{"actor":{"display_login":"ashishagg"}}