{"action":"created","issue":{"url":"https://api.github.com/repos/spyder-ide/spyder/issues/7785","repository_url":"https://api.github.com/repos/spyder-ide/spyder","labels_url":"https://api.github.com/repos/spyder-ide/spyder/issues/7785/labels{/name}","comments_url":"https://api.github.com/repos/spyder-ide/spyder/issues/7785/comments","events_url":"https://api.github.com/repos/spyder-ide/spyder/issues/7785/events","html_url":"https://github.com/spyder-ide/spyder/pull/7785","id":355363084,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTEwNjE0","number":7785,"title":"[WiP] PR: House cleaning","user":{"login":"CAM-Gerlach","id":17051931,"node_id":"MDQ6VXNlcjE3MDUxOTMx","avatar_url":"https://avatars0.githubusercontent.com/u/17051931?v=4","gravatar_id":"","url":"https://api.github.com/users/CAM-Gerlach","html_url":"https://github.com/CAM-Gerlach","followers_url":"https://api.github.com/users/CAM-Gerlach/followers","following_url":"https://api.github.com/users/CAM-Gerlach/following{/other_user}","gists_url":"https://api.github.com/users/CAM-Gerlach/gists{/gist_id}","starred_url":"https://api.github.com/users/CAM-Gerlach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CAM-Gerlach/subscriptions","organizations_url":"https://api.github.com/users/CAM-Gerlach/orgs","repos_url":"https://api.github.com/users/CAM-Gerlach/repos","events_url":"https://api.github.com/users/CAM-Gerlach/events{/privacy}","received_events_url":"https://api.github.com/users/CAM-Gerlach/received_events","type":"User","site_admin":false},"labels":[{"id":821132344,"node_id":"MDU6TGFiZWw4MjExMzIzNDQ=","url":"https://api.github.com/repos/spyder-ide/spyder/labels/status:Work%20In%20Progress","name":"status:Work In Progress","color":"53fcda","default":false},{"id":517492233,"node_id":"MDU6TGFiZWw1MTc0OTIyMzM=","url":"https://api.github.com/repos/spyder-ide/spyder/labels/type:Task","name":"type:Task","color":"e99695","default":false}],"state":"open","locked":false,"assignee":{"login":"CAM-Gerlach","id":17051931,"node_id":"MDQ6VXNlcjE3MDUxOTMx","avatar_url":"https://avatars0.githubusercontent.com/u/17051931?v=4","gravatar_id":"","url":"https://api.github.com/users/CAM-Gerlach","html_url":"https://github.com/CAM-Gerlach","followers_url":"https://api.github.com/users/CAM-Gerlach/followers","following_url":"https://api.github.com/users/CAM-Gerlach/following{/other_user}","gists_url":"https://api.github.com/users/CAM-Gerlach/gists{/gist_id}","starred_url":"https://api.github.com/users/CAM-Gerlach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CAM-Gerlach/subscriptions","organizations_url":"https://api.github.com/users/CAM-Gerlach/orgs","repos_url":"https://api.github.com/users/CAM-Gerlach/repos","events_url":"https://api.github.com/users/CAM-Gerlach/events{/privacy}","received_events_url":"https://api.github.com/users/CAM-Gerlach/received_events","type":"User","site_admin":false},"assignees":[{"login":"CAM-Gerlach","id":17051931,"node_id":"MDQ6VXNlcjE3MDUxOTMx","avatar_url":"https://avatars0.githubusercontent.com/u/17051931?v=4","gravatar_id":"","url":"https://api.github.com/users/CAM-Gerlach","html_url":"https://github.com/CAM-Gerlach","followers_url":"https://api.github.com/users/CAM-Gerlach/followers","following_url":"https://api.github.com/users/CAM-Gerlach/following{/other_user}","gists_url":"https://api.github.com/users/CAM-Gerlach/gists{/gist_id}","starred_url":"https://api.github.com/users/CAM-Gerlach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CAM-Gerlach/subscriptions","organizations_url":"https://api.github.com/users/CAM-Gerlach/orgs","repos_url":"https://api.github.com/users/CAM-Gerlach/repos","events_url":"https://api.github.com/users/CAM-Gerlach/events{/privacy}","received_events_url":"https://api.github.com/users/CAM-Gerlach/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/spyder-ide/spyder/milestones/59","html_url":"https://github.com/spyder-ide/spyder/milestone/59","labels_url":"https://api.github.com/repos/spyder-ide/spyder/milestones/59/labels","id":3496447,"node_id":"MDk6TWlsZXN0b25lMzQ5NjQ0Nw==","number":59,"title":"v3.3.2","description":"","creator":{"login":"ccordoba12","id":365293,"node_id":"MDQ6VXNlcjM2NTI5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/365293?v=4","gravatar_id":"","url":"https://api.github.com/users/ccordoba12","html_url":"https://github.com/ccordoba12","followers_url":"https://api.github.com/users/ccordoba12/followers","following_url":"https://api.github.com/users/ccordoba12/following{/other_user}","gists_url":"https://api.github.com/users/ccordoba12/gists{/gist_id}","starred_url":"https://api.github.com/users/ccordoba12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccordoba12/subscriptions","organizations_url":"https://api.github.com/users/ccordoba12/orgs","repos_url":"https://api.github.com/users/ccordoba12/repos","events_url":"https://api.github.com/users/ccordoba12/events{/privacy}","received_events_url":"https://api.github.com/users/ccordoba12/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":43,"state":"open","created_at":"2018-07-14T23:49:53Z","updated_at":"2018-09-03T17:01:14Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2018-08-29T22:57:03Z","updated_at":"2018-09-05T08:16:30Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/spyder-ide/spyder/pulls/7785","html_url":"https://github.com/spyder-ide/spyder/pull/7785","diff_url":"https://github.com/spyder-ide/spyder/pull/7785.diff","patch_url":"https://github.com/spyder-ide/spyder/pull/7785.patch"},"body":"<!--- Before submitting your pull request --->\r\n<!--- please complete as much as possible of the following checklist: --->\r\n\r\n### Pull Request Checklist\r\n\r\n* [x] Read and followed this repo's [Contributing Guidelines](https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md)\r\n* [x] Based your PR on the latest version of the correct branch (master or 3.x)\r\n* [x] Followed [PEP8](https://www.python.org/dev/peps/pep-0008/) for code style\r\n* [x] ~~Ensured your pull request hasn't eliminated unrelated blank lines/spaces,\r\n      modified the ``spyder/defaults`` directory, or added new icons/assets~~\r\n* [x] Described your changes and the motivation for them below\r\n\r\n\r\n## Description of Changes\r\n\r\n<!--- Describe what you've changed and why. --->\r\n\r\nWaiting on @ccordoba12 to attach the source files for the Oxygen icons; then I'll make a few final changes that need to go last, and this will at long last be done.\r\n\r\nFinal changes:\r\n* [ ] Add source files for Oxygen icon them-derived icons from @ccordoba12 : BLOCKING\r\n* [ ] Harmonize LICENSE, etc. to LF\r\n* [ ] Move LICENSE/AUTHORS to .txt and NOTICES to NOTICE and update MANIFEST\r\n* [ ] Add appropriate boilerplate/list to LICENSE, AUTHORS, and __init__\r\n* [ ] Fix license title and other details in LICENSE and __init__.py\r\n* [ ] Clarify/add links to AUTHORS like for docs\r\n* [ ] Add template and instructions to NOTICES.txt and checkbox to PR template\r\n\r\nAlso, is there anything that needs to be done to make sure the NOTICE.txt always gets shipped with the package on both conda and pip?\r\n\r\nClean up a lot of old mess that could potentially cause problems, particularly legal ones, and make everything much cleaner, clearer, more transparent and well-documented.\r\n\r\nI tried to minimize modifications to files that were moved in ``split-plugins`` to only those that were strictly necessary. The files added or changed in locations there moved were: \r\n\r\nAdd:\r\n```\r\nspyder/utils/help/js/mathjax/LICENSE.txt\r\nspyder/utils/help/LICENSE.txt\r\n```\r\n\r\nModify:\r\n```\r\nspyder/utils/sourcecode/kill_ring.py\r\nspyder_profiler/widgets/profilergui.py\r\nspyder/utils/help/__init__.py\r\nspyder/utils/help/js/collapse_sections.py\r\nspyder/utils/help/js/copy_button.py\r\nspyder/widgets/variableexplorer/dataframeeditor.py\r\n```\r\n\r\nOnce merged to master, I will follow this up with a PR making a few master-specific changes (mostly to file paths listed in NOTICE.txt), if they are not modified in the merge itself.\r\n\r\nFor the icon files that were removed, I took numerous steps to ensure to the greatest extent practical that they were not used anywhere and their removal would not cause other problems. Included among these steps for each of the removed icons (where \"name\" is the name of the icon, without the extension):\r\n\r\n- Searched for all instances of \"name\" and \"name + extension\" in 3.x and master w/ both Github and Spyder Find in Files\r\n- Used Git Blame to trace and verify past usage(s) of given icons\r\n- Inserted temporary code to both print a debug message and raise an exception if an icon was not found\r\n- Started Spyder with all panes enabled and tested basic functionality in every pane as well as the File Switcher and File Open/Save dialogs\r\n- Tested both Python 3 and Python 2 icon sets, and compared functionality with clean Spyder 3.2.8\r\n- Ran all tests (including slow) locally\r\n- Filetypes-specific removal justification:\r\n    - Added prior to July 2009, although a few additional types added as soon as ~2012\r\n    - Checked every relevant icon(), get_icon(), get_std_icon(), get_image_path() and filetypes call\r\n    - Tested file explorer with and without change in both icon sets with files of various extensions\r\n    - Checked every \"*.png\" string\r\n\r\nThanks!\r\n\r\n<!--- Thanks for your help making Spyder better for everyone! --->\r\n"},"comment":{"url":"https://api.github.com/repos/spyder-ide/spyder/issues/comments/418641290","html_url":"https://github.com/spyder-ide/spyder/pull/7785#issuecomment-418641290","issue_url":"https://api.github.com/repos/spyder-ide/spyder/issues/7785","id":418641290,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODY0MTI5MA==","user":{"login":"ccordoba12","id":365293,"node_id":"MDQ6VXNlcjM2NTI5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/365293?v=4","gravatar_id":"","url":"https://api.github.com/users/ccordoba12","html_url":"https://github.com/ccordoba12","followers_url":"https://api.github.com/users/ccordoba12/followers","following_url":"https://api.github.com/users/ccordoba12/following{/other_user}","gists_url":"https://api.github.com/users/ccordoba12/gists{/gist_id}","starred_url":"https://api.github.com/users/ccordoba12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccordoba12/subscriptions","organizations_url":"https://api.github.com/users/ccordoba12/orgs","repos_url":"https://api.github.com/users/ccordoba12/repos","events_url":"https://api.github.com/users/ccordoba12/events{/privacy}","received_events_url":"https://api.github.com/users/ccordoba12/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T08:16:30Z","updated_at":"2018-09-05T08:16:30Z","author_association":"MEMBER","body":"> especially as Spyder 3 becomes our \"LTS\" branch that is going to be out there for a long time yet\r\n\r\nSpyder 3 will cease to be supported as soon as Spyder 4 is out.\r\n\r\n----\r\n\r\nI'll add the icons in another PR **for 3.3.2**. Until that version is released, I see nothing wrong about it."}}
{"actor":{"display_login":"ccordoba12"}}