{"action":"created","issue":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1496","repository_url":"https://api.github.com/repos/Subsurface-divelog/subsurface","labels_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1496/labels{/name}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1496/comments","events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1496/events","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1496","id":340501654,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODk3MTA0","number":1496,"title":"Qt-script update","user":{"login":"jbygdell","id":24942439,"node_id":"MDQ6VXNlcjI0OTQyNDM5","avatar_url":"https://avatars2.githubusercontent.com/u/24942439?v=4","gravatar_id":"","url":"https://api.github.com/users/jbygdell","html_url":"https://github.com/jbygdell","followers_url":"https://api.github.com/users/jbygdell/followers","following_url":"https://api.github.com/users/jbygdell/following{/other_user}","gists_url":"https://api.github.com/users/jbygdell/gists{/gist_id}","starred_url":"https://api.github.com/users/jbygdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbygdell/subscriptions","organizations_url":"https://api.github.com/users/jbygdell/orgs","repos_url":"https://api.github.com/users/jbygdell/repos","events_url":"https://api.github.com/users/jbygdell/events{/privacy}","received_events_url":"https://api.github.com/users/jbygdell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-12T06:12:14Z","updated_at":"2018-07-12T14:58:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1496","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1496","diff_url":"https://github.com/Subsurface-divelog/subsurface/pull/1496.diff","patch_url":"https://github.com/Subsurface-divelog/subsurface/pull/1496.patch"},"body":"With commit c62ce43 the Qt version where updated to 5.11.1, this updates the qt install script to match the versions of the Qt parts we want.\r\n\r\n### Describe the pull request:\r\n<!-- Replace [ ] with [x] to select options. -->\r\n- [ ] Bug fix\r\n- [ ] Functional change\r\n- [ ] New feature\r\n- [ ] Code cleanup\r\n- [x] Build system change\r\n- [ ] Documentation change\r\n- [ ] Language translation\r\n\r\n### Pull request long description:\r\nWhen changing Qt version both the variables.sh and qt-installer-noninteractive.qs files needs to be updated. Comment added to the variables file not to forget to also change the qt-install script.\r\n\r\n### Changes made:\r\n<!-- Enumerate the changes with 1), 2), 3) etc. -->\r\n<!-- Ensure the test cases are updated if needed. -->\r\n\r\n### Related issues:\r\n<!-- Reference issues with #<issue-num>. -->\r\n<!-- Write \"Fixes #<issue-num\" to notify Github that this PR fixes an issue. -->\r\n\r\n### Additional information:\r\n<!-- Include sample dive log or other relevant information to allow testing the change where feasible. -->\r\n\r\n### Release note:\r\n<!-- Describe if this change needs a release note present in CHANGELOG.md. -->\r\n<!-- Also, please make sure to add the release note on top of the file CHANGELOG.md. -->\r\n\r\n### Documentation change:\r\n<!-- If this PR makes changes to user functionality, then the documentation has to be updated too. -->\r\n<!-- Please, briefly outline here what has changed in terms of the user experience (UX). -->\r\n<!-- If UX changes have been made, a maintainer should apply the 'needs-documentation-change' label. -->\r\n\r\n### Mentions:\r\n<!-- Mention users that you want to review your pull request with @<user-name>. Leave empty if not sure. -->\r\n"},"comment":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/comments/404542010","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1496#issuecomment-404542010","issue_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1496","id":404542010,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDU0MjAxMA==","user":{"login":"dirkhh","id":237471,"node_id":"MDQ6VXNlcjIzNzQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/237471?v=4","gravatar_id":"","url":"https://api.github.com/users/dirkhh","html_url":"https://github.com/dirkhh","followers_url":"https://api.github.com/users/dirkhh/followers","following_url":"https://api.github.com/users/dirkhh/following{/other_user}","gists_url":"https://api.github.com/users/dirkhh/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkhh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkhh/subscriptions","organizations_url":"https://api.github.com/users/dirkhh/orgs","repos_url":"https://api.github.com/users/dirkhh/repos","events_url":"https://api.github.com/users/dirkhh/events{/privacy}","received_events_url":"https://api.github.com/users/dirkhh/received_events","type":"User","site_admin":false},"created_at":"2018-07-12T14:58:04Z","updated_at":"2018-07-12T14:58:04Z","author_association":"COLLABORATOR","body":"Thank you for those. Both of them should have been obvious to me. I am still happier with the Travis Android solution (much faster), but I completely missed that I SHOULD have done this in the first place.\r\nMuch appreciated."}}
{"actor":{"display_login":"dirkhh"}}