{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/fissile/pulls/comments/185139006","pull_request_review_id":116470989,"id":185139006,"diff_hunk":"@@ -86,3 +101,32 @@ func mergeMap(obj map[string]interface{}, value interface{}, key ...string) map[\n \tobj[key[0]] = mergeMap(obj[key[0]].(map[string]interface{}), value, key[1:]...)\n \treturn obj\n }\n+\n+// Helper functions for the template engine. Snarfed from sprig and\n+// helm for our testing. Avoid vendoring of entire sprig, and of the\n+// whole helm rendering engine.","path":"testhelpers/helm_helper.go","position":null,"original_position":43,"commit_id":"fc02ae35793cbaf9e0f77f68e43c245707c6aaca","original_commit_id":"fb6ad3f0da118d9bf72cc4a49a9378219bfdb851","user":{"login":"andreas-kupries","id":577247,"avatar_url":"https://avatars0.githubusercontent.com/u/577247?v=4","gravatar_id":"","url":"https://api.github.com/users/andreas-kupries","html_url":"https://github.com/andreas-kupries","followers_url":"https://api.github.com/users/andreas-kupries/followers","following_url":"https://api.github.com/users/andreas-kupries/following{/other_user}","gists_url":"https://api.github.com/users/andreas-kupries/gists{/gist_id}","starred_url":"https://api.github.com/users/andreas-kupries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreas-kupries/subscriptions","organizations_url":"https://api.github.com/users/andreas-kupries/orgs","repos_url":"https://api.github.com/users/andreas-kupries/repos","events_url":"https://api.github.com/users/andreas-kupries/events{/privacy}","received_events_url":"https://api.github.com/users/andreas-kupries/received_events","type":"User","site_admin":false},"body":"Done with commit 98813ae590b3d25adf072c87e9042b2b6a9237d0","created_at":"2018-04-30T23:34:42Z","updated_at":"2018-04-30T23:34:42Z","html_url":"https://github.com/SUSE/fissile/pull/350#discussion_r185139006","pull_request_url":"https://api.github.com/repos/SUSE/fissile/pulls/350","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SUSE/fissile/pulls/comments/185139006"},"html":{"href":"https://github.com/SUSE/fissile/pull/350#discussion_r185139006"},"pull_request":{"href":"https://api.github.com/repos/SUSE/fissile/pulls/350"}},"in_reply_to_id":185122088},"pull_request":{"url":"https://api.github.com/repos/SUSE/fissile/pulls/350","id":184184289,"html_url":"https://github.com/SUSE/fissile/pull/350","diff_url":"https://github.com/SUSE/fissile/pull/350.diff","patch_url":"https://github.com/SUSE/fissile/pull/350.patch","issue_url":"https://api.github.com/repos/SUSE/fissile/issues/350","number":350,"state":"open","locked":false,"title":"Extended unit tests covering more of helm chart output","user":{"login":"andreas-kupries","id":577247,"avatar_url":"https://avatars0.githubusercontent.com/u/577247?v=4","gravatar_id":"","url":"https://api.github.com/users/andreas-kupries","html_url":"https://github.com/andreas-kupries","followers_url":"https://api.github.com/users/andreas-kupries/followers","following_url":"https://api.github.com/users/andreas-kupries/following{/other_user}","gists_url":"https://api.github.com/users/andreas-kupries/gists{/gist_id}","starred_url":"https://api.github.com/users/andreas-kupries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreas-kupries/subscriptions","organizations_url":"https://api.github.com/users/andreas-kupries/orgs","repos_url":"https://api.github.com/users/andreas-kupries/repos","events_url":"https://api.github.com/users/andreas-kupries/events{/privacy}","received_events_url":"https://api.github.com/users/andreas-kupries/received_events","type":"User","site_admin":false},"body":"Ref https://trello.com/c/42gyM3NL/382-8-create-fissile-tests-for-helm-charts\r\n\r\nNote, this and https://github.com/SUSE/fissile/pull/349 are in conflict over the contents of `helm_helper.go` (RenderNode, template setup). Whichever is merged second has to rebase fix the conflict.","created_at":"2018-04-25T22:50:07Z","updated_at":"2018-04-30T23:34:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1bed58060b56e96f3244197c4821782570f3fe5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/fissile/pulls/350/commits","review_comments_url":"https://api.github.com/repos/SUSE/fissile/pulls/350/comments","review_comment_url":"https://api.github.com/repos/SUSE/fissile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/fissile/issues/350/comments","statuses_url":"https://api.github.com/repos/SUSE/fissile/statuses/fc02ae35793cbaf9e0f77f68e43c245707c6aaca","head":{"label":"SUSE:aku/42gyM3NL-helm-testing","ref":"aku/42gyM3NL-helm-testing","sha":"fc02ae35793cbaf9e0f77f68e43c245707c6aaca","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":42498148,"name":"fissile","full_name":"SUSE/fissile","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/fissile","description":"Turn a BOSH release into Docker images / files","fork":false,"url":"https://api.github.com/repos/SUSE/fissile","forks_url":"https://api.github.com/repos/SUSE/fissile/forks","keys_url":"https://api.github.com/repos/SUSE/fissile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/fissile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/fissile/teams","hooks_url":"https://api.github.com/repos/SUSE/fissile/hooks","issue_events_url":"https://api.github.com/repos/SUSE/fissile/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/fissile/events","assignees_url":"https://api.github.com/repos/SUSE/fissile/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/fissile/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/fissile/tags","blobs_url":"https://api.github.com/repos/SUSE/fissile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/fissile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/fissile/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/fissile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/fissile/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/fissile/languages","stargazers_url":"https://api.github.com/repos/SUSE/fissile/stargazers","contributors_url":"https://api.github.com/repos/SUSE/fissile/contributors","subscribers_url":"https://api.github.com/repos/SUSE/fissile/subscribers","subscription_url":"https://api.github.com/repos/SUSE/fissile/subscription","commits_url":"https://api.github.com/repos/SUSE/fissile/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/fissile/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/fissile/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/fissile/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/fissile/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/fissile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/fissile/merges","archive_url":"https://api.github.com/repos/SUSE/fissile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/fissile/downloads","issues_url":"https://api.github.com/repos/SUSE/fissile/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/fissile/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/fissile/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/fissile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/fissile/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/fissile/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/fissile/deployments","created_at":"2015-09-15T05:51:21Z","updated_at":"2018-04-27T20:57:53Z","pushed_at":"2018-04-30T23:34:19Z","git_url":"git://github.com/SUSE/fissile.git","ssh_url":"git@github.com:SUSE/fissile.git","clone_url":"https://github.com/SUSE/fissile.git","svn_url":"https://github.com/SUSE/fissile","homepage":"","size":51230,"stargazers_count":43,"watchers_count":43,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":21,"open_issues":7,"watchers":43,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"4c79a2ba7c11114ce8eb69071eef6fa0c1c605a6","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":42498148,"name":"fissile","full_name":"SUSE/fissile","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/fissile","description":"Turn a BOSH release into Docker images / files","fork":false,"url":"https://api.github.com/repos/SUSE/fissile","forks_url":"https://api.github.com/repos/SUSE/fissile/forks","keys_url":"https://api.github.com/repos/SUSE/fissile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/fissile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/fissile/teams","hooks_url":"https://api.github.com/repos/SUSE/fissile/hooks","issue_events_url":"https://api.github.com/repos/SUSE/fissile/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/fissile/events","assignees_url":"https://api.github.com/repos/SUSE/fissile/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/fissile/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/fissile/tags","blobs_url":"https://api.github.com/repos/SUSE/fissile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/fissile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/fissile/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/fissile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/fissile/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/fissile/languages","stargazers_url":"https://api.github.com/repos/SUSE/fissile/stargazers","contributors_url":"https://api.github.com/repos/SUSE/fissile/contributors","subscribers_url":"https://api.github.com/repos/SUSE/fissile/subscribers","subscription_url":"https://api.github.com/repos/SUSE/fissile/subscription","commits_url":"https://api.github.com/repos/SUSE/fissile/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/fissile/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/fissile/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/fissile/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/fissile/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/fissile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/fissile/merges","archive_url":"https://api.github.com/repos/SUSE/fissile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/fissile/downloads","issues_url":"https://api.github.com/repos/SUSE/fissile/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/fissile/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/fissile/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/fissile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/fissile/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/fissile/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/fissile/deployments","created_at":"2015-09-15T05:51:21Z","updated_at":"2018-04-27T20:57:53Z","pushed_at":"2018-04-30T23:34:19Z","git_url":"git://github.com/SUSE/fissile.git","ssh_url":"git@github.com:SUSE/fissile.git","clone_url":"https://github.com/SUSE/fissile.git","svn_url":"https://github.com/SUSE/fissile","homepage":"","size":51230,"stargazers_count":43,"watchers_count":43,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":21,"open_issues":7,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/fissile/pulls/350"},"html":{"href":"https://github.com/SUSE/fissile/pull/350"},"issue":{"href":"https://api.github.com/repos/SUSE/fissile/issues/350"},"comments":{"href":"https://api.github.com/repos/SUSE/fissile/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/fissile/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/fissile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/fissile/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/fissile/statuses/fc02ae35793cbaf9e0f77f68e43c245707c6aaca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andreas-kupries"}}