{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/243778964","pull_request_review_id":187635851,"id":243778964,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzc3ODk2NA==","diff_hunk":"@@ -306,23 +306,30 @@ The same alignment can be used when ``others`` is a ``DataFrame``:\n Concatenating a Series and many objects into a Series\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n \n-All one-dimensional list-likes can be combined in a list-like container (including iterators, ``dict``-views, etc.):\n+Several items can be combined a list-like container (including iterators, ``dict``-views, etc.), which may contain ``Series``, ``Index`` and ``np.ndarray``.\n+Note that ``Index`` will align as well, so for the purpose of this example, we change ``s`` and ``u`` from above to also have a string index:\n \n .. ipython:: python\n \n-    s\n-    u\n-    s.str.cat([u.values,\n-               u.index.astype(str).values], na_rep='-')\n+    s_values = np.array(['a', 'b', 'c', 'd'], dtype=object)\n+    s2 = pd.Series(s_values, index=s_values)\n+    s2","path":"doc/source/text.rst","position":16,"original_position":16,"commit_id":"f7440525bd0c254846fcaa1e244f2d6a82fc646a","original_commit_id":"f7440525bd0c254846fcaa1e244f2d6a82fc646a","user":{"login":"jreback","id":953992,"node_id":"MDQ6VXNlcjk1Mzk5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"this whole example needs to be simpler. maybe just leave the index as integers to avoid confusion, IOW focus less on the join in str.cat and more on the list-lke things that are going on.","created_at":"2018-12-23T23:41:20Z","updated_at":"2018-12-23T23:41:23Z","html_url":"https://github.com/pandas-dev/pandas/pull/23723#discussion_r243778964","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23723","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/243778964"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/23723#discussion_r243778964"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23723"}},"in_reply_to_id":243778947},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23723","id":231299663,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjk5NjYz","html_url":"https://github.com/pandas-dev/pandas/pull/23723","diff_url":"https://github.com/pandas-dev/pandas/pull/23723.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/23723.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/23723","number":23723,"state":"open","locked":false,"title":"DOC: update str.cat example","user":{"login":"h-vetinari","id":33685575,"node_id":"MDQ6VXNlcjMzNjg1NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"body":"There have been a couple of changes recently due to the whole docstring validation effort (e.g. #22838), which got rid of some warnings emitted by the sample code.\r\n\r\nAs it stands, the code samples don't really reflect the running text anymore, and with the changes from #22264, it makes sense to update the running text as well.","created_at":"2018-11-15T18:57:30Z","updated_at":"2018-12-23T23:41:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abd89eb9a1606c7fde3c069f046faccc6668c591","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":134699,"node_id":"MDU6TGFiZWwxMzQ2OTk=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Docs","name":"Docs","color":"3465A4","default":false},{"id":57522093,"node_id":"MDU6TGFiZWw1NzUyMjA5Mw==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Strings","name":"Strings","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23723/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23723/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/23723/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/f7440525bd0c254846fcaa1e244f2d6a82fc646a","head":{"label":"h-vetinari:str_cat_docs","ref":"str_cat_docs","sha":"f7440525bd0c254846fcaa1e244f2d6a82fc646a","user":{"login":"h-vetinari","id":33685575,"node_id":"MDQ6VXNlcjMzNjg1NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"repo":{"id":125207159,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyMDcxNTk=","name":"pandas","full_name":"h-vetinari/pandas","private":false,"owner":{"login":"h-vetinari","id":33685575,"node_id":"MDQ6VXNlcjMzNjg1NTc1","avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"html_url":"https://github.com/h-vetinari/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/h-vetinari/pandas","forks_url":"https://api.github.com/repos/h-vetinari/pandas/forks","keys_url":"https://api.github.com/repos/h-vetinari/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h-vetinari/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h-vetinari/pandas/teams","hooks_url":"https://api.github.com/repos/h-vetinari/pandas/hooks","issue_events_url":"https://api.github.com/repos/h-vetinari/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/h-vetinari/pandas/events","assignees_url":"https://api.github.com/repos/h-vetinari/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/h-vetinari/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/h-vetinari/pandas/tags","blobs_url":"https://api.github.com/repos/h-vetinari/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h-vetinari/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h-vetinari/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/h-vetinari/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h-vetinari/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/h-vetinari/pandas/languages","stargazers_url":"https://api.github.com/repos/h-vetinari/pandas/stargazers","contributors_url":"https://api.github.com/repos/h-vetinari/pandas/contributors","subscribers_url":"https://api.github.com/repos/h-vetinari/pandas/subscribers","subscription_url":"https://api.github.com/repos/h-vetinari/pandas/subscription","commits_url":"https://api.github.com/repos/h-vetinari/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/h-vetinari/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/h-vetinari/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/h-vetinari/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/h-vetinari/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/h-vetinari/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h-vetinari/pandas/merges","archive_url":"https://api.github.com/repos/h-vetinari/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h-vetinari/pandas/downloads","issues_url":"https://api.github.com/repos/h-vetinari/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/h-vetinari/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/h-vetinari/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/h-vetinari/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h-vetinari/pandas/labels{/name}","releases_url":"https://api.github.com/repos/h-vetinari/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/h-vetinari/pandas/deployments","created_at":"2018-03-14T12:12:19Z","updated_at":"2018-12-19T22:52:19Z","pushed_at":"2018-12-22T23:47:39Z","git_url":"git://github.com/h-vetinari/pandas.git","ssh_url":"git@github.com:h-vetinari/pandas.git","clone_url":"https://github.com/h-vetinari/pandas.git","svn_url":"https://github.com/h-vetinari/pandas","homepage":"http://pandas.pydata.org","size":140779,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"1250500cfe18f60cfb8a4867c82d14467bbee7ad","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","private":false,"owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-12-23T23:08:40Z","pushed_at":"2018-12-23T23:16:22Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"https://pandas.pydata.org","size":140893,"stargazers_count":17478,"watchers_count":17478,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7011,"mirror_url":null,"archived":false,"open_issues_count":2821,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":7011,"open_issues":2821,"watchers":17478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23723"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/23723"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/23723"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/23723/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23723/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23723/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/f7440525bd0c254846fcaa1e244f2d6a82fc646a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jreback"}}