{"action":"created","comment":{"url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/pulls/comments/241946310","pull_request_review_id":185351424,"id":241946310,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTk0NjMxMA==","diff_hunk":"@@ -482,30 +482,30 @@ echo \"### Deleting older versions of service daemons. This might throw errors, i\n sudo systemctl disable idle-watchdog\n sudo systemctl disable rfid-reader\n sudo systemctl disable startup-sound\n-sudo systemctl disable gpio-buttons","path":"scripts/installscripts/stretch-install-default.sh","position":15,"original_position":15,"commit_id":"9770955521f5c8efe7832d0412c9b3c3e80f8fdb","original_commit_id":"9770955521f5c8efe7832d0412c9b3c3e80f8fdb","user":{"login":"topas-rec","id":20391449,"node_id":"MDQ6VXNlcjIwMzkxNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/20391449?v=4","gravatar_id":"","url":"https://api.github.com/users/topas-rec","html_url":"https://github.com/topas-rec","followers_url":"https://api.github.com/users/topas-rec/followers","following_url":"https://api.github.com/users/topas-rec/following{/other_user}","gists_url":"https://api.github.com/users/topas-rec/gists{/gist_id}","starred_url":"https://api.github.com/users/topas-rec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topas-rec/subscriptions","organizations_url":"https://api.github.com/users/topas-rec/orgs","repos_url":"https://api.github.com/users/topas-rec/repos","events_url":"https://api.github.com/users/topas-rec/events{/privacy}","received_events_url":"https://api.github.com/users/topas-rec/received_events","type":"User","site_admin":false},"body":"This should stay for a while I guess right?","created_at":"2018-12-15T11:13:28Z","updated_at":"2018-12-15T11:13:28Z","html_url":"https://github.com/MiczFlor/RPi-Jukebox-RFID/pull/387#discussion_r241946310","pull_request_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/pulls/387","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/pulls/comments/241946310"},"html":{"href":"https://github.com/MiczFlor/RPi-Jukebox-RFID/pull/387#discussion_r241946310"},"pull_request":{"href":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/pulls/387"}}},"pull_request":{"url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/pulls/387","id":238903138,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTAzMTM4","html_url":"https://github.com/MiczFlor/RPi-Jukebox-RFID/pull/387","diff_url":"https://github.com/MiczFlor/RPi-Jukebox-RFID/pull/387.diff","patch_url":"https://github.com/MiczFlor/RPi-Jukebox-RFID/pull/387.patch","issue_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/issues/387","number":387,"state":"open","locked":false,"title":"Simple powered up led","user":{"login":"topas-rec","id":20391449,"node_id":"MDQ6VXNlcjIwMzkxNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/20391449?v=4","gravatar_id":"","url":"https://api.github.com/users/topas-rec","html_url":"https://github.com/topas-rec","followers_url":"https://api.github.com/users/topas-rec/followers","following_url":"https://api.github.com/users/topas-rec/following{/other_user}","gists_url":"https://api.github.com/users/topas-rec/gists{/gist_id}","starred_url":"https://api.github.com/users/topas-rec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topas-rec/subscriptions","organizations_url":"https://api.github.com/users/topas-rec/orgs","repos_url":"https://api.github.com/users/topas-rec/repos","events_url":"https://api.github.com/users/topas-rec/events{/privacy}","received_events_url":"https://api.github.com/users/topas-rec/received_events","type":"User","site_admin":false},"body":"In my opinion a good addition to find out if usb power connection can be safely disconnected between Raspberry Pi and the Power bank using an external switch.\r\nLed is turned on, when Pi is running, when pushing power button is blinks two times to indicate shutdown initiated. Then is stays on until Pi loses power. Now one can disconnect power safely.\r\n\r\nLed uses free GPIO 3.\r\nCan be ignored if led is not used.\r\n\r\nRenamed GPIO buttons file because it now also controls led.\r\n\r\nI made video of the functionality, but need to upload it somewhere.","created_at":"2018-12-15T10:15:22Z","updated_at":"2018-12-15T11:13:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c837aa8e01dbf0f95b3848afef224aa3c0104da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/pulls/387/commits","review_comments_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/pulls/387/comments","review_comment_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/issues/387/comments","statuses_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/statuses/9770955521f5c8efe7832d0412c9b3c3e80f8fdb","head":{"label":"topas-rec:simple_powered_up_led","ref":"simple_powered_up_led","sha":"9770955521f5c8efe7832d0412c9b3c3e80f8fdb","user":{"login":"topas-rec","id":20391449,"node_id":"MDQ6VXNlcjIwMzkxNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/20391449?v=4","gravatar_id":"","url":"https://api.github.com/users/topas-rec","html_url":"https://github.com/topas-rec","followers_url":"https://api.github.com/users/topas-rec/followers","following_url":"https://api.github.com/users/topas-rec/following{/other_user}","gists_url":"https://api.github.com/users/topas-rec/gists{/gist_id}","starred_url":"https://api.github.com/users/topas-rec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topas-rec/subscriptions","organizations_url":"https://api.github.com/users/topas-rec/orgs","repos_url":"https://api.github.com/users/topas-rec/repos","events_url":"https://api.github.com/users/topas-rec/events{/privacy}","received_events_url":"https://api.github.com/users/topas-rec/received_events","type":"User","site_admin":false},"repo":{"id":159708137,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk3MDgxMzc=","name":"RPi-Jukebox-RFID","full_name":"topas-rec/RPi-Jukebox-RFID","private":false,"owner":{"login":"topas-rec","id":20391449,"node_id":"MDQ6VXNlcjIwMzkxNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/20391449?v=4","gravatar_id":"","url":"https://api.github.com/users/topas-rec","html_url":"https://github.com/topas-rec","followers_url":"https://api.github.com/users/topas-rec/followers","following_url":"https://api.github.com/users/topas-rec/following{/other_user}","gists_url":"https://api.github.com/users/topas-rec/gists{/gist_id}","starred_url":"https://api.github.com/users/topas-rec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topas-rec/subscriptions","organizations_url":"https://api.github.com/users/topas-rec/orgs","repos_url":"https://api.github.com/users/topas-rec/repos","events_url":"https://api.github.com/users/topas-rec/events{/privacy}","received_events_url":"https://api.github.com/users/topas-rec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/topas-rec/RPi-Jukebox-RFID","description":"A Raspberry Pi jukebox, playing local music, podcasts and web radio, streams and spotify triggered by RFID cards and/or web app. All plug and play via USB. GPIO scripts available.","fork":true,"url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID","forks_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/forks","keys_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/keys{/key_id}","collaborators_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/teams","hooks_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/hooks","issue_events_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/issues/events{/number}","events_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/events","assignees_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/assignees{/user}","branches_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/branches{/branch}","tags_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/tags","blobs_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/git/refs{/sha}","trees_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/git/trees{/sha}","statuses_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/statuses/{sha}","languages_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/languages","stargazers_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/stargazers","contributors_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/contributors","subscribers_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/subscribers","subscription_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/subscription","commits_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/commits{/sha}","git_commits_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/git/commits{/sha}","comments_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/comments{/number}","issue_comment_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/issues/comments{/number}","contents_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/contents/{+path}","compare_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/compare/{base}...{head}","merges_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/merges","archive_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/downloads","issues_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/issues{/number}","pulls_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/pulls{/number}","milestones_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/milestones{/number}","notifications_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/labels{/name}","releases_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/releases{/id}","deployments_url":"https://api.github.com/repos/topas-rec/RPi-Jukebox-RFID/deployments","created_at":"2018-11-29T18:12:46Z","updated_at":"2018-12-15T09:35:34Z","pushed_at":"2018-12-15T09:49:58Z","git_url":"git://github.com/topas-rec/RPi-Jukebox-RFID.git","ssh_url":"git@github.com:topas-rec/RPi-Jukebox-RFID.git","clone_url":"https://github.com/topas-rec/RPi-Jukebox-RFID.git","svn_url":"https://github.com/topas-rec/RPi-Jukebox-RFID","homepage":"http://phoniebox.de","size":12184,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MiczFlor:master","ref":"master","sha":"6ba66e09e285ef4dd83c6068d49b499aa1bcb130","user":{"login":"MiczFlor","id":1876216,"node_id":"MDQ6VXNlcjE4NzYyMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1876216?v=4","gravatar_id":"","url":"https://api.github.com/users/MiczFlor","html_url":"https://github.com/MiczFlor","followers_url":"https://api.github.com/users/MiczFlor/followers","following_url":"https://api.github.com/users/MiczFlor/following{/other_user}","gists_url":"https://api.github.com/users/MiczFlor/gists{/gist_id}","starred_url":"https://api.github.com/users/MiczFlor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiczFlor/subscriptions","organizations_url":"https://api.github.com/users/MiczFlor/orgs","repos_url":"https://api.github.com/users/MiczFlor/repos","events_url":"https://api.github.com/users/MiczFlor/events{/privacy}","received_events_url":"https://api.github.com/users/MiczFlor/received_events","type":"User","site_admin":false},"repo":{"id":80719637,"node_id":"MDEwOlJlcG9zaXRvcnk4MDcxOTYzNw==","name":"RPi-Jukebox-RFID","full_name":"MiczFlor/RPi-Jukebox-RFID","private":false,"owner":{"login":"MiczFlor","id":1876216,"node_id":"MDQ6VXNlcjE4NzYyMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1876216?v=4","gravatar_id":"","url":"https://api.github.com/users/MiczFlor","html_url":"https://github.com/MiczFlor","followers_url":"https://api.github.com/users/MiczFlor/followers","following_url":"https://api.github.com/users/MiczFlor/following{/other_user}","gists_url":"https://api.github.com/users/MiczFlor/gists{/gist_id}","starred_url":"https://api.github.com/users/MiczFlor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiczFlor/subscriptions","organizations_url":"https://api.github.com/users/MiczFlor/orgs","repos_url":"https://api.github.com/users/MiczFlor/repos","events_url":"https://api.github.com/users/MiczFlor/events{/privacy}","received_events_url":"https://api.github.com/users/MiczFlor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MiczFlor/RPi-Jukebox-RFID","description":"A Raspberry Pi jukebox, playing local music, podcasts and web radio, streams and spotify triggered by RFID cards and/or web app. All plug and play via USB. GPIO scripts available.","fork":false,"url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID","forks_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/forks","keys_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/teams","hooks_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/hooks","issue_events_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/issues/events{/number}","events_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/events","assignees_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/assignees{/user}","branches_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/branches{/branch}","tags_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/tags","blobs_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/git/refs{/sha}","trees_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/statuses/{sha}","languages_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/languages","stargazers_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/stargazers","contributors_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/contributors","subscribers_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/subscribers","subscription_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/subscription","commits_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/commits{/sha}","git_commits_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/git/commits{/sha}","comments_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/comments{/number}","issue_comment_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/issues/comments{/number}","contents_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/contents/{+path}","compare_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/merges","archive_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/downloads","issues_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/issues{/number}","pulls_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/pulls{/number}","milestones_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/milestones{/number}","notifications_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/labels{/name}","releases_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/releases{/id}","deployments_url":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/deployments","created_at":"2017-02-02T11:41:41Z","updated_at":"2018-12-14T07:29:41Z","pushed_at":"2018-12-15T10:15:23Z","git_url":"git://github.com/MiczFlor/RPi-Jukebox-RFID.git","ssh_url":"git@github.com:MiczFlor/RPi-Jukebox-RFID.git","clone_url":"https://github.com/MiczFlor/RPi-Jukebox-RFID.git","svn_url":"https://github.com/MiczFlor/RPi-Jukebox-RFID","homepage":"http://phoniebox.de","size":10708,"stargazers_count":182,"watchers_count":182,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":95,"open_issues":68,"watchers":182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/pulls/387"},"html":{"href":"https://github.com/MiczFlor/RPi-Jukebox-RFID/pull/387"},"issue":{"href":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/issues/387"},"comments":{"href":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/issues/387/comments"},"review_comments":{"href":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/pulls/387/comments"},"review_comment":{"href":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/pulls/387/commits"},"statuses":{"href":"https://api.github.com/repos/MiczFlor/RPi-Jukebox-RFID/statuses/9770955521f5c8efe7832d0412c9b3c3e80f8fdb"}},"author_association":"NONE"}}
{"actor":{"display_login":"topas-rec"}}