{"action":"created","issue":{"url":"https://api.github.com/repos/consilience/iso8583/issues/1","repository_url":"https://api.github.com/repos/consilience/iso8583","labels_url":"https://api.github.com/repos/consilience/iso8583/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/consilience/iso8583/issues/1/comments","events_url":"https://api.github.com/repos/consilience/iso8583/issues/1/events","html_url":"https://github.com/consilience/iso8583/issues/1","id":364404181,"node_id":"MDU6SXNzdWUzNjQ0MDQxODE=","number":1,"title":"Change Name","user":{"login":"judgej","id":395934,"node_id":"MDQ6VXNlcjM5NTkzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/395934?v=4","gravatar_id":"","url":"https://api.github.com/users/judgej","html_url":"https://github.com/judgej","followers_url":"https://api.github.com/users/judgej/followers","following_url":"https://api.github.com/users/judgej/following{/other_user}","gists_url":"https://api.github.com/users/judgej/gists{/gist_id}","starred_url":"https://api.github.com/users/judgej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judgej/subscriptions","organizations_url":"https://api.github.com/users/judgej/orgs","repos_url":"https://api.github.com/users/judgej/repos","events_url":"https://api.github.com/users/judgej/events{/privacy}","received_events_url":"https://api.github.com/users/judgej/received_events","type":"User","site_admin":false},"labels":[{"id":1071189245,"node_id":"MDU6TGFiZWwxMDcxMTg5MjQ1","url":"https://api.github.com/repos/consilience/iso8583/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"open","locked":false,"assignee":{"login":"judgej","id":395934,"node_id":"MDQ6VXNlcjM5NTkzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/395934?v=4","gravatar_id":"","url":"https://api.github.com/users/judgej","html_url":"https://github.com/judgej","followers_url":"https://api.github.com/users/judgej/followers","following_url":"https://api.github.com/users/judgej/following{/other_user}","gists_url":"https://api.github.com/users/judgej/gists{/gist_id}","starred_url":"https://api.github.com/users/judgej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judgej/subscriptions","organizations_url":"https://api.github.com/users/judgej/orgs","repos_url":"https://api.github.com/users/judgej/repos","events_url":"https://api.github.com/users/judgej/events{/privacy}","received_events_url":"https://api.github.com/users/judgej/received_events","type":"User","site_admin":false},"assignees":[{"login":"judgej","id":395934,"node_id":"MDQ6VXNlcjM5NTkzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/395934?v=4","gravatar_id":"","url":"https://api.github.com/users/judgej","html_url":"https://github.com/judgej","followers_url":"https://api.github.com/users/judgej/followers","following_url":"https://api.github.com/users/judgej/following{/other_user}","gists_url":"https://api.github.com/users/judgej/gists{/gist_id}","starred_url":"https://api.github.com/users/judgej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judgej/subscriptions","organizations_url":"https://api.github.com/users/judgej/orgs","repos_url":"https://api.github.com/users/judgej/repos","events_url":"https://api.github.com/users/judgej/events{/privacy}","received_events_url":"https://api.github.com/users/judgej/received_events","type":"User","site_admin":false},{"login":"barnabaskecskes","id":3535449,"node_id":"MDQ6VXNlcjM1MzU0NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/3535449?v=4","gravatar_id":"","url":"https://api.github.com/users/barnabaskecskes","html_url":"https://github.com/barnabaskecskes","followers_url":"https://api.github.com/users/barnabaskecskes/followers","following_url":"https://api.github.com/users/barnabaskecskes/following{/other_user}","gists_url":"https://api.github.com/users/barnabaskecskes/gists{/gist_id}","starred_url":"https://api.github.com/users/barnabaskecskes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barnabaskecskes/subscriptions","organizations_url":"https://api.github.com/users/barnabaskecskes/orgs","repos_url":"https://api.github.com/users/barnabaskecskes/repos","events_url":"https://api.github.com/users/barnabaskecskes/events{/privacy}","received_events_url":"https://api.github.com/users/barnabaskecskes/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-09-27T10:21:29Z","updated_at":"2018-09-27T14:57:13Z","closed_at":null,"author_association":"COLLABORATOR","body":"This fork is `consilience/iso8583` - forked for better control of features and fixes we need. We are using a proprietary caching system (everything rep-cached for production, with no reflection surprises). We are using our own custom schemas, which we cannot include here, but we want our schema to work reliably and that will mean some small changes.\r\n\r\nInitial tasks:\r\n\r\n* [x] Change root namespace. Also applies to tests, docs etc. Probably `Consilience\\Iso8583`?\r\n* [x] Remove absolute dependency on `tightenco/collect`. The risk here is that we are bringing in a package that name clashes with Laravel. Keeping our laravel version and the version of this dependency in sync is a burden we don't want. It could be added as an optional/recommended dependency, if the collection features turn out to be indispensable.\r\n* [ ] The cache manage needs an interface and we need the ability to inject our own cache manager. We will be generating the driving data offline and that data will be incorporated in our release, so we will have a cache manager that supplies the \"cached\" data from its own source, possibly as a PHP array rather than a JSON string that needs parsing every time we use it.\r\n* [ ] On cache management, a simple API to get at the parsed data - in JSON or as an array - is needed. (Not sure, this may already be built in, but I'm sure it's wrapped inside the cache manager.)\r\n* [ ] Hex encoding will be made an option. We are given messages that are NOT hex encoded, so having to encode them, just so this package can decode them, is a step that does not need to happen. Maybe the hex decoding can just be a single step at the start, rather than decoding scattered throughout? I guess there are implications for ISO8583 messages that contain binary data, so make sure we are dealing with non-ml strings here (binary strings).\r\n* [ ] Custom mappers - we do have some fields that need sub-fields extracted. A clean way to do that would be great. It seems a little ad-hoc at the moment.\r\n* [x] There is a develop branch in the source package that contains a little refactoring. Check if there are any bug fixes in there that we should also pull in.\r\n\r\nWe'll get this on composer for the first release, and tidy up the tests a little (so they pass). Also need to test against PHP 7.1 and 7.2"},"comment":{"url":"https://api.github.com/repos/consilience/iso8583/issues/comments/425124889","html_url":"https://github.com/consilience/iso8583/issues/1#issuecomment-425124889","issue_url":"https://api.github.com/repos/consilience/iso8583/issues/1","id":425124889,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTEyNDg4OQ==","user":{"login":"barnabaskecskes","id":3535449,"node_id":"MDQ6VXNlcjM1MzU0NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/3535449?v=4","gravatar_id":"","url":"https://api.github.com/users/barnabaskecskes","html_url":"https://github.com/barnabaskecskes","followers_url":"https://api.github.com/users/barnabaskecskes/followers","following_url":"https://api.github.com/users/barnabaskecskes/following{/other_user}","gists_url":"https://api.github.com/users/barnabaskecskes/gists{/gist_id}","starred_url":"https://api.github.com/users/barnabaskecskes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barnabaskecskes/subscriptions","organizations_url":"https://api.github.com/users/barnabaskecskes/orgs","repos_url":"https://api.github.com/users/barnabaskecskes/repos","events_url":"https://api.github.com/users/barnabaskecskes/events{/privacy}","received_events_url":"https://api.github.com/users/barnabaskecskes/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T14:57:13Z","updated_at":"2018-09-27T14:57:13Z","author_association":"NONE","body":"Fair enough. I trusted the documentation on optionals and positions, but further validation won't hurt, I agree. "}}
{"actor":{"display_login":"barnabaskecskes"}}