{"action":"created","issue":{"url":"https://api.github.com/repos/cn-uofbasel/ccn-lite/issues/173","repository_url":"https://api.github.com/repos/cn-uofbasel/ccn-lite","labels_url":"https://api.github.com/repos/cn-uofbasel/ccn-lite/issues/173/labels{/name}","comments_url":"https://api.github.com/repos/cn-uofbasel/ccn-lite/issues/173/comments","events_url":"https://api.github.com/repos/cn-uofbasel/ccn-lite/issues/173/events","html_url":"https://github.com/cn-uofbasel/ccn-lite/pull/173","id":294098777,"number":173,"title":"ccnl-pkt: static memory vs dynamic memory","user":{"login":"cgundogan","id":739129,"avatar_url":"https://avatars2.githubusercontent.com/u/739129?v=4","gravatar_id":"","url":"https://api.github.com/users/cgundogan","html_url":"https://github.com/cgundogan","followers_url":"https://api.github.com/users/cgundogan/followers","following_url":"https://api.github.com/users/cgundogan/following{/other_user}","gists_url":"https://api.github.com/users/cgundogan/gists{/gist_id}","starred_url":"https://api.github.com/users/cgundogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgundogan/subscriptions","organizations_url":"https://api.github.com/users/cgundogan/orgs","repos_url":"https://api.github.com/users/cgundogan/repos","events_url":"https://api.github.com/users/cgundogan/events{/privacy}","received_events_url":"https://api.github.com/users/cgundogan/received_events","type":"User","site_admin":false},"labels":[{"id":33085259,"url":"https://api.github.com/repos/cn-uofbasel/ccn-lite/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"blacksheeep","id":3641597,"avatar_url":"https://avatars0.githubusercontent.com/u/3641597?v=4","gravatar_id":"","url":"https://api.github.com/users/blacksheeep","html_url":"https://github.com/blacksheeep","followers_url":"https://api.github.com/users/blacksheeep/followers","following_url":"https://api.github.com/users/blacksheeep/following{/other_user}","gists_url":"https://api.github.com/users/blacksheeep/gists{/gist_id}","starred_url":"https://api.github.com/users/blacksheeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blacksheeep/subscriptions","organizations_url":"https://api.github.com/users/blacksheeep/orgs","repos_url":"https://api.github.com/users/blacksheeep/repos","events_url":"https://api.github.com/users/blacksheeep/events{/privacy}","received_events_url":"https://api.github.com/users/blacksheeep/received_events","type":"User","site_admin":false},"assignees":[{"login":"blacksheeep","id":3641597,"avatar_url":"https://avatars0.githubusercontent.com/u/3641597?v=4","gravatar_id":"","url":"https://api.github.com/users/blacksheeep","html_url":"https://github.com/blacksheeep","followers_url":"https://api.github.com/users/blacksheeep/followers","following_url":"https://api.github.com/users/blacksheeep/following{/other_user}","gists_url":"https://api.github.com/users/blacksheeep/gists{/gist_id}","starred_url":"https://api.github.com/users/blacksheeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blacksheeep/subscriptions","organizations_url":"https://api.github.com/users/blacksheeep/orgs","repos_url":"https://api.github.com/users/blacksheeep/repos","events_url":"https://api.github.com/users/blacksheeep/events{/privacy}","received_events_url":"https://api.github.com/users/blacksheeep/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-02-03T09:46:20Z","updated_at":"2018-02-04T17:14:30Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/cn-uofbasel/ccn-lite/pulls/173","html_url":"https://github.com/cn-uofbasel/ccn-lite/pull/173","diff_url":"https://github.com/cn-uofbasel/ccn-lite/pull/173.diff","patch_url":"https://github.com/cn-uofbasel/ccn-lite/pull/173.patch"},"body":"This patch introduces versions of `mkSimpleInterest` and `mkSimpleContent` that make use of a provided scratch space instead of calling malloc. I restructured the original functions to be simple wrapper functions that provide memory through `malloc` and pass the allocated memory to the new `*_scratch()` functions.\r\n\r\nI also changed the RIOT adapter to call the `_scratch()` function directly with static memory."},"comment":{"url":"https://api.github.com/repos/cn-uofbasel/ccn-lite/issues/comments/362922904","html_url":"https://github.com/cn-uofbasel/ccn-lite/pull/173#issuecomment-362922904","issue_url":"https://api.github.com/repos/cn-uofbasel/ccn-lite/issues/173","id":362922904,"user":{"login":"cgundogan","id":739129,"avatar_url":"https://avatars2.githubusercontent.com/u/739129?v=4","gravatar_id":"","url":"https://api.github.com/users/cgundogan","html_url":"https://github.com/cgundogan","followers_url":"https://api.github.com/users/cgundogan/followers","following_url":"https://api.github.com/users/cgundogan/following{/other_user}","gists_url":"https://api.github.com/users/cgundogan/gists{/gist_id}","starred_url":"https://api.github.com/users/cgundogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgundogan/subscriptions","organizations_url":"https://api.github.com/users/cgundogan/orgs","repos_url":"https://api.github.com/users/cgundogan/repos","events_url":"https://api.github.com/users/cgundogan/events{/privacy}","received_events_url":"https://api.github.com/users/cgundogan/received_events","type":"User","site_admin":false},"created_at":"2018-02-04T17:14:30Z","updated_at":"2018-02-04T17:14:30Z","author_association":"COLLABORATOR","body":">mkSimpleContent/Interest was already a wrapper around mkContent, which handles result value as parameter, but uses some more parameter. Not handy for riot?\r\n\r\nBut mkSimpleContent/Interest make use of malloc to allocate memory, while the proposed `_scratch()` functions allow for passing a custom memory block – be it dynamically or statically allocated. With the proposed patch, the interface does not break, as all applications can still use the normal mkSimpleContent/Interest function signature (with malloc)"}}
{"actor":{"display_login":"cgundogan"}}