{"action":"closed","number":9152,"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9152","id":220845964,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODQ1OTY0","html_url":"https://github.com/DynamoDS/Dynamo/pull/9152","diff_url":"https://github.com/DynamoDS/Dynamo/pull/9152.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/9152.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9152","number":9152,"state":"closed","locked":false,"title":"remap old style libG names to new folder names","user":{"login":"mjkkirschner","id":508936,"node_id":"MDQ6VXNlcjUwODkzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/508936?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"body":"\r\n### Purpose\r\n\r\n![image](https://user-images.githubusercontent.com/508936/46563985-ab741900-c8d2-11e8-8bd1-8cfba9e9e911.png)\r\n\r\nTo deal with the issue of an old DynamoRevit client calling a new DynamoCore where libG folders have had their names changed to specify precise version - dynamo should attempt to remap the folder name before giving up.\r\n\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [x] The code base is in a better state after this PR\r\n- [x] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [x] The level of testing this PR includes is appropriate\r\n- [ ] User facing strings, if any, are extracted into `*.resx` files\r\n- [ ] All tests pass using the self-service CI.\r\n- [ ] Snapshot of UI changes, if any.\r\n- [x] Changes to the API follow [Semantic Versioning](https://github.com/DynamoDS/Dynamo/wiki/Dynamo-Versions), and are documented in the [API Changes](https://github.com/DynamoDS/Dynamo/wiki/API-Changes) document.\r\n\r\n### Reviewers\r\n\r\n@QilongTang \r\n@alfarok \r\n### FYIs\r\n\r\n@kronz \r\n@smangarole ","created_at":"2018-10-05T23:14:41Z","updated_at":"2018-10-07T13:27:32Z","closed_at":"2018-10-07T13:27:32Z","merged_at":"2018-10-07T13:27:32Z","merge_commit_sha":"f12158acbaad9a90b936cf19b68b23228e69e79e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9152/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9152/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9152/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/2d12499e8718dcbe50d258e3fdeeaa07e60ef8b3","head":{"label":"mjkkirschner:master_libGLoadingOldClient","ref":"master_libGLoadingOldClient","sha":"2d12499e8718dcbe50d258e3fdeeaa07e60ef8b3","user":{"login":"mjkkirschner","id":508936,"node_id":"MDQ6VXNlcjUwODkzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/508936?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"repo":{"id":14159492,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1OTQ5Mg==","name":"Dynamo","full_name":"mjkkirschner/Dynamo","private":false,"owner":{"login":"mjkkirschner","id":508936,"node_id":"MDQ6VXNlcjUwODkzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/508936?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mjkkirschner/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/mjkkirschner/Dynamo","forks_url":"https://api.github.com/repos/mjkkirschner/Dynamo/forks","keys_url":"https://api.github.com/repos/mjkkirschner/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjkkirschner/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjkkirschner/Dynamo/teams","hooks_url":"https://api.github.com/repos/mjkkirschner/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/mjkkirschner/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/mjkkirschner/Dynamo/events","assignees_url":"https://api.github.com/repos/mjkkirschner/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/mjkkirschner/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/mjkkirschner/Dynamo/tags","blobs_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjkkirschner/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/mjkkirschner/Dynamo/languages","stargazers_url":"https://api.github.com/repos/mjkkirschner/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/mjkkirschner/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/mjkkirschner/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/mjkkirschner/Dynamo/subscription","commits_url":"https://api.github.com/repos/mjkkirschner/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjkkirschner/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjkkirschner/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjkkirschner/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/mjkkirschner/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjkkirschner/Dynamo/merges","archive_url":"https://api.github.com/repos/mjkkirschner/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjkkirschner/Dynamo/downloads","issues_url":"https://api.github.com/repos/mjkkirschner/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/mjkkirschner/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/mjkkirschner/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/mjkkirschner/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjkkirschner/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/mjkkirschner/Dynamo/releases{/id}","deployments_url":"https://api.github.com/repos/mjkkirschner/Dynamo/deployments","created_at":"2013-11-06T01:18:42Z","updated_at":"2015-01-20T19:30:58Z","pushed_at":"2018-10-07T13:15:51Z","git_url":"git://github.com/mjkkirschner/Dynamo.git","ssh_url":"git@github.com:mjkkirschner/Dynamo.git","clone_url":"https://github.com/mjkkirschner/Dynamo.git","svn_url":"https://github.com/mjkkirschner/Dynamo","homepage":"http://dynamobim.org","size":1131545,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"385a18f359e95effcb67818b7547ffd0e8a71f40","user":{"login":"DynamoDS","id":6528209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjgyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528209?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"node_id":"MDEwOlJlcG9zaXRvcnkzMzk1MTc5","name":"Dynamo","full_name":"DynamoDS/Dynamo","private":false,"owner":{"login":"DynamoDS","id":6528209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjgyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528209?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DynamoDS/Dynamo","description":"Open Source Graphical Programming for Design","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoDS/Dynamo/deployments","created_at":"2012-02-09T07:35:33Z","updated_at":"2018-10-07T02:43:48Z","pushed_at":"2018-10-07T13:27:32Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":1373998,"stargazers_count":637,"watchers_count":637,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":368,"mirror_url":null,"archived":false,"open_issues_count":563,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":368,"open_issues":563,"watchers":637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9152"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/9152"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9152"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9152/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9152/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9152/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/2d12499e8718dcbe50d258e3fdeeaa07e60ef8b3"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mjkkirschner","id":508936,"node_id":"MDQ6VXNlcjUwODkzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/508936?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"comments":5,"review_comments":7,"maintainer_can_modify":false,"commits":5,"additions":75,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"mjkkirschner"}}