{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/build/issues/1402","repository_url":"https://api.github.com/repos/nodejs/build","labels_url":"https://api.github.com/repos/nodejs/build/issues/1402/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/build/issues/1402/comments","events_url":"https://api.github.com/repos/nodejs/build/issues/1402/events","html_url":"https://github.com/nodejs/build/pull/1402","id":342167945,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTMyMDk3","number":1402,"title":"www: letsencrypt config for dist.libuv.org","user":{"login":"rvagg","id":495647,"node_id":"MDQ6VXNlcjQ5NTY0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/495647?v=4","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-18T03:57:13Z","updated_at":"2018-07-31T22:44:10Z","closed_at":"2018-07-31T22:43:56Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/build/pulls/1402","html_url":"https://github.com/nodejs/build/pull/1402","diff_url":"https://github.com/nodejs/build/pull/1402.diff","patch_url":"https://github.com/nodejs/build/pull/1402.patch"},"body":"Existing `libuv.org` nginx config file isn't accurate for what's on the server at the moment, it looks like we (me probably) forgot to sync the two when we went https a while back. This update fixes that but there is a minor adjustment to what was on the server: port 80 doesn't just do an everything-redirect, there's a fall-through for `/.well-known/` because letsencrypt apparently likes to go straight for port 80 to verify (there may be a way around this but I couldn't find anything other than doing DNS validation). I don't think this is a big deal, we're serving `Strict-Transport-Security` anyway so browsers at least will always just jump to https.\r\n\r\nFor letsencrypt, I've opted to include instructions in doc form rather than ansible, it just gets too complicated, particularly since we have two servers this ansible setup gets applied to but only one needs the Certbot stuff. This is probably something to rectify when (if) we re-do the www ansible scripts.\r\n\r\nSo, https://dist.libuv.org/ is now serving a certificate generated from letsencrypt, its Comodo certificate expires next month so we'll let it go. We have another year on the nodejs.org certificate I think but since we front it with Cloudflare we need to come up with something more creative for that, or possibly just rely on Cloudflare's own issued certificates."},"comment":{"url":"https://api.github.com/repos/nodejs/build/issues/comments/409391908","html_url":"https://github.com/nodejs/build/pull/1402#issuecomment-409391908","issue_url":"https://api.github.com/repos/nodejs/build/issues/1402","id":409391908,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTM5MTkwOA==","user":{"login":"rvagg","id":495647,"node_id":"MDQ6VXNlcjQ5NTY0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/495647?v=4","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T22:44:10Z","updated_at":"2018-07-31T22:44:10Z","author_association":"MEMBER","body":"merged 2cf8811\r\n"}}
{"actor":{"display_login":"rvagg"}}