{"action":"created","comment":{"url":"https://api.github.com/repos/kata-containers/osbuilder/pulls/comments/236159358","pull_request_review_id":178175295,"id":236159358,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjE1OTM1OA==","diff_hunk":"@@ -16,6 +16,7 @@ AGENT_BIN=${AGENT_BIN:-kata-agent}\n AGENT_INIT=${AGENT_INIT:-no}\n KERNEL_MODULES_DIR=${KERNEL_MODULES_DIR:-\"\"}\n OSBUILDER_VERSION=\"unknown\"\n+export GOPATH=${GOPATH:-${PWD}/go}","path":"rootfs-builder/rootfs.sh","position":4,"original_position":4,"commit_id":"2437066f58faa3f389c87d06e43a29d5ae723911","original_commit_id":"2437066f58faa3f389c87d06e43a29d5ae723911","user":{"login":"jodh-intel","id":20315601,"node_id":"MDQ6VXNlcjIwMzE1NjAx","avatar_url":"https://avatars1.githubusercontent.com/u/20315601?v=4","gravatar_id":"","url":"https://api.github.com/users/jodh-intel","html_url":"https://github.com/jodh-intel","followers_url":"https://api.github.com/users/jodh-intel/followers","following_url":"https://api.github.com/users/jodh-intel/following{/other_user}","gists_url":"https://api.github.com/users/jodh-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/jodh-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodh-intel/subscriptions","organizations_url":"https://api.github.com/users/jodh-intel/orgs","repos_url":"https://api.github.com/users/jodh-intel/repos","events_url":"https://api.github.com/users/jodh-intel/events{/privacy}","received_events_url":"https://api.github.com/users/jodh-intel/received_events","type":"User","site_admin":false},"body":"I wonder if this should be `$HOME/go` if `$GOPATH` isn't set? Is `$HOME` guaranteed to be set in a package build environment though I wonder?","created_at":"2018-11-26T08:37:12Z","updated_at":"2018-11-26T08:39:10Z","html_url":"https://github.com/kata-containers/osbuilder/pull/207#discussion_r236159358","pull_request_url":"https://api.github.com/repos/kata-containers/osbuilder/pulls/207","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kata-containers/osbuilder/pulls/comments/236159358"},"html":{"href":"https://github.com/kata-containers/osbuilder/pull/207#discussion_r236159358"},"pull_request":{"href":"https://api.github.com/repos/kata-containers/osbuilder/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/kata-containers/osbuilder/pulls/207","id":233288196,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjg4MTk2","html_url":"https://github.com/kata-containers/osbuilder/pull/207","diff_url":"https://github.com/kata-containers/osbuilder/pull/207.diff","patch_url":"https://github.com/kata-containers/osbuilder/pull/207.patch","issue_url":"https://api.github.com/repos/kata-containers/osbuilder/issues/207","number":207,"state":"open","locked":false,"title":"Add 'install' target to makefile","user":{"login":"jcvenegas","id":20407785,"node_id":"MDQ6VXNlcjIwNDA3Nzg1","avatar_url":"https://avatars3.githubusercontent.com/u/20407785?v=4","gravatar_id":"","url":"https://api.github.com/users/jcvenegas","html_url":"https://github.com/jcvenegas","followers_url":"https://api.github.com/users/jcvenegas/followers","following_url":"https://api.github.com/users/jcvenegas/following{/other_user}","gists_url":"https://api.github.com/users/jcvenegas/gists{/gist_id}","starred_url":"https://api.github.com/users/jcvenegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcvenegas/subscriptions","organizations_url":"https://api.github.com/users/jcvenegas/orgs","repos_url":"https://api.github.com/users/jcvenegas/repos","events_url":"https://api.github.com/users/jcvenegas/events{/privacy}","received_events_url":"https://api.github.com/users/jcvenegas/received_events","type":"User","site_admin":false},"body":"Allow install osbuilder scripts in a host, packages like \r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1590414 may install them in the host.","created_at":"2018-11-23T23:04:12Z","updated_at":"2018-11-26T08:39:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c401de2d200020f3cfff1278780de09c5819f8b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kata-containers/osbuilder/pulls/207/commits","review_comments_url":"https://api.github.com/repos/kata-containers/osbuilder/pulls/207/comments","review_comment_url":"https://api.github.com/repos/kata-containers/osbuilder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kata-containers/osbuilder/issues/207/comments","statuses_url":"https://api.github.com/repos/kata-containers/osbuilder/statuses/2437066f58faa3f389c87d06e43a29d5ae723911","head":{"label":"jcvenegas:install","ref":"install","sha":"2437066f58faa3f389c87d06e43a29d5ae723911","user":{"login":"jcvenegas","id":20407785,"node_id":"MDQ6VXNlcjIwNDA3Nzg1","avatar_url":"https://avatars3.githubusercontent.com/u/20407785?v=4","gravatar_id":"","url":"https://api.github.com/users/jcvenegas","html_url":"https://github.com/jcvenegas","followers_url":"https://api.github.com/users/jcvenegas/followers","following_url":"https://api.github.com/users/jcvenegas/following{/other_user}","gists_url":"https://api.github.com/users/jcvenegas/gists{/gist_id}","starred_url":"https://api.github.com/users/jcvenegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcvenegas/subscriptions","organizations_url":"https://api.github.com/users/jcvenegas/orgs","repos_url":"https://api.github.com/users/jcvenegas/repos","events_url":"https://api.github.com/users/jcvenegas/events{/privacy}","received_events_url":"https://api.github.com/users/jcvenegas/received_events","type":"User","site_admin":false},"repo":{"id":112159621,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIxNTk2MjE=","name":"osbuilder-1","full_name":"jcvenegas/osbuilder-1","private":false,"owner":{"login":"jcvenegas","id":20407785,"node_id":"MDQ6VXNlcjIwNDA3Nzg1","avatar_url":"https://avatars3.githubusercontent.com/u/20407785?v=4","gravatar_id":"","url":"https://api.github.com/users/jcvenegas","html_url":"https://github.com/jcvenegas","followers_url":"https://api.github.com/users/jcvenegas/followers","following_url":"https://api.github.com/users/jcvenegas/following{/other_user}","gists_url":"https://api.github.com/users/jcvenegas/gists{/gist_id}","starred_url":"https://api.github.com/users/jcvenegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcvenegas/subscriptions","organizations_url":"https://api.github.com/users/jcvenegas/orgs","repos_url":"https://api.github.com/users/jcvenegas/repos","events_url":"https://api.github.com/users/jcvenegas/events{/privacy}","received_events_url":"https://api.github.com/users/jcvenegas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jcvenegas/osbuilder-1","description":"Kata containers guest OS building scripts","fork":true,"url":"https://api.github.com/repos/jcvenegas/osbuilder-1","forks_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/forks","keys_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/teams","hooks_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/hooks","issue_events_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/issues/events{/number}","events_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/events","assignees_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/assignees{/user}","branches_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/branches{/branch}","tags_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/tags","blobs_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/statuses/{sha}","languages_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/languages","stargazers_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/stargazers","contributors_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/contributors","subscribers_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/subscribers","subscription_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/subscription","commits_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/contents/{+path}","compare_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/merges","archive_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/downloads","issues_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/issues{/number}","pulls_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/pulls{/number}","milestones_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/milestones{/number}","notifications_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/labels{/name}","releases_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/releases{/id}","deployments_url":"https://api.github.com/repos/jcvenegas/osbuilder-1/deployments","created_at":"2017-11-27T06:56:41Z","updated_at":"2018-06-29T15:35:26Z","pushed_at":"2018-11-26T05:36:07Z","git_url":"git://github.com/jcvenegas/osbuilder-1.git","ssh_url":"git@github.com:jcvenegas/osbuilder-1.git","clone_url":"https://github.com/jcvenegas/osbuilder-1.git","svn_url":"https://github.com/jcvenegas/osbuilder-1","homepage":"","size":255,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kata-containers:master","ref":"master","sha":"39e6aa4094cb1b886dcd1d12b63ae9e9c871a9d1","user":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"repo":{"id":110539619,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1Mzk2MTk=","name":"osbuilder","full_name":"kata-containers/osbuilder","private":false,"owner":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kata-containers/osbuilder","description":"Kata Containers guest OS building scripts","fork":false,"url":"https://api.github.com/repos/kata-containers/osbuilder","forks_url":"https://api.github.com/repos/kata-containers/osbuilder/forks","keys_url":"https://api.github.com/repos/kata-containers/osbuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kata-containers/osbuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kata-containers/osbuilder/teams","hooks_url":"https://api.github.com/repos/kata-containers/osbuilder/hooks","issue_events_url":"https://api.github.com/repos/kata-containers/osbuilder/issues/events{/number}","events_url":"https://api.github.com/repos/kata-containers/osbuilder/events","assignees_url":"https://api.github.com/repos/kata-containers/osbuilder/assignees{/user}","branches_url":"https://api.github.com/repos/kata-containers/osbuilder/branches{/branch}","tags_url":"https://api.github.com/repos/kata-containers/osbuilder/tags","blobs_url":"https://api.github.com/repos/kata-containers/osbuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kata-containers/osbuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kata-containers/osbuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/kata-containers/osbuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kata-containers/osbuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/kata-containers/osbuilder/languages","stargazers_url":"https://api.github.com/repos/kata-containers/osbuilder/stargazers","contributors_url":"https://api.github.com/repos/kata-containers/osbuilder/contributors","subscribers_url":"https://api.github.com/repos/kata-containers/osbuilder/subscribers","subscription_url":"https://api.github.com/repos/kata-containers/osbuilder/subscription","commits_url":"https://api.github.com/repos/kata-containers/osbuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/kata-containers/osbuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/kata-containers/osbuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/kata-containers/osbuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/kata-containers/osbuilder/contents/{+path}","compare_url":"https://api.github.com/repos/kata-containers/osbuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kata-containers/osbuilder/merges","archive_url":"https://api.github.com/repos/kata-containers/osbuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kata-containers/osbuilder/downloads","issues_url":"https://api.github.com/repos/kata-containers/osbuilder/issues{/number}","pulls_url":"https://api.github.com/repos/kata-containers/osbuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/kata-containers/osbuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/kata-containers/osbuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kata-containers/osbuilder/labels{/name}","releases_url":"https://api.github.com/repos/kata-containers/osbuilder/releases{/id}","deployments_url":"https://api.github.com/repos/kata-containers/osbuilder/deployments","created_at":"2017-11-13T11:24:55Z","updated_at":"2018-11-23T01:45:14Z","pushed_at":"2018-11-26T05:36:08Z","git_url":"git://github.com/kata-containers/osbuilder.git","ssh_url":"git@github.com:kata-containers/osbuilder.git","clone_url":"https://github.com/kata-containers/osbuilder.git","svn_url":"https://github.com/kata-containers/osbuilder","homepage":"","size":254,"stargazers_count":39,"watchers_count":39,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":40,"open_issues":25,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kata-containers/osbuilder/pulls/207"},"html":{"href":"https://github.com/kata-containers/osbuilder/pull/207"},"issue":{"href":"https://api.github.com/repos/kata-containers/osbuilder/issues/207"},"comments":{"href":"https://api.github.com/repos/kata-containers/osbuilder/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/kata-containers/osbuilder/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/kata-containers/osbuilder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kata-containers/osbuilder/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/kata-containers/osbuilder/statuses/2437066f58faa3f389c87d06e43a29d5ae723911"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jodh-intel"}}