{"action":"created","comment":{"url":"https://api.github.com/repos/NVIDIA/DALI/pulls/comments/238602073","pull_request_review_id":181180853,"id":238602073,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODYwMjA3Mw==","diff_hunk":"@@ -60,16 +60,16 @@ class DALIGenericIterator(object):\n     ----------\n     pipelines : list of nvidia.dali.pipeline.Pipeline\n                 List of pipelines to use\n-    output_map : list of str\n-                 List of strings (either \"data\" or \"label\") which maps\n-                 the output of DALI pipeline to proper field in MXNet's\n-                 DataBatch\n+    output_map : list of (str, str)\n+                 List of pairs (output_name, tag) which maps consecutive\n+                 outputs of DALI pipelines to proper field in MXNet's\n+                 DataBatch.\n+                 tag is one of DALIGenericIterator.DATA_TAG\n+                 and DALIGenericIterator.LABEL_TAG mapping given output","path":"dali/python/nvidia/dali/plugin/mxnet.py","position":13,"original_position":13,"commit_id":"e8a9cadffd5ee3ddbec00076e2620c6fb759e6db","original_commit_id":"e8a9cadffd5ee3ddbec00076e2620c6fb759e6db","user":{"login":"JanuszL","id":39967756,"node_id":"MDQ6VXNlcjM5OTY3NzU2","avatar_url":"https://avatars1.githubusercontent.com/u/39967756?v=4","gravatar_id":"","url":"https://api.github.com/users/JanuszL","html_url":"https://github.com/JanuszL","followers_url":"https://api.github.com/users/JanuszL/followers","following_url":"https://api.github.com/users/JanuszL/following{/other_user}","gists_url":"https://api.github.com/users/JanuszL/gists{/gist_id}","starred_url":"https://api.github.com/users/JanuszL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanuszL/subscriptions","organizations_url":"https://api.github.com/users/JanuszL/orgs","repos_url":"https://api.github.com/users/JanuszL/repos","events_url":"https://api.github.com/users/JanuszL/events{/privacy}","received_events_url":"https://api.github.com/users/JanuszL/received_events","type":"User","site_admin":false},"body":"Understood.","created_at":"2018-12-04T10:19:24Z","updated_at":"2018-12-04T10:19:24Z","html_url":"https://github.com/NVIDIA/DALI/pull/282#discussion_r238602073","pull_request_url":"https://api.github.com/repos/NVIDIA/DALI/pulls/282","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/comments/238602073"},"html":{"href":"https://github.com/NVIDIA/DALI/pull/282#discussion_r238602073"},"pull_request":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/282"}},"in_reply_to_id":238584102},"pull_request":{"url":"https://api.github.com/repos/NVIDIA/DALI/pulls/282","id":229862328,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODYyMzI4","html_url":"https://github.com/NVIDIA/DALI/pull/282","diff_url":"https://github.com/NVIDIA/DALI/pull/282.diff","patch_url":"https://github.com/NVIDIA/DALI/pull/282.patch","issue_url":"https://api.github.com/repos/NVIDIA/DALI/issues/282","number":282,"state":"open","locked":false,"title":"[WIP] Pytorch wrapper - use dictionary of categories","user":{"login":"klecki","id":8121971,"node_id":"MDQ6VXNlcjgxMjE5NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/8121971?v=4","gravatar_id":"","url":"https://api.github.com/users/klecki","html_url":"https://github.com/klecki","followers_url":"https://api.github.com/users/klecki/followers","following_url":"https://api.github.com/users/klecki/following{/other_user}","gists_url":"https://api.github.com/users/klecki/gists{/gist_id}","starred_url":"https://api.github.com/users/klecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klecki/subscriptions","organizations_url":"https://api.github.com/users/klecki/orgs","repos_url":"https://api.github.com/users/klecki/repos","events_url":"https://api.github.com/users/klecki/events{/privacy}","received_events_url":"https://api.github.com/users/klecki/received_events","type":"User","site_admin":false},"body":"Split from #240.\r\nInstead of using fixed \"data\" and \"labels\" we use\r\ndictionary of categories, allowing for user to divide outputs\r\ninto more groups\r\n\r\nThis breaks the return type of pytorch iterator. It is more generic, instead of tuples it will return dict. It should probably be adjusted in some way, or the examples should be adjusted to this change. ","created_at":"2018-11-10T01:53:39Z","updated_at":"2018-12-04T10:19:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0a02418eaa91c25bb059c14f0b261c5f46a5c72","assignee":null,"assignees":[],"requested_reviewers":[{"login":"szalpal","id":7101064,"node_id":"MDQ6VXNlcjcxMDEwNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7101064?v=4","gravatar_id":"","url":"https://api.github.com/users/szalpal","html_url":"https://github.com/szalpal","followers_url":"https://api.github.com/users/szalpal/followers","following_url":"https://api.github.com/users/szalpal/following{/other_user}","gists_url":"https://api.github.com/users/szalpal/gists{/gist_id}","starred_url":"https://api.github.com/users/szalpal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szalpal/subscriptions","organizations_url":"https://api.github.com/users/szalpal/orgs","repos_url":"https://api.github.com/users/szalpal/repos","events_url":"https://api.github.com/users/szalpal/events{/privacy}","received_events_url":"https://api.github.com/users/szalpal/received_events","type":"User","site_admin":false},{"login":"ptrendx","id":8398980,"node_id":"MDQ6VXNlcjgzOTg5ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/8398980?v=4","gravatar_id":"","url":"https://api.github.com/users/ptrendx","html_url":"https://github.com/ptrendx","followers_url":"https://api.github.com/users/ptrendx/followers","following_url":"https://api.github.com/users/ptrendx/following{/other_user}","gists_url":"https://api.github.com/users/ptrendx/gists{/gist_id}","starred_url":"https://api.github.com/users/ptrendx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptrendx/subscriptions","organizations_url":"https://api.github.com/users/ptrendx/orgs","repos_url":"https://api.github.com/users/ptrendx/repos","events_url":"https://api.github.com/users/ptrendx/events{/privacy}","received_events_url":"https://api.github.com/users/ptrendx/received_events","type":"User","site_admin":false},{"login":"pribalta","id":35964727,"node_id":"MDQ6VXNlcjM1OTY0NzI3","avatar_url":"https://avatars1.githubusercontent.com/u/35964727?v=4","gravatar_id":"","url":"https://api.github.com/users/pribalta","html_url":"https://github.com/pribalta","followers_url":"https://api.github.com/users/pribalta/followers","following_url":"https://api.github.com/users/pribalta/following{/other_user}","gists_url":"https://api.github.com/users/pribalta/gists{/gist_id}","starred_url":"https://api.github.com/users/pribalta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pribalta/subscriptions","organizations_url":"https://api.github.com/users/pribalta/orgs","repos_url":"https://api.github.com/users/pribalta/repos","events_url":"https://api.github.com/users/pribalta/events{/privacy}","received_events_url":"https://api.github.com/users/pribalta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NVIDIA/DALI/pulls/282/commits","review_comments_url":"https://api.github.com/repos/NVIDIA/DALI/pulls/282/comments","review_comment_url":"https://api.github.com/repos/NVIDIA/DALI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NVIDIA/DALI/issues/282/comments","statuses_url":"https://api.github.com/repos/NVIDIA/DALI/statuses/e8a9cadffd5ee3ddbec00076e2620c6fb759e6db","head":{"label":"klecki:pytorch-plugin","ref":"pytorch-plugin","sha":"e8a9cadffd5ee3ddbec00076e2620c6fb759e6db","user":{"login":"klecki","id":8121971,"node_id":"MDQ6VXNlcjgxMjE5NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/8121971?v=4","gravatar_id":"","url":"https://api.github.com/users/klecki","html_url":"https://github.com/klecki","followers_url":"https://api.github.com/users/klecki/followers","following_url":"https://api.github.com/users/klecki/following{/other_user}","gists_url":"https://api.github.com/users/klecki/gists{/gist_id}","starred_url":"https://api.github.com/users/klecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klecki/subscriptions","organizations_url":"https://api.github.com/users/klecki/orgs","repos_url":"https://api.github.com/users/klecki/repos","events_url":"https://api.github.com/users/klecki/events{/privacy}","received_events_url":"https://api.github.com/users/klecki/received_events","type":"User","site_admin":false},"repo":{"id":147820750,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4MjA3NTA=","name":"DALI","full_name":"klecki/DALI","private":false,"owner":{"login":"klecki","id":8121971,"node_id":"MDQ6VXNlcjgxMjE5NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/8121971?v=4","gravatar_id":"","url":"https://api.github.com/users/klecki","html_url":"https://github.com/klecki","followers_url":"https://api.github.com/users/klecki/followers","following_url":"https://api.github.com/users/klecki/following{/other_user}","gists_url":"https://api.github.com/users/klecki/gists{/gist_id}","starred_url":"https://api.github.com/users/klecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klecki/subscriptions","organizations_url":"https://api.github.com/users/klecki/orgs","repos_url":"https://api.github.com/users/klecki/repos","events_url":"https://api.github.com/users/klecki/events{/privacy}","received_events_url":"https://api.github.com/users/klecki/received_events","type":"User","site_admin":false},"html_url":"https://github.com/klecki/DALI","description":"A library containing both highly optimized building blocks and an execution engine for data pre-processing in deep learning applications","fork":true,"url":"https://api.github.com/repos/klecki/DALI","forks_url":"https://api.github.com/repos/klecki/DALI/forks","keys_url":"https://api.github.com/repos/klecki/DALI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klecki/DALI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klecki/DALI/teams","hooks_url":"https://api.github.com/repos/klecki/DALI/hooks","issue_events_url":"https://api.github.com/repos/klecki/DALI/issues/events{/number}","events_url":"https://api.github.com/repos/klecki/DALI/events","assignees_url":"https://api.github.com/repos/klecki/DALI/assignees{/user}","branches_url":"https://api.github.com/repos/klecki/DALI/branches{/branch}","tags_url":"https://api.github.com/repos/klecki/DALI/tags","blobs_url":"https://api.github.com/repos/klecki/DALI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klecki/DALI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klecki/DALI/git/refs{/sha}","trees_url":"https://api.github.com/repos/klecki/DALI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klecki/DALI/statuses/{sha}","languages_url":"https://api.github.com/repos/klecki/DALI/languages","stargazers_url":"https://api.github.com/repos/klecki/DALI/stargazers","contributors_url":"https://api.github.com/repos/klecki/DALI/contributors","subscribers_url":"https://api.github.com/repos/klecki/DALI/subscribers","subscription_url":"https://api.github.com/repos/klecki/DALI/subscription","commits_url":"https://api.github.com/repos/klecki/DALI/commits{/sha}","git_commits_url":"https://api.github.com/repos/klecki/DALI/git/commits{/sha}","comments_url":"https://api.github.com/repos/klecki/DALI/comments{/number}","issue_comment_url":"https://api.github.com/repos/klecki/DALI/issues/comments{/number}","contents_url":"https://api.github.com/repos/klecki/DALI/contents/{+path}","compare_url":"https://api.github.com/repos/klecki/DALI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klecki/DALI/merges","archive_url":"https://api.github.com/repos/klecki/DALI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klecki/DALI/downloads","issues_url":"https://api.github.com/repos/klecki/DALI/issues{/number}","pulls_url":"https://api.github.com/repos/klecki/DALI/pulls{/number}","milestones_url":"https://api.github.com/repos/klecki/DALI/milestones{/number}","notifications_url":"https://api.github.com/repos/klecki/DALI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klecki/DALI/labels{/name}","releases_url":"https://api.github.com/repos/klecki/DALI/releases{/id}","deployments_url":"https://api.github.com/repos/klecki/DALI/deployments","created_at":"2018-09-07T12:32:48Z","updated_at":"2018-09-24T11:52:17Z","pushed_at":"2018-12-03T17:54:39Z","git_url":"git://github.com/klecki/DALI.git","ssh_url":"git@github.com:klecki/DALI.git","clone_url":"https://github.com/klecki/DALI.git","svn_url":"https://github.com/klecki/DALI","homepage":"https://docs.nvidia.com/deeplearning/sdk/dali-developer-guide/index.html","size":40921,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"NVIDIA:master","ref":"master","sha":"bd2fbc15094fa47f7833058299829d1078aab938","user":{"login":"NVIDIA","id":1728152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjgxNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1728152?v=4","gravatar_id":"","url":"https://api.github.com/users/NVIDIA","html_url":"https://github.com/NVIDIA","followers_url":"https://api.github.com/users/NVIDIA/followers","following_url":"https://api.github.com/users/NVIDIA/following{/other_user}","gists_url":"https://api.github.com/users/NVIDIA/gists{/gist_id}","starred_url":"https://api.github.com/users/NVIDIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NVIDIA/subscriptions","organizations_url":"https://api.github.com/users/NVIDIA/orgs","repos_url":"https://api.github.com/users/NVIDIA/repos","events_url":"https://api.github.com/users/NVIDIA/events{/privacy}","received_events_url":"https://api.github.com/users/NVIDIA/received_events","type":"Organization","site_admin":false},"repo":{"id":135768037,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3NjgwMzc=","name":"DALI","full_name":"NVIDIA/DALI","private":false,"owner":{"login":"NVIDIA","id":1728152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjgxNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1728152?v=4","gravatar_id":"","url":"https://api.github.com/users/NVIDIA","html_url":"https://github.com/NVIDIA","followers_url":"https://api.github.com/users/NVIDIA/followers","following_url":"https://api.github.com/users/NVIDIA/following{/other_user}","gists_url":"https://api.github.com/users/NVIDIA/gists{/gist_id}","starred_url":"https://api.github.com/users/NVIDIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NVIDIA/subscriptions","organizations_url":"https://api.github.com/users/NVIDIA/orgs","repos_url":"https://api.github.com/users/NVIDIA/repos","events_url":"https://api.github.com/users/NVIDIA/events{/privacy}","received_events_url":"https://api.github.com/users/NVIDIA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NVIDIA/DALI","description":"A library containing both highly optimized building blocks and an execution engine for data pre-processing in deep learning applications","fork":false,"url":"https://api.github.com/repos/NVIDIA/DALI","forks_url":"https://api.github.com/repos/NVIDIA/DALI/forks","keys_url":"https://api.github.com/repos/NVIDIA/DALI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NVIDIA/DALI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NVIDIA/DALI/teams","hooks_url":"https://api.github.com/repos/NVIDIA/DALI/hooks","issue_events_url":"https://api.github.com/repos/NVIDIA/DALI/issues/events{/number}","events_url":"https://api.github.com/repos/NVIDIA/DALI/events","assignees_url":"https://api.github.com/repos/NVIDIA/DALI/assignees{/user}","branches_url":"https://api.github.com/repos/NVIDIA/DALI/branches{/branch}","tags_url":"https://api.github.com/repos/NVIDIA/DALI/tags","blobs_url":"https://api.github.com/repos/NVIDIA/DALI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NVIDIA/DALI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NVIDIA/DALI/git/refs{/sha}","trees_url":"https://api.github.com/repos/NVIDIA/DALI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NVIDIA/DALI/statuses/{sha}","languages_url":"https://api.github.com/repos/NVIDIA/DALI/languages","stargazers_url":"https://api.github.com/repos/NVIDIA/DALI/stargazers","contributors_url":"https://api.github.com/repos/NVIDIA/DALI/contributors","subscribers_url":"https://api.github.com/repos/NVIDIA/DALI/subscribers","subscription_url":"https://api.github.com/repos/NVIDIA/DALI/subscription","commits_url":"https://api.github.com/repos/NVIDIA/DALI/commits{/sha}","git_commits_url":"https://api.github.com/repos/NVIDIA/DALI/git/commits{/sha}","comments_url":"https://api.github.com/repos/NVIDIA/DALI/comments{/number}","issue_comment_url":"https://api.github.com/repos/NVIDIA/DALI/issues/comments{/number}","contents_url":"https://api.github.com/repos/NVIDIA/DALI/contents/{+path}","compare_url":"https://api.github.com/repos/NVIDIA/DALI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NVIDIA/DALI/merges","archive_url":"https://api.github.com/repos/NVIDIA/DALI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NVIDIA/DALI/downloads","issues_url":"https://api.github.com/repos/NVIDIA/DALI/issues{/number}","pulls_url":"https://api.github.com/repos/NVIDIA/DALI/pulls{/number}","milestones_url":"https://api.github.com/repos/NVIDIA/DALI/milestones{/number}","notifications_url":"https://api.github.com/repos/NVIDIA/DALI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NVIDIA/DALI/labels{/name}","releases_url":"https://api.github.com/repos/NVIDIA/DALI/releases{/id}","deployments_url":"https://api.github.com/repos/NVIDIA/DALI/deployments","created_at":"2018-06-01T22:18:01Z","updated_at":"2018-12-04T08:06:15Z","pushed_at":"2018-12-04T10:12:14Z","git_url":"git://github.com/NVIDIA/DALI.git","ssh_url":"git@github.com:NVIDIA/DALI.git","clone_url":"https://github.com/NVIDIA/DALI.git","svn_url":"https://github.com/NVIDIA/DALI","homepage":"https://docs.nvidia.com/deeplearning/sdk/dali-developer-guide/index.html","size":40949,"stargazers_count":844,"watchers_count":844,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":93,"open_issues":45,"watchers":844,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/282"},"html":{"href":"https://github.com/NVIDIA/DALI/pull/282"},"issue":{"href":"https://api.github.com/repos/NVIDIA/DALI/issues/282"},"comments":{"href":"https://api.github.com/repos/NVIDIA/DALI/issues/282/comments"},"review_comments":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/282/comments"},"review_comment":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/282/commits"},"statuses":{"href":"https://api.github.com/repos/NVIDIA/DALI/statuses/e8a9cadffd5ee3ddbec00076e2620c6fb759e6db"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JanuszL"}}