{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/designer/issues/214","repository_url":"https://api.github.com/repos/vaadin/designer","labels_url":"https://api.github.com/repos/vaadin/designer/issues/214/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/designer/issues/214/comments","events_url":"https://api.github.com/repos/vaadin/designer/issues/214/events","html_url":"https://github.com/vaadin/designer/issues/214","id":186503993,"number":214,"title":"Renaming design does not perform Java refactoring on extended Java class","user":{"login":"vaadin-bot","id":20280877,"avatar_url":"https://avatars1.githubusercontent.com/u/20280877?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin-bot","html_url":"https://github.com/vaadin-bot","followers_url":"https://api.github.com/users/vaadin-bot/followers","following_url":"https://api.github.com/users/vaadin-bot/following{/other_user}","gists_url":"https://api.github.com/users/vaadin-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin-bot/subscriptions","organizations_url":"https://api.github.com/users/vaadin-bot/orgs","repos_url":"https://api.github.com/users/vaadin-bot/repos","events_url":"https://api.github.com/users/vaadin-bot/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin-bot/received_events","type":"User","site_admin":false},"labels":[{"id":497643912,"url":"https://api.github.com/repos/vaadin/designer/labels/designfiles","name":"designfiles","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2015-04-06T11:37:11Z","updated_at":"2018-03-26T16:04:53Z","closed_at":null,"author_association":"NONE","body":"**Originally by @denis-anisimov**\n\n___\nRemove \"Rename\" action for Design HTML file and create Refactoring popup menu with Rename inside it.\n\n\"Rename\" currently tries behave as refactoring \"Rename\" but it works only when everything is correct.\n\nThis has been discussed in details, but it has to be fixed at some point.\n\nProblem : \"Rename\" is plain rename action for HTML and it invokes internally Java rename refactoring. There are a number of issues:\n- Rename allows to change file name along with extension. Should only allow to change file name without extension.\n- Refactoring is done after HTML file rename. But refactoring preconditions have to be checked BEFORE any action (before HTML rename). It's not possible to implement with current approach.\n- As a result of previous item: at the moment there is a bug.\nSteps to reproduce:\n- Create new Design .\n- Create new Java class.\n- Extend latter class from Design Java class.\n- Introduce compilation errors in your Java class.\n- Rename Design.\nResult: there will be error dialog (result of refactoring). BUT : HTML file is renamed, old Java file is not renamed. New Java file is created and it's empty.\nSo it's again the same issue as it was without Java refactoring.\n\nWhat it should do: it should show Refactoring rename dialog (with number of options). If refactoring is confirmed: it should checks preconditions, start refactoring only if everything is fine. Rename HTML, refactor Java. In case of errors it should roll back all changes along with HTML file rename.\n\n___\n Imported from https://dev.vaadin.com/ issue #17393"},"comment":{"url":"https://api.github.com/repos/vaadin/designer/issues/comments/376219885","html_url":"https://github.com/vaadin/designer/issues/214#issuecomment-376219885","issue_url":"https://api.github.com/repos/vaadin/designer/issues/214","id":376219885,"user":{"login":"stale[bot]","id":26384082,"avatar_url":"https://avatars3.githubusercontent.com/in/1724?v=4","gravatar_id":"","url":"https://api.github.com/users/stale%5Bbot%5D","html_url":"https://github.com/apps/stale","followers_url":"https://api.github.com/users/stale%5Bbot%5D/followers","following_url":"https://api.github.com/users/stale%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/stale%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/stale%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stale%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/stale%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/stale%5Bbot%5D/repos","events_url":"https://api.github.com/users/stale%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/stale%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-03-26T16:04:53Z","updated_at":"2018-03-26T16:04:53Z","author_association":"NONE","body":"Hello there!\n\nIt looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.\n\nThere are a few things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):\n\n * Check if the issue is still valid for the latest version. There are many duplicates in our issue tracker, so it is possible that the issue is already tackled.\n * Provide more details how to reproduce the issue.\n * Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.\n * Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.\n * If the issue is clearly a bug, use the [Warranty](https://vaadin.com/pricing) in your Vaadin subscription to raise its priority.\n\nThanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!\n"}}
{"actor":{"display_login":"stale"}}