{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/112","repository_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack","labels_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/112/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/112/comments","events_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/112/events","html_url":"https://github.com/kubernetes/cloud-provider-openstack/pull/112","id":313328727,"number":112,"title":"Squash unnecessary ERROR prefixes in logs","user":{"login":"dims","id":23304,"avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"labels":[{"id":875191555,"url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":875191482,"url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-11T13:39:51Z","updated_at":"2018-04-11T13:55:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/pulls/112","html_url":"https://github.com/kubernetes/cloud-provider-openstack/pull/112","diff_url":"https://github.com/kubernetes/cloud-provider-openstack/pull/112.diff","patch_url":"https://github.com/kubernetes/cloud-provider-openstack/pull/112.patch"},"body":"we were getting some bad prefixes to actual logging because of the way flags are setup. just squash them. \r\n\r\n```\r\nERROR: logging before flag.Parse: W0411 08:27:21.065165   52319 client_config.go:533] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.\r\nERROR: logging before flag.Parse: W0411 08:27:21.065296   52319 client_config.go:538] error creating inClusterConfig, falling back to default config: unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PO\r\n```"},"comment":{"url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/comments/380460494","html_url":"https://github.com/kubernetes/cloud-provider-openstack/pull/112#issuecomment-380460494","issue_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/112","id":380460494,"user":{"login":"gonzolino","id":3019505,"avatar_url":"https://avatars1.githubusercontent.com/u/3019505?v=4","gravatar_id":"","url":"https://api.github.com/users/gonzolino","html_url":"https://github.com/gonzolino","followers_url":"https://api.github.com/users/gonzolino/followers","following_url":"https://api.github.com/users/gonzolino/following{/other_user}","gists_url":"https://api.github.com/users/gonzolino/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzolino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzolino/subscriptions","organizations_url":"https://api.github.com/users/gonzolino/orgs","repos_url":"https://api.github.com/users/gonzolino/repos","events_url":"https://api.github.com/users/gonzolino/events{/privacy}","received_events_url":"https://api.github.com/users/gonzolino/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T13:55:09Z","updated_at":"2018-04-11T13:55:09Z","author_association":"CONTRIBUTOR","body":"The change looks fine to me.\r\n\r\nBut just out of curiosity: Wouldn't it also be possible to move the flag parsing to the start of the `main` function and then load the client config afterwards to ensure that `flags.Parse` is called before any logging happens?"}}
{"actor":{"display_login":"gonzolino"}}