{"action":"created","comment":{"url":"https://api.github.com/repos/reumo/git-cata-score/pulls/comments/193673465","pull_request_review_id":126689999,"id":193673465,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzY3MzQ2NQ==","diff_hunk":"@@ -10,21 +10,45 @@\n     final static int N_CHAR = 6;\n \n     @Test\n-    public void generateSixCharacterKey() {\n+    public void generateSixCharacterKey() throws Exception{\n         KeyGenerator keyGenerator = new KeyGeneratorImpl();\n         assertEquals(N_CHAR, keyGenerator.generateKey().length());\n     }\n \n     @Test\n-    public void generateUppercaseKey() {\n+    public void generateUppercaseKey() throws Exception{\n         KeyGenerator keyGenerator = new KeyGeneratorImpl();\n-        String key = keyGenerator.generateKey();\n+        String key = null;\n+        key = keyGenerator.generateKey();\n         assertEquals(key.toUpperCase(),key);\n     }\n \n     @Test\n-    public void  generateUniqueKey() {\n+    public void  generateUniqueKey() throws Exception{\n         KeyGenerator keyGenerator = new KeyGeneratorImpl();\n         assertNotEquals(keyGenerator.generateKey(),keyGenerator.generateKey());\n     }\n+\n+    @Test\n+    public void changeNextLetter() throws Exception{\n+        KeyGenerator keyGenerator = new KeyGeneratorImpl();\n+            String key;\n+        do{\n+                key = keyGenerator.generateKey();\n+        }while (key.charAt(key.length() -1) != 'Z');\n+\n+        key = keyGenerator.generateKey();\n+        assertEquals('A', key.charAt(key.length() -1));\n+        assertEquals('B', key.charAt(key.length() -2));\n+    }","path":"src/test/java/catascore/KeyGeneratorImplTest.java","position":43,"original_position":38,"commit_id":"b16b05ef76552800117bfb63f4e443fed90fe198","original_commit_id":"b16b05ef76552800117bfb63f4e443fed90fe198","user":{"login":"florlp","id":28428570,"node_id":"MDQ6VXNlcjI4NDI4NTcw","avatar_url":"https://avatars0.githubusercontent.com/u/28428570?v=4","gravatar_id":"","url":"https://api.github.com/users/florlp","html_url":"https://github.com/florlp","followers_url":"https://api.github.com/users/florlp/followers","following_url":"https://api.github.com/users/florlp/following{/other_user}","gists_url":"https://api.github.com/users/florlp/gists{/gist_id}","starred_url":"https://api.github.com/users/florlp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florlp/subscriptions","organizations_url":"https://api.github.com/users/florlp/orgs","repos_url":"https://api.github.com/users/florlp/repos","events_url":"https://api.github.com/users/florlp/events{/privacy}","received_events_url":"https://api.github.com/users/florlp/received_events","type":"User","site_admin":false},"body":"I think we could make a private method that receives two indexes, one from the beginning and one from the end to complete it with Z and then we could try the last case.","created_at":"2018-06-07T08:57:26Z","updated_at":"2018-06-07T08:57:26Z","html_url":"https://github.com/reumo/git-cata-score/pull/1#discussion_r193673465","pull_request_url":"https://api.github.com/repos/reumo/git-cata-score/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/reumo/git-cata-score/pulls/comments/193673465"},"html":{"href":"https://github.com/reumo/git-cata-score/pull/1#discussion_r193673465"},"pull_request":{"href":"https://api.github.com/repos/reumo/git-cata-score/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/reumo/git-cata-score/pulls/1","id":193045220,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMDQ1MjIw","html_url":"https://github.com/reumo/git-cata-score/pull/1","diff_url":"https://github.com/reumo/git-cata-score/pull/1.diff","patch_url":"https://github.com/reumo/git-cata-score/pull/1.patch","issue_url":"https://api.github.com/repos/reumo/git-cata-score/issues/1","number":1,"state":"open","locked":false,"title":"Feature/key generator","user":{"login":"reumo","id":4179474,"node_id":"MDQ6VXNlcjQxNzk0NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4179474?v=4","gravatar_id":"","url":"https://api.github.com/users/reumo","html_url":"https://github.com/reumo","followers_url":"https://api.github.com/users/reumo/followers","following_url":"https://api.github.com/users/reumo/following{/other_user}","gists_url":"https://api.github.com/users/reumo/gists{/gist_id}","starred_url":"https://api.github.com/users/reumo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reumo/subscriptions","organizations_url":"https://api.github.com/users/reumo/orgs","repos_url":"https://api.github.com/users/reumo/repos","events_url":"https://api.github.com/users/reumo/events{/privacy}","received_events_url":"https://api.github.com/users/reumo/received_events","type":"User","site_admin":false},"body":"First pull request","created_at":"2018-06-06T15:04:24Z","updated_at":"2018-06-07T08:57:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b58684d2dac6661b9a98d73f24607dc49ea0dd21","assignee":null,"assignees":[],"requested_reviewers":[{"login":"AndreuCalvo","id":16287637,"node_id":"MDQ6VXNlcjE2Mjg3NjM3","avatar_url":"https://avatars0.githubusercontent.com/u/16287637?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreuCalvo","html_url":"https://github.com/AndreuCalvo","followers_url":"https://api.github.com/users/AndreuCalvo/followers","following_url":"https://api.github.com/users/AndreuCalvo/following{/other_user}","gists_url":"https://api.github.com/users/AndreuCalvo/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreuCalvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreuCalvo/subscriptions","organizations_url":"https://api.github.com/users/AndreuCalvo/orgs","repos_url":"https://api.github.com/users/AndreuCalvo/repos","events_url":"https://api.github.com/users/AndreuCalvo/events{/privacy}","received_events_url":"https://api.github.com/users/AndreuCalvo/received_events","type":"User","site_admin":false},{"login":"hbachsiv","id":39990992,"node_id":"MDQ6VXNlcjM5OTkwOTky","avatar_url":"https://avatars3.githubusercontent.com/u/39990992?v=4","gravatar_id":"","url":"https://api.github.com/users/hbachsiv","html_url":"https://github.com/hbachsiv","followers_url":"https://api.github.com/users/hbachsiv/followers","following_url":"https://api.github.com/users/hbachsiv/following{/other_user}","gists_url":"https://api.github.com/users/hbachsiv/gists{/gist_id}","starred_url":"https://api.github.com/users/hbachsiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbachsiv/subscriptions","organizations_url":"https://api.github.com/users/hbachsiv/orgs","repos_url":"https://api.github.com/users/hbachsiv/repos","events_url":"https://api.github.com/users/hbachsiv/events{/privacy}","received_events_url":"https://api.github.com/users/hbachsiv/received_events","type":"User","site_admin":false},{"login":"lnavarrom","id":39991050,"node_id":"MDQ6VXNlcjM5OTkxMDUw","avatar_url":"https://avatars1.githubusercontent.com/u/39991050?v=4","gravatar_id":"","url":"https://api.github.com/users/lnavarrom","html_url":"https://github.com/lnavarrom","followers_url":"https://api.github.com/users/lnavarrom/followers","following_url":"https://api.github.com/users/lnavarrom/following{/other_user}","gists_url":"https://api.github.com/users/lnavarrom/gists{/gist_id}","starred_url":"https://api.github.com/users/lnavarrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnavarrom/subscriptions","organizations_url":"https://api.github.com/users/lnavarrom/orgs","repos_url":"https://api.github.com/users/lnavarrom/repos","events_url":"https://api.github.com/users/lnavarrom/events{/privacy}","received_events_url":"https://api.github.com/users/lnavarrom/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reumo/git-cata-score/pulls/1/commits","review_comments_url":"https://api.github.com/repos/reumo/git-cata-score/pulls/1/comments","review_comment_url":"https://api.github.com/repos/reumo/git-cata-score/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reumo/git-cata-score/issues/1/comments","statuses_url":"https://api.github.com/repos/reumo/git-cata-score/statuses/b16b05ef76552800117bfb63f4e443fed90fe198","head":{"label":"reumo:feature/key-generator","ref":"feature/key-generator","sha":"b16b05ef76552800117bfb63f4e443fed90fe198","user":{"login":"reumo","id":4179474,"node_id":"MDQ6VXNlcjQxNzk0NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4179474?v=4","gravatar_id":"","url":"https://api.github.com/users/reumo","html_url":"https://github.com/reumo","followers_url":"https://api.github.com/users/reumo/followers","following_url":"https://api.github.com/users/reumo/following{/other_user}","gists_url":"https://api.github.com/users/reumo/gists{/gist_id}","starred_url":"https://api.github.com/users/reumo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reumo/subscriptions","organizations_url":"https://api.github.com/users/reumo/orgs","repos_url":"https://api.github.com/users/reumo/repos","events_url":"https://api.github.com/users/reumo/events{/privacy}","received_events_url":"https://api.github.com/users/reumo/received_events","type":"User","site_admin":false},"repo":{"id":136315327,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzMTUzMjc=","name":"git-cata-score","full_name":"reumo/git-cata-score","owner":{"login":"reumo","id":4179474,"node_id":"MDQ6VXNlcjQxNzk0NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4179474?v=4","gravatar_id":"","url":"https://api.github.com/users/reumo","html_url":"https://github.com/reumo","followers_url":"https://api.github.com/users/reumo/followers","following_url":"https://api.github.com/users/reumo/following{/other_user}","gists_url":"https://api.github.com/users/reumo/gists{/gist_id}","starred_url":"https://api.github.com/users/reumo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reumo/subscriptions","organizations_url":"https://api.github.com/users/reumo/orgs","repos_url":"https://api.github.com/users/reumo/repos","events_url":"https://api.github.com/users/reumo/events{/privacy}","received_events_url":"https://api.github.com/users/reumo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reumo/git-cata-score","description":"Cata","fork":false,"url":"https://api.github.com/repos/reumo/git-cata-score","forks_url":"https://api.github.com/repos/reumo/git-cata-score/forks","keys_url":"https://api.github.com/repos/reumo/git-cata-score/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reumo/git-cata-score/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reumo/git-cata-score/teams","hooks_url":"https://api.github.com/repos/reumo/git-cata-score/hooks","issue_events_url":"https://api.github.com/repos/reumo/git-cata-score/issues/events{/number}","events_url":"https://api.github.com/repos/reumo/git-cata-score/events","assignees_url":"https://api.github.com/repos/reumo/git-cata-score/assignees{/user}","branches_url":"https://api.github.com/repos/reumo/git-cata-score/branches{/branch}","tags_url":"https://api.github.com/repos/reumo/git-cata-score/tags","blobs_url":"https://api.github.com/repos/reumo/git-cata-score/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reumo/git-cata-score/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reumo/git-cata-score/git/refs{/sha}","trees_url":"https://api.github.com/repos/reumo/git-cata-score/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reumo/git-cata-score/statuses/{sha}","languages_url":"https://api.github.com/repos/reumo/git-cata-score/languages","stargazers_url":"https://api.github.com/repos/reumo/git-cata-score/stargazers","contributors_url":"https://api.github.com/repos/reumo/git-cata-score/contributors","subscribers_url":"https://api.github.com/repos/reumo/git-cata-score/subscribers","subscription_url":"https://api.github.com/repos/reumo/git-cata-score/subscription","commits_url":"https://api.github.com/repos/reumo/git-cata-score/commits{/sha}","git_commits_url":"https://api.github.com/repos/reumo/git-cata-score/git/commits{/sha}","comments_url":"https://api.github.com/repos/reumo/git-cata-score/comments{/number}","issue_comment_url":"https://api.github.com/repos/reumo/git-cata-score/issues/comments{/number}","contents_url":"https://api.github.com/repos/reumo/git-cata-score/contents/{+path}","compare_url":"https://api.github.com/repos/reumo/git-cata-score/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reumo/git-cata-score/merges","archive_url":"https://api.github.com/repos/reumo/git-cata-score/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reumo/git-cata-score/downloads","issues_url":"https://api.github.com/repos/reumo/git-cata-score/issues{/number}","pulls_url":"https://api.github.com/repos/reumo/git-cata-score/pulls{/number}","milestones_url":"https://api.github.com/repos/reumo/git-cata-score/milestones{/number}","notifications_url":"https://api.github.com/repos/reumo/git-cata-score/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reumo/git-cata-score/labels{/name}","releases_url":"https://api.github.com/repos/reumo/git-cata-score/releases{/id}","deployments_url":"https://api.github.com/repos/reumo/git-cata-score/deployments","created_at":"2018-06-06T10:52:40Z","updated_at":"2018-06-06T11:28:51Z","pushed_at":"2018-06-06T15:04:25Z","git_url":"git://github.com/reumo/git-cata-score.git","ssh_url":"git@github.com:reumo/git-cata-score.git","clone_url":"https://github.com/reumo/git-cata-score.git","svn_url":"https://github.com/reumo/git-cata-score","homepage":null,"size":19,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"reumo:whip","ref":"whip","sha":"d88267fea1299f3e07bc24bb1db8f55096111347","user":{"login":"reumo","id":4179474,"node_id":"MDQ6VXNlcjQxNzk0NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4179474?v=4","gravatar_id":"","url":"https://api.github.com/users/reumo","html_url":"https://github.com/reumo","followers_url":"https://api.github.com/users/reumo/followers","following_url":"https://api.github.com/users/reumo/following{/other_user}","gists_url":"https://api.github.com/users/reumo/gists{/gist_id}","starred_url":"https://api.github.com/users/reumo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reumo/subscriptions","organizations_url":"https://api.github.com/users/reumo/orgs","repos_url":"https://api.github.com/users/reumo/repos","events_url":"https://api.github.com/users/reumo/events{/privacy}","received_events_url":"https://api.github.com/users/reumo/received_events","type":"User","site_admin":false},"repo":{"id":136315327,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzMTUzMjc=","name":"git-cata-score","full_name":"reumo/git-cata-score","owner":{"login":"reumo","id":4179474,"node_id":"MDQ6VXNlcjQxNzk0NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4179474?v=4","gravatar_id":"","url":"https://api.github.com/users/reumo","html_url":"https://github.com/reumo","followers_url":"https://api.github.com/users/reumo/followers","following_url":"https://api.github.com/users/reumo/following{/other_user}","gists_url":"https://api.github.com/users/reumo/gists{/gist_id}","starred_url":"https://api.github.com/users/reumo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reumo/subscriptions","organizations_url":"https://api.github.com/users/reumo/orgs","repos_url":"https://api.github.com/users/reumo/repos","events_url":"https://api.github.com/users/reumo/events{/privacy}","received_events_url":"https://api.github.com/users/reumo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reumo/git-cata-score","description":"Cata","fork":false,"url":"https://api.github.com/repos/reumo/git-cata-score","forks_url":"https://api.github.com/repos/reumo/git-cata-score/forks","keys_url":"https://api.github.com/repos/reumo/git-cata-score/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reumo/git-cata-score/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reumo/git-cata-score/teams","hooks_url":"https://api.github.com/repos/reumo/git-cata-score/hooks","issue_events_url":"https://api.github.com/repos/reumo/git-cata-score/issues/events{/number}","events_url":"https://api.github.com/repos/reumo/git-cata-score/events","assignees_url":"https://api.github.com/repos/reumo/git-cata-score/assignees{/user}","branches_url":"https://api.github.com/repos/reumo/git-cata-score/branches{/branch}","tags_url":"https://api.github.com/repos/reumo/git-cata-score/tags","blobs_url":"https://api.github.com/repos/reumo/git-cata-score/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reumo/git-cata-score/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reumo/git-cata-score/git/refs{/sha}","trees_url":"https://api.github.com/repos/reumo/git-cata-score/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reumo/git-cata-score/statuses/{sha}","languages_url":"https://api.github.com/repos/reumo/git-cata-score/languages","stargazers_url":"https://api.github.com/repos/reumo/git-cata-score/stargazers","contributors_url":"https://api.github.com/repos/reumo/git-cata-score/contributors","subscribers_url":"https://api.github.com/repos/reumo/git-cata-score/subscribers","subscription_url":"https://api.github.com/repos/reumo/git-cata-score/subscription","commits_url":"https://api.github.com/repos/reumo/git-cata-score/commits{/sha}","git_commits_url":"https://api.github.com/repos/reumo/git-cata-score/git/commits{/sha}","comments_url":"https://api.github.com/repos/reumo/git-cata-score/comments{/number}","issue_comment_url":"https://api.github.com/repos/reumo/git-cata-score/issues/comments{/number}","contents_url":"https://api.github.com/repos/reumo/git-cata-score/contents/{+path}","compare_url":"https://api.github.com/repos/reumo/git-cata-score/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reumo/git-cata-score/merges","archive_url":"https://api.github.com/repos/reumo/git-cata-score/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reumo/git-cata-score/downloads","issues_url":"https://api.github.com/repos/reumo/git-cata-score/issues{/number}","pulls_url":"https://api.github.com/repos/reumo/git-cata-score/pulls{/number}","milestones_url":"https://api.github.com/repos/reumo/git-cata-score/milestones{/number}","notifications_url":"https://api.github.com/repos/reumo/git-cata-score/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reumo/git-cata-score/labels{/name}","releases_url":"https://api.github.com/repos/reumo/git-cata-score/releases{/id}","deployments_url":"https://api.github.com/repos/reumo/git-cata-score/deployments","created_at":"2018-06-06T10:52:40Z","updated_at":"2018-06-06T11:28:51Z","pushed_at":"2018-06-06T15:04:25Z","git_url":"git://github.com/reumo/git-cata-score.git","ssh_url":"git@github.com:reumo/git-cata-score.git","clone_url":"https://github.com/reumo/git-cata-score.git","svn_url":"https://github.com/reumo/git-cata-score","homepage":null,"size":19,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reumo/git-cata-score/pulls/1"},"html":{"href":"https://github.com/reumo/git-cata-score/pull/1"},"issue":{"href":"https://api.github.com/repos/reumo/git-cata-score/issues/1"},"comments":{"href":"https://api.github.com/repos/reumo/git-cata-score/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/reumo/git-cata-score/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/reumo/git-cata-score/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reumo/git-cata-score/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/reumo/git-cata-score/statuses/b16b05ef76552800117bfb63f4e443fed90fe198"}},"author_association":"OWNER"}}
{"actor":{"display_login":"florlp"}}