{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/224778778","pull_request_review_id":164234645,"id":224778778,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDc3ODc3OA==","diff_hunk":"@@ -20,6 +20,10 @@ stdenv.mkDerivation rec {\n \n     # I think this is a typo and should be CXX? Either way let's kill it\n     sed -i '/XX=\\/usr/d' makefile.macosx_llvm_64bits\n+  '' + stdenv.lib.optionalString (stdenv.buildPlatform != stdenv.hostPlatform) ''\n+    substituteInPlace makefile.machine \\\n+      --replace 'CC=gcc'  'CC=${stdenv.cc.targetPrefix}gcc' \\\n+      --replace 'CXX=g++' 'CXX=${stdenv.cc.targetPrefix}g++'","path":"pkgs/tools/archivers/p7zip/default.nix","position":7,"original_position":7,"commit_id":"fbeeed1c5c81dec0823ca12691a6cd66d5c7599f","original_commit_id":"fbeeed1c5c81dec0823ca12691a6cd66d5c7599f","user":{"login":"Mic92","id":96200,"node_id":"MDQ6VXNlcjk2MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"mhm. is this really the best way to do this? What about non-gcc platforms? ","created_at":"2018-10-12T13:13:43Z","updated_at":"2018-10-12T13:13:43Z","html_url":"https://github.com/NixOS/nixpkgs/pull/48266#discussion_r224778778","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48266","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/224778778"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/48266#discussion_r224778778"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48266"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48266","id":222452254,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNDUyMjU0","html_url":"https://github.com/NixOS/nixpkgs/pull/48266","diff_url":"https://github.com/NixOS/nixpkgs/pull/48266.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/48266.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/48266","number":48266,"state":"closed","locked":false,"title":"p7zip: fix cross-compilation","user":{"login":"volth","id":508305,"node_id":"MDQ6VXNlcjUwODMwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/508305?v=4","gravatar_id":"","url":"https://api.github.com/users/volth","html_url":"https://github.com/volth","followers_url":"https://api.github.com/users/volth/followers","following_url":"https://api.github.com/users/volth/following{/other_user}","gists_url":"https://api.github.com/users/volth/gists{/gist_id}","starred_url":"https://api.github.com/users/volth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volth/subscriptions","organizations_url":"https://api.github.com/users/volth/orgs","repos_url":"https://api.github.com/users/volth/repos","events_url":"https://api.github.com/users/volth/events{/privacy}","received_events_url":"https://api.github.com/users/volth/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nfix cross-compilation\r\n","created_at":"2018-10-12T12:37:03Z","updated_at":"2018-10-12T13:13:43Z","closed_at":"2018-10-12T13:12:55Z","merged_at":"2018-10-12T13:12:55Z","merge_commit_sha":"5bd1b675c668cf249ebdeaf72ec6fe5b5f4fab00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48266/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48266/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/48266/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/fbeeed1c5c81dec0823ca12691a6cd66d5c7599f","head":{"label":"volth:patch-265","ref":"patch-265","sha":"fbeeed1c5c81dec0823ca12691a6cd66d5c7599f","user":{"login":"volth","id":508305,"node_id":"MDQ6VXNlcjUwODMwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/508305?v=4","gravatar_id":"","url":"https://api.github.com/users/volth","html_url":"https://github.com/volth","followers_url":"https://api.github.com/users/volth/followers","following_url":"https://api.github.com/users/volth/following{/other_user}","gists_url":"https://api.github.com/users/volth/gists{/gist_id}","starred_url":"https://api.github.com/users/volth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volth/subscriptions","organizations_url":"https://api.github.com/users/volth/orgs","repos_url":"https://api.github.com/users/volth/repos","events_url":"https://api.github.com/users/volth/events{/privacy}","received_events_url":"https://api.github.com/users/volth/received_events","type":"User","site_admin":false},"repo":{"id":77714826,"node_id":"MDEwOlJlcG9zaXRvcnk3NzcxNDgyNg==","name":"nixpkgs","full_name":"volth/nixpkgs","private":false,"owner":{"login":"volth","id":508305,"node_id":"MDQ6VXNlcjUwODMwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/508305?v=4","gravatar_id":"","url":"https://api.github.com/users/volth","html_url":"https://github.com/volth","followers_url":"https://api.github.com/users/volth/followers","following_url":"https://api.github.com/users/volth/following{/other_user}","gists_url":"https://api.github.com/users/volth/gists{/gist_id}","starred_url":"https://api.github.com/users/volth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volth/subscriptions","organizations_url":"https://api.github.com/users/volth/orgs","repos_url":"https://api.github.com/users/volth/repos","events_url":"https://api.github.com/users/volth/events{/privacy}","received_events_url":"https://api.github.com/users/volth/received_events","type":"User","site_admin":false},"html_url":"https://github.com/volth/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/volth/nixpkgs","forks_url":"https://api.github.com/repos/volth/nixpkgs/forks","keys_url":"https://api.github.com/repos/volth/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/volth/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/volth/nixpkgs/teams","hooks_url":"https://api.github.com/repos/volth/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/volth/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/volth/nixpkgs/events","assignees_url":"https://api.github.com/repos/volth/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/volth/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/volth/nixpkgs/tags","blobs_url":"https://api.github.com/repos/volth/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/volth/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/volth/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/volth/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/volth/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/volth/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/volth/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/volth/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/volth/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/volth/nixpkgs/subscription","commits_url":"https://api.github.com/repos/volth/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/volth/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/volth/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/volth/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/volth/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/volth/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/volth/nixpkgs/merges","archive_url":"https://api.github.com/repos/volth/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/volth/nixpkgs/downloads","issues_url":"https://api.github.com/repos/volth/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/volth/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/volth/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/volth/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/volth/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/volth/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/volth/nixpkgs/deployments","created_at":"2016-12-30T23:01:45Z","updated_at":"2018-04-08T11:02:54Z","pushed_at":"2018-10-12T13:03:50Z","git_url":"git://github.com/volth/nixpkgs.git","ssh_url":"git@github.com:volth/nixpkgs.git","clone_url":"https://github.com/volth/nixpkgs.git","svn_url":"https://github.com/volth/nixpkgs","homepage":null,"size":796627,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"c4afb45af52ab976e2ee18fb1cf06531e0fd35e1","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-10-12T13:08:16Z","pushed_at":"2018-10-12T13:12:56Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":867593,"stargazers_count":2885,"watchers_count":2885,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3059,"mirror_url":null,"archived":false,"open_issues_count":3349,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3059,"open_issues":3349,"watchers":2885,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48266"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/48266"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/48266"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/48266/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48266/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48266/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/fbeeed1c5c81dec0823ca12691a6cd66d5c7599f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Mic92"}}