{"action":"closed","number":17756,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/17756","id":199457177,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NDU3MTc3","html_url":"https://github.com/apple/swift/pull/17756","diff_url":"https://github.com/apple/swift/pull/17756.diff","patch_url":"https://github.com/apple/swift/pull/17756.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/17756","number":17756,"state":"closed","locked":false,"title":"Derive Equatable & Hashable for uninhabited types","user":{"login":"mdiep","id":1302,"node_id":"MDQ6VXNlcjEzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1302?v=4","gravatar_id":"","url":"https://api.github.com/users/mdiep","html_url":"https://github.com/mdiep","followers_url":"https://api.github.com/users/mdiep/followers","following_url":"https://api.github.com/users/mdiep/following{/other_user}","gists_url":"https://api.github.com/users/mdiep/gists{/gist_id}","starred_url":"https://api.github.com/users/mdiep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdiep/subscriptions","organizations_url":"https://api.github.com/users/mdiep/orgs","repos_url":"https://api.github.com/users/mdiep/repos","events_url":"https://api.github.com/users/mdiep/events{/privacy}","received_events_url":"https://api.github.com/users/mdiep/received_events","type":"User","site_admin":false},"body":"The original proposal did explicitly say this wouldn't be done:\r\n\r\n> The compiler does not synthesize P's requirements for an enum with no cases because it is not possible to create instances of such types.\r\n\r\nBut I'm hoping that this change doesn't need to go through the evolution process:\r\n\r\n1. This is clearly possible\r\n\r\n2. It's useful when your enum is part of a larger protocol, you expect it to gain cases, or you're using it with generics.\r\n\r\nI've been running into this a lot at work. It's often confusing for people to figure out why these aren't derived and what they should do about it.","created_at":"2018-07-05T12:41:09Z","updated_at":"2018-07-12T19:22:34Z","closed_at":"2018-07-12T19:22:34Z","merged_at":"2018-07-12T19:22:34Z","merge_commit_sha":"85115dd2c9e2125c9fe6a9b743ceaf07c978f1a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/17756/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/17756/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/17756/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/30949c75ef8d745626112b7a0f94eca3e26aab04","head":{"label":"mdiep:synthesize-equatable-hashable-for-uninhabited-types","ref":"synthesize-equatable-hashable-for-uninhabited-types","sha":"30949c75ef8d745626112b7a0f94eca3e26aab04","user":{"login":"mdiep","id":1302,"node_id":"MDQ6VXNlcjEzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1302?v=4","gravatar_id":"","url":"https://api.github.com/users/mdiep","html_url":"https://github.com/mdiep","followers_url":"https://api.github.com/users/mdiep/followers","following_url":"https://api.github.com/users/mdiep/following{/other_user}","gists_url":"https://api.github.com/users/mdiep/gists{/gist_id}","starred_url":"https://api.github.com/users/mdiep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdiep/subscriptions","organizations_url":"https://api.github.com/users/mdiep/orgs","repos_url":"https://api.github.com/users/mdiep/repos","events_url":"https://api.github.com/users/mdiep/events{/privacy}","received_events_url":"https://api.github.com/users/mdiep/received_events","type":"User","site_admin":false},"repo":{"id":47346251,"node_id":"MDEwOlJlcG9zaXRvcnk0NzM0NjI1MQ==","name":"swift","full_name":"mdiep/swift","owner":{"login":"mdiep","id":1302,"node_id":"MDQ6VXNlcjEzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1302?v=4","gravatar_id":"","url":"https://api.github.com/users/mdiep","html_url":"https://github.com/mdiep","followers_url":"https://api.github.com/users/mdiep/followers","following_url":"https://api.github.com/users/mdiep/following{/other_user}","gists_url":"https://api.github.com/users/mdiep/gists{/gist_id}","starred_url":"https://api.github.com/users/mdiep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdiep/subscriptions","organizations_url":"https://api.github.com/users/mdiep/orgs","repos_url":"https://api.github.com/users/mdiep/repos","events_url":"https://api.github.com/users/mdiep/events{/privacy}","received_events_url":"https://api.github.com/users/mdiep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdiep/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/mdiep/swift","forks_url":"https://api.github.com/repos/mdiep/swift/forks","keys_url":"https://api.github.com/repos/mdiep/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdiep/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdiep/swift/teams","hooks_url":"https://api.github.com/repos/mdiep/swift/hooks","issue_events_url":"https://api.github.com/repos/mdiep/swift/issues/events{/number}","events_url":"https://api.github.com/repos/mdiep/swift/events","assignees_url":"https://api.github.com/repos/mdiep/swift/assignees{/user}","branches_url":"https://api.github.com/repos/mdiep/swift/branches{/branch}","tags_url":"https://api.github.com/repos/mdiep/swift/tags","blobs_url":"https://api.github.com/repos/mdiep/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdiep/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdiep/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdiep/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdiep/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/mdiep/swift/languages","stargazers_url":"https://api.github.com/repos/mdiep/swift/stargazers","contributors_url":"https://api.github.com/repos/mdiep/swift/contributors","subscribers_url":"https://api.github.com/repos/mdiep/swift/subscribers","subscription_url":"https://api.github.com/repos/mdiep/swift/subscription","commits_url":"https://api.github.com/repos/mdiep/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdiep/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdiep/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdiep/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdiep/swift/contents/{+path}","compare_url":"https://api.github.com/repos/mdiep/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdiep/swift/merges","archive_url":"https://api.github.com/repos/mdiep/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdiep/swift/downloads","issues_url":"https://api.github.com/repos/mdiep/swift/issues{/number}","pulls_url":"https://api.github.com/repos/mdiep/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/mdiep/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/mdiep/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdiep/swift/labels{/name}","releases_url":"https://api.github.com/repos/mdiep/swift/releases{/id}","deployments_url":"https://api.github.com/repos/mdiep/swift/deployments","created_at":"2015-12-03T16:53:34Z","updated_at":"2018-07-12T12:59:59Z","pushed_at":"2018-07-12T12:59:47Z","git_url":"git://github.com/mdiep/swift.git","ssh_url":"git@github.com:mdiep/swift.git","clone_url":"https://github.com/mdiep/swift.git","svn_url":"https://github.com/mdiep/swift","homepage":"","size":281052,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"6c0d3258058ea0c8ef3705d7eaac4fd418a72b93","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-07-12T18:36:32Z","pushed_at":"2018-07-12T19:22:34Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":309275,"stargazers_count":44500,"watchers_count":44500,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7029,"mirror_url":null,"archived":false,"open_issues_count":372,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7029,"open_issues":372,"watchers":44500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/17756"},"html":{"href":"https://github.com/apple/swift/pull/17756"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/17756"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/17756/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/17756/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/17756/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/30949c75ef8d745626112b7a0f94eca3e26aab04"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rudkx","id":162784,"node_id":"MDQ6VXNlcjE2Mjc4NA==","avatar_url":"https://avatars1.githubusercontent.com/u/162784?v=4","gravatar_id":"","url":"https://api.github.com/users/rudkx","html_url":"https://github.com/rudkx","followers_url":"https://api.github.com/users/rudkx/followers","following_url":"https://api.github.com/users/rudkx/following{/other_user}","gists_url":"https://api.github.com/users/rudkx/gists{/gist_id}","starred_url":"https://api.github.com/users/rudkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudkx/subscriptions","organizations_url":"https://api.github.com/users/rudkx/orgs","repos_url":"https://api.github.com/users/rudkx/repos","events_url":"https://api.github.com/users/rudkx/events{/privacy}","received_events_url":"https://api.github.com/users/rudkx/received_events","type":"User","site_admin":false},"comments":12,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":40,"deletions":14,"changed_files":2}}
{"actor":{"display_login":"rudkx"}}