{"action":"created","comment":{"url":"https://api.github.com/repos/mdsol/dice_bag/pulls/comments/213537476","pull_request_review_id":150393200,"id":213537476,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzUzNzQ3Ng==","diff_hunk":"@@ -9,32 +8,33 @@ def initialize(key)\n       @private_key = key\n     end\n \n-    def is_valid_private_key?\n+    def valid_private_key?\n       require 'openssl'\n+\n       begin\n         OpenSSL::PKey::RSA.new @private_key\n-        return true  \n+        true\n       rescue => e\n         p e.message\n         p e.backtrace\n-        return false\n+\n+        false\n       end\n-    end \n+    end\n \n     def to_rsa_format!\n       strip_down_key\n       body = @private_key.split(/\\s+/)\n       body = body.first.scan(/.{1,64}/) if body.length == 1\n-    \t@private_key = [@@header, body, @@footer].flatten.join(\"\\n\")\n+      @private_key = [@@header, body, @@footer].flatten.join(\"\\n\")","path":"lib/dice_bag/private_key.rb","position":34,"original_position":34,"commit_id":"0e33379e3b5f337396a808241f866bee1f5f3e2c","original_commit_id":"0e33379e3b5f337396a808241f866bee1f5f3e2c","user":{"login":"jfeltesse-mdsol","id":13656490,"node_id":"MDQ6VXNlcjEzNjU2NDkw","avatar_url":"https://avatars2.githubusercontent.com/u/13656490?v=4","gravatar_id":"","url":"https://api.github.com/users/jfeltesse-mdsol","html_url":"https://github.com/jfeltesse-mdsol","followers_url":"https://api.github.com/users/jfeltesse-mdsol/followers","following_url":"https://api.github.com/users/jfeltesse-mdsol/following{/other_user}","gists_url":"https://api.github.com/users/jfeltesse-mdsol/gists{/gist_id}","starred_url":"https://api.github.com/users/jfeltesse-mdsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfeltesse-mdsol/subscriptions","organizations_url":"https://api.github.com/users/jfeltesse-mdsol/orgs","repos_url":"https://api.github.com/users/jfeltesse-mdsol/repos","events_url":"https://api.github.com/users/jfeltesse-mdsol/events{/privacy}","received_events_url":"https://api.github.com/users/jfeltesse-mdsol/received_events","type":"User","site_admin":false},"body":"for another PR too but those nasty class vars should really be constants, unless some hidden case I'm missing here.","created_at":"2018-08-29T03:52:35Z","updated_at":"2018-08-29T03:53:48Z","html_url":"https://github.com/mdsol/dice_bag/pull/87#discussion_r213537476","pull_request_url":"https://api.github.com/repos/mdsol/dice_bag/pulls/87","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mdsol/dice_bag/pulls/comments/213537476"},"html":{"href":"https://github.com/mdsol/dice_bag/pull/87#discussion_r213537476"},"pull_request":{"href":"https://api.github.com/repos/mdsol/dice_bag/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/mdsol/dice_bag/pulls/87","id":211353851,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMzUzODUx","html_url":"https://github.com/mdsol/dice_bag/pull/87","diff_url":"https://github.com/mdsol/dice_bag/pull/87.diff","patch_url":"https://github.com/mdsol/dice_bag/pull/87.patch","issue_url":"https://api.github.com/repos/mdsol/dice_bag/issues/87","number":87,"state":"open","locked":false,"title":"Refactoring styles: follow the standard Ruby style guide","user":{"login":"piao-mdsol","id":39818722,"node_id":"MDQ6VXNlcjM5ODE4NzIy","avatar_url":"https://avatars2.githubusercontent.com/u/39818722?v=4","gravatar_id":"","url":"https://api.github.com/users/piao-mdsol","html_url":"https://github.com/piao-mdsol","followers_url":"https://api.github.com/users/piao-mdsol/followers","following_url":"https://api.github.com/users/piao-mdsol/following{/other_user}","gists_url":"https://api.github.com/users/piao-mdsol/gists{/gist_id}","starred_url":"https://api.github.com/users/piao-mdsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piao-mdsol/subscriptions","organizations_url":"https://api.github.com/users/piao-mdsol/orgs","repos_url":"https://api.github.com/users/piao-mdsol/repos","events_url":"https://api.github.com/users/piao-mdsol/events{/privacy}","received_events_url":"https://api.github.com/users/piao-mdsol/received_events","type":"User","site_admin":false},"body":"When working on this repo, I noticed there are places that are not following the [Ruby style guide](https://github.com/rubocop-hq/ruby-style-guide). This PR is focused to make the quick wins to fix the style problems around spacing, empty line, comments, etc.\r\n\r\n## Motivation\r\n\r\nHaving a clean codebase would encourage developers to contribute more, focus on the problems they want to solve and not distract by the low-level styles.\r\n\r\nI feel I'm more motivated to walk around the codebase after these cleanup 🙂.\r\n\r\n## Approach\r\n\r\nI used the default setting of Rubocop that mostly follows the Ruby style guide.\r\nEach commit is fixing one style problem with the auto-correction, plus manual change if needed.\r\nPlan to squash the commits all once review is completed, for now, expanding them for easier review and discussions.\r\n\r\n## Single quote vs double quote ❓ \r\n\r\nThis is the one style I haven't addressed. The two styles are mingled in the project, seemingly single quote is taking more territory, but let me know which one we'd like to follow. I'll update them all in once.\r\n\r\n@mdsol/team-10 Please 🙏 ","created_at":"2018-08-28T09:16:51Z","updated_at":"2018-08-29T03:53:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"867def8027e4c137f18887f443a44ec3682ef388","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mdsol/dice_bag/pulls/87/commits","review_comments_url":"https://api.github.com/repos/mdsol/dice_bag/pulls/87/comments","review_comment_url":"https://api.github.com/repos/mdsol/dice_bag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mdsol/dice_bag/issues/87/comments","statuses_url":"https://api.github.com/repos/mdsol/dice_bag/statuses/0e33379e3b5f337396a808241f866bee1f5f3e2c","head":{"label":"mdsol:fix/refactoring-styles","ref":"fix/refactoring-styles","sha":"0e33379e3b5f337396a808241f866bee1f5f3e2c","user":{"login":"mdsol","id":171103,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTEwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/171103?v=4","gravatar_id":"","url":"https://api.github.com/users/mdsol","html_url":"https://github.com/mdsol","followers_url":"https://api.github.com/users/mdsol/followers","following_url":"https://api.github.com/users/mdsol/following{/other_user}","gists_url":"https://api.github.com/users/mdsol/gists{/gist_id}","starred_url":"https://api.github.com/users/mdsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdsol/subscriptions","organizations_url":"https://api.github.com/users/mdsol/orgs","repos_url":"https://api.github.com/users/mdsol/repos","events_url":"https://api.github.com/users/mdsol/events{/privacy}","received_events_url":"https://api.github.com/users/mdsol/received_events","type":"Organization","site_admin":false},"repo":{"id":6171817,"node_id":"MDEwOlJlcG9zaXRvcnk2MTcxODE3","name":"dice_bag","full_name":"mdsol/dice_bag","owner":{"login":"mdsol","id":171103,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTEwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/171103?v=4","gravatar_id":"","url":"https://api.github.com/users/mdsol","html_url":"https://github.com/mdsol","followers_url":"https://api.github.com/users/mdsol/followers","following_url":"https://api.github.com/users/mdsol/following{/other_user}","gists_url":"https://api.github.com/users/mdsol/gists{/gist_id}","starred_url":"https://api.github.com/users/mdsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdsol/subscriptions","organizations_url":"https://api.github.com/users/mdsol/orgs","repos_url":"https://api.github.com/users/mdsol/repos","events_url":"https://api.github.com/users/mdsol/events{/privacy}","received_events_url":"https://api.github.com/users/mdsol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mdsol/dice_bag","description":"DiceBag is a library of rake tasks for configuring web apps in the style of The Twelve-Factor App.","fork":false,"url":"https://api.github.com/repos/mdsol/dice_bag","forks_url":"https://api.github.com/repos/mdsol/dice_bag/forks","keys_url":"https://api.github.com/repos/mdsol/dice_bag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdsol/dice_bag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdsol/dice_bag/teams","hooks_url":"https://api.github.com/repos/mdsol/dice_bag/hooks","issue_events_url":"https://api.github.com/repos/mdsol/dice_bag/issues/events{/number}","events_url":"https://api.github.com/repos/mdsol/dice_bag/events","assignees_url":"https://api.github.com/repos/mdsol/dice_bag/assignees{/user}","branches_url":"https://api.github.com/repos/mdsol/dice_bag/branches{/branch}","tags_url":"https://api.github.com/repos/mdsol/dice_bag/tags","blobs_url":"https://api.github.com/repos/mdsol/dice_bag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdsol/dice_bag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdsol/dice_bag/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdsol/dice_bag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdsol/dice_bag/statuses/{sha}","languages_url":"https://api.github.com/repos/mdsol/dice_bag/languages","stargazers_url":"https://api.github.com/repos/mdsol/dice_bag/stargazers","contributors_url":"https://api.github.com/repos/mdsol/dice_bag/contributors","subscribers_url":"https://api.github.com/repos/mdsol/dice_bag/subscribers","subscription_url":"https://api.github.com/repos/mdsol/dice_bag/subscription","commits_url":"https://api.github.com/repos/mdsol/dice_bag/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdsol/dice_bag/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdsol/dice_bag/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdsol/dice_bag/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdsol/dice_bag/contents/{+path}","compare_url":"https://api.github.com/repos/mdsol/dice_bag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdsol/dice_bag/merges","archive_url":"https://api.github.com/repos/mdsol/dice_bag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdsol/dice_bag/downloads","issues_url":"https://api.github.com/repos/mdsol/dice_bag/issues{/number}","pulls_url":"https://api.github.com/repos/mdsol/dice_bag/pulls{/number}","milestones_url":"https://api.github.com/repos/mdsol/dice_bag/milestones{/number}","notifications_url":"https://api.github.com/repos/mdsol/dice_bag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdsol/dice_bag/labels{/name}","releases_url":"https://api.github.com/repos/mdsol/dice_bag/releases{/id}","deployments_url":"https://api.github.com/repos/mdsol/dice_bag/deployments","created_at":"2012-10-11T09:59:16Z","updated_at":"2018-08-28T08:05:23Z","pushed_at":"2018-08-28T09:16:52Z","git_url":"git://github.com/mdsol/dice_bag.git","ssh_url":"git@github.com:mdsol/dice_bag.git","clone_url":"https://github.com/mdsol/dice_bag.git","svn_url":"https://github.com/mdsol/dice_bag","homepage":"","size":185,"stargazers_count":14,"watchers_count":14,"language":"Gherkin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":7,"watchers":14,"default_branch":"develop"}},"base":{"label":"mdsol:develop","ref":"develop","sha":"2d1d624327f6db1becc52705ff15815064cc7583","user":{"login":"mdsol","id":171103,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTEwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/171103?v=4","gravatar_id":"","url":"https://api.github.com/users/mdsol","html_url":"https://github.com/mdsol","followers_url":"https://api.github.com/users/mdsol/followers","following_url":"https://api.github.com/users/mdsol/following{/other_user}","gists_url":"https://api.github.com/users/mdsol/gists{/gist_id}","starred_url":"https://api.github.com/users/mdsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdsol/subscriptions","organizations_url":"https://api.github.com/users/mdsol/orgs","repos_url":"https://api.github.com/users/mdsol/repos","events_url":"https://api.github.com/users/mdsol/events{/privacy}","received_events_url":"https://api.github.com/users/mdsol/received_events","type":"Organization","site_admin":false},"repo":{"id":6171817,"node_id":"MDEwOlJlcG9zaXRvcnk2MTcxODE3","name":"dice_bag","full_name":"mdsol/dice_bag","owner":{"login":"mdsol","id":171103,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTEwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/171103?v=4","gravatar_id":"","url":"https://api.github.com/users/mdsol","html_url":"https://github.com/mdsol","followers_url":"https://api.github.com/users/mdsol/followers","following_url":"https://api.github.com/users/mdsol/following{/other_user}","gists_url":"https://api.github.com/users/mdsol/gists{/gist_id}","starred_url":"https://api.github.com/users/mdsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdsol/subscriptions","organizations_url":"https://api.github.com/users/mdsol/orgs","repos_url":"https://api.github.com/users/mdsol/repos","events_url":"https://api.github.com/users/mdsol/events{/privacy}","received_events_url":"https://api.github.com/users/mdsol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mdsol/dice_bag","description":"DiceBag is a library of rake tasks for configuring web apps in the style of The Twelve-Factor App.","fork":false,"url":"https://api.github.com/repos/mdsol/dice_bag","forks_url":"https://api.github.com/repos/mdsol/dice_bag/forks","keys_url":"https://api.github.com/repos/mdsol/dice_bag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdsol/dice_bag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdsol/dice_bag/teams","hooks_url":"https://api.github.com/repos/mdsol/dice_bag/hooks","issue_events_url":"https://api.github.com/repos/mdsol/dice_bag/issues/events{/number}","events_url":"https://api.github.com/repos/mdsol/dice_bag/events","assignees_url":"https://api.github.com/repos/mdsol/dice_bag/assignees{/user}","branches_url":"https://api.github.com/repos/mdsol/dice_bag/branches{/branch}","tags_url":"https://api.github.com/repos/mdsol/dice_bag/tags","blobs_url":"https://api.github.com/repos/mdsol/dice_bag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdsol/dice_bag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdsol/dice_bag/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdsol/dice_bag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdsol/dice_bag/statuses/{sha}","languages_url":"https://api.github.com/repos/mdsol/dice_bag/languages","stargazers_url":"https://api.github.com/repos/mdsol/dice_bag/stargazers","contributors_url":"https://api.github.com/repos/mdsol/dice_bag/contributors","subscribers_url":"https://api.github.com/repos/mdsol/dice_bag/subscribers","subscription_url":"https://api.github.com/repos/mdsol/dice_bag/subscription","commits_url":"https://api.github.com/repos/mdsol/dice_bag/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdsol/dice_bag/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdsol/dice_bag/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdsol/dice_bag/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdsol/dice_bag/contents/{+path}","compare_url":"https://api.github.com/repos/mdsol/dice_bag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdsol/dice_bag/merges","archive_url":"https://api.github.com/repos/mdsol/dice_bag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdsol/dice_bag/downloads","issues_url":"https://api.github.com/repos/mdsol/dice_bag/issues{/number}","pulls_url":"https://api.github.com/repos/mdsol/dice_bag/pulls{/number}","milestones_url":"https://api.github.com/repos/mdsol/dice_bag/milestones{/number}","notifications_url":"https://api.github.com/repos/mdsol/dice_bag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdsol/dice_bag/labels{/name}","releases_url":"https://api.github.com/repos/mdsol/dice_bag/releases{/id}","deployments_url":"https://api.github.com/repos/mdsol/dice_bag/deployments","created_at":"2012-10-11T09:59:16Z","updated_at":"2018-08-28T08:05:23Z","pushed_at":"2018-08-28T09:16:52Z","git_url":"git://github.com/mdsol/dice_bag.git","ssh_url":"git@github.com:mdsol/dice_bag.git","clone_url":"https://github.com/mdsol/dice_bag.git","svn_url":"https://github.com/mdsol/dice_bag","homepage":"","size":185,"stargazers_count":14,"watchers_count":14,"language":"Gherkin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":7,"watchers":14,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mdsol/dice_bag/pulls/87"},"html":{"href":"https://github.com/mdsol/dice_bag/pull/87"},"issue":{"href":"https://api.github.com/repos/mdsol/dice_bag/issues/87"},"comments":{"href":"https://api.github.com/repos/mdsol/dice_bag/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/mdsol/dice_bag/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/mdsol/dice_bag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mdsol/dice_bag/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/mdsol/dice_bag/statuses/0e33379e3b5f337396a808241f866bee1f5f3e2c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jfeltesse-mdsol"}}