{"action":"created","issue":{"url":"https://api.github.com/repos/Midburn/spark/issues/742","repository_url":"https://api.github.com/repos/Midburn/spark","labels_url":"https://api.github.com/repos/Midburn/spark/issues/742/labels{/name}","comments_url":"https://api.github.com/repos/Midburn/spark/issues/742/comments","events_url":"https://api.github.com/repos/Midburn/spark/issues/742/events","html_url":"https://github.com/Midburn/spark/pull/742","id":303946208,"number":742,"title":"Support dgs allocation","user":{"login":"NitayRabi","id":24541325,"avatar_url":"https://avatars1.githubusercontent.com/u/24541325?v=4","gravatar_id":"","url":"https://api.github.com/users/NitayRabi","html_url":"https://github.com/NitayRabi","followers_url":"https://api.github.com/users/NitayRabi/followers","following_url":"https://api.github.com/users/NitayRabi/following{/other_user}","gists_url":"https://api.github.com/users/NitayRabi/gists{/gist_id}","starred_url":"https://api.github.com/users/NitayRabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NitayRabi/subscriptions","organizations_url":"https://api.github.com/users/NitayRabi/orgs","repos_url":"https://api.github.com/users/NitayRabi/repos","events_url":"https://api.github.com/users/NitayRabi/events{/privacy}","received_events_url":"https://api.github.com/users/NitayRabi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-09T19:02:00Z","updated_at":"2018-03-11T12:19:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Midburn/spark/pulls/742","html_url":"https://github.com/Midburn/spark/pull/742","diff_url":"https://github.com/Midburn/spark/pull/742.diff","patch_url":"https://github.com/Midburn/spark/pull/742.patch"},"body":"<!-- PLEASE READ THE FOLLOWING INSTRUCTIONS -->\r\n\r\n### Proposed solution\r\nAdd another ticket type named DGS (קבוצה) - naming conventions are temporary.\r\nAdd date range for events for the sale of these tickets and implement disabling by date-range.\r\nAdd another input for theme-camps admin to allocate tickets to camps\r\nAdd inputs for allocating these tickets to camp members.\r\n#### Some fixs\r\nDate visibility in date inputs under event editing\r\nCounts - showing correct ticket counts in camp edit (Total camp members, total available tickets (+by ticket type), total allocated tickets) \r\n\r\n### Tradeoffs\r\nCurrently this is a quick and dirty solution - we need to restructure the tables and avoid the usage of the stringed json columns.\r\nWe'll need to migrate the current production data to the correct new field in camps table and camp_members json field.\r\n\r\n### Testing Done\r\nE2E for the following processes - \r\n- Adding dates for ticket allocation (both types) under event and validating dis/abling of relevant inputs for ticket allocation under camp management.\r\n- Allocating the different ticket types to camps\r\n- Adding and removing tickets from camp members\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Midburn/spark/issues/comments/372111085","html_url":"https://github.com/Midburn/spark/pull/742#issuecomment-372111085","issue_url":"https://api.github.com/repos/Midburn/spark/issues/742","id":372111085,"user":{"login":"amotenko","id":7461928,"avatar_url":"https://avatars3.githubusercontent.com/u/7461928?v=4","gravatar_id":"","url":"https://api.github.com/users/amotenko","html_url":"https://github.com/amotenko","followers_url":"https://api.github.com/users/amotenko/followers","following_url":"https://api.github.com/users/amotenko/following{/other_user}","gists_url":"https://api.github.com/users/amotenko/gists{/gist_id}","starred_url":"https://api.github.com/users/amotenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amotenko/subscriptions","organizations_url":"https://api.github.com/users/amotenko/orgs","repos_url":"https://api.github.com/users/amotenko/repos","events_url":"https://api.github.com/users/amotenko/events{/privacy}","received_events_url":"https://api.github.com/users/amotenko/received_events","type":"User","site_admin":false},"created_at":"2018-03-11T12:19:26Z","updated_at":"2018-03-11T12:19:26Z","author_association":"OWNER","body":"Good! Merging after sale"}}
{"actor":{"display_login":"amotenko"}}