{"action":"created","issue":{"url":"https://api.github.com/repos/ngauthier/tubesock/issues/55","repository_url":"https://api.github.com/repos/ngauthier/tubesock","labels_url":"https://api.github.com/repos/ngauthier/tubesock/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/ngauthier/tubesock/issues/55/comments","events_url":"https://api.github.com/repos/ngauthier/tubesock/issues/55/events","html_url":"https://github.com/ngauthier/tubesock/pull/55","id":342468406,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzYxNTE5","number":55,"title":"Fix `env` deprecated in Rails 5.0","user":{"login":"gosukiwi","id":161972,"node_id":"MDQ6VXNlcjE2MTk3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/161972?v=4","gravatar_id":"","url":"https://api.github.com/users/gosukiwi","html_url":"https://github.com/gosukiwi","followers_url":"https://api.github.com/users/gosukiwi/followers","following_url":"https://api.github.com/users/gosukiwi/following{/other_user}","gists_url":"https://api.github.com/users/gosukiwi/gists{/gist_id}","starred_url":"https://api.github.com/users/gosukiwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosukiwi/subscriptions","organizations_url":"https://api.github.com/users/gosukiwi/orgs","repos_url":"https://api.github.com/users/gosukiwi/repos","events_url":"https://api.github.com/users/gosukiwi/events{/privacy}","received_events_url":"https://api.github.com/users/gosukiwi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-18T19:52:27Z","updated_at":"2018-09-12T23:42:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ngauthier/tubesock/pulls/55","html_url":"https://github.com/ngauthier/tubesock/pull/55","diff_url":"https://github.com/ngauthier/tubesock/pull/55.diff","patch_url":"https://github.com/ngauthier/tubesock/pull/55.patch"},"body":"`env` is deprecated in Ralis 5.0 and removed in 5.1, this updates the code to use `request.env` instead: https://github.com/rails/rails/issues/23294"},"comment":{"url":"https://api.github.com/repos/ngauthier/tubesock/issues/comments/420834245","html_url":"https://github.com/ngauthier/tubesock/pull/55#issuecomment-420834245","issue_url":"https://api.github.com/repos/ngauthier/tubesock/issues/55","id":420834245,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDgzNDI0NQ==","user":{"login":"cantino","id":83835,"node_id":"MDQ6VXNlcjgzODM1","avatar_url":"https://avatars0.githubusercontent.com/u/83835?v=4","gravatar_id":"","url":"https://api.github.com/users/cantino","html_url":"https://github.com/cantino","followers_url":"https://api.github.com/users/cantino/followers","following_url":"https://api.github.com/users/cantino/following{/other_user}","gists_url":"https://api.github.com/users/cantino/gists{/gist_id}","starred_url":"https://api.github.com/users/cantino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cantino/subscriptions","organizations_url":"https://api.github.com/users/cantino/orgs","repos_url":"https://api.github.com/users/cantino/repos","events_url":"https://api.github.com/users/cantino/events{/privacy}","received_events_url":"https://api.github.com/users/cantino/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T23:42:26Z","updated_at":"2018-09-12T23:42:26Z","author_association":"NONE","body":"It'd be great to see this get merged!\r\n\r\nIn the meantime, I don't use `Tubesock::Hijack` and instead define in my Controller:\r\n\r\n```ruby\r\nprivate\r\n\r\n  def hijack\r\n      sock = Tubesock.hijack(request.env)\r\n      yield sock\r\n      sock.onclose { ActiveRecord::Base.clear_active_connections! if defined?(ActiveRecord) }\r\n      sock.listen\r\n      render plain: nil, status: -1\r\n    end\r\n```"}}
{"actor":{"display_login":"cantino"}}