{"action":"closed","number":12893,"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/12893","id":190098387,"html_url":"https://github.com/facebook/react/pull/12893","diff_url":"https://github.com/facebook/react/pull/12893.diff","patch_url":"https://github.com/facebook/react/pull/12893.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/12893","number":12893,"state":"closed","locked":false,"title":"[scheduler] 3/n Use a linked list instead of map and queue for callback storage","user":{"login":"flarnie","id":1114467,"avatar_url":"https://avatars2.githubusercontent.com/u/1114467?v=4","gravatar_id":"","url":"https://api.github.com/users/flarnie","html_url":"https://github.com/flarnie","followers_url":"https://api.github.com/users/flarnie/followers","following_url":"https://api.github.com/users/flarnie/following{/other_user}","gists_url":"https://api.github.com/users/flarnie/gists{/gist_id}","starred_url":"https://api.github.com/users/flarnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flarnie/subscriptions","organizations_url":"https://api.github.com/users/flarnie/orgs","repos_url":"https://api.github.com/users/flarnie/repos","events_url":"https://api.github.com/users/flarnie/events{/privacy}","received_events_url":"https://api.github.com/users/flarnie/received_events","type":"User","site_admin":false},"body":"**Edit:** Rebased and now there is no cruft on this PR. :)\r\n    \r\n---\r\n    \r\n**what is the change?:**\r\nSee title\r\n    \r\n**why make this change?:**\r\nThis seems to make the code simpler, and potentially saves space of\r\nhaving an array and object around holding references to the callbacks.\r\n    \r\n**test plan:**\r\nRun existing the new and improved tests, from the previous PR.","created_at":"2018-05-23T20:40:11Z","updated_at":"2018-05-26T22:55:58Z","closed_at":"2018-05-26T22:55:58Z","merged_at":"2018-05-26T22:55:58Z","merge_commit_sha":"61777a78f6f9d90bea6ecdab4038675010bd70db","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars2.githubusercontent.com/u/63648?v=4","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":196858374,"url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/12893/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/12893/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/12893/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/4785e74e1af9503347acdb5c5331c8400bdbbc64","head":{"label":"flarnie:useYouALinkedListForGreatGood4","ref":"useYouALinkedListForGreatGood4","sha":"4785e74e1af9503347acdb5c5331c8400bdbbc64","user":{"login":"flarnie","id":1114467,"avatar_url":"https://avatars2.githubusercontent.com/u/1114467?v=4","gravatar_id":"","url":"https://api.github.com/users/flarnie","html_url":"https://github.com/flarnie","followers_url":"https://api.github.com/users/flarnie/followers","following_url":"https://api.github.com/users/flarnie/following{/other_user}","gists_url":"https://api.github.com/users/flarnie/gists{/gist_id}","starred_url":"https://api.github.com/users/flarnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flarnie/subscriptions","organizations_url":"https://api.github.com/users/flarnie/orgs","repos_url":"https://api.github.com/users/flarnie/repos","events_url":"https://api.github.com/users/flarnie/events{/privacy}","received_events_url":"https://api.github.com/users/flarnie/received_events","type":"User","site_admin":false},"repo":{"id":66949751,"name":"react","full_name":"flarnie/react","owner":{"login":"flarnie","id":1114467,"avatar_url":"https://avatars2.githubusercontent.com/u/1114467?v=4","gravatar_id":"","url":"https://api.github.com/users/flarnie","html_url":"https://github.com/flarnie","followers_url":"https://api.github.com/users/flarnie/followers","following_url":"https://api.github.com/users/flarnie/following{/other_user}","gists_url":"https://api.github.com/users/flarnie/gists{/gist_id}","starred_url":"https://api.github.com/users/flarnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flarnie/subscriptions","organizations_url":"https://api.github.com/users/flarnie/orgs","repos_url":"https://api.github.com/users/flarnie/repos","events_url":"https://api.github.com/users/flarnie/events{/privacy}","received_events_url":"https://api.github.com/users/flarnie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flarnie/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/flarnie/react","forks_url":"https://api.github.com/repos/flarnie/react/forks","keys_url":"https://api.github.com/repos/flarnie/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flarnie/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flarnie/react/teams","hooks_url":"https://api.github.com/repos/flarnie/react/hooks","issue_events_url":"https://api.github.com/repos/flarnie/react/issues/events{/number}","events_url":"https://api.github.com/repos/flarnie/react/events","assignees_url":"https://api.github.com/repos/flarnie/react/assignees{/user}","branches_url":"https://api.github.com/repos/flarnie/react/branches{/branch}","tags_url":"https://api.github.com/repos/flarnie/react/tags","blobs_url":"https://api.github.com/repos/flarnie/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flarnie/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flarnie/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/flarnie/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flarnie/react/statuses/{sha}","languages_url":"https://api.github.com/repos/flarnie/react/languages","stargazers_url":"https://api.github.com/repos/flarnie/react/stargazers","contributors_url":"https://api.github.com/repos/flarnie/react/contributors","subscribers_url":"https://api.github.com/repos/flarnie/react/subscribers","subscription_url":"https://api.github.com/repos/flarnie/react/subscription","commits_url":"https://api.github.com/repos/flarnie/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/flarnie/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/flarnie/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/flarnie/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/flarnie/react/contents/{+path}","compare_url":"https://api.github.com/repos/flarnie/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flarnie/react/merges","archive_url":"https://api.github.com/repos/flarnie/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flarnie/react/downloads","issues_url":"https://api.github.com/repos/flarnie/react/issues{/number}","pulls_url":"https://api.github.com/repos/flarnie/react/pulls{/number}","milestones_url":"https://api.github.com/repos/flarnie/react/milestones{/number}","notifications_url":"https://api.github.com/repos/flarnie/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flarnie/react/labels{/name}","releases_url":"https://api.github.com/repos/flarnie/react/releases{/id}","deployments_url":"https://api.github.com/repos/flarnie/react/deployments","created_at":"2016-08-30T14:46:03Z","updated_at":"2018-05-17T17:21:39Z","pushed_at":"2018-05-26T21:38:17Z","git_url":"git://github.com/flarnie/react.git","ssh_url":"git@github.com:flarnie/react.git","clone_url":"https://github.com/flarnie/react.git","svn_url":"https://github.com/flarnie/react","homepage":"https://facebook.github.io/react/","size":135950,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"e7bd3d59a9502b4727982087b70d82693ebde7d8","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2018-05-26T22:50:09Z","pushed_at":"2018-05-26T22:55:58Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://reactjs.org","size":136311,"stargazers_count":96784,"watchers_count":96784,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18207,"mirror_url":null,"archived":false,"open_issues_count":465,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":18207,"open_issues":465,"watchers":96784,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/12893"},"html":{"href":"https://github.com/facebook/react/pull/12893"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/12893"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/12893/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/12893/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/12893/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/4785e74e1af9503347acdb5c5331c8400bdbbc64"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"flarnie","id":1114467,"avatar_url":"https://avatars2.githubusercontent.com/u/1114467?v=4","gravatar_id":"","url":"https://api.github.com/users/flarnie","html_url":"https://github.com/flarnie","followers_url":"https://api.github.com/users/flarnie/followers","following_url":"https://api.github.com/users/flarnie/following{/other_user}","gists_url":"https://api.github.com/users/flarnie/gists{/gist_id}","starred_url":"https://api.github.com/users/flarnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flarnie/subscriptions","organizations_url":"https://api.github.com/users/flarnie/orgs","repos_url":"https://api.github.com/users/flarnie/repos","events_url":"https://api.github.com/users/flarnie/events{/privacy}","received_events_url":"https://api.github.com/users/flarnie/received_events","type":"User","site_admin":false},"comments":6,"review_comments":11,"maintainer_can_modify":false,"commits":9,"additions":134,"deletions":77,"changed_files":3}}
{"actor":{"display_login":"flarnie"}}