{"action":"opened","number":2539,"pull_request":{"url":"https://api.github.com/repos/FAForever/fa/pulls/2539","id":204433748,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDMzNzQ4","html_url":"https://github.com/FAForever/fa/pull/2539","diff_url":"https://github.com/FAForever/fa/pull/2539.diff","patch_url":"https://github.com/FAForever/fa/pull/2539.patch","issue_url":"https://api.github.com/repos/FAForever/fa/issues/2539","number":2539,"state":"open","locked":false,"title":" [Issue#1260] Ythotha fix destroy","user":{"login":"zkov96","id":14039793,"node_id":"MDQ6VXNlcjE0MDM5Nzkz","avatar_url":"https://avatars1.githubusercontent.com/u/14039793?v=4","gravatar_id":"","url":"https://api.github.com/users/zkov96","html_url":"https://github.com/zkov96","followers_url":"https://api.github.com/users/zkov96/followers","following_url":"https://api.github.com/users/zkov96/following{/other_user}","gists_url":"https://api.github.com/users/zkov96/gists{/gist_id}","starred_url":"https://api.github.com/users/zkov96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zkov96/subscriptions","organizations_url":"https://api.github.com/users/zkov96/orgs","repos_url":"https://api.github.com/users/zkov96/repos","events_url":"https://api.github.com/users/zkov96/events{/privacy}","received_events_url":"https://api.github.com/users/zkov96/received_events","type":"User","site_admin":false},"body":"Refactored code in fa/units/XSL0401/XSL0401_Script.lua\r\nChanged:\r\n1. Move lightning spawn from OnDestroy to OnReclaimed\r\n2. Spawn lightning in DeathThread as original\r\n3. Add defuse lightning from owner by reclaim\r\n4. Call Unit:Destroy() not spawn lightning [as wanila]\r\n\r\nThis commits add lightning after reclaim Ythotha unit by any army (not owner). But it work more correctly then this [commit 1449dc5a3450b4cb497d20439969f0736ff6c784](https://github.com/FAForever/fa/commit/1449dc5a3450b4cb497d20439969f0736ff6c784) without using duct tape [IsBeingTransferred](https://github.com/FAForever/fa/commit/810ffcc30af98701374bd2588fbdc61d911a605b#diff-978e442e90e99e5cab1d4e27bd351351). Also not spawn lightning on Unit:Destroy() how it should be","created_at":"2018-07-27T13:36:00Z","updated_at":"2018-07-27T13:36:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FAForever/fa/pulls/2539/commits","review_comments_url":"https://api.github.com/repos/FAForever/fa/pulls/2539/comments","review_comment_url":"https://api.github.com/repos/FAForever/fa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FAForever/fa/issues/2539/comments","statuses_url":"https://api.github.com/repos/FAForever/fa/statuses/75111936b5c49b0ed78951608121721b55ae4fd9","head":{"label":"zkov96:UnitLogicFIx","ref":"UnitLogicFIx","sha":"75111936b5c49b0ed78951608121721b55ae4fd9","user":{"login":"zkov96","id":14039793,"node_id":"MDQ6VXNlcjE0MDM5Nzkz","avatar_url":"https://avatars1.githubusercontent.com/u/14039793?v=4","gravatar_id":"","url":"https://api.github.com/users/zkov96","html_url":"https://github.com/zkov96","followers_url":"https://api.github.com/users/zkov96/followers","following_url":"https://api.github.com/users/zkov96/following{/other_user}","gists_url":"https://api.github.com/users/zkov96/gists{/gist_id}","starred_url":"https://api.github.com/users/zkov96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zkov96/subscriptions","organizations_url":"https://api.github.com/users/zkov96/orgs","repos_url":"https://api.github.com/users/zkov96/repos","events_url":"https://api.github.com/users/zkov96/events{/privacy}","received_events_url":"https://api.github.com/users/zkov96/received_events","type":"User","site_admin":false},"repo":{"id":142568648,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI1Njg2NDg=","name":"fa","full_name":"zkov96/fa","owner":{"login":"zkov96","id":14039793,"node_id":"MDQ6VXNlcjE0MDM5Nzkz","avatar_url":"https://avatars1.githubusercontent.com/u/14039793?v=4","gravatar_id":"","url":"https://api.github.com/users/zkov96","html_url":"https://github.com/zkov96","followers_url":"https://api.github.com/users/zkov96/followers","following_url":"https://api.github.com/users/zkov96/following{/other_user}","gists_url":"https://api.github.com/users/zkov96/gists{/gist_id}","starred_url":"https://api.github.com/users/zkov96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zkov96/subscriptions","organizations_url":"https://api.github.com/users/zkov96/orgs","repos_url":"https://api.github.com/users/zkov96/repos","events_url":"https://api.github.com/users/zkov96/events{/privacy}","received_events_url":"https://api.github.com/users/zkov96/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zkov96/fa","description":"Lua code for FAF","fork":true,"url":"https://api.github.com/repos/zkov96/fa","forks_url":"https://api.github.com/repos/zkov96/fa/forks","keys_url":"https://api.github.com/repos/zkov96/fa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zkov96/fa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zkov96/fa/teams","hooks_url":"https://api.github.com/repos/zkov96/fa/hooks","issue_events_url":"https://api.github.com/repos/zkov96/fa/issues/events{/number}","events_url":"https://api.github.com/repos/zkov96/fa/events","assignees_url":"https://api.github.com/repos/zkov96/fa/assignees{/user}","branches_url":"https://api.github.com/repos/zkov96/fa/branches{/branch}","tags_url":"https://api.github.com/repos/zkov96/fa/tags","blobs_url":"https://api.github.com/repos/zkov96/fa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zkov96/fa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zkov96/fa/git/refs{/sha}","trees_url":"https://api.github.com/repos/zkov96/fa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zkov96/fa/statuses/{sha}","languages_url":"https://api.github.com/repos/zkov96/fa/languages","stargazers_url":"https://api.github.com/repos/zkov96/fa/stargazers","contributors_url":"https://api.github.com/repos/zkov96/fa/contributors","subscribers_url":"https://api.github.com/repos/zkov96/fa/subscribers","subscription_url":"https://api.github.com/repos/zkov96/fa/subscription","commits_url":"https://api.github.com/repos/zkov96/fa/commits{/sha}","git_commits_url":"https://api.github.com/repos/zkov96/fa/git/commits{/sha}","comments_url":"https://api.github.com/repos/zkov96/fa/comments{/number}","issue_comment_url":"https://api.github.com/repos/zkov96/fa/issues/comments{/number}","contents_url":"https://api.github.com/repos/zkov96/fa/contents/{+path}","compare_url":"https://api.github.com/repos/zkov96/fa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zkov96/fa/merges","archive_url":"https://api.github.com/repos/zkov96/fa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zkov96/fa/downloads","issues_url":"https://api.github.com/repos/zkov96/fa/issues{/number}","pulls_url":"https://api.github.com/repos/zkov96/fa/pulls{/number}","milestones_url":"https://api.github.com/repos/zkov96/fa/milestones{/number}","notifications_url":"https://api.github.com/repos/zkov96/fa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zkov96/fa/labels{/name}","releases_url":"https://api.github.com/repos/zkov96/fa/releases{/id}","deployments_url":"https://api.github.com/repos/zkov96/fa/deployments","created_at":"2018-07-27T11:24:23Z","updated_at":"2018-07-27T11:24:32Z","pushed_at":"2018-07-27T12:50:45Z","git_url":"git://github.com/zkov96/fa.git","ssh_url":"git@github.com:zkov96/fa.git","clone_url":"https://github.com/zkov96/fa.git","svn_url":"https://github.com/zkov96/fa","homepage":"","size":179313,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"FAForever:develop","ref":"develop","sha":"67f892422059aeb1c61a0ba422bcf859fd47145c","user":{"login":"FAForever","id":8887184,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4ODcxODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8887184?v=4","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"repo":{"id":24403473,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQwMzQ3Mw==","name":"fa","full_name":"FAForever/fa","owner":{"login":"FAForever","id":8887184,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4ODcxODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8887184?v=4","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FAForever/fa","description":"Lua code for FAF","fork":false,"url":"https://api.github.com/repos/FAForever/fa","forks_url":"https://api.github.com/repos/FAForever/fa/forks","keys_url":"https://api.github.com/repos/FAForever/fa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FAForever/fa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FAForever/fa/teams","hooks_url":"https://api.github.com/repos/FAForever/fa/hooks","issue_events_url":"https://api.github.com/repos/FAForever/fa/issues/events{/number}","events_url":"https://api.github.com/repos/FAForever/fa/events","assignees_url":"https://api.github.com/repos/FAForever/fa/assignees{/user}","branches_url":"https://api.github.com/repos/FAForever/fa/branches{/branch}","tags_url":"https://api.github.com/repos/FAForever/fa/tags","blobs_url":"https://api.github.com/repos/FAForever/fa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FAForever/fa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FAForever/fa/git/refs{/sha}","trees_url":"https://api.github.com/repos/FAForever/fa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FAForever/fa/statuses/{sha}","languages_url":"https://api.github.com/repos/FAForever/fa/languages","stargazers_url":"https://api.github.com/repos/FAForever/fa/stargazers","contributors_url":"https://api.github.com/repos/FAForever/fa/contributors","subscribers_url":"https://api.github.com/repos/FAForever/fa/subscribers","subscription_url":"https://api.github.com/repos/FAForever/fa/subscription","commits_url":"https://api.github.com/repos/FAForever/fa/commits{/sha}","git_commits_url":"https://api.github.com/repos/FAForever/fa/git/commits{/sha}","comments_url":"https://api.github.com/repos/FAForever/fa/comments{/number}","issue_comment_url":"https://api.github.com/repos/FAForever/fa/issues/comments{/number}","contents_url":"https://api.github.com/repos/FAForever/fa/contents/{+path}","compare_url":"https://api.github.com/repos/FAForever/fa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FAForever/fa/merges","archive_url":"https://api.github.com/repos/FAForever/fa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FAForever/fa/downloads","issues_url":"https://api.github.com/repos/FAForever/fa/issues{/number}","pulls_url":"https://api.github.com/repos/FAForever/fa/pulls{/number}","milestones_url":"https://api.github.com/repos/FAForever/fa/milestones{/number}","notifications_url":"https://api.github.com/repos/FAForever/fa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FAForever/fa/labels{/name}","releases_url":"https://api.github.com/repos/FAForever/fa/releases{/id}","deployments_url":"https://api.github.com/repos/FAForever/fa/deployments","created_at":"2014-09-24T06:34:12Z","updated_at":"2018-07-22T19:31:10Z","pushed_at":"2018-07-27T02:53:47Z","git_url":"git://github.com/FAForever/fa.git","ssh_url":"git@github.com:FAForever/fa.git","clone_url":"https://github.com/FAForever/fa.git","svn_url":"https://github.com/FAForever/fa","homepage":"","size":179289,"stargazers_count":61,"watchers_count":61,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"archived":false,"open_issues_count":315,"license":null,"forks":96,"open_issues":315,"watchers":61,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/FAForever/fa/pulls/2539"},"html":{"href":"https://github.com/FAForever/fa/pull/2539"},"issue":{"href":"https://api.github.com/repos/FAForever/fa/issues/2539"},"comments":{"href":"https://api.github.com/repos/FAForever/fa/issues/2539/comments"},"review_comments":{"href":"https://api.github.com/repos/FAForever/fa/pulls/2539/comments"},"review_comment":{"href":"https://api.github.com/repos/FAForever/fa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FAForever/fa/pulls/2539/commits"},"statuses":{"href":"https://api.github.com/repos/FAForever/fa/statuses/75111936b5c49b0ed78951608121721b55ae4fd9"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":27,"deletions":14,"changed_files":1}}
{"actor":{"display_login":"zkov96"}}