{"action":"closed","issue":{"url":"https://api.github.com/repos/brainvisa/testbidon/issues/115","repository_url":"https://api.github.com/repos/brainvisa/testbidon","labels_url":"https://api.github.com/repos/brainvisa/testbidon/issues/115/labels{/name}","comments_url":"https://api.github.com/repos/brainvisa/testbidon/issues/115/comments","events_url":"https://api.github.com/repos/brainvisa/testbidon/issues/115/events","html_url":"https://github.com/brainvisa/testbidon/issues/115","id":373494256,"node_id":"MDU6SXNzdWUzNzM0OTQyNTY=","number":115,"title":"Incorrect code in carto::Headered::disconnect","user":{"login":"denisri","id":1913468,"node_id":"MDQ6VXNlcjE5MTM0Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1913468?v=4","gravatar_id":"","url":"https://api.github.com/users/denisri","html_url":"https://github.com/denisri","followers_url":"https://api.github.com/users/denisri/followers","following_url":"https://api.github.com/users/denisri/following{/other_user}","gists_url":"https://api.github.com/users/denisri/gists{/gist_id}","starred_url":"https://api.github.com/users/denisri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisri/subscriptions","organizations_url":"https://api.github.com/users/denisri/orgs","repos_url":"https://api.github.com/users/denisri/repos","events_url":"https://api.github.com/users/denisri/events{/privacy}","received_events_url":"https://api.github.com/users/denisri/received_events","type":"User","site_admin":false},"labels":[{"id":1102911205,"node_id":"MDU6TGFiZWwxMTAyOTExMjA1","url":"https://api.github.com/repos/brainvisa/testbidon/labels/Component:%20Resolution","name":"Component: Resolution","color":"ededed","default":false},{"id":1102911204,"node_id":"MDU6TGFiZWwxMTAyOTExMjA0","url":"https://api.github.com/repos/brainvisa/testbidon/labels/Priority:%20Normal","name":"Priority: Normal","color":"ededed","default":false},{"id":1102911202,"node_id":"MDU6TGFiZWwxMTAyOTExMjAy","url":"https://api.github.com/repos/brainvisa/testbidon/labels/Status:%20Closed","name":"Status: Closed","color":"ededed","default":false},{"id":1102911203,"node_id":"MDU6TGFiZWwxMTAyOTExMjAz","url":"https://api.github.com/repos/brainvisa/testbidon/labels/Tracker:%20Defect","name":"Tracker: Defect","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-24T13:51:35Z","updated_at":"2018-10-24T13:51:39Z","closed_at":"2018-10-24T13:51:39Z","author_association":"NONE","body":"---\n\n\nAuthor Name: **Leprince, Yann** (Leprince, Yann)\nOriginal Redmine Issue: 14728, https://bioproj.extra.cea.fr/redmine/issues/14728\nOriginal Date: 2016-04-18\n\n\n---\n\nCompiling cartobase with a recent version of libsigc++ (version 2.8 in my case) leads to this error:\r\n```\r\nsoma/soma-io/trunk/src/libcartobase/object/headered.cc:184:40: error: \r\n      invalid operands to binary expression ('sigc::slot<void, const\r\n      carto::PropertyFilter &, sigc::nil, sigc::nil, sigc::nil, sigc::nil,\r\n      sigc::nil, sigc::nil>' and 'const PropertyFilter::Slot' (aka 'const\r\n      slot1<void, const carto::PropertyFilter &>'))\r\n      for( is=sl.begin(); is!=es && *is==slot; ++is ) ;\r\n                                    ~~~^ ~~~~\r\n\n```\r\n\r\nThe error appears because:\r\n1. There is no @operator==@ for the @sigc::slot@ family.\r\n2. The code compiles fine with older libsigc++ versions because they have an implicit @sigc::slot_base::operator bool()@.\r\n3. This operator has been made explicit in recent libsigc++.\r\n\r\nComparing the outcome of @operator bool@ was probably never the intended behaviour for this code… so I will commit a patch to trunk in order to fix the compilation, but I am unsure if this is really the proper fix (I replaced @*is==slot@ by @&(*is)!=&slot@… eek, ugly!).\r\n\r\nCartobase signal/slots experts, can you please review the fix, and merge it back into bug_fix if it is appropriate?\n\n\n"}}
{"actor":{"display_login":"denisri"}}