{"action":"created","issue":{"url":"https://api.github.com/repos/xBimTeam/XbimEssentials/issues/202","repository_url":"https://api.github.com/repos/xBimTeam/XbimEssentials","labels_url":"https://api.github.com/repos/xBimTeam/XbimEssentials/issues/202/labels{/name}","comments_url":"https://api.github.com/repos/xBimTeam/XbimEssentials/issues/202/comments","events_url":"https://api.github.com/repos/xBimTeam/XbimEssentials/issues/202/events","html_url":"https://github.com/xBimTeam/XbimEssentials/issues/202","id":355095852,"node_id":"MDU6SXNzdWUzNTUwOTU4NTI=","number":202,"title":"[IMPROVEMENTS] Add faceIndex for XbimFaceTriangulation and IFCFACETEDBREP","user":{"login":"liszto","id":408031,"node_id":"MDQ6VXNlcjQwODAzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/408031?v=4","gravatar_id":"","url":"https://api.github.com/users/liszto","html_url":"https://github.com/liszto","followers_url":"https://api.github.com/users/liszto/followers","following_url":"https://api.github.com/users/liszto/following{/other_user}","gists_url":"https://api.github.com/users/liszto/gists{/gist_id}","starred_url":"https://api.github.com/users/liszto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liszto/subscriptions","organizations_url":"https://api.github.com/users/liszto/orgs","repos_url":"https://api.github.com/users/liszto/repos","events_url":"https://api.github.com/users/liszto/events{/privacy}","received_events_url":"https://api.github.com/users/liszto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-29T10:25:41Z","updated_at":"2018-08-29T17:09:22Z","closed_at":null,"author_association":"NONE","body":"Hello guys,\r\nI'm still working on all our XBim / ifc stuff and I'm facing an annoying issue when I try to create a nice rendering in our engine.\r\nWhen I generate some asset that contains some \"IFCFACETEDBREP\", in XBimFaceTriangulation, each triangle generated based on an IFCFACETEDBREP is an independant face for you, so each triangle have its own normals.\r\nSo when the normals at one point are not the same for the same point it create some crappy display with rendering pipeline.\r\nIs there a way to add in the XbimTriangulation a new parameter to allow us to link each triangle between them, like a faceIndex ?\r\nIn this way, it's possible to detect and retrieve all the triangle that could be merged into a single mesh.\r\n\r\nOr maybe iterate through the faces in a shape would be enough if the IsPlanar value is different from 1 for each face ?\r\n\r\nThanks."},"comment":{"url":"https://api.github.com/repos/xBimTeam/XbimEssentials/issues/comments/417030950","html_url":"https://github.com/xBimTeam/XbimEssentials/issues/202#issuecomment-417030950","issue_url":"https://api.github.com/repos/xBimTeam/XbimEssentials/issues/202","id":417030950,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzAzMDk1MA==","user":{"login":"martin1cerny","id":773078,"node_id":"MDQ6VXNlcjc3MzA3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/773078?v=4","gravatar_id":"","url":"https://api.github.com/users/martin1cerny","html_url":"https://github.com/martin1cerny","followers_url":"https://api.github.com/users/martin1cerny/followers","following_url":"https://api.github.com/users/martin1cerny/following{/other_user}","gists_url":"https://api.github.com/users/martin1cerny/gists{/gist_id}","starred_url":"https://api.github.com/users/martin1cerny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martin1cerny/subscriptions","organizations_url":"https://api.github.com/users/martin1cerny/orgs","repos_url":"https://api.github.com/users/martin1cerny/repos","events_url":"https://api.github.com/users/martin1cerny/events{/privacy}","received_events_url":"https://api.github.com/users/martin1cerny/received_events","type":"User","site_admin":false},"created_at":"2018-08-29T17:09:22Z","updated_at":"2018-08-29T17:09:22Z","author_association":"MEMBER","body":"Well, it is virtually impossible to say if the surface should be smoothed out or not if it is not in the original data. You are right that we should consider face to be planar if all vertices are in the same plane and all normals point in the direction parallel with the plane normal. \r\n\r\nBut if you just have a pile of triangles which come from IfcFacetedBRep you can't assume anything. Smoothing applied to all faces would create very bad visual impression as square would look like a sphere and for example wall corners would become invisible."}}
{"actor":{"display_login":"martin1cerny"}}