{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/216614204","pull_request_review_id":154132312,"id":216614204,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjYxNDIwNA==","diff_hunk":"@@ -0,0 +1,22 @@\n+/*\n+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one\n+ * or more contributor license agreements. Licensed under the Elastic License;\n+ * you may not use this file except in compliance with the Elastic License.\n+ */\n+\n+import { InfraMetricType } from '../../../../../common/graphql/types';\n+import { count } from './count';\n+import { cpu } from './cpu';\n+import { load } from './load';\n+import { memory } from './memory';\n+import { rx } from './rx';\n+import { tx } from './tx';\n+\n+export const metrics = {","path":"x-pack/plugins/infra/server/lib/adapters/nodes/metric_aggregation_creators/index.ts","position":15,"original_position":15,"commit_id":"03321ae54ad2e2bc5b23ebbc8accbff687715fe6","original_commit_id":"03321ae54ad2e2bc5b23ebbc8accbff687715fe6","user":{"login":"weltenwort","id":973741,"node_id":"MDQ6VXNlcjk3Mzc0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/973741?v=4","gravatar_id":"","url":"https://api.github.com/users/weltenwort","html_url":"https://github.com/weltenwort","followers_url":"https://api.github.com/users/weltenwort/followers","following_url":"https://api.github.com/users/weltenwort/following{/other_user}","gists_url":"https://api.github.com/users/weltenwort/gists{/gist_id}","starred_url":"https://api.github.com/users/weltenwort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weltenwort/subscriptions","organizations_url":"https://api.github.com/users/weltenwort/orgs","repos_url":"https://api.github.com/users/weltenwort/repos","events_url":"https://api.github.com/users/weltenwort/events{/privacy}","received_events_url":"https://api.github.com/users/weltenwort/received_events","type":"User","site_admin":false},"body":"nitpicking: How about renaming this to `export const metricsAggregationCreators` too? Then it would match the directory name and the imported symbol would not have to be renamed.","created_at":"2018-09-11T10:04:30Z","updated_at":"2018-09-11T10:11:14Z","html_url":"https://github.com/elastic/kibana/pull/22614#discussion_r216614204","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/22614","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/216614204"},"html":{"href":"https://github.com/elastic/kibana/pull/22614#discussion_r216614204"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22614"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/22614","id":212516882,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTE2ODgy","html_url":"https://github.com/elastic/kibana/pull/22614","diff_url":"https://github.com/elastic/kibana/pull/22614.diff","patch_url":"https://github.com/elastic/kibana/pull/22614.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/22614","number":22614,"state":"open","locked":false,"title":"[Infra UI] Add Metrics support to WaffleMap and map GraphQL Endpoint","user":{"login":"simianhacker","id":41702,"node_id":"MDQ6VXNlcjQxNzAy","avatar_url":"https://avatars2.githubusercontent.com/u/41702?v=4","gravatar_id":"","url":"https://api.github.com/users/simianhacker","html_url":"https://github.com/simianhacker","followers_url":"https://api.github.com/users/simianhacker/followers","following_url":"https://api.github.com/users/simianhacker/following{/other_user}","gists_url":"https://api.github.com/users/simianhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/simianhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simianhacker/subscriptions","organizations_url":"https://api.github.com/users/simianhacker/orgs","repos_url":"https://api.github.com/users/simianhacker/repos","events_url":"https://api.github.com/users/simianhacker/events{/privacy}","received_events_url":"https://api.github.com/users/simianhacker/received_events","type":"User","site_admin":false},"body":"This PR adds the ability to specify a preset metric for the WaffleMap. It also includes support for overriding the bounds for the gradient legend. I removed support for \"custom\" metrics, that can come later if we decide it's needed.\r\n\r\n![image](https://user-images.githubusercontent.com/41702/44940203-27150000-ad40-11e8-8243-da2ff9e37825.png)\r\n\r\nCloses #21825\r\n","created_at":"2018-09-01T00:07:12Z","updated_at":"2018-09-11T10:11:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a78eb9398d5ab2e7e167b809470258afe0fee159","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":983061515,"node_id":"MDU6TGFiZWw5ODMwNjE1MTU=","url":"https://api.github.com/repos/elastic/kibana/labels/:Infra%20UI","name":":Infra UI","color":"6cddd6","default":false},{"id":981817023,"node_id":"MDU6TGFiZWw5ODE4MTcwMjM=","url":"https://api.github.com/repos/elastic/kibana/labels/:Ingest%20UI","name":":Ingest UI","color":"c5def5","default":false},{"id":135307740,"node_id":"MDU6TGFiZWwxMzUzMDc3NDA=","url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/22614/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/22614/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/22614/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/03321ae54ad2e2bc5b23ebbc8accbff687715fe6","head":{"label":"simianhacker:map-endpoint-metrics-support","ref":"map-endpoint-metrics-support","sha":"03321ae54ad2e2bc5b23ebbc8accbff687715fe6","user":{"login":"simianhacker","id":41702,"node_id":"MDQ6VXNlcjQxNzAy","avatar_url":"https://avatars2.githubusercontent.com/u/41702?v=4","gravatar_id":"","url":"https://api.github.com/users/simianhacker","html_url":"https://github.com/simianhacker","followers_url":"https://api.github.com/users/simianhacker/followers","following_url":"https://api.github.com/users/simianhacker/following{/other_user}","gists_url":"https://api.github.com/users/simianhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/simianhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simianhacker/subscriptions","organizations_url":"https://api.github.com/users/simianhacker/orgs","repos_url":"https://api.github.com/users/simianhacker/repos","events_url":"https://api.github.com/users/simianhacker/events{/privacy}","received_events_url":"https://api.github.com/users/simianhacker/received_events","type":"User","site_admin":false},"repo":{"id":14648766,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY0ODc2Ng==","name":"kibana","full_name":"simianhacker/kibana","owner":{"login":"simianhacker","id":41702,"node_id":"MDQ6VXNlcjQxNzAy","avatar_url":"https://avatars2.githubusercontent.com/u/41702?v=4","gravatar_id":"","url":"https://api.github.com/users/simianhacker","html_url":"https://github.com/simianhacker","followers_url":"https://api.github.com/users/simianhacker/followers","following_url":"https://api.github.com/users/simianhacker/following{/other_user}","gists_url":"https://api.github.com/users/simianhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/simianhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simianhacker/subscriptions","organizations_url":"https://api.github.com/users/simianhacker/orgs","repos_url":"https://api.github.com/users/simianhacker/repos","events_url":"https://api.github.com/users/simianhacker/events{/privacy}","received_events_url":"https://api.github.com/users/simianhacker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simianhacker/kibana","description":"Kibana 3","fork":true,"url":"https://api.github.com/repos/simianhacker/kibana","forks_url":"https://api.github.com/repos/simianhacker/kibana/forks","keys_url":"https://api.github.com/repos/simianhacker/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simianhacker/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simianhacker/kibana/teams","hooks_url":"https://api.github.com/repos/simianhacker/kibana/hooks","issue_events_url":"https://api.github.com/repos/simianhacker/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/simianhacker/kibana/events","assignees_url":"https://api.github.com/repos/simianhacker/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/simianhacker/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/simianhacker/kibana/tags","blobs_url":"https://api.github.com/repos/simianhacker/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simianhacker/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simianhacker/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/simianhacker/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simianhacker/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/simianhacker/kibana/languages","stargazers_url":"https://api.github.com/repos/simianhacker/kibana/stargazers","contributors_url":"https://api.github.com/repos/simianhacker/kibana/contributors","subscribers_url":"https://api.github.com/repos/simianhacker/kibana/subscribers","subscription_url":"https://api.github.com/repos/simianhacker/kibana/subscription","commits_url":"https://api.github.com/repos/simianhacker/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/simianhacker/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/simianhacker/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/simianhacker/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/simianhacker/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/simianhacker/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simianhacker/kibana/merges","archive_url":"https://api.github.com/repos/simianhacker/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simianhacker/kibana/downloads","issues_url":"https://api.github.com/repos/simianhacker/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/simianhacker/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/simianhacker/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/simianhacker/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simianhacker/kibana/labels{/name}","releases_url":"https://api.github.com/repos/simianhacker/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/simianhacker/kibana/deployments","created_at":"2013-11-23T19:19:22Z","updated_at":"2018-08-30T16:19:37Z","pushed_at":"2018-09-10T16:46:58Z","git_url":"git://github.com/simianhacker/kibana.git","ssh_url":"git@github.com:simianhacker/kibana.git","clone_url":"https://github.com/simianhacker/kibana.git","svn_url":"https://github.com/simianhacker/kibana","homepage":"http://www.elasticsearch.org/overview/kibana/","size":430624,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"elastic:feature-infra-ui","ref":"feature-infra-ui","sha":"7288169cf5fbe5831934105af2fb40b0084f79a3","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-09-11T09:59:32Z","pushed_at":"2018-09-11T09:54:56Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":453196,"stargazers_count":10057,"watchers_count":10057,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3901,"mirror_url":null,"archived":false,"open_issues_count":3405,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3901,"open_issues":3405,"watchers":10057,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22614"},"html":{"href":"https://github.com/elastic/kibana/pull/22614"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/22614"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/22614/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22614/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/22614/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/03321ae54ad2e2bc5b23ebbc8accbff687715fe6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"weltenwort"}}