{"action":"closed","number":144,"pull_request":{"url":"https://api.github.com/repos/mapbox/node-fontnik/pulls/144","id":154025847,"node_id":"MDExOlB1bGxSZXF1ZXN0MTU0MDI1ODQ3","html_url":"https://github.com/mapbox/node-fontnik/pull/144","diff_url":"https://github.com/mapbox/node-fontnik/pull/144.diff","patch_url":"https://github.com/mapbox/node-fontnik/pull/144.patch","issue_url":"https://api.github.com/repos/mapbox/node-fontnik/issues/144","number":144,"state":"closed","locked":false,"title":"Port node-cpp-skel updates","user":{"login":"GretaCB","id":1209162,"node_id":"MDQ6VXNlcjEyMDkxNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1209162?v=4","gravatar_id":"","url":"https://api.github.com/users/GretaCB","html_url":"https://github.com/GretaCB","followers_url":"https://api.github.com/users/GretaCB/followers","following_url":"https://api.github.com/users/GretaCB/following{/other_user}","gists_url":"https://api.github.com/users/GretaCB/gists{/gist_id}","starred_url":"https://api.github.com/users/GretaCB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GretaCB/subscriptions","organizations_url":"https://api.github.com/users/GretaCB/orgs","repos_url":"https://api.github.com/users/GretaCB/repos","events_url":"https://api.github.com/users/GretaCB/events{/privacy}","received_events_url":"https://api.github.com/users/GretaCB/received_events","type":"User","site_admin":false},"body":"Per https://github.com/mapbox/node-fontnik/issues/142\r\n\r\n### Next Actions\r\n- [x] support for more node versions (https://github.com/mapbox/node-fontnik/issues/138)\r\n- [x] moving the secure param's to the travis settings UI (no longer storing in .travis.yml) per https://github.com/mapbox/node-cpp-skel/blob/master/docs/publishing-binaries.md\r\n- [x] ensuring the code is correctly formatted with clang-format and all bugs found by clang-tidy are fixed\r\n- [ ] ~~mason-js is used (once that lands in node-cpp-skel)~~\r\n- [ ] Add modeul_utils.hpp for CallbackError method (?) and integrate into error handling\r\n- [ ] Update docs\r\n- [ ] Update benchmarks (?)\r\n- [x] Update `.gitignore`\r\n- [x] Update binding.gyp to point to new instal script to replace `install_mason.sh`\r\n- [x] Fix new flagged compile errors\r\n- [x] Resolve V8/Node specific compile warnings for code that we dont control\r\n- [x] Remove unneeded diagnostics per https://github.com/mapnik/mapnik/issues/3800\r\n\r\n@mapbox/core-tech ","created_at":"2017-11-21T23:17:18Z","updated_at":"2018-06-27T20:50:56Z","closed_at":"2018-06-27T20:50:56Z","merged_at":"2018-06-27T20:50:56Z","merge_commit_sha":"4c239cc116801eaa0f9bee9aaa9c60ab167c199c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/node-fontnik/pulls/144/commits","review_comments_url":"https://api.github.com/repos/mapbox/node-fontnik/pulls/144/comments","review_comment_url":"https://api.github.com/repos/mapbox/node-fontnik/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/node-fontnik/issues/144/comments","statuses_url":"https://api.github.com/repos/mapbox/node-fontnik/statuses/b082e4ce044c3bcab74b3e703d400061bd27e909","head":{"label":"mapbox:port-skel","ref":"port-skel","sha":"b082e4ce044c3bcab74b3e703d400061bd27e909","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":13218990,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIxODk5MA==","name":"node-fontnik","full_name":"mapbox/node-fontnik","owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/node-fontnik","description":"Fonts ⇢ protobuf-encoded SDF glyphs","fork":false,"url":"https://api.github.com/repos/mapbox/node-fontnik","forks_url":"https://api.github.com/repos/mapbox/node-fontnik/forks","keys_url":"https://api.github.com/repos/mapbox/node-fontnik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/node-fontnik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/node-fontnik/teams","hooks_url":"https://api.github.com/repos/mapbox/node-fontnik/hooks","issue_events_url":"https://api.github.com/repos/mapbox/node-fontnik/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/node-fontnik/events","assignees_url":"https://api.github.com/repos/mapbox/node-fontnik/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/node-fontnik/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/node-fontnik/tags","blobs_url":"https://api.github.com/repos/mapbox/node-fontnik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/node-fontnik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/node-fontnik/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/node-fontnik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/node-fontnik/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/node-fontnik/languages","stargazers_url":"https://api.github.com/repos/mapbox/node-fontnik/stargazers","contributors_url":"https://api.github.com/repos/mapbox/node-fontnik/contributors","subscribers_url":"https://api.github.com/repos/mapbox/node-fontnik/subscribers","subscription_url":"https://api.github.com/repos/mapbox/node-fontnik/subscription","commits_url":"https://api.github.com/repos/mapbox/node-fontnik/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/node-fontnik/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/node-fontnik/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/node-fontnik/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/node-fontnik/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/node-fontnik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/node-fontnik/merges","archive_url":"https://api.github.com/repos/mapbox/node-fontnik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/node-fontnik/downloads","issues_url":"https://api.github.com/repos/mapbox/node-fontnik/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/node-fontnik/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/node-fontnik/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/node-fontnik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/node-fontnik/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/node-fontnik/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/node-fontnik/deployments","created_at":"2013-09-30T15:20:53Z","updated_at":"2018-04-26T15:08:17Z","pushed_at":"2018-06-27T20:50:56Z","git_url":"git://github.com/mapbox/node-fontnik.git","ssh_url":"git@github.com:mapbox/node-fontnik.git","clone_url":"https://github.com/mapbox/node-fontnik.git","svn_url":"https://github.com/mapbox/node-fontnik","homepage":"","size":31943,"stargazers_count":64,"watchers_count":64,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":28,"open_issues":22,"watchers":64,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"f327e89be3a4611090505211d336b46b732cda13","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":13218990,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIxODk5MA==","name":"node-fontnik","full_name":"mapbox/node-fontnik","owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/node-fontnik","description":"Fonts ⇢ protobuf-encoded SDF glyphs","fork":false,"url":"https://api.github.com/repos/mapbox/node-fontnik","forks_url":"https://api.github.com/repos/mapbox/node-fontnik/forks","keys_url":"https://api.github.com/repos/mapbox/node-fontnik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/node-fontnik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/node-fontnik/teams","hooks_url":"https://api.github.com/repos/mapbox/node-fontnik/hooks","issue_events_url":"https://api.github.com/repos/mapbox/node-fontnik/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/node-fontnik/events","assignees_url":"https://api.github.com/repos/mapbox/node-fontnik/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/node-fontnik/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/node-fontnik/tags","blobs_url":"https://api.github.com/repos/mapbox/node-fontnik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/node-fontnik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/node-fontnik/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/node-fontnik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/node-fontnik/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/node-fontnik/languages","stargazers_url":"https://api.github.com/repos/mapbox/node-fontnik/stargazers","contributors_url":"https://api.github.com/repos/mapbox/node-fontnik/contributors","subscribers_url":"https://api.github.com/repos/mapbox/node-fontnik/subscribers","subscription_url":"https://api.github.com/repos/mapbox/node-fontnik/subscription","commits_url":"https://api.github.com/repos/mapbox/node-fontnik/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/node-fontnik/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/node-fontnik/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/node-fontnik/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/node-fontnik/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/node-fontnik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/node-fontnik/merges","archive_url":"https://api.github.com/repos/mapbox/node-fontnik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/node-fontnik/downloads","issues_url":"https://api.github.com/repos/mapbox/node-fontnik/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/node-fontnik/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/node-fontnik/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/node-fontnik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/node-fontnik/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/node-fontnik/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/node-fontnik/deployments","created_at":"2013-09-30T15:20:53Z","updated_at":"2018-04-26T15:08:17Z","pushed_at":"2018-06-27T20:50:56Z","git_url":"git://github.com/mapbox/node-fontnik.git","ssh_url":"git@github.com:mapbox/node-fontnik.git","clone_url":"https://github.com/mapbox/node-fontnik.git","svn_url":"https://github.com/mapbox/node-fontnik","homepage":"","size":31943,"stargazers_count":64,"watchers_count":64,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":28,"open_issues":22,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/node-fontnik/pulls/144"},"html":{"href":"https://github.com/mapbox/node-fontnik/pull/144"},"issue":{"href":"https://api.github.com/repos/mapbox/node-fontnik/issues/144"},"comments":{"href":"https://api.github.com/repos/mapbox/node-fontnik/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/node-fontnik/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/node-fontnik/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/node-fontnik/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/node-fontnik/statuses/b082e4ce044c3bcab74b3e703d400061bd27e909"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"springmeyer","id":20300,"node_id":"MDQ6VXNlcjIwMzAw","avatar_url":"https://avatars1.githubusercontent.com/u/20300?v=4","gravatar_id":"","url":"https://api.github.com/users/springmeyer","html_url":"https://github.com/springmeyer","followers_url":"https://api.github.com/users/springmeyer/followers","following_url":"https://api.github.com/users/springmeyer/following{/other_user}","gists_url":"https://api.github.com/users/springmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/springmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springmeyer/subscriptions","organizations_url":"https://api.github.com/users/springmeyer/orgs","repos_url":"https://api.github.com/users/springmeyer/repos","events_url":"https://api.github.com/users/springmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/springmeyer/received_events","type":"User","site_admin":false},"comments":7,"review_comments":1,"maintainer_can_modify":false,"commits":18,"additions":672,"deletions":194,"changed_files":20}}
{"actor":{"display_login":"springmeyer"}}