{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/166980100","pull_request_review_id":95128046,"id":166980100,"diff_hunk":"@@ -39,6 +39,7 @@\n struct fi_tx_attr smr_tx_attr = {\n \t.caps = SMR_TX_CAPS,\n \t.comp_order = FI_ORDER_STRICT,\n+\t.msg_order = FI_ORDER_STRICT,","path":"prov/shm/src/smr_attr.c","position":4,"original_position":4,"commit_id":"81f0e11b6a7aaf116b753366bacc75e5c03f9f86","original_commit_id":"7364b1cb191b740ae846c20c981c095a23f30bd7","user":{"login":"aingerson","id":10183414,"avatar_url":"https://avatars0.githubusercontent.com/u/10183414?v=4","gravatar_id":"","url":"https://api.github.com/users/aingerson","html_url":"https://github.com/aingerson","followers_url":"https://api.github.com/users/aingerson/followers","following_url":"https://api.github.com/users/aingerson/following{/other_user}","gists_url":"https://api.github.com/users/aingerson/gists{/gist_id}","starred_url":"https://api.github.com/users/aingerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aingerson/subscriptions","organizations_url":"https://api.github.com/users/aingerson/orgs","repos_url":"https://api.github.com/users/aingerson/repos","events_url":"https://api.github.com/users/aingerson/events{/privacy}","received_events_url":"https://api.github.com/users/aingerson/received_events","type":"User","site_admin":false},"body":"Actually, as it is right now I think fast RMA results would still be seen in order because the peer region is locked during the fast RMA so no one else can post to the receiver side until the CMA is over. Not optimal though. One of the areas I'm looking into is how to avoid this region locking during the memcpy but I think we can still keep it in order since the sender still needs a spot in the command queue and claims that before doing the copy.","created_at":"2018-02-08T15:58:41Z","updated_at":"2018-02-08T15:58:41Z","html_url":"https://github.com/ofiwg/libfabric/pull/3786#discussion_r166980100","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/3786","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/166980100"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/3786#discussion_r166980100"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/3786"}},"in_reply_to_id":166781612},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/3786","id":167528620,"html_url":"https://github.com/ofiwg/libfabric/pull/3786","diff_url":"https://github.com/ofiwg/libfabric/pull/3786.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/3786.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/3786","number":3786,"state":"open","locked":false,"title":"prov/shm: set msg_order, mr mode, and complete with app context","user":{"login":"aingerson","id":10183414,"avatar_url":"https://avatars0.githubusercontent.com/u/10183414?v=4","gravatar_id":"","url":"https://api.github.com/users/aingerson","html_url":"https://github.com/aingerson","followers_url":"https://api.github.com/users/aingerson/followers","following_url":"https://api.github.com/users/aingerson/following{/other_user}","gists_url":"https://api.github.com/users/aingerson/gists{/gist_id}","starred_url":"https://api.github.com/users/aingerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aingerson/subscriptions","organizations_url":"https://api.github.com/users/aingerson/orgs","repos_url":"https://api.github.com/users/aingerson/repos","events_url":"https://api.github.com/users/aingerson/events{/privacy}","received_events_url":"https://api.github.com/users/aingerson/received_events","type":"User","site_admin":false},"body":"- set msg ordering to STRICT\r\n- set cmd->msg.hdr.msg_id as app's inputted context for large messages so the tx can complete with that context on progress_resp, rather than just completing with a NULL context\r\n- update MR mode to be backwards compatible with earlier versions of libfabric by adding FI_MR_SCALABLE\r\n- add ability to switch to using virtual addresses based on app input, enabling \"fast\" RMA operations\r\n\r\nSigned-off-by: aingerson <alexia.ingerson@intel.com>","created_at":"2018-02-06T21:03:58Z","updated_at":"2018-02-08T15:58:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2ab87ffdc30fb6127a1cf843d0ae8f876123597","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/3786/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/3786/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/3786/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/81f0e11b6a7aaf116b753366bacc75e5c03f9f86","head":{"label":"aingerson:shm_upstream","ref":"shm_upstream","sha":"81f0e11b6a7aaf116b753366bacc75e5c03f9f86","user":{"login":"aingerson","id":10183414,"avatar_url":"https://avatars0.githubusercontent.com/u/10183414?v=4","gravatar_id":"","url":"https://api.github.com/users/aingerson","html_url":"https://github.com/aingerson","followers_url":"https://api.github.com/users/aingerson/followers","following_url":"https://api.github.com/users/aingerson/following{/other_user}","gists_url":"https://api.github.com/users/aingerson/gists{/gist_id}","starred_url":"https://api.github.com/users/aingerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aingerson/subscriptions","organizations_url":"https://api.github.com/users/aingerson/orgs","repos_url":"https://api.github.com/users/aingerson/repos","events_url":"https://api.github.com/users/aingerson/events{/privacy}","received_events_url":"https://api.github.com/users/aingerson/received_events","type":"User","site_admin":false},"repo":{"id":76907140,"name":"libfabric","full_name":"aingerson/libfabric","owner":{"login":"aingerson","id":10183414,"avatar_url":"https://avatars0.githubusercontent.com/u/10183414?v=4","gravatar_id":"","url":"https://api.github.com/users/aingerson","html_url":"https://github.com/aingerson","followers_url":"https://api.github.com/users/aingerson/followers","following_url":"https://api.github.com/users/aingerson/following{/other_user}","gists_url":"https://api.github.com/users/aingerson/gists{/gist_id}","starred_url":"https://api.github.com/users/aingerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aingerson/subscriptions","organizations_url":"https://api.github.com/users/aingerson/orgs","repos_url":"https://api.github.com/users/aingerson/repos","events_url":"https://api.github.com/users/aingerson/events{/privacy}","received_events_url":"https://api.github.com/users/aingerson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aingerson/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/aingerson/libfabric","forks_url":"https://api.github.com/repos/aingerson/libfabric/forks","keys_url":"https://api.github.com/repos/aingerson/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aingerson/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aingerson/libfabric/teams","hooks_url":"https://api.github.com/repos/aingerson/libfabric/hooks","issue_events_url":"https://api.github.com/repos/aingerson/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/aingerson/libfabric/events","assignees_url":"https://api.github.com/repos/aingerson/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/aingerson/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/aingerson/libfabric/tags","blobs_url":"https://api.github.com/repos/aingerson/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aingerson/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aingerson/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/aingerson/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aingerson/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/aingerson/libfabric/languages","stargazers_url":"https://api.github.com/repos/aingerson/libfabric/stargazers","contributors_url":"https://api.github.com/repos/aingerson/libfabric/contributors","subscribers_url":"https://api.github.com/repos/aingerson/libfabric/subscribers","subscription_url":"https://api.github.com/repos/aingerson/libfabric/subscription","commits_url":"https://api.github.com/repos/aingerson/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/aingerson/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/aingerson/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/aingerson/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/aingerson/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/aingerson/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aingerson/libfabric/merges","archive_url":"https://api.github.com/repos/aingerson/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aingerson/libfabric/downloads","issues_url":"https://api.github.com/repos/aingerson/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/aingerson/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/aingerson/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/aingerson/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aingerson/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/aingerson/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/aingerson/libfabric/deployments","created_at":"2016-12-20T00:01:28Z","updated_at":"2016-12-20T00:01:34Z","pushed_at":"2018-02-07T21:19:58Z","git_url":"git://github.com/aingerson/libfabric.git","ssh_url":"git@github.com:aingerson/libfabric.git","clone_url":"https://github.com/aingerson/libfabric.git","svn_url":"https://github.com/aingerson/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":16771,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"3b9d95e5028280629b3e0ed0b49b63d353236708","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/ofiwg/libfabric/deployments","created_at":"2014-08-15T16:45:53Z","updated_at":"2018-02-07T22:02:20Z","pushed_at":"2018-02-08T15:43:00Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://libfabric.org/","size":17109,"stargazers_count":138,"watchers_count":138,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":125,"open_issues":110,"watchers":138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/3786"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/3786"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/3786"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/3786/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/3786/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/3786/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/81f0e11b6a7aaf116b753366bacc75e5c03f9f86"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aingerson"}}