{"action":"created","comment":{"url":"https://api.github.com/repos/mathjax/mathjax-v3/pulls/comments/225540328","pull_request_review_id":165160085,"id":225540328,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTU0MDMyOA==","diff_hunk":"@@ -0,0 +1,1625 @@\n+/*************************************************************\n+ *\n+ *  Copyright (c) 2017 The MathJax Consortium\n+ *\n+ *  Licensed under the Apache License, Version 2.0 (the \"License\");\n+ *  you may not use this file except in compliance with the License.\n+ *  You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ *  Unless required by applicable law or agreed to in writing, software\n+ *  distributed under the License is distributed on an \"AS IS\" BASIS,\n+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ *  See the License for the specific language governing permissions and\n+ *  limitations under the License.\n+ */\n+\n+\n+/**\n+ * @fileoverview The Basic Parse methods.\n+ *\n+ * @author v.sorge@mathjax.org (Volker Sorge)\n+ */\n+\n+import * as sitem from './BaseItems.js';\n+import {StackItem, EnvList} from '../StackItem.js';\n+import {Symbol, Macro} from '../Symbol.js';\n+import {ParseMethod} from '../Types.js';\n+import NodeUtil from '../NodeUtil.js';\n+import TexError from '../TexError.js';\n+import TexParser from '../TexParser.js';\n+import {TexConstant} from '../TexConstants.js';\n+import ParseUtil from '../ParseUtil.js';\n+import {MmlNode, TEXCLASS} from '../../../core/MmlTree/MmlNode.js';\n+import {MmlMsubsup} from '../../../core/MmlTree/MmlNodes/msubsup.js';\n+import {MmlMunderover} from '../../../core/MmlTree/MmlNodes/munderover.js';\n+import {MmlMo} from '../../../core/MmlTree/MmlNodes/mo.js';\n+import {Label} from '../Tags.js';\n+\n+\n+// Namespace\n+let BaseMethods: Record<string, ParseMethod> = {};\n+\n+// TODO: Once we can properly load AllEntities, there should be no need for\n+//       those anymore.","path":"mathjax3-ts/input/tex/base/BaseMethods.ts","position":45,"original_position":45,"commit_id":"51cca744180330c3dd97ccad502175544423f3b8","original_commit_id":"ad323ebd20e4bf3e098b4af763386ccc463b61d2","user":{"login":"zorkow","id":5717215,"node_id":"MDQ6VXNlcjU3MTcyMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5717215?v=4","gravatar_id":"","url":"https://api.github.com/users/zorkow","html_url":"https://github.com/zorkow","followers_url":"https://api.github.com/users/zorkow/followers","following_url":"https://api.github.com/users/zorkow/following{/other_user}","gists_url":"https://api.github.com/users/zorkow/gists{/gist_id}","starred_url":"https://api.github.com/users/zorkow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zorkow/subscriptions","organizations_url":"https://api.github.com/users/zorkow/orgs","repos_url":"https://api.github.com/users/zorkow/repos","events_url":"https://api.github.com/users/zorkow/events{/privacy}","received_events_url":"https://api.github.com/users/zorkow/received_events","type":"User","site_admin":false},"body":"Yes, but when I use `Entities.ENTITIES.nbsp` for example it is undefined. So I still need to create it but there will only ever be one copy. In other words it's a singleton, correct?","created_at":"2018-10-16T13:32:31Z","updated_at":"2018-10-16T13:32:31Z","html_url":"https://github.com/mathjax/mathjax-v3/pull/116#discussion_r225540328","pull_request_url":"https://api.github.com/repos/mathjax/mathjax-v3/pulls/116","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mathjax/mathjax-v3/pulls/comments/225540328"},"html":{"href":"https://github.com/mathjax/mathjax-v3/pull/116#discussion_r225540328"},"pull_request":{"href":"https://api.github.com/repos/mathjax/mathjax-v3/pulls/116"}},"in_reply_to_id":224490461},"pull_request":{"url":"https://api.github.com/repos/mathjax/mathjax-v3/pulls/116","id":188286333,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4Mjg2MzMz","html_url":"https://github.com/mathjax/mathjax-v3/pull/116","diff_url":"https://github.com/mathjax/mathjax-v3/pull/116.diff","patch_url":"https://github.com/mathjax/mathjax-v3/pull/116.patch","issue_url":"https://api.github.com/repos/mathjax/mathjax-v3/issues/116","number":116,"state":"open","locked":false,"title":"Tex input typescript","user":{"login":"zorkow","id":5717215,"node_id":"MDQ6VXNlcjU3MTcyMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5717215?v=4","gravatar_id":"","url":"https://api.github.com/users/zorkow","html_url":"https://github.com/zorkow","followers_url":"https://api.github.com/users/zorkow/followers","following_url":"https://api.github.com/users/zorkow/following{/other_user}","gists_url":"https://api.github.com/users/zorkow/gists{/gist_id}","starred_url":"https://api.github.com/users/zorkow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zorkow/subscriptions","organizations_url":"https://api.github.com/users/zorkow/orgs","repos_url":"https://api.github.com/users/zorkow/repos","events_url":"https://api.github.com/users/zorkow/events{/privacy}","received_events_url":"https://api.github.com/users/zorkow/received_events","type":"User","site_admin":false},"body":"This is the big one! I will write more detailed description of that later.","created_at":"2018-05-15T23:56:28Z","updated_at":"2018-10-16T13:32:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51617fd47604a299fe0cef2969b5333beccd15fe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mathjax/mathjax-v3/pulls/116/commits","review_comments_url":"https://api.github.com/repos/mathjax/mathjax-v3/pulls/116/comments","review_comment_url":"https://api.github.com/repos/mathjax/mathjax-v3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mathjax/mathjax-v3/issues/116/comments","statuses_url":"https://api.github.com/repos/mathjax/mathjax-v3/statuses/51cca744180330c3dd97ccad502175544423f3b8","head":{"label":"mathjax:tex_input_typescript","ref":"tex_input_typescript","sha":"51cca744180330c3dd97ccad502175544423f3b8","user":{"login":"mathjax","id":252187,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjE4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/252187?v=4","gravatar_id":"","url":"https://api.github.com/users/mathjax","html_url":"https://github.com/mathjax","followers_url":"https://api.github.com/users/mathjax/followers","following_url":"https://api.github.com/users/mathjax/following{/other_user}","gists_url":"https://api.github.com/users/mathjax/gists{/gist_id}","starred_url":"https://api.github.com/users/mathjax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathjax/subscriptions","organizations_url":"https://api.github.com/users/mathjax/orgs","repos_url":"https://api.github.com/users/mathjax/repos","events_url":"https://api.github.com/users/mathjax/events{/privacy}","received_events_url":"https://api.github.com/users/mathjax/received_events","type":"Organization","site_admin":false},"repo":{"id":52348698,"node_id":"MDEwOlJlcG9zaXRvcnk1MjM0ODY5OA==","name":"mathjax-v3","full_name":"mathjax/mathjax-v3","private":false,"owner":{"login":"mathjax","id":252187,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjE4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/252187?v=4","gravatar_id":"","url":"https://api.github.com/users/mathjax","html_url":"https://github.com/mathjax","followers_url":"https://api.github.com/users/mathjax/followers","following_url":"https://api.github.com/users/mathjax/following{/other_user}","gists_url":"https://api.github.com/users/mathjax/gists{/gist_id}","starred_url":"https://api.github.com/users/mathjax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathjax/subscriptions","organizations_url":"https://api.github.com/users/mathjax/orgs","repos_url":"https://api.github.com/users/mathjax/repos","events_url":"https://api.github.com/users/mathjax/events{/privacy}","received_events_url":"https://api.github.com/users/mathjax/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mathjax/mathjax-v3","description":"A repository for early stages of MathJax v3 ","fork":false,"url":"https://api.github.com/repos/mathjax/mathjax-v3","forks_url":"https://api.github.com/repos/mathjax/mathjax-v3/forks","keys_url":"https://api.github.com/repos/mathjax/mathjax-v3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mathjax/mathjax-v3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mathjax/mathjax-v3/teams","hooks_url":"https://api.github.com/repos/mathjax/mathjax-v3/hooks","issue_events_url":"https://api.github.com/repos/mathjax/mathjax-v3/issues/events{/number}","events_url":"https://api.github.com/repos/mathjax/mathjax-v3/events","assignees_url":"https://api.github.com/repos/mathjax/mathjax-v3/assignees{/user}","branches_url":"https://api.github.com/repos/mathjax/mathjax-v3/branches{/branch}","tags_url":"https://api.github.com/repos/mathjax/mathjax-v3/tags","blobs_url":"https://api.github.com/repos/mathjax/mathjax-v3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mathjax/mathjax-v3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mathjax/mathjax-v3/git/refs{/sha}","trees_url":"https://api.github.com/repos/mathjax/mathjax-v3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mathjax/mathjax-v3/statuses/{sha}","languages_url":"https://api.github.com/repos/mathjax/mathjax-v3/languages","stargazers_url":"https://api.github.com/repos/mathjax/mathjax-v3/stargazers","contributors_url":"https://api.github.com/repos/mathjax/mathjax-v3/contributors","subscribers_url":"https://api.github.com/repos/mathjax/mathjax-v3/subscribers","subscription_url":"https://api.github.com/repos/mathjax/mathjax-v3/subscription","commits_url":"https://api.github.com/repos/mathjax/mathjax-v3/commits{/sha}","git_commits_url":"https://api.github.com/repos/mathjax/mathjax-v3/git/commits{/sha}","comments_url":"https://api.github.com/repos/mathjax/mathjax-v3/comments{/number}","issue_comment_url":"https://api.github.com/repos/mathjax/mathjax-v3/issues/comments{/number}","contents_url":"https://api.github.com/repos/mathjax/mathjax-v3/contents/{+path}","compare_url":"https://api.github.com/repos/mathjax/mathjax-v3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mathjax/mathjax-v3/merges","archive_url":"https://api.github.com/repos/mathjax/mathjax-v3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mathjax/mathjax-v3/downloads","issues_url":"https://api.github.com/repos/mathjax/mathjax-v3/issues{/number}","pulls_url":"https://api.github.com/repos/mathjax/mathjax-v3/pulls{/number}","milestones_url":"https://api.github.com/repos/mathjax/mathjax-v3/milestones{/number}","notifications_url":"https://api.github.com/repos/mathjax/mathjax-v3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mathjax/mathjax-v3/labels{/name}","releases_url":"https://api.github.com/repos/mathjax/mathjax-v3/releases{/id}","deployments_url":"https://api.github.com/repos/mathjax/mathjax-v3/deployments","created_at":"2016-02-23T09:52:03Z","updated_at":"2018-10-11T17:01:08Z","pushed_at":"2018-10-16T13:15:51Z","git_url":"git://github.com/mathjax/mathjax-v3.git","ssh_url":"git@github.com:mathjax/mathjax-v3.git","clone_url":"https://github.com/mathjax/mathjax-v3.git","svn_url":"https://github.com/mathjax/mathjax-v3","homepage":"","size":8814,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":33,"license":null,"forks":12,"open_issues":33,"watchers":47,"default_branch":"master"}},"base":{"label":"mathjax:master","ref":"master","sha":"c585c894a7802a81aebe6fcbeb54172fa266633d","user":{"login":"mathjax","id":252187,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjE4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/252187?v=4","gravatar_id":"","url":"https://api.github.com/users/mathjax","html_url":"https://github.com/mathjax","followers_url":"https://api.github.com/users/mathjax/followers","following_url":"https://api.github.com/users/mathjax/following{/other_user}","gists_url":"https://api.github.com/users/mathjax/gists{/gist_id}","starred_url":"https://api.github.com/users/mathjax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathjax/subscriptions","organizations_url":"https://api.github.com/users/mathjax/orgs","repos_url":"https://api.github.com/users/mathjax/repos","events_url":"https://api.github.com/users/mathjax/events{/privacy}","received_events_url":"https://api.github.com/users/mathjax/received_events","type":"Organization","site_admin":false},"repo":{"id":52348698,"node_id":"MDEwOlJlcG9zaXRvcnk1MjM0ODY5OA==","name":"mathjax-v3","full_name":"mathjax/mathjax-v3","private":false,"owner":{"login":"mathjax","id":252187,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjE4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/252187?v=4","gravatar_id":"","url":"https://api.github.com/users/mathjax","html_url":"https://github.com/mathjax","followers_url":"https://api.github.com/users/mathjax/followers","following_url":"https://api.github.com/users/mathjax/following{/other_user}","gists_url":"https://api.github.com/users/mathjax/gists{/gist_id}","starred_url":"https://api.github.com/users/mathjax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathjax/subscriptions","organizations_url":"https://api.github.com/users/mathjax/orgs","repos_url":"https://api.github.com/users/mathjax/repos","events_url":"https://api.github.com/users/mathjax/events{/privacy}","received_events_url":"https://api.github.com/users/mathjax/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mathjax/mathjax-v3","description":"A repository for early stages of MathJax v3 ","fork":false,"url":"https://api.github.com/repos/mathjax/mathjax-v3","forks_url":"https://api.github.com/repos/mathjax/mathjax-v3/forks","keys_url":"https://api.github.com/repos/mathjax/mathjax-v3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mathjax/mathjax-v3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mathjax/mathjax-v3/teams","hooks_url":"https://api.github.com/repos/mathjax/mathjax-v3/hooks","issue_events_url":"https://api.github.com/repos/mathjax/mathjax-v3/issues/events{/number}","events_url":"https://api.github.com/repos/mathjax/mathjax-v3/events","assignees_url":"https://api.github.com/repos/mathjax/mathjax-v3/assignees{/user}","branches_url":"https://api.github.com/repos/mathjax/mathjax-v3/branches{/branch}","tags_url":"https://api.github.com/repos/mathjax/mathjax-v3/tags","blobs_url":"https://api.github.com/repos/mathjax/mathjax-v3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mathjax/mathjax-v3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mathjax/mathjax-v3/git/refs{/sha}","trees_url":"https://api.github.com/repos/mathjax/mathjax-v3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mathjax/mathjax-v3/statuses/{sha}","languages_url":"https://api.github.com/repos/mathjax/mathjax-v3/languages","stargazers_url":"https://api.github.com/repos/mathjax/mathjax-v3/stargazers","contributors_url":"https://api.github.com/repos/mathjax/mathjax-v3/contributors","subscribers_url":"https://api.github.com/repos/mathjax/mathjax-v3/subscribers","subscription_url":"https://api.github.com/repos/mathjax/mathjax-v3/subscription","commits_url":"https://api.github.com/repos/mathjax/mathjax-v3/commits{/sha}","git_commits_url":"https://api.github.com/repos/mathjax/mathjax-v3/git/commits{/sha}","comments_url":"https://api.github.com/repos/mathjax/mathjax-v3/comments{/number}","issue_comment_url":"https://api.github.com/repos/mathjax/mathjax-v3/issues/comments{/number}","contents_url":"https://api.github.com/repos/mathjax/mathjax-v3/contents/{+path}","compare_url":"https://api.github.com/repos/mathjax/mathjax-v3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mathjax/mathjax-v3/merges","archive_url":"https://api.github.com/repos/mathjax/mathjax-v3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mathjax/mathjax-v3/downloads","issues_url":"https://api.github.com/repos/mathjax/mathjax-v3/issues{/number}","pulls_url":"https://api.github.com/repos/mathjax/mathjax-v3/pulls{/number}","milestones_url":"https://api.github.com/repos/mathjax/mathjax-v3/milestones{/number}","notifications_url":"https://api.github.com/repos/mathjax/mathjax-v3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mathjax/mathjax-v3/labels{/name}","releases_url":"https://api.github.com/repos/mathjax/mathjax-v3/releases{/id}","deployments_url":"https://api.github.com/repos/mathjax/mathjax-v3/deployments","created_at":"2016-02-23T09:52:03Z","updated_at":"2018-10-11T17:01:08Z","pushed_at":"2018-10-16T13:15:51Z","git_url":"git://github.com/mathjax/mathjax-v3.git","ssh_url":"git@github.com:mathjax/mathjax-v3.git","clone_url":"https://github.com/mathjax/mathjax-v3.git","svn_url":"https://github.com/mathjax/mathjax-v3","homepage":"","size":8814,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":33,"license":null,"forks":12,"open_issues":33,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mathjax/mathjax-v3/pulls/116"},"html":{"href":"https://github.com/mathjax/mathjax-v3/pull/116"},"issue":{"href":"https://api.github.com/repos/mathjax/mathjax-v3/issues/116"},"comments":{"href":"https://api.github.com/repos/mathjax/mathjax-v3/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/mathjax/mathjax-v3/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/mathjax/mathjax-v3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mathjax/mathjax-v3/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/mathjax/mathjax-v3/statuses/51cca744180330c3dd97ccad502175544423f3b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zorkow"}}