{"action":"created","issue":{"url":"https://api.github.com/repos/Coursemology/coursemology2/issues/2999","repository_url":"https://api.github.com/repos/Coursemology/coursemology2","labels_url":"https://api.github.com/repos/Coursemology/coursemology2/issues/2999/labels{/name}","comments_url":"https://api.github.com/repos/Coursemology/coursemology2/issues/2999/comments","events_url":"https://api.github.com/repos/Coursemology/coursemology2/issues/2999/events","html_url":"https://github.com/Coursemology/coursemology2/pull/2999","id":340579448,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwOTU2MDI0","number":2999,"title":"Associate Skills with QuestionAssessments instead of Question","user":{"login":"fonglh","id":1902527,"node_id":"MDQ6VXNlcjE5MDI1Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1902527?v=4","gravatar_id":"","url":"https://api.github.com/users/fonglh","html_url":"https://github.com/fonglh","followers_url":"https://api.github.com/users/fonglh/followers","following_url":"https://api.github.com/users/fonglh/following{/other_user}","gists_url":"https://api.github.com/users/fonglh/gists{/gist_id}","starred_url":"https://api.github.com/users/fonglh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fonglh/subscriptions","organizations_url":"https://api.github.com/users/fonglh/orgs","repos_url":"https://api.github.com/users/fonglh/repos","events_url":"https://api.github.com/users/fonglh/events{/privacy}","received_events_url":"https://api.github.com/users/fonglh/received_events","type":"User","site_admin":false},"labels":[{"id":428708484,"node_id":"MDU6TGFiZWw0Mjg3MDg0ODQ=","url":"https://api.github.com/repos/Coursemology/coursemology2/labels/needs%20review","name":"needs review","color":"e6e6e6","default":false}],"state":"open","locked":false,"assignee":{"login":"fonglh","id":1902527,"node_id":"MDQ6VXNlcjE5MDI1Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1902527?v=4","gravatar_id":"","url":"https://api.github.com/users/fonglh","html_url":"https://github.com/fonglh","followers_url":"https://api.github.com/users/fonglh/followers","following_url":"https://api.github.com/users/fonglh/following{/other_user}","gists_url":"https://api.github.com/users/fonglh/gists{/gist_id}","starred_url":"https://api.github.com/users/fonglh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fonglh/subscriptions","organizations_url":"https://api.github.com/users/fonglh/orgs","repos_url":"https://api.github.com/users/fonglh/repos","events_url":"https://api.github.com/users/fonglh/events{/privacy}","received_events_url":"https://api.github.com/users/fonglh/received_events","type":"User","site_admin":false},"assignees":[{"login":"fonglh","id":1902527,"node_id":"MDQ6VXNlcjE5MDI1Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1902527?v=4","gravatar_id":"","url":"https://api.github.com/users/fonglh","html_url":"https://github.com/fonglh","followers_url":"https://api.github.com/users/fonglh/followers","following_url":"https://api.github.com/users/fonglh/following{/other_user}","gists_url":"https://api.github.com/users/fonglh/gists{/gist_id}","starred_url":"https://api.github.com/users/fonglh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fonglh/subscriptions","organizations_url":"https://api.github.com/users/fonglh/orgs","repos_url":"https://api.github.com/users/fonglh/repos","events_url":"https://api.github.com/users/fonglh/events{/privacy}","received_events_url":"https://api.github.com/users/fonglh/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-07-12T10:27:09Z","updated_at":"2018-07-24T03:03:32Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Coursemology/coursemology2/pulls/2999","html_url":"https://github.com/Coursemology/coursemology2/pull/2999","diff_url":"https://github.com/Coursemology/coursemology2/pull/2999.diff","patch_url":"https://github.com/Coursemology/coursemology2/pull/2999.patch"},"body":"With `QuestionAssessments`, a single question can belong to multiple assessments, even those from different courses. Another course might not have the same Skills, so it no longer makes sense for Skills to be associated with Questions.\r\n\r\nThis PR:\r\n\r\n1. Creates a new association table for skills and question_assessments and migrates the existing data over.\r\n2. Modify the various question type forms so they correctly assign Skills through the QuestionAssessment.\r\n3. Move the Duplication logic so Skills are duplicated through QuestionAssessments.\r\n4. Fix the question cherry picking duplication so Skills are copied from and to QuestionAssessments.\r\n\r\n- [x] Check that assessment duplication to a different course with a different Skill structure does NOT duplicate the skills. EDIT: Assessment duplication to a different course does not duplicate the skills at all."},"comment":{"url":"https://api.github.com/repos/Coursemology/coursemology2/issues/comments/407265387","html_url":"https://github.com/Coursemology/coursemology2/pull/2999#issuecomment-407265387","issue_url":"https://api.github.com/repos/Coursemology/coursemology2/issues/2999","id":407265387,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzI2NTM4Nw==","user":{"login":"fonglh","id":1902527,"node_id":"MDQ6VXNlcjE5MDI1Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1902527?v=4","gravatar_id":"","url":"https://api.github.com/users/fonglh","html_url":"https://github.com/fonglh","followers_url":"https://api.github.com/users/fonglh/followers","following_url":"https://api.github.com/users/fonglh/following{/other_user}","gists_url":"https://api.github.com/users/fonglh/gists{/gist_id}","starred_url":"https://api.github.com/users/fonglh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fonglh/subscriptions","organizations_url":"https://api.github.com/users/fonglh/orgs","repos_url":"https://api.github.com/users/fonglh/repos","events_url":"https://api.github.com/users/fonglh/events{/privacy}","received_events_url":"https://api.github.com/users/fonglh/received_events","type":"User","site_admin":false},"created_at":"2018-07-24T03:03:32Z","updated_at":"2018-07-24T03:03:32Z","author_association":"MEMBER","body":"Changing the controller from the inheritance hierarchy from `Question` to `QuestionAssessment` turned out to be hugely complex. #3017 has been created to track that instead.\r\n\r\nI think we should merge this first so it doesn't hold up #2969 and continue working separately on #3017."}}
{"actor":{"display_login":"fonglh"}}