{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/jpclark6/date-night/pulls/1","id":225104771,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MTA0Nzcx","html_url":"https://github.com/jpclark6/date-night/pull/1","diff_url":"https://github.com/jpclark6/date-night/pull/1.diff","patch_url":"https://github.com/jpclark6/date-night/pull/1.patch","issue_url":"https://api.github.com/repos/jpclark6/date-night/issues/1","number":1,"state":"open","locked":false,"title":"General Notes","user":{"login":"memcmahon","id":32604200,"node_id":"MDQ6VXNlcjMyNjA0MjAw","avatar_url":"https://avatars1.githubusercontent.com/u/32604200?v=4","gravatar_id":"","url":"https://api.github.com/users/memcmahon","html_url":"https://github.com/memcmahon","followers_url":"https://api.github.com/users/memcmahon/followers","following_url":"https://api.github.com/users/memcmahon/following{/other_user}","gists_url":"https://api.github.com/users/memcmahon/gists{/gist_id}","starred_url":"https://api.github.com/users/memcmahon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memcmahon/subscriptions","organizations_url":"https://api.github.com/users/memcmahon/orgs","repos_url":"https://api.github.com/users/memcmahon/repos","events_url":"https://api.github.com/users/memcmahon/events{/privacy}","received_events_url":"https://api.github.com/users/memcmahon/received_events","type":"User","site_admin":false},"body":"I left some comments on your BinarySearchTree class, but here are the high-level notes:\r\n\r\n* This is a great project to practice recursion - many places where you are using a `while` or `until` loop could be refactored to use a recursive method call.  This is not _necessary_ but is a fun challenge 🤓 \r\n\r\n* Some longer methods really do need refactoring - especially the main methods like `insert`, `delete`, `sort`.  It would be nice to have these as CEO methods near the top of your class and the helper methods grouped toward the bottom.","created_at":"2018-10-23T16:23:24Z","updated_at":"2018-10-23T16:23:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jpclark6/date-night/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jpclark6/date-night/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jpclark6/date-night/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jpclark6/date-night/issues/1/comments","statuses_url":"https://api.github.com/repos/jpclark6/date-night/statuses/2536dfa7fe64d2d64ce33abfe1aea9b573c9ccd1","head":{"label":"jpclark6:megans_comments","ref":"megans_comments","sha":"2536dfa7fe64d2d64ce33abfe1aea9b573c9ccd1","user":{"login":"jpclark6","id":41842702,"node_id":"MDQ6VXNlcjQxODQyNzAy","avatar_url":"https://avatars0.githubusercontent.com/u/41842702?v=4","gravatar_id":"","url":"https://api.github.com/users/jpclark6","html_url":"https://github.com/jpclark6","followers_url":"https://api.github.com/users/jpclark6/followers","following_url":"https://api.github.com/users/jpclark6/following{/other_user}","gists_url":"https://api.github.com/users/jpclark6/gists{/gist_id}","starred_url":"https://api.github.com/users/jpclark6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpclark6/subscriptions","organizations_url":"https://api.github.com/users/jpclark6/orgs","repos_url":"https://api.github.com/users/jpclark6/repos","events_url":"https://api.github.com/users/jpclark6/events{/privacy}","received_events_url":"https://api.github.com/users/jpclark6/received_events","type":"User","site_admin":false},"repo":{"id":154235890,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQyMzU4OTA=","name":"date-night","full_name":"jpclark6/date-night","private":false,"owner":{"login":"jpclark6","id":41842702,"node_id":"MDQ6VXNlcjQxODQyNzAy","avatar_url":"https://avatars0.githubusercontent.com/u/41842702?v=4","gravatar_id":"","url":"https://api.github.com/users/jpclark6","html_url":"https://github.com/jpclark6","followers_url":"https://api.github.com/users/jpclark6/followers","following_url":"https://api.github.com/users/jpclark6/following{/other_user}","gists_url":"https://api.github.com/users/jpclark6/gists{/gist_id}","starred_url":"https://api.github.com/users/jpclark6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpclark6/subscriptions","organizations_url":"https://api.github.com/users/jpclark6/orgs","repos_url":"https://api.github.com/users/jpclark6/repos","events_url":"https://api.github.com/users/jpclark6/events{/privacy}","received_events_url":"https://api.github.com/users/jpclark6/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jpclark6/date-night","description":null,"fork":false,"url":"https://api.github.com/repos/jpclark6/date-night","forks_url":"https://api.github.com/repos/jpclark6/date-night/forks","keys_url":"https://api.github.com/repos/jpclark6/date-night/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpclark6/date-night/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpclark6/date-night/teams","hooks_url":"https://api.github.com/repos/jpclark6/date-night/hooks","issue_events_url":"https://api.github.com/repos/jpclark6/date-night/issues/events{/number}","events_url":"https://api.github.com/repos/jpclark6/date-night/events","assignees_url":"https://api.github.com/repos/jpclark6/date-night/assignees{/user}","branches_url":"https://api.github.com/repos/jpclark6/date-night/branches{/branch}","tags_url":"https://api.github.com/repos/jpclark6/date-night/tags","blobs_url":"https://api.github.com/repos/jpclark6/date-night/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpclark6/date-night/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpclark6/date-night/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpclark6/date-night/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpclark6/date-night/statuses/{sha}","languages_url":"https://api.github.com/repos/jpclark6/date-night/languages","stargazers_url":"https://api.github.com/repos/jpclark6/date-night/stargazers","contributors_url":"https://api.github.com/repos/jpclark6/date-night/contributors","subscribers_url":"https://api.github.com/repos/jpclark6/date-night/subscribers","subscription_url":"https://api.github.com/repos/jpclark6/date-night/subscription","commits_url":"https://api.github.com/repos/jpclark6/date-night/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpclark6/date-night/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpclark6/date-night/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpclark6/date-night/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpclark6/date-night/contents/{+path}","compare_url":"https://api.github.com/repos/jpclark6/date-night/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpclark6/date-night/merges","archive_url":"https://api.github.com/repos/jpclark6/date-night/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpclark6/date-night/downloads","issues_url":"https://api.github.com/repos/jpclark6/date-night/issues{/number}","pulls_url":"https://api.github.com/repos/jpclark6/date-night/pulls{/number}","milestones_url":"https://api.github.com/repos/jpclark6/date-night/milestones{/number}","notifications_url":"https://api.github.com/repos/jpclark6/date-night/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpclark6/date-night/labels{/name}","releases_url":"https://api.github.com/repos/jpclark6/date-night/releases{/id}","deployments_url":"https://api.github.com/repos/jpclark6/date-night/deployments","created_at":"2018-10-23T00:32:12Z","updated_at":"2018-10-23T00:33:48Z","pushed_at":"2018-10-23T16:19:20Z","git_url":"git://github.com/jpclark6/date-night.git","ssh_url":"git@github.com:jpclark6/date-night.git","clone_url":"https://github.com/jpclark6/date-night.git","svn_url":"https://github.com/jpclark6/date-night","homepage":null,"size":117,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"jpclark6:master","ref":"master","sha":"b5c7956d235fb985212bd95991bf4f3150d5f09d","user":{"login":"jpclark6","id":41842702,"node_id":"MDQ6VXNlcjQxODQyNzAy","avatar_url":"https://avatars0.githubusercontent.com/u/41842702?v=4","gravatar_id":"","url":"https://api.github.com/users/jpclark6","html_url":"https://github.com/jpclark6","followers_url":"https://api.github.com/users/jpclark6/followers","following_url":"https://api.github.com/users/jpclark6/following{/other_user}","gists_url":"https://api.github.com/users/jpclark6/gists{/gist_id}","starred_url":"https://api.github.com/users/jpclark6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpclark6/subscriptions","organizations_url":"https://api.github.com/users/jpclark6/orgs","repos_url":"https://api.github.com/users/jpclark6/repos","events_url":"https://api.github.com/users/jpclark6/events{/privacy}","received_events_url":"https://api.github.com/users/jpclark6/received_events","type":"User","site_admin":false},"repo":{"id":154235890,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQyMzU4OTA=","name":"date-night","full_name":"jpclark6/date-night","private":false,"owner":{"login":"jpclark6","id":41842702,"node_id":"MDQ6VXNlcjQxODQyNzAy","avatar_url":"https://avatars0.githubusercontent.com/u/41842702?v=4","gravatar_id":"","url":"https://api.github.com/users/jpclark6","html_url":"https://github.com/jpclark6","followers_url":"https://api.github.com/users/jpclark6/followers","following_url":"https://api.github.com/users/jpclark6/following{/other_user}","gists_url":"https://api.github.com/users/jpclark6/gists{/gist_id}","starred_url":"https://api.github.com/users/jpclark6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpclark6/subscriptions","organizations_url":"https://api.github.com/users/jpclark6/orgs","repos_url":"https://api.github.com/users/jpclark6/repos","events_url":"https://api.github.com/users/jpclark6/events{/privacy}","received_events_url":"https://api.github.com/users/jpclark6/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jpclark6/date-night","description":null,"fork":false,"url":"https://api.github.com/repos/jpclark6/date-night","forks_url":"https://api.github.com/repos/jpclark6/date-night/forks","keys_url":"https://api.github.com/repos/jpclark6/date-night/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpclark6/date-night/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpclark6/date-night/teams","hooks_url":"https://api.github.com/repos/jpclark6/date-night/hooks","issue_events_url":"https://api.github.com/repos/jpclark6/date-night/issues/events{/number}","events_url":"https://api.github.com/repos/jpclark6/date-night/events","assignees_url":"https://api.github.com/repos/jpclark6/date-night/assignees{/user}","branches_url":"https://api.github.com/repos/jpclark6/date-night/branches{/branch}","tags_url":"https://api.github.com/repos/jpclark6/date-night/tags","blobs_url":"https://api.github.com/repos/jpclark6/date-night/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpclark6/date-night/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpclark6/date-night/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpclark6/date-night/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpclark6/date-night/statuses/{sha}","languages_url":"https://api.github.com/repos/jpclark6/date-night/languages","stargazers_url":"https://api.github.com/repos/jpclark6/date-night/stargazers","contributors_url":"https://api.github.com/repos/jpclark6/date-night/contributors","subscribers_url":"https://api.github.com/repos/jpclark6/date-night/subscribers","subscription_url":"https://api.github.com/repos/jpclark6/date-night/subscription","commits_url":"https://api.github.com/repos/jpclark6/date-night/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpclark6/date-night/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpclark6/date-night/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpclark6/date-night/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpclark6/date-night/contents/{+path}","compare_url":"https://api.github.com/repos/jpclark6/date-night/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpclark6/date-night/merges","archive_url":"https://api.github.com/repos/jpclark6/date-night/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpclark6/date-night/downloads","issues_url":"https://api.github.com/repos/jpclark6/date-night/issues{/number}","pulls_url":"https://api.github.com/repos/jpclark6/date-night/pulls{/number}","milestones_url":"https://api.github.com/repos/jpclark6/date-night/milestones{/number}","notifications_url":"https://api.github.com/repos/jpclark6/date-night/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpclark6/date-night/labels{/name}","releases_url":"https://api.github.com/repos/jpclark6/date-night/releases{/id}","deployments_url":"https://api.github.com/repos/jpclark6/date-night/deployments","created_at":"2018-10-23T00:32:12Z","updated_at":"2018-10-23T00:33:48Z","pushed_at":"2018-10-23T16:19:20Z","git_url":"git://github.com/jpclark6/date-night.git","ssh_url":"git@github.com:jpclark6/date-night.git","clone_url":"https://github.com/jpclark6/date-night.git","svn_url":"https://github.com/jpclark6/date-night","homepage":null,"size":117,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jpclark6/date-night/pulls/1"},"html":{"href":"https://github.com/jpclark6/date-night/pull/1"},"issue":{"href":"https://api.github.com/repos/jpclark6/date-night/issues/1"},"comments":{"href":"https://api.github.com/repos/jpclark6/date-night/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jpclark6/date-night/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jpclark6/date-night/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jpclark6/date-night/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jpclark6/date-night/statuses/2536dfa7fe64d2d64ce33abfe1aea9b573c9ccd1"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":450,"deletions":203,"changed_files":5}}
{"actor":{"display_login":"memcmahon"}}