{"action":"closed","number":766,"pull_request":{"url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/pulls/766","id":238933917,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTMzOTE3","html_url":"https://github.com/ArkEcosystem/desktop-wallet/pull/766","diff_url":"https://github.com/ArkEcosystem/desktop-wallet/pull/766.diff","patch_url":"https://github.com/ArkEcosystem/desktop-wallet/pull/766.patch","issue_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/766","number":766,"state":"closed","locked":false,"title":" fix: include fee in second signature builder","user":{"login":"dated","id":6547002,"node_id":"MDQ6VXNlcjY1NDcwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6547002?v=4","gravatar_id":"","url":"https://api.github.com/users/dated","html_url":"https://github.com/dated","followers_url":"https://api.github.com/users/dated/followers","following_url":"https://api.github.com/users/dated/following{/other_user}","gists_url":"https://api.github.com/users/dated/gists{/gist_id}","starred_url":"https://api.github.com/users/dated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dated/subscriptions","organizations_url":"https://api.github.com/users/dated/orgs","repos_url":"https://api.github.com/users/dated/repos","events_url":"https://api.github.com/users/dated/events{/privacy}","received_events_url":"https://api.github.com/users/dated/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n<!--\r\nDescribe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.\r\n-->\r\n\r\nThe fee was not being added to the transaction in `buildSecondSignatureRegistration`. Fixes #764.\r\n\r\nAlso replaces occurrences of `Math.pow(10, 8)` and `Math.pow(10, -8)` with the the respective e notation.\r\n\r\n## Types of changes\r\n<!--\r\nWhat types of changes does your code introduce?\r\n_Put an `x` in the boxes that apply and remove the rest of them: keep this PR as concise, but descriptive, as possible.._\r\n-->\r\n\r\n- [x] Bugfix (non-breaking change which fixes an issue)\r\n- [x] Refactoring (improve a current implementation without adding a new feature or fixing a bug)\r\n\r\n## Checklist\r\n<!--\r\n_Put an `x` in the boxes that apply and remove this text and the rest of them. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._\r\n-->\r\n\r\n- [x] I have read the [CONTRIBUTING](https://docs.ark.io/guidebook/contribution-guidelines/contributing.html) documentation\r\n- [x] Lint and unit tests pass locally with my changes","created_at":"2018-12-15T21:42:35Z","updated_at":"2018-12-16T10:34:35Z","closed_at":"2018-12-16T10:34:35Z","merged_at":"2018-12-16T10:34:35Z","merge_commit_sha":"d423f7a3bab3e7728838a7adf04c5b25ce69e444","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/pulls/766/commits","review_comments_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/pulls/766/comments","review_comment_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/766/comments","statuses_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/statuses/37c733dc846a3110cfb87be4e5b60f04e5ddfeba","head":{"label":"dated:2nd-signature-fee","ref":"2nd-signature-fee","sha":"37c733dc846a3110cfb87be4e5b60f04e5ddfeba","user":{"login":"dated","id":6547002,"node_id":"MDQ6VXNlcjY1NDcwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6547002?v=4","gravatar_id":"","url":"https://api.github.com/users/dated","html_url":"https://github.com/dated","followers_url":"https://api.github.com/users/dated/followers","following_url":"https://api.github.com/users/dated/following{/other_user}","gists_url":"https://api.github.com/users/dated/gists{/gist_id}","starred_url":"https://api.github.com/users/dated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dated/subscriptions","organizations_url":"https://api.github.com/users/dated/orgs","repos_url":"https://api.github.com/users/dated/repos","events_url":"https://api.github.com/users/dated/events{/privacy}","received_events_url":"https://api.github.com/users/dated/received_events","type":"User","site_admin":false},"repo":{"id":160314360,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAzMTQzNjA=","name":"desktop-wallet","full_name":"dated/desktop-wallet","private":false,"owner":{"login":"dated","id":6547002,"node_id":"MDQ6VXNlcjY1NDcwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6547002?v=4","gravatar_id":"","url":"https://api.github.com/users/dated","html_url":"https://github.com/dated","followers_url":"https://api.github.com/users/dated/followers","following_url":"https://api.github.com/users/dated/following{/other_user}","gists_url":"https://api.github.com/users/dated/gists{/gist_id}","starred_url":"https://api.github.com/users/dated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dated/subscriptions","organizations_url":"https://api.github.com/users/dated/orgs","repos_url":"https://api.github.com/users/dated/repos","events_url":"https://api.github.com/users/dated/events{/privacy}","received_events_url":"https://api.github.com/users/dated/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dated/desktop-wallet","description":":computer: Multi Platform ARK Desktop Wallet","fork":true,"url":"https://api.github.com/repos/dated/desktop-wallet","forks_url":"https://api.github.com/repos/dated/desktop-wallet/forks","keys_url":"https://api.github.com/repos/dated/desktop-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dated/desktop-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dated/desktop-wallet/teams","hooks_url":"https://api.github.com/repos/dated/desktop-wallet/hooks","issue_events_url":"https://api.github.com/repos/dated/desktop-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/dated/desktop-wallet/events","assignees_url":"https://api.github.com/repos/dated/desktop-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/dated/desktop-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/dated/desktop-wallet/tags","blobs_url":"https://api.github.com/repos/dated/desktop-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dated/desktop-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dated/desktop-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dated/desktop-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dated/desktop-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/dated/desktop-wallet/languages","stargazers_url":"https://api.github.com/repos/dated/desktop-wallet/stargazers","contributors_url":"https://api.github.com/repos/dated/desktop-wallet/contributors","subscribers_url":"https://api.github.com/repos/dated/desktop-wallet/subscribers","subscription_url":"https://api.github.com/repos/dated/desktop-wallet/subscription","commits_url":"https://api.github.com/repos/dated/desktop-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dated/desktop-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dated/desktop-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dated/desktop-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dated/desktop-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/dated/desktop-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dated/desktop-wallet/merges","archive_url":"https://api.github.com/repos/dated/desktop-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dated/desktop-wallet/downloads","issues_url":"https://api.github.com/repos/dated/desktop-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/dated/desktop-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/dated/desktop-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/dated/desktop-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dated/desktop-wallet/labels{/name}","releases_url":"https://api.github.com/repos/dated/desktop-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/dated/desktop-wallet/deployments","created_at":"2018-12-04T07:08:41Z","updated_at":"2018-12-14T19:10:15Z","pushed_at":"2018-12-16T10:27:59Z","git_url":"git://github.com/dated/desktop-wallet.git","ssh_url":"git@github.com:dated/desktop-wallet.git","clone_url":"https://github.com/dated/desktop-wallet.git","svn_url":"https://github.com/dated/desktop-wallet","homepage":"","size":20453,"stargazers_count":0,"watchers_count":0,"language":"Vue","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ArkEcosystem:develop","ref":"develop","sha":"f13ed131bf413ce4d6714a118ced372f9aa6a9fd","user":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":73618120,"node_id":"MDEwOlJlcG9zaXRvcnk3MzYxODEyMA==","name":"desktop-wallet","full_name":"ArkEcosystem/desktop-wallet","private":false,"owner":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArkEcosystem/desktop-wallet","description":":computer: Multi Platform ARK Desktop Wallet","fork":false,"url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet","forks_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/forks","keys_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/teams","hooks_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/hooks","issue_events_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/events","assignees_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/tags","blobs_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/languages","stargazers_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/stargazers","contributors_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/contributors","subscribers_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/subscribers","subscription_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/subscription","commits_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/merges","archive_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/downloads","issues_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/labels{/name}","releases_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/deployments","created_at":"2016-11-13T13:39:11Z","updated_at":"2018-12-16T10:27:50Z","pushed_at":"2018-12-16T10:34:34Z","git_url":"git://github.com/ArkEcosystem/desktop-wallet.git","ssh_url":"git@github.com:ArkEcosystem/desktop-wallet.git","clone_url":"https://github.com/ArkEcosystem/desktop-wallet.git","svn_url":"https://github.com/ArkEcosystem/desktop-wallet","homepage":"","size":20482,"stargazers_count":227,"watchers_count":227,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":163,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":163,"open_issues":28,"watchers":227,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/pulls/766"},"html":{"href":"https://github.com/ArkEcosystem/desktop-wallet/pull/766"},"issue":{"href":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/766"},"comments":{"href":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/766/comments"},"review_comments":{"href":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/pulls/766/comments"},"review_comment":{"href":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/pulls/766/commits"},"statuses":{"href":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/statuses/37c733dc846a3110cfb87be4e5b60f04e5ddfeba"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"faustbrian","id":22145591,"node_id":"MDQ6VXNlcjIyMTQ1NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/22145591?v=4","gravatar_id":"","url":"https://api.github.com/users/faustbrian","html_url":"https://github.com/faustbrian","followers_url":"https://api.github.com/users/faustbrian/followers","following_url":"https://api.github.com/users/faustbrian/following{/other_user}","gists_url":"https://api.github.com/users/faustbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/faustbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faustbrian/subscriptions","organizations_url":"https://api.github.com/users/faustbrian/orgs","repos_url":"https://api.github.com/users/faustbrian/repos","events_url":"https://api.github.com/users/faustbrian/events{/privacy}","received_events_url":"https://api.github.com/users/faustbrian/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":40,"deletions":39,"changed_files":7}}
{"actor":{"display_login":"faustbrian"}}