{"action":"created","comment":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/comments/224057990","pull_request_review_id":163331862,"id":224057990,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDA1Nzk5MA==","diff_hunk":"@@ -276,23 +293,43 @@ func (store *imageStore) RemoveReference(id digest.Digest, ref reference.Named)\n \treturn nil\n }\n \n-// RemoveAllReferences removes all the reference by the given imageID.\n-func (store *imageStore) RemoveAllReferences(id digest.Digest) error {\n+// ListCtrdImageInfo returns all the CtrdImageInfo.\n+func (store *imageStore) ListCtrdImageInfo() []CtrdImageInfo {","path":"daemon/mgr/image_store.go","position":49,"original_position":49,"commit_id":"24dbb79767ff5c35315b652e2b310bf58d97761a","original_commit_id":"24dbb79767ff5c35315b652e2b310bf58d97761a","user":{"login":"HusterWan","id":10414039,"node_id":"MDQ6VXNlcjEwNDE0MDM5","avatar_url":"https://avatars3.githubusercontent.com/u/10414039?v=4","gravatar_id":"","url":"https://api.github.com/users/HusterWan","html_url":"https://github.com/HusterWan","followers_url":"https://api.github.com/users/HusterWan/followers","following_url":"https://api.github.com/users/HusterWan/following{/other_user}","gists_url":"https://api.github.com/users/HusterWan/gists{/gist_id}","starred_url":"https://api.github.com/users/HusterWan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HusterWan/subscriptions","organizations_url":"https://api.github.com/users/HusterWan/orgs","repos_url":"https://api.github.com/users/HusterWan/repos","events_url":"https://api.github.com/users/HusterWan/events{/privacy}","received_events_url":"https://api.github.com/users/HusterWan/received_events","type":"User","site_admin":false},"body":"support filter later?","created_at":"2018-10-10T12:40:07Z","updated_at":"2018-10-10T12:40:07Z","html_url":"https://github.com/alibaba/pouch/pull/2301#discussion_r224057990","pull_request_url":"https://api.github.com/repos/alibaba/pouch/pulls/2301","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/comments/224057990"},"html":{"href":"https://github.com/alibaba/pouch/pull/2301#discussion_r224057990"},"pull_request":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/2301"}}},"pull_request":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/2301","id":221309845,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMzA5ODQ1","html_url":"https://github.com/alibaba/pouch/pull/2301","diff_url":"https://github.com/alibaba/pouch/pull/2301.diff","patch_url":"https://github.com/alibaba/pouch/pull/2301.patch","issue_url":"https://api.github.com/repos/alibaba/pouch/issues/2301","number":2301,"state":"open","locked":false,"title":"enhance: cache image size and oci image spec in pouchd","user":{"login":"fuweid","id":17510957,"node_id":"MDQ6VXNlcjE3NTEwOTU3","avatar_url":"https://avatars3.githubusercontent.com/u/17510957?v=4","gravatar_id":"","url":"https://api.github.com/users/fuweid","html_url":"https://github.com/fuweid","followers_url":"https://api.github.com/users/fuweid/followers","following_url":"https://api.github.com/users/fuweid/following{/other_user}","gists_url":"https://api.github.com/users/fuweid/gists{/gist_id}","starred_url":"https://api.github.com/users/fuweid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuweid/subscriptions","organizations_url":"https://api.github.com/users/fuweid/orgs","repos_url":"https://api.github.com/users/fuweid/repos","events_url":"https://api.github.com/users/fuweid/events{/privacy}","received_events_url":"https://api.github.com/users/fuweid/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Wei Fu <fuweid89@gmail.com>\r\n\r\n<!-- \r\nPlease make sure you have read and understood the contributing guidelines;\r\nhttps://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md -->\r\n\r\n### Ⅰ. Describe what this PR did\r\n\r\nwhen the containerd manages many big images, the pouchd ListImage will\r\nconsume a lot of CPU resources caused by containerd.Content.Read stream\r\ngrpc call.\r\n\r\nIn the k8s, the kubelet gc image manager will send the ListImage request\r\nevery 30s. If the containerd consumes too many CPU resources, it will\r\nimpact the container. Therefore, pouchd needs to cache the data.\r\n\r\n### Ⅱ. Does this pull request fix one issue?\r\n<!--If that, add \"fixes #xxxx\" below in the next line, for example, fixes #15. Otherwise, add \"NONE\" -->\r\n\r\nNONE\r\n\r\n### Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)\r\n\r\nno need \r\n\r\n### Ⅳ. Describe how to verify it\r\n\r\nCI\r\n\r\n### Ⅴ. Special notes for reviews\r\n\r\n\r\n","created_at":"2018-10-09T05:07:54Z","updated_at":"2018-10-10T12:40:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10241955a58a8e225c0e3de060e8c4d8597907b0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":722339975,"node_id":"MDU6TGFiZWw3MjIzMzk5NzU=","url":"https://api.github.com/repos/alibaba/pouch/labels/areas/test","name":"areas/test","color":"1d76db","default":false},{"id":722355122,"node_id":"MDU6TGFiZWw3MjIzNTUxMjI=","url":"https://api.github.com/repos/alibaba/pouch/labels/size/L","name":"size/L","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/alibaba/pouch/pulls/2301/commits","review_comments_url":"https://api.github.com/repos/alibaba/pouch/pulls/2301/comments","review_comment_url":"https://api.github.com/repos/alibaba/pouch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alibaba/pouch/issues/2301/comments","statuses_url":"https://api.github.com/repos/alibaba/pouch/statuses/24dbb79767ff5c35315b652e2b310bf58d97761a","head":{"label":"fuweid:enhance_cache_oci_image_info","ref":"enhance_cache_oci_image_info","sha":"24dbb79767ff5c35315b652e2b310bf58d97761a","user":{"login":"fuweid","id":17510957,"node_id":"MDQ6VXNlcjE3NTEwOTU3","avatar_url":"https://avatars3.githubusercontent.com/u/17510957?v=4","gravatar_id":"","url":"https://api.github.com/users/fuweid","html_url":"https://github.com/fuweid","followers_url":"https://api.github.com/users/fuweid/followers","following_url":"https://api.github.com/users/fuweid/following{/other_user}","gists_url":"https://api.github.com/users/fuweid/gists{/gist_id}","starred_url":"https://api.github.com/users/fuweid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuweid/subscriptions","organizations_url":"https://api.github.com/users/fuweid/orgs","repos_url":"https://api.github.com/users/fuweid/repos","events_url":"https://api.github.com/users/fuweid/events{/privacy}","received_events_url":"https://api.github.com/users/fuweid/received_events","type":"User","site_admin":false},"repo":{"id":143372593,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzNzI1OTM=","name":"pouch","full_name":"fuweid/pouch","private":false,"owner":{"login":"fuweid","id":17510957,"node_id":"MDQ6VXNlcjE3NTEwOTU3","avatar_url":"https://avatars3.githubusercontent.com/u/17510957?v=4","gravatar_id":"","url":"https://api.github.com/users/fuweid","html_url":"https://github.com/fuweid","followers_url":"https://api.github.com/users/fuweid/followers","following_url":"https://api.github.com/users/fuweid/following{/other_user}","gists_url":"https://api.github.com/users/fuweid/gists{/gist_id}","starred_url":"https://api.github.com/users/fuweid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuweid/subscriptions","organizations_url":"https://api.github.com/users/fuweid/orgs","repos_url":"https://api.github.com/users/fuweid/repos","events_url":"https://api.github.com/users/fuweid/events{/privacy}","received_events_url":"https://api.github.com/users/fuweid/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fuweid/pouch","description":"An Efficient Enterprise-class Rich Container Engine","fork":true,"url":"https://api.github.com/repos/fuweid/pouch","forks_url":"https://api.github.com/repos/fuweid/pouch/forks","keys_url":"https://api.github.com/repos/fuweid/pouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fuweid/pouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fuweid/pouch/teams","hooks_url":"https://api.github.com/repos/fuweid/pouch/hooks","issue_events_url":"https://api.github.com/repos/fuweid/pouch/issues/events{/number}","events_url":"https://api.github.com/repos/fuweid/pouch/events","assignees_url":"https://api.github.com/repos/fuweid/pouch/assignees{/user}","branches_url":"https://api.github.com/repos/fuweid/pouch/branches{/branch}","tags_url":"https://api.github.com/repos/fuweid/pouch/tags","blobs_url":"https://api.github.com/repos/fuweid/pouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fuweid/pouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fuweid/pouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/fuweid/pouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fuweid/pouch/statuses/{sha}","languages_url":"https://api.github.com/repos/fuweid/pouch/languages","stargazers_url":"https://api.github.com/repos/fuweid/pouch/stargazers","contributors_url":"https://api.github.com/repos/fuweid/pouch/contributors","subscribers_url":"https://api.github.com/repos/fuweid/pouch/subscribers","subscription_url":"https://api.github.com/repos/fuweid/pouch/subscription","commits_url":"https://api.github.com/repos/fuweid/pouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/fuweid/pouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/fuweid/pouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/fuweid/pouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/fuweid/pouch/contents/{+path}","compare_url":"https://api.github.com/repos/fuweid/pouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fuweid/pouch/merges","archive_url":"https://api.github.com/repos/fuweid/pouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fuweid/pouch/downloads","issues_url":"https://api.github.com/repos/fuweid/pouch/issues{/number}","pulls_url":"https://api.github.com/repos/fuweid/pouch/pulls{/number}","milestones_url":"https://api.github.com/repos/fuweid/pouch/milestones{/number}","notifications_url":"https://api.github.com/repos/fuweid/pouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fuweid/pouch/labels{/name}","releases_url":"https://api.github.com/repos/fuweid/pouch/releases{/id}","deployments_url":"https://api.github.com/repos/fuweid/pouch/deployments","created_at":"2018-08-03T03:23:54Z","updated_at":"2018-08-03T03:23:57Z","pushed_at":"2018-10-10T01:45:32Z","git_url":"git://github.com/fuweid/pouch.git","ssh_url":"git@github.com:fuweid/pouch.git","clone_url":"https://github.com/fuweid/pouch.git","svn_url":"https://github.com/fuweid/pouch","homepage":"https://pouchcontainer.io","size":20192,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alibaba:master","ref":"master","sha":"4002e93d1c836b2bb4dd15262a2066841fcbbc52","user":{"login":"alibaba","id":1961952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjE5NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1961952?v=4","gravatar_id":"","url":"https://api.github.com/users/alibaba","html_url":"https://github.com/alibaba","followers_url":"https://api.github.com/users/alibaba/followers","following_url":"https://api.github.com/users/alibaba/following{/other_user}","gists_url":"https://api.github.com/users/alibaba/gists{/gist_id}","starred_url":"https://api.github.com/users/alibaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibaba/subscriptions","organizations_url":"https://api.github.com/users/alibaba/orgs","repos_url":"https://api.github.com/users/alibaba/repos","events_url":"https://api.github.com/users/alibaba/events{/privacy}","received_events_url":"https://api.github.com/users/alibaba/received_events","type":"Organization","site_admin":false},"repo":{"id":102555965,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NTU5NjU=","name":"pouch","full_name":"alibaba/pouch","private":false,"owner":{"login":"alibaba","id":1961952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjE5NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1961952?v=4","gravatar_id":"","url":"https://api.github.com/users/alibaba","html_url":"https://github.com/alibaba","followers_url":"https://api.github.com/users/alibaba/followers","following_url":"https://api.github.com/users/alibaba/following{/other_user}","gists_url":"https://api.github.com/users/alibaba/gists{/gist_id}","starred_url":"https://api.github.com/users/alibaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibaba/subscriptions","organizations_url":"https://api.github.com/users/alibaba/orgs","repos_url":"https://api.github.com/users/alibaba/repos","events_url":"https://api.github.com/users/alibaba/events{/privacy}","received_events_url":"https://api.github.com/users/alibaba/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alibaba/pouch","description":"An Efficient Enterprise-class Rich Container Engine","fork":false,"url":"https://api.github.com/repos/alibaba/pouch","forks_url":"https://api.github.com/repos/alibaba/pouch/forks","keys_url":"https://api.github.com/repos/alibaba/pouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alibaba/pouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alibaba/pouch/teams","hooks_url":"https://api.github.com/repos/alibaba/pouch/hooks","issue_events_url":"https://api.github.com/repos/alibaba/pouch/issues/events{/number}","events_url":"https://api.github.com/repos/alibaba/pouch/events","assignees_url":"https://api.github.com/repos/alibaba/pouch/assignees{/user}","branches_url":"https://api.github.com/repos/alibaba/pouch/branches{/branch}","tags_url":"https://api.github.com/repos/alibaba/pouch/tags","blobs_url":"https://api.github.com/repos/alibaba/pouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alibaba/pouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alibaba/pouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/alibaba/pouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alibaba/pouch/statuses/{sha}","languages_url":"https://api.github.com/repos/alibaba/pouch/languages","stargazers_url":"https://api.github.com/repos/alibaba/pouch/stargazers","contributors_url":"https://api.github.com/repos/alibaba/pouch/contributors","subscribers_url":"https://api.github.com/repos/alibaba/pouch/subscribers","subscription_url":"https://api.github.com/repos/alibaba/pouch/subscription","commits_url":"https://api.github.com/repos/alibaba/pouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/alibaba/pouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/alibaba/pouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/alibaba/pouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/alibaba/pouch/contents/{+path}","compare_url":"https://api.github.com/repos/alibaba/pouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alibaba/pouch/merges","archive_url":"https://api.github.com/repos/alibaba/pouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alibaba/pouch/downloads","issues_url":"https://api.github.com/repos/alibaba/pouch/issues{/number}","pulls_url":"https://api.github.com/repos/alibaba/pouch/pulls{/number}","milestones_url":"https://api.github.com/repos/alibaba/pouch/milestones{/number}","notifications_url":"https://api.github.com/repos/alibaba/pouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alibaba/pouch/labels{/name}","releases_url":"https://api.github.com/repos/alibaba/pouch/releases{/id}","deployments_url":"https://api.github.com/repos/alibaba/pouch/deployments","created_at":"2017-09-06T03:01:51Z","updated_at":"2018-10-10T12:01:06Z","pushed_at":"2018-10-10T07:41:17Z","git_url":"git://github.com/alibaba/pouch.git","ssh_url":"git@github.com:alibaba/pouch.git","clone_url":"https://github.com/alibaba/pouch.git","svn_url":"https://github.com/alibaba/pouch","homepage":"https://pouchcontainer.io","size":20185,"stargazers_count":3354,"watchers_count":3354,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":819,"mirror_url":null,"archived":false,"open_issues_count":149,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":819,"open_issues":149,"watchers":3354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/2301"},"html":{"href":"https://github.com/alibaba/pouch/pull/2301"},"issue":{"href":"https://api.github.com/repos/alibaba/pouch/issues/2301"},"comments":{"href":"https://api.github.com/repos/alibaba/pouch/issues/2301/comments"},"review_comments":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/2301/comments"},"review_comment":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/2301/commits"},"statuses":{"href":"https://api.github.com/repos/alibaba/pouch/statuses/24dbb79767ff5c35315b652e2b310bf58d97761a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"HusterWan"}}