{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/224660186","pull_request_review_id":164084681,"id":224660186,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDY2MDE4Ng==","diff_hunk":"@@ -256,6 +256,10 @@ <h3>${course_dir}</h3>\n           <div id=\"dashboard-search-results\" class=\"search-results dashboard-search-results\"></div>\n         % endif\n \n+        % if settings.FEATURES.get('ENABLE_ANNOUNCEMENTS'):\n+          <%include file='dashboard/_dashboard_announcements.html' args='announcements=announcements' />\n+        % endif","path":"lms/templates/dashboard.html","position":6,"original_position":6,"commit_id":"a30011085f9d7bdd07748011789b48eabc8988ad","original_commit_id":"89c043d124e9018626dfde4f2c1253c137acaa56","user":{"login":"ormsbee","id":41625,"node_id":"MDQ6VXNlcjQxNjI1","avatar_url":"https://avatars1.githubusercontent.com/u/41625?v=4","gravatar_id":"","url":"https://api.github.com/users/ormsbee","html_url":"https://github.com/ormsbee","followers_url":"https://api.github.com/users/ormsbee/followers","following_url":"https://api.github.com/users/ormsbee/following{/other_user}","gists_url":"https://api.github.com/users/ormsbee/gists{/gist_id}","starred_url":"https://api.github.com/users/ormsbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ormsbee/subscriptions","organizations_url":"https://api.github.com/users/ormsbee/orgs","repos_url":"https://api.github.com/users/ormsbee/repos","events_url":"https://api.github.com/users/ormsbee/events{/privacy}","received_events_url":"https://api.github.com/users/ormsbee/received_events","type":"User","site_admin":false},"body":"@wittjeff: This was the PR I mentioned in the Accessibility chat room, where the announcements go after the course listing in the DOM ordering (this is the student dashboard). Is it sufficient to put role=\"alert\" or role=\"status\" on it, or is it critical that it also come before the course listing?","created_at":"2018-10-12T03:07:07Z","updated_at":"2018-10-12T03:07:07Z","html_url":"https://github.com/edx/edx-platform/pull/16496#discussion_r224660186","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/16496","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/224660186"},"html":{"href":"https://github.com/edx/edx-platform/pull/16496#discussion_r224660186"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/16496"}},"in_reply_to_id":220651687},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/16496","id":151444113,"node_id":"MDExOlB1bGxSZXF1ZXN0MTUxNDQ0MTEz","html_url":"https://github.com/edx/edx-platform/pull/16496","diff_url":"https://github.com/edx/edx-platform/pull/16496.diff","patch_url":"https://github.com/edx/edx-platform/pull/16496.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/16496","number":16496,"state":"open","locked":false,"title":"Dashboard announcements feature","user":{"login":"kaizoku","id":270966,"node_id":"MDQ6VXNlcjI3MDk2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/270966?v=4","gravatar_id":"","url":"https://api.github.com/users/kaizoku","html_url":"https://github.com/kaizoku","followers_url":"https://api.github.com/users/kaizoku/followers","following_url":"https://api.github.com/users/kaizoku/following{/other_user}","gists_url":"https://api.github.com/users/kaizoku/gists{/gist_id}","starred_url":"https://api.github.com/users/kaizoku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaizoku/subscriptions","organizations_url":"https://api.github.com/users/kaizoku/orgs","repos_url":"https://api.github.com/users/kaizoku/repos","events_url":"https://api.github.com/users/kaizoku/events{/privacy}","received_events_url":"https://api.github.com/users/kaizoku/received_events","type":"User","site_admin":false},"body":"This PR adds an Announcement feature to show announcements on the sidebar of the LMS dashboard. It uses TinyMCE to show an editor in the studio.\r\n\r\n**JIRA tickets**: Implements OC-3201, HMS-15\r\n\r\n**Discussions**: Discussed in JIRA tickets\r\n\r\n**Dependencies**: None\r\n\r\n**Screenshots**:\r\n\r\n![dashboard announcements](https://user-images.githubusercontent.com/7556571/32713023-53721626-c897-11e7-9514-0abbdb8a89ad.png)\r\n![screenshot-2018-4-24 edit announcements studio](https://user-images.githubusercontent.com/270966/39393694-4314a4f2-4a7d-11e8-9ed2-e60bb83f8c27.png)\r\n![screenshot-2018-4-24 edit announcement studio](https://user-images.githubusercontent.com/270966/39393705-52feb8c6-4a7d-11e8-886b-4c0063154aac.png)\r\n![screenshot-2018-4-24 delete announcement studio](https://user-images.githubusercontent.com/270966/39393703-50623fde-4a7d-11e8-889f-c8ff02c92770.png)\r\n\r\n\r\n**Sandbox URL**:\r\n\r\n* LMS: https://pr16496.sandbox.opencraft.hosting/\r\n* Studio: https://studio-pr16496.sandbox.opencraft.hosting/\r\n\r\n**Testing setup**:\r\n\r\n1. Enable announcements with `settings.FEATURES['ENABLE_ANNOUNCEMENTS'] = True`.\r\n1. Run migrations `./manage.py cms migrate --settings=devstack`\r\n\r\n**Testing instructions**:\r\n\r\n1. Login to Studio as a staff member.\r\n1. Navigate to the announcements page in studio: https://studio-pr16496.sandbox.opencraft.hosting/maintenance/announcements/\r\n1. Click the \"Create New\", add content, ensure announcement is enabled\r\n1. Add more than 5 announcements to check pagination.\r\n1. Login to the LMS as a student.\r\n1. View the Course Dashboard and check that the Announcement is properly displayed\r\n1. Edit the Announcement, disable the active field, and ensure that it is removed from the LMS Dashboard.\r\n1. Delete an announcement and check that the delete endpoint works.\r\n\r\n**Author notes and concerns**:\r\n\r\n1. I wrote tests for the JSX component using [enzyme](https://github.com/airbnb/enzyme) and [jest](https://facebook.github.io/jest/docs/en/tutorial-react.html), similar to the ones in [Paragon](https://github.com/edx/paragon/blob/master/src/Tabs/Tabs.test.jsx), but I was unable to run them without adding a number of dependencies in package.json which seem out of the scope of this pull request. Are there already plans for adding JSX testing into edx-platform? If desired I could open another PR with those dependencies and configuration options.\r\n\r\n**Reviewers**\r\n- [ ] (pomegranited)\r\n- [ ] edX reviewer[s] TBD\r\n\r\n**Settings**\r\n```yaml\r\nEDXAPP_FEATURES:\r\n  ENABLE_ANNOUNCEMENTS: true\r\n```","created_at":"2017-11-08T17:19:37Z","updated_at":"2018-10-12T03:07:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a9cdcd330c32a642374fc4117f50b8775b2f9ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":920772109,"node_id":"MDU6TGFiZWw5MjA3NzIxMDk=","url":"https://api.github.com/repos/edx/edx-platform/labels/architecture%20review","name":"architecture review","color":"f4a213","default":false},{"id":78051711,"node_id":"MDU6TGFiZWw3ODA1MTcxMQ==","url":"https://api.github.com/repos/edx/edx-platform/labels/open-source-contribution","name":"open-source-contribution","color":"bfe5bf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/16496/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/16496/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/16496/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/a30011085f9d7bdd07748011789b48eabc8988ad","head":{"label":"open-craft:josh/announcements-feature","ref":"josh/announcements-feature","sha":"a30011085f9d7bdd07748011789b48eabc8988ad","user":{"login":"open-craft","id":7414786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MTQ3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"repo":{"id":19940883,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk0MDg4Mw==","name":"edx-platform","full_name":"open-craft/edx-platform","private":false,"owner":{"login":"open-craft","id":7414786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MTQ3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-craft/edx-platform","description":"the edX learning management system (LMS) and course authoring tool, Studio","fork":true,"url":"https://api.github.com/repos/open-craft/edx-platform","forks_url":"https://api.github.com/repos/open-craft/edx-platform/forks","keys_url":"https://api.github.com/repos/open-craft/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-craft/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-craft/edx-platform/teams","hooks_url":"https://api.github.com/repos/open-craft/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/open-craft/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/open-craft/edx-platform/events","assignees_url":"https://api.github.com/repos/open-craft/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/open-craft/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/open-craft/edx-platform/tags","blobs_url":"https://api.github.com/repos/open-craft/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-craft/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-craft/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-craft/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-craft/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/open-craft/edx-platform/languages","stargazers_url":"https://api.github.com/repos/open-craft/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/open-craft/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/open-craft/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/open-craft/edx-platform/subscription","commits_url":"https://api.github.com/repos/open-craft/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-craft/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-craft/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-craft/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-craft/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/open-craft/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-craft/edx-platform/merges","archive_url":"https://api.github.com/repos/open-craft/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-craft/edx-platform/downloads","issues_url":"https://api.github.com/repos/open-craft/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/open-craft/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/open-craft/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/open-craft/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-craft/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/open-craft/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/open-craft/edx-platform/deployments","created_at":"2014-05-19T12:28:25Z","updated_at":"2018-07-20T16:54:43Z","pushed_at":"2018-10-12T01:56:16Z","git_url":"git://github.com/open-craft/edx-platform.git","ssh_url":"git@github.com:open-craft/edx-platform.git","clone_url":"https://github.com/open-craft/edx-platform.git","svn_url":"https://github.com/open-craft/edx-platform","homepage":"http://code.edx.org/","size":977820,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":2,"open_issues":4,"watchers":6,"default_branch":"open-craft-notice"}},"base":{"label":"edx:master","ref":"master","sha":"65ab430c0487fb1312be7daa7ba365a6fc9aa23d","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM5MTA3Mw==","name":"edx-platform","full_name":"edx/edx-platform","private":false,"owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2018-10-12T01:36:54Z","pushed_at":"2018-10-12T01:56:19Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":968963,"stargazers_count":3900,"watchers_count":3900,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2192,"mirror_url":null,"archived":false,"open_issues_count":228,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2192,"open_issues":228,"watchers":3900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/16496"},"html":{"href":"https://github.com/edx/edx-platform/pull/16496"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/16496"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/16496/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/16496/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/16496/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/a30011085f9d7bdd07748011789b48eabc8988ad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ormsbee"}}