{"action":"created","issue":{"url":"https://api.github.com/repos/iNistyuk/Student-practice/issues/4","repository_url":"https://api.github.com/repos/iNistyuk/Student-practice","labels_url":"https://api.github.com/repos/iNistyuk/Student-practice/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/iNistyuk/Student-practice/issues/4/comments","events_url":"https://api.github.com/repos/iNistyuk/Student-practice/issues/4/events","html_url":"https://github.com/iNistyuk/Student-practice/issues/4","id":308649413,"number":4,"title":"task 6 ","user":{"login":"iNistyuk","id":22748291,"avatar_url":"https://avatars3.githubusercontent.com/u/22748291?v=4","gravatar_id":"","url":"https://api.github.com/users/iNistyuk","html_url":"https://github.com/iNistyuk","followers_url":"https://api.github.com/users/iNistyuk/followers","following_url":"https://api.github.com/users/iNistyuk/following{/other_user}","gists_url":"https://api.github.com/users/iNistyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/iNistyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNistyuk/subscriptions","organizations_url":"https://api.github.com/users/iNistyuk/orgs","repos_url":"https://api.github.com/users/iNistyuk/repos","events_url":"https://api.github.com/users/iNistyuk/events{/privacy}","received_events_url":"https://api.github.com/users/iNistyuk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-26T16:43:22Z","updated_at":"2018-05-21T11:30:16Z","closed_at":null,"author_association":"OWNER","body":"@slawiko\r\nСогласно условию, данные должны храниться не в js-файле, а в localstorage.\r\nВ моей программе сохранение данных производится вручную. \r\nПосле первого запуска страницы, когда в localstorage будет сохранён массив фотопостов, \r\n\r\n_**необходимо будет закомментировать в task6.js выделенный участок кода между**_ \"`//*******************`\", \r\n\r\nчтобы при обновлении страницы её содержимое не менялось.\r\n\r\n\r\nИмена пользователей и пароли можно найти здесь:\r\n```\r\nvar usersString = JSON.stringify([{\r\n    name: \"Mark Twain\",\r\n    password: \"11204\"\r\n},\r\n    {\r\n        name: \"Mark Twain\",\r\n        password: \"11204\"\r\n    },\r\n    {\r\n        name:\"Rudolf Shenker\",\r\n        password:\"afgt\"\r\n    },\r\n    {\r\n        name:\"Klaus Meine\",\r\n        password:\"WeWillRockYou\"\r\n    },\r\n    {\r\n        name:\"Steve Jobs\",\r\n        password:\"iPhone10\"\r\n    },\r\n    {\r\n        name:\"Michael Flatley\",\r\n        password:\"Irish_Not_Irish\"\r\n    },\r\n    {\r\n        name:\"Ronnie James Dio\",\r\n        password:\"Dream_On123\"\r\n    },\r\n    {\r\n        name:\"Joe Cocker\",\r\n        password:\"1120w4\"\r\n    },\r\n    {\r\n        name:\"Ingwie Malmsten\",\r\n        password:\"1dfe1204\"\r\n    },\r\n    {\r\n        name:\"Oldschool Skater\",\r\n        password:\"112023234\"\r\n    },\r\n    {\r\n        name:\"Rich Man\",\r\n        password:\"104\"\r\n    },\r\n    {\r\n        name:\"Swedish King\",\r\n        password:\"1rev1204\"\r\n    },\r\n    {\r\n        name:\"Wolfgang Mozart\",\r\n        password:\"1rerev1204\"\r\n    },\r\n    {\r\n        name:\"African Hunter\",\r\n        password:\"1204\"\r\n    },\r\n    {\r\n        name:\"Jack Unknown\",\r\n        password:\"1revef1204\"\r\n    },\r\n    {\r\n        name:\"Les Paul\",\r\n        password:\"1rereiuv1204\"\r\n    }\r\n    ]);\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/iNistyuk/Student-practice/issues/comments/390628665","html_url":"https://github.com/iNistyuk/Student-practice/issues/4#issuecomment-390628665","issue_url":"https://api.github.com/repos/iNistyuk/Student-practice/issues/4","id":390628665,"user":{"login":"slawiko","id":10272192,"avatar_url":"https://avatars2.githubusercontent.com/u/10272192?v=4","gravatar_id":"","url":"https://api.github.com/users/slawiko","html_url":"https://github.com/slawiko","followers_url":"https://api.github.com/users/slawiko/followers","following_url":"https://api.github.com/users/slawiko/following{/other_user}","gists_url":"https://api.github.com/users/slawiko/gists{/gist_id}","starred_url":"https://api.github.com/users/slawiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slawiko/subscriptions","organizations_url":"https://api.github.com/users/slawiko/orgs","repos_url":"https://api.github.com/users/slawiko/repos","events_url":"https://api.github.com/users/slawiko/events{/privacy}","received_events_url":"https://api.github.com/users/slawiko/received_events","type":"User","site_admin":false},"created_at":"2018-05-21T11:30:15Z","updated_at":"2018-05-21T11:30:15Z","author_association":"NONE","body":"@iNistyuk \r\n\r\nСпасибо большое, за пояснение.\r\n\r\nПроверял по `task6`\r\n\r\n### Общие\r\n- все замечания из #9 справедливы и здесь\r\n- стоило бы, конечно же, разделить все ресурсы по папкам. Иначе получается какая-то свалка в корне\r\n- `getPhotoPosts` ну зачем же она такая большая. Вам же тоже наверное тяжело читать\r\n- `depictPhotoPost`, `depictPhotoPostWithoutWrap`, `depictPhotoPostAuthorised`, `depictPhotoPostAuthorisedWithoutWrap` во-первых слишком сложные названия (и я понял что такое WW из #9), а во-вторых они ну очень похожи. Вы повторяете свой же код несколько раз. Такой код надо выносить в отдельную функцию\r\n- вы заставляете вводить решетку в фильтре по хештегам. Это негуманно :)\r\n\r\nто ли я чего-то не нашел, то ли у вас не реализована половина функциональность: добавить пост, удалить пост, отредактировать пост - где это всё? Если добавите нужные фичи - повысим отметку"}}
{"actor":{"display_login":"slawiko"}}