{"action":"created","comment":{"url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/comments/218901991","pull_request_review_id":156944850,"id":218901991,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODkwMTk5MQ==","diff_hunk":"@@ -0,0 +1,128 @@\n+// Copyright 2018 The Operator-SDK Authors\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package cmdtest\n+\n+import (\n+\t\"bytes\"\n+\t\"fmt\"\n+\t\"os\"\n+\t\"time\"\n+\n+\t\"github.com/spf13/cobra\"\n+\tv1 \"k8s.io/api/core/v1\"\n+\tmetav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"\n+\t\"k8s.io/client-go/kubernetes\"\n+\t\"k8s.io/client-go/tools/clientcmd\"\n+)\n+\n+var (\n+\ttestNamespace     string\n+\tkubeconfigCluster string\n+\timagePullPolicy   bool\n+)\n+\n+func NewTestClusterCmd() *cobra.Command {\n+\ttestCmd := &cobra.Command{\n+\t\tUse:   \"cluster <image name> [flags]\",\n+\t\tShort: \"Run End-To-End tests using image with embedded test binary\",\n+\t\tRunE:  testClusterFunc,\n+\t}\n+\tdefaultKubeConfig := \"\"","path":"commands/operator-sdk/cmd/test/cluster.go","position":42,"original_position":42,"commit_id":"695995d4b8a02fd8eedc92dba6bc5e8bc452e2e7","original_commit_id":"b4d18dc2985eb2ec8852d5b696df8d60a5a2dc5b","user":{"login":"AlexNPavel","id":3813031,"node_id":"MDQ6VXNlcjM4MTMwMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3813031?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexNPavel","html_url":"https://github.com/AlexNPavel","followers_url":"https://api.github.com/users/AlexNPavel/followers","following_url":"https://api.github.com/users/AlexNPavel/following{/other_user}","gists_url":"https://api.github.com/users/AlexNPavel/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexNPavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexNPavel/subscriptions","organizations_url":"https://api.github.com/users/AlexNPavel/orgs","repos_url":"https://api.github.com/users/AlexNPavel/repos","events_url":"https://api.github.com/users/AlexNPavel/events{/privacy}","received_events_url":"https://api.github.com/users/AlexNPavel/received_events","type":"User","site_admin":false},"body":"Shouldn't those be configurable via the kubeconfig file itself? The simplest way to handle this imo would be letting the user create a custom kubeconfig for these cases and passing that file to the command. I'm not sure how we would be able to easily utilize the bind functions.","created_at":"2018-09-19T17:51:05Z","updated_at":"2018-09-19T17:51:05Z","html_url":"https://github.com/operator-framework/operator-sdk/pull/469#discussion_r218901991","pull_request_url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/469","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/comments/218901991"},"html":{"href":"https://github.com/operator-framework/operator-sdk/pull/469#discussion_r218901991"},"pull_request":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/469"}},"in_reply_to_id":218191885},"pull_request":{"url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/469","id":214463538,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDYzNTM4","html_url":"https://github.com/operator-framework/operator-sdk/pull/469","diff_url":"https://github.com/operator-framework/operator-sdk/pull/469.diff","patch_url":"https://github.com/operator-framework/operator-sdk/pull/469.patch","issue_url":"https://api.github.com/repos/operator-framework/operator-sdk/issues/469","number":469,"state":"open","locked":false,"title":"pkg/test: add in-cluster/in-image testing support","user":{"login":"AlexNPavel","id":3813031,"node_id":"MDQ6VXNlcjM4MTMwMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3813031?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexNPavel","html_url":"https://github.com/AlexNPavel","followers_url":"https://api.github.com/users/AlexNPavel/followers","following_url":"https://api.github.com/users/AlexNPavel/following{/other_user}","gists_url":"https://api.github.com/users/AlexNPavel/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexNPavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexNPavel/subscriptions","organizations_url":"https://api.github.com/users/AlexNPavel/orgs","repos_url":"https://api.github.com/users/AlexNPavel/repos","events_url":"https://api.github.com/users/AlexNPavel/events{/privacy}","received_events_url":"https://api.github.com/users/AlexNPavel/received_events","type":"User","site_admin":false},"body":"Issue #435","created_at":"2018-09-10T22:35:12Z","updated_at":"2018-09-19T17:51:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0586e4f311270ce3771d456c343115cadd8d6a4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fanminshi","id":4983345,"node_id":"MDQ6VXNlcjQ5ODMzNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/4983345?v=4","gravatar_id":"","url":"https://api.github.com/users/fanminshi","html_url":"https://github.com/fanminshi","followers_url":"https://api.github.com/users/fanminshi/followers","following_url":"https://api.github.com/users/fanminshi/following{/other_user}","gists_url":"https://api.github.com/users/fanminshi/gists{/gist_id}","starred_url":"https://api.github.com/users/fanminshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanminshi/subscriptions","organizations_url":"https://api.github.com/users/fanminshi/orgs","repos_url":"https://api.github.com/users/fanminshi/repos","events_url":"https://api.github.com/users/fanminshi/events{/privacy}","received_events_url":"https://api.github.com/users/fanminshi/received_events","type":"User","site_admin":false},{"login":"hasbro17","id":6660644,"node_id":"MDQ6VXNlcjY2NjA2NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6660644?v=4","gravatar_id":"","url":"https://api.github.com/users/hasbro17","html_url":"https://github.com/hasbro17","followers_url":"https://api.github.com/users/hasbro17/followers","following_url":"https://api.github.com/users/hasbro17/following{/other_user}","gists_url":"https://api.github.com/users/hasbro17/gists{/gist_id}","starred_url":"https://api.github.com/users/hasbro17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hasbro17/subscriptions","organizations_url":"https://api.github.com/users/hasbro17/orgs","repos_url":"https://api.github.com/users/hasbro17/repos","events_url":"https://api.github.com/users/hasbro17/events{/privacy}","received_events_url":"https://api.github.com/users/hasbro17/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/469/commits","review_comments_url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/469/comments","review_comment_url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/operator-framework/operator-sdk/issues/469/comments","statuses_url":"https://api.github.com/repos/operator-framework/operator-sdk/statuses/695995d4b8a02fd8eedc92dba6bc5e8bc452e2e7","head":{"label":"AlexNPavel:incluster-test","ref":"incluster-test","sha":"695995d4b8a02fd8eedc92dba6bc5e8bc452e2e7","user":{"login":"AlexNPavel","id":3813031,"node_id":"MDQ6VXNlcjM4MTMwMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3813031?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexNPavel","html_url":"https://github.com/AlexNPavel","followers_url":"https://api.github.com/users/AlexNPavel/followers","following_url":"https://api.github.com/users/AlexNPavel/following{/other_user}","gists_url":"https://api.github.com/users/AlexNPavel/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexNPavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexNPavel/subscriptions","organizations_url":"https://api.github.com/users/AlexNPavel/orgs","repos_url":"https://api.github.com/users/AlexNPavel/repos","events_url":"https://api.github.com/users/AlexNPavel/events{/privacy}","received_events_url":"https://api.github.com/users/AlexNPavel/received_events","type":"User","site_admin":false},"repo":{"id":140767708,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA3Njc3MDg=","name":"operator-sdk","full_name":"AlexNPavel/operator-sdk","private":false,"owner":{"login":"AlexNPavel","id":3813031,"node_id":"MDQ6VXNlcjM4MTMwMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3813031?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexNPavel","html_url":"https://github.com/AlexNPavel","followers_url":"https://api.github.com/users/AlexNPavel/followers","following_url":"https://api.github.com/users/AlexNPavel/following{/other_user}","gists_url":"https://api.github.com/users/AlexNPavel/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexNPavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexNPavel/subscriptions","organizations_url":"https://api.github.com/users/AlexNPavel/orgs","repos_url":"https://api.github.com/users/AlexNPavel/repos","events_url":"https://api.github.com/users/AlexNPavel/events{/privacy}","received_events_url":"https://api.github.com/users/AlexNPavel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AlexNPavel/operator-sdk","description":"SDK for building Kubernetes applications. Provides high level APIs, useful abstractions, and project scaffolding.","fork":true,"url":"https://api.github.com/repos/AlexNPavel/operator-sdk","forks_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/forks","keys_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/teams","hooks_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/hooks","issue_events_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/events","assignees_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/tags","blobs_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/languages","stargazers_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/stargazers","contributors_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/contributors","subscribers_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/subscribers","subscription_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/subscription","commits_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/merges","archive_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/downloads","issues_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/labels{/name}","releases_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/AlexNPavel/operator-sdk/deployments","created_at":"2018-07-12T21:45:39Z","updated_at":"2018-08-29T19:48:55Z","pushed_at":"2018-09-17T23:25:48Z","git_url":"git://github.com/AlexNPavel/operator-sdk.git","ssh_url":"git@github.com:AlexNPavel/operator-sdk.git","clone_url":"https://github.com/AlexNPavel/operator-sdk.git","svn_url":"https://github.com/AlexNPavel/operator-sdk","homepage":"https://coreos.com/operators","size":1051,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"operator-framework:master","ref":"master","sha":"bc557b1489f02f3b14180af9980bf4e06a1fa00c","user":{"login":"operator-framework","id":38202270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjAyMjcw","avatar_url":"https://avatars0.githubusercontent.com/u/38202270?v=4","gravatar_id":"","url":"https://api.github.com/users/operator-framework","html_url":"https://github.com/operator-framework","followers_url":"https://api.github.com/users/operator-framework/followers","following_url":"https://api.github.com/users/operator-framework/following{/other_user}","gists_url":"https://api.github.com/users/operator-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/operator-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/operator-framework/subscriptions","organizations_url":"https://api.github.com/users/operator-framework/orgs","repos_url":"https://api.github.com/users/operator-framework/repos","events_url":"https://api.github.com/users/operator-framework/events{/privacy}","received_events_url":"https://api.github.com/users/operator-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":120650407,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA2NTA0MDc=","name":"operator-sdk","full_name":"operator-framework/operator-sdk","private":false,"owner":{"login":"operator-framework","id":38202270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjAyMjcw","avatar_url":"https://avatars0.githubusercontent.com/u/38202270?v=4","gravatar_id":"","url":"https://api.github.com/users/operator-framework","html_url":"https://github.com/operator-framework","followers_url":"https://api.github.com/users/operator-framework/followers","following_url":"https://api.github.com/users/operator-framework/following{/other_user}","gists_url":"https://api.github.com/users/operator-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/operator-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/operator-framework/subscriptions","organizations_url":"https://api.github.com/users/operator-framework/orgs","repos_url":"https://api.github.com/users/operator-framework/repos","events_url":"https://api.github.com/users/operator-framework/events{/privacy}","received_events_url":"https://api.github.com/users/operator-framework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/operator-framework/operator-sdk","description":"SDK for building Kubernetes applications. Provides high level APIs, useful abstractions, and project scaffolding.","fork":false,"url":"https://api.github.com/repos/operator-framework/operator-sdk","forks_url":"https://api.github.com/repos/operator-framework/operator-sdk/forks","keys_url":"https://api.github.com/repos/operator-framework/operator-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/operator-framework/operator-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/operator-framework/operator-sdk/teams","hooks_url":"https://api.github.com/repos/operator-framework/operator-sdk/hooks","issue_events_url":"https://api.github.com/repos/operator-framework/operator-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/operator-framework/operator-sdk/events","assignees_url":"https://api.github.com/repos/operator-framework/operator-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/operator-framework/operator-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/operator-framework/operator-sdk/tags","blobs_url":"https://api.github.com/repos/operator-framework/operator-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/operator-framework/operator-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/operator-framework/operator-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/operator-framework/operator-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/operator-framework/operator-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/operator-framework/operator-sdk/languages","stargazers_url":"https://api.github.com/repos/operator-framework/operator-sdk/stargazers","contributors_url":"https://api.github.com/repos/operator-framework/operator-sdk/contributors","subscribers_url":"https://api.github.com/repos/operator-framework/operator-sdk/subscribers","subscription_url":"https://api.github.com/repos/operator-framework/operator-sdk/subscription","commits_url":"https://api.github.com/repos/operator-framework/operator-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/operator-framework/operator-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/operator-framework/operator-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/operator-framework/operator-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/operator-framework/operator-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/operator-framework/operator-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/operator-framework/operator-sdk/merges","archive_url":"https://api.github.com/repos/operator-framework/operator-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/operator-framework/operator-sdk/downloads","issues_url":"https://api.github.com/repos/operator-framework/operator-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/operator-framework/operator-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/operator-framework/operator-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/operator-framework/operator-sdk/labels{/name}","releases_url":"https://api.github.com/repos/operator-framework/operator-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/operator-framework/operator-sdk/deployments","created_at":"2018-02-07T17:53:51Z","updated_at":"2018-09-19T14:00:51Z","pushed_at":"2018-09-19T15:57:16Z","git_url":"git://github.com/operator-framework/operator-sdk.git","ssh_url":"git@github.com:operator-framework/operator-sdk.git","clone_url":"https://github.com/operator-framework/operator-sdk.git","svn_url":"https://github.com/operator-framework/operator-sdk","homepage":"https://coreos.com/operators","size":1074,"stargazers_count":795,"watchers_count":795,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":137,"open_issues":87,"watchers":795,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/469"},"html":{"href":"https://github.com/operator-framework/operator-sdk/pull/469"},"issue":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/issues/469"},"comments":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/issues/469/comments"},"review_comments":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/469/comments"},"review_comment":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/469/commits"},"statuses":{"href":"https://api.github.com/repos/operator-framework/operator-sdk/statuses/695995d4b8a02fd8eedc92dba6bc5e8bc452e2e7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AlexNPavel"}}