{"action":"created","comment":{"url":"https://api.github.com/repos/liferay/liferay-faces-util/pulls/comments/184238858","pull_request_review_id":115393589,"id":184238858,"diff_hunk":"@@ -39,17 +42,16 @@\n \t// serialVersionUID\n \tprivate static final long serialVersionUID = 4993137243887595902L;\n \n-\tstatic {\n+\t// Private Data Members\n+\tprivate final I18nMap i18nMap = new I18nMap();","path":"src/main/java/com/liferay/faces/util/el/internal/UtilELResolver.java","position":31,"original_position":31,"commit_id":"d81d3160453559c04623a1061d02a454c70c1ad2","original_commit_id":"d81d3160453559c04623a1061d02a454c70c1ad2","user":{"login":"ngriffin7a","id":989387,"avatar_url":"https://avatars2.githubusercontent.com/u/989387?v=4","gravatar_id":"","url":"https://api.github.com/users/ngriffin7a","html_url":"https://github.com/ngriffin7a","followers_url":"https://api.github.com/users/ngriffin7a/followers","following_url":"https://api.github.com/users/ngriffin7a/following{/other_user}","gists_url":"https://api.github.com/users/ngriffin7a/gists{/gist_id}","starred_url":"https://api.github.com/users/ngriffin7a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngriffin7a/subscriptions","organizations_url":"https://api.github.com/users/ngriffin7a/orgs","repos_url":"https://api.github.com/users/ngriffin7a/repos","events_url":"https://api.github.com/users/ngriffin7a/events{/privacy}","received_events_url":"https://api.github.com/users/ngriffin7a/received_events","type":"User","site_admin":false},"body":"@stiemannkj1 As I recall, usage of the final keyword for private data members is not commonly used in the codebase.","created_at":"2018-04-25T23:56:30Z","updated_at":"2018-04-25T23:56:30Z","html_url":"https://github.com/liferay/liferay-faces-util/pull/100#discussion_r184238858","pull_request_url":"https://api.github.com/repos/liferay/liferay-faces-util/pulls/100","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/liferay/liferay-faces-util/pulls/comments/184238858"},"html":{"href":"https://github.com/liferay/liferay-faces-util/pull/100#discussion_r184238858"},"pull_request":{"href":"https://api.github.com/repos/liferay/liferay-faces-util/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/liferay/liferay-faces-util/pulls/100","id":184165327,"html_url":"https://github.com/liferay/liferay-faces-util/pull/100","diff_url":"https://github.com/liferay/liferay-faces-util/pull/100.diff","patch_url":"https://github.com/liferay/liferay-faces-util/pull/100.patch","issue_url":"https://api.github.com/repos/liferay/liferay-faces-util/issues/100","number":100,"state":"open","locked":false,"title":"FACES-3245 Liferay Faces libraries save innapropriate values into static variables and constants","user":{"login":"stiemannkj1","id":3483874,"avatar_url":"https://avatars0.githubusercontent.com/u/3483874?v=4","gravatar_id":"","url":"https://api.github.com/users/stiemannkj1","html_url":"https://github.com/stiemannkj1","followers_url":"https://api.github.com/users/stiemannkj1/followers","following_url":"https://api.github.com/users/stiemannkj1/following{/other_user}","gists_url":"https://api.github.com/users/stiemannkj1/gists{/gist_id}","starred_url":"https://api.github.com/users/stiemannkj1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stiemannkj1/subscriptions","organizations_url":"https://api.github.com/users/stiemannkj1/orgs","repos_url":"https://api.github.com/users/stiemannkj1/repos","events_url":"https://api.github.com/users/stiemannkj1/events{/privacy}","received_events_url":"https://api.github.com/users/stiemannkj1/received_events","type":"User","site_admin":false},"body":"\r\n\r\n@ngriffin7a, this is a pretty big PR, so please take a look at the API changes (and the important impl changes) during your review:\r\n\r\n- [`ExtFacesContext`](https://github.com/liferay/liferay-faces-util/compare/master...stiemannkj1:fix-static-FACES-3245?expand=1#diff-435b3424a69638986213f6ab68885877)\r\n- [`ELResolverBase`](https://github.com/liferay/liferay-faces-util/compare/master...stiemannkj1:fix-static-FACES-3245?expand=1#diff-e090161c344ca07293168b3e69399e1c)\r\n- [`ProductFactory`](https://github.com/liferay/liferay-faces-util/compare/master...stiemannkj1:fix-static-FACES-3245?expand=1#diff-de6fc1e7df84ec6538aabdfc7f9929e7)\r\n\r\nThis commit should be backported to `3.x` **only**.","created_at":"2018-04-25T21:13:49Z","updated_at":"2018-04-25T23:56:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e034362ada44e64343b26ef42c3762bd006909d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/liferay/liferay-faces-util/pulls/100/commits","review_comments_url":"https://api.github.com/repos/liferay/liferay-faces-util/pulls/100/comments","review_comment_url":"https://api.github.com/repos/liferay/liferay-faces-util/pulls/comments{/number}","comments_url":"https://api.github.com/repos/liferay/liferay-faces-util/issues/100/comments","statuses_url":"https://api.github.com/repos/liferay/liferay-faces-util/statuses/d81d3160453559c04623a1061d02a454c70c1ad2","head":{"label":"stiemannkj1:fix-static-FACES-3245","ref":"fix-static-FACES-3245","sha":"d81d3160453559c04623a1061d02a454c70c1ad2","user":{"login":"stiemannkj1","id":3483874,"avatar_url":"https://avatars0.githubusercontent.com/u/3483874?v=4","gravatar_id":"","url":"https://api.github.com/users/stiemannkj1","html_url":"https://github.com/stiemannkj1","followers_url":"https://api.github.com/users/stiemannkj1/followers","following_url":"https://api.github.com/users/stiemannkj1/following{/other_user}","gists_url":"https://api.github.com/users/stiemannkj1/gists{/gist_id}","starred_url":"https://api.github.com/users/stiemannkj1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stiemannkj1/subscriptions","organizations_url":"https://api.github.com/users/stiemannkj1/orgs","repos_url":"https://api.github.com/users/stiemannkj1/repos","events_url":"https://api.github.com/users/stiemannkj1/events{/privacy}","received_events_url":"https://api.github.com/users/stiemannkj1/received_events","type":"User","site_admin":false},"repo":{"id":42178745,"name":"liferay-faces-util","full_name":"stiemannkj1/liferay-faces-util","owner":{"login":"stiemannkj1","id":3483874,"avatar_url":"https://avatars0.githubusercontent.com/u/3483874?v=4","gravatar_id":"","url":"https://api.github.com/users/stiemannkj1","html_url":"https://github.com/stiemannkj1","followers_url":"https://api.github.com/users/stiemannkj1/followers","following_url":"https://api.github.com/users/stiemannkj1/following{/other_user}","gists_url":"https://api.github.com/users/stiemannkj1/gists{/gist_id}","starred_url":"https://api.github.com/users/stiemannkj1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stiemannkj1/subscriptions","organizations_url":"https://api.github.com/users/stiemannkj1/orgs","repos_url":"https://api.github.com/users/stiemannkj1/repos","events_url":"https://api.github.com/users/stiemannkj1/events{/privacy}","received_events_url":"https://api.github.com/users/stiemannkj1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stiemannkj1/liferay-faces-util","description":null,"fork":true,"url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util","forks_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/forks","keys_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/teams","hooks_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/hooks","issue_events_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/issues/events{/number}","events_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/events","assignees_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/assignees{/user}","branches_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/branches{/branch}","tags_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/tags","blobs_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/git/refs{/sha}","trees_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/statuses/{sha}","languages_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/languages","stargazers_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/stargazers","contributors_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/contributors","subscribers_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/subscribers","subscription_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/subscription","commits_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/commits{/sha}","git_commits_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/git/commits{/sha}","comments_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/comments{/number}","issue_comment_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/issues/comments{/number}","contents_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/contents/{+path}","compare_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/merges","archive_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/downloads","issues_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/issues{/number}","pulls_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/pulls{/number}","milestones_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/milestones{/number}","notifications_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/labels{/name}","releases_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/releases{/id}","deployments_url":"https://api.github.com/repos/stiemannkj1/liferay-faces-util/deployments","created_at":"2015-09-09T13:04:41Z","updated_at":"2016-01-15T22:23:46Z","pushed_at":"2018-04-25T21:13:00Z","git_url":"git://github.com/stiemannkj1/liferay-faces-util.git","ssh_url":"git@github.com:stiemannkj1/liferay-faces-util.git","clone_url":"https://github.com/stiemannkj1/liferay-faces-util.git","svn_url":"https://github.com/stiemannkj1/liferay-faces-util","homepage":null,"size":1348,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"liferay:master","ref":"master","sha":"2263a5cac27f20d2555b615985b561a38b472306","user":{"login":"liferay","id":131436,"avatar_url":"https://avatars3.githubusercontent.com/u/131436?v=4","gravatar_id":"","url":"https://api.github.com/users/liferay","html_url":"https://github.com/liferay","followers_url":"https://api.github.com/users/liferay/followers","following_url":"https://api.github.com/users/liferay/following{/other_user}","gists_url":"https://api.github.com/users/liferay/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay/subscriptions","organizations_url":"https://api.github.com/users/liferay/orgs","repos_url":"https://api.github.com/users/liferay/repos","events_url":"https://api.github.com/users/liferay/events{/privacy}","received_events_url":"https://api.github.com/users/liferay/received_events","type":"Organization","site_admin":false},"repo":{"id":41882236,"name":"liferay-faces-util","full_name":"liferay/liferay-faces-util","owner":{"login":"liferay","id":131436,"avatar_url":"https://avatars3.githubusercontent.com/u/131436?v=4","gravatar_id":"","url":"https://api.github.com/users/liferay","html_url":"https://github.com/liferay","followers_url":"https://api.github.com/users/liferay/followers","following_url":"https://api.github.com/users/liferay/following{/other_user}","gists_url":"https://api.github.com/users/liferay/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay/subscriptions","organizations_url":"https://api.github.com/users/liferay/orgs","repos_url":"https://api.github.com/users/liferay/repos","events_url":"https://api.github.com/users/liferay/events{/privacy}","received_events_url":"https://api.github.com/users/liferay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/liferay/liferay-faces-util","description":null,"fork":false,"url":"https://api.github.com/repos/liferay/liferay-faces-util","forks_url":"https://api.github.com/repos/liferay/liferay-faces-util/forks","keys_url":"https://api.github.com/repos/liferay/liferay-faces-util/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liferay/liferay-faces-util/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liferay/liferay-faces-util/teams","hooks_url":"https://api.github.com/repos/liferay/liferay-faces-util/hooks","issue_events_url":"https://api.github.com/repos/liferay/liferay-faces-util/issues/events{/number}","events_url":"https://api.github.com/repos/liferay/liferay-faces-util/events","assignees_url":"https://api.github.com/repos/liferay/liferay-faces-util/assignees{/user}","branches_url":"https://api.github.com/repos/liferay/liferay-faces-util/branches{/branch}","tags_url":"https://api.github.com/repos/liferay/liferay-faces-util/tags","blobs_url":"https://api.github.com/repos/liferay/liferay-faces-util/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liferay/liferay-faces-util/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liferay/liferay-faces-util/git/refs{/sha}","trees_url":"https://api.github.com/repos/liferay/liferay-faces-util/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liferay/liferay-faces-util/statuses/{sha}","languages_url":"https://api.github.com/repos/liferay/liferay-faces-util/languages","stargazers_url":"https://api.github.com/repos/liferay/liferay-faces-util/stargazers","contributors_url":"https://api.github.com/repos/liferay/liferay-faces-util/contributors","subscribers_url":"https://api.github.com/repos/liferay/liferay-faces-util/subscribers","subscription_url":"https://api.github.com/repos/liferay/liferay-faces-util/subscription","commits_url":"https://api.github.com/repos/liferay/liferay-faces-util/commits{/sha}","git_commits_url":"https://api.github.com/repos/liferay/liferay-faces-util/git/commits{/sha}","comments_url":"https://api.github.com/repos/liferay/liferay-faces-util/comments{/number}","issue_comment_url":"https://api.github.com/repos/liferay/liferay-faces-util/issues/comments{/number}","contents_url":"https://api.github.com/repos/liferay/liferay-faces-util/contents/{+path}","compare_url":"https://api.github.com/repos/liferay/liferay-faces-util/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liferay/liferay-faces-util/merges","archive_url":"https://api.github.com/repos/liferay/liferay-faces-util/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liferay/liferay-faces-util/downloads","issues_url":"https://api.github.com/repos/liferay/liferay-faces-util/issues{/number}","pulls_url":"https://api.github.com/repos/liferay/liferay-faces-util/pulls{/number}","milestones_url":"https://api.github.com/repos/liferay/liferay-faces-util/milestones{/number}","notifications_url":"https://api.github.com/repos/liferay/liferay-faces-util/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liferay/liferay-faces-util/labels{/name}","releases_url":"https://api.github.com/repos/liferay/liferay-faces-util/releases{/id}","deployments_url":"https://api.github.com/repos/liferay/liferay-faces-util/deployments","created_at":"2015-09-03T20:31:40Z","updated_at":"2018-04-25T15:20:39Z","pushed_at":"2018-04-25T21:13:50Z","git_url":"git://github.com/liferay/liferay-faces-util.git","ssh_url":"git@github.com:liferay/liferay-faces-util.git","clone_url":"https://github.com/liferay/liferay-faces-util.git","svn_url":"https://github.com/liferay/liferay-faces-util","homepage":null,"size":1161,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":6,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/liferay/liferay-faces-util/pulls/100"},"html":{"href":"https://github.com/liferay/liferay-faces-util/pull/100"},"issue":{"href":"https://api.github.com/repos/liferay/liferay-faces-util/issues/100"},"comments":{"href":"https://api.github.com/repos/liferay/liferay-faces-util/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/liferay/liferay-faces-util/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/liferay/liferay-faces-util/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/liferay/liferay-faces-util/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/liferay/liferay-faces-util/statuses/d81d3160453559c04623a1061d02a454c70c1ad2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ngriffin7a"}}