{"action":"created","comment":{"url":"https://api.github.com/repos/OperationCode/front-end/pulls/comments/229061281","pull_request_review_id":169471056,"id":229061281,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTA2MTI4MQ==","diff_hunk":"@@ -5,20 +5,23 @@ import styles from './Badge.css';\n \n Badge.propTypes = {\n   svgComponent: PropTypes.element.isRequired,\n+  children: PropTypes.element,\n   label: PropTypes.string,\n   labelClassName: PropTypes.string,\n };\n \n Badge.defaultProps = {\n+  children: undefined,\n   label: '',\n   labelClassName: undefined,\n };\n \n-function Badge({ svgComponent, label, labelClassName }) {\n+function Badge({ children, svgComponent, label, labelClassName }) {\n   return (\n     <div className={styles.Badge}>\n       <div className={styles.iconContainer}>{svgComponent}</div>\n       <div className={classNames(styles.centerText, styles.label, labelClassName)}>{label}</div>\n+      {children}","path":"components/Badge/Badge.js","position":21,"original_position":21,"commit_id":"d9887ec871c3717ddf0b4a8e5a07a17a89528398","original_commit_id":"d9887ec871c3717ddf0b4a8e5a07a17a89528398","user":{"login":"kylemh","id":9523719,"node_id":"MDQ6VXNlcjk1MjM3MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9523719?v=4","gravatar_id":"","url":"https://api.github.com/users/kylemh","html_url":"https://github.com/kylemh","followers_url":"https://api.github.com/users/kylemh/followers","following_url":"https://api.github.com/users/kylemh/following{/other_user}","gists_url":"https://api.github.com/users/kylemh/gists{/gist_id}","starred_url":"https://api.github.com/users/kylemh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylemh/subscriptions","organizations_url":"https://api.github.com/users/kylemh/orgs","repos_url":"https://api.github.com/users/kylemh/repos","events_url":"https://api.github.com/users/kylemh/events{/privacy}","received_events_url":"https://api.github.com/users/kylemh/received_events","type":"User","site_admin":false},"body":"This lends itself to a bit of a shaky API - consider what you've gotta handle when passing children and then label.\r\n\r\nI also don't like the idea of needing to hijack `labelClassName` like you would have to do otherwise.\r\n\r\nLet's drop label as a prop and give total control of the children styling to the user via render prop (children).\r\n\r\nCan you make children accept a prop type of element _or_ string _or_ node?\r\n\r\nAlso, when you make those changes, you'll need to fix the few live Badge implementations. It should just be copy-pasting styles from the Badge component to the implementation.\r\n\r\nLastly, don't forget to update the Story for Badge.\r\n\r\nThanks for doing so much work with us! I've got you on the list to get a t-shirt, and if you don't have time to make these changes, don't sweat it. You've already done a lot for me. ❤️ ","created_at":"2018-10-29T19:10:24Z","updated_at":"2018-10-29T19:11:01Z","html_url":"https://github.com/OperationCode/front-end/pull/243#discussion_r229061281","pull_request_url":"https://api.github.com/repos/OperationCode/front-end/pulls/243","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/OperationCode/front-end/pulls/comments/229061281"},"html":{"href":"https://github.com/OperationCode/front-end/pull/243#discussion_r229061281"},"pull_request":{"href":"https://api.github.com/repos/OperationCode/front-end/pulls/243"}}},"pull_request":{"url":"https://api.github.com/repos/OperationCode/front-end/pulls/243","id":226301329,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzAxMzI5","html_url":"https://github.com/OperationCode/front-end/pull/243","diff_url":"https://github.com/OperationCode/front-end/pull/243.diff","patch_url":"https://github.com/OperationCode/front-end/pull/243.patch","issue_url":"https://api.github.com/repos/OperationCode/front-end/issues/243","number":243,"state":"open","locked":false,"title":"Feat: added contact page","user":{"login":"chrisgalvan","id":1694600,"node_id":"MDQ6VXNlcjE2OTQ2MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1694600?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisgalvan","html_url":"https://github.com/chrisgalvan","followers_url":"https://api.github.com/users/chrisgalvan/followers","following_url":"https://api.github.com/users/chrisgalvan/following{/other_user}","gists_url":"https://api.github.com/users/chrisgalvan/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisgalvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisgalvan/subscriptions","organizations_url":"https://api.github.com/users/chrisgalvan/orgs","repos_url":"https://api.github.com/users/chrisgalvan/repos","events_url":"https://api.github.com/users/chrisgalvan/events{/privacy}","received_events_url":"https://api.github.com/users/chrisgalvan/received_events","type":"User","site_admin":false},"body":"Addresses #168 \r\n\r\nNote: I don't have mockup with new styles so I just used current prod page as a guide https://operationcode.org/contact\r\n\r\n![image](https://user-images.githubusercontent.com/1694600/47605814-18119d80-d9d1-11e8-83cf-ba952b1cb44e.png)\r\n","created_at":"2018-10-27T15:13:39Z","updated_at":"2018-10-29T19:11:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3c6b4a68064aa08c998118ba1562fcb61da2c02","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OperationCode/front-end/pulls/243/commits","review_comments_url":"https://api.github.com/repos/OperationCode/front-end/pulls/243/comments","review_comment_url":"https://api.github.com/repos/OperationCode/front-end/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OperationCode/front-end/issues/243/comments","statuses_url":"https://api.github.com/repos/OperationCode/front-end/statuses/d9887ec871c3717ddf0b4a8e5a07a17a89528398","head":{"label":"chrisgalvan:feature/contact","ref":"feature/contact","sha":"d9887ec871c3717ddf0b4a8e5a07a17a89528398","user":{"login":"chrisgalvan","id":1694600,"node_id":"MDQ6VXNlcjE2OTQ2MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1694600?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisgalvan","html_url":"https://github.com/chrisgalvan","followers_url":"https://api.github.com/users/chrisgalvan/followers","following_url":"https://api.github.com/users/chrisgalvan/following{/other_user}","gists_url":"https://api.github.com/users/chrisgalvan/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisgalvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisgalvan/subscriptions","organizations_url":"https://api.github.com/users/chrisgalvan/orgs","repos_url":"https://api.github.com/users/chrisgalvan/repos","events_url":"https://api.github.com/users/chrisgalvan/events{/privacy}","received_events_url":"https://api.github.com/users/chrisgalvan/received_events","type":"User","site_admin":false},"repo":{"id":152790311,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI3OTAzMTE=","name":"front-end","full_name":"chrisgalvan/front-end","private":false,"owner":{"login":"chrisgalvan","id":1694600,"node_id":"MDQ6VXNlcjE2OTQ2MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1694600?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisgalvan","html_url":"https://github.com/chrisgalvan","followers_url":"https://api.github.com/users/chrisgalvan/followers","following_url":"https://api.github.com/users/chrisgalvan/following{/other_user}","gists_url":"https://api.github.com/users/chrisgalvan/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisgalvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisgalvan/subscriptions","organizations_url":"https://api.github.com/users/chrisgalvan/orgs","repos_url":"https://api.github.com/users/chrisgalvan/repos","events_url":"https://api.github.com/users/chrisgalvan/events{/privacy}","received_events_url":"https://api.github.com/users/chrisgalvan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chrisgalvan/front-end","description":"Re-implementation of Operation Code's front-end with best practices, SEO, and performance in mind.","fork":true,"url":"https://api.github.com/repos/chrisgalvan/front-end","forks_url":"https://api.github.com/repos/chrisgalvan/front-end/forks","keys_url":"https://api.github.com/repos/chrisgalvan/front-end/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisgalvan/front-end/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisgalvan/front-end/teams","hooks_url":"https://api.github.com/repos/chrisgalvan/front-end/hooks","issue_events_url":"https://api.github.com/repos/chrisgalvan/front-end/issues/events{/number}","events_url":"https://api.github.com/repos/chrisgalvan/front-end/events","assignees_url":"https://api.github.com/repos/chrisgalvan/front-end/assignees{/user}","branches_url":"https://api.github.com/repos/chrisgalvan/front-end/branches{/branch}","tags_url":"https://api.github.com/repos/chrisgalvan/front-end/tags","blobs_url":"https://api.github.com/repos/chrisgalvan/front-end/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisgalvan/front-end/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisgalvan/front-end/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisgalvan/front-end/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisgalvan/front-end/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisgalvan/front-end/languages","stargazers_url":"https://api.github.com/repos/chrisgalvan/front-end/stargazers","contributors_url":"https://api.github.com/repos/chrisgalvan/front-end/contributors","subscribers_url":"https://api.github.com/repos/chrisgalvan/front-end/subscribers","subscription_url":"https://api.github.com/repos/chrisgalvan/front-end/subscription","commits_url":"https://api.github.com/repos/chrisgalvan/front-end/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisgalvan/front-end/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisgalvan/front-end/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisgalvan/front-end/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisgalvan/front-end/contents/{+path}","compare_url":"https://api.github.com/repos/chrisgalvan/front-end/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisgalvan/front-end/merges","archive_url":"https://api.github.com/repos/chrisgalvan/front-end/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisgalvan/front-end/downloads","issues_url":"https://api.github.com/repos/chrisgalvan/front-end/issues{/number}","pulls_url":"https://api.github.com/repos/chrisgalvan/front-end/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisgalvan/front-end/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisgalvan/front-end/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisgalvan/front-end/labels{/name}","releases_url":"https://api.github.com/repos/chrisgalvan/front-end/releases{/id}","deployments_url":"https://api.github.com/repos/chrisgalvan/front-end/deployments","created_at":"2018-10-12T18:09:16Z","updated_at":"2018-10-26T23:26:56Z","pushed_at":"2018-10-29T14:29:45Z","git_url":"git://github.com/chrisgalvan/front-end.git","ssh_url":"git@github.com:chrisgalvan/front-end.git","clone_url":"https://github.com/chrisgalvan/front-end.git","svn_url":"https://github.com/chrisgalvan/front-end","homepage":"http://operation-code.now.sh","size":3969,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OperationCode:master","ref":"master","sha":"458c5bb45c1f695f959126346accacfb72126076","user":{"login":"OperationCode","id":10479364,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDc5MzY0","avatar_url":"https://avatars3.githubusercontent.com/u/10479364?v=4","gravatar_id":"","url":"https://api.github.com/users/OperationCode","html_url":"https://github.com/OperationCode","followers_url":"https://api.github.com/users/OperationCode/followers","following_url":"https://api.github.com/users/OperationCode/following{/other_user}","gists_url":"https://api.github.com/users/OperationCode/gists{/gist_id}","starred_url":"https://api.github.com/users/OperationCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OperationCode/subscriptions","organizations_url":"https://api.github.com/users/OperationCode/orgs","repos_url":"https://api.github.com/users/OperationCode/repos","events_url":"https://api.github.com/users/OperationCode/events{/privacy}","received_events_url":"https://api.github.com/users/OperationCode/received_events","type":"Organization","site_admin":false},"repo":{"id":135777271,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3NzcyNzE=","name":"front-end","full_name":"OperationCode/front-end","private":false,"owner":{"login":"OperationCode","id":10479364,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDc5MzY0","avatar_url":"https://avatars3.githubusercontent.com/u/10479364?v=4","gravatar_id":"","url":"https://api.github.com/users/OperationCode","html_url":"https://github.com/OperationCode","followers_url":"https://api.github.com/users/OperationCode/followers","following_url":"https://api.github.com/users/OperationCode/following{/other_user}","gists_url":"https://api.github.com/users/OperationCode/gists{/gist_id}","starred_url":"https://api.github.com/users/OperationCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OperationCode/subscriptions","organizations_url":"https://api.github.com/users/OperationCode/orgs","repos_url":"https://api.github.com/users/OperationCode/repos","events_url":"https://api.github.com/users/OperationCode/events{/privacy}","received_events_url":"https://api.github.com/users/OperationCode/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OperationCode/front-end","description":"Re-implementation of Operation Code's front-end with best practices, SEO, and performance in mind.","fork":false,"url":"https://api.github.com/repos/OperationCode/front-end","forks_url":"https://api.github.com/repos/OperationCode/front-end/forks","keys_url":"https://api.github.com/repos/OperationCode/front-end/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OperationCode/front-end/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OperationCode/front-end/teams","hooks_url":"https://api.github.com/repos/OperationCode/front-end/hooks","issue_events_url":"https://api.github.com/repos/OperationCode/front-end/issues/events{/number}","events_url":"https://api.github.com/repos/OperationCode/front-end/events","assignees_url":"https://api.github.com/repos/OperationCode/front-end/assignees{/user}","branches_url":"https://api.github.com/repos/OperationCode/front-end/branches{/branch}","tags_url":"https://api.github.com/repos/OperationCode/front-end/tags","blobs_url":"https://api.github.com/repos/OperationCode/front-end/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OperationCode/front-end/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OperationCode/front-end/git/refs{/sha}","trees_url":"https://api.github.com/repos/OperationCode/front-end/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OperationCode/front-end/statuses/{sha}","languages_url":"https://api.github.com/repos/OperationCode/front-end/languages","stargazers_url":"https://api.github.com/repos/OperationCode/front-end/stargazers","contributors_url":"https://api.github.com/repos/OperationCode/front-end/contributors","subscribers_url":"https://api.github.com/repos/OperationCode/front-end/subscribers","subscription_url":"https://api.github.com/repos/OperationCode/front-end/subscription","commits_url":"https://api.github.com/repos/OperationCode/front-end/commits{/sha}","git_commits_url":"https://api.github.com/repos/OperationCode/front-end/git/commits{/sha}","comments_url":"https://api.github.com/repos/OperationCode/front-end/comments{/number}","issue_comment_url":"https://api.github.com/repos/OperationCode/front-end/issues/comments{/number}","contents_url":"https://api.github.com/repos/OperationCode/front-end/contents/{+path}","compare_url":"https://api.github.com/repos/OperationCode/front-end/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OperationCode/front-end/merges","archive_url":"https://api.github.com/repos/OperationCode/front-end/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OperationCode/front-end/downloads","issues_url":"https://api.github.com/repos/OperationCode/front-end/issues{/number}","pulls_url":"https://api.github.com/repos/OperationCode/front-end/pulls{/number}","milestones_url":"https://api.github.com/repos/OperationCode/front-end/milestones{/number}","notifications_url":"https://api.github.com/repos/OperationCode/front-end/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OperationCode/front-end/labels{/name}","releases_url":"https://api.github.com/repos/OperationCode/front-end/releases{/id}","deployments_url":"https://api.github.com/repos/OperationCode/front-end/deployments","created_at":"2018-06-02T01:23:17Z","updated_at":"2018-10-29T19:03:29Z","pushed_at":"2018-10-29T19:05:29Z","git_url":"git://github.com/OperationCode/front-end.git","ssh_url":"git@github.com:OperationCode/front-end.git","clone_url":"https://github.com/OperationCode/front-end.git","svn_url":"https://github.com/OperationCode/front-end","homepage":"http://operation-code.now.sh","size":4007,"stargazers_count":68,"watchers_count":68,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":51,"open_issues":27,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OperationCode/front-end/pulls/243"},"html":{"href":"https://github.com/OperationCode/front-end/pull/243"},"issue":{"href":"https://api.github.com/repos/OperationCode/front-end/issues/243"},"comments":{"href":"https://api.github.com/repos/OperationCode/front-end/issues/243/comments"},"review_comments":{"href":"https://api.github.com/repos/OperationCode/front-end/pulls/243/comments"},"review_comment":{"href":"https://api.github.com/repos/OperationCode/front-end/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OperationCode/front-end/pulls/243/commits"},"statuses":{"href":"https://api.github.com/repos/OperationCode/front-end/statuses/d9887ec871c3717ddf0b4a8e5a07a17a89528398"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kylemh"}}