{"action":"closed","number":25122,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/25122","id":239706327,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NzA2MzI3","html_url":"https://github.com/nodejs/node/pull/25122","diff_url":"https://github.com/nodejs/node/pull/25122.diff","patch_url":"https://github.com/nodejs/node/pull/25122.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/25122","number":25122,"state":"closed","locked":false,"title":"Update v8.x docs for http request set timeout","user":{"login":"jbunton-atlassian","id":13862371,"node_id":"MDQ6VXNlcjEzODYyMzcx","avatar_url":"https://avatars0.githubusercontent.com/u/13862371?v=4","gravatar_id":"","url":"https://api.github.com/users/jbunton-atlassian","html_url":"https://github.com/jbunton-atlassian","followers_url":"https://api.github.com/users/jbunton-atlassian/followers","following_url":"https://api.github.com/users/jbunton-atlassian/following{/other_user}","gists_url":"https://api.github.com/users/jbunton-atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/jbunton-atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbunton-atlassian/subscriptions","organizations_url":"https://api.github.com/users/jbunton-atlassian/orgs","repos_url":"https://api.github.com/users/jbunton-atlassian/repos","events_url":"https://api.github.com/users/jbunton-atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/jbunton-atlassian/received_events","type":"User","site_admin":false},"body":"When upgrading from Node.js 8 to 10 I hit the behaviour change in #8895. This documentation update would have helped me find the problem faster :)\r\n\r\nAlso see #25121 for an update to the docs on master.\r\n\r\nThanks :)\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-12-19T04:08:38Z","updated_at":"2018-12-19T06:08:39Z","closed_at":"2018-12-19T06:08:39Z","merged_at":null,"merge_commit_sha":"358538d6fd8aae19a6c006b2546b3261d114cc85","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":171787391,"node_id":"MDU6TGFiZWwxNzE3ODczOTE=","url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false},{"id":155267517,"node_id":"MDU6TGFiZWwxNTUyNjc1MTc=","url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false},{"id":191447057,"node_id":"MDU6TGFiZWwxOTE0NDcwNTc=","url":"https://api.github.com/repos/nodejs/node/labels/meta","name":"meta","color":"fef2c0","default":false},{"id":237979054,"node_id":"MDU6TGFiZWwyMzc5NzkwNTQ=","url":"https://api.github.com/repos/nodejs/node/labels/tools","name":"tools","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/25122/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/25122/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/25122/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/b1d62ee77e70687c3900b92c6d8bc2c379cf9e2f","head":{"label":"jbunton-atlassian:update_v8.x_docs_for_http_request_setTimeout","ref":"update_v8.x_docs_for_http_request_setTimeout","sha":"b1d62ee77e70687c3900b92c6d8bc2c379cf9e2f","user":{"login":"jbunton-atlassian","id":13862371,"node_id":"MDQ6VXNlcjEzODYyMzcx","avatar_url":"https://avatars0.githubusercontent.com/u/13862371?v=4","gravatar_id":"","url":"https://api.github.com/users/jbunton-atlassian","html_url":"https://github.com/jbunton-atlassian","followers_url":"https://api.github.com/users/jbunton-atlassian/followers","following_url":"https://api.github.com/users/jbunton-atlassian/following{/other_user}","gists_url":"https://api.github.com/users/jbunton-atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/jbunton-atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbunton-atlassian/subscriptions","organizations_url":"https://api.github.com/users/jbunton-atlassian/orgs","repos_url":"https://api.github.com/users/jbunton-atlassian/repos","events_url":"https://api.github.com/users/jbunton-atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/jbunton-atlassian/received_events","type":"User","site_admin":false},"repo":{"id":92708148,"node_id":"MDEwOlJlcG9zaXRvcnk5MjcwODE0OA==","name":"node","full_name":"jbunton-atlassian/node","private":false,"owner":{"login":"jbunton-atlassian","id":13862371,"node_id":"MDQ6VXNlcjEzODYyMzcx","avatar_url":"https://avatars0.githubusercontent.com/u/13862371?v=4","gravatar_id":"","url":"https://api.github.com/users/jbunton-atlassian","html_url":"https://github.com/jbunton-atlassian","followers_url":"https://api.github.com/users/jbunton-atlassian/followers","following_url":"https://api.github.com/users/jbunton-atlassian/following{/other_user}","gists_url":"https://api.github.com/users/jbunton-atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/jbunton-atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbunton-atlassian/subscriptions","organizations_url":"https://api.github.com/users/jbunton-atlassian/orgs","repos_url":"https://api.github.com/users/jbunton-atlassian/repos","events_url":"https://api.github.com/users/jbunton-atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/jbunton-atlassian/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jbunton-atlassian/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/jbunton-atlassian/node","forks_url":"https://api.github.com/repos/jbunton-atlassian/node/forks","keys_url":"https://api.github.com/repos/jbunton-atlassian/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbunton-atlassian/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbunton-atlassian/node/teams","hooks_url":"https://api.github.com/repos/jbunton-atlassian/node/hooks","issue_events_url":"https://api.github.com/repos/jbunton-atlassian/node/issues/events{/number}","events_url":"https://api.github.com/repos/jbunton-atlassian/node/events","assignees_url":"https://api.github.com/repos/jbunton-atlassian/node/assignees{/user}","branches_url":"https://api.github.com/repos/jbunton-atlassian/node/branches{/branch}","tags_url":"https://api.github.com/repos/jbunton-atlassian/node/tags","blobs_url":"https://api.github.com/repos/jbunton-atlassian/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbunton-atlassian/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbunton-atlassian/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbunton-atlassian/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbunton-atlassian/node/statuses/{sha}","languages_url":"https://api.github.com/repos/jbunton-atlassian/node/languages","stargazers_url":"https://api.github.com/repos/jbunton-atlassian/node/stargazers","contributors_url":"https://api.github.com/repos/jbunton-atlassian/node/contributors","subscribers_url":"https://api.github.com/repos/jbunton-atlassian/node/subscribers","subscription_url":"https://api.github.com/repos/jbunton-atlassian/node/subscription","commits_url":"https://api.github.com/repos/jbunton-atlassian/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbunton-atlassian/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbunton-atlassian/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbunton-atlassian/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbunton-atlassian/node/contents/{+path}","compare_url":"https://api.github.com/repos/jbunton-atlassian/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbunton-atlassian/node/merges","archive_url":"https://api.github.com/repos/jbunton-atlassian/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbunton-atlassian/node/downloads","issues_url":"https://api.github.com/repos/jbunton-atlassian/node/issues{/number}","pulls_url":"https://api.github.com/repos/jbunton-atlassian/node/pulls{/number}","milestones_url":"https://api.github.com/repos/jbunton-atlassian/node/milestones{/number}","notifications_url":"https://api.github.com/repos/jbunton-atlassian/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbunton-atlassian/node/labels{/name}","releases_url":"https://api.github.com/repos/jbunton-atlassian/node/releases{/id}","deployments_url":"https://api.github.com/repos/jbunton-atlassian/node/deployments","created_at":"2017-05-29T05:02:09Z","updated_at":"2018-12-19T04:04:23Z","pushed_at":"2018-12-19T06:08:37Z","git_url":"git://github.com/jbunton-atlassian/node.git","ssh_url":"git@github.com:jbunton-atlassian/node.git","clone_url":"https://github.com/jbunton-atlassian/node.git","svn_url":"https://github.com/jbunton-atlassian/node","homepage":"https://nodejs.org","size":442308,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:v8.x-staging","ref":"v8.x-staging","sha":"ae24aafd40cc4cd44f325e1d0fd03abd8ea50d30","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-12-19T05:59:48Z","pushed_at":"2018-12-19T05:51:32Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":442196,"stargazers_count":56531,"watchers_count":56531,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12488,"mirror_url":null,"archived":false,"open_issues_count":746,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12488,"open_issues":746,"watchers":56531,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/25122"},"html":{"href":"https://github.com/nodejs/node/pull/25122"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/25122"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/25122/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/25122/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/25122/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/b1d62ee77e70687c3900b92c6d8bc2c379cf9e2f"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"jbunton-atlassian"}}