{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/225994650","pull_request_review_id":165706160,"id":225994650,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTk5NDY1MA==","diff_hunk":"@@ -330,44 +396,33 @@ private enum NodeState\n         }\n \n         /// <remarks>\n-        /// Load a graph with root node at entryProjectFile\n+        /// Traverse an evaluated graph\n         /// Maintain the state of each node (InProcess and Processed) to detect cycles\n         /// returns false if loading the graph is not successful\n         /// </remarks>\n-        private (bool success, List<string> projectsInCycle) ProcessNode(ConfigurationMetadata projectToEvaluate,\n-            Dictionary<ConfigurationMetadata, NodeState> nodeState,\n+        private (bool success, List<string> projectsInCycle) DetectCycles(ProjectGraphNode node,\n+            Dictionary<ProjectGraphNode, NodeState> nodeState,\n             ProjectCollection projectCollection,\n             PropertyDictionary<ProjectPropertyInstance> globalProperties)\n         {\n-            nodeState[projectToEvaluate] = NodeState.InProcess;\n-            ProjectGraphNode parsedProject = CreateNewNode(projectToEvaluate, projectCollection);\n-            IEnumerable<ProjectItemInstance> projectReferenceItems = parsedProject.ProjectInstance.GetItems(ProjectReferenceItemName);\n+            nodeState[node] = NodeState.InProcess;\n+            IEnumerable<ProjectItemInstance> projectReferenceItems = node.ProjectInstance.GetItems(ProjectReferenceItemName);\n             foreach (var projectReferenceToParse in projectReferenceItems)\n             {\n-                if (!string.IsNullOrEmpty(projectReferenceToParse.GetMetadataValue(ToolsVersionMetadataName)))\n-                {\n-                    throw new InvalidOperationException(string.Format(\n-                        CultureInfo.InvariantCulture,\n-                        ResourceUtilities.GetResourceString(\n-                            \"ProjectGraphDoesNotSupportProjectReferenceWithToolset\"),\n-                        projectReferenceToParse.EvaluatedInclude,\n-                        parsedProject.ProjectInstance.FullPath));\n-                }\n-\n                 string projectReferenceFullPath = projectReferenceToParse.GetMetadataValue(FullPathMetadataName);","path":"src/Build/Graph/ProjectGraph.cs","position":163,"original_position":163,"commit_id":"ea53dc9d20a20770a52e17ef2dac8b790285dda9","original_commit_id":"ea53dc9d20a20770a52e17ef2dac8b790285dda9","user":{"login":"rainersigwald","id":3347530,"node_id":"MDQ6VXNlcjMzNDc1MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3347530?v=4","gravatar_id":"","url":"https://api.github.com/users/rainersigwald","html_url":"https://github.com/rainersigwald","followers_url":"https://api.github.com/users/rainersigwald/followers","following_url":"https://api.github.com/users/rainersigwald/following{/other_user}","gists_url":"https://api.github.com/users/rainersigwald/gists{/gist_id}","starred_url":"https://api.github.com/users/rainersigwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainersigwald/subscriptions","organizations_url":"https://api.github.com/users/rainersigwald/orgs","repos_url":"https://api.github.com/users/rainersigwald/repos","events_url":"https://api.github.com/users/rainersigwald/events{/privacy}","received_events_url":"https://api.github.com/users/rainersigwald/received_events","type":"User","site_admin":false},"body":"Is this item/metadata manipulation required? Since this is now pushed to after graph construction, can you use the graph directly?","created_at":"2018-10-17T16:01:12Z","updated_at":"2018-10-17T16:05:59Z","html_url":"https://github.com/Microsoft/msbuild/pull/3862#discussion_r225994650","pull_request_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3862","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/225994650"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/3862#discussion_r225994650"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3862"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3862","id":223421819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDIxODE5","html_url":"https://github.com/Microsoft/msbuild/pull/3862","diff_url":"https://github.com/Microsoft/msbuild/pull/3862.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/3862.patch","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/3862","number":3862,"state":"open","locked":false,"title":"Evaluate nodes in parallel","user":{"login":"yash256","id":2836929,"node_id":"MDQ6VXNlcjI4MzY5Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/2836929?v=4","gravatar_id":"","url":"https://api.github.com/users/yash256","html_url":"https://github.com/yash256","followers_url":"https://api.github.com/users/yash256/followers","following_url":"https://api.github.com/users/yash256/following{/other_user}","gists_url":"https://api.github.com/users/yash256/gists{/gist_id}","starred_url":"https://api.github.com/users/yash256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yash256/subscriptions","organizations_url":"https://api.github.com/users/yash256/orgs","repos_url":"https://api.github.com/users/yash256/repos","events_url":"https://api.github.com/users/yash256/events{/privacy}","received_events_url":"https://api.github.com/users/yash256/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-16T23:00:25Z","updated_at":"2018-10-17T16:05:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"627a39a212a590b823e94f57183dfceee7f8f1f3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cdmihai","id":2255729,"node_id":"MDQ6VXNlcjIyNTU3Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2255729?v=4","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3862/commits","review_comments_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3862/comments","review_comment_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/3862/comments","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/ea53dc9d20a20770a52e17ef2dac8b790285dda9","head":{"label":"yash256:parallelEvaluation2","ref":"parallelEvaluation2","sha":"ea53dc9d20a20770a52e17ef2dac8b790285dda9","user":{"login":"yash256","id":2836929,"node_id":"MDQ6VXNlcjI4MzY5Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/2836929?v=4","gravatar_id":"","url":"https://api.github.com/users/yash256","html_url":"https://github.com/yash256","followers_url":"https://api.github.com/users/yash256/followers","following_url":"https://api.github.com/users/yash256/following{/other_user}","gists_url":"https://api.github.com/users/yash256/gists{/gist_id}","starred_url":"https://api.github.com/users/yash256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yash256/subscriptions","organizations_url":"https://api.github.com/users/yash256/orgs","repos_url":"https://api.github.com/users/yash256/repos","events_url":"https://api.github.com/users/yash256/events{/privacy}","received_events_url":"https://api.github.com/users/yash256/received_events","type":"User","site_admin":false},"repo":{"id":145481818,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0ODE4MTg=","name":"msbuild","full_name":"yash256/msbuild","private":false,"owner":{"login":"yash256","id":2836929,"node_id":"MDQ6VXNlcjI4MzY5Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/2836929?v=4","gravatar_id":"","url":"https://api.github.com/users/yash256","html_url":"https://github.com/yash256","followers_url":"https://api.github.com/users/yash256/followers","following_url":"https://api.github.com/users/yash256/following{/other_user}","gists_url":"https://api.github.com/users/yash256/gists{/gist_id}","starred_url":"https://api.github.com/users/yash256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yash256/subscriptions","organizations_url":"https://api.github.com/users/yash256/orgs","repos_url":"https://api.github.com/users/yash256/repos","events_url":"https://api.github.com/users/yash256/events{/privacy}","received_events_url":"https://api.github.com/users/yash256/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yash256/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":true,"url":"https://api.github.com/repos/yash256/msbuild","forks_url":"https://api.github.com/repos/yash256/msbuild/forks","keys_url":"https://api.github.com/repos/yash256/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yash256/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yash256/msbuild/teams","hooks_url":"https://api.github.com/repos/yash256/msbuild/hooks","issue_events_url":"https://api.github.com/repos/yash256/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/yash256/msbuild/events","assignees_url":"https://api.github.com/repos/yash256/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/yash256/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/yash256/msbuild/tags","blobs_url":"https://api.github.com/repos/yash256/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yash256/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yash256/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/yash256/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yash256/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/yash256/msbuild/languages","stargazers_url":"https://api.github.com/repos/yash256/msbuild/stargazers","contributors_url":"https://api.github.com/repos/yash256/msbuild/contributors","subscribers_url":"https://api.github.com/repos/yash256/msbuild/subscribers","subscription_url":"https://api.github.com/repos/yash256/msbuild/subscription","commits_url":"https://api.github.com/repos/yash256/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/yash256/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/yash256/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/yash256/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/yash256/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/yash256/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yash256/msbuild/merges","archive_url":"https://api.github.com/repos/yash256/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yash256/msbuild/downloads","issues_url":"https://api.github.com/repos/yash256/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/yash256/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/yash256/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/yash256/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yash256/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/yash256/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/yash256/msbuild/deployments","created_at":"2018-08-20T23:45:49Z","updated_at":"2018-09-12T16:33:31Z","pushed_at":"2018-10-16T22:57:43Z","git_url":"git://github.com/yash256/msbuild.git","ssh_url":"git@github.com:yash256/msbuild.git","clone_url":"https://github.com/yash256/msbuild.git","svn_url":"https://github.com/yash256/msbuild","homepage":null,"size":32677,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:exp/net472","ref":"exp/net472","sha":"00fd648dfe2b9777a2106ff8843894f1ea113509","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32051890,"node_id":"MDEwOlJlcG9zaXRvcnkzMjA1MTg5MA==","name":"msbuild","full_name":"Microsoft/msbuild","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/msbuild","forks_url":"https://api.github.com/repos/Microsoft/msbuild/forks","keys_url":"https://api.github.com/repos/Microsoft/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/msbuild/teams","hooks_url":"https://api.github.com/repos/Microsoft/msbuild/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/msbuild/events","assignees_url":"https://api.github.com/repos/Microsoft/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/msbuild/tags","blobs_url":"https://api.github.com/repos/Microsoft/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/msbuild/languages","stargazers_url":"https://api.github.com/repos/Microsoft/msbuild/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/msbuild/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/msbuild/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/msbuild/subscription","commits_url":"https://api.github.com/repos/Microsoft/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/msbuild/merges","archive_url":"https://api.github.com/repos/Microsoft/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/msbuild/downloads","issues_url":"https://api.github.com/repos/Microsoft/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/msbuild/deployments","created_at":"2015-03-12T02:04:46Z","updated_at":"2018-10-17T13:28:46Z","pushed_at":"2018-10-17T01:02:00Z","git_url":"git://github.com/Microsoft/msbuild.git","ssh_url":"git@github.com:Microsoft/msbuild.git","clone_url":"https://github.com/Microsoft/msbuild.git","svn_url":"https://github.com/Microsoft/msbuild","homepage":null,"size":32741,"stargazers_count":3643,"watchers_count":3643,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":828,"mirror_url":null,"archived":false,"open_issues_count":971,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":828,"open_issues":971,"watchers":3643,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3862"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/3862"},"issue":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/3862"},"comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/3862/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3862/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3862/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/msbuild/statuses/ea53dc9d20a20770a52e17ef2dac8b790285dda9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rainersigwald"}}