{"action":"created","comment":{"url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/pulls/comments/222527754","pull_request_review_id":161435278,"id":222527754,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjUyNzc1NA==","diff_hunk":"@@ -25,19 +27,24 @@ class RepositoryImpl constructor(\n     }\n \n \n-    override fun addFavoriteMovie(movie: Movie?): Long {\n-        return roomMovieDao.insertMovie(movie)\n+    override fun addFavoriteMovie(movie: Movie?) {\n+        doAsync {\n+            roomMovieDao.insertMovie(movie)\n+        }","path":"app/src/main/java/com/tranhoabinh/framgia/moviedbkotlin/data/repository/RepositoryImpl.kt","position":21,"original_position":21,"commit_id":"db322d06c1aac6853d22cc41cf17bd64e083c746","original_commit_id":"db322d06c1aac6853d22cc41cf17bd64e083c746","user":{"login":"mrprona92","id":17597284,"node_id":"MDQ6VXNlcjE3NTk3Mjg0","avatar_url":"https://avatars2.githubusercontent.com/u/17597284?v=4","gravatar_id":"","url":"https://api.github.com/users/mrprona92","html_url":"https://github.com/mrprona92","followers_url":"https://api.github.com/users/mrprona92/followers","following_url":"https://api.github.com/users/mrprona92/following{/other_user}","gists_url":"https://api.github.com/users/mrprona92/gists{/gist_id}","starred_url":"https://api.github.com/users/mrprona92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrprona92/subscriptions","organizations_url":"https://api.github.com/users/mrprona92/orgs","repos_url":"https://api.github.com/users/mrprona92/repos","events_url":"https://api.github.com/users/mrprona92/events{/privacy}","received_events_url":"https://api.github.com/users/mrprona92/received_events","type":"User","site_admin":false},"body":"a search thì thấy anko cũng có handle error. a đang gặp bug backstack cần fix trước nên phần handle error a sẽ tìm hiểu và thêm vào sau. https://medium.com/@andrea.bresolin/playing-with-kotlin-in-android-coroutines-and-how-to-get-rid-of-the-callback-hell-a96e817c108b","created_at":"2018-10-04T03:20:25Z","updated_at":"2018-10-04T03:20:25Z","html_url":"https://github.com/mrprona92/MovieDB-Kotlin/pull/8#discussion_r222527754","pull_request_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/pulls/8","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/pulls/comments/222527754"},"html":{"href":"https://github.com/mrprona92/MovieDB-Kotlin/pull/8#discussion_r222527754"},"pull_request":{"href":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/pulls/8"}},"in_reply_to_id":222520037},"pull_request":{"url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/pulls/8","id":219992508,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTkyNTA4","html_url":"https://github.com/mrprona92/MovieDB-Kotlin/pull/8","diff_url":"https://github.com/mrprona92/MovieDB-Kotlin/pull/8.diff","patch_url":"https://github.com/mrprona92/MovieDB-Kotlin/pull/8.patch","issue_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/issues/8","number":8,"state":"open","locked":false,"title":"[Task6] Favorite list, fix bug layout","user":{"login":"mrprona92","id":17597284,"node_id":"MDQ6VXNlcjE3NTk3Mjg0","avatar_url":"https://avatars2.githubusercontent.com/u/17597284?v=4","gravatar_id":"","url":"https://api.github.com/users/mrprona92","html_url":"https://github.com/mrprona92","followers_url":"https://api.github.com/users/mrprona92/followers","following_url":"https://api.github.com/users/mrprona92/following{/other_user}","gists_url":"https://api.github.com/users/mrprona92/gists{/gist_id}","starred_url":"https://api.github.com/users/mrprona92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrprona92/subscriptions","organizations_url":"https://api.github.com/users/mrprona92/orgs","repos_url":"https://api.github.com/users/mrprona92/repos","events_url":"https://api.github.com/users/mrprona92/events{/privacy}","received_events_url":"https://api.github.com/users/mrprona92/received_events","type":"User","site_admin":false},"body":"**Description:** \r\n\r\n[Task6-FavoriteMovie]  Favorite list, fix bug layout\r\n\r\n**Affected:** \r\n\r\n- Favorite list, fix bug layout\r\n\r\n**Reference:**\r\n-https://docs.google.com/spreadsheets/d/1jPalufqXsgZbV0lR7ZGd3ZbZeqUXaVC5WFkCLJpa7AI/edit#gid=1201469719\r\n\r\n**Checklist:** \r\n- N/A\r\n","created_at":"2018-10-03T10:49:51Z","updated_at":"2018-10-04T03:20:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d9db2786d21353642d3b1d6687245a3d8b428d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/pulls/8/commits","review_comments_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/pulls/8/comments","review_comment_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/issues/8/comments","statuses_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/statuses/db322d06c1aac6853d22cc41cf17bd64e083c746","head":{"label":"mrprona92:develop","ref":"develop","sha":"db322d06c1aac6853d22cc41cf17bd64e083c746","user":{"login":"mrprona92","id":17597284,"node_id":"MDQ6VXNlcjE3NTk3Mjg0","avatar_url":"https://avatars2.githubusercontent.com/u/17597284?v=4","gravatar_id":"","url":"https://api.github.com/users/mrprona92","html_url":"https://github.com/mrprona92","followers_url":"https://api.github.com/users/mrprona92/followers","following_url":"https://api.github.com/users/mrprona92/following{/other_user}","gists_url":"https://api.github.com/users/mrprona92/gists{/gist_id}","starred_url":"https://api.github.com/users/mrprona92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrprona92/subscriptions","organizations_url":"https://api.github.com/users/mrprona92/orgs","repos_url":"https://api.github.com/users/mrprona92/repos","events_url":"https://api.github.com/users/mrprona92/events{/privacy}","received_events_url":"https://api.github.com/users/mrprona92/received_events","type":"User","site_admin":false},"repo":{"id":149585059,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk1ODUwNTk=","name":"MovieDB-Kotlin","full_name":"mrprona92/MovieDB-Kotlin","private":false,"owner":{"login":"mrprona92","id":17597284,"node_id":"MDQ6VXNlcjE3NTk3Mjg0","avatar_url":"https://avatars2.githubusercontent.com/u/17597284?v=4","gravatar_id":"","url":"https://api.github.com/users/mrprona92","html_url":"https://github.com/mrprona92","followers_url":"https://api.github.com/users/mrprona92/followers","following_url":"https://api.github.com/users/mrprona92/following{/other_user}","gists_url":"https://api.github.com/users/mrprona92/gists{/gist_id}","starred_url":"https://api.github.com/users/mrprona92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrprona92/subscriptions","organizations_url":"https://api.github.com/users/mrprona92/orgs","repos_url":"https://api.github.com/users/mrprona92/repos","events_url":"https://api.github.com/users/mrprona92/events{/privacy}","received_events_url":"https://api.github.com/users/mrprona92/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mrprona92/MovieDB-Kotlin","description":null,"fork":false,"url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin","forks_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/forks","keys_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/teams","hooks_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/hooks","issue_events_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/issues/events{/number}","events_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/events","assignees_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/assignees{/user}","branches_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/branches{/branch}","tags_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/tags","blobs_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/statuses/{sha}","languages_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/languages","stargazers_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/stargazers","contributors_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/contributors","subscribers_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/subscribers","subscription_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/subscription","commits_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/contents/{+path}","compare_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/merges","archive_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/downloads","issues_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/issues{/number}","pulls_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/pulls{/number}","milestones_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/milestones{/number}","notifications_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/labels{/name}","releases_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/releases{/id}","deployments_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/deployments","created_at":"2018-09-20T09:29:14Z","updated_at":"2018-10-03T10:43:33Z","pushed_at":"2018-10-03T10:49:51Z","git_url":"git://github.com/mrprona92/MovieDB-Kotlin.git","ssh_url":"git@github.com:mrprona92/MovieDB-Kotlin.git","clone_url":"https://github.com/mrprona92/MovieDB-Kotlin.git","svn_url":"https://github.com/mrprona92/MovieDB-Kotlin","homepage":null,"size":235,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mrprona92:master","ref":"master","sha":"d53de1c46ce5ddc26d0a1987487b193cf6ec379c","user":{"login":"mrprona92","id":17597284,"node_id":"MDQ6VXNlcjE3NTk3Mjg0","avatar_url":"https://avatars2.githubusercontent.com/u/17597284?v=4","gravatar_id":"","url":"https://api.github.com/users/mrprona92","html_url":"https://github.com/mrprona92","followers_url":"https://api.github.com/users/mrprona92/followers","following_url":"https://api.github.com/users/mrprona92/following{/other_user}","gists_url":"https://api.github.com/users/mrprona92/gists{/gist_id}","starred_url":"https://api.github.com/users/mrprona92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrprona92/subscriptions","organizations_url":"https://api.github.com/users/mrprona92/orgs","repos_url":"https://api.github.com/users/mrprona92/repos","events_url":"https://api.github.com/users/mrprona92/events{/privacy}","received_events_url":"https://api.github.com/users/mrprona92/received_events","type":"User","site_admin":false},"repo":{"id":149585059,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk1ODUwNTk=","name":"MovieDB-Kotlin","full_name":"mrprona92/MovieDB-Kotlin","private":false,"owner":{"login":"mrprona92","id":17597284,"node_id":"MDQ6VXNlcjE3NTk3Mjg0","avatar_url":"https://avatars2.githubusercontent.com/u/17597284?v=4","gravatar_id":"","url":"https://api.github.com/users/mrprona92","html_url":"https://github.com/mrprona92","followers_url":"https://api.github.com/users/mrprona92/followers","following_url":"https://api.github.com/users/mrprona92/following{/other_user}","gists_url":"https://api.github.com/users/mrprona92/gists{/gist_id}","starred_url":"https://api.github.com/users/mrprona92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrprona92/subscriptions","organizations_url":"https://api.github.com/users/mrprona92/orgs","repos_url":"https://api.github.com/users/mrprona92/repos","events_url":"https://api.github.com/users/mrprona92/events{/privacy}","received_events_url":"https://api.github.com/users/mrprona92/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mrprona92/MovieDB-Kotlin","description":null,"fork":false,"url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin","forks_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/forks","keys_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/teams","hooks_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/hooks","issue_events_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/issues/events{/number}","events_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/events","assignees_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/assignees{/user}","branches_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/branches{/branch}","tags_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/tags","blobs_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/statuses/{sha}","languages_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/languages","stargazers_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/stargazers","contributors_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/contributors","subscribers_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/subscribers","subscription_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/subscription","commits_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/contents/{+path}","compare_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/merges","archive_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/downloads","issues_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/issues{/number}","pulls_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/pulls{/number}","milestones_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/milestones{/number}","notifications_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/labels{/name}","releases_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/releases{/id}","deployments_url":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/deployments","created_at":"2018-09-20T09:29:14Z","updated_at":"2018-10-03T10:43:33Z","pushed_at":"2018-10-03T10:49:51Z","git_url":"git://github.com/mrprona92/MovieDB-Kotlin.git","ssh_url":"git@github.com:mrprona92/MovieDB-Kotlin.git","clone_url":"https://github.com/mrprona92/MovieDB-Kotlin.git","svn_url":"https://github.com/mrprona92/MovieDB-Kotlin","homepage":null,"size":235,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/pulls/8"},"html":{"href":"https://github.com/mrprona92/MovieDB-Kotlin/pull/8"},"issue":{"href":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/issues/8"},"comments":{"href":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/mrprona92/MovieDB-Kotlin/statuses/db322d06c1aac6853d22cc41cf17bd64e083c746"}},"author_association":"OWNER"}}
{"actor":{"display_login":"mrprona92"}}