{"action":"created","issue":{"url":"https://api.github.com/repos/Slicer/Slicer/issues/911","repository_url":"https://api.github.com/repos/Slicer/Slicer","labels_url":"https://api.github.com/repos/Slicer/Slicer/issues/911/labels{/name}","comments_url":"https://api.github.com/repos/Slicer/Slicer/issues/911/comments","events_url":"https://api.github.com/repos/Slicer/Slicer/issues/911/events","html_url":"https://github.com/Slicer/Slicer/pull/911","id":303557409,"number":911,"title":"ENH: Added performance related options to GPU volume rendering","user":{"login":"cpinter","id":1325980,"avatar_url":"https://avatars0.githubusercontent.com/u/1325980?v=4","gravatar_id":"","url":"https://api.github.com/users/cpinter","html_url":"https://github.com/cpinter","followers_url":"https://api.github.com/users/cpinter/followers","following_url":"https://api.github.com/users/cpinter/following{/other_user}","gists_url":"https://api.github.com/users/cpinter/gists{/gist_id}","starred_url":"https://api.github.com/users/cpinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpinter/subscriptions","organizations_url":"https://api.github.com/users/cpinter/orgs","repos_url":"https://api.github.com/users/cpinter/repos","events_url":"https://api.github.com/users/cpinter/events{/privacy}","received_events_url":"https://api.github.com/users/cpinter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-03-08T17:06:49Z","updated_at":"2018-03-10T19:03:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Slicer/Slicer/pulls/911","html_url":"https://github.com/Slicer/Slicer/pull/911","diff_url":"https://github.com/Slicer/Slicer/pull/911.diff","patch_url":"https://github.com/Slicer/Slicer/pull/911.patch"},"body":"- Added option to use the mapper's feature LockSampleDistanceToInputSpacing to calculate it internally instead of setting sampling distance manually. Off by default. This applies only for GPU rendering. If it's on, then AutoAdjustSampleDistances is disabled, because it prevents using this feature. Because of this, if the flag is on, then the MaximumQuality and AdaptiveQuality setting does not work\r\n- Added UseJittering option to GPU display node. If turned on, then uses random noise to remove the wood-grain artifact. Off by default. Not exposed on the UI yet\r\n- Widened range of FPS slider for adaptive mode to accommodate for new virtual reality use cases (maximum used to be 20, now it is 100)\r\n- Removed empty \"Misc\" tab from Volume rendering module UI\r\n- Fixed ctkDoubleSlider related warning message\r\n- Modernized vtkMRMLVolumeRenderingDisplayNode to use node references and new property macros. This fixed several bugs as well (e.g. not reading/writing attributes)"},"comment":{"url":"https://api.github.com/repos/Slicer/Slicer/issues/comments/372056068","html_url":"https://github.com/Slicer/Slicer/pull/911#issuecomment-372056068","issue_url":"https://api.github.com/repos/Slicer/Slicer/issues/911","id":372056068,"user":{"login":"cpinter","id":1325980,"avatar_url":"https://avatars0.githubusercontent.com/u/1325980?v=4","gravatar_id":"","url":"https://api.github.com/users/cpinter","html_url":"https://github.com/cpinter","followers_url":"https://api.github.com/users/cpinter/followers","following_url":"https://api.github.com/users/cpinter/following{/other_user}","gists_url":"https://api.github.com/users/cpinter/gists{/gist_id}","starred_url":"https://api.github.com/users/cpinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpinter/subscriptions","organizations_url":"https://api.github.com/users/cpinter/orgs","repos_url":"https://api.github.com/users/cpinter/repos","events_url":"https://api.github.com/users/cpinter/events{/privacy}","received_events_url":"https://api.github.com/users/cpinter/received_events","type":"User","site_admin":false},"created_at":"2018-03-10T19:03:55Z","updated_at":"2018-03-10T19:03:55Z","author_association":"CONTRIBUTOR","body":"This is known, please read above\n\nOn March 10, 2018 13:52:51 Hollister Herhold <notifications@github.com> wrote:\n\nI've tried setting rendering quality to Adaptive and Maximum, and I see no difference in quality or frame rate. (This is contrasted with 4.8.1 where there is a big difference in quality and frame rate.) I can post a screen capture movie if that would help.\n\n—\nYou are receiving this because you authored the thread.\nReply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSlicer%2FSlicer%2Fpull%2F911%23issuecomment-372055096&data=02%7C01%7Ccsaba.pinter%40queensu.ca%7Cc24f9c5917c44dcd7fcc08d586b81f59%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636563047712891139&sdata=%2Bn%2FwFe0AlfyOVbX48n%2B4c%2B6nzMhBRhDsOtM2VAd0VdU%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABQ7nM6ofnMr17UIRors96RRS2paRoJfks5tdCEAgaJpZM4SjBQJ&data=02%7C01%7Ccsaba.pinter%40queensu.ca%7Cc24f9c5917c44dcd7fcc08d586b81f59%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636563047712891139&sdata=5CyOH%2FeKVXuoxJJi1Vh%2Bml2VD9gaOE3griB3%2BXLRUow%3D&reserved=0>.\n"}}
{"actor":{"display_login":"cpinter"}}