{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/20879","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/20879/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/20879/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/20879/events","html_url":"https://github.com/facebook/react-native/issues/20879","id":354464947,"node_id":"MDU6SXNzdWUzNTQ0NjQ5NDc=","number":20879,"title":"App submitted to App Store requires NSLocationAlwaysUsageDescription and NSLocationWhenInUseUsageDescription in Info.plist even if not using Geolocation","user":{"login":"fiznool","id":820863,"node_id":"MDQ6VXNlcjgyMDg2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/820863?v=4","gravatar_id":"","url":"https://api.github.com/users/fiznool","html_url":"https://github.com/fiznool","followers_url":"https://api.github.com/users/fiznool/followers","following_url":"https://api.github.com/users/fiznool/following{/other_user}","gists_url":"https://api.github.com/users/fiznool/gists{/gist_id}","starred_url":"https://api.github.com/users/fiznool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiznool/subscriptions","organizations_url":"https://api.github.com/users/fiznool/orgs","repos_url":"https://api.github.com/users/fiznool/repos","events_url":"https://api.github.com/users/fiznool/events{/privacy}","received_events_url":"https://api.github.com/users/fiznool/received_events","type":"User","site_admin":false},"labels":[{"id":257497884,"node_id":"MDU6TGFiZWwyNTc0OTc4ODQ=","url":"https://api.github.com/repos/facebook/react-native/labels/%F0%9F%94%B7iOS","name":"🔷iOS","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-08-27T20:25:15Z","updated_at":"2018-11-01T00:11:19Z","closed_at":null,"author_association":"NONE","body":"<!-- Requirements: please go through this checklist before opening a new issue -->\r\n  - [x] Review the documentation: https://facebook.github.io/react-native\r\n  - [x] Search for existing issues: https://github.com/facebook/react-native/issues\r\n  - [x] Use the latest React Native release: https://github.com/facebook/react-native/releases\r\n\r\n## Environment\r\nRun `react-native info` in your terminal and paste its contents here.\r\n\r\n```\r\n  React Native Environment Info:\r\n    System:\r\n      OS: macOS High Sierra 10.13.6\r\n      CPU: x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz\r\n      Memory: 93.31 MB / 16.00 GB\r\n      Shell: 5.3 - /bin/zsh\r\n    Binaries:\r\n      Node: 10.9.0 - /usr/local/bin/node\r\n      Yarn: 1.9.4 - /usr/local/bin/yarn\r\n      npm: 6.2.0 - /usr/local/bin/npm\r\n      Watchman: 4.9.0 - /usr/local/bin/watchman\r\n    SDKs:\r\n      iOS SDK:\r\n        Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3\r\n      Android SDK:\r\n        Build Tools: 23.0.1, 25.0.2, 26.0.3, 27.0.3, 28.0.0, 28.0.1\r\n        API Levels: 23, 25, 26, 27, 28\r\n    IDEs:\r\n      Android Studio: 3.1 AI-173.4819257\r\n      Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild\r\n    npmPackages:\r\n      react: 16.4.2 => 16.4.2\r\n      react-native: 0.56.0 => 0.56.0\r\n    npmGlobalPackages:\r\n      calvium-react-native-cli: 0.9.1\r\n      create-react-native-app: 1.0.0\r\n      react-native-cli: 2.0.1\r\n      react-native-git-upgrade: 0.2.7\r\n```\r\n\r\n## Description\r\n\r\nBuilding a RN app and submitting to the Apple App Store results in an automated email, asking to add the following keys to the Info.plist file:\r\n\r\n- NSLocationAlwaysUsageDescription\r\n- NSLocationWhenInUseUsageDescription\r\n\r\nThis happens even if you don't use Geolocation at all in your app.\r\n\r\nThe source of the issue appears to be the use of `requestAlwaysAuthorization` and `requestWhenInUseAuthorization` [here](https://github.com/facebook/react-native/blob/5c2720b089dd0fb277771b0ac8b0e7788c493e5d/Libraries/Geolocation/RCTLocationObserver.m#L207-L220). It seems that the presence of these API calls in the bundled app code is enough to trigger the request for the necessary keys to be added to the Info.plist file.\r\n\r\nRelated issue on the Expo forums: https://forums.expo.io/t/rejected-from-app-store-missing-location-string/13029/3\r\n\r\n## Reproducible Demo\r\n\r\n`react-native init SampleApp`\r\n\r\nBuild the app for release, upload to the App Store.\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/434889232","html_url":"https://github.com/facebook/react-native/issues/20879#issuecomment-434889232","issue_url":"https://api.github.com/repos/facebook/react-native/issues/20879","id":434889232,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDg4OTIzMg==","user":{"login":"manask88","id":694340,"node_id":"MDQ6VXNlcjY5NDM0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/694340?v=4","gravatar_id":"","url":"https://api.github.com/users/manask88","html_url":"https://github.com/manask88","followers_url":"https://api.github.com/users/manask88/followers","following_url":"https://api.github.com/users/manask88/following{/other_user}","gists_url":"https://api.github.com/users/manask88/gists{/gist_id}","starred_url":"https://api.github.com/users/manask88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manask88/subscriptions","organizations_url":"https://api.github.com/users/manask88/orgs","repos_url":"https://api.github.com/users/manask88/repos","events_url":"https://api.github.com/users/manask88/events{/privacy}","received_events_url":"https://api.github.com/users/manask88/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T00:11:19Z","updated_at":"2018-11-01T00:11:19Z","author_association":"CONTRIBUTOR","body":"anybody still getting this warning? The last time i got this was on Aug 31. It seems like the code in RCTLocationObserver is still the same so i wonder what happened. Perhaps Apple is now smarter about this?"}}
{"actor":{"display_login":"manask88"}}