{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/229073257","pull_request_review_id":169486162,"id":229073257,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTA3MzI1Nw==","diff_hunk":"@@ -113,6 +113,16 @@ public override void Execute()\n \n             MNM.ConnectivityParameters parameters = new MNM.ConnectivityParameters();\n \n+            if (string.IsNullOrEmpty(this.DestinationId) && string.IsNullOrEmpty(this.DestinationAddress))\n+            {\n+                throw new ArgumentException(\"Connectivity check missing destination resource id or address\");","path":"src/ResourceManager/Network/Commands.Network/NetworkWatcher/TestAzureNetworkWatcherConnectivityCommand.cs","position":6,"original_position":6,"commit_id":"4c24af5e6ea8efda4227a14017d54e2e8a7b6965","original_commit_id":"4c24af5e6ea8efda4227a14017d54e2e8a7b6965","user":{"login":"markcowl","id":1054056,"node_id":"MDQ6VXNlcjEwNTQwNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1054056?v=4","gravatar_id":"","url":"https://api.github.com/users/markcowl","html_url":"https://github.com/markcowl","followers_url":"https://api.github.com/users/markcowl/followers","following_url":"https://api.github.com/users/markcowl/following{/other_user}","gists_url":"https://api.github.com/users/markcowl/gists{/gist_id}","starred_url":"https://api.github.com/users/markcowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markcowl/subscriptions","organizations_url":"https://api.github.com/users/markcowl/orgs","repos_url":"https://api.github.com/users/markcowl/repos","events_url":"https://api.github.com/users/markcowl/events{/privacy}","received_events_url":"https://api.github.com/users/markcowl/received_events","type":"User","site_admin":false},"body":"Please put these customer facing strings into the resource strings for this project","created_at":"2018-10-29T19:49:27Z","updated_at":"2018-10-29T19:49:50Z","html_url":"https://github.com/Azure/azure-powershell/pull/7697#discussion_r229073257","pull_request_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7697","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/229073257"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/7697#discussion_r229073257"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7697"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7697","id":226674996,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2Njc0OTk2","html_url":"https://github.com/Azure/azure-powershell/pull/7697","diff_url":"https://github.com/Azure/azure-powershell/pull/7697.diff","patch_url":"https://github.com/Azure/azure-powershell/pull/7697.patch","issue_url":"https://api.github.com/repos/Azure/azure-powershell/issues/7697","number":7697,"state":"open","locked":false,"title":"add more check on destination id, address and port for connectivity c…","user":{"login":"junyezhu","id":38572086,"node_id":"MDQ6VXNlcjM4NTcyMDg2","avatar_url":"https://avatars0.githubusercontent.com/u/38572086?v=4","gravatar_id":"","url":"https://api.github.com/users/junyezhu","html_url":"https://github.com/junyezhu","followers_url":"https://api.github.com/users/junyezhu/followers","following_url":"https://api.github.com/users/junyezhu/following{/other_user}","gists_url":"https://api.github.com/users/junyezhu/gists{/gist_id}","starred_url":"https://api.github.com/users/junyezhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junyezhu/subscriptions","organizations_url":"https://api.github.com/users/junyezhu/orgs","repos_url":"https://api.github.com/users/junyezhu/repos","events_url":"https://api.github.com/users/junyezhu/events{/privacy}","received_events_url":"https://api.github.com/users/junyezhu/received_events","type":"User","site_admin":false},"body":"…heck cmdlet\r\n\r\n<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\n\r\n<!-- Please add a brief description of the changes made in this PR -->\r\n\r\n## Checklist\r\n\r\n- [x] I have read the [_Submitting Changes_](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#submitting-changes) section of [`CONTRIBUTING.md`](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md)\r\n- [x] The title of the PR is clear and informative\r\n- [x] The appropriate [change log has been updated](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#updating-the-change-log)\r\n- [x] The PR does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/preview/documentation/breaking-changes/breaking-changes-definition.md)\r\n- [x] If applicable, the changes made in the PR have proper test coverage\r\n- [x] For public API changes to cmdlets:\r\n    - [x] the changes have gone through a [cmdlet design review](https://github.com/Azure/azure-powershell-cmdlet-review-pr) (Microsoft internal partners only)\r\n    - [x] the cmdlet markdown files were [generated using the `platyPS` module](https://github.com/Azure/azure-powershell/blob/preview/documentation/development-docs/help-generation.md)\r\n","created_at":"2018-10-29T18:52:37Z","updated_at":"2018-10-29T19:49:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3807e09ce7c818146cfd32de964f915a8d29816d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1056158818,"node_id":"MDU6TGFiZWwxMDU2MTU4ODE4","url":"https://api.github.com/repos/Azure/azure-powershell/labels/needs-review","name":"needs-review","color":"fbcfff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7697/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7697/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/issues/7697/comments","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/4c24af5e6ea8efda4227a14017d54e2e8a7b6965","head":{"label":"junyezhu:juliet/feat/updateconnectivitycheck","ref":"juliet/feat/updateconnectivitycheck","sha":"4c24af5e6ea8efda4227a14017d54e2e8a7b6965","user":{"login":"junyezhu","id":38572086,"node_id":"MDQ6VXNlcjM4NTcyMDg2","avatar_url":"https://avatars0.githubusercontent.com/u/38572086?v=4","gravatar_id":"","url":"https://api.github.com/users/junyezhu","html_url":"https://github.com/junyezhu","followers_url":"https://api.github.com/users/junyezhu/followers","following_url":"https://api.github.com/users/junyezhu/following{/other_user}","gists_url":"https://api.github.com/users/junyezhu/gists{/gist_id}","starred_url":"https://api.github.com/users/junyezhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junyezhu/subscriptions","organizations_url":"https://api.github.com/users/junyezhu/orgs","repos_url":"https://api.github.com/users/junyezhu/repos","events_url":"https://api.github.com/users/junyezhu/events{/privacy}","received_events_url":"https://api.github.com/users/junyezhu/received_events","type":"User","site_admin":false},"repo":{"id":130416278,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA0MTYyNzg=","name":"azure-powershell","full_name":"junyezhu/azure-powershell","private":false,"owner":{"login":"junyezhu","id":38572086,"node_id":"MDQ6VXNlcjM4NTcyMDg2","avatar_url":"https://avatars0.githubusercontent.com/u/38572086?v=4","gravatar_id":"","url":"https://api.github.com/users/junyezhu","html_url":"https://github.com/junyezhu","followers_url":"https://api.github.com/users/junyezhu/followers","following_url":"https://api.github.com/users/junyezhu/following{/other_user}","gists_url":"https://api.github.com/users/junyezhu/gists{/gist_id}","starred_url":"https://api.github.com/users/junyezhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junyezhu/subscriptions","organizations_url":"https://api.github.com/users/junyezhu/orgs","repos_url":"https://api.github.com/users/junyezhu/repos","events_url":"https://api.github.com/users/junyezhu/events{/privacy}","received_events_url":"https://api.github.com/users/junyezhu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/junyezhu/azure-powershell","description":"Microsoft Azure PowerShell","fork":true,"url":"https://api.github.com/repos/junyezhu/azure-powershell","forks_url":"https://api.github.com/repos/junyezhu/azure-powershell/forks","keys_url":"https://api.github.com/repos/junyezhu/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junyezhu/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junyezhu/azure-powershell/teams","hooks_url":"https://api.github.com/repos/junyezhu/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/junyezhu/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/junyezhu/azure-powershell/events","assignees_url":"https://api.github.com/repos/junyezhu/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/junyezhu/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/junyezhu/azure-powershell/tags","blobs_url":"https://api.github.com/repos/junyezhu/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junyezhu/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junyezhu/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/junyezhu/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junyezhu/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/junyezhu/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/junyezhu/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/junyezhu/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/junyezhu/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/junyezhu/azure-powershell/subscription","commits_url":"https://api.github.com/repos/junyezhu/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/junyezhu/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/junyezhu/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/junyezhu/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/junyezhu/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/junyezhu/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junyezhu/azure-powershell/merges","archive_url":"https://api.github.com/repos/junyezhu/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junyezhu/azure-powershell/downloads","issues_url":"https://api.github.com/repos/junyezhu/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/junyezhu/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/junyezhu/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/junyezhu/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junyezhu/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/junyezhu/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/junyezhu/azure-powershell/deployments","created_at":"2018-04-20T21:38:53Z","updated_at":"2018-10-27T18:57:01Z","pushed_at":"2018-10-29T18:52:03Z","git_url":"git://github.com/junyezhu/azure-powershell.git","ssh_url":"git@github.com:junyezhu/azure-powershell.git","clone_url":"https://github.com/junyezhu/azure-powershell.git","svn_url":"https://github.com/junyezhu/azure-powershell","homepage":null,"size":649171,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"preview"}},"base":{"label":"Azure:preview","ref":"preview","sha":"f364f434372e3bd1f9e9d695e894c620e45396fb","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":23891194,"node_id":"MDEwOlJlcG9zaXRvcnkyMzg5MTE5NA==","name":"azure-powershell","full_name":"Azure/azure-powershell","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-powershell","description":"Microsoft Azure PowerShell","fork":false,"url":"https://api.github.com/repos/Azure/azure-powershell","forks_url":"https://api.github.com/repos/Azure/azure-powershell/forks","keys_url":"https://api.github.com/repos/Azure/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-powershell/teams","hooks_url":"https://api.github.com/repos/Azure/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-powershell/events","assignees_url":"https://api.github.com/repos/Azure/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-powershell/tags","blobs_url":"https://api.github.com/repos/Azure/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-powershell/subscription","commits_url":"https://api.github.com/repos/Azure/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-powershell/merges","archive_url":"https://api.github.com/repos/Azure/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-powershell/downloads","issues_url":"https://api.github.com/repos/Azure/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-powershell/deployments","created_at":"2014-09-10T20:35:18Z","updated_at":"2018-10-29T19:31:39Z","pushed_at":"2018-10-29T19:48:09Z","git_url":"git://github.com/Azure/azure-powershell.git","ssh_url":"git@github.com:Azure/azure-powershell.git","clone_url":"https://github.com/Azure/azure-powershell.git","svn_url":"https://github.com/Azure/azure-powershell","homepage":null,"size":671796,"stargazers_count":1197,"watchers_count":1197,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1258,"mirror_url":null,"archived":false,"open_issues_count":733,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1258,"open_issues":733,"watchers":1197,"default_branch":"preview"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7697"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/7697"},"issue":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/7697"},"comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/7697/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7697/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7697/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-powershell/statuses/4c24af5e6ea8efda4227a14017d54e2e8a7b6965"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"markcowl"}}