{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/186888028","pull_request_review_id":118558075,"id":186888028,"diff_hunk":"@@ -0,0 +1,122 @@\n+/**\n+ * Copyright 2018 The AMP HTML Authors. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS-IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+.amp-docked-video-shadow,","path":"css/video-docking.css","position":null,"original_position":17,"commit_id":"063b74827b320c7935de2d9875ac49e437a73d58","original_commit_id":"a43e4204490d13fd6290252c65552ec7622f7ace","user":{"login":"alanorozco","id":254946,"avatar_url":"https://avatars2.githubusercontent.com/u/254946?v=4","gravatar_id":"","url":"https://api.github.com/users/alanorozco","html_url":"https://github.com/alanorozco","followers_url":"https://api.github.com/users/alanorozco/followers","following_url":"https://api.github.com/users/alanorozco/following{/other_user}","gists_url":"https://api.github.com/users/alanorozco/gists{/gist_id}","starred_url":"https://api.github.com/users/alanorozco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanorozco/subscriptions","organizations_url":"https://api.github.com/users/alanorozco/orgs","repos_url":"https://api.github.com/users/alanorozco/repos","events_url":"https://api.github.com/users/alanorozco/events{/privacy}","received_events_url":"https://api.github.com/users/alanorozco/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-05-08T22:38:12Z","updated_at":"2018-05-08T22:38:12Z","html_url":"https://github.com/ampproject/amphtml/pull/14961#discussion_r186888028","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14961","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/186888028"},"html":{"href":"https://github.com/ampproject/amphtml/pull/14961#discussion_r186888028"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14961"}},"in_reply_to_id":186592058},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/14961","id":184984682,"html_url":"https://github.com/ampproject/amphtml/pull/14961","diff_url":"https://github.com/ampproject/amphtml/pull/14961.diff","patch_url":"https://github.com/ampproject/amphtml/pull/14961.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/14961","number":14961,"state":"open","locked":false,"title":"✨ Implement video docking (minimize to corner)","user":{"login":"alanorozco","id":254946,"avatar_url":"https://avatars2.githubusercontent.com/u/254946?v=4","gravatar_id":"","url":"https://api.github.com/users/alanorozco","html_url":"https://github.com/alanorozco","followers_url":"https://api.github.com/users/alanorozco/followers","following_url":"https://api.github.com/users/alanorozco/following{/other_user}","gists_url":"https://api.github.com/users/alanorozco/gists{/gist_id}","starred_url":"https://api.github.com/users/alanorozco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanorozco/subscriptions","organizations_url":"https://api.github.com/users/alanorozco/orgs","repos_url":"https://api.github.com/users/alanorozco/repos","events_url":"https://api.github.com/users/alanorozco/events{/privacy}","received_events_url":"https://api.github.com/users/alanorozco/received_events","type":"User","site_admin":false},"body":"Partial for #14061\r\n\r\nPassed over some ideas/corner cases from original implementation (#14614, thanks @wassgha!), but defers to runtime APIs when possible and keeps less state for sanity/robustness.\r\n\r\n## Features\r\n\r\n- Calculates margin/size based on viewport.\r\n- Interpolates transition\r\n- Times out transition\r\n- Creates build rule for CSS as not to bloat the core binary.\r\n- Snap to corner\r\n- Flick to dismiss\r\n\r\n## Demo\r\n\r\nhttp://slicing-cheese.glitch.me\r\n\r\n## Interpolation\r\n\r\n![interpolate](https://user-images.githubusercontent.com/254946/39436865-16c1ec88-4c54-11e8-93de-c3c5e11ed806.gif)\r\n\r\n## In follow-up PRs:\r\n\r\n(in no particular order)\r\n\r\n- Animate flick to dismiss using flick vector.\r\n- ~~Don't show controls after dragging.~~ (Done already.)\r\n- ~~Refresh on resize.~~ (Done already.)\r\n- Dock to container.\r\n- Tests for controls and snap to corner.\r\n- ~~Video should not switch positions when scrolling quickly past the component container.~~ (Fixed.)\r\n- Integration tests.\r\n","created_at":"2018-04-30T15:18:09Z","updated_at":"2018-05-08T22:38:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cf58d40dc3839b5e9e0213179f2f8b67b9ee8ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596633554,"url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14961/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14961/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/14961/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/063b74827b320c7935de2d9875ac49e437a73d58","head":{"label":"alanorozco:docking","ref":"docking","sha":"063b74827b320c7935de2d9875ac49e437a73d58","user":{"login":"alanorozco","id":254946,"avatar_url":"https://avatars2.githubusercontent.com/u/254946?v=4","gravatar_id":"","url":"https://api.github.com/users/alanorozco","html_url":"https://github.com/alanorozco","followers_url":"https://api.github.com/users/alanorozco/followers","following_url":"https://api.github.com/users/alanorozco/following{/other_user}","gists_url":"https://api.github.com/users/alanorozco/gists{/gist_id}","starred_url":"https://api.github.com/users/alanorozco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanorozco/subscriptions","organizations_url":"https://api.github.com/users/alanorozco/orgs","repos_url":"https://api.github.com/users/alanorozco/repos","events_url":"https://api.github.com/users/alanorozco/events{/privacy}","received_events_url":"https://api.github.com/users/alanorozco/received_events","type":"User","site_admin":false},"repo":{"id":81253386,"name":"amphtml","full_name":"alanorozco/amphtml","owner":{"login":"alanorozco","id":254946,"avatar_url":"https://avatars2.githubusercontent.com/u/254946?v=4","gravatar_id":"","url":"https://api.github.com/users/alanorozco","html_url":"https://github.com/alanorozco","followers_url":"https://api.github.com/users/alanorozco/followers","following_url":"https://api.github.com/users/alanorozco/following{/other_user}","gists_url":"https://api.github.com/users/alanorozco/gists{/gist_id}","starred_url":"https://api.github.com/users/alanorozco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanorozco/subscriptions","organizations_url":"https://api.github.com/users/alanorozco/orgs","repos_url":"https://api.github.com/users/alanorozco/repos","events_url":"https://api.github.com/users/alanorozco/events{/privacy}","received_events_url":"https://api.github.com/users/alanorozco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alanorozco/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/alanorozco/amphtml","forks_url":"https://api.github.com/repos/alanorozco/amphtml/forks","keys_url":"https://api.github.com/repos/alanorozco/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alanorozco/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alanorozco/amphtml/teams","hooks_url":"https://api.github.com/repos/alanorozco/amphtml/hooks","issue_events_url":"https://api.github.com/repos/alanorozco/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/alanorozco/amphtml/events","assignees_url":"https://api.github.com/repos/alanorozco/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/alanorozco/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/alanorozco/amphtml/tags","blobs_url":"https://api.github.com/repos/alanorozco/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alanorozco/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alanorozco/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/alanorozco/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alanorozco/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/alanorozco/amphtml/languages","stargazers_url":"https://api.github.com/repos/alanorozco/amphtml/stargazers","contributors_url":"https://api.github.com/repos/alanorozco/amphtml/contributors","subscribers_url":"https://api.github.com/repos/alanorozco/amphtml/subscribers","subscription_url":"https://api.github.com/repos/alanorozco/amphtml/subscription","commits_url":"https://api.github.com/repos/alanorozco/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/alanorozco/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/alanorozco/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/alanorozco/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/alanorozco/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/alanorozco/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alanorozco/amphtml/merges","archive_url":"https://api.github.com/repos/alanorozco/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alanorozco/amphtml/downloads","issues_url":"https://api.github.com/repos/alanorozco/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/alanorozco/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/alanorozco/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/alanorozco/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alanorozco/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/alanorozco/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/alanorozco/amphtml/deployments","created_at":"2017-02-07T20:56:38Z","updated_at":"2017-02-07T20:56:45Z","pushed_at":"2018-05-08T22:38:10Z","git_url":"git://github.com/alanorozco/amphtml.git","ssh_url":"git@github.com:alanorozco/amphtml.git","clone_url":"https://github.com/alanorozco/amphtml.git","svn_url":"https://github.com/alanorozco/amphtml","homepage":"https://ampproject.org","size":419106,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"9d4526e8ccb8562cb094aef66637f25534fa5c79","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-05-08T22:31:12Z","pushed_at":"2018-05-08T22:38:13Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":443097,"stargazers_count":11522,"watchers_count":11522,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2371,"mirror_url":null,"archived":false,"open_issues_count":1322,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2371,"open_issues":1322,"watchers":11522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14961"},"html":{"href":"https://github.com/ampproject/amphtml/pull/14961"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/14961"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/14961/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14961/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14961/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/063b74827b320c7935de2d9875ac49e437a73d58"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alanorozco"}}