{"action":"created","issue":{"url":"https://api.github.com/repos/clojure-emacs/cider/issues/2336","repository_url":"https://api.github.com/repos/clojure-emacs/cider","labels_url":"https://api.github.com/repos/clojure-emacs/cider/issues/2336/labels{/name}","comments_url":"https://api.github.com/repos/clojure-emacs/cider/issues/2336/comments","events_url":"https://api.github.com/repos/clojure-emacs/cider/issues/2336/events","html_url":"https://github.com/clojure-emacs/cider/issues/2336","id":333351948,"node_id":"MDU6SXNzdWUzMzMzNTE5NDg=","number":2336,"title":"New connection manager reads the wrong cider-default-cljs-repl","user":{"login":"arichiardi","id":1724788,"node_id":"MDQ6VXNlcjE3MjQ3ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1724788?v=4","gravatar_id":"","url":"https://api.github.com/users/arichiardi","html_url":"https://github.com/arichiardi","followers_url":"https://api.github.com/users/arichiardi/followers","following_url":"https://api.github.com/users/arichiardi/following{/other_user}","gists_url":"https://api.github.com/users/arichiardi/gists{/gist_id}","starred_url":"https://api.github.com/users/arichiardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arichiardi/subscriptions","organizations_url":"https://api.github.com/users/arichiardi/orgs","repos_url":"https://api.github.com/users/arichiardi/repos","events_url":"https://api.github.com/users/arichiardi/events{/privacy}","received_events_url":"https://api.github.com/users/arichiardi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-18T16:47:21Z","updated_at":"2018-06-18T17:20:00Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Expected behavior\r\n\r\nWhen I call `C-c M-J` the `cider-connect-sibling-cljs` should read the `cider-default-cljs-repl` from the code buffer's locals.\r\n\r\n## Actual behavior\r\nIt always reads from the REPL buffer.\r\n\r\n## Steps to reproduce the problem\r\n\r\nHave a `.dir-locals.el` like this in your folder:\r\n\r\n```elisp\r\n((nil . ((cider-default-cljs-repl . figwheel-main)))\r\n```\r\n\r\n`C-c M-J` in a code buffer. You will always be prompted no matter what is the value of `cider-default-cljs-repl`.\r\n\r\n### CIDER version information\r\n`latest master`\r\n\r\nThe problems seems in  [here](https://github.com/clojure-emacs/cider/blob/master/cider.el#L947), the variable should be read from the code buffer but it is read from the REPL instead.\r\n"},"comment":{"url":"https://api.github.com/repos/clojure-emacs/cider/issues/comments/398130125","html_url":"https://github.com/clojure-emacs/cider/issues/2336#issuecomment-398130125","issue_url":"https://api.github.com/repos/clojure-emacs/cider/issues/2336","id":398130125,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODEzMDEyNQ==","user":{"login":"arichiardi","id":1724788,"node_id":"MDQ6VXNlcjE3MjQ3ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1724788?v=4","gravatar_id":"","url":"https://api.github.com/users/arichiardi","html_url":"https://github.com/arichiardi","followers_url":"https://api.github.com/users/arichiardi/followers","following_url":"https://api.github.com/users/arichiardi/following{/other_user}","gists_url":"https://api.github.com/users/arichiardi/gists{/gist_id}","starred_url":"https://api.github.com/users/arichiardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arichiardi/subscriptions","organizations_url":"https://api.github.com/users/arichiardi/orgs","repos_url":"https://api.github.com/users/arichiardi/repos","events_url":"https://api.github.com/users/arichiardi/events{/privacy}","received_events_url":"https://api.github.com/users/arichiardi/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T17:20:00Z","updated_at":"2018-06-18T17:20:00Z","author_association":"CONTRIBUTOR","body":"I think @vspinu is right and I do this all the time:\r\n\r\n - launch a Clojure REPL in the terminal with all the required deps\r\n- `cider-connect`\r\n- execute forms for upgrading\r\n\r\nI think `cider-connect-cljs` does the last two steps for me automatically?"}}
{"actor":{"display_login":"arichiardi"}}