{"action":"created","issue":{"url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1216","repository_url":"https://api.github.com/repos/input-output-hk/daedalus","labels_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1216/labels{/name}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1216/comments","events_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1216/events","html_url":"https://github.com/input-output-hk/daedalus/pull/1216","id":389781711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NjkyNDI0","number":1216,"title":"[DDW-457] Update Webpack to version 4","user":{"login":"DominikGuzei","id":172414,"node_id":"MDQ6VXNlcjE3MjQxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/172414?v=4","gravatar_id":"","url":"https://api.github.com/users/DominikGuzei","html_url":"https://github.com/DominikGuzei","followers_url":"https://api.github.com/users/DominikGuzei/followers","following_url":"https://api.github.com/users/DominikGuzei/following{/other_user}","gists_url":"https://api.github.com/users/DominikGuzei/gists{/gist_id}","starred_url":"https://api.github.com/users/DominikGuzei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominikGuzei/subscriptions","organizations_url":"https://api.github.com/users/DominikGuzei/orgs","repos_url":"https://api.github.com/users/DominikGuzei/repos","events_url":"https://api.github.com/users/DominikGuzei/events{/privacy}","received_events_url":"https://api.github.com/users/DominikGuzei/received_events","type":"User","site_admin":false},"labels":[{"id":570282890,"node_id":"MDU6TGFiZWw1NzAyODI4OTA=","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/chore","name":"chore","color":"5f5f5f","default":false},{"id":1092249453,"node_id":"MDU6TGFiZWwxMDkyMjQ5NDUz","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/release-0.13.0","name":"release-0.13.0","color":"cba8f7","default":false}],"state":"open","locked":false,"assignee":{"login":"DominikGuzei","id":172414,"node_id":"MDQ6VXNlcjE3MjQxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/172414?v=4","gravatar_id":"","url":"https://api.github.com/users/DominikGuzei","html_url":"https://github.com/DominikGuzei","followers_url":"https://api.github.com/users/DominikGuzei/followers","following_url":"https://api.github.com/users/DominikGuzei/following{/other_user}","gists_url":"https://api.github.com/users/DominikGuzei/gists{/gist_id}","starred_url":"https://api.github.com/users/DominikGuzei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominikGuzei/subscriptions","organizations_url":"https://api.github.com/users/DominikGuzei/orgs","repos_url":"https://api.github.com/users/DominikGuzei/repos","events_url":"https://api.github.com/users/DominikGuzei/events{/privacy}","received_events_url":"https://api.github.com/users/DominikGuzei/received_events","type":"User","site_admin":false},"assignees":[{"login":"DominikGuzei","id":172414,"node_id":"MDQ6VXNlcjE3MjQxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/172414?v=4","gravatar_id":"","url":"https://api.github.com/users/DominikGuzei","html_url":"https://github.com/DominikGuzei","followers_url":"https://api.github.com/users/DominikGuzei/followers","following_url":"https://api.github.com/users/DominikGuzei/following{/other_user}","gists_url":"https://api.github.com/users/DominikGuzei/gists{/gist_id}","starred_url":"https://api.github.com/users/DominikGuzei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominikGuzei/subscriptions","organizations_url":"https://api.github.com/users/DominikGuzei/orgs","repos_url":"https://api.github.com/users/DominikGuzei/repos","events_url":"https://api.github.com/users/DominikGuzei/events{/privacy}","received_events_url":"https://api.github.com/users/DominikGuzei/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2018-12-11T14:08:45Z","updated_at":"2018-12-13T14:43:54Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1216","html_url":"https://github.com/input-output-hk/daedalus/pull/1216","diff_url":"https://github.com/input-output-hk/daedalus/pull/1216.diff","patch_url":"https://github.com/input-output-hk/daedalus/pull/1216.patch"},"body":"This PR updates the following main dependencies (and related ones) to latest versions and introduces all necessary changes to make it work:\r\n\r\nwebpack, babel (+loaders), eslint, storybook, react-intl\r\n\r\n---\r\n\r\n## Review Checklist:\r\n\r\n### Basics\r\n\r\n- [ ] PR is updated to the most recent version of target branch (and there are no conflicts)\r\n- [ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes\r\n- [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub\r\n- [ ] Automated tests: All acceptance tests are passing (`yarn run test`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds)\r\n- [ ] There are no *flow* errors or warnings (`yarn run flow:test`)\r\n- [ ] There are no *lint* errors or warnings (`yarn run lint`)\r\n- [ ] Text changes are proofread and approved (Jane Wild)\r\n- [ ] There are no missing translations (running `yarn run manage:translations` produces no changes)\r\n- [ ] UI changes look good in all themes (Alexander Rukin)\r\n- [ ] Storybook works and no stories are broken (`yarn run storybook`)\r\n- [ ] In case of dependency changes `yarn.lock` file is updated\r\n\r\n### Code Quality\r\n- [ ] Important parts of the code are properly documented and commented\r\n- [ ] Code is properly typed with flow\r\n- [ ] React components are split-up enough to avoid unnecessary re-rendering\r\n- [ ] Any code that only works in Electron is neatly separated from components\r\n\r\n### Testing\r\n- [ ] New feature / change is covered by acceptance tests\r\n- [ ] All existing acceptance tests are still up-to-date\r\n- [ ] New feature / change is covered by Daedalus Testing scenario\r\n- [ ] All existing Daedalus Testing scenarios are still up-to-date\r\n\r\n### After Review:\r\n- [ ] Merge PR\r\n- [ ] Delete source branch\r\n- [ ] Move ticket to `done` on the Youtrack board\r\n"},"comment":{"url":"https://api.github.com/repos/input-output-hk/daedalus/issues/comments/446992633","html_url":"https://github.com/input-output-hk/daedalus/pull/1216#issuecomment-446992633","issue_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1216","id":446992633,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Njk5MjYzMw==","user":{"login":"DominikGuzei","id":172414,"node_id":"MDQ6VXNlcjE3MjQxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/172414?v=4","gravatar_id":"","url":"https://api.github.com/users/DominikGuzei","html_url":"https://github.com/DominikGuzei","followers_url":"https://api.github.com/users/DominikGuzei/followers","following_url":"https://api.github.com/users/DominikGuzei/following{/other_user}","gists_url":"https://api.github.com/users/DominikGuzei/gists{/gist_id}","starred_url":"https://api.github.com/users/DominikGuzei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominikGuzei/subscriptions","organizations_url":"https://api.github.com/users/DominikGuzei/orgs","repos_url":"https://api.github.com/users/DominikGuzei/repos","events_url":"https://api.github.com/users/DominikGuzei/events{/privacy}","received_events_url":"https://api.github.com/users/DominikGuzei/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T14:43:54Z","updated_at":"2018-12-13T14:43:54Z","author_association":"MEMBER","body":"@nikolaglumac yeah we need to go through all `getRef` cases because they are all failing … "}}
{"actor":{"display_login":"DominikGuzei"}}