{"action":"created","issue":{"url":"https://api.github.com/repos/dart-lang/dart-pad/issues/835","repository_url":"https://api.github.com/repos/dart-lang/dart-pad","labels_url":"https://api.github.com/repos/dart-lang/dart-pad/issues/835/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/dart-pad/issues/835/comments","events_url":"https://api.github.com/repos/dart-lang/dart-pad/issues/835/events","html_url":"https://github.com/dart-lang/dart-pad/issues/835","id":341562293,"node_id":"MDU6SXNzdWUzNDE1NjIyOTM=","number":835,"title":"dartpad with preview-dart-2 does not work on Macs","user":{"login":"jcollins-g","id":14116827,"node_id":"MDQ6VXNlcjE0MTE2ODI3","avatar_url":"https://avatars3.githubusercontent.com/u/14116827?v=4","gravatar_id":"","url":"https://api.github.com/users/jcollins-g","html_url":"https://github.com/jcollins-g","followers_url":"https://api.github.com/users/jcollins-g/followers","following_url":"https://api.github.com/users/jcollins-g/following{/other_user}","gists_url":"https://api.github.com/users/jcollins-g/gists{/gist_id}","starred_url":"https://api.github.com/users/jcollins-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcollins-g/subscriptions","organizations_url":"https://api.github.com/users/jcollins-g/orgs","repos_url":"https://api.github.com/users/jcollins-g/repos","events_url":"https://api.github.com/users/jcollins-g/events{/privacy}","received_events_url":"https://api.github.com/users/jcollins-g/received_events","type":"User","site_admin":false},"labels":[{"id":165673926,"node_id":"MDU6TGFiZWwxNjU2NzM5MjY=","url":"https://api.github.com/repos/dart-lang/dart-pad/labels/p0","name":"p0","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":{"login":"jcollins-g","id":14116827,"node_id":"MDQ6VXNlcjE0MTE2ODI3","avatar_url":"https://avatars3.githubusercontent.com/u/14116827?v=4","gravatar_id":"","url":"https://api.github.com/users/jcollins-g","html_url":"https://github.com/jcollins-g","followers_url":"https://api.github.com/users/jcollins-g/followers","following_url":"https://api.github.com/users/jcollins-g/following{/other_user}","gists_url":"https://api.github.com/users/jcollins-g/gists{/gist_id}","starred_url":"https://api.github.com/users/jcollins-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcollins-g/subscriptions","organizations_url":"https://api.github.com/users/jcollins-g/orgs","repos_url":"https://api.github.com/users/jcollins-g/repos","events_url":"https://api.github.com/users/jcollins-g/events{/privacy}","received_events_url":"https://api.github.com/users/jcollins-g/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcollins-g","id":14116827,"node_id":"MDQ6VXNlcjE0MTE2ODI3","avatar_url":"https://avatars3.githubusercontent.com/u/14116827?v=4","gravatar_id":"","url":"https://api.github.com/users/jcollins-g","html_url":"https://github.com/jcollins-g","followers_url":"https://api.github.com/users/jcollins-g/followers","following_url":"https://api.github.com/users/jcollins-g/following{/other_user}","gists_url":"https://api.github.com/users/jcollins-g/gists{/gist_id}","starred_url":"https://api.github.com/users/jcollins-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcollins-g/subscriptions","organizations_url":"https://api.github.com/users/jcollins-g/orgs","repos_url":"https://api.github.com/users/jcollins-g/repos","events_url":"https://api.github.com/users/jcollins-g/events{/privacy}","received_events_url":"https://api.github.com/users/jcollins-g/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-07-16T15:16:37Z","updated_at":"2018-07-16T16:19:35Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Safari and Chrome browsers are affected -- dart-pad does not work at all on them when built with preview-dart-2, the page loads and hangs.\r\n\r\nInspector shows (example from Safari):\r\n```\r\nUncaught Error: TypeError: Instance of 'cH<dynamic>': type 'cH<dynamic>' is not a subtype of type 'List<String>'\r\n    at Object.d (js_helper.dart:1763)\r\n    at Object.o (js_rti.dart:641)\r\n    at Object.mW (keys.dart:127)\r\n    at rG.$1 (dialogs.dart:273)\r\n    at lI.H (collection_patch.dart:1330)\r\n    at rH.$2 (dialogs.dart:272)\r\n    at a3.H (linked_hash_map.dart:202)\r\n    at rF.gl4 (dialogs.dart:269)\r\n    at tv.jr (dialogs.dart:264)\r\n    at ut.dart.ut.$1 (playground.dart:179)\r\n```\r\n\r\nDigging a bit without minify and the problem is here, a missing cast to String:  https://github.com/dart-lang/dart-pad/blob/dce80881c13441957e975f1412004806e48e3976/lib/core/keys.dart#L133.\r\n\r\nPatch coming up."},"comment":{"url":"https://api.github.com/repos/dart-lang/dart-pad/issues/comments/405303199","html_url":"https://github.com/dart-lang/dart-pad/issues/835#issuecomment-405303199","issue_url":"https://api.github.com/repos/dart-lang/dart-pad/issues/835","id":405303199,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTMwMzE5OQ==","user":{"login":"sigmundch","id":2049220,"node_id":"MDQ6VXNlcjIwNDkyMjA=","avatar_url":"https://avatars3.githubusercontent.com/u/2049220?v=4","gravatar_id":"","url":"https://api.github.com/users/sigmundch","html_url":"https://github.com/sigmundch","followers_url":"https://api.github.com/users/sigmundch/followers","following_url":"https://api.github.com/users/sigmundch/following{/other_user}","gists_url":"https://api.github.com/users/sigmundch/gists{/gist_id}","starred_url":"https://api.github.com/users/sigmundch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigmundch/subscriptions","organizations_url":"https://api.github.com/users/sigmundch/orgs","repos_url":"https://api.github.com/users/sigmundch/repos","events_url":"https://api.github.com/users/sigmundch/events{/privacy}","received_events_url":"https://api.github.com/users/sigmundch/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T16:19:35Z","updated_at":"2018-07-16T16:19:35Z","author_association":"MEMBER","body":"Glad you were able to repro - that's exactly the error I saw in the console!\r\n\r\nLooking at the fix, I realize that you probably are running dart2js without the `--omit-implicit-checks` flags. You may want to consider using it, but depends on what the performance looks like at this time.\r\n\r\nIf you find that the app is running slow, adding `--omit-implicit-checks` will potentially help a bunch. We are working on making Dart2 without this flag faster, but we know of a few areas where it is going to be slow for some time. At this time, using the flag will make apps close in performance to that of Dart1, without the flag is closer to Dart1+`--checked`."}}
{"actor":{"display_login":"sigmundch"}}