{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/225043543","pull_request_review_id":164555957,"id":225043543,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTA0MzU0Mw==","diff_hunk":"@@ -111,7 +111,8 @@ void DlgPrefWaveform::slotUpdate() {\n     midVisualGain->setValue(factory->getVisualGain(WaveformWidgetFactory::Mid));\n     highVisualGain->setValue(factory->getVisualGain(WaveformWidgetFactory::High));\n     normalizeOverviewCheckBox->setChecked(factory->isOverviewNormalized());\n-    defaultZoomComboBox->setCurrentIndex(factory->getDefaultZoom() - 1);\n+    // Round zoom to int to get a default zoom index.\n+    defaultZoomComboBox->setCurrentIndex(static_cast<int>(factory->getDefaultZoom()) - 1);","path":"src/preferences/dialog/dlgprefwaveform.cpp","position":6,"original_position":6,"commit_id":"82bc3d7711883c4c325b82f7888f4cf3fbbc999e","original_commit_id":"82bc3d7711883c4c325b82f7888f4cf3fbbc999e","user":{"login":"Be-ing","id":9455094,"node_id":"MDQ6VXNlcjk0NTUwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/9455094?v=4","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"body":"Can this result in a situation where a user accidentally has their zoom level changed slightly by rounding because they press Apply in the preferences?","created_at":"2018-10-15T05:47:58Z","updated_at":"2018-10-15T05:48:14Z","html_url":"https://github.com/mixxxdj/mixxx/pull/1843#discussion_r225043543","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1843","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/225043543"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1843#discussion_r225043543"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1843"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1843","id":222751623,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzUxNjIz","html_url":"https://github.com/mixxxdj/mixxx/pull/1843","diff_url":"https://github.com/mixxxdj/mixxx/pull/1843.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1843.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1843","number":1843,"state":"open","locked":false,"title":"Allow waveform zoom levels to be fractional for smoother zooming with mouse wheel","user":{"login":"ywwg","id":888940,"node_id":"MDQ6VXNlcjg4ODk0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/888940?v=4","gravatar_id":"","url":"https://api.github.com/users/ywwg","html_url":"https://github.com/ywwg","followers_url":"https://api.github.com/users/ywwg/followers","following_url":"https://api.github.com/users/ywwg/following{/other_user}","gists_url":"https://api.github.com/users/ywwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ywwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywwg/subscriptions","organizations_url":"https://api.github.com/users/ywwg/orgs","repos_url":"https://api.github.com/users/ywwg/repos","events_url":"https://api.github.com/users/ywwg/events{/privacy}","received_events_url":"https://api.github.com/users/ywwg/received_events","type":"User","site_admin":false},"body":"Zoom level is still saved in cfg as an index, so the stored value is still an integer.","created_at":"2018-10-14T23:38:38Z","updated_at":"2018-10-15T05:48:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52c1a6e01f71a535dd42a31ae70535cd2fc40eb8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1843/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1843/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1843/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/82bc3d7711883c4c325b82f7888f4cf3fbbc999e","head":{"label":"ywwg:fractional-zoom","ref":"fractional-zoom","sha":"82bc3d7711883c4c325b82f7888f4cf3fbbc999e","user":{"login":"ywwg","id":888940,"node_id":"MDQ6VXNlcjg4ODk0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/888940?v=4","gravatar_id":"","url":"https://api.github.com/users/ywwg","html_url":"https://github.com/ywwg","followers_url":"https://api.github.com/users/ywwg/followers","following_url":"https://api.github.com/users/ywwg/following{/other_user}","gists_url":"https://api.github.com/users/ywwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ywwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywwg/subscriptions","organizations_url":"https://api.github.com/users/ywwg/orgs","repos_url":"https://api.github.com/users/ywwg/repos","events_url":"https://api.github.com/users/ywwg/events{/privacy}","received_events_url":"https://api.github.com/users/ywwg/received_events","type":"User","site_admin":false},"repo":{"id":10135825,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEzNTgyNQ==","name":"mixxx","full_name":"ywwg/mixxx","private":false,"owner":{"login":"ywwg","id":888940,"node_id":"MDQ6VXNlcjg4ODk0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/888940?v=4","gravatar_id":"","url":"https://api.github.com/users/ywwg","html_url":"https://github.com/ywwg","followers_url":"https://api.github.com/users/ywwg/followers","following_url":"https://api.github.com/users/ywwg/following{/other_user}","gists_url":"https://api.github.com/users/ywwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ywwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywwg/subscriptions","organizations_url":"https://api.github.com/users/ywwg/orgs","repos_url":"https://api.github.com/users/ywwg/repos","events_url":"https://api.github.com/users/ywwg/events{/privacy}","received_events_url":"https://api.github.com/users/ywwg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ywwg/mixxx","description":"Personal work branches for the mixxx project -- you may be interested in DJO-hacks-trunk, which contains a bunch of UNSUPPORTED tweaks I like","fork":true,"url":"https://api.github.com/repos/ywwg/mixxx","forks_url":"https://api.github.com/repos/ywwg/mixxx/forks","keys_url":"https://api.github.com/repos/ywwg/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ywwg/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ywwg/mixxx/teams","hooks_url":"https://api.github.com/repos/ywwg/mixxx/hooks","issue_events_url":"https://api.github.com/repos/ywwg/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/ywwg/mixxx/events","assignees_url":"https://api.github.com/repos/ywwg/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/ywwg/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/ywwg/mixxx/tags","blobs_url":"https://api.github.com/repos/ywwg/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ywwg/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ywwg/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ywwg/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ywwg/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/ywwg/mixxx/languages","stargazers_url":"https://api.github.com/repos/ywwg/mixxx/stargazers","contributors_url":"https://api.github.com/repos/ywwg/mixxx/contributors","subscribers_url":"https://api.github.com/repos/ywwg/mixxx/subscribers","subscription_url":"https://api.github.com/repos/ywwg/mixxx/subscription","commits_url":"https://api.github.com/repos/ywwg/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ywwg/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ywwg/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ywwg/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ywwg/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/ywwg/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ywwg/mixxx/merges","archive_url":"https://api.github.com/repos/ywwg/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ywwg/mixxx/downloads","issues_url":"https://api.github.com/repos/ywwg/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/ywwg/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/ywwg/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/ywwg/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ywwg/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/ywwg/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/ywwg/mixxx/deployments","created_at":"2013-05-18T02:52:01Z","updated_at":"2018-10-14T23:31:14Z","pushed_at":"2018-10-14T23:35:48Z","git_url":"git://github.com/ywwg/mixxx.git","ssh_url":"git@github.com:ywwg/mixxx.git","clone_url":"https://github.com/ywwg/mixxx.git","svn_url":"https://github.com/ywwg/mixxx","homepage":"","size":295575,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"669662b6ccd5f0a968391bc309e6e3fd7630be81","user":{"login":"mixxxdj","id":1743769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDM3Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNjAzMQ==","name":"mixxx","full_name":"mixxxdj/mixxx","private":false,"owner":{"login":"mixxxdj","id":1743769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDM3Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2018-10-15T03:57:18Z","pushed_at":"2018-10-15T04:33:23Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":296864,"stargazers_count":1137,"watchers_count":1137,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":534,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":534,"open_issues":87,"watchers":1137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1843"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1843"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1843"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1843/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1843/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1843/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/82bc3d7711883c4c325b82f7888f4cf3fbbc999e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Be-ing"}}