{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/230606253","pull_request_review_id":171380377,"id":230606253,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDYwNjI1Mw==","diff_hunk":"@@ -127,22 +124,44 @@ def _simple_new(cls, values, freq=None, dtype=_TD_DTYPE):\n         result._freq = freq\n         return result\n \n-    def __new__(cls, values, freq=None):\n+    def __new__(cls, values, freq=None, dtype=_TD_DTYPE, copy=False):\n+        _require_m8ns_dtype(dtype)\n+\n+        if isinstance(values, (list, tuple)) or is_object_dtype(values):\n+            values = cls._from_sequence(values, copy=copy)._data\n+            # TODO: can we set copy=False to avoid re-copying?\n \n         freq, freq_infer = dtl.maybe_infer_freq(freq)\n \n-        values = np.array(values, copy=False)\n-        if values.dtype == np.object_:\n-            values = array_to_timedelta64(values)\n+        if isinstance(values, TimedeltaArrayMixin):\n+            if freq is None and values.freq is not None:\n+                freq = values.freq\n+                freq_infer = False\n+            values = values._data\n \n-        result = cls._simple_new(values, freq=freq)\n-        if freq_infer:\n-            inferred = result.inferred_freq\n-            if inferred:\n-                result.freq = to_offset(inferred)\n+        values = np.array(values, copy=copy)\n+\n+        if values.dtype == 'i8':\n+            pass\n+        elif not is_timedelta64_dtype(values):\n+            raise TypeError(values.dtype)\n+        elif values.dtype != _TD_DTYPE:\n+            # i.e. non-nano unit\n+            # TODO: use tslibs.conversion func? watch out for overflows\n+            values = values.astype(_TD_DTYPE)\n \n+        result = cls._simple_new(values, freq=freq)\n+        dtl.maybe_define_freq(freq_infer, result)\n         return result\n \n+    @classmethod\n+    def _from_sequence(cls, scalars, dtype=_TD_DTYPE, copy=False):\n+        # list, tuple, or object-dtype ndarray/Index\n+        values = np.array(scalars, dtype=np.object_, copy=copy)","path":"pandas/core/arrays/timedeltas.py","position":74,"original_position":74,"commit_id":"1a015f6803887bf88d9afadecc228daa7ae3fe9c","original_commit_id":"1a015f6803887bf88d9afadecc228daa7ae3fe9c","user":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"body":"This doesn't call to_timedelta, so this does require that we pass an object array.","created_at":"2018-11-04T21:32:44Z","updated_at":"2018-11-04T21:32:45Z","html_url":"https://github.com/pandas-dev/pandas/pull/23493#discussion_r230606253","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23493","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/230606253"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/23493#discussion_r230606253"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23493"}},"in_reply_to_id":230603467},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23493","id":228195111,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTk1MTEx","html_url":"https://github.com/pandas-dev/pandas/pull/23493","diff_url":"https://github.com/pandas-dev/pandas/pull/23493.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/23493.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/23493","number":23493,"state":"open","locked":false,"title":"REF/ENH: Constructors for DatetimeArray/TimedeltaArray","user":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"body":"Big push on the constructors for DatetimeArray/TimedeltaArray, some progress de-duplicating code from their Index counterparts.\r\n\r\nAs discussed elsewhere, adds `dtype` to `PeriodArray.__init__`\r\n\r\n@TomAugspurger can you confirm that the `_from_sequence`s implemented here handle the right cases?  It wasn't obvious if object-dtyped array/indexes were supposed to be handled there, but combining those cases was too clean to overlook.\r\n\r\nSmall fix in DatetimeArray comparison methods, just enough to make the tests work.  A separate PR forthcoming PR will do a more thorough fix/improvements of those.\r\n\r\nOne non-obvious point on which input would be especially welcome is how/when to use the `copy` kwarg in such a way as to copy at-most-once.  (related: deep_copy_if_needed and #21907)\r\n\r\n#23491 found during this process, will be addressed in a follow-up.","created_at":"2018-11-04T18:52:37Z","updated_at":"2018-11-04T21:32:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e26af2db2d35ef4a50837baf29e26623dd705e0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":49597148,"node_id":"MDU6TGFiZWw0OTU5NzE0OA==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Timedelta","name":"Timedelta","color":"5319e7","default":false},{"id":211840,"node_id":"MDU6TGFiZWwyMTE4NDA=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Timeseries","name":"Timeseries","color":"AFEEEE","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23493/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23493/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/23493/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/1a015f6803887bf88d9afadecc228daa7ae3fe9c","head":{"label":"jbrockmendel:pre-constructors","ref":"pre-constructors","sha":"1a015f6803887bf88d9afadecc228daa7ae3fe9c","user":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"repo":{"id":96820953,"node_id":"MDEwOlJlcG9zaXRvcnk5NjgyMDk1Mw==","name":"pandas","full_name":"jbrockmendel/pandas","private":false,"owner":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jbrockmendel/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/jbrockmendel/pandas","forks_url":"https://api.github.com/repos/jbrockmendel/pandas/forks","keys_url":"https://api.github.com/repos/jbrockmendel/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbrockmendel/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbrockmendel/pandas/teams","hooks_url":"https://api.github.com/repos/jbrockmendel/pandas/hooks","issue_events_url":"https://api.github.com/repos/jbrockmendel/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/jbrockmendel/pandas/events","assignees_url":"https://api.github.com/repos/jbrockmendel/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/jbrockmendel/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/jbrockmendel/pandas/tags","blobs_url":"https://api.github.com/repos/jbrockmendel/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbrockmendel/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbrockmendel/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbrockmendel/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbrockmendel/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/jbrockmendel/pandas/languages","stargazers_url":"https://api.github.com/repos/jbrockmendel/pandas/stargazers","contributors_url":"https://api.github.com/repos/jbrockmendel/pandas/contributors","subscribers_url":"https://api.github.com/repos/jbrockmendel/pandas/subscribers","subscription_url":"https://api.github.com/repos/jbrockmendel/pandas/subscription","commits_url":"https://api.github.com/repos/jbrockmendel/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbrockmendel/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbrockmendel/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbrockmendel/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbrockmendel/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/jbrockmendel/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbrockmendel/pandas/merges","archive_url":"https://api.github.com/repos/jbrockmendel/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbrockmendel/pandas/downloads","issues_url":"https://api.github.com/repos/jbrockmendel/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/jbrockmendel/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/jbrockmendel/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/jbrockmendel/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbrockmendel/pandas/labels{/name}","releases_url":"https://api.github.com/repos/jbrockmendel/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/jbrockmendel/pandas/deployments","created_at":"2017-07-10T21:01:07Z","updated_at":"2017-07-10T21:01:15Z","pushed_at":"2018-11-04T18:58:28Z","git_url":"git://github.com/jbrockmendel/pandas.git","ssh_url":"git@github.com:jbrockmendel/pandas.git","clone_url":"https://github.com/jbrockmendel/pandas.git","svn_url":"https://github.com/jbrockmendel/pandas","homepage":"http://pandas.pydata.org","size":133737,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"b9fc22db9ddd8b2aa10be4680f4c7bf1b5c50ad8","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","private":false,"owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-11-04T20:33:00Z","pushed_at":"2018-11-04T21:23:45Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"https://pandas.pydata.org","size":133899,"stargazers_count":16743,"watchers_count":16743,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6753,"mirror_url":null,"archived":false,"open_issues_count":2868,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6753,"open_issues":2868,"watchers":16743,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23493"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/23493"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/23493"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/23493/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23493/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23493/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/1a015f6803887bf88d9afadecc228daa7ae3fe9c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jbrockmendel"}}