{"action":"created","comment":{"url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/comments/205033128","pull_request_review_id":140221350,"id":205033128,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTAzMzEyOA==","diff_hunk":"@@ -306,15 +306,13 @@ no-auto-default=*\n       </varlistentry>\n       <varlistentry>\n         <term><varname>dns</varname></term>\n-        <listitem><para>Set the DNS (<filename>resolv.conf</filename>) processing mode.\n-        If the key is unspecified, <literal>default</literal> is used,\n-        unless <filename>/etc/resolv.conf</filename> is a symlink to\n-        <filename>/run/systemd/resolve/stub-resolv.conf</filename>,\n-        <filename>/run/systemd/resolve/resolv.conf</filename>,\n-        <filename>/lib/systemd/resolv.conf</filename> or\n-        <filename>/usr/lib/systemd/resolv.conf</filename>.\n-        In that case, <literal>systemd-resolved</literal> is chosen automatically.\n-        </para>\n+        <listitem><para>Configures the processing mode of DNS information known to\n+        NetworkManager. Takes a value in\n+        <arg choice='plain'><replaceable>mode</replaceable></arg><arg>,systemd-resolved</arg>\n+        form. The primary <replaceable>mode</replaceable> influences how is the system's\n+        <filename>resolv.conf</filename> managed, while the supplementary systemd-resolved\n+        mode allows passing the DNS configuration to systemd-resolved even if it's not\n+        configured as a primary resolver. The following modes are available:</para>","path":"man/NetworkManager.conf.xml","position":19,"original_position":19,"commit_id":"6555948526fa5c6c3b0119c9937378c9d3bb63b4","original_commit_id":"a0b791cdd8657e38618ba8968d10760c5e111e8b","user":{"login":"thom311","id":1295078,"node_id":"MDQ6VXNlcjEyOTUwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1295078?v=4","gravatar_id":"","url":"https://api.github.com/users/thom311","html_url":"https://github.com/thom311","followers_url":"https://api.github.com/users/thom311/followers","following_url":"https://api.github.com/users/thom311/following{/other_user}","gists_url":"https://api.github.com/users/thom311/gists{/gist_id}","starred_url":"https://api.github.com/users/thom311/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thom311/subscriptions","organizations_url":"https://api.github.com/users/thom311/orgs","repos_url":"https://api.github.com/users/thom311/repos","events_url":"https://api.github.com/users/thom311/events{/privacy}","received_events_url":"https://api.github.com/users/thom311/received_events","type":"User","site_admin":false},"body":"it seems not optimal to configure it this way. the only setting that makes sense, is either having\r\n```\r\ndns=$ONE_VALUE\r\n```\r\nor\r\n```\r\ndns=$ONE_VALUE_NOT_SDRD,systemd-resolved\r\n```\r\nmeaning: you either select one mode; or you select a mode != `systemd-resolved` and followed by `systemd-resolved`.\r\n\r\nWouldn't it be clearer to add separate option like:\r\n```\r\ndns-internal=systemd-resolved\r\n```\r\n?","created_at":"2018-07-25T09:02:16Z","updated_at":"2018-07-25T09:30:24Z","html_url":"https://github.com/NetworkManager/NetworkManager/pull/157#discussion_r205033128","pull_request_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/157","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/comments/205033128"},"html":{"href":"https://github.com/NetworkManager/NetworkManager/pull/157#discussion_r205033128"},"pull_request":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/157"}}},"pull_request":{"url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/157","id":199060660,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDYwNjYw","html_url":"https://github.com/NetworkManager/NetworkManager/pull/157","diff_url":"https://github.com/NetworkManager/NetworkManager/pull/157.diff","patch_url":"https://github.com/NetworkManager/NetworkManager/pull/157.patch","issue_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/157","number":157,"state":"open","locked":false,"title":"lr/conn-check-af: reliably check connectivity per device, separately for IPv4 and IPv6","user":{"login":"lkundrak","id":92695,"node_id":"MDQ6VXNlcjkyNjk1","avatar_url":"https://avatars2.githubusercontent.com/u/92695?v=4","gravatar_id":"","url":"https://api.github.com/users/lkundrak","html_url":"https://github.com/lkundrak","followers_url":"https://api.github.com/users/lkundrak/followers","following_url":"https://api.github.com/users/lkundrak/following{/other_user}","gists_url":"https://api.github.com/users/lkundrak/gists{/gist_id}","starred_url":"https://api.github.com/users/lkundrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkundrak/subscriptions","organizations_url":"https://api.github.com/users/lkundrak/orgs","repos_url":"https://api.github.com/users/lkundrak/repos","events_url":"https://api.github.com/users/lkundrak/events{/privacy}","received_events_url":"https://api.github.com/users/lkundrak/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-03T19:21:38Z","updated_at":"2018-07-25T09:30:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3575ba17ce37a0b284df64a06cc7f41cfff01f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/157/commits","review_comments_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/157/comments","review_comment_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/157/comments","statuses_url":"https://api.github.com/repos/NetworkManager/NetworkManager/statuses/6555948526fa5c6c3b0119c9937378c9d3bb63b4","head":{"label":"lkundrak:lr/conn-check-af","ref":"lr/conn-check-af","sha":"6555948526fa5c6c3b0119c9937378c9d3bb63b4","user":{"login":"lkundrak","id":92695,"node_id":"MDQ6VXNlcjkyNjk1","avatar_url":"https://avatars2.githubusercontent.com/u/92695?v=4","gravatar_id":"","url":"https://api.github.com/users/lkundrak","html_url":"https://github.com/lkundrak","followers_url":"https://api.github.com/users/lkundrak/followers","following_url":"https://api.github.com/users/lkundrak/following{/other_user}","gists_url":"https://api.github.com/users/lkundrak/gists{/gist_id}","starred_url":"https://api.github.com/users/lkundrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkundrak/subscriptions","organizations_url":"https://api.github.com/users/lkundrak/orgs","repos_url":"https://api.github.com/users/lkundrak/repos","events_url":"https://api.github.com/users/lkundrak/events{/privacy}","received_events_url":"https://api.github.com/users/lkundrak/received_events","type":"User","site_admin":false},"repo":{"id":42936560,"node_id":"MDEwOlJlcG9zaXRvcnk0MjkzNjU2MA==","name":"NetworkManager","full_name":"lkundrak/NetworkManager","owner":{"login":"lkundrak","id":92695,"node_id":"MDQ6VXNlcjkyNjk1","avatar_url":"https://avatars2.githubusercontent.com/u/92695?v=4","gravatar_id":"","url":"https://api.github.com/users/lkundrak","html_url":"https://github.com/lkundrak","followers_url":"https://api.github.com/users/lkundrak/followers","following_url":"https://api.github.com/users/lkundrak/following{/other_user}","gists_url":"https://api.github.com/users/lkundrak/gists{/gist_id}","starred_url":"https://api.github.com/users/lkundrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkundrak/subscriptions","organizations_url":"https://api.github.com/users/lkundrak/orgs","repos_url":"https://api.github.com/users/lkundrak/repos","events_url":"https://api.github.com/users/lkundrak/events{/privacy}","received_events_url":"https://api.github.com/users/lkundrak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lkundrak/NetworkManager","description":"Mirror of the freedesktop.org repository. Feel free to do the pull requests!","fork":true,"url":"https://api.github.com/repos/lkundrak/NetworkManager","forks_url":"https://api.github.com/repos/lkundrak/NetworkManager/forks","keys_url":"https://api.github.com/repos/lkundrak/NetworkManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lkundrak/NetworkManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lkundrak/NetworkManager/teams","hooks_url":"https://api.github.com/repos/lkundrak/NetworkManager/hooks","issue_events_url":"https://api.github.com/repos/lkundrak/NetworkManager/issues/events{/number}","events_url":"https://api.github.com/repos/lkundrak/NetworkManager/events","assignees_url":"https://api.github.com/repos/lkundrak/NetworkManager/assignees{/user}","branches_url":"https://api.github.com/repos/lkundrak/NetworkManager/branches{/branch}","tags_url":"https://api.github.com/repos/lkundrak/NetworkManager/tags","blobs_url":"https://api.github.com/repos/lkundrak/NetworkManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lkundrak/NetworkManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lkundrak/NetworkManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/lkundrak/NetworkManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lkundrak/NetworkManager/statuses/{sha}","languages_url":"https://api.github.com/repos/lkundrak/NetworkManager/languages","stargazers_url":"https://api.github.com/repos/lkundrak/NetworkManager/stargazers","contributors_url":"https://api.github.com/repos/lkundrak/NetworkManager/contributors","subscribers_url":"https://api.github.com/repos/lkundrak/NetworkManager/subscribers","subscription_url":"https://api.github.com/repos/lkundrak/NetworkManager/subscription","commits_url":"https://api.github.com/repos/lkundrak/NetworkManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/lkundrak/NetworkManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/lkundrak/NetworkManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/lkundrak/NetworkManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/lkundrak/NetworkManager/contents/{+path}","compare_url":"https://api.github.com/repos/lkundrak/NetworkManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lkundrak/NetworkManager/merges","archive_url":"https://api.github.com/repos/lkundrak/NetworkManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lkundrak/NetworkManager/downloads","issues_url":"https://api.github.com/repos/lkundrak/NetworkManager/issues{/number}","pulls_url":"https://api.github.com/repos/lkundrak/NetworkManager/pulls{/number}","milestones_url":"https://api.github.com/repos/lkundrak/NetworkManager/milestones{/number}","notifications_url":"https://api.github.com/repos/lkundrak/NetworkManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lkundrak/NetworkManager/labels{/name}","releases_url":"https://api.github.com/repos/lkundrak/NetworkManager/releases{/id}","deployments_url":"https://api.github.com/repos/lkundrak/NetworkManager/deployments","created_at":"2015-09-22T13:48:43Z","updated_at":"2016-01-12T09:41:30Z","pushed_at":"2018-07-23T12:39:07Z","git_url":"git://github.com/lkundrak/NetworkManager.git","ssh_url":"git@github.com:lkundrak/NetworkManager.git","clone_url":"https://github.com/lkundrak/NetworkManager.git","svn_url":"https://github.com/lkundrak/NetworkManager","homepage":"http://cgit.freedesktop.org/NetworkManager/NetworkManager/","size":105099,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NetworkManager:master","ref":"master","sha":"21f955b4dde1696aa8cb2b714d52615a63ce5569","user":{"login":"NetworkManager","id":14775807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Nzc1ODA3","avatar_url":"https://avatars2.githubusercontent.com/u/14775807?v=4","gravatar_id":"","url":"https://api.github.com/users/NetworkManager","html_url":"https://github.com/NetworkManager","followers_url":"https://api.github.com/users/NetworkManager/followers","following_url":"https://api.github.com/users/NetworkManager/following{/other_user}","gists_url":"https://api.github.com/users/NetworkManager/gists{/gist_id}","starred_url":"https://api.github.com/users/NetworkManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetworkManager/subscriptions","organizations_url":"https://api.github.com/users/NetworkManager/orgs","repos_url":"https://api.github.com/users/NetworkManager/repos","events_url":"https://api.github.com/users/NetworkManager/events{/privacy}","received_events_url":"https://api.github.com/users/NetworkManager/received_events","type":"Organization","site_admin":false},"repo":{"id":42934521,"node_id":"MDEwOlJlcG9zaXRvcnk0MjkzNDUyMQ==","name":"NetworkManager","full_name":"NetworkManager/NetworkManager","owner":{"login":"NetworkManager","id":14775807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Nzc1ODA3","avatar_url":"https://avatars2.githubusercontent.com/u/14775807?v=4","gravatar_id":"","url":"https://api.github.com/users/NetworkManager","html_url":"https://github.com/NetworkManager","followers_url":"https://api.github.com/users/NetworkManager/followers","following_url":"https://api.github.com/users/NetworkManager/following{/other_user}","gists_url":"https://api.github.com/users/NetworkManager/gists{/gist_id}","starred_url":"https://api.github.com/users/NetworkManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetworkManager/subscriptions","organizations_url":"https://api.github.com/users/NetworkManager/orgs","repos_url":"https://api.github.com/users/NetworkManager/repos","events_url":"https://api.github.com/users/NetworkManager/events{/privacy}","received_events_url":"https://api.github.com/users/NetworkManager/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetworkManager/NetworkManager","description":"Mirror of the freedesktop.org repository. Feel free to do the pull requests!","fork":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager","forks_url":"https://api.github.com/repos/NetworkManager/NetworkManager/forks","keys_url":"https://api.github.com/repos/NetworkManager/NetworkManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetworkManager/NetworkManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetworkManager/NetworkManager/teams","hooks_url":"https://api.github.com/repos/NetworkManager/NetworkManager/hooks","issue_events_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/events{/number}","events_url":"https://api.github.com/repos/NetworkManager/NetworkManager/events","assignees_url":"https://api.github.com/repos/NetworkManager/NetworkManager/assignees{/user}","branches_url":"https://api.github.com/repos/NetworkManager/NetworkManager/branches{/branch}","tags_url":"https://api.github.com/repos/NetworkManager/NetworkManager/tags","blobs_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetworkManager/NetworkManager/statuses/{sha}","languages_url":"https://api.github.com/repos/NetworkManager/NetworkManager/languages","stargazers_url":"https://api.github.com/repos/NetworkManager/NetworkManager/stargazers","contributors_url":"https://api.github.com/repos/NetworkManager/NetworkManager/contributors","subscribers_url":"https://api.github.com/repos/NetworkManager/NetworkManager/subscribers","subscription_url":"https://api.github.com/repos/NetworkManager/NetworkManager/subscription","commits_url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetworkManager/NetworkManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetworkManager/NetworkManager/contents/{+path}","compare_url":"https://api.github.com/repos/NetworkManager/NetworkManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetworkManager/NetworkManager/merges","archive_url":"https://api.github.com/repos/NetworkManager/NetworkManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetworkManager/NetworkManager/downloads","issues_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues{/number}","pulls_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls{/number}","milestones_url":"https://api.github.com/repos/NetworkManager/NetworkManager/milestones{/number}","notifications_url":"https://api.github.com/repos/NetworkManager/NetworkManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetworkManager/NetworkManager/labels{/name}","releases_url":"https://api.github.com/repos/NetworkManager/NetworkManager/releases{/id}","deployments_url":"https://api.github.com/repos/NetworkManager/NetworkManager/deployments","created_at":"2015-09-22T13:12:35Z","updated_at":"2018-07-24T18:20:10Z","pushed_at":"2018-07-24T18:20:06Z","git_url":"git://github.com/NetworkManager/NetworkManager.git","ssh_url":"git@github.com:NetworkManager/NetworkManager.git","clone_url":"https://github.com/NetworkManager/NetworkManager.git","svn_url":"https://github.com/NetworkManager/NetworkManager","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","size":108336,"stargazers_count":55,"watchers_count":55,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":66,"open_issues":10,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/157"},"html":{"href":"https://github.com/NetworkManager/NetworkManager/pull/157"},"issue":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/157"},"comments":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/statuses/6555948526fa5c6c3b0119c9937378c9d3bb63b4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"thom311"}}