{"action":"created","comment":{"url":"https://api.github.com/repos/kiali/kiali/pulls/comments/194980286","pull_request_review_id":128254966,"id":194980286,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDk4MDI4Ng==","diff_hunk":"@@ -96,12 +96,13 @@ func applymTLS(n *tree.ServiceNode, namespaceName string, istioDetails *kubernet\n \t\treturn\n \t}\n \n-\tserviceName := strings.Split(n.Name, \".\")[0]\n+\tnodeService := strings.Split(n.Name, \".\")[0]","path":"graph/appender/istio_details.go","position":5,"original_position":5,"commit_id":"d4949d26937dc3bae3c655da5299d43e12862828","original_commit_id":"d4949d26937dc3bae3c655da5299d43e12862828","user":{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"body":"Why split twice ? I would do it in one time, and check that the len() is correct.\r\nPerhaps serviceName is tested outside this method, but it should add a validation, and a single op for Split() IMO.","created_at":"2018-06-13T07:30:26Z","updated_at":"2018-06-13T07:30:26Z","html_url":"https://github.com/kiali/kiali/pull/273#discussion_r194980286","pull_request_url":"https://api.github.com/repos/kiali/kiali/pulls/273","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali/pulls/comments/194980286"},"html":{"href":"https://github.com/kiali/kiali/pull/273#discussion_r194980286"},"pull_request":{"href":"https://api.github.com/repos/kiali/kiali/pulls/273"}}},"pull_request":{"url":"https://api.github.com/repos/kiali/kiali/pulls/273","id":194336167,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MzM2MTY3","html_url":"https://github.com/kiali/kiali/pull/273","diff_url":"https://github.com/kiali/kiali/pull/273.diff","patch_url":"https://github.com/kiali/kiali/pull/273.patch","issue_url":"https://api.github.com/repos/kiali/kiali/issues/273","number":273,"state":"open","locked":false,"title":"KIALI-750 Fixing enablemTLS flag - now using destination rule with 0.8 syntax","user":{"login":"xeviknal","id":613814,"node_id":"MDQ6VXNlcjYxMzgxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/613814?v=4","gravatar_id":"","url":"https://api.github.com/users/xeviknal","html_url":"https://github.com/xeviknal","followers_url":"https://api.github.com/users/xeviknal/followers","following_url":"https://api.github.com/users/xeviknal/following{/other_user}","gists_url":"https://api.github.com/users/xeviknal/gists{/gist_id}","starred_url":"https://api.github.com/users/xeviknal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeviknal/subscriptions","organizations_url":"https://api.github.com/users/xeviknal/orgs","repos_url":"https://api.github.com/users/xeviknal/repos","events_url":"https://api.github.com/users/xeviknal/events{/privacy}","received_events_url":"https://api.github.com/users/xeviknal/received_events","type":"User","site_admin":false},"body":"This is a quick fix of #269. It didn't include the change to use 0.8 syntax for Destination Rule","created_at":"2018-06-12T16:19:38Z","updated_at":"2018-06-13T07:30:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cae01acc10c67e7082f2e7dc8f71eab112f2201","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali/pulls/273/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali/pulls/273/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali/issues/273/comments","statuses_url":"https://api.github.com/repos/kiali/kiali/statuses/d4949d26937dc3bae3c655da5299d43e12862828","head":{"label":"xeviknal:KIALI-750-2","ref":"KIALI-750-2","sha":"d4949d26937dc3bae3c655da5299d43e12862828","user":{"login":"xeviknal","id":613814,"node_id":"MDQ6VXNlcjYxMzgxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/613814?v=4","gravatar_id":"","url":"https://api.github.com/users/xeviknal","html_url":"https://github.com/xeviknal","followers_url":"https://api.github.com/users/xeviknal/followers","following_url":"https://api.github.com/users/xeviknal/following{/other_user}","gists_url":"https://api.github.com/users/xeviknal/gists{/gist_id}","starred_url":"https://api.github.com/users/xeviknal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeviknal/subscriptions","organizations_url":"https://api.github.com/users/xeviknal/orgs","repos_url":"https://api.github.com/users/xeviknal/repos","events_url":"https://api.github.com/users/xeviknal/events{/privacy}","received_events_url":"https://api.github.com/users/xeviknal/received_events","type":"User","site_admin":false},"repo":{"id":120455008,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA0NTUwMDg=","name":"swscore","full_name":"xeviknal/swscore","owner":{"login":"xeviknal","id":613814,"node_id":"MDQ6VXNlcjYxMzgxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/613814?v=4","gravatar_id":"","url":"https://api.github.com/users/xeviknal","html_url":"https://github.com/xeviknal","followers_url":"https://api.github.com/users/xeviknal/followers","following_url":"https://api.github.com/users/xeviknal/following{/other_user}","gists_url":"https://api.github.com/users/xeviknal/gists{/gist_id}","starred_url":"https://api.github.com/users/xeviknal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeviknal/subscriptions","organizations_url":"https://api.github.com/users/xeviknal/orgs","repos_url":"https://api.github.com/users/xeviknal/repos","events_url":"https://api.github.com/users/xeviknal/events{/privacy}","received_events_url":"https://api.github.com/users/xeviknal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xeviknal/swscore","description":null,"fork":true,"url":"https://api.github.com/repos/xeviknal/swscore","forks_url":"https://api.github.com/repos/xeviknal/swscore/forks","keys_url":"https://api.github.com/repos/xeviknal/swscore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xeviknal/swscore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xeviknal/swscore/teams","hooks_url":"https://api.github.com/repos/xeviknal/swscore/hooks","issue_events_url":"https://api.github.com/repos/xeviknal/swscore/issues/events{/number}","events_url":"https://api.github.com/repos/xeviknal/swscore/events","assignees_url":"https://api.github.com/repos/xeviknal/swscore/assignees{/user}","branches_url":"https://api.github.com/repos/xeviknal/swscore/branches{/branch}","tags_url":"https://api.github.com/repos/xeviknal/swscore/tags","blobs_url":"https://api.github.com/repos/xeviknal/swscore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xeviknal/swscore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xeviknal/swscore/git/refs{/sha}","trees_url":"https://api.github.com/repos/xeviknal/swscore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xeviknal/swscore/statuses/{sha}","languages_url":"https://api.github.com/repos/xeviknal/swscore/languages","stargazers_url":"https://api.github.com/repos/xeviknal/swscore/stargazers","contributors_url":"https://api.github.com/repos/xeviknal/swscore/contributors","subscribers_url":"https://api.github.com/repos/xeviknal/swscore/subscribers","subscription_url":"https://api.github.com/repos/xeviknal/swscore/subscription","commits_url":"https://api.github.com/repos/xeviknal/swscore/commits{/sha}","git_commits_url":"https://api.github.com/repos/xeviknal/swscore/git/commits{/sha}","comments_url":"https://api.github.com/repos/xeviknal/swscore/comments{/number}","issue_comment_url":"https://api.github.com/repos/xeviknal/swscore/issues/comments{/number}","contents_url":"https://api.github.com/repos/xeviknal/swscore/contents/{+path}","compare_url":"https://api.github.com/repos/xeviknal/swscore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xeviknal/swscore/merges","archive_url":"https://api.github.com/repos/xeviknal/swscore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xeviknal/swscore/downloads","issues_url":"https://api.github.com/repos/xeviknal/swscore/issues{/number}","pulls_url":"https://api.github.com/repos/xeviknal/swscore/pulls{/number}","milestones_url":"https://api.github.com/repos/xeviknal/swscore/milestones{/number}","notifications_url":"https://api.github.com/repos/xeviknal/swscore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xeviknal/swscore/labels{/name}","releases_url":"https://api.github.com/repos/xeviknal/swscore/releases{/id}","deployments_url":"https://api.github.com/repos/xeviknal/swscore/deployments","created_at":"2018-02-06T12:44:52Z","updated_at":"2018-04-05T10:05:23Z","pushed_at":"2018-06-12T22:11:11Z","git_url":"git://github.com/xeviknal/swscore.git","ssh_url":"git@github.com:xeviknal/swscore.git","clone_url":"https://github.com/xeviknal/swscore.git","svn_url":"https://github.com/xeviknal/swscore","homepage":null,"size":10947,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiali:istio-0.8","ref":"istio-0.8","sha":"0f61a7a27cd11d72bd1cec2581872a27d2c9ed8f","user":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":120181748,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAxODE3NDg=","name":"kiali","full_name":"kiali/kiali","owner":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiali/kiali","description":"Kiali project, observability for the Istio service mesh","fork":false,"url":"https://api.github.com/repos/kiali/kiali","forks_url":"https://api.github.com/repos/kiali/kiali/forks","keys_url":"https://api.github.com/repos/kiali/kiali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali/teams","hooks_url":"https://api.github.com/repos/kiali/kiali/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali/events","assignees_url":"https://api.github.com/repos/kiali/kiali/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali/tags","blobs_url":"https://api.github.com/repos/kiali/kiali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali/subscription","commits_url":"https://api.github.com/repos/kiali/kiali/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali/merges","archive_url":"https://api.github.com/repos/kiali/kiali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali/downloads","issues_url":"https://api.github.com/repos/kiali/kiali/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali/deployments","created_at":"2018-02-04T12:11:57Z","updated_at":"2018-06-12T14:17:49Z","pushed_at":"2018-06-13T07:14:52Z","git_url":"git://github.com/kiali/kiali.git","ssh_url":"git@github.com:kiali/kiali.git","clone_url":"https://github.com/kiali/kiali.git","svn_url":"https://github.com/kiali/kiali","homepage":"https://kiali.org/","size":10932,"stargazers_count":61,"watchers_count":61,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":19,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali/pulls/273"},"html":{"href":"https://github.com/kiali/kiali/pull/273"},"issue":{"href":"https://api.github.com/repos/kiali/kiali/issues/273"},"comments":{"href":"https://api.github.com/repos/kiali/kiali/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali/statuses/d4949d26937dc3bae3c655da5299d43e12862828"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lucasponce"}}