{"action":"created","comment":{"url":"https://api.github.com/repos/pusher/pusher-platform-ruby/pulls/comments/218418051","pull_request_review_id":156349015,"id":218418051,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODQxODA1MQ==","diff_hunk":"@@ -0,0 +1,26 @@\n+require_relative './error'\n+\n+module PusherPlatform\n+  class SDKInfo\n+    attr_reader :product_name, :version, :language, :platform, :headers\n+\n+    def initialize(options)\n+      raise Error.new('No product_name provided to SDKInfo') if options[:product_name].nil?\n+      raise Error.new('No version provided to SDKInfo') if options[:version].nil?\n+\n+      @product_name = options[:product_name]\n+      @version = options[:version]\n+\n+      @platform = options[:platform] || 'server'\n+      @language = 'ruby'\n+\n+      @headers = {\n+        \"X-SDK-Product\" => @product_name,","path":"lib/pusher-platform/sdk_info.rb","position":18,"original_position":18,"commit_id":"54de1543a030d711f3d1bf1db533c3725428f2b1","original_commit_id":"54de1543a030d711f3d1bf1db533c3725428f2b1","user":{"login":"hamchapman","id":2475150,"node_id":"MDQ6VXNlcjI0NzUxNTA=","avatar_url":"https://avatars2.githubusercontent.com/u/2475150?v=4","gravatar_id":"","url":"https://api.github.com/users/hamchapman","html_url":"https://github.com/hamchapman","followers_url":"https://api.github.com/users/hamchapman/followers","following_url":"https://api.github.com/users/hamchapman/following{/other_user}","gists_url":"https://api.github.com/users/hamchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/hamchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamchapman/subscriptions","organizations_url":"https://api.github.com/users/hamchapman/orgs","repos_url":"https://api.github.com/users/hamchapman/repos","events_url":"https://api.github.com/users/hamchapman/events{/privacy}","received_events_url":"https://api.github.com/users/hamchapman/received_events","type":"User","site_admin":false},"body":"Thing is, it's only Chatkit, so if we ever want to do it, now's the time. If we're in agreement that it would be better to have `X-Pusher-SDK-Product`, `X-Pusher-SDK-Language`, `X-Pusher-SDK-Platform` and `X-Pusher-SDK-Version` then I can do that today","created_at":"2018-09-18T12:51:31Z","updated_at":"2018-09-18T12:51:31Z","html_url":"https://github.com/pusher/pusher-platform-ruby/pull/23#discussion_r218418051","pull_request_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/pulls/23","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pusher/pusher-platform-ruby/pulls/comments/218418051"},"html":{"href":"https://github.com/pusher/pusher-platform-ruby/pull/23#discussion_r218418051"},"pull_request":{"href":"https://api.github.com/repos/pusher/pusher-platform-ruby/pulls/23"}},"in_reply_to_id":218184904},"pull_request":{"url":"https://api.github.com/repos/pusher/pusher-platform-ruby/pulls/23","id":216018376,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MDE4Mzc2","html_url":"https://github.com/pusher/pusher-platform-ruby/pull/23","diff_url":"https://github.com/pusher/pusher-platform-ruby/pull/23.diff","patch_url":"https://github.com/pusher/pusher-platform-ruby/pull/23.patch","issue_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/issues/23","number":23,"state":"open","locked":false,"title":"SDK info","user":{"login":"hamchapman","id":2475150,"node_id":"MDQ6VXNlcjI0NzUxNTA=","avatar_url":"https://avatars2.githubusercontent.com/u/2475150?v=4","gravatar_id":"","url":"https://api.github.com/users/hamchapman","html_url":"https://github.com/hamchapman","followers_url":"https://api.github.com/users/hamchapman/followers","following_url":"https://api.github.com/users/hamchapman/following{/other_user}","gists_url":"https://api.github.com/users/hamchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/hamchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamchapman/subscriptions","organizations_url":"https://api.github.com/users/hamchapman/orgs","repos_url":"https://api.github.com/users/hamchapman/repos","events_url":"https://api.github.com/users/hamchapman/events{/privacy}","received_events_url":"https://api.github.com/users/hamchapman/received_events","type":"User","site_admin":false},"body":"### What?\r\n\r\nAdd requirement for SDKInfo to be provided\r\n\r\n### Why?\r\n\r\nSo headers containing SDK information can be sent to services running on the shared platform\r\n\r\n----\r\n\r\n- [ ] README updated if you changed the API?\r\n- [x] CHANGELOG updated if relevant?\r\n\r\n----\r\n\r\nCC @pusher/sigsdk\r\n","created_at":"2018-09-17T15:15:30Z","updated_at":"2018-09-18T12:51:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"794d75d1fc7c7ee278f76cc67f2488bdc2238d57","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/pulls/23/commits","review_comments_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/pulls/23/comments","review_comment_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/issues/23/comments","statuses_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/statuses/54de1543a030d711f3d1bf1db533c3725428f2b1","head":{"label":"pusher:sdk-info","ref":"sdk-info","sha":"54de1543a030d711f3d1bf1db533c3725428f2b1","user":{"login":"pusher","id":739550,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTU1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/739550?v=4","gravatar_id":"","url":"https://api.github.com/users/pusher","html_url":"https://github.com/pusher","followers_url":"https://api.github.com/users/pusher/followers","following_url":"https://api.github.com/users/pusher/following{/other_user}","gists_url":"https://api.github.com/users/pusher/gists{/gist_id}","starred_url":"https://api.github.com/users/pusher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusher/subscriptions","organizations_url":"https://api.github.com/users/pusher/orgs","repos_url":"https://api.github.com/users/pusher/repos","events_url":"https://api.github.com/users/pusher/events{/privacy}","received_events_url":"https://api.github.com/users/pusher/received_events","type":"Organization","site_admin":false},"repo":{"id":79822026,"node_id":"MDEwOlJlcG9zaXRvcnk3OTgyMjAyNg==","name":"pusher-platform-ruby","full_name":"pusher/pusher-platform-ruby","private":false,"owner":{"login":"pusher","id":739550,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTU1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/739550?v=4","gravatar_id":"","url":"https://api.github.com/users/pusher","html_url":"https://github.com/pusher","followers_url":"https://api.github.com/users/pusher/followers","following_url":"https://api.github.com/users/pusher/following{/other_user}","gists_url":"https://api.github.com/users/pusher/gists{/gist_id}","starred_url":"https://api.github.com/users/pusher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusher/subscriptions","organizations_url":"https://api.github.com/users/pusher/orgs","repos_url":"https://api.github.com/users/pusher/repos","events_url":"https://api.github.com/users/pusher/events{/privacy}","received_events_url":"https://api.github.com/users/pusher/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pusher/pusher-platform-ruby","description":"Sample authorizer component in Ruby","fork":false,"url":"https://api.github.com/repos/pusher/pusher-platform-ruby","forks_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/forks","keys_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/teams","hooks_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/hooks","issue_events_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/events","assignees_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/tags","blobs_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/languages","stargazers_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/stargazers","contributors_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/contributors","subscribers_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/subscribers","subscription_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/subscription","commits_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/merges","archive_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/downloads","issues_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/labels{/name}","releases_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/deployments","created_at":"2017-01-23T16:20:09Z","updated_at":"2018-09-17T09:34:10Z","pushed_at":"2018-09-17T16:39:38Z","git_url":"git://github.com/pusher/pusher-platform-ruby.git","ssh_url":"git@github.com:pusher/pusher-platform-ruby.git","clone_url":"https://github.com/pusher/pusher-platform-ruby.git","svn_url":"https://github.com/pusher/pusher-platform-ruby","homepage":null,"size":114,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pusher:master","ref":"master","sha":"df5a3e57735495b1c3b5c116eaedeeacfeba987e","user":{"login":"pusher","id":739550,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTU1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/739550?v=4","gravatar_id":"","url":"https://api.github.com/users/pusher","html_url":"https://github.com/pusher","followers_url":"https://api.github.com/users/pusher/followers","following_url":"https://api.github.com/users/pusher/following{/other_user}","gists_url":"https://api.github.com/users/pusher/gists{/gist_id}","starred_url":"https://api.github.com/users/pusher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusher/subscriptions","organizations_url":"https://api.github.com/users/pusher/orgs","repos_url":"https://api.github.com/users/pusher/repos","events_url":"https://api.github.com/users/pusher/events{/privacy}","received_events_url":"https://api.github.com/users/pusher/received_events","type":"Organization","site_admin":false},"repo":{"id":79822026,"node_id":"MDEwOlJlcG9zaXRvcnk3OTgyMjAyNg==","name":"pusher-platform-ruby","full_name":"pusher/pusher-platform-ruby","private":false,"owner":{"login":"pusher","id":739550,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTU1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/739550?v=4","gravatar_id":"","url":"https://api.github.com/users/pusher","html_url":"https://github.com/pusher","followers_url":"https://api.github.com/users/pusher/followers","following_url":"https://api.github.com/users/pusher/following{/other_user}","gists_url":"https://api.github.com/users/pusher/gists{/gist_id}","starred_url":"https://api.github.com/users/pusher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusher/subscriptions","organizations_url":"https://api.github.com/users/pusher/orgs","repos_url":"https://api.github.com/users/pusher/repos","events_url":"https://api.github.com/users/pusher/events{/privacy}","received_events_url":"https://api.github.com/users/pusher/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pusher/pusher-platform-ruby","description":"Sample authorizer component in Ruby","fork":false,"url":"https://api.github.com/repos/pusher/pusher-platform-ruby","forks_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/forks","keys_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/teams","hooks_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/hooks","issue_events_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/events","assignees_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/tags","blobs_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/languages","stargazers_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/stargazers","contributors_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/contributors","subscribers_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/subscribers","subscription_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/subscription","commits_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/merges","archive_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/downloads","issues_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/labels{/name}","releases_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/pusher/pusher-platform-ruby/deployments","created_at":"2017-01-23T16:20:09Z","updated_at":"2018-09-17T09:34:10Z","pushed_at":"2018-09-17T16:39:38Z","git_url":"git://github.com/pusher/pusher-platform-ruby.git","ssh_url":"git@github.com:pusher/pusher-platform-ruby.git","clone_url":"https://github.com/pusher/pusher-platform-ruby.git","svn_url":"https://github.com/pusher/pusher-platform-ruby","homepage":null,"size":114,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pusher/pusher-platform-ruby/pulls/23"},"html":{"href":"https://github.com/pusher/pusher-platform-ruby/pull/23"},"issue":{"href":"https://api.github.com/repos/pusher/pusher-platform-ruby/issues/23"},"comments":{"href":"https://api.github.com/repos/pusher/pusher-platform-ruby/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/pusher/pusher-platform-ruby/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/pusher/pusher-platform-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pusher/pusher-platform-ruby/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/pusher/pusher-platform-ruby/statuses/54de1543a030d711f3d1bf1db533c3725428f2b1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hamchapman"}}