{"action":"created","comment":{"url":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments/213214306","pull_request_review_id":150001471,"id":213214306,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzIxNDMwNg==","diff_hunk":"@@ -245,6 +245,8 @@ def __init__(self, config, file=None):\n         self.isatty = file.isatty()\n         self._progress_nodeids_reported = set()\n         self._show_progress_info = self._determine_show_progress_info()\n+        self.rewrite_lines = 0\n+        self.width_adjust = 1 if sys.platform == \"win32\" else 0","path":"src/_pytest/terminal.py","position":5,"original_position":5,"commit_id":"f782db22a73364648834c05540f037750e0b5c85","original_commit_id":"f782db22a73364648834c05540f037750e0b5c85","user":{"login":"RonnyPfannschmidt","id":156838,"node_id":"MDQ6VXNlcjE1NjgzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/156838?v=4","gravatar_id":"","url":"https://api.github.com/users/RonnyPfannschmidt","html_url":"https://github.com/RonnyPfannschmidt","followers_url":"https://api.github.com/users/RonnyPfannschmidt/followers","following_url":"https://api.github.com/users/RonnyPfannschmidt/following{/other_user}","gists_url":"https://api.github.com/users/RonnyPfannschmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/RonnyPfannschmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonnyPfannschmidt/subscriptions","organizations_url":"https://api.github.com/users/RonnyPfannschmidt/orgs","repos_url":"https://api.github.com/users/RonnyPfannschmidt/repos","events_url":"https://api.github.com/users/RonnyPfannschmidt/events{/privacy}","received_events_url":"https://api.github.com/users/RonnyPfannschmidt/received_events","type":"User","site_admin":false},"body":"i'd like to see it as constant, since its clearly not something thats even remotely related to a lifecycle of a terminalwriter","created_at":"2018-08-28T07:49:27Z","updated_at":"2018-08-28T07:49:27Z","html_url":"https://github.com/pytest-dev/pytest/pull/3896#discussion_r213214306","pull_request_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/3896","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments/213214306"},"html":{"href":"https://github.com/pytest-dev/pytest/pull/3896#discussion_r213214306"},"pull_request":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/3896"}},"in_reply_to_id":213185580},"pull_request":{"url":"https://api.github.com/repos/pytest-dev/pytest/pulls/3896","id":211297300,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjk3MzAw","html_url":"https://github.com/pytest-dev/pytest/pull/3896","diff_url":"https://github.com/pytest-dev/pytest/pull/3896.diff","patch_url":"https://github.com/pytest-dev/pytest/pull/3896.patch","issue_url":"https://api.github.com/repos/pytest-dev/pytest/issues/3896","number":3896,"state":"open","locked":false,"title":"TerminalReporter.rewrite to handle lines longer than terminal width","user":{"login":"stephenrauch","id":10407290,"node_id":"MDQ6VXNlcjEwNDA3Mjkw","avatar_url":"https://avatars1.githubusercontent.com/u/10407290?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenrauch","html_url":"https://github.com/stephenrauch","followers_url":"https://api.github.com/users/stephenrauch/followers","following_url":"https://api.github.com/users/stephenrauch/following{/other_user}","gists_url":"https://api.github.com/users/stephenrauch/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenrauch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenrauch/subscriptions","organizations_url":"https://api.github.com/users/stephenrauch/orgs","repos_url":"https://api.github.com/users/stephenrauch/repos","events_url":"https://api.github.com/users/stephenrauch/events{/privacy}","received_events_url":"https://api.github.com/users/stephenrauch/received_events","type":"User","site_admin":false},"body":"If `TerminalReporter.rewrite` is passed a line wider than the terminal, the result is that the terminal will scroll with each update.  I ran into this while using xdist and 16 threads and 1k+ test cases.  During the gathering of the test cases, the terminal did some unwanted scrolling.\r\n\r\nThis change will take advantage of terminals that can do vertical scrolling to clean up the display in these cases.","created_at":"2018-08-28T04:21:22Z","updated_at":"2018-08-28T07:49:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b9edb4e1e088580412f394ebf32a40d4bb1a8ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/3896/commits","review_comments_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/3896/comments","review_comment_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytest-dev/pytest/issues/3896/comments","statuses_url":"https://api.github.com/repos/pytest-dev/pytest/statuses/f782db22a73364648834c05540f037750e0b5c85","head":{"label":"stephenrauch:multi-line-terminal-rewrite","ref":"multi-line-terminal-rewrite","sha":"f782db22a73364648834c05540f037750e0b5c85","user":{"login":"stephenrauch","id":10407290,"node_id":"MDQ6VXNlcjEwNDA3Mjkw","avatar_url":"https://avatars1.githubusercontent.com/u/10407290?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenrauch","html_url":"https://github.com/stephenrauch","followers_url":"https://api.github.com/users/stephenrauch/followers","following_url":"https://api.github.com/users/stephenrauch/following{/other_user}","gists_url":"https://api.github.com/users/stephenrauch/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenrauch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenrauch/subscriptions","organizations_url":"https://api.github.com/users/stephenrauch/orgs","repos_url":"https://api.github.com/users/stephenrauch/repos","events_url":"https://api.github.com/users/stephenrauch/events{/privacy}","received_events_url":"https://api.github.com/users/stephenrauch/received_events","type":"User","site_admin":false},"repo":{"id":144782504,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3ODI1MDQ=","name":"pytest","full_name":"stephenrauch/pytest","owner":{"login":"stephenrauch","id":10407290,"node_id":"MDQ6VXNlcjEwNDA3Mjkw","avatar_url":"https://avatars1.githubusercontent.com/u/10407290?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenrauch","html_url":"https://github.com/stephenrauch","followers_url":"https://api.github.com/users/stephenrauch/followers","following_url":"https://api.github.com/users/stephenrauch/following{/other_user}","gists_url":"https://api.github.com/users/stephenrauch/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenrauch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenrauch/subscriptions","organizations_url":"https://api.github.com/users/stephenrauch/orgs","repos_url":"https://api.github.com/users/stephenrauch/repos","events_url":"https://api.github.com/users/stephenrauch/events{/privacy}","received_events_url":"https://api.github.com/users/stephenrauch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephenrauch/pytest","description":"The pytest framework makes it easy to write small tests, yet scales to support complex functional testing","fork":true,"url":"https://api.github.com/repos/stephenrauch/pytest","forks_url":"https://api.github.com/repos/stephenrauch/pytest/forks","keys_url":"https://api.github.com/repos/stephenrauch/pytest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephenrauch/pytest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephenrauch/pytest/teams","hooks_url":"https://api.github.com/repos/stephenrauch/pytest/hooks","issue_events_url":"https://api.github.com/repos/stephenrauch/pytest/issues/events{/number}","events_url":"https://api.github.com/repos/stephenrauch/pytest/events","assignees_url":"https://api.github.com/repos/stephenrauch/pytest/assignees{/user}","branches_url":"https://api.github.com/repos/stephenrauch/pytest/branches{/branch}","tags_url":"https://api.github.com/repos/stephenrauch/pytest/tags","blobs_url":"https://api.github.com/repos/stephenrauch/pytest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephenrauch/pytest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephenrauch/pytest/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephenrauch/pytest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephenrauch/pytest/statuses/{sha}","languages_url":"https://api.github.com/repos/stephenrauch/pytest/languages","stargazers_url":"https://api.github.com/repos/stephenrauch/pytest/stargazers","contributors_url":"https://api.github.com/repos/stephenrauch/pytest/contributors","subscribers_url":"https://api.github.com/repos/stephenrauch/pytest/subscribers","subscription_url":"https://api.github.com/repos/stephenrauch/pytest/subscription","commits_url":"https://api.github.com/repos/stephenrauch/pytest/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephenrauch/pytest/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephenrauch/pytest/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephenrauch/pytest/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephenrauch/pytest/contents/{+path}","compare_url":"https://api.github.com/repos/stephenrauch/pytest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephenrauch/pytest/merges","archive_url":"https://api.github.com/repos/stephenrauch/pytest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephenrauch/pytest/downloads","issues_url":"https://api.github.com/repos/stephenrauch/pytest/issues{/number}","pulls_url":"https://api.github.com/repos/stephenrauch/pytest/pulls{/number}","milestones_url":"https://api.github.com/repos/stephenrauch/pytest/milestones{/number}","notifications_url":"https://api.github.com/repos/stephenrauch/pytest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephenrauch/pytest/labels{/name}","releases_url":"https://api.github.com/repos/stephenrauch/pytest/releases{/id}","deployments_url":"https://api.github.com/repos/stephenrauch/pytest/deployments","created_at":"2018-08-14T23:34:47Z","updated_at":"2018-08-28T04:29:14Z","pushed_at":"2018-08-28T04:29:11Z","git_url":"git://github.com/stephenrauch/pytest.git","ssh_url":"git@github.com:stephenrauch/pytest.git","clone_url":"https://github.com/stephenrauch/pytest.git","svn_url":"https://github.com/stephenrauch/pytest","homepage":"http://pytest.org/","size":13463,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytest-dev:master","ref":"master","sha":"2a059b1c1bff392252c02413c89913dd672af168","user":{"login":"pytest-dev","id":8897583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4OTc1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/8897583?v=4","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":37489525,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ4OTUyNQ==","name":"pytest","full_name":"pytest-dev/pytest","owner":{"login":"pytest-dev","id":8897583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4OTc1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/8897583?v=4","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytest-dev/pytest","description":"The pytest framework makes it easy to write small tests, yet scales to support complex functional testing","fork":false,"url":"https://api.github.com/repos/pytest-dev/pytest","forks_url":"https://api.github.com/repos/pytest-dev/pytest/forks","keys_url":"https://api.github.com/repos/pytest-dev/pytest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytest-dev/pytest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytest-dev/pytest/teams","hooks_url":"https://api.github.com/repos/pytest-dev/pytest/hooks","issue_events_url":"https://api.github.com/repos/pytest-dev/pytest/issues/events{/number}","events_url":"https://api.github.com/repos/pytest-dev/pytest/events","assignees_url":"https://api.github.com/repos/pytest-dev/pytest/assignees{/user}","branches_url":"https://api.github.com/repos/pytest-dev/pytest/branches{/branch}","tags_url":"https://api.github.com/repos/pytest-dev/pytest/tags","blobs_url":"https://api.github.com/repos/pytest-dev/pytest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytest-dev/pytest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytest-dev/pytest/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytest-dev/pytest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytest-dev/pytest/statuses/{sha}","languages_url":"https://api.github.com/repos/pytest-dev/pytest/languages","stargazers_url":"https://api.github.com/repos/pytest-dev/pytest/stargazers","contributors_url":"https://api.github.com/repos/pytest-dev/pytest/contributors","subscribers_url":"https://api.github.com/repos/pytest-dev/pytest/subscribers","subscription_url":"https://api.github.com/repos/pytest-dev/pytest/subscription","commits_url":"https://api.github.com/repos/pytest-dev/pytest/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytest-dev/pytest/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytest-dev/pytest/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytest-dev/pytest/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytest-dev/pytest/contents/{+path}","compare_url":"https://api.github.com/repos/pytest-dev/pytest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytest-dev/pytest/merges","archive_url":"https://api.github.com/repos/pytest-dev/pytest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytest-dev/pytest/downloads","issues_url":"https://api.github.com/repos/pytest-dev/pytest/issues{/number}","pulls_url":"https://api.github.com/repos/pytest-dev/pytest/pulls{/number}","milestones_url":"https://api.github.com/repos/pytest-dev/pytest/milestones{/number}","notifications_url":"https://api.github.com/repos/pytest-dev/pytest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytest-dev/pytest/labels{/name}","releases_url":"https://api.github.com/repos/pytest-dev/pytest/releases{/id}","deployments_url":"https://api.github.com/repos/pytest-dev/pytest/deployments","created_at":"2015-06-15T20:28:27Z","updated_at":"2018-08-28T07:26:18Z","pushed_at":"2018-08-28T04:27:54Z","git_url":"git://github.com/pytest-dev/pytest.git","ssh_url":"git@github.com:pytest-dev/pytest.git","clone_url":"https://github.com/pytest-dev/pytest.git","svn_url":"https://github.com/pytest-dev/pytest","homepage":"http://pytest.org/","size":13471,"stargazers_count":2964,"watchers_count":2964,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":757,"mirror_url":null,"archived":false,"open_issues_count":541,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":757,"open_issues":541,"watchers":2964,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/3896"},"html":{"href":"https://github.com/pytest-dev/pytest/pull/3896"},"issue":{"href":"https://api.github.com/repos/pytest-dev/pytest/issues/3896"},"comments":{"href":"https://api.github.com/repos/pytest-dev/pytest/issues/3896/comments"},"review_comments":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/3896/comments"},"review_comment":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/3896/commits"},"statuses":{"href":"https://api.github.com/repos/pytest-dev/pytest/statuses/f782db22a73364648834c05540f037750e0b5c85"}},"author_association":"NONE"}}
{"actor":{"display_login":"RonnyPfannschmidt"}}