{"action":"created","issue":{"url":"https://api.github.com/repos/AndyGrant/Ethereal/issues/46","repository_url":"https://api.github.com/repos/AndyGrant/Ethereal","labels_url":"https://api.github.com/repos/AndyGrant/Ethereal/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/AndyGrant/Ethereal/issues/46/comments","events_url":"https://api.github.com/repos/AndyGrant/Ethereal/issues/46/events","html_url":"https://github.com/AndyGrant/Ethereal/pull/46","id":326806644,"number":46,"title":"printMove() -> moveToString()","user":{"login":"lucasart","id":2278294,"avatar_url":"https://avatars2.githubusercontent.com/u/2278294?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasart","html_url":"https://github.com/lucasart","followers_url":"https://api.github.com/users/lucasart/followers","following_url":"https://api.github.com/users/lucasart/following{/other_user}","gists_url":"https://api.github.com/users/lucasart/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasart/subscriptions","organizations_url":"https://api.github.com/users/lucasart/orgs","repos_url":"https://api.github.com/users/lucasart/repos","events_url":"https://api.github.com/users/lucasart/events{/privacy}","received_events_url":"https://api.github.com/users/lucasart/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-27T11:00:55Z","updated_at":"2018-05-27T23:18:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/AndyGrant/Ethereal/pulls/46","html_url":"https://github.com/AndyGrant/Ethereal/pull/46","diff_url":"https://github.com/AndyGrant/Ethereal/pull/46.diff","patch_url":"https://github.com/AndyGrant/Ethereal/pull/46.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/AndyGrant/Ethereal/issues/comments/392385718","html_url":"https://github.com/AndyGrant/Ethereal/pull/46#issuecomment-392385718","issue_url":"https://api.github.com/repos/AndyGrant/Ethereal/issues/46","id":392385718,"user":{"login":"lucasart","id":2278294,"avatar_url":"https://avatars2.githubusercontent.com/u/2278294?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasart","html_url":"https://github.com/lucasart","followers_url":"https://api.github.com/users/lucasart/followers","following_url":"https://api.github.com/users/lucasart/following{/other_user}","gists_url":"https://api.github.com/users/lucasart/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasart/subscriptions","organizations_url":"https://api.github.com/users/lucasart/orgs","repos_url":"https://api.github.com/users/lucasart/repos","events_url":"https://api.github.com/users/lucasart/events{/privacy}","received_events_url":"https://api.github.com/users/lucasart/received_events","type":"User","site_admin":false},"created_at":"2018-05-27T23:18:23Z","updated_at":"2018-05-27T23:18:23Z","author_association":"CONTRIBUTOR","body":"> In board.c, lets move const char *PieceLabel[COLOUR_NB] = {\"PNBRQK\", \"pnbrqk\"}; before my list of positions.\r\n\r\nDone, along with removing NUM_BENCHMARKS. Instead, it's discovered as we loop across the array. Makes the code flexible (ie. just add/remove strings from Benchmarks[], nothing to change).\r\n\r\n> In move.c::moveToString() do you not want to set str[4] = '\\0' for non promotions?\r\n\r\nThis is taken care of by squareToString().\r\n\r\n> Throughout I prefer to not use puts(), and use printf(\"%s\\n\", str);\r\n\r\nputs() is the most straightforward way to print a string. Instead, I find printf(\"%s\\n\", str) quite convoluted. And significantly slower (because it has a lot more work to do, implementing printf() from scratch is not simple). So it seems to me that the good habit is to use puts() and only printf() when you need to.\r\n\r\n> You closed the Zobrist PR. Do you want to put the rename in this patch ?\r\n\r\nYes. Well there was not much point. A more worthy patch would be to completely redesign the Zobrist logic, perhaps along with FRC. But that's a bit more work."}}
{"actor":{"display_login":"lucasart"}}