{"action":"created","issue":{"url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant-modules/issues/98","repository_url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant-modules","labels_url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant-modules/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant-modules/issues/98/comments","events_url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant-modules/issues/98/events","html_url":"https://github.com/upgrades-migrations/preupgrade-assistant-modules/pull/98","id":338306120,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MjcyNzU0","number":98,"title":" networking/samba - RFE","user":{"login":"jmazanek","id":16332741,"node_id":"MDQ6VXNlcjE2MzMyNzQx","avatar_url":"https://avatars3.githubusercontent.com/u/16332741?v=4","gravatar_id":"","url":"https://api.github.com/users/jmazanek","html_url":"https://github.com/jmazanek","followers_url":"https://api.github.com/users/jmazanek/followers","following_url":"https://api.github.com/users/jmazanek/following{/other_user}","gists_url":"https://api.github.com/users/jmazanek/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazanek/subscriptions","organizations_url":"https://api.github.com/users/jmazanek/orgs","repos_url":"https://api.github.com/users/jmazanek/repos","events_url":"https://api.github.com/users/jmazanek/events{/privacy}","received_events_url":"https://api.github.com/users/jmazanek/received_events","type":"User","site_admin":false},"labels":[{"id":661255201,"node_id":"MDU6TGFiZWw2NjEyNTUyMDE=","url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant-modules/labels/enhancement","name":"enhancement","color":"5ff611","default":true},{"id":673422481,"node_id":"MDU6TGFiZWw2NzM0MjI0ODE=","url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant-modules/labels/needs_verify","name":"needs_verify","color":"e99695","default":false},{"id":703454290,"node_id":"MDU6TGFiZWw3MDM0NTQyOTA=","url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant-modules/labels/on_qe","name":"on_qe","color":"c2e0c6","default":false},{"id":698899287,"node_id":"MDU6TGFiZWw2OTg4OTkyODc=","url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant-modules/labels/text_reviewed","name":"text_reviewed","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"jmazanek","id":16332741,"node_id":"MDQ6VXNlcjE2MzMyNzQx","avatar_url":"https://avatars3.githubusercontent.com/u/16332741?v=4","gravatar_id":"","url":"https://api.github.com/users/jmazanek","html_url":"https://github.com/jmazanek","followers_url":"https://api.github.com/users/jmazanek/followers","following_url":"https://api.github.com/users/jmazanek/following{/other_user}","gists_url":"https://api.github.com/users/jmazanek/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazanek/subscriptions","organizations_url":"https://api.github.com/users/jmazanek/orgs","repos_url":"https://api.github.com/users/jmazanek/repos","events_url":"https://api.github.com/users/jmazanek/events{/privacy}","received_events_url":"https://api.github.com/users/jmazanek/received_events","type":"User","site_admin":false},"assignees":[{"login":"jmazanek","id":16332741,"node_id":"MDQ6VXNlcjE2MzMyNzQx","avatar_url":"https://avatars3.githubusercontent.com/u/16332741?v=4","gravatar_id":"","url":"https://api.github.com/users/jmazanek","html_url":"https://github.com/jmazanek","followers_url":"https://api.github.com/users/jmazanek/followers","following_url":"https://api.github.com/users/jmazanek/following{/other_user}","gists_url":"https://api.github.com/users/jmazanek/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazanek/subscriptions","organizations_url":"https://api.github.com/users/jmazanek/orgs","repos_url":"https://api.github.com/users/jmazanek/repos","events_url":"https://api.github.com/users/jmazanek/events{/privacy}","received_events_url":"https://api.github.com/users/jmazanek/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant-modules/milestones/5","html_url":"https://github.com/upgrades-migrations/preupgrade-assistant-modules/milestone/5","labels_url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant-modules/milestones/5/labels","id":3391893,"node_id":"MDk6TWlsZXN0b25lMzM5MTg5Mw==","number":5,"title":"el610toel76b0","description":"","creator":{"login":"pirat89","id":1656374,"node_id":"MDQ6VXNlcjE2NTYzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1656374?v=4","gravatar_id":"","url":"https://api.github.com/users/pirat89","html_url":"https://github.com/pirat89","followers_url":"https://api.github.com/users/pirat89/followers","following_url":"https://api.github.com/users/pirat89/following{/other_user}","gists_url":"https://api.github.com/users/pirat89/gists{/gist_id}","starred_url":"https://api.github.com/users/pirat89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pirat89/subscriptions","organizations_url":"https://api.github.com/users/pirat89/orgs","repos_url":"https://api.github.com/users/pirat89/repos","events_url":"https://api.github.com/users/pirat89/events{/privacy}","received_events_url":"https://api.github.com/users/pirat89/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":4,"state":"open","created_at":"2018-05-31T21:23:27Z","updated_at":"2018-08-22T13:51:42Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-07-04T14:54:37Z","updated_at":"2018-08-22T14:57:13Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant-modules/pulls/98","html_url":"https://github.com/upgrades-migrations/preupgrade-assistant-modules/pull/98","diff_url":"https://github.com/upgrades-migrations/preupgrade-assistant-modules/pull/98.diff","patch_url":"https://github.com/upgrades-migrations/preupgrade-assistant-modules/pull/98.patch"},"body":" - prints the informative messages for the\r\n   user about possible incompatibilities\r\n   of the samba configuration file\r\n   on the target system.\r\n - creates a post-upgrade script\r\n   checking the validity of the\r\n   configuration file after upgrade."},"comment":{"url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant-modules/issues/comments/415062157","html_url":"https://github.com/upgrades-migrations/preupgrade-assistant-modules/pull/98#issuecomment-415062157","issue_url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant-modules/issues/98","id":415062157,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTA2MjE1Nw==","user":{"login":"AloisMahdal","id":217935,"node_id":"MDQ6VXNlcjIxNzkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/217935?v=4","gravatar_id":"","url":"https://api.github.com/users/AloisMahdal","html_url":"https://github.com/AloisMahdal","followers_url":"https://api.github.com/users/AloisMahdal/followers","following_url":"https://api.github.com/users/AloisMahdal/following{/other_user}","gists_url":"https://api.github.com/users/AloisMahdal/gists{/gist_id}","starred_url":"https://api.github.com/users/AloisMahdal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AloisMahdal/subscriptions","organizations_url":"https://api.github.com/users/AloisMahdal/orgs","repos_url":"https://api.github.com/users/AloisMahdal/repos","events_url":"https://api.github.com/users/AloisMahdal/events{/privacy}","received_events_url":"https://api.github.com/users/AloisMahdal/received_events","type":"User","site_admin":false},"created_at":"2018-08-22T14:57:13Z","updated_at":"2018-08-22T14:57:13Z","author_association":"CONTRIBUTOR","body":"Can you please confirm, @jmazanek\r\n\r\n> 3.  Pre-upgrade results:\r\n>\r\n>    - New log_medium_risk message informing user about possible incompatibilities in samba configuration should be printed in p-a result.\r\n>    - New message informing user about post-upgrade script and how to get the more detailed information after upgrade is appended to `$SOLUTION_FILE`.\r\n>    - The post-upgrade script is created in `/root/preupgrade/postupgrade.d/smb/` directory.\r\n>\r\n> 5. Post-upgrade results:\r\n>\r\n>   - In the post-upgrade phase, post-upgrade script is run and checks the compatibility of the samba configuration file.\r\n\r\nAre all these results triggered merely by installing the samba-common?  (Ie. do we need to actually add some directives?)\r\n\r\nIf so, I assume these should be already observed in the samba tests we have. (I assume the samba-common is dependency of all samba-related stuff.)"}}
{"actor":{"display_login":"AloisMahdal"}}