{"action":"created","comment":{"url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/pulls/comments/165428800","pull_request_review_id":93367191,"id":165428800,"diff_hunk":"@@ -33,7 +32,8 @@\n         'django_prices_openexchangerates.templatetags'],\n     include_package_data=True,\n     classifiers=CLASSIFIERS,\n-    install_requires=['Django>=1.4', 'django-prices>=1.0.0-beta2', 'prices>=1.0.0-beta2'],\n+    install_requires=[\n+        'Django<2.1.0', 'django-prices>=1.0.0-beta3', 'prices>=1.0.0-beta3'],","path":"setup.py","position":14,"original_position":14,"commit_id":"b130e3ad7a042f8a358cdc744297c0120bd7bebe","original_commit_id":"b130e3ad7a042f8a358cdc744297c0120bd7bebe","user":{"login":"patrys","id":81205,"avatar_url":"https://avatars1.githubusercontent.com/u/81205?v=4","gravatar_id":"","url":"https://api.github.com/users/patrys","html_url":"https://github.com/patrys","followers_url":"https://api.github.com/users/patrys/followers","following_url":"https://api.github.com/users/patrys/following{/other_user}","gists_url":"https://api.github.com/users/patrys/gists{/gist_id}","starred_url":"https://api.github.com/users/patrys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrys/subscriptions","organizations_url":"https://api.github.com/users/patrys/orgs","repos_url":"https://api.github.com/users/patrys/repos","events_url":"https://api.github.com/users/patrys/events{/privacy}","received_events_url":"https://api.github.com/users/patrys/received_events","type":"User","site_admin":false},"body":"Why `Django<2.1.0` instead of `Django>=1.11`?","created_at":"2018-02-01T17:27:10Z","updated_at":"2018-02-01T17:27:10Z","html_url":"https://github.com/mirumee/django-prices-openexchangerates/pull/27#discussion_r165428800","pull_request_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/pulls/27","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/pulls/comments/165428800"},"html":{"href":"https://github.com/mirumee/django-prices-openexchangerates/pull/27#discussion_r165428800"},"pull_request":{"href":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/pulls/27","id":165676201,"html_url":"https://github.com/mirumee/django-prices-openexchangerates/pull/27","diff_url":"https://github.com/mirumee/django-prices-openexchangerates/pull/27.diff","patch_url":"https://github.com/mirumee/django-prices-openexchangerates/pull/27.patch","issue_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/issues/27","number":27,"state":"open","locked":false,"title":"Update lib to work with prices/django-prices beta 3","user":{"login":"rafalp","id":750553,"avatar_url":"https://avatars1.githubusercontent.com/u/750553?v=4","gravatar_id":"","url":"https://api.github.com/users/rafalp","html_url":"https://github.com/rafalp","followers_url":"https://api.github.com/users/rafalp/followers","following_url":"https://api.github.com/users/rafalp/following{/other_user}","gists_url":"https://api.github.com/users/rafalp/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalp/subscriptions","organizations_url":"https://api.github.com/users/rafalp/orgs","repos_url":"https://api.github.com/users/rafalp/repos","events_url":"https://api.github.com/users/rafalp/events{/privacy}","received_events_url":"https://api.github.com/users/rafalp/received_events","type":"User","site_admin":false},"body":"This PR is followup for changes that occured in prices 1.0.0b3 and django-prices. In addition this PR adds extra tests for better coverage as well as synces our requirements and tests config with prices and django prices.\r\n\r\n**TODO**\r\n\r\n* [x] Make tests pass\r\n* [x] Sync requirements with other libs\r\n* [x] Test `discount_amount_in_currency`\r\n* [x] Rename 'value' and 'price' to 'base' whenever value's usage is unknown or too generic\r\n* [x] Remove `from __future__` imports\r\n* [ ] Try refactoring `convert_price`\r\n* [ ] Add `mypy` type annotations wherever possible","created_at":"2018-01-29T11:13:20Z","updated_at":"2018-02-01T17:27:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4781aeb8aee7ae3abd7bb26d2b10187ab9bd41d0","assignee":{"login":"rafalp","id":750553,"avatar_url":"https://avatars1.githubusercontent.com/u/750553?v=4","gravatar_id":"","url":"https://api.github.com/users/rafalp","html_url":"https://github.com/rafalp","followers_url":"https://api.github.com/users/rafalp/followers","following_url":"https://api.github.com/users/rafalp/following{/other_user}","gists_url":"https://api.github.com/users/rafalp/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalp/subscriptions","organizations_url":"https://api.github.com/users/rafalp/orgs","repos_url":"https://api.github.com/users/rafalp/repos","events_url":"https://api.github.com/users/rafalp/events{/privacy}","received_events_url":"https://api.github.com/users/rafalp/received_events","type":"User","site_admin":false},"assignees":[{"login":"rafalp","id":750553,"avatar_url":"https://avatars1.githubusercontent.com/u/750553?v=4","gravatar_id":"","url":"https://api.github.com/users/rafalp","html_url":"https://github.com/rafalp","followers_url":"https://api.github.com/users/rafalp/followers","following_url":"https://api.github.com/users/rafalp/following{/other_user}","gists_url":"https://api.github.com/users/rafalp/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalp/subscriptions","organizations_url":"https://api.github.com/users/rafalp/orgs","repos_url":"https://api.github.com/users/rafalp/repos","events_url":"https://api.github.com/users/rafalp/events{/privacy}","received_events_url":"https://api.github.com/users/rafalp/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/pulls/27/commits","review_comments_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/pulls/27/comments","review_comment_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/issues/27/comments","statuses_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/statuses/b130e3ad7a042f8a358cdc744297c0120bd7bebe","head":{"label":"mirumee:update-to-prices-beta-3","ref":"update-to-prices-beta-3","sha":"b130e3ad7a042f8a358cdc744297c0120bd7bebe","user":{"login":"mirumee","id":170574,"avatar_url":"https://avatars3.githubusercontent.com/u/170574?v=4","gravatar_id":"","url":"https://api.github.com/users/mirumee","html_url":"https://github.com/mirumee","followers_url":"https://api.github.com/users/mirumee/followers","following_url":"https://api.github.com/users/mirumee/following{/other_user}","gists_url":"https://api.github.com/users/mirumee/gists{/gist_id}","starred_url":"https://api.github.com/users/mirumee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirumee/subscriptions","organizations_url":"https://api.github.com/users/mirumee/orgs","repos_url":"https://api.github.com/users/mirumee/repos","events_url":"https://api.github.com/users/mirumee/events{/privacy}","received_events_url":"https://api.github.com/users/mirumee/received_events","type":"Organization","site_admin":false},"repo":{"id":29908545,"name":"django-prices-openexchangerates","full_name":"mirumee/django-prices-openexchangerates","owner":{"login":"mirumee","id":170574,"avatar_url":"https://avatars3.githubusercontent.com/u/170574?v=4","gravatar_id":"","url":"https://api.github.com/users/mirumee","html_url":"https://github.com/mirumee","followers_url":"https://api.github.com/users/mirumee/followers","following_url":"https://api.github.com/users/mirumee/following{/other_user}","gists_url":"https://api.github.com/users/mirumee/gists{/gist_id}","starred_url":"https://api.github.com/users/mirumee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirumee/subscriptions","organizations_url":"https://api.github.com/users/mirumee/orgs","repos_url":"https://api.github.com/users/mirumee/repos","events_url":"https://api.github.com/users/mirumee/events{/privacy}","received_events_url":"https://api.github.com/users/mirumee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mirumee/django-prices-openexchangerates","description":"openexchangerates.org support for django-prices","fork":false,"url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates","forks_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/forks","keys_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/teams","hooks_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/hooks","issue_events_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/issues/events{/number}","events_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/events","assignees_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/assignees{/user}","branches_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/branches{/branch}","tags_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/tags","blobs_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/statuses/{sha}","languages_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/languages","stargazers_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/stargazers","contributors_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/contributors","subscribers_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/subscribers","subscription_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/subscription","commits_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/contents/{+path}","compare_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/merges","archive_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/downloads","issues_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/issues{/number}","pulls_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/pulls{/number}","milestones_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/milestones{/number}","notifications_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/labels{/name}","releases_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/releases{/id}","deployments_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/deployments","created_at":"2015-01-27T10:10:35Z","updated_at":"2018-01-14T14:01:39Z","pushed_at":"2018-02-01T17:00:32Z","git_url":"git://github.com/mirumee/django-prices-openexchangerates.git","ssh_url":"git@github.com:mirumee/django-prices-openexchangerates.git","clone_url":"https://github.com/mirumee/django-prices-openexchangerates.git","svn_url":"https://github.com/mirumee/django-prices-openexchangerates","homepage":null,"size":113,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":7,"open_issues":2,"watchers":12,"default_branch":"master"}},"base":{"label":"mirumee:master","ref":"master","sha":"dfb6678982bb1216e321c784f5c8b571b10042c8","user":{"login":"mirumee","id":170574,"avatar_url":"https://avatars3.githubusercontent.com/u/170574?v=4","gravatar_id":"","url":"https://api.github.com/users/mirumee","html_url":"https://github.com/mirumee","followers_url":"https://api.github.com/users/mirumee/followers","following_url":"https://api.github.com/users/mirumee/following{/other_user}","gists_url":"https://api.github.com/users/mirumee/gists{/gist_id}","starred_url":"https://api.github.com/users/mirumee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirumee/subscriptions","organizations_url":"https://api.github.com/users/mirumee/orgs","repos_url":"https://api.github.com/users/mirumee/repos","events_url":"https://api.github.com/users/mirumee/events{/privacy}","received_events_url":"https://api.github.com/users/mirumee/received_events","type":"Organization","site_admin":false},"repo":{"id":29908545,"name":"django-prices-openexchangerates","full_name":"mirumee/django-prices-openexchangerates","owner":{"login":"mirumee","id":170574,"avatar_url":"https://avatars3.githubusercontent.com/u/170574?v=4","gravatar_id":"","url":"https://api.github.com/users/mirumee","html_url":"https://github.com/mirumee","followers_url":"https://api.github.com/users/mirumee/followers","following_url":"https://api.github.com/users/mirumee/following{/other_user}","gists_url":"https://api.github.com/users/mirumee/gists{/gist_id}","starred_url":"https://api.github.com/users/mirumee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirumee/subscriptions","organizations_url":"https://api.github.com/users/mirumee/orgs","repos_url":"https://api.github.com/users/mirumee/repos","events_url":"https://api.github.com/users/mirumee/events{/privacy}","received_events_url":"https://api.github.com/users/mirumee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mirumee/django-prices-openexchangerates","description":"openexchangerates.org support for django-prices","fork":false,"url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates","forks_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/forks","keys_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/teams","hooks_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/hooks","issue_events_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/issues/events{/number}","events_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/events","assignees_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/assignees{/user}","branches_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/branches{/branch}","tags_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/tags","blobs_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/statuses/{sha}","languages_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/languages","stargazers_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/stargazers","contributors_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/contributors","subscribers_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/subscribers","subscription_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/subscription","commits_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/contents/{+path}","compare_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/merges","archive_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/downloads","issues_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/issues{/number}","pulls_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/pulls{/number}","milestones_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/milestones{/number}","notifications_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/labels{/name}","releases_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/releases{/id}","deployments_url":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/deployments","created_at":"2015-01-27T10:10:35Z","updated_at":"2018-01-14T14:01:39Z","pushed_at":"2018-02-01T17:00:32Z","git_url":"git://github.com/mirumee/django-prices-openexchangerates.git","ssh_url":"git@github.com:mirumee/django-prices-openexchangerates.git","clone_url":"https://github.com/mirumee/django-prices-openexchangerates.git","svn_url":"https://github.com/mirumee/django-prices-openexchangerates","homepage":null,"size":113,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":7,"open_issues":2,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/pulls/27"},"html":{"href":"https://github.com/mirumee/django-prices-openexchangerates/pull/27"},"issue":{"href":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/issues/27"},"comments":{"href":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/mirumee/django-prices-openexchangerates/statuses/b130e3ad7a042f8a358cdc744297c0120bd7bebe"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"patrys"}}