{"action":"created","comment":{"url":"https://api.github.com/repos/satellogic/telluric/pulls/comments/199758878","pull_request_review_id":133938174,"id":199758878,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTc1ODg3OA==","diff_hunk":"@@ -34,9 +34,14 @@ def rasterize(shapes, crs, bounds=None, dest_resolution=None, *, fill_value=None\n     if nodata_value is not None:\n         warnings.warn(NODATA_DEPRECATION_WARNING, DeprecationWarning)\n \n-    if not(dest_resolution):\n+    if not dest_resolution:\n         raise ValueError(\"dest_resolution must be specified\")\n \n+    elif isinstance(dest_resolution, (int, float)):\n+        rx = ry = dest_resolution","path":"telluric/rasterization.py","position":9,"original_position":9,"commit_id":"b0bf2e72667cb382f307e3b6114d04461c95aa01","original_commit_id":"b0bf2e72667cb382f307e3b6114d04461c95aa01","user":{"login":"Juanlu001","id":316517,"node_id":"MDQ6VXNlcjMxNjUxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/316517?v=4","gravatar_id":"","url":"https://api.github.com/users/Juanlu001","html_url":"https://github.com/Juanlu001","followers_url":"https://api.github.com/users/Juanlu001/followers","following_url":"https://api.github.com/users/Juanlu001/following{/other_user}","gists_url":"https://api.github.com/users/Juanlu001/gists{/gist_id}","starred_url":"https://api.github.com/users/Juanlu001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juanlu001/subscriptions","organizations_url":"https://api.github.com/users/Juanlu001/orgs","repos_url":"https://api.github.com/users/Juanlu001/repos","events_url":"https://api.github.com/users/Juanlu001/events{/privacy}","received_events_url":"https://api.github.com/users/Juanlu001/received_events","type":"User","site_admin":false},"body":"The case `rx = ry = dest_resolution` is the case we were supporting before. The new case is when `rx != ry` (next block).","created_at":"2018-07-03T10:29:51Z","updated_at":"2018-07-03T10:29:51Z","html_url":"https://github.com/satellogic/telluric/pull/62#discussion_r199758878","pull_request_url":"https://api.github.com/repos/satellogic/telluric/pulls/62","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/satellogic/telluric/pulls/comments/199758878"},"html":{"href":"https://github.com/satellogic/telluric/pull/62#discussion_r199758878"},"pull_request":{"href":"https://api.github.com/repos/satellogic/telluric/pulls/62"}},"in_reply_to_id":199689100},"pull_request":{"url":"https://api.github.com/repos/satellogic/telluric/pulls/62","id":196125613,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MTI1NjEz","html_url":"https://github.com/satellogic/telluric/pull/62","diff_url":"https://github.com/satellogic/telluric/pull/62.diff","patch_url":"https://github.com/satellogic/telluric/pull/62.patch","issue_url":"https://api.github.com/repos/satellogic/telluric/issues/62","number":62,"state":"open","locked":false,"title":"Miscellaneous GeoRaster2 fixes","user":{"login":"Juanlu001","id":316517,"node_id":"MDQ6VXNlcjMxNjUxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/316517?v=4","gravatar_id":"","url":"https://api.github.com/users/Juanlu001","html_url":"https://github.com/Juanlu001","followers_url":"https://api.github.com/users/Juanlu001/followers","following_url":"https://api.github.com/users/Juanlu001/following{/other_user}","gists_url":"https://api.github.com/users/Juanlu001/gists{/gist_id}","starred_url":"https://api.github.com/users/Juanlu001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juanlu001/subscriptions","organizations_url":"https://api.github.com/users/Juanlu001/orgs","repos_url":"https://api.github.com/users/Juanlu001/repos","events_url":"https://api.github.com/users/Juanlu001/events{/privacy}","received_events_url":"https://api.github.com/users/Juanlu001/received_events","type":"User","site_admin":false},"body":"This fixes #61 but there's one remaning failing test that I'm not sure how to modify:\r\n\r\nhttps://github.com/satellogic/telluric/blob/f34c79d2cfae4d67dc77d702dafef2a3b2904f5b/tests/test_georaster_tiling.py#L422-L430\r\n\r\nSuggestions @arielze?","created_at":"2018-06-20T12:45:06Z","updated_at":"2018-07-03T10:29:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3281575c84750be03cf0e46ce44948b1abfca1f5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"arielze","id":1247079,"node_id":"MDQ6VXNlcjEyNDcwNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1247079?v=4","gravatar_id":"","url":"https://api.github.com/users/arielze","html_url":"https://github.com/arielze","followers_url":"https://api.github.com/users/arielze/followers","following_url":"https://api.github.com/users/arielze/following{/other_user}","gists_url":"https://api.github.com/users/arielze/gists{/gist_id}","starred_url":"https://api.github.com/users/arielze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielze/subscriptions","organizations_url":"https://api.github.com/users/arielze/orgs","repos_url":"https://api.github.com/users/arielze/repos","events_url":"https://api.github.com/users/arielze/events{/privacy}","received_events_url":"https://api.github.com/users/arielze/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/satellogic/telluric/pulls/62/commits","review_comments_url":"https://api.github.com/repos/satellogic/telluric/pulls/62/comments","review_comment_url":"https://api.github.com/repos/satellogic/telluric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/satellogic/telluric/issues/62/comments","statuses_url":"https://api.github.com/repos/satellogic/telluric/statuses/b0bf2e72667cb382f307e3b6114d04461c95aa01","head":{"label":"Juanlu001:fix-geographic-crop","ref":"fix-geographic-crop","sha":"b0bf2e72667cb382f307e3b6114d04461c95aa01","user":{"login":"Juanlu001","id":316517,"node_id":"MDQ6VXNlcjMxNjUxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/316517?v=4","gravatar_id":"","url":"https://api.github.com/users/Juanlu001","html_url":"https://github.com/Juanlu001","followers_url":"https://api.github.com/users/Juanlu001/followers","following_url":"https://api.github.com/users/Juanlu001/following{/other_user}","gists_url":"https://api.github.com/users/Juanlu001/gists{/gist_id}","starred_url":"https://api.github.com/users/Juanlu001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juanlu001/subscriptions","organizations_url":"https://api.github.com/users/Juanlu001/orgs","repos_url":"https://api.github.com/users/Juanlu001/repos","events_url":"https://api.github.com/users/Juanlu001/events{/privacy}","received_events_url":"https://api.github.com/users/Juanlu001/received_events","type":"User","site_admin":false},"repo":{"id":128917215,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg5MTcyMTU=","name":"telluric","full_name":"Juanlu001/telluric","owner":{"login":"Juanlu001","id":316517,"node_id":"MDQ6VXNlcjMxNjUxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/316517?v=4","gravatar_id":"","url":"https://api.github.com/users/Juanlu001","html_url":"https://github.com/Juanlu001","followers_url":"https://api.github.com/users/Juanlu001/followers","following_url":"https://api.github.com/users/Juanlu001/following{/other_user}","gists_url":"https://api.github.com/users/Juanlu001/gists{/gist_id}","starred_url":"https://api.github.com/users/Juanlu001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juanlu001/subscriptions","organizations_url":"https://api.github.com/users/Juanlu001/orgs","repos_url":"https://api.github.com/users/Juanlu001/repos","events_url":"https://api.github.com/users/Juanlu001/events{/privacy}","received_events_url":"https://api.github.com/users/Juanlu001/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Juanlu001/telluric","description":"telluric is a Python library to manage vector and raster geospatial data in an interactive and easy way","fork":true,"url":"https://api.github.com/repos/Juanlu001/telluric","forks_url":"https://api.github.com/repos/Juanlu001/telluric/forks","keys_url":"https://api.github.com/repos/Juanlu001/telluric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Juanlu001/telluric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Juanlu001/telluric/teams","hooks_url":"https://api.github.com/repos/Juanlu001/telluric/hooks","issue_events_url":"https://api.github.com/repos/Juanlu001/telluric/issues/events{/number}","events_url":"https://api.github.com/repos/Juanlu001/telluric/events","assignees_url":"https://api.github.com/repos/Juanlu001/telluric/assignees{/user}","branches_url":"https://api.github.com/repos/Juanlu001/telluric/branches{/branch}","tags_url":"https://api.github.com/repos/Juanlu001/telluric/tags","blobs_url":"https://api.github.com/repos/Juanlu001/telluric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Juanlu001/telluric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Juanlu001/telluric/git/refs{/sha}","trees_url":"https://api.github.com/repos/Juanlu001/telluric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Juanlu001/telluric/statuses/{sha}","languages_url":"https://api.github.com/repos/Juanlu001/telluric/languages","stargazers_url":"https://api.github.com/repos/Juanlu001/telluric/stargazers","contributors_url":"https://api.github.com/repos/Juanlu001/telluric/contributors","subscribers_url":"https://api.github.com/repos/Juanlu001/telluric/subscribers","subscription_url":"https://api.github.com/repos/Juanlu001/telluric/subscription","commits_url":"https://api.github.com/repos/Juanlu001/telluric/commits{/sha}","git_commits_url":"https://api.github.com/repos/Juanlu001/telluric/git/commits{/sha}","comments_url":"https://api.github.com/repos/Juanlu001/telluric/comments{/number}","issue_comment_url":"https://api.github.com/repos/Juanlu001/telluric/issues/comments{/number}","contents_url":"https://api.github.com/repos/Juanlu001/telluric/contents/{+path}","compare_url":"https://api.github.com/repos/Juanlu001/telluric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Juanlu001/telluric/merges","archive_url":"https://api.github.com/repos/Juanlu001/telluric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Juanlu001/telluric/downloads","issues_url":"https://api.github.com/repos/Juanlu001/telluric/issues{/number}","pulls_url":"https://api.github.com/repos/Juanlu001/telluric/pulls{/number}","milestones_url":"https://api.github.com/repos/Juanlu001/telluric/milestones{/number}","notifications_url":"https://api.github.com/repos/Juanlu001/telluric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Juanlu001/telluric/labels{/name}","releases_url":"https://api.github.com/repos/Juanlu001/telluric/releases{/id}","deployments_url":"https://api.github.com/repos/Juanlu001/telluric/deployments","created_at":"2018-04-10T10:44:29Z","updated_at":"2018-07-02T14:10:54Z","pushed_at":"2018-07-02T16:51:21Z","git_url":"git://github.com/Juanlu001/telluric.git","ssh_url":"git@github.com:Juanlu001/telluric.git","clone_url":"https://github.com/Juanlu001/telluric.git","svn_url":"https://github.com/Juanlu001/telluric","homepage":null,"size":21530,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"satellogic:master","ref":"master","sha":"b6a2100f81efd58da0a5fc55f0565e3a7b32d2b5","user":{"login":"satellogic","id":5545050,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDUwNTA=","avatar_url":"https://avatars2.githubusercontent.com/u/5545050?v=4","gravatar_id":"","url":"https://api.github.com/users/satellogic","html_url":"https://github.com/satellogic","followers_url":"https://api.github.com/users/satellogic/followers","following_url":"https://api.github.com/users/satellogic/following{/other_user}","gists_url":"https://api.github.com/users/satellogic/gists{/gist_id}","starred_url":"https://api.github.com/users/satellogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satellogic/subscriptions","organizations_url":"https://api.github.com/users/satellogic/orgs","repos_url":"https://api.github.com/users/satellogic/repos","events_url":"https://api.github.com/users/satellogic/events{/privacy}","received_events_url":"https://api.github.com/users/satellogic/received_events","type":"Organization","site_admin":false},"repo":{"id":128917083,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg5MTcwODM=","name":"telluric","full_name":"satellogic/telluric","owner":{"login":"satellogic","id":5545050,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDUwNTA=","avatar_url":"https://avatars2.githubusercontent.com/u/5545050?v=4","gravatar_id":"","url":"https://api.github.com/users/satellogic","html_url":"https://github.com/satellogic","followers_url":"https://api.github.com/users/satellogic/followers","following_url":"https://api.github.com/users/satellogic/following{/other_user}","gists_url":"https://api.github.com/users/satellogic/gists{/gist_id}","starred_url":"https://api.github.com/users/satellogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satellogic/subscriptions","organizations_url":"https://api.github.com/users/satellogic/orgs","repos_url":"https://api.github.com/users/satellogic/repos","events_url":"https://api.github.com/users/satellogic/events{/privacy}","received_events_url":"https://api.github.com/users/satellogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/satellogic/telluric","description":"telluric is a Python library to manage vector and raster geospatial data in an interactive and easy way","fork":false,"url":"https://api.github.com/repos/satellogic/telluric","forks_url":"https://api.github.com/repos/satellogic/telluric/forks","keys_url":"https://api.github.com/repos/satellogic/telluric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/satellogic/telluric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/satellogic/telluric/teams","hooks_url":"https://api.github.com/repos/satellogic/telluric/hooks","issue_events_url":"https://api.github.com/repos/satellogic/telluric/issues/events{/number}","events_url":"https://api.github.com/repos/satellogic/telluric/events","assignees_url":"https://api.github.com/repos/satellogic/telluric/assignees{/user}","branches_url":"https://api.github.com/repos/satellogic/telluric/branches{/branch}","tags_url":"https://api.github.com/repos/satellogic/telluric/tags","blobs_url":"https://api.github.com/repos/satellogic/telluric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/satellogic/telluric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/satellogic/telluric/git/refs{/sha}","trees_url":"https://api.github.com/repos/satellogic/telluric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/satellogic/telluric/statuses/{sha}","languages_url":"https://api.github.com/repos/satellogic/telluric/languages","stargazers_url":"https://api.github.com/repos/satellogic/telluric/stargazers","contributors_url":"https://api.github.com/repos/satellogic/telluric/contributors","subscribers_url":"https://api.github.com/repos/satellogic/telluric/subscribers","subscription_url":"https://api.github.com/repos/satellogic/telluric/subscription","commits_url":"https://api.github.com/repos/satellogic/telluric/commits{/sha}","git_commits_url":"https://api.github.com/repos/satellogic/telluric/git/commits{/sha}","comments_url":"https://api.github.com/repos/satellogic/telluric/comments{/number}","issue_comment_url":"https://api.github.com/repos/satellogic/telluric/issues/comments{/number}","contents_url":"https://api.github.com/repos/satellogic/telluric/contents/{+path}","compare_url":"https://api.github.com/repos/satellogic/telluric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/satellogic/telluric/merges","archive_url":"https://api.github.com/repos/satellogic/telluric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/satellogic/telluric/downloads","issues_url":"https://api.github.com/repos/satellogic/telluric/issues{/number}","pulls_url":"https://api.github.com/repos/satellogic/telluric/pulls{/number}","milestones_url":"https://api.github.com/repos/satellogic/telluric/milestones{/number}","notifications_url":"https://api.github.com/repos/satellogic/telluric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/satellogic/telluric/labels{/name}","releases_url":"https://api.github.com/repos/satellogic/telluric/releases{/id}","deployments_url":"https://api.github.com/repos/satellogic/telluric/deployments","created_at":"2018-04-10T10:43:15Z","updated_at":"2018-07-02T14:00:19Z","pushed_at":"2018-07-03T09:47:02Z","git_url":"git://github.com/satellogic/telluric.git","ssh_url":"git@github.com:satellogic/telluric.git","clone_url":"https://github.com/satellogic/telluric.git","svn_url":"https://github.com/satellogic/telluric","homepage":null,"size":21758,"stargazers_count":20,"watchers_count":20,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":25,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/satellogic/telluric/pulls/62"},"html":{"href":"https://github.com/satellogic/telluric/pull/62"},"issue":{"href":"https://api.github.com/repos/satellogic/telluric/issues/62"},"comments":{"href":"https://api.github.com/repos/satellogic/telluric/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/satellogic/telluric/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/satellogic/telluric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/satellogic/telluric/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/satellogic/telluric/statuses/b0bf2e72667cb382f307e3b6114d04461c95aa01"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Juanlu001"}}