{"action":"created","comment":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/211416931","pull_request_review_id":147834037,"id":211416931,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTQxNjkzMQ==","diff_hunk":"@@ -206,30 +192,27 @@ AttributeInitializer::loadAttribute(const AttributeVectorSP &attr,\n }\n \n void\n-AttributeInitializer::setupEmptyAttribute(AttributeVectorSP &attr,\n-                                          search::SerialNum serialNum,\n+AttributeInitializer::setupEmptyAttribute(AttributeVectorSP &attr, search::SerialNum serialNum,\n                                           const AttributeHeader &header) const\n {\n     if (header.getCreateSerialNum() > _currentSerialNum) {\n-        logAttributeTooNew(attr, header, _currentSerialNum);\n+        logAttributeTooNew(header, _currentSerialNum);\n     }\n     if (serialNum < _currentSerialNum) {\n-        logAttributeTooOld(attr, serialNum, _currentSerialNum);\n+        logAttributeTooOld(header, serialNum, _currentSerialNum);\n     }\n     if (!headerTypeOK(header, attr->getConfig())) {\n         logAttributeWrongType(attr, header);\n     }\n-    LOG(info, \"Returning empty attribute vector for '%s'\",\n-            attr->getBaseFileName().c_str());\n+    LOG(info, \"Returning empty attribute vector for '%s'\", attr->getName().c_str());","path":"searchcore/src/vespa/searchcore/proton/attribute/attribute_initializer.cpp","position":null,"original_position":74,"commit_id":"1d930cbddc00bf9a761eae48a2fd89bd6c5cc570","original_commit_id":"9cb7442c74b6c7d4f3aac89f26f849ab11ec110f","user":{"login":"baldersheim","id":19857788,"node_id":"MDQ6VXNlcjE5ODU3Nzg4","avatar_url":"https://avatars2.githubusercontent.com/u/19857788?v=4","gravatar_id":"","url":"https://api.github.com/users/baldersheim","html_url":"https://github.com/baldersheim","followers_url":"https://api.github.com/users/baldersheim/followers","following_url":"https://api.github.com/users/baldersheim/following{/other_user}","gists_url":"https://api.github.com/users/baldersheim/gists{/gist_id}","starred_url":"https://api.github.com/users/baldersheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baldersheim/subscriptions","organizations_url":"https://api.github.com/users/baldersheim/orgs","repos_url":"https://api.github.com/users/baldersheim/repos","events_url":"https://api.github.com/users/baldersheim/events{/privacy}","received_events_url":"https://api.github.com/users/baldersheim/received_events","type":"User","site_admin":false},"body":"I pulled this one back. It will be redone later on.","created_at":"2018-08-20T21:43:02Z","updated_at":"2018-08-20T21:43:02Z","html_url":"https://github.com/vespa-engine/vespa/pull/6630#discussion_r211416931","pull_request_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6630","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/211416931"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/6630#discussion_r211416931"},"pull_request":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6630"}},"in_reply_to_id":211368089},"pull_request":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6630","id":209507412,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NTA3NDEy","html_url":"https://github.com/vespa-engine/vespa/pull/6630","diff_url":"https://github.com/vespa-engine/vespa/pull/6630.diff","patch_url":"https://github.com/vespa-engine/vespa/pull/6630.patch","issue_url":"https://api.github.com/repos/vespa-engine/vespa/issues/6630","number":6630,"state":"open","locked":false,"title":"Use std::make_xxx","user":{"login":"baldersheim","id":19857788,"node_id":"MDQ6VXNlcjE5ODU3Nzg4","avatar_url":"https://avatars2.githubusercontent.com/u/19857788?v=4","gravatar_id":"","url":"https://api.github.com/users/baldersheim","html_url":"https://github.com/baldersheim","followers_url":"https://api.github.com/users/baldersheim/followers","following_url":"https://api.github.com/users/baldersheim/following{/other_user}","gists_url":"https://api.github.com/users/baldersheim/gists{/gist_id}","starred_url":"https://api.github.com/users/baldersheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baldersheim/subscriptions","organizations_url":"https://api.github.com/users/baldersheim/orgs","repos_url":"https://api.github.com/users/baldersheim/repos","events_url":"https://api.github.com/users/baldersheim/events{/privacy}","received_events_url":"https://api.github.com/users/baldersheim/received_events","type":"User","site_admin":false},"body":"nested namespace\r\nAnd various other style changes.\r\n@toregge PR","created_at":"2018-08-20T12:38:53Z","updated_at":"2018-08-20T21:43:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"478ea156663d93d56c259322359e2f61eee50911","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6630/commits","review_comments_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6630/comments","review_comment_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/issues/6630/comments","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/1d930cbddc00bf9a761eae48a2fd89bd6c5cc570","head":{"label":"vespa-engine:balder/make-shared-unique-plusplus","ref":"balder/make-shared-unique-plusplus","sha":"1d930cbddc00bf9a761eae48a2fd89bd6c5cc570","user":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NzA3MA==","name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2018-08-20T19:54:12Z","pushed_at":"2018-08-20T21:42:00Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"http://vespa.ai/","size":73830,"stargazers_count":2560,"watchers_count":2560,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":302,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":302,"open_issues":53,"watchers":2560,"default_branch":"master"}},"base":{"label":"vespa-engine:master","ref":"master","sha":"5a46e3fa7e8ca830bccf68f03032050ac1b5d11b","user":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NzA3MA==","name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2018-08-20T19:54:12Z","pushed_at":"2018-08-20T21:42:00Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"http://vespa.ai/","size":73830,"stargazers_count":2560,"watchers_count":2560,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":302,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":302,"open_issues":53,"watchers":2560,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6630"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/6630"},"issue":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/6630"},"comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/6630/comments"},"review_comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6630/comments"},"review_comment":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6630/commits"},"statuses":{"href":"https://api.github.com/repos/vespa-engine/vespa/statuses/1d930cbddc00bf9a761eae48a2fd89bd6c5cc570"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"baldersheim"}}