{"action":"created","comment":{"url":"https://api.github.com/repos/jethrokuan/fzf/pulls/comments/225858770","pull_request_review_id":165547248,"id":225858770,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTg1ODc3MA==","diff_hunk":"@@ -31,25 +32,25 @@ omf install https://github.com/jethrokuan/fzf\n \n ## Requirements\n \n-* fish version: `>=2.4.0`\n-* fzf versions: `>0.11.3`\n+- [fish](https://github.com/fish-shell/fish-shell) `>=2.4.0`\n+- [fzf](https://github.com/junegunn/fzf) `>0.11.3`\n+\n+## About the fzf binary\n \n-## FZF binary\n-This plugin will fail if the `fzf` binary is not detected in your `PATH`.\n+This package will fail if the `fzf` binary is not detected in your `PATH`.\n \n-The recommended means of installing `fzf` is through your respective\n-package managers. \n+See the [fzf documentation](https://github.com/junegunn/fzf#installation) for instructions to install `fzf` on your system.\n \n ## Usage\n \n-| Legacy      | New Keybindings   | Remarks                                                       |\n-| -------     | ----------------- | ------------------------------------------------------------- |\n-| Ctrl-t      | Ctrl-f            | Find a file.                                                  |\n-| Ctrl-r      | Ctrl-r            | Search through command history.                               |\n-| Alt-c       | Alt-o             | cd into sub-directories (recursively searched).               |\n-| Alt-Shift-c | Alt-Shift-o       | cd into sub-directories, including hidden ones.               |\n-| Ctrl-o      | Ctrl-o            | Open a file/dir using default editor ($EDITOR)                |\n-| Ctrl-g      | Ctrl-g            | Open a file/dir using xdg-open or open command                |\n+| Legacy      | New Keybindings | Remarks                                         |\n+| ----------- | --------------- | ----------------------------------------------- |","path":"README.md","position":67,"original_position":67,"commit_id":"3860b772369ab88bd217d9a06723b75933a545e0","original_commit_id":"3860b772369ab88bd217d9a06723b75933a545e0","user":{"login":"jorgebucaran","id":56996,"node_id":"MDQ6VXNlcjU2OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/56996?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgebucaran","html_url":"https://github.com/jorgebucaran","followers_url":"https://api.github.com/users/jorgebucaran/followers","following_url":"https://api.github.com/users/jorgebucaran/following{/other_user}","gists_url":"https://api.github.com/users/jorgebucaran/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebucaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebucaran/subscriptions","organizations_url":"https://api.github.com/users/jorgebucaran/orgs","repos_url":"https://api.github.com/users/jorgebucaran/repos","events_url":"https://api.github.com/users/jorgebucaran/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebucaran/received_events","type":"User","site_admin":false},"body":"Table changes are also from my markdown lint. They are mostly about clearing white space and pretty formatting. ","created_at":"2018-10-17T09:58:35Z","updated_at":"2018-10-17T09:58:35Z","html_url":"https://github.com/jethrokuan/fzf/pull/85#discussion_r225858770","pull_request_url":"https://api.github.com/repos/jethrokuan/fzf/pulls/85","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jethrokuan/fzf/pulls/comments/225858770"},"html":{"href":"https://github.com/jethrokuan/fzf/pull/85#discussion_r225858770"},"pull_request":{"href":"https://api.github.com/repos/jethrokuan/fzf/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/jethrokuan/fzf/pulls/85","id":220886835,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODg2ODM1","html_url":"https://github.com/jethrokuan/fzf/pull/85","diff_url":"https://github.com/jethrokuan/fzf/pull/85.diff","patch_url":"https://github.com/jethrokuan/fzf/pull/85.patch","issue_url":"https://api.github.com/repos/jethrokuan/fzf/issues/85","number":85,"state":"open","locked":false,"title":"Fisher V3 support","user":{"login":"jorgebucaran","id":56996,"node_id":"MDQ6VXNlcjU2OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/56996?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgebucaran","html_url":"https://github.com/jorgebucaran","followers_url":"https://api.github.com/users/jorgebucaran/followers","following_url":"https://api.github.com/users/jorgebucaran/following{/other_user}","gists_url":"https://api.github.com/users/jorgebucaran/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebucaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebucaran/subscriptions","organizations_url":"https://api.github.com/users/jorgebucaran/orgs","repos_url":"https://api.github.com/users/jorgebucaran/repos","events_url":"https://api.github.com/users/jorgebucaran/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebucaran/received_events","type":"User","site_admin":false},"body":"@jethrokuan With this PR fzf uses the shell's canonical way to run fish code on startup, adding support for fisher V3.\r\n\r\n ~~I'm not done yet~~. I'm done now! ~~We need to add one dependency to support key bindings. This depedency is not yet up on GitHub, but I already have the implementation.~~ \r\n\r\nWe don't need any dependencies now! 🎉 \r\n\r\n\r\n\r\n\r\n","created_at":"2018-10-06T13:37:51Z","updated_at":"2018-10-17T09:58:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"504de34bcfa122cb3b2dd699faa0fb197e9e758e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jethrokuan/fzf/pulls/85/commits","review_comments_url":"https://api.github.com/repos/jethrokuan/fzf/pulls/85/comments","review_comment_url":"https://api.github.com/repos/jethrokuan/fzf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jethrokuan/fzf/issues/85/comments","statuses_url":"https://api.github.com/repos/jethrokuan/fzf/statuses/3860b772369ab88bd217d9a06723b75933a545e0","head":{"label":"jorgebucaran:master","ref":"master","sha":"3860b772369ab88bd217d9a06723b75933a545e0","user":{"login":"jorgebucaran","id":56996,"node_id":"MDQ6VXNlcjU2OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/56996?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgebucaran","html_url":"https://github.com/jorgebucaran","followers_url":"https://api.github.com/users/jorgebucaran/followers","following_url":"https://api.github.com/users/jorgebucaran/following{/other_user}","gists_url":"https://api.github.com/users/jorgebucaran/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebucaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebucaran/subscriptions","organizations_url":"https://api.github.com/users/jorgebucaran/orgs","repos_url":"https://api.github.com/users/jorgebucaran/repos","events_url":"https://api.github.com/users/jorgebucaran/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebucaran/received_events","type":"User","site_admin":false},"repo":{"id":151841716,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE4NDE3MTY=","name":"fzf","full_name":"jorgebucaran/fzf","private":false,"owner":{"login":"jorgebucaran","id":56996,"node_id":"MDQ6VXNlcjU2OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/56996?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgebucaran","html_url":"https://github.com/jorgebucaran","followers_url":"https://api.github.com/users/jorgebucaran/followers","following_url":"https://api.github.com/users/jorgebucaran/following{/other_user}","gists_url":"https://api.github.com/users/jorgebucaran/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebucaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebucaran/subscriptions","organizations_url":"https://api.github.com/users/jorgebucaran/orgs","repos_url":"https://api.github.com/users/jorgebucaran/repos","events_url":"https://api.github.com/users/jorgebucaran/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebucaran/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jorgebucaran/fzf","description":"Ef-🐟-ient fish keybindings for fzf","fork":true,"url":"https://api.github.com/repos/jorgebucaran/fzf","forks_url":"https://api.github.com/repos/jorgebucaran/fzf/forks","keys_url":"https://api.github.com/repos/jorgebucaran/fzf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jorgebucaran/fzf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jorgebucaran/fzf/teams","hooks_url":"https://api.github.com/repos/jorgebucaran/fzf/hooks","issue_events_url":"https://api.github.com/repos/jorgebucaran/fzf/issues/events{/number}","events_url":"https://api.github.com/repos/jorgebucaran/fzf/events","assignees_url":"https://api.github.com/repos/jorgebucaran/fzf/assignees{/user}","branches_url":"https://api.github.com/repos/jorgebucaran/fzf/branches{/branch}","tags_url":"https://api.github.com/repos/jorgebucaran/fzf/tags","blobs_url":"https://api.github.com/repos/jorgebucaran/fzf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jorgebucaran/fzf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jorgebucaran/fzf/git/refs{/sha}","trees_url":"https://api.github.com/repos/jorgebucaran/fzf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jorgebucaran/fzf/statuses/{sha}","languages_url":"https://api.github.com/repos/jorgebucaran/fzf/languages","stargazers_url":"https://api.github.com/repos/jorgebucaran/fzf/stargazers","contributors_url":"https://api.github.com/repos/jorgebucaran/fzf/contributors","subscribers_url":"https://api.github.com/repos/jorgebucaran/fzf/subscribers","subscription_url":"https://api.github.com/repos/jorgebucaran/fzf/subscription","commits_url":"https://api.github.com/repos/jorgebucaran/fzf/commits{/sha}","git_commits_url":"https://api.github.com/repos/jorgebucaran/fzf/git/commits{/sha}","comments_url":"https://api.github.com/repos/jorgebucaran/fzf/comments{/number}","issue_comment_url":"https://api.github.com/repos/jorgebucaran/fzf/issues/comments{/number}","contents_url":"https://api.github.com/repos/jorgebucaran/fzf/contents/{+path}","compare_url":"https://api.github.com/repos/jorgebucaran/fzf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jorgebucaran/fzf/merges","archive_url":"https://api.github.com/repos/jorgebucaran/fzf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jorgebucaran/fzf/downloads","issues_url":"https://api.github.com/repos/jorgebucaran/fzf/issues{/number}","pulls_url":"https://api.github.com/repos/jorgebucaran/fzf/pulls{/number}","milestones_url":"https://api.github.com/repos/jorgebucaran/fzf/milestones{/number}","notifications_url":"https://api.github.com/repos/jorgebucaran/fzf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jorgebucaran/fzf/labels{/name}","releases_url":"https://api.github.com/repos/jorgebucaran/fzf/releases{/id}","deployments_url":"https://api.github.com/repos/jorgebucaran/fzf/deployments","created_at":"2018-10-06T13:17:51Z","updated_at":"2018-10-17T04:27:06Z","pushed_at":"2018-10-17T04:27:04Z","git_url":"git://github.com/jorgebucaran/fzf.git","ssh_url":"git@github.com:jorgebucaran/fzf.git","clone_url":"https://github.com/jorgebucaran/fzf.git","svn_url":"https://github.com/jorgebucaran/fzf","homepage":"","size":86,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jethrokuan:master","ref":"master","sha":"fdb69549a3a37c15b096ad9eb5ea661d4739aa4e","user":{"login":"jethrokuan","id":1667473,"node_id":"MDQ6VXNlcjE2Njc0NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1667473?v=4","gravatar_id":"","url":"https://api.github.com/users/jethrokuan","html_url":"https://github.com/jethrokuan","followers_url":"https://api.github.com/users/jethrokuan/followers","following_url":"https://api.github.com/users/jethrokuan/following{/other_user}","gists_url":"https://api.github.com/users/jethrokuan/gists{/gist_id}","starred_url":"https://api.github.com/users/jethrokuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jethrokuan/subscriptions","organizations_url":"https://api.github.com/users/jethrokuan/orgs","repos_url":"https://api.github.com/users/jethrokuan/repos","events_url":"https://api.github.com/users/jethrokuan/events{/privacy}","received_events_url":"https://api.github.com/users/jethrokuan/received_events","type":"User","site_admin":false},"repo":{"id":52280534,"node_id":"MDEwOlJlcG9zaXRvcnk1MjI4MDUzNA==","name":"fzf","full_name":"jethrokuan/fzf","private":false,"owner":{"login":"jethrokuan","id":1667473,"node_id":"MDQ6VXNlcjE2Njc0NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1667473?v=4","gravatar_id":"","url":"https://api.github.com/users/jethrokuan","html_url":"https://github.com/jethrokuan","followers_url":"https://api.github.com/users/jethrokuan/followers","following_url":"https://api.github.com/users/jethrokuan/following{/other_user}","gists_url":"https://api.github.com/users/jethrokuan/gists{/gist_id}","starred_url":"https://api.github.com/users/jethrokuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jethrokuan/subscriptions","organizations_url":"https://api.github.com/users/jethrokuan/orgs","repos_url":"https://api.github.com/users/jethrokuan/repos","events_url":"https://api.github.com/users/jethrokuan/events{/privacy}","received_events_url":"https://api.github.com/users/jethrokuan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jethrokuan/fzf","description":"Ef-🐟-ient fish keybindings for fzf","fork":false,"url":"https://api.github.com/repos/jethrokuan/fzf","forks_url":"https://api.github.com/repos/jethrokuan/fzf/forks","keys_url":"https://api.github.com/repos/jethrokuan/fzf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jethrokuan/fzf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jethrokuan/fzf/teams","hooks_url":"https://api.github.com/repos/jethrokuan/fzf/hooks","issue_events_url":"https://api.github.com/repos/jethrokuan/fzf/issues/events{/number}","events_url":"https://api.github.com/repos/jethrokuan/fzf/events","assignees_url":"https://api.github.com/repos/jethrokuan/fzf/assignees{/user}","branches_url":"https://api.github.com/repos/jethrokuan/fzf/branches{/branch}","tags_url":"https://api.github.com/repos/jethrokuan/fzf/tags","blobs_url":"https://api.github.com/repos/jethrokuan/fzf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jethrokuan/fzf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jethrokuan/fzf/git/refs{/sha}","trees_url":"https://api.github.com/repos/jethrokuan/fzf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jethrokuan/fzf/statuses/{sha}","languages_url":"https://api.github.com/repos/jethrokuan/fzf/languages","stargazers_url":"https://api.github.com/repos/jethrokuan/fzf/stargazers","contributors_url":"https://api.github.com/repos/jethrokuan/fzf/contributors","subscribers_url":"https://api.github.com/repos/jethrokuan/fzf/subscribers","subscription_url":"https://api.github.com/repos/jethrokuan/fzf/subscription","commits_url":"https://api.github.com/repos/jethrokuan/fzf/commits{/sha}","git_commits_url":"https://api.github.com/repos/jethrokuan/fzf/git/commits{/sha}","comments_url":"https://api.github.com/repos/jethrokuan/fzf/comments{/number}","issue_comment_url":"https://api.github.com/repos/jethrokuan/fzf/issues/comments{/number}","contents_url":"https://api.github.com/repos/jethrokuan/fzf/contents/{+path}","compare_url":"https://api.github.com/repos/jethrokuan/fzf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jethrokuan/fzf/merges","archive_url":"https://api.github.com/repos/jethrokuan/fzf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jethrokuan/fzf/downloads","issues_url":"https://api.github.com/repos/jethrokuan/fzf/issues{/number}","pulls_url":"https://api.github.com/repos/jethrokuan/fzf/pulls{/number}","milestones_url":"https://api.github.com/repos/jethrokuan/fzf/milestones{/number}","notifications_url":"https://api.github.com/repos/jethrokuan/fzf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jethrokuan/fzf/labels{/name}","releases_url":"https://api.github.com/repos/jethrokuan/fzf/releases{/id}","deployments_url":"https://api.github.com/repos/jethrokuan/fzf/deployments","created_at":"2016-02-22T14:51:20Z","updated_at":"2018-10-10T05:55:47Z","pushed_at":"2018-10-17T09:28:55Z","git_url":"git://github.com/jethrokuan/fzf.git","ssh_url":"git@github.com:jethrokuan/fzf.git","clone_url":"https://github.com/jethrokuan/fzf.git","svn_url":"https://github.com/jethrokuan/fzf","homepage":"","size":85,"stargazers_count":163,"watchers_count":163,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":30,"open_issues":3,"watchers":163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jethrokuan/fzf/pulls/85"},"html":{"href":"https://github.com/jethrokuan/fzf/pull/85"},"issue":{"href":"https://api.github.com/repos/jethrokuan/fzf/issues/85"},"comments":{"href":"https://api.github.com/repos/jethrokuan/fzf/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/jethrokuan/fzf/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/jethrokuan/fzf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jethrokuan/fzf/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/jethrokuan/fzf/statuses/3860b772369ab88bd217d9a06723b75933a545e0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jorgebucaran"}}