{"action":"created","comment":{"url":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/comments/233655702","pull_request_review_id":175122806,"id":233655702,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzY1NTcwMg==","diff_hunk":"@@ -1,14 +1,14 @@\n function s(w1, w2) {\n-    return w1.concat(w2);\n+  return w1.concat(w2);\n }\n \n-var result = s('code', 'your');\n+var result = s(\"code\", \"your\");\n console.log(result);\n \n // Answer these questions:\n-// - What does this program do? Run it and see, or Google some of the methods used ot understand them.\n-// - How many parameters does the function take?\n-// - What is the function name?\n-// - Where is the function called? with what parameters?\n+// - What does this program do? Run it and see, or Google some of the methods used ot understand them. concated two strings\n+// - How many parameters does the function take? 2 parameter\n+// - What is the function name? s\n+// - Where is the function called? with what parameters? assign to result with two parameters code and your\n // - What does the function return?","path":"week-1-practise/level-1/9-function-output-2.js","position":19,"original_position":19,"commit_id":"8acb2ebaad128ce9b7bec1977e559402645bff59","original_commit_id":"8acb2ebaad128ce9b7bec1977e559402645bff59","user":{"login":"SamiraAlmatar","id":24848781,"node_id":"MDQ6VXNlcjI0ODQ4Nzgx","avatar_url":"https://avatars3.githubusercontent.com/u/24848781?v=4","gravatar_id":"","url":"https://api.github.com/users/SamiraAlmatar","html_url":"https://github.com/SamiraAlmatar","followers_url":"https://api.github.com/users/SamiraAlmatar/followers","following_url":"https://api.github.com/users/SamiraAlmatar/following{/other_user}","gists_url":"https://api.github.com/users/SamiraAlmatar/gists{/gist_id}","starred_url":"https://api.github.com/users/SamiraAlmatar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamiraAlmatar/subscriptions","organizations_url":"https://api.github.com/users/SamiraAlmatar/orgs","repos_url":"https://api.github.com/users/SamiraAlmatar/repos","events_url":"https://api.github.com/users/SamiraAlmatar/events{/privacy}","received_events_url":"https://api.github.com/users/SamiraAlmatar/received_events","type":"User","site_admin":false},"body":"- What does the function return? the function take two strings as parameter and return them concated in one string.\r\n- How can this function be improved? first chooes a meaningful name to the function , second concate the strings with space to make the result string more readable like w1.concat(\" \",w2);","created_at":"2018-11-14T23:04:58Z","updated_at":"2018-11-14T23:04:58Z","html_url":"https://github.com/CodeYourFuture/js-exercises/pull/152#discussion_r233655702","pull_request_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/152","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/comments/233655702"},"html":{"href":"https://github.com/CodeYourFuture/js-exercises/pull/152#discussion_r233655702"},"pull_request":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/152"}},"in_reply_to_id":233600021},"pull_request":{"url":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/152","id":230940655,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTQwNjU1","html_url":"https://github.com/CodeYourFuture/js-exercises/pull/152","diff_url":"https://github.com/CodeYourFuture/js-exercises/pull/152.diff","patch_url":"https://github.com/CodeYourFuture/js-exercises/pull/152.patch","issue_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/issues/152","number":152,"state":"open","locked":false,"title":"Samira - Homework","user":{"login":"SamiraAlmatar","id":24848781,"node_id":"MDQ6VXNlcjI0ODQ4Nzgx","avatar_url":"https://avatars3.githubusercontent.com/u/24848781?v=4","gravatar_id":"","url":"https://api.github.com/users/SamiraAlmatar","html_url":"https://github.com/SamiraAlmatar","followers_url":"https://api.github.com/users/SamiraAlmatar/followers","following_url":"https://api.github.com/users/SamiraAlmatar/following{/other_user}","gists_url":"https://api.github.com/users/SamiraAlmatar/gists{/gist_id}","starred_url":"https://api.github.com/users/SamiraAlmatar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamiraAlmatar/subscriptions","organizations_url":"https://api.github.com/users/SamiraAlmatar/orgs","repos_url":"https://api.github.com/users/SamiraAlmatar/repos","events_url":"https://api.github.com/users/SamiraAlmatar/events{/privacy}","received_events_url":"https://api.github.com/users/SamiraAlmatar/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-14T18:42:49Z","updated_at":"2018-11-14T23:04:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb8537000f7f4b37c95b96a5f4f825a1d44563bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/152/commits","review_comments_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/152/comments","review_comment_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/issues/152/comments","statuses_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/statuses/8acb2ebaad128ce9b7bec1977e559402645bff59","head":{"label":"SamiraAlmatar:master","ref":"master","sha":"8acb2ebaad128ce9b7bec1977e559402645bff59","user":{"login":"SamiraAlmatar","id":24848781,"node_id":"MDQ6VXNlcjI0ODQ4Nzgx","avatar_url":"https://avatars3.githubusercontent.com/u/24848781?v=4","gravatar_id":"","url":"https://api.github.com/users/SamiraAlmatar","html_url":"https://github.com/SamiraAlmatar","followers_url":"https://api.github.com/users/SamiraAlmatar/followers","following_url":"https://api.github.com/users/SamiraAlmatar/following{/other_user}","gists_url":"https://api.github.com/users/SamiraAlmatar/gists{/gist_id}","starred_url":"https://api.github.com/users/SamiraAlmatar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamiraAlmatar/subscriptions","organizations_url":"https://api.github.com/users/SamiraAlmatar/orgs","repos_url":"https://api.github.com/users/SamiraAlmatar/repos","events_url":"https://api.github.com/users/SamiraAlmatar/events{/privacy}","received_events_url":"https://api.github.com/users/SamiraAlmatar/received_events","type":"User","site_admin":false},"repo":{"id":156976463,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY5NzY0NjM=","name":"js-exercises","full_name":"SamiraAlmatar/js-exercises","private":false,"owner":{"login":"SamiraAlmatar","id":24848781,"node_id":"MDQ6VXNlcjI0ODQ4Nzgx","avatar_url":"https://avatars3.githubusercontent.com/u/24848781?v=4","gravatar_id":"","url":"https://api.github.com/users/SamiraAlmatar","html_url":"https://github.com/SamiraAlmatar","followers_url":"https://api.github.com/users/SamiraAlmatar/followers","following_url":"https://api.github.com/users/SamiraAlmatar/following{/other_user}","gists_url":"https://api.github.com/users/SamiraAlmatar/gists{/gist_id}","starred_url":"https://api.github.com/users/SamiraAlmatar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamiraAlmatar/subscriptions","organizations_url":"https://api.github.com/users/SamiraAlmatar/orgs","repos_url":"https://api.github.com/users/SamiraAlmatar/repos","events_url":"https://api.github.com/users/SamiraAlmatar/events{/privacy}","received_events_url":"https://api.github.com/users/SamiraAlmatar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SamiraAlmatar/js-exercises","description":"JavaScript exercises for CodeYourFuture students","fork":true,"url":"https://api.github.com/repos/SamiraAlmatar/js-exercises","forks_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/forks","keys_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/teams","hooks_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/hooks","issue_events_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/issues/events{/number}","events_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/events","assignees_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/assignees{/user}","branches_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/branches{/branch}","tags_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/tags","blobs_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/languages","stargazers_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/stargazers","contributors_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/contributors","subscribers_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/subscribers","subscription_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/subscription","commits_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/contents/{+path}","compare_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/merges","archive_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/downloads","issues_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/issues{/number}","pulls_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/labels{/name}","releases_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/releases{/id}","deployments_url":"https://api.github.com/repos/SamiraAlmatar/js-exercises/deployments","created_at":"2018-11-10T11:54:21Z","updated_at":"2018-11-14T18:35:32Z","pushed_at":"2018-11-14T18:35:30Z","git_url":"git://github.com/SamiraAlmatar/js-exercises.git","ssh_url":"git@github.com:SamiraAlmatar/js-exercises.git","clone_url":"https://github.com/SamiraAlmatar/js-exercises.git","svn_url":"https://github.com/SamiraAlmatar/js-exercises","homepage":"","size":749,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CodeYourFuture:master","ref":"master","sha":"e557a0badb79d4a4d1a0d59d22fef9f1ec8cb57d","user":{"login":"CodeYourFuture","id":22743767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzQzNzY3","avatar_url":"https://avatars3.githubusercontent.com/u/22743767?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeYourFuture","html_url":"https://github.com/CodeYourFuture","followers_url":"https://api.github.com/users/CodeYourFuture/followers","following_url":"https://api.github.com/users/CodeYourFuture/following{/other_user}","gists_url":"https://api.github.com/users/CodeYourFuture/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeYourFuture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeYourFuture/subscriptions","organizations_url":"https://api.github.com/users/CodeYourFuture/orgs","repos_url":"https://api.github.com/users/CodeYourFuture/repos","events_url":"https://api.github.com/users/CodeYourFuture/events{/privacy}","received_events_url":"https://api.github.com/users/CodeYourFuture/received_events","type":"Organization","site_admin":false},"repo":{"id":121384131,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEzODQxMzE=","name":"js-exercises","full_name":"CodeYourFuture/js-exercises","private":false,"owner":{"login":"CodeYourFuture","id":22743767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzQzNzY3","avatar_url":"https://avatars3.githubusercontent.com/u/22743767?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeYourFuture","html_url":"https://github.com/CodeYourFuture","followers_url":"https://api.github.com/users/CodeYourFuture/followers","following_url":"https://api.github.com/users/CodeYourFuture/following{/other_user}","gists_url":"https://api.github.com/users/CodeYourFuture/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeYourFuture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeYourFuture/subscriptions","organizations_url":"https://api.github.com/users/CodeYourFuture/orgs","repos_url":"https://api.github.com/users/CodeYourFuture/repos","events_url":"https://api.github.com/users/CodeYourFuture/events{/privacy}","received_events_url":"https://api.github.com/users/CodeYourFuture/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CodeYourFuture/js-exercises","description":"JavaScript exercises for CodeYourFuture students","fork":false,"url":"https://api.github.com/repos/CodeYourFuture/js-exercises","forks_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/forks","keys_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/teams","hooks_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/hooks","issue_events_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/issues/events{/number}","events_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/events","assignees_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/assignees{/user}","branches_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/branches{/branch}","tags_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/tags","blobs_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/languages","stargazers_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/stargazers","contributors_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/contributors","subscribers_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/subscribers","subscription_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/subscription","commits_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/contents/{+path}","compare_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/merges","archive_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/downloads","issues_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/issues{/number}","pulls_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/labels{/name}","releases_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/releases{/id}","deployments_url":"https://api.github.com/repos/CodeYourFuture/js-exercises/deployments","created_at":"2018-02-13T13:12:58Z","updated_at":"2018-09-09T11:20:25Z","pushed_at":"2018-11-14T23:02:09Z","git_url":"git://github.com/CodeYourFuture/js-exercises.git","ssh_url":"git@github.com:CodeYourFuture/js-exercises.git","clone_url":"https://github.com/CodeYourFuture/js-exercises.git","svn_url":"https://github.com/CodeYourFuture/js-exercises","homepage":"","size":742,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":84,"open_issues":24,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/152"},"html":{"href":"https://github.com/CodeYourFuture/js-exercises/pull/152"},"issue":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/issues/152"},"comments":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/CodeYourFuture/js-exercises/statuses/8acb2ebaad128ce9b7bec1977e559402645bff59"}},"author_association":"NONE"}}
{"actor":{"display_login":"SamiraAlmatar"}}