{"action":"created","issue":{"url":"https://api.github.com/repos/OfficeDev/Open-XML-SDK/issues/487","repository_url":"https://api.github.com/repos/OfficeDev/Open-XML-SDK","labels_url":"https://api.github.com/repos/OfficeDev/Open-XML-SDK/issues/487/labels{/name}","comments_url":"https://api.github.com/repos/OfficeDev/Open-XML-SDK/issues/487/comments","events_url":"https://api.github.com/repos/OfficeDev/Open-XML-SDK/issues/487/events","html_url":"https://github.com/OfficeDev/Open-XML-SDK/pull/487","id":316202862,"number":487,"title":"Make simple types comparable and equatable","user":{"login":"ThomasBarnekow","id":8481516,"avatar_url":"https://avatars0.githubusercontent.com/u/8481516?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasBarnekow","html_url":"https://github.com/ThomasBarnekow","followers_url":"https://api.github.com/users/ThomasBarnekow/followers","following_url":"https://api.github.com/users/ThomasBarnekow/following{/other_user}","gists_url":"https://api.github.com/users/ThomasBarnekow/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasBarnekow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasBarnekow/subscriptions","organizations_url":"https://api.github.com/users/ThomasBarnekow/orgs","repos_url":"https://api.github.com/users/ThomasBarnekow/repos","events_url":"https://api.github.com/users/ThomasBarnekow/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasBarnekow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-20T09:52:10Z","updated_at":"2018-04-22T22:27:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OfficeDev/Open-XML-SDK/pulls/487","html_url":"https://github.com/OfficeDev/Open-XML-SDK/pull/487","diff_url":"https://github.com/OfficeDev/Open-XML-SDK/pull/487.diff","patch_url":"https://github.com/OfficeDev/Open-XML-SDK/pull/487.patch"},"body":"In conjunction with #485, this commit introduces two base classes,\r\n`OpenXmlComparableReferenceType` and `OpenXmlComparableValueType`, which\r\nimplement the `IComparable`, `IComparable<T>`, and `IEquatable<T>`\r\ninterfaces. With the exception of `EnumValue` and `ListValue`, all children\r\nor descendants of `OpenXmlSimpleType` are changed to become subclasses of\r\none of those two base classes.\r\n\r\nThis commit further adds unit tests for the new behavior. The core\r\ntests are contained in the `OpenXmlComparableReferenceTypeTests` and\r\n`OpenXmlComparableValueTypeTests` base classes. For each concrete simple\r\ntype, subclasses of those base classes create the concrete values to be\r\nused in the generic unit tests.\r\n\r\nLastly, this commit fixes existing unit tests within the `SimpleTypeTest`\r\nand `OpenXmlSimpleValueTest` classes, because those unit tests asserted\r\nthat two instances with same value but constructed separately are NOT\r\nequal.\r\n\r\nNote that the implementation is not yet complete as it lacks comments\r\nfor some public methods, for example. We might also have to add further\r\nunit tests."},"comment":{"url":"https://api.github.com/repos/OfficeDev/Open-XML-SDK/issues/comments/383417353","html_url":"https://github.com/OfficeDev/Open-XML-SDK/pull/487#issuecomment-383417353","issue_url":"https://api.github.com/repos/OfficeDev/Open-XML-SDK/issues/487","id":383417353,"user":{"login":"ThomasBarnekow","id":8481516,"avatar_url":"https://avatars0.githubusercontent.com/u/8481516?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasBarnekow","html_url":"https://github.com/ThomasBarnekow","followers_url":"https://api.github.com/users/ThomasBarnekow/followers","following_url":"https://api.github.com/users/ThomasBarnekow/following{/other_user}","gists_url":"https://api.github.com/users/ThomasBarnekow/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasBarnekow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasBarnekow/subscriptions","organizations_url":"https://api.github.com/users/ThomasBarnekow/orgs","repos_url":"https://api.github.com/users/ThomasBarnekow/repos","events_url":"https://api.github.com/users/ThomasBarnekow/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasBarnekow/received_events","type":"User","site_admin":false},"created_at":"2018-04-22T22:27:16Z","updated_at":"2018-04-22T22:27:16Z","author_association":"CONTRIBUTOR","body":"The Travis CI failures came from an outdated build that I had once configured for my repo when we originally set up build servers for the Open XML SDK."}}
{"actor":{"display_login":"ThomasBarnekow"}}