{"action":"created","comment":{"url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/pulls/comments/208151229","pull_request_review_id":143901991,"id":208151229,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODE1MTIyOQ==","diff_hunk":"@@ -298,6 +299,33 @@ public String getEmptyValue() {\n         return \"\";\n     }\n \n+    /**\n+     * Sets the value of this text area. If the new value is not equal to\n+     * {@code getValue()}, fires a value change event. Throws\n+     * {@code NullPointerException}, if the value is null.\n+     * <p>\n+     * Note: {@link Binder} will take care of the {@code null} conversion when\n+     * integrates with text area, as long as no new converter is defined.\n+     * \n+     * @param value\n+     *            the new value, not {@code null}\n+     */\n+    @Override\n+    public void setValue(String value) {\n+        super.setValue(value);\n+    }\n+\n+    /**\n+     * Returns the current value of the text area. By default, the empty text\n+     * area will return an empty string.\n+     * \n+     * @return the current value.\n+     */\n+    @Override\n+    public String getValue() {","path":"src/main/java/com/vaadin/flow/component/textfield/TextArea.java","position":35,"original_position":35,"commit_id":"8c5c335b8112ca57d61baca2445eac41741f63e6","original_commit_id":"8c5c335b8112ca57d61baca2445eac41741f63e6","user":{"login":"vaadin-bot","id":20280877,"node_id":"MDQ6VXNlcjIwMjgwODc3","avatar_url":"https://avatars1.githubusercontent.com/u/20280877?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin-bot","html_url":"https://github.com/vaadin-bot","followers_url":"https://api.github.com/users/vaadin-bot/followers","following_url":"https://api.github.com/users/vaadin-bot/following{/other_user}","gists_url":"https://api.github.com/users/vaadin-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin-bot/subscriptions","organizations_url":"https://api.github.com/users/vaadin-bot/orgs","repos_url":"https://api.github.com/users/vaadin-bot/repos","events_url":"https://api.github.com/users/vaadin-bot/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin-bot/received_events","type":"User","site_admin":false},"body":"![MINOR](https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR') Remove this method to simply inherit it. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS1185)\n","created_at":"2018-08-07T09:01:27Z","updated_at":"2018-08-07T09:01:27Z","html_url":"https://github.com/vaadin/vaadin-text-field-flow/pull/97#discussion_r208151229","pull_request_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/pulls/97","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/pulls/comments/208151229"},"html":{"href":"https://github.com/vaadin/vaadin-text-field-flow/pull/97#discussion_r208151229"},"pull_request":{"href":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/pulls/97","id":206622880,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjIyODgw","html_url":"https://github.com/vaadin/vaadin-text-field-flow/pull/97","diff_url":"https://github.com/vaadin/vaadin-text-field-flow/pull/97.diff","patch_url":"https://github.com/vaadin/vaadin-text-field-flow/pull/97.patch","issue_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/issues/97","number":97,"state":"open","locked":false,"title":"Clarify the null value acceptance in javadoc (#96)","user":{"login":"ZheSun88","id":31067185,"node_id":"MDQ6VXNlcjMxMDY3MTg1","avatar_url":"https://avatars2.githubusercontent.com/u/31067185?v=4","gravatar_id":"","url":"https://api.github.com/users/ZheSun88","html_url":"https://github.com/ZheSun88","followers_url":"https://api.github.com/users/ZheSun88/followers","following_url":"https://api.github.com/users/ZheSun88/following{/other_user}","gists_url":"https://api.github.com/users/ZheSun88/gists{/gist_id}","starred_url":"https://api.github.com/users/ZheSun88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZheSun88/subscriptions","organizations_url":"https://api.github.com/users/ZheSun88/orgs","repos_url":"https://api.github.com/users/ZheSun88/repos","events_url":"https://api.github.com/users/ZheSun88/events{/privacy}","received_events_url":"https://api.github.com/users/ZheSun88/received_events","type":"User","site_admin":false},"body":"* Clarify the null value acceptance in javadoc\r\n\r\nFixes #94\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-text-field-flow/97)\n<!-- Reviewable:end -->\n","created_at":"2018-08-07T08:45:22Z","updated_at":"2018-08-07T09:01:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fbfea711e02ff9395714af91a1f568f2f8b88f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/milestones/33","html_url":"https://github.com/vaadin/vaadin-text-field-flow/milestone/33","labels_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/milestones/33/labels","id":3543912,"node_id":"MDk6TWlsZXN0b25lMzU0MzkxMg==","number":33,"title":"1.0.4","description":"","creator":{"login":"pekam","id":28533233,"node_id":"MDQ6VXNlcjI4NTMzMjMz","avatar_url":"https://avatars3.githubusercontent.com/u/28533233?v=4","gravatar_id":"","url":"https://api.github.com/users/pekam","html_url":"https://github.com/pekam","followers_url":"https://api.github.com/users/pekam/followers","following_url":"https://api.github.com/users/pekam/following{/other_user}","gists_url":"https://api.github.com/users/pekam/gists{/gist_id}","starred_url":"https://api.github.com/users/pekam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pekam/subscriptions","organizations_url":"https://api.github.com/users/pekam/orgs","repos_url":"https://api.github.com/users/pekam/repos","events_url":"https://api.github.com/users/pekam/events{/privacy}","received_events_url":"https://api.github.com/users/pekam/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2018-08-03T07:51:07Z","updated_at":"2018-08-07T08:45:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/pulls/97/commits","review_comments_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/pulls/97/comments","review_comment_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/issues/97/comments","statuses_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/statuses/8c5c335b8112ca57d61baca2445eac41741f63e6","head":{"label":"vaadin:cherrypick-96","ref":"cherrypick-96","sha":"8c5c335b8112ca57d61baca2445eac41741f63e6","user":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":107542375,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc1NDIzNzU=","name":"vaadin-text-field-flow","full_name":"vaadin/vaadin-text-field-flow","owner":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vaadin/vaadin-text-field-flow","description":null,"fork":false,"url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow","forks_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/forks","keys_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/teams","hooks_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/hooks","issue_events_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/events","assignees_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/tags","blobs_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/languages","stargazers_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/stargazers","contributors_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/contributors","subscribers_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/subscribers","subscription_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/subscription","commits_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/merges","archive_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/downloads","issues_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/deployments","created_at":"2017-10-19T12:20:43Z","updated_at":"2018-08-07T08:50:42Z","pushed_at":"2018-08-07T08:45:28Z","git_url":"git://github.com/vaadin/vaadin-text-field-flow.git","ssh_url":"git@github.com:vaadin/vaadin-text-field-flow.git","clone_url":"https://github.com/vaadin/vaadin-text-field-flow.git","svn_url":"https://github.com/vaadin/vaadin-text-field-flow","homepage":null,"size":271,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"vaadin:1.0","ref":"1.0","sha":"a23935307c0108d3e4d226978ae29a5e6ee08f01","user":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":107542375,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc1NDIzNzU=","name":"vaadin-text-field-flow","full_name":"vaadin/vaadin-text-field-flow","owner":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vaadin/vaadin-text-field-flow","description":null,"fork":false,"url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow","forks_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/forks","keys_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/teams","hooks_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/hooks","issue_events_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/events","assignees_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/tags","blobs_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/languages","stargazers_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/stargazers","contributors_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/contributors","subscribers_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/subscribers","subscription_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/subscription","commits_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/merges","archive_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/downloads","issues_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/deployments","created_at":"2017-10-19T12:20:43Z","updated_at":"2018-08-07T08:50:42Z","pushed_at":"2018-08-07T08:45:28Z","git_url":"git://github.com/vaadin/vaadin-text-field-flow.git","ssh_url":"git@github.com:vaadin/vaadin-text-field-flow.git","clone_url":"https://github.com/vaadin/vaadin-text-field-flow.git","svn_url":"https://github.com/vaadin/vaadin-text-field-flow","homepage":null,"size":271,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/pulls/97"},"html":{"href":"https://github.com/vaadin/vaadin-text-field-flow/pull/97"},"issue":{"href":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/issues/97"},"comments":{"href":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/vaadin/vaadin-text-field-flow/statuses/8c5c335b8112ca57d61baca2445eac41741f63e6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vaadin-bot"}}