{"action":"created","comment":{"url":"https://api.github.com/repos/squid-cache/squid/pulls/comments/218211862","pull_request_review_id":156098935,"id":218211862,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODIxMTg2Mg==","diff_hunk":"@@ -4872,8 +4871,7 @@ static void free_ftp_epsv(acl_access **ftp_epsv)\n static void\n parse_UrlHelperTimeout(SquidConfig::UrlHelperTimeout *config)\n {\n-    time_msec_t tval;\n-    parseTimeLine(&tval, T_SECOND_STR, false, true);\n+    time_msec_t tval = parseTimeLine(T_SECOND_STR, false, true);","path":"src/cache_cf.cc","position":83,"original_position":83,"commit_id":"4606d67be284d2071ae621f3ca7631b61d1f4ce4","original_commit_id":"4606d67be284d2071ae621f3ca7631b61d1f4ce4","user":{"login":"rousskov","id":1084944,"node_id":"MDQ6VXNlcjEwODQ5NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1084944?v=4","gravatar_id":"","url":"https://api.github.com/users/rousskov","html_url":"https://github.com/rousskov","followers_url":"https://api.github.com/users/rousskov/followers","following_url":"https://api.github.com/users/rousskov/following{/other_user}","gists_url":"https://api.github.com/users/rousskov/gists{/gist_id}","starred_url":"https://api.github.com/users/rousskov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rousskov/subscriptions","organizations_url":"https://api.github.com/users/rousskov/orgs","repos_url":"https://api.github.com/users/rousskov/repos","events_url":"https://api.github.com/users/rousskov/events{/privacy}","received_events_url":"https://api.github.com/users/rousskov/received_events","type":"User","site_admin":false},"body":"Please use `const` and/or `auto` if possible.","created_at":"2018-09-17T20:17:42Z","updated_at":"2018-09-17T20:33:12Z","html_url":"https://github.com/squid-cache/squid/pull/288#discussion_r218211862","pull_request_url":"https://api.github.com/repos/squid-cache/squid/pulls/288","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/comments/218211862"},"html":{"href":"https://github.com/squid-cache/squid/pull/288#discussion_r218211862"},"pull_request":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/288"}}},"pull_request":{"url":"https://api.github.com/repos/squid-cache/squid/pulls/288","id":215832234,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODMyMjM0","html_url":"https://github.com/squid-cache/squid/pull/288","diff_url":"https://github.com/squid-cache/squid/pull/288.diff","patch_url":"https://github.com/squid-cache/squid/pull/288.patch","issue_url":"https://api.github.com/repos/squid-cache/squid/issues/288","number":288,"state":"open","locked":false,"title":"Bug 4875 pt2: GCC-8 compile errors with -O3 optimization","user":{"login":"yadij","id":9123754,"node_id":"MDQ6VXNlcjkxMjM3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"body":"Refactor parseTimeLine().\r\n\r\nGCC-8 warnings exposed at -O3 optimization causes its\r\nown static analyzer to detect optimized code is eliding\r\ninitialization on paths that do not use the\r\nconfiguration variables.\r\n\r\nExplicitly zero-initialize the time variable prior to\r\nparse so that there is always a definite value for\r\nanalyzers and debugging any bugs resulting from these\r\n-O3 optimizations.","created_at":"2018-09-16T16:32:18Z","updated_at":"2018-09-17T20:33:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"175dc44b058ced55d2a73d0b8068d188713da3a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":876196860,"node_id":"MDU6TGFiZWw4NzYxOTY4NjA=","url":"https://api.github.com/repos/squid-cache/squid/labels/M-cleared-for-merge","name":"M-cleared-for-merge","color":"6f42c1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/squid-cache/squid/pulls/288/commits","review_comments_url":"https://api.github.com/repos/squid-cache/squid/pulls/288/comments","review_comment_url":"https://api.github.com/repos/squid-cache/squid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/squid-cache/squid/issues/288/comments","statuses_url":"https://api.github.com/repos/squid-cache/squid/statuses/4606d67be284d2071ae621f3ca7631b61d1f4ce4","head":{"label":"yadij:bug4875_2","ref":"bug4875_2","sha":"4606d67be284d2071ae621f3ca7631b61d1f4ce4","user":{"login":"yadij","id":9123754,"node_id":"MDQ6VXNlcjkxMjM3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"repo":{"id":97826891,"node_id":"MDEwOlJlcG9zaXRvcnk5NzgyNjg5MQ==","name":"squid","full_name":"yadij/squid","private":false,"owner":{"login":"yadij","id":9123754,"node_id":"MDQ6VXNlcjkxMjM3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yadij/squid","description":"Squid Web Proxy Cache","fork":true,"url":"https://api.github.com/repos/yadij/squid","forks_url":"https://api.github.com/repos/yadij/squid/forks","keys_url":"https://api.github.com/repos/yadij/squid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yadij/squid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yadij/squid/teams","hooks_url":"https://api.github.com/repos/yadij/squid/hooks","issue_events_url":"https://api.github.com/repos/yadij/squid/issues/events{/number}","events_url":"https://api.github.com/repos/yadij/squid/events","assignees_url":"https://api.github.com/repos/yadij/squid/assignees{/user}","branches_url":"https://api.github.com/repos/yadij/squid/branches{/branch}","tags_url":"https://api.github.com/repos/yadij/squid/tags","blobs_url":"https://api.github.com/repos/yadij/squid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yadij/squid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yadij/squid/git/refs{/sha}","trees_url":"https://api.github.com/repos/yadij/squid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yadij/squid/statuses/{sha}","languages_url":"https://api.github.com/repos/yadij/squid/languages","stargazers_url":"https://api.github.com/repos/yadij/squid/stargazers","contributors_url":"https://api.github.com/repos/yadij/squid/contributors","subscribers_url":"https://api.github.com/repos/yadij/squid/subscribers","subscription_url":"https://api.github.com/repos/yadij/squid/subscription","commits_url":"https://api.github.com/repos/yadij/squid/commits{/sha}","git_commits_url":"https://api.github.com/repos/yadij/squid/git/commits{/sha}","comments_url":"https://api.github.com/repos/yadij/squid/comments{/number}","issue_comment_url":"https://api.github.com/repos/yadij/squid/issues/comments{/number}","contents_url":"https://api.github.com/repos/yadij/squid/contents/{+path}","compare_url":"https://api.github.com/repos/yadij/squid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yadij/squid/merges","archive_url":"https://api.github.com/repos/yadij/squid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yadij/squid/downloads","issues_url":"https://api.github.com/repos/yadij/squid/issues{/number}","pulls_url":"https://api.github.com/repos/yadij/squid/pulls{/number}","milestones_url":"https://api.github.com/repos/yadij/squid/milestones{/number}","notifications_url":"https://api.github.com/repos/yadij/squid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yadij/squid/labels{/name}","releases_url":"https://api.github.com/repos/yadij/squid/releases{/id}","deployments_url":"https://api.github.com/repos/yadij/squid/deployments","created_at":"2017-07-20T11:20:53Z","updated_at":"2018-09-16T16:18:10Z","pushed_at":"2018-09-17T14:21:22Z","git_url":"git://github.com/yadij/squid.git","ssh_url":"git@github.com:yadij/squid.git","clone_url":"https://github.com/yadij/squid.git","svn_url":"https://github.com/yadij/squid","homepage":"http://www.squid-cache.org/","size":137270,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"squid-cache:master","ref":"master","sha":"d429cbd0e4d86d4af54ed50e499da14039ff7429","user":{"login":"squid-cache","id":363029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/363029?v=4","gravatar_id":"","url":"https://api.github.com/users/squid-cache","html_url":"https://github.com/squid-cache","followers_url":"https://api.github.com/users/squid-cache/followers","following_url":"https://api.github.com/users/squid-cache/following{/other_user}","gists_url":"https://api.github.com/users/squid-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/squid-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squid-cache/subscriptions","organizations_url":"https://api.github.com/users/squid-cache/orgs","repos_url":"https://api.github.com/users/squid-cache/repos","events_url":"https://api.github.com/users/squid-cache/events{/privacy}","received_events_url":"https://api.github.com/users/squid-cache/received_events","type":"Organization","site_admin":false},"repo":{"id":24519987,"node_id":"MDEwOlJlcG9zaXRvcnkyNDUxOTk4Nw==","name":"squid","full_name":"squid-cache/squid","private":false,"owner":{"login":"squid-cache","id":363029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/363029?v=4","gravatar_id":"","url":"https://api.github.com/users/squid-cache","html_url":"https://github.com/squid-cache","followers_url":"https://api.github.com/users/squid-cache/followers","following_url":"https://api.github.com/users/squid-cache/following{/other_user}","gists_url":"https://api.github.com/users/squid-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/squid-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squid-cache/subscriptions","organizations_url":"https://api.github.com/users/squid-cache/orgs","repos_url":"https://api.github.com/users/squid-cache/repos","events_url":"https://api.github.com/users/squid-cache/events{/privacy}","received_events_url":"https://api.github.com/users/squid-cache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/squid-cache/squid","description":"Squid Web Proxy Cache","fork":false,"url":"https://api.github.com/repos/squid-cache/squid","forks_url":"https://api.github.com/repos/squid-cache/squid/forks","keys_url":"https://api.github.com/repos/squid-cache/squid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squid-cache/squid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squid-cache/squid/teams","hooks_url":"https://api.github.com/repos/squid-cache/squid/hooks","issue_events_url":"https://api.github.com/repos/squid-cache/squid/issues/events{/number}","events_url":"https://api.github.com/repos/squid-cache/squid/events","assignees_url":"https://api.github.com/repos/squid-cache/squid/assignees{/user}","branches_url":"https://api.github.com/repos/squid-cache/squid/branches{/branch}","tags_url":"https://api.github.com/repos/squid-cache/squid/tags","blobs_url":"https://api.github.com/repos/squid-cache/squid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squid-cache/squid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squid-cache/squid/git/refs{/sha}","trees_url":"https://api.github.com/repos/squid-cache/squid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squid-cache/squid/statuses/{sha}","languages_url":"https://api.github.com/repos/squid-cache/squid/languages","stargazers_url":"https://api.github.com/repos/squid-cache/squid/stargazers","contributors_url":"https://api.github.com/repos/squid-cache/squid/contributors","subscribers_url":"https://api.github.com/repos/squid-cache/squid/subscribers","subscription_url":"https://api.github.com/repos/squid-cache/squid/subscription","commits_url":"https://api.github.com/repos/squid-cache/squid/commits{/sha}","git_commits_url":"https://api.github.com/repos/squid-cache/squid/git/commits{/sha}","comments_url":"https://api.github.com/repos/squid-cache/squid/comments{/number}","issue_comment_url":"https://api.github.com/repos/squid-cache/squid/issues/comments{/number}","contents_url":"https://api.github.com/repos/squid-cache/squid/contents/{+path}","compare_url":"https://api.github.com/repos/squid-cache/squid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squid-cache/squid/merges","archive_url":"https://api.github.com/repos/squid-cache/squid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squid-cache/squid/downloads","issues_url":"https://api.github.com/repos/squid-cache/squid/issues{/number}","pulls_url":"https://api.github.com/repos/squid-cache/squid/pulls{/number}","milestones_url":"https://api.github.com/repos/squid-cache/squid/milestones{/number}","notifications_url":"https://api.github.com/repos/squid-cache/squid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squid-cache/squid/labels{/name}","releases_url":"https://api.github.com/repos/squid-cache/squid/releases{/id}","deployments_url":"https://api.github.com/repos/squid-cache/squid/deployments","created_at":"2014-09-27T00:59:40Z","updated_at":"2018-09-17T06:59:29Z","pushed_at":"2018-09-17T19:19:32Z","git_url":"git://github.com/squid-cache/squid.git","ssh_url":"git@github.com:squid-cache/squid.git","clone_url":"https://github.com/squid-cache/squid.git","svn_url":"https://github.com/squid-cache/squid","homepage":"http://www.squid-cache.org/","size":162022,"stargazers_count":390,"watchers_count":390,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":159,"open_issues":21,"watchers":390,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/288"},"html":{"href":"https://github.com/squid-cache/squid/pull/288"},"issue":{"href":"https://api.github.com/repos/squid-cache/squid/issues/288"},"comments":{"href":"https://api.github.com/repos/squid-cache/squid/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/squid-cache/squid/statuses/4606d67be284d2071ae621f3ca7631b61d1f4ce4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rousskov"}}