{"action":"created","comment":{"url":"https://api.github.com/repos/RattlesnakeOS/script/pulls/comments/230575643","pull_request_review_id":171349855,"id":230575643,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDU3NTY0Mw==","diff_hunk":"@@ -10,48 +10,71 @@ user_error() {\n \n KEY_DIR=keys/$1\n OUT=out/release-$1-$BUILD_NUMBER\n+PREFIX=aosp_\n \n source device/common/clear-factory-images-variables.sh\n \n+DEVICE=$1\n+case \"$DEVICE\" in\n+  hikey*)\n+    VERITY_MODE=none\n+    PREFIX=\n+    ;;\n+  bullhead)\n+    VENDOR=lge\n+    VERITY_MODE=legacy\n+    ;;\n+  angler)\n+    VENDOR=huawei\n+    VERITY_MODE=legacy\n+    ;;\n+  marlin|sailfish)\n+    VENDOR=google_devices\n+    VERITY_MODE=legacy\n+    ;;\n+  taimen|walleye)\n+    VENDOR=google_devices\n+    VERITY_MODE=avb1","path":"release.sh","position":28,"original_position":28,"commit_id":"883816c1e3acf7b1ef50f69050f0e4aa2199f5f6","original_commit_id":"883816c1e3acf7b1ef50f69050f0e4aa2199f5f6","user":{"login":"dan-v","id":1596016,"node_id":"MDQ6VXNlcjE1OTYwMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1596016?v=4","gravatar_id":"","url":"https://api.github.com/users/dan-v","html_url":"https://github.com/dan-v","followers_url":"https://api.github.com/users/dan-v/followers","following_url":"https://api.github.com/users/dan-v/following{/other_user}","gists_url":"https://api.github.com/users/dan-v/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-v/subscriptions","organizations_url":"https://api.github.com/users/dan-v/orgs","repos_url":"https://api.github.com/users/dan-v/repos","events_url":"https://api.github.com/users/dan-v/events{/privacy}","received_events_url":"https://api.github.com/users/dan-v/received_events","type":"User","site_admin":false},"body":"tamin/walleye are avb2, but there needs to be a way to distinguish as crosshatch/blueline require a different setup ","created_at":"2018-11-04T04:58:48Z","updated_at":"2018-11-04T04:58:48Z","html_url":"https://github.com/RattlesnakeOS/script/pull/1#discussion_r230575643","pull_request_url":"https://api.github.com/repos/RattlesnakeOS/script/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/RattlesnakeOS/script/pulls/comments/230575643"},"html":{"href":"https://github.com/RattlesnakeOS/script/pull/1#discussion_r230575643"},"pull_request":{"href":"https://api.github.com/repos/RattlesnakeOS/script/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/RattlesnakeOS/script/pulls/1","id":228152523,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTUyNTIz","html_url":"https://github.com/RattlesnakeOS/script/pull/1","diff_url":"https://github.com/RattlesnakeOS/script/pull/1.diff","patch_url":"https://github.com/RattlesnakeOS/script/pull/1.patch","issue_url":"https://api.github.com/repos/RattlesnakeOS/script/issues/1","number":1,"state":"open","locked":false,"title":"Add support for Pixel 3 devices in release.sh","user":{"login":"cernekee","id":1631864,"node_id":"MDQ6VXNlcjE2MzE4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1631864?v=4","gravatar_id":"","url":"https://api.github.com/users/cernekee","html_url":"https://github.com/cernekee","followers_url":"https://api.github.com/users/cernekee/followers","following_url":"https://api.github.com/users/cernekee/following{/other_user}","gists_url":"https://api.github.com/users/cernekee/gists{/gist_id}","starred_url":"https://api.github.com/users/cernekee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cernekee/subscriptions","organizations_url":"https://api.github.com/users/cernekee/orgs","repos_url":"https://api.github.com/users/cernekee/repos","events_url":"https://api.github.com/users/cernekee/events{/privacy}","received_events_url":"https://api.github.com/users/cernekee/received_events","type":"User","site_admin":false},"body":"The standard builds for AVB 2.0 devices will try to sign the system.img vbmeta block with an insecure test key, causing a verity error on boot (eio / red screen).  Override it to use avb.pem instead.\r\n\r\nThis patch also consolidates some of the per-device settings to one big case block.\r\n\r\n(Not sure whether this repo is intended to be used going forward?  I just looked at refs/heads/9.0 on rattlesnakeos-stack and that has merged parts of release.sh into build.sh.  And my pxz patch is probably redundant too...)","created_at":"2018-11-04T01:59:24Z","updated_at":"2018-11-04T04:58:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff5c35b16e4df080e4e26d325f9451fca498ff56","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RattlesnakeOS/script/pulls/1/commits","review_comments_url":"https://api.github.com/repos/RattlesnakeOS/script/pulls/1/comments","review_comment_url":"https://api.github.com/repos/RattlesnakeOS/script/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RattlesnakeOS/script/issues/1/comments","statuses_url":"https://api.github.com/repos/RattlesnakeOS/script/statuses/883816c1e3acf7b1ef50f69050f0e4aa2199f5f6","head":{"label":"cernekee:master","ref":"master","sha":"883816c1e3acf7b1ef50f69050f0e4aa2199f5f6","user":{"login":"cernekee","id":1631864,"node_id":"MDQ6VXNlcjE2MzE4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1631864?v=4","gravatar_id":"","url":"https://api.github.com/users/cernekee","html_url":"https://github.com/cernekee","followers_url":"https://api.github.com/users/cernekee/followers","following_url":"https://api.github.com/users/cernekee/following{/other_user}","gists_url":"https://api.github.com/users/cernekee/gists{/gist_id}","starred_url":"https://api.github.com/users/cernekee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cernekee/subscriptions","organizations_url":"https://api.github.com/users/cernekee/orgs","repos_url":"https://api.github.com/users/cernekee/repos","events_url":"https://api.github.com/users/cernekee/events{/privacy}","received_events_url":"https://api.github.com/users/cernekee/received_events","type":"User","site_admin":false},"repo":{"id":156031078,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYwMzEwNzg=","name":"script","full_name":"cernekee/script","private":false,"owner":{"login":"cernekee","id":1631864,"node_id":"MDQ6VXNlcjE2MzE4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1631864?v=4","gravatar_id":"","url":"https://api.github.com/users/cernekee","html_url":"https://github.com/cernekee","followers_url":"https://api.github.com/users/cernekee/followers","following_url":"https://api.github.com/users/cernekee/following{/other_user}","gists_url":"https://api.github.com/users/cernekee/gists{/gist_id}","starred_url":"https://api.github.com/users/cernekee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cernekee/subscriptions","organizations_url":"https://api.github.com/users/cernekee/orgs","repos_url":"https://api.github.com/users/cernekee/repos","events_url":"https://api.github.com/users/cernekee/events{/privacy}","received_events_url":"https://api.github.com/users/cernekee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cernekee/script","description":"Scripts used for generating RattlesnakeOS releases","fork":true,"url":"https://api.github.com/repos/cernekee/script","forks_url":"https://api.github.com/repos/cernekee/script/forks","keys_url":"https://api.github.com/repos/cernekee/script/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cernekee/script/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cernekee/script/teams","hooks_url":"https://api.github.com/repos/cernekee/script/hooks","issue_events_url":"https://api.github.com/repos/cernekee/script/issues/events{/number}","events_url":"https://api.github.com/repos/cernekee/script/events","assignees_url":"https://api.github.com/repos/cernekee/script/assignees{/user}","branches_url":"https://api.github.com/repos/cernekee/script/branches{/branch}","tags_url":"https://api.github.com/repos/cernekee/script/tags","blobs_url":"https://api.github.com/repos/cernekee/script/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cernekee/script/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cernekee/script/git/refs{/sha}","trees_url":"https://api.github.com/repos/cernekee/script/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cernekee/script/statuses/{sha}","languages_url":"https://api.github.com/repos/cernekee/script/languages","stargazers_url":"https://api.github.com/repos/cernekee/script/stargazers","contributors_url":"https://api.github.com/repos/cernekee/script/contributors","subscribers_url":"https://api.github.com/repos/cernekee/script/subscribers","subscription_url":"https://api.github.com/repos/cernekee/script/subscription","commits_url":"https://api.github.com/repos/cernekee/script/commits{/sha}","git_commits_url":"https://api.github.com/repos/cernekee/script/git/commits{/sha}","comments_url":"https://api.github.com/repos/cernekee/script/comments{/number}","issue_comment_url":"https://api.github.com/repos/cernekee/script/issues/comments{/number}","contents_url":"https://api.github.com/repos/cernekee/script/contents/{+path}","compare_url":"https://api.github.com/repos/cernekee/script/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cernekee/script/merges","archive_url":"https://api.github.com/repos/cernekee/script/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cernekee/script/downloads","issues_url":"https://api.github.com/repos/cernekee/script/issues{/number}","pulls_url":"https://api.github.com/repos/cernekee/script/pulls{/number}","milestones_url":"https://api.github.com/repos/cernekee/script/milestones{/number}","notifications_url":"https://api.github.com/repos/cernekee/script/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cernekee/script/labels{/name}","releases_url":"https://api.github.com/repos/cernekee/script/releases{/id}","deployments_url":"https://api.github.com/repos/cernekee/script/deployments","created_at":"2018-11-03T22:59:35Z","updated_at":"2018-11-03T22:59:37Z","pushed_at":"2018-11-03T23:10:27Z","git_url":"git://github.com/cernekee/script.git","ssh_url":"git@github.com:cernekee/script.git","clone_url":"https://github.com/cernekee/script.git","svn_url":"https://github.com/cernekee/script","homepage":"","size":159,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"9.0"}},"base":{"label":"RattlesnakeOS:master","ref":"master","sha":"5531ac31c1978ccf732142d8caae8d3554e45a48","user":{"login":"RattlesnakeOS","id":40250349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMjUwMzQ5","avatar_url":"https://avatars3.githubusercontent.com/u/40250349?v=4","gravatar_id":"","url":"https://api.github.com/users/RattlesnakeOS","html_url":"https://github.com/RattlesnakeOS","followers_url":"https://api.github.com/users/RattlesnakeOS/followers","following_url":"https://api.github.com/users/RattlesnakeOS/following{/other_user}","gists_url":"https://api.github.com/users/RattlesnakeOS/gists{/gist_id}","starred_url":"https://api.github.com/users/RattlesnakeOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RattlesnakeOS/subscriptions","organizations_url":"https://api.github.com/users/RattlesnakeOS/orgs","repos_url":"https://api.github.com/users/RattlesnakeOS/repos","events_url":"https://api.github.com/users/RattlesnakeOS/events{/privacy}","received_events_url":"https://api.github.com/users/RattlesnakeOS/received_events","type":"Organization","site_admin":false},"repo":{"id":137019950,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwMTk5NTA=","name":"script","full_name":"RattlesnakeOS/script","private":false,"owner":{"login":"RattlesnakeOS","id":40250349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMjUwMzQ5","avatar_url":"https://avatars3.githubusercontent.com/u/40250349?v=4","gravatar_id":"","url":"https://api.github.com/users/RattlesnakeOS","html_url":"https://github.com/RattlesnakeOS","followers_url":"https://api.github.com/users/RattlesnakeOS/followers","following_url":"https://api.github.com/users/RattlesnakeOS/following{/other_user}","gists_url":"https://api.github.com/users/RattlesnakeOS/gists{/gist_id}","starred_url":"https://api.github.com/users/RattlesnakeOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RattlesnakeOS/subscriptions","organizations_url":"https://api.github.com/users/RattlesnakeOS/orgs","repos_url":"https://api.github.com/users/RattlesnakeOS/repos","events_url":"https://api.github.com/users/RattlesnakeOS/events{/privacy}","received_events_url":"https://api.github.com/users/RattlesnakeOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RattlesnakeOS/script","description":"Scripts used for generating RattlesnakeOS releases","fork":true,"url":"https://api.github.com/repos/RattlesnakeOS/script","forks_url":"https://api.github.com/repos/RattlesnakeOS/script/forks","keys_url":"https://api.github.com/repos/RattlesnakeOS/script/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RattlesnakeOS/script/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RattlesnakeOS/script/teams","hooks_url":"https://api.github.com/repos/RattlesnakeOS/script/hooks","issue_events_url":"https://api.github.com/repos/RattlesnakeOS/script/issues/events{/number}","events_url":"https://api.github.com/repos/RattlesnakeOS/script/events","assignees_url":"https://api.github.com/repos/RattlesnakeOS/script/assignees{/user}","branches_url":"https://api.github.com/repos/RattlesnakeOS/script/branches{/branch}","tags_url":"https://api.github.com/repos/RattlesnakeOS/script/tags","blobs_url":"https://api.github.com/repos/RattlesnakeOS/script/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RattlesnakeOS/script/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RattlesnakeOS/script/git/refs{/sha}","trees_url":"https://api.github.com/repos/RattlesnakeOS/script/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RattlesnakeOS/script/statuses/{sha}","languages_url":"https://api.github.com/repos/RattlesnakeOS/script/languages","stargazers_url":"https://api.github.com/repos/RattlesnakeOS/script/stargazers","contributors_url":"https://api.github.com/repos/RattlesnakeOS/script/contributors","subscribers_url":"https://api.github.com/repos/RattlesnakeOS/script/subscribers","subscription_url":"https://api.github.com/repos/RattlesnakeOS/script/subscription","commits_url":"https://api.github.com/repos/RattlesnakeOS/script/commits{/sha}","git_commits_url":"https://api.github.com/repos/RattlesnakeOS/script/git/commits{/sha}","comments_url":"https://api.github.com/repos/RattlesnakeOS/script/comments{/number}","issue_comment_url":"https://api.github.com/repos/RattlesnakeOS/script/issues/comments{/number}","contents_url":"https://api.github.com/repos/RattlesnakeOS/script/contents/{+path}","compare_url":"https://api.github.com/repos/RattlesnakeOS/script/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RattlesnakeOS/script/merges","archive_url":"https://api.github.com/repos/RattlesnakeOS/script/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RattlesnakeOS/script/downloads","issues_url":"https://api.github.com/repos/RattlesnakeOS/script/issues{/number}","pulls_url":"https://api.github.com/repos/RattlesnakeOS/script/pulls{/number}","milestones_url":"https://api.github.com/repos/RattlesnakeOS/script/milestones{/number}","notifications_url":"https://api.github.com/repos/RattlesnakeOS/script/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RattlesnakeOS/script/labels{/name}","releases_url":"https://api.github.com/repos/RattlesnakeOS/script/releases{/id}","deployments_url":"https://api.github.com/repos/RattlesnakeOS/script/deployments","created_at":"2018-06-12T05:09:56Z","updated_at":"2018-08-17T19:58:42Z","pushed_at":"2018-11-04T01:59:24Z","git_url":"git://github.com/RattlesnakeOS/script.git","ssh_url":"git@github.com:RattlesnakeOS/script.git","clone_url":"https://github.com/RattlesnakeOS/script.git","svn_url":"https://github.com/RattlesnakeOS/script","homepage":"","size":158,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/RattlesnakeOS/script/pulls/1"},"html":{"href":"https://github.com/RattlesnakeOS/script/pull/1"},"issue":{"href":"https://api.github.com/repos/RattlesnakeOS/script/issues/1"},"comments":{"href":"https://api.github.com/repos/RattlesnakeOS/script/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/RattlesnakeOS/script/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/RattlesnakeOS/script/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RattlesnakeOS/script/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/RattlesnakeOS/script/statuses/883816c1e3acf7b1ef50f69050f0e4aa2199f5f6"}},"author_association":"NONE"}}
{"actor":{"display_login":"dan-v"}}