{"action":"created","comment":{"url":"https://api.github.com/repos/layoutBox/PinLayout/pulls/comments/195065467","pull_request_review_id":128356260,"id":195065467,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTA2NTQ2Nw==","diff_hunk":"@@ -152,7 +152,8 @@ extension PinLayoutImpl {\n             #endif\n         }\n \n-        displayText += \", Tag: \\(view.tag))\\n\"\n+        // Removed, layoutable tag should probably not be exposed\n+        //displayText += \", Tag: \\(view.tag))\\n\"","path":"Sources/Impl/PinLayoutImpl+Warning.swift","position":67,"original_position":67,"commit_id":"ba6f09dcbb58ccbcd7bf85a388f848f4b6b44e93","original_commit_id":"ba6f09dcbb58ccbcd7bf85a388f848f4b6b44e93","user":{"login":"lucdion","id":14981341,"node_id":"MDQ6VXNlcjE0OTgxMzQx","avatar_url":"https://avatars2.githubusercontent.com/u/14981341?v=4","gravatar_id":"","url":"https://api.github.com/users/lucdion","html_url":"https://github.com/lucdion","followers_url":"https://api.github.com/users/lucdion/followers","following_url":"https://api.github.com/users/lucdion/following{/other_user}","gists_url":"https://api.github.com/users/lucdion/gists{/gist_id}","starred_url":"https://api.github.com/users/lucdion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucdion/subscriptions","organizations_url":"https://api.github.com/users/lucdion/orgs","repos_url":"https://api.github.com/users/lucdion/repos","events_url":"https://api.github.com/users/lucdion/events{/privacy}","received_events_url":"https://api.github.com/users/lucdion/received_events","type":"User","site_admin":false},"body":"I didn't know this one, excellent idea.","created_at":"2018-06-13T12:41:00Z","updated_at":"2018-06-13T12:41:01Z","html_url":"https://github.com/layoutBox/PinLayout/pull/148#discussion_r195065467","pull_request_url":"https://api.github.com/repos/layoutBox/PinLayout/pulls/148","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/layoutBox/PinLayout/pulls/comments/195065467"},"html":{"href":"https://github.com/layoutBox/PinLayout/pull/148#discussion_r195065467"},"pull_request":{"href":"https://api.github.com/repos/layoutBox/PinLayout/pulls/148"}},"in_reply_to_id":195043175},"pull_request":{"url":"https://api.github.com/repos/layoutBox/PinLayout/pulls/148","id":194435905,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NDM1OTA1","html_url":"https://github.com/layoutBox/PinLayout/pull/148","diff_url":"https://github.com/layoutBox/PinLayout/pull/148.diff","patch_url":"https://github.com/layoutBox/PinLayout/pull/148.patch","issue_url":"https://api.github.com/repos/layoutBox/PinLayout/issues/148","number":148,"state":"open","locked":false,"title":"Layoutable and SizeCalculable protocols","user":{"login":"antoinelamy","id":291573,"node_id":"MDQ6VXNlcjI5MTU3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/291573?v=4","gravatar_id":"","url":"https://api.github.com/users/antoinelamy","html_url":"https://github.com/antoinelamy","followers_url":"https://api.github.com/users/antoinelamy/followers","following_url":"https://api.github.com/users/antoinelamy/following{/other_user}","gists_url":"https://api.github.com/users/antoinelamy/gists{/gist_id}","starred_url":"https://api.github.com/users/antoinelamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoinelamy/subscriptions","organizations_url":"https://api.github.com/users/antoinelamy/orgs","repos_url":"https://api.github.com/users/antoinelamy/repos","events_url":"https://api.github.com/users/antoinelamy/events{/privacy}","received_events_url":"https://api.github.com/users/antoinelamy/received_events","type":"User","site_admin":false},"body":"Refactoring to avoid having to deal directly with view types making it easier to extend layouting to other APIs (ie: CALayer).\r\n\r\nI avoided moving/adding files for now to avoid potential conflicts but I feel like some things should be renamed/moved. For exemple, `getRect` / `setRect` / `isLTR()`  functions should probably be moved where protocol conformance is declared.","created_at":"2018-06-12T23:37:40Z","updated_at":"2018-06-13T12:41:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5f7a534b604ee82c4f25e3b3b695356597ebdab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/layoutBox/PinLayout/pulls/148/commits","review_comments_url":"https://api.github.com/repos/layoutBox/PinLayout/pulls/148/comments","review_comment_url":"https://api.github.com/repos/layoutBox/PinLayout/pulls/comments{/number}","comments_url":"https://api.github.com/repos/layoutBox/PinLayout/issues/148/comments","statuses_url":"https://api.github.com/repos/layoutBox/PinLayout/statuses/ba6f09dcbb58ccbcd7bf85a388f848f4b6b44e93","head":{"label":"antoinelamy:refactor/layoutable","ref":"refactor/layoutable","sha":"ba6f09dcbb58ccbcd7bf85a388f848f4b6b44e93","user":{"login":"antoinelamy","id":291573,"node_id":"MDQ6VXNlcjI5MTU3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/291573?v=4","gravatar_id":"","url":"https://api.github.com/users/antoinelamy","html_url":"https://github.com/antoinelamy","followers_url":"https://api.github.com/users/antoinelamy/followers","following_url":"https://api.github.com/users/antoinelamy/following{/other_user}","gists_url":"https://api.github.com/users/antoinelamy/gists{/gist_id}","starred_url":"https://api.github.com/users/antoinelamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoinelamy/subscriptions","organizations_url":"https://api.github.com/users/antoinelamy/orgs","repos_url":"https://api.github.com/users/antoinelamy/repos","events_url":"https://api.github.com/users/antoinelamy/events{/privacy}","received_events_url":"https://api.github.com/users/antoinelamy/received_events","type":"User","site_admin":false},"repo":{"id":136917617,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5MTc2MTc=","name":"PinLayout","full_name":"antoinelamy/PinLayout","owner":{"login":"antoinelamy","id":291573,"node_id":"MDQ6VXNlcjI5MTU3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/291573?v=4","gravatar_id":"","url":"https://api.github.com/users/antoinelamy","html_url":"https://github.com/antoinelamy","followers_url":"https://api.github.com/users/antoinelamy/followers","following_url":"https://api.github.com/users/antoinelamy/following{/other_user}","gists_url":"https://api.github.com/users/antoinelamy/gists{/gist_id}","starred_url":"https://api.github.com/users/antoinelamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoinelamy/subscriptions","organizations_url":"https://api.github.com/users/antoinelamy/orgs","repos_url":"https://api.github.com/users/antoinelamy/repos","events_url":"https://api.github.com/users/antoinelamy/events{/privacy}","received_events_url":"https://api.github.com/users/antoinelamy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antoinelamy/PinLayout","description":"Fast Swift Views layouting without auto layout. No magic, pure code, full control and blazing fast. Concise syntax, intuitive, readable & chainable. [iOS/macOS/tvOS]","fork":true,"url":"https://api.github.com/repos/antoinelamy/PinLayout","forks_url":"https://api.github.com/repos/antoinelamy/PinLayout/forks","keys_url":"https://api.github.com/repos/antoinelamy/PinLayout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antoinelamy/PinLayout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antoinelamy/PinLayout/teams","hooks_url":"https://api.github.com/repos/antoinelamy/PinLayout/hooks","issue_events_url":"https://api.github.com/repos/antoinelamy/PinLayout/issues/events{/number}","events_url":"https://api.github.com/repos/antoinelamy/PinLayout/events","assignees_url":"https://api.github.com/repos/antoinelamy/PinLayout/assignees{/user}","branches_url":"https://api.github.com/repos/antoinelamy/PinLayout/branches{/branch}","tags_url":"https://api.github.com/repos/antoinelamy/PinLayout/tags","blobs_url":"https://api.github.com/repos/antoinelamy/PinLayout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antoinelamy/PinLayout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antoinelamy/PinLayout/git/refs{/sha}","trees_url":"https://api.github.com/repos/antoinelamy/PinLayout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antoinelamy/PinLayout/statuses/{sha}","languages_url":"https://api.github.com/repos/antoinelamy/PinLayout/languages","stargazers_url":"https://api.github.com/repos/antoinelamy/PinLayout/stargazers","contributors_url":"https://api.github.com/repos/antoinelamy/PinLayout/contributors","subscribers_url":"https://api.github.com/repos/antoinelamy/PinLayout/subscribers","subscription_url":"https://api.github.com/repos/antoinelamy/PinLayout/subscription","commits_url":"https://api.github.com/repos/antoinelamy/PinLayout/commits{/sha}","git_commits_url":"https://api.github.com/repos/antoinelamy/PinLayout/git/commits{/sha}","comments_url":"https://api.github.com/repos/antoinelamy/PinLayout/comments{/number}","issue_comment_url":"https://api.github.com/repos/antoinelamy/PinLayout/issues/comments{/number}","contents_url":"https://api.github.com/repos/antoinelamy/PinLayout/contents/{+path}","compare_url":"https://api.github.com/repos/antoinelamy/PinLayout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antoinelamy/PinLayout/merges","archive_url":"https://api.github.com/repos/antoinelamy/PinLayout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antoinelamy/PinLayout/downloads","issues_url":"https://api.github.com/repos/antoinelamy/PinLayout/issues{/number}","pulls_url":"https://api.github.com/repos/antoinelamy/PinLayout/pulls{/number}","milestones_url":"https://api.github.com/repos/antoinelamy/PinLayout/milestones{/number}","notifications_url":"https://api.github.com/repos/antoinelamy/PinLayout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antoinelamy/PinLayout/labels{/name}","releases_url":"https://api.github.com/repos/antoinelamy/PinLayout/releases{/id}","deployments_url":"https://api.github.com/repos/antoinelamy/PinLayout/deployments","created_at":"2018-06-11T11:35:28Z","updated_at":"2018-06-11T11:35:30Z","pushed_at":"2018-06-12T23:44:44Z","git_url":"git://github.com/antoinelamy/PinLayout.git","ssh_url":"git@github.com:antoinelamy/PinLayout.git","clone_url":"https://github.com/antoinelamy/PinLayout.git","svn_url":"https://github.com/antoinelamy/PinLayout","homepage":"","size":15008,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"layoutBox:master","ref":"master","sha":"9baec0855c40d11336273e090f34f4c588427a4c","user":{"login":"layoutBox","id":33347318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMzQ3MzE4","avatar_url":"https://avatars2.githubusercontent.com/u/33347318?v=4","gravatar_id":"","url":"https://api.github.com/users/layoutBox","html_url":"https://github.com/layoutBox","followers_url":"https://api.github.com/users/layoutBox/followers","following_url":"https://api.github.com/users/layoutBox/following{/other_user}","gists_url":"https://api.github.com/users/layoutBox/gists{/gist_id}","starred_url":"https://api.github.com/users/layoutBox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/layoutBox/subscriptions","organizations_url":"https://api.github.com/users/layoutBox/orgs","repos_url":"https://api.github.com/users/layoutBox/repos","events_url":"https://api.github.com/users/layoutBox/events{/privacy}","received_events_url":"https://api.github.com/users/layoutBox/received_events","type":"Organization","site_admin":false},"repo":{"id":83370364,"node_id":"MDEwOlJlcG9zaXRvcnk4MzM3MDM2NA==","name":"PinLayout","full_name":"layoutBox/PinLayout","owner":{"login":"layoutBox","id":33347318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMzQ3MzE4","avatar_url":"https://avatars2.githubusercontent.com/u/33347318?v=4","gravatar_id":"","url":"https://api.github.com/users/layoutBox","html_url":"https://github.com/layoutBox","followers_url":"https://api.github.com/users/layoutBox/followers","following_url":"https://api.github.com/users/layoutBox/following{/other_user}","gists_url":"https://api.github.com/users/layoutBox/gists{/gist_id}","starred_url":"https://api.github.com/users/layoutBox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/layoutBox/subscriptions","organizations_url":"https://api.github.com/users/layoutBox/orgs","repos_url":"https://api.github.com/users/layoutBox/repos","events_url":"https://api.github.com/users/layoutBox/events{/privacy}","received_events_url":"https://api.github.com/users/layoutBox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/layoutBox/PinLayout","description":"Fast Swift Views layouting without auto layout. No magic, pure code, full control and blazing fast. Concise syntax, intuitive, readable & chainable. [iOS/macOS/tvOS]","fork":false,"url":"https://api.github.com/repos/layoutBox/PinLayout","forks_url":"https://api.github.com/repos/layoutBox/PinLayout/forks","keys_url":"https://api.github.com/repos/layoutBox/PinLayout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/layoutBox/PinLayout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/layoutBox/PinLayout/teams","hooks_url":"https://api.github.com/repos/layoutBox/PinLayout/hooks","issue_events_url":"https://api.github.com/repos/layoutBox/PinLayout/issues/events{/number}","events_url":"https://api.github.com/repos/layoutBox/PinLayout/events","assignees_url":"https://api.github.com/repos/layoutBox/PinLayout/assignees{/user}","branches_url":"https://api.github.com/repos/layoutBox/PinLayout/branches{/branch}","tags_url":"https://api.github.com/repos/layoutBox/PinLayout/tags","blobs_url":"https://api.github.com/repos/layoutBox/PinLayout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/layoutBox/PinLayout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/layoutBox/PinLayout/git/refs{/sha}","trees_url":"https://api.github.com/repos/layoutBox/PinLayout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/layoutBox/PinLayout/statuses/{sha}","languages_url":"https://api.github.com/repos/layoutBox/PinLayout/languages","stargazers_url":"https://api.github.com/repos/layoutBox/PinLayout/stargazers","contributors_url":"https://api.github.com/repos/layoutBox/PinLayout/contributors","subscribers_url":"https://api.github.com/repos/layoutBox/PinLayout/subscribers","subscription_url":"https://api.github.com/repos/layoutBox/PinLayout/subscription","commits_url":"https://api.github.com/repos/layoutBox/PinLayout/commits{/sha}","git_commits_url":"https://api.github.com/repos/layoutBox/PinLayout/git/commits{/sha}","comments_url":"https://api.github.com/repos/layoutBox/PinLayout/comments{/number}","issue_comment_url":"https://api.github.com/repos/layoutBox/PinLayout/issues/comments{/number}","contents_url":"https://api.github.com/repos/layoutBox/PinLayout/contents/{+path}","compare_url":"https://api.github.com/repos/layoutBox/PinLayout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/layoutBox/PinLayout/merges","archive_url":"https://api.github.com/repos/layoutBox/PinLayout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/layoutBox/PinLayout/downloads","issues_url":"https://api.github.com/repos/layoutBox/PinLayout/issues{/number}","pulls_url":"https://api.github.com/repos/layoutBox/PinLayout/pulls{/number}","milestones_url":"https://api.github.com/repos/layoutBox/PinLayout/milestones{/number}","notifications_url":"https://api.github.com/repos/layoutBox/PinLayout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/layoutBox/PinLayout/labels{/name}","releases_url":"https://api.github.com/repos/layoutBox/PinLayout/releases{/id}","deployments_url":"https://api.github.com/repos/layoutBox/PinLayout/deployments","created_at":"2017-02-28T00:14:18Z","updated_at":"2018-06-11T13:23:07Z","pushed_at":"2018-06-12T23:44:45Z","git_url":"git://github.com/layoutBox/PinLayout.git","ssh_url":"git@github.com:layoutBox/PinLayout.git","clone_url":"https://github.com/layoutBox/PinLayout.git","svn_url":"https://github.com/layoutBox/PinLayout","homepage":"","size":14992,"stargazers_count":956,"watchers_count":956,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":45,"open_issues":4,"watchers":956,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/layoutBox/PinLayout/pulls/148"},"html":{"href":"https://github.com/layoutBox/PinLayout/pull/148"},"issue":{"href":"https://api.github.com/repos/layoutBox/PinLayout/issues/148"},"comments":{"href":"https://api.github.com/repos/layoutBox/PinLayout/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/layoutBox/PinLayout/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/layoutBox/PinLayout/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/layoutBox/PinLayout/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/layoutBox/PinLayout/statuses/ba6f09dcbb58ccbcd7bf85a388f848f4b6b44e93"}},"author_association":"NONE"}}
{"actor":{"display_login":"lucdion"}}