{"action":"opened","number":1785,"pull_request":{"url":"https://api.github.com/repos/Talend/data-prep/pulls/1785","id":234599002,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NTk5MDAy","html_url":"https://github.com/Talend/data-prep/pull/1785","diff_url":"https://github.com/Talend/data-prep/pull/1785.diff","patch_url":"https://github.com/Talend/data-prep/pull/1785.patch","issue_url":"https://api.github.com/repos/Talend/data-prep/issues/1785","number":1785,"state":"open","locked":false,"title":"fix(TDP-4990): missing dataset name in lookup action","user":{"login":"aleboulanger","id":35097656,"node_id":"MDQ6VXNlcjM1MDk3NjU2","avatar_url":"https://avatars1.githubusercontent.com/u/35097656?v=4","gravatar_id":"","url":"https://api.github.com/users/aleboulanger","html_url":"https://github.com/aleboulanger","followers_url":"https://api.github.com/users/aleboulanger/followers","following_url":"https://api.github.com/users/aleboulanger/following{/other_user}","gists_url":"https://api.github.com/users/aleboulanger/gists{/gist_id}","starred_url":"https://api.github.com/users/aleboulanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleboulanger/subscriptions","organizations_url":"https://api.github.com/users/aleboulanger/orgs","repos_url":"https://api.github.com/users/aleboulanger/repos","events_url":"https://api.github.com/users/aleboulanger/events{/privacy}","received_events_url":"https://api.github.com/users/aleboulanger/received_events","type":"User","site_admin":false},"body":"* add Dataset -> datasetMetadata conversion in order to apply datasetMetadata id and name on the lookup action\r\n\r\n* remove DatasetMetadata command since it's not used int the SuggestLookupActions command\r\n\r\n* create another Dataset api /api/datasets/actions/lookup to be more consistent regarding the result of the API\r\n\r\n* deprecate /api/datasets/{datasetId}/actions\r\n\r\n**Link to the JIRA issue**\r\nhttps://jira.talendforge.org/browse/TDP-4990\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [ ] The commit(s) message(s) follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md#commit-message-format)\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n- [ ] The code coverage on new code is > 75 % for backend and > 95% for frontend\r\n- [ ] The new code does not introduce new technical issues (sonar / eslint)\r\n- [ ] Functional tests have been performed\r\n- [ ] Docker configuration files for config-std or config-cloud profiles are impacted\r\n\r\n**Please check the browsers you've tested on**\r\n- [ ] Chrome, Firefox, Safari, Edge, IE11\r\n- [ ] No, that's bad, this PR should not be merged !\r\n- [ ] No, and no need to (backend changes only)\r\n","created_at":"2018-11-29T11:18:22Z","updated_at":"2018-11-29T11:18:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/data-prep/pulls/1785/commits","review_comments_url":"https://api.github.com/repos/Talend/data-prep/pulls/1785/comments","review_comment_url":"https://api.github.com/repos/Talend/data-prep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/data-prep/issues/1785/comments","statuses_url":"https://api.github.com/repos/Talend/data-prep/statuses/de61777060996749be6afd74e0c8f600b7cbbfe8","head":{"label":"Talend:aleboulanger/fix/TDP-4990-missing_dataset_name_in_lookup_action","ref":"aleboulanger/fix/TDP-4990-missing_dataset_name_in_lookup_action","sha":"de61777060996749be6afd74e0c8f600b7cbbfe8","user":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":26644682,"node_id":"MDEwOlJlcG9zaXRvcnkyNjY0NDY4Mg==","name":"data-prep","full_name":"Talend/data-prep","private":false,"owner":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Talend/data-prep","description":"OS code of Data-prep project","fork":false,"url":"https://api.github.com/repos/Talend/data-prep","forks_url":"https://api.github.com/repos/Talend/data-prep/forks","keys_url":"https://api.github.com/repos/Talend/data-prep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/data-prep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/data-prep/teams","hooks_url":"https://api.github.com/repos/Talend/data-prep/hooks","issue_events_url":"https://api.github.com/repos/Talend/data-prep/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/data-prep/events","assignees_url":"https://api.github.com/repos/Talend/data-prep/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/data-prep/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/data-prep/tags","blobs_url":"https://api.github.com/repos/Talend/data-prep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/data-prep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/data-prep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/data-prep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/data-prep/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/data-prep/languages","stargazers_url":"https://api.github.com/repos/Talend/data-prep/stargazers","contributors_url":"https://api.github.com/repos/Talend/data-prep/contributors","subscribers_url":"https://api.github.com/repos/Talend/data-prep/subscribers","subscription_url":"https://api.github.com/repos/Talend/data-prep/subscription","commits_url":"https://api.github.com/repos/Talend/data-prep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/data-prep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/data-prep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/data-prep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/data-prep/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/data-prep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/data-prep/merges","archive_url":"https://api.github.com/repos/Talend/data-prep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/data-prep/downloads","issues_url":"https://api.github.com/repos/Talend/data-prep/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/data-prep/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/data-prep/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/data-prep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/data-prep/labels{/name}","releases_url":"https://api.github.com/repos/Talend/data-prep/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/data-prep/deployments","created_at":"2014-11-14T15:32:38Z","updated_at":"2018-11-29T09:15:01Z","pushed_at":"2018-11-29T11:18:11Z","git_url":"git://github.com/Talend/data-prep.git","ssh_url":"git@github.com:Talend/data-prep.git","clone_url":"https://github.com/Talend/data-prep.git","svn_url":"https://github.com/Talend/data-prep","homepage":"","size":70462,"stargazers_count":48,"watchers_count":48,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":24,"open_issues":23,"watchers":48,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"3b63114add058615e79baa4068c87486a8375428","user":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":26644682,"node_id":"MDEwOlJlcG9zaXRvcnkyNjY0NDY4Mg==","name":"data-prep","full_name":"Talend/data-prep","private":false,"owner":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Talend/data-prep","description":"OS code of Data-prep project","fork":false,"url":"https://api.github.com/repos/Talend/data-prep","forks_url":"https://api.github.com/repos/Talend/data-prep/forks","keys_url":"https://api.github.com/repos/Talend/data-prep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/data-prep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/data-prep/teams","hooks_url":"https://api.github.com/repos/Talend/data-prep/hooks","issue_events_url":"https://api.github.com/repos/Talend/data-prep/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/data-prep/events","assignees_url":"https://api.github.com/repos/Talend/data-prep/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/data-prep/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/data-prep/tags","blobs_url":"https://api.github.com/repos/Talend/data-prep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/data-prep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/data-prep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/data-prep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/data-prep/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/data-prep/languages","stargazers_url":"https://api.github.com/repos/Talend/data-prep/stargazers","contributors_url":"https://api.github.com/repos/Talend/data-prep/contributors","subscribers_url":"https://api.github.com/repos/Talend/data-prep/subscribers","subscription_url":"https://api.github.com/repos/Talend/data-prep/subscription","commits_url":"https://api.github.com/repos/Talend/data-prep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/data-prep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/data-prep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/data-prep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/data-prep/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/data-prep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/data-prep/merges","archive_url":"https://api.github.com/repos/Talend/data-prep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/data-prep/downloads","issues_url":"https://api.github.com/repos/Talend/data-prep/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/data-prep/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/data-prep/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/data-prep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/data-prep/labels{/name}","releases_url":"https://api.github.com/repos/Talend/data-prep/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/data-prep/deployments","created_at":"2014-11-14T15:32:38Z","updated_at":"2018-11-29T09:15:01Z","pushed_at":"2018-11-29T11:18:11Z","git_url":"git://github.com/Talend/data-prep.git","ssh_url":"git@github.com:Talend/data-prep.git","clone_url":"https://github.com/Talend/data-prep.git","svn_url":"https://github.com/Talend/data-prep","homepage":"","size":70462,"stargazers_count":48,"watchers_count":48,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":24,"open_issues":23,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/data-prep/pulls/1785"},"html":{"href":"https://github.com/Talend/data-prep/pull/1785"},"issue":{"href":"https://api.github.com/repos/Talend/data-prep/issues/1785"},"comments":{"href":"https://api.github.com/repos/Talend/data-prep/issues/1785/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/data-prep/pulls/1785/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/data-prep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/data-prep/pulls/1785/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/data-prep/statuses/de61777060996749be6afd74e0c8f600b7cbbfe8"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":33,"deletions":35,"changed_files":2}}
{"actor":{"display_login":"aleboulanger"}}