{"action":"created","comment":{"url":"https://api.github.com/repos/SoCo/SoCo/pulls/comments/170177862","pull_request_review_id":98824537,"id":170177862,"diff_hunk":"@@ -23,7 +23,7 @@\n _LOG.debug('%s imported', __name__)\n \n \n-def from_didl_string(string):\n+def from_didl_string(string, music_service_medata_hack=False):","path":"soco/data_structures_entry.py","position":14,"original_position":14,"commit_id":"9ff63731482aae10372382a4cea54d54132d9ccb","original_commit_id":"9ff63731482aae10372382a4cea54d54132d9ccb","user":{"login":"ghcs27","id":15690065,"avatar_url":"https://avatars0.githubusercontent.com/u/15690065?v=4","gravatar_id":"","url":"https://api.github.com/users/ghcs27","html_url":"https://github.com/ghcs27","followers_url":"https://api.github.com/users/ghcs27/followers","following_url":"https://api.github.com/users/ghcs27/following{/other_user}","gists_url":"https://api.github.com/users/ghcs27/gists{/gist_id}","starred_url":"https://api.github.com/users/ghcs27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghcs27/subscriptions","organizations_url":"https://api.github.com/users/ghcs27/orgs","repos_url":"https://api.github.com/users/ghcs27/repos","events_url":"https://api.github.com/users/ghcs27/events{/privacy}","received_events_url":"https://api.github.com/users/ghcs27/received_events","type":"User","site_admin":false},"body":"Is there a specific reason why you don't want to activate this by default? ","created_at":"2018-02-23T06:54:24Z","updated_at":"2018-02-23T06:59:08Z","html_url":"https://github.com/SoCo/SoCo/pull/589#discussion_r170177862","pull_request_url":"https://api.github.com/repos/SoCo/SoCo/pulls/589","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SoCo/SoCo/pulls/comments/170177862"},"html":{"href":"https://github.com/SoCo/SoCo/pull/589#discussion_r170177862"},"pull_request":{"href":"https://api.github.com/repos/SoCo/SoCo/pulls/589"}}},"pull_request":{"url":"https://api.github.com/repos/SoCo/SoCo/pulls/589","id":170583891,"html_url":"https://github.com/SoCo/SoCo/pull/589","diff_url":"https://github.com/SoCo/SoCo/pull/589.diff","patch_url":"https://github.com/SoCo/SoCo/pull/589.patch","issue_url":"https://api.github.com/repos/SoCo/SoCo/issues/589","number":589,"state":"open","locked":false,"title":"Copy metadata from DidlItem to MusicServiceItem in get_queue and events","user":{"login":"KennethNielsen","id":1611076,"avatar_url":"https://avatars1.githubusercontent.com/u/1611076?v=4","gravatar_id":"","url":"https://api.github.com/users/KennethNielsen","html_url":"https://github.com/KennethNielsen","followers_url":"https://api.github.com/users/KennethNielsen/followers","following_url":"https://api.github.com/users/KennethNielsen/following{/other_user}","gists_url":"https://api.github.com/users/KennethNielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/KennethNielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KennethNielsen/subscriptions","organizations_url":"https://api.github.com/users/KennethNielsen/orgs","repos_url":"https://api.github.com/users/KennethNielsen/repos","events_url":"https://api.github.com/users/KennethNielsen/events{/privacy}","received_events_url":"https://api.github.com/users/KennethNielsen/received_events","type":"User","site_admin":false},"body":"This PR fixes an issue with a reduced amount of metadata for queue and\r\nevent items when upgrading them to their appropriate music service\r\ntype.\r\n\r\nThis should allow e.g. getting both title and album as properties and all remaining metadata from the DidlItem is available in the .metadata property of thr MusicService item.\r\n\r\nNote. This PR is published as an alternative to #559. The reason for that is, that the music service data structures was added, since the music services use a completely different internal structure. In the long run, we want to be able to ask the music service to produce metadata for the MusicService items, including those coming from the queue. But until that has been implemented, we should preserve all the metadata we got.\r\n\r\nCloses #535 and #559 and #547 and #552","created_at":"2018-02-21T20:47:16Z","updated_at":"2018-02-23T06:59:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d719d7fcf971c1ec4ec8c35698419939c0b71980","assignee":{"login":"KennethNielsen","id":1611076,"avatar_url":"https://avatars1.githubusercontent.com/u/1611076?v=4","gravatar_id":"","url":"https://api.github.com/users/KennethNielsen","html_url":"https://github.com/KennethNielsen","followers_url":"https://api.github.com/users/KennethNielsen/followers","following_url":"https://api.github.com/users/KennethNielsen/following{/other_user}","gists_url":"https://api.github.com/users/KennethNielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/KennethNielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KennethNielsen/subscriptions","organizations_url":"https://api.github.com/users/KennethNielsen/orgs","repos_url":"https://api.github.com/users/KennethNielsen/repos","events_url":"https://api.github.com/users/KennethNielsen/events{/privacy}","received_events_url":"https://api.github.com/users/KennethNielsen/received_events","type":"User","site_admin":false},"assignees":[{"login":"KennethNielsen","id":1611076,"avatar_url":"https://avatars1.githubusercontent.com/u/1611076?v=4","gravatar_id":"","url":"https://api.github.com/users/KennethNielsen","html_url":"https://github.com/KennethNielsen","followers_url":"https://api.github.com/users/KennethNielsen/followers","following_url":"https://api.github.com/users/KennethNielsen/following{/other_user}","gists_url":"https://api.github.com/users/KennethNielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/KennethNielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KennethNielsen/subscriptions","organizations_url":"https://api.github.com/users/KennethNielsen/orgs","repos_url":"https://api.github.com/users/KennethNielsen/repos","events_url":"https://api.github.com/users/KennethNielsen/events{/privacy}","received_events_url":"https://api.github.com/users/KennethNielsen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":562504490,"url":"https://api.github.com/repos/SoCo/SoCo/labels/Bugfix","name":"Bugfix","color":"fc2929","default":false},{"id":520828304,"url":"https://api.github.com/repos/SoCo/SoCo/labels/Needs%20review","name":"Needs review","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SoCo/SoCo/pulls/589/commits","review_comments_url":"https://api.github.com/repos/SoCo/SoCo/pulls/589/comments","review_comment_url":"https://api.github.com/repos/SoCo/SoCo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SoCo/SoCo/issues/589/comments","statuses_url":"https://api.github.com/repos/SoCo/SoCo/statuses/9ff63731482aae10372382a4cea54d54132d9ccb","head":{"label":"KennethNielsen:metadata_fix_for_item_upgrade","ref":"metadata_fix_for_item_upgrade","sha":"9ff63731482aae10372382a4cea54d54132d9ccb","user":{"login":"KennethNielsen","id":1611076,"avatar_url":"https://avatars1.githubusercontent.com/u/1611076?v=4","gravatar_id":"","url":"https://api.github.com/users/KennethNielsen","html_url":"https://github.com/KennethNielsen","followers_url":"https://api.github.com/users/KennethNielsen/followers","following_url":"https://api.github.com/users/KennethNielsen/following{/other_user}","gists_url":"https://api.github.com/users/KennethNielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/KennethNielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KennethNielsen/subscriptions","organizations_url":"https://api.github.com/users/KennethNielsen/orgs","repos_url":"https://api.github.com/users/KennethNielsen/repos","events_url":"https://api.github.com/users/KennethNielsen/events{/privacy}","received_events_url":"https://api.github.com/users/KennethNielsen/received_events","type":"User","site_admin":false},"repo":{"id":8866293,"name":"SoCo","full_name":"KennethNielsen/SoCo","owner":{"login":"KennethNielsen","id":1611076,"avatar_url":"https://avatars1.githubusercontent.com/u/1611076?v=4","gravatar_id":"","url":"https://api.github.com/users/KennethNielsen","html_url":"https://github.com/KennethNielsen","followers_url":"https://api.github.com/users/KennethNielsen/followers","following_url":"https://api.github.com/users/KennethNielsen/following{/other_user}","gists_url":"https://api.github.com/users/KennethNielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/KennethNielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KennethNielsen/subscriptions","organizations_url":"https://api.github.com/users/KennethNielsen/orgs","repos_url":"https://api.github.com/users/KennethNielsen/repos","events_url":"https://api.github.com/users/KennethNielsen/events{/privacy}","received_events_url":"https://api.github.com/users/KennethNielsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KennethNielsen/SoCo","description":"SoCo (Sonos Controller) is a simple Python class that allows you to programmatically control Sonos speakers.","fork":true,"url":"https://api.github.com/repos/KennethNielsen/SoCo","forks_url":"https://api.github.com/repos/KennethNielsen/SoCo/forks","keys_url":"https://api.github.com/repos/KennethNielsen/SoCo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KennethNielsen/SoCo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KennethNielsen/SoCo/teams","hooks_url":"https://api.github.com/repos/KennethNielsen/SoCo/hooks","issue_events_url":"https://api.github.com/repos/KennethNielsen/SoCo/issues/events{/number}","events_url":"https://api.github.com/repos/KennethNielsen/SoCo/events","assignees_url":"https://api.github.com/repos/KennethNielsen/SoCo/assignees{/user}","branches_url":"https://api.github.com/repos/KennethNielsen/SoCo/branches{/branch}","tags_url":"https://api.github.com/repos/KennethNielsen/SoCo/tags","blobs_url":"https://api.github.com/repos/KennethNielsen/SoCo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KennethNielsen/SoCo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KennethNielsen/SoCo/git/refs{/sha}","trees_url":"https://api.github.com/repos/KennethNielsen/SoCo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KennethNielsen/SoCo/statuses/{sha}","languages_url":"https://api.github.com/repos/KennethNielsen/SoCo/languages","stargazers_url":"https://api.github.com/repos/KennethNielsen/SoCo/stargazers","contributors_url":"https://api.github.com/repos/KennethNielsen/SoCo/contributors","subscribers_url":"https://api.github.com/repos/KennethNielsen/SoCo/subscribers","subscription_url":"https://api.github.com/repos/KennethNielsen/SoCo/subscription","commits_url":"https://api.github.com/repos/KennethNielsen/SoCo/commits{/sha}","git_commits_url":"https://api.github.com/repos/KennethNielsen/SoCo/git/commits{/sha}","comments_url":"https://api.github.com/repos/KennethNielsen/SoCo/comments{/number}","issue_comment_url":"https://api.github.com/repos/KennethNielsen/SoCo/issues/comments{/number}","contents_url":"https://api.github.com/repos/KennethNielsen/SoCo/contents/{+path}","compare_url":"https://api.github.com/repos/KennethNielsen/SoCo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KennethNielsen/SoCo/merges","archive_url":"https://api.github.com/repos/KennethNielsen/SoCo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KennethNielsen/SoCo/downloads","issues_url":"https://api.github.com/repos/KennethNielsen/SoCo/issues{/number}","pulls_url":"https://api.github.com/repos/KennethNielsen/SoCo/pulls{/number}","milestones_url":"https://api.github.com/repos/KennethNielsen/SoCo/milestones{/number}","notifications_url":"https://api.github.com/repos/KennethNielsen/SoCo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KennethNielsen/SoCo/labels{/name}","releases_url":"https://api.github.com/repos/KennethNielsen/SoCo/releases{/id}","deployments_url":"https://api.github.com/repos/KennethNielsen/SoCo/deployments","created_at":"2013-03-18T23:08:00Z","updated_at":"2014-08-24T13:49:45Z","pushed_at":"2018-02-21T20:47:09Z","git_url":"git://github.com/KennethNielsen/SoCo.git","ssh_url":"git@github.com:KennethNielsen/SoCo.git","clone_url":"https://github.com/KennethNielsen/SoCo.git","svn_url":"https://github.com/KennethNielsen/SoCo","homepage":null,"size":2571,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SoCo:master","ref":"master","sha":"3aec9fe7b7bbe4048484e35af0d9e7da8e67fbd8","user":{"login":"SoCo","id":3826649,"avatar_url":"https://avatars2.githubusercontent.com/u/3826649?v=4","gravatar_id":"","url":"https://api.github.com/users/SoCo","html_url":"https://github.com/SoCo","followers_url":"https://api.github.com/users/SoCo/followers","following_url":"https://api.github.com/users/SoCo/following{/other_user}","gists_url":"https://api.github.com/users/SoCo/gists{/gist_id}","starred_url":"https://api.github.com/users/SoCo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SoCo/subscriptions","organizations_url":"https://api.github.com/users/SoCo/orgs","repos_url":"https://api.github.com/users/SoCo/repos","events_url":"https://api.github.com/users/SoCo/events{/privacy}","received_events_url":"https://api.github.com/users/SoCo/received_events","type":"Organization","site_admin":false},"repo":{"id":8763405,"name":"SoCo","full_name":"SoCo/SoCo","owner":{"login":"SoCo","id":3826649,"avatar_url":"https://avatars2.githubusercontent.com/u/3826649?v=4","gravatar_id":"","url":"https://api.github.com/users/SoCo","html_url":"https://github.com/SoCo","followers_url":"https://api.github.com/users/SoCo/followers","following_url":"https://api.github.com/users/SoCo/following{/other_user}","gists_url":"https://api.github.com/users/SoCo/gists{/gist_id}","starred_url":"https://api.github.com/users/SoCo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SoCo/subscriptions","organizations_url":"https://api.github.com/users/SoCo/orgs","repos_url":"https://api.github.com/users/SoCo/repos","events_url":"https://api.github.com/users/SoCo/events{/privacy}","received_events_url":"https://api.github.com/users/SoCo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SoCo/SoCo","description":"SoCo (Sonos Controller) is a Python project that allows you to programmatically control Sonos speakers.","fork":false,"url":"https://api.github.com/repos/SoCo/SoCo","forks_url":"https://api.github.com/repos/SoCo/SoCo/forks","keys_url":"https://api.github.com/repos/SoCo/SoCo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SoCo/SoCo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SoCo/SoCo/teams","hooks_url":"https://api.github.com/repos/SoCo/SoCo/hooks","issue_events_url":"https://api.github.com/repos/SoCo/SoCo/issues/events{/number}","events_url":"https://api.github.com/repos/SoCo/SoCo/events","assignees_url":"https://api.github.com/repos/SoCo/SoCo/assignees{/user}","branches_url":"https://api.github.com/repos/SoCo/SoCo/branches{/branch}","tags_url":"https://api.github.com/repos/SoCo/SoCo/tags","blobs_url":"https://api.github.com/repos/SoCo/SoCo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SoCo/SoCo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SoCo/SoCo/git/refs{/sha}","trees_url":"https://api.github.com/repos/SoCo/SoCo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SoCo/SoCo/statuses/{sha}","languages_url":"https://api.github.com/repos/SoCo/SoCo/languages","stargazers_url":"https://api.github.com/repos/SoCo/SoCo/stargazers","contributors_url":"https://api.github.com/repos/SoCo/SoCo/contributors","subscribers_url":"https://api.github.com/repos/SoCo/SoCo/subscribers","subscription_url":"https://api.github.com/repos/SoCo/SoCo/subscription","commits_url":"https://api.github.com/repos/SoCo/SoCo/commits{/sha}","git_commits_url":"https://api.github.com/repos/SoCo/SoCo/git/commits{/sha}","comments_url":"https://api.github.com/repos/SoCo/SoCo/comments{/number}","issue_comment_url":"https://api.github.com/repos/SoCo/SoCo/issues/comments{/number}","contents_url":"https://api.github.com/repos/SoCo/SoCo/contents/{+path}","compare_url":"https://api.github.com/repos/SoCo/SoCo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SoCo/SoCo/merges","archive_url":"https://api.github.com/repos/SoCo/SoCo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SoCo/SoCo/downloads","issues_url":"https://api.github.com/repos/SoCo/SoCo/issues{/number}","pulls_url":"https://api.github.com/repos/SoCo/SoCo/pulls{/number}","milestones_url":"https://api.github.com/repos/SoCo/SoCo/milestones{/number}","notifications_url":"https://api.github.com/repos/SoCo/SoCo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SoCo/SoCo/labels{/name}","releases_url":"https://api.github.com/repos/SoCo/SoCo/releases{/id}","deployments_url":"https://api.github.com/repos/SoCo/SoCo/deployments","created_at":"2013-03-13T22:56:39Z","updated_at":"2018-02-22T21:45:09Z","pushed_at":"2018-02-22T19:43:36Z","git_url":"git://github.com/SoCo/SoCo.git","ssh_url":"git@github.com:SoCo/SoCo.git","clone_url":"https://github.com/SoCo/SoCo.git","svn_url":"https://github.com/SoCo/SoCo","homepage":"http://python-soco.com/","size":2517,"stargazers_count":848,"watchers_count":848,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":168,"open_issues":69,"watchers":848,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SoCo/SoCo/pulls/589"},"html":{"href":"https://github.com/SoCo/SoCo/pull/589"},"issue":{"href":"https://api.github.com/repos/SoCo/SoCo/issues/589"},"comments":{"href":"https://api.github.com/repos/SoCo/SoCo/issues/589/comments"},"review_comments":{"href":"https://api.github.com/repos/SoCo/SoCo/pulls/589/comments"},"review_comment":{"href":"https://api.github.com/repos/SoCo/SoCo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SoCo/SoCo/pulls/589/commits"},"statuses":{"href":"https://api.github.com/repos/SoCo/SoCo/statuses/9ff63731482aae10372382a4cea54d54132d9ccb"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ghcs27"}}