{"action":"opened","number":17209,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/17209","id":204991138,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTkxMTM4","html_url":"https://github.com/ampproject/amphtml/pull/17209","diff_url":"https://github.com/ampproject/amphtml/pull/17209.diff","patch_url":"https://github.com/ampproject/amphtml/pull/17209.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/17209","number":17209,"state":"open","locked":false,"title":"amp-list: Hide placeholder et al. after re-render with local data","user":{"login":"choumx","id":20525523,"node_id":"MDQ6VXNlcjIwNTI1NTIz","avatar_url":"https://avatars1.githubusercontent.com/u/20525523?v=4","gravatar_id":"","url":"https://api.github.com/users/choumx","html_url":"https://github.com/choumx","followers_url":"https://api.github.com/users/choumx/followers","following_url":"https://api.github.com/users/choumx/following{/other_user}","gists_url":"https://api.github.com/users/choumx/gists{/gist_id}","starred_url":"https://api.github.com/users/choumx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choumx/subscriptions","organizations_url":"https://api.github.com/users/choumx/orgs","repos_url":"https://api.github.com/users/choumx/repos","events_url":"https://api.github.com/users/choumx/events{/privacy}","received_events_url":"https://api.github.com/users/choumx/received_events","type":"User","site_admin":false},"body":"Fixes #17202.\r\n\r\nOther things I noticed that I'd like to fix:\r\n- Figure out why two tests caused all following tests to be silently skipped\r\n- Refactor `resetIfNecessary_`, `hideFallbackAndPlaceholder_`, `showFallback_` into a single function that takes a tri-state enum: FETCHING, SUCCESS, FAIL\r\n\r\n/to @aghassemi ","created_at":"2018-07-31T04:12:55Z","updated_at":"2018-07-31T04:12:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/17209/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/17209/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/17209/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/86de0d790a305ea1cdfba2ff651b5a0051b4bb3a","head":{"label":"choumx:amp-list-reset-bug","ref":"amp-list-reset-bug","sha":"86de0d790a305ea1cdfba2ff651b5a0051b4bb3a","user":{"login":"choumx","id":20525523,"node_id":"MDQ6VXNlcjIwNTI1NTIz","avatar_url":"https://avatars1.githubusercontent.com/u/20525523?v=4","gravatar_id":"","url":"https://api.github.com/users/choumx","html_url":"https://github.com/choumx","followers_url":"https://api.github.com/users/choumx/followers","following_url":"https://api.github.com/users/choumx/following{/other_user}","gists_url":"https://api.github.com/users/choumx/gists{/gist_id}","starred_url":"https://api.github.com/users/choumx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choumx/subscriptions","organizations_url":"https://api.github.com/users/choumx/orgs","repos_url":"https://api.github.com/users/choumx/repos","events_url":"https://api.github.com/users/choumx/events{/privacy}","received_events_url":"https://api.github.com/users/choumx/received_events","type":"User","site_admin":false},"repo":{"id":63805137,"node_id":"MDEwOlJlcG9zaXRvcnk2MzgwNTEzNw==","name":"amphtml","full_name":"choumx/amphtml","owner":{"login":"choumx","id":20525523,"node_id":"MDQ6VXNlcjIwNTI1NTIz","avatar_url":"https://avatars1.githubusercontent.com/u/20525523?v=4","gravatar_id":"","url":"https://api.github.com/users/choumx","html_url":"https://github.com/choumx","followers_url":"https://api.github.com/users/choumx/followers","following_url":"https://api.github.com/users/choumx/following{/other_user}","gists_url":"https://api.github.com/users/choumx/gists{/gist_id}","starred_url":"https://api.github.com/users/choumx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choumx/subscriptions","organizations_url":"https://api.github.com/users/choumx/orgs","repos_url":"https://api.github.com/users/choumx/repos","events_url":"https://api.github.com/users/choumx/events{/privacy}","received_events_url":"https://api.github.com/users/choumx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/choumx/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/choumx/amphtml","forks_url":"https://api.github.com/repos/choumx/amphtml/forks","keys_url":"https://api.github.com/repos/choumx/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/choumx/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/choumx/amphtml/teams","hooks_url":"https://api.github.com/repos/choumx/amphtml/hooks","issue_events_url":"https://api.github.com/repos/choumx/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/choumx/amphtml/events","assignees_url":"https://api.github.com/repos/choumx/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/choumx/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/choumx/amphtml/tags","blobs_url":"https://api.github.com/repos/choumx/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/choumx/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/choumx/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/choumx/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/choumx/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/choumx/amphtml/languages","stargazers_url":"https://api.github.com/repos/choumx/amphtml/stargazers","contributors_url":"https://api.github.com/repos/choumx/amphtml/contributors","subscribers_url":"https://api.github.com/repos/choumx/amphtml/subscribers","subscription_url":"https://api.github.com/repos/choumx/amphtml/subscription","commits_url":"https://api.github.com/repos/choumx/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/choumx/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/choumx/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/choumx/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/choumx/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/choumx/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/choumx/amphtml/merges","archive_url":"https://api.github.com/repos/choumx/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/choumx/amphtml/downloads","issues_url":"https://api.github.com/repos/choumx/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/choumx/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/choumx/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/choumx/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/choumx/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/choumx/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/choumx/amphtml/deployments","created_at":"2016-07-20T18:33:46Z","updated_at":"2018-07-30T15:18:22Z","pushed_at":"2018-07-31T04:05:52Z","git_url":"git://github.com/choumx/amphtml.git","ssh_url":"git@github.com:choumx/amphtml.git","clone_url":"https://github.com/choumx/amphtml.git","svn_url":"https://github.com/choumx/amphtml","homepage":"https://ampproject.org","size":493354,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"17de0933d7472569d229befb65287995ad12d54a","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-07-31T00:07:37Z","pushed_at":"2018-07-31T04:06:22Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":493475,"stargazers_count":11812,"watchers_count":11812,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2506,"mirror_url":null,"archived":false,"open_issues_count":1343,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2506,"open_issues":1343,"watchers":11812,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17209"},"html":{"href":"https://github.com/ampproject/amphtml/pull/17209"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/17209"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/17209/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17209/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17209/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/86de0d790a305ea1cdfba2ff651b5a0051b4bb3a"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":59,"deletions":42,"changed_files":3}}
{"actor":{"display_login":"choumx"}}