{"action":"created","issue":{"url":"https://api.github.com/repos/material-components/material-components-web/issues/2020","repository_url":"https://api.github.com/repos/material-components/material-components-web","labels_url":"https://api.github.com/repos/material-components/material-components-web/issues/2020/labels{/name}","comments_url":"https://api.github.com/repos/material-components/material-components-web/issues/2020/comments","events_url":"https://api.github.com/repos/material-components/material-components-web/issues/2020/events","html_url":"https://github.com/material-components/material-components-web/pull/2020","id":290183463,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY0MTIyMzcz","number":2020,"title":"feat(expansion-panel): Add Expansion Panel component","user":{"login":"griest024","id":5853222,"node_id":"MDQ6VXNlcjU4NTMyMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/5853222?v=4","gravatar_id":"","url":"https://api.github.com/users/griest024","html_url":"https://github.com/griest024","followers_url":"https://api.github.com/users/griest024/followers","following_url":"https://api.github.com/users/griest024/following{/other_user}","gists_url":"https://api.github.com/users/griest024/gists{/gist_id}","starred_url":"https://api.github.com/users/griest024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/griest024/subscriptions","organizations_url":"https://api.github.com/users/griest024/orgs","repos_url":"https://api.github.com/users/griest024/repos","events_url":"https://api.github.com/users/griest024/events{/privacy}","received_events_url":"https://api.github.com/users/griest024/received_events","type":"User","site_admin":false},"labels":[{"id":505616798,"node_id":"MDU6TGFiZWw1MDU2MTY3OTg=","url":"https://api.github.com/repos/material-components/material-components-web/labels/needs-design-guidance","name":"needs-design-guidance","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2018-01-20T10:58:15Z","updated_at":"2018-10-12T02:27:55Z","closed_at":"2018-06-29T22:22:59Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/2020","html_url":"https://github.com/material-components/material-components-web/pull/2020","diff_url":"https://github.com/material-components/material-components-web/pull/2020.diff","patch_url":"https://github.com/material-components/material-components-web/pull/2020.patch"},"body":"closes #46\r\n\r\nThis is ready for code review.\r\n\r\n[Engineering Outline](https://docs.google.com/document/d/1y0092LZJABV-T2_dKX4THlwb7l9j8-zg3yh5J4uWTko/edit?usp=sharing)\r\n\r\nTODO:\r\n\r\n- [x] Accordion\r\n- [x] Block `toggleExpansion()` when target is not appropriate\r\n- [x] Docs/README\r\n- [x] RTL\r\n- [x] Theming\r\n- [ ] Accessibility\r\n- [x] Tests\r\n- [x] SCSS mixins and partials\r\n- [x] ~~Define keyframes~~\r\n- [x] Tab key selection\r\n- [ ] No JS variant\r\n- [x] Closure compatibility\r\n\r\nI need guidance on a few things:\r\n\r\n- I set the inner HTML of the expansion icon(s) to `expand_more` in the foundation because the spec shows that exact icon. Is this preferable to actually inserting the icon into the header manually and not having the user create the icon at all?\r\n- The spec doesn't say how to style the text in the body or footer sections. Should I use the \"Label\" text style (15sp Roboto Regular; 87% black)?\r\n- The theming is still a bit weak. With dark theme going away, what is the proper way to implement component theming in a dark context?"},"comment":{"url":"https://api.github.com/repos/material-components/material-components-web/issues/comments/429183156","html_url":"https://github.com/material-components/material-components-web/pull/2020#issuecomment-429183156","issue_url":"https://api.github.com/repos/material-components/material-components-web/issues/2020","id":429183156,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTE4MzE1Ng==","user":{"login":"jasonsturges","id":1213591,"node_id":"MDQ6VXNlcjEyMTM1OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1213591?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonsturges","html_url":"https://github.com/jasonsturges","followers_url":"https://api.github.com/users/jasonsturges/followers","following_url":"https://api.github.com/users/jasonsturges/following{/other_user}","gists_url":"https://api.github.com/users/jasonsturges/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonsturges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonsturges/subscriptions","organizations_url":"https://api.github.com/users/jasonsturges/orgs","repos_url":"https://api.github.com/users/jasonsturges/repos","events_url":"https://api.github.com/users/jasonsturges/events{/privacy}","received_events_url":"https://api.github.com/users/jasonsturges/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T02:27:55Z","updated_at":"2018-10-12T02:27:55Z","author_association":"NONE","body":"As noted in #3738, I wanted to point out here Material Design specifies expand and collapse for Lists:\r\n\r\nhttps://material.io/design/components/lists.html#types\r\n\r\n![image](https://user-images.githubusercontent.com/1213591/46844218-a106c300-cd9b-11e8-92a5-a64c215582b5.png)\r\n"}}
{"actor":{"display_login":"jasonsturges"}}