{"action":"created","comment":{"url":"https://api.github.com/repos/sugarcrm/school/pulls/comments/178639670","pull_request_review_id":108729642,"id":178639670,"diff_hunk":"@@ -0,0 +1,62 @@\n+<?php\n+\n+use Sugarcrm\\Sugarcrm\\custom\\gradebook_fake\\RecordManager;\n+\n+class StudentGradebookJob implements RunnableSchedulerJob {","path":"package/src/custom/Extension/modules/Schedulers/Ext/ScheduledTasks/StudentGradebookJob.php","position":null,"original_position":5,"commit_id":"639f28b3d8709c82bd1b17ed9a7fa10a024b8edb","original_commit_id":"e4bf8269f9b83ca865df43b9ed824d512a33949b","user":{"login":"lschaefer-sugarcrm","id":30125048,"avatar_url":"https://avatars3.githubusercontent.com/u/30125048?v=4","gravatar_id":"","url":"https://api.github.com/users/lschaefer-sugarcrm","html_url":"https://github.com/lschaefer-sugarcrm","followers_url":"https://api.github.com/users/lschaefer-sugarcrm/followers","following_url":"https://api.github.com/users/lschaefer-sugarcrm/following{/other_user}","gists_url":"https://api.github.com/users/lschaefer-sugarcrm/gists{/gist_id}","starred_url":"https://api.github.com/users/lschaefer-sugarcrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lschaefer-sugarcrm/subscriptions","organizations_url":"https://api.github.com/users/lschaefer-sugarcrm/orgs","repos_url":"https://api.github.com/users/lschaefer-sugarcrm/repos","events_url":"https://api.github.com/users/lschaefer-sugarcrm/events{/privacy}","received_events_url":"https://api.github.com/users/lschaefer-sugarcrm/received_events","type":"User","site_admin":false},"body":"Thanks for the detailed review! I've made the style changes you made and opened an issue to track adding a style checker to our build process.","created_at":"2018-04-02T20:22:50Z","updated_at":"2018-04-02T20:22:50Z","html_url":"https://github.com/sugarcrm/school/pull/38#discussion_r178639670","pull_request_url":"https://api.github.com/repos/sugarcrm/school/pulls/38","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sugarcrm/school/pulls/comments/178639670"},"html":{"href":"https://github.com/sugarcrm/school/pull/38#discussion_r178639670"},"pull_request":{"href":"https://api.github.com/repos/sugarcrm/school/pulls/38"}},"in_reply_to_id":178568101},"pull_request":{"url":"https://api.github.com/repos/sugarcrm/school/pulls/38","id":178055349,"html_url":"https://github.com/sugarcrm/school/pull/38","diff_url":"https://github.com/sugarcrm/school/pull/38.diff","patch_url":"https://github.com/sugarcrm/school/pull/38.patch","issue_url":"https://api.github.com/repos/sugarcrm/school/issues/38","number":38,"state":"open","locked":false,"title":"Integration tests","user":{"login":"lschaefer-sugarcrm","id":30125048,"avatar_url":"https://avatars3.githubusercontent.com/u/30125048?v=4","gravatar_id":"","url":"https://api.github.com/users/lschaefer-sugarcrm","html_url":"https://github.com/lschaefer-sugarcrm","followers_url":"https://api.github.com/users/lschaefer-sugarcrm/followers","following_url":"https://api.github.com/users/lschaefer-sugarcrm/following{/other_user}","gists_url":"https://api.github.com/users/lschaefer-sugarcrm/gists{/gist_id}","starred_url":"https://api.github.com/users/lschaefer-sugarcrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lschaefer-sugarcrm/subscriptions","organizations_url":"https://api.github.com/users/lschaefer-sugarcrm/orgs","repos_url":"https://api.github.com/users/lschaefer-sugarcrm/repos","events_url":"https://api.github.com/users/lschaefer-sugarcrm/events{/privacy}","received_events_url":"https://api.github.com/users/lschaefer-sugarcrm/received_events","type":"User","site_admin":false},"body":"@glevine-sugarcrm Are you able to review the unit tests?  I think I mostly stuck with what you suggested. \r\n\r\n@mmarum-sugarcrm This PR is finally ready for review!  If you're able to try out running the tests locally as well as in Jenkins, it might be really helpful.  I think I've documented all of the little pieces you need to install and configure, but it's possible I missed something along the way.  I've been opening Issues related to this work that can be finished separate from this PR.","created_at":"2018-03-28T14:21:22Z","updated_at":"2018-04-02T20:22:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d853c236048d12a4f126eb74bcc84ad0d29b1c1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"glevine-sugarcrm","id":1737955,"avatar_url":"https://avatars2.githubusercontent.com/u/1737955?v=4","gravatar_id":"","url":"https://api.github.com/users/glevine-sugarcrm","html_url":"https://github.com/glevine-sugarcrm","followers_url":"https://api.github.com/users/glevine-sugarcrm/followers","following_url":"https://api.github.com/users/glevine-sugarcrm/following{/other_user}","gists_url":"https://api.github.com/users/glevine-sugarcrm/gists{/gist_id}","starred_url":"https://api.github.com/users/glevine-sugarcrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevine-sugarcrm/subscriptions","organizations_url":"https://api.github.com/users/glevine-sugarcrm/orgs","repos_url":"https://api.github.com/users/glevine-sugarcrm/repos","events_url":"https://api.github.com/users/glevine-sugarcrm/events{/privacy}","received_events_url":"https://api.github.com/users/glevine-sugarcrm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sugarcrm/school/pulls/38/commits","review_comments_url":"https://api.github.com/repos/sugarcrm/school/pulls/38/comments","review_comment_url":"https://api.github.com/repos/sugarcrm/school/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sugarcrm/school/issues/38/comments","statuses_url":"https://api.github.com/repos/sugarcrm/school/statuses/639f28b3d8709c82bd1b17ed9a7fa10a024b8edb","head":{"label":"sugarcrm:integration-tests","ref":"integration-tests","sha":"639f28b3d8709c82bd1b17ed9a7fa10a024b8edb","user":{"login":"sugarcrm","id":60142,"avatar_url":"https://avatars2.githubusercontent.com/u/60142?v=4","gravatar_id":"","url":"https://api.github.com/users/sugarcrm","html_url":"https://github.com/sugarcrm","followers_url":"https://api.github.com/users/sugarcrm/followers","following_url":"https://api.github.com/users/sugarcrm/following{/other_user}","gists_url":"https://api.github.com/users/sugarcrm/gists{/gist_id}","starred_url":"https://api.github.com/users/sugarcrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sugarcrm/subscriptions","organizations_url":"https://api.github.com/users/sugarcrm/orgs","repos_url":"https://api.github.com/users/sugarcrm/repos","events_url":"https://api.github.com/users/sugarcrm/events{/privacy}","received_events_url":"https://api.github.com/users/sugarcrm/received_events","type":"Organization","site_admin":false},"repo":{"id":109023666,"name":"school","full_name":"sugarcrm/school","owner":{"login":"sugarcrm","id":60142,"avatar_url":"https://avatars2.githubusercontent.com/u/60142?v=4","gravatar_id":"","url":"https://api.github.com/users/sugarcrm","html_url":"https://github.com/sugarcrm","followers_url":"https://api.github.com/users/sugarcrm/followers","following_url":"https://api.github.com/users/sugarcrm/following{/other_user}","gists_url":"https://api.github.com/users/sugarcrm/gists{/gist_id}","starred_url":"https://api.github.com/users/sugarcrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sugarcrm/subscriptions","organizations_url":"https://api.github.com/users/sugarcrm/orgs","repos_url":"https://api.github.com/users/sugarcrm/repos","events_url":"https://api.github.com/users/sugarcrm/events{/privacy}","received_events_url":"https://api.github.com/users/sugarcrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sugarcrm/school","description":"Professor M's School for Gifted Coders","fork":false,"url":"https://api.github.com/repos/sugarcrm/school","forks_url":"https://api.github.com/repos/sugarcrm/school/forks","keys_url":"https://api.github.com/repos/sugarcrm/school/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sugarcrm/school/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sugarcrm/school/teams","hooks_url":"https://api.github.com/repos/sugarcrm/school/hooks","issue_events_url":"https://api.github.com/repos/sugarcrm/school/issues/events{/number}","events_url":"https://api.github.com/repos/sugarcrm/school/events","assignees_url":"https://api.github.com/repos/sugarcrm/school/assignees{/user}","branches_url":"https://api.github.com/repos/sugarcrm/school/branches{/branch}","tags_url":"https://api.github.com/repos/sugarcrm/school/tags","blobs_url":"https://api.github.com/repos/sugarcrm/school/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sugarcrm/school/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sugarcrm/school/git/refs{/sha}","trees_url":"https://api.github.com/repos/sugarcrm/school/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sugarcrm/school/statuses/{sha}","languages_url":"https://api.github.com/repos/sugarcrm/school/languages","stargazers_url":"https://api.github.com/repos/sugarcrm/school/stargazers","contributors_url":"https://api.github.com/repos/sugarcrm/school/contributors","subscribers_url":"https://api.github.com/repos/sugarcrm/school/subscribers","subscription_url":"https://api.github.com/repos/sugarcrm/school/subscription","commits_url":"https://api.github.com/repos/sugarcrm/school/commits{/sha}","git_commits_url":"https://api.github.com/repos/sugarcrm/school/git/commits{/sha}","comments_url":"https://api.github.com/repos/sugarcrm/school/comments{/number}","issue_comment_url":"https://api.github.com/repos/sugarcrm/school/issues/comments{/number}","contents_url":"https://api.github.com/repos/sugarcrm/school/contents/{+path}","compare_url":"https://api.github.com/repos/sugarcrm/school/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sugarcrm/school/merges","archive_url":"https://api.github.com/repos/sugarcrm/school/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sugarcrm/school/downloads","issues_url":"https://api.github.com/repos/sugarcrm/school/issues{/number}","pulls_url":"https://api.github.com/repos/sugarcrm/school/pulls{/number}","milestones_url":"https://api.github.com/repos/sugarcrm/school/milestones{/number}","notifications_url":"https://api.github.com/repos/sugarcrm/school/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sugarcrm/school/labels{/name}","releases_url":"https://api.github.com/repos/sugarcrm/school/releases{/id}","deployments_url":"https://api.github.com/repos/sugarcrm/school/deployments","created_at":"2017-10-31T16:34:05Z","updated_at":"2018-02-12T12:54:28Z","pushed_at":"2018-04-02T20:21:37Z","git_url":"git://github.com/sugarcrm/school.git","ssh_url":"git@github.com:sugarcrm/school.git","clone_url":"https://github.com/sugarcrm/school.git","svn_url":"https://github.com/sugarcrm/school","homepage":null,"size":2889,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5,"open_issues":20,"watchers":6,"default_branch":"master"}},"base":{"label":"sugarcrm:master","ref":"master","sha":"be516e8c6dfe5c7b5599007ce1b50f171a4fb5ee","user":{"login":"sugarcrm","id":60142,"avatar_url":"https://avatars2.githubusercontent.com/u/60142?v=4","gravatar_id":"","url":"https://api.github.com/users/sugarcrm","html_url":"https://github.com/sugarcrm","followers_url":"https://api.github.com/users/sugarcrm/followers","following_url":"https://api.github.com/users/sugarcrm/following{/other_user}","gists_url":"https://api.github.com/users/sugarcrm/gists{/gist_id}","starred_url":"https://api.github.com/users/sugarcrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sugarcrm/subscriptions","organizations_url":"https://api.github.com/users/sugarcrm/orgs","repos_url":"https://api.github.com/users/sugarcrm/repos","events_url":"https://api.github.com/users/sugarcrm/events{/privacy}","received_events_url":"https://api.github.com/users/sugarcrm/received_events","type":"Organization","site_admin":false},"repo":{"id":109023666,"name":"school","full_name":"sugarcrm/school","owner":{"login":"sugarcrm","id":60142,"avatar_url":"https://avatars2.githubusercontent.com/u/60142?v=4","gravatar_id":"","url":"https://api.github.com/users/sugarcrm","html_url":"https://github.com/sugarcrm","followers_url":"https://api.github.com/users/sugarcrm/followers","following_url":"https://api.github.com/users/sugarcrm/following{/other_user}","gists_url":"https://api.github.com/users/sugarcrm/gists{/gist_id}","starred_url":"https://api.github.com/users/sugarcrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sugarcrm/subscriptions","organizations_url":"https://api.github.com/users/sugarcrm/orgs","repos_url":"https://api.github.com/users/sugarcrm/repos","events_url":"https://api.github.com/users/sugarcrm/events{/privacy}","received_events_url":"https://api.github.com/users/sugarcrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sugarcrm/school","description":"Professor M's School for Gifted Coders","fork":false,"url":"https://api.github.com/repos/sugarcrm/school","forks_url":"https://api.github.com/repos/sugarcrm/school/forks","keys_url":"https://api.github.com/repos/sugarcrm/school/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sugarcrm/school/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sugarcrm/school/teams","hooks_url":"https://api.github.com/repos/sugarcrm/school/hooks","issue_events_url":"https://api.github.com/repos/sugarcrm/school/issues/events{/number}","events_url":"https://api.github.com/repos/sugarcrm/school/events","assignees_url":"https://api.github.com/repos/sugarcrm/school/assignees{/user}","branches_url":"https://api.github.com/repos/sugarcrm/school/branches{/branch}","tags_url":"https://api.github.com/repos/sugarcrm/school/tags","blobs_url":"https://api.github.com/repos/sugarcrm/school/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sugarcrm/school/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sugarcrm/school/git/refs{/sha}","trees_url":"https://api.github.com/repos/sugarcrm/school/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sugarcrm/school/statuses/{sha}","languages_url":"https://api.github.com/repos/sugarcrm/school/languages","stargazers_url":"https://api.github.com/repos/sugarcrm/school/stargazers","contributors_url":"https://api.github.com/repos/sugarcrm/school/contributors","subscribers_url":"https://api.github.com/repos/sugarcrm/school/subscribers","subscription_url":"https://api.github.com/repos/sugarcrm/school/subscription","commits_url":"https://api.github.com/repos/sugarcrm/school/commits{/sha}","git_commits_url":"https://api.github.com/repos/sugarcrm/school/git/commits{/sha}","comments_url":"https://api.github.com/repos/sugarcrm/school/comments{/number}","issue_comment_url":"https://api.github.com/repos/sugarcrm/school/issues/comments{/number}","contents_url":"https://api.github.com/repos/sugarcrm/school/contents/{+path}","compare_url":"https://api.github.com/repos/sugarcrm/school/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sugarcrm/school/merges","archive_url":"https://api.github.com/repos/sugarcrm/school/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sugarcrm/school/downloads","issues_url":"https://api.github.com/repos/sugarcrm/school/issues{/number}","pulls_url":"https://api.github.com/repos/sugarcrm/school/pulls{/number}","milestones_url":"https://api.github.com/repos/sugarcrm/school/milestones{/number}","notifications_url":"https://api.github.com/repos/sugarcrm/school/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sugarcrm/school/labels{/name}","releases_url":"https://api.github.com/repos/sugarcrm/school/releases{/id}","deployments_url":"https://api.github.com/repos/sugarcrm/school/deployments","created_at":"2017-10-31T16:34:05Z","updated_at":"2018-02-12T12:54:28Z","pushed_at":"2018-04-02T20:21:37Z","git_url":"git://github.com/sugarcrm/school.git","ssh_url":"git@github.com:sugarcrm/school.git","clone_url":"https://github.com/sugarcrm/school.git","svn_url":"https://github.com/sugarcrm/school","homepage":null,"size":2889,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5,"open_issues":20,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sugarcrm/school/pulls/38"},"html":{"href":"https://github.com/sugarcrm/school/pull/38"},"issue":{"href":"https://api.github.com/repos/sugarcrm/school/issues/38"},"comments":{"href":"https://api.github.com/repos/sugarcrm/school/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/sugarcrm/school/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/sugarcrm/school/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sugarcrm/school/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/sugarcrm/school/statuses/639f28b3d8709c82bd1b17ed9a7fa10a024b8edb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lschaefer-sugarcrm"}}