{"action":"created","comment":{"url":"https://api.github.com/repos/emcconville/wand/pulls/comments/231163106","pull_request_review_id":172069359,"id":231163106,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTE2MzEwNg==","diff_hunk":"@@ -1,35 +1,27 @@\n language: python\n sudo: false\n python:\n-- 2.6\n - 2.7\n-- 3.2\n-- 3.3\n-- 3.4\n-- 3.5\n+- 3.6\n - pypy\n - pypy3\n env:\n - secure: \"EhG2uSD2m1eGxuL2HeQewJJx7MVL4WpjrxyfiUBEgsApemD1yKJPjUnLwAyd\\nbPi5HJx5ySm1TTRSvj6/yP85YLYTaJHA8OabKk7p0wFW294qcrYIDGovU7NL\\n3YOqZmqN+S3XOBGFCOnByxE+pcxxWW/3/I09EgeW7D6tBPh67G0=\"\n install:\n - echo $TRAVIS_PYTHON_VERSION\n-- pip install pytest pytest-xdist pytest-capturelog memory_profiler==0.40 psutil coveralls flake8\n+- pip install pytest pytest-xdist pytest-catchlog memory_profiler==0.40 psutil coveralls","path":".travis.yml","position":18,"original_position":18,"commit_id":"2175ed49ec54828a6436f27b4b88c5feeda1c962","original_commit_id":"2175ed49ec54828a6436f27b4b88c5feeda1c962","user":{"login":"dahlia","id":12431,"node_id":"MDQ6VXNlcjEyNDMx","avatar_url":"https://avatars1.githubusercontent.com/u/12431?v=4","gravatar_id":"","url":"https://api.github.com/users/dahlia","html_url":"https://github.com/dahlia","followers_url":"https://api.github.com/users/dahlia/followers","following_url":"https://api.github.com/users/dahlia/following{/other_user}","gists_url":"https://api.github.com/users/dahlia/gists{/gist_id}","starred_url":"https://api.github.com/users/dahlia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dahlia/subscriptions","organizations_url":"https://api.github.com/users/dahlia/orgs","repos_url":"https://api.github.com/users/dahlia/repos","events_url":"https://api.github.com/users/dahlia/events{/privacy}","received_events_url":"https://api.github.com/users/dahlia/received_events","type":"User","site_admin":false},"body":"FYI [since the version 3.3.0, pytest has its own built-in catchlog/caplog feature.][1]\r\n\r\n[1]: https://docs.pytest.org/en/latest/changelog.html#pytest-3-3-0-2017-11-23","created_at":"2018-11-06T15:17:23Z","updated_at":"2018-11-06T15:17:23Z","html_url":"https://github.com/emcconville/wand/pull/380#discussion_r231163106","pull_request_url":"https://api.github.com/repos/emcconville/wand/pulls/380","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/emcconville/wand/pulls/comments/231163106"},"html":{"href":"https://github.com/emcconville/wand/pull/380#discussion_r231163106"},"pull_request":{"href":"https://api.github.com/repos/emcconville/wand/pulls/380"}}},"pull_request":{"url":"https://api.github.com/repos/emcconville/wand/pulls/380","id":228718010,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NzE4MDEw","html_url":"https://github.com/emcconville/wand/pull/380","diff_url":"https://github.com/emcconville/wand/pull/380.diff","patch_url":"https://github.com/emcconville/wand/pull/380.patch","issue_url":"https://api.github.com/repos/emcconville/wand/issues/380","number":380,"state":"open","locked":false,"title":"Reduce complexity of CI testing","user":{"login":"emcconville","id":84594,"node_id":"MDQ6VXNlcjg0NTk0","avatar_url":"https://avatars3.githubusercontent.com/u/84594?v=4","gravatar_id":"","url":"https://api.github.com/users/emcconville","html_url":"https://github.com/emcconville","followers_url":"https://api.github.com/users/emcconville/followers","following_url":"https://api.github.com/users/emcconville/following{/other_user}","gists_url":"https://api.github.com/users/emcconville/gists{/gist_id}","starred_url":"https://api.github.com/users/emcconville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emcconville/subscriptions","organizations_url":"https://api.github.com/users/emcconville/orgs","repos_url":"https://api.github.com/users/emcconville/repos","events_url":"https://api.github.com/users/emcconville/events{/privacy}","received_events_url":"https://api.github.com/users/emcconville/received_events","type":"User","site_admin":false},"body":"This PR reworks the Travis CI test suite, and reduces the complexity be limiting the number of python run-times to the latest stable versions.\r\n\r\n**What made CI complex in the first place?**\r\n\r\nPreviously the CI performed regression testing on 8 python run-times, and was missing Python-3.6 & 3.7(dev) support. With additional work for ImageMagick-7 planned, the responsibilities of CI regression testing would increase to 20 runtimes (10x Python interpreters * 2x ImageMagick version). In my opinion, that was a little to much for the current wand-py community, and I felt it was also discouraging  to new pull-requests by users not familiar with the devops behind CI.\r\n\r\n**The new security landscape.**\r\n\r\nIt's been a crazy couple of years for CVE. With enforcement of HTTPS, revised security policies, and other take-aways from ImageTragick, a few test-cases should not be attempted on Travis-CI. Tests dependent on MVG, TXT, and HTTP(S) protocols will be marked as `skipped` if the underlining system does not permit it.\r\nThis PR introduces a `--no-pdf` option to skip any PDF tests. I believe many folks _do_ want to continue regression testing with PDF documents, and so I felt it was best to allow folks to explicitly opt-out.\r\n\r\n**That'll do Flake8, that'll do.**\r\n\r\nI love using the `flake8` utility, but I felt it was not the role of CI to enforce clean-code. It's shame because it's so easy to include it. But the role of clean-code belongs to maintainers + community developers, not regression testing. Plus new members having their pull-request rejected with \"`E722 do not use bare except`\" messages are not helpful. I'd rather issue a comment like: \"`Welcome & thanks! ... Can you please run flake8 against your branch?`\"\r\n\r\n**TL;DR**\r\n\r\nMoving forward, I'd like the role of CI to focus on latest stable Python/Pypy 2.X & 3.X runtimes provided by Travis-CI, and be open & inviting to new community members. Other runtimes will continue to be officially supported, but not included in the day-to-day CI testing.\r\n\r\nThoughts? Comments?","created_at":"2018-11-06T14:51:07Z","updated_at":"2018-11-06T15:17:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d81ff45502314633fb030f7f9d083836c4f08b6f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/emcconville/wand/pulls/380/commits","review_comments_url":"https://api.github.com/repos/emcconville/wand/pulls/380/comments","review_comment_url":"https://api.github.com/repos/emcconville/wand/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emcconville/wand/issues/380/comments","statuses_url":"https://api.github.com/repos/emcconville/wand/statuses/2175ed49ec54828a6436f27b4b88c5feeda1c962","head":{"label":"emcconville:refactor/ci_testing","ref":"refactor/ci_testing","sha":"2175ed49ec54828a6436f27b4b88c5feeda1c962","user":{"login":"emcconville","id":84594,"node_id":"MDQ6VXNlcjg0NTk0","avatar_url":"https://avatars3.githubusercontent.com/u/84594?v=4","gravatar_id":"","url":"https://api.github.com/users/emcconville","html_url":"https://github.com/emcconville","followers_url":"https://api.github.com/users/emcconville/followers","following_url":"https://api.github.com/users/emcconville/following{/other_user}","gists_url":"https://api.github.com/users/emcconville/gists{/gist_id}","starred_url":"https://api.github.com/users/emcconville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emcconville/subscriptions","organizations_url":"https://api.github.com/users/emcconville/orgs","repos_url":"https://api.github.com/users/emcconville/repos","events_url":"https://api.github.com/users/emcconville/events{/privacy}","received_events_url":"https://api.github.com/users/emcconville/received_events","type":"User","site_admin":false},"repo":{"id":2492312,"node_id":"MDEwOlJlcG9zaXRvcnkyNDkyMzEy","name":"wand","full_name":"emcconville/wand","private":false,"owner":{"login":"emcconville","id":84594,"node_id":"MDQ6VXNlcjg0NTk0","avatar_url":"https://avatars3.githubusercontent.com/u/84594?v=4","gravatar_id":"","url":"https://api.github.com/users/emcconville","html_url":"https://github.com/emcconville","followers_url":"https://api.github.com/users/emcconville/followers","following_url":"https://api.github.com/users/emcconville/following{/other_user}","gists_url":"https://api.github.com/users/emcconville/gists{/gist_id}","starred_url":"https://api.github.com/users/emcconville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emcconville/subscriptions","organizations_url":"https://api.github.com/users/emcconville/orgs","repos_url":"https://api.github.com/users/emcconville/repos","events_url":"https://api.github.com/users/emcconville/events{/privacy}","received_events_url":"https://api.github.com/users/emcconville/received_events","type":"User","site_admin":false},"html_url":"https://github.com/emcconville/wand","description":"The ctypes-based simple ImageMagick binding for Python","fork":false,"url":"https://api.github.com/repos/emcconville/wand","forks_url":"https://api.github.com/repos/emcconville/wand/forks","keys_url":"https://api.github.com/repos/emcconville/wand/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emcconville/wand/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emcconville/wand/teams","hooks_url":"https://api.github.com/repos/emcconville/wand/hooks","issue_events_url":"https://api.github.com/repos/emcconville/wand/issues/events{/number}","events_url":"https://api.github.com/repos/emcconville/wand/events","assignees_url":"https://api.github.com/repos/emcconville/wand/assignees{/user}","branches_url":"https://api.github.com/repos/emcconville/wand/branches{/branch}","tags_url":"https://api.github.com/repos/emcconville/wand/tags","blobs_url":"https://api.github.com/repos/emcconville/wand/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emcconville/wand/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emcconville/wand/git/refs{/sha}","trees_url":"https://api.github.com/repos/emcconville/wand/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emcconville/wand/statuses/{sha}","languages_url":"https://api.github.com/repos/emcconville/wand/languages","stargazers_url":"https://api.github.com/repos/emcconville/wand/stargazers","contributors_url":"https://api.github.com/repos/emcconville/wand/contributors","subscribers_url":"https://api.github.com/repos/emcconville/wand/subscribers","subscription_url":"https://api.github.com/repos/emcconville/wand/subscription","commits_url":"https://api.github.com/repos/emcconville/wand/commits{/sha}","git_commits_url":"https://api.github.com/repos/emcconville/wand/git/commits{/sha}","comments_url":"https://api.github.com/repos/emcconville/wand/comments{/number}","issue_comment_url":"https://api.github.com/repos/emcconville/wand/issues/comments{/number}","contents_url":"https://api.github.com/repos/emcconville/wand/contents/{+path}","compare_url":"https://api.github.com/repos/emcconville/wand/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emcconville/wand/merges","archive_url":"https://api.github.com/repos/emcconville/wand/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emcconville/wand/downloads","issues_url":"https://api.github.com/repos/emcconville/wand/issues{/number}","pulls_url":"https://api.github.com/repos/emcconville/wand/pulls{/number}","milestones_url":"https://api.github.com/repos/emcconville/wand/milestones{/number}","notifications_url":"https://api.github.com/repos/emcconville/wand/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emcconville/wand/labels{/name}","releases_url":"https://api.github.com/repos/emcconville/wand/releases{/id}","deployments_url":"https://api.github.com/repos/emcconville/wand/deployments","created_at":"2011-09-30T21:36:38Z","updated_at":"2018-11-06T15:02:22Z","pushed_at":"2018-11-06T14:51:08Z","git_url":"git://github.com/emcconville/wand.git","ssh_url":"git@github.com:emcconville/wand.git","clone_url":"https://github.com/emcconville/wand.git","svn_url":"https://github.com/emcconville/wand","homepage":"http://wand-py.org/","size":11184,"stargazers_count":809,"watchers_count":809,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":164,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":164,"open_issues":136,"watchers":809,"default_branch":"master"}},"base":{"label":"emcconville:master","ref":"master","sha":"f676aae19a5e6d317f0bad2221d1f44f19e064fd","user":{"login":"emcconville","id":84594,"node_id":"MDQ6VXNlcjg0NTk0","avatar_url":"https://avatars3.githubusercontent.com/u/84594?v=4","gravatar_id":"","url":"https://api.github.com/users/emcconville","html_url":"https://github.com/emcconville","followers_url":"https://api.github.com/users/emcconville/followers","following_url":"https://api.github.com/users/emcconville/following{/other_user}","gists_url":"https://api.github.com/users/emcconville/gists{/gist_id}","starred_url":"https://api.github.com/users/emcconville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emcconville/subscriptions","organizations_url":"https://api.github.com/users/emcconville/orgs","repos_url":"https://api.github.com/users/emcconville/repos","events_url":"https://api.github.com/users/emcconville/events{/privacy}","received_events_url":"https://api.github.com/users/emcconville/received_events","type":"User","site_admin":false},"repo":{"id":2492312,"node_id":"MDEwOlJlcG9zaXRvcnkyNDkyMzEy","name":"wand","full_name":"emcconville/wand","private":false,"owner":{"login":"emcconville","id":84594,"node_id":"MDQ6VXNlcjg0NTk0","avatar_url":"https://avatars3.githubusercontent.com/u/84594?v=4","gravatar_id":"","url":"https://api.github.com/users/emcconville","html_url":"https://github.com/emcconville","followers_url":"https://api.github.com/users/emcconville/followers","following_url":"https://api.github.com/users/emcconville/following{/other_user}","gists_url":"https://api.github.com/users/emcconville/gists{/gist_id}","starred_url":"https://api.github.com/users/emcconville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emcconville/subscriptions","organizations_url":"https://api.github.com/users/emcconville/orgs","repos_url":"https://api.github.com/users/emcconville/repos","events_url":"https://api.github.com/users/emcconville/events{/privacy}","received_events_url":"https://api.github.com/users/emcconville/received_events","type":"User","site_admin":false},"html_url":"https://github.com/emcconville/wand","description":"The ctypes-based simple ImageMagick binding for Python","fork":false,"url":"https://api.github.com/repos/emcconville/wand","forks_url":"https://api.github.com/repos/emcconville/wand/forks","keys_url":"https://api.github.com/repos/emcconville/wand/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emcconville/wand/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emcconville/wand/teams","hooks_url":"https://api.github.com/repos/emcconville/wand/hooks","issue_events_url":"https://api.github.com/repos/emcconville/wand/issues/events{/number}","events_url":"https://api.github.com/repos/emcconville/wand/events","assignees_url":"https://api.github.com/repos/emcconville/wand/assignees{/user}","branches_url":"https://api.github.com/repos/emcconville/wand/branches{/branch}","tags_url":"https://api.github.com/repos/emcconville/wand/tags","blobs_url":"https://api.github.com/repos/emcconville/wand/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emcconville/wand/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emcconville/wand/git/refs{/sha}","trees_url":"https://api.github.com/repos/emcconville/wand/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emcconville/wand/statuses/{sha}","languages_url":"https://api.github.com/repos/emcconville/wand/languages","stargazers_url":"https://api.github.com/repos/emcconville/wand/stargazers","contributors_url":"https://api.github.com/repos/emcconville/wand/contributors","subscribers_url":"https://api.github.com/repos/emcconville/wand/subscribers","subscription_url":"https://api.github.com/repos/emcconville/wand/subscription","commits_url":"https://api.github.com/repos/emcconville/wand/commits{/sha}","git_commits_url":"https://api.github.com/repos/emcconville/wand/git/commits{/sha}","comments_url":"https://api.github.com/repos/emcconville/wand/comments{/number}","issue_comment_url":"https://api.github.com/repos/emcconville/wand/issues/comments{/number}","contents_url":"https://api.github.com/repos/emcconville/wand/contents/{+path}","compare_url":"https://api.github.com/repos/emcconville/wand/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emcconville/wand/merges","archive_url":"https://api.github.com/repos/emcconville/wand/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emcconville/wand/downloads","issues_url":"https://api.github.com/repos/emcconville/wand/issues{/number}","pulls_url":"https://api.github.com/repos/emcconville/wand/pulls{/number}","milestones_url":"https://api.github.com/repos/emcconville/wand/milestones{/number}","notifications_url":"https://api.github.com/repos/emcconville/wand/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emcconville/wand/labels{/name}","releases_url":"https://api.github.com/repos/emcconville/wand/releases{/id}","deployments_url":"https://api.github.com/repos/emcconville/wand/deployments","created_at":"2011-09-30T21:36:38Z","updated_at":"2018-11-06T15:02:22Z","pushed_at":"2018-11-06T14:51:08Z","git_url":"git://github.com/emcconville/wand.git","ssh_url":"git@github.com:emcconville/wand.git","clone_url":"https://github.com/emcconville/wand.git","svn_url":"https://github.com/emcconville/wand","homepage":"http://wand-py.org/","size":11184,"stargazers_count":809,"watchers_count":809,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":164,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":164,"open_issues":136,"watchers":809,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emcconville/wand/pulls/380"},"html":{"href":"https://github.com/emcconville/wand/pull/380"},"issue":{"href":"https://api.github.com/repos/emcconville/wand/issues/380"},"comments":{"href":"https://api.github.com/repos/emcconville/wand/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/emcconville/wand/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/emcconville/wand/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emcconville/wand/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/emcconville/wand/statuses/2175ed49ec54828a6436f27b4b88c5feeda1c962"}},"author_association":"OWNER"}}
{"actor":{"display_login":"dahlia"}}