{"action":"created","issue":{"url":"https://api.github.com/repos/IndicoDataSolutions/finetune/issues/29","repository_url":"https://api.github.com/repos/IndicoDataSolutions/finetune","labels_url":"https://api.github.com/repos/IndicoDataSolutions/finetune/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/IndicoDataSolutions/finetune/issues/29/comments","events_url":"https://api.github.com/repos/IndicoDataSolutions/finetune/issues/29/events","html_url":"https://github.com/IndicoDataSolutions/finetune/issues/29","id":339381061,"node_id":"MDU6SXNzdWUzMzkzODEwNjE=","number":29,"title":"implementation of ExponentialMovingAverage is not correct","user":{"login":"FrankWork","id":13351333,"node_id":"MDQ6VXNlcjEzMzUxMzMz","avatar_url":"https://avatars3.githubusercontent.com/u/13351333?v=4","gravatar_id":"","url":"https://api.github.com/users/FrankWork","html_url":"https://github.com/FrankWork","followers_url":"https://api.github.com/users/FrankWork/followers","following_url":"https://api.github.com/users/FrankWork/following{/other_user}","gists_url":"https://api.github.com/users/FrankWork/gists{/gist_id}","starred_url":"https://api.github.com/users/FrankWork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrankWork/subscriptions","organizations_url":"https://api.github.com/users/FrankWork/orgs","repos_url":"https://api.github.com/users/FrankWork/repos","events_url":"https://api.github.com/users/FrankWork/events{/privacy}","received_events_url":"https://api.github.com/users/FrankWork/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-09T09:54:02Z","updated_at":"2018-07-11T13:40:32Z","closed_at":null,"author_association":"NONE","body":"```\r\ndef get_ema_if_exists(v, gvs):\r\n    name = v.name.split(':')[0]\r\n    ema_name = name+'/ExponentialMovingAverage:0'\r\n    ema_v = [v for v in gvs if v.name == ema_name]\r\n    if len(ema_v) == 0:\r\n        ema_v = [v]\r\n    return ema_v[0]\r\n\r\ndef get_ema_vars(*vs):\r\n    if tf.get_variable_scope().reuse:\r\n        gvs = tf.global_variables()\r\n        vs = [get_ema_if_exists(v, gvs) for v in vs]\r\n    if len(vs) == 1:\r\n        return vs[0]\r\n    else:\r\n        return vs\r\n```\r\n\r\n`g, b = get_ema_vars(g, b)` I think `g, b` is the original tensor, not the ema"},"comment":{"url":"https://api.github.com/repos/IndicoDataSolutions/finetune/issues/comments/404173324","html_url":"https://github.com/IndicoDataSolutions/finetune/issues/29#issuecomment-404173324","issue_url":"https://api.github.com/repos/IndicoDataSolutions/finetune/issues/29","id":404173324,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDE3MzMyNA==","user":{"login":"madisonmay","id":2645393,"node_id":"MDQ6VXNlcjI2NDUzOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2645393?v=4","gravatar_id":"","url":"https://api.github.com/users/madisonmay","html_url":"https://github.com/madisonmay","followers_url":"https://api.github.com/users/madisonmay/followers","following_url":"https://api.github.com/users/madisonmay/following{/other_user}","gists_url":"https://api.github.com/users/madisonmay/gists{/gist_id}","starred_url":"https://api.github.com/users/madisonmay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madisonmay/subscriptions","organizations_url":"https://api.github.com/users/madisonmay/orgs","repos_url":"https://api.github.com/users/madisonmay/repos","events_url":"https://api.github.com/users/madisonmay/events{/privacy}","received_events_url":"https://api.github.com/users/madisonmay/received_events","type":"User","site_admin":false},"created_at":"2018-07-11T13:40:32Z","updated_at":"2018-07-11T13:40:32Z","author_association":"CONTRIBUTOR","body":"@FrankWork seems like the primary issue is that ExponentialMovingAverage variables are never set.  I'm assuming this is just dead code at this point and can be removed.  I've put up a PR for a fix but am checking with the original project author (Alec Radford) before merge to make sure -- I want to ensure that the EMA variables were not also not available at train time."}}
{"actor":{"display_login":"madisonmay"}}