{"action":"created","comment":{"url":"https://api.github.com/repos/innogames/openfl/pulls/comments/225985564","pull_request_review_id":165700296,"id":225985564,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTk4NTU2NA==","diff_hunk":"@@ -384,7 +384,7 @@ class Bitmap extends DisplayObject implements IShaderDrawable {\n \t\t\n \t\tif (__bitmapData != null) {\n \t\t\t\n-\t\t\tif (value != __bitmapData.height) {\n+\t\t\tif (value != __bitmapData.height * __scaleY) {","path":"src/openfl/display/Bitmap.hx","position":5,"original_position":5,"commit_id":"b730dfd844ca7bb7ebcbac3243fda2ab905e61da","original_commit_id":"b730dfd844ca7bb7ebcbac3243fda2ab905e61da","user":{"login":"nadako","id":49749,"node_id":"MDQ6VXNlcjQ5NzQ5","avatar_url":"https://avatars0.githubusercontent.com/u/49749?v=4","gravatar_id":"","url":"https://api.github.com/users/nadako","html_url":"https://github.com/nadako","followers_url":"https://api.github.com/users/nadako/followers","following_url":"https://api.github.com/users/nadako/following{/other_user}","gists_url":"https://api.github.com/users/nadako/gists{/gist_id}","starred_url":"https://api.github.com/users/nadako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadako/subscriptions","organizations_url":"https://api.github.com/users/nadako/orgs","repos_url":"https://api.github.com/users/nadako/repos","events_url":"https://api.github.com/users/nadako/events{/privacy}","received_events_url":"https://api.github.com/users/nadako/received_events","type":"User","site_admin":false},"body":"Note that it intentionally doesn't do `Math.abs` on scaleX/Y values there, because that's how Flash behaves:\r\n\r\n```as3\r\ntrace(bitmap.bitmapData.width); // 250\r\nbitmap.scaleX = -1;\r\ntrace(bitmap.width); // 250\r\nbitmap.width = bitmapData.width;\r\ntrace(bitmap.width); // 250\r\ntrace(bitmap.scaleX); // 1\r\n```","created_at":"2018-10-17T15:38:51Z","updated_at":"2018-10-17T15:38:51Z","html_url":"https://github.com/innogames/openfl/pull/81#discussion_r225985564","pull_request_url":"https://api.github.com/repos/innogames/openfl/pulls/81","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/innogames/openfl/pulls/comments/225985564"},"html":{"href":"https://github.com/innogames/openfl/pull/81#discussion_r225985564"},"pull_request":{"href":"https://api.github.com/repos/innogames/openfl/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/innogames/openfl/pulls/81","id":223654060,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjU0MDYw","html_url":"https://github.com/innogames/openfl/pull/81","diff_url":"https://github.com/innogames/openfl/pull/81.diff","patch_url":"https://github.com/innogames/openfl/pull/81.patch","issue_url":"https://api.github.com/repos/innogames/openfl/issues/81","number":81,"state":"open","locked":false,"title":"Fix setting Bitmap.width/height to the same values as its BitmapData's width/height","user":{"login":"nadako","id":49749,"node_id":"MDQ6VXNlcjQ5NzQ5","avatar_url":"https://avatars0.githubusercontent.com/u/49749?v=4","gravatar_id":"","url":"https://api.github.com/users/nadako","html_url":"https://github.com/nadako","followers_url":"https://api.github.com/users/nadako/followers","following_url":"https://api.github.com/users/nadako/following{/other_user}","gists_url":"https://api.github.com/users/nadako/gists{/gist_id}","starred_url":"https://api.github.com/users/nadako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadako/subscriptions","organizations_url":"https://api.github.com/users/nadako/orgs","repos_url":"https://api.github.com/users/nadako/repos","events_url":"https://api.github.com/users/nadako/events{/privacy}","received_events_url":"https://api.github.com/users/nadako/received_events","type":"User","site_admin":false},"body":"It must take scaleX/Y into account when determining whether the value has changed\r\n","created_at":"2018-10-17T15:36:57Z","updated_at":"2018-10-17T15:38:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b7004c6d06b450176cfbf0ab41f3b22d1a6f197","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/innogames/openfl/pulls/81/commits","review_comments_url":"https://api.github.com/repos/innogames/openfl/pulls/81/comments","review_comment_url":"https://api.github.com/repos/innogames/openfl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/innogames/openfl/issues/81/comments","statuses_url":"https://api.github.com/repos/innogames/openfl/statuses/b730dfd844ca7bb7ebcbac3243fda2ab905e61da","head":{"label":"innogames:bitmap-wh-setters-fix","ref":"bitmap-wh-setters-fix","sha":"b730dfd844ca7bb7ebcbac3243fda2ab905e61da","user":{"login":"innogames","id":1314968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTQ5Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1314968?v=4","gravatar_id":"","url":"https://api.github.com/users/innogames","html_url":"https://github.com/innogames","followers_url":"https://api.github.com/users/innogames/followers","following_url":"https://api.github.com/users/innogames/following{/other_user}","gists_url":"https://api.github.com/users/innogames/gists{/gist_id}","starred_url":"https://api.github.com/users/innogames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/innogames/subscriptions","organizations_url":"https://api.github.com/users/innogames/orgs","repos_url":"https://api.github.com/users/innogames/repos","events_url":"https://api.github.com/users/innogames/events{/privacy}","received_events_url":"https://api.github.com/users/innogames/received_events","type":"Organization","site_admin":false},"repo":{"id":88423138,"node_id":"MDEwOlJlcG9zaXRvcnk4ODQyMzEzOA==","name":"openfl","full_name":"innogames/openfl","private":false,"owner":{"login":"innogames","id":1314968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTQ5Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1314968?v=4","gravatar_id":"","url":"https://api.github.com/users/innogames","html_url":"https://github.com/innogames","followers_url":"https://api.github.com/users/innogames/followers","following_url":"https://api.github.com/users/innogames/following{/other_user}","gists_url":"https://api.github.com/users/innogames/gists{/gist_id}","starred_url":"https://api.github.com/users/innogames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/innogames/subscriptions","organizations_url":"https://api.github.com/users/innogames/orgs","repos_url":"https://api.github.com/users/innogames/repos","events_url":"https://api.github.com/users/innogames/events{/privacy}","received_events_url":"https://api.github.com/users/innogames/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/innogames/openfl","description":"The \"Open Flash Library\" for fast 2D development","fork":true,"url":"https://api.github.com/repos/innogames/openfl","forks_url":"https://api.github.com/repos/innogames/openfl/forks","keys_url":"https://api.github.com/repos/innogames/openfl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/innogames/openfl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/innogames/openfl/teams","hooks_url":"https://api.github.com/repos/innogames/openfl/hooks","issue_events_url":"https://api.github.com/repos/innogames/openfl/issues/events{/number}","events_url":"https://api.github.com/repos/innogames/openfl/events","assignees_url":"https://api.github.com/repos/innogames/openfl/assignees{/user}","branches_url":"https://api.github.com/repos/innogames/openfl/branches{/branch}","tags_url":"https://api.github.com/repos/innogames/openfl/tags","blobs_url":"https://api.github.com/repos/innogames/openfl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/innogames/openfl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/innogames/openfl/git/refs{/sha}","trees_url":"https://api.github.com/repos/innogames/openfl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/innogames/openfl/statuses/{sha}","languages_url":"https://api.github.com/repos/innogames/openfl/languages","stargazers_url":"https://api.github.com/repos/innogames/openfl/stargazers","contributors_url":"https://api.github.com/repos/innogames/openfl/contributors","subscribers_url":"https://api.github.com/repos/innogames/openfl/subscribers","subscription_url":"https://api.github.com/repos/innogames/openfl/subscription","commits_url":"https://api.github.com/repos/innogames/openfl/commits{/sha}","git_commits_url":"https://api.github.com/repos/innogames/openfl/git/commits{/sha}","comments_url":"https://api.github.com/repos/innogames/openfl/comments{/number}","issue_comment_url":"https://api.github.com/repos/innogames/openfl/issues/comments{/number}","contents_url":"https://api.github.com/repos/innogames/openfl/contents/{+path}","compare_url":"https://api.github.com/repos/innogames/openfl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/innogames/openfl/merges","archive_url":"https://api.github.com/repos/innogames/openfl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/innogames/openfl/downloads","issues_url":"https://api.github.com/repos/innogames/openfl/issues{/number}","pulls_url":"https://api.github.com/repos/innogames/openfl/pulls{/number}","milestones_url":"https://api.github.com/repos/innogames/openfl/milestones{/number}","notifications_url":"https://api.github.com/repos/innogames/openfl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/innogames/openfl/labels{/name}","releases_url":"https://api.github.com/repos/innogames/openfl/releases{/id}","deployments_url":"https://api.github.com/repos/innogames/openfl/deployments","created_at":"2017-04-16T15:36:14Z","updated_at":"2018-10-16T11:37:21Z","pushed_at":"2018-10-17T15:36:58Z","git_url":"git://github.com/innogames/openfl.git","ssh_url":"git@github.com:innogames/openfl.git","clone_url":"https://github.com/innogames/openfl.git","svn_url":"https://github.com/innogames/openfl","homepage":"http://www.openfl.org","size":19986,"stargazers_count":4,"watchers_count":4,"language":"Haxe","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":4,"default_branch":"develop"}},"base":{"label":"innogames:develop","ref":"develop","sha":"9efcebdc224cbf576ff6545a21c049433a5be76d","user":{"login":"innogames","id":1314968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTQ5Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1314968?v=4","gravatar_id":"","url":"https://api.github.com/users/innogames","html_url":"https://github.com/innogames","followers_url":"https://api.github.com/users/innogames/followers","following_url":"https://api.github.com/users/innogames/following{/other_user}","gists_url":"https://api.github.com/users/innogames/gists{/gist_id}","starred_url":"https://api.github.com/users/innogames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/innogames/subscriptions","organizations_url":"https://api.github.com/users/innogames/orgs","repos_url":"https://api.github.com/users/innogames/repos","events_url":"https://api.github.com/users/innogames/events{/privacy}","received_events_url":"https://api.github.com/users/innogames/received_events","type":"Organization","site_admin":false},"repo":{"id":88423138,"node_id":"MDEwOlJlcG9zaXRvcnk4ODQyMzEzOA==","name":"openfl","full_name":"innogames/openfl","private":false,"owner":{"login":"innogames","id":1314968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTQ5Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1314968?v=4","gravatar_id":"","url":"https://api.github.com/users/innogames","html_url":"https://github.com/innogames","followers_url":"https://api.github.com/users/innogames/followers","following_url":"https://api.github.com/users/innogames/following{/other_user}","gists_url":"https://api.github.com/users/innogames/gists{/gist_id}","starred_url":"https://api.github.com/users/innogames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/innogames/subscriptions","organizations_url":"https://api.github.com/users/innogames/orgs","repos_url":"https://api.github.com/users/innogames/repos","events_url":"https://api.github.com/users/innogames/events{/privacy}","received_events_url":"https://api.github.com/users/innogames/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/innogames/openfl","description":"The \"Open Flash Library\" for fast 2D development","fork":true,"url":"https://api.github.com/repos/innogames/openfl","forks_url":"https://api.github.com/repos/innogames/openfl/forks","keys_url":"https://api.github.com/repos/innogames/openfl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/innogames/openfl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/innogames/openfl/teams","hooks_url":"https://api.github.com/repos/innogames/openfl/hooks","issue_events_url":"https://api.github.com/repos/innogames/openfl/issues/events{/number}","events_url":"https://api.github.com/repos/innogames/openfl/events","assignees_url":"https://api.github.com/repos/innogames/openfl/assignees{/user}","branches_url":"https://api.github.com/repos/innogames/openfl/branches{/branch}","tags_url":"https://api.github.com/repos/innogames/openfl/tags","blobs_url":"https://api.github.com/repos/innogames/openfl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/innogames/openfl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/innogames/openfl/git/refs{/sha}","trees_url":"https://api.github.com/repos/innogames/openfl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/innogames/openfl/statuses/{sha}","languages_url":"https://api.github.com/repos/innogames/openfl/languages","stargazers_url":"https://api.github.com/repos/innogames/openfl/stargazers","contributors_url":"https://api.github.com/repos/innogames/openfl/contributors","subscribers_url":"https://api.github.com/repos/innogames/openfl/subscribers","subscription_url":"https://api.github.com/repos/innogames/openfl/subscription","commits_url":"https://api.github.com/repos/innogames/openfl/commits{/sha}","git_commits_url":"https://api.github.com/repos/innogames/openfl/git/commits{/sha}","comments_url":"https://api.github.com/repos/innogames/openfl/comments{/number}","issue_comment_url":"https://api.github.com/repos/innogames/openfl/issues/comments{/number}","contents_url":"https://api.github.com/repos/innogames/openfl/contents/{+path}","compare_url":"https://api.github.com/repos/innogames/openfl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/innogames/openfl/merges","archive_url":"https://api.github.com/repos/innogames/openfl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/innogames/openfl/downloads","issues_url":"https://api.github.com/repos/innogames/openfl/issues{/number}","pulls_url":"https://api.github.com/repos/innogames/openfl/pulls{/number}","milestones_url":"https://api.github.com/repos/innogames/openfl/milestones{/number}","notifications_url":"https://api.github.com/repos/innogames/openfl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/innogames/openfl/labels{/name}","releases_url":"https://api.github.com/repos/innogames/openfl/releases{/id}","deployments_url":"https://api.github.com/repos/innogames/openfl/deployments","created_at":"2017-04-16T15:36:14Z","updated_at":"2018-10-16T11:37:21Z","pushed_at":"2018-10-17T15:36:58Z","git_url":"git://github.com/innogames/openfl.git","ssh_url":"git@github.com:innogames/openfl.git","clone_url":"https://github.com/innogames/openfl.git","svn_url":"https://github.com/innogames/openfl","homepage":"http://www.openfl.org","size":19986,"stargazers_count":4,"watchers_count":4,"language":"Haxe","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/innogames/openfl/pulls/81"},"html":{"href":"https://github.com/innogames/openfl/pull/81"},"issue":{"href":"https://api.github.com/repos/innogames/openfl/issues/81"},"comments":{"href":"https://api.github.com/repos/innogames/openfl/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/innogames/openfl/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/innogames/openfl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/innogames/openfl/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/innogames/openfl/statuses/b730dfd844ca7bb7ebcbac3243fda2ab905e61da"}},"author_association":"NONE"}}
{"actor":{"display_login":"nadako"}}