{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/198014685","pull_request_review_id":131865843,"id":198014685,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODAxNDY4NQ==","diff_hunk":"@@ -0,0 +1,515 @@\n+// Copyright 2016 The Rust Project Developers. See the COPYRIGHT\n+// file at the top-level directory of this distribution and at\n+// http://rust-lang.org/COPYRIGHT.\n+//\n+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or\n+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license\n+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your\n+// option. This file may not be copied, modified, or distributed\n+// except according to those terms.\n+\n+#![unstable(feature = \"unix_socket_redox\", reason = \"new feature\", issue=\"51553\")]\n+\n+//! Unix-specific networking functionality\n+\n+use fmt;\n+use io::{self, Error, ErrorKind, Initializer};\n+use net::Shutdown;\n+use os::unix::io::{RawFd, AsRawFd, FromRawFd, IntoRawFd};\n+use path::Path;\n+use time::Duration;\n+use sys::{cvt, fd::FileDesc, syscall};\n+\n+/// An address associated with a Unix socket.\n+///\n+/// # Examples\n+///\n+/// ```\n+/// use std::os::unix::net::UnixListener;","path":"src/libstd/sys/redox/ext/net.rs","position":28,"original_position":28,"commit_id":"21d09b983de87fec2e98832f4c30b52f12d6342f","original_commit_id":"21d09b983de87fec2e98832f4c30b52f12d6342f","user":{"login":"sfackler","id":1455697,"node_id":"MDQ6VXNlcjE0NTU2OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1455697?v=4","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"body":"Redox is considered a unix?","created_at":"2018-06-26T05:06:37Z","updated_at":"2018-06-26T05:06:38Z","html_url":"https://github.com/rust-lang/rust/pull/51553#discussion_r198014685","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/51553","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/198014685"},"html":{"href":"https://github.com/rust-lang/rust/pull/51553#discussion_r198014685"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/51553"}},"in_reply_to_id":197814267},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/51553","id":194904841,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0OTA0ODQx","html_url":"https://github.com/rust-lang/rust/pull/51553","diff_url":"https://github.com/rust-lang/rust/pull/51553.diff","patch_url":"https://github.com/rust-lang/rust/pull/51553.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/51553","number":51553,"state":"open","locked":false,"title":"Unix sockets on redox","user":{"login":"jD91mZM2","id":12830969,"node_id":"MDQ6VXNlcjEyODMwOTY5","avatar_url":"https://avatars0.githubusercontent.com/u/12830969?v=4","gravatar_id":"","url":"https://api.github.com/users/jD91mZM2","html_url":"https://github.com/jD91mZM2","followers_url":"https://api.github.com/users/jD91mZM2/followers","following_url":"https://api.github.com/users/jD91mZM2/following{/other_user}","gists_url":"https://api.github.com/users/jD91mZM2/gists{/gist_id}","starred_url":"https://api.github.com/users/jD91mZM2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jD91mZM2/subscriptions","organizations_url":"https://api.github.com/users/jD91mZM2/orgs","repos_url":"https://api.github.com/users/jD91mZM2/repos","events_url":"https://api.github.com/users/jD91mZM2/events{/privacy}","received_events_url":"https://api.github.com/users/jD91mZM2/received_events","type":"User","site_admin":false},"body":"This is done using the ipcd daemon. It's not exactly like unix sockets because there is not actually a physical file for the path, but it's close enough for a basic implementation :)\r\nThis allows mio-uds and tokio-uds to work with a few modifications as well, which is exciting!","created_at":"2018-06-14T14:03:44Z","updated_at":"2018-06-26T05:06:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a3d53cb71fa6fb2e1ceeaa0edacdfbe6e8908c6","assignee":{"login":"sfackler","id":1455697,"node_id":"MDQ6VXNlcjE0NTU2OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1455697?v=4","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"assignees":[{"login":"sfackler","id":1455697,"node_id":"MDQ6VXNlcjE0NTU2OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1455697?v=4","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/51553/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/51553/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/51553/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/21d09b983de87fec2e98832f4c30b52f12d6342f","head":{"label":"jD91mZM2:uds","ref":"uds","sha":"21d09b983de87fec2e98832f4c30b52f12d6342f","user":{"login":"jD91mZM2","id":12830969,"node_id":"MDQ6VXNlcjEyODMwOTY5","avatar_url":"https://avatars0.githubusercontent.com/u/12830969?v=4","gravatar_id":"","url":"https://api.github.com/users/jD91mZM2","html_url":"https://github.com/jD91mZM2","followers_url":"https://api.github.com/users/jD91mZM2/followers","following_url":"https://api.github.com/users/jD91mZM2/following{/other_user}","gists_url":"https://api.github.com/users/jD91mZM2/gists{/gist_id}","starred_url":"https://api.github.com/users/jD91mZM2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jD91mZM2/subscriptions","organizations_url":"https://api.github.com/users/jD91mZM2/orgs","repos_url":"https://api.github.com/users/jD91mZM2/repos","events_url":"https://api.github.com/users/jD91mZM2/events{/privacy}","received_events_url":"https://api.github.com/users/jD91mZM2/received_events","type":"User","site_admin":false},"repo":{"id":137365165,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczNjUxNjU=","name":"rust","full_name":"jD91mZM2/rust","owner":{"login":"jD91mZM2","id":12830969,"node_id":"MDQ6VXNlcjEyODMwOTY5","avatar_url":"https://avatars0.githubusercontent.com/u/12830969?v=4","gravatar_id":"","url":"https://api.github.com/users/jD91mZM2","html_url":"https://github.com/jD91mZM2","followers_url":"https://api.github.com/users/jD91mZM2/followers","following_url":"https://api.github.com/users/jD91mZM2/following{/other_user}","gists_url":"https://api.github.com/users/jD91mZM2/gists{/gist_id}","starred_url":"https://api.github.com/users/jD91mZM2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jD91mZM2/subscriptions","organizations_url":"https://api.github.com/users/jD91mZM2/orgs","repos_url":"https://api.github.com/users/jD91mZM2/repos","events_url":"https://api.github.com/users/jD91mZM2/events{/privacy}","received_events_url":"https://api.github.com/users/jD91mZM2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jD91mZM2/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/jD91mZM2/rust","forks_url":"https://api.github.com/repos/jD91mZM2/rust/forks","keys_url":"https://api.github.com/repos/jD91mZM2/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jD91mZM2/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jD91mZM2/rust/teams","hooks_url":"https://api.github.com/repos/jD91mZM2/rust/hooks","issue_events_url":"https://api.github.com/repos/jD91mZM2/rust/issues/events{/number}","events_url":"https://api.github.com/repos/jD91mZM2/rust/events","assignees_url":"https://api.github.com/repos/jD91mZM2/rust/assignees{/user}","branches_url":"https://api.github.com/repos/jD91mZM2/rust/branches{/branch}","tags_url":"https://api.github.com/repos/jD91mZM2/rust/tags","blobs_url":"https://api.github.com/repos/jD91mZM2/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jD91mZM2/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jD91mZM2/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/jD91mZM2/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jD91mZM2/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/jD91mZM2/rust/languages","stargazers_url":"https://api.github.com/repos/jD91mZM2/rust/stargazers","contributors_url":"https://api.github.com/repos/jD91mZM2/rust/contributors","subscribers_url":"https://api.github.com/repos/jD91mZM2/rust/subscribers","subscription_url":"https://api.github.com/repos/jD91mZM2/rust/subscription","commits_url":"https://api.github.com/repos/jD91mZM2/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/jD91mZM2/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/jD91mZM2/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/jD91mZM2/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/jD91mZM2/rust/contents/{+path}","compare_url":"https://api.github.com/repos/jD91mZM2/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jD91mZM2/rust/merges","archive_url":"https://api.github.com/repos/jD91mZM2/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jD91mZM2/rust/downloads","issues_url":"https://api.github.com/repos/jD91mZM2/rust/issues{/number}","pulls_url":"https://api.github.com/repos/jD91mZM2/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/jD91mZM2/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/jD91mZM2/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jD91mZM2/rust/labels{/name}","releases_url":"https://api.github.com/repos/jD91mZM2/rust/releases{/id}","deployments_url":"https://api.github.com/repos/jD91mZM2/rust/deployments","created_at":"2018-06-14T13:56:30Z","updated_at":"2018-06-14T13:57:00Z","pushed_at":"2018-06-18T05:23:57Z","git_url":"git://github.com/jD91mZM2/rust.git","ssh_url":"git@github.com:jD91mZM2/rust.git","clone_url":"https://github.com/jD91mZM2/rust.git","svn_url":"https://github.com/jD91mZM2/rust","homepage":"https://www.rust-lang.org","size":374435,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"5205ae8bdc2991eecf3bfbb58ed8f56c0673e738","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-06-26T04:27:07Z","pushed_at":"2018-06-26T04:29:10Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":375815,"stargazers_count":28983,"watchers_count":28983,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5006,"mirror_url":null,"archived":false,"open_issues_count":3938,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5006,"open_issues":3938,"watchers":28983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/51553"},"html":{"href":"https://github.com/rust-lang/rust/pull/51553"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/51553"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/51553/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/51553/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/51553/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/21d09b983de87fec2e98832f4c30b52f12d6342f"}},"author_association":"NONE"}}
{"actor":{"display_login":"sfackler"}}