{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1595","repository_url":"https://api.github.com/repos/ipfs/js-ipfs","labels_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1595/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1595/comments","events_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1595/events","html_url":"https://github.com/ipfs/js-ipfs/pull/1595","id":364403466,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NTk4NjE4","number":1595,"title":"feat: show Web UI url in daemon output","user":{"login":"olizilla","id":58871,"node_id":"MDQ6VXNlcjU4ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/58871?v=4","gravatar_id":"","url":"https://api.github.com/users/olizilla","html_url":"https://github.com/olizilla","followers_url":"https://api.github.com/users/olizilla/followers","following_url":"https://api.github.com/users/olizilla/following{/other_user}","gists_url":"https://api.github.com/users/olizilla/gists{/gist_id}","starred_url":"https://api.github.com/users/olizilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olizilla/subscriptions","organizations_url":"https://api.github.com/users/olizilla/orgs","repos_url":"https://api.github.com/users/olizilla/repos","events_url":"https://api.github.com/users/olizilla/events{/privacy}","received_events_url":"https://api.github.com/users/olizilla/received_events","type":"User","site_admin":false},"labels":[{"id":259619775,"node_id":"MDU6TGFiZWwyNTk2MTk3NzU=","url":"https://api.github.com/repos/ipfs/js-ipfs/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"olizilla","id":58871,"node_id":"MDQ6VXNlcjU4ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/58871?v=4","gravatar_id":"","url":"https://api.github.com/users/olizilla","html_url":"https://github.com/olizilla","followers_url":"https://api.github.com/users/olizilla/followers","following_url":"https://api.github.com/users/olizilla/following{/other_user}","gists_url":"https://api.github.com/users/olizilla/gists{/gist_id}","starred_url":"https://api.github.com/users/olizilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olizilla/subscriptions","organizations_url":"https://api.github.com/users/olizilla/orgs","repos_url":"https://api.github.com/users/olizilla/repos","events_url":"https://api.github.com/users/olizilla/events{/privacy}","received_events_url":"https://api.github.com/users/olizilla/received_events","type":"User","site_admin":false},"assignees":[{"login":"olizilla","id":58871,"node_id":"MDQ6VXNlcjU4ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/58871?v=4","gravatar_id":"","url":"https://api.github.com/users/olizilla","html_url":"https://github.com/olizilla","followers_url":"https://api.github.com/users/olizilla/followers","following_url":"https://api.github.com/users/olizilla/following{/other_user}","gists_url":"https://api.github.com/users/olizilla/gists{/gist_id}","starred_url":"https://api.github.com/users/olizilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olizilla/subscriptions","organizations_url":"https://api.github.com/users/olizilla/orgs","repos_url":"https://api.github.com/users/olizilla/repos","events_url":"https://api.github.com/users/olizilla/events{/privacy}","received_events_url":"https://api.github.com/users/olizilla/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-09-27T10:19:35Z","updated_at":"2018-09-27T16:32:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1595","html_url":"https://github.com/ipfs/js-ipfs/pull/1595","diff_url":"https://github.com/ipfs/js-ipfs/pull/1595.diff","patch_url":"https://github.com/ipfs/js-ipfs/pull/1595.patch"},"body":"- make it easier for people to discover the Web UI\r\n- tidy up inconsistencies across the log lines\r\n- add IPFS to the first line. confirm to new users they started what they expected to.\r\n\r\nfixes https://github.com/ipfs-shipyard/ipfs-webui/issues/815\r\n\r\n**Before**\r\n```console\r\n$ jsipfs daemon\r\nInitializing daemon...\r\nSwarm listening on /ip4/127.0.0.1/tcp/4003/ws/ipfs/QmPmrqh4ybdUJwGchEecuj2GBXCxKL5iapW9qmk8pwgCGs\r\nSwarm listening on /ip4/127.0.0.1/tcp/4002/ipfs/QmPmrqh4ybdUJwGchEecuj2GBXCxKL5iapW9qmk8pwgCGs\r\nSwarm listening on /ip4/192.168.1.244/tcp/4002/ipfs/QmPmrqh4ybdUJwGchEecuj2GBXCxKL5iapW9qmk8pwgCGs\r\nAPI is listening on: /ip4/127.0.0.1/tcp/5002\r\nGateway (readonly) is listening on: /ip4/127.0.0.1/tcp/9090\r\nDaemon is ready\r\n```\r\n\r\n**After**\r\n```console\r\n$ node src/cli/bin.js daemon\r\nInitializing IPFS daemon...\r\nSwarm listening on /ip4/127.0.0.1/tcp/4003/ws/ipfs/QmPmrqh4ybdUJwGchEecuj2GBXCxKL5iapW9qmk8pwgCGs\r\nSwarm listening on /ip4/127.0.0.1/tcp/4002/ipfs/QmPmrqh4ybdUJwGchEecuj2GBXCxKL5iapW9qmk8pwgCGs\r\nSwarm listening on /ip4/192.168.1.244/tcp/4002/ipfs/QmPmrqh4ybdUJwGchEecuj2GBXCxKL5iapW9qmk8pwgCGs\r\nAPI listening on /ip4/127.0.0.1/tcp/5002\r\nGateway (read only) listening on /ip4/127.0.0.1/tcp/9090\r\nWeb UI available at http://127.0.0.1:5002/webui\r\nDaemon is ready\r\n```\r\n- Announces the Web UI 🎉\r\n- No colons, simply siding with what most of the log lines do currently\r\n- Use \"listening on\" consistently rather than \"**is** listening on\"\r\n- Use \"read only\" not \"readonly\"\r\n- Initializing **IPFS** daemon... to confirm to the user they started the thing they expected.\r\n\r\nI'd keep the \"Daemon is ready\" copy the same though as it's the kind of output that people might be scraping from scripts to check that it started without error, and changing it would frustrate.\r\n\r\nLicense: MIT\r\nSigned-off-by: Oli Evans <oli@tableflip.io>"},"comment":{"url":"https://api.github.com/repos/ipfs/js-ipfs/issues/comments/425158748","html_url":"https://github.com/ipfs/js-ipfs/pull/1595#issuecomment-425158748","issue_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1595","id":425158748,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTE1ODc0OA==","user":{"login":"olizilla","id":58871,"node_id":"MDQ6VXNlcjU4ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/58871?v=4","gravatar_id":"","url":"https://api.github.com/users/olizilla","html_url":"https://github.com/olizilla","followers_url":"https://api.github.com/users/olizilla/followers","following_url":"https://api.github.com/users/olizilla/following{/other_user}","gists_url":"https://api.github.com/users/olizilla/gists{/gist_id}","starred_url":"https://api.github.com/users/olizilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olizilla/subscriptions","organizations_url":"https://api.github.com/users/olizilla/orgs","repos_url":"https://api.github.com/users/olizilla/repos","events_url":"https://api.github.com/users/olizilla/events{/privacy}","received_events_url":"https://api.github.com/users/olizilla/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T16:32:12Z","updated_at":"2018-09-27T16:32:12Z","author_association":"MEMBER","body":"@alanshaw the alignment isn't like when people create work for everyone by aligning their variable declarations; in this case it's more like we're showing tabular data (or at least a definition list) so lets give it a table-like layout for readability.\r\n\r\nYou will get a PR with a CID for the new Web UI when we fix all the issues you raised 😜"}}
{"actor":{"display_login":"olizilla"}}