{"action":"created","comment":{"url":"https://api.github.com/repos/gradle/gradle/pulls/comments/203276786","pull_request_review_id":138131877,"id":203276786,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzI3Njc4Ng==","diff_hunk":"@@ -115,69 +109,12 @@ outputs.docs = files(docsDir) {\n     builtBy 'javadocAll', 'userguide', 'dslHtml', 'releaseNotes'\n }\n \n-tasks.withType(CacheableAsciidoctorTask).configureEach {\n-    backends = ['docbook']\n-\n-    separateOutputDirs = false\n-    options doctype: 'book'\n-    inputs.file asciidocSanitizeStylesheet withPropertyName \"sanitizerStylesheet\" withPathSensitivity PathSensitivity.NONE\n-\n-    extensions {\n-        inlinemacro (name: \"api\") {\n-            parent, target, attributes ->\n-            def (className, method) = target.split('#', 2) as List\n-            def content = \"<apilink class=\\\"$className\\\"\"\n-            if (method) {\n-                // Add space after comma, because we can't have spaces in api: targets\n-                // Restore Asciidoc's '&hellip;&zwsp;' replacement to the original '...'\n-                content += \" method=\\\"${method.replaceAll(/,\\s*/, ', ').replaceAll(/\\&#8230;\\&#8203;/, '...')}\\\"\"\n-            }\n-            content += \" />\"\n-            return content\n-        }\n-    }\n-\n-    attributes 'source-highlighter': 'prettify',\n-               website: 'http://www.gradle.org',\n-               javaApi: 'https://docs.oracle.com/javase/7/docs/api',\n-               antManual: 'https://ant.apache.org/manual',\n-               gradleVersion: version\n-\n-    doLast {\n-        outputDir.eachFileMatch(~/.*.xml/) { File file ->\n-            def contents = file.getText(\"utf-8\")\n-            try {\n-                def transformer = TransformerFactory.newInstance().newTransformer(new StreamSource(asciidocSanitizeStylesheet))\n-                transformer.transform(new StreamSource(new StringReader(contents)), new StreamResult(file))\n-            } catch (Exception ex) {\n-                throw new RuntimeException(\"Couldn't process $file:\\n\" + contents, ex)\n-            }\n-        }\n-    }\n-}\n-\n tasks.withType(Docbook2Xhtml).configureEach {\n     dependsOn userguideStyleSheets\n     classpath = configurations.userGuideTask\n     stylesheetsDir = userguideStyleSheets.destinationDir\n }","path":"subprojects/docs/docs.gradle","position":106,"original_position":106,"commit_id":"1a51e5aa617da6792f53be2b642c5db76adbf658","original_commit_id":"1a51e5aa617da6792f53be2b642c5db76adbf658","user":{"login":"pledbrook","id":19075,"node_id":"MDQ6VXNlcjE5MDc1","avatar_url":"https://avatars2.githubusercontent.com/u/19075?v=4","gravatar_id":"","url":"https://api.github.com/users/pledbrook","html_url":"https://github.com/pledbrook","followers_url":"https://api.github.com/users/pledbrook/followers","following_url":"https://api.github.com/users/pledbrook/following{/other_user}","gists_url":"https://api.github.com/users/pledbrook/gists{/gist_id}","starred_url":"https://api.github.com/users/pledbrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pledbrook/subscriptions","organizations_url":"https://api.github.com/users/pledbrook/orgs","repos_url":"https://api.github.com/users/pledbrook/repos","events_url":"https://api.github.com/users/pledbrook/events{/privacy}","received_events_url":"https://api.github.com/users/pledbrook/received_events","type":"User","site_admin":false},"body":"Is this still needed?","created_at":"2018-07-18T07:31:39Z","updated_at":"2018-07-18T07:41:41Z","html_url":"https://github.com/gradle/gradle/pull/6006#discussion_r203276786","pull_request_url":"https://api.github.com/repos/gradle/gradle/pulls/6006","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments/203276786"},"html":{"href":"https://github.com/gradle/gradle/pull/6006#discussion_r203276786"},"pull_request":{"href":"https://api.github.com/repos/gradle/gradle/pulls/6006"}}},"pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/6006","id":202105957,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTA1OTU3","html_url":"https://github.com/gradle/gradle/pull/6006","diff_url":"https://github.com/gradle/gradle/pull/6006.diff","patch_url":"https://github.com/gradle/gradle/pull/6006.patch","issue_url":"https://api.github.com/repos/gradle/gradle/issues/6006","number":6006,"state":"open","locked":false,"title":"[DO NOT MERGE] Convert user manual to be generated by Asciidoctor only","user":{"login":"eriwen","id":51534,"node_id":"MDQ6VXNlcjUxNTM0","avatar_url":"https://avatars2.githubusercontent.com/u/51534?v=4","gravatar_id":"","url":"https://api.github.com/users/eriwen","html_url":"https://github.com/eriwen","followers_url":"https://api.github.com/users/eriwen/followers","following_url":"https://api.github.com/users/eriwen/following{/other_user}","gists_url":"https://api.github.com/users/eriwen/gists{/gist_id}","starred_url":"https://api.github.com/users/eriwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriwen/subscriptions","organizations_url":"https://api.github.com/users/eriwen/orgs","repos_url":"https://api.github.com/users/eriwen/repos","events_url":"https://api.github.com/users/eriwen/events{/privacy}","received_events_url":"https://api.github.com/users/eriwen/received_events","type":"User","site_admin":false},"body":"This allows a single page HTML and PDF user manual to be\r\ngenerated via asciidoctor, and includes what's necessary to\r\nconvert the user manual totally to asciidoctor syntax.\r\n\r\nSee also #5837\r\n\r\nThis cannot be merged to master without other PRs that actually convert the docbook stuff to asciidoc included. The intent is to review this automation separately.\r\n\r\nHere's what one can to test now, though:\r\n\r\n`./gradlew :docs:userguide` then open `subprojects/docs/build/userguidePdf/userguide_single.pdf`. This should show you the asciidoctor infrastructure working, however, the samples will be missing. Same for `userguide_single.html`.\r\n\r\n### Context\r\n<!--- Why do you believe many users will benefit from this change? -->\r\n<!--- Link to relevant issues or forum discussions here -->\r\n\r\n### Gradle Core Team Checklist\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation\r\n- [ ] Recognize contributor in release notes\r\n","created_at":"2018-07-18T00:04:09Z","updated_at":"2018-07-18T07:41:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75a0df719ea651a402dc7d1030c8ef1df1f09f7d","assignee":{"login":"eriwen","id":51534,"node_id":"MDQ6VXNlcjUxNTM0","avatar_url":"https://avatars2.githubusercontent.com/u/51534?v=4","gravatar_id":"","url":"https://api.github.com/users/eriwen","html_url":"https://github.com/eriwen","followers_url":"https://api.github.com/users/eriwen/followers","following_url":"https://api.github.com/users/eriwen/following{/other_user}","gists_url":"https://api.github.com/users/eriwen/gists{/gist_id}","starred_url":"https://api.github.com/users/eriwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriwen/subscriptions","organizations_url":"https://api.github.com/users/eriwen/orgs","repos_url":"https://api.github.com/users/eriwen/repos","events_url":"https://api.github.com/users/eriwen/events{/privacy}","received_events_url":"https://api.github.com/users/eriwen/received_events","type":"User","site_admin":false},"assignees":[{"login":"eriwen","id":51534,"node_id":"MDQ6VXNlcjUxNTM0","avatar_url":"https://avatars2.githubusercontent.com/u/51534?v=4","gravatar_id":"","url":"https://api.github.com/users/eriwen","html_url":"https://github.com/eriwen","followers_url":"https://api.github.com/users/eriwen/followers","following_url":"https://api.github.com/users/eriwen/following{/other_user}","gists_url":"https://api.github.com/users/eriwen/gists{/gist_id}","starred_url":"https://api.github.com/users/eriwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriwen/subscriptions","organizations_url":"https://api.github.com/users/eriwen/orgs","repos_url":"https://api.github.com/users/eriwen/repos","events_url":"https://api.github.com/users/eriwen/events{/privacy}","received_events_url":"https://api.github.com/users/eriwen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":289469033,"node_id":"MDU6TGFiZWwyODk0NjkwMzM=","url":"https://api.github.com/repos/gradle/gradle/labels/from:member","name":"from:member","color":"0052cc","default":false},{"id":290482145,"node_id":"MDU6TGFiZWwyOTA0ODIxNDU=","url":"https://api.github.com/repos/gradle/gradle/labels/in:docs","name":"in:docs","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/gradle/gradle/milestones/73","html_url":"https://github.com/gradle/gradle/milestone/73","labels_url":"https://api.github.com/repos/gradle/gradle/milestones/73/labels","id":3382823,"node_id":"MDk6TWlsZXN0b25lMzM4MjgyMw==","number":73,"title":"4.10 RC1","description":"","creator":{"login":"oehme","id":1191797,"node_id":"MDQ6VXNlcjExOTE3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1191797?v=4","gravatar_id":"","url":"https://api.github.com/users/oehme","html_url":"https://github.com/oehme","followers_url":"https://api.github.com/users/oehme/followers","following_url":"https://api.github.com/users/oehme/following{/other_user}","gists_url":"https://api.github.com/users/oehme/gists{/gist_id}","starred_url":"https://api.github.com/users/oehme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oehme/subscriptions","organizations_url":"https://api.github.com/users/oehme/orgs","repos_url":"https://api.github.com/users/oehme/repos","events_url":"https://api.github.com/users/oehme/events{/privacy}","received_events_url":"https://api.github.com/users/oehme/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":69,"state":"open","created_at":"2018-05-29T07:35:56Z","updated_at":"2018-07-18T00:04:09Z","due_on":"2018-08-06T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/gradle/gradle/pulls/6006/commits","review_comments_url":"https://api.github.com/repos/gradle/gradle/pulls/6006/comments","review_comment_url":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/6006/comments","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/1a51e5aa617da6792f53be2b642c5db76adbf658","head":{"label":"gradle:eriwen/docs/asciidoc-pdf-and-single-page-manual","ref":"eriwen/docs/asciidoc-pdf-and-single-page-manual","sha":"1a51e5aa617da6792f53be2b642c5db76adbf658","user":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"node_id":"MDEwOlJlcG9zaXRvcnkzMDIzMjI=","name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2018-07-18T05:51:08Z","pushed_at":"2018-07-18T06:14:25Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":220235,"stargazers_count":7131,"watchers_count":7131,"language":"Groovy","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2232,"mirror_url":null,"archived":false,"open_issues_count":1163,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2232,"open_issues":1163,"watchers":7131,"default_branch":"master"}},"base":{"label":"gradle:master","ref":"master","sha":"726b42a71de9519e0de56ae354d88ce581f073ca","user":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"node_id":"MDEwOlJlcG9zaXRvcnkzMDIzMjI=","name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2018-07-18T05:51:08Z","pushed_at":"2018-07-18T06:14:25Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":220235,"stargazers_count":7131,"watchers_count":7131,"language":"Groovy","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2232,"mirror_url":null,"archived":false,"open_issues_count":1163,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2232,"open_issues":1163,"watchers":7131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/6006"},"html":{"href":"https://github.com/gradle/gradle/pull/6006"},"issue":{"href":"https://api.github.com/repos/gradle/gradle/issues/6006"},"comments":{"href":"https://api.github.com/repos/gradle/gradle/issues/6006/comments"},"review_comments":{"href":"https://api.github.com/repos/gradle/gradle/pulls/6006/comments"},"review_comment":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gradle/gradle/pulls/6006/commits"},"statuses":{"href":"https://api.github.com/repos/gradle/gradle/statuses/1a51e5aa617da6792f53be2b642c5db76adbf658"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pledbrook"}}