{"action":"closed","number":3686,"pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/3686","id":188894373,"html_url":"https://github.com/learningequality/kolibri/pull/3686","diff_url":"https://github.com/learningequality/kolibri/pull/3686.diff","patch_url":"https://github.com/learningequality/kolibri/pull/3686.patch","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/3686","number":3686,"state":"closed","locked":false,"title":"Aligned user-dropdown with app bar","user":{"login":"HansGam","id":18543718,"avatar_url":"https://avatars3.githubusercontent.com/u/18543718?v=4","gravatar_id":"","url":"https://api.github.com/users/HansGam","html_url":"https://github.com/HansGam","followers_url":"https://api.github.com/users/HansGam/followers","following_url":"https://api.github.com/users/HansGam/following{/other_user}","gists_url":"https://api.github.com/users/HansGam/gists{/gist_id}","starred_url":"https://api.github.com/users/HansGam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansGam/subscriptions","organizations_url":"https://api.github.com/users/HansGam/orgs","repos_url":"https://api.github.com/users/HansGam/repos","events_url":"https://api.github.com/users/HansGam/events{/privacy}","received_events_url":"https://api.github.com/users/HansGam/received_events","type":"User","site_admin":false},"body":"<!--\r\n 1. Following guidance below, replace …'s with your own words\r\n 2. After saving the PR, tick of completed checklist items\r\n 3. Skip checklist items that are not applicable or not necessary\r\n 4. Delete instruction/comment blocks\r\n-->\r\n\r\n### Summary\r\n<!--\r\n * description of the change\r\n * manual verification steps performed\r\n * screenshots if the PR affects the UI\r\n-->\r\nBefore\r\n![beforealign](https://user-images.githubusercontent.com/18543718/40210061-c30dfb7a-59f7-11e8-8dc2-dab125c98769.png)\r\n\r\n\r\nAfter\r\n![afteralign](https://user-images.githubusercontent.com/18543718/40210060-c2cf0f50-59f7-11e8-864e-a0a9a6c46baf.jpg)\r\n\r\nEdit: This appears to have an effect on mobile devices (Screenshot taken on Samsung Galaxy S5)\r\n\r\nHere is the before effect:\r\n![mobilebefore](https://user-images.githubusercontent.com/18543718/40210229-989668d6-59f8-11e8-97e0-7cea8c5bc721.jpg)\r\n\r\nHere is the after effect:\r\n![mobileafter](https://user-images.githubusercontent.com/18543718/40210236-9f78c7d4-59f8-11e8-8159-7350c74258e5.jpg)\r\n\r\nIt is a bit subtle, however the search bar has moved down. These changes are from adding \"margin-top: 3px\" to the class \".search-bar\" in kolibri/plugins/learn/assets/src/views/search-box.vue\r\n\r\nUnsure how to change the search bar on desktop so it does not negatively affect the bar on mobile, advice would be appreciated. Thanks!\r\n…\r\n\r\n### Reviewer guidance\r\n<!--\r\n * how can a reviewer test these changes?\r\n * are there any risky areas that deserve extra testing\r\n-->\r\n-Sign in as a user\r\n-Hover over the user dropdown bar\r\n-It should be aligned with the search bar and also have a space (8px) separating them\r\n…\r\n\r\n### References\r\nSee #3639 \r\n<!--\r\n * references to related issues and PRs\r\n * links to mockups or specs for new features\r\n * links to the diffs for any dependency updates, e.g. in iceqube or the perseus plugin\r\n-->\r\n\r\n…\r\n\r\n----\r\n\r\n### Contributor Checklist\r\n\r\n- [x] Contributor has fully tested the PR manually\r\n- [ ] PR has the correct target branch and milestone\r\n- [ ] PR has 'needs review' or 'work-in-progress' label\r\n- [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')\r\n- [x] If there are any front-end changes, before/after screenshots are included\r\n- [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label\r\n\r\n### Reviewer Checklist\r\n\r\n- [ ] Automated test coverage is satisfactory\r\n- [ ] Reviewer has fully tested the PR manually\r\n- [ ] PR has been tested for [accessibility regressions](http://kolibri-dev.readthedocs.io/en/develop/manual_testing.html#accessibility-a11y-testing)\r\n- [ ] External dependencies files were updated (`yarn` and `pip`)\r\n- [ ] Documentation is updated\r\n- [ ] Link to diff of internal dependency change is included\r\n- [ ] CHANGELOG.rst is updated for high-level changes\r\n- [ ] Contributor is in AUTHORS.rst\r\n","created_at":"2018-05-18T00:29:19Z","updated_at":"2018-05-25T20:57:42Z","closed_at":"2018-05-25T20:57:42Z","merged_at":"2018-05-25T20:57:41Z","merge_commit_sha":"395928c206c4c750de9fddcacdd8ca040c3014ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":410338552,"url":"https://api.github.com/repos/learningequality/kolibri/labels/PR:%20needs%20review","name":"PR: needs review","color":"1f6ad6","default":false}],"milestone":{"url":"https://api.github.com/repos/learningequality/kolibri/milestones/18","html_url":"https://github.com/learningequality/kolibri/milestone/18","labels_url":"https://api.github.com/repos/learningequality/kolibri/milestones/18/labels","id":3097289,"number":18,"title":"0.10.0","description":"","creator":{"login":"indirectlylit","id":2367265,"avatar_url":"https://avatars2.githubusercontent.com/u/2367265?v=4","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":81,"state":"open","created_at":"2018-02-07T17:08:38Z","updated_at":"2018-05-25T20:57:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/learningequality/kolibri/pulls/3686/commits","review_comments_url":"https://api.github.com/repos/learningequality/kolibri/pulls/3686/comments","review_comment_url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/3686/comments","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/0286718a26577a8d79841624648a2047b54d5b78","head":{"label":"HansGam:alignment","ref":"alignment","sha":"0286718a26577a8d79841624648a2047b54d5b78","user":{"login":"HansGam","id":18543718,"avatar_url":"https://avatars3.githubusercontent.com/u/18543718?v=4","gravatar_id":"","url":"https://api.github.com/users/HansGam","html_url":"https://github.com/HansGam","followers_url":"https://api.github.com/users/HansGam/followers","following_url":"https://api.github.com/users/HansGam/following{/other_user}","gists_url":"https://api.github.com/users/HansGam/gists{/gist_id}","starred_url":"https://api.github.com/users/HansGam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansGam/subscriptions","organizations_url":"https://api.github.com/users/HansGam/orgs","repos_url":"https://api.github.com/users/HansGam/repos","events_url":"https://api.github.com/users/HansGam/events{/privacy}","received_events_url":"https://api.github.com/users/HansGam/received_events","type":"User","site_admin":false},"repo":{"id":121699071,"name":"kolibri","full_name":"HansGam/kolibri","owner":{"login":"HansGam","id":18543718,"avatar_url":"https://avatars3.githubusercontent.com/u/18543718?v=4","gravatar_id":"","url":"https://api.github.com/users/HansGam","html_url":"https://github.com/HansGam","followers_url":"https://api.github.com/users/HansGam/followers","following_url":"https://api.github.com/users/HansGam/following{/other_user}","gists_url":"https://api.github.com/users/HansGam/gists{/gist_id}","starred_url":"https://api.github.com/users/HansGam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansGam/subscriptions","organizations_url":"https://api.github.com/users/HansGam/orgs","repos_url":"https://api.github.com/users/HansGam/repos","events_url":"https://api.github.com/users/HansGam/events{/privacy}","received_events_url":"https://api.github.com/users/HansGam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HansGam/kolibri","description":"Kolibri: the offline app for universal education","fork":true,"url":"https://api.github.com/repos/HansGam/kolibri","forks_url":"https://api.github.com/repos/HansGam/kolibri/forks","keys_url":"https://api.github.com/repos/HansGam/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HansGam/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HansGam/kolibri/teams","hooks_url":"https://api.github.com/repos/HansGam/kolibri/hooks","issue_events_url":"https://api.github.com/repos/HansGam/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/HansGam/kolibri/events","assignees_url":"https://api.github.com/repos/HansGam/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/HansGam/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/HansGam/kolibri/tags","blobs_url":"https://api.github.com/repos/HansGam/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HansGam/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HansGam/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/HansGam/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HansGam/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/HansGam/kolibri/languages","stargazers_url":"https://api.github.com/repos/HansGam/kolibri/stargazers","contributors_url":"https://api.github.com/repos/HansGam/kolibri/contributors","subscribers_url":"https://api.github.com/repos/HansGam/kolibri/subscribers","subscription_url":"https://api.github.com/repos/HansGam/kolibri/subscription","commits_url":"https://api.github.com/repos/HansGam/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/HansGam/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/HansGam/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/HansGam/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/HansGam/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/HansGam/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HansGam/kolibri/merges","archive_url":"https://api.github.com/repos/HansGam/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HansGam/kolibri/downloads","issues_url":"https://api.github.com/repos/HansGam/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/HansGam/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/HansGam/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/HansGam/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HansGam/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/HansGam/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/HansGam/kolibri/deployments","created_at":"2018-02-16T00:14:42Z","updated_at":"2018-02-16T00:14:46Z","pushed_at":"2018-05-25T17:50:29Z","git_url":"git://github.com/HansGam/kolibri.git","ssh_url":"git@github.com:HansGam/kolibri.git","clone_url":"https://github.com/HansGam/kolibri.git","svn_url":"https://github.com/HansGam/kolibri","homepage":"http://learningequality.org/kolibri/","size":37838,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"learningequality:develop","ref":"develop","sha":"c97c3ff064f8b47c92dbb30964b09960c91ea3ff","user":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":49976939,"name":"kolibri","full_name":"learningequality/kolibri","owner":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/kolibri","description":"Kolibri: the offline app for universal education","fork":false,"url":"https://api.github.com/repos/learningequality/kolibri","forks_url":"https://api.github.com/repos/learningequality/kolibri/forks","keys_url":"https://api.github.com/repos/learningequality/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/kolibri/teams","hooks_url":"https://api.github.com/repos/learningequality/kolibri/hooks","issue_events_url":"https://api.github.com/repos/learningequality/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/kolibri/events","assignees_url":"https://api.github.com/repos/learningequality/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/kolibri/tags","blobs_url":"https://api.github.com/repos/learningequality/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/kolibri/languages","stargazers_url":"https://api.github.com/repos/learningequality/kolibri/stargazers","contributors_url":"https://api.github.com/repos/learningequality/kolibri/contributors","subscribers_url":"https://api.github.com/repos/learningequality/kolibri/subscribers","subscription_url":"https://api.github.com/repos/learningequality/kolibri/subscription","commits_url":"https://api.github.com/repos/learningequality/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/learningequality/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/kolibri/merges","archive_url":"https://api.github.com/repos/learningequality/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/kolibri/downloads","issues_url":"https://api.github.com/repos/learningequality/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/learningequality/kolibri/deployments","created_at":"2016-01-19T19:22:07Z","updated_at":"2018-05-25T17:21:10Z","pushed_at":"2018-05-25T20:57:41Z","git_url":"git://github.com/learningequality/kolibri.git","ssh_url":"git@github.com:learningequality/kolibri.git","clone_url":"https://github.com/learningequality/kolibri.git","svn_url":"https://github.com/learningequality/kolibri","homepage":"http://learningequality.org/kolibri/","size":37914,"stargazers_count":167,"watchers_count":167,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"archived":false,"open_issues_count":261,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":130,"open_issues":261,"watchers":167,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3686"},"html":{"href":"https://github.com/learningequality/kolibri/pull/3686"},"issue":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/3686"},"comments":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/3686/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3686/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3686/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/kolibri/statuses/0286718a26577a8d79841624648a2047b54d5b78"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"christianmemije","id":7193975,"avatar_url":"https://avatars1.githubusercontent.com/u/7193975?v=4","gravatar_id":"","url":"https://api.github.com/users/christianmemije","html_url":"https://github.com/christianmemije","followers_url":"https://api.github.com/users/christianmemije/followers","following_url":"https://api.github.com/users/christianmemije/following{/other_user}","gists_url":"https://api.github.com/users/christianmemije/gists{/gist_id}","starred_url":"https://api.github.com/users/christianmemije/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianmemije/subscriptions","organizations_url":"https://api.github.com/users/christianmemije/orgs","repos_url":"https://api.github.com/users/christianmemije/repos","events_url":"https://api.github.com/users/christianmemije/events{/privacy}","received_events_url":"https://api.github.com/users/christianmemije/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":2,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"christianmemije"}}