{"action":"created","comment":{"url":"https://api.github.com/repos/justeat/JustEat.StatsD/pulls/comments/222930252","pull_request_review_id":161938132,"id":222930252,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjkzMDI1Mg==","diff_hunk":"@@ -0,0 +1,8 @@\n+namespace JustEat.StatsD\n+{\n+    public enum SocketProtocol","path":"src/JustEat.StatsD/SocketProtocol.cs","position":7,"original_position":3,"commit_id":"93c8cb6f4b599ef5d8fef38e4efa073ee4d2ed18","original_commit_id":"a1d26233ae45b232d64af3fd49de559547c090e3","user":{"login":"martincostello","id":1439341,"node_id":"MDQ6VXNlcjE0MzkzNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1439341?v=4","gravatar_id":"","url":"https://api.github.com/users/martincostello","html_url":"https://github.com/martincostello","followers_url":"https://api.github.com/users/martincostello/followers","following_url":"https://api.github.com/users/martincostello/following{/other_user}","gists_url":"https://api.github.com/users/martincostello/gists{/gist_id}","starred_url":"https://api.github.com/users/martincostello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martincostello/subscriptions","organizations_url":"https://api.github.com/users/martincostello/orgs","repos_url":"https://api.github.com/users/martincostello/repos","events_url":"https://api.github.com/users/martincostello/events{/privacy}","received_events_url":"https://api.github.com/users/martincostello/received_events","type":"User","site_admin":false},"body":"Need docs for the values too.","created_at":"2018-10-05T08:37:23Z","updated_at":"2018-10-05T08:37:45Z","html_url":"https://github.com/justeat/JustEat.StatsD/pull/116#discussion_r222930252","pull_request_url":"https://api.github.com/repos/justeat/JustEat.StatsD/pulls/116","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/justeat/JustEat.StatsD/pulls/comments/222930252"},"html":{"href":"https://github.com/justeat/JustEat.StatsD/pull/116#discussion_r222930252"},"pull_request":{"href":"https://api.github.com/repos/justeat/JustEat.StatsD/pulls/116"}},"in_reply_to_id":222927464},"pull_request":{"url":"https://api.github.com/repos/justeat/JustEat.StatsD/pulls/116","id":220619104,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNjE5MTA0","html_url":"https://github.com/justeat/JustEat.StatsD/pull/116","diff_url":"https://github.com/justeat/JustEat.StatsD/pull/116.diff","patch_url":"https://github.com/justeat/JustEat.StatsD/pull/116.patch","issue_url":"https://api.github.com/repos/justeat/JustEat.StatsD/issues/116","number":116,"state":"open","locked":false,"title":"Easy set transport","user":{"login":"AnthonySteele","id":104187,"node_id":"MDQ6VXNlcjEwNDE4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/104187?v=4","gravatar_id":"","url":"https://api.github.com/users/AnthonySteele","html_url":"https://github.com/AnthonySteele","followers_url":"https://api.github.com/users/AnthonySteele/followers","following_url":"https://api.github.com/users/AnthonySteele/following{/other_user}","gists_url":"https://api.github.com/users/AnthonySteele/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonySteele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonySteele/subscriptions","organizations_url":"https://api.github.com/users/AnthonySteele/orgs","repos_url":"https://api.github.com/users/AnthonySteele/repos","events_url":"https://api.github.com/users/AnthonySteele/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonySteele/received_events","type":"User","site_admin":false},"body":"_Summarise the changes this Pull Request makes._\r\n\r\nThe `UDPTransport` is far ahead of the `IPTransport` and I think that this is not an essential thing, simply due to all the development effort being focussed on the more common UDP scenario. It seems that the only _essential_ way that these differ is in the variety of socket created.\r\n\r\nSo  `UDPTransport` becomes `SocketTransport` that can create either kind of socket, controlled by a 2-state enum `SocketProtocol`.\r\n\r\n`IPTransport` or something to replace it is necessary: We still need to make IP sockets for AWS Lambda cases, but there should be an easier way to do that common case.  A `SocketProtocol` flag on the configuration solves that.\r\n\r\nThe more complex custom setup should still be just as possible as before.\r\n\r\nWe will need to test this with both kinds of socket, localy and then in Lambdas with IP sockets, and in regular features with UDP.\r\n\r\n_Please include a reference to a GitHub issue if appropriate._\r\n","created_at":"2018-10-05T08:12:41Z","updated_at":"2018-10-05T08:37:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0484726938872386a7ef40c8be3bd8b7d98013a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/justeat/JustEat.StatsD/milestones/2","html_url":"https://github.com/justeat/JustEat.StatsD/milestone/2","labels_url":"https://api.github.com/repos/justeat/JustEat.StatsD/milestones/2/labels","id":3506694,"node_id":"MDk6TWlsZXN0b25lMzUwNjY5NA==","number":2,"title":"v4.0.0","description":"Version `4.0.0` of JustEat.StatsD.","creator":{"login":"martincostello","id":1439341,"node_id":"MDQ6VXNlcjE0MzkzNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1439341?v=4","gravatar_id":"","url":"https://api.github.com/users/martincostello","html_url":"https://github.com/martincostello","followers_url":"https://api.github.com/users/martincostello/followers","following_url":"https://api.github.com/users/martincostello/following{/other_user}","gists_url":"https://api.github.com/users/martincostello/gists{/gist_id}","starred_url":"https://api.github.com/users/martincostello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martincostello/subscriptions","organizations_url":"https://api.github.com/users/martincostello/orgs","repos_url":"https://api.github.com/users/martincostello/repos","events_url":"https://api.github.com/users/martincostello/events{/privacy}","received_events_url":"https://api.github.com/users/martincostello/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":8,"state":"open","created_at":"2018-07-18T15:09:19Z","updated_at":"2018-10-05T08:28:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/justeat/JustEat.StatsD/pulls/116/commits","review_comments_url":"https://api.github.com/repos/justeat/JustEat.StatsD/pulls/116/comments","review_comment_url":"https://api.github.com/repos/justeat/JustEat.StatsD/pulls/comments{/number}","comments_url":"https://api.github.com/repos/justeat/JustEat.StatsD/issues/116/comments","statuses_url":"https://api.github.com/repos/justeat/JustEat.StatsD/statuses/93c8cb6f4b599ef5d8fef38e4efa073ee4d2ed18","head":{"label":"AnthonySteele:easy-set-transport","ref":"easy-set-transport","sha":"93c8cb6f4b599ef5d8fef38e4efa073ee4d2ed18","user":{"login":"AnthonySteele","id":104187,"node_id":"MDQ6VXNlcjEwNDE4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/104187?v=4","gravatar_id":"","url":"https://api.github.com/users/AnthonySteele","html_url":"https://github.com/AnthonySteele","followers_url":"https://api.github.com/users/AnthonySteele/followers","following_url":"https://api.github.com/users/AnthonySteele/following{/other_user}","gists_url":"https://api.github.com/users/AnthonySteele/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonySteele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonySteele/subscriptions","organizations_url":"https://api.github.com/users/AnthonySteele/orgs","repos_url":"https://api.github.com/users/AnthonySteele/repos","events_url":"https://api.github.com/users/AnthonySteele/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonySteele/received_events","type":"User","site_admin":false},"repo":{"id":43442042,"node_id":"MDEwOlJlcG9zaXRvcnk0MzQ0MjA0Mg==","name":"JustEat.StatsD","full_name":"AnthonySteele/JustEat.StatsD","private":false,"owner":{"login":"AnthonySteele","id":104187,"node_id":"MDQ6VXNlcjEwNDE4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/104187?v=4","gravatar_id":"","url":"https://api.github.com/users/AnthonySteele","html_url":"https://github.com/AnthonySteele","followers_url":"https://api.github.com/users/AnthonySteele/followers","following_url":"https://api.github.com/users/AnthonySteele/following{/other_user}","gists_url":"https://api.github.com/users/AnthonySteele/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonySteele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonySteele/subscriptions","organizations_url":"https://api.github.com/users/AnthonySteele/orgs","repos_url":"https://api.github.com/users/AnthonySteele/repos","events_url":"https://api.github.com/users/AnthonySteele/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonySteele/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AnthonySteele/JustEat.StatsD","description":"Our library for publishing metrics to statsd","fork":true,"url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD","forks_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/forks","keys_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/teams","hooks_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/hooks","issue_events_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/issues/events{/number}","events_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/events","assignees_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/assignees{/user}","branches_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/branches{/branch}","tags_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/tags","blobs_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/statuses/{sha}","languages_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/languages","stargazers_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/stargazers","contributors_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/contributors","subscribers_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/subscribers","subscription_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/subscription","commits_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/contents/{+path}","compare_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/merges","archive_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/downloads","issues_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/issues{/number}","pulls_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/pulls{/number}","milestones_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/milestones{/number}","notifications_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/labels{/name}","releases_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/releases{/id}","deployments_url":"https://api.github.com/repos/AnthonySteele/JustEat.StatsD/deployments","created_at":"2015-09-30T15:46:10Z","updated_at":"2018-10-04T10:20:47Z","pushed_at":"2018-10-05T08:36:34Z","git_url":"git://github.com/AnthonySteele/JustEat.StatsD.git","ssh_url":"git@github.com:AnthonySteele/JustEat.StatsD.git","clone_url":"https://github.com/AnthonySteele/JustEat.StatsD.git","svn_url":"https://github.com/AnthonySteele/JustEat.StatsD","homepage":null,"size":18970,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"justeat:master","ref":"master","sha":"d55d41426f94bc60cf569ceaafec41f9ed2ae52e","user":{"login":"justeat","id":1516790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTY3OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1516790?v=4","gravatar_id":"","url":"https://api.github.com/users/justeat","html_url":"https://github.com/justeat","followers_url":"https://api.github.com/users/justeat/followers","following_url":"https://api.github.com/users/justeat/following{/other_user}","gists_url":"https://api.github.com/users/justeat/gists{/gist_id}","starred_url":"https://api.github.com/users/justeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justeat/subscriptions","organizations_url":"https://api.github.com/users/justeat/orgs","repos_url":"https://api.github.com/users/justeat/repos","events_url":"https://api.github.com/users/justeat/events{/privacy}","received_events_url":"https://api.github.com/users/justeat/received_events","type":"Organization","site_admin":false},"repo":{"id":39507491,"node_id":"MDEwOlJlcG9zaXRvcnkzOTUwNzQ5MQ==","name":"JustEat.StatsD","full_name":"justeat/JustEat.StatsD","private":false,"owner":{"login":"justeat","id":1516790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTY3OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1516790?v=4","gravatar_id":"","url":"https://api.github.com/users/justeat","html_url":"https://github.com/justeat","followers_url":"https://api.github.com/users/justeat/followers","following_url":"https://api.github.com/users/justeat/following{/other_user}","gists_url":"https://api.github.com/users/justeat/gists{/gist_id}","starred_url":"https://api.github.com/users/justeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justeat/subscriptions","organizations_url":"https://api.github.com/users/justeat/orgs","repos_url":"https://api.github.com/users/justeat/repos","events_url":"https://api.github.com/users/justeat/events{/privacy}","received_events_url":"https://api.github.com/users/justeat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/justeat/JustEat.StatsD","description":"Our library for publishing metrics to statsd","fork":false,"url":"https://api.github.com/repos/justeat/JustEat.StatsD","forks_url":"https://api.github.com/repos/justeat/JustEat.StatsD/forks","keys_url":"https://api.github.com/repos/justeat/JustEat.StatsD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justeat/JustEat.StatsD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justeat/JustEat.StatsD/teams","hooks_url":"https://api.github.com/repos/justeat/JustEat.StatsD/hooks","issue_events_url":"https://api.github.com/repos/justeat/JustEat.StatsD/issues/events{/number}","events_url":"https://api.github.com/repos/justeat/JustEat.StatsD/events","assignees_url":"https://api.github.com/repos/justeat/JustEat.StatsD/assignees{/user}","branches_url":"https://api.github.com/repos/justeat/JustEat.StatsD/branches{/branch}","tags_url":"https://api.github.com/repos/justeat/JustEat.StatsD/tags","blobs_url":"https://api.github.com/repos/justeat/JustEat.StatsD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justeat/JustEat.StatsD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justeat/JustEat.StatsD/git/refs{/sha}","trees_url":"https://api.github.com/repos/justeat/JustEat.StatsD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justeat/JustEat.StatsD/statuses/{sha}","languages_url":"https://api.github.com/repos/justeat/JustEat.StatsD/languages","stargazers_url":"https://api.github.com/repos/justeat/JustEat.StatsD/stargazers","contributors_url":"https://api.github.com/repos/justeat/JustEat.StatsD/contributors","subscribers_url":"https://api.github.com/repos/justeat/JustEat.StatsD/subscribers","subscription_url":"https://api.github.com/repos/justeat/JustEat.StatsD/subscription","commits_url":"https://api.github.com/repos/justeat/JustEat.StatsD/commits{/sha}","git_commits_url":"https://api.github.com/repos/justeat/JustEat.StatsD/git/commits{/sha}","comments_url":"https://api.github.com/repos/justeat/JustEat.StatsD/comments{/number}","issue_comment_url":"https://api.github.com/repos/justeat/JustEat.StatsD/issues/comments{/number}","contents_url":"https://api.github.com/repos/justeat/JustEat.StatsD/contents/{+path}","compare_url":"https://api.github.com/repos/justeat/JustEat.StatsD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justeat/JustEat.StatsD/merges","archive_url":"https://api.github.com/repos/justeat/JustEat.StatsD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justeat/JustEat.StatsD/downloads","issues_url":"https://api.github.com/repos/justeat/JustEat.StatsD/issues{/number}","pulls_url":"https://api.github.com/repos/justeat/JustEat.StatsD/pulls{/number}","milestones_url":"https://api.github.com/repos/justeat/JustEat.StatsD/milestones{/number}","notifications_url":"https://api.github.com/repos/justeat/JustEat.StatsD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justeat/JustEat.StatsD/labels{/name}","releases_url":"https://api.github.com/repos/justeat/JustEat.StatsD/releases{/id}","deployments_url":"https://api.github.com/repos/justeat/JustEat.StatsD/deployments","created_at":"2015-07-22T13:26:52Z","updated_at":"2018-10-04T10:20:21Z","pushed_at":"2018-10-05T08:36:36Z","git_url":"git://github.com/justeat/JustEat.StatsD.git","ssh_url":"git@github.com:justeat/JustEat.StatsD.git","clone_url":"https://github.com/justeat/JustEat.StatsD.git","svn_url":"https://github.com/justeat/JustEat.StatsD","homepage":null,"size":18971,"stargazers_count":20,"watchers_count":20,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":19,"open_issues":1,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/justeat/JustEat.StatsD/pulls/116"},"html":{"href":"https://github.com/justeat/JustEat.StatsD/pull/116"},"issue":{"href":"https://api.github.com/repos/justeat/JustEat.StatsD/issues/116"},"comments":{"href":"https://api.github.com/repos/justeat/JustEat.StatsD/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/justeat/JustEat.StatsD/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/justeat/JustEat.StatsD/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/justeat/JustEat.StatsD/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/justeat/JustEat.StatsD/statuses/93c8cb6f4b599ef5d8fef38e4efa073ee4d2ed18"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"martincostello"}}