{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/installer/issues/890","repository_url":"https://api.github.com/repos/openshift/installer","labels_url":"https://api.github.com/repos/openshift/installer/issues/890/labels{/name}","comments_url":"https://api.github.com/repos/openshift/installer/issues/890/comments","events_url":"https://api.github.com/repos/openshift/installer/issues/890/events","html_url":"https://github.com/openshift/installer/pull/890","id":390468781,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjI4OTc3","number":890,"title":" assets: add tests for validating asset fetching of targets","user":{"login":"staebler","id":30120115,"node_id":"MDQ6VXNlcjMwMTIwMTE1","avatar_url":"https://avatars1.githubusercontent.com/u/30120115?v=4","gravatar_id":"","url":"https://api.github.com/users/staebler","html_url":"https://github.com/staebler","followers_url":"https://api.github.com/users/staebler/followers","following_url":"https://api.github.com/users/staebler/following{/other_user}","gists_url":"https://api.github.com/users/staebler/gists{/gist_id}","starred_url":"https://api.github.com/users/staebler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staebler/subscriptions","organizations_url":"https://api.github.com/users/staebler/orgs","repos_url":"https://api.github.com/users/staebler/repos","events_url":"https://api.github.com/users/staebler/events{/privacy}","received_events_url":"https://api.github.com/users/staebler/received_events","type":"User","site_admin":false},"labels":[{"id":959732229,"node_id":"MDU6TGFiZWw5NTk3MzIyMjk=","url":"https://api.github.com/repos/openshift/installer/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":959730581,"node_id":"MDU6TGFiZWw5NTk3MzA1ODE=","url":"https://api.github.com/repos/openshift/installer/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-13T00:35:27Z","updated_at":"2018-12-13T00:48:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/890","html_url":"https://github.com/openshift/installer/pull/890","diff_url":"https://github.com/openshift/installer/pull/890.diff","patch_url":"https://github.com/openshift/installer/pull/890.patch"},"body":"This adds tests around creating the targeted assets. The tests validate the following.\r\n\r\n1) An asset that is generated and then fetched again from a new store has equivalent state.\r\n2) A targeted asset restored from the state file and from on-disk has equivalent state.\r\n\r\nThis PR also includes a few changes to the assets to get the tests passing.\r\n\r\nFixes https://jira.coreos.com/browse/CORS-940"},"comment":{"url":"https://api.github.com/repos/openshift/installer/issues/comments/446800830","html_url":"https://github.com/openshift/installer/pull/890#issuecomment-446800830","issue_url":"https://api.github.com/repos/openshift/installer/issues/890","id":446800830,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjgwMDgzMA==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T00:48:48Z","updated_at":"2018-12-13T00:48:48Z","author_association":"NONE","body":"@staebler: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/prow/e2e-aws | 506156a4b15e6b79b3140305e9c97ee74be098a1 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/890/pull-ci-openshift-installer-master-e2e-aws/2250) | `/test e2e-aws`\nci/prow/govet | 506156a4b15e6b79b3140305e9c97ee74be098a1 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/890/pull-ci-openshift-installer-master-govet/1734) | `/test govet`\nci/prow/images | 506156a4b15e6b79b3140305e9c97ee74be098a1 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/890/pull-ci-openshift-installer-master-images/1667) | `/test images`\nci/prow/rhel-images | 506156a4b15e6b79b3140305e9c97ee74be098a1 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/890/pull-ci-openshift-installer-master-rhel-images/216) | `/test rhel-images`\nci/prow/golint | 9fd939d508aec974fa8a357b14215ac7d48fdaa7 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/890/pull-ci-openshift-installer-master-golint/1732) | `/test golint`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/openshift_installer/890). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/staebler). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/installer/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}