{"action":"closed","number":9240,"pull_request":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/9240","id":203095292,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDk1Mjky","html_url":"https://github.com/ParadiseSS13/Paradise/pull/9240","diff_url":"https://github.com/ParadiseSS13/Paradise/pull/9240.diff","patch_url":"https://github.com/ParadiseSS13/Paradise/pull/9240.patch","issue_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/9240","number":9240,"state":"closed","locked":false,"title":"Reveal identity while using megaphone ","user":{"login":"nicetoolbox","id":41554512,"node_id":"MDQ6VXNlcjQxNTU0NTEy","avatar_url":"https://avatars0.githubusercontent.com/u/41554512?v=4","gravatar_id":"","url":"https://api.github.com/users/nicetoolbox","html_url":"https://github.com/nicetoolbox","followers_url":"https://api.github.com/users/nicetoolbox/followers","following_url":"https://api.github.com/users/nicetoolbox/following{/other_user}","gists_url":"https://api.github.com/users/nicetoolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/nicetoolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicetoolbox/subscriptions","organizations_url":"https://api.github.com/users/nicetoolbox/orgs","repos_url":"https://api.github.com/users/nicetoolbox/repos","events_url":"https://api.github.com/users/nicetoolbox/events{/privacy}","received_events_url":"https://api.github.com/users/nicetoolbox/received_events","type":"User","site_admin":false},"body":"See #3031\r\n\r\n* Displays who is really speaking when they use the microphone\r\n* Refactor to remove alt_name arguments from hear, speak, and whisper. Moved it to a proc on mob called GetAltName\r\n\r\nI tested it for a while and it seems to be working. But this is my first change and I'm not very familiar with the code base.\r\n\r\nTried these things:\r\n\r\n* whispering\r\n* Using megaphone\r\n* speaking\r\n* speaking on radio\r\n\r\nI'm not sure how it appears from the other player's perspective. Please let me know if I should test more or what to change, thanks\r\n\r\n[cl]\r\n:fix: Megaphones now reveal the identity of the speaker, like speaking normally.\r\n[/cl]","created_at":"2018-07-23T02:33:35Z","updated_at":"2018-09-28T04:45:21Z","closed_at":"2018-09-28T04:45:21Z","merged_at":"2018-09-28T04:45:21Z","merge_commit_sha":"3010b71c8d8f97329128104eb2be62411e80f9cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":176235380,"node_id":"MDU6TGFiZWwxNzYyMzUzODA=","url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels/Feature","name":"Feature","color":"26A726","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/9240/commits","review_comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/9240/comments","review_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/9240/comments","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/fdc729795452f82b60da143b5cabf6dbde1d4d48","head":{"label":"nicetoolbox:megaphone-fix","ref":"megaphone-fix","sha":"fdc729795452f82b60da143b5cabf6dbde1d4d48","user":{"login":"nicetoolbox","id":41554512,"node_id":"MDQ6VXNlcjQxNTU0NTEy","avatar_url":"https://avatars0.githubusercontent.com/u/41554512?v=4","gravatar_id":"","url":"https://api.github.com/users/nicetoolbox","html_url":"https://github.com/nicetoolbox","followers_url":"https://api.github.com/users/nicetoolbox/followers","following_url":"https://api.github.com/users/nicetoolbox/following{/other_user}","gists_url":"https://api.github.com/users/nicetoolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/nicetoolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicetoolbox/subscriptions","organizations_url":"https://api.github.com/users/nicetoolbox/orgs","repos_url":"https://api.github.com/users/nicetoolbox/repos","events_url":"https://api.github.com/users/nicetoolbox/events{/privacy}","received_events_url":"https://api.github.com/users/nicetoolbox/received_events","type":"User","site_admin":false},"repo":{"id":141937975,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE5Mzc5NzU=","name":"Paradise","full_name":"nicetoolbox/Paradise","private":false,"owner":{"login":"nicetoolbox","id":41554512,"node_id":"MDQ6VXNlcjQxNTU0NTEy","avatar_url":"https://avatars0.githubusercontent.com/u/41554512?v=4","gravatar_id":"","url":"https://api.github.com/users/nicetoolbox","html_url":"https://github.com/nicetoolbox","followers_url":"https://api.github.com/users/nicetoolbox/followers","following_url":"https://api.github.com/users/nicetoolbox/following{/other_user}","gists_url":"https://api.github.com/users/nicetoolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/nicetoolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicetoolbox/subscriptions","organizations_url":"https://api.github.com/users/nicetoolbox/orgs","repos_url":"https://api.github.com/users/nicetoolbox/repos","events_url":"https://api.github.com/users/nicetoolbox/events{/privacy}","received_events_url":"https://api.github.com/users/nicetoolbox/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nicetoolbox/Paradise","description":"Paradise Station's GitHub main repository.","fork":true,"url":"https://api.github.com/repos/nicetoolbox/Paradise","forks_url":"https://api.github.com/repos/nicetoolbox/Paradise/forks","keys_url":"https://api.github.com/repos/nicetoolbox/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicetoolbox/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicetoolbox/Paradise/teams","hooks_url":"https://api.github.com/repos/nicetoolbox/Paradise/hooks","issue_events_url":"https://api.github.com/repos/nicetoolbox/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/nicetoolbox/Paradise/events","assignees_url":"https://api.github.com/repos/nicetoolbox/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/nicetoolbox/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/nicetoolbox/Paradise/tags","blobs_url":"https://api.github.com/repos/nicetoolbox/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicetoolbox/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicetoolbox/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicetoolbox/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicetoolbox/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/nicetoolbox/Paradise/languages","stargazers_url":"https://api.github.com/repos/nicetoolbox/Paradise/stargazers","contributors_url":"https://api.github.com/repos/nicetoolbox/Paradise/contributors","subscribers_url":"https://api.github.com/repos/nicetoolbox/Paradise/subscribers","subscription_url":"https://api.github.com/repos/nicetoolbox/Paradise/subscription","commits_url":"https://api.github.com/repos/nicetoolbox/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicetoolbox/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicetoolbox/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicetoolbox/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicetoolbox/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/nicetoolbox/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicetoolbox/Paradise/merges","archive_url":"https://api.github.com/repos/nicetoolbox/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicetoolbox/Paradise/downloads","issues_url":"https://api.github.com/repos/nicetoolbox/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/nicetoolbox/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/nicetoolbox/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/nicetoolbox/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicetoolbox/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/nicetoolbox/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/nicetoolbox/Paradise/deployments","created_at":"2018-07-22T23:18:45Z","updated_at":"2018-09-01T22:28:45Z","pushed_at":"2018-09-28T03:37:00Z","git_url":"git://github.com/nicetoolbox/Paradise.git","ssh_url":"git@github.com:nicetoolbox/Paradise.git","clone_url":"https://github.com/nicetoolbox/Paradise.git","svn_url":"https://github.com/nicetoolbox/Paradise","homepage":"https://nanotrasen.se/forum/","size":1057312,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ParadiseSS13:master","ref":"master","sha":"05e8116138cad13248fa6a0f69bbccfa16de9851","user":{"login":"ParadiseSS13","id":9994901,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5OTQ5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/9994901?v=4","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"repo":{"id":27286452,"node_id":"MDEwOlJlcG9zaXRvcnkyNzI4NjQ1Mg==","name":"Paradise","full_name":"ParadiseSS13/Paradise","private":false,"owner":{"login":"ParadiseSS13","id":9994901,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5OTQ5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/9994901?v=4","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ParadiseSS13/Paradise","description":"Paradise Station's GitHub main repository.","fork":false,"url":"https://api.github.com/repos/ParadiseSS13/Paradise","forks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/forks","keys_url":"https://api.github.com/repos/ParadiseSS13/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParadiseSS13/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParadiseSS13/Paradise/teams","hooks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/hooks","issue_events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/events","assignees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/ParadiseSS13/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/tags","blobs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/ParadiseSS13/Paradise/languages","stargazers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/stargazers","contributors_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contributors","subscribers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscribers","subscription_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscription","commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/ParadiseSS13/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParadiseSS13/Paradise/merges","archive_url":"https://api.github.com/repos/ParadiseSS13/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParadiseSS13/Paradise/downloads","issues_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/ParadiseSS13/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/ParadiseSS13/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/ParadiseSS13/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/deployments","created_at":"2014-11-29T00:16:54Z","updated_at":"2018-09-28T04:39:59Z","pushed_at":"2018-09-28T04:45:21Z","git_url":"git://github.com/ParadiseSS13/Paradise.git","ssh_url":"git@github.com:ParadiseSS13/Paradise.git","clone_url":"https://github.com/ParadiseSS13/Paradise.git","svn_url":"https://github.com/ParadiseSS13/Paradise","homepage":"https://nanotrasen.se/forum/","size":1057305,"stargazers_count":129,"watchers_count":129,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":445,"mirror_url":null,"archived":false,"open_issues_count":583,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":445,"open_issues":583,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/9240"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/9240"},"issue":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/9240"},"comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/9240/comments"},"review_comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/9240/comments"},"review_comment":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/9240/commits"},"statuses":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/fdc729795452f82b60da143b5cabf6dbde1d4d48"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"variableundefined","id":40092670,"node_id":"MDQ6VXNlcjQwMDkyNjcw","avatar_url":"https://avatars3.githubusercontent.com/u/40092670?v=4","gravatar_id":"","url":"https://api.github.com/users/variableundefined","html_url":"https://github.com/variableundefined","followers_url":"https://api.github.com/users/variableundefined/followers","following_url":"https://api.github.com/users/variableundefined/following{/other_user}","gists_url":"https://api.github.com/users/variableundefined/gists{/gist_id}","starred_url":"https://api.github.com/users/variableundefined/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/variableundefined/subscriptions","organizations_url":"https://api.github.com/users/variableundefined/orgs","repos_url":"https://api.github.com/users/variableundefined/repos","events_url":"https://api.github.com/users/variableundefined/events{/privacy}","received_events_url":"https://api.github.com/users/variableundefined/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":37,"deletions":39,"changed_files":13}}
{"actor":{"display_login":"variableundefined"}}