{"action":"created","comment":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/235268478","pull_request_review_id":177093537,"id":235268478,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTI2ODQ3OA==","diff_hunk":"@@ -84,9 +84,8 @@ function(op_library TARGET)\n     endif()\n     if (WIN32)\n     # remove windows unsupported op, because windows has no nccl, no warpctc such ops.\n-    foreach(windows_unsupport_op \"nccl_op\" \"gen_nccl_id_op\" \"warpctc_op\" \"hierarchical_sigmoid_op\"\n-     \"crf_decoding_op\" \"select_op\" \"lstmp_op\" \"gru_op\" \"fusion_gru_op\" \"lstm_op\" \"fusion_lstm_op\" \"cumsum_op\"\n-      \"fusion_seqconv_eltadd_relu_op\" \"channel_send_op\" \"channel_create_op\" \"channel_close_op\" \"channel_recv_op\")\n+    foreach(windows_unsupport_op \"nccl_op\" \"gen_nccl_id_op\" \"warpctc_op\"\n+            \"channel_send_op\" \"channel_create_op\" \"channel_close_op\" \"channel_recv_op\")","path":"cmake/operators.cmake","position":8,"original_position":8,"commit_id":"a7c8e42d6be7bd60fefa25ea68e776d52b58d28e","original_commit_id":"a7c8e42d6be7bd60fefa25ea68e776d52b58d28e","user":{"login":"dzhwinter","id":6687176,"node_id":"MDQ6VXNlcjY2ODcxNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/6687176?v=4","gravatar_id":"","url":"https://api.github.com/users/dzhwinter","html_url":"https://github.com/dzhwinter","followers_url":"https://api.github.com/users/dzhwinter/followers","following_url":"https://api.github.com/users/dzhwinter/following{/other_user}","gists_url":"https://api.github.com/users/dzhwinter/gists{/gist_id}","starred_url":"https://api.github.com/users/dzhwinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzhwinter/subscriptions","organizations_url":"https://api.github.com/users/dzhwinter/orgs","repos_url":"https://api.github.com/users/dzhwinter/repos","events_url":"https://api.github.com/users/dzhwinter/events{/privacy}","received_events_url":"https://api.github.com/users/dzhwinter/received_events","type":"User","site_admin":false},"body":" \"channel_send_op\" \"channel_create_op\" \"channel_close_op\" \"channel_recv_op\" \r\ncan be deleted.","created_at":"2018-11-21T06:45:40Z","updated_at":"2018-11-21T06:45:47Z","html_url":"https://github.com/PaddlePaddle/Paddle/pull/14474#discussion_r235268478","pull_request_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/14474","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/235268478"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/14474#discussion_r235268478"},"pull_request":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/14474"}}},"pull_request":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/14474","id":231780730,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzgwNzMw","html_url":"https://github.com/PaddlePaddle/Paddle/pull/14474","diff_url":"https://github.com/PaddlePaddle/Paddle/pull/14474.diff","patch_url":"https://github.com/PaddlePaddle/Paddle/pull/14474.patch","issue_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/14474","number":14474,"state":"open","locked":false,"title":"Windows/online ","user":{"login":"wopeizl","id":23548796,"node_id":"MDQ6VXNlcjIzNTQ4Nzk2","avatar_url":"https://avatars1.githubusercontent.com/u/23548796?v=4","gravatar_id":"","url":"https://api.github.com/users/wopeizl","html_url":"https://github.com/wopeizl","followers_url":"https://api.github.com/users/wopeizl/followers","following_url":"https://api.github.com/users/wopeizl/following{/other_user}","gists_url":"https://api.github.com/users/wopeizl/gists{/gist_id}","starred_url":"https://api.github.com/users/wopeizl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wopeizl/subscriptions","organizations_url":"https://api.github.com/users/wopeizl/orgs","repos_url":"https://api.github.com/users/wopeizl/repos","events_url":"https://api.github.com/users/wopeizl/events{/privacy}","received_events_url":"https://api.github.com/users/wopeizl/received_events","type":"User","site_admin":false},"body":"1. add the recordio support back\r\n2. add the jit related ops back\r\n3. fix the test issue\r\n4. replace the non-ascii characters with in ops since it may block the protobuf parsing on windows\r\n5. fix the mkdir issue on windows\r\n6. adjust some python script to avoid api-check complaints\r\n","created_at":"2018-11-18T10:41:13Z","updated_at":"2018-11-21T06:45:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95eca033c01a0b2e2252ab30f328d6df45584607","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/14474/commits","review_comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/14474/comments","review_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/14474/comments","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/a7c8e42d6be7bd60fefa25ea68e776d52b58d28e","head":{"label":"wopeizl:windows/online","ref":"windows/online","sha":"a7c8e42d6be7bd60fefa25ea68e776d52b58d28e","user":{"login":"wopeizl","id":23548796,"node_id":"MDQ6VXNlcjIzNTQ4Nzk2","avatar_url":"https://avatars1.githubusercontent.com/u/23548796?v=4","gravatar_id":"","url":"https://api.github.com/users/wopeizl","html_url":"https://github.com/wopeizl","followers_url":"https://api.github.com/users/wopeizl/followers","following_url":"https://api.github.com/users/wopeizl/following{/other_user}","gists_url":"https://api.github.com/users/wopeizl/gists{/gist_id}","starred_url":"https://api.github.com/users/wopeizl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wopeizl/subscriptions","organizations_url":"https://api.github.com/users/wopeizl/orgs","repos_url":"https://api.github.com/users/wopeizl/repos","events_url":"https://api.github.com/users/wopeizl/events{/privacy}","received_events_url":"https://api.github.com/users/wopeizl/received_events","type":"User","site_admin":false},"repo":{"id":153248797,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMyNDg3OTc=","name":"Paddle","full_name":"wopeizl/Paddle","private":false,"owner":{"login":"wopeizl","id":23548796,"node_id":"MDQ6VXNlcjIzNTQ4Nzk2","avatar_url":"https://avatars1.githubusercontent.com/u/23548796?v=4","gravatar_id":"","url":"https://api.github.com/users/wopeizl","html_url":"https://github.com/wopeizl","followers_url":"https://api.github.com/users/wopeizl/followers","following_url":"https://api.github.com/users/wopeizl/following{/other_user}","gists_url":"https://api.github.com/users/wopeizl/gists{/gist_id}","starred_url":"https://api.github.com/users/wopeizl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wopeizl/subscriptions","organizations_url":"https://api.github.com/users/wopeizl/orgs","repos_url":"https://api.github.com/users/wopeizl/repos","events_url":"https://api.github.com/users/wopeizl/events{/privacy}","received_events_url":"https://api.github.com/users/wopeizl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wopeizl/Paddle","description":"PArallel Distributed Deep LEarning","fork":true,"url":"https://api.github.com/repos/wopeizl/Paddle","forks_url":"https://api.github.com/repos/wopeizl/Paddle/forks","keys_url":"https://api.github.com/repos/wopeizl/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wopeizl/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wopeizl/Paddle/teams","hooks_url":"https://api.github.com/repos/wopeizl/Paddle/hooks","issue_events_url":"https://api.github.com/repos/wopeizl/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/wopeizl/Paddle/events","assignees_url":"https://api.github.com/repos/wopeizl/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/wopeizl/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/wopeizl/Paddle/tags","blobs_url":"https://api.github.com/repos/wopeizl/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wopeizl/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wopeizl/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/wopeizl/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wopeizl/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/wopeizl/Paddle/languages","stargazers_url":"https://api.github.com/repos/wopeizl/Paddle/stargazers","contributors_url":"https://api.github.com/repos/wopeizl/Paddle/contributors","subscribers_url":"https://api.github.com/repos/wopeizl/Paddle/subscribers","subscription_url":"https://api.github.com/repos/wopeizl/Paddle/subscription","commits_url":"https://api.github.com/repos/wopeizl/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/wopeizl/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/wopeizl/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/wopeizl/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/wopeizl/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/wopeizl/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wopeizl/Paddle/merges","archive_url":"https://api.github.com/repos/wopeizl/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wopeizl/Paddle/downloads","issues_url":"https://api.github.com/repos/wopeizl/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/wopeizl/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/wopeizl/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/wopeizl/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wopeizl/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/wopeizl/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/wopeizl/Paddle/deployments","created_at":"2018-10-16T08:19:12Z","updated_at":"2018-11-16T16:14:18Z","pushed_at":"2018-11-21T03:40:48Z","git_url":"git://github.com/wopeizl/Paddle.git","ssh_url":"git@github.com:wopeizl/Paddle.git","clone_url":"https://github.com/wopeizl/Paddle.git","svn_url":"https://github.com/wopeizl/Paddle","homepage":"http://www.paddlepaddle.org/","size":140745,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PaddlePaddle:develop","ref":"develop","sha":"1d9b2a453c8ecbb7f44f45924d010f7e09456012","user":{"login":"PaddlePaddle","id":23534030,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0MDMw","avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"repo":{"id":65711522,"node_id":"MDEwOlJlcG9zaXRvcnk2NTcxMTUyMg==","name":"Paddle","full_name":"PaddlePaddle/Paddle","private":false,"owner":{"login":"PaddlePaddle","id":23534030,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0MDMw","avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PaddlePaddle/Paddle","description":"PArallel Distributed Deep LEarning","fork":false,"url":"https://api.github.com/repos/PaddlePaddle/Paddle","forks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/forks","keys_url":"https://api.github.com/repos/PaddlePaddle/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaddlePaddle/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaddlePaddle/Paddle/teams","hooks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/hooks","issue_events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/events","assignees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/PaddlePaddle/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/tags","blobs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/PaddlePaddle/Paddle/languages","stargazers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/stargazers","contributors_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contributors","subscribers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscribers","subscription_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscription","commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/PaddlePaddle/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaddlePaddle/Paddle/merges","archive_url":"https://api.github.com/repos/PaddlePaddle/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaddlePaddle/Paddle/downloads","issues_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/PaddlePaddle/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/PaddlePaddle/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaddlePaddle/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/PaddlePaddle/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/deployments","created_at":"2016-08-15T06:59:08Z","updated_at":"2018-11-21T04:33:20Z","pushed_at":"2018-11-21T06:14:07Z","git_url":"git://github.com/PaddlePaddle/Paddle.git","ssh_url":"git@github.com:PaddlePaddle/Paddle.git","clone_url":"https://github.com/PaddlePaddle/Paddle.git","svn_url":"https://github.com/PaddlePaddle/Paddle","homepage":"http://www.paddlepaddle.org/","size":140654,"stargazers_count":7798,"watchers_count":7798,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2114,"mirror_url":null,"archived":false,"open_issues_count":707,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2114,"open_issues":707,"watchers":7798,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/14474"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/14474"},"issue":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/14474"},"comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/14474/comments"},"review_comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/14474/comments"},"review_comment":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/14474/commits"},"statuses":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/a7c8e42d6be7bd60fefa25ea68e776d52b58d28e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dzhwinter"}}