{"action":"closed","number":37,"pull_request":{"url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/pulls/37","id":206539095,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTM5MDk1","html_url":"https://github.com/voxpelli/node-pg-pubsub/pull/37","diff_url":"https://github.com/voxpelli/node-pg-pubsub/pull/37.diff","patch_url":"https://github.com/voxpelli/node-pg-pubsub/pull/37.patch","issue_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/issues/37","number":37,"state":"closed","locked":false,"title":"feat(pkg): allow waiting for pgPool to close","user":{"login":"cdaringe","id":1003261,"node_id":"MDQ6VXNlcjEwMDMyNjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1003261?v=4","gravatar_id":"","url":"https://api.github.com/users/cdaringe","html_url":"https://github.com/cdaringe","followers_url":"https://api.github.com/users/cdaringe/followers","following_url":"https://api.github.com/users/cdaringe/following{/other_user}","gists_url":"https://api.github.com/users/cdaringe/gists{/gist_id}","starred_url":"https://api.github.com/users/cdaringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdaringe/subscriptions","organizations_url":"https://api.github.com/users/cdaringe/orgs","repos_url":"https://api.github.com/users/cdaringe/repos","events_url":"https://api.github.com/users/cdaringe/events{/privacy}","received_events_url":"https://api.github.com/users/cdaringe/received_events","type":"User","site_admin":false},"body":"# problem\r\n\r\nclose allows for a race, and gives no chance of preventing race\r\n\r\n# solution\r\n\r\n- allow close to be awaitable (e.g. use the pg .close promise).  [ref close usage](https://node-postgres.com/#getting-started)","created_at":"2018-08-06T23:05:36Z","updated_at":"2018-09-11T19:54:52Z","closed_at":"2018-09-11T19:54:52Z","merged_at":"2018-09-11T19:54:52Z","merge_commit_sha":"a1bc8f0ee41df6571a742a8b273c61e948012407","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/pulls/37/commits","review_comments_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/pulls/37/comments","review_comment_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/issues/37/comments","statuses_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/statuses/8f80b90523b54fb465fa8cb6198d73365fca8023","head":{"label":"cdaringe:feat/awaitable-close","ref":"feat/awaitable-close","sha":"8f80b90523b54fb465fa8cb6198d73365fca8023","user":{"login":"cdaringe","id":1003261,"node_id":"MDQ6VXNlcjEwMDMyNjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1003261?v=4","gravatar_id":"","url":"https://api.github.com/users/cdaringe","html_url":"https://github.com/cdaringe","followers_url":"https://api.github.com/users/cdaringe/followers","following_url":"https://api.github.com/users/cdaringe/following{/other_user}","gists_url":"https://api.github.com/users/cdaringe/gists{/gist_id}","starred_url":"https://api.github.com/users/cdaringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdaringe/subscriptions","organizations_url":"https://api.github.com/users/cdaringe/orgs","repos_url":"https://api.github.com/users/cdaringe/repos","events_url":"https://api.github.com/users/cdaringe/events{/privacy}","received_events_url":"https://api.github.com/users/cdaringe/received_events","type":"User","site_admin":false},"repo":{"id":127670152,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc2NzAxNTI=","name":"node-pg-pubsub","full_name":"cdaringe/node-pg-pubsub","owner":{"login":"cdaringe","id":1003261,"node_id":"MDQ6VXNlcjEwMDMyNjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1003261?v=4","gravatar_id":"","url":"https://api.github.com/users/cdaringe","html_url":"https://github.com/cdaringe","followers_url":"https://api.github.com/users/cdaringe/followers","following_url":"https://api.github.com/users/cdaringe/following{/other_user}","gists_url":"https://api.github.com/users/cdaringe/gists{/gist_id}","starred_url":"https://api.github.com/users/cdaringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdaringe/subscriptions","organizations_url":"https://api.github.com/users/cdaringe/orgs","repos_url":"https://api.github.com/users/cdaringe/repos","events_url":"https://api.github.com/users/cdaringe/events{/privacy}","received_events_url":"https://api.github.com/users/cdaringe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdaringe/node-pg-pubsub","description":"A Publish/Subscribe implementation on top of PostgreSQL NOTIFY/LISTEN","fork":true,"url":"https://api.github.com/repos/cdaringe/node-pg-pubsub","forks_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/forks","keys_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/teams","hooks_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/hooks","issue_events_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/issues/events{/number}","events_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/events","assignees_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/assignees{/user}","branches_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/branches{/branch}","tags_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/tags","blobs_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/statuses/{sha}","languages_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/languages","stargazers_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/stargazers","contributors_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/contributors","subscribers_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/subscribers","subscription_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/subscription","commits_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/contents/{+path}","compare_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/merges","archive_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/downloads","issues_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/issues{/number}","pulls_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/pulls{/number}","milestones_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/milestones{/number}","notifications_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/labels{/name}","releases_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/releases{/id}","deployments_url":"https://api.github.com/repos/cdaringe/node-pg-pubsub/deployments","created_at":"2018-04-01T20:49:23Z","updated_at":"2018-04-01T20:49:25Z","pushed_at":"2018-08-06T23:01:49Z","git_url":"git://github.com/cdaringe/node-pg-pubsub.git","ssh_url":"git@github.com:cdaringe/node-pg-pubsub.git","clone_url":"https://github.com/cdaringe/node-pg-pubsub.git","svn_url":"https://github.com/cdaringe/node-pg-pubsub","homepage":"https://www.npmjs.com/package/pg-pubsub","size":45,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpelli:master","ref":"master","sha":"b7e923de5e55642c479780e8b0af1df62d87e70c","user":{"login":"voxpelli","id":34457,"node_id":"MDQ6VXNlcjM0NDU3","avatar_url":"https://avatars1.githubusercontent.com/u/34457?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpelli","html_url":"https://github.com/voxpelli","followers_url":"https://api.github.com/users/voxpelli/followers","following_url":"https://api.github.com/users/voxpelli/following{/other_user}","gists_url":"https://api.github.com/users/voxpelli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpelli/subscriptions","organizations_url":"https://api.github.com/users/voxpelli/orgs","repos_url":"https://api.github.com/users/voxpelli/repos","events_url":"https://api.github.com/users/voxpelli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpelli/received_events","type":"User","site_admin":false},"repo":{"id":27651656,"node_id":"MDEwOlJlcG9zaXRvcnkyNzY1MTY1Ng==","name":"node-pg-pubsub","full_name":"voxpelli/node-pg-pubsub","owner":{"login":"voxpelli","id":34457,"node_id":"MDQ6VXNlcjM0NDU3","avatar_url":"https://avatars1.githubusercontent.com/u/34457?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpelli","html_url":"https://github.com/voxpelli","followers_url":"https://api.github.com/users/voxpelli/followers","following_url":"https://api.github.com/users/voxpelli/following{/other_user}","gists_url":"https://api.github.com/users/voxpelli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpelli/subscriptions","organizations_url":"https://api.github.com/users/voxpelli/orgs","repos_url":"https://api.github.com/users/voxpelli/repos","events_url":"https://api.github.com/users/voxpelli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpelli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/voxpelli/node-pg-pubsub","description":"A Publish/Subscribe implementation on top of PostgreSQL NOTIFY/LISTEN","fork":false,"url":"https://api.github.com/repos/voxpelli/node-pg-pubsub","forks_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/forks","keys_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/teams","hooks_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/hooks","issue_events_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/issues/events{/number}","events_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/events","assignees_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/assignees{/user}","branches_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/branches{/branch}","tags_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/tags","blobs_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/languages","stargazers_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/stargazers","contributors_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/contributors","subscribers_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/subscribers","subscription_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/subscription","commits_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/contents/{+path}","compare_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/merges","archive_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/downloads","issues_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/issues{/number}","pulls_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/labels{/name}","releases_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/releases{/id}","deployments_url":"https://api.github.com/repos/voxpelli/node-pg-pubsub/deployments","created_at":"2014-12-06T22:43:14Z","updated_at":"2018-09-11T18:36:19Z","pushed_at":"2018-09-11T19:54:52Z","git_url":"git://github.com/voxpelli/node-pg-pubsub.git","ssh_url":"git@github.com:voxpelli/node-pg-pubsub.git","clone_url":"https://github.com/voxpelli/node-pg-pubsub.git","svn_url":"https://github.com/voxpelli/node-pg-pubsub","homepage":"https://www.npmjs.com/package/pg-pubsub","size":49,"stargazers_count":127,"watchers_count":127,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":9,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpelli/node-pg-pubsub/pulls/37"},"html":{"href":"https://github.com/voxpelli/node-pg-pubsub/pull/37"},"issue":{"href":"https://api.github.com/repos/voxpelli/node-pg-pubsub/issues/37"},"comments":{"href":"https://api.github.com/repos/voxpelli/node-pg-pubsub/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpelli/node-pg-pubsub/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpelli/node-pg-pubsub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpelli/node-pg-pubsub/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/voxpelli/node-pg-pubsub/statuses/8f80b90523b54fb465fa8cb6198d73365fca8023"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"voxpelli","id":34457,"node_id":"MDQ6VXNlcjM0NDU3","avatar_url":"https://avatars1.githubusercontent.com/u/34457?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpelli","html_url":"https://github.com/voxpelli","followers_url":"https://api.github.com/users/voxpelli/followers","following_url":"https://api.github.com/users/voxpelli/following{/other_user}","gists_url":"https://api.github.com/users/voxpelli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpelli/subscriptions","organizations_url":"https://api.github.com/users/voxpelli/orgs","repos_url":"https://api.github.com/users/voxpelli/repos","events_url":"https://api.github.com/users/voxpelli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpelli/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"voxpelli"}}