{"action":"closed","number":1037,"pull_request":{"url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1037","id":206534037,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTM0MDM3","html_url":"https://github.com/input-output-hk/daedalus/pull/1037","diff_url":"https://github.com/input-output-hk/daedalus/pull/1037.diff","patch_url":"https://github.com/input-output-hk/daedalus/pull/1037.patch","issue_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1037","number":1037,"state":"closed","locked":false,"title":"[DDW-356] V1 API endpoints integration 2/5","user":{"login":"MarcusHurney","id":13347886,"node_id":"MDQ6VXNlcjEzMzQ3ODg2","avatar_url":"https://avatars2.githubusercontent.com/u/13347886?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcusHurney","html_url":"https://github.com/MarcusHurney","followers_url":"https://api.github.com/users/MarcusHurney/followers","following_url":"https://api.github.com/users/MarcusHurney/following{/other_user}","gists_url":"https://api.github.com/users/MarcusHurney/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcusHurney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcusHurney/subscriptions","organizations_url":"https://api.github.com/users/MarcusHurney/orgs","repos_url":"https://api.github.com/users/MarcusHurney/repos","events_url":"https://api.github.com/users/MarcusHurney/events{/privacy}","received_events_url":"https://api.github.com/users/MarcusHurney/received_events","type":"User","site_admin":false},"body":"This PR integrates the V1 API endpoints for the following:\r\n\r\n- fetching all accounts associated with a wallet (**getAdaWalletAccounts.js**)\r\n- fetching a single address (**getAdaAddress.js**) formerly named (**isValidAdaAddress.js**)\r\n- creating a new address (**newAdaWalletAddress.js**)\r\n\r\n## Review Checklist:\r\n\r\n### Basics\r\n\r\n- [x] PR is updated to the most recent version of target branch (and there are no conflicts)\r\n- [x] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes\r\n- [x] CHANGELOG entry has been added and is linked to the correct PR on GitHub\r\n- [ ] Automated tests: All acceptance tests are passing (`yarn run test`)\r\n- [x] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`)\r\n- [x] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds)\r\n- [x] There are no *flow* errors or warnings (`yarn run flow:test`)\r\n- [x] There are no *lint* errors or warnings (`yarn run lint`)\r\n- [x] Text changes are proofread and approved (Jane Wild)\r\n- [x] There are no missing translations (running `yarn run manage:translations` produces no changes)\r\n- [x] UI changes look good in all themes (Alexander Rukin)\r\n- [x] Storybook works and no stories are broken (`yarn run storybook`)\r\n- [x] In case of dependency changes `yarn.lock` file is updated\r\n\r\n### Code Quality\r\n- [ ] Important parts of the code are properly documented and commented\r\n- [ ] Code is properly typed with flow\r\n- [ ] React components are split-up enough to avoid unnecessary re-rendering\r\n- [ ] Any code that only works in Electron is neatly separated from components\r\n\r\n### Testing\r\n- [ ] New feature / change is covered by acceptance tests\r\n- [ ] All existing acceptance tests are still up-to-date\r\n- [ ] New feature / change is covered by Daedalus Testing scenario\r\n- [ ] All existing Daedalus Testing scenarios are still up-to-date\r\n\r\n### After Review:\r\n- [ ] Merge PR\r\n- [ ] Delete source branch\r\n- [ ] Move ticket to `done` on the Youtrack board\r\n","created_at":"2018-08-06T22:33:09Z","updated_at":"2018-08-22T20:43:47Z","closed_at":"2018-08-22T20:43:47Z","merged_at":"2018-08-22T20:43:47Z","merge_commit_sha":"a13312cf6dd1a50d1540a07a566ea79b291137b4","assignee":{"login":"MarcusHurney","id":13347886,"node_id":"MDQ6VXNlcjEzMzQ3ODg2","avatar_url":"https://avatars2.githubusercontent.com/u/13347886?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcusHurney","html_url":"https://github.com/MarcusHurney","followers_url":"https://api.github.com/users/MarcusHurney/followers","following_url":"https://api.github.com/users/MarcusHurney/following{/other_user}","gists_url":"https://api.github.com/users/MarcusHurney/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcusHurney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcusHurney/subscriptions","organizations_url":"https://api.github.com/users/MarcusHurney/orgs","repos_url":"https://api.github.com/users/MarcusHurney/repos","events_url":"https://api.github.com/users/MarcusHurney/events{/privacy}","received_events_url":"https://api.github.com/users/MarcusHurney/received_events","type":"User","site_admin":false},"assignees":[{"login":"MarcusHurney","id":13347886,"node_id":"MDQ6VXNlcjEzMzQ3ODg2","avatar_url":"https://avatars2.githubusercontent.com/u/13347886?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcusHurney","html_url":"https://github.com/MarcusHurney","followers_url":"https://api.github.com/users/MarcusHurney/followers","following_url":"https://api.github.com/users/MarcusHurney/following{/other_user}","gists_url":"https://api.github.com/users/MarcusHurney/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcusHurney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcusHurney/subscriptions","organizations_url":"https://api.github.com/users/MarcusHurney/orgs","repos_url":"https://api.github.com/users/MarcusHurney/repos","events_url":"https://api.github.com/users/MarcusHurney/events{/privacy}","received_events_url":"https://api.github.com/users/MarcusHurney/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"DominikGuzei","id":172414,"node_id":"MDQ6VXNlcjE3MjQxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/172414?v=4","gravatar_id":"","url":"https://api.github.com/users/DominikGuzei","html_url":"https://github.com/DominikGuzei","followers_url":"https://api.github.com/users/DominikGuzei/followers","following_url":"https://api.github.com/users/DominikGuzei/following{/other_user}","gists_url":"https://api.github.com/users/DominikGuzei/gists{/gist_id}","starred_url":"https://api.github.com/users/DominikGuzei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominikGuzei/subscriptions","organizations_url":"https://api.github.com/users/DominikGuzei/orgs","repos_url":"https://api.github.com/users/DominikGuzei/repos","events_url":"https://api.github.com/users/DominikGuzei/events{/privacy}","received_events_url":"https://api.github.com/users/DominikGuzei/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":455603673,"node_id":"MDU6TGFiZWw0NTU2MDM2NzM=","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/feature","name":"feature","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1037/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1037/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1037/comments","statuses_url":"https://api.github.com/repos/input-output-hk/daedalus/statuses/a1dfc43d011afb751433d10974d0ff858dd92972","head":{"label":"input-output-hk:feature/ddw-356-v1-api-endpoints-integration-2-5","ref":"feature/ddw-356-v1-api-endpoints-integration-2-5","sha":"a1dfc43d011afb751433d10974d0ff858dd92972","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70064828,"node_id":"MDEwOlJlcG9zaXRvcnk3MDA2NDgyOA==","name":"daedalus","full_name":"input-output-hk/daedalus","owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/daedalus","description":"Daedalus - cryptocurrency wallet","fork":false,"url":"https://api.github.com/repos/input-output-hk/daedalus","forks_url":"https://api.github.com/repos/input-output-hk/daedalus/forks","keys_url":"https://api.github.com/repos/input-output-hk/daedalus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/daedalus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/daedalus/teams","hooks_url":"https://api.github.com/repos/input-output-hk/daedalus/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/daedalus/events","assignees_url":"https://api.github.com/repos/input-output-hk/daedalus/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/daedalus/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/daedalus/tags","blobs_url":"https://api.github.com/repos/input-output-hk/daedalus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/daedalus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/daedalus/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/daedalus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/daedalus/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/daedalus/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/daedalus/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/daedalus/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/daedalus/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/daedalus/subscription","commits_url":"https://api.github.com/repos/input-output-hk/daedalus/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/daedalus/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/daedalus/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/daedalus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/daedalus/merges","archive_url":"https://api.github.com/repos/input-output-hk/daedalus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/daedalus/downloads","issues_url":"https://api.github.com/repos/input-output-hk/daedalus/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/daedalus/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/daedalus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/daedalus/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/daedalus/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/daedalus/deployments","created_at":"2016-10-05T13:48:54Z","updated_at":"2018-08-21T23:25:23Z","pushed_at":"2018-08-22T20:43:47Z","git_url":"git://github.com/input-output-hk/daedalus.git","ssh_url":"git@github.com:input-output-hk/daedalus.git","clone_url":"https://github.com/input-output-hk/daedalus.git","svn_url":"https://github.com/input-output-hk/daedalus","homepage":null,"size":129357,"stargazers_count":477,"watchers_count":477,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":153,"open_issues":108,"watchers":477,"default_branch":"develop"}},"base":{"label":"input-output-hk:feature/ddw-321-v1-api-integration","ref":"feature/ddw-321-v1-api-integration","sha":"c99a9545d602192f2fac277dae2bb3e9291bfd4f","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70064828,"node_id":"MDEwOlJlcG9zaXRvcnk3MDA2NDgyOA==","name":"daedalus","full_name":"input-output-hk/daedalus","owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/daedalus","description":"Daedalus - cryptocurrency wallet","fork":false,"url":"https://api.github.com/repos/input-output-hk/daedalus","forks_url":"https://api.github.com/repos/input-output-hk/daedalus/forks","keys_url":"https://api.github.com/repos/input-output-hk/daedalus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/daedalus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/daedalus/teams","hooks_url":"https://api.github.com/repos/input-output-hk/daedalus/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/daedalus/events","assignees_url":"https://api.github.com/repos/input-output-hk/daedalus/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/daedalus/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/daedalus/tags","blobs_url":"https://api.github.com/repos/input-output-hk/daedalus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/daedalus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/daedalus/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/daedalus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/daedalus/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/daedalus/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/daedalus/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/daedalus/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/daedalus/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/daedalus/subscription","commits_url":"https://api.github.com/repos/input-output-hk/daedalus/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/daedalus/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/daedalus/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/daedalus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/daedalus/merges","archive_url":"https://api.github.com/repos/input-output-hk/daedalus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/daedalus/downloads","issues_url":"https://api.github.com/repos/input-output-hk/daedalus/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/daedalus/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/daedalus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/daedalus/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/daedalus/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/daedalus/deployments","created_at":"2016-10-05T13:48:54Z","updated_at":"2018-08-21T23:25:23Z","pushed_at":"2018-08-22T20:43:47Z","git_url":"git://github.com/input-output-hk/daedalus.git","ssh_url":"git@github.com:input-output-hk/daedalus.git","clone_url":"https://github.com/input-output-hk/daedalus.git","svn_url":"https://github.com/input-output-hk/daedalus","homepage":null,"size":129357,"stargazers_count":477,"watchers_count":477,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":153,"open_issues":108,"watchers":477,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1037"},"html":{"href":"https://github.com/input-output-hk/daedalus/pull/1037"},"issue":{"href":"https://api.github.com/repos/input-output-hk/daedalus/issues/1037"},"comments":{"href":"https://api.github.com/repos/input-output-hk/daedalus/issues/1037/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1037/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/daedalus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1037/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/daedalus/statuses/a1dfc43d011afb751433d10974d0ff858dd92972"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MarcusHurney","id":13347886,"node_id":"MDQ6VXNlcjEzMzQ3ODg2","avatar_url":"https://avatars2.githubusercontent.com/u/13347886?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcusHurney","html_url":"https://github.com/MarcusHurney","followers_url":"https://api.github.com/users/MarcusHurney/followers","following_url":"https://api.github.com/users/MarcusHurney/following{/other_user}","gists_url":"https://api.github.com/users/MarcusHurney/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcusHurney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcusHurney/subscriptions","organizations_url":"https://api.github.com/users/MarcusHurney/orgs","repos_url":"https://api.github.com/users/MarcusHurney/repos","events_url":"https://api.github.com/users/MarcusHurney/events{/privacy}","received_events_url":"https://api.github.com/users/MarcusHurney/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":26,"additions":137,"deletions":107,"changed_files":18}}
{"actor":{"display_login":"MarcusHurney"}}