{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/168760956","pull_request_review_id":97183313,"id":168760956,"diff_hunk":"@@ -19,617 +21,368 @@\n \n #include \"geometry/polygon.hpp\"\n \n-#include \"coding/internal/file_data.hpp\"\n #include \"coding/file_container.hpp\"\n #include \"coding/file_name_utils.hpp\"\n+#include \"coding/internal/file_data.hpp\"\n \n #include \"base/assert.hpp\"\n #include \"base/logging.hpp\"\n #include \"base/scope_guard.hpp\"\n #include \"base/string_utils.hpp\"\n \n-namespace\n+#include <list>\n+#include <memory>\n+#include <vector>\n+\n+using namespace std;\n+\n+namespace feature\n+{\n+class FeaturesCollector2 : public FeaturesCollector\n {\n-  typedef pair<uint64_t, uint64_t> CellAndOffsetT;\n+  DISALLOW_COPY_AND_MOVE(FeaturesCollector2);\n \n-  class CalculateMidPoints\n-  {\n-    m2::PointD m_midLoc, m_midAll;\n-    size_t m_locCount, m_allCount;\n-    uint32_t m_coordBits;\n+  FilesContainerW m_writer;","path":"generator/feature_sorter.cpp","position":53,"original_position":53,"commit_id":"baeffb30c02734afd255491a72be3dad33e3a4e7","original_commit_id":"baeffb30c02734afd255491a72be3dad33e3a4e7","user":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"body":"тут вообще порядок всего перемешан (private, потом public, потом опять private вперемешку поля, методы, подкалссы и т.д.), давай я отдельным pr  всё переставлю, а то и так не ясно что в этом реквесте добавлено, а что переехало","created_at":"2018-02-16T13:52:47Z","updated_at":"2018-02-16T13:52:47Z","html_url":"https://github.com/mapsme/omim/pull/8093#discussion_r168760956","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/8093","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/168760956"},"html":{"href":"https://github.com/mapsme/omim/pull/8093#discussion_r168760956"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8093"}},"in_reply_to_id":168749607},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/8093","id":169073697,"html_url":"https://github.com/mapsme/omim/pull/8093","diff_url":"https://github.com/mapsme/omim/pull/8093.diff","patch_url":"https://github.com/mapsme/omim/pull/8093.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/8093","number":8093,"state":"open","locked":false,"title":"[geocoder] Generate locality data","user":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"body":"В этом PR добавление генерации промежуточных данных для создания индекса геокодера и добавление в generator_tool запуска генерации индекса геокодера.\r\n\r\nПромежуточные данные генерятся из *.mwm.tmp, полученных при сборке карт.\r\n\r\nВ первом коммите только применение clang-format к generator/feature_sorter.* ","created_at":"2018-02-14T10:36:39Z","updated_at":"2018-02-16T13:52:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e62c0305e0803c30a82ef0631affc4ad51a0c4a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/8093/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/8093/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/8093/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/baeffb30c02734afd255491a72be3dad33e3a4e7","head":{"label":"tatiana-kondakova:generate_locality_data","ref":"generate_locality_data","sha":"baeffb30c02734afd255491a72be3dad33e3a4e7","user":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"repo":{"id":98180090,"name":"omim","full_name":"tatiana-kondakova/omim","owner":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tatiana-kondakova/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":true,"url":"https://api.github.com/repos/tatiana-kondakova/omim","forks_url":"https://api.github.com/repos/tatiana-kondakova/omim/forks","keys_url":"https://api.github.com/repos/tatiana-kondakova/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tatiana-kondakova/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tatiana-kondakova/omim/teams","hooks_url":"https://api.github.com/repos/tatiana-kondakova/omim/hooks","issue_events_url":"https://api.github.com/repos/tatiana-kondakova/omim/issues/events{/number}","events_url":"https://api.github.com/repos/tatiana-kondakova/omim/events","assignees_url":"https://api.github.com/repos/tatiana-kondakova/omim/assignees{/user}","branches_url":"https://api.github.com/repos/tatiana-kondakova/omim/branches{/branch}","tags_url":"https://api.github.com/repos/tatiana-kondakova/omim/tags","blobs_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tatiana-kondakova/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/tatiana-kondakova/omim/languages","stargazers_url":"https://api.github.com/repos/tatiana-kondakova/omim/stargazers","contributors_url":"https://api.github.com/repos/tatiana-kondakova/omim/contributors","subscribers_url":"https://api.github.com/repos/tatiana-kondakova/omim/subscribers","subscription_url":"https://api.github.com/repos/tatiana-kondakova/omim/subscription","commits_url":"https://api.github.com/repos/tatiana-kondakova/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/tatiana-kondakova/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/tatiana-kondakova/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/tatiana-kondakova/omim/contents/{+path}","compare_url":"https://api.github.com/repos/tatiana-kondakova/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tatiana-kondakova/omim/merges","archive_url":"https://api.github.com/repos/tatiana-kondakova/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tatiana-kondakova/omim/downloads","issues_url":"https://api.github.com/repos/tatiana-kondakova/omim/issues{/number}","pulls_url":"https://api.github.com/repos/tatiana-kondakova/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/tatiana-kondakova/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/tatiana-kondakova/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tatiana-kondakova/omim/labels{/name}","releases_url":"https://api.github.com/repos/tatiana-kondakova/omim/releases{/id}","deployments_url":"https://api.github.com/repos/tatiana-kondakova/omim/deployments","created_at":"2017-07-24T10:44:21Z","updated_at":"2017-07-24T10:45:30Z","pushed_at":"2018-02-15T15:28:26Z","git_url":"git://github.com/tatiana-kondakova/omim.git","ssh_url":"git@github.com:tatiana-kondakova/omim.git","clone_url":"https://github.com/tatiana-kondakova/omim.git","svn_url":"https://github.com/tatiana-kondakova/omim","homepage":"","size":3613044,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"74d4bfcc69c4422ed5410e256d12920126fd3424","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2018-02-16T10:03:47Z","pushed_at":"2018-02-16T13:47:14Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":3641068,"stargazers_count":2551,"watchers_count":2551,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":552,"mirror_url":null,"archived":false,"open_issues_count":648,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":552,"open_issues":648,"watchers":2551,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8093"},"html":{"href":"https://github.com/mapsme/omim/pull/8093"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/8093"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/8093/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8093/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/8093/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/baeffb30c02734afd255491a72be3dad33e3a4e7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tatiana-kondakova"}}