{"action":"created","issue":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1509","repository_url":"https://api.github.com/repos/CorfuDB/CorfuDB","labels_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1509/labels{/name}","comments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1509/comments","events_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1509/events","html_url":"https://github.com/CorfuDB/CorfuDB/pull/1509","id":370386196,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDc1ODU4","number":1509,"title":"Corfu db logging","user":{"login":"xnull","id":314292,"node_id":"MDQ6VXNlcjMxNDI5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/314292?v=4","gravatar_id":"","url":"https://api.github.com/users/xnull","html_url":"https://github.com/xnull","followers_url":"https://api.github.com/users/xnull/followers","following_url":"https://api.github.com/users/xnull/following{/other_user}","gists_url":"https://api.github.com/users/xnull/gists{/gist_id}","starred_url":"https://api.github.com/users/xnull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xnull/subscriptions","organizations_url":"https://api.github.com/users/xnull/orgs","repos_url":"https://api.github.com/users/xnull/repos","events_url":"https://api.github.com/users/xnull/events{/privacy}","received_events_url":"https://api.github.com/users/xnull/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-15T23:49:18Z","updated_at":"2018-10-16T00:59:51Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/1509","html_url":"https://github.com/CorfuDB/CorfuDB/pull/1509","diff_url":"https://github.com/CorfuDB/CorfuDB/pull/1509.diff","patch_url":"https://github.com/CorfuDB/CorfuDB/pull/1509.patch"},"body":"## Overview\r\n\r\nDescription:\r\nSetup logging in corfu db. `Infrastructure`/resource directory contains two logback configs:\r\n - logback.xml - for development purposes\r\n - logback.prod.xml - production config\r\n\r\nWhy should this be merged: \r\nThis PR provides logging config for production and development environments. The production config missing on prod environment.\r\n\r\nRelated issue(s) (if applicable): #<number>\r\n\r\n\r\n## Checklist (Definition of Done):\r\n\r\n- [x] There are no TODOs left in the code\r\n- [x] [Coding conventions](https://github.com/CorfuDB/CorfuDB/wiki/Corfu-Style-Guidelines) (e.g. for logging, unit tests) have been followed\r\n- [x] Change is covered by automated tests\r\n- [x] Public API has Javadoc\r\n"},"comment":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/comments/430064465","html_url":"https://github.com/CorfuDB/CorfuDB/pull/1509#issuecomment-430064465","issue_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1509","id":430064465,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDA2NDQ2NQ==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-10-16T00:59:51Z","updated_at":"2018-10-16T00:59:51Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509?src=pr&el=h1) Report\n> Merging [#1509](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509?src=pr&el=desc) into [master](https://codecov.io/gh/CorfuDB/CorfuDB/commit/871201f654bc8e164dd185bd15ee321d046fc89a?src=pr&el=desc) will **increase** coverage by `0.17%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509/graphs/tree.svg?width=650&token=Wouw9OaGMi&height=150&src=pr)](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1509      +/-   ##\n==========================================\n+ Coverage   70.07%   70.25%   +0.17%     \n==========================================\n  Files         270      270              \n  Lines       11940    11940              \n  Branches     1160     1160              \n==========================================\n+ Hits         8367     8388      +21     \n+ Misses       3103     3089      -14     \n+ Partials      470      463       -7\n```\n\n\n| [Impacted Files](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...org/corfudb/runtime/clients/NettyClientRouter.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509/diff?src=pr&el=tree#diff-cnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9jb3JmdWRiL3J1bnRpbWUvY2xpZW50cy9OZXR0eUNsaWVudFJvdXRlci5qYXZh) | `74.69% <0%> (+0.4%)` | :arrow_up: |\n| [...rg/corfudb/runtime/object/VersionLockedObject.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509/diff?src=pr&el=tree#diff-cnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9jb3JmdWRiL3J1bnRpbWUvb2JqZWN0L1ZlcnNpb25Mb2NrZWRPYmplY3QuamF2YQ==) | `92.63% <0%> (+0.52%)` | :arrow_up: |\n| [.../java/org/corfudb/infrastructure/LayoutServer.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509/diff?src=pr&el=tree#diff-aW5mcmFzdHJ1Y3R1cmUvc3JjL21haW4vamF2YS9vcmcvY29yZnVkYi9pbmZyYXN0cnVjdHVyZS9MYXlvdXRTZXJ2ZXIuamF2YQ==) | `79.31% <0%> (+0.68%)` | :arrow_up: |\n| [...main/java/org/corfudb/runtime/view/LayoutView.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509/diff?src=pr&el=tree#diff-cnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9jb3JmdWRiL3J1bnRpbWUvdmlldy9MYXlvdXRWaWV3LmphdmE=) | `81.42% <0%> (+0.71%)` | :arrow_up: |\n| [...va/org/corfudb/infrastructure/ManagementAgent.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509/diff?src=pr&el=tree#diff-aW5mcmFzdHJ1Y3R1cmUvc3JjL21haW4vamF2YS9vcmcvY29yZnVkYi9pbmZyYXN0cnVjdHVyZS9NYW5hZ2VtZW50QWdlbnQuamF2YQ==) | `83.27% <0%> (+1.33%)` | :arrow_up: |\n| [...va/org/corfudb/protocols/wireprotocol/LogData.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509/diff?src=pr&el=tree#diff-cnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9jb3JmdWRiL3Byb3RvY29scy93aXJlcHJvdG9jb2wvTG9nRGF0YS5qYXZh) | `85.03% <0%> (+1.57%)` | :arrow_up: |\n| [...in/java/org/corfudb/recovery/FastObjectLoader.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509/diff?src=pr&el=tree#diff-cnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9jb3JmdWRiL3JlY292ZXJ5L0Zhc3RPYmplY3RMb2FkZXIuamF2YQ==) | `85.33% <0%> (+1.66%)` | :arrow_up: |\n| [...fudb/protocols/wireprotocol/MsgHandlingFilter.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509/diff?src=pr&el=tree#diff-cnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9jb3JmdWRiL3Byb3RvY29scy93aXJlcHJvdG9jb2wvTXNnSGFuZGxpbmdGaWx0ZXIuamF2YQ==) | `33.96% <0%> (+1.88%)` | :arrow_up: |\n| [...orfudb/runtime/view/workflows/WorkflowRequest.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509/diff?src=pr&el=tree#diff-cnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9jb3JmdWRiL3J1bnRpbWUvdmlldy93b3JrZmxvd3MvV29ya2Zsb3dSZXF1ZXN0LmphdmE=) | `86.36% <0%> (+2.27%)` | :arrow_up: |\n| [...udb/infrastructure/management/HealingDetector.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509/diff?src=pr&el=tree#diff-aW5mcmFzdHJ1Y3R1cmUvc3JjL21haW4vamF2YS9vcmcvY29yZnVkYi9pbmZyYXN0cnVjdHVyZS9tYW5hZ2VtZW50L0hlYWxpbmdEZXRlY3Rvci5qYXZh) | `86.66% <0%> (+6.66%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509?src=pr&el=footer). Last update [871201f...251d313](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1509?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}