{"action":"created","comment":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/214677774","pull_request_review_id":151783023,"id":214677774,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDY3Nzc3NA==","diff_hunk":"@@ -0,0 +1,15 @@\n+﻿using Unity.Entities;\n+\n+namespace Improbable.Gdk.Core.GameObjectRepresentation","path":"workers/unity/Packages/com.improbable.gdk.core/GameObjectRepresentation/GameObjectRepresentationSystemHelper.cs","position":3,"original_position":3,"commit_id":"259b0f951015aa67570655e8d1b846c3921facd3","original_commit_id":"259b0f951015aa67570655e8d1b846c3921facd3","user":{"login":"jessicafalk","id":31853332,"node_id":"MDQ6VXNlcjMxODUzMzMy","avatar_url":"https://avatars3.githubusercontent.com/u/31853332?v=4","gravatar_id":"","url":"https://api.github.com/users/jessicafalk","html_url":"https://github.com/jessicafalk","followers_url":"https://api.github.com/users/jessicafalk/followers","following_url":"https://api.github.com/users/jessicafalk/following{/other_user}","gists_url":"https://api.github.com/users/jessicafalk/gists{/gist_id}","starred_url":"https://api.github.com/users/jessicafalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessicafalk/subscriptions","organizations_url":"https://api.github.com/users/jessicafalk/orgs","repos_url":"https://api.github.com/users/jessicafalk/repos","events_url":"https://api.github.com/users/jessicafalk/events{/privacy}","received_events_url":"https://api.github.com/users/jessicafalk/received_events","type":"User","site_admin":false},"body":"what kind of codegen do we need for it?","created_at":"2018-09-03T12:41:37Z","updated_at":"2018-09-03T12:41:37Z","html_url":"https://github.com/spatialos/UnityGDK/pull/272#discussion_r214677774","pull_request_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/272","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/214677774"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/272#discussion_r214677774"},"pull_request":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/272"}},"in_reply_to_id":214673077},"pull_request":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/272","id":211491661,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNDkxNjYx","html_url":"https://github.com/spatialos/UnityGDK/pull/272","diff_url":"https://github.com/spatialos/UnityGDK/pull/272.diff","patch_url":"https://github.com/spatialos/UnityGDK/pull/272.patch","issue_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/272","number":272,"state":"open","locked":false,"title":"UTY-969: Moved standard GameObject instantiation out of Playground","user":{"login":"MPeti01","id":25401316,"node_id":"MDQ6VXNlcjI1NDAxMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/25401316?v=4","gravatar_id":"","url":"https://api.github.com/users/MPeti01","html_url":"https://github.com/MPeti01","followers_url":"https://api.github.com/users/MPeti01/followers","following_url":"https://api.github.com/users/MPeti01/following{/other_user}","gists_url":"https://api.github.com/users/MPeti01/gists{/gist_id}","starred_url":"https://api.github.com/users/MPeti01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MPeti01/subscriptions","organizations_url":"https://api.github.com/users/MPeti01/orgs","repos_url":"https://api.github.com/users/MPeti01/repos","events_url":"https://api.github.com/users/MPeti01/events{/privacy}","received_events_url":"https://api.github.com/users/MPeti01/received_events","type":"User","site_admin":false},"body":"**Contributions**: We are not currently taking public contributions - see our [contributions](CONTRIBUTING.md) policy. However, we are accepting issues and we do want your [feedback](../README.md#give-us-feedback).\r\n\r\n-------\r\n\r\n#### Description\r\nTLDR: Moved the GameObjectInitializationSystem into the MonoBehaviours module. User now just has to call a method from their SystemConfig to enable the setup performed previously by that system in Playground\r\n\r\n- Moved the EntityGameObjectLinker into its own System\r\n- Created new assembly that had access to both Core and the Generated assembly (for access to the metadata and transform components)\r\n- Moved GameObjectInitializationSystem and its helper class EntityGameObjectCreator there\r\n- Moved the corresponding tests, removing the Tests folder in Playground\r\n- Removed the PrefabConfig class, now just checking `Prefab/<WorkerType>/<EntityName>` and `Prefabs/Common/<EntityName>`, where <EntityName> is retrieved from the Metadata component.\r\n- Moved prefabs accordingly\r\n- Split adding MonoBehaviour-related Systems into separate helper classes from the CoreSystemHelper class\r\n\r\n#### Tests\r\nTests still passing, Playground appears to work\r\n#### Documentation\r\nN/A\r\n#### Primary reviewers\r\n@firtina-improbable @jamiebrynes7 ","created_at":"2018-08-28T16:57:51Z","updated_at":"2018-09-03T12:41:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be2da1113c5704de8dae530da968167926be9cdb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":999948057,"node_id":"MDU6TGFiZWw5OTk5NDgwNTc=","url":"https://api.github.com/repos/spatialos/UnityGDK/labels/size/XL","name":"size/XL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/272/commits","review_comments_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/272/comments","review_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/272/comments","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/259b0f951015aa67570655e8d1b846c3921facd3","head":{"label":"spatialos:feature/UTY-969/monobehaviour-setup-workflow","ref":"feature/UTY-969/monobehaviour-setup-workflow","sha":"259b0f951015aa67570655e8d1b846c3921facd3","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-09-03T11:04:11Z","pushed_at":"2018-09-03T12:07:12Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":187798,"stargazers_count":83,"watchers_count":83,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":10,"watchers":83,"default_branch":"master"}},"base":{"label":"spatialos:master","ref":"master","sha":"3f075c2e45851ee0a9c9523a756bd4d658614b35","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-09-03T11:04:11Z","pushed_at":"2018-09-03T12:07:12Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":187798,"stargazers_count":83,"watchers_count":83,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":10,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/272"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/272"},"issue":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/272"},"comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/spatialos/UnityGDK/statuses/259b0f951015aa67570655e8d1b846c3921facd3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jessicafalk"}}