{"action":"opened","issue":{"url":"https://api.github.com/repos/flutter/flutter/issues/18741","repository_url":"https://api.github.com/repos/flutter/flutter","labels_url":"https://api.github.com/repos/flutter/flutter/issues/18741/labels{/name}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/18741/comments","events_url":"https://api.github.com/repos/flutter/flutter/issues/18741/events","html_url":"https://github.com/flutter/flutter/issues/18741","id":335016763,"node_id":"MDU6SXNzdWUzMzUwMTY3NjM=","number":18741,"title":"test_smoke_test/timeout_test_pass.dart is flaky","user":{"login":"jcollins-g","id":14116827,"node_id":"MDQ6VXNlcjE0MTE2ODI3","avatar_url":"https://avatars3.githubusercontent.com/u/14116827?v=4","gravatar_id":"","url":"https://api.github.com/users/jcollins-g","html_url":"https://github.com/jcollins-g","followers_url":"https://api.github.com/users/jcollins-g/followers","following_url":"https://api.github.com/users/jcollins-g/following{/other_user}","gists_url":"https://api.github.com/users/jcollins-g/gists{/gist_id}","starred_url":"https://api.github.com/users/jcollins-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcollins-g/subscriptions","organizations_url":"https://api.github.com/users/jcollins-g/orgs","repos_url":"https://api.github.com/users/jcollins-g/repos","events_url":"https://api.github.com/users/jcollins-g/events{/privacy}","received_events_url":"https://api.github.com/users/jcollins-g/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-22T20:57:18Z","updated_at":"2018-06-22T20:57:18Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"@Hixie \r\n\r\nTrying to land #18725 and ran into a flake in this test at least twice:\r\n\r\n```\r\n⏩ RUNNING: cd dev\\automated_tests; ..\\..\\bin\\flutter.bat test test_smoke_test\\timeout_pass_test.dart\r\n00:11 +0: flutter_test timeout logic - addTime - positive                                                                                                                                              \r\n══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════\r\nThe following TimeoutException was thrown running a test:\r\nTimeoutException after 0:00:04.000000: The test exceeded the timeout. It may have hung.\r\nConsider using \"addTime\" to increase the timeout before expensive operations.\r\nWhen the exception was thrown, this was the stack:\r\n#2      AutomatedTestWidgetsFlutterBinding._checkTimeout (package:flutter_test/src/binding.dart:786:25)\r\n#16     _Timer._runTimers (dart:isolate/runtime/libtimer_impl.dart:382:19)\r\n#17     _Timer._handleMessage (dart:isolate/runtime/libtimer_impl.dart:416:5)\r\n#18     _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:165:12)\r\n#22     AutomatedTestWidgetsFlutterBinding.runTest (package:flutter_test/src/binding.dart:836:25)\r\n#23     testWidgets.<anonymous closure> (package:flutter_test/src/widget_tester.dart:68:22)\r\n#24     Declarer.test.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test/src/backend/declarer.dart:161:27)\r\n#27     Declarer.test.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test/src/backend/declarer.dart:0:0)\r\n#28     Invoker.waitForOutstandingCallbacks.<anonymous closure> (package:test/src/backend/invoker.dart:249:15)\r\n#34     Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test/src/backend/invoker.dart:402:15)\r\n(elided 24 frames from package dart:async and package stack_trace)\r\nThe test description was:\r\nflutter_test timeout logic - addTime - positive\r\n════════════════════════════════════════════════════════════════════════════════════════════════════\r\n00:11 +0 -1: flutter_test timeout logic - addTime - positive [E]                                                                                                                                       \r\n  Test failed. See exception logs above.\r\n  The test description was: flutter_test timeout logic - addTime - positive\r\n  \r\n══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════\r\nThe following assertion was thrown running a test (but after the test had completed):\r\n'package:flutter_test/src/binding.dart': Failed assertion: line 873 pos 12: '_currentFakeAsync !=\r\nnull': is not true.\r\nEither the assertion indicates an error in the framework itself, or we should provide substantially\r\nmore information in this error message to help you determine and fix the underlying cause.\r\nIn either case, please report this assertion by filing a bug on GitHub:\r\n  https://github.com/flutter/flutter/issues/new\r\nWhen the exception was thrown, this was the stack:\r\n#2      AutomatedTestWidgetsFlutterBinding.asyncBarrier (package:flutter_test/src/binding.dart)\r\n#3      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:519:5)\r\n<asynchronous suspension>\r\n#6      TestWidgetsFlutterBinding._runTest (package:flutter_test/src/binding.dart:502:14)\r\n#7      AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:846:24)\r\n#13     AutomatedTestWidgetsFlutterBinding.runTest (package:flutter_test/src/binding.dart:843:15)\r\n00:11 +0 -1: Some tests failed.                                                                                                                                                                        \r\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\r\nERROR: Last command exited with 1 (expected: zero).\r\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\r\n```\r\n\r\nThe [test code](https://github.com/flutter/flutter/blob/d6465c477ab5123e61b57f560eca96128226683e/dev/automated_tests/test_smoke_test/timeout_pass_test.dart#L10) seems to suggest that this is just a case of AppVeyor's dart run not being quite fast enough sometimes to get in under the timeout (only 500ms of wiggle room).\r\n\r\nI'll try giving it more wiggle room, but this sort of timing test depending on a real clock always has the potential to flake.\r\n\r\nFull log: https://ci.appveyor.com/project/flutter/flutter/build/1.0.14468"}}
{"actor":{"display_login":"jcollins-g"}}