{"action":"opened","number":18984,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/18984","id":210892764,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwODkyNzY0","html_url":"https://github.com/apple/swift/pull/18984","diff_url":"https://github.com/apple/swift/pull/18984.diff","patch_url":"https://github.com/apple/swift/pull/18984.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/18984","number":18984,"state":"open","locked":false,"title":"[benchmark] Add preliminary helper for measuring instructions executed.","user":{"login":"graydon","id":14097,"node_id":"MDQ6VXNlcjE0MDk3","avatar_url":"https://avatars3.githubusercontent.com/u/14097?v=4","gravatar_id":"","url":"https://api.github.com/users/graydon","html_url":"https://github.com/graydon","followers_url":"https://api.github.com/users/graydon/followers","following_url":"https://api.github.com/users/graydon/following{/other_user}","gists_url":"https://api.github.com/users/graydon/gists{/gist_id}","starred_url":"https://api.github.com/users/graydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graydon/subscriptions","organizations_url":"https://api.github.com/users/graydon/orgs","repos_url":"https://api.github.com/users/graydon/repos","events_url":"https://api.github.com/users/graydon/events{/privacy}","received_events_url":"https://api.github.com/users/graydon/received_events","type":"User","site_admin":false},"body":"After my delight at discovering `proc_pid_rusage` / `rusage_info_v4` interface that allows you to inspect your process' PMC-measured count of executed instructions, I figured the compiler shouldn't have all the fun, so added a helper function here to the runtime benchmark harness as well.\r\n\r\nThe key point here is that the numbers it reports have _substantially_ lower noise than timers, and tend to be more stable between machines. So I think it's worth the effort to wire them up, get more precise reporting.\r\n\r\nImplementation-wise: there's something amiss with the way the `proc_pid_rusage` symbol imports using `#include` within the module (see comment in patch -- I am a bit stumped) and I figure you're going to want to rearrange a bunch of stuff to treat these numbers in a useful way, so I just made a first cut here. Feel free to clone this change, close the PR and Do It How You Prefer. I just figured this was a convenient way to get the ball rolling.","created_at":"2018-08-25T08:39:08Z","updated_at":"2018-08-25T08:39:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/18984/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/18984/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/18984/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/94725dff2be49967facfe1e893eb2072ba74dce9","head":{"label":"graydon:follow-my-simple-instruction","ref":"follow-my-simple-instruction","sha":"94725dff2be49967facfe1e893eb2072ba74dce9","user":{"login":"graydon","id":14097,"node_id":"MDQ6VXNlcjE0MDk3","avatar_url":"https://avatars3.githubusercontent.com/u/14097?v=4","gravatar_id":"","url":"https://api.github.com/users/graydon","html_url":"https://github.com/graydon","followers_url":"https://api.github.com/users/graydon/followers","following_url":"https://api.github.com/users/graydon/following{/other_user}","gists_url":"https://api.github.com/users/graydon/gists{/gist_id}","starred_url":"https://api.github.com/users/graydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graydon/subscriptions","organizations_url":"https://api.github.com/users/graydon/orgs","repos_url":"https://api.github.com/users/graydon/repos","events_url":"https://api.github.com/users/graydon/events{/privacy}","received_events_url":"https://api.github.com/users/graydon/received_events","type":"User","site_admin":false},"repo":{"id":66865548,"node_id":"MDEwOlJlcG9zaXRvcnk2Njg2NTU0OA==","name":"swift","full_name":"graydon/swift","owner":{"login":"graydon","id":14097,"node_id":"MDQ6VXNlcjE0MDk3","avatar_url":"https://avatars3.githubusercontent.com/u/14097?v=4","gravatar_id":"","url":"https://api.github.com/users/graydon","html_url":"https://github.com/graydon","followers_url":"https://api.github.com/users/graydon/followers","following_url":"https://api.github.com/users/graydon/following{/other_user}","gists_url":"https://api.github.com/users/graydon/gists{/gist_id}","starred_url":"https://api.github.com/users/graydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graydon/subscriptions","organizations_url":"https://api.github.com/users/graydon/orgs","repos_url":"https://api.github.com/users/graydon/repos","events_url":"https://api.github.com/users/graydon/events{/privacy}","received_events_url":"https://api.github.com/users/graydon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/graydon/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/graydon/swift","forks_url":"https://api.github.com/repos/graydon/swift/forks","keys_url":"https://api.github.com/repos/graydon/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graydon/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graydon/swift/teams","hooks_url":"https://api.github.com/repos/graydon/swift/hooks","issue_events_url":"https://api.github.com/repos/graydon/swift/issues/events{/number}","events_url":"https://api.github.com/repos/graydon/swift/events","assignees_url":"https://api.github.com/repos/graydon/swift/assignees{/user}","branches_url":"https://api.github.com/repos/graydon/swift/branches{/branch}","tags_url":"https://api.github.com/repos/graydon/swift/tags","blobs_url":"https://api.github.com/repos/graydon/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graydon/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graydon/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/graydon/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graydon/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/graydon/swift/languages","stargazers_url":"https://api.github.com/repos/graydon/swift/stargazers","contributors_url":"https://api.github.com/repos/graydon/swift/contributors","subscribers_url":"https://api.github.com/repos/graydon/swift/subscribers","subscription_url":"https://api.github.com/repos/graydon/swift/subscription","commits_url":"https://api.github.com/repos/graydon/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/graydon/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/graydon/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/graydon/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/graydon/swift/contents/{+path}","compare_url":"https://api.github.com/repos/graydon/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graydon/swift/merges","archive_url":"https://api.github.com/repos/graydon/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graydon/swift/downloads","issues_url":"https://api.github.com/repos/graydon/swift/issues{/number}","pulls_url":"https://api.github.com/repos/graydon/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/graydon/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/graydon/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graydon/swift/labels{/name}","releases_url":"https://api.github.com/repos/graydon/swift/releases{/id}","deployments_url":"https://api.github.com/repos/graydon/swift/deployments","created_at":"2016-08-29T17:37:10Z","updated_at":"2018-04-10T23:44:15Z","pushed_at":"2018-08-25T08:31:30Z","git_url":"git://github.com/graydon/swift.git","ssh_url":"git@github.com:graydon/swift.git","clone_url":"https://github.com/graydon/swift.git","svn_url":"https://github.com/graydon/swift","homepage":"https://swift.org/","size":318113,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"f3f07ec055e1960d01fb53a53c7731b5a496c0f1","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-08-25T06:55:53Z","pushed_at":"2018-08-25T08:24:50Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":332213,"stargazers_count":44952,"watchers_count":44952,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7089,"mirror_url":null,"archived":false,"open_issues_count":394,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7089,"open_issues":394,"watchers":44952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/18984"},"html":{"href":"https://github.com/apple/swift/pull/18984"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/18984"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/18984/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/18984/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/18984/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/94725dff2be49967facfe1e893eb2072ba74dce9"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":63,"deletions":0,"changed_files":4}}
{"actor":{"display_login":"graydon"}}