{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla-tw/Rocket/issues/1955","repository_url":"https://api.github.com/repos/mozilla-tw/Rocket","labels_url":"https://api.github.com/repos/mozilla-tw/Rocket/issues/1955/labels{/name}","comments_url":"https://api.github.com/repos/mozilla-tw/Rocket/issues/1955/comments","events_url":"https://api.github.com/repos/mozilla-tw/Rocket/issues/1955/events","html_url":"https://github.com/mozilla-tw/Rocket/pull/1955","id":324486017,"number":1955,"title":"Use the value from Firebase, if disabled will return the default value","user":{"login":"cnevinc","id":1287363,"avatar_url":"https://avatars3.githubusercontent.com/u/1287363?v=4","gravatar_id":"","url":"https://api.github.com/users/cnevinc","html_url":"https://github.com/cnevinc","followers_url":"https://api.github.com/users/cnevinc/followers","following_url":"https://api.github.com/users/cnevinc/following{/other_user}","gists_url":"https://api.github.com/users/cnevinc/gists{/gist_id}","starred_url":"https://api.github.com/users/cnevinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnevinc/subscriptions","organizations_url":"https://api.github.com/users/cnevinc/orgs","repos_url":"https://api.github.com/users/cnevinc/repos","events_url":"https://api.github.com/users/cnevinc/events{/privacy}","received_events_url":"https://api.github.com/users/cnevinc/received_events","type":"User","site_admin":false},"labels":[{"id":705006869,"url":"https://api.github.com/repos/mozilla-tw/Rocket/labels/Uplift","name":"Uplift","color":"b60205","default":false}],"state":"closed","locked":false,"assignee":{"login":"cnevinc","id":1287363,"avatar_url":"https://avatars3.githubusercontent.com/u/1287363?v=4","gravatar_id":"","url":"https://api.github.com/users/cnevinc","html_url":"https://github.com/cnevinc","followers_url":"https://api.github.com/users/cnevinc/followers","following_url":"https://api.github.com/users/cnevinc/following{/other_user}","gists_url":"https://api.github.com/users/cnevinc/gists{/gist_id}","starred_url":"https://api.github.com/users/cnevinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnevinc/subscriptions","organizations_url":"https://api.github.com/users/cnevinc/orgs","repos_url":"https://api.github.com/users/cnevinc/repos","events_url":"https://api.github.com/users/cnevinc/events{/privacy}","received_events_url":"https://api.github.com/users/cnevinc/received_events","type":"User","site_admin":false},"assignees":[{"login":"cnevinc","id":1287363,"avatar_url":"https://avatars3.githubusercontent.com/u/1287363?v=4","gravatar_id":"","url":"https://api.github.com/users/cnevinc","html_url":"https://github.com/cnevinc","followers_url":"https://api.github.com/users/cnevinc/followers","following_url":"https://api.github.com/users/cnevinc/following{/other_user}","gists_url":"https://api.github.com/users/cnevinc/gists{/gist_id}","starred_url":"https://api.github.com/users/cnevinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnevinc/subscriptions","organizations_url":"https://api.github.com/users/cnevinc/orgs","repos_url":"https://api.github.com/users/cnevinc/repos","events_url":"https://api.github.com/users/cnevinc/events{/privacy}","received_events_url":"https://api.github.com/users/cnevinc/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mozilla-tw/Rocket/milestones/26","html_url":"https://github.com/mozilla-tw/Rocket/milestone/26","labels_url":"https://api.github.com/repos/mozilla-tw/Rocket/milestones/26/labels","id":3276833,"number":26,"title":"2.2","description":"","creator":{"login":"mxlius","id":441664,"avatar_url":"https://avatars0.githubusercontent.com/u/441664?v=4","gravatar_id":"","url":"https://api.github.com/users/mxlius","html_url":"https://github.com/mxlius","followers_url":"https://api.github.com/users/mxlius/followers","following_url":"https://api.github.com/users/mxlius/following{/other_user}","gists_url":"https://api.github.com/users/mxlius/gists{/gist_id}","starred_url":"https://api.github.com/users/mxlius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxlius/subscriptions","organizations_url":"https://api.github.com/users/mxlius/orgs","repos_url":"https://api.github.com/users/mxlius/repos","events_url":"https://api.github.com/users/mxlius/events{/privacy}","received_events_url":"https://api.github.com/users/mxlius/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":6,"state":"open","created_at":"2018-04-18T06:16:54Z","updated_at":"2018-05-22T04:03:23Z","due_on":"2018-06-05T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-05-18T17:05:34Z","updated_at":"2018-05-22T04:08:05Z","closed_at":"2018-05-21T06:08:15Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mozilla-tw/Rocket/pulls/1955","html_url":"https://github.com/mozilla-tw/Rocket/pull/1955","diff_url":"https://github.com/mozilla-tw/Rocket/pull/1955.diff","patch_url":"https://github.com/mozilla-tw/Rocket/pull/1955.patch"},"body":"I found a bug that getShareDialogLaunchTimeThreshold will not use the value from Firebase Remote Config. This PR fixed that.\r\n\r\nThe default value for  share dialog should be configurable. without the fix the share dialog always appears at the 10th app launch if the user rate 5 star. But if the user click cancel, it’s still configurable"},"comment":{"url":"https://api.github.com/repos/mozilla-tw/Rocket/issues/comments/390856596","html_url":"https://github.com/mozilla-tw/Rocket/pull/1955#issuecomment-390856596","issue_url":"https://api.github.com/repos/mozilla-tw/Rocket/issues/1955","id":390856596,"user":{"login":"chianger","id":9859809,"avatar_url":"https://avatars0.githubusercontent.com/u/9859809?v=4","gravatar_id":"","url":"https://api.github.com/users/chianger","html_url":"https://github.com/chianger","followers_url":"https://api.github.com/users/chianger/followers","following_url":"https://api.github.com/users/chianger/following{/other_user}","gists_url":"https://api.github.com/users/chianger/gists{/gist_id}","starred_url":"https://api.github.com/users/chianger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chianger/subscriptions","organizations_url":"https://api.github.com/users/chianger/orgs","repos_url":"https://api.github.com/users/chianger/repos","events_url":"https://api.github.com/users/chianger/events{/privacy}","received_events_url":"https://api.github.com/users/chianger/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T04:08:05Z","updated_at":"2018-05-22T04:08:05Z","author_association":"NONE","body":"[uplift] flag to go into 2.1"}}
{"actor":{"display_login":"chianger"}}