{"action":"created","issue":{"url":"https://api.github.com/repos/aio-libs/aiohttp/issues/3484","repository_url":"https://api.github.com/repos/aio-libs/aiohttp","labels_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/3484/labels{/name}","comments_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/3484/comments","events_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/3484/events","html_url":"https://github.com/aio-libs/aiohttp/pull/3484","id":396008937,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMzI3Mzgz","number":3484,"title":"Change type of Payload.size from Optional[float] to Optional[int]","user":{"login":"kxepal","id":785983,"node_id":"MDQ6VXNlcjc4NTk4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/785983?v=4","gravatar_id":"","url":"https://api.github.com/users/kxepal","html_url":"https://github.com/kxepal","followers_url":"https://api.github.com/users/kxepal/followers","following_url":"https://api.github.com/users/kxepal/following{/other_user}","gists_url":"https://api.github.com/users/kxepal/gists{/gist_id}","starred_url":"https://api.github.com/users/kxepal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kxepal/subscriptions","organizations_url":"https://api.github.com/users/kxepal/orgs","repos_url":"https://api.github.com/users/kxepal/repos","events_url":"https://api.github.com/users/kxepal/events{/privacy}","received_events_url":"https://api.github.com/users/kxepal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-01-04T17:39:50Z","updated_at":"2019-01-04T18:06:24Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3484","html_url":"https://github.com/aio-libs/aiohttp/pull/3484","diff_url":"https://github.com/aio-libs/aiohttp/pull/3484.diff","patch_url":"https://github.com/aio-libs/aiohttp/pull/3484.patch"},"body":"## What do these changes do?\r\n\r\nThis changes type of `Payload.size` property from `float` to `int`. Since this property defines amount of bytes which payload contains, it's impossible to have there floating point value.\r\n\r\nThis behavior was introduced in #3294.\r\n\r\n## Are there changes in behavior for the user?\r\n\r\nIt's possible to break some annotations for users custom Payload instances, but no runtime issues should be caused.\r\n"},"comment":{"url":"https://api.github.com/repos/aio-libs/aiohttp/issues/comments/451521674","html_url":"https://github.com/aio-libs/aiohttp/pull/3484#issuecomment-451521674","issue_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/3484","id":451521674,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTUyMTY3NA==","user":{"login":"kornicameister","id":1029674,"node_id":"MDQ6VXNlcjEwMjk2NzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1029674?v=4","gravatar_id":"","url":"https://api.github.com/users/kornicameister","html_url":"https://github.com/kornicameister","followers_url":"https://api.github.com/users/kornicameister/followers","following_url":"https://api.github.com/users/kornicameister/following{/other_user}","gists_url":"https://api.github.com/users/kornicameister/gists{/gist_id}","starred_url":"https://api.github.com/users/kornicameister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kornicameister/subscriptions","organizations_url":"https://api.github.com/users/kornicameister/orgs","repos_url":"https://api.github.com/users/kornicameister/repos","events_url":"https://api.github.com/users/kornicameister/events{/privacy}","received_events_url":"https://api.github.com/users/kornicameister/received_events","type":"User","site_admin":false},"created_at":"2019-01-04T18:06:24Z","updated_at":"2019-01-04T18:06:24Z","author_association":"CONTRIBUTOR","body":"@kxepal AFAIR I have similar doubts. I think it was coming from another portion of the code that received typings earlier. @asvetlov might remember more as he reviewed the code."}}
{"actor":{"display_login":"kornicameister"}}