{"action":"created","issue":{"url":"https://api.github.com/repos/flame/blis/issues/223","repository_url":"https://api.github.com/repos/flame/blis","labels_url":"https://api.github.com/repos/flame/blis/issues/223/labels{/name}","comments_url":"https://api.github.com/repos/flame/blis/issues/223/comments","events_url":"https://api.github.com/repos/flame/blis/issues/223/events","html_url":"https://github.com/flame/blis/issues/223","id":334055216,"node_id":"MDU6SXNzdWUzMzQwNTUyMTY=","number":223,"title":"adding extra build flags","user":{"login":"loveshack","id":6197299,"node_id":"MDQ6VXNlcjYxOTcyOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6197299?v=4","gravatar_id":"","url":"https://api.github.com/users/loveshack","html_url":"https://github.com/loveshack","followers_url":"https://api.github.com/users/loveshack/followers","following_url":"https://api.github.com/users/loveshack/following{/other_user}","gists_url":"https://api.github.com/users/loveshack/gists{/gist_id}","starred_url":"https://api.github.com/users/loveshack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loveshack/subscriptions","organizations_url":"https://api.github.com/users/loveshack/orgs","repos_url":"https://api.github.com/users/loveshack/repos","events_url":"https://api.github.com/users/loveshack/events{/privacy}","received_events_url":"https://api.github.com/users/loveshack/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-20T12:30:35Z","updated_at":"2018-06-21T17:10:20Z","closed_at":null,"author_association":"NONE","body":"It would be useful if there was a hook in the build system to add extra CFLAGS and LDFLAGS on top of the optimization ones that get chosen.  When I looked before, doubtless without understanding the system properly, as far as I remember there wasn't an obvious place to edit the make fragments other then redefining the compile command; apologies if I missed something.\r\n\r\nThis came up in the review of the Fedora packaging <https://bugzilla.redhat.com/show_bug.cgi?id=1591910>, where there's a requirement for \"security hardening\" flags generally, even in numerical libraries. (That said, libxsmm uses its own set rather than distro-supplied ones, some of which apparently have a performance impact, so I'd be circumspect about using them all.) Another case might be if you wanted to build the generic implementation with architecture-specific flags."},"comment":{"url":"https://api.github.com/repos/flame/blis/issues/comments/399176958","html_url":"https://github.com/flame/blis/issues/223#issuecomment-399176958","issue_url":"https://api.github.com/repos/flame/blis/issues/223","id":399176958,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTE3Njk1OA==","user":{"login":"fgvanzee","id":5487570,"node_id":"MDQ6VXNlcjU0ODc1NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/5487570?v=4","gravatar_id":"","url":"https://api.github.com/users/fgvanzee","html_url":"https://github.com/fgvanzee","followers_url":"https://api.github.com/users/fgvanzee/followers","following_url":"https://api.github.com/users/fgvanzee/following{/other_user}","gists_url":"https://api.github.com/users/fgvanzee/gists{/gist_id}","starred_url":"https://api.github.com/users/fgvanzee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgvanzee/subscriptions","organizations_url":"https://api.github.com/users/fgvanzee/orgs","repos_url":"https://api.github.com/users/fgvanzee/repos","events_url":"https://api.github.com/users/fgvanzee/events{/privacy}","received_events_url":"https://api.github.com/users/fgvanzee/received_events","type":"User","site_admin":false},"created_at":"2018-06-21T17:10:20Z","updated_at":"2018-06-21T17:10:20Z","author_association":"CONTRIBUTOR","body":"@loveshack I just realized we dealt with a similar issue in libflame, [issue 14](https://github.com/flame/libflame/issues/14).\r\n\r\nBasically, before that issue, libflame had exactly this `EXTRA_CFLAGS` feature you've requested for BLIS. But the problem for @iotamudelta was that in FreeBSD's ports system, it's assumed that some basic `CFLAGS` can be set prior to building software X, and that those values be used in addition to whatever `CFLAGS` the build system for X would deem appropriate. The solution I crafted for him was to change the behavior of libflame's `configure` script so that by setting `CFLAGS` before building libflame, those flags would be prepended (instead of override) the values determined by libflame's build system. This obviated libflame's `EXTRA_CFLAGS`, with the only difference being that the \"preset\" CFLAGS would be prepended instead of being appended (as they would with `EXTRA_CFLAGS`).\r\n\r\nSo, before implementing `EXTRA_CFLAGS` for BLIS, I'd prefer that we all agree on a solution that will work for both you and @iotamudelta. \r\n\r\n@iotamudelta Is the problem of libflame's issue 14 not also a problem for BLIS? If not, can you tell us why? And if so, I assume you would prefer to see a solution for BLIS that is similar to that of libflame?"}}
{"actor":{"display_login":"fgvanzee"}}