{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/microprofile-opentracing/pulls/comments/230317302","pull_request_review_id":171028914,"id":230317302,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDMxNzMwMg==","diff_hunk":"@@ -184,13 +184,13 @@ If there is an exception object available the implementation SHOULD also add log\n [[server-skip-pattern]]\n ===== Disabling server side tracing\n Server side tracing can be disabled by specifying a skip pattern which is used to match with HTTP path\n-`UriInfo.getPath()`. If the regex matches with HTTP path then tracing for the given server\n-request is disabled even if the method or class is annotated with `@Traced`.\n-The configuration does not disable any outbound request made from the disabled\n-server endpoint.\n+including context path and excluding query parameters e.g. `UriInfo.getAbsolutePath().getPath()`.\n+If the regex matches with HTTP path then tracing for the given server request is disabled even if\n+the method or class is annotated with `@Traced`. The configuration does not disable any outbound\n+request made from the disabled server endpoint.\n \n The skip pattern is specified as a string with key `mp.opentracing.server.skip-pattern` which has to be\n-compliant with `java.util.regex.Pattern`. An example skip pattern might be `mp.opentracing.server.skip-pattern=/health|/metrics.*`\n+compliant with `java.util.regex.Pattern`. An example skip pattern might be `mp.opentracing.server.skip-pattern/context/=/health|/metrics.*`","path":"spec/src/main/asciidoc/microprofile-opentracing.asciidoc","position":null,"original_position":15,"commit_id":"111674f3eff3b93baa7368f9f9521e14045f700d","original_commit_id":"848cb1667ffef899d0e19fa5c9e1dc02f8f9968a","user":{"login":"pavolloffay","id":5618424,"node_id":"MDQ6VXNlcjU2MTg0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"body":"good point, fixed","created_at":"2018-11-02T09:44:48Z","updated_at":"2018-11-02T09:44:48Z","html_url":"https://github.com/eclipse/microprofile-opentracing/pull/120#discussion_r230317302","pull_request_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/pulls/120","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eclipse/microprofile-opentracing/pulls/comments/230317302"},"html":{"href":"https://github.com/eclipse/microprofile-opentracing/pull/120#discussion_r230317302"},"pull_request":{"href":"https://api.github.com/repos/eclipse/microprofile-opentracing/pulls/120"}},"in_reply_to_id":230155767},"pull_request":{"url":"https://api.github.com/repos/eclipse/microprofile-opentracing/pulls/120","id":227673993,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NjczOTkz","html_url":"https://github.com/eclipse/microprofile-opentracing/pull/120","diff_url":"https://github.com/eclipse/microprofile-opentracing/pull/120.diff","patch_url":"https://github.com/eclipse/microprofile-opentracing/pull/120.patch","issue_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/issues/120","number":120,"state":"open","locked":false,"title":"Include context path into skip pattern","user":{"login":"pavolloffay","id":5618424,"node_id":"MDQ6VXNlcjU2MTg0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"body":"Resolves #119 \r\n\r\n* skip pattern has to include full URL without schema, host, port and query params e.g. `/context/app/endoint`\r\n* test suite expects the test app to be deployed on `/opentracing` context root. \r\n\r\nSigned-off-by: Pavol Loffay <ploffay@redhat.com>","created_at":"2018-11-01T16:13:49Z","updated_at":"2018-11-02T09:44:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de0b3417de67bedcd3cb4f17032d1a2577bf35b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/pulls/120/commits","review_comments_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/pulls/120/comments","review_comment_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/issues/120/comments","statuses_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/statuses/111674f3eff3b93baa7368f9f9521e14045f700d","head":{"label":"pavolloffay:skip-pattern-context-path","ref":"skip-pattern-context-path","sha":"111674f3eff3b93baa7368f9f9521e14045f700d","user":{"login":"pavolloffay","id":5618424,"node_id":"MDQ6VXNlcjU2MTg0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"repo":{"id":110849975,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA4NDk5NzU=","name":"microprofile-opentracing","full_name":"pavolloffay/microprofile-opentracing","private":false,"owner":{"login":"pavolloffay","id":5618424,"node_id":"MDQ6VXNlcjU2MTg0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pavolloffay/microprofile-opentracing","description":"microprofile-opentracing","fork":true,"url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing","forks_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/forks","keys_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/teams","hooks_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/hooks","issue_events_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/issues/events{/number}","events_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/events","assignees_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/assignees{/user}","branches_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/branches{/branch}","tags_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/tags","blobs_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/git/refs{/sha}","trees_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/statuses/{sha}","languages_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/languages","stargazers_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/stargazers","contributors_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/contributors","subscribers_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/subscribers","subscription_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/subscription","commits_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/commits{/sha}","git_commits_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/git/commits{/sha}","comments_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/comments{/number}","issue_comment_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/issues/comments{/number}","contents_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/contents/{+path}","compare_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/merges","archive_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/downloads","issues_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/issues{/number}","pulls_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/pulls{/number}","milestones_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/milestones{/number}","notifications_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/labels{/name}","releases_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/releases{/id}","deployments_url":"https://api.github.com/repos/pavolloffay/microprofile-opentracing/deployments","created_at":"2017-11-15T15:19:16Z","updated_at":"2017-11-15T15:19:18Z","pushed_at":"2018-11-02T09:44:35Z","git_url":"git://github.com/pavolloffay/microprofile-opentracing.git","ssh_url":"git@github.com:pavolloffay/microprofile-opentracing.git","clone_url":"https://github.com/pavolloffay/microprofile-opentracing.git","svn_url":"https://github.com/pavolloffay/microprofile-opentracing","homepage":null,"size":365,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"a6ea3eb8c04cf4c0b7e7fb46e47b0a4eed1eb3fd","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":95922083,"node_id":"MDEwOlJlcG9zaXRvcnk5NTkyMjA4Mw==","name":"microprofile-opentracing","full_name":"eclipse/microprofile-opentracing","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/microprofile-opentracing","description":"microprofile-opentracing","fork":false,"url":"https://api.github.com/repos/eclipse/microprofile-opentracing","forks_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/forks","keys_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/teams","hooks_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/hooks","issue_events_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/events","assignees_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/tags","blobs_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/languages","stargazers_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/stargazers","contributors_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/contributors","subscribers_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/subscribers","subscription_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/subscription","commits_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/merges","archive_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/downloads","issues_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/microprofile-opentracing/deployments","created_at":"2017-06-30T20:33:45Z","updated_at":"2018-10-24T15:51:01Z","pushed_at":"2018-11-02T09:44:36Z","git_url":"git://github.com/eclipse/microprofile-opentracing.git","ssh_url":"git@github.com:eclipse/microprofile-opentracing.git","clone_url":"https://github.com/eclipse/microprofile-opentracing.git","svn_url":"https://github.com/eclipse/microprofile-opentracing","homepage":null,"size":324,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":26,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/microprofile-opentracing/pulls/120"},"html":{"href":"https://github.com/eclipse/microprofile-opentracing/pull/120"},"issue":{"href":"https://api.github.com/repos/eclipse/microprofile-opentracing/issues/120"},"comments":{"href":"https://api.github.com/repos/eclipse/microprofile-opentracing/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/microprofile-opentracing/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/microprofile-opentracing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/microprofile-opentracing/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/microprofile-opentracing/statuses/111674f3eff3b93baa7368f9f9521e14045f700d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pavolloffay"}}