{"action":"created","issue":{"url":"https://api.github.com/repos/moschap/MindMap/issues/1","repository_url":"https://api.github.com/repos/moschap/MindMap","labels_url":"https://api.github.com/repos/moschap/MindMap/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/moschap/MindMap/issues/1/comments","events_url":"https://api.github.com/repos/moschap/MindMap/issues/1/events","html_url":"https://github.com/moschap/MindMap/pull/1","id":384699607,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzODM2ODY4","number":1,"title":"Fix animations","user":{"login":"osdnk","id":25709300,"node_id":"MDQ6VXNlcjI1NzA5MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25709300?v=4","gravatar_id":"","url":"https://api.github.com/users/osdnk","html_url":"https://github.com/osdnk","followers_url":"https://api.github.com/users/osdnk/followers","following_url":"https://api.github.com/users/osdnk/following{/other_user}","gists_url":"https://api.github.com/users/osdnk/gists{/gist_id}","starred_url":"https://api.github.com/users/osdnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osdnk/subscriptions","organizations_url":"https://api.github.com/users/osdnk/orgs","repos_url":"https://api.github.com/users/osdnk/repos","events_url":"https://api.github.com/users/osdnk/events{/privacy}","received_events_url":"https://api.github.com/users/osdnk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-27T09:30:27Z","updated_at":"2018-11-27T10:03:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/moschap/MindMap/pulls/1","html_url":"https://github.com/moschap/MindMap/pull/1","diff_url":"https://github.com/moschap/MindMap/pull/1.diff","patch_url":"https://github.com/moschap/MindMap/pull/1.patch"},"body":"Let me explain quickly what is being done in this code. \r\n\r\nin `_onHandlerStateChange` function we define animation behaviour of `nativeEvent`. You set result of `runTiming` method to `this.trans` but you do in only if `state` is `ACTIVE`. If not, you do nothing, so it's a reason of your bug. \r\n\r\nI'm not certain what you want to achieve, but probably it is not really what you want, because I suppose there is no need to rewrite the result of `runTiming` on each frame under some condition. I think that you might want to make something with `clock` in this `_onHandlerStateChange`.\r\n\r\nPlease take a look on this code. If it's not understandable, let me know\r\n"},"comment":{"url":"https://api.github.com/repos/moschap/MindMap/issues/comments/441999671","html_url":"https://github.com/moschap/MindMap/pull/1#issuecomment-441999671","issue_url":"https://api.github.com/repos/moschap/MindMap/issues/1","id":441999671,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTk5OTY3MQ==","user":{"login":"osdnk","id":25709300,"node_id":"MDQ6VXNlcjI1NzA5MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25709300?v=4","gravatar_id":"","url":"https://api.github.com/users/osdnk","html_url":"https://github.com/osdnk","followers_url":"https://api.github.com/users/osdnk/followers","following_url":"https://api.github.com/users/osdnk/following{/other_user}","gists_url":"https://api.github.com/users/osdnk/gists{/gist_id}","starred_url":"https://api.github.com/users/osdnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osdnk/subscriptions","organizations_url":"https://api.github.com/users/osdnk/orgs","repos_url":"https://api.github.com/users/osdnk/repos","events_url":"https://api.github.com/users/osdnk/events{/privacy}","received_events_url":"https://api.github.com/users/osdnk/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T10:03:17Z","updated_at":"2018-11-27T10:03:17Z","author_association":"NONE","body":"And when it comes to second question, I advise you to use \r\n```\r\n cond(state.finished, [\r\n      stopClock(clock),\r\n    ]),\r\n```\r\nin `RunTiming` method. You could use it some kind of callback on end of the `timing` animation"}}
{"actor":{"display_login":"osdnk"}}