{"action":"created","issue":{"url":"https://api.github.com/repos/LN-Zap/zap-desktop/issues/740","repository_url":"https://api.github.com/repos/LN-Zap/zap-desktop","labels_url":"https://api.github.com/repos/LN-Zap/zap-desktop/issues/740/labels{/name}","comments_url":"https://api.github.com/repos/LN-Zap/zap-desktop/issues/740/comments","events_url":"https://api.github.com/repos/LN-Zap/zap-desktop/issues/740/events","html_url":"https://github.com/LN-Zap/zap-desktop/pull/740","id":356912048,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMDU0MzEw","number":740,"title":"fix(fsm): ensure lnd connect before state change","user":{"login":"mrfelton","id":200251,"node_id":"MDQ6VXNlcjIwMDI1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/200251?v=4","gravatar_id":"","url":"https://api.github.com/users/mrfelton","html_url":"https://github.com/mrfelton","followers_url":"https://api.github.com/users/mrfelton/followers","following_url":"https://api.github.com/users/mrfelton/following{/other_user}","gists_url":"https://api.github.com/users/mrfelton/gists{/gist_id}","starred_url":"https://api.github.com/users/mrfelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrfelton/subscriptions","organizations_url":"https://api.github.com/users/mrfelton/orgs","repos_url":"https://api.github.com/users/mrfelton/repos","events_url":"https://api.github.com/users/mrfelton/events{/privacy}","received_events_url":"https://api.github.com/users/mrfelton/received_events","type":"User","site_admin":false},"labels":[{"id":666128278,"node_id":"MDU6TGFiZWw2NjYxMjgyNzg=","url":"https://api.github.com/repos/LN-Zap/zap-desktop/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"mrfelton","id":200251,"node_id":"MDQ6VXNlcjIwMDI1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/200251?v=4","gravatar_id":"","url":"https://api.github.com/users/mrfelton","html_url":"https://github.com/mrfelton","followers_url":"https://api.github.com/users/mrfelton/followers","following_url":"https://api.github.com/users/mrfelton/following{/other_user}","gists_url":"https://api.github.com/users/mrfelton/gists{/gist_id}","starred_url":"https://api.github.com/users/mrfelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrfelton/subscriptions","organizations_url":"https://api.github.com/users/mrfelton/orgs","repos_url":"https://api.github.com/users/mrfelton/repos","events_url":"https://api.github.com/users/mrfelton/events{/privacy}","received_events_url":"https://api.github.com/users/mrfelton/received_events","type":"User","site_admin":false},"assignees":[{"login":"mrfelton","id":200251,"node_id":"MDQ6VXNlcjIwMDI1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/200251?v=4","gravatar_id":"","url":"https://api.github.com/users/mrfelton","html_url":"https://github.com/mrfelton","followers_url":"https://api.github.com/users/mrfelton/followers","following_url":"https://api.github.com/users/mrfelton/following{/other_user}","gists_url":"https://api.github.com/users/mrfelton/gists{/gist_id}","starred_url":"https://api.github.com/users/mrfelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrfelton/subscriptions","organizations_url":"https://api.github.com/users/mrfelton/orgs","repos_url":"https://api.github.com/users/mrfelton/repos","events_url":"https://api.github.com/users/mrfelton/events{/privacy}","received_events_url":"https://api.github.com/users/mrfelton/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/LN-Zap/zap-desktop/milestones/4","html_url":"https://github.com/LN-Zap/zap-desktop/milestone/4","labels_url":"https://api.github.com/repos/LN-Zap/zap-desktop/milestones/4/labels","id":3529236,"node_id":"MDk6TWlsZXN0b25lMzUyOTIzNg==","number":4,"title":"v0.2.2-beta","description":"Bug fixes and improvements.","creator":{"login":"mrfelton","id":200251,"node_id":"MDQ6VXNlcjIwMDI1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/200251?v=4","gravatar_id":"","url":"https://api.github.com/users/mrfelton","html_url":"https://github.com/mrfelton","followers_url":"https://api.github.com/users/mrfelton/followers","following_url":"https://api.github.com/users/mrfelton/following{/other_user}","gists_url":"https://api.github.com/users/mrfelton/gists{/gist_id}","starred_url":"https://api.github.com/users/mrfelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrfelton/subscriptions","organizations_url":"https://api.github.com/users/mrfelton/orgs","repos_url":"https://api.github.com/users/mrfelton/repos","events_url":"https://api.github.com/users/mrfelton/events{/privacy}","received_events_url":"https://api.github.com/users/mrfelton/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":52,"state":"open","created_at":"2018-07-28T07:14:43Z","updated_at":"2018-09-04T17:47:29Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-09-04T17:47:05Z","updated_at":"2018-09-04T18:01:54Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/LN-Zap/zap-desktop/pulls/740","html_url":"https://github.com/LN-Zap/zap-desktop/pull/740","diff_url":"https://github.com/LN-Zap/zap-desktop/pull/740.diff","patch_url":"https://github.com/LN-Zap/zap-desktop/pull/740.patch"},"body":"## Description:\r\n\r\nEnsure that a failed lnd connection attempt prevents the FSM from changing state by moving the connect handlers to the `onBefore<TRANSITION>` lifecycle events.\r\n\r\nSee https://github.com/jakesgordon/javascript-state-machine/blob/master/docs/lifecycle-events.md#cancelling-a-transition\r\n\r\n## Motivation and Context:\r\n\r\nFix for #739\r\n\r\n## How Has This Been Tested?\r\n\r\n1. Start zap\r\n2. select custom mode\r\n3. enter invalid connection details\r\n4. proceed to connect\r\n5. after returning to the connect form, submit for a second time with invalid credentials\r\n\r\n## Types of changes:\r\n\r\nBug fix\r\n\r\n## Checklist:\r\n\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n\r\n- [x] My code follows the code style of this project.\r\n- [x] I have reviewed and updated the documentation accordingly.\r\n- [x] I have read the _CONTRIBUTING_ document.\r\n- [ ] I have added tests to cover my changes where needed.\r\n- [ ] All new and existing tests passed.\r\n- [x] My commits have been squashed into a concise set of changes.\r\n"},"comment":{"url":"https://api.github.com/repos/LN-Zap/zap-desktop/issues/comments/418462845","html_url":"https://github.com/LN-Zap/zap-desktop/pull/740#issuecomment-418462845","issue_url":"https://api.github.com/repos/LN-Zap/zap-desktop/issues/740","id":418462845,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODQ2Mjg0NQ==","user":{"login":"coveralls","id":2354108,"node_id":"MDQ6VXNlcjIzNTQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-09-04T18:01:54Z","updated_at":"2018-09-04T18:01:54Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/18823765/badge)](https://coveralls.io/builds/18823765)\n\nCoverage decreased (-0.003%) to 16.233% when pulling **bfb8b6d86e9a9fbdae3b789976f74a225b5f55f2 on mrfelton:fix/lnd-connect-failure-state** into **994d3617f7bb5ad92a3376f41a46dd133cea2156 on LN-Zap:master**.\n"}}
{"actor":{"display_login":"coveralls"}}