{"action":"closed","number":317,"pull_request":{"url":"https://api.github.com/repos/NaluCFD/Nalu/pulls/317","id":167506575,"html_url":"https://github.com/NaluCFD/Nalu/pull/317","diff_url":"https://github.com/NaluCFD/Nalu/pull/317.diff","patch_url":"https://github.com/NaluCFD/Nalu/pull/317.patch","issue_url":"https://api.github.com/repos/NaluCFD/Nalu/issues/317","number":317,"state":"closed","locked":false,"title":"Be more careful with wall data in presence of Dirichlet or wall fuction.","user":{"login":"spdomin","id":8699324,"avatar_url":"https://avatars3.githubusercontent.com/u/8699324?v=4","gravatar_id":"","url":"https://api.github.com/users/spdomin","html_url":"https://github.com/spdomin","followers_url":"https://api.github.com/users/spdomin/followers","following_url":"https://api.github.com/users/spdomin/following{/other_user}","gists_url":"https://api.github.com/users/spdomin/gists{/gist_id}","starred_url":"https://api.github.com/users/spdomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spdomin/subscriptions","organizations_url":"https://api.github.com/users/spdomin/orgs","repos_url":"https://api.github.com/users/spdomin/repos","events_url":"https://api.github.com/users/spdomin/events{/privacy}","received_events_url":"https://api.github.com/users/spdomin/received_events","type":"User","site_admin":false},"body":"Addresses issue: https://github.com/NaluCFD/Nalu/issues/312\r\n\r\n* Use specified inflow velocity for Gjui inflow contribution. Formerly,\r\nwe were always using the dof velocity. As only Dirichlet inflow bcs are\r\nsupported, this will not chnage anything, however, will be appropriate for\r\n\"use_fluxes\" possible implementation.\r\n\r\n* Use specified wall velocity for Gjui wall contribution. Formerly,\r\nwe were always using the dof velocity. When wall fucntions are used, we\r\nwant the specified velocity from the user input file.\r\n\r\n* Do not project only when Dirichlet values are specified in wall bc; any type of wall-function will require projection.\r\n\r\n* Do not popuate the dof velocity with user specified value each time step when using wall functions. Rather, only set the IC value to the wall. Again, Dirichlet's win...\r\n\r\n* wall_velocity_bc or velocity_bc usage? In the ABL use-case, this was wrong. At any wall function, we use wall_velocity_bc as boundary data for projected nodal gradients and boundary contributions.\r\n\r\n* new gold files due to the above changes. All verified to be proper. In general,\r\nmost cases look like equal or lower norms. In some cases, norms are higher now.\r\n\r\nNote:\r\n\r\na) the movingCylinder was found to diff based on the change of velocityNp1 to bcVelocity.\r\nHowever, the new code is proper - order-of-ops.\r\n\r\nb) the code could benifit from a use_fluxes inflow now. However, that would require\r\nproperty management improvements.","created_at":"2018-02-06T19:23:48Z","updated_at":"2018-02-06T21:21:01Z","closed_at":"2018-02-06T21:21:01Z","merged_at":"2018-02-06T21:21:01Z","merge_commit_sha":"80529c84f4f54f5bf480d73c928c54d10ad43053","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rcknaus","id":11062437,"avatar_url":"https://avatars1.githubusercontent.com/u/11062437?v=4","gravatar_id":"","url":"https://api.github.com/users/rcknaus","html_url":"https://github.com/rcknaus","followers_url":"https://api.github.com/users/rcknaus/followers","following_url":"https://api.github.com/users/rcknaus/following{/other_user}","gists_url":"https://api.github.com/users/rcknaus/gists{/gist_id}","starred_url":"https://api.github.com/users/rcknaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcknaus/subscriptions","organizations_url":"https://api.github.com/users/rcknaus/orgs","repos_url":"https://api.github.com/users/rcknaus/repos","events_url":"https://api.github.com/users/rcknaus/events{/privacy}","received_events_url":"https://api.github.com/users/rcknaus/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/NaluCFD/Nalu/pulls/317/commits","review_comments_url":"https://api.github.com/repos/NaluCFD/Nalu/pulls/317/comments","review_comment_url":"https://api.github.com/repos/NaluCFD/Nalu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NaluCFD/Nalu/issues/317/comments","statuses_url":"https://api.github.com/repos/NaluCFD/Nalu/statuses/c09f6e8a8a4b21134fd31d70093711d6874c16a7","head":{"label":"spdomin:wallDirichlet","ref":"wallDirichlet","sha":"c09f6e8a8a4b21134fd31d70093711d6874c16a7","user":{"login":"spdomin","id":8699324,"avatar_url":"https://avatars3.githubusercontent.com/u/8699324?v=4","gravatar_id":"","url":"https://api.github.com/users/spdomin","html_url":"https://github.com/spdomin","followers_url":"https://api.github.com/users/spdomin/followers","following_url":"https://api.github.com/users/spdomin/following{/other_user}","gists_url":"https://api.github.com/users/spdomin/gists{/gist_id}","starred_url":"https://api.github.com/users/spdomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spdomin/subscriptions","organizations_url":"https://api.github.com/users/spdomin/orgs","repos_url":"https://api.github.com/users/spdomin/repos","events_url":"https://api.github.com/users/spdomin/events{/privacy}","received_events_url":"https://api.github.com/users/spdomin/received_events","type":"User","site_admin":false},"repo":{"id":92991948,"name":"NaluFork","full_name":"spdomin/NaluFork","owner":{"login":"spdomin","id":8699324,"avatar_url":"https://avatars3.githubusercontent.com/u/8699324?v=4","gravatar_id":"","url":"https://api.github.com/users/spdomin","html_url":"https://github.com/spdomin","followers_url":"https://api.github.com/users/spdomin/followers","following_url":"https://api.github.com/users/spdomin/following{/other_user}","gists_url":"https://api.github.com/users/spdomin/gists{/gist_id}","starred_url":"https://api.github.com/users/spdomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spdomin/subscriptions","organizations_url":"https://api.github.com/users/spdomin/orgs","repos_url":"https://api.github.com/users/spdomin/repos","events_url":"https://api.github.com/users/spdomin/events{/privacy}","received_events_url":"https://api.github.com/users/spdomin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spdomin/NaluFork","description":"Nalu: a generalized unstructured massively parallel low Mach flow code designed to support a variety of energy applications of interest (most notably Wind ECP) built on the Sierra Toolkit and Trilinos solver Tpetra/Epetra stack. The open source BSD, clause 3 license model has been chosen for the code base. See LICENSE for more information. ","fork":true,"url":"https://api.github.com/repos/spdomin/NaluFork","forks_url":"https://api.github.com/repos/spdomin/NaluFork/forks","keys_url":"https://api.github.com/repos/spdomin/NaluFork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spdomin/NaluFork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spdomin/NaluFork/teams","hooks_url":"https://api.github.com/repos/spdomin/NaluFork/hooks","issue_events_url":"https://api.github.com/repos/spdomin/NaluFork/issues/events{/number}","events_url":"https://api.github.com/repos/spdomin/NaluFork/events","assignees_url":"https://api.github.com/repos/spdomin/NaluFork/assignees{/user}","branches_url":"https://api.github.com/repos/spdomin/NaluFork/branches{/branch}","tags_url":"https://api.github.com/repos/spdomin/NaluFork/tags","blobs_url":"https://api.github.com/repos/spdomin/NaluFork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spdomin/NaluFork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spdomin/NaluFork/git/refs{/sha}","trees_url":"https://api.github.com/repos/spdomin/NaluFork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spdomin/NaluFork/statuses/{sha}","languages_url":"https://api.github.com/repos/spdomin/NaluFork/languages","stargazers_url":"https://api.github.com/repos/spdomin/NaluFork/stargazers","contributors_url":"https://api.github.com/repos/spdomin/NaluFork/contributors","subscribers_url":"https://api.github.com/repos/spdomin/NaluFork/subscribers","subscription_url":"https://api.github.com/repos/spdomin/NaluFork/subscription","commits_url":"https://api.github.com/repos/spdomin/NaluFork/commits{/sha}","git_commits_url":"https://api.github.com/repos/spdomin/NaluFork/git/commits{/sha}","comments_url":"https://api.github.com/repos/spdomin/NaluFork/comments{/number}","issue_comment_url":"https://api.github.com/repos/spdomin/NaluFork/issues/comments{/number}","contents_url":"https://api.github.com/repos/spdomin/NaluFork/contents/{+path}","compare_url":"https://api.github.com/repos/spdomin/NaluFork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spdomin/NaluFork/merges","archive_url":"https://api.github.com/repos/spdomin/NaluFork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spdomin/NaluFork/downloads","issues_url":"https://api.github.com/repos/spdomin/NaluFork/issues{/number}","pulls_url":"https://api.github.com/repos/spdomin/NaluFork/pulls{/number}","milestones_url":"https://api.github.com/repos/spdomin/NaluFork/milestones{/number}","notifications_url":"https://api.github.com/repos/spdomin/NaluFork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spdomin/NaluFork/labels{/name}","releases_url":"https://api.github.com/repos/spdomin/NaluFork/releases{/id}","deployments_url":"https://api.github.com/repos/spdomin/NaluFork/deployments","created_at":"2017-05-31T21:54:10Z","updated_at":"2017-05-31T21:54:30Z","pushed_at":"2018-02-06T19:22:53Z","git_url":"git://github.com/spdomin/NaluFork.git","ssh_url":"git@github.com:spdomin/NaluFork.git","clone_url":"https://github.com/spdomin/NaluFork.git","svn_url":"https://github.com/spdomin/NaluFork","homepage":"NaluCFD.org","size":10796,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NaluCFD:master","ref":"master","sha":"249ebce0f4580e06cbb2e5aa2fd584f9bdf72682","user":{"login":"NaluCFD","id":22531105,"avatar_url":"https://avatars1.githubusercontent.com/u/22531105?v=4","gravatar_id":"","url":"https://api.github.com/users/NaluCFD","html_url":"https://github.com/NaluCFD","followers_url":"https://api.github.com/users/NaluCFD/followers","following_url":"https://api.github.com/users/NaluCFD/following{/other_user}","gists_url":"https://api.github.com/users/NaluCFD/gists{/gist_id}","starred_url":"https://api.github.com/users/NaluCFD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NaluCFD/subscriptions","organizations_url":"https://api.github.com/users/NaluCFD/orgs","repos_url":"https://api.github.com/users/NaluCFD/repos","events_url":"https://api.github.com/users/NaluCFD/events{/privacy}","received_events_url":"https://api.github.com/users/NaluCFD/received_events","type":"Organization","site_admin":false},"repo":{"id":69712764,"name":"Nalu","full_name":"NaluCFD/Nalu","owner":{"login":"NaluCFD","id":22531105,"avatar_url":"https://avatars1.githubusercontent.com/u/22531105?v=4","gravatar_id":"","url":"https://api.github.com/users/NaluCFD","html_url":"https://github.com/NaluCFD","followers_url":"https://api.github.com/users/NaluCFD/followers","following_url":"https://api.github.com/users/NaluCFD/following{/other_user}","gists_url":"https://api.github.com/users/NaluCFD/gists{/gist_id}","starred_url":"https://api.github.com/users/NaluCFD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NaluCFD/subscriptions","organizations_url":"https://api.github.com/users/NaluCFD/orgs","repos_url":"https://api.github.com/users/NaluCFD/repos","events_url":"https://api.github.com/users/NaluCFD/events{/privacy}","received_events_url":"https://api.github.com/users/NaluCFD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NaluCFD/Nalu","description":"Nalu: a generalized unstructured massively parallel low Mach flow code designed to support a variety of energy applications of interest (most notably Wind ECP) built on the Sierra Toolkit and Trilinos solver Tpetra/Epetra stack. The open source BSD, clause 3 license model has been chosen for the code base. See LICENSE for more information. ","fork":false,"url":"https://api.github.com/repos/NaluCFD/Nalu","forks_url":"https://api.github.com/repos/NaluCFD/Nalu/forks","keys_url":"https://api.github.com/repos/NaluCFD/Nalu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NaluCFD/Nalu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NaluCFD/Nalu/teams","hooks_url":"https://api.github.com/repos/NaluCFD/Nalu/hooks","issue_events_url":"https://api.github.com/repos/NaluCFD/Nalu/issues/events{/number}","events_url":"https://api.github.com/repos/NaluCFD/Nalu/events","assignees_url":"https://api.github.com/repos/NaluCFD/Nalu/assignees{/user}","branches_url":"https://api.github.com/repos/NaluCFD/Nalu/branches{/branch}","tags_url":"https://api.github.com/repos/NaluCFD/Nalu/tags","blobs_url":"https://api.github.com/repos/NaluCFD/Nalu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NaluCFD/Nalu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NaluCFD/Nalu/git/refs{/sha}","trees_url":"https://api.github.com/repos/NaluCFD/Nalu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NaluCFD/Nalu/statuses/{sha}","languages_url":"https://api.github.com/repos/NaluCFD/Nalu/languages","stargazers_url":"https://api.github.com/repos/NaluCFD/Nalu/stargazers","contributors_url":"https://api.github.com/repos/NaluCFD/Nalu/contributors","subscribers_url":"https://api.github.com/repos/NaluCFD/Nalu/subscribers","subscription_url":"https://api.github.com/repos/NaluCFD/Nalu/subscription","commits_url":"https://api.github.com/repos/NaluCFD/Nalu/commits{/sha}","git_commits_url":"https://api.github.com/repos/NaluCFD/Nalu/git/commits{/sha}","comments_url":"https://api.github.com/repos/NaluCFD/Nalu/comments{/number}","issue_comment_url":"https://api.github.com/repos/NaluCFD/Nalu/issues/comments{/number}","contents_url":"https://api.github.com/repos/NaluCFD/Nalu/contents/{+path}","compare_url":"https://api.github.com/repos/NaluCFD/Nalu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NaluCFD/Nalu/merges","archive_url":"https://api.github.com/repos/NaluCFD/Nalu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NaluCFD/Nalu/downloads","issues_url":"https://api.github.com/repos/NaluCFD/Nalu/issues{/number}","pulls_url":"https://api.github.com/repos/NaluCFD/Nalu/pulls{/number}","milestones_url":"https://api.github.com/repos/NaluCFD/Nalu/milestones{/number}","notifications_url":"https://api.github.com/repos/NaluCFD/Nalu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NaluCFD/Nalu/labels{/name}","releases_url":"https://api.github.com/repos/NaluCFD/Nalu/releases{/id}","deployments_url":"https://api.github.com/repos/NaluCFD/Nalu/deployments","created_at":"2016-10-01T01:25:20Z","updated_at":"2018-02-02T12:57:11Z","pushed_at":"2018-02-06T21:21:01Z","git_url":"git://github.com/NaluCFD/Nalu.git","ssh_url":"git@github.com:NaluCFD/Nalu.git","clone_url":"https://github.com/NaluCFD/Nalu.git","svn_url":"https://github.com/NaluCFD/Nalu","homepage":"NaluCFD.org","size":10938,"stargazers_count":31,"watchers_count":31,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":30,"open_issues":17,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NaluCFD/Nalu/pulls/317"},"html":{"href":"https://github.com/NaluCFD/Nalu/pull/317"},"issue":{"href":"https://api.github.com/repos/NaluCFD/Nalu/issues/317"},"comments":{"href":"https://api.github.com/repos/NaluCFD/Nalu/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/NaluCFD/Nalu/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/NaluCFD/Nalu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NaluCFD/Nalu/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/NaluCFD/Nalu/statuses/c09f6e8a8a4b21134fd31d70093711d6874c16a7"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"spdomin","id":8699324,"avatar_url":"https://avatars3.githubusercontent.com/u/8699324?v=4","gravatar_id":"","url":"https://api.github.com/users/spdomin","html_url":"https://github.com/spdomin","followers_url":"https://api.github.com/users/spdomin/followers","following_url":"https://api.github.com/users/spdomin/following{/other_user}","gists_url":"https://api.github.com/users/spdomin/gists{/gist_id}","starred_url":"https://api.github.com/users/spdomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spdomin/subscriptions","organizations_url":"https://api.github.com/users/spdomin/orgs","repos_url":"https://api.github.com/users/spdomin/repos","events_url":"https://api.github.com/users/spdomin/events{/privacy}","received_events_url":"https://api.github.com/users/spdomin/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":155,"deletions":146,"changed_files":12}}
{"actor":{"display_login":"spdomin"}}