{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments/190512694","pull_request_review_id":122902186,"id":190512694,"diff_hunk":"@@ -128,7 +128,8 @@ def get_task_args(ems)\n         connect_opts = [MiqPassword.encrypt(params[:amqp_password]), params.to_hash.symbolize_keys.slice(*OPENSTACK_AMQP_PARAMS)] if params[:cred_type] == \"amqp\"\n         connect_opts\n       when 'ManageIQ::Providers::Amazon::CloudManager'\n-        [user, password, :EC2, params[:provider_region], ems.http_proxy_uri, true]\n+        uri = URI.parse(params[:default_url])","path":"app/controllers/mixins/ems_common_angular.rb","position":5,"original_position":5,"commit_id":"a62d85ce5d630229c8a55a37f0be8eae76555c4e","original_commit_id":"a62d85ce5d630229c8a55a37f0be8eae76555c4e","user":{"login":"AlexanderZagaynov","id":7778414,"avatar_url":"https://avatars3.githubusercontent.com/u/7778414?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexanderZagaynov","html_url":"https://github.com/AlexanderZagaynov","followers_url":"https://api.github.com/users/AlexanderZagaynov/followers","following_url":"https://api.github.com/users/AlexanderZagaynov/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderZagaynov/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderZagaynov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderZagaynov/subscriptions","organizations_url":"https://api.github.com/users/AlexanderZagaynov/orgs","repos_url":"https://api.github.com/users/AlexanderZagaynov/repos","events_url":"https://api.github.com/users/AlexanderZagaynov/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderZagaynov/received_events","type":"User","site_admin":false},"body":"Related comment here: https://github.com/ManageIQ/manageiq-providers-amazon/pull/444#issuecomment-391641011 (need to decide where escaping will be made)","created_at":"2018-05-24T09:01:46Z","updated_at":"2018-05-24T09:01:46Z","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3958#discussion_r190512694","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3958","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments/190512694"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3958#discussion_r190512694"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3958"}},"in_reply_to_id":190510607},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3958","id":188876269,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3958","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3958.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3958.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3958","number":3958,"state":"open","locked":false,"title":"Add a new \"Endpoint URL\" field in AWS endpoints","user":{"login":"AparnaKarve","id":1538216,"avatar_url":"https://avatars3.githubusercontent.com/u/1538216?v=4","gravatar_id":"","url":"https://api.github.com/users/AparnaKarve","html_url":"https://github.com/AparnaKarve","followers_url":"https://api.github.com/users/AparnaKarve/followers","following_url":"https://api.github.com/users/AparnaKarve/following{/other_user}","gists_url":"https://api.github.com/users/AparnaKarve/gists{/gist_id}","starred_url":"https://api.github.com/users/AparnaKarve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AparnaKarve/subscriptions","organizations_url":"https://api.github.com/users/AparnaKarve/orgs","repos_url":"https://api.github.com/users/AparnaKarve/repos","events_url":"https://api.github.com/users/AparnaKarve/events{/privacy}","received_events_url":"https://api.github.com/users/AparnaKarve/received_events","type":"User","site_admin":false},"body":"Added a new `Endpoint URL` optional field in AWS endpoints as shown in the screenshot.\r\n\r\n<img width=\"719\" alt=\"screen shot 2018-05-17 at 3 12 28 pm\" src=\"https://user-images.githubusercontent.com/1538216/40206501-2f1d3e10-59e5-11e8-9957-c96bcb8ff212.png\">\r\n\r\nDepends on https://github.com/ManageIQ/manageiq-providers-amazon/pull/444\r\n\r\nFixes https://github.com/ManageIQ/manageiq-ui-classic/issues/3907","created_at":"2018-05-17T22:18:27Z","updated_at":"2018-05-24T09:01:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5995c552d49a66fb4b48382e6968eab3313d775c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":505532506,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/compute/cloud","name":"compute/cloud","color":"5319e7","default":false},{"id":505074431,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":512227375,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/pending%20core","name":"pending core","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3958/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3958/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3958/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/a62d85ce5d630229c8a55a37f0be8eae76555c4e","head":{"label":"AparnaKarve:add_url_to_amz_and_azure","ref":"add_url_to_amz_and_azure","sha":"a62d85ce5d630229c8a55a37f0be8eae76555c4e","user":{"login":"AparnaKarve","id":1538216,"avatar_url":"https://avatars3.githubusercontent.com/u/1538216?v=4","gravatar_id":"","url":"https://api.github.com/users/AparnaKarve","html_url":"https://github.com/AparnaKarve","followers_url":"https://api.github.com/users/AparnaKarve/followers","following_url":"https://api.github.com/users/AparnaKarve/following{/other_user}","gists_url":"https://api.github.com/users/AparnaKarve/gists{/gist_id}","starred_url":"https://api.github.com/users/AparnaKarve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AparnaKarve/subscriptions","organizations_url":"https://api.github.com/users/AparnaKarve/orgs","repos_url":"https://api.github.com/users/AparnaKarve/repos","events_url":"https://api.github.com/users/AparnaKarve/events{/privacy}","received_events_url":"https://api.github.com/users/AparnaKarve/received_events","type":"User","site_admin":false},"repo":{"id":77175364,"name":"manageiq-ui-classic","full_name":"AparnaKarve/manageiq-ui-classic","owner":{"login":"AparnaKarve","id":1538216,"avatar_url":"https://avatars3.githubusercontent.com/u/1538216?v=4","gravatar_id":"","url":"https://api.github.com/users/AparnaKarve","html_url":"https://github.com/AparnaKarve","followers_url":"https://api.github.com/users/AparnaKarve/followers","following_url":"https://api.github.com/users/AparnaKarve/following{/other_user}","gists_url":"https://api.github.com/users/AparnaKarve/gists{/gist_id}","starred_url":"https://api.github.com/users/AparnaKarve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AparnaKarve/subscriptions","organizations_url":"https://api.github.com/users/AparnaKarve/orgs","repos_url":"https://api.github.com/users/AparnaKarve/repos","events_url":"https://api.github.com/users/AparnaKarve/events{/privacy}","received_events_url":"https://api.github.com/users/AparnaKarve/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AparnaKarve/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":true,"url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic","forks_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/deployments","created_at":"2016-12-22T20:57:20Z","updated_at":"2016-12-22T20:57:27Z","pushed_at":"2018-05-18T00:05:39Z","git_url":"git://github.com/AparnaKarve/manageiq-ui-classic.git","ssh_url":"git@github.com:AparnaKarve/manageiq-ui-classic.git","clone_url":"https://github.com/AparnaKarve/manageiq-ui-classic.git","svn_url":"https://github.com/AparnaKarve/manageiq-ui-classic","homepage":null,"size":59888,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"1df2669e8cee4636aea57b93a7724b807308720b","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":77085298,"name":"manageiq-ui-classic","full_name":"ManageIQ/manageiq-ui-classic","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/deployments","created_at":"2016-12-21T20:53:08Z","updated_at":"2018-05-24T08:23:37Z","pushed_at":"2018-05-24T08:52:43Z","git_url":"git://github.com/ManageIQ/manageiq-ui-classic.git","ssh_url":"git@github.com:ManageIQ/manageiq-ui-classic.git","clone_url":"https://github.com/ManageIQ/manageiq-ui-classic.git","svn_url":"https://github.com/ManageIQ/manageiq-ui-classic","homepage":null,"size":63349,"stargazers_count":24,"watchers_count":24,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":245,"mirror_url":null,"archived":false,"open_issues_count":305,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":245,"open_issues":305,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3958"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3958"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3958"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3958/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3958/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3958/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/a62d85ce5d630229c8a55a37f0be8eae76555c4e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AlexanderZagaynov"}}