{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/49514","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/49514/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/49514/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/49514/events","html_url":"https://github.com/ansible/ansible/pull/49514","id":387525220,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1OTk1MzE4","number":49514,"title":"Add Direct Rule support for Firewall Module (rebase of #34027)","user":{"login":"maxamillion","id":839000,"node_id":"MDQ6VXNlcjgzOTAwMA==","avatar_url":"https://avatars1.githubusercontent.com/u/839000?v=4","gravatar_id":"","url":"https://api.github.com/users/maxamillion","html_url":"https://github.com/maxamillion","followers_url":"https://api.github.com/users/maxamillion/followers","following_url":"https://api.github.com/users/maxamillion/following{/other_user}","gists_url":"https://api.github.com/users/maxamillion/gists{/gist_id}","starred_url":"https://api.github.com/users/maxamillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxamillion/subscriptions","organizations_url":"https://api.github.com/users/maxamillion/orgs","repos_url":"https://api.github.com/users/maxamillion/repos","events_url":"https://api.github.com/users/maxamillion/events{/privacy}","received_events_url":"https://api.github.com/users/maxamillion/received_events","type":"User","site_admin":false},"labels":[{"id":1043397454,"node_id":"MDU6TGFiZWwxMDQzMzk3NDU0","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.8","name":"affects_2.8","color":"ededed","default":false},{"id":852590921,"node_id":"MDU6TGFiZWw4NTI1OTA5MjE=","url":"https://api.github.com/repos/ansible/ansible/labels/feature","name":"feature","color":"006b75","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":61436281,"node_id":"MDU6TGFiZWw2MTQzNjI4MQ==","url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":636327968,"node_id":"MDU6TGFiZWw2MzYzMjc5Njg=","url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-04T23:26:35Z","updated_at":"2018-12-05T16:41:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/49514","html_url":"https://github.com/ansible/ansible/pull/49514","diff_url":"https://github.com/ansible/ansible/pull/49514.diff","patch_url":"https://github.com/ansible/ansible/pull/49514.patch"},"body":"##### SUMMARY\r\n<!--- Describe the change below, including rationale and design decisions -->\r\nrebase/port of https://github.com/ansible/ansible/pull/34027 post `firewalld` module refactor\r\n\r\nAdd support Direct rule operations add/remove\r\nOperation syntax\r\n Add Chain\r\n```\r\n    -  firewalld:\r\n          chain: sshg\r\n          fw_family: ipv4\r\n          table: filter\r\n          permanent: true\r\n          state: enabled\r\n```\r\nAdd rule to chain\r\n```\r\n    -  firewalld:\r\n          chain: sshg\r\n          fw_family: ipv4\r\n          table: filter\r\n          direct_rule: '-m tcp -p tcp --dport 332 -j ACCEPT'\r\n          permanent: true\r\n          state: enabled\r\n```\r\nRemove rule from chain\r\n```\r\n    - firewalld:\r\n          chain: sshg\r\n          fw_family: ipv4\r\n          table: filter\r\n          direct_rule: '-m tcp -p tcp --dport 332 -j ACCEPT'\r\n          permanent: true \r\n          state: disabled\r\n```\r\nRemove chain\r\n```\r\n    -  firewalld:\r\n          chain: sshg\r\n          fw_family: ipv4\r\n          table: filter\r\n          permanent: true\r\n```\r\n\r\nAdd passthrough\r\n```\r\n    - firewalld:\r\n          fw_family: ipv4\r\n          direct_rule: '-I FORWARD -o bridge3 -j ACCEPT'\r\n          permanent: true\r\n          state: enabled\r\n```\r\nRemove passthrough\r\n```\r\n    - firewalld:\r\n          fw_family: ipv4\r\n          direct_rule: '-I FORWARD -o bridge3 -j ACCEPT'\r\n          permanent: true\r\n          state: disabled\r\n```\r\n\r\nContact: pershin87@yandex.ru\r\n\r\n##### ISSUE TYPE\r\nFeature Pull Request\r\n\r\n##### COMPONENT NAME\r\nfirewalld module\r\n"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/444553969","html_url":"https://github.com/ansible/ansible/pull/49514#issuecomment-444553969","issue_url":"https://api.github.com/repos/ansible/ansible/issues/49514","id":444553969,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDU1Mzk2OQ==","user":{"login":"ansibot","id":6585283,"node_id":"MDQ6VXNlcjY1ODUyODM=","avatar_url":"https://avatars0.githubusercontent.com/u/6585283?v=4","gravatar_id":"","url":"https://api.github.com/users/ansibot","html_url":"https://github.com/ansibot","followers_url":"https://api.github.com/users/ansibot/followers","following_url":"https://api.github.com/users/ansibot/following{/other_user}","gists_url":"https://api.github.com/users/ansibot/gists{/gist_id}","starred_url":"https://api.github.com/users/ansibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansibot/subscriptions","organizations_url":"https://api.github.com/users/ansibot/orgs","repos_url":"https://api.github.com/users/ansibot/repos","events_url":"https://api.github.com/users/ansibot/events{/privacy}","received_events_url":"https://api.github.com/users/ansibot/received_events","type":"User","site_admin":false},"created_at":"2018-12-05T16:41:18Z","updated_at":"2018-12-05T16:41:18Z","author_association":"CONTRIBUTOR","body":"The test `ansible-test sanity --test pep8` [[explain](https://docs.ansible.com/ansible/devel/dev_guide/testing/sanity/pep8.html)] failed with 1 error:\n```\nlib/ansible/modules/system/firewalld.py:307:27: E128 continuation line under-indented for visual indent\n```\n<!-- job_id: 5c07f1b1b3b594070049e685 -->\n<!-- job_id: 5c07f1b897dab909007cdcef -->\n<!-- job_id: /testresults/ansible-test-sanity-pep8.json -->\n\n[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)\n<!--- boilerplate: shippable_test_result --->"}}
{"actor":{"display_login":"ansibot"}}