{"action":"created","comment":{"url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/pulls/comments/199314660","pull_request_review_id":133417372,"id":199314660,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTMxNDY2MA==","diff_hunk":"@@ -44,6 +44,7 @@ module.exports = {\n |**`include`**|`{RegExp\\|Array<RegExp>}`|`undefined`|Files to `include`|\n |**`exclude`**|`{RegExp\\|Array<RegExp>}`|`undefined`|Files to `exclude`|\n |**`cache`**|`{Boolean\\|String}`|`false`|Enable file caching|\n+|**`cacheKeys`**|`{Function(defaultCacheKeys, file) -> {Object}}`|`defaultCacheKeys => defaultCacheKeys`|Allows you to override default cache keys|","path":"README.md","position":4,"original_position":4,"commit_id":"142497e29afddedd697e99ef38363a84d4aaab5c","original_commit_id":"3e9acfa000008436e3084172f01d3567412bd5fd","user":{"login":"ooflorent","id":168498,"node_id":"MDQ6VXNlcjE2ODQ5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/168498?v=4","gravatar_id":"","url":"https://api.github.com/users/ooflorent","html_url":"https://github.com/ooflorent","followers_url":"https://api.github.com/users/ooflorent/followers","following_url":"https://api.github.com/users/ooflorent/following{/other_user}","gists_url":"https://api.github.com/users/ooflorent/gists{/gist_id}","starred_url":"https://api.github.com/users/ooflorent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooflorent/subscriptions","organizations_url":"https://api.github.com/users/ooflorent/orgs","repos_url":"https://api.github.com/users/ooflorent/repos","events_url":"https://api.github.com/users/ooflorent/events{/privacy}","received_events_url":"https://api.github.com/users/ooflorent/received_events","type":"User","site_admin":false},"body":"Example below:\r\n\r\n```js\r\n[\r\n  new UglifyJsPlugin({\r\n    cache: true,\r\n    cacheKeys: (defaultCacheKeys, file, options) => {\r\n      //                                ^^^^^^^\r\n      defaultCacheKeys.myCacheKey = 'myCacheKeyValue';\r\n      \r\n      return defaultCacheKeys;\r\n    },\r\n  })\r\n]\r\n```\r\n\r\nI now understand that my comment was wrong. The signature is correct, the example is not.","created_at":"2018-06-30T06:32:32Z","updated_at":"2018-06-30T06:33:20Z","html_url":"https://github.com/webpack-contrib/uglifyjs-webpack-plugin/pull/320#discussion_r199314660","pull_request_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/pulls/320","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/pulls/comments/199314660"},"html":{"href":"https://github.com/webpack-contrib/uglifyjs-webpack-plugin/pull/320#discussion_r199314660"},"pull_request":{"href":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/pulls/320"}},"in_reply_to_id":198985356},"pull_request":{"url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/pulls/320","id":198079289,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MDc5Mjg5","html_url":"https://github.com/webpack-contrib/uglifyjs-webpack-plugin/pull/320","diff_url":"https://github.com/webpack-contrib/uglifyjs-webpack-plugin/pull/320.diff","patch_url":"https://github.com/webpack-contrib/uglifyjs-webpack-plugin/pull/320.patch","issue_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/issues/320","number":320,"state":"open","locked":false,"title":"feat: `cacheKeys` option","user":{"login":"evilebottnawi","id":4567934,"node_id":"MDQ6VXNlcjQ1Njc5MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4567934?v=4","gravatar_id":"","url":"https://api.github.com/users/evilebottnawi","html_url":"https://github.com/evilebottnawi","followers_url":"https://api.github.com/users/evilebottnawi/followers","following_url":"https://api.github.com/users/evilebottnawi/following{/other_user}","gists_url":"https://api.github.com/users/evilebottnawi/gists{/gist_id}","starred_url":"https://api.github.com/users/evilebottnawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilebottnawi/subscriptions","organizations_url":"https://api.github.com/users/evilebottnawi/orgs","repos_url":"https://api.github.com/users/evilebottnawi/repos","events_url":"https://api.github.com/users/evilebottnawi/events{/privacy}","received_events_url":"https://api.github.com/users/evilebottnawi/received_events","type":"User","site_admin":false},"body":"<!--\r\n1. [Read and sign the CLA](https://cla.js.foundation/webpack/webpack.js.org). This needs to be done only once. PRs that haven't signed it won't be accepted.\r\n2. Check out the [development guide](https://webpack.js.org/development/) for the API and development guidelines.\r\n3. Read through the PR diff carefully as sometimes this can reveal issues. The work will be reviewed, but this can save some effort.\r\n-->\r\n","created_at":"2018-06-28T16:04:37Z","updated_at":"2018-06-30T06:33:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80fd330001ddc059970474ec19d14b4c39219d5b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shellscape","id":76371,"node_id":"MDQ6VXNlcjc2Mzcx","avatar_url":"https://avatars1.githubusercontent.com/u/76371?v=4","gravatar_id":"","url":"https://api.github.com/users/shellscape","html_url":"https://github.com/shellscape","followers_url":"https://api.github.com/users/shellscape/followers","following_url":"https://api.github.com/users/shellscape/following{/other_user}","gists_url":"https://api.github.com/users/shellscape/gists{/gist_id}","starred_url":"https://api.github.com/users/shellscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shellscape/subscriptions","organizations_url":"https://api.github.com/users/shellscape/orgs","repos_url":"https://api.github.com/users/shellscape/repos","events_url":"https://api.github.com/users/shellscape/events{/privacy}","received_events_url":"https://api.github.com/users/shellscape/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/pulls/320/commits","review_comments_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/pulls/320/comments","review_comment_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/issues/320/comments","statuses_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/statuses/142497e29afddedd697e99ef38363a84d4aaab5c","head":{"label":"webpack-contrib:feat-custom-cache-keys","ref":"feat-custom-cache-keys","sha":"142497e29afddedd697e99ef38363a84d4aaab5c","user":{"login":"webpack-contrib","id":25012217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEyMjE3","avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":79637359,"node_id":"MDEwOlJlcG9zaXRvcnk3OTYzNzM1OQ==","name":"uglifyjs-webpack-plugin","full_name":"webpack-contrib/uglifyjs-webpack-plugin","owner":{"login":"webpack-contrib","id":25012217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEyMjE3","avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack-contrib/uglifyjs-webpack-plugin","description":"UglifyJS Plugin","fork":false,"url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin","forks_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/forks","keys_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/teams","hooks_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/hooks","issue_events_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/events","assignees_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/tags","blobs_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/languages","stargazers_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/stargazers","contributors_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/contributors","subscribers_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/subscribers","subscription_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/subscription","commits_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/merges","archive_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/downloads","issues_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/labels{/name}","releases_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/deployments","created_at":"2017-01-21T09:49:17Z","updated_at":"2018-06-29T18:30:22Z","pushed_at":"2018-06-29T14:11:31Z","git_url":"git://github.com/webpack-contrib/uglifyjs-webpack-plugin.git","ssh_url":"git@github.com:webpack-contrib/uglifyjs-webpack-plugin.git","clone_url":"https://github.com/webpack-contrib/uglifyjs-webpack-plugin.git","svn_url":"https://github.com/webpack-contrib/uglifyjs-webpack-plugin","homepage":"","size":827,"stargazers_count":798,"watchers_count":798,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":135,"open_issues":19,"watchers":798,"default_branch":"master"}},"base":{"label":"webpack-contrib:master","ref":"master","sha":"f0d0a3b5c0865a431b6dfce7490263ed21531ba2","user":{"login":"webpack-contrib","id":25012217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEyMjE3","avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":79637359,"node_id":"MDEwOlJlcG9zaXRvcnk3OTYzNzM1OQ==","name":"uglifyjs-webpack-plugin","full_name":"webpack-contrib/uglifyjs-webpack-plugin","owner":{"login":"webpack-contrib","id":25012217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEyMjE3","avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack-contrib/uglifyjs-webpack-plugin","description":"UglifyJS Plugin","fork":false,"url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin","forks_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/forks","keys_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/teams","hooks_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/hooks","issue_events_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/events","assignees_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/tags","blobs_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/languages","stargazers_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/stargazers","contributors_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/contributors","subscribers_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/subscribers","subscription_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/subscription","commits_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/merges","archive_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/downloads","issues_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/labels{/name}","releases_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/deployments","created_at":"2017-01-21T09:49:17Z","updated_at":"2018-06-29T18:30:22Z","pushed_at":"2018-06-29T14:11:31Z","git_url":"git://github.com/webpack-contrib/uglifyjs-webpack-plugin.git","ssh_url":"git@github.com:webpack-contrib/uglifyjs-webpack-plugin.git","clone_url":"https://github.com/webpack-contrib/uglifyjs-webpack-plugin.git","svn_url":"https://github.com/webpack-contrib/uglifyjs-webpack-plugin","homepage":"","size":827,"stargazers_count":798,"watchers_count":798,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":135,"open_issues":19,"watchers":798,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/pulls/320"},"html":{"href":"https://github.com/webpack-contrib/uglifyjs-webpack-plugin/pull/320"},"issue":{"href":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/issues/320"},"comments":{"href":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/webpack-contrib/uglifyjs-webpack-plugin/statuses/142497e29afddedd697e99ef38363a84d4aaab5c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ooflorent"}}