{"action":"created","comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/221766698","pull_request_review_id":160497873,"id":221766698,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTc2NjY5OA==","diff_hunk":"@@ -13,3 +13,13 @@ UPDATE civicrm_navigation SET icon = \"crm-i fa-exchange\" WHERE name = \"Grants\" A\n UPDATE civicrm_navigation SET icon = \"crm-i fa-cog\" WHERE name = \"Administer\" AND domain_id = {$domainID} AND icon IS NULL;\n UPDATE civicrm_navigation SET icon = \"crm-i fa-life-ring\" WHERE name = \"Support\" AND domain_id = {$domainID} AND icon IS NULL;\n UPDATE civicrm_navigation SET icon = \"crm-i fa-bar-chart\" WHERE name = \"Reports\" AND domain_id = {$domainID} AND icon IS NULL;\n+\n+-- CRM-19751\n+INSERT INTO `civicrm_option_group` (`name`, `title`, `data_type`, `is_reserved`, `is_active`, `is_locked`)","path":"CRM/Upgrade/Incremental/sql/5.7.alpha1.mysql.tpl","position":6,"original_position":6,"commit_id":"3ffd5e7ca3fde880b541700043c037eaeb38c9c1","original_commit_id":"3ffd5e7ca3fde880b541700043c037eaeb38c9c1","user":{"login":"seamuslee001","id":6799125,"node_id":"MDQ6VXNlcjY3OTkxMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/6799125?v=4","gravatar_id":"","url":"https://api.github.com/users/seamuslee001","html_url":"https://github.com/seamuslee001","followers_url":"https://api.github.com/users/seamuslee001/followers","following_url":"https://api.github.com/users/seamuslee001/following{/other_user}","gists_url":"https://api.github.com/users/seamuslee001/gists{/gist_id}","starred_url":"https://api.github.com/users/seamuslee001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seamuslee001/subscriptions","organizations_url":"https://api.github.com/users/seamuslee001/orgs","repos_url":"https://api.github.com/users/seamuslee001/repos","events_url":"https://api.github.com/users/seamuslee001/events{/privacy}","received_events_url":"https://api.github.com/users/seamuslee001/received_events","type":"User","site_admin":false},"body":"also @eileenmcnaughton would this be better done via PHP?","created_at":"2018-10-01T21:43:42Z","updated_at":"2018-10-01T21:43:42Z","html_url":"https://github.com/civicrm/civicrm-core/pull/12883#discussion_r221766698","pull_request_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12883","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/221766698"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/12883#discussion_r221766698"},"pull_request":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12883"}},"in_reply_to_id":221766329},"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12883","id":219180048,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTgwMDQ4","html_url":"https://github.com/civicrm/civicrm-core/pull/12883","diff_url":"https://github.com/civicrm/civicrm-core/pull/12883.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/12883.patch","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/12883","number":12883,"state":"open","locked":false,"title":"Toward CRM-19751: change db schema so that on_hold is INT instead of BOOLEAN.","user":{"login":"twomice","id":759449,"node_id":"MDQ6VXNlcjc1OTQ0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/759449?v=4","gravatar_id":"","url":"https://api.github.com/users/twomice","html_url":"https://github.com/twomice","followers_url":"https://api.github.com/users/twomice/followers","following_url":"https://api.github.com/users/twomice/following{/other_user}","gists_url":"https://api.github.com/users/twomice/gists{/gist_id}","starred_url":"https://api.github.com/users/twomice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twomice/subscriptions","organizations_url":"https://api.github.com/users/twomice/orgs","repos_url":"https://api.github.com/users/twomice/repos","events_url":"https://api.github.com/users/twomice/events{/privacy}","received_events_url":"https://api.github.com/users/twomice/received_events","type":"User","site_admin":false},"body":"Overview\r\n----------------------------------------\r\nThe issue CRM-19751 aims to solve a problem in which Advanced Search criteria \"email on hold\" doesn't find emails with the \"on hold opt-out\" setting. To fix this, we need the form to offer a set of options for this criteria, not just a checkbox. But on the way to that, we noticed that the XML schema describes this column as a boolean, whereas the PHP code is treating it like an INT, variously storing integers between 0 and 2.  So before we fix the form, we need to fix the schema.\r\n\r\nBefore\r\n----------------------------------------\r\nSchema defines email.on_hold as a boolean; PHP on the other hand writes integers into this column.\r\n\r\nAfter\r\n----------------------------------------\r\n* New option_group _email_on_hold_ presents the 3 options currently in use in the code (0, 1, and 2, with appropriate labels.\r\n* Schema defines email.on_hold as an int, html type as 'select', with pseudoconstant of this new _email_on_hold_ option_group\r\n\r\nTechnical Details\r\n----------------------------------------\r\n\r\nComments\r\n----------------------------------------\r\nOnce this is merged, we can address the search form changes.","created_at":"2018-09-30T02:25:00Z","updated_at":"2018-10-01T21:43:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"264639724d8ce7bc8e6f65f03ab80474bf2facbc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":246037889,"node_id":"MDU6TGFiZWwyNDYwMzc4ODk=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12883/commits","review_comments_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12883/comments","review_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/12883/comments","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/3ffd5e7ca3fde880b541700043c037eaeb38c9c1","head":{"label":"twomice:CRM-19751_search_on_hold-2","ref":"CRM-19751_search_on_hold-2","sha":"3ffd5e7ca3fde880b541700043c037eaeb38c9c1","user":{"login":"twomice","id":759449,"node_id":"MDQ6VXNlcjc1OTQ0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/759449?v=4","gravatar_id":"","url":"https://api.github.com/users/twomice","html_url":"https://github.com/twomice","followers_url":"https://api.github.com/users/twomice/followers","following_url":"https://api.github.com/users/twomice/following{/other_user}","gists_url":"https://api.github.com/users/twomice/gists{/gist_id}","starred_url":"https://api.github.com/users/twomice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twomice/subscriptions","organizations_url":"https://api.github.com/users/twomice/orgs","repos_url":"https://api.github.com/users/twomice/repos","events_url":"https://api.github.com/users/twomice/events{/privacy}","received_events_url":"https://api.github.com/users/twomice/received_events","type":"User","site_admin":false},"repo":{"id":8569665,"node_id":"MDEwOlJlcG9zaXRvcnk4NTY5NjY1","name":"civicrm-core","full_name":"twomice/civicrm-core","private":false,"owner":{"login":"twomice","id":759449,"node_id":"MDQ6VXNlcjc1OTQ0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/759449?v=4","gravatar_id":"","url":"https://api.github.com/users/twomice","html_url":"https://github.com/twomice","followers_url":"https://api.github.com/users/twomice/followers","following_url":"https://api.github.com/users/twomice/following{/other_user}","gists_url":"https://api.github.com/users/twomice/gists{/gist_id}","starred_url":"https://api.github.com/users/twomice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twomice/subscriptions","organizations_url":"https://api.github.com/users/twomice/orgs","repos_url":"https://api.github.com/users/twomice/repos","events_url":"https://api.github.com/users/twomice/events{/privacy}","received_events_url":"https://api.github.com/users/twomice/received_events","type":"User","site_admin":false},"html_url":"https://github.com/twomice/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":true,"url":"https://api.github.com/repos/twomice/civicrm-core","forks_url":"https://api.github.com/repos/twomice/civicrm-core/forks","keys_url":"https://api.github.com/repos/twomice/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twomice/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twomice/civicrm-core/teams","hooks_url":"https://api.github.com/repos/twomice/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/twomice/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/twomice/civicrm-core/events","assignees_url":"https://api.github.com/repos/twomice/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/twomice/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/twomice/civicrm-core/tags","blobs_url":"https://api.github.com/repos/twomice/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twomice/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twomice/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/twomice/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twomice/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/twomice/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/twomice/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/twomice/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/twomice/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/twomice/civicrm-core/subscription","commits_url":"https://api.github.com/repos/twomice/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/twomice/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/twomice/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/twomice/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/twomice/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/twomice/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twomice/civicrm-core/merges","archive_url":"https://api.github.com/repos/twomice/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twomice/civicrm-core/downloads","issues_url":"https://api.github.com/repos/twomice/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/twomice/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/twomice/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/twomice/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twomice/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/twomice/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/twomice/civicrm-core/deployments","created_at":"2013-03-05T01:41:31Z","updated_at":"2018-09-30T00:10:45Z","pushed_at":"2018-09-30T02:13:24Z","git_url":"git://github.com/twomice/civicrm-core.git","ssh_url":"git@github.com:twomice/civicrm-core.git","clone_url":"https://github.com/twomice/civicrm-core.git","svn_url":"https://github.com/twomice/civicrm-core","homepage":null,"size":157246,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"civicrm:master","ref":"master","sha":"98d0b6c0813e7ea957ef6a7890181614b709097b","user":{"login":"civicrm","id":136373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":8495499,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk1NDk5","name":"civicrm-core","full_name":"civicrm/civicrm-core","private":false,"owner":{"login":"civicrm","id":136373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/civicrm/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":false,"url":"https://api.github.com/repos/civicrm/civicrm-core","forks_url":"https://api.github.com/repos/civicrm/civicrm-core/forks","keys_url":"https://api.github.com/repos/civicrm/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civicrm-core/teams","hooks_url":"https://api.github.com/repos/civicrm/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civicrm-core/events","assignees_url":"https://api.github.com/repos/civicrm/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civicrm-core/tags","blobs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/civicrm/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civicrm-core/subscription","commits_url":"https://api.github.com/repos/civicrm/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civicrm-core/merges","archive_url":"https://api.github.com/repos/civicrm/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civicrm-core/downloads","issues_url":"https://api.github.com/repos/civicrm/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civicrm-core/deployments","created_at":"2013-03-01T06:11:56Z","updated_at":"2018-10-01T21:40:38Z","pushed_at":"2018-10-01T21:40:00Z","git_url":"git://github.com/civicrm/civicrm-core.git","ssh_url":"git@github.com:civicrm/civicrm-core.git","clone_url":"https://github.com/civicrm/civicrm-core.git","svn_url":"https://github.com/civicrm/civicrm-core","homepage":null,"size":167089,"stargazers_count":297,"watchers_count":297,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":640,"mirror_url":null,"archived":false,"open_issues_count":120,"license":null,"forks":640,"open_issues":120,"watchers":297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12883"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/12883"},"issue":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/12883"},"comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/12883/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12883/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12883/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civicrm-core/statuses/3ffd5e7ca3fde880b541700043c037eaeb38c9c1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"seamuslee001"}}