{"action":"created","issue":{"url":"https://api.github.com/repos/fastai/fastai/issues/978","repository_url":"https://api.github.com/repos/fastai/fastai","labels_url":"https://api.github.com/repos/fastai/fastai/issues/978/labels{/name}","comments_url":"https://api.github.com/repos/fastai/fastai/issues/978/comments","events_url":"https://api.github.com/repos/fastai/fastai/issues/978/events","html_url":"https://github.com/fastai/fastai/issues/978","id":374248963,"node_id":"MDU6SXNzdWUzNzQyNDg5NjM=","number":978,"title":"`download_images` bug","user":{"login":"WNoxchi","id":16154304,"node_id":"MDQ6VXNlcjE2MTU0MzA0","avatar_url":"https://avatars2.githubusercontent.com/u/16154304?v=4","gravatar_id":"","url":"https://api.github.com/users/WNoxchi","html_url":"https://github.com/WNoxchi","followers_url":"https://api.github.com/users/WNoxchi/followers","following_url":"https://api.github.com/users/WNoxchi/following{/other_user}","gists_url":"https://api.github.com/users/WNoxchi/gists{/gist_id}","starred_url":"https://api.github.com/users/WNoxchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WNoxchi/subscriptions","organizations_url":"https://api.github.com/users/WNoxchi/orgs","repos_url":"https://api.github.com/users/WNoxchi/repos","events_url":"https://api.github.com/users/WNoxchi/events{/privacy}","received_events_url":"https://api.github.com/users/WNoxchi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-26T06:49:01Z","updated_at":"2018-10-27T14:19:20Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"<!-- **Please note**: Installation issues should be reported here:\r\n\r\nfastai-1.0.x: http://forums.fast.ai/t/fastai-v1-install-issues-thread/24111\r\nfastai-0.7.x: http://forums.fast.ai/t/fastai-v0-install-issues-thread/24652\r\n-->\r\n\r\n**Describe the bug**\r\n<!-- A clear and concise description of what the bug is. -->\r\n`download_images` either fails silently or throws a `BrokenProcessPool` error when called to download images from urls. `download_images` can be made to start working as intended, by first running `download_url`. This happens when following along with [course-v3/nbs/dl1/download_images.ipynb](https://github.com/fastai/course-v3/blob/master/nbs/dl1/download_images.ipynb) with your own set of urls.\r\n\r\n**To Reproduce**\r\n<!-- Steps to reproduce the behavior. -->\r\n<!-- If possible please add a new test for https://github.com/fastai/fastai/tests that helps us reproduce the problem and will help with future regression testing -->\r\nSee gist: [fastai_bug_download_images_20181026.ipynb](https://gist.github.com/WNoxchi/ced5ad2c8248a152ed1ae5334b742290)\r\n\r\n**Expected behavior**\r\n<!-- A clear and concise description of what you expected to happen. -->\r\n`download_images` should download (or attemp to) all images pertaining to the urls in a provided filepath, to a specified folder.\r\n\r\n**Screenshots**\r\n<!-- If applicable, add screenshots to help explain your problem. -->\r\nSee gist above.\r\n\r\n**Additional context**\r\n<!-- Add any other context about the problem here. -->\r\nfastai developer install, updated 20181026 at 02:26 EST; courses-v3 folder updated soon before.\r\nSystem: macOS 10.14.\r\n"},"comment":{"url":"https://api.github.com/repos/fastai/fastai/issues/comments/433624545","html_url":"https://github.com/fastai/fastai/issues/978#issuecomment-433624545","issue_url":"https://api.github.com/repos/fastai/fastai/issues/978","id":433624545,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzYyNDU0NQ==","user":{"login":"jph00","id":346999,"node_id":"MDQ6VXNlcjM0Njk5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/346999?v=4","gravatar_id":"","url":"https://api.github.com/users/jph00","html_url":"https://github.com/jph00","followers_url":"https://api.github.com/users/jph00/followers","following_url":"https://api.github.com/users/jph00/following{/other_user}","gists_url":"https://api.github.com/users/jph00/gists{/gist_id}","starred_url":"https://api.github.com/users/jph00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jph00/subscriptions","organizations_url":"https://api.github.com/users/jph00/orgs","repos_url":"https://api.github.com/users/jph00/repos","events_url":"https://api.github.com/users/jph00/events{/privacy}","received_events_url":"https://api.github.com/users/jph00/received_events","type":"User","site_admin":false},"created_at":"2018-10-27T14:19:20Z","updated_at":"2018-10-27T14:19:20Z","author_association":"MEMBER","body":"Well that's odd! Not sure what's going on there. Try using a debugger and removing the use of the process pool to if you can find the actual error that's causing this."}}
{"actor":{"display_login":"jph00"}}