{"action":"created","comment":{"url":"https://api.github.com/repos/ruslo/polly/pulls/comments/171630624","pull_request_review_id":100518137,"id":171630624,"diff_hunk":"@@ -23,22 +23,51 @@ environment:\n       EXAMPLE: 01-executable\n       CONFIG: Release\n \n+    - TOOLCHAIN: \"vs-14-2015\"\n+      EXAMPLE: 02-library\n+      CONFIG: Release\n+\n+    - TOOLCHAIN: \"vs-14-2015\"\n+      EXAMPLE: 03-shared-link\n+      CONFIG: Release\n+\n     - TOOLCHAIN: \"mingw\"\n       EXAMPLE: 01-executable\n       CONFIG: Release\n \n-    - TOOLCHAIN: \"msys\"\n+    - TOOLCHAIN: \"mingw-cxx14\"\n       EXAMPLE: 01-executable\n       CONFIG: Release\n+      CMAKE_MAKE_PROGRAM: mingw32-make.exe\n+      MINGW_PATH: C:\\mingw-w64\\x86_64-7.2.0-posix-seh-rt_v5-rev1\\mingw64\\bin\n+      ADD_TO_PATH: C:\\mingw-w64\\x86_64-7.2.0-posix-seh-rt_v5-rev1\\mingw64\\bin \n \n-    - TOOLCHAIN: \"vs-14-2015\"\n-      EXAMPLE: 02-library\n+    - TOOLCHAIN: \"mingw-cxx17\"\n+      EXAMPLE: 01-executable\n       CONFIG: Release\n+      CMAKE_MAKE_PROGRAM: mingw32-make.exe\n+      MINGW_PATH: C:\\mingw-w64\\x86_64-7.2.0-posix-seh-rt_v5-rev1\\mingw64\\bin\n+      ADD_TO_PATH: C:\\mingw-w64\\x86_64-7.2.0-posix-seh-rt_v5-rev1\\mingw64\\bin \n \n-    - TOOLCHAIN: \"vs-14-2015\"\n-      EXAMPLE: 03-shared-link\n+    - TOOLCHAIN: \"msys\"\n+      EXAMPLE: 01-executable\n       CONFIG: Release\n \n+    #- TOOLCHAIN: \"msys-cxx14\"","path":"appveyor.yml","position":39,"original_position":39,"commit_id":"fe6736d235f01d3e41bee45ffd282f4b9101d73f","original_commit_id":"fe6736d235f01d3e41bee45ffd282f4b9101d73f","user":{"login":"ckaminski","id":437007,"avatar_url":"https://avatars1.githubusercontent.com/u/437007?v=4","gravatar_id":"","url":"https://api.github.com/users/ckaminski","html_url":"https://github.com/ckaminski","followers_url":"https://api.github.com/users/ckaminski/followers","following_url":"https://api.github.com/users/ckaminski/following{/other_user}","gists_url":"https://api.github.com/users/ckaminski/gists{/gist_id}","starred_url":"https://api.github.com/users/ckaminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckaminski/subscriptions","organizations_url":"https://api.github.com/users/ckaminski/orgs","repos_url":"https://api.github.com/users/ckaminski/repos","events_url":"https://api.github.com/users/ckaminski/events{/privacy}","received_events_url":"https://api.github.com/users/ckaminski/received_events","type":"User","site_admin":false},"body":"Sorry, I was experimenting with fixing msys.  I'll do this work in another branch so you won't get nagged by changes, but I'll remove anything I can't fix. \r\n","created_at":"2018-03-01T17:22:45Z","updated_at":"2018-03-01T17:22:45Z","html_url":"https://github.com/ruslo/polly/pull/235#discussion_r171630624","pull_request_url":"https://api.github.com/repos/ruslo/polly/pulls/235","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ruslo/polly/pulls/comments/171630624"},"html":{"href":"https://github.com/ruslo/polly/pull/235#discussion_r171630624"},"pull_request":{"href":"https://api.github.com/repos/ruslo/polly/pulls/235"}},"in_reply_to_id":171622213},"pull_request":{"url":"https://api.github.com/repos/ruslo/polly/pulls/235","id":171111213,"html_url":"https://github.com/ruslo/polly/pull/235","diff_url":"https://github.com/ruslo/polly/pull/235.diff","patch_url":"https://github.com/ruslo/polly/pull/235.patch","issue_url":"https://api.github.com/repos/ruslo/polly/issues/235","number":235,"state":"open","locked":false,"title":"* Adding windows c++14/17 support","user":{"login":"ckaminski","id":437007,"avatar_url":"https://avatars1.githubusercontent.com/u/437007?v=4","gravatar_id":"","url":"https://api.github.com/users/ckaminski","html_url":"https://github.com/ckaminski","followers_url":"https://api.github.com/users/ckaminski/followers","following_url":"https://api.github.com/users/ckaminski/following{/other_user}","gists_url":"https://api.github.com/users/ckaminski/gists{/gist_id}","starred_url":"https://api.github.com/users/ckaminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckaminski/subscriptions","organizations_url":"https://api.github.com/users/ckaminski/orgs","repos_url":"https://api.github.com/users/ckaminski/repos","events_url":"https://api.github.com/users/ckaminski/events{/privacy}","received_events_url":"https://api.github.com/users/ckaminski/received_events","type":"User","site_admin":false},"body":"* Adding windows mingw c++14/17 support\r\n* attempting to add windows msys C++14/17 support\r\n  - Issue with shell finding CMAKE_MAKE_PROGRAM.\r\n\r\nOpen to input on fixing the broken msys builds: \r\nhttps://ci.appveyor.com/project/ckaminski/polly/build/1.0.56/job/qfg2x34sqyt96tx8\r\n\r\n","created_at":"2018-02-23T20:40:30Z","updated_at":"2018-03-01T17:22:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c190de83f0eafcd02077cb189a5e068ad5b8aeb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ruslo/polly/pulls/235/commits","review_comments_url":"https://api.github.com/repos/ruslo/polly/pulls/235/comments","review_comment_url":"https://api.github.com/repos/ruslo/polly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ruslo/polly/issues/235/comments","statuses_url":"https://api.github.com/repos/ruslo/polly/statuses/fe6736d235f01d3e41bee45ffd282f4b9101d73f","head":{"label":"ckaminski:win-cxx17","ref":"win-cxx17","sha":"fe6736d235f01d3e41bee45ffd282f4b9101d73f","user":{"login":"ckaminski","id":437007,"avatar_url":"https://avatars1.githubusercontent.com/u/437007?v=4","gravatar_id":"","url":"https://api.github.com/users/ckaminski","html_url":"https://github.com/ckaminski","followers_url":"https://api.github.com/users/ckaminski/followers","following_url":"https://api.github.com/users/ckaminski/following{/other_user}","gists_url":"https://api.github.com/users/ckaminski/gists{/gist_id}","starred_url":"https://api.github.com/users/ckaminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckaminski/subscriptions","organizations_url":"https://api.github.com/users/ckaminski/orgs","repos_url":"https://api.github.com/users/ckaminski/repos","events_url":"https://api.github.com/users/ckaminski/events{/privacy}","received_events_url":"https://api.github.com/users/ckaminski/received_events","type":"User","site_admin":false},"repo":{"id":118846343,"name":"polly","full_name":"ckaminski/polly","owner":{"login":"ckaminski","id":437007,"avatar_url":"https://avatars1.githubusercontent.com/u/437007?v=4","gravatar_id":"","url":"https://api.github.com/users/ckaminski","html_url":"https://github.com/ckaminski","followers_url":"https://api.github.com/users/ckaminski/followers","following_url":"https://api.github.com/users/ckaminski/following{/other_user}","gists_url":"https://api.github.com/users/ckaminski/gists{/gist_id}","starred_url":"https://api.github.com/users/ckaminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckaminski/subscriptions","organizations_url":"https://api.github.com/users/ckaminski/orgs","repos_url":"https://api.github.com/users/ckaminski/repos","events_url":"https://api.github.com/users/ckaminski/events{/privacy}","received_events_url":"https://api.github.com/users/ckaminski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ckaminski/polly","description":" :wrench: Collection of CMake toolchain files and scripts for cross-platform build and CI testing (GCC, Visual Studio, iOS, Android, Clang analyzer, sanitizers etc.)","fork":true,"url":"https://api.github.com/repos/ckaminski/polly","forks_url":"https://api.github.com/repos/ckaminski/polly/forks","keys_url":"https://api.github.com/repos/ckaminski/polly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckaminski/polly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckaminski/polly/teams","hooks_url":"https://api.github.com/repos/ckaminski/polly/hooks","issue_events_url":"https://api.github.com/repos/ckaminski/polly/issues/events{/number}","events_url":"https://api.github.com/repos/ckaminski/polly/events","assignees_url":"https://api.github.com/repos/ckaminski/polly/assignees{/user}","branches_url":"https://api.github.com/repos/ckaminski/polly/branches{/branch}","tags_url":"https://api.github.com/repos/ckaminski/polly/tags","blobs_url":"https://api.github.com/repos/ckaminski/polly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckaminski/polly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckaminski/polly/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckaminski/polly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckaminski/polly/statuses/{sha}","languages_url":"https://api.github.com/repos/ckaminski/polly/languages","stargazers_url":"https://api.github.com/repos/ckaminski/polly/stargazers","contributors_url":"https://api.github.com/repos/ckaminski/polly/contributors","subscribers_url":"https://api.github.com/repos/ckaminski/polly/subscribers","subscription_url":"https://api.github.com/repos/ckaminski/polly/subscription","commits_url":"https://api.github.com/repos/ckaminski/polly/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckaminski/polly/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckaminski/polly/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckaminski/polly/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckaminski/polly/contents/{+path}","compare_url":"https://api.github.com/repos/ckaminski/polly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckaminski/polly/merges","archive_url":"https://api.github.com/repos/ckaminski/polly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckaminski/polly/downloads","issues_url":"https://api.github.com/repos/ckaminski/polly/issues{/number}","pulls_url":"https://api.github.com/repos/ckaminski/polly/pulls{/number}","milestones_url":"https://api.github.com/repos/ckaminski/polly/milestones{/number}","notifications_url":"https://api.github.com/repos/ckaminski/polly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckaminski/polly/labels{/name}","releases_url":"https://api.github.com/repos/ckaminski/polly/releases{/id}","deployments_url":"https://api.github.com/repos/ckaminski/polly/deployments","created_at":"2018-01-25T01:42:02Z","updated_at":"2018-01-25T01:42:05Z","pushed_at":"2018-03-01T16:11:58Z","git_url":"git://github.com/ckaminski/polly.git","ssh_url":"git@github.com:ckaminski/polly.git","clone_url":"https://github.com/ckaminski/polly.git","svn_url":"https://github.com/ckaminski/polly","homepage":"http://goo.gl/5JpHX","size":1348,"stargazers_count":0,"watchers_count":0,"language":"CMake","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ruslo:master","ref":"master","sha":"def6b50d7f08e164ac874232c474ffb3bff9b970","user":{"login":"ruslo","id":4346993,"avatar_url":"https://avatars2.githubusercontent.com/u/4346993?v=4","gravatar_id":"","url":"https://api.github.com/users/ruslo","html_url":"https://github.com/ruslo","followers_url":"https://api.github.com/users/ruslo/followers","following_url":"https://api.github.com/users/ruslo/following{/other_user}","gists_url":"https://api.github.com/users/ruslo/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslo/subscriptions","organizations_url":"https://api.github.com/users/ruslo/orgs","repos_url":"https://api.github.com/users/ruslo/repos","events_url":"https://api.github.com/users/ruslo/events{/privacy}","received_events_url":"https://api.github.com/users/ruslo/received_events","type":"User","site_admin":false},"repo":{"id":14066763,"name":"polly","full_name":"ruslo/polly","owner":{"login":"ruslo","id":4346993,"avatar_url":"https://avatars2.githubusercontent.com/u/4346993?v=4","gravatar_id":"","url":"https://api.github.com/users/ruslo","html_url":"https://github.com/ruslo","followers_url":"https://api.github.com/users/ruslo/followers","following_url":"https://api.github.com/users/ruslo/following{/other_user}","gists_url":"https://api.github.com/users/ruslo/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslo/subscriptions","organizations_url":"https://api.github.com/users/ruslo/orgs","repos_url":"https://api.github.com/users/ruslo/repos","events_url":"https://api.github.com/users/ruslo/events{/privacy}","received_events_url":"https://api.github.com/users/ruslo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ruslo/polly","description":" :wrench: Collection of CMake toolchain files and scripts for cross-platform build and CI testing (GCC, Visual Studio, iOS, Android, Clang analyzer, sanitizers etc.)","fork":false,"url":"https://api.github.com/repos/ruslo/polly","forks_url":"https://api.github.com/repos/ruslo/polly/forks","keys_url":"https://api.github.com/repos/ruslo/polly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruslo/polly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruslo/polly/teams","hooks_url":"https://api.github.com/repos/ruslo/polly/hooks","issue_events_url":"https://api.github.com/repos/ruslo/polly/issues/events{/number}","events_url":"https://api.github.com/repos/ruslo/polly/events","assignees_url":"https://api.github.com/repos/ruslo/polly/assignees{/user}","branches_url":"https://api.github.com/repos/ruslo/polly/branches{/branch}","tags_url":"https://api.github.com/repos/ruslo/polly/tags","blobs_url":"https://api.github.com/repos/ruslo/polly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruslo/polly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruslo/polly/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruslo/polly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruslo/polly/statuses/{sha}","languages_url":"https://api.github.com/repos/ruslo/polly/languages","stargazers_url":"https://api.github.com/repos/ruslo/polly/stargazers","contributors_url":"https://api.github.com/repos/ruslo/polly/contributors","subscribers_url":"https://api.github.com/repos/ruslo/polly/subscribers","subscription_url":"https://api.github.com/repos/ruslo/polly/subscription","commits_url":"https://api.github.com/repos/ruslo/polly/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruslo/polly/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruslo/polly/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruslo/polly/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruslo/polly/contents/{+path}","compare_url":"https://api.github.com/repos/ruslo/polly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruslo/polly/merges","archive_url":"https://api.github.com/repos/ruslo/polly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruslo/polly/downloads","issues_url":"https://api.github.com/repos/ruslo/polly/issues{/number}","pulls_url":"https://api.github.com/repos/ruslo/polly/pulls{/number}","milestones_url":"https://api.github.com/repos/ruslo/polly/milestones{/number}","notifications_url":"https://api.github.com/repos/ruslo/polly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruslo/polly/labels{/name}","releases_url":"https://api.github.com/repos/ruslo/polly/releases{/id}","deployments_url":"https://api.github.com/repos/ruslo/polly/deployments","created_at":"2013-11-02T13:43:23Z","updated_at":"2018-03-01T15:43:45Z","pushed_at":"2018-03-01T16:11:59Z","git_url":"git://github.com/ruslo/polly.git","ssh_url":"git@github.com:ruslo/polly.git","clone_url":"https://github.com/ruslo/polly.git","svn_url":"https://github.com/ruslo/polly","homepage":"http://goo.gl/5JpHX","size":1364,"stargazers_count":378,"watchers_count":378,"language":"CMake","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":105,"open_issues":24,"watchers":378,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ruslo/polly/pulls/235"},"html":{"href":"https://github.com/ruslo/polly/pull/235"},"issue":{"href":"https://api.github.com/repos/ruslo/polly/issues/235"},"comments":{"href":"https://api.github.com/repos/ruslo/polly/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/ruslo/polly/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/ruslo/polly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ruslo/polly/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/ruslo/polly/statuses/fe6736d235f01d3e41bee45ffd282f4b9101d73f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ckaminski"}}