{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65122","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65122/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65122/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65122/events","html_url":"https://github.com/kubernetes/kubernetes/issues/65122","id":332603604,"node_id":"MDU6SXNzdWUzMzI2MDM2MDQ=","number":65122,"title":"CSI volume source fstype incompatible with CSI spec","user":{"login":"msau42","id":24448061,"node_id":"MDQ6VXNlcjI0NDQ4MDYx","avatar_url":"https://avatars3.githubusercontent.com/u/24448061?v=4","gravatar_id":"","url":"https://api.github.com/users/msau42","html_url":"https://github.com/msau42","followers_url":"https://api.github.com/users/msau42/followers","following_url":"https://api.github.com/users/msau42/following{/other_user}","gists_url":"https://api.github.com/users/msau42/gists{/gist_id}","starred_url":"https://api.github.com/users/msau42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msau42/subscriptions","organizations_url":"https://api.github.com/users/msau42/orgs","repos_url":"https://api.github.com/users/msau42/repos","events_url":"https://api.github.com/users/msau42/events{/privacy}","received_events_url":"https://api.github.com/users/msau42/received_events","type":"User","site_admin":false},"labels":[{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":169428334,"node_id":"MDU6TGFiZWwxNjk0MjgzMzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-15T00:00:32Z","updated_at":"2018-06-15T00:10:20Z","closed_at":null,"author_association":"MEMBER","body":"<!-- This form is for bug reports and feature requests ONLY!\r\n\r\nIf you're looking for help check [Stack Overflow](https://stackoverflow.com/questions/tagged/kubernetes) and the [troubleshooting guide](https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/).\r\n\r\nIf the matter is security related, please disclose it privately via https://kubernetes.io/security/.\r\n-->\r\n\r\n**Is this a BUG REPORT or FEATURE REQUEST?**:\r\n@kubernetes/sig-storage-bugs \r\n\r\n**What happened**:\r\nCSI spec allows for an empty fstype string.  This is intended for non-block plugins like nfs and gluster where filesystems are not separately created on the volume.\r\n```\r\n  // Indicate that the volume will be accessed via the filesystem API.\r\n  message MountVolume {\r\n    // The filesystem type. This field is OPTIONAL.\r\n    // An empty string is equal to an unspecified field value.\r\n    string fs_type = 1;\r\n  }\r\n```\r\n\r\nThe Kubernetes CSI volume source API defaults fstype to \"ext4\" and doesn't allow an empty string:\r\n```\r\n        // Filesystem type to mount.\r\n        // Must be a filesystem type supported by the host operating system.\r\n        // Ex. \"ext4\", \"xfs\", \"ntfs\". Implicitly inferred to be \"ext4\" if unspecified.\r\n        // +optional\r\n        FSType string\r\n```\r\n\r\nThis makes it impossible for Kubernetes to pass in an empty fs_type to the plugin.  \r\n\r\n**What you expected to happen**:\r\nSince we currently leave fs creation and formatting up to the plugin, the plugin should be the one to decide the default.\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/397474949","html_url":"https://github.com/kubernetes/kubernetes/issues/65122#issuecomment-397474949","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65122","id":397474949,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzQ3NDk0OQ==","user":{"login":"saad-ali","id":10052848,"node_id":"MDQ6VXNlcjEwMDUyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"created_at":"2018-06-15T00:10:19Z","updated_at":"2018-06-15T00:10:19Z","author_association":"MEMBER","body":"We should change the default `FSType` value for `CSIPersistentVolumeSource` empty string. And plugins will be responsible for setting a sane default."}}
{"actor":{"display_login":"saad-ali"}}