{"action":"created","issue":{"url":"https://api.github.com/repos/python/cpython/issues/8547","repository_url":"https://api.github.com/repos/python/cpython","labels_url":"https://api.github.com/repos/python/cpython/issues/8547/labels{/name}","comments_url":"https://api.github.com/repos/python/cpython/issues/8547/comments","events_url":"https://api.github.com/repos/python/cpython/issues/8547/events","html_url":"https://github.com/python/cpython/pull/8547","id":345523990,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjM4MTA4","number":8547,"title":"bpo-34270: added the ability to name asyncio tasks","user":{"login":"agronholm","id":130003,"node_id":"MDQ6VXNlcjEzMDAwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/130003?v=4","gravatar_id":"","url":"https://api.github.com/users/agronholm","html_url":"https://github.com/agronholm","followers_url":"https://api.github.com/users/agronholm/followers","following_url":"https://api.github.com/users/agronholm/following{/other_user}","gists_url":"https://api.github.com/users/agronholm/gists{/gist_id}","starred_url":"https://api.github.com/users/agronholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agronholm/subscriptions","organizations_url":"https://api.github.com/users/agronholm/orgs","repos_url":"https://api.github.com/users/agronholm/repos","events_url":"https://api.github.com/users/agronholm/events{/privacy}","received_events_url":"https://api.github.com/users/agronholm/received_events","type":"User","site_admin":false},"labels":[{"id":536945472,"node_id":"MDU6TGFiZWw1MzY5NDU0NzI=","url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666979922,"node_id":"MDU6TGFiZWw2NjY5Nzk5MjI=","url":"https://api.github.com/repos/python/cpython/labels/awaiting%20changes","name":"awaiting changes","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-07-29T11:41:28Z","updated_at":"2018-08-01T09:16:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/8547","html_url":"https://github.com/python/cpython/pull/8547","diff_url":"https://github.com/python/cpython/pull/8547.diff","patch_url":"https://github.com/python/cpython/pull/8547.patch"},"body":"The ability to name individual tasks helps developers debug complex\r\nasyncio applications.\r\n\r\nCo-authored-by: Antti Haapala <antti.haapala@anttipatterns.com>\r\n\r\n<!--\r\nThanks for your contribution!\r\nPlease read this comment in its entirety. It's quite important.\r\n\r\n# Pull Request title\r\n\r\nIt should be in the following format:\r\n\r\n```\r\nbpo-NNNN: Summary of the changes made\r\n```\r\n\r\nWhere: bpo-NNNN refers to the issue number in the https://bugs.python.org.\r\n\r\nMost PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.\r\n\r\n# Backport Pull Request title\r\n\r\nIf this is a backport PR (PR made against branches other than `master`),\r\nplease ensure that the PR title is in the following format:\r\n\r\n```\r\n[X.Y] <title from the original PR> (GH-NNNN)\r\n```\r\n\r\nWhere: [X.Y] is the branch name, e.g. [3.6].\r\n\r\nGH-NNNN refers to the PR number from `master`.\r\n\r\n-->\r\n\n\n<!-- issue-number: [bpo-34270](https://www.bugs.python.org/issue34270) -->\nhttps://bugs.python.org/issue34270\n<!-- /issue-number -->\n"},"comment":{"url":"https://api.github.com/repos/python/cpython/issues/comments/409509395","html_url":"https://github.com/python/cpython/pull/8547#issuecomment-409509395","issue_url":"https://api.github.com/repos/python/cpython/issues/8547","id":409509395,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTUwOTM5NQ==","user":{"login":"agronholm","id":130003,"node_id":"MDQ6VXNlcjEzMDAwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/130003?v=4","gravatar_id":"","url":"https://api.github.com/users/agronholm","html_url":"https://github.com/agronholm","followers_url":"https://api.github.com/users/agronholm/followers","following_url":"https://api.github.com/users/agronholm/following{/other_user}","gists_url":"https://api.github.com/users/agronholm/gists{/gist_id}","starred_url":"https://api.github.com/users/agronholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agronholm/subscriptions","organizations_url":"https://api.github.com/users/agronholm/orgs","repos_url":"https://api.github.com/users/agronholm/repos","events_url":"https://api.github.com/users/agronholm/events{/privacy}","received_events_url":"https://api.github.com/users/agronholm/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T09:16:49Z","updated_at":"2018-08-01T09:16:49Z","author_association":"NONE","body":"> IOW I'm trying to argue here that we can completely avoid any potential future compatibility problem in this very case with some, admittedly ugly, workaround in asyncio.\r\n\r\nSorry to drag this on but I don't understand how this workaround would solve this problem. Suppose that we refrain from modifying the task factory API but add `Task.set_name()`, a dependency which tries to set the task name would still get an `AttributeError` since the custom task factory could still be producing `Task` instances which don't have the `set_name()` method. So what am I missing?"}}
{"actor":{"display_login":"agronholm"}}