{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/dmd/pulls/comments/207033652","pull_request_review_id":142565787,"id":207033652,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzAzMzY1Mg==","diff_hunk":"@@ -3588,6 +3589,32 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor\n         }\n \n         result = Expression.combine(argprefix, exp);\n+\n+        if (isSuper)\n+        {\n+            auto ad = sc.func ? sc.func.isThis() : null;\n+            auto cd = ad ? ad.isClassDeclaration() : null;\n+            if (cd && cd.classKind == ClassKind.cpp)\n+            {\n+                // if super is defined in C++, it sets the vtable pointer to the base class\n+                // so we have to rewrite it, but still return 'this' from super() call:\n+                // (auto tmp = super(), this.__vptr = __vtbl, tmp)","path":"src/dmd/expressionsem.d","position":30,"original_position":30,"commit_id":"403d5f0148abe60ac1836da9038c18cebd8b8644","original_commit_id":"403d5f0148abe60ac1836da9038c18cebd8b8644","user":{"login":"kinke","id":1889215,"node_id":"MDQ6VXNlcjE4ODkyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1889215?v=4","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"body":"This assignment cannot be interpreted at compile-time (unsupported cast), see https://forum.dlang.org/thread/ghusgzuqpcskhwzmlwbh@forum.dlang.org.","created_at":"2018-08-01T21:14:02Z","updated_at":"2018-08-01T21:14:03Z","html_url":"https://github.com/dlang/dmd/pull/8362#discussion_r207033652","pull_request_url":"https://api.github.com/repos/dlang/dmd/pulls/8362","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments/207033652"},"html":{"href":"https://github.com/dlang/dmd/pull/8362#discussion_r207033652"},"pull_request":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8362"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/8362","id":195331636,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzMxNjM2","html_url":"https://github.com/dlang/dmd/pull/8362","diff_url":"https://github.com/dlang/dmd/pull/8362.diff","patch_url":"https://github.com/dlang/dmd/pull/8362.patch","issue_url":"https://api.github.com/repos/dlang/dmd/issues/8362","number":8362,"state":"closed","locked":false,"title":"fix Issue 18966 - extern(C++) constructor should match C++ semantics …","user":{"login":"rainers","id":702284,"node_id":"MDQ6VXNlcjcwMjI4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/702284?v=4","gravatar_id":"","url":"https://api.github.com/users/rainers","html_url":"https://github.com/rainers","followers_url":"https://api.github.com/users/rainers/followers","following_url":"https://api.github.com/users/rainers/following{/other_user}","gists_url":"https://api.github.com/users/rainers/gists{/gist_id}","starred_url":"https://api.github.com/users/rainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainers/subscriptions","organizations_url":"https://api.github.com/users/rainers/orgs","repos_url":"https://api.github.com/users/rainers/repos","events_url":"https://api.github.com/users/rainers/events{/privacy}","received_events_url":"https://api.github.com/users/rainers/received_events","type":"User","site_admin":false},"body":"…assigning vtable\r\n\r\nset vtbl after exlicit or implicit call to super() in C++ constructors","created_at":"2018-06-16T13:02:14Z","updated_at":"2018-08-01T21:14:03Z","closed_at":"2018-06-17T17:35:58Z","merged_at":"2018-06-17T17:35:58Z","merge_commit_sha":"297844f035be1753cbbf07f9338c6383b2b62708","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ibuclaw","id":397929,"node_id":"MDQ6VXNlcjM5NzkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/397929?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":537492633,"node_id":"MDU6TGFiZWw1Mzc0OTI2MzM=","url":"https://api.github.com/repos/dlang/dmd/labels/Bug%20Fix","name":"Bug Fix","color":"0052cc","default":false},{"id":876579237,"node_id":"MDU6TGFiZWw4NzY1NzkyMzc=","url":"https://api.github.com/repos/dlang/dmd/labels/Vision","name":"Vision","color":"aafc07","default":false},{"id":502721241,"node_id":"MDU6TGFiZWw1MDI3MjEyNDE=","url":"https://api.github.com/repos/dlang/dmd/labels/auto-merge","name":"auto-merge","color":"d3d3d3","default":false}],"milestone":{"url":"https://api.github.com/repos/dlang/dmd/milestones/23","html_url":"https://github.com/dlang/dmd/milestone/23","labels_url":"https://api.github.com/repos/dlang/dmd/milestones/23/labels","id":3323131,"node_id":"MDk6TWlsZXN0b25lMzMyMzEzMQ==","number":23,"title":"2.081.0","description":null,"creator":{"login":"JinShil","id":6023641,"node_id":"MDQ6VXNlcjYwMjM2NDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6023641?v=4","gravatar_id":"","url":"https://api.github.com/users/JinShil","html_url":"https://github.com/JinShil","followers_url":"https://api.github.com/users/JinShil/followers","following_url":"https://api.github.com/users/JinShil/following{/other_user}","gists_url":"https://api.github.com/users/JinShil/gists{/gist_id}","starred_url":"https://api.github.com/users/JinShil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JinShil/subscriptions","organizations_url":"https://api.github.com/users/JinShil/orgs","repos_url":"https://api.github.com/users/JinShil/repos","events_url":"https://api.github.com/users/JinShil/events{/privacy}","received_events_url":"https://api.github.com/users/JinShil/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":5,"state":"closed","created_at":"2018-05-06T00:51:19Z","updated_at":"2018-07-29T17:04:01Z","due_on":"2018-07-01T07:00:00Z","closed_at":"2018-07-29T17:04:01Z"},"commits_url":"https://api.github.com/repos/dlang/dmd/pulls/8362/commits","review_comments_url":"https://api.github.com/repos/dlang/dmd/pulls/8362/comments","review_comment_url":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/8362/comments","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/403d5f0148abe60ac1836da9038c18cebd8b8644","head":{"label":"rainers:issue18966","ref":"issue18966","sha":"403d5f0148abe60ac1836da9038c18cebd8b8644","user":{"login":"rainers","id":702284,"node_id":"MDQ6VXNlcjcwMjI4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/702284?v=4","gravatar_id":"","url":"https://api.github.com/users/rainers","html_url":"https://github.com/rainers","followers_url":"https://api.github.com/users/rainers/followers","following_url":"https://api.github.com/users/rainers/following{/other_user}","gists_url":"https://api.github.com/users/rainers/gists{/gist_id}","starred_url":"https://api.github.com/users/rainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainers/subscriptions","organizations_url":"https://api.github.com/users/rainers/orgs","repos_url":"https://api.github.com/users/rainers/repos","events_url":"https://api.github.com/users/rainers/events{/privacy}","received_events_url":"https://api.github.com/users/rainers/received_events","type":"User","site_admin":false},"repo":{"id":1554385,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU0Mzg1","name":"dmd","full_name":"rainers/dmd","owner":{"login":"rainers","id":702284,"node_id":"MDQ6VXNlcjcwMjI4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/702284?v=4","gravatar_id":"","url":"https://api.github.com/users/rainers","html_url":"https://github.com/rainers","followers_url":"https://api.github.com/users/rainers/followers","following_url":"https://api.github.com/users/rainers/following{/other_user}","gists_url":"https://api.github.com/users/rainers/gists{/gist_id}","starred_url":"https://api.github.com/users/rainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainers/subscriptions","organizations_url":"https://api.github.com/users/rainers/orgs","repos_url":"https://api.github.com/users/rainers/repos","events_url":"https://api.github.com/users/rainers/events{/privacy}","received_events_url":"https://api.github.com/users/rainers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rainers/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/rainers/dmd","forks_url":"https://api.github.com/repos/rainers/dmd/forks","keys_url":"https://api.github.com/repos/rainers/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rainers/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rainers/dmd/teams","hooks_url":"https://api.github.com/repos/rainers/dmd/hooks","issue_events_url":"https://api.github.com/repos/rainers/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/rainers/dmd/events","assignees_url":"https://api.github.com/repos/rainers/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/rainers/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/rainers/dmd/tags","blobs_url":"https://api.github.com/repos/rainers/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rainers/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rainers/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/rainers/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rainers/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/rainers/dmd/languages","stargazers_url":"https://api.github.com/repos/rainers/dmd/stargazers","contributors_url":"https://api.github.com/repos/rainers/dmd/contributors","subscribers_url":"https://api.github.com/repos/rainers/dmd/subscribers","subscription_url":"https://api.github.com/repos/rainers/dmd/subscription","commits_url":"https://api.github.com/repos/rainers/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/rainers/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/rainers/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/rainers/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/rainers/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/rainers/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rainers/dmd/merges","archive_url":"https://api.github.com/repos/rainers/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rainers/dmd/downloads","issues_url":"https://api.github.com/repos/rainers/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/rainers/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/rainers/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/rainers/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rainers/dmd/labels{/name}","releases_url":"https://api.github.com/repos/rainers/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/rainers/dmd/deployments","created_at":"2011-04-01T06:15:32Z","updated_at":"2014-06-06T10:49:17Z","pushed_at":"2018-06-19T21:34:25Z","git_url":"git://github.com/rainers/dmd.git","ssh_url":"git@github.com:rainers/dmd.git","clone_url":"https://github.com/rainers/dmd.git","svn_url":"https://github.com/rainers/dmd","homepage":"d-programming-language.org","size":85505,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dlang:stable","ref":"stable","sha":"3131d12144dd7cd2b42cbe1b1f85b8173414f5c4","user":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3MDcw","name":"dmd","full_name":"dlang/dmd","owner":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/dlang/dmd","forks_url":"https://api.github.com/repos/dlang/dmd/forks","keys_url":"https://api.github.com/repos/dlang/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dmd/teams","hooks_url":"https://api.github.com/repos/dlang/dmd/hooks","issue_events_url":"https://api.github.com/repos/dlang/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dmd/events","assignees_url":"https://api.github.com/repos/dlang/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dmd/tags","blobs_url":"https://api.github.com/repos/dlang/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dmd/languages","stargazers_url":"https://api.github.com/repos/dlang/dmd/stargazers","contributors_url":"https://api.github.com/repos/dlang/dmd/contributors","subscribers_url":"https://api.github.com/repos/dlang/dmd/subscribers","subscription_url":"https://api.github.com/repos/dlang/dmd/subscription","commits_url":"https://api.github.com/repos/dlang/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dmd/merges","archive_url":"https://api.github.com/repos/dlang/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dmd/downloads","issues_url":"https://api.github.com/repos/dlang/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dmd/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dmd/deployments","created_at":"2011-01-15T06:53:53Z","updated_at":"2018-08-01T02:16:00Z","pushed_at":"2018-08-01T13:58:53Z","git_url":"git://github.com/dlang/dmd.git","ssh_url":"git@github.com:dlang/dmd.git","clone_url":"https://github.com/dlang/dmd.git","svn_url":"https://github.com/dlang/dmd","homepage":"dlang.org","size":91996,"stargazers_count":1821,"watchers_count":1821,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":457,"mirror_url":null,"archived":false,"open_issues_count":143,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":457,"open_issues":143,"watchers":1821,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8362"},"html":{"href":"https://github.com/dlang/dmd/pull/8362"},"issue":{"href":"https://api.github.com/repos/dlang/dmd/issues/8362"},"comments":{"href":"https://api.github.com/repos/dlang/dmd/issues/8362/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8362/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8362/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dmd/statuses/403d5f0148abe60ac1836da9038c18cebd8b8644"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kinke"}}