{"action":"closed","number":266,"pull_request":{"url":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/266","id":199966029,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTY2MDI5","html_url":"https://github.com/openid/AppAuth-iOS/pull/266","diff_url":"https://github.com/openid/AppAuth-iOS/pull/266.diff","patch_url":"https://github.com/openid/AppAuth-iOS/pull/266.patch","issue_url":"https://api.github.com/repos/openid/AppAuth-iOS/issues/266","number":266,"state":"closed","locked":false,"title":"Percent encode special characters from client ID and client secret in…","user":{"login":"julienbodet","id":3465275,"node_id":"MDQ6VXNlcjM0NjUyNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3465275?v=4","gravatar_id":"","url":"https://api.github.com/users/julienbodet","html_url":"https://github.com/julienbodet","followers_url":"https://api.github.com/users/julienbodet/followers","following_url":"https://api.github.com/users/julienbodet/following{/other_user}","gists_url":"https://api.github.com/users/julienbodet/gists{/gist_id}","starred_url":"https://api.github.com/users/julienbodet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienbodet/subscriptions","organizations_url":"https://api.github.com/users/julienbodet/orgs","repos_url":"https://api.github.com/users/julienbodet/repos","events_url":"https://api.github.com/users/julienbodet/events{/privacy}","received_events_url":"https://api.github.com/users/julienbodet/received_events","type":"User","site_admin":false},"body":"… Basic Authorization header\r\n\r\nThis pull request resolves issue #233.\r\n\r\nI added code to percent encode all characters other than alphanumeric ones included in `URLQueryAllowedCharacterSet`. I also followed @WilliamDenniss's recommendation to percent encode space rather than replacing it by \"+\".","created_at":"2018-07-08T23:12:32Z","updated_at":"2018-07-11T18:58:03Z","closed_at":"2018-07-11T18:58:03Z","merged_at":"2018-07-11T18:58:03Z","merge_commit_sha":"67716e00f6edb1aefb4927ca41e7f0812f80339d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":324684322,"node_id":"MDU6TGFiZWwzMjQ2ODQzMjI=","url":"https://api.github.com/repos/openid/AppAuth-iOS/labels/bug","name":"bug","color":"d4c5f9","default":true},{"id":555602919,"node_id":"MDU6TGFiZWw1NTU2MDI5MTk=","url":"https://api.github.com/repos/openid/AppAuth-iOS/labels/openid-cla:%20yes","name":"openid-cla: yes","color":"e6e6e6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/266/commits","review_comments_url":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/266/comments","review_comment_url":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openid/AppAuth-iOS/issues/266/comments","statuses_url":"https://api.github.com/repos/openid/AppAuth-iOS/statuses/36bd02241212dce3aa4f8a622f75192169b3bec4","head":{"label":"julienbodet:issue/223","ref":"issue/223","sha":"36bd02241212dce3aa4f8a622f75192169b3bec4","user":{"login":"julienbodet","id":3465275,"node_id":"MDQ6VXNlcjM0NjUyNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3465275?v=4","gravatar_id":"","url":"https://api.github.com/users/julienbodet","html_url":"https://github.com/julienbodet","followers_url":"https://api.github.com/users/julienbodet/followers","following_url":"https://api.github.com/users/julienbodet/following{/other_user}","gists_url":"https://api.github.com/users/julienbodet/gists{/gist_id}","starred_url":"https://api.github.com/users/julienbodet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienbodet/subscriptions","organizations_url":"https://api.github.com/users/julienbodet/orgs","repos_url":"https://api.github.com/users/julienbodet/repos","events_url":"https://api.github.com/users/julienbodet/events{/privacy}","received_events_url":"https://api.github.com/users/julienbodet/received_events","type":"User","site_admin":false},"repo":{"id":119550689,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk1NTA2ODk=","name":"AppAuth-iOS","full_name":"julienbodet/AppAuth-iOS","owner":{"login":"julienbodet","id":3465275,"node_id":"MDQ6VXNlcjM0NjUyNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3465275?v=4","gravatar_id":"","url":"https://api.github.com/users/julienbodet","html_url":"https://github.com/julienbodet","followers_url":"https://api.github.com/users/julienbodet/followers","following_url":"https://api.github.com/users/julienbodet/following{/other_user}","gists_url":"https://api.github.com/users/julienbodet/gists{/gist_id}","starred_url":"https://api.github.com/users/julienbodet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienbodet/subscriptions","organizations_url":"https://api.github.com/users/julienbodet/orgs","repos_url":"https://api.github.com/users/julienbodet/repos","events_url":"https://api.github.com/users/julienbodet/events{/privacy}","received_events_url":"https://api.github.com/users/julienbodet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julienbodet/AppAuth-iOS","description":"iOS and macOS SDK for communicating with OAuth 2.0 and OpenID Connect providers.","fork":true,"url":"https://api.github.com/repos/julienbodet/AppAuth-iOS","forks_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/forks","keys_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/teams","hooks_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/hooks","issue_events_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/events","assignees_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/tags","blobs_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/languages","stargazers_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/stargazers","contributors_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/contributors","subscribers_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/subscribers","subscription_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/subscription","commits_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/merges","archive_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/downloads","issues_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/labels{/name}","releases_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/julienbodet/AppAuth-iOS/deployments","created_at":"2018-01-30T14:54:45Z","updated_at":"2018-07-08T17:41:00Z","pushed_at":"2018-07-10T18:24:41Z","git_url":"git://github.com/julienbodet/AppAuth-iOS.git","ssh_url":"git@github.com:julienbodet/AppAuth-iOS.git","clone_url":"https://github.com/julienbodet/AppAuth-iOS.git","svn_url":"https://github.com/julienbodet/AppAuth-iOS","homepage":"https://openid.github.io/AppAuth-iOS","size":1171,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openid:master","ref":"master","sha":"d6ff5a162c40b05dfc28877ce46d20adee7d97e5","user":{"login":"openid","id":71971,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTcx","avatar_url":"https://avatars2.githubusercontent.com/u/71971?v=4","gravatar_id":"","url":"https://api.github.com/users/openid","html_url":"https://github.com/openid","followers_url":"https://api.github.com/users/openid/followers","following_url":"https://api.github.com/users/openid/following{/other_user}","gists_url":"https://api.github.com/users/openid/gists{/gist_id}","starred_url":"https://api.github.com/users/openid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openid/subscriptions","organizations_url":"https://api.github.com/users/openid/orgs","repos_url":"https://api.github.com/users/openid/repos","events_url":"https://api.github.com/users/openid/events{/privacy}","received_events_url":"https://api.github.com/users/openid/received_events","type":"Organization","site_admin":false},"repo":{"id":51520488,"node_id":"MDEwOlJlcG9zaXRvcnk1MTUyMDQ4OA==","name":"AppAuth-iOS","full_name":"openid/AppAuth-iOS","owner":{"login":"openid","id":71971,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTcx","avatar_url":"https://avatars2.githubusercontent.com/u/71971?v=4","gravatar_id":"","url":"https://api.github.com/users/openid","html_url":"https://github.com/openid","followers_url":"https://api.github.com/users/openid/followers","following_url":"https://api.github.com/users/openid/following{/other_user}","gists_url":"https://api.github.com/users/openid/gists{/gist_id}","starred_url":"https://api.github.com/users/openid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openid/subscriptions","organizations_url":"https://api.github.com/users/openid/orgs","repos_url":"https://api.github.com/users/openid/repos","events_url":"https://api.github.com/users/openid/events{/privacy}","received_events_url":"https://api.github.com/users/openid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openid/AppAuth-iOS","description":"iOS and macOS SDK for communicating with OAuth 2.0 and OpenID Connect providers.","fork":false,"url":"https://api.github.com/repos/openid/AppAuth-iOS","forks_url":"https://api.github.com/repos/openid/AppAuth-iOS/forks","keys_url":"https://api.github.com/repos/openid/AppAuth-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openid/AppAuth-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openid/AppAuth-iOS/teams","hooks_url":"https://api.github.com/repos/openid/AppAuth-iOS/hooks","issue_events_url":"https://api.github.com/repos/openid/AppAuth-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/openid/AppAuth-iOS/events","assignees_url":"https://api.github.com/repos/openid/AppAuth-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/openid/AppAuth-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/openid/AppAuth-iOS/tags","blobs_url":"https://api.github.com/repos/openid/AppAuth-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openid/AppAuth-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openid/AppAuth-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/openid/AppAuth-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openid/AppAuth-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/openid/AppAuth-iOS/languages","stargazers_url":"https://api.github.com/repos/openid/AppAuth-iOS/stargazers","contributors_url":"https://api.github.com/repos/openid/AppAuth-iOS/contributors","subscribers_url":"https://api.github.com/repos/openid/AppAuth-iOS/subscribers","subscription_url":"https://api.github.com/repos/openid/AppAuth-iOS/subscription","commits_url":"https://api.github.com/repos/openid/AppAuth-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/openid/AppAuth-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/openid/AppAuth-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/openid/AppAuth-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/openid/AppAuth-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/openid/AppAuth-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openid/AppAuth-iOS/merges","archive_url":"https://api.github.com/repos/openid/AppAuth-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openid/AppAuth-iOS/downloads","issues_url":"https://api.github.com/repos/openid/AppAuth-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/openid/AppAuth-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/openid/AppAuth-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/openid/AppAuth-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openid/AppAuth-iOS/labels{/name}","releases_url":"https://api.github.com/repos/openid/AppAuth-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/openid/AppAuth-iOS/deployments","created_at":"2016-02-11T14:38:23Z","updated_at":"2018-07-10T19:57:11Z","pushed_at":"2018-07-11T18:58:03Z","git_url":"git://github.com/openid/AppAuth-iOS.git","ssh_url":"git@github.com:openid/AppAuth-iOS.git","clone_url":"https://github.com/openid/AppAuth-iOS.git","svn_url":"https://github.com/openid/AppAuth-iOS","homepage":"https://openid.github.io/AppAuth-iOS","size":1185,"stargazers_count":411,"watchers_count":411,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":183,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":183,"open_issues":28,"watchers":411,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/266"},"html":{"href":"https://github.com/openid/AppAuth-iOS/pull/266"},"issue":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/issues/266"},"comments":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/statuses/36bd02241212dce3aa4f8a622f75192169b3bec4"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"WilliamDenniss","id":445150,"node_id":"MDQ6VXNlcjQ0NTE1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/445150?v=4","gravatar_id":"","url":"https://api.github.com/users/WilliamDenniss","html_url":"https://github.com/WilliamDenniss","followers_url":"https://api.github.com/users/WilliamDenniss/followers","following_url":"https://api.github.com/users/WilliamDenniss/following{/other_user}","gists_url":"https://api.github.com/users/WilliamDenniss/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamDenniss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamDenniss/subscriptions","organizations_url":"https://api.github.com/users/WilliamDenniss/orgs","repos_url":"https://api.github.com/users/WilliamDenniss/repos","events_url":"https://api.github.com/users/WilliamDenniss/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamDenniss/received_events","type":"User","site_admin":false},"comments":1,"review_comments":14,"maintainer_can_modify":false,"commits":4,"additions":47,"deletions":1,"changed_files":4}}
{"actor":{"display_login":"WilliamDenniss"}}