{"action":"created","comment":{"url":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments/184112063","pull_request_review_id":115240572,"id":184112063,"diff_hunk":"@@ -0,0 +1,90 @@\n+export enum PfColors {","path":"src/components/Pf/PfColors.tsx","position":1,"original_position":1,"commit_id":"9edb74bed07adba264a1630c09730720fbbb4527","original_commit_id":"9edb74bed07adba264a1630c09730720fbbb4527","user":{"login":"josejulio","id":3845764,"avatar_url":"https://avatars1.githubusercontent.com/u/3845764?v=4","gravatar_id":"","url":"https://api.github.com/users/josejulio","html_url":"https://github.com/josejulio","followers_url":"https://api.github.com/users/josejulio/followers","following_url":"https://api.github.com/users/josejulio/following{/other_user}","gists_url":"https://api.github.com/users/josejulio/gists{/gist_id}","starred_url":"https://api.github.com/users/josejulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejulio/subscriptions","organizations_url":"https://api.github.com/users/josejulio/orgs","repos_url":"https://api.github.com/users/josejulio/repos","events_url":"https://api.github.com/users/josejulio/events{/privacy}","received_events_url":"https://api.github.com/users/josejulio/received_events","type":"User","site_admin":false},"body":"I think we should use these patternfly constants (`patternfly.pfPaletteColors.green`) instead of writing directly the '#cfe7cd'\r\nI don't think these constants are changed, but maybe more explicit the 1-1 relation\r\n\r\n```typescript\r\nGreen = '#cfe7cd',\r\n```\r\nWe could use (if possible)\r\n```typescript\r\nGreen = patternfly.pfPaletteColors.green,\r\n```","created_at":"2018-04-25T15:50:10Z","updated_at":"2018-04-25T15:50:10Z","html_url":"https://github.com/kiali/kiali-ui/pull/281#discussion_r184112063","pull_request_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/281","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments/184112063"},"html":{"href":"https://github.com/kiali/kiali-ui/pull/281#discussion_r184112063"},"pull_request":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/281"}},"in_reply_to_id":184049186},"pull_request":{"url":"https://api.github.com/repos/kiali/kiali-ui/pulls/281","id":183977027,"html_url":"https://github.com/kiali/kiali-ui/pull/281","diff_url":"https://github.com/kiali/kiali-ui/pull/281.diff","patch_url":"https://github.com/kiali/kiali-ui/pull/281.patch","issue_url":"https://api.github.com/repos/kiali/kiali-ui/issues/281","number":281,"state":"open","locked":false,"title":"KIALI-598 - don't hardcode pf colors everywhere","user":{"login":"jmazzitelli","id":2029470,"avatar_url":"https://avatars0.githubusercontent.com/u/2029470?v=4","gravatar_id":"","url":"https://api.github.com/users/jmazzitelli","html_url":"https://github.com/jmazzitelli","followers_url":"https://api.github.com/users/jmazzitelli/followers","following_url":"https://api.github.com/users/jmazzitelli/following{/other_user}","gists_url":"https://api.github.com/users/jmazzitelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazzitelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazzitelli/subscriptions","organizations_url":"https://api.github.com/users/jmazzitelli/orgs","repos_url":"https://api.github.com/users/jmazzitelli/repos","events_url":"https://api.github.com/users/jmazzitelli/events{/privacy}","received_events_url":"https://api.github.com/users/jmazzitelli/received_events","type":"User","site_admin":false},"body":"We want to use PF colors everywhere. But we don't want to hardcode the actual #RGB values everywhere either. Since we use these colors mainly in the JS/react code, this creates an enum with the colors that can be used in place of the '#rrggbb' notation.","created_at":"2018-04-25T09:38:43Z","updated_at":"2018-04-25T15:50:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b77dd2d8684883cb75ec201c348d71af506bfdc7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/281/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/281/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/issues/281/comments","statuses_url":"https://api.github.com/repos/kiali/kiali-ui/statuses/9edb74bed07adba264a1630c09730720fbbb4527","head":{"label":"jmazzitelli:KIALI-598-pf-colors","ref":"KIALI-598-pf-colors","sha":"9edb74bed07adba264a1630c09730720fbbb4527","user":{"login":"jmazzitelli","id":2029470,"avatar_url":"https://avatars0.githubusercontent.com/u/2029470?v=4","gravatar_id":"","url":"https://api.github.com/users/jmazzitelli","html_url":"https://github.com/jmazzitelli","followers_url":"https://api.github.com/users/jmazzitelli/followers","following_url":"https://api.github.com/users/jmazzitelli/following{/other_user}","gists_url":"https://api.github.com/users/jmazzitelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazzitelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazzitelli/subscriptions","organizations_url":"https://api.github.com/users/jmazzitelli/orgs","repos_url":"https://api.github.com/users/jmazzitelli/repos","events_url":"https://api.github.com/users/jmazzitelli/events{/privacy}","received_events_url":"https://api.github.com/users/jmazzitelli/received_events","type":"User","site_admin":false},"repo":{"id":126534412,"name":"kiali-ui","full_name":"jmazzitelli/kiali-ui","owner":{"login":"jmazzitelli","id":2029470,"avatar_url":"https://avatars0.githubusercontent.com/u/2029470?v=4","gravatar_id":"","url":"https://api.github.com/users/jmazzitelli","html_url":"https://github.com/jmazzitelli","followers_url":"https://api.github.com/users/jmazzitelli/followers","following_url":"https://api.github.com/users/jmazzitelli/following{/other_user}","gists_url":"https://api.github.com/users/jmazzitelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazzitelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazzitelli/subscriptions","organizations_url":"https://api.github.com/users/jmazzitelli/orgs","repos_url":"https://api.github.com/users/jmazzitelli/repos","events_url":"https://api.github.com/users/jmazzitelli/events{/privacy}","received_events_url":"https://api.github.com/users/jmazzitelli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmazzitelli/kiali-ui","description":null,"fork":true,"url":"https://api.github.com/repos/jmazzitelli/kiali-ui","forks_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/forks","keys_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/teams","hooks_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/hooks","issue_events_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/issues/events{/number}","events_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/events","assignees_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/assignees{/user}","branches_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/branches{/branch}","tags_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/tags","blobs_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/languages","stargazers_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/stargazers","contributors_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/contributors","subscribers_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/subscribers","subscription_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/subscription","commits_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/contents/{+path}","compare_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/merges","archive_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/downloads","issues_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/issues{/number}","pulls_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/labels{/name}","releases_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/releases{/id}","deployments_url":"https://api.github.com/repos/jmazzitelli/kiali-ui/deployments","created_at":"2018-03-23T20:13:04Z","updated_at":"2018-03-23T20:13:07Z","pushed_at":"2018-04-25T10:52:21Z","git_url":"git://github.com/jmazzitelli/kiali-ui.git","ssh_url":"git@github.com:jmazzitelli/kiali-ui.git","clone_url":"https://github.com/jmazzitelli/kiali-ui.git","svn_url":"https://github.com/jmazzitelli/kiali-ui","homepage":null,"size":1256,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kiali:master","ref":"master","sha":"e8c9425385581594cdf9dcd67b10f57ec190b8ef","user":{"login":"kiali","id":36001875,"avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":120308264,"name":"kiali-ui","full_name":"kiali/kiali-ui","owner":{"login":"kiali","id":36001875,"avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiali/kiali-ui","description":"Frontend part of Kiali","fork":false,"url":"https://api.github.com/repos/kiali/kiali-ui","forks_url":"https://api.github.com/repos/kiali/kiali-ui/forks","keys_url":"https://api.github.com/repos/kiali/kiali-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali-ui/teams","hooks_url":"https://api.github.com/repos/kiali/kiali-ui/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali-ui/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali-ui/events","assignees_url":"https://api.github.com/repos/kiali/kiali-ui/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali-ui/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali-ui/tags","blobs_url":"https://api.github.com/repos/kiali/kiali-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali-ui/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali-ui/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali-ui/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali-ui/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali-ui/subscription","commits_url":"https://api.github.com/repos/kiali/kiali-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali-ui/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali-ui/merges","archive_url":"https://api.github.com/repos/kiali/kiali-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali-ui/downloads","issues_url":"https://api.github.com/repos/kiali/kiali-ui/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali-ui/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali-ui/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali-ui/deployments","created_at":"2018-02-05T13:27:15Z","updated_at":"2018-04-24T21:28:35Z","pushed_at":"2018-04-25T10:52:23Z","git_url":"git://github.com/kiali/kiali-ui.git","ssh_url":"git@github.com:kiali/kiali-ui.git","clone_url":"https://github.com/kiali/kiali-ui.git","svn_url":"https://github.com/kiali/kiali-ui","homepage":"","size":1245,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15,"open_issues":11,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/281"},"html":{"href":"https://github.com/kiali/kiali-ui/pull/281"},"issue":{"href":"https://api.github.com/repos/kiali/kiali-ui/issues/281"},"comments":{"href":"https://api.github.com/repos/kiali/kiali-ui/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali-ui/statuses/9edb74bed07adba264a1630c09730720fbbb4527"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"josejulio"}}