{"action":"closed","number":3795,"pull_request":{"url":"https://api.github.com/repos/pojome/elementor/pulls/3795","id":175752236,"html_url":"https://github.com/pojome/elementor/pull/3795","diff_url":"https://github.com/pojome/elementor/pull/3795.diff","patch_url":"https://github.com/pojome/elementor/pull/3795.patch","issue_url":"https://api.github.com/repos/pojome/elementor/issues/3795","number":3795,"state":"closed","locked":false,"title":"Control Settings: remove 'placeholder' and 'title' settings from base settings","user":{"login":"ramiy","id":576623,"avatar_url":"https://avatars0.githubusercontent.com/u/576623?v=4","gravatar_id":"","url":"https://api.github.com/users/ramiy","html_url":"https://github.com/ramiy","followers_url":"https://api.github.com/users/ramiy/followers","following_url":"https://api.github.com/users/ramiy/following{/other_user}","gists_url":"https://api.github.com/users/ramiy/gists{/gist_id}","starred_url":"https://api.github.com/users/ramiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramiy/subscriptions","organizations_url":"https://api.github.com/users/ramiy/orgs","repos_url":"https://api.github.com/users/ramiy/repos","events_url":"https://api.github.com/users/ramiy/events{/privacy}","received_events_url":"https://api.github.com/users/ramiy/received_events","type":"User","site_admin":false},"body":"The `$_base_settings` property in `Base_Control` holds the common settings relevant for all the controls (`label`, `description`, `separator`, `label_block`, `show_label`), but it also has two settings that are relevant to few very specific controls (`title`, `placeholder`). Those settings should be moved to those specific controls to their `get_default_settings()` methods.","created_at":"2018-03-18T13:52:10Z","updated_at":"2018-03-19T10:40:49Z","closed_at":"2018-03-19T10:40:48Z","merged_at":"2018-03-19T10:40:48Z","merge_commit_sha":"366793112bb85864d8a7cc3630243d39a6191a47","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pojome/elementor/pulls/3795/commits","review_comments_url":"https://api.github.com/repos/pojome/elementor/pulls/3795/comments","review_comment_url":"https://api.github.com/repos/pojome/elementor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pojome/elementor/issues/3795/comments","statuses_url":"https://api.github.com/repos/pojome/elementor/statuses/5c0a34e9ccb096c8a59dd78006e41e44da013438","head":{"label":"ramiy:controls_base_settings","ref":"controls_base_settings","sha":"5c0a34e9ccb096c8a59dd78006e41e44da013438","user":{"login":"ramiy","id":576623,"avatar_url":"https://avatars0.githubusercontent.com/u/576623?v=4","gravatar_id":"","url":"https://api.github.com/users/ramiy","html_url":"https://github.com/ramiy","followers_url":"https://api.github.com/users/ramiy/followers","following_url":"https://api.github.com/users/ramiy/following{/other_user}","gists_url":"https://api.github.com/users/ramiy/gists{/gist_id}","starred_url":"https://api.github.com/users/ramiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramiy/subscriptions","organizations_url":"https://api.github.com/users/ramiy/orgs","repos_url":"https://api.github.com/users/ramiy/repos","events_url":"https://api.github.com/users/ramiy/events{/privacy}","received_events_url":"https://api.github.com/users/ramiy/received_events","type":"User","site_admin":false},"repo":{"id":60021536,"name":"elementor","full_name":"ramiy/elementor","owner":{"login":"ramiy","id":576623,"avatar_url":"https://avatars0.githubusercontent.com/u/576623?v=4","gravatar_id":"","url":"https://api.github.com/users/ramiy","html_url":"https://github.com/ramiy","followers_url":"https://api.github.com/users/ramiy/followers","following_url":"https://api.github.com/users/ramiy/following{/other_user}","gists_url":"https://api.github.com/users/ramiy/gists{/gist_id}","starred_url":"https://api.github.com/users/ramiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramiy/subscriptions","organizations_url":"https://api.github.com/users/ramiy/orgs","repos_url":"https://api.github.com/users/ramiy/repos","events_url":"https://api.github.com/users/ramiy/events{/privacy}","received_events_url":"https://api.github.com/users/ramiy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ramiy/elementor","description":"A drag and drop page builder for designers that want to create high-end, pixel perfect pages at record speeds. No more drag & drop loading lags. No more click for preview mode.","fork":true,"url":"https://api.github.com/repos/ramiy/elementor","forks_url":"https://api.github.com/repos/ramiy/elementor/forks","keys_url":"https://api.github.com/repos/ramiy/elementor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramiy/elementor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramiy/elementor/teams","hooks_url":"https://api.github.com/repos/ramiy/elementor/hooks","issue_events_url":"https://api.github.com/repos/ramiy/elementor/issues/events{/number}","events_url":"https://api.github.com/repos/ramiy/elementor/events","assignees_url":"https://api.github.com/repos/ramiy/elementor/assignees{/user}","branches_url":"https://api.github.com/repos/ramiy/elementor/branches{/branch}","tags_url":"https://api.github.com/repos/ramiy/elementor/tags","blobs_url":"https://api.github.com/repos/ramiy/elementor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramiy/elementor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramiy/elementor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramiy/elementor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramiy/elementor/statuses/{sha}","languages_url":"https://api.github.com/repos/ramiy/elementor/languages","stargazers_url":"https://api.github.com/repos/ramiy/elementor/stargazers","contributors_url":"https://api.github.com/repos/ramiy/elementor/contributors","subscribers_url":"https://api.github.com/repos/ramiy/elementor/subscribers","subscription_url":"https://api.github.com/repos/ramiy/elementor/subscription","commits_url":"https://api.github.com/repos/ramiy/elementor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramiy/elementor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramiy/elementor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramiy/elementor/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramiy/elementor/contents/{+path}","compare_url":"https://api.github.com/repos/ramiy/elementor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramiy/elementor/merges","archive_url":"https://api.github.com/repos/ramiy/elementor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramiy/elementor/downloads","issues_url":"https://api.github.com/repos/ramiy/elementor/issues{/number}","pulls_url":"https://api.github.com/repos/ramiy/elementor/pulls{/number}","milestones_url":"https://api.github.com/repos/ramiy/elementor/milestones{/number}","notifications_url":"https://api.github.com/repos/ramiy/elementor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramiy/elementor/labels{/name}","releases_url":"https://api.github.com/repos/ramiy/elementor/releases{/id}","deployments_url":"https://api.github.com/repos/ramiy/elementor/deployments","created_at":"2016-05-30T15:46:28Z","updated_at":"2017-01-14T01:34:17Z","pushed_at":"2018-03-18T13:49:34Z","git_url":"git://github.com/ramiy/elementor.git","ssh_url":"git@github.com:ramiy/elementor.git","clone_url":"https://github.com/ramiy/elementor.git","svn_url":"https://github.com/ramiy/elementor","homepage":"https://wordpress.org/plugins/elementor","size":29407,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pojome:release/2.0.0","ref":"release/2.0.0","sha":"ea0761583ffb7a56fbadef0e53a085e163889677","user":{"login":"pojome","id":6918482,"avatar_url":"https://avatars2.githubusercontent.com/u/6918482?v=4","gravatar_id":"","url":"https://api.github.com/users/pojome","html_url":"https://github.com/pojome","followers_url":"https://api.github.com/users/pojome/followers","following_url":"https://api.github.com/users/pojome/following{/other_user}","gists_url":"https://api.github.com/users/pojome/gists{/gist_id}","starred_url":"https://api.github.com/users/pojome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pojome/subscriptions","organizations_url":"https://api.github.com/users/pojome/orgs","repos_url":"https://api.github.com/users/pojome/repos","events_url":"https://api.github.com/users/pojome/events{/privacy}","received_events_url":"https://api.github.com/users/pojome/received_events","type":"Organization","site_admin":false},"repo":{"id":60010673,"name":"elementor","full_name":"pojome/elementor","owner":{"login":"pojome","id":6918482,"avatar_url":"https://avatars2.githubusercontent.com/u/6918482?v=4","gravatar_id":"","url":"https://api.github.com/users/pojome","html_url":"https://github.com/pojome","followers_url":"https://api.github.com/users/pojome/followers","following_url":"https://api.github.com/users/pojome/following{/other_user}","gists_url":"https://api.github.com/users/pojome/gists{/gist_id}","starred_url":"https://api.github.com/users/pojome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pojome/subscriptions","organizations_url":"https://api.github.com/users/pojome/orgs","repos_url":"https://api.github.com/users/pojome/repos","events_url":"https://api.github.com/users/pojome/events{/privacy}","received_events_url":"https://api.github.com/users/pojome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pojome/elementor","description":"The most advanced frontend drag & drop page builder. Create high-end, pixel perfect websites at record speeds. Any theme, any page, any design.","fork":false,"url":"https://api.github.com/repos/pojome/elementor","forks_url":"https://api.github.com/repos/pojome/elementor/forks","keys_url":"https://api.github.com/repos/pojome/elementor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pojome/elementor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pojome/elementor/teams","hooks_url":"https://api.github.com/repos/pojome/elementor/hooks","issue_events_url":"https://api.github.com/repos/pojome/elementor/issues/events{/number}","events_url":"https://api.github.com/repos/pojome/elementor/events","assignees_url":"https://api.github.com/repos/pojome/elementor/assignees{/user}","branches_url":"https://api.github.com/repos/pojome/elementor/branches{/branch}","tags_url":"https://api.github.com/repos/pojome/elementor/tags","blobs_url":"https://api.github.com/repos/pojome/elementor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pojome/elementor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pojome/elementor/git/refs{/sha}","trees_url":"https://api.github.com/repos/pojome/elementor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pojome/elementor/statuses/{sha}","languages_url":"https://api.github.com/repos/pojome/elementor/languages","stargazers_url":"https://api.github.com/repos/pojome/elementor/stargazers","contributors_url":"https://api.github.com/repos/pojome/elementor/contributors","subscribers_url":"https://api.github.com/repos/pojome/elementor/subscribers","subscription_url":"https://api.github.com/repos/pojome/elementor/subscription","commits_url":"https://api.github.com/repos/pojome/elementor/commits{/sha}","git_commits_url":"https://api.github.com/repos/pojome/elementor/git/commits{/sha}","comments_url":"https://api.github.com/repos/pojome/elementor/comments{/number}","issue_comment_url":"https://api.github.com/repos/pojome/elementor/issues/comments{/number}","contents_url":"https://api.github.com/repos/pojome/elementor/contents/{+path}","compare_url":"https://api.github.com/repos/pojome/elementor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pojome/elementor/merges","archive_url":"https://api.github.com/repos/pojome/elementor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pojome/elementor/downloads","issues_url":"https://api.github.com/repos/pojome/elementor/issues{/number}","pulls_url":"https://api.github.com/repos/pojome/elementor/pulls{/number}","milestones_url":"https://api.github.com/repos/pojome/elementor/milestones{/number}","notifications_url":"https://api.github.com/repos/pojome/elementor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pojome/elementor/labels{/name}","releases_url":"https://api.github.com/repos/pojome/elementor/releases{/id}","deployments_url":"https://api.github.com/repos/pojome/elementor/deployments","created_at":"2016-05-30T13:05:46Z","updated_at":"2018-03-19T07:12:23Z","pushed_at":"2018-03-19T10:40:48Z","git_url":"git://github.com/pojome/elementor.git","ssh_url":"git@github.com:pojome/elementor.git","clone_url":"https://github.com/pojome/elementor.git","svn_url":"https://github.com/pojome/elementor","homepage":"https://elementor.com/","size":29412,"stargazers_count":1257,"watchers_count":1257,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":293,"mirror_url":null,"archived":false,"open_issues_count":309,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":293,"open_issues":309,"watchers":1257,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pojome/elementor/pulls/3795"},"html":{"href":"https://github.com/pojome/elementor/pull/3795"},"issue":{"href":"https://api.github.com/repos/pojome/elementor/issues/3795"},"comments":{"href":"https://api.github.com/repos/pojome/elementor/issues/3795/comments"},"review_comments":{"href":"https://api.github.com/repos/pojome/elementor/pulls/3795/comments"},"review_comment":{"href":"https://api.github.com/repos/pojome/elementor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pojome/elementor/pulls/3795/commits"},"statuses":{"href":"https://api.github.com/repos/pojome/elementor/statuses/5c0a34e9ccb096c8a59dd78006e41e44da013438"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"KingYes","id":902548,"avatar_url":"https://avatars0.githubusercontent.com/u/902548?v=4","gravatar_id":"","url":"https://api.github.com/users/KingYes","html_url":"https://github.com/KingYes","followers_url":"https://api.github.com/users/KingYes/followers","following_url":"https://api.github.com/users/KingYes/following{/other_user}","gists_url":"https://api.github.com/users/KingYes/gists{/gist_id}","starred_url":"https://api.github.com/users/KingYes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KingYes/subscriptions","organizations_url":"https://api.github.com/users/KingYes/orgs","repos_url":"https://api.github.com/users/KingYes/repos","events_url":"https://api.github.com/users/KingYes/events{/privacy}","received_events_url":"https://api.github.com/users/KingYes/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":2,"changed_files":5}}
{"actor":{"display_login":"KingYes"}}