{"action":"created","comment":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/218276203","pull_request_review_id":156176487,"id":218276203,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODI3NjIwMw==","diff_hunk":"@@ -40,12 +40,6 @@ class MultiDevSSAGraphBuilder : public ir::Pass {\n                          size_t device_id) const;\n   void Init() const;\n \n- private:\n-  mutable std::string loss_var_name_;\n-  mutable std::vector<platform::Place> places_;\n-  mutable std::vector<Scope *> local_scopes_;\n-  mutable std::unordered_set<std::string> grad_names_;","path":"paddle/fluid/framework/details/multi_devices_graph_pass.h","position":8,"original_position":8,"commit_id":"e5b322051b13811747bc5244a093cdb22caceeb6","original_commit_id":"e5b322051b13811747bc5244a093cdb22caceeb6","user":{"login":"Yancey1989","id":1426912,"node_id":"MDQ6VXNlcjE0MjY5MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1426912?v=4","gravatar_id":"","url":"https://api.github.com/users/Yancey1989","html_url":"https://github.com/Yancey1989","followers_url":"https://api.github.com/users/Yancey1989/followers","following_url":"https://api.github.com/users/Yancey1989/following{/other_user}","gists_url":"https://api.github.com/users/Yancey1989/gists{/gist_id}","starred_url":"https://api.github.com/users/Yancey1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yancey1989/subscriptions","organizations_url":"https://api.github.com/users/Yancey1989/orgs","repos_url":"https://api.github.com/users/Yancey1989/repos","events_url":"https://api.github.com/users/Yancey1989/events{/privacy}","received_events_url":"https://api.github.com/users/Yancey1989/received_events","type":"User","site_admin":false},"body":"Seems `grad_names_` is useless.\r\n","created_at":"2018-09-18T01:27:02Z","updated_at":"2018-09-18T01:36:15Z","html_url":"https://github.com/PaddlePaddle/Paddle/pull/13441#discussion_r218276203","pull_request_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/13441","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/218276203"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/13441#discussion_r218276203"},"pull_request":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/13441"}}},"pull_request":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/13441","id":215923035,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTIzMDM1","html_url":"https://github.com/PaddlePaddle/Paddle/pull/13441","diff_url":"https://github.com/PaddlePaddle/Paddle/pull/13441.diff","patch_url":"https://github.com/PaddlePaddle/Paddle/pull/13441.patch","issue_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/13441","number":13441,"state":"open","locked":false,"title":"simplify and hide bcast_params","user":{"login":"panyx0718","id":2887803,"node_id":"MDQ6VXNlcjI4ODc4MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2887803?v=4","gravatar_id":"","url":"https://api.github.com/users/panyx0718","html_url":"https://github.com/panyx0718","followers_url":"https://api.github.com/users/panyx0718/followers","following_url":"https://api.github.com/users/panyx0718/following{/other_user}","gists_url":"https://api.github.com/users/panyx0718/gists{/gist_id}","starred_url":"https://api.github.com/users/panyx0718/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panyx0718/subscriptions","organizations_url":"https://api.github.com/users/panyx0718/orgs","repos_url":"https://api.github.com/users/panyx0718/repos","events_url":"https://api.github.com/users/panyx0718/events{/privacy}","received_events_url":"https://api.github.com/users/panyx0718/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-17T09:41:16Z","updated_at":"2018-09-18T01:36:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97e54799e5c56ad53ec168d97464c4e8db4a98b0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/13441/commits","review_comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/13441/comments","review_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/13441/comments","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/e5b322051b13811747bc5244a093cdb22caceeb6","head":{"label":"panyx0718:ir2","ref":"ir2","sha":"e5b322051b13811747bc5244a093cdb22caceeb6","user":{"login":"panyx0718","id":2887803,"node_id":"MDQ6VXNlcjI4ODc4MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2887803?v=4","gravatar_id":"","url":"https://api.github.com/users/panyx0718","html_url":"https://github.com/panyx0718","followers_url":"https://api.github.com/users/panyx0718/followers","following_url":"https://api.github.com/users/panyx0718/following{/other_user}","gists_url":"https://api.github.com/users/panyx0718/gists{/gist_id}","starred_url":"https://api.github.com/users/panyx0718/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panyx0718/subscriptions","organizations_url":"https://api.github.com/users/panyx0718/orgs","repos_url":"https://api.github.com/users/panyx0718/repos","events_url":"https://api.github.com/users/panyx0718/events{/privacy}","received_events_url":"https://api.github.com/users/panyx0718/received_events","type":"User","site_admin":false},"repo":{"id":114556630,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ1NTY2MzA=","name":"Paddle","full_name":"panyx0718/Paddle","private":false,"owner":{"login":"panyx0718","id":2887803,"node_id":"MDQ6VXNlcjI4ODc4MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2887803?v=4","gravatar_id":"","url":"https://api.github.com/users/panyx0718","html_url":"https://github.com/panyx0718","followers_url":"https://api.github.com/users/panyx0718/followers","following_url":"https://api.github.com/users/panyx0718/following{/other_user}","gists_url":"https://api.github.com/users/panyx0718/gists{/gist_id}","starred_url":"https://api.github.com/users/panyx0718/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panyx0718/subscriptions","organizations_url":"https://api.github.com/users/panyx0718/orgs","repos_url":"https://api.github.com/users/panyx0718/repos","events_url":"https://api.github.com/users/panyx0718/events{/privacy}","received_events_url":"https://api.github.com/users/panyx0718/received_events","type":"User","site_admin":false},"html_url":"https://github.com/panyx0718/Paddle","description":"PArallel Distributed Deep LEarning","fork":true,"url":"https://api.github.com/repos/panyx0718/Paddle","forks_url":"https://api.github.com/repos/panyx0718/Paddle/forks","keys_url":"https://api.github.com/repos/panyx0718/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/panyx0718/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/panyx0718/Paddle/teams","hooks_url":"https://api.github.com/repos/panyx0718/Paddle/hooks","issue_events_url":"https://api.github.com/repos/panyx0718/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/panyx0718/Paddle/events","assignees_url":"https://api.github.com/repos/panyx0718/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/panyx0718/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/panyx0718/Paddle/tags","blobs_url":"https://api.github.com/repos/panyx0718/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/panyx0718/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/panyx0718/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/panyx0718/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/panyx0718/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/panyx0718/Paddle/languages","stargazers_url":"https://api.github.com/repos/panyx0718/Paddle/stargazers","contributors_url":"https://api.github.com/repos/panyx0718/Paddle/contributors","subscribers_url":"https://api.github.com/repos/panyx0718/Paddle/subscribers","subscription_url":"https://api.github.com/repos/panyx0718/Paddle/subscription","commits_url":"https://api.github.com/repos/panyx0718/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/panyx0718/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/panyx0718/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/panyx0718/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/panyx0718/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/panyx0718/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/panyx0718/Paddle/merges","archive_url":"https://api.github.com/repos/panyx0718/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/panyx0718/Paddle/downloads","issues_url":"https://api.github.com/repos/panyx0718/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/panyx0718/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/panyx0718/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/panyx0718/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/panyx0718/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/panyx0718/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/panyx0718/Paddle/deployments","created_at":"2017-12-17T17:48:04Z","updated_at":"2018-09-17T08:27:08Z","pushed_at":"2018-09-17T12:33:52Z","git_url":"git://github.com/panyx0718/Paddle.git","ssh_url":"git@github.com:panyx0718/Paddle.git","clone_url":"https://github.com/panyx0718/Paddle.git","svn_url":"https://github.com/panyx0718/Paddle","homepage":"http://www.paddlepaddle.org/","size":121024,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PaddlePaddle:develop","ref":"develop","sha":"d9297c1231020c9e60dad504b3d690601a26eba6","user":{"login":"PaddlePaddle","id":23534030,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0MDMw","avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"repo":{"id":65711522,"node_id":"MDEwOlJlcG9zaXRvcnk2NTcxMTUyMg==","name":"Paddle","full_name":"PaddlePaddle/Paddle","private":false,"owner":{"login":"PaddlePaddle","id":23534030,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0MDMw","avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PaddlePaddle/Paddle","description":"PArallel Distributed Deep LEarning","fork":false,"url":"https://api.github.com/repos/PaddlePaddle/Paddle","forks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/forks","keys_url":"https://api.github.com/repos/PaddlePaddle/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaddlePaddle/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaddlePaddle/Paddle/teams","hooks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/hooks","issue_events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/events","assignees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/PaddlePaddle/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/tags","blobs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/PaddlePaddle/Paddle/languages","stargazers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/stargazers","contributors_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contributors","subscribers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscribers","subscription_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscription","commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/PaddlePaddle/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaddlePaddle/Paddle/merges","archive_url":"https://api.github.com/repos/PaddlePaddle/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaddlePaddle/Paddle/downloads","issues_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/PaddlePaddle/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/PaddlePaddle/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaddlePaddle/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/PaddlePaddle/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/deployments","created_at":"2016-08-15T06:59:08Z","updated_at":"2018-09-18T01:18:39Z","pushed_at":"2018-09-18T01:17:14Z","git_url":"git://github.com/PaddlePaddle/Paddle.git","ssh_url":"git@github.com:PaddlePaddle/Paddle.git","clone_url":"https://github.com/PaddlePaddle/Paddle.git","svn_url":"https://github.com/PaddlePaddle/Paddle","homepage":"http://www.paddlepaddle.org/","size":134792,"stargazers_count":7531,"watchers_count":7531,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2052,"mirror_url":null,"archived":false,"open_issues_count":698,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2052,"open_issues":698,"watchers":7531,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/13441"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/13441"},"issue":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/13441"},"comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/13441/comments"},"review_comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/13441/comments"},"review_comment":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/13441/commits"},"statuses":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/e5b322051b13811747bc5244a093cdb22caceeb6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Yancey1989"}}