{"action":"created","issue":{"url":"https://api.github.com/repos/archiverjs/node-archiver/issues/309","repository_url":"https://api.github.com/repos/archiverjs/node-archiver","labels_url":"https://api.github.com/repos/archiverjs/node-archiver/issues/309/labels{/name}","comments_url":"https://api.github.com/repos/archiverjs/node-archiver/issues/309/comments","events_url":"https://api.github.com/repos/archiverjs/node-archiver/issues/309/events","html_url":"https://github.com/archiverjs/node-archiver/issues/309","id":297065009,"number":309,"title":"How can i tell if operation is over? `end` or `close`  events? or maybe the promise of finalize?","user":{"login":"Bnaya","id":1304862,"avatar_url":"https://avatars0.githubusercontent.com/u/1304862?v=4","gravatar_id":"","url":"https://api.github.com/users/Bnaya","html_url":"https://github.com/Bnaya","followers_url":"https://api.github.com/users/Bnaya/followers","following_url":"https://api.github.com/users/Bnaya/following{/other_user}","gists_url":"https://api.github.com/users/Bnaya/gists{/gist_id}","starred_url":"https://api.github.com/users/Bnaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bnaya/subscriptions","organizations_url":"https://api.github.com/users/Bnaya/orgs","repos_url":"https://api.github.com/users/Bnaya/repos","events_url":"https://api.github.com/users/Bnaya/events{/privacy}","received_events_url":"https://api.github.com/users/Bnaya/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-02-14T11:40:16Z","updated_at":"2018-04-03T01:42:17Z","closed_at":null,"author_association":"NONE","body":"How can i tell if operation is over? `end` or `close`  events? or maybe the promise of finalize?"},"comment":{"url":"https://api.github.com/repos/archiverjs/node-archiver/issues/comments/378100981","html_url":"https://github.com/archiverjs/node-archiver/issues/309#issuecomment-378100981","issue_url":"https://api.github.com/repos/archiverjs/node-archiver/issues/309","id":378100981,"user":{"login":"ctalkington","id":209757,"avatar_url":"https://avatars0.githubusercontent.com/u/209757?v=4","gravatar_id":"","url":"https://api.github.com/users/ctalkington","html_url":"https://github.com/ctalkington","followers_url":"https://api.github.com/users/ctalkington/followers","following_url":"https://api.github.com/users/ctalkington/following{/other_user}","gists_url":"https://api.github.com/users/ctalkington/gists{/gist_id}","starred_url":"https://api.github.com/users/ctalkington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctalkington/subscriptions","organizations_url":"https://api.github.com/users/ctalkington/orgs","repos_url":"https://api.github.com/users/ctalkington/repos","events_url":"https://api.github.com/users/ctalkington/events{/privacy}","received_events_url":"https://api.github.com/users/ctalkington/received_events","type":"User","site_admin":false},"created_at":"2018-04-03T01:42:17Z","updated_at":"2018-04-03T01:42:17Z","author_association":"OWNER","body":"there are a few references that show/note/elude to this in documentation. though i think the point that archiver is a stream and you should be monitoring the fs/http/etc stream for true completion may be missed and could be better documented in the jsdoc that generates the docs.\r\n\r\nthe finish event on archiver just means that it has finished receiving data, not emitting it. only the next link the chain (ie fs) would know if its been written to disk.\r\n\r\nhttps://archiverjs.com/docs/#quick-start\r\nhttps://archiverjs.com/docs/Archiver.html#finalize\r\n\r\n```The end, close or finish events on the destination stream may fire right after calling this method so you should set listeners beforehand to properly detect stream completion.```\r\n"}}
{"actor":{"display_login":"ctalkington"}}