{"action":"created","issue":{"url":"https://api.github.com/repos/ag-grid/ag-grid/issues/2627","repository_url":"https://api.github.com/repos/ag-grid/ag-grid","labels_url":"https://api.github.com/repos/ag-grid/ag-grid/issues/2627/labels{/name}","comments_url":"https://api.github.com/repos/ag-grid/ag-grid/issues/2627/comments","events_url":"https://api.github.com/repos/ag-grid/ag-grid/issues/2627/events","html_url":"https://github.com/ag-grid/ag-grid/issues/2627","id":359624769,"node_id":"MDU6SXNzdWUzNTk2MjQ3Njk=","number":2627,"title":"V19 - blank defaultToolPanel yields unexpected warnings in console","user":{"login":"mcrib96","id":26966537,"node_id":"MDQ6VXNlcjI2OTY2NTM3","avatar_url":"https://avatars2.githubusercontent.com/u/26966537?v=4","gravatar_id":"","url":"https://api.github.com/users/mcrib96","html_url":"https://github.com/mcrib96","followers_url":"https://api.github.com/users/mcrib96/followers","following_url":"https://api.github.com/users/mcrib96/following{/other_user}","gists_url":"https://api.github.com/users/mcrib96/gists{/gist_id}","starred_url":"https://api.github.com/users/mcrib96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcrib96/subscriptions","organizations_url":"https://api.github.com/users/mcrib96/orgs","repos_url":"https://api.github.com/users/mcrib96/repos","events_url":"https://api.github.com/users/mcrib96/events{/privacy}","received_events_url":"https://api.github.com/users/mcrib96/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-12T19:43:38Z","updated_at":"2018-09-27T15:51:05Z","closed_at":"2018-09-26T13:42:28Z","author_association":"NONE","body":"**I'm submitting a ...**  (check one with \"x\")\r\n```\r\nX bug report => see 'Providing a Reproducible Scenario'\r\n[] feature request => do not use Github for feature requests, see 'Customers of ag-Grid'\r\n[] support request => see 'Requesting Community Support'\r\n```\r\nI am trying to make the toolPanel NOT display by default.\r\nThe documentation states that defaultToolPanel should be set to none.\r\n(https://www.ag-grid.com/javascript-grid-side-bar/)\r\n\r\n    var gridOptions = {    \r\n    ...\r\n    sideBar: {\r\n        toolPanels: [\r\n                {\r\n                    id: 'columns',\r\n                    labelDefault: 'Columns',\r\n                    labelKey: 'columns',\r\n                    iconKey: 'columns',\r\n                    toolPanel: 'agColumnsToolPanel',\r\n                    toolPanelParams: {\r\n                        suppressValues: true,\r\n                        suppressPivots: true,\r\n                        suppressPivotMode: true,\r\n                        suppressRowGroups: false\r\n                    }\r\n                },\r\n                {\r\n                    id: 'filters',\r\n                    labelDefault: 'Filters',\r\n                    labelKey: 'filters',\r\n                    iconKey: 'filter',\r\n                    toolPanel: 'agFiltersToolPanel',\r\n                }\r\n            ],\r\n            defaultToolPanel: ''\r\n        }\r\n    }\r\n\r\n**Current behavior.**\r\nwhen the grid loads, i get a warning:\r\nag-grid: can't set the visibility of the tool panel item [] since it can't be found\r\n\r\n**Expected behavior**\r\nI expect no warnings since there is no defaultToolPanel to display.\r\n\r\n**Please tell us about your environment:**\r\nUsing ag-grid v19 with angular 1.5.10\r\n\r\n* **ag-Grid version:** X.X.X\r\nag-grid-enterprise v19\r\n\r\n* **Browser:**\r\nChrome\r\n\r\n* **Language:** [all | TypeScript X.X | ES6/7 | ES5]\r\nall\r\n"},"comment":{"url":"https://api.github.com/repos/ag-grid/ag-grid/issues/comments/425144886","html_url":"https://github.com/ag-grid/ag-grid/issues/2627#issuecomment-425144886","issue_url":"https://api.github.com/repos/ag-grid/ag-grid/issues/2627","id":425144886,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTE0NDg4Ng==","user":{"login":"makinggoodsoftware","id":505400,"node_id":"MDQ6VXNlcjUwNTQwMA==","avatar_url":"https://avatars0.githubusercontent.com/u/505400?v=4","gravatar_id":"","url":"https://api.github.com/users/makinggoodsoftware","html_url":"https://github.com/makinggoodsoftware","followers_url":"https://api.github.com/users/makinggoodsoftware/followers","following_url":"https://api.github.com/users/makinggoodsoftware/following{/other_user}","gists_url":"https://api.github.com/users/makinggoodsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/makinggoodsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makinggoodsoftware/subscriptions","organizations_url":"https://api.github.com/users/makinggoodsoftware/orgs","repos_url":"https://api.github.com/users/makinggoodsoftware/repos","events_url":"https://api.github.com/users/makinggoodsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/makinggoodsoftware/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T15:51:05Z","updated_at":"2018-09-27T15:51:05Z","author_association":"CONTRIBUTOR","body":"Hi,\r\n\r\nI am afraid that we don't think that is correct, having '' is not the same as having null or undefined, we think is more semantic to have this value to be either null or undefined.\r\n\r\nHope this makes sense"}}
{"actor":{"display_login":"makinggoodsoftware"}}