{"action":"created","issue":{"url":"https://api.github.com/repos/netdata/netdata/issues/4281","repository_url":"https://api.github.com/repos/netdata/netdata","labels_url":"https://api.github.com/repos/netdata/netdata/issues/4281/labels{/name}","comments_url":"https://api.github.com/repos/netdata/netdata/issues/4281/comments","events_url":"https://api.github.com/repos/netdata/netdata/issues/4281/events","html_url":"https://github.com/netdata/netdata/pull/4281","id":363154466,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NjYyNjkw","number":4281,"title":"tcp syn and accept queue charts and alarms","user":{"login":"ktsaou","id":2662304,"node_id":"MDQ6VXNlcjI2NjIzMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2662304?v=4","gravatar_id":"","url":"https://api.github.com/users/ktsaou","html_url":"https://github.com/ktsaou","followers_url":"https://api.github.com/users/ktsaou/followers","following_url":"https://api.github.com/users/ktsaou/following{/other_user}","gists_url":"https://api.github.com/users/ktsaou/gists{/gist_id}","starred_url":"https://api.github.com/users/ktsaou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktsaou/subscriptions","organizations_url":"https://api.github.com/users/ktsaou/orgs","repos_url":"https://api.github.com/users/ktsaou/repos","events_url":"https://api.github.com/users/ktsaou/events{/privacy}","received_events_url":"https://api.github.com/users/ktsaou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-24T13:48:19Z","updated_at":"2018-09-25T10:10:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/netdata/netdata/pulls/4281","html_url":"https://github.com/netdata/netdata/pull/4281","diff_url":"https://github.com/netdata/netdata/pull/4281.diff","patch_url":"https://github.com/netdata/netdata/pull/4281.patch"},"body":"fixes #3234 \r\n\r\nThanks to @literal, this PR:\r\n\r\n1. Adds a new chart `ipv4.tcp_syn_queue` that tracks `TcpExtTCPReqQFullDoCookies` and `TcpExtTCPReqQFullDrop`\r\n2. The chart `ipv4.tcplistenissues` is now renamed to `ipv4.tcp_accept_queue` that tracks `TcpExtListenOverflows` and `TcpExtListenDrops`\r\n3. The alarm `1m_ipv4_tcp_listen_drops` is commented out\r\n4. The alarm `1m_ipv4_tcp_listen_overflows` has been renamed to `1m_ipv4_tcp_accept_queue_overflows`\r\n5. New alarm `1m_ipv4_tcp_syn_queue_drops` is tracking `TcpExtTCPReqQFullDrop`\r\n6. New alarm `1m_ipv4_tcp_syn_queue_cookies` is tracking `TcpExtTCPReqQFullDoCookies`\r\n7. Added the explanation given by @literal here: https://github.com/netdata/netdata/issues/3234#issuecomment-423935842 to both the alarm configuration file and above the charts.\r\n\r\nThe charts:\r\n\r\n![image](https://user-images.githubusercontent.com/2662304/45955742-653cd100-c019-11e8-9025-05db356640ef.png)\r\n\r\nThe alarms:\r\n\r\n![image](https://user-images.githubusercontent.com/2662304/45955826-9d441400-c019-11e8-8a74-4d1d7e457a4a.png)\r\n"},"comment":{"url":"https://api.github.com/repos/netdata/netdata/issues/comments/424284622","html_url":"https://github.com/netdata/netdata/pull/4281#issuecomment-424284622","issue_url":"https://api.github.com/repos/netdata/netdata/issues/4281","id":424284622,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDI4NDYyMg==","user":{"login":"literal","id":294364,"node_id":"MDQ6VXNlcjI5NDM2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/294364?v=4","gravatar_id":"","url":"https://api.github.com/users/literal","html_url":"https://github.com/literal","followers_url":"https://api.github.com/users/literal/followers","following_url":"https://api.github.com/users/literal/following{/other_user}","gists_url":"https://api.github.com/users/literal/gists{/gist_id}","starred_url":"https://api.github.com/users/literal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/literal/subscriptions","organizations_url":"https://api.github.com/users/literal/orgs","repos_url":"https://api.github.com/users/literal/repos","events_url":"https://api.github.com/users/literal/events{/privacy}","received_events_url":"https://api.github.com/users/literal/received_events","type":"User","site_admin":false},"created_at":"2018-09-25T10:10:56Z","updated_at":"2018-09-25T10:10:56Z","author_association":"NONE","body":"Thinking about it once again, I wonder whether `TcpExtListenDrops` is a very useful metric at all. It's incremented in a variety of different situations, some of which are harmless while others indicate trouble. And there are even cases when incoming TCP connection requests are discarded without `TcpExtListenDrops` being incremented, e.g. when they time out (after retransmitting the SYN/ACK reply a couple of times).\r\nSo perhaps it does more harm confusing users than being a useful piece of information?\r\n\r\nApart from that I agree with your idea to keep the metrics on a single chart, renaming them for more clarity, eg. `synOverflows`, `synCookies` and `acceptDrops`. The chart name `ipv4.tcplistenissues` might be a bit misleading though, because the numbers apply to IPv6 as well."}}
{"actor":{"display_login":"literal"}}