{"action":"created","comment":{"url":"https://api.github.com/repos/simonsoft/cms-publish/pulls/comments/194030399","pull_request_review_id":127127154,"id":194030399,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDAzMDM5OQ==","diff_hunk":"@@ -380,6 +379,16 @@ private String getProgressAsJson(PublishJobProgress progress) {\n \t\treturn progressJson;\n \t}\n \t\n+\tprivate void sendTaskResultBestEffort(GetActivityTaskResult taskResult, CommandRuntimeException cre) {\n+\t\ttry {\n+\t\t\tsendTaskResult(taskResult, cre);\n+\t\t} catch (TaskTimedOutException timedOutEx) {\n+\t\t\tlogger.error(\"AWS Client has timed out while tring to send task result\", timedOutEx);","path":"cms-publish-worker-webapp/src/main/java/se/simonsoft/cms/publish/worker/AwsStepfunctionPublishWorker.java","position":37,"original_position":37,"commit_id":"eec834977e241e4029b0228d8778b8785f16d48b","original_commit_id":"eec834977e241e4029b0228d8778b8785f16d48b","user":{"login":"takesson","id":8809736,"node_id":"MDQ6VXNlcjg4MDk3MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/8809736?v=4","gravatar_id":"","url":"https://api.github.com/users/takesson","html_url":"https://github.com/takesson","followers_url":"https://api.github.com/users/takesson/followers","following_url":"https://api.github.com/users/takesson/following{/other_user}","gists_url":"https://api.github.com/users/takesson/gists{/gist_id}","starred_url":"https://api.github.com/users/takesson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takesson/subscriptions","organizations_url":"https://api.github.com/users/takesson/orgs","repos_url":"https://api.github.com/users/takesson/repos","events_url":"https://api.github.com/users/takesson/events{/privacy}","received_events_url":"https://api.github.com/users/takesson/received_events","type":"User","site_admin":false},"body":"No, you have not understood TTE. \r\n\r\nAWS Task has timed out while processed by the Worker (heartbeats too sparse or total time exceeded).","created_at":"2018-06-08T11:37:59Z","updated_at":"2018-06-08T11:38:05Z","html_url":"https://github.com/simonsoft/cms-publish/pull/69#discussion_r194030399","pull_request_url":"https://api.github.com/repos/simonsoft/cms-publish/pulls/69","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/simonsoft/cms-publish/pulls/comments/194030399"},"html":{"href":"https://github.com/simonsoft/cms-publish/pull/69#discussion_r194030399"},"pull_request":{"href":"https://api.github.com/repos/simonsoft/cms-publish/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/simonsoft/cms-publish/pulls/69","id":193586823,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTg2ODIz","html_url":"https://github.com/simonsoft/cms-publish/pull/69","diff_url":"https://github.com/simonsoft/cms-publish/pull/69.diff","patch_url":"https://github.com/simonsoft/cms-publish/pull/69.patch","issue_url":"https://api.github.com/repos/simonsoft/cms-publish/issues/69","number":69,"state":"open","locked":false,"title":"Dangerous-code-in-catch","user":{"login":"anderjo4","id":5907897,"node_id":"MDQ6VXNlcjU5MDc4OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/5907897?v=4","gravatar_id":"","url":"https://api.github.com/users/anderjo4","html_url":"https://github.com/anderjo4","followers_url":"https://api.github.com/users/anderjo4/followers","following_url":"https://api.github.com/users/anderjo4/following{/other_user}","gists_url":"https://api.github.com/users/anderjo4/gists{/gist_id}","starred_url":"https://api.github.com/users/anderjo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anderjo4/subscriptions","organizations_url":"https://api.github.com/users/anderjo4/orgs","repos_url":"https://api.github.com/users/anderjo4/repos","events_url":"https://api.github.com/users/anderjo4/events{/privacy}","received_events_url":"https://api.github.com/users/anderjo4/received_events","type":"User","site_admin":false},"body":"- Catching exceptions that may be thrown in our catch blocks while making requests to AWS.\r\n- Exceptions is logged.\r\n- Own catch for TimedOutException.\r\n- Loop will not break.","created_at":"2018-06-08T11:32:05Z","updated_at":"2018-06-08T11:38:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f7138375c694a680087806d86eda1969149a190","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/simonsoft/cms-publish/pulls/69/commits","review_comments_url":"https://api.github.com/repos/simonsoft/cms-publish/pulls/69/comments","review_comment_url":"https://api.github.com/repos/simonsoft/cms-publish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simonsoft/cms-publish/issues/69/comments","statuses_url":"https://api.github.com/repos/simonsoft/cms-publish/statuses/eec834977e241e4029b0228d8778b8785f16d48b","head":{"label":"simonsoft:sendTaskResultExceptions","ref":"sendTaskResultExceptions","sha":"eec834977e241e4029b0228d8778b8785f16d48b","user":{"login":"simonsoft","id":8809789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4MDk3ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/8809789?v=4","gravatar_id":"","url":"https://api.github.com/users/simonsoft","html_url":"https://github.com/simonsoft","followers_url":"https://api.github.com/users/simonsoft/followers","following_url":"https://api.github.com/users/simonsoft/following{/other_user}","gists_url":"https://api.github.com/users/simonsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/simonsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonsoft/subscriptions","organizations_url":"https://api.github.com/users/simonsoft/orgs","repos_url":"https://api.github.com/users/simonsoft/repos","events_url":"https://api.github.com/users/simonsoft/events{/privacy}","received_events_url":"https://api.github.com/users/simonsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":105135185,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUxMzUxODU=","name":"cms-publish","full_name":"simonsoft/cms-publish","owner":{"login":"simonsoft","id":8809789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4MDk3ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/8809789?v=4","gravatar_id":"","url":"https://api.github.com/users/simonsoft","html_url":"https://github.com/simonsoft","followers_url":"https://api.github.com/users/simonsoft/followers","following_url":"https://api.github.com/users/simonsoft/following{/other_user}","gists_url":"https://api.github.com/users/simonsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/simonsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonsoft/subscriptions","organizations_url":"https://api.github.com/users/simonsoft/orgs","repos_url":"https://api.github.com/users/simonsoft/repos","events_url":"https://api.github.com/users/simonsoft/events{/privacy}","received_events_url":"https://api.github.com/users/simonsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simonsoft/cms-publish","description":null,"fork":false,"url":"https://api.github.com/repos/simonsoft/cms-publish","forks_url":"https://api.github.com/repos/simonsoft/cms-publish/forks","keys_url":"https://api.github.com/repos/simonsoft/cms-publish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simonsoft/cms-publish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simonsoft/cms-publish/teams","hooks_url":"https://api.github.com/repos/simonsoft/cms-publish/hooks","issue_events_url":"https://api.github.com/repos/simonsoft/cms-publish/issues/events{/number}","events_url":"https://api.github.com/repos/simonsoft/cms-publish/events","assignees_url":"https://api.github.com/repos/simonsoft/cms-publish/assignees{/user}","branches_url":"https://api.github.com/repos/simonsoft/cms-publish/branches{/branch}","tags_url":"https://api.github.com/repos/simonsoft/cms-publish/tags","blobs_url":"https://api.github.com/repos/simonsoft/cms-publish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simonsoft/cms-publish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simonsoft/cms-publish/git/refs{/sha}","trees_url":"https://api.github.com/repos/simonsoft/cms-publish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simonsoft/cms-publish/statuses/{sha}","languages_url":"https://api.github.com/repos/simonsoft/cms-publish/languages","stargazers_url":"https://api.github.com/repos/simonsoft/cms-publish/stargazers","contributors_url":"https://api.github.com/repos/simonsoft/cms-publish/contributors","subscribers_url":"https://api.github.com/repos/simonsoft/cms-publish/subscribers","subscription_url":"https://api.github.com/repos/simonsoft/cms-publish/subscription","commits_url":"https://api.github.com/repos/simonsoft/cms-publish/commits{/sha}","git_commits_url":"https://api.github.com/repos/simonsoft/cms-publish/git/commits{/sha}","comments_url":"https://api.github.com/repos/simonsoft/cms-publish/comments{/number}","issue_comment_url":"https://api.github.com/repos/simonsoft/cms-publish/issues/comments{/number}","contents_url":"https://api.github.com/repos/simonsoft/cms-publish/contents/{+path}","compare_url":"https://api.github.com/repos/simonsoft/cms-publish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simonsoft/cms-publish/merges","archive_url":"https://api.github.com/repos/simonsoft/cms-publish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simonsoft/cms-publish/downloads","issues_url":"https://api.github.com/repos/simonsoft/cms-publish/issues{/number}","pulls_url":"https://api.github.com/repos/simonsoft/cms-publish/pulls{/number}","milestones_url":"https://api.github.com/repos/simonsoft/cms-publish/milestones{/number}","notifications_url":"https://api.github.com/repos/simonsoft/cms-publish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simonsoft/cms-publish/labels{/name}","releases_url":"https://api.github.com/repos/simonsoft/cms-publish/releases{/id}","deployments_url":"https://api.github.com/repos/simonsoft/cms-publish/deployments","created_at":"2017-09-28T10:28:50Z","updated_at":"2018-05-31T14:06:55Z","pushed_at":"2018-06-08T11:32:06Z","git_url":"git://github.com/simonsoft/cms-publish.git","ssh_url":"git@github.com:simonsoft/cms-publish.git","clone_url":"https://github.com/simonsoft/cms-publish.git","svn_url":"https://github.com/simonsoft/cms-publish","homepage":null,"size":1328,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"simonsoft:master","ref":"master","sha":"7af0bdc8d12a986b698ade3009b4bb96de1e23b8","user":{"login":"simonsoft","id":8809789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4MDk3ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/8809789?v=4","gravatar_id":"","url":"https://api.github.com/users/simonsoft","html_url":"https://github.com/simonsoft","followers_url":"https://api.github.com/users/simonsoft/followers","following_url":"https://api.github.com/users/simonsoft/following{/other_user}","gists_url":"https://api.github.com/users/simonsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/simonsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonsoft/subscriptions","organizations_url":"https://api.github.com/users/simonsoft/orgs","repos_url":"https://api.github.com/users/simonsoft/repos","events_url":"https://api.github.com/users/simonsoft/events{/privacy}","received_events_url":"https://api.github.com/users/simonsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":105135185,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUxMzUxODU=","name":"cms-publish","full_name":"simonsoft/cms-publish","owner":{"login":"simonsoft","id":8809789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4MDk3ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/8809789?v=4","gravatar_id":"","url":"https://api.github.com/users/simonsoft","html_url":"https://github.com/simonsoft","followers_url":"https://api.github.com/users/simonsoft/followers","following_url":"https://api.github.com/users/simonsoft/following{/other_user}","gists_url":"https://api.github.com/users/simonsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/simonsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonsoft/subscriptions","organizations_url":"https://api.github.com/users/simonsoft/orgs","repos_url":"https://api.github.com/users/simonsoft/repos","events_url":"https://api.github.com/users/simonsoft/events{/privacy}","received_events_url":"https://api.github.com/users/simonsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simonsoft/cms-publish","description":null,"fork":false,"url":"https://api.github.com/repos/simonsoft/cms-publish","forks_url":"https://api.github.com/repos/simonsoft/cms-publish/forks","keys_url":"https://api.github.com/repos/simonsoft/cms-publish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simonsoft/cms-publish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simonsoft/cms-publish/teams","hooks_url":"https://api.github.com/repos/simonsoft/cms-publish/hooks","issue_events_url":"https://api.github.com/repos/simonsoft/cms-publish/issues/events{/number}","events_url":"https://api.github.com/repos/simonsoft/cms-publish/events","assignees_url":"https://api.github.com/repos/simonsoft/cms-publish/assignees{/user}","branches_url":"https://api.github.com/repos/simonsoft/cms-publish/branches{/branch}","tags_url":"https://api.github.com/repos/simonsoft/cms-publish/tags","blobs_url":"https://api.github.com/repos/simonsoft/cms-publish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simonsoft/cms-publish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simonsoft/cms-publish/git/refs{/sha}","trees_url":"https://api.github.com/repos/simonsoft/cms-publish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simonsoft/cms-publish/statuses/{sha}","languages_url":"https://api.github.com/repos/simonsoft/cms-publish/languages","stargazers_url":"https://api.github.com/repos/simonsoft/cms-publish/stargazers","contributors_url":"https://api.github.com/repos/simonsoft/cms-publish/contributors","subscribers_url":"https://api.github.com/repos/simonsoft/cms-publish/subscribers","subscription_url":"https://api.github.com/repos/simonsoft/cms-publish/subscription","commits_url":"https://api.github.com/repos/simonsoft/cms-publish/commits{/sha}","git_commits_url":"https://api.github.com/repos/simonsoft/cms-publish/git/commits{/sha}","comments_url":"https://api.github.com/repos/simonsoft/cms-publish/comments{/number}","issue_comment_url":"https://api.github.com/repos/simonsoft/cms-publish/issues/comments{/number}","contents_url":"https://api.github.com/repos/simonsoft/cms-publish/contents/{+path}","compare_url":"https://api.github.com/repos/simonsoft/cms-publish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simonsoft/cms-publish/merges","archive_url":"https://api.github.com/repos/simonsoft/cms-publish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simonsoft/cms-publish/downloads","issues_url":"https://api.github.com/repos/simonsoft/cms-publish/issues{/number}","pulls_url":"https://api.github.com/repos/simonsoft/cms-publish/pulls{/number}","milestones_url":"https://api.github.com/repos/simonsoft/cms-publish/milestones{/number}","notifications_url":"https://api.github.com/repos/simonsoft/cms-publish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simonsoft/cms-publish/labels{/name}","releases_url":"https://api.github.com/repos/simonsoft/cms-publish/releases{/id}","deployments_url":"https://api.github.com/repos/simonsoft/cms-publish/deployments","created_at":"2017-09-28T10:28:50Z","updated_at":"2018-05-31T14:06:55Z","pushed_at":"2018-06-08T11:32:06Z","git_url":"git://github.com/simonsoft/cms-publish.git","ssh_url":"git@github.com:simonsoft/cms-publish.git","clone_url":"https://github.com/simonsoft/cms-publish.git","svn_url":"https://github.com/simonsoft/cms-publish","homepage":null,"size":1328,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simonsoft/cms-publish/pulls/69"},"html":{"href":"https://github.com/simonsoft/cms-publish/pull/69"},"issue":{"href":"https://api.github.com/repos/simonsoft/cms-publish/issues/69"},"comments":{"href":"https://api.github.com/repos/simonsoft/cms-publish/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/simonsoft/cms-publish/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/simonsoft/cms-publish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simonsoft/cms-publish/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/simonsoft/cms-publish/statuses/eec834977e241e4029b0228d8778b8785f16d48b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"takesson"}}