{"action":"created","issue":{"url":"https://api.github.com/repos/couchbase/sync_gateway/issues/3333","repository_url":"https://api.github.com/repos/couchbase/sync_gateway","labels_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/3333/labels{/name}","comments_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/3333/comments","events_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/3333/events","html_url":"https://github.com/couchbase/sync_gateway/pull/3333","id":299493426,"number":3333,"title":"Attempt to make gocb bucket flushable","user":{"login":"tleyden","id":296876,"avatar_url":"https://avatars1.githubusercontent.com/u/296876?v=4","gravatar_id":"","url":"https://api.github.com/users/tleyden","html_url":"https://github.com/tleyden","followers_url":"https://api.github.com/users/tleyden/followers","following_url":"https://api.github.com/users/tleyden/following{/other_user}","gists_url":"https://api.github.com/users/tleyden/gists{/gist_id}","starred_url":"https://api.github.com/users/tleyden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tleyden/subscriptions","organizations_url":"https://api.github.com/users/tleyden/orgs","repos_url":"https://api.github.com/users/tleyden/repos","events_url":"https://api.github.com/users/tleyden/events{/privacy}","received_events_url":"https://api.github.com/users/tleyden/received_events","type":"User","site_admin":false},"labels":[{"id":107354377,"url":"https://api.github.com/repos/couchbase/sync_gateway/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"adamcfraser","id":8866453,"avatar_url":"https://avatars3.githubusercontent.com/u/8866453?v=4","gravatar_id":"","url":"https://api.github.com/users/adamcfraser","html_url":"https://github.com/adamcfraser","followers_url":"https://api.github.com/users/adamcfraser/followers","following_url":"https://api.github.com/users/adamcfraser/following{/other_user}","gists_url":"https://api.github.com/users/adamcfraser/gists{/gist_id}","starred_url":"https://api.github.com/users/adamcfraser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamcfraser/subscriptions","organizations_url":"https://api.github.com/users/adamcfraser/orgs","repos_url":"https://api.github.com/users/adamcfraser/repos","events_url":"https://api.github.com/users/adamcfraser/events{/privacy}","received_events_url":"https://api.github.com/users/adamcfraser/received_events","type":"User","site_admin":false},"assignees":[{"login":"adamcfraser","id":8866453,"avatar_url":"https://avatars3.githubusercontent.com/u/8866453?v=4","gravatar_id":"","url":"https://api.github.com/users/adamcfraser","html_url":"https://github.com/adamcfraser","followers_url":"https://api.github.com/users/adamcfraser/followers","following_url":"https://api.github.com/users/adamcfraser/following{/other_user}","gists_url":"https://api.github.com/users/adamcfraser/gists{/gist_id}","starred_url":"https://api.github.com/users/adamcfraser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamcfraser/subscriptions","organizations_url":"https://api.github.com/users/adamcfraser/orgs","repos_url":"https://api.github.com/users/adamcfraser/repos","events_url":"https://api.github.com/users/adamcfraser/events{/privacy}","received_events_url":"https://api.github.com/users/adamcfraser/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-02-22T20:16:57Z","updated_at":"2018-04-17T22:35:53Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/couchbase/sync_gateway/pulls/3333","html_url":"https://github.com/couchbase/sync_gateway/pull/3333","diff_url":"https://github.com/couchbase/sync_gateway/pull/3333.diff","patch_url":"https://github.com/couchbase/sync_gateway/pull/3333.patch"},"body":"**Not ready for merge** -- will need to first merge the dependent PR in the sg-bucket repo\r\n\r\nFixes https://github.com/couchbase/sync_gateway/issues/3305 (dev branch)\r\n\r\n## Changes:\r\n\r\n- Add `CloseAndDelete()` (aka \"flush\") method to `gocb_bucket.go`, as well as `BucketItemCount()` helper method needed by `CloseAndDelete()`\r\n- Update `handleFlush()` to properly handle the flush so it doesn't try to flush a closed bucket.  Manually verified that this still works against Walrus.\r\n- Add unsupported config flag + check in `handleFlush()` to force the user to set a flag if flushing a Couchbase bucket via REST API\r\n- Refactor out a `GetBucketSpec()` method\r\n- [x] Merge the dependent PR in the sg-bucket repo: https://github.com/couchbase/sg-bucket/pull/34\r\n\r\n## Post merge\r\n\r\n- [ ] Update the LiteCore replication tests to enable couchbase server buckets to be flushed"},"comment":{"url":"https://api.github.com/repos/couchbase/sync_gateway/issues/comments/382178001","html_url":"https://github.com/couchbase/sync_gateway/pull/3333#issuecomment-382178001","issue_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/3333","id":382178001,"user":{"login":"tleyden","id":296876,"avatar_url":"https://avatars1.githubusercontent.com/u/296876?v=4","gravatar_id":"","url":"https://api.github.com/users/tleyden","html_url":"https://github.com/tleyden","followers_url":"https://api.github.com/users/tleyden/followers","following_url":"https://api.github.com/users/tleyden/following{/other_user}","gists_url":"https://api.github.com/users/tleyden/gists{/gist_id}","starred_url":"https://api.github.com/users/tleyden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tleyden/subscriptions","organizations_url":"https://api.github.com/users/tleyden/orgs","repos_url":"https://api.github.com/users/tleyden/repos","events_url":"https://api.github.com/users/tleyden/events{/privacy}","received_events_url":"https://api.github.com/users/tleyden/received_events","type":"User","site_admin":false},"created_at":"2018-04-17T22:35:53Z","updated_at":"2018-04-17T22:35:53Z","author_association":"COLLABORATOR","body":"Integration test failures: http://uberjenkins.sc.couchbase.com/view/Build/job/sync-gateway-integration-master/516/consoleFull\r\n\r\n@adamcfraser any chance you can do a quick triage on these to see if they look like they were newly introduced?\r\n\r\n"}}
{"actor":{"display_login":"tleyden"}}