{"action":"created","issue":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3253","repository_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3253/labels{/name}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3253/comments","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3253/events","html_url":"https://github.com/gravitystorm/openstreetmap-carto/issues/3253","id":327524138,"node_id":"MDU6SXNzdWUzMjc1MjQxMzg=","number":3253,"title":"Spring icon invisible under waterway=river","user":{"login":"polarbearing","id":8266355,"node_id":"MDQ6VXNlcjgyNjYzNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/8266355?v=4","gravatar_id":"","url":"https://api.github.com/users/polarbearing","html_url":"https://github.com/polarbearing","followers_url":"https://api.github.com/users/polarbearing/followers","following_url":"https://api.github.com/users/polarbearing/following{/other_user}","gists_url":"https://api.github.com/users/polarbearing/gists{/gist_id}","starred_url":"https://api.github.com/users/polarbearing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polarbearing/subscriptions","organizations_url":"https://api.github.com/users/polarbearing/orgs","repos_url":"https://api.github.com/users/polarbearing/repos","events_url":"https://api.github.com/users/polarbearing/events{/privacy}","received_events_url":"https://api.github.com/users/polarbearing/received_events","type":"User","site_admin":false},"labels":[{"id":92406692,"node_id":"MDU6TGFiZWw5MjQwNjY5Mg==","url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/labels/water-features","name":"water-features","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/milestones/3","html_url":"https://github.com/gravitystorm/openstreetmap-carto/milestone/3","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/milestones/3/labels","id":804552,"node_id":"MDk6TWlsZXN0b25lODA0NTUy","number":3,"title":"Bugs and improvements","description":"","creator":{"login":"matthijsmelissen","id":5251909,"node_id":"MDQ6VXNlcjUyNTE5MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/5251909?v=4","gravatar_id":"","url":"https://api.github.com/users/matthijsmelissen","html_url":"https://github.com/matthijsmelissen","followers_url":"https://api.github.com/users/matthijsmelissen/followers","following_url":"https://api.github.com/users/matthijsmelissen/following{/other_user}","gists_url":"https://api.github.com/users/matthijsmelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/matthijsmelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthijsmelissen/subscriptions","organizations_url":"https://api.github.com/users/matthijsmelissen/orgs","repos_url":"https://api.github.com/users/matthijsmelissen/repos","events_url":"https://api.github.com/users/matthijsmelissen/events{/privacy}","received_events_url":"https://api.github.com/users/matthijsmelissen/received_events","type":"User","site_admin":false},"open_issues":232,"closed_issues":571,"state":"open","created_at":"2014-09-26T17:37:22Z","updated_at":"2018-06-06T10:51:36Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2018-05-29T23:43:16Z","updated_at":"2018-06-08T08:44:03Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The spring icon was recently refurbished as a blue ring with a white halo #3189.\r\n\r\nUnfortunately this was not tested when surrounded with a body of water, which is a common case for a spring. Example: [Big Spring Missouri](https://www.openstreetmap.org/#map=19/36.95184/-90.99300),  mapped as a node in a body of water. The old 'S' icon was visible, see example in [comment](3189#issuecomment-390004949). The new one is not:\r\n![204155](https://user-images.githubusercontent.com/8266355/40260580-b57bbe2a-5afb-11e8-8032-1aad2a4a5e7c.png)\r\n\r\nThe ring is defined slightly darker than water colour and has a halo, so it is not clear to me why it is completely invisible. I had done some analysis so far (from #3189):\r\n\r\n> The SVG is constructed atypically compared to other icons. It seems to have no artboard size, thus git shows the icon in a large transparent square, opening with Illustrator presents it on an A4 sheet, partially hanging over the border.\r\n> It has 3 grouped paths being concentric rings. One is the blue ring (# 7abcec), the others are white (# ffffff). One of the white rings sits behind the blue and is thicker, thus constructs the 'halo'. The function of the third ring is unclear since it is thinner and behind the blue.\r\n> The SVG contains some 'transform' operations which apparently just shift the rings onto each other and could be avoided if they were drawn in the right place already.\r\n> \r\n> All new icons I have analysed so far use fill while the stroke is empty. This SVG is the opposite.\r\n> \r\n> Typically we have the icon black and define the colour in carto.\r\n> \r\n> The ring (# 7abcec) is darker than water (@water-color defined as # aad3df)\r\n> \r\n> IIRC, the order of the 'id:' elements in the 'Layer:' section in the project.mml defines the painting order? If so, 'water-areas' are painted earlier than 'springs' which are earlier than 'water-lines'.\r\n> \r\n> This explains why a river line is painted over the ring, but I don't understand why the white rings disappear over a water area?\r\n> \r\n> Finally I'd have the style for the spring rather in the water.mss with the natural things, while water-features.mss mostly has the man-made barrieres etc."},"comment":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/comments/395693270","html_url":"https://github.com/gravitystorm/openstreetmap-carto/issues/3253#issuecomment-395693270","issue_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3253","id":395693270,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTY5MzI3MA==","user":{"login":"Penegal","id":13777824,"node_id":"MDQ6VXNlcjEzNzc3ODI0","avatar_url":"https://avatars3.githubusercontent.com/u/13777824?v=4","gravatar_id":"","url":"https://api.github.com/users/Penegal","html_url":"https://github.com/Penegal","followers_url":"https://api.github.com/users/Penegal/followers","following_url":"https://api.github.com/users/Penegal/following{/other_user}","gists_url":"https://api.github.com/users/Penegal/gists{/gist_id}","starred_url":"https://api.github.com/users/Penegal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Penegal/subscriptions","organizations_url":"https://api.github.com/users/Penegal/orgs","repos_url":"https://api.github.com/users/Penegal/repos","events_url":"https://api.github.com/users/Penegal/events{/privacy}","received_events_url":"https://api.github.com/users/Penegal/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T08:44:03Z","updated_at":"2018-06-08T08:44:03Z","author_association":"CONTRIBUTOR","body":"> I'd also like to close the transparent middle of the icon as it leads to another inconsistency. Filling with blue creates a nice circular 'wave ripple' effect, you can study that on springs in water bodies that are not covered by a river.\r\n\r\nThis design was rejected because of risk of confusion with other water features, which could ultimately lead to mistagging."}}
{"actor":{"display_login":"Penegal"}}