{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6861","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6861/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6861/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6861/events","html_url":"https://github.com/NREL/EnergyPlus/pull/6861","id":344961005,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjMyMTEw","number":6861,"title":"Addressed Heat exchanger bypass control problems ","user":{"login":"Nigusse","id":5805126,"node_id":"MDQ6VXNlcjU4MDUxMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5805126?v=4","gravatar_id":"","url":"https://api.github.com/users/Nigusse","html_url":"https://github.com/Nigusse","followers_url":"https://api.github.com/users/Nigusse/followers","following_url":"https://api.github.com/users/Nigusse/following{/other_user}","gists_url":"https://api.github.com/users/Nigusse/gists{/gist_id}","starred_url":"https://api.github.com/users/Nigusse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nigusse/subscriptions","organizations_url":"https://api.github.com/users/Nigusse/orgs","repos_url":"https://api.github.com/users/Nigusse/repos","events_url":"https://api.github.com/users/Nigusse/events{/privacy}","received_events_url":"https://api.github.com/users/Nigusse/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-26T18:43:34Z","updated_at":"2018-07-27T17:51:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6861","html_url":"https://github.com/NREL/EnergyPlus/pull/6861","diff_url":"https://github.com/NREL/EnergyPlus/pull/6861.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/6861.patch"},"body":"Pull request overview\r\n---------------------\r\nThis is a defect. The Minimum Outdoor Air Fraction and actual Outdoor Air Fraction are calculated using a different basis. Outdoor air fraction calculated using a different basis is invalid for comparison and leads to incorrect HX bypass status. Diffs are expected.\r\n\r\n### Work Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [ ] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n - [ ] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n   - Defect: This pull request repairs a github defect issue.  The github issue should be referenced in the PR description\r\n\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [ ] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [ ] CI status: all green or justified\r\n - [ ] Performance: CI Linux results include performance check -- verify this\r\n - [ ] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/408492265","html_url":"https://github.com/NREL/EnergyPlus/pull/6861#issuecomment-408492265","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6861","id":408492265,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODQ5MjI2NQ==","user":{"login":"Nigusse","id":5805126,"node_id":"MDQ6VXNlcjU4MDUxMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5805126?v=4","gravatar_id":"","url":"https://api.github.com/users/Nigusse","html_url":"https://github.com/Nigusse","followers_url":"https://api.github.com/users/Nigusse/followers","following_url":"https://api.github.com/users/Nigusse/following{/other_user}","gists_url":"https://api.github.com/users/Nigusse/gists{/gist_id}","starred_url":"https://api.github.com/users/Nigusse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nigusse/subscriptions","organizations_url":"https://api.github.com/users/Nigusse/orgs","repos_url":"https://api.github.com/users/Nigusse/repos","events_url":"https://api.github.com/users/Nigusse/events{/privacy}","received_events_url":"https://api.github.com/users/Nigusse/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T17:51:26Z","updated_at":"2018-07-27T17:51:26Z","author_association":"CONTRIBUTOR","body":"Yes, there are a couple places in the code were that the OutAirMinFrac is used incorrectly.\r\n(1) OutAirMinFrac is passed to CalcOAEconomizer function [here](https://github.com/NREL/EnergyPlus/blob/develop/src/EnergyPlus/MixedAir.cc#L3645) and subsequently used to calculate \"OA Node\" mass flow rate [here](https://github.com/NREL/EnergyPlus/blob/develop/src/EnergyPlus/MixedAir.cc#L4563-L4566)  by multiplying it with the \"Mixed Air Node\" mass flow rate.\r\n(2) OutAirMinFrac is used to determine HX bypass status by comparing it with actual OA fraction (OASignal) [here](https://github.com/NREL/EnergyPlus/blob/develop/src/EnergyPlus/MixedAir.cc#L4654-L4659)."}}
{"actor":{"display_login":"Nigusse"}}