{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/20185","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20185/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20185/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20185/events","html_url":"https://github.com/joomla/joomla-cms/pull/20185","id":314986117,"number":20185,"title":"[4.0] Removing artificial sharding from com_finder","user":{"login":"Hackwar","id":313866,"avatar_url":"https://avatars2.githubusercontent.com/u/313866?v=4","gravatar_id":"","url":"https://api.github.com/users/Hackwar","html_url":"https://github.com/Hackwar","followers_url":"https://api.github.com/users/Hackwar/followers","following_url":"https://api.github.com/users/Hackwar/following{/other_user}","gists_url":"https://api.github.com/users/Hackwar/gists{/gist_id}","starred_url":"https://api.github.com/users/Hackwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hackwar/subscriptions","organizations_url":"https://api.github.com/users/Hackwar/orgs","repos_url":"https://api.github.com/users/Hackwar/repos","events_url":"https://api.github.com/users/Hackwar/events{/privacy}","received_events_url":"https://api.github.com/users/Hackwar/received_events","type":"User","site_admin":false},"labels":[{"id":444033883,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-04-17T09:51:25Z","updated_at":"2018-05-11T21:16:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20185","html_url":"https://github.com/joomla/joomla-cms/pull/20185","diff_url":"https://github.com/joomla/joomla-cms/pull/20185.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/20185.patch"},"body":"Finder has an artificial sharding, which splits up the links between terms and content items onto 16 seperate tables. This PR removes that sharding. It makes the code extremely complex and bloats it unnecessarily and it also slows down the whole finder system. Indexing the original sample data of Joomla 4.0 with the current finder indexer takes about 2:40 minutes on my system. With these changes, we are already down to 1:30 minute. \r\n\r\nThis PR also fixes a few other bugs that prevented com_finder from working in Joomla 4.0 right now and I standardised all the language fields to be 7 characters long. While I plan to provide more PRs with further improvements to make com_finder more usable, this PR is in itself complete and can be merged like this.\r\n\r\n## How to test\r\nInstall 4.0-dev and go to the backend of Smart Search. Enable the Smart Search Plugin and start the indexing process. Notice that it takes a long time (preferably measure the time with a stopwatch). Go to the frontend and open the Smart Search menu item. See that it throws errors and doesn't work right now.\r\nApply this PR and clear the index in the backend. Start the re-indexing and notice that it finishes quicker. Go to the frontend and see that that menu item no longer throws errors and that all features work like expected.\r\n\r\nWhen typing in a phrase and then pressing enter, sending the request to the server, a message \"error\" is displayed before the page is reloaded both before and after applying the patch. I'm still looking for the source of that issue.\r\n\r\nI want to thank [cloudaccess.net](https://www.cloudaccess.net/) for supporting these changes. Without their generous help, this wouldn't be possible."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/388487925","html_url":"https://github.com/joomla/joomla-cms/pull/20185#issuecomment-388487925","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20185","id":388487925,"user":{"login":"Hackwar","id":313866,"avatar_url":"https://avatars2.githubusercontent.com/u/313866?v=4","gravatar_id":"","url":"https://api.github.com/users/Hackwar","html_url":"https://github.com/Hackwar","followers_url":"https://api.github.com/users/Hackwar/followers","following_url":"https://api.github.com/users/Hackwar/following{/other_user}","gists_url":"https://api.github.com/users/Hackwar/gists{/gist_id}","starred_url":"https://api.github.com/users/Hackwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hackwar/subscriptions","organizations_url":"https://api.github.com/users/Hackwar/orgs","repos_url":"https://api.github.com/users/Hackwar/repos","events_url":"https://api.github.com/users/Hackwar/events{/privacy}","received_events_url":"https://api.github.com/users/Hackwar/received_events","type":"User","site_admin":false},"created_at":"2018-05-11T21:16:35Z","updated_at":"2018-05-11T21:16:35Z","author_association":"MEMBER","body":"The current 4.0-dev branch fails in displaying the frontend when opening the smart search component and having debug mode enabled with the following error message:\r\n1055 'j4search2.t.parent_id' isn't in GROUP BY \r\nThis has been fixed in this PR.\r\n\r\nI have updated the branch with the latest changes from 4.0-dev and checked it again. It does work. Could it be that you did not apply the database changes, that this introduces? I would be happy if you could test this again."}}
{"actor":{"display_login":"Hackwar"}}