{"action":"created","comment":{"url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/pulls/comments/195314428","pull_request_review_id":128656101,"id":195314428,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTMxNDQyOA==","diff_hunk":"@@ -48,12 +48,12 @@\n import { mapState } from 'vuex'\n import pollAction from '@/mixins/pollAction'\n export default {\n-  mixins: [pollAction('fetchNodeStatus')],\n+  mixins: [pollAction('getNodeStatus')],\n   data: () => ({\n     node: process.env.AETERNITY_EPOCH_API_URL\n   }),\n   computed: mapState({\n-    s: 'nodeStatus'\n+    s: '$nodeStatus'","path":"src/screens/status/status.vue","position":11,"original_position":11,"commit_id":"0feba0eb9d307a902554edbef368dd2f3a1b8182","original_commit_id":"7b018ab1560ea24622a995e534e3045e708e9051","user":{"login":"sadiqevani","id":2134415,"node_id":"MDQ6VXNlcjIxMzQ0MTU=","avatar_url":"https://avatars1.githubusercontent.com/u/2134415?v=4","gravatar_id":"","url":"https://api.github.com/users/sadiqevani","html_url":"https://github.com/sadiqevani","followers_url":"https://api.github.com/users/sadiqevani/followers","following_url":"https://api.github.com/users/sadiqevani/following{/other_user}","gists_url":"https://api.github.com/users/sadiqevani/gists{/gist_id}","starred_url":"https://api.github.com/users/sadiqevani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadiqevani/subscriptions","organizations_url":"https://api.github.com/users/sadiqevani/orgs","repos_url":"https://api.github.com/users/sadiqevani/repos","events_url":"https://api.github.com/users/sadiqevani/events{/privacy}","received_events_url":"https://api.github.com/users/sadiqevani/received_events","type":"User","site_admin":false},"body":"This is the syntax for the store:\r\n\r\n- `${name of the variable}` -> global property unto the state\r\n- `_{name of the module}` -> partials/component state, ex: modal, tooltip, etc..\r\n- `{everything else}` -> modules\r\n\r\nReduces name collisions, makes it more clear where it comes from, though need to write this somewhere/readme.md","created_at":"2018-06-14T06:35:23Z","updated_at":"2018-06-14T06:35:23Z","html_url":"https://github.com/aeternity/aepp-blockchain-explorer/pull/28#discussion_r195314428","pull_request_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/pulls/28","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/pulls/comments/195314428"},"html":{"href":"https://github.com/aeternity/aepp-blockchain-explorer/pull/28#discussion_r195314428"},"pull_request":{"href":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/pulls/28"}},"in_reply_to_id":195282458},"pull_request":{"url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/pulls/28","id":193545227,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTQ1MjI3","html_url":"https://github.com/aeternity/aepp-blockchain-explorer/pull/28","diff_url":"https://github.com/aeternity/aepp-blockchain-explorer/pull/28.diff","patch_url":"https://github.com/aeternity/aepp-blockchain-explorer/pull/28.patch","issue_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/issues/28","number":28,"state":"open","locked":false,"title":"[WIP] Vuex Store Blockchain aepp-sdk Implementation","user":{"login":"sqevani","id":40054938,"node_id":"MDQ6VXNlcjQwMDU0OTM4","avatar_url":"https://avatars2.githubusercontent.com/u/40054938?v=4","gravatar_id":"","url":"https://api.github.com/users/sqevani","html_url":"https://github.com/sqevani","followers_url":"https://api.github.com/users/sqevani/followers","following_url":"https://api.github.com/users/sqevani/following{/other_user}","gists_url":"https://api.github.com/users/sqevani/gists{/gist_id}","starred_url":"https://api.github.com/users/sqevani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sqevani/subscriptions","organizations_url":"https://api.github.com/users/sqevani/orgs","repos_url":"https://api.github.com/users/sqevani/repos","events_url":"https://api.github.com/users/sqevani/events{/privacy}","received_events_url":"https://api.github.com/users/sqevani/received_events","type":"User","site_admin":false},"body":"### Task\r\n_Vuex Store Blockchain aepp-sdk Implementation_\r\n\r\n### Description\r\n_Due to the constant change of the REST API of the aeternity blockchain, we need to implement the SDK internally for the blockchain explorer, to minimize the need to continuously update the app and waste time_\r\n\r\n### Flow\r\n_Currently I'll try to refactor the Vuex-Store and implement it so its modular, and context specific, the idea is that the Vuex-Store will act as a middleware for the SDK and the Vue App (Blockchain explorer)_\r\n\r\n* Refactor Vuex-Store into modular parts\r\n* Reading on the AEPP-SDK API\r\n* Implement AEPP-SDK API into Vuex Actions\r\n* Bind data to the views\r\n\r\n__PS: WIP stands for Work in Progress__","created_at":"2018-06-08T08:39:53Z","updated_at":"2018-06-14T06:35:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"066bdb5b91b376c5c77da07b060b3502e0777018","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/pulls/28/commits","review_comments_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/pulls/28/comments","review_comment_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/issues/28/comments","statuses_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/statuses/0feba0eb9d307a902554edbef368dd2f3a1b8182","head":{"label":"sqevani:vuex-store-blockchain-sdk-implementation","ref":"vuex-store-blockchain-sdk-implementation","sha":"0feba0eb9d307a902554edbef368dd2f3a1b8182","user":{"login":"sqevani","id":40054938,"node_id":"MDQ6VXNlcjQwMDU0OTM4","avatar_url":"https://avatars2.githubusercontent.com/u/40054938?v=4","gravatar_id":"","url":"https://api.github.com/users/sqevani","html_url":"https://github.com/sqevani","followers_url":"https://api.github.com/users/sqevani/followers","following_url":"https://api.github.com/users/sqevani/following{/other_user}","gists_url":"https://api.github.com/users/sqevani/gists{/gist_id}","starred_url":"https://api.github.com/users/sqevani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sqevani/subscriptions","organizations_url":"https://api.github.com/users/sqevani/orgs","repos_url":"https://api.github.com/users/sqevani/repos","events_url":"https://api.github.com/users/sqevani/events{/privacy}","received_events_url":"https://api.github.com/users/sqevani/received_events","type":"User","site_admin":false},"repo":{"id":136583601,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY1ODM2MDE=","name":"aepp-blockchain-explorer","full_name":"sqevani/aepp-blockchain-explorer","owner":{"login":"sqevani","id":40054938,"node_id":"MDQ6VXNlcjQwMDU0OTM4","avatar_url":"https://avatars2.githubusercontent.com/u/40054938?v=4","gravatar_id":"","url":"https://api.github.com/users/sqevani","html_url":"https://github.com/sqevani","followers_url":"https://api.github.com/users/sqevani/followers","following_url":"https://api.github.com/users/sqevani/following{/other_user}","gists_url":"https://api.github.com/users/sqevani/gists{/gist_id}","starred_url":"https://api.github.com/users/sqevani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sqevani/subscriptions","organizations_url":"https://api.github.com/users/sqevani/orgs","repos_url":"https://api.github.com/users/sqevani/repos","events_url":"https://api.github.com/users/sqevani/events{/privacy}","received_events_url":"https://api.github.com/users/sqevani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sqevani/aepp-blockchain-explorer","description":null,"fork":true,"url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer","forks_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/forks","keys_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/teams","hooks_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/hooks","issue_events_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/events","assignees_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/tags","blobs_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/languages","stargazers_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/stargazers","contributors_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/contributors","subscribers_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/subscribers","subscription_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/subscription","commits_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/merges","archive_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/downloads","issues_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/labels{/name}","releases_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/sqevani/aepp-blockchain-explorer/deployments","created_at":"2018-06-08T07:31:41Z","updated_at":"2018-06-08T07:31:42Z","pushed_at":"2018-06-14T06:32:31Z","git_url":"git://github.com/sqevani/aepp-blockchain-explorer.git","ssh_url":"git@github.com:sqevani/aepp-blockchain-explorer.git","clone_url":"https://github.com/sqevani/aepp-blockchain-explorer.git","svn_url":"https://github.com/sqevani/aepp-blockchain-explorer","homepage":null,"size":720,"stargazers_count":0,"watchers_count":0,"language":"Vue","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aeternity:master","ref":"master","sha":"339445d9927d7ff78d061bf6e6440ed555489fb0","user":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":118007776,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgwMDc3NzY=","name":"aepp-blockchain-explorer","full_name":"aeternity/aepp-blockchain-explorer","owner":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aeternity/aepp-blockchain-explorer","description":null,"fork":false,"url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer","forks_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/forks","keys_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/teams","hooks_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/hooks","issue_events_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/events","assignees_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/tags","blobs_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/languages","stargazers_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/stargazers","contributors_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/contributors","subscribers_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/subscribers","subscription_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/subscription","commits_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/merges","archive_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/downloads","issues_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/deployments","created_at":"2018-01-18T16:25:01Z","updated_at":"2018-06-12T08:45:15Z","pushed_at":"2018-06-14T06:32:33Z","git_url":"git://github.com/aeternity/aepp-blockchain-explorer.git","ssh_url":"git@github.com:aeternity/aepp-blockchain-explorer.git","clone_url":"https://github.com/aeternity/aepp-blockchain-explorer.git","svn_url":"https://github.com/aeternity/aepp-blockchain-explorer","homepage":null,"size":557,"stargazers_count":7,"watchers_count":7,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":10,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/pulls/28"},"html":{"href":"https://github.com/aeternity/aepp-blockchain-explorer/pull/28"},"issue":{"href":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/issues/28"},"comments":{"href":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/aeternity/aepp-blockchain-explorer/statuses/0feba0eb9d307a902554edbef368dd2f3a1b8182"}},"author_association":"NONE"}}
{"actor":{"display_login":"sadiqevani"}}