{"action":"closed","issue":{"url":"https://api.github.com/repos/hangoutsbot/hangoutsbot/issues/820","repository_url":"https://api.github.com/repos/hangoutsbot/hangoutsbot","labels_url":"https://api.github.com/repos/hangoutsbot/hangoutsbot/issues/820/labels{/name}","comments_url":"https://api.github.com/repos/hangoutsbot/hangoutsbot/issues/820/comments","events_url":"https://api.github.com/repos/hangoutsbot/hangoutsbot/issues/820/events","html_url":"https://github.com/hangoutsbot/hangoutsbot/issues/820","id":219994386,"node_id":"MDU6SXNzdWUyMTk5OTQzODY=","number":820,"title":"Multi-person mention doesn't catch individual failures","user":{"login":"Terrance","id":4025899,"node_id":"MDQ6VXNlcjQwMjU4OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/4025899?v=4","gravatar_id":"","url":"https://api.github.com/users/Terrance","html_url":"https://github.com/Terrance","followers_url":"https://api.github.com/users/Terrance/followers","following_url":"https://api.github.com/users/Terrance/following{/other_user}","gists_url":"https://api.github.com/users/Terrance/gists{/gist_id}","starred_url":"https://api.github.com/users/Terrance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terrance/subscriptions","organizations_url":"https://api.github.com/users/Terrance/orgs","repos_url":"https://api.github.com/users/Terrance/repos","events_url":"https://api.github.com/users/Terrance/events{/privacy}","received_events_url":"https://api.github.com/users/Terrance/received_events","type":"User","site_admin":false},"labels":[{"id":242762515,"node_id":"MDU6TGFiZWwyNDI3NjI1MTU=","url":"https://api.github.com/repos/hangoutsbot/hangoutsbot/labels/documentation","name":"documentation","color":"84b6eb","default":false},{"id":558269861,"node_id":"MDU6TGFiZWw1NTgyNjk4NjE=","url":"https://api.github.com/repos/hangoutsbot/hangoutsbot/labels/framework","name":"framework","color":"207de5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-04-06T18:42:38Z","updated_at":"2018-12-05T22:43:31Z","closed_at":"2018-12-05T22:43:31Z","author_association":"MEMBER","body":"After using `@all` in a group, towards the end of notifications being sent out:\r\n\r\n```\r\nERROR root: CORO_SEND_MESSAGE: error sending <1-to-1 ho>\r\nTraceback (most recent call last):\r\n  File \"hangoutsbot/hangupsbot/hangupsbot.py\", line 761, in coro_send_message\r\n    context = context )\r\n  File \"hangoutsbot/hangupsbot/hangups_conversation.py\", line 252, in send_message\r\n    expected_otr = otr_status )))\r\n  File \"hangoutsbot/venv/lib/python3.6/site-packages/hangups/client.py\", line 552, in send_chat_message\r\n    send_chat_message_request, response)\r\n  File \"hangoutsbot/venv/lib/python3.6/site-packages/hangups/client.py\", line 379, in _pb_request\r\n    .format(status, description)\r\nhangups.exceptions.NetworkError: Request failed with status 4: 'BlockedUserException SENDER_IS_BLOCKED'\r\n```\r\n\r\nLooks like someone in the hangout has blocked the bot user.  I can't see any exception handling to catch these whilst looping through the users to mention, which means some notifications wouldn't be delivered.\r\n\r\nFor the general case, perhaps it would be prudent to set a flag somewhere on a user, if we fail to send a message to them due to being blocked?"}}
{"actor":{"display_login":"Terrance"}}