{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/208592612","pull_request_review_id":144432511,"id":208592612,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODU5MjYxMg==","diff_hunk":"@@ -18,6 +18,16 @@ let\n     (boolFlag \"secure\" cfg.secure)\n     (boolFlag \"noupnp\" cfg.noUPnP)\n   ];\n+  stopScript = pkgs.writeScript \"terraria-stop\" ''\n+    #!${pkgs.stdenv.runtimeShell}","path":"nixos/modules/services/games/terraria.nix","position":5,"original_position":5,"commit_id":"759ce9b21b06eae18fe8a7370bf73371831985c5","original_commit_id":"759ce9b21b06eae18fe8a7370bf73371831985c5","user":{"login":"joachifm","id":41977,"node_id":"MDQ6VXNlcjQxOTc3","avatar_url":"https://avatars3.githubusercontent.com/u/41977?v=4","gravatar_id":"","url":"https://api.github.com/users/joachifm","html_url":"https://github.com/joachifm","followers_url":"https://api.github.com/users/joachifm/followers","following_url":"https://api.github.com/users/joachifm/following{/other_user}","gists_url":"https://api.github.com/users/joachifm/gists{/gist_id}","starred_url":"https://api.github.com/users/joachifm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joachifm/subscriptions","organizations_url":"https://api.github.com/users/joachifm/orgs","repos_url":"https://api.github.com/users/joachifm/repos","events_url":"https://api.github.com/users/joachifm/events{/privacy}","received_events_url":"https://api.github.com/users/joachifm/received_events","type":"User","site_admin":false},"body":"Typo here, the correct attribute path is `pkgs.runtimeShell`","created_at":"2018-08-08T14:02:31Z","updated_at":"2018-08-08T14:02:31Z","html_url":"https://github.com/NixOS/nixpkgs/pull/44631#discussion_r208592612","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44631","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/208592612"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/44631#discussion_r208592612"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44631"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44631","id":206779707,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2Nzc5NzA3","html_url":"https://github.com/NixOS/nixpkgs/pull/44631","diff_url":"https://github.com/NixOS/nixpkgs/pull/44631.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/44631.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44631","number":44631,"state":"open","locked":false,"title":"nixos/terraria: Wait for daemon to stop","user":{"login":"dasJ","id":4971975,"node_id":"MDQ6VXNlcjQ5NzE5NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/4971975?v=4","gravatar_id":"","url":"https://api.github.com/users/dasJ","html_url":"https://github.com/dasJ","followers_url":"https://api.github.com/users/dasJ/followers","following_url":"https://api.github.com/users/dasJ/following{/other_user}","gists_url":"https://api.github.com/users/dasJ/gists{/gist_id}","starred_url":"https://api.github.com/users/dasJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dasJ/subscriptions","organizations_url":"https://api.github.com/users/dasJ/orgs","repos_url":"https://api.github.com/users/dasJ/repos","events_url":"https://api.github.com/users/dasJ/events{/privacy}","received_events_url":"https://api.github.com/users/dasJ/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nsystemd wasn't waiting for the daemon to exit (because it's asynchronous) and hence killed it without saving the world first.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-08-07T17:58:48Z","updated_at":"2018-08-08T14:02:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ace42eab974bafb193966b7d2378e5452fba1f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"node_id":"MDU6TGFiZWw2MDI2NTIxMg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"node_id":"MDU6TGFiZWwyOTAxMjI4ODQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44631/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44631/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44631/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/759ce9b21b06eae18fe8a7370bf73371831985c5","head":{"label":"dasJ:terraria","ref":"terraria","sha":"759ce9b21b06eae18fe8a7370bf73371831985c5","user":{"login":"dasJ","id":4971975,"node_id":"MDQ6VXNlcjQ5NzE5NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/4971975?v=4","gravatar_id":"","url":"https://api.github.com/users/dasJ","html_url":"https://github.com/dasJ","followers_url":"https://api.github.com/users/dasJ/followers","following_url":"https://api.github.com/users/dasJ/following{/other_user}","gists_url":"https://api.github.com/users/dasJ/gists{/gist_id}","starred_url":"https://api.github.com/users/dasJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dasJ/subscriptions","organizations_url":"https://api.github.com/users/dasJ/orgs","repos_url":"https://api.github.com/users/dasJ/repos","events_url":"https://api.github.com/users/dasJ/events{/privacy}","received_events_url":"https://api.github.com/users/dasJ/received_events","type":"User","site_admin":false},"repo":{"id":128820252,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4MjAyNTI=","name":"nixpkgs","full_name":"dasJ/nixpkgs","owner":{"login":"dasJ","id":4971975,"node_id":"MDQ6VXNlcjQ5NzE5NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/4971975?v=4","gravatar_id":"","url":"https://api.github.com/users/dasJ","html_url":"https://github.com/dasJ","followers_url":"https://api.github.com/users/dasJ/followers","following_url":"https://api.github.com/users/dasJ/following{/other_user}","gists_url":"https://api.github.com/users/dasJ/gists{/gist_id}","starred_url":"https://api.github.com/users/dasJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dasJ/subscriptions","organizations_url":"https://api.github.com/users/dasJ/orgs","repos_url":"https://api.github.com/users/dasJ/repos","events_url":"https://api.github.com/users/dasJ/events{/privacy}","received_events_url":"https://api.github.com/users/dasJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dasJ/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/dasJ/nixpkgs","forks_url":"https://api.github.com/repos/dasJ/nixpkgs/forks","keys_url":"https://api.github.com/repos/dasJ/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dasJ/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dasJ/nixpkgs/teams","hooks_url":"https://api.github.com/repos/dasJ/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/dasJ/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/dasJ/nixpkgs/events","assignees_url":"https://api.github.com/repos/dasJ/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/dasJ/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/dasJ/nixpkgs/tags","blobs_url":"https://api.github.com/repos/dasJ/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dasJ/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dasJ/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dasJ/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dasJ/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/dasJ/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/dasJ/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/dasJ/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/dasJ/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/dasJ/nixpkgs/subscription","commits_url":"https://api.github.com/repos/dasJ/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dasJ/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dasJ/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dasJ/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dasJ/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/dasJ/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dasJ/nixpkgs/merges","archive_url":"https://api.github.com/repos/dasJ/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dasJ/nixpkgs/downloads","issues_url":"https://api.github.com/repos/dasJ/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/dasJ/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/dasJ/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/dasJ/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dasJ/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/dasJ/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/dasJ/nixpkgs/deployments","created_at":"2018-04-09T19:00:51Z","updated_at":"2018-06-04T12:43:19Z","pushed_at":"2018-08-07T21:40:37Z","git_url":"git://github.com/dasJ/nixpkgs.git","ssh_url":"git@github.com:dasJ/nixpkgs.git","clone_url":"https://github.com/dasJ/nixpkgs.git","svn_url":"https://github.com/dasJ/nixpkgs","homepage":null,"size":779779,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"main"}},"base":{"label":"NixOS:master","ref":"master","sha":"676f09be679e3d4d8758356914ef4ae81388bcc5","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-08-08T13:49:47Z","pushed_at":"2018-08-08T14:02:01Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":832156,"stargazers_count":2625,"watchers_count":2625,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2933,"mirror_url":null,"archived":false,"open_issues_count":3094,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2933,"open_issues":3094,"watchers":2625,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44631"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/44631"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44631"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44631/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44631/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44631/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/759ce9b21b06eae18fe8a7370bf73371831985c5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joachifm"}}