{"action":"created","comment":{"url":"https://api.github.com/repos/TheDevPath/Navi/pulls/comments/176581880","pull_request_review_id":106313532,"id":176581880,"diff_hunk":"@@ -41,11 +49,16 @@\n         \"eslint-plugin-react-compat\": \"0.0.3\",\n         \"if-env\": \"^1.0.0\",\n         \"ignore-styles\": \"^5.0.1\",\n+        \"jest\": \"^22.4.2\",\n+        \"jest-css-modules\": \"^1.1.0\",\n         \"mocha\": \"^5.0.0\",\n         \"preact-cli\": \"^2.0.1\",\n         \"preact-cli-sw-precache\": \"^1.0.3\",\n+        \"preact-compat-enzyme\": \"^0.2.5\",\n         \"preact-jsx-chai\": \"^2.2.1\",","path":"client/package.json","position":19,"original_position":44,"commit_id":"a4439b8f626d38fe1449ae93875ca301a215205f","original_commit_id":"955c1543f0e5ea2367113e8cc895a25da31c4405","user":{"login":"motosharpley","id":17731807,"avatar_url":"https://avatars1.githubusercontent.com/u/17731807?v=4","gravatar_id":"","url":"https://api.github.com/users/motosharpley","html_url":"https://github.com/motosharpley","followers_url":"https://api.github.com/users/motosharpley/followers","following_url":"https://api.github.com/users/motosharpley/following{/other_user}","gists_url":"https://api.github.com/users/motosharpley/gists{/gist_id}","starred_url":"https://api.github.com/users/motosharpley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/motosharpley/subscriptions","organizations_url":"https://api.github.com/users/motosharpley/orgs","repos_url":"https://api.github.com/users/motosharpley/repos","events_url":"https://api.github.com/users/motosharpley/events{/privacy}","received_events_url":"https://api.github.com/users/motosharpley/received_events","type":"User","site_admin":false},"body":"I was referring to  preact-jsx-chai here, probably mocha and chai could go at this point too ","created_at":"2018-03-22T21:45:57Z","updated_at":"2018-03-22T21:45:57Z","html_url":"https://github.com/TheDevPath/Navi/pull/261#discussion_r176581880","pull_request_url":"https://api.github.com/repos/TheDevPath/Navi/pulls/261","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/TheDevPath/Navi/pulls/comments/176581880"},"html":{"href":"https://github.com/TheDevPath/Navi/pull/261#discussion_r176581880"},"pull_request":{"href":"https://api.github.com/repos/TheDevPath/Navi/pulls/261"}},"in_reply_to_id":176465002},"pull_request":{"url":"https://api.github.com/repos/TheDevPath/Navi/pulls/261","id":176059655,"html_url":"https://github.com/TheDevPath/Navi/pull/261","diff_url":"https://github.com/TheDevPath/Navi/pull/261.diff","patch_url":"https://github.com/TheDevPath/Navi/pull/261.patch","issue_url":"https://api.github.com/repos/TheDevPath/Navi/issues/261","number":261,"state":"open","locked":false,"title":"add testing and remove _PATH environment variables","user":{"login":"seckboy","id":6200031,"avatar_url":"https://avatars3.githubusercontent.com/u/6200031?v=4","gravatar_id":"","url":"https://api.github.com/users/seckboy","html_url":"https://github.com/seckboy","followers_url":"https://api.github.com/users/seckboy/followers","following_url":"https://api.github.com/users/seckboy/following{/other_user}","gists_url":"https://api.github.com/users/seckboy/gists{/gist_id}","starred_url":"https://api.github.com/users/seckboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seckboy/subscriptions","organizations_url":"https://api.github.com/users/seckboy/orgs","repos_url":"https://api.github.com/users/seckboy/repos","events_url":"https://api.github.com/users/seckboy/events{/privacy}","received_events_url":"https://api.github.com/users/seckboy/received_events","type":"User","site_admin":false},"body":"## Issue Number:\r\n214\r\n\r\n## Issue Description:\r\nAdd client testing - also removed _PATH variables from environment variables.\r\n\r\n### Summary of solution:\r\n1. Used Jest and Enzyme\r\n2. Replaced _PATH variables with BASE_ENDPOINTS from server-request-utils.js\r\n3. \r\n\r\n### Can this issue be closed?\r\nYes\r\n\r\n### Should any new issues be added as a result of this solution?\r\nYes - create tests for other components and js/utilities\r\n\r\n### Have you named your branch in a descriptive way? Remember to name your branch in a unique and descriptive manner in order to properly reflect the issue or feature.\r\nIt is named enzyme-jest-testing\r\n\r\n### Thanks for contributing!\r\n","created_at":"2018-03-20T00:23:20Z","updated_at":"2018-03-22T21:45:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76cc621074d44d6b61f171e152425b728967375d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":808479707,"url":"https://api.github.com/repos/TheDevPath/Navi/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TheDevPath/Navi/pulls/261/commits","review_comments_url":"https://api.github.com/repos/TheDevPath/Navi/pulls/261/comments","review_comment_url":"https://api.github.com/repos/TheDevPath/Navi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TheDevPath/Navi/issues/261/comments","statuses_url":"https://api.github.com/repos/TheDevPath/Navi/statuses/a4439b8f626d38fe1449ae93875ca301a215205f","head":{"label":"seckboy:enzyme-jest-testing","ref":"enzyme-jest-testing","sha":"a4439b8f626d38fe1449ae93875ca301a215205f","user":{"login":"seckboy","id":6200031,"avatar_url":"https://avatars3.githubusercontent.com/u/6200031?v=4","gravatar_id":"","url":"https://api.github.com/users/seckboy","html_url":"https://github.com/seckboy","followers_url":"https://api.github.com/users/seckboy/followers","following_url":"https://api.github.com/users/seckboy/following{/other_user}","gists_url":"https://api.github.com/users/seckboy/gists{/gist_id}","starred_url":"https://api.github.com/users/seckboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seckboy/subscriptions","organizations_url":"https://api.github.com/users/seckboy/orgs","repos_url":"https://api.github.com/users/seckboy/repos","events_url":"https://api.github.com/users/seckboy/events{/privacy}","received_events_url":"https://api.github.com/users/seckboy/received_events","type":"User","site_admin":false},"repo":{"id":120117839,"name":"googleMaps-offline-navigator","full_name":"seckboy/googleMaps-offline-navigator","owner":{"login":"seckboy","id":6200031,"avatar_url":"https://avatars3.githubusercontent.com/u/6200031?v=4","gravatar_id":"","url":"https://api.github.com/users/seckboy","html_url":"https://github.com/seckboy","followers_url":"https://api.github.com/users/seckboy/followers","following_url":"https://api.github.com/users/seckboy/following{/other_user}","gists_url":"https://api.github.com/users/seckboy/gists{/gist_id}","starred_url":"https://api.github.com/users/seckboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seckboy/subscriptions","organizations_url":"https://api.github.com/users/seckboy/orgs","repos_url":"https://api.github.com/users/seckboy/repos","events_url":"https://api.github.com/users/seckboy/events{/privacy}","received_events_url":"https://api.github.com/users/seckboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seckboy/googleMaps-offline-navigator","description":"Open source project for Grow with Google Udacity Scholarship Challenge - Navigation app using offline first strategy and google maps api","fork":true,"url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator","forks_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/forks","keys_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/teams","hooks_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/hooks","issue_events_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/issues/events{/number}","events_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/events","assignees_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/assignees{/user}","branches_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/branches{/branch}","tags_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/tags","blobs_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/git/refs{/sha}","trees_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/statuses/{sha}","languages_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/languages","stargazers_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/stargazers","contributors_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/contributors","subscribers_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/subscribers","subscription_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/subscription","commits_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/commits{/sha}","git_commits_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/git/commits{/sha}","comments_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/comments{/number}","issue_comment_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/issues/comments{/number}","contents_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/contents/{+path}","compare_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/merges","archive_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/downloads","issues_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/issues{/number}","pulls_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/pulls{/number}","milestones_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/milestones{/number}","notifications_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/labels{/name}","releases_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/releases{/id}","deployments_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/deployments","created_at":"2018-02-03T18:24:59Z","updated_at":"2018-03-18T18:27:32Z","pushed_at":"2018-03-22T19:57:56Z","git_url":"git://github.com/seckboy/googleMaps-offline-navigator.git","ssh_url":"git@github.com:seckboy/googleMaps-offline-navigator.git","clone_url":"https://github.com/seckboy/googleMaps-offline-navigator.git","svn_url":"https://github.com/seckboy/googleMaps-offline-navigator","homepage":null,"size":3441,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"TheDevPath:development","ref":"development","sha":"62f0eb340f1467e6dd7ec0cc1317d52e9503897b","user":{"login":"TheDevPath","id":34627465,"avatar_url":"https://avatars0.githubusercontent.com/u/34627465?v=4","gravatar_id":"","url":"https://api.github.com/users/TheDevPath","html_url":"https://github.com/TheDevPath","followers_url":"https://api.github.com/users/TheDevPath/followers","following_url":"https://api.github.com/users/TheDevPath/following{/other_user}","gists_url":"https://api.github.com/users/TheDevPath/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDevPath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDevPath/subscriptions","organizations_url":"https://api.github.com/users/TheDevPath/orgs","repos_url":"https://api.github.com/users/TheDevPath/repos","events_url":"https://api.github.com/users/TheDevPath/events{/privacy}","received_events_url":"https://api.github.com/users/TheDevPath/received_events","type":"Organization","site_admin":false},"repo":{"id":117900050,"name":"Navi","full_name":"TheDevPath/Navi","owner":{"login":"TheDevPath","id":34627465,"avatar_url":"https://avatars0.githubusercontent.com/u/34627465?v=4","gravatar_id":"","url":"https://api.github.com/users/TheDevPath","html_url":"https://github.com/TheDevPath","followers_url":"https://api.github.com/users/TheDevPath/followers","following_url":"https://api.github.com/users/TheDevPath/following{/other_user}","gists_url":"https://api.github.com/users/TheDevPath/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDevPath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDevPath/subscriptions","organizations_url":"https://api.github.com/users/TheDevPath/orgs","repos_url":"https://api.github.com/users/TheDevPath/repos","events_url":"https://api.github.com/users/TheDevPath/events{/privacy}","received_events_url":"https://api.github.com/users/TheDevPath/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheDevPath/Navi","description":"Open Source Project for Grow with Google Udacity Scholarship Challenge - Navigation app using offline first strategy and google maps api - To get started please refer to the README.md - CONTRIBUTING.md and the project Wiki","fork":false,"url":"https://api.github.com/repos/TheDevPath/Navi","forks_url":"https://api.github.com/repos/TheDevPath/Navi/forks","keys_url":"https://api.github.com/repos/TheDevPath/Navi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheDevPath/Navi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheDevPath/Navi/teams","hooks_url":"https://api.github.com/repos/TheDevPath/Navi/hooks","issue_events_url":"https://api.github.com/repos/TheDevPath/Navi/issues/events{/number}","events_url":"https://api.github.com/repos/TheDevPath/Navi/events","assignees_url":"https://api.github.com/repos/TheDevPath/Navi/assignees{/user}","branches_url":"https://api.github.com/repos/TheDevPath/Navi/branches{/branch}","tags_url":"https://api.github.com/repos/TheDevPath/Navi/tags","blobs_url":"https://api.github.com/repos/TheDevPath/Navi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheDevPath/Navi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheDevPath/Navi/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheDevPath/Navi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheDevPath/Navi/statuses/{sha}","languages_url":"https://api.github.com/repos/TheDevPath/Navi/languages","stargazers_url":"https://api.github.com/repos/TheDevPath/Navi/stargazers","contributors_url":"https://api.github.com/repos/TheDevPath/Navi/contributors","subscribers_url":"https://api.github.com/repos/TheDevPath/Navi/subscribers","subscription_url":"https://api.github.com/repos/TheDevPath/Navi/subscription","commits_url":"https://api.github.com/repos/TheDevPath/Navi/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheDevPath/Navi/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheDevPath/Navi/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheDevPath/Navi/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheDevPath/Navi/contents/{+path}","compare_url":"https://api.github.com/repos/TheDevPath/Navi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheDevPath/Navi/merges","archive_url":"https://api.github.com/repos/TheDevPath/Navi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheDevPath/Navi/downloads","issues_url":"https://api.github.com/repos/TheDevPath/Navi/issues{/number}","pulls_url":"https://api.github.com/repos/TheDevPath/Navi/pulls{/number}","milestones_url":"https://api.github.com/repos/TheDevPath/Navi/milestones{/number}","notifications_url":"https://api.github.com/repos/TheDevPath/Navi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheDevPath/Navi/labels{/name}","releases_url":"https://api.github.com/repos/TheDevPath/Navi/releases{/id}","deployments_url":"https://api.github.com/repos/TheDevPath/Navi/deployments","created_at":"2018-01-17T22:23:57Z","updated_at":"2018-03-22T21:03:14Z","pushed_at":"2018-03-22T21:03:12Z","git_url":"git://github.com/TheDevPath/Navi.git","ssh_url":"git@github.com:TheDevPath/Navi.git","clone_url":"https://github.com/TheDevPath/Navi.git","svn_url":"https://github.com/TheDevPath/Navi","homepage":"","size":7002,"stargazers_count":43,"watchers_count":43,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":66,"open_issues":17,"watchers":43,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/TheDevPath/Navi/pulls/261"},"html":{"href":"https://github.com/TheDevPath/Navi/pull/261"},"issue":{"href":"https://api.github.com/repos/TheDevPath/Navi/issues/261"},"comments":{"href":"https://api.github.com/repos/TheDevPath/Navi/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/TheDevPath/Navi/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/TheDevPath/Navi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TheDevPath/Navi/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/TheDevPath/Navi/statuses/a4439b8f626d38fe1449ae93875ca301a215205f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"motosharpley"}}