{"action":"reopened","issue":{"url":"https://api.github.com/repos/tmont/sunlight/issues/24","repository_url":"https://api.github.com/repos/tmont/sunlight","labels_url":"https://api.github.com/repos/tmont/sunlight/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/tmont/sunlight/issues/24/comments","events_url":"https://api.github.com/repos/tmont/sunlight/issues/24/events","html_url":"https://github.com/tmont/sunlight/issues/24","id":287736284,"number":24,"title":"Javascript new ES6 identifiers are not handled as such","user":{"login":"jr-grenoble","id":24454054,"avatar_url":"https://avatars1.githubusercontent.com/u/24454054?v=4","gravatar_id":"","url":"https://api.github.com/users/jr-grenoble","html_url":"https://github.com/jr-grenoble","followers_url":"https://api.github.com/users/jr-grenoble/followers","following_url":"https://api.github.com/users/jr-grenoble/following{/other_user}","gists_url":"https://api.github.com/users/jr-grenoble/gists{/gist_id}","starred_url":"https://api.github.com/users/jr-grenoble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jr-grenoble/subscriptions","organizations_url":"https://api.github.com/users/jr-grenoble/orgs","repos_url":"https://api.github.com/users/jr-grenoble/repos","events_url":"https://api.github.com/users/jr-grenoble/events{/privacy}","received_events_url":"https://api.github.com/users/jr-grenoble/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-01-11T10:31:15Z","updated_at":"2018-02-03T11:29:37Z","closed_at":null,"author_association":"NONE","body":"There are 2 issues related to ES6 identifiers:\r\n\r\n1. In ES6, identifiers are less constrained than in ES5. For instance, you can define a class method named 𑀓ꘌ where 𑀓 is the Brahmi letter Ka \\u{11013} and ꘌ is the Vai syllable lengthener \\u{a60c}.\r\nNote that you can [check](https://mothereff.in/js-variables) that 𑀓ꘌ is a valid ES6 identifier. Mathias Bynens from Google has created a [script](https://mathiasbynens.be/demo/javascript-identifier-regex) that generates the proper regex for ES6 (and ES5) identifiers. \r\n\r\nHowever, the Sunlight javascript rules for syntax highlighting do not handle such identifiers properly and treat them as punctuation, e.g. `d.𑀓ꘌ ( { days: 7 } );` will display with 𑀓 and ꘌ highlighted as sunlight-punctuation.\r\n\r\n2. It also seems that the processing of such characters discards some of them: they appear as � in the resulting code. E.g. this is the case for Brahmi letter Ka 𑀓. \r\n\r\nIt is not a font issue, as Consolas is capable of displaying this letter.\r\n\r\nNote that there are other UTF-8 characters that exhibit this second issue, this is only an example."}}
{"actor":{"display_login":"jr-grenoble"}}