{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/27004","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/27004/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/27004/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/27004/events","html_url":"https://github.com/elastic/elasticsearch/issues/27004","id":265262079,"number":27004,"title":"Add size-based check to rollover API","user":{"login":"clintongormley","id":56599,"avatar_url":"https://avatars0.githubusercontent.com/u/56599?v=4","gravatar_id":"","url":"https://api.github.com/users/clintongormley","html_url":"https://github.com/clintongormley","followers_url":"https://api.github.com/users/clintongormley/followers","following_url":"https://api.github.com/users/clintongormley/following{/other_user}","gists_url":"https://api.github.com/users/clintongormley/gists{/gist_id}","starred_url":"https://api.github.com/users/clintongormley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintongormley/subscriptions","organizations_url":"https://api.github.com/users/clintongormley/orgs","repos_url":"https://api.github.com/users/clintongormley/repos","events_url":"https://api.github.com/users/clintongormley/events{/privacy}","received_events_url":"https://api.github.com/users/clintongormley/received_events","type":"User","site_admin":false},"labels":[{"id":163824881,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Core/Index%20APIs","name":":Core/Index APIs","color":"0e8a16","default":false},{"id":23174,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Eenhancement","name":">enhancement","color":"4a4ea8","default":false}],"state":"closed","locked":false,"assignee":{"login":"dnhatn","id":13474362,"avatar_url":"https://avatars3.githubusercontent.com/u/13474362?v=4","gravatar_id":"","url":"https://api.github.com/users/dnhatn","html_url":"https://github.com/dnhatn","followers_url":"https://api.github.com/users/dnhatn/followers","following_url":"https://api.github.com/users/dnhatn/following{/other_user}","gists_url":"https://api.github.com/users/dnhatn/gists{/gist_id}","starred_url":"https://api.github.com/users/dnhatn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnhatn/subscriptions","organizations_url":"https://api.github.com/users/dnhatn/orgs","repos_url":"https://api.github.com/users/dnhatn/repos","events_url":"https://api.github.com/users/dnhatn/events{/privacy}","received_events_url":"https://api.github.com/users/dnhatn/received_events","type":"User","site_admin":false},"assignees":[{"login":"dnhatn","id":13474362,"avatar_url":"https://avatars3.githubusercontent.com/u/13474362?v=4","gravatar_id":"","url":"https://api.github.com/users/dnhatn","html_url":"https://github.com/dnhatn","followers_url":"https://api.github.com/users/dnhatn/followers","following_url":"https://api.github.com/users/dnhatn/following{/other_user}","gists_url":"https://api.github.com/users/dnhatn/gists{/gist_id}","starred_url":"https://api.github.com/users/dnhatn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnhatn/subscriptions","organizations_url":"https://api.github.com/users/dnhatn/orgs","repos_url":"https://api.github.com/users/dnhatn/repos","events_url":"https://api.github.com/users/dnhatn/events{/privacy}","received_events_url":"https://api.github.com/users/dnhatn/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2017-10-13T11:49:42Z","updated_at":"2018-04-20T04:00:07Z","closed_at":"2017-11-04T23:51:49Z","author_association":"OWNER","body":"Initially, we added just a doc-count and date-based check to the rollover API.  We avoided a size-based check because it could be wildly inaccurate if multiple merges are in progress on different shards of the index.\r\n\r\nWe could make a more reasonable estimation by converting from segment sizes to # of docs which makes us less prone to merges etc. Could we sample the avg doc size on disk from existing docs and make the decision ultimately based on docs?"},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/382967564","html_url":"https://github.com/elastic/elasticsearch/issues/27004#issuecomment-382967564","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/27004","id":382967564,"user":{"login":"diranged","id":768067,"avatar_url":"https://avatars0.githubusercontent.com/u/768067?v=4","gravatar_id":"","url":"https://api.github.com/users/diranged","html_url":"https://github.com/diranged","followers_url":"https://api.github.com/users/diranged/followers","following_url":"https://api.github.com/users/diranged/following{/other_user}","gists_url":"https://api.github.com/users/diranged/gists{/gist_id}","starred_url":"https://api.github.com/users/diranged/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diranged/subscriptions","organizations_url":"https://api.github.com/users/diranged/orgs","repos_url":"https://api.github.com/users/diranged/repos","events_url":"https://api.github.com/users/diranged/events{/privacy}","received_events_url":"https://api.github.com/users/diranged/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T04:00:07Z","updated_at":"2018-04-20T04:00:07Z","author_association":"NONE","body":"@dnhatn,\r\n  I'm trying this feature out in ES 6.2.3 and I'm getting strange results. On an index (50 shards, 1 replica) that had an index_size_in_bytes of ~1.2TB, and with a `max_size: 1024gb` setting, ES chose not to do the rollover. If I dropped the `max_size` setting to `768gb`, it did the rollover. I know that the max_size calculation isn't perfect - but its also not well documented right now as to exactly what its calculating against. Can you help clarify that?"}}
{"actor":{"display_login":"diranged"}}