{"action":"closed","number":19373,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/19373","id":175285399,"html_url":"https://github.com/nodejs/node/pull/19373","diff_url":"https://github.com/nodejs/node/pull/19373.diff","patch_url":"https://github.com/nodejs/node/pull/19373.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/19373","number":19373,"state":"closed","locked":false,"title":"lib: finish assigning codes to errors thrown from JS","user":{"login":"targos","id":2352663,"avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-03-15T15:21:05Z","updated_at":"2018-03-21T19:20:11Z","closed_at":"2018-03-21T19:20:11Z","merged_at":null,"merge_commit_sha":"5702a31a13dfca6342a38ed78ee783bf52b7b395","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":458724661,"url":"https://api.github.com/repos/nodejs/node/labels/errors","name":"errors","color":"ededed","default":false},{"id":281232761,"url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false},{"id":169485514,"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/19373/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/19373/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/19373/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/957c493bd627aa64d3bdb570827c4a9c78e635b7","head":{"label":"targos:finish-lib-error-codes","ref":"finish-lib-error-codes","sha":"957c493bd627aa64d3bdb570827c4a9c78e635b7","user":{"login":"targos","id":2352663,"avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"repo":{"id":29471300,"name":"node","full_name":"targos/node","owner":{"login":"targos","id":2352663,"avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/targos/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/targos/node","forks_url":"https://api.github.com/repos/targos/node/forks","keys_url":"https://api.github.com/repos/targos/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/targos/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/targos/node/teams","hooks_url":"https://api.github.com/repos/targos/node/hooks","issue_events_url":"https://api.github.com/repos/targos/node/issues/events{/number}","events_url":"https://api.github.com/repos/targos/node/events","assignees_url":"https://api.github.com/repos/targos/node/assignees{/user}","branches_url":"https://api.github.com/repos/targos/node/branches{/branch}","tags_url":"https://api.github.com/repos/targos/node/tags","blobs_url":"https://api.github.com/repos/targos/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/targos/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/targos/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/targos/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/targos/node/statuses/{sha}","languages_url":"https://api.github.com/repos/targos/node/languages","stargazers_url":"https://api.github.com/repos/targos/node/stargazers","contributors_url":"https://api.github.com/repos/targos/node/contributors","subscribers_url":"https://api.github.com/repos/targos/node/subscribers","subscription_url":"https://api.github.com/repos/targos/node/subscription","commits_url":"https://api.github.com/repos/targos/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/targos/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/targos/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/targos/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/targos/node/contents/{+path}","compare_url":"https://api.github.com/repos/targos/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/targos/node/merges","archive_url":"https://api.github.com/repos/targos/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/targos/node/downloads","issues_url":"https://api.github.com/repos/targos/node/issues{/number}","pulls_url":"https://api.github.com/repos/targos/node/pulls{/number}","milestones_url":"https://api.github.com/repos/targos/node/milestones{/number}","notifications_url":"https://api.github.com/repos/targos/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/targos/node/labels{/name}","releases_url":"https://api.github.com/repos/targos/node/releases{/id}","deployments_url":"https://api.github.com/repos/targos/node/deployments","created_at":"2015-01-19T13:07:04Z","updated_at":"2018-03-21T18:07:06Z","pushed_at":"2018-03-21T19:12:21Z","git_url":"git://github.com/targos/node.git","ssh_url":"git@github.com:targos/node.git","clone_url":"https://github.com/targos/node.git","svn_url":"https://github.com/targos/node","homepage":"https://nodejs.org","size":338517,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"3662934b5ac9002586676fdec662bea957144b34","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-03-21T19:19:57Z","pushed_at":"2018-03-21T19:19:54Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":357838,"stargazers_count":46647,"watchers_count":46647,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9777,"mirror_url":null,"archived":false,"open_issues_count":871,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9777,"open_issues":871,"watchers":46647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/19373"},"html":{"href":"https://github.com/nodejs/node/pull/19373"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/19373"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/19373/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/19373/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/19373/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/957c493bd627aa64d3bdb570827c4a9c78e635b7"}},"author_association":"OWNER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":7,"review_comments":20,"maintainer_can_modify":false,"commits":2,"additions":71,"deletions":19,"changed_files":21}}
{"actor":{"display_login":"targos"}}