{"action":"created","issue":{"url":"https://api.github.com/repos/GafferHQ/gaffer/issues/2730","repository_url":"https://api.github.com/repos/GafferHQ/gaffer","labels_url":"https://api.github.com/repos/GafferHQ/gaffer/issues/2730/labels{/name}","comments_url":"https://api.github.com/repos/GafferHQ/gaffer/issues/2730/comments","events_url":"https://api.github.com/repos/GafferHQ/gaffer/issues/2730/events","html_url":"https://github.com/GafferHQ/gaffer/pull/2730","id":349470487,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTc2ODc4","number":2730,"title":"appleseed: fix object instance interactive updates","user":{"login":"est77","id":409013,"node_id":"MDQ6VXNlcjQwOTAxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/409013?v=4","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-08-10T10:54:59Z","updated_at":"2018-09-07T10:53:48Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/GafferHQ/gaffer/pulls/2730","html_url":"https://github.com/GafferHQ/gaffer/pull/2730","diff_url":"https://github.com/GafferHQ/gaffer/pull/2730.diff","patch_url":"https://github.com/GafferHQ/gaffer/pull/2730.patch"},"body":"Proposed fix for appleseed IPR crashes or wrong material assignments when shaders are disconnected.\r\nAlso fixed interactive editing of object visibility flags. \r\n\r\n### Related Issues ###\r\n\r\nFixes #2700\r\n\r\n### Checklist ###\r\n\r\n- [x] I have read the [contribution guidelines](https://github.com/GafferHQ/gaffer/blob/master/CONTRIBUTING.md).\r\n- [x] I have updated the documentation, if applicable.\r\n- [x] I have tested my change(s) in the test suite, and added new test cases where necessary.\r\n- [x] My code follows the Gaffer project's prevailing coding style and conventions.\r\n"},"comment":{"url":"https://api.github.com/repos/GafferHQ/gaffer/issues/comments/419403507","html_url":"https://github.com/GafferHQ/gaffer/pull/2730#issuecomment-419403507","issue_url":"https://api.github.com/repos/GafferHQ/gaffer/issues/2730","id":419403507,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTQwMzUwNw==","user":{"login":"est77","id":409013,"node_id":"MDQ6VXNlcjQwOTAxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/409013?v=4","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T10:53:48Z","updated_at":"2018-09-07T10:53:48Z","author_association":"MEMBER","body":"> What should we do with this PR?\r\n\r\nI think I'll close it and add the fix to the update.\r\n\r\nOne of the changes I am doing is introducing a smart pointer class that automatically handles \r\nthe insert entity into a container / get_by_name pattern that we use everywhere in Gafferseed."}}
{"actor":{"display_login":"est77"}}