{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/195288531","pull_request_review_id":128625450,"id":195288531,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTI4ODUzMQ==","diff_hunk":"@@ -84,7 +84,7 @@ $ wget https://bootstrap.pypa.io/get-pip.py && sudo python get-pip.py\n **Step 2** Install MXNet with OpenBLAS acceleration.\n \n ```bash\n-$ pip install mxnet\n+$ sudo pip install mxnet","path":"docs/install/index.md","position":5,"original_position":5,"commit_id":"c09c679e0b41fbb69d695190dd131b358c927ff5","original_commit_id":"fc729007f5e6467d4462a62f4649fecd954b0a71","user":{"login":"mbaijal","id":30911248,"node_id":"MDQ6VXNlcjMwOTExMjQ4","avatar_url":"https://avatars1.githubusercontent.com/u/30911248?v=4","gravatar_id":"","url":"https://api.github.com/users/mbaijal","html_url":"https://github.com/mbaijal","followers_url":"https://api.github.com/users/mbaijal/followers","following_url":"https://api.github.com/users/mbaijal/following{/other_user}","gists_url":"https://api.github.com/users/mbaijal/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaijal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaijal/subscriptions","organizations_url":"https://api.github.com/users/mbaijal/orgs","repos_url":"https://api.github.com/users/mbaijal/repos","events_url":"https://api.github.com/users/mbaijal/events{/privacy}","received_events_url":"https://api.github.com/users/mbaijal/received_events","type":"User","site_admin":false},"body":"I do not have an exact answer to this. The test fails without a sudo. ","created_at":"2018-06-14T02:35:05Z","updated_at":"2018-06-14T02:35:05Z","html_url":"https://github.com/apache/incubator-mxnet/pull/10827#discussion_r195288531","pull_request_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10827","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/195288531"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/10827#discussion_r195288531"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10827"}},"in_reply_to_id":186579497},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10827","id":186187520,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2MTg3NTIw","html_url":"https://github.com/apache/incubator-mxnet/pull/10827","diff_url":"https://github.com/apache/incubator-mxnet/pull/10827.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/10827.patch","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/10827","number":10827,"state":"open","locked":false,"title":"[MXNET-405][WIP] Add 2 new pipelines to the Official CI and run nightly tests. ","user":{"login":"mbaijal","id":30911248,"node_id":"MDQ6VXNlcjMwOTExMjQ4","avatar_url":"https://avatars1.githubusercontent.com/u/30911248?v=4","gravatar_id":"","url":"https://api.github.com/users/mbaijal","html_url":"https://github.com/mbaijal","followers_url":"https://api.github.com/users/mbaijal/followers","following_url":"https://api.github.com/users/mbaijal/following{/other_user}","gists_url":"https://api.github.com/users/mbaijal/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaijal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaijal/subscriptions","organizations_url":"https://api.github.com/users/mbaijal/orgs","repos_url":"https://api.github.com/users/mbaijal/repos","events_url":"https://api.github.com/users/mbaijal/events{/privacy}","received_events_url":"https://api.github.com/users/mbaijal/received_events","type":"User","site_admin":false},"body":"## Description ##\r\n@marcoabreu @gautamkmr Can you please review !\r\n\r\nThis PR does the following:\r\n1. Added 2 new Jenkins pipeline jobs - one which runs tests on MXNet Source and other which runs tests on MXNet Binaries. \r\n2. Several tests were running nightly on a local jenkins setup. I have modified these tests to the new format so they now run as a part of the new jenkinsfiles on the official CI\r\n3. I have not modified any tests themselves but have only modified the design/format so that they run as a pipeline\r\n4. This provides an easy mechanism for any one to add long running tests to run as a part of the nightly pipelines. \r\n\r\nWhile reviewing this code, you can look at this link where these pipelines are currently running on my local repo:\r\nhttp://jenkins.mxnet-ci.amazon-ml.com/view/Nightly%20Tests/\r\n\r\n## Checklist ##\r\n### Essentials ###\r\nPlease feel free to remove inapplicable items for your PR.\r\n- [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)\r\n- [ ] Changes are complete (i.e. I finished coding on this PR)\r\n- [x] All changes have test coverage:\r\n- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)\r\n- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)\r\n- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)\r\n- [x] Code is well-documented: \r\n- For user-facing API changes, API doc string has been updated. \r\n- For new C++ functions in header files, their functionalities and arguments are documented. \r\n- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable\r\n- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html\r\n- [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change\r\n\r\n### Changes ###\r\n- [x] Created a new Jenkinsfile to run nightly tests on source\r\n- [x] Created a new Jenkinsfile to run nightly tests on mxnet binaries\r\n- [x] Made some changes to a few test scripts to make them compatible with the new CI design (Image classification, compilation warnings, Installation guide etc)\r\n- [x] Added RAT check as a nightly test with a post run check on the logs\r\n- [x] Added new dockerfiles for some tests as needed (for example the JS test and Install guide)\r\n- [x] Added appropriate install scripts where needed for the newly added dockerfiles \r\n- [ ] Added Readmes/comments where necessary\r\n- [x] Fix Pip Install test\r\n- [ ] Add an instance with 4 GPUs and then uncomment the KVstore test\r\n\r\n## Comments ##\r\nTo the best of my knowledge, the 3 tests that I have changed are not being run elsewhere/ standalone and hence should not cause any regressions. \r\nTo Do:\r\n1. Need to remove pip test from the source pipeline - it is deprecated\r\n2. There is a potential install issue that I need to test (build from source on a cpu only instance)","created_at":"2018-05-06T04:20:27Z","updated_at":"2018-06-14T02:35:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e60c8c595d6df5b317a13e635deab564991d0c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10827/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10827/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/10827/comments","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/c09c679e0b41fbb69d695190dd131b358c927ff5","head":{"label":"mbaijal:NightlyTestMigration_PR","ref":"NightlyTestMigration_PR","sha":"c09c679e0b41fbb69d695190dd131b358c927ff5","user":{"login":"mbaijal","id":30911248,"node_id":"MDQ6VXNlcjMwOTExMjQ4","avatar_url":"https://avatars1.githubusercontent.com/u/30911248?v=4","gravatar_id":"","url":"https://api.github.com/users/mbaijal","html_url":"https://github.com/mbaijal","followers_url":"https://api.github.com/users/mbaijal/followers","following_url":"https://api.github.com/users/mbaijal/following{/other_user}","gists_url":"https://api.github.com/users/mbaijal/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaijal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaijal/subscriptions","organizations_url":"https://api.github.com/users/mbaijal/orgs","repos_url":"https://api.github.com/users/mbaijal/repos","events_url":"https://api.github.com/users/mbaijal/events{/privacy}","received_events_url":"https://api.github.com/users/mbaijal/received_events","type":"User","site_admin":false},"repo":{"id":100059674,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAwNTk2NzQ=","name":"incubator-mxnet","full_name":"mbaijal/incubator-mxnet","owner":{"login":"mbaijal","id":30911248,"node_id":"MDQ6VXNlcjMwOTExMjQ4","avatar_url":"https://avatars1.githubusercontent.com/u/30911248?v=4","gravatar_id":"","url":"https://api.github.com/users/mbaijal","html_url":"https://github.com/mbaijal","followers_url":"https://api.github.com/users/mbaijal/followers","following_url":"https://api.github.com/users/mbaijal/following{/other_user}","gists_url":"https://api.github.com/users/mbaijal/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaijal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaijal/subscriptions","organizations_url":"https://api.github.com/users/mbaijal/orgs","repos_url":"https://api.github.com/users/mbaijal/repos","events_url":"https://api.github.com/users/mbaijal/events{/privacy}","received_events_url":"https://api.github.com/users/mbaijal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbaijal/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/mbaijal/incubator-mxnet","forks_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/mbaijal/incubator-mxnet/deployments","created_at":"2017-08-11T18:21:16Z","updated_at":"2018-06-11T22:12:21Z","pushed_at":"2018-06-14T02:19:09Z","git_url":"git://github.com/mbaijal/incubator-mxnet.git","ssh_url":"git@github.com:mbaijal/incubator-mxnet.git","clone_url":"https://github.com/mbaijal/incubator-mxnet.git","svn_url":"https://github.com/mbaijal/incubator-mxnet","homepage":"http://mxnet.io","size":38124,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":14,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"14275a5b5b271024ed7d3a1e3afa04edb4bbd86e","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"node_id":"MDEwOlJlcG9zaXRvcnkzNDg2NDQwMg==","name":"incubator-mxnet","full_name":"apache/incubator-mxnet","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/apache/incubator-mxnet","forks_url":"https://api.github.com/repos/apache/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/apache/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/apache/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/apache/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/apache/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/apache/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/apache/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2018-06-14T01:38:33Z","pushed_at":"2018-06-14T02:29:05Z","git_url":"git://github.com/apache/incubator-mxnet.git","ssh_url":"git@github.com:apache/incubator-mxnet.git","clone_url":"https://github.com/apache/incubator-mxnet.git","svn_url":"https://github.com/apache/incubator-mxnet","homepage":"https://mxnet.apache.org","size":37249,"stargazers_count":14176,"watchers_count":14176,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5224,"mirror_url":null,"archived":false,"open_issues_count":969,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5224,"open_issues":969,"watchers":14176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10827"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/10827"},"issue":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/10827"},"comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/10827/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10827/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10827/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-mxnet/statuses/c09c679e0b41fbb69d695190dd131b358c927ff5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mbaijal"}}