{"action":"created","comment":{"url":"https://api.github.com/repos/vanniktech/Emoji/pulls/comments/183463889","pull_request_review_id":114466664,"id":183463889,"diff_hunk":"@@ -149,15 +154,21 @@ public void toggle() {\n       if (isKeyboardOpen) {\n         // If the keyboard is visible, simply show the emoji popup.\n         showAtBottom();\n-      } else {\n+      } else if (editInterface instanceof View) {\n+        /* Uses properties unique to certain Android classes (those that inherit from\n+          android.view.View */\n+\n         // Open the text keyboard first and immediately after that show the emoji popup.\n-        emojiEditText.setFocusableInTouchMode(true);\n-        emojiEditText.requestFocus();\n+        ((View) editInterface).setFocusableInTouchMode(true);\n+        ((View) editInterface).requestFocus();\n \n         showAtBottomPending();\n \n         final InputMethodManager inputMethodManager = (InputMethodManager) context.getSystemService(Context.INPUT_METHOD_SERVICE);\n-        inputMethodManager.showSoftInput(emojiEditText, InputMethodManager.SHOW_IMPLICIT);\n+        inputMethodManager.showSoftInput(","path":"emoji/src/main/java/com/vanniktech/emoji/EmojiPopup.java","position":66,"original_position":66,"commit_id":"7512c87c815b4346ec68d8984ed4bf787de08142","original_commit_id":"7512c87c815b4346ec68d8984ed4bf787de08142","user":{"login":"vanniktech","id":5759366,"avatar_url":"https://avatars0.githubusercontent.com/u/5759366?v=4","gravatar_id":"","url":"https://api.github.com/users/vanniktech","html_url":"https://github.com/vanniktech","followers_url":"https://api.github.com/users/vanniktech/followers","following_url":"https://api.github.com/users/vanniktech/following{/other_user}","gists_url":"https://api.github.com/users/vanniktech/gists{/gist_id}","starred_url":"https://api.github.com/users/vanniktech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanniktech/subscriptions","organizations_url":"https://api.github.com/users/vanniktech/orgs","repos_url":"https://api.github.com/users/vanniktech/repos","events_url":"https://api.github.com/users/vanniktech/events{/privacy}","received_events_url":"https://api.github.com/users/vanniktech/received_events","type":"User","site_admin":false},"body":"keep the old behavior please","created_at":"2018-04-23T16:48:44Z","updated_at":"2018-04-23T16:50:22Z","html_url":"https://github.com/vanniktech/Emoji/pull/277#discussion_r183463889","pull_request_url":"https://api.github.com/repos/vanniktech/Emoji/pulls/277","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/vanniktech/Emoji/pulls/comments/183463889"},"html":{"href":"https://github.com/vanniktech/Emoji/pull/277#discussion_r183463889"},"pull_request":{"href":"https://api.github.com/repos/vanniktech/Emoji/pulls/277"}}},"pull_request":{"url":"https://api.github.com/repos/vanniktech/Emoji/pulls/277","id":183482898,"html_url":"https://github.com/vanniktech/Emoji/pull/277","diff_url":"https://github.com/vanniktech/Emoji/pull/277.diff","patch_url":"https://github.com/vanniktech/Emoji/pull/277.patch","issue_url":"https://api.github.com/repos/vanniktech/Emoji/issues/277","number":277,"state":"open","locked":false,"title":"Allow customization","user":{"login":"Foo-Manroot","id":15656012,"avatar_url":"https://avatars3.githubusercontent.com/u/15656012?v=4","gravatar_id":"","url":"https://api.github.com/users/Foo-Manroot","html_url":"https://github.com/Foo-Manroot","followers_url":"https://api.github.com/users/Foo-Manroot/followers","following_url":"https://api.github.com/users/Foo-Manroot/following{/other_user}","gists_url":"https://api.github.com/users/Foo-Manroot/gists{/gist_id}","starred_url":"https://api.github.com/users/Foo-Manroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foo-Manroot/subscriptions","organizations_url":"https://api.github.com/users/Foo-Manroot/orgs","repos_url":"https://api.github.com/users/Foo-Manroot/repos","events_url":"https://api.github.com/users/Foo-Manroot/events{/privacy}","received_events_url":"https://api.github.com/users/Foo-Manroot/received_events","type":"User","site_admin":false},"body":"I was trying to add support for a built-in emoji keyboard on [the Android client](https://github.com/vector-im/riot-android) for Riot, and I found this library, so I started figuring out how to do it. However, [the view](https://github.com/vector-im/riot-android/blob/develop/vector/src/main/java/im/vector/view/VectorAutoCompleteTextView.java) responsible for the keyboard inside the chats extends  `AppCompatMultiAutoCompleteTextView`, so it can't inherit `EmojiEditText` to add support.\r\n\r\nIn this pull request the class `EmojiEditText` has been replaced by an interface, **`EmojiEditTextInterface`**. Now, any class that wants to act as the emoji edit text (like `EmojiEditText` itself) has to implement those methods, and can extend from any class that's needed. Al this is reflected on the changed **README.md**.\r\n\r\n---\r\n\r\nI'm new to Android development, so there may be some things that I did wrong, or something missing; in which case I'd appreciate some help to fix it.\r\n\r\nAlso, I didn't see any contribution guidelines. If anything about the code is wrong (like the formatting), please let me know.","created_at":"2018-04-23T16:02:33Z","updated_at":"2018-04-23T16:50:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39f1784aac34acfb2dbefcbe9ea6d74a2f8ae7df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vanniktech/Emoji/pulls/277/commits","review_comments_url":"https://api.github.com/repos/vanniktech/Emoji/pulls/277/comments","review_comment_url":"https://api.github.com/repos/vanniktech/Emoji/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vanniktech/Emoji/issues/277/comments","statuses_url":"https://api.github.com/repos/vanniktech/Emoji/statuses/7512c87c815b4346ec68d8984ed4bf787de08142","head":{"label":"Foo-Manroot:allow_customization","ref":"allow_customization","sha":"7512c87c815b4346ec68d8984ed4bf787de08142","user":{"login":"Foo-Manroot","id":15656012,"avatar_url":"https://avatars3.githubusercontent.com/u/15656012?v=4","gravatar_id":"","url":"https://api.github.com/users/Foo-Manroot","html_url":"https://github.com/Foo-Manroot","followers_url":"https://api.github.com/users/Foo-Manroot/followers","following_url":"https://api.github.com/users/Foo-Manroot/following{/other_user}","gists_url":"https://api.github.com/users/Foo-Manroot/gists{/gist_id}","starred_url":"https://api.github.com/users/Foo-Manroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foo-Manroot/subscriptions","organizations_url":"https://api.github.com/users/Foo-Manroot/orgs","repos_url":"https://api.github.com/users/Foo-Manroot/repos","events_url":"https://api.github.com/users/Foo-Manroot/events{/privacy}","received_events_url":"https://api.github.com/users/Foo-Manroot/received_events","type":"User","site_admin":false},"repo":{"id":130719761,"name":"Emoji","full_name":"Foo-Manroot/Emoji","owner":{"login":"Foo-Manroot","id":15656012,"avatar_url":"https://avatars3.githubusercontent.com/u/15656012?v=4","gravatar_id":"","url":"https://api.github.com/users/Foo-Manroot","html_url":"https://github.com/Foo-Manroot","followers_url":"https://api.github.com/users/Foo-Manroot/followers","following_url":"https://api.github.com/users/Foo-Manroot/following{/other_user}","gists_url":"https://api.github.com/users/Foo-Manroot/gists{/gist_id}","starred_url":"https://api.github.com/users/Foo-Manroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foo-Manroot/subscriptions","organizations_url":"https://api.github.com/users/Foo-Manroot/orgs","repos_url":"https://api.github.com/users/Foo-Manroot/repos","events_url":"https://api.github.com/users/Foo-Manroot/events{/privacy}","received_events_url":"https://api.github.com/users/Foo-Manroot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Foo-Manroot/Emoji","description":"A simple library to add Emoji support to your Android Application","fork":true,"url":"https://api.github.com/repos/Foo-Manroot/Emoji","forks_url":"https://api.github.com/repos/Foo-Manroot/Emoji/forks","keys_url":"https://api.github.com/repos/Foo-Manroot/Emoji/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Foo-Manroot/Emoji/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Foo-Manroot/Emoji/teams","hooks_url":"https://api.github.com/repos/Foo-Manroot/Emoji/hooks","issue_events_url":"https://api.github.com/repos/Foo-Manroot/Emoji/issues/events{/number}","events_url":"https://api.github.com/repos/Foo-Manroot/Emoji/events","assignees_url":"https://api.github.com/repos/Foo-Manroot/Emoji/assignees{/user}","branches_url":"https://api.github.com/repos/Foo-Manroot/Emoji/branches{/branch}","tags_url":"https://api.github.com/repos/Foo-Manroot/Emoji/tags","blobs_url":"https://api.github.com/repos/Foo-Manroot/Emoji/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Foo-Manroot/Emoji/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Foo-Manroot/Emoji/git/refs{/sha}","trees_url":"https://api.github.com/repos/Foo-Manroot/Emoji/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Foo-Manroot/Emoji/statuses/{sha}","languages_url":"https://api.github.com/repos/Foo-Manroot/Emoji/languages","stargazers_url":"https://api.github.com/repos/Foo-Manroot/Emoji/stargazers","contributors_url":"https://api.github.com/repos/Foo-Manroot/Emoji/contributors","subscribers_url":"https://api.github.com/repos/Foo-Manroot/Emoji/subscribers","subscription_url":"https://api.github.com/repos/Foo-Manroot/Emoji/subscription","commits_url":"https://api.github.com/repos/Foo-Manroot/Emoji/commits{/sha}","git_commits_url":"https://api.github.com/repos/Foo-Manroot/Emoji/git/commits{/sha}","comments_url":"https://api.github.com/repos/Foo-Manroot/Emoji/comments{/number}","issue_comment_url":"https://api.github.com/repos/Foo-Manroot/Emoji/issues/comments{/number}","contents_url":"https://api.github.com/repos/Foo-Manroot/Emoji/contents/{+path}","compare_url":"https://api.github.com/repos/Foo-Manroot/Emoji/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Foo-Manroot/Emoji/merges","archive_url":"https://api.github.com/repos/Foo-Manroot/Emoji/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Foo-Manroot/Emoji/downloads","issues_url":"https://api.github.com/repos/Foo-Manroot/Emoji/issues{/number}","pulls_url":"https://api.github.com/repos/Foo-Manroot/Emoji/pulls{/number}","milestones_url":"https://api.github.com/repos/Foo-Manroot/Emoji/milestones{/number}","notifications_url":"https://api.github.com/repos/Foo-Manroot/Emoji/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Foo-Manroot/Emoji/labels{/name}","releases_url":"https://api.github.com/repos/Foo-Manroot/Emoji/releases{/id}","deployments_url":"https://api.github.com/repos/Foo-Manroot/Emoji/deployments","created_at":"2018-04-23T15:41:12Z","updated_at":"2018-04-23T15:41:15Z","pushed_at":"2018-04-23T16:20:29Z","git_url":"git://github.com/Foo-Manroot/Emoji.git","ssh_url":"git@github.com:Foo-Manroot/Emoji.git","clone_url":"https://github.com/Foo-Manroot/Emoji.git","svn_url":"https://github.com/Foo-Manroot/Emoji","homepage":"","size":44807,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vanniktech:master","ref":"master","sha":"1d927d10cf39ccf3498a4a5aa6787ad52e4c6c82","user":{"login":"vanniktech","id":5759366,"avatar_url":"https://avatars0.githubusercontent.com/u/5759366?v=4","gravatar_id":"","url":"https://api.github.com/users/vanniktech","html_url":"https://github.com/vanniktech","followers_url":"https://api.github.com/users/vanniktech/followers","following_url":"https://api.github.com/users/vanniktech/following{/other_user}","gists_url":"https://api.github.com/users/vanniktech/gists{/gist_id}","starred_url":"https://api.github.com/users/vanniktech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanniktech/subscriptions","organizations_url":"https://api.github.com/users/vanniktech/orgs","repos_url":"https://api.github.com/users/vanniktech/repos","events_url":"https://api.github.com/users/vanniktech/events{/privacy}","received_events_url":"https://api.github.com/users/vanniktech/received_events","type":"User","site_admin":false},"repo":{"id":53511222,"name":"Emoji","full_name":"vanniktech/Emoji","owner":{"login":"vanniktech","id":5759366,"avatar_url":"https://avatars0.githubusercontent.com/u/5759366?v=4","gravatar_id":"","url":"https://api.github.com/users/vanniktech","html_url":"https://github.com/vanniktech","followers_url":"https://api.github.com/users/vanniktech/followers","following_url":"https://api.github.com/users/vanniktech/following{/other_user}","gists_url":"https://api.github.com/users/vanniktech/gists{/gist_id}","starred_url":"https://api.github.com/users/vanniktech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanniktech/subscriptions","organizations_url":"https://api.github.com/users/vanniktech/orgs","repos_url":"https://api.github.com/users/vanniktech/repos","events_url":"https://api.github.com/users/vanniktech/events{/privacy}","received_events_url":"https://api.github.com/users/vanniktech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vanniktech/Emoji","description":"A simple library to add Emoji support to your Android Application","fork":false,"url":"https://api.github.com/repos/vanniktech/Emoji","forks_url":"https://api.github.com/repos/vanniktech/Emoji/forks","keys_url":"https://api.github.com/repos/vanniktech/Emoji/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanniktech/Emoji/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanniktech/Emoji/teams","hooks_url":"https://api.github.com/repos/vanniktech/Emoji/hooks","issue_events_url":"https://api.github.com/repos/vanniktech/Emoji/issues/events{/number}","events_url":"https://api.github.com/repos/vanniktech/Emoji/events","assignees_url":"https://api.github.com/repos/vanniktech/Emoji/assignees{/user}","branches_url":"https://api.github.com/repos/vanniktech/Emoji/branches{/branch}","tags_url":"https://api.github.com/repos/vanniktech/Emoji/tags","blobs_url":"https://api.github.com/repos/vanniktech/Emoji/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanniktech/Emoji/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanniktech/Emoji/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanniktech/Emoji/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanniktech/Emoji/statuses/{sha}","languages_url":"https://api.github.com/repos/vanniktech/Emoji/languages","stargazers_url":"https://api.github.com/repos/vanniktech/Emoji/stargazers","contributors_url":"https://api.github.com/repos/vanniktech/Emoji/contributors","subscribers_url":"https://api.github.com/repos/vanniktech/Emoji/subscribers","subscription_url":"https://api.github.com/repos/vanniktech/Emoji/subscription","commits_url":"https://api.github.com/repos/vanniktech/Emoji/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanniktech/Emoji/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanniktech/Emoji/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanniktech/Emoji/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanniktech/Emoji/contents/{+path}","compare_url":"https://api.github.com/repos/vanniktech/Emoji/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanniktech/Emoji/merges","archive_url":"https://api.github.com/repos/vanniktech/Emoji/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanniktech/Emoji/downloads","issues_url":"https://api.github.com/repos/vanniktech/Emoji/issues{/number}","pulls_url":"https://api.github.com/repos/vanniktech/Emoji/pulls{/number}","milestones_url":"https://api.github.com/repos/vanniktech/Emoji/milestones{/number}","notifications_url":"https://api.github.com/repos/vanniktech/Emoji/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanniktech/Emoji/labels{/name}","releases_url":"https://api.github.com/repos/vanniktech/Emoji/releases{/id}","deployments_url":"https://api.github.com/repos/vanniktech/Emoji/deployments","created_at":"2016-03-09T16:01:10Z","updated_at":"2018-04-22T10:28:27Z","pushed_at":"2018-04-23T16:20:31Z","git_url":"git://github.com/vanniktech/Emoji.git","ssh_url":"git@github.com:vanniktech/Emoji.git","clone_url":"https://github.com/vanniktech/Emoji.git","svn_url":"https://github.com/vanniktech/Emoji","homepage":"","size":44799,"stargazers_count":737,"watchers_count":737,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":184,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":184,"open_issues":8,"watchers":737,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vanniktech/Emoji/pulls/277"},"html":{"href":"https://github.com/vanniktech/Emoji/pull/277"},"issue":{"href":"https://api.github.com/repos/vanniktech/Emoji/issues/277"},"comments":{"href":"https://api.github.com/repos/vanniktech/Emoji/issues/277/comments"},"review_comments":{"href":"https://api.github.com/repos/vanniktech/Emoji/pulls/277/comments"},"review_comment":{"href":"https://api.github.com/repos/vanniktech/Emoji/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vanniktech/Emoji/pulls/277/commits"},"statuses":{"href":"https://api.github.com/repos/vanniktech/Emoji/statuses/7512c87c815b4346ec68d8984ed4bf787de08142"}},"author_association":"NONE"}}
{"actor":{"display_login":"vanniktech"}}