{"action":"created","comment":{"url":"https://api.github.com/repos/containers/virtcontainers/pulls/comments/168612058","pull_request_review_id":96988792,"id":168612058,"diff_hunk":"@@ -728,32 +330,36 @@ func (q *qemu) createPod(podConfig PodConfig) error {\n \t\t},\n \t}\n \n-\tdevices = q.appendFSDevices(devices, podConfig)\n-\tdevices = q.appendConsoles(devices, podConfig)\n-\tdevices, err = q.appendImage(devices, podConfig)\n+\tdevices = q.arch.append9PVolumes(devices, podConfig.Volumes)","path":"qemu.go","position":647,"original_position":647,"commit_id":"c4ccc1537b23ab0e07654953bd66c00f2dbbd33b","original_commit_id":"e774669da9864c1cdb5b17ffd32068df5098919e","user":{"login":"sboeuf","id":22890413,"avatar_url":"https://avatars3.githubusercontent.com/u/22890413?v=4","gravatar_id":"","url":"https://api.github.com/users/sboeuf","html_url":"https://github.com/sboeuf","followers_url":"https://api.github.com/users/sboeuf/followers","following_url":"https://api.github.com/users/sboeuf/following{/other_user}","gists_url":"https://api.github.com/users/sboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/sboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboeuf/subscriptions","organizations_url":"https://api.github.com/users/sboeuf/orgs","repos_url":"https://api.github.com/users/sboeuf/repos","events_url":"https://api.github.com/users/sboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/sboeuf/received_events","type":"User","site_admin":false},"body":"Renames should be done in separate commit.","created_at":"2018-02-15T21:23:16Z","updated_at":"2018-02-15T21:36:39Z","html_url":"https://github.com/containers/virtcontainers/pull/614#discussion_r168612058","pull_request_url":"https://api.github.com/repos/containers/virtcontainers/pulls/614","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/containers/virtcontainers/pulls/comments/168612058"},"html":{"href":"https://github.com/containers/virtcontainers/pull/614#discussion_r168612058"},"pull_request":{"href":"https://api.github.com/repos/containers/virtcontainers/pulls/614"}}},"pull_request":{"url":"https://api.github.com/repos/containers/virtcontainers/pulls/614","id":168382448,"html_url":"https://github.com/containers/virtcontainers/pull/614","diff_url":"https://github.com/containers/virtcontainers/pull/614.diff","patch_url":"https://github.com/containers/virtcontainers/pull/614.patch","issue_url":"https://api.github.com/repos/containers/virtcontainers/issues/614","number":614,"state":"open","locked":false,"title":"qemu: Add support for ARM","user":{"login":"devimc","id":13009432,"avatar_url":"https://avatars0.githubusercontent.com/u/13009432?v=4","gravatar_id":"","url":"https://api.github.com/users/devimc","html_url":"https://github.com/devimc","followers_url":"https://api.github.com/users/devimc/followers","following_url":"https://api.github.com/users/devimc/following{/other_user}","gists_url":"https://api.github.com/users/devimc/gists{/gist_id}","starred_url":"https://api.github.com/users/devimc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devimc/subscriptions","organizations_url":"https://api.github.com/users/devimc/orgs","repos_url":"https://api.github.com/users/devimc/repos","events_url":"https://api.github.com/users/devimc/events{/privacy}","received_events_url":"https://api.github.com/users/devimc/received_events","type":"User","site_admin":false},"body":"This patch introduces a new interface called qemuArch that contains\r\nthe functions needed to create qemu specific architecture implementations.\r\nThis patch also includes three qemu specific architecture\r\nimplementations: qemuSystem, qemuAmd64 and qemuArm64, since all architectures\r\nuse similar qemu command lines, the base structure is qemuSystem that is an\r\nagnostic implementation to start virtual machines, qemuAmd64 and qemuArm64\r\ninherit and override (if needed) the functions of qemuSystem, therefore architecture\r\nspecific optimizations are in qemuAmd64 and qemuArm64.\r\nFor example the `appendImage` function defined by qemuSystem uses a block\r\ndevice to provide the image to the VM, qemuArm64 inherits and doesn't\r\noverwrite it, but qemuAmd64 inherits and overwites it to provide the\r\nimage throught NVDIMM and DAX.\r\n    \r\nfixes #608\r\nfixes #610\r\nfixes #611\r\nfixes #612\r\n\r\nSigned-off-by: Julio Montes <julio.montes@intel.com>","created_at":"2018-02-10T02:58:48Z","updated_at":"2018-02-15T21:36:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"947bf348124d09d2f6923d909f716cfbf5020ae9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":832019411,"url":"https://api.github.com/repos/containers/virtcontainers/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/containers/virtcontainers/pulls/614/commits","review_comments_url":"https://api.github.com/repos/containers/virtcontainers/pulls/614/comments","review_comment_url":"https://api.github.com/repos/containers/virtcontainers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containers/virtcontainers/issues/614/comments","statuses_url":"https://api.github.com/repos/containers/virtcontainers/statuses/c4ccc1537b23ab0e07654953bd66c00f2dbbd33b","head":{"label":"devimc:ARM","ref":"ARM","sha":"c4ccc1537b23ab0e07654953bd66c00f2dbbd33b","user":{"login":"devimc","id":13009432,"avatar_url":"https://avatars0.githubusercontent.com/u/13009432?v=4","gravatar_id":"","url":"https://api.github.com/users/devimc","html_url":"https://github.com/devimc","followers_url":"https://api.github.com/users/devimc/followers","following_url":"https://api.github.com/users/devimc/following{/other_user}","gists_url":"https://api.github.com/users/devimc/gists{/gist_id}","starred_url":"https://api.github.com/users/devimc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devimc/subscriptions","organizations_url":"https://api.github.com/users/devimc/orgs","repos_url":"https://api.github.com/users/devimc/repos","events_url":"https://api.github.com/users/devimc/events{/privacy}","received_events_url":"https://api.github.com/users/devimc/received_events","type":"User","site_admin":false},"repo":{"id":80849666,"name":"virtcontainers","full_name":"devimc/virtcontainers","owner":{"login":"devimc","id":13009432,"avatar_url":"https://avatars0.githubusercontent.com/u/13009432?v=4","gravatar_id":"","url":"https://api.github.com/users/devimc","html_url":"https://github.com/devimc","followers_url":"https://api.github.com/users/devimc/followers","following_url":"https://api.github.com/users/devimc/following{/other_user}","gists_url":"https://api.github.com/users/devimc/gists{/gist_id}","starred_url":"https://api.github.com/users/devimc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devimc/subscriptions","organizations_url":"https://api.github.com/users/devimc/orgs","repos_url":"https://api.github.com/users/devimc/repos","events_url":"https://api.github.com/users/devimc/events{/privacy}","received_events_url":"https://api.github.com/users/devimc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/devimc/virtcontainers","description":"A Go package for building hardware virtualized container runtimes","fork":true,"url":"https://api.github.com/repos/devimc/virtcontainers","forks_url":"https://api.github.com/repos/devimc/virtcontainers/forks","keys_url":"https://api.github.com/repos/devimc/virtcontainers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devimc/virtcontainers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devimc/virtcontainers/teams","hooks_url":"https://api.github.com/repos/devimc/virtcontainers/hooks","issue_events_url":"https://api.github.com/repos/devimc/virtcontainers/issues/events{/number}","events_url":"https://api.github.com/repos/devimc/virtcontainers/events","assignees_url":"https://api.github.com/repos/devimc/virtcontainers/assignees{/user}","branches_url":"https://api.github.com/repos/devimc/virtcontainers/branches{/branch}","tags_url":"https://api.github.com/repos/devimc/virtcontainers/tags","blobs_url":"https://api.github.com/repos/devimc/virtcontainers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devimc/virtcontainers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devimc/virtcontainers/git/refs{/sha}","trees_url":"https://api.github.com/repos/devimc/virtcontainers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devimc/virtcontainers/statuses/{sha}","languages_url":"https://api.github.com/repos/devimc/virtcontainers/languages","stargazers_url":"https://api.github.com/repos/devimc/virtcontainers/stargazers","contributors_url":"https://api.github.com/repos/devimc/virtcontainers/contributors","subscribers_url":"https://api.github.com/repos/devimc/virtcontainers/subscribers","subscription_url":"https://api.github.com/repos/devimc/virtcontainers/subscription","commits_url":"https://api.github.com/repos/devimc/virtcontainers/commits{/sha}","git_commits_url":"https://api.github.com/repos/devimc/virtcontainers/git/commits{/sha}","comments_url":"https://api.github.com/repos/devimc/virtcontainers/comments{/number}","issue_comment_url":"https://api.github.com/repos/devimc/virtcontainers/issues/comments{/number}","contents_url":"https://api.github.com/repos/devimc/virtcontainers/contents/{+path}","compare_url":"https://api.github.com/repos/devimc/virtcontainers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devimc/virtcontainers/merges","archive_url":"https://api.github.com/repos/devimc/virtcontainers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devimc/virtcontainers/downloads","issues_url":"https://api.github.com/repos/devimc/virtcontainers/issues{/number}","pulls_url":"https://api.github.com/repos/devimc/virtcontainers/pulls{/number}","milestones_url":"https://api.github.com/repos/devimc/virtcontainers/milestones{/number}","notifications_url":"https://api.github.com/repos/devimc/virtcontainers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devimc/virtcontainers/labels{/name}","releases_url":"https://api.github.com/repos/devimc/virtcontainers/releases{/id}","deployments_url":"https://api.github.com/repos/devimc/virtcontainers/deployments","created_at":"2017-02-03T17:00:24Z","updated_at":"2017-02-03T17:00:26Z","pushed_at":"2018-02-15T20:36:00Z","git_url":"git://github.com/devimc/virtcontainers.git","ssh_url":"git@github.com:devimc/virtcontainers.git","clone_url":"https://github.com/devimc/virtcontainers.git","svn_url":"https://github.com/devimc/virtcontainers","homepage":null,"size":10927,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containers:master","ref":"master","sha":"000e6860d188dfc7a5be972ec0c2c386a09acf6f","user":{"login":"containers","id":5874934,"avatar_url":"https://avatars3.githubusercontent.com/u/5874934?v=4","gravatar_id":"","url":"https://api.github.com/users/containers","html_url":"https://github.com/containers","followers_url":"https://api.github.com/users/containers/followers","following_url":"https://api.github.com/users/containers/following{/other_user}","gists_url":"https://api.github.com/users/containers/gists{/gist_id}","starred_url":"https://api.github.com/users/containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containers/subscriptions","organizations_url":"https://api.github.com/users/containers/orgs","repos_url":"https://api.github.com/users/containers/repos","events_url":"https://api.github.com/users/containers/events{/privacy}","received_events_url":"https://api.github.com/users/containers/received_events","type":"Organization","site_admin":false},"repo":{"id":71125072,"name":"virtcontainers","full_name":"containers/virtcontainers","owner":{"login":"containers","id":5874934,"avatar_url":"https://avatars3.githubusercontent.com/u/5874934?v=4","gravatar_id":"","url":"https://api.github.com/users/containers","html_url":"https://github.com/containers","followers_url":"https://api.github.com/users/containers/followers","following_url":"https://api.github.com/users/containers/following{/other_user}","gists_url":"https://api.github.com/users/containers/gists{/gist_id}","starred_url":"https://api.github.com/users/containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containers/subscriptions","organizations_url":"https://api.github.com/users/containers/orgs","repos_url":"https://api.github.com/users/containers/repos","events_url":"https://api.github.com/users/containers/events{/privacy}","received_events_url":"https://api.github.com/users/containers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/containers/virtcontainers","description":"A Go package for building hardware virtualized container runtimes","fork":false,"url":"https://api.github.com/repos/containers/virtcontainers","forks_url":"https://api.github.com/repos/containers/virtcontainers/forks","keys_url":"https://api.github.com/repos/containers/virtcontainers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containers/virtcontainers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containers/virtcontainers/teams","hooks_url":"https://api.github.com/repos/containers/virtcontainers/hooks","issue_events_url":"https://api.github.com/repos/containers/virtcontainers/issues/events{/number}","events_url":"https://api.github.com/repos/containers/virtcontainers/events","assignees_url":"https://api.github.com/repos/containers/virtcontainers/assignees{/user}","branches_url":"https://api.github.com/repos/containers/virtcontainers/branches{/branch}","tags_url":"https://api.github.com/repos/containers/virtcontainers/tags","blobs_url":"https://api.github.com/repos/containers/virtcontainers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containers/virtcontainers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containers/virtcontainers/git/refs{/sha}","trees_url":"https://api.github.com/repos/containers/virtcontainers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containers/virtcontainers/statuses/{sha}","languages_url":"https://api.github.com/repos/containers/virtcontainers/languages","stargazers_url":"https://api.github.com/repos/containers/virtcontainers/stargazers","contributors_url":"https://api.github.com/repos/containers/virtcontainers/contributors","subscribers_url":"https://api.github.com/repos/containers/virtcontainers/subscribers","subscription_url":"https://api.github.com/repos/containers/virtcontainers/subscription","commits_url":"https://api.github.com/repos/containers/virtcontainers/commits{/sha}","git_commits_url":"https://api.github.com/repos/containers/virtcontainers/git/commits{/sha}","comments_url":"https://api.github.com/repos/containers/virtcontainers/comments{/number}","issue_comment_url":"https://api.github.com/repos/containers/virtcontainers/issues/comments{/number}","contents_url":"https://api.github.com/repos/containers/virtcontainers/contents/{+path}","compare_url":"https://api.github.com/repos/containers/virtcontainers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containers/virtcontainers/merges","archive_url":"https://api.github.com/repos/containers/virtcontainers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containers/virtcontainers/downloads","issues_url":"https://api.github.com/repos/containers/virtcontainers/issues{/number}","pulls_url":"https://api.github.com/repos/containers/virtcontainers/pulls{/number}","milestones_url":"https://api.github.com/repos/containers/virtcontainers/milestones{/number}","notifications_url":"https://api.github.com/repos/containers/virtcontainers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containers/virtcontainers/labels{/name}","releases_url":"https://api.github.com/repos/containers/virtcontainers/releases{/id}","deployments_url":"https://api.github.com/repos/containers/virtcontainers/deployments","created_at":"2016-10-17T10:08:28Z","updated_at":"2018-02-15T21:36:24Z","pushed_at":"2018-02-15T20:36:01Z","git_url":"git://github.com/containers/virtcontainers.git","ssh_url":"git@github.com:containers/virtcontainers.git","clone_url":"https://github.com/containers/virtcontainers.git","svn_url":"https://github.com/containers/virtcontainers","homepage":null,"size":11062,"stargazers_count":83,"watchers_count":83,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":26,"open_issues":64,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containers/virtcontainers/pulls/614"},"html":{"href":"https://github.com/containers/virtcontainers/pull/614"},"issue":{"href":"https://api.github.com/repos/containers/virtcontainers/issues/614"},"comments":{"href":"https://api.github.com/repos/containers/virtcontainers/issues/614/comments"},"review_comments":{"href":"https://api.github.com/repos/containers/virtcontainers/pulls/614/comments"},"review_comment":{"href":"https://api.github.com/repos/containers/virtcontainers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containers/virtcontainers/pulls/614/commits"},"statuses":{"href":"https://api.github.com/repos/containers/virtcontainers/statuses/c4ccc1537b23ab0e07654953bd66c00f2dbbd33b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sboeuf"}}