{"action":"created","comment":{"url":"https://api.github.com/repos/syncthing/syncthing/pulls/comments/216793528","pull_request_review_id":154360719,"id":216793528,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjc5MzUyOA==","diff_hunk":"@@ -0,0 +1,46 @@\n+// Copyright (C) 2016 The Syncthing Authors.\n+//\n+// This Source Code Form is subject to the terms of the Mozilla Public\n+// License, v. 2.0. If a copy of the MPL was not distributed with this file,\n+// You can obtain one at https://mozilla.org/MPL/2.0/.\n+\n+package config\n+\n+type LDAPTLSMode int\n+\n+const (\n+\tLDAPTLSModePlain LDAPTLSMode = iota // default is notls\n+\tLDAPTLSModeTLS\n+\tLDAPTLSModeStartTLS\n+)\n+\n+func (t LDAPTLSMode) String() string {\n+\tswitch t {\n+\tcase LDAPTLSModePlain:\n+\t\treturn \"plain\"","path":"lib/config/ldaptlsmode.go","position":20,"original_position":20,"commit_id":"22dfbb00fc1bfeb5c2ac5570b2863b11b6e05fd0","original_commit_id":"22dfbb00fc1bfeb5c2ac5570b2863b11b6e05fd0","user":{"login":"AudriusButkevicius","id":1144861,"node_id":"MDQ6VXNlcjExNDQ4NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1144861?v=4","gravatar_id":"","url":"https://api.github.com/users/AudriusButkevicius","html_url":"https://github.com/AudriusButkevicius","followers_url":"https://api.github.com/users/AudriusButkevicius/followers","following_url":"https://api.github.com/users/AudriusButkevicius/following{/other_user}","gists_url":"https://api.github.com/users/AudriusButkevicius/gists{/gist_id}","starred_url":"https://api.github.com/users/AudriusButkevicius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudriusButkevicius/subscriptions","organizations_url":"https://api.github.com/users/AudriusButkevicius/orgs","repos_url":"https://api.github.com/users/AudriusButkevicius/repos","events_url":"https://api.github.com/users/AudriusButkevicius/events{/privacy}","received_events_url":"https://api.github.com/users/AudriusButkevicius/received_events","type":"User","site_admin":false},"body":"Now that I think about it, it's not plain tls, it's simply not tls at all, so perhaps this should not be LDAPTLSMode, but LDAPTransport or LDAPProtocol or something alike. Or the mode should be none, (as in non-tls).\r\n\r\nSorry for distracting you here earlier.","created_at":"2018-09-11T19:31:06Z","updated_at":"2018-09-11T19:31:06Z","html_url":"https://github.com/syncthing/syncthing/pull/5169#discussion_r216793528","pull_request_url":"https://api.github.com/repos/syncthing/syncthing/pulls/5169","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/comments/216793528"},"html":{"href":"https://github.com/syncthing/syncthing/pull/5169#discussion_r216793528"},"pull_request":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/5169"}}},"pull_request":{"url":"https://api.github.com/repos/syncthing/syncthing/pulls/5169","id":214051692,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDUxNjky","html_url":"https://github.com/syncthing/syncthing/pull/5169","diff_url":"https://github.com/syncthing/syncthing/pull/5169.diff","patch_url":"https://github.com/syncthing/syncthing/pull/5169.patch","issue_url":"https://api.github.com/repos/syncthing/syncthing/issues/5169","number":5169,"state":"open","locked":false,"title":"ldap auth mode","user":{"login":"cyberb","id":885528,"node_id":"MDQ6VXNlcjg4NTUyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/885528?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberb","html_url":"https://github.com/cyberb","followers_url":"https://api.github.com/users/cyberb/followers","following_url":"https://api.github.com/users/cyberb/following{/other_user}","gists_url":"https://api.github.com/users/cyberb/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberb/subscriptions","organizations_url":"https://api.github.com/users/cyberb/orgs","repos_url":"https://api.github.com/users/cyberb/repos","events_url":"https://api.github.com/users/cyberb/events{/privacy}","received_events_url":"https://api.github.com/users/cyberb/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nAllows gui to authenticate against ldap using simple bind approach.\r\n\r\nAdditional config section:\r\n\r\n    <authMode>ldap</authMode>\r\n    <LDAPAuth>\r\n        <address>localhost:389</address>\r\n        <bindDn>cn=%s,ou=users,dc=syncloud,dc=org</bindDn>\r\n        <tlsMode>nontls/tls/starttls</tlsMode>\r\n        <insecureSkipVerify>false/true</insecureSkipVerify>\r\n    </LDAPAuth>\r\n\r\nExisting user/password authentication is preserved and can be used as before if authMode is not present or not equals to ldap.\r\n\r\n### Testing\r\n\r\nFew mising unit tests are added for existing auth.\r\nNo unit tests for ldap, although integration tests are available in Syncloud project:\r\nhttps://github.com/syncloud/syncthing/blob/master/integration/verify.py#L99\r\n\r\n## Authorship\r\n\r\nBoris Rybalkin (ribalkin@gmail.com)\r\n\r\n","created_at":"2018-09-07T22:14:40Z","updated_at":"2018-09-11T19:31:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b8c78cb06db16d3400f2237cd3589e240b79358","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/syncthing/syncthing/pulls/5169/commits","review_comments_url":"https://api.github.com/repos/syncthing/syncthing/pulls/5169/comments","review_comment_url":"https://api.github.com/repos/syncthing/syncthing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syncthing/syncthing/issues/5169/comments","statuses_url":"https://api.github.com/repos/syncthing/syncthing/statuses/22dfbb00fc1bfeb5c2ac5570b2863b11b6e05fd0","head":{"label":"cyberb:master","ref":"master","sha":"22dfbb00fc1bfeb5c2ac5570b2863b11b6e05fd0","user":{"login":"cyberb","id":885528,"node_id":"MDQ6VXNlcjg4NTUyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/885528?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberb","html_url":"https://github.com/cyberb","followers_url":"https://api.github.com/users/cyberb/followers","following_url":"https://api.github.com/users/cyberb/following{/other_user}","gists_url":"https://api.github.com/users/cyberb/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberb/subscriptions","organizations_url":"https://api.github.com/users/cyberb/orgs","repos_url":"https://api.github.com/users/cyberb/repos","events_url":"https://api.github.com/users/cyberb/events{/privacy}","received_events_url":"https://api.github.com/users/cyberb/received_events","type":"User","site_admin":false},"repo":{"id":147569329,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1NjkzMjk=","name":"syncthing","full_name":"cyberb/syncthing","owner":{"login":"cyberb","id":885528,"node_id":"MDQ6VXNlcjg4NTUyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/885528?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberb","html_url":"https://github.com/cyberb","followers_url":"https://api.github.com/users/cyberb/followers","following_url":"https://api.github.com/users/cyberb/following{/other_user}","gists_url":"https://api.github.com/users/cyberb/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberb/subscriptions","organizations_url":"https://api.github.com/users/cyberb/orgs","repos_url":"https://api.github.com/users/cyberb/repos","events_url":"https://api.github.com/users/cyberb/events{/privacy}","received_events_url":"https://api.github.com/users/cyberb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyberb/syncthing","description":"Open Source Continuous File Synchronization","fork":true,"url":"https://api.github.com/repos/cyberb/syncthing","forks_url":"https://api.github.com/repos/cyberb/syncthing/forks","keys_url":"https://api.github.com/repos/cyberb/syncthing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyberb/syncthing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyberb/syncthing/teams","hooks_url":"https://api.github.com/repos/cyberb/syncthing/hooks","issue_events_url":"https://api.github.com/repos/cyberb/syncthing/issues/events{/number}","events_url":"https://api.github.com/repos/cyberb/syncthing/events","assignees_url":"https://api.github.com/repos/cyberb/syncthing/assignees{/user}","branches_url":"https://api.github.com/repos/cyberb/syncthing/branches{/branch}","tags_url":"https://api.github.com/repos/cyberb/syncthing/tags","blobs_url":"https://api.github.com/repos/cyberb/syncthing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyberb/syncthing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyberb/syncthing/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyberb/syncthing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyberb/syncthing/statuses/{sha}","languages_url":"https://api.github.com/repos/cyberb/syncthing/languages","stargazers_url":"https://api.github.com/repos/cyberb/syncthing/stargazers","contributors_url":"https://api.github.com/repos/cyberb/syncthing/contributors","subscribers_url":"https://api.github.com/repos/cyberb/syncthing/subscribers","subscription_url":"https://api.github.com/repos/cyberb/syncthing/subscription","commits_url":"https://api.github.com/repos/cyberb/syncthing/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyberb/syncthing/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyberb/syncthing/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyberb/syncthing/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyberb/syncthing/contents/{+path}","compare_url":"https://api.github.com/repos/cyberb/syncthing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyberb/syncthing/merges","archive_url":"https://api.github.com/repos/cyberb/syncthing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyberb/syncthing/downloads","issues_url":"https://api.github.com/repos/cyberb/syncthing/issues{/number}","pulls_url":"https://api.github.com/repos/cyberb/syncthing/pulls{/number}","milestones_url":"https://api.github.com/repos/cyberb/syncthing/milestones{/number}","notifications_url":"https://api.github.com/repos/cyberb/syncthing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyberb/syncthing/labels{/name}","releases_url":"https://api.github.com/repos/cyberb/syncthing/releases{/id}","deployments_url":"https://api.github.com/repos/cyberb/syncthing/deployments","created_at":"2018-09-05T19:30:04Z","updated_at":"2018-09-11T18:30:07Z","pushed_at":"2018-09-11T19:21:26Z","git_url":"git://github.com/cyberb/syncthing.git","ssh_url":"git@github.com:cyberb/syncthing.git","clone_url":"https://github.com/cyberb/syncthing.git","svn_url":"https://github.com/cyberb/syncthing","homepage":"https://forum.syncthing.net/","size":97022,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"syncthing:master","ref":"master","sha":"8aa2d8d92c26a2fd62b1d46bb935d738851b9d13","user":{"login":"syncthing","id":7628018,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MjgwMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/7628018?v=4","gravatar_id":"","url":"https://api.github.com/users/syncthing","html_url":"https://github.com/syncthing","followers_url":"https://api.github.com/users/syncthing/followers","following_url":"https://api.github.com/users/syncthing/following{/other_user}","gists_url":"https://api.github.com/users/syncthing/gists{/gist_id}","starred_url":"https://api.github.com/users/syncthing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncthing/subscriptions","organizations_url":"https://api.github.com/users/syncthing/orgs","repos_url":"https://api.github.com/users/syncthing/repos","events_url":"https://api.github.com/users/syncthing/events{/privacy}","received_events_url":"https://api.github.com/users/syncthing/received_events","type":"Organization","site_admin":false},"repo":{"id":14712850,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcxMjg1MA==","name":"syncthing","full_name":"syncthing/syncthing","owner":{"login":"syncthing","id":7628018,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MjgwMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/7628018?v=4","gravatar_id":"","url":"https://api.github.com/users/syncthing","html_url":"https://github.com/syncthing","followers_url":"https://api.github.com/users/syncthing/followers","following_url":"https://api.github.com/users/syncthing/following{/other_user}","gists_url":"https://api.github.com/users/syncthing/gists{/gist_id}","starred_url":"https://api.github.com/users/syncthing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncthing/subscriptions","organizations_url":"https://api.github.com/users/syncthing/orgs","repos_url":"https://api.github.com/users/syncthing/repos","events_url":"https://api.github.com/users/syncthing/events{/privacy}","received_events_url":"https://api.github.com/users/syncthing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/syncthing/syncthing","description":"Open Source Continuous File Synchronization","fork":false,"url":"https://api.github.com/repos/syncthing/syncthing","forks_url":"https://api.github.com/repos/syncthing/syncthing/forks","keys_url":"https://api.github.com/repos/syncthing/syncthing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syncthing/syncthing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syncthing/syncthing/teams","hooks_url":"https://api.github.com/repos/syncthing/syncthing/hooks","issue_events_url":"https://api.github.com/repos/syncthing/syncthing/issues/events{/number}","events_url":"https://api.github.com/repos/syncthing/syncthing/events","assignees_url":"https://api.github.com/repos/syncthing/syncthing/assignees{/user}","branches_url":"https://api.github.com/repos/syncthing/syncthing/branches{/branch}","tags_url":"https://api.github.com/repos/syncthing/syncthing/tags","blobs_url":"https://api.github.com/repos/syncthing/syncthing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syncthing/syncthing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syncthing/syncthing/git/refs{/sha}","trees_url":"https://api.github.com/repos/syncthing/syncthing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syncthing/syncthing/statuses/{sha}","languages_url":"https://api.github.com/repos/syncthing/syncthing/languages","stargazers_url":"https://api.github.com/repos/syncthing/syncthing/stargazers","contributors_url":"https://api.github.com/repos/syncthing/syncthing/contributors","subscribers_url":"https://api.github.com/repos/syncthing/syncthing/subscribers","subscription_url":"https://api.github.com/repos/syncthing/syncthing/subscription","commits_url":"https://api.github.com/repos/syncthing/syncthing/commits{/sha}","git_commits_url":"https://api.github.com/repos/syncthing/syncthing/git/commits{/sha}","comments_url":"https://api.github.com/repos/syncthing/syncthing/comments{/number}","issue_comment_url":"https://api.github.com/repos/syncthing/syncthing/issues/comments{/number}","contents_url":"https://api.github.com/repos/syncthing/syncthing/contents/{+path}","compare_url":"https://api.github.com/repos/syncthing/syncthing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syncthing/syncthing/merges","archive_url":"https://api.github.com/repos/syncthing/syncthing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syncthing/syncthing/downloads","issues_url":"https://api.github.com/repos/syncthing/syncthing/issues{/number}","pulls_url":"https://api.github.com/repos/syncthing/syncthing/pulls{/number}","milestones_url":"https://api.github.com/repos/syncthing/syncthing/milestones{/number}","notifications_url":"https://api.github.com/repos/syncthing/syncthing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syncthing/syncthing/labels{/name}","releases_url":"https://api.github.com/repos/syncthing/syncthing/releases{/id}","deployments_url":"https://api.github.com/repos/syncthing/syncthing/deployments","created_at":"2013-11-26T09:48:21Z","updated_at":"2018-09-11T18:46:26Z","pushed_at":"2018-09-11T19:18:36Z","git_url":"git://github.com/syncthing/syncthing.git","ssh_url":"git@github.com:syncthing/syncthing.git","clone_url":"https://github.com/syncthing/syncthing.git","svn_url":"https://github.com/syncthing/syncthing","homepage":"https://forum.syncthing.net/","size":97164,"stargazers_count":21858,"watchers_count":21858,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1857,"mirror_url":null,"archived":false,"open_issues_count":249,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1857,"open_issues":249,"watchers":21858,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/5169"},"html":{"href":"https://github.com/syncthing/syncthing/pull/5169"},"issue":{"href":"https://api.github.com/repos/syncthing/syncthing/issues/5169"},"comments":{"href":"https://api.github.com/repos/syncthing/syncthing/issues/5169/comments"},"review_comments":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/5169/comments"},"review_comment":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/5169/commits"},"statuses":{"href":"https://api.github.com/repos/syncthing/syncthing/statuses/22dfbb00fc1bfeb5c2ac5570b2863b11b6e05fd0"}},"author_association":"NONE"}}
{"actor":{"display_login":"AudriusButkevicius"}}