{"action":"created","issue":{"url":"https://api.github.com/repos/dcos/dcos-ui/issues/3299","repository_url":"https://api.github.com/repos/dcos/dcos-ui","labels_url":"https://api.github.com/repos/dcos/dcos-ui/issues/3299/labels{/name}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/issues/3299/comments","events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/3299/events","html_url":"https://github.com/dcos/dcos-ui/pull/3299","id":361679638,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NTg3OTcy","number":3299,"title":"DCOS-42035: Invalid Environment variables have no error and are simply ignored (1.10 backport)","user":{"login":"GeorgiSTodorov","id":40791275,"node_id":"MDQ6VXNlcjQwNzkxMjc1","avatar_url":"https://avatars2.githubusercontent.com/u/40791275?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgiSTodorov","html_url":"https://github.com/GeorgiSTodorov","followers_url":"https://api.github.com/users/GeorgiSTodorov/followers","following_url":"https://api.github.com/users/GeorgiSTodorov/following{/other_user}","gists_url":"https://api.github.com/users/GeorgiSTodorov/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgiSTodorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgiSTodorov/subscriptions","organizations_url":"https://api.github.com/users/GeorgiSTodorov/orgs","repos_url":"https://api.github.com/users/GeorgiSTodorov/repos","events_url":"https://api.github.com/users/GeorgiSTodorov/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgiSTodorov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dcos/dcos-ui/milestones/5","html_url":"https://github.com/dcos/dcos-ui/milestone/5","labels_url":"https://api.github.com/repos/dcos/dcos-ui/milestones/5/labels","id":2472096,"node_id":"MDk6TWlsZXN0b25lMjQ3MjA5Ng==","number":5,"title":"1.10","description":"","creator":{"login":"orlandohohmeier","id":647035,"node_id":"MDQ6VXNlcjY0NzAzNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/647035?v=4","gravatar_id":"","url":"https://api.github.com/users/orlandohohmeier","html_url":"https://github.com/orlandohohmeier","followers_url":"https://api.github.com/users/orlandohohmeier/followers","following_url":"https://api.github.com/users/orlandohohmeier/following{/other_user}","gists_url":"https://api.github.com/users/orlandohohmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/orlandohohmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlandohohmeier/subscriptions","organizations_url":"https://api.github.com/users/orlandohohmeier/orgs","repos_url":"https://api.github.com/users/orlandohohmeier/repos","events_url":"https://api.github.com/users/orlandohohmeier/events{/privacy}","received_events_url":"https://api.github.com/users/orlandohohmeier/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":34,"state":"open","created_at":"2017-04-21T13:04:05Z","updated_at":"2018-09-20T09:09:46Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-09-19T10:23:42Z","updated_at":"2018-09-20T18:05:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/3299","html_url":"https://github.com/dcos/dcos-ui/pull/3299","diff_url":"https://github.com/dcos/dcos-ui/pull/3299.diff","patch_url":"https://github.com/dcos/dcos-ui/pull/3299.patch"},"body":"backport for https://github.com/dcos/dcos-ui/pull/3234 with some minor fixes\r\n\r\nHalf of https://jira.mesosphere.com/browse/DCOS-42035\r\n\r\nThis branch was created using @DanielMSchmidt 's tool https://github.com/DanielMSchmidt/backporter which works great.\r\n\r\n## Testing\r\n1. Switch to branch 1.10 and set up node to use version 4.4.7 and npm to use version 3.9.6\r\nI recommend using a new copy of the dcos-ui repository.\r\nSetting up node is easy: just use a node version manager (I used https://github.com/creationix/nvm) and run (if you are using nvm) `nvm install 4.4.7` in the directory. Setting up npm is a bit trickier - navigate to the nvm directory, for example `cd ~/.nvm/versions/node/v4.4.7/lib` and run `npm install npm@3.9.6`.\r\nThen run `npm install`.\r\n2. Test the changes\r\nClick on Services Tab\r\nClick `+` or `Run a Service` to add a new service\r\nClick on Single Container\r\nClick on Environment\r\nClick on `Add Environment Variable`\r\nEnter a `Value` without entering `Key`\r\nVerify that an error message is shown\r\nTest the same thing for a Multi-Container\r\n\r\n## Trade-offs\r\nNone\r\n\r\n## Dependencies\r\nNone\r\n\r\n## Screenshots\r\n\r\n### Before\r\n![peek 2018-09-19 13-13](https://user-images.githubusercontent.com/40791275/45747623-181ec080-bc0f-11e8-95da-e863b23620de.gif)\r\n\r\n### After\r\n![peek 2018-09-19 13-15](https://user-images.githubusercontent.com/40791275/45747627-1bb24780-bc0f-11e8-8986-718867f4b9b7.gif)\r\n\r\n### After with css change\r\n![peek 2018-09-19 13-17](https://user-images.githubusercontent.com/40791275/45747634-210f9200-bc0f-11e8-8a2d-a84648cedd96.gif)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments/423279257","html_url":"https://github.com/dcos/dcos-ui/pull/3299#issuecomment-423279257","issue_url":"https://api.github.com/repos/dcos/dcos-ui/issues/3299","id":423279257,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzI3OTI1Nw==","user":{"login":"natmegs","id":19582796,"node_id":"MDQ6VXNlcjE5NTgyNzk2","avatar_url":"https://avatars1.githubusercontent.com/u/19582796?v=4","gravatar_id":"","url":"https://api.github.com/users/natmegs","html_url":"https://github.com/natmegs","followers_url":"https://api.github.com/users/natmegs/followers","following_url":"https://api.github.com/users/natmegs/following{/other_user}","gists_url":"https://api.github.com/users/natmegs/gists{/gist_id}","starred_url":"https://api.github.com/users/natmegs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natmegs/subscriptions","organizations_url":"https://api.github.com/users/natmegs/orgs","repos_url":"https://api.github.com/users/natmegs/repos","events_url":"https://api.github.com/users/natmegs/events{/privacy}","received_events_url":"https://api.github.com/users/natmegs/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T18:05:27Z","updated_at":"2018-09-20T18:05:27Z","author_association":"CONTRIBUTOR","body":"run system tests"}}
{"actor":{"display_login":"natmegs"}}