{"action":"created","comment":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments/223984560","pull_request_review_id":163241782,"id":223984560,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzk4NDU2MA==","diff_hunk":"@@ -521,9 +556,629 @@ paths:\n         200:\n           description: Account information on the blockchain\n           schema:\n-            $ref: \"#/definitions/AccountQueryResponse\"\n+            type: object\n+            properties:\n+              type:\n+                type: string\n+              value:\n+                type: object\n+                properties:\n+                  account_number:\n+                    type: string\n+                  address:\n+                    type: string\n+                  coins:\n+                    type: array\n+                    items:\n+                      $ref: \"#/definitions/Coin\"\n+                  public_key:\n+                    type: string\n+                  sequence:\n+                    type: string\n         404:","path":"client/lcd/swagger-ui/swagger.yaml","position":162,"original_position":162,"commit_id":"4ba59c7333e966df67898de5000e231c4a66cbab","original_commit_id":"4ba59c7333e966df67898de5000e231c4a66cbab","user":{"login":"faboweb","id":5869273,"node_id":"MDQ6VXNlcjU4NjkyNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/5869273?v=4","gravatar_id":"","url":"https://api.github.com/users/faboweb","html_url":"https://github.com/faboweb","followers_url":"https://api.github.com/users/faboweb/followers","following_url":"https://api.github.com/users/faboweb/following{/other_user}","gists_url":"https://api.github.com/users/faboweb/gists{/gist_id}","starred_url":"https://api.github.com/users/faboweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faboweb/subscriptions","organizations_url":"https://api.github.com/users/faboweb/orgs","repos_url":"https://api.github.com/users/faboweb/repos","events_url":"https://api.github.com/users/faboweb/events{/privacy}","received_events_url":"https://api.github.com/users/faboweb/received_events","type":"User","site_admin":false},"body":"Did we choose to make this a 404? We don't know if someone holds that address but hasn't don't any transaction yet. Querying such an account would result in an error. I propose we do either serve a 400 or serve a default response with an empty account and a 200.","created_at":"2018-10-10T08:40:26Z","updated_at":"2018-10-10T08:40:26Z","html_url":"https://github.com/cosmos/cosmos-sdk/pull/2462#discussion_r223984560","pull_request_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2462","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments/223984560"},"html":{"href":"https://github.com/cosmos/cosmos-sdk/pull/2462#discussion_r223984560"},"pull_request":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2462"}}},"pull_request":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2462","id":221651379,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNjUxMzc5","html_url":"https://github.com/cosmos/cosmos-sdk/pull/2462","diff_url":"https://github.com/cosmos/cosmos-sdk/pull/2462.diff","patch_url":"https://github.com/cosmos/cosmos-sdk/pull/2462.patch","issue_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2462","number":2462,"state":"open","locked":false,"title":"[R4R]: add swagger-ui for gov, stake and slashing","user":{"login":"HaoyangLiu","id":2945006,"node_id":"MDQ6VXNlcjI5NDUwMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2945006?v=4","gravatar_id":"","url":"https://api.github.com/users/HaoyangLiu","html_url":"https://github.com/HaoyangLiu","followers_url":"https://api.github.com/users/HaoyangLiu/followers","following_url":"https://api.github.com/users/HaoyangLiu/following{/other_user}","gists_url":"https://api.github.com/users/HaoyangLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoyangLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoyangLiu/subscriptions","organizations_url":"https://api.github.com/users/HaoyangLiu/orgs","repos_url":"https://api.github.com/users/HaoyangLiu/repos","events_url":"https://api.github.com/users/HaoyangLiu/events{/privacy}","received_events_url":"https://api.github.com/users/HaoyangLiu/received_events","type":"User","site_admin":false},"body":"Main changes:\r\n* add swagger-ui for gov, stake and slashing\r\n* refactor swagger.yaml","created_at":"2018-10-10T03:53:54Z","updated_at":"2018-10-10T08:40:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04b8872f678148b02f01c8be04b0f5380b851297","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ebuchman","id":2300911,"node_id":"MDQ6VXNlcjIzMDA5MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2300911?v=4","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false},{"login":"rigelrozanski","id":20132176,"node_id":"MDQ6VXNlcjIwMTMyMTc2","avatar_url":"https://avatars1.githubusercontent.com/u/20132176?v=4","gravatar_id":"","url":"https://api.github.com/users/rigelrozanski","html_url":"https://github.com/rigelrozanski","followers_url":"https://api.github.com/users/rigelrozanski/followers","following_url":"https://api.github.com/users/rigelrozanski/following{/other_user}","gists_url":"https://api.github.com/users/rigelrozanski/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelrozanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelrozanski/subscriptions","organizations_url":"https://api.github.com/users/rigelrozanski/orgs","repos_url":"https://api.github.com/users/rigelrozanski/repos","events_url":"https://api.github.com/users/rigelrozanski/events{/privacy}","received_events_url":"https://api.github.com/users/rigelrozanski/received_events","type":"User","site_admin":false},{"login":"cwgoes","id":24760279,"node_id":"MDQ6VXNlcjI0NzYwMjc5","avatar_url":"https://avatars2.githubusercontent.com/u/24760279?v=4","gravatar_id":"","url":"https://api.github.com/users/cwgoes","html_url":"https://github.com/cwgoes","followers_url":"https://api.github.com/users/cwgoes/followers","following_url":"https://api.github.com/users/cwgoes/following{/other_user}","gists_url":"https://api.github.com/users/cwgoes/gists{/gist_id}","starred_url":"https://api.github.com/users/cwgoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwgoes/subscriptions","organizations_url":"https://api.github.com/users/cwgoes/orgs","repos_url":"https://api.github.com/users/cwgoes/repos","events_url":"https://api.github.com/users/cwgoes/events{/privacy}","received_events_url":"https://api.github.com/users/cwgoes/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2462/commits","review_comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2462/comments","review_comment_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2462/comments","statuses_url":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/4ba59c7333e966df67898de5000e231c4a66cbab","head":{"label":"HaoyangLiu:irisnet/swagger-ui-gov-stake","ref":"irisnet/swagger-ui-gov-stake","sha":"4ba59c7333e966df67898de5000e231c4a66cbab","user":{"login":"HaoyangLiu","id":2945006,"node_id":"MDQ6VXNlcjI5NDUwMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2945006?v=4","gravatar_id":"","url":"https://api.github.com/users/HaoyangLiu","html_url":"https://github.com/HaoyangLiu","followers_url":"https://api.github.com/users/HaoyangLiu/followers","following_url":"https://api.github.com/users/HaoyangLiu/following{/other_user}","gists_url":"https://api.github.com/users/HaoyangLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoyangLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoyangLiu/subscriptions","organizations_url":"https://api.github.com/users/HaoyangLiu/orgs","repos_url":"https://api.github.com/users/HaoyangLiu/repos","events_url":"https://api.github.com/users/HaoyangLiu/events{/privacy}","received_events_url":"https://api.github.com/users/HaoyangLiu/received_events","type":"User","site_admin":false},"repo":{"id":142951456,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5NTE0NTY=","name":"cosmos-sdk","full_name":"HaoyangLiu/cosmos-sdk","private":false,"owner":{"login":"HaoyangLiu","id":2945006,"node_id":"MDQ6VXNlcjI5NDUwMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2945006?v=4","gravatar_id":"","url":"https://api.github.com/users/HaoyangLiu","html_url":"https://github.com/HaoyangLiu","followers_url":"https://api.github.com/users/HaoyangLiu/followers","following_url":"https://api.github.com/users/HaoyangLiu/following{/other_user}","gists_url":"https://api.github.com/users/HaoyangLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoyangLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoyangLiu/subscriptions","organizations_url":"https://api.github.com/users/HaoyangLiu/orgs","repos_url":"https://api.github.com/users/HaoyangLiu/repos","events_url":"https://api.github.com/users/HaoyangLiu/events{/privacy}","received_events_url":"https://api.github.com/users/HaoyangLiu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/HaoyangLiu/cosmos-sdk","description":"Secure Blockchain Framework","fork":true,"url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk","forks_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/forks","keys_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/teams","hooks_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/hooks","issue_events_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/events","assignees_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/tags","blobs_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/languages","stargazers_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/stargazers","contributors_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/contributors","subscribers_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/subscribers","subscription_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/subscription","commits_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/merges","archive_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/downloads","issues_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/labels{/name}","releases_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/HaoyangLiu/cosmos-sdk/deployments","created_at":"2018-07-31T02:24:14Z","updated_at":"2018-09-26T05:07:08Z","pushed_at":"2018-10-10T06:59:29Z","git_url":"git://github.com/HaoyangLiu/cosmos-sdk.git","ssh_url":"git@github.com:HaoyangLiu/cosmos-sdk.git","clone_url":"https://github.com/HaoyangLiu/cosmos-sdk.git","svn_url":"https://github.com/HaoyangLiu/cosmos-sdk","homepage":"https://tendermint.com","size":41202,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cosmos:develop","ref":"develop","sha":"e25108867246083ade570525f6b3a0c6702a2138","user":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"repo":{"id":51193526,"node_id":"MDEwOlJlcG9zaXRvcnk1MTE5MzUyNg==","name":"cosmos-sdk","full_name":"cosmos/cosmos-sdk","private":false,"owner":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cosmos/cosmos-sdk","description":":chains: Well Designed Blockchain Framework :sparkles:","fork":false,"url":"https://api.github.com/repos/cosmos/cosmos-sdk","forks_url":"https://api.github.com/repos/cosmos/cosmos-sdk/forks","keys_url":"https://api.github.com/repos/cosmos/cosmos-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmos/cosmos-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmos/cosmos-sdk/teams","hooks_url":"https://api.github.com/repos/cosmos/cosmos-sdk/hooks","issue_events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/events","assignees_url":"https://api.github.com/repos/cosmos/cosmos-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/cosmos/cosmos-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/cosmos/cosmos-sdk/tags","blobs_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmos/cosmos-sdk/languages","stargazers_url":"https://api.github.com/repos/cosmos/cosmos-sdk/stargazers","contributors_url":"https://api.github.com/repos/cosmos/cosmos-sdk/contributors","subscribers_url":"https://api.github.com/repos/cosmos/cosmos-sdk/subscribers","subscription_url":"https://api.github.com/repos/cosmos/cosmos-sdk/subscription","commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmos/cosmos-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/cosmos/cosmos-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmos/cosmos-sdk/merges","archive_url":"https://api.github.com/repos/cosmos/cosmos-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmos/cosmos-sdk/downloads","issues_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmos/cosmos-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmos/cosmos-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels{/name}","releases_url":"https://api.github.com/repos/cosmos/cosmos-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/deployments","created_at":"2016-02-06T07:15:53Z","updated_at":"2018-10-09T21:34:13Z","pushed_at":"2018-10-10T07:09:34Z","git_url":"git://github.com/cosmos/cosmos-sdk.git","ssh_url":"git@github.com:cosmos/cosmos-sdk.git","clone_url":"https://github.com/cosmos/cosmos-sdk.git","svn_url":"https://github.com/cosmos/cosmos-sdk","homepage":"https://cosmos.network/","size":41476,"stargazers_count":622,"watchers_count":622,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":208,"mirror_url":null,"archived":false,"open_issues_count":324,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":208,"open_issues":324,"watchers":622,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2462"},"html":{"href":"https://github.com/cosmos/cosmos-sdk/pull/2462"},"issue":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2462"},"comments":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2462/comments"},"review_comments":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2462/comments"},"review_comment":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2462/commits"},"statuses":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/4ba59c7333e966df67898de5000e231c4a66cbab"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"faboweb"}}