{"action":"created","issue":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2883","repository_url":"https://api.github.com/repos/input-output-hk/cardano-sl","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2883/labels{/name}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2883/comments","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2883/events","html_url":"https://github.com/input-output-hk/cardano-sl/pull/2883","id":321044828,"number":2883,"title":"Enforce building of benchmark programs in CI","user":{"login":"erikd","id":307277,"avatar_url":"https://avatars0.githubusercontent.com/u/307277?v=4","gravatar_id":"","url":"https://api.github.com/users/erikd","html_url":"https://github.com/erikd","followers_url":"https://api.github.com/users/erikd/followers","following_url":"https://api.github.com/users/erikd/following{/other_user}","gists_url":"https://api.github.com/users/erikd/gists{/gist_id}","starred_url":"https://api.github.com/users/erikd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikd/subscriptions","organizations_url":"https://api.github.com/users/erikd/orgs","repos_url":"https://api.github.com/users/erikd/repos","events_url":"https://api.github.com/users/erikd/events{/privacy}","received_events_url":"https://api.github.com/users/erikd/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-08T05:14:02Z","updated_at":"2018-05-18T06:29:51Z","closed_at":"2018-05-18T06:29:51Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2883","html_url":"https://github.com/input-output-hk/cardano-sl/pull/2883","diff_url":"https://github.com/input-output-hk/cardano-sl/pull/2883.diff","patch_url":"https://github.com/input-output-hk/cardano-sl/pull/2883.patch"},"body":"## Description\r\n\r\nUp until now, benchmark programs have not been built in CI. This meant that changes to a library that breaks a benchmark would often go un-noticed for some time.\r\n\r\nThis PR makes sure all benchmark programs are built, but not run.\r\n\r\n## Linked issue\r\n\r\nN/A\r\n\r\n## Type of change\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply and `~` in the ones that do not: -->\r\n- [ ] 🐞 Bug fix (non-breaking change which fixes an issue)\r\n- [ ] 🛠 New feature (non-breaking change which adds functionality)\r\n- [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc\r\n- [x] 🔨 New or improved tests for existing code\r\n- [ ] ⛑ git-flow chore (backport, hotfix, etc)\r\n\r\n## Developer checklist\r\n<!--- A mental checklist for the developer submitting the PR. Put an `x` in all the boxes that apply and `~` in the ones that do not: --->\r\n- [ ] I have read the [style guide](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/style-guide.md) document, and my code follows the code style of this project.\r\n- [ ] If my code deals with exceptions, it follows the [guidelines](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/exceptions.md).\r\n- [ ] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on [cardanodocs.com](https://github.com/input-output-hk/cardanodocs.com), amending the inline [Haddock](https://www.haskell.org/haddock/) comments, any relevant README file or one of the document listed in the [docs](https://github.com/input-output-hk/cardano-sl/tree/develop/docs) directory.\r\n\r\n## Testing checklist\r\n<!-- If you aren't providing any tests as part of this PR, use this section to state clearly why. It needs to be a strong motivation and definitely the exception, not the rule. -->\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n## QA Steps\r\n<!--- Which are the steps needed to test this feature, if any? -->\r\n\r\n## Screenshots (if available)\r\n<!--- Upload a GIF, an asciinema video or an image demoing the feature -->\r\n"},"comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments/390108088","html_url":"https://github.com/input-output-hk/cardano-sl/pull/2883#issuecomment-390108088","issue_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2883","id":390108088,"user":{"login":"erikd","id":307277,"avatar_url":"https://avatars0.githubusercontent.com/u/307277?v=4","gravatar_id":"","url":"https://api.github.com/users/erikd","html_url":"https://github.com/erikd","followers_url":"https://api.github.com/users/erikd/followers","following_url":"https://api.github.com/users/erikd/following{/other_user}","gists_url":"https://api.github.com/users/erikd/gists{/gist_id}","starred_url":"https://api.github.com/users/erikd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikd/subscriptions","organizations_url":"https://api.github.com/users/erikd/orgs","repos_url":"https://api.github.com/users/erikd/repos","events_url":"https://api.github.com/users/erikd/events{/privacy}","received_events_url":"https://api.github.com/users/erikd/received_events","type":"User","site_admin":false},"created_at":"2018-05-18T06:29:51Z","updated_at":"2018-05-18T06:29:51Z","author_association":"MEMBER","body":"Closing this PR as the last commit proves that benchmark programs are now being build in CI."}}
{"actor":{"display_login":"erikd"}}