{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/226280736","pull_request_review_id":166062080,"id":226280736,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjI4MDczNg==","diff_hunk":"@@ -472,6 +472,15 @@ class BasicOperatorTable extends ReflectiveSqlOperatorTable {\n     ScalarSqlFunctions.REPEAT,\n     ScalarSqlFunctions.REGEXP_REPLACE,\n \n+    // MATCH_RECOGNIZE\n+    SqlStdOperatorTable.FIRST,\n+    SqlStdOperatorTable.LAST,\n+    SqlStdOperatorTable.PREV,\n+    SqlStdOperatorTable.NEXT,\n+    SqlStdOperatorTable.CLASSIFIER,","path":"flink-libraries/flink-table/src/main/scala/org/apache/flink/table/validate/FunctionCatalog.scala","position":9,"original_position":9,"commit_id":"de8d2e17d317bcc23f4206462e7f1fe2672c4ce7","original_commit_id":"fb54b2722214a40ba2a5ca988bbca01ff5910691","user":{"login":"dawidwys","id":6242259,"node_id":"MDQ6VXNlcjYyNDIyNTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6242259?v=4","gravatar_id":"","url":"https://api.github.com/users/dawidwys","html_url":"https://github.com/dawidwys","followers_url":"https://api.github.com/users/dawidwys/followers","following_url":"https://api.github.com/users/dawidwys/following{/other_user}","gists_url":"https://api.github.com/users/dawidwys/gists{/gist_id}","starred_url":"https://api.github.com/users/dawidwys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawidwys/subscriptions","organizations_url":"https://api.github.com/users/dawidwys/orgs","repos_url":"https://api.github.com/users/dawidwys/repos","events_url":"https://api.github.com/users/dawidwys/events{/privacy}","received_events_url":"https://api.github.com/users/dawidwys/received_events","type":"User","site_admin":false},"body":"I've dropped `CLASSIFIER`, `MATCH_NUMBER` and `NEXT`. \r\n\r\nCannot drop `RUNNING` cause it is needed for `ALL ROWS PER MATCH`. We do not support it, but in order to throw meaningful exception it has to go through the validation.","created_at":"2018-10-18T12:17:08Z","updated_at":"2018-10-18T12:17:08Z","html_url":"https://github.com/apache/flink/pull/6815#discussion_r226280736","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/6815","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/226280736"},"html":{"href":"https://github.com/apache/flink/pull/6815#discussion_r226280736"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/6815"}},"in_reply_to_id":226183576},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/6815","id":221773948,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNzczOTQ4","html_url":"https://github.com/apache/flink/pull/6815","diff_url":"https://github.com/apache/flink/pull/6815.diff","patch_url":"https://github.com/apache/flink/pull/6815.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/6815","number":6815,"state":"open","locked":false,"title":" [FLINK-7062][cep][table] Added basic support for MATCH_RECOGNIZE","user":{"login":"dawidwys","id":6242259,"node_id":"MDQ6VXNlcjYyNDIyNTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6242259?v=4","gravatar_id":"","url":"https://api.github.com/users/dawidwys","html_url":"https://github.com/dawidwys","followers_url":"https://api.github.com/users/dawidwys/followers","following_url":"https://api.github.com/users/dawidwys/following{/other_user}","gists_url":"https://api.github.com/users/dawidwys/gists{/gist_id}","starred_url":"https://api.github.com/users/dawidwys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawidwys/subscriptions","organizations_url":"https://api.github.com/users/dawidwys/orgs","repos_url":"https://api.github.com/users/dawidwys/repos","events_url":"https://api.github.com/users/dawidwys/events{/privacy}","received_events_url":"https://api.github.com/users/dawidwys/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\nThis commit adds basic support of MATCH_RECOGNIZE to SQL using CEP library. It is a follow up of work from @dianfu from PR: #4502 \r\n\r\n\r\n## Brief change log\r\n\r\n  - translating MATCH_RECOGNIZE to CEP library building blocks\r\n  -  9ba70a8 -  changed names assigned to CEP operators to distinguish between keyed and non-keyed\r\n  - b2afb2a - fixed return type when time indicator is a result from aggregation\r\n  - da8c225 - throw exception when we were to skip to first element of match \r\n\r\n## Verifying this change\r\n\r\nThis change added tests and can be verified as follows:\r\n\r\n  - Validation tests: \r\n    - org.apache.flink.table.api.stream.sql.validation.MatchValidationTest\r\n    - org.apache.flink.table.runtime.stream.sql.MatchRecognizeITCase (validations that are performed only during plan translation)\r\n    - org.apache.flink.table.`match`.MatchRecognizeTest (validations that are performed during pattern translation)\r\n  - Query translation: org.apache.flink.table.api.stream.sql.MatchRecognizeTest\r\n  - IT cases: org.apache.flink.table.runtime.stream.sql.MatchRecognizeITCase\r\n  - Translation from MATCH_RECOGNIZE to CEP patterns: org.apache.flink.table.`match`.MatchRecognizeTest\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (**yes** / no)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)\r\n  - The serializers: (yes / **no** / don't know)\r\n  - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)\r\n  - The S3 file system connector: (yes / **no /** don't know)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (**yes** / no)\r\n  - documentation will be added in subsequent PR\r\n","created_at":"2018-10-10T12:41:26Z","updated_at":"2018-10-18T12:17:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b47035017f0c0a30045a896fdab46dbe2de4b771","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/6815/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/6815/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/6815/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/de8d2e17d317bcc23f4206462e7f1fe2672c4ce7","head":{"label":"dawidwys:flink7062","ref":"flink7062","sha":"de8d2e17d317bcc23f4206462e7f1fe2672c4ce7","user":{"login":"dawidwys","id":6242259,"node_id":"MDQ6VXNlcjYyNDIyNTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6242259?v=4","gravatar_id":"","url":"https://api.github.com/users/dawidwys","html_url":"https://github.com/dawidwys","followers_url":"https://api.github.com/users/dawidwys/followers","following_url":"https://api.github.com/users/dawidwys/following{/other_user}","gists_url":"https://api.github.com/users/dawidwys/gists{/gist_id}","starred_url":"https://api.github.com/users/dawidwys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawidwys/subscriptions","organizations_url":"https://api.github.com/users/dawidwys/orgs","repos_url":"https://api.github.com/users/dawidwys/repos","events_url":"https://api.github.com/users/dawidwys/events{/privacy}","received_events_url":"https://api.github.com/users/dawidwys/received_events","type":"User","site_admin":false},"repo":{"id":43764900,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzc2NDkwMA==","name":"flink","full_name":"dawidwys/flink","private":false,"owner":{"login":"dawidwys","id":6242259,"node_id":"MDQ6VXNlcjYyNDIyNTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6242259?v=4","gravatar_id":"","url":"https://api.github.com/users/dawidwys","html_url":"https://github.com/dawidwys","followers_url":"https://api.github.com/users/dawidwys/followers","following_url":"https://api.github.com/users/dawidwys/following{/other_user}","gists_url":"https://api.github.com/users/dawidwys/gists{/gist_id}","starred_url":"https://api.github.com/users/dawidwys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawidwys/subscriptions","organizations_url":"https://api.github.com/users/dawidwys/orgs","repos_url":"https://api.github.com/users/dawidwys/repos","events_url":"https://api.github.com/users/dawidwys/events{/privacy}","received_events_url":"https://api.github.com/users/dawidwys/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dawidwys/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/dawidwys/flink","forks_url":"https://api.github.com/repos/dawidwys/flink/forks","keys_url":"https://api.github.com/repos/dawidwys/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dawidwys/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dawidwys/flink/teams","hooks_url":"https://api.github.com/repos/dawidwys/flink/hooks","issue_events_url":"https://api.github.com/repos/dawidwys/flink/issues/events{/number}","events_url":"https://api.github.com/repos/dawidwys/flink/events","assignees_url":"https://api.github.com/repos/dawidwys/flink/assignees{/user}","branches_url":"https://api.github.com/repos/dawidwys/flink/branches{/branch}","tags_url":"https://api.github.com/repos/dawidwys/flink/tags","blobs_url":"https://api.github.com/repos/dawidwys/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dawidwys/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dawidwys/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/dawidwys/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dawidwys/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/dawidwys/flink/languages","stargazers_url":"https://api.github.com/repos/dawidwys/flink/stargazers","contributors_url":"https://api.github.com/repos/dawidwys/flink/contributors","subscribers_url":"https://api.github.com/repos/dawidwys/flink/subscribers","subscription_url":"https://api.github.com/repos/dawidwys/flink/subscription","commits_url":"https://api.github.com/repos/dawidwys/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/dawidwys/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/dawidwys/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/dawidwys/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/dawidwys/flink/contents/{+path}","compare_url":"https://api.github.com/repos/dawidwys/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dawidwys/flink/merges","archive_url":"https://api.github.com/repos/dawidwys/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dawidwys/flink/downloads","issues_url":"https://api.github.com/repos/dawidwys/flink/issues{/number}","pulls_url":"https://api.github.com/repos/dawidwys/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/dawidwys/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/dawidwys/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dawidwys/flink/labels{/name}","releases_url":"https://api.github.com/repos/dawidwys/flink/releases{/id}","deployments_url":"https://api.github.com/repos/dawidwys/flink/deployments","created_at":"2015-10-06T17:01:12Z","updated_at":"2018-10-04T07:46:10Z","pushed_at":"2018-10-17T15:58:54Z","git_url":"git://github.com/dawidwys/flink.git","ssh_url":"git@github.com:dawidwys/flink.git","clone_url":"https://github.com/dawidwys/flink.git","svn_url":"https://github.com/dawidwys/flink","homepage":null,"size":161984,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3566bb8987872b29aa88b8f7d5b0f122e74bd518","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-10-18T12:15:47Z","pushed_at":"2018-10-18T12:14:13Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":167533,"stargazers_count":4652,"watchers_count":4652,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2995,"mirror_url":null,"archived":false,"open_issues_count":376,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2995,"open_issues":376,"watchers":4652,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/6815"},"html":{"href":"https://github.com/apache/flink/pull/6815"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/6815"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/6815/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/6815/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/6815/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/de8d2e17d317bcc23f4206462e7f1fe2672c4ce7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dawidwys"}}