{"action":"created","issue":{"url":"https://api.github.com/repos/TechnionTDK/jbs-text2json/issues/49","repository_url":"https://api.github.com/repos/TechnionTDK/jbs-text2json","labels_url":"https://api.github.com/repos/TechnionTDK/jbs-text2json/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/TechnionTDK/jbs-text2json/issues/49/comments","events_url":"https://api.github.com/repos/TechnionTDK/jbs-text2json/issues/49/events","html_url":"https://github.com/TechnionTDK/jbs-text2json/issues/49","id":344737400,"node_id":"MDU6SXNzdWUzNDQ3Mzc0MDA=","number":49,"title":"Create a new Tanach parser","user":{"login":"omishali","id":3026479,"node_id":"MDQ6VXNlcjMwMjY0Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3026479?v=4","gravatar_id":"","url":"https://api.github.com/users/omishali","html_url":"https://github.com/omishali","followers_url":"https://api.github.com/users/omishali/followers","following_url":"https://api.github.com/users/omishali/following{/other_user}","gists_url":"https://api.github.com/users/omishali/gists{/gist_id}","starred_url":"https://api.github.com/users/omishali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omishali/subscriptions","organizations_url":"https://api.github.com/users/omishali/orgs","repos_url":"https://api.github.com/users/omishali/repos","events_url":"https://api.github.com/users/omishali/events{/privacy}","received_events_url":"https://api.github.com/users/omishali/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"orelkan","id":28227658,"node_id":"MDQ6VXNlcjI4MjI3NjU4","avatar_url":"https://avatars0.githubusercontent.com/u/28227658?v=4","gravatar_id":"","url":"https://api.github.com/users/orelkan","html_url":"https://github.com/orelkan","followers_url":"https://api.github.com/users/orelkan/followers","following_url":"https://api.github.com/users/orelkan/following{/other_user}","gists_url":"https://api.github.com/users/orelkan/gists{/gist_id}","starred_url":"https://api.github.com/users/orelkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orelkan/subscriptions","organizations_url":"https://api.github.com/users/orelkan/orgs","repos_url":"https://api.github.com/users/orelkan/repos","events_url":"https://api.github.com/users/orelkan/events{/privacy}","received_events_url":"https://api.github.com/users/orelkan/received_events","type":"User","site_admin":false},"assignees":[{"login":"orelkan","id":28227658,"node_id":"MDQ6VXNlcjI4MjI3NjU4","avatar_url":"https://avatars0.githubusercontent.com/u/28227658?v=4","gravatar_id":"","url":"https://api.github.com/users/orelkan","html_url":"https://github.com/orelkan","followers_url":"https://api.github.com/users/orelkan/followers","following_url":"https://api.github.com/users/orelkan/following{/other_user}","gists_url":"https://api.github.com/users/orelkan/gists{/gist_id}","starred_url":"https://api.github.com/users/orelkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orelkan/subscriptions","organizations_url":"https://api.github.com/users/orelkan/orgs","repos_url":"https://api.github.com/users/orelkan/repos","events_url":"https://api.github.com/users/orelkan/events{/privacy}","received_events_url":"https://api.github.com/users/orelkan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-07-26T08:05:41Z","updated_at":"2018-07-29T13:19:51Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"(Lets continue the conversation here. Create an issue for each task you are working on. If you need my attention, add @omishali once.)\r\n\r\nVery good work!\r\n\r\nSome comments:\r\n- Use the method addWithin in JbsParser.\r\n- Add an ending \":\" to pasuk text nikud.\r\n- No need to copy SEFARIM_TANACH_URI_EN? it is public.\r\n- Add a few public static methods to JbsUtils to get the different URIs. Then remove the private ones that you created and use them instead. Use these static methods whenever needed from the mefarshim parsers as well.\r\n  - String getPasukUri(int sefer, int perek, int pasuk)\r\n  - String getTanachPerekUri(int sefer, int perek)\r\n  - String getTorahParashaUri(int parasha)\r\n- Add more test: the number of parashot is 54, the number of perakim is 929.\r\n- tanach-packages: the position of a perek should continue and not restarted."},"comment":{"url":"https://api.github.com/repos/TechnionTDK/jbs-text2json/issues/comments/408677360","html_url":"https://github.com/TechnionTDK/jbs-text2json/issues/49#issuecomment-408677360","issue_url":"https://api.github.com/repos/TechnionTDK/jbs-text2json/issues/49","id":408677360,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODY3NzM2MA==","user":{"login":"omishali","id":3026479,"node_id":"MDQ6VXNlcjMwMjY0Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3026479?v=4","gravatar_id":"","url":"https://api.github.com/users/omishali","html_url":"https://github.com/omishali","followers_url":"https://api.github.com/users/omishali/followers","following_url":"https://api.github.com/users/omishali/following{/other_user}","gists_url":"https://api.github.com/users/omishali/gists{/gist_id}","starred_url":"https://api.github.com/users/omishali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omishali/subscriptions","organizations_url":"https://api.github.com/users/omishali/orgs","repos_url":"https://api.github.com/users/omishali/repos","events_url":"https://api.github.com/users/omishali/events{/privacy}","received_events_url":"https://api.github.com/users/omishali/received_events","type":"User","site_admin":false},"created_at":"2018-07-29T13:19:51Z","updated_at":"2018-07-29T13:19:51Z","author_association":"CONTRIBUTOR","body":"I also see it in my editor but I don't see it in GitHub in the json file...\n(now I see it for the text with nikud but not for the text without the\nnikud).\n\n‫בתאריך יום א׳, 29 ביולי 2018 ב-16:06 מאת ‪orelkan‬‏ <‪\nnotifications@github.com‬‏>:‬\n\n> I didn't understand why it didn't show at your files, because in my file\n> editor the \":\" character did exist.\n> This character in the nikud is different than the normal \":\" character (I\n> checked using character to number converters), so I assumed some editors\n> didn't show the character properly or something like that. So I decided to\n> manually replace the character with the normal \":\" character.\n> As I said, in my file editor (gedit on Ubuntu) I did see the whole nikud\n> line, including the hebrew \":\" character on the json file\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/TechnionTDK/jbs-text2json/issues/49#issuecomment-408676681>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AC4uL_O46zQ-GyHxs4E2sNM6-L8xuOS-ks5uLbNegaJpZM4VhW_q>\n> .\n>\n"}}
{"actor":{"display_login":"omishali"}}