{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/dev-kit/pulls/comments/238215346","pull_request_review_id":180699928,"id":238215346,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODIxNTM0Ng==","diff_hunk":"@@ -42,6 +42,7 @@ env:\n     - SYMFONY_DEPRECATIONS_HELPER=weak_vendors\n     - TARGET=test\n     - UPSTREAM_URL=https://github.com/sonata-project/{{ repository_name }}.git\n+    - PHPUNIT_VERSION={{ '5.6' in php ? '5.7', '7' }}","path":"project/.travis.yml.twig","position":4,"original_position":4,"commit_id":"389342f63673e321629ecb56710a41867e76d523","original_commit_id":"389342f63673e321629ecb56710a41867e76d523","user":{"login":"greg0ire","id":657779,"node_id":"MDQ6VXNlcjY1Nzc3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/657779?v=4","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"body":"Woops","created_at":"2018-12-03T10:33:55Z","updated_at":"2018-12-03T10:33:55Z","html_url":"https://github.com/sonata-project/dev-kit/pull/446#discussion_r238215346","pull_request_url":"https://api.github.com/repos/sonata-project/dev-kit/pulls/446","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/dev-kit/pulls/comments/238215346"},"html":{"href":"https://github.com/sonata-project/dev-kit/pull/446#discussion_r238215346"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/dev-kit/pulls/446"}},"in_reply_to_id":238189401},"pull_request":{"url":"https://api.github.com/repos/sonata-project/dev-kit/pulls/446","id":234542215,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NTQyMjE1","html_url":"https://github.com/sonata-project/dev-kit/pull/446","diff_url":"https://github.com/sonata-project/dev-kit/pull/446.diff","patch_url":"https://github.com/sonata-project/dev-kit/pull/446.patch","issue_url":"https://api.github.com/repos/sonata-project/dev-kit/issues/446","number":446,"state":"open","locked":false,"title":"Use a better strategy to pick the phpunit version","user":{"login":"greg0ire","id":657779,"node_id":"MDQ6VXNlcjY1Nzc3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/657779?v=4","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"body":"Right now, repositories like the SonataArticleBundle one use phpunit 5.7\r\non their stable branch even though they only support php 7 and could use\r\nphpunit 7. This moves the condition in the .travis.yml, meaning it will\r\nbe computed by Twig. We do not need bash conditions since we have one\r\n.travis.yml per branch.","created_at":"2018-11-29T08:05:16Z","updated_at":"2018-12-03T10:33:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a795c921e67dd0490cb14a4a56139e9e851ae65e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"core23","id":3440437,"node_id":"MDQ6VXNlcjM0NDA0Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/3440437?v=4","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},{"login":"kunicmarko20","id":13528674,"node_id":"MDQ6VXNlcjEzNTI4Njc0","avatar_url":"https://avatars3.githubusercontent.com/u/13528674?v=4","gravatar_id":"","url":"https://api.github.com/users/kunicmarko20","html_url":"https://github.com/kunicmarko20","followers_url":"https://api.github.com/users/kunicmarko20/followers","following_url":"https://api.github.com/users/kunicmarko20/following{/other_user}","gists_url":"https://api.github.com/users/kunicmarko20/gists{/gist_id}","starred_url":"https://api.github.com/users/kunicmarko20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunicmarko20/subscriptions","organizations_url":"https://api.github.com/users/kunicmarko20/orgs","repos_url":"https://api.github.com/users/kunicmarko20/repos","events_url":"https://api.github.com/users/kunicmarko20/events{/privacy}","received_events_url":"https://api.github.com/users/kunicmarko20/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":350522984,"node_id":"MDU6TGFiZWwzNTA1MjI5ODQ=","url":"https://api.github.com/repos/sonata-project/dev-kit/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/dev-kit/pulls/446/commits","review_comments_url":"https://api.github.com/repos/sonata-project/dev-kit/pulls/446/comments","review_comment_url":"https://api.github.com/repos/sonata-project/dev-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/dev-kit/issues/446/comments","statuses_url":"https://api.github.com/repos/sonata-project/dev-kit/statuses/389342f63673e321629ecb56710a41867e76d523","head":{"label":"greg0ire:phpunit_version","ref":"phpunit_version","sha":"389342f63673e321629ecb56710a41867e76d523","user":{"login":"greg0ire","id":657779,"node_id":"MDQ6VXNlcjY1Nzc3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/657779?v=4","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"repo":{"id":56678726,"node_id":"MDEwOlJlcG9zaXRvcnk1NjY3ODcyNg==","name":"dev-kit","full_name":"greg0ire/dev-kit","private":false,"owner":{"login":"greg0ire","id":657779,"node_id":"MDQ6VXNlcjY1Nzc3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/657779?v=4","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"html_url":"https://github.com/greg0ire/dev-kit","description":null,"fork":true,"url":"https://api.github.com/repos/greg0ire/dev-kit","forks_url":"https://api.github.com/repos/greg0ire/dev-kit/forks","keys_url":"https://api.github.com/repos/greg0ire/dev-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greg0ire/dev-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greg0ire/dev-kit/teams","hooks_url":"https://api.github.com/repos/greg0ire/dev-kit/hooks","issue_events_url":"https://api.github.com/repos/greg0ire/dev-kit/issues/events{/number}","events_url":"https://api.github.com/repos/greg0ire/dev-kit/events","assignees_url":"https://api.github.com/repos/greg0ire/dev-kit/assignees{/user}","branches_url":"https://api.github.com/repos/greg0ire/dev-kit/branches{/branch}","tags_url":"https://api.github.com/repos/greg0ire/dev-kit/tags","blobs_url":"https://api.github.com/repos/greg0ire/dev-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greg0ire/dev-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greg0ire/dev-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/greg0ire/dev-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greg0ire/dev-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/greg0ire/dev-kit/languages","stargazers_url":"https://api.github.com/repos/greg0ire/dev-kit/stargazers","contributors_url":"https://api.github.com/repos/greg0ire/dev-kit/contributors","subscribers_url":"https://api.github.com/repos/greg0ire/dev-kit/subscribers","subscription_url":"https://api.github.com/repos/greg0ire/dev-kit/subscription","commits_url":"https://api.github.com/repos/greg0ire/dev-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/greg0ire/dev-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/greg0ire/dev-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/greg0ire/dev-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/greg0ire/dev-kit/contents/{+path}","compare_url":"https://api.github.com/repos/greg0ire/dev-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greg0ire/dev-kit/merges","archive_url":"https://api.github.com/repos/greg0ire/dev-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greg0ire/dev-kit/downloads","issues_url":"https://api.github.com/repos/greg0ire/dev-kit/issues{/number}","pulls_url":"https://api.github.com/repos/greg0ire/dev-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/greg0ire/dev-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/greg0ire/dev-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greg0ire/dev-kit/labels{/name}","releases_url":"https://api.github.com/repos/greg0ire/dev-kit/releases{/id}","deployments_url":"https://api.github.com/repos/greg0ire/dev-kit/deployments","created_at":"2016-04-20T10:42:33Z","updated_at":"2016-03-31T12:54:15Z","pushed_at":"2018-12-02T12:09:09Z","git_url":"git://github.com/greg0ire/dev-kit.git","ssh_url":"git@github.com:greg0ire/dev-kit.git","clone_url":"https://github.com/greg0ire/dev-kit.git","svn_url":"https://github.com/greg0ire/dev-kit","homepage":null,"size":390,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:master","ref":"master","sha":"a1bd1ec1a5121647db9b4678d266387d8efe5a41","user":{"login":"sonata-project","id":404157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":55150410,"node_id":"MDEwOlJlcG9zaXRvcnk1NTE1MDQxMA==","name":"dev-kit","full_name":"sonata-project/dev-kit","private":false,"owner":{"login":"sonata-project","id":404157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sonata-project/dev-kit","description":null,"fork":false,"url":"https://api.github.com/repos/sonata-project/dev-kit","forks_url":"https://api.github.com/repos/sonata-project/dev-kit/forks","keys_url":"https://api.github.com/repos/sonata-project/dev-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/dev-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/dev-kit/teams","hooks_url":"https://api.github.com/repos/sonata-project/dev-kit/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/dev-kit/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/dev-kit/events","assignees_url":"https://api.github.com/repos/sonata-project/dev-kit/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/dev-kit/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/dev-kit/tags","blobs_url":"https://api.github.com/repos/sonata-project/dev-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/dev-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/dev-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/dev-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/dev-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/dev-kit/languages","stargazers_url":"https://api.github.com/repos/sonata-project/dev-kit/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/dev-kit/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/dev-kit/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/dev-kit/subscription","commits_url":"https://api.github.com/repos/sonata-project/dev-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/dev-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/dev-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/dev-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/dev-kit/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/dev-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/dev-kit/merges","archive_url":"https://api.github.com/repos/sonata-project/dev-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/dev-kit/downloads","issues_url":"https://api.github.com/repos/sonata-project/dev-kit/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/dev-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/dev-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/dev-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/dev-kit/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/dev-kit/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/dev-kit/deployments","created_at":"2016-03-31T12:54:15Z","updated_at":"2018-12-03T09:15:06Z","pushed_at":"2018-12-03T09:15:03Z","git_url":"git://github.com/sonata-project/dev-kit.git","ssh_url":"git@github.com:sonata-project/dev-kit.git","clone_url":"https://github.com/sonata-project/dev-kit.git","svn_url":"https://github.com/sonata-project/dev-kit","homepage":null,"size":372,"stargazers_count":17,"watchers_count":17,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":64,"license":null,"forks":27,"open_issues":64,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/dev-kit/pulls/446"},"html":{"href":"https://github.com/sonata-project/dev-kit/pull/446"},"issue":{"href":"https://api.github.com/repos/sonata-project/dev-kit/issues/446"},"comments":{"href":"https://api.github.com/repos/sonata-project/dev-kit/issues/446/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/dev-kit/pulls/446/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/dev-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/dev-kit/pulls/446/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/dev-kit/statuses/389342f63673e321629ecb56710a41867e76d523"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"greg0ire"}}