{"action":"created","issue":{"url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1113","repository_url":"https://api.github.com/repos/AliceO2Group/AliceO2","labels_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1113/labels{/name}","comments_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1113/comments","events_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1113/events","html_url":"https://github.com/AliceO2Group/AliceO2/pull/1113","id":326118471,"number":1113,"title":"Allow the creation of a(n almost) full geometry w/o a prior VMC instance","user":{"login":"aphecetche","id":1566009,"avatar_url":"https://avatars3.githubusercontent.com/u/1566009?v=4","gravatar_id":"","url":"https://api.github.com/users/aphecetche","html_url":"https://github.com/aphecetche","followers_url":"https://api.github.com/users/aphecetche/followers","following_url":"https://api.github.com/users/aphecetche/following{/other_user}","gists_url":"https://api.github.com/users/aphecetche/gists{/gist_id}","starred_url":"https://api.github.com/users/aphecetche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aphecetche/subscriptions","organizations_url":"https://api.github.com/users/aphecetche/orgs","repos_url":"https://api.github.com/users/aphecetche/repos","events_url":"https://api.github.com/users/aphecetche/events{/privacy}","received_events_url":"https://api.github.com/users/aphecetche/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-05-24T13:19:19Z","updated_at":"2018-05-24T17:45:54Z","closed_at":"2018-05-24T15:51:03Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/1113","html_url":"https://github.com/AliceO2Group/AliceO2/pull/1113","diff_url":"https://github.com/AliceO2Group/AliceO2/pull/1113.diff","patch_url":"https://github.com/AliceO2Group/AliceO2/pull/1113.patch"},"body":"Decoupling TGeo material creation from VMC (i.e. can now build TGeo material without having to instantiate first a TGeant3TGeo or TGeant4 object)\r\n\r\nThis is done by inverting the current responsabilities. TGeo is now the master in charge of\r\n creating the geometry, and VMC is just the client taking the geometry\r\n from TGeo (and possibly tweaking media properties which cannot be\r\n handled by TGeo itself).\r\n\r\nThe net advantage is to get a lighter dependency tree and is useful e.g. to build a geometry within a unit test."},"comment":{"url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/comments/391801376","html_url":"https://github.com/AliceO2Group/AliceO2/pull/1113#issuecomment-391801376","issue_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/1113","id":391801376,"user":{"login":"sawenzel","id":3536753,"avatar_url":"https://avatars1.githubusercontent.com/u/3536753?v=4","gravatar_id":"","url":"https://api.github.com/users/sawenzel","html_url":"https://github.com/sawenzel","followers_url":"https://api.github.com/users/sawenzel/followers","following_url":"https://api.github.com/users/sawenzel/following{/other_user}","gists_url":"https://api.github.com/users/sawenzel/gists{/gist_id}","starred_url":"https://api.github.com/users/sawenzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sawenzel/subscriptions","organizations_url":"https://api.github.com/users/sawenzel/orgs","repos_url":"https://api.github.com/users/sawenzel/repos","events_url":"https://api.github.com/users/sawenzel/events{/privacy}","received_events_url":"https://api.github.com/users/sawenzel/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T17:45:54Z","updated_at":"2018-05-24T17:45:54Z","author_association":"CONTRIBUTOR","body":"Well for the moment you could just use in the MaterialManager (like in Detector): `if(vmc) { } else {\r\n// use ROOT\r\n}`\r\n\r\nThis should leave the simulation intact and allowing you to test geometry standalone.\r\n"}}
{"actor":{"display_login":"sawenzel"}}