{"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/comments/165804968","pull_request_review_id":93807170,"id":165804968,"diff_hunk":"@@ -122,7 +125,16 @@ class Node {\n       this.path = initOpts.directory\n     }\n \n-    const args = ['init', '-b', initOpts.keysize || 2048]\n+    let keysize = initOpts.keysize\n+    if (!keysize) {\n+      if (typeof global.it === 'function') {","path":"src/daemon-node.js","position":23,"original_position":23,"commit_id":"5e66ffda9eb65ff8a79115782409a390dd13c8ea","original_commit_id":"5e66ffda9eb65ff8a79115782409a390dd13c8ea","user":{"login":"dryajov","id":1094341,"avatar_url":"https://avatars1.githubusercontent.com/u/1094341?v=4","gravatar_id":"","url":"https://api.github.com/users/dryajov","html_url":"https://github.com/dryajov","followers_url":"https://api.github.com/users/dryajov/followers","following_url":"https://api.github.com/users/dryajov/following{/other_user}","gists_url":"https://api.github.com/users/dryajov/gists{/gist_id}","starred_url":"https://api.github.com/users/dryajov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryajov/subscriptions","organizations_url":"https://api.github.com/users/dryajov/orgs","repos_url":"https://api.github.com/users/dryajov/repos","events_url":"https://api.github.com/users/dryajov/events{/privacy}","received_events_url":"https://api.github.com/users/dryajov/received_events","type":"User","site_admin":false},"body":"also, checking for `global.it` ties us to mocha and feels a bit iffy...","created_at":"2018-02-03T04:49:02Z","updated_at":"2018-02-03T04:49:02Z","html_url":"https://github.com/ipfs/js-ipfsd-ctl/pull/198#discussion_r165804968","pull_request_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/198","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/comments/165804968"},"html":{"href":"https://github.com/ipfs/js-ipfsd-ctl/pull/198#discussion_r165804968"},"pull_request":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/198"}},"in_reply_to_id":165804737},"pull_request":{"url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/198","id":166943499,"html_url":"https://github.com/ipfs/js-ipfsd-ctl/pull/198","diff_url":"https://github.com/ipfs/js-ipfsd-ctl/pull/198.diff","patch_url":"https://github.com/ipfs/js-ipfsd-ctl/pull/198.patch","issue_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/198","number":198,"state":"open","locked":false,"title":"Smaller key size when testing","user":{"login":"richardschneider","id":631061,"avatar_url":"https://avatars2.githubusercontent.com/u/631061?v=4","gravatar_id":"","url":"https://api.github.com/users/richardschneider","html_url":"https://github.com/richardschneider","followers_url":"https://api.github.com/users/richardschneider/followers","following_url":"https://api.github.com/users/richardschneider/following{/other_user}","gists_url":"https://api.github.com/users/richardschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/richardschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardschneider/subscriptions","organizations_url":"https://api.github.com/users/richardschneider/orgs","repos_url":"https://api.github.com/users/richardschneider/repos","events_url":"https://api.github.com/users/richardschneider/events{/privacy}","received_events_url":"https://api.github.com/users/richardschneider/received_events","type":"User","site_admin":false},"body":"A 2048 bit RSA key can take up to 20 seconds to generate.  When testing, a smaller key size can be used.\r\n\r\nFor `js-ipfs` a 512 bit key size is used.  For `go-ipfs`, because it enforces minimum key size, 1024 bits is used.","created_at":"2018-02-03T03:16:41Z","updated_at":"2018-02-03T04:49:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bbd13425ee5c1f8d32c444059d3f69373db42aa","assignee":{"login":"richardschneider","id":631061,"avatar_url":"https://avatars2.githubusercontent.com/u/631061?v=4","gravatar_id":"","url":"https://api.github.com/users/richardschneider","html_url":"https://github.com/richardschneider","followers_url":"https://api.github.com/users/richardschneider/followers","following_url":"https://api.github.com/users/richardschneider/following{/other_user}","gists_url":"https://api.github.com/users/richardschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/richardschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardschneider/subscriptions","organizations_url":"https://api.github.com/users/richardschneider/orgs","repos_url":"https://api.github.com/users/richardschneider/repos","events_url":"https://api.github.com/users/richardschneider/events{/privacy}","received_events_url":"https://api.github.com/users/richardschneider/received_events","type":"User","site_admin":false},"assignees":[{"login":"richardschneider","id":631061,"avatar_url":"https://avatars2.githubusercontent.com/u/631061?v=4","gravatar_id":"","url":"https://api.github.com/users/richardschneider","html_url":"https://github.com/richardschneider","followers_url":"https://api.github.com/users/richardschneider/followers","following_url":"https://api.github.com/users/richardschneider/following{/other_user}","gists_url":"https://api.github.com/users/richardschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/richardschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardschneider/subscriptions","organizations_url":"https://api.github.com/users/richardschneider/orgs","repos_url":"https://api.github.com/users/richardschneider/repos","events_url":"https://api.github.com/users/richardschneider/events{/privacy}","received_events_url":"https://api.github.com/users/richardschneider/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars0.githubusercontent.com/u/1211152?v=4","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/198/commits","review_comments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/198/comments","review_comment_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/198/comments","statuses_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/statuses/5e66ffda9eb65ff8a79115782409a390dd13c8ea","head":{"label":"ipfs:small-keysize","ref":"small-keysize","sha":"5e66ffda9eb65ff8a79115782409a390dd13c8ea","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":34555538,"name":"js-ipfsd-ctl","full_name":"ipfs/js-ipfsd-ctl","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/js-ipfsd-ctl","description":"Control an IPFS daemon (go-ipfs or js-ipfs) using JavaScript!","fork":false,"url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl","forks_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/forks","keys_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/teams","hooks_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/hooks","issue_events_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/events","assignees_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/tags","blobs_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/languages","stargazers_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/stargazers","contributors_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/contributors","subscribers_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/subscribers","subscription_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/subscription","commits_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/merges","archive_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/downloads","issues_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/deployments","created_at":"2015-04-25T04:40:11Z","updated_at":"2018-01-26T19:37:05Z","pushed_at":"2018-02-03T04:31:43Z","git_url":"git://github.com/ipfs/js-ipfsd-ctl.git","ssh_url":"git@github.com:ipfs/js-ipfsd-ctl.git","clone_url":"https://github.com/ipfs/js-ipfsd-ctl.git","svn_url":"https://github.com/ipfs/js-ipfsd-ctl","homepage":"","size":237,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":21,"open_issues":10,"watchers":35,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"34ef8206721f8be3d74d627c2408bab84e75d786","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":34555538,"name":"js-ipfsd-ctl","full_name":"ipfs/js-ipfsd-ctl","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/js-ipfsd-ctl","description":"Control an IPFS daemon (go-ipfs or js-ipfs) using JavaScript!","fork":false,"url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl","forks_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/forks","keys_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/teams","hooks_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/hooks","issue_events_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/events","assignees_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/tags","blobs_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/languages","stargazers_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/stargazers","contributors_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/contributors","subscribers_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/subscribers","subscription_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/subscription","commits_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/merges","archive_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/downloads","issues_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/deployments","created_at":"2015-04-25T04:40:11Z","updated_at":"2018-01-26T19:37:05Z","pushed_at":"2018-02-03T04:31:43Z","git_url":"git://github.com/ipfs/js-ipfsd-ctl.git","ssh_url":"git@github.com:ipfs/js-ipfsd-ctl.git","clone_url":"https://github.com/ipfs/js-ipfsd-ctl.git","svn_url":"https://github.com/ipfs/js-ipfsd-ctl","homepage":"","size":237,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":21,"open_issues":10,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/198"},"html":{"href":"https://github.com/ipfs/js-ipfsd-ctl/pull/198"},"issue":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/198"},"comments":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/js-ipfsd-ctl/statuses/5e66ffda9eb65ff8a79115782409a390dd13c8ea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dryajov"}}