{"action":"opened","number":3005,"pull_request":{"url":"https://api.github.com/repos/apache/trafficcontrol/pulls/3005","id":229550060,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTUwMDYw","html_url":"https://github.com/apache/trafficcontrol/pull/3005","diff_url":"https://github.com/apache/trafficcontrol/pull/3005.diff","patch_url":"https://github.com/apache/trafficcontrol/pull/3005.patch","issue_url":"https://api.github.com/repos/apache/trafficcontrol/issues/3005","number":3005,"state":"open","locked":false,"title":"Fix optional vnc container","user":{"login":"JBevillC","id":40668095,"node_id":"MDQ6VXNlcjQwNjY4MDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40668095?v=4","gravatar_id":"","url":"https://api.github.com/users/JBevillC","html_url":"https://github.com/JBevillC","followers_url":"https://api.github.com/users/JBevillC/followers","following_url":"https://api.github.com/users/JBevillC/following{/other_user}","gists_url":"https://api.github.com/users/JBevillC/gists{/gist_id}","starred_url":"https://api.github.com/users/JBevillC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JBevillC/subscriptions","organizations_url":"https://api.github.com/users/JBevillC/orgs","repos_url":"https://api.github.com/users/JBevillC/repos","events_url":"https://api.github.com/users/JBevillC/events{/privacy}","received_events_url":"https://api.github.com/users/JBevillC/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n\r\nThis PR fixes a number of problems with the existing vnc `testclient` container:\r\n\r\n1) rename the container to `vnc` since that is it's purpose\r\n2) add `vnc.infra.ciab.test` hostname entry into the static dns server configuration.\r\n3) move the vnc container under the `optional` containers directory for better organization\r\n4) updates the shared volume required to get access to shared CA x509 SSL certificate\r\n5) fixes to allow firefox to start up in a  container without dbus or systemd\r\n6) default vnc password is now random by default. Override via environment at runtime.\r\n7) Port changed to 5909 to avoid port collision\r\n\r\nNew proposed directory structure for optional containers: \r\n```\r\ncdn-in-a-box/optional\r\ncdn-in-a-box/optional/docker-compose.$NAME.yml\r\ncdn-in-a-box/optional/$NAME/\r\n```\r\n\r\n#### Which TC components are affected by this PR?\r\n\r\n- [ ] Documentation\r\n- [ ] Grove\r\n- [ ] Traffic Analytics\r\n- [ ] Traffic Monitor\r\n- [ ] Traffic Ops\r\n- [ ] Traffic Ops ORT\r\n- [ ] Traffic Portal\r\n- [ ] Traffic Router\r\n- [ ] Traffic Stats\r\n- [ ] Traffic Vault\r\n- [ ] Other _________\r\n\r\n#### What is the best way to verify this PR?\r\n\r\n1) Add VNC_PASSWD with 6 digit password to variables.env\r\n2) Start up the CIAB stack using the following alias:\r\n```\r\nalias vdc='docker-compose -f docker-compose.yml -f docker-compose.testclient.yml'\r\nvdc build \r\nvdc kill && vdc rm -f \r\ndocker volume prune -f\r\nvdc up\r\n```\r\n3) Connect with vnc client to localhost 5909 with $VNC_PASSWD\r\n4) firefox should start as soon as the traffic portal is available.\r\n\r\n#### Check all that apply\r\n\r\n- [ ] This PR includes tests\r\n- [ ] This PR includes documentation updates\r\n- [ ] This PR includes an update to CHANGELOG.md\r\n- [ ] This PR includes all required license headers\r\n- [ ] This PR includes a database migration (ensure that migration sequence is correct)\r\n- [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)\r\n\r\n<!--\r\n    Licensed to the Apache Software Foundation (ASF) under one\r\n    or more contributor license agreements.  See the NOTICE file\r\n    distributed with this work for additional information\r\n    regarding copyright ownership.  The ASF licenses this file\r\n    to you under the Apache License, Version 2.0 (the\r\n    \"License\"); you may not use this file except in compliance\r\n    with the License.  You may obtain a copy of the License at\r\n\r\n      http://www.apache.org/licenses/LICENSE-2.0\r\n\r\n    Unless required by applicable law or agreed to in writing,\r\n    software distributed under the License is distributed on an\r\n    \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\r\n    KIND, either express or implied.  See the License for the\r\n    specific language governing permissions and limitations\r\n    under the License.\r\n-->\r\n\r\n\r\n\r\n","created_at":"2018-11-09T00:11:38Z","updated_at":"2018-11-09T00:11:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/trafficcontrol/pulls/3005/commits","review_comments_url":"https://api.github.com/repos/apache/trafficcontrol/pulls/3005/comments","review_comment_url":"https://api.github.com/repos/apache/trafficcontrol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficcontrol/issues/3005/comments","statuses_url":"https://api.github.com/repos/apache/trafficcontrol/statuses/96e42ffaa983a887a2f6df53253028110a59370e","head":{"label":"JBevillC:ciab_fix_vnc","ref":"ciab_fix_vnc","sha":"96e42ffaa983a887a2f6df53253028110a59370e","user":{"login":"JBevillC","id":40668095,"node_id":"MDQ6VXNlcjQwNjY4MDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40668095?v=4","gravatar_id":"","url":"https://api.github.com/users/JBevillC","html_url":"https://github.com/JBevillC","followers_url":"https://api.github.com/users/JBevillC/followers","following_url":"https://api.github.com/users/JBevillC/following{/other_user}","gists_url":"https://api.github.com/users/JBevillC/gists{/gist_id}","starred_url":"https://api.github.com/users/JBevillC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JBevillC/subscriptions","organizations_url":"https://api.github.com/users/JBevillC/orgs","repos_url":"https://api.github.com/users/JBevillC/repos","events_url":"https://api.github.com/users/JBevillC/events{/privacy}","received_events_url":"https://api.github.com/users/JBevillC/received_events","type":"User","site_admin":false},"repo":{"id":139054857,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwNTQ4NTc=","name":"trafficcontrol","full_name":"JBevillC/trafficcontrol","private":false,"owner":{"login":"JBevillC","id":40668095,"node_id":"MDQ6VXNlcjQwNjY4MDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40668095?v=4","gravatar_id":"","url":"https://api.github.com/users/JBevillC","html_url":"https://github.com/JBevillC","followers_url":"https://api.github.com/users/JBevillC/followers","following_url":"https://api.github.com/users/JBevillC/following{/other_user}","gists_url":"https://api.github.com/users/JBevillC/gists{/gist_id}","starred_url":"https://api.github.com/users/JBevillC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JBevillC/subscriptions","organizations_url":"https://api.github.com/users/JBevillC/orgs","repos_url":"https://api.github.com/users/JBevillC/repos","events_url":"https://api.github.com/users/JBevillC/events{/privacy}","received_events_url":"https://api.github.com/users/JBevillC/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JBevillC/trafficcontrol","description":"Apache Traffic Control","fork":true,"url":"https://api.github.com/repos/JBevillC/trafficcontrol","forks_url":"https://api.github.com/repos/JBevillC/trafficcontrol/forks","keys_url":"https://api.github.com/repos/JBevillC/trafficcontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JBevillC/trafficcontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JBevillC/trafficcontrol/teams","hooks_url":"https://api.github.com/repos/JBevillC/trafficcontrol/hooks","issue_events_url":"https://api.github.com/repos/JBevillC/trafficcontrol/issues/events{/number}","events_url":"https://api.github.com/repos/JBevillC/trafficcontrol/events","assignees_url":"https://api.github.com/repos/JBevillC/trafficcontrol/assignees{/user}","branches_url":"https://api.github.com/repos/JBevillC/trafficcontrol/branches{/branch}","tags_url":"https://api.github.com/repos/JBevillC/trafficcontrol/tags","blobs_url":"https://api.github.com/repos/JBevillC/trafficcontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JBevillC/trafficcontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JBevillC/trafficcontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/JBevillC/trafficcontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JBevillC/trafficcontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/JBevillC/trafficcontrol/languages","stargazers_url":"https://api.github.com/repos/JBevillC/trafficcontrol/stargazers","contributors_url":"https://api.github.com/repos/JBevillC/trafficcontrol/contributors","subscribers_url":"https://api.github.com/repos/JBevillC/trafficcontrol/subscribers","subscription_url":"https://api.github.com/repos/JBevillC/trafficcontrol/subscription","commits_url":"https://api.github.com/repos/JBevillC/trafficcontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/JBevillC/trafficcontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/JBevillC/trafficcontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/JBevillC/trafficcontrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/JBevillC/trafficcontrol/contents/{+path}","compare_url":"https://api.github.com/repos/JBevillC/trafficcontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JBevillC/trafficcontrol/merges","archive_url":"https://api.github.com/repos/JBevillC/trafficcontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JBevillC/trafficcontrol/downloads","issues_url":"https://api.github.com/repos/JBevillC/trafficcontrol/issues{/number}","pulls_url":"https://api.github.com/repos/JBevillC/trafficcontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/JBevillC/trafficcontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/JBevillC/trafficcontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JBevillC/trafficcontrol/labels{/name}","releases_url":"https://api.github.com/repos/JBevillC/trafficcontrol/releases{/id}","deployments_url":"https://api.github.com/repos/JBevillC/trafficcontrol/deployments","created_at":"2018-06-28T18:30:22Z","updated_at":"2018-10-08T21:07:41Z","pushed_at":"2018-11-09T00:06:55Z","git_url":"git://github.com/JBevillC/trafficcontrol.git","ssh_url":"git@github.com:JBevillC/trafficcontrol.git","clone_url":"https://github.com/JBevillC/trafficcontrol.git","svn_url":"https://github.com/JBevillC/trafficcontrol","homepage":"https://trafficcontrol.apache.org","size":79742,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"eb99b3af27fb89cba1e533375912cfd80d4b7f1b","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":67198520,"node_id":"MDEwOlJlcG9zaXRvcnk2NzE5ODUyMA==","name":"trafficcontrol","full_name":"apache/trafficcontrol","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/trafficcontrol","description":"Apache Traffic Control","fork":false,"url":"https://api.github.com/repos/apache/trafficcontrol","forks_url":"https://api.github.com/repos/apache/trafficcontrol/forks","keys_url":"https://api.github.com/repos/apache/trafficcontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficcontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficcontrol/teams","hooks_url":"https://api.github.com/repos/apache/trafficcontrol/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficcontrol/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficcontrol/events","assignees_url":"https://api.github.com/repos/apache/trafficcontrol/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficcontrol/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficcontrol/tags","blobs_url":"https://api.github.com/repos/apache/trafficcontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficcontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficcontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficcontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficcontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficcontrol/languages","stargazers_url":"https://api.github.com/repos/apache/trafficcontrol/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficcontrol/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficcontrol/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficcontrol/subscription","commits_url":"https://api.github.com/repos/apache/trafficcontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficcontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficcontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficcontrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficcontrol/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficcontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficcontrol/merges","archive_url":"https://api.github.com/repos/apache/trafficcontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficcontrol/downloads","issues_url":"https://api.github.com/repos/apache/trafficcontrol/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficcontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficcontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficcontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficcontrol/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficcontrol/releases{/id}","deployments_url":"https://api.github.com/repos/apache/trafficcontrol/deployments","created_at":"2016-09-02T07:00:06Z","updated_at":"2018-11-08T16:26:02Z","pushed_at":"2018-11-08T18:42:52Z","git_url":"git://github.com/apache/trafficcontrol.git","ssh_url":"git@github.com:apache/trafficcontrol.git","clone_url":"https://github.com/apache/trafficcontrol.git","svn_url":"https://github.com/apache/trafficcontrol","homepage":"https://trafficcontrol.apache.org","size":79628,"stargazers_count":245,"watchers_count":245,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":475,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":144,"open_issues":475,"watchers":245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficcontrol/pulls/3005"},"html":{"href":"https://github.com/apache/trafficcontrol/pull/3005"},"issue":{"href":"https://api.github.com/repos/apache/trafficcontrol/issues/3005"},"comments":{"href":"https://api.github.com/repos/apache/trafficcontrol/issues/3005/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficcontrol/pulls/3005/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficcontrol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficcontrol/pulls/3005/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficcontrol/statuses/96e42ffaa983a887a2f6df53253028110a59370e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":126,"deletions":79,"changed_files":9}}
{"actor":{"display_login":"JBevillC"}}