{"action":"created","comment":{"url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/pulls/comments/238449064","pull_request_review_id":180993159,"id":238449064,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODQ0OTA2NA==","diff_hunk":"@@ -3687,7 +3746,7 @@ BOOST_SERIALIZATION_ASSUME_ABSTRACT(NonCopyable)\n      * @param override\n      * @return true if sensor is registered with SensorManager, false if Sensor name is not unique\n      */\n-    void RegisterSensor(Sensor* pSensor, kt_bool override = false)\n+    void RegisterSensor(Sensor* pSensor, kt_bool override = true)","path":"include/open_karto/Karto.h","position":282,"original_position":282,"commit_id":"3ca0ecaa46fbc15a252ee4ed033e42428f7ac848","original_commit_id":"3ca0ecaa46fbc15a252ee4ed033e42428f7ac848","user":{"login":"ivonaj","id":22012105,"node_id":"MDQ6VXNlcjIyMDEyMTA1","avatar_url":"https://avatars0.githubusercontent.com/u/22012105?v=4","gravatar_id":"","url":"https://api.github.com/users/ivonaj","html_url":"https://github.com/ivonaj","followers_url":"https://api.github.com/users/ivonaj/followers","following_url":"https://api.github.com/users/ivonaj/following{/other_user}","gists_url":"https://api.github.com/users/ivonaj/gists{/gist_id}","starred_url":"https://api.github.com/users/ivonaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivonaj/subscriptions","organizations_url":"https://api.github.com/users/ivonaj/orgs","repos_url":"https://api.github.com/users/ivonaj/repos","events_url":"https://api.github.com/users/ivonaj/events{/privacy}","received_events_url":"https://api.github.com/users/ivonaj/received_events","type":"User","site_admin":false},"body":"when the  mapping continues and in case the same sensor is used it will override with the same name, otherwise it throws error: Cannot register sensor: already registered.","created_at":"2018-12-03T21:44:19Z","updated_at":"2018-12-03T21:53:24Z","html_url":"https://github.com/SteveMacenski/KartoSDK-slam_toolbox/pull/5#discussion_r238449064","pull_request_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/pulls/comments/238449064"},"html":{"href":"https://github.com/SteveMacenski/KartoSDK-slam_toolbox/pull/5#discussion_r238449064"},"pull_request":{"href":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/pulls/5"}},"in_reply_to_id":238446234},"pull_request":{"url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/pulls/5","id":234786554,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Nzg2NTU0","html_url":"https://github.com/SteveMacenski/KartoSDK-slam_toolbox/pull/5","diff_url":"https://github.com/SteveMacenski/KartoSDK-slam_toolbox/pull/5.diff","patch_url":"https://github.com/SteveMacenski/KartoSDK-slam_toolbox/pull/5.patch","issue_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/issues/5","number":5,"state":"open","locked":false,"title":"Serialization of mapper object","user":{"login":"ivonaj","id":22012105,"node_id":"MDQ6VXNlcjIyMDEyMTA1","avatar_url":"https://avatars0.githubusercontent.com/u/22012105?v=4","gravatar_id":"","url":"https://api.github.com/users/ivonaj","html_url":"https://github.com/ivonaj","followers_url":"https://api.github.com/users/ivonaj/followers","following_url":"https://api.github.com/users/ivonaj/following{/other_user}","gists_url":"https://api.github.com/users/ivonaj/gists{/gist_id}","starred_url":"https://api.github.com/users/ivonaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivonaj/subscriptions","organizations_url":"https://api.github.com/users/ivonaj/orgs","repos_url":"https://api.github.com/users/ivonaj/repos","events_url":"https://api.github.com/users/ivonaj/events{/privacy}","received_events_url":"https://api.github.com/users/ivonaj/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-29T21:08:15Z","updated_at":"2018-12-03T21:53:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8aa544fda2b122933481dbb111d2a6daffa74a41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/pulls/5/commits","review_comments_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/pulls/5/comments","review_comment_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/issues/5/comments","statuses_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/statuses/3ca0ecaa46fbc15a252ee4ed033e42428f7ac848","head":{"label":"ivonaj:serialization","ref":"serialization","sha":"3ca0ecaa46fbc15a252ee4ed033e42428f7ac848","user":{"login":"ivonaj","id":22012105,"node_id":"MDQ6VXNlcjIyMDEyMTA1","avatar_url":"https://avatars0.githubusercontent.com/u/22012105?v=4","gravatar_id":"","url":"https://api.github.com/users/ivonaj","html_url":"https://github.com/ivonaj","followers_url":"https://api.github.com/users/ivonaj/followers","following_url":"https://api.github.com/users/ivonaj/following{/other_user}","gists_url":"https://api.github.com/users/ivonaj/gists{/gist_id}","starred_url":"https://api.github.com/users/ivonaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivonaj/subscriptions","organizations_url":"https://api.github.com/users/ivonaj/orgs","repos_url":"https://api.github.com/users/ivonaj/repos","events_url":"https://api.github.com/users/ivonaj/events{/privacy}","received_events_url":"https://api.github.com/users/ivonaj/received_events","type":"User","site_admin":false},"repo":{"id":143048671,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNDg2NzE=","name":"KartoSDK-slam_toolbox","full_name":"ivonaj/KartoSDK-slam_toolbox","private":false,"owner":{"login":"ivonaj","id":22012105,"node_id":"MDQ6VXNlcjIyMDEyMTA1","avatar_url":"https://avatars0.githubusercontent.com/u/22012105?v=4","gravatar_id":"","url":"https://api.github.com/users/ivonaj","html_url":"https://github.com/ivonaj","followers_url":"https://api.github.com/users/ivonaj/followers","following_url":"https://api.github.com/users/ivonaj/following{/other_user}","gists_url":"https://api.github.com/users/ivonaj/gists{/gist_id}","starred_url":"https://api.github.com/users/ivonaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivonaj/subscriptions","organizations_url":"https://api.github.com/users/ivonaj/orgs","repos_url":"https://api.github.com/users/ivonaj/repos","events_url":"https://api.github.com/users/ivonaj/events{/privacy}","received_events_url":"https://api.github.com/users/ivonaj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ivonaj/KartoSDK-slam_toolbox","description":"Catkinized ROS Package of the OpenKarto Library (LGPL3)","fork":true,"url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox","forks_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/forks","keys_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/teams","hooks_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/hooks","issue_events_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/issues/events{/number}","events_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/events","assignees_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/assignees{/user}","branches_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/branches{/branch}","tags_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/tags","blobs_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/languages","stargazers_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/stargazers","contributors_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/contributors","subscribers_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/subscribers","subscription_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/subscription","commits_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/contents/{+path}","compare_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/merges","archive_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/downloads","issues_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/issues{/number}","pulls_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/labels{/name}","releases_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/releases{/id}","deployments_url":"https://api.github.com/repos/ivonaj/KartoSDK-slam_toolbox/deployments","created_at":"2018-07-31T17:55:16Z","updated_at":"2018-07-31T17:55:18Z","pushed_at":"2018-11-30T23:53:26Z","git_url":"git://github.com/ivonaj/KartoSDK-slam_toolbox.git","ssh_url":"git@github.com:ivonaj/KartoSDK-slam_toolbox.git","clone_url":"https://github.com/ivonaj/KartoSDK-slam_toolbox.git","svn_url":"https://github.com/ivonaj/KartoSDK-slam_toolbox","homepage":null,"size":651,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"kinetic-devel"}},"base":{"label":"SteveMacenski:kinetic-devel","ref":"kinetic-devel","sha":"fd9f0c81c4ccbfb0300f2350b658d1a53d5eb11c","user":{"login":"SteveMacenski","id":14944147,"node_id":"MDQ6VXNlcjE0OTQ0MTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/14944147?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveMacenski","html_url":"https://github.com/SteveMacenski","followers_url":"https://api.github.com/users/SteveMacenski/followers","following_url":"https://api.github.com/users/SteveMacenski/following{/other_user}","gists_url":"https://api.github.com/users/SteveMacenski/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveMacenski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveMacenski/subscriptions","organizations_url":"https://api.github.com/users/SteveMacenski/orgs","repos_url":"https://api.github.com/users/SteveMacenski/repos","events_url":"https://api.github.com/users/SteveMacenski/events{/privacy}","received_events_url":"https://api.github.com/users/SteveMacenski/received_events","type":"User","site_admin":false},"repo":{"id":134314507,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQzMTQ1MDc=","name":"KartoSDK-slam_toolbox","full_name":"SteveMacenski/KartoSDK-slam_toolbox","private":false,"owner":{"login":"SteveMacenski","id":14944147,"node_id":"MDQ6VXNlcjE0OTQ0MTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/14944147?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveMacenski","html_url":"https://github.com/SteveMacenski","followers_url":"https://api.github.com/users/SteveMacenski/followers","following_url":"https://api.github.com/users/SteveMacenski/following{/other_user}","gists_url":"https://api.github.com/users/SteveMacenski/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveMacenski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveMacenski/subscriptions","organizations_url":"https://api.github.com/users/SteveMacenski/orgs","repos_url":"https://api.github.com/users/SteveMacenski/repos","events_url":"https://api.github.com/users/SteveMacenski/events{/privacy}","received_events_url":"https://api.github.com/users/SteveMacenski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SteveMacenski/KartoSDK-slam_toolbox","description":"Catkinized ROS Package of the OpenKarto Library (LGPL3)","fork":true,"url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox","forks_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/forks","keys_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/teams","hooks_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/hooks","issue_events_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/issues/events{/number}","events_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/events","assignees_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/assignees{/user}","branches_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/branches{/branch}","tags_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/tags","blobs_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/languages","stargazers_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/stargazers","contributors_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/contributors","subscribers_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/subscribers","subscription_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/subscription","commits_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/contents/{+path}","compare_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/merges","archive_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/downloads","issues_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/issues{/number}","pulls_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/labels{/name}","releases_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/releases{/id}","deployments_url":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/deployments","created_at":"2018-05-21T19:18:38Z","updated_at":"2018-09-27T01:59:12Z","pushed_at":"2018-11-30T23:53:27Z","git_url":"git://github.com/SteveMacenski/KartoSDK-slam_toolbox.git","ssh_url":"git@github.com:SteveMacenski/KartoSDK-slam_toolbox.git","clone_url":"https://github.com/SteveMacenski/KartoSDK-slam_toolbox.git","svn_url":"https://github.com/SteveMacenski/KartoSDK-slam_toolbox","homepage":null,"size":482,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/pulls/5"},"html":{"href":"https://github.com/SteveMacenski/KartoSDK-slam_toolbox/pull/5"},"issue":{"href":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/issues/5"},"comments":{"href":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/SteveMacenski/KartoSDK-slam_toolbox/statuses/3ca0ecaa46fbc15a252ee4ed033e42428f7ac848"}},"author_association":"NONE"}}
{"actor":{"display_login":"ivonaj"}}