{"action":"opened","issue":{"url":"https://api.github.com/repos/schibsted/account-sdk-android/issues/188","repository_url":"https://api.github.com/repos/schibsted/account-sdk-android","labels_url":"https://api.github.com/repos/schibsted/account-sdk-android/issues/188/labels{/name}","comments_url":"https://api.github.com/repos/schibsted/account-sdk-android/issues/188/comments","events_url":"https://api.github.com/repos/schibsted/account-sdk-android/issues/188/events","html_url":"https://github.com/schibsted/account-sdk-android/issues/188","id":324289376,"number":188,"title":"Version 1.0.0-rc1 crashes when login is opened","user":{"login":"damianpetla","id":8932745,"avatar_url":"https://avatars0.githubusercontent.com/u/8932745?v=4","gravatar_id":"","url":"https://api.github.com/users/damianpetla","html_url":"https://github.com/damianpetla","followers_url":"https://api.github.com/users/damianpetla/followers","following_url":"https://api.github.com/users/damianpetla/following{/other_user}","gists_url":"https://api.github.com/users/damianpetla/gists{/gist_id}","starred_url":"https://api.github.com/users/damianpetla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianpetla/subscriptions","organizations_url":"https://api.github.com/users/damianpetla/orgs","repos_url":"https://api.github.com/users/damianpetla/repos","events_url":"https://api.github.com/users/damianpetla/events{/privacy}","received_events_url":"https://api.github.com/users/damianpetla/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-18T06:46:02Z","updated_at":"2018-05-18T06:46:02Z","closed_at":null,"author_association":"NONE","body":"### Summary\r\nWhen I try to open Password login, I can see briefly login indicator and then app crashes\r\n\r\n### Environment\r\n- SDK Version: 1.0.0-rc1\r\n- SDK Module: ui\r\n- Android Version: any \r\n- Device Info: any\r\n\r\n### Details\r\n```\r\n05-17 12:53:33.338 12568-12568/se.omni.debug E/AndroidRuntime: FATAL EXCEPTION: main\r\n    Process: se.omni.debug, PID: 12568\r\n    android.content.res.Resources$NotFoundException: Resource not found\r\n        at com.schibsted.account.ui.login.BaseLoginActivity.updateTitle(BaseLoginActivity.kt:449)\r\n        at com.schibsted.account.ui.login.BaseLoginActivity.updateActionBar(BaseLoginActivity.kt:420)\r\n        at com.schibsted.account.ui.login.BaseLoginActivity.onCreateOptionsMenu(BaseLoginActivity.kt:354)\r\n        at android.app.Activity.onCreatePanelMenu(Activity.java:3388)\r\n        at android.support.v4.app.FragmentActivity.onCreatePanelMenu(FragmentActivity.java:364)\r\n```\r\nI have tried configuration through manifest and Application.\r\n\r\nI have looked into SDK code and I think it's crashing because identification screen is postponed \r\n```\r\n   fun startIdentificationFragment(flowSelectionListener: FlowSelectionListener?) {\r\n        if (clientInfo.value != null) {\r\n            val fragment = fragmentProvider.getOrCreateIdentificationFragment(\r\n                    navigationController.currentFragment,\r\n                    identifierType = Identifier.IdentifierType.EMAIL.value,\r\n                    flowSelectionListener = flowSelectionListener,\r\n                    clientInfo = clientInfo.value!!)\r\n            navigationController.navigateToFragment(fragment as AbstractIdentificationFragment)\r\n        } else {\r\n            clientInfo.addListener(true) {\r\n                val fragment = fragmentProvider.getOrCreateIdentificationFragment(\r\n                        navigationController.currentFragment,\r\n                        identifierType = Identifier.IdentifierType.EMAIL.value,\r\n                        flowSelectionListener = flowSelectionListener,\r\n                        clientInfo = it!!)\r\n                navigationController.navigateToFragment(fragment as AbstractIdentificationFragment)\r\n            }\r\n        }\r\n    }\r\n```\r\nSo if `private fun updateTitle(screen: LoginScreen?)` is called and `while` statement goes to the end, exception is thrown. I guess that you missed it because you tested it with smartlock enabled but I don't use smartlock.\r\n\r\n### Steps to reproduce\r\nOpen login with Password type, no smartlock\r\n"}}
{"actor":{"display_login":"damianpetla"}}