{"action":"closed","number":1595,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/1595","id":170522961,"html_url":"https://github.com/dotnet/roslyn-analyzers/pull/1595","diff_url":"https://github.com/dotnet/roslyn-analyzers/pull/1595.diff","patch_url":"https://github.com/dotnet/roslyn-analyzers/pull/1595.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/1595","number":1595,"state":"closed","locked":false,"title":"Implement CA2213 (DisposableFieldsShouldBeDisposed)","user":{"login":"mavasani","id":10605811,"avatar_url":"https://avatars2.githubusercontent.com/u/10605811?v=4","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"body":"See https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2213-disposable-fields-should-be-disposed for the rule description.\r\nFxCop implementation for this rule reported CA2213 only for those fields which were assigned a locally created disposable object within the containing type methods/initializers. This reduced noise for cases where the type did not own the dispose responsibility for certain disposable fields. We are matching this implementation and will need to get the docs updated accordingly (#1593)\r\n\r\nTODO: #1594 (Improve CA2213 (DisposableFieldsShouldBeDisposed) to handle cases where fields are disposed by helper methods invoked by Dispose)\r\n\r\nFixes #695","created_at":"2018-02-21T16:35:18Z","updated_at":"2018-02-21T20:40:45Z","closed_at":"2018-02-21T20:40:45Z","merged_at":"2018-02-21T20:40:44Z","merge_commit_sha":"c0d3da851dfd00f7625131decdc71f89f4451fe9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/1595/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/1595/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/1595/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/statuses/33fb36cf8c0dfcf560c2303e2770eed99bcb2f38","head":{"label":"mavasani:CA2213","ref":"CA2213","sha":"33fb36cf8c0dfcf560c2303e2770eed99bcb2f38","user":{"login":"mavasani","id":10605811,"avatar_url":"https://avatars2.githubusercontent.com/u/10605811?v=4","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"repo":{"id":45504515,"name":"roslyn-analyzers","full_name":"mavasani/roslyn-analyzers","owner":{"login":"mavasani","id":10605811,"avatar_url":"https://avatars2.githubusercontent.com/u/10605811?v=4","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mavasani/roslyn-analyzers","description":null,"fork":true,"url":"https://api.github.com/repos/mavasani/roslyn-analyzers","forks_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/forks","keys_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/teams","hooks_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/hooks","issue_events_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/issues/events{/number}","events_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/events","assignees_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/assignees{/user}","branches_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/branches{/branch}","tags_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/tags","blobs_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/statuses/{sha}","languages_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/languages","stargazers_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/stargazers","contributors_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/contributors","subscribers_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/subscribers","subscription_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/subscription","commits_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/issues/comments{/number}","contents_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/contents/{+path}","compare_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/merges","archive_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/downloads","issues_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/issues{/number}","pulls_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/pulls{/number}","milestones_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/milestones{/number}","notifications_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/labels{/name}","releases_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/releases{/id}","deployments_url":"https://api.github.com/repos/mavasani/roslyn-analyzers/deployments","created_at":"2015-11-04T00:20:33Z","updated_at":"2017-01-23T17:47:53Z","pushed_at":"2018-02-21T20:32:06Z","git_url":"git://github.com/mavasani/roslyn-analyzers.git","ssh_url":"git@github.com:mavasani/roslyn-analyzers.git","clone_url":"https://github.com/mavasani/roslyn-analyzers.git","svn_url":"https://github.com/mavasani/roslyn-analyzers","homepage":null,"size":13444,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c5d23f2f2b4da4b2a9b0c92d69937670e742bf59","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":36946704,"name":"roslyn-analyzers","full_name":"dotnet/roslyn-analyzers","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn-analyzers","description":null,"fork":false,"url":"https://api.github.com/repos/dotnet/roslyn-analyzers","forks_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/deployments","created_at":"2015-06-05T17:48:07Z","updated_at":"2018-02-20T18:28:34Z","pushed_at":"2018-02-21T20:40:44Z","git_url":"git://github.com/dotnet/roslyn-analyzers.git","ssh_url":"git@github.com:dotnet/roslyn-analyzers.git","clone_url":"https://github.com/dotnet/roslyn-analyzers.git","svn_url":"https://github.com/dotnet/roslyn-analyzers","homepage":null,"size":13169,"stargazers_count":301,"watchers_count":301,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":127,"mirror_url":null,"archived":false,"open_issues_count":280,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":127,"open_issues":280,"watchers":301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/1595"},"html":{"href":"https://github.com/dotnet/roslyn-analyzers/pull/1595"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/1595"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/1595/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/1595/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/1595/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/statuses/33fb36cf8c0dfcf560c2303e2770eed99bcb2f38"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mavasani","id":10605811,"avatar_url":"https://avatars2.githubusercontent.com/u/10605811?v=4","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"comments":2,"review_comments":3,"maintainer_can_modify":false,"commits":4,"additions":3041,"deletions":123,"changed_files":26}}
{"actor":{"display_login":"mavasani"}}