{"comment":{"url":"https://api.github.com/repos/LubomirR/scummvm/comments/29818503","html_url":"https://github.com/LubomirR/scummvm/commit/907660e58b217879a1339d8a411d8d0c2082c148#commitcomment-29818503","id":29818503,"node_id":"MDEzOkNvbW1pdENvbW1lbnQyOTgxODUwMw==","user":{"login":"LubomirR","id":1394562,"node_id":"MDQ6VXNlcjEzOTQ1NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1394562?v=4","gravatar_id":"","url":"https://api.github.com/users/LubomirR","html_url":"https://github.com/LubomirR","followers_url":"https://api.github.com/users/LubomirR/followers","following_url":"https://api.github.com/users/LubomirR/following{/other_user}","gists_url":"https://api.github.com/users/LubomirR/gists{/gist_id}","starred_url":"https://api.github.com/users/LubomirR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LubomirR/subscriptions","organizations_url":"https://api.github.com/users/LubomirR/orgs","repos_url":"https://api.github.com/users/LubomirR/repos","events_url":"https://api.github.com/users/LubomirR/events{/privacy}","received_events_url":"https://api.github.com/users/LubomirR/received_events","type":"User","site_admin":false},"position":60,"line":124,"path":"engines/mutationofjb/font.cpp","commit_id":"907660e58b217879a1339d8a411d8d0c2082c148","created_at":"2018-07-24T18:58:34Z","updated_at":"2018-07-24T18:58:34Z","author_association":"OWNER","body":"Hi @sev-,\r\nWe were aware of this method. However, we need to make sure the bounding box is exactly the same as in the original game. When the text is supposed to be cleared, its bounding box is used for redrawing the area. If we redraw more (i.e. we get a different bbox), the effect of some rendering commands from the script could be reverted by this operation.\r\n\r\nSo what we could do here is to try to use wordWrapText(). Actually, @MiroslavR already implemented it in https://github.com/LubomirR/scummvm/pull/10. There are some subtle (and one big) difference in the ScummVM implementation. So far we don't see the small differences happen, but if we do, unfortunately we will have to revert to the old implementation.\r\n\r\nHowever, the big one can be observed quite easily as @MiroslavR pointed out in the PR. Today we debugged it and found out it's a bug in ScummVM code. If you think it's okay to fix wordWrapText(), I'll submit a PR."}}
{"actor":{"display_login":"LubomirR"}}