{"action":"created","issue":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/3906","repository_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore","labels_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/3906/labels{/name}","comments_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/3906/comments","events_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/3906/events","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/3906","id":299978048,"number":3906,"title":"Alignment Data Errors","user":{"login":"RoyalSix","id":16184018,"avatar_url":"https://avatars0.githubusercontent.com/u/16184018?v=4","gravatar_id":"","url":"https://api.github.com/users/RoyalSix","html_url":"https://github.com/RoyalSix","followers_url":"https://api.github.com/users/RoyalSix/followers","following_url":"https://api.github.com/users/RoyalSix/following{/other_user}","gists_url":"https://api.github.com/users/RoyalSix/gists{/gist_id}","starred_url":"https://api.github.com/users/RoyalSix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoyalSix/subscriptions","organizations_url":"https://api.github.com/users/RoyalSix/orgs","repos_url":"https://api.github.com/users/RoyalSix/repos","events_url":"https://api.github.com/users/RoyalSix/events{/privacy}","received_events_url":"https://api.github.com/users/RoyalSix/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-02-24T22:24:20Z","updated_at":"2018-02-26T16:12:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls/3906","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/3906","diff_url":"https://github.com/unfoldingWord-dev/translationCore/pull/3906.diff","patch_url":"https://github.com/unfoldingWord-dev/translationCore/pull/3906.patch"},"body":"#### Describe what your pull request addresses (Please include relevant issue numbers):\r\n- This PR addresses resetting invalidated alignments.\r\n  - Invalid alignments can be caused by changes to the target language verse text (which have been aligned), or to the greek source text (which has been aligned).\r\n  - Check the [story](https://github.com/unfoldingWord-dev/translationCore/issues/3193) for a more detailed description.\r\n\r\n#### Please include detailed Test instructions for your pull request:\r\n- First make sure you are on the latests tC_resources, node modules, and tC_apps.\r\n- Open a project with or without alignments.\r\n- Do some alignments (remember the verse!)\r\n- Open the tW tool, edit that same verse in the target language. Save.\r\n- Open the word alignment tool, the alignments should now be reset.\r\n\r\n#### Standard Test Instructions for PR Review Process:\r\n\r\n- [ ] Double check unit tests that have been written\r\n- [ ] Check for documentation for code changes\r\n- [ ] Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR\r\n- [ ] Checkout the branch locally and ensure that app runs as expected\r\n  - [ ] Ensure tests pass\r\n  - [ ] Open and watch the console for errors\r\n  - [ ] Make sure all actions perform as expected\r\n  - [ ] Import and Load a new Project\r\n  - [ ] Load a tool and perform basic actions\r\n  - [ ] Switch tools and perform basic actions\r\n  - [ ] Switch project to an existing project\r\n  - [ ] Load a tool and perform basic actions\r\n  - [ ] Switch tools and perform basic actions\r\n  - [ ] Next time reverse the order of importing after loading an existing project\r\n- [ ] Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story\r\n- [ ] Ask Ben or Koz if you have any concerns about implementation (especially UI related)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/unfoldingword-dev/translationcore/3906)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/comments/368555199","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/3906#issuecomment-368555199","issue_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/3906","id":368555199,"user":{"login":"klappy","id":118073,"avatar_url":"https://avatars3.githubusercontent.com/u/118073?v=4","gravatar_id":"","url":"https://api.github.com/users/klappy","html_url":"https://github.com/klappy","followers_url":"https://api.github.com/users/klappy/followers","following_url":"https://api.github.com/users/klappy/following{/other_user}","gists_url":"https://api.github.com/users/klappy/gists{/gist_id}","starred_url":"https://api.github.com/users/klappy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klappy/subscriptions","organizations_url":"https://api.github.com/users/klappy/orgs","repos_url":"https://api.github.com/users/klappy/repos","events_url":"https://api.github.com/users/klappy/events{/privacy}","received_events_url":"https://api.github.com/users/klappy/received_events","type":"User","site_admin":false},"created_at":"2018-02-26T16:12:28Z","updated_at":"2018-02-26T16:12:28Z","author_association":"CONTRIBUTOR","body":"\n\n\n\n\n\n\n\n*[__tests__/fixtures/pivotAlignmentVerseObjects/tit1-1.json, line 2 at r1](https://reviewable.io:443/reviews/unfoldingword-dev/translationcore/3906#-L6HsS9H7cHlCA-vOhhr:-L6Hs_UqpCqHnQtb1C13:bv60kur) ([raw file](https://github.com/unfoldingword-dev/translationcore/blob/529e8a2a6c87fa0f9f4850740c2c2175343640fc/__tests__/fixtures/pivotAlignmentVerseObjects/tit1-1.json#L2)):*\n<details><summary><i>Previously, klappy (Christopher Klapp) wrote…</i></summary><blockquote>\n\nOut of curiosity, what changed to remove this accent in the text? `κατ’` should be preserved from the original language word object and not be removed.\n</blockquote></details>\n\nWe need to know if we can preserve that from the original language or not. If we can't we may have to spend some extra time rethinking the approach or discussing implications with Ben/Jesse.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/unfoldingword-dev/translationcore/3906)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"klappy"}}