{"action":"created","comment":{"url":"https://api.github.com/repos/rcbops/pytest-rpc/pulls/comments/205949444","pull_request_review_id":141323210,"id":205949444,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTk0OTQ0NA==","diff_hunk":"@@ -298,74 +298,79 @@ def create_instance(data, run_on_host):\n     return None\n \n \n-def _asset_in_list(service_type, service_name, expected_asset, run_on_host, retries=10):\n+def _resource_in_list(service_type, service_name, expected_resource, run_on_host, retries=10):\n     \"\"\"Verify if a volume/server/image is existing\n \n     Args:\n         service_type (str): The OpenStack object type to query for.\n         service_name (str): The name of the OpenStack object to query for.\n-        expected_asset (bool): Whether or not the asset is expected in the list\n+        expected_resource (bool): Whether or not the resource is expected in the list\n         run_on_host (testinfra.Host): Testinfra host object to execute the action on.\n         retries (int): The maximum number of retry attempts.\n \n     Returns:\n-        bool: Whether the expected asset was found or not.\n+        bool: Whether the expected resource was found or not.","path":"pytest_rpc/helpers.py","position":285,"original_position":18,"commit_id":"2fc8dba859ad08af4b46bab82c07c0633d08ef43","original_commit_id":"ec06077c88f0cd514954c28e2291d17d4e89fd14","user":{"login":"johnduarte","id":1040859,"node_id":"MDQ6VXNlcjEwNDA4NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1040859?v=4","gravatar_id":"","url":"https://api.github.com/users/johnduarte","html_url":"https://github.com/johnduarte","followers_url":"https://api.github.com/users/johnduarte/followers","following_url":"https://api.github.com/users/johnduarte/following{/other_user}","gists_url":"https://api.github.com/users/johnduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduarte/subscriptions","organizations_url":"https://api.github.com/users/johnduarte/orgs","repos_url":"https://api.github.com/users/johnduarte/repos","events_url":"https://api.github.com/users/johnduarte/events{/privacy}","received_events_url":"https://api.github.com/users/johnduarte/received_events","type":"User","site_admin":false},"body":"The file has been updated to use the short form for the built-in data types.","created_at":"2018-07-28T17:51:55Z","updated_at":"2018-07-28T17:51:56Z","html_url":"https://github.com/rcbops/pytest-rpc/pull/46#discussion_r205949444","pull_request_url":"https://api.github.com/repos/rcbops/pytest-rpc/pulls/46","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rcbops/pytest-rpc/pulls/comments/205949444"},"html":{"href":"https://github.com/rcbops/pytest-rpc/pull/46#discussion_r205949444"},"pull_request":{"href":"https://api.github.com/repos/rcbops/pytest-rpc/pulls/46"}},"in_reply_to_id":205821256},"pull_request":{"url":"https://api.github.com/repos/rcbops/pytest-rpc/pulls/46","id":204255042,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjU1MDQy","html_url":"https://github.com/rcbops/pytest-rpc/pull/46","diff_url":"https://github.com/rcbops/pytest-rpc/pull/46.diff","patch_url":"https://github.com/rcbops/pytest-rpc/pull/46.patch","issue_url":"https://api.github.com/repos/rcbops/pytest-rpc/issues/46","number":46,"state":"open","locked":false,"title":"Asc-765 Refactor helpers","user":{"login":"johnduarte","id":1040859,"node_id":"MDQ6VXNlcjEwNDA4NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1040859?v=4","gravatar_id":"","url":"https://api.github.com/users/johnduarte","html_url":"https://github.com/johnduarte","followers_url":"https://api.github.com/users/johnduarte/followers","following_url":"https://api.github.com/users/johnduarte/following{/other_user}","gists_url":"https://api.github.com/users/johnduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduarte/subscriptions","organizations_url":"https://api.github.com/users/johnduarte/orgs","repos_url":"https://api.github.com/users/johnduarte/repos","events_url":"https://api.github.com/users/johnduarte/events{/privacy}","received_events_url":"https://api.github.com/users/johnduarte/received_events","type":"User","site_admin":false},"body":"This PR is an effort to make the existing methods in helpers.py more consistent, intuitive, and efficient.","created_at":"2018-07-26T20:17:46Z","updated_at":"2018-07-28T17:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4a67e31e7a13abd1502a066a431a322e0323e2f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zreichert","id":2602509,"node_id":"MDQ6VXNlcjI2MDI1MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/2602509?v=4","gravatar_id":"","url":"https://api.github.com/users/zreichert","html_url":"https://github.com/zreichert","followers_url":"https://api.github.com/users/zreichert/followers","following_url":"https://api.github.com/users/zreichert/following{/other_user}","gists_url":"https://api.github.com/users/zreichert/gists{/gist_id}","starred_url":"https://api.github.com/users/zreichert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zreichert/subscriptions","organizations_url":"https://api.github.com/users/zreichert/orgs","repos_url":"https://api.github.com/users/zreichert/repos","events_url":"https://api.github.com/users/zreichert/events{/privacy}","received_events_url":"https://api.github.com/users/zreichert/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rcbops/pytest-rpc/pulls/46/commits","review_comments_url":"https://api.github.com/repos/rcbops/pytest-rpc/pulls/46/comments","review_comment_url":"https://api.github.com/repos/rcbops/pytest-rpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rcbops/pytest-rpc/issues/46/comments","statuses_url":"https://api.github.com/repos/rcbops/pytest-rpc/statuses/2fc8dba859ad08af4b46bab82c07c0633d08ef43","head":{"label":"johnduarte:asc-765/refactor-helpers","ref":"asc-765/refactor-helpers","sha":"2fc8dba859ad08af4b46bab82c07c0633d08ef43","user":{"login":"johnduarte","id":1040859,"node_id":"MDQ6VXNlcjEwNDA4NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1040859?v=4","gravatar_id":"","url":"https://api.github.com/users/johnduarte","html_url":"https://github.com/johnduarte","followers_url":"https://api.github.com/users/johnduarte/followers","following_url":"https://api.github.com/users/johnduarte/following{/other_user}","gists_url":"https://api.github.com/users/johnduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduarte/subscriptions","organizations_url":"https://api.github.com/users/johnduarte/orgs","repos_url":"https://api.github.com/users/johnduarte/repos","events_url":"https://api.github.com/users/johnduarte/events{/privacy}","received_events_url":"https://api.github.com/users/johnduarte/received_events","type":"User","site_admin":false},"repo":{"id":138775377,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3NzUzNzc=","name":"pytest-rpc","full_name":"johnduarte/pytest-rpc","owner":{"login":"johnduarte","id":1040859,"node_id":"MDQ6VXNlcjEwNDA4NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1040859?v=4","gravatar_id":"","url":"https://api.github.com/users/johnduarte","html_url":"https://github.com/johnduarte","followers_url":"https://api.github.com/users/johnduarte/followers","following_url":"https://api.github.com/users/johnduarte/following{/other_user}","gists_url":"https://api.github.com/users/johnduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduarte/subscriptions","organizations_url":"https://api.github.com/users/johnduarte/orgs","repos_url":"https://api.github.com/users/johnduarte/repos","events_url":"https://api.github.com/users/johnduarte/events{/privacy}","received_events_url":"https://api.github.com/users/johnduarte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnduarte/pytest-rpc","description":"Extend py.test for RPC OpenStack testing.","fork":true,"url":"https://api.github.com/repos/johnduarte/pytest-rpc","forks_url":"https://api.github.com/repos/johnduarte/pytest-rpc/forks","keys_url":"https://api.github.com/repos/johnduarte/pytest-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnduarte/pytest-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnduarte/pytest-rpc/teams","hooks_url":"https://api.github.com/repos/johnduarte/pytest-rpc/hooks","issue_events_url":"https://api.github.com/repos/johnduarte/pytest-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/johnduarte/pytest-rpc/events","assignees_url":"https://api.github.com/repos/johnduarte/pytest-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/johnduarte/pytest-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/johnduarte/pytest-rpc/tags","blobs_url":"https://api.github.com/repos/johnduarte/pytest-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnduarte/pytest-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnduarte/pytest-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnduarte/pytest-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnduarte/pytest-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/johnduarte/pytest-rpc/languages","stargazers_url":"https://api.github.com/repos/johnduarte/pytest-rpc/stargazers","contributors_url":"https://api.github.com/repos/johnduarte/pytest-rpc/contributors","subscribers_url":"https://api.github.com/repos/johnduarte/pytest-rpc/subscribers","subscription_url":"https://api.github.com/repos/johnduarte/pytest-rpc/subscription","commits_url":"https://api.github.com/repos/johnduarte/pytest-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnduarte/pytest-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnduarte/pytest-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnduarte/pytest-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnduarte/pytest-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/johnduarte/pytest-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnduarte/pytest-rpc/merges","archive_url":"https://api.github.com/repos/johnduarte/pytest-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnduarte/pytest-rpc/downloads","issues_url":"https://api.github.com/repos/johnduarte/pytest-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/johnduarte/pytest-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/johnduarte/pytest-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/johnduarte/pytest-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnduarte/pytest-rpc/labels{/name}","releases_url":"https://api.github.com/repos/johnduarte/pytest-rpc/releases{/id}","deployments_url":"https://api.github.com/repos/johnduarte/pytest-rpc/deployments","created_at":"2018-06-26T18:06:53Z","updated_at":"2018-06-26T18:06:55Z","pushed_at":"2018-07-28T17:49:15Z","git_url":"git://github.com/johnduarte/pytest-rpc.git","ssh_url":"git@github.com:johnduarte/pytest-rpc.git","clone_url":"https://github.com/johnduarte/pytest-rpc.git","svn_url":"https://github.com/johnduarte/pytest-rpc","homepage":"","size":131,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rcbops:master","ref":"master","sha":"59053bdc3133e2bf0f17f3d569afbd68f8d88beb","user":{"login":"rcbops","id":1153548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTM1NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1153548?v=4","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"repo":{"id":123343106,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzNDMxMDY=","name":"pytest-rpc","full_name":"rcbops/pytest-rpc","owner":{"login":"rcbops","id":1153548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTM1NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1153548?v=4","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rcbops/pytest-rpc","description":"Extend py.test for RPC OpenStack testing.","fork":false,"url":"https://api.github.com/repos/rcbops/pytest-rpc","forks_url":"https://api.github.com/repos/rcbops/pytest-rpc/forks","keys_url":"https://api.github.com/repos/rcbops/pytest-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcbops/pytest-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcbops/pytest-rpc/teams","hooks_url":"https://api.github.com/repos/rcbops/pytest-rpc/hooks","issue_events_url":"https://api.github.com/repos/rcbops/pytest-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/rcbops/pytest-rpc/events","assignees_url":"https://api.github.com/repos/rcbops/pytest-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/rcbops/pytest-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/rcbops/pytest-rpc/tags","blobs_url":"https://api.github.com/repos/rcbops/pytest-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcbops/pytest-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcbops/pytest-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcbops/pytest-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcbops/pytest-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/rcbops/pytest-rpc/languages","stargazers_url":"https://api.github.com/repos/rcbops/pytest-rpc/stargazers","contributors_url":"https://api.github.com/repos/rcbops/pytest-rpc/contributors","subscribers_url":"https://api.github.com/repos/rcbops/pytest-rpc/subscribers","subscription_url":"https://api.github.com/repos/rcbops/pytest-rpc/subscription","commits_url":"https://api.github.com/repos/rcbops/pytest-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcbops/pytest-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcbops/pytest-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcbops/pytest-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcbops/pytest-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/rcbops/pytest-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcbops/pytest-rpc/merges","archive_url":"https://api.github.com/repos/rcbops/pytest-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcbops/pytest-rpc/downloads","issues_url":"https://api.github.com/repos/rcbops/pytest-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/rcbops/pytest-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/rcbops/pytest-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/rcbops/pytest-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcbops/pytest-rpc/labels{/name}","releases_url":"https://api.github.com/repos/rcbops/pytest-rpc/releases{/id}","deployments_url":"https://api.github.com/repos/rcbops/pytest-rpc/deployments","created_at":"2018-02-28T21:12:16Z","updated_at":"2018-07-24T19:46:47Z","pushed_at":"2018-07-28T17:49:16Z","git_url":"git://github.com/rcbops/pytest-rpc.git","ssh_url":"git@github.com:rcbops/pytest-rpc.git","clone_url":"https://github.com/rcbops/pytest-rpc.git","svn_url":"https://github.com/rcbops/pytest-rpc","homepage":"","size":121,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rcbops/pytest-rpc/pulls/46"},"html":{"href":"https://github.com/rcbops/pytest-rpc/pull/46"},"issue":{"href":"https://api.github.com/repos/rcbops/pytest-rpc/issues/46"},"comments":{"href":"https://api.github.com/repos/rcbops/pytest-rpc/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/rcbops/pytest-rpc/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/rcbops/pytest-rpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rcbops/pytest-rpc/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/rcbops/pytest-rpc/statuses/2fc8dba859ad08af4b46bab82c07c0633d08ef43"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"johnduarte"}}