{"action":"created","issue":{"url":"https://api.github.com/repos/mrmacete/r2-ggpack/issues/3","repository_url":"https://api.github.com/repos/mrmacete/r2-ggpack","labels_url":"https://api.github.com/repos/mrmacete/r2-ggpack/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/mrmacete/r2-ggpack/issues/3/comments","events_url":"https://api.github.com/repos/mrmacete/r2-ggpack/issues/3/events","html_url":"https://github.com/mrmacete/r2-ggpack/issues/3","id":340020504,"node_id":"MDU6SXNzdWUzNDAwMjA1MDQ=","number":3,"title":"Cannot open 'ggpack://ThimbleweedPark.ggpack1'","user":{"login":"urielz","id":11670888,"node_id":"MDQ6VXNlcjExNjcwODg4","avatar_url":"https://avatars2.githubusercontent.com/u/11670888?v=4","gravatar_id":"","url":"https://api.github.com/users/urielz","html_url":"https://github.com/urielz","followers_url":"https://api.github.com/users/urielz/followers","following_url":"https://api.github.com/users/urielz/following{/other_user}","gists_url":"https://api.github.com/users/urielz/gists{/gist_id}","starred_url":"https://api.github.com/users/urielz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urielz/subscriptions","organizations_url":"https://api.github.com/users/urielz/orgs","repos_url":"https://api.github.com/users/urielz/repos","events_url":"https://api.github.com/users/urielz/events{/privacy}","received_events_url":"https://api.github.com/users/urielz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-10T21:53:41Z","updated_at":"2018-07-11T06:37:21Z","closed_at":null,"author_association":"NONE","body":"I'm having an issue using the plugin on macOS 10.13.5. I don't know anything at all about radare and how to use it. So I'm basically trying to guess a fix. I'd appreciate if someone can point out an obvious error: \r\n\r\nThe output of:\r\n`r2 ggpack://ThimbleweedPark.ggpack1`\r\nis:\r\n`Cannot open 'ggpack://ThimbleweedPark.ggpack1'`\r\n\r\nBy inspecting the code, I followed a suggestion made in a comment in  **io_ggpack.c**: To look for the magic byte (which could be platform-dependent). I have to extend the mask quite a bit to get a hit, this is what I did:\r\n\r\n[0x00000000]> /x 4fd0..........................93\r\nSearching 16 bytes in [0x0-0x1df6013f]\r\nhits: 26\r\n0x019ed84f hit26_0 4fd0e3fa860551f79e8c5b0ac8ae1493\r\n0x01fc3223 hit26_1 4fd0f16a8bfc3b6749e3e05b970cbc93\r\n0x01fdda86 hit26_2 4fd0684011dd653edd8df2b8a2ed8593\r\n0x0247acfe hit26_3 4fd019ab17aec9955a8775ac927a5493\r\n0x028805e7 hit26_4 4fd0abe52e4e9bddff01a684ada22f93\r\n0x02dae656 hit26_5 4fd0dcf25f43d8880e7ca592f62f7793\r\n0x0533d35a hit26_6 4fd0e5fa61f09a8ee3c92e2fa6931993\r\n0x06151af4 hit26_7 4fd0ab81d7591f46d60f05356c764093\r\n0x0711c651 hit26_8 4fd0036f6f1ca2572a48633c514e0493\r\n0x071d824c hit26_9 4fd0dea517813bdbc899ae76d4e77293\r\n0x0758ab51 hit26_10 4fd078a67cca7a81849300ed9243e193\r\n0x0c23f83e hit26_11 4fd0cd831ac285761a2e28dd41ec9993\r\n0x0ec19be5 hit26_12 4fd0e128791f2b7260244861d27ba593\r\n0x10e3dcdb hit26_13 4fd0a4c5f18e84ae270b42e88938b593\r\n0x127f0baa hit26_14 4fd08f7215b2c3f22888325921c47193\r\n0x140ea530 hit26_15 4fd00e8d9c5de107d8a942a0364fa993\r\n0x1428ec64 hit26_16 4fd0fa62414b4f50fbe642ee6706be93\r\n0x142f6d8d hit26_17 4fd04ccb6d5b3ff6b859b031fb900493\r\n0x15931600 hit26_18 4fd0557cbe366fe7ef14c896b5cfde93\r\n0x161a8437 hit26_19 4fd031adf4ba5bc2194e33f4390b5a93\r\n0x167f5492 hit26_20 4fd03fe46df83b8d335b029745db2a93\r\n0x197081d6 hit26_21 4fd0482c8e3ffdfd38f7608ba6da4493\r\n0x19b56ee4 hit26_22 4fd0aca508ecad2cd77601b8c419bb93\r\n0x1c6f79bf hit26_23 4fd07a71be3989de51c7d35066947093\r\n0x1dc91851 hit26_24 4fd0dcf1732f30f180d59427b9fd4d93\r\n0x1de2f6d9 hit26_25 4fd049dbcf4b4982833ca9bd6e379c93\r\n\r\nSo I added all of that to **io_ggpack.c** and changed the line:\r\n`#define BRUTE_VERSIONS 2`\r\nto \r\n`#define BRUTE_VERSIONS 28`\r\n\r\nAfter doing make install I still get the same error... any help would be appreciate it.\r\n\r\nAnd @mrmacete thanks for sharing this!\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mrmacete/r2-ggpack/issues/comments/404061170","html_url":"https://github.com/mrmacete/r2-ggpack/issues/3#issuecomment-404061170","issue_url":"https://api.github.com/repos/mrmacete/r2-ggpack/issues/3","id":404061170,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDA2MTE3MA==","user":{"login":"mrmacete","id":4139069,"node_id":"MDQ6VXNlcjQxMzkwNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/4139069?v=4","gravatar_id":"","url":"https://api.github.com/users/mrmacete","html_url":"https://github.com/mrmacete","followers_url":"https://api.github.com/users/mrmacete/followers","following_url":"https://api.github.com/users/mrmacete/following{/other_user}","gists_url":"https://api.github.com/users/mrmacete/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmacete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmacete/subscriptions","organizations_url":"https://api.github.com/users/mrmacete/orgs","repos_url":"https://api.github.com/users/mrmacete/repos","events_url":"https://api.github.com/users/mrmacete/events{/privacy}","received_events_url":"https://api.github.com/users/mrmacete/received_events","type":"User","site_admin":false},"created_at":"2018-07-11T06:37:21Z","updated_at":"2018-07-11T06:37:21Z","author_association":"OWNER","body":"wow, super interesting.\r\n\r\ncan you also set this to one (sorry forgot to say this yesterday): https://github.com/mrmacete/r2-ggpack/blob/master/gglib.c#L9\r\n\r\nfrom what platform is the game file?\r\n\r\nalso: `r2 -e bin.maxstrbuf=0x1df6013f ThimbleweedPark.ggpack1` actually doesn't use the plugin, it opens the raw file, that's why you get issues with string buffers"}}
{"actor":{"display_login":"mrmacete"}}