{"action":"closed","issue":{"url":"https://api.github.com/repos/electron-userland/electron-builder/issues/3284","repository_url":"https://api.github.com/repos/electron-userland/electron-builder","labels_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/3284/labels{/name}","comments_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/3284/comments","events_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/3284/events","html_url":"https://github.com/electron-userland/electron-builder/issues/3284","id":354934712,"node_id":"MDU6SXNzdWUzNTQ5MzQ3MTI=","number":3284,"title":"Persistently uses default osx icon","user":{"login":"junebug12851","id":1305564,"node_id":"MDQ6VXNlcjEzMDU1NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1305564?v=4","gravatar_id":"","url":"https://api.github.com/users/junebug12851","html_url":"https://github.com/junebug12851","followers_url":"https://api.github.com/users/junebug12851/followers","following_url":"https://api.github.com/users/junebug12851/following{/other_user}","gists_url":"https://api.github.com/users/junebug12851/gists{/gist_id}","starred_url":"https://api.github.com/users/junebug12851/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junebug12851/subscriptions","organizations_url":"https://api.github.com/users/junebug12851/orgs","repos_url":"https://api.github.com/users/junebug12851/repos","events_url":"https://api.github.com/users/junebug12851/events{/privacy}","received_events_url":"https://api.github.com/users/junebug12851/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-28T22:59:55Z","updated_at":"2018-08-30T07:03:47Z","closed_at":"2018-08-30T07:03:47Z","author_association":"NONE","body":"<!-- Which version of electron-builder are you using? -->\r\n<!-- Please always try to use latest version before report. -->\r\n* **Version**: 20.28.3\r\n\r\n<!-- Which version of electron-updater are you using (if applicable)? -->\r\n\r\n<!-- What target are you building for? -->\r\n* **Target**: platform=darwin arch=x64 electron=2.0.6\r\n\r\n<!-- Enter your issue details below this comment. -->\r\nApps built with electron-builder for mac seem to persistently use the osx default icon, dmg background works just fine but also doesn't use correct icon.\r\n\r\n![screen shot 2018-08-28 at 6 36 26 pm](https://user-images.githubusercontent.com/1305564/44754785-5f72cf00-aaf1-11e8-8784-95dc1213613f.png)\r\n\r\nI've scoured Google and any kind of help I can try to find including this issue tracker and have been trying solutions for hours\r\n\r\n* Do I have it in my `build` folder, **maybe** read next item\r\n* What does **maybe** mean?\r\n\r\n> I'm using Angular which builds to `dist` so I have to tell `electron-builder` to assign `dist` as the `build` folder and use `build` as the `dist` folder\r\n\r\n* How did I do that?\r\n\r\n> package.json\r\n\r\n```js\r\n    \"build\": {\r\n        \"directories\": {\r\n            \"buildResources\": \"dist\",\r\n            \"output\": \"build\"\r\n        },\r\n```\r\n\r\n* Where are my icons in the `build` folder?\r\n\r\n`./dist/project-name/assets/icons`\r\n\r\n* Are they in `icns` format? **Yes**\r\n* What size is the icns file? **1024x1024**\r\n* How am I referencing them in the file?\r\n\r\n> package.json\r\n\r\n```js\r\n    \"build\": {\r\n        \"mac\": {\r\n            \"icon\": \"./dist/project-name/assets/icons/icns/web_hi_res_512_1024x1024.icns\",\r\n        },\r\n        \"dmg\": {\r\n            \"icon\": \"./dist/project-name/assets/icons/icns/web_hi_res_512_1024x1024.icns\",\r\n        },\r\n```\r\n\r\n* Am I using `files`? **Yes**\r\n\r\n> package.json\r\n\r\n```js\r\n    \"build\": {\r\n        \"files\": [\r\n            \"./dist/**/*\",\r\n            \"./main.js\"\r\n        ],\r\n```\r\n\r\n* Finally what's the full build section of `package.json`?\r\n\r\n> package.json (Full / uncut)\r\n\r\n```js\r\n    \"build\": {\r\n        \"appId\": \"com.gmail.junehanabi.${name}\",\r\n        \"productName\": \"Name\",\r\n        \"copyright\": \"Copyright © 2018 June Hanabi\",\r\n        \"directories\": {\r\n            \"buildResources\": \"dist\",\r\n            \"output\": \"build\"\r\n        },\r\n        \"files\": [\r\n            \"./dist/**/*\",\r\n            \"./main.js\"\r\n        ],\r\n        \"mac\": {\r\n            \"category\": \"public.app-category.utilities\",\r\n            \"target\": [\r\n                {\r\n                    \"target\": \"dmg\",\r\n                    \"arch\": [\r\n                        \"x64\"\r\n                    ]\r\n                },\r\n                {\r\n                    \"target\": \"zip\",\r\n                    \"arch\": [\r\n                        \"x64\"\r\n                    ]\r\n                }\r\n            ],\r\n            \"icon\": \"./dist/project-name/assets/icons/icns/web_hi_res_512_1024x1024.icns\",\r\n            \"identity\": null\r\n        },\r\n        \"dmg\": {\r\n            \"background\": \"./dist/project-name/assets/splash/DMGSplash.png\",\r\n            \"icon\": \"./dist/project-name/assets/icons/icns/web_hi_res_512_1024x1024.icns\",\r\n            \"title\": \"${productName}\"\r\n        },\r\n        \"win\": {\r\n            \"target\": [\r\n                {\r\n                    \"target\": \"nsis\",\r\n                    \"arch\": [\r\n                        \"x64\",\r\n                        \"ia32\"\r\n                    ]\r\n                },\r\n                {\r\n                    \"target\": \"portable\",\r\n                    \"arch\": [\r\n                        \"x64\",\r\n                        \"ia32\"\r\n                    ]\r\n                }\r\n            ],\r\n            \"icon\": \"./dist/project-name/assets/icons/ico/web_hi_res_512_256x256.ico\"\r\n        },\r\n        \"nsis\": {\r\n            \"installerIcon\": \"./dist/project-name/assets/icons/ico/web_hi_res_512_256x256.ico\",\r\n            \"uninstallerIcon\": \"./dist/project-name/assets/icons/ico/web_hi_res_512_256x256.ico\",\r\n            \"installerHeaderIcon\": \"./dist/project-name/assets/icons/ico/web_hi_res_512_256x256.ico\",\r\n            \"deleteAppDataOnUninstall\": true\r\n        },\r\n        \"linux\": {\r\n            \"target\": [\r\n                {\r\n                    \"target\": \"AppImage\",\r\n                    \"arch\": [\r\n                        \"x64\",\r\n                        \"ia32\"\r\n                    ]\r\n                }\r\n            ],\r\n            \"icon\": \"./dist/project-name/assets/icons/png/mipmap-mdpi/ic_launcher.png\",\r\n            \"synopsis\": \"Project Synopsis\",\r\n            \"category\": \"Utility\"\r\n        },\r\n        \"appImage\": {\r\n            \"synopsis\": \"Project Synopsis\",\r\n            \"category\": \"Utility\"\r\n        }\r\n    },\r\n```\r\n"}}
{"actor":{"display_login":"junebug12851"}}