{"action":"created","comment":{"url":"https://api.github.com/repos/oshi/oshi/pulls/comments/191044293","pull_request_review_id":123552305,"id":191044293,"diff_hunk":"@@ -18,6 +18,20 @@\n  */\n package oshi.hardware;\n \n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+import oshi.SystemInfo;\n+import oshi.hardware.platform.linux.LinuxDisks;\n+import oshi.hardware.platform.linux.LinuxNetworks;\n+import oshi.hardware.platform.mac.MacDisks;\n+import oshi.hardware.platform.mac.MacNetworks;","path":"oshi-core/src/main/java/oshi/hardware/HWDiskStore.java","position":10,"original_position":10,"commit_id":"f1e4dcd435a3aa630d157d5c8fa22c5150e8293d","original_commit_id":"f1e4dcd435a3aa630d157d5c8fa22c5150e8293d","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Avoid unused imports such as 'oshi.hardware.platform.mac.MacNetworks'](https://app.codacy.com/app/widdis/oshi/pullRequest?prid=1697416)","created_at":"2018-05-26T09:26:47Z","updated_at":"2018-05-26T09:26:47Z","html_url":"https://github.com/oshi/oshi/pull/501#discussion_r191044293","pull_request_url":"https://api.github.com/repos/oshi/oshi/pulls/501","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/oshi/oshi/pulls/comments/191044293"},"html":{"href":"https://github.com/oshi/oshi/pull/501#discussion_r191044293"},"pull_request":{"href":"https://api.github.com/repos/oshi/oshi/pulls/501"}}},"pull_request":{"url":"https://api.github.com/repos/oshi/oshi/pulls/501","id":190559114,"html_url":"https://github.com/oshi/oshi/pull/501","diff_url":"https://github.com/oshi/oshi/pull/501.diff","patch_url":"https://github.com/oshi/oshi/pull/501.patch","issue_url":"https://api.github.com/repos/oshi/oshi/issues/501","number":501,"state":"open","locked":false,"title":"Added HWDiskStore.updateDiskStats","user":{"login":"cjbrowne","id":375847,"avatar_url":"https://avatars0.githubusercontent.com/u/375847?v=4","gravatar_id":"","url":"https://api.github.com/users/cjbrowne","html_url":"https://github.com/cjbrowne","followers_url":"https://api.github.com/users/cjbrowne/followers","following_url":"https://api.github.com/users/cjbrowne/following{/other_user}","gists_url":"https://api.github.com/users/cjbrowne/gists{/gist_id}","starred_url":"https://api.github.com/users/cjbrowne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjbrowne/subscriptions","organizations_url":"https://api.github.com/users/cjbrowne/orgs","repos_url":"https://api.github.com/users/cjbrowne/repos","events_url":"https://api.github.com/users/cjbrowne/events{/privacy}","received_events_url":"https://api.github.com/users/cjbrowne/received_events","type":"User","site_admin":false},"body":"I used a similar approach to NetworkIF.updateNetworkStats, and implemented the update methods for each platform to the best of my ability.\r\n\r\nNB: untested, but the changes are really just *moving* existing code rather than adding anything especially new, so in most cases should be fairly low risk.  I can test it on Windows, Linux, and FreeBSD fairly easily but don't have access to Mac or Solaris for testing those.","created_at":"2018-05-25T11:25:57Z","updated_at":"2018-05-26T09:26:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9343a22c121ee38a424e2dc0649a43553dafb7a1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oshi/oshi/pulls/501/commits","review_comments_url":"https://api.github.com/repos/oshi/oshi/pulls/501/comments","review_comment_url":"https://api.github.com/repos/oshi/oshi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oshi/oshi/issues/501/comments","statuses_url":"https://api.github.com/repos/oshi/oshi/statuses/f1e4dcd435a3aa630d157d5c8fa22c5150e8293d","head":{"label":"cjbrowne:master","ref":"master","sha":"f1e4dcd435a3aa630d157d5c8fa22c5150e8293d","user":{"login":"cjbrowne","id":375847,"avatar_url":"https://avatars0.githubusercontent.com/u/375847?v=4","gravatar_id":"","url":"https://api.github.com/users/cjbrowne","html_url":"https://github.com/cjbrowne","followers_url":"https://api.github.com/users/cjbrowne/followers","following_url":"https://api.github.com/users/cjbrowne/following{/other_user}","gists_url":"https://api.github.com/users/cjbrowne/gists{/gist_id}","starred_url":"https://api.github.com/users/cjbrowne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjbrowne/subscriptions","organizations_url":"https://api.github.com/users/cjbrowne/orgs","repos_url":"https://api.github.com/users/cjbrowne/repos","events_url":"https://api.github.com/users/cjbrowne/events{/privacy}","received_events_url":"https://api.github.com/users/cjbrowne/received_events","type":"User","site_admin":false},"repo":{"id":134536971,"name":"oshi","full_name":"cjbrowne/oshi","owner":{"login":"cjbrowne","id":375847,"avatar_url":"https://avatars0.githubusercontent.com/u/375847?v=4","gravatar_id":"","url":"https://api.github.com/users/cjbrowne","html_url":"https://github.com/cjbrowne","followers_url":"https://api.github.com/users/cjbrowne/followers","following_url":"https://api.github.com/users/cjbrowne/following{/other_user}","gists_url":"https://api.github.com/users/cjbrowne/gists{/gist_id}","starred_url":"https://api.github.com/users/cjbrowne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjbrowne/subscriptions","organizations_url":"https://api.github.com/users/cjbrowne/orgs","repos_url":"https://api.github.com/users/cjbrowne/repos","events_url":"https://api.github.com/users/cjbrowne/events{/privacy}","received_events_url":"https://api.github.com/users/cjbrowne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjbrowne/oshi","description":"Native Operating System and Hardware Information","fork":true,"url":"https://api.github.com/repos/cjbrowne/oshi","forks_url":"https://api.github.com/repos/cjbrowne/oshi/forks","keys_url":"https://api.github.com/repos/cjbrowne/oshi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjbrowne/oshi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjbrowne/oshi/teams","hooks_url":"https://api.github.com/repos/cjbrowne/oshi/hooks","issue_events_url":"https://api.github.com/repos/cjbrowne/oshi/issues/events{/number}","events_url":"https://api.github.com/repos/cjbrowne/oshi/events","assignees_url":"https://api.github.com/repos/cjbrowne/oshi/assignees{/user}","branches_url":"https://api.github.com/repos/cjbrowne/oshi/branches{/branch}","tags_url":"https://api.github.com/repos/cjbrowne/oshi/tags","blobs_url":"https://api.github.com/repos/cjbrowne/oshi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjbrowne/oshi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjbrowne/oshi/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjbrowne/oshi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjbrowne/oshi/statuses/{sha}","languages_url":"https://api.github.com/repos/cjbrowne/oshi/languages","stargazers_url":"https://api.github.com/repos/cjbrowne/oshi/stargazers","contributors_url":"https://api.github.com/repos/cjbrowne/oshi/contributors","subscribers_url":"https://api.github.com/repos/cjbrowne/oshi/subscribers","subscription_url":"https://api.github.com/repos/cjbrowne/oshi/subscription","commits_url":"https://api.github.com/repos/cjbrowne/oshi/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjbrowne/oshi/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjbrowne/oshi/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjbrowne/oshi/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjbrowne/oshi/contents/{+path}","compare_url":"https://api.github.com/repos/cjbrowne/oshi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjbrowne/oshi/merges","archive_url":"https://api.github.com/repos/cjbrowne/oshi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjbrowne/oshi/downloads","issues_url":"https://api.github.com/repos/cjbrowne/oshi/issues{/number}","pulls_url":"https://api.github.com/repos/cjbrowne/oshi/pulls{/number}","milestones_url":"https://api.github.com/repos/cjbrowne/oshi/milestones{/number}","notifications_url":"https://api.github.com/repos/cjbrowne/oshi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjbrowne/oshi/labels{/name}","releases_url":"https://api.github.com/repos/cjbrowne/oshi/releases{/id}","deployments_url":"https://api.github.com/repos/cjbrowne/oshi/deployments","created_at":"2018-05-23T08:19:43Z","updated_at":"2018-05-26T08:01:58Z","pushed_at":"2018-05-26T08:01:56Z","git_url":"git://github.com/cjbrowne/oshi.git","ssh_url":"git@github.com:cjbrowne/oshi.git","clone_url":"https://github.com/cjbrowne/oshi.git","svn_url":"https://github.com/cjbrowne/oshi","homepage":"","size":45149,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oshi:master","ref":"master","sha":"cd09e35462cc68a883e15982864cf52bd5539b56","user":{"login":"oshi","id":21304425,"avatar_url":"https://avatars2.githubusercontent.com/u/21304425?v=4","gravatar_id":"","url":"https://api.github.com/users/oshi","html_url":"https://github.com/oshi","followers_url":"https://api.github.com/users/oshi/followers","following_url":"https://api.github.com/users/oshi/following{/other_user}","gists_url":"https://api.github.com/users/oshi/gists{/gist_id}","starred_url":"https://api.github.com/users/oshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshi/subscriptions","organizations_url":"https://api.github.com/users/oshi/orgs","repos_url":"https://api.github.com/users/oshi/repos","events_url":"https://api.github.com/users/oshi/events{/privacy}","received_events_url":"https://api.github.com/users/oshi/received_events","type":"Organization","site_admin":false},"repo":{"id":3407114,"name":"oshi","full_name":"oshi/oshi","owner":{"login":"oshi","id":21304425,"avatar_url":"https://avatars2.githubusercontent.com/u/21304425?v=4","gravatar_id":"","url":"https://api.github.com/users/oshi","html_url":"https://github.com/oshi","followers_url":"https://api.github.com/users/oshi/followers","following_url":"https://api.github.com/users/oshi/following{/other_user}","gists_url":"https://api.github.com/users/oshi/gists{/gist_id}","starred_url":"https://api.github.com/users/oshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshi/subscriptions","organizations_url":"https://api.github.com/users/oshi/orgs","repos_url":"https://api.github.com/users/oshi/repos","events_url":"https://api.github.com/users/oshi/events{/privacy}","received_events_url":"https://api.github.com/users/oshi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oshi/oshi","description":"Native Operating System and Hardware Information","fork":false,"url":"https://api.github.com/repos/oshi/oshi","forks_url":"https://api.github.com/repos/oshi/oshi/forks","keys_url":"https://api.github.com/repos/oshi/oshi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oshi/oshi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oshi/oshi/teams","hooks_url":"https://api.github.com/repos/oshi/oshi/hooks","issue_events_url":"https://api.github.com/repos/oshi/oshi/issues/events{/number}","events_url":"https://api.github.com/repos/oshi/oshi/events","assignees_url":"https://api.github.com/repos/oshi/oshi/assignees{/user}","branches_url":"https://api.github.com/repos/oshi/oshi/branches{/branch}","tags_url":"https://api.github.com/repos/oshi/oshi/tags","blobs_url":"https://api.github.com/repos/oshi/oshi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oshi/oshi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oshi/oshi/git/refs{/sha}","trees_url":"https://api.github.com/repos/oshi/oshi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oshi/oshi/statuses/{sha}","languages_url":"https://api.github.com/repos/oshi/oshi/languages","stargazers_url":"https://api.github.com/repos/oshi/oshi/stargazers","contributors_url":"https://api.github.com/repos/oshi/oshi/contributors","subscribers_url":"https://api.github.com/repos/oshi/oshi/subscribers","subscription_url":"https://api.github.com/repos/oshi/oshi/subscription","commits_url":"https://api.github.com/repos/oshi/oshi/commits{/sha}","git_commits_url":"https://api.github.com/repos/oshi/oshi/git/commits{/sha}","comments_url":"https://api.github.com/repos/oshi/oshi/comments{/number}","issue_comment_url":"https://api.github.com/repos/oshi/oshi/issues/comments{/number}","contents_url":"https://api.github.com/repos/oshi/oshi/contents/{+path}","compare_url":"https://api.github.com/repos/oshi/oshi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oshi/oshi/merges","archive_url":"https://api.github.com/repos/oshi/oshi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oshi/oshi/downloads","issues_url":"https://api.github.com/repos/oshi/oshi/issues{/number}","pulls_url":"https://api.github.com/repos/oshi/oshi/pulls{/number}","milestones_url":"https://api.github.com/repos/oshi/oshi/milestones{/number}","notifications_url":"https://api.github.com/repos/oshi/oshi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oshi/oshi/labels{/name}","releases_url":"https://api.github.com/repos/oshi/oshi/releases{/id}","deployments_url":"https://api.github.com/repos/oshi/oshi/deployments","created_at":"2012-02-10T12:46:48Z","updated_at":"2018-05-25T05:50:05Z","pushed_at":"2018-05-26T08:01:57Z","git_url":"git://github.com/oshi/oshi.git","ssh_url":"git@github.com:oshi/oshi.git","clone_url":"https://github.com/oshi/oshi.git","svn_url":"https://github.com/oshi/oshi","homepage":"","size":45146,"stargazers_count":536,"watchers_count":536,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":146,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":146,"open_issues":21,"watchers":536,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oshi/oshi/pulls/501"},"html":{"href":"https://github.com/oshi/oshi/pull/501"},"issue":{"href":"https://api.github.com/repos/oshi/oshi/issues/501"},"comments":{"href":"https://api.github.com/repos/oshi/oshi/issues/501/comments"},"review_comments":{"href":"https://api.github.com/repos/oshi/oshi/pulls/501/comments"},"review_comment":{"href":"https://api.github.com/repos/oshi/oshi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oshi/oshi/pulls/501/commits"},"statuses":{"href":"https://api.github.com/repos/oshi/oshi/statuses/f1e4dcd435a3aa630d157d5c8fa22c5150e8293d"}},"author_association":"NONE"}}
{"actor":{"display_login":"codacy-bot"}}