{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments/208511469","pull_request_review_id":144332705,"id":208511469,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODUxMTQ2OQ==","diff_hunk":"@@ -0,0 +1,103 @@\n+- name: tear down existing osd filesystems then logical volumes, volume groups, and physical volumes\n+  hosts:\n+  - osds\n+\n+  vars_prompt:\n+    - name: ireallymeanit\n+      prompt: Are you sure you want to tear down the logical volumes?\n+      default: 'no'\n+      private: no\n+\n+  tasks:\n+  - name: exit playbook, if user did not mean to tear down logical volumes\n+    fail:\n+      msg: >\n+        \"Exiting lv-teardown playbook, logical volumes were NOT torn down.\n+         To tear down the logical volumes, either say 'yes' on the prompt or\n+         or use `-e ireallymeanit=yes` on the command line when\n+         invoking the playbook\"\n+    when: ireallymeanit != 'yes'\n+\n+  - name: include vars of lv_vars.yaml\n+    include_vars:\n+      file: lv_vars.yaml\n+\n+  # need to check if lvm2 is installed\n+  - name: install lvm2\n+    package:\n+      name: lvm2\n+      state: present\n+\n+# BEGIN TEARDOWN\n+  - name: find any existing OSD filesystems\n+    shell: \"grep /var/lib/ceph/osd /proc/mounts | awk '{print $2}'\"\n+    register: old_osd_filesystems\n+\n+  - name: tear down any existing OSD filesystems\n+    shell: \"umount -v {{item}}\"\n+    with_items: \"{{ old_osd_filesystems.stdout_lines }}\"\n+\n+  - name: kill all LVM commands that may have been hung\n+    shell: \"killall -q lvcreate pvcreate vgcreate lvconvert || echo -n\"","path":"infrastructure-playbooks/lv-teardown.yml","position":null,"original_position":41,"commit_id":"5ad607e4f0dbfb235316b8e2550c9e1157c62a87","original_commit_id":"4d5fba77608ff44dcbb636571f34371de6939e36","user":{"login":"leseb","id":912735,"node_id":"MDQ6VXNlcjkxMjczNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/912735?v=4","gravatar_id":"","url":"https://api.github.com/users/leseb","html_url":"https://github.com/leseb","followers_url":"https://api.github.com/users/leseb/followers","following_url":"https://api.github.com/users/leseb/following{/other_user}","gists_url":"https://api.github.com/users/leseb/gists{/gist_id}","starred_url":"https://api.github.com/users/leseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leseb/subscriptions","organizations_url":"https://api.github.com/users/leseb/orgs","repos_url":"https://api.github.com/users/leseb/repos","events_url":"https://api.github.com/users/leseb/events{/privacy}","received_events_url":"https://api.github.com/users/leseb/received_events","type":"User","site_admin":false},"body":"I think we should either remove the task for now. If commands hang that's probably for a good reason.","created_at":"2018-08-08T09:14:48Z","updated_at":"2018-08-08T09:14:48Z","html_url":"https://github.com/ceph/ceph-ansible/pull/2922#discussion_r208511469","pull_request_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/2922","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments/208511469"},"html":{"href":"https://github.com/ceph/ceph-ansible/pull/2922#discussion_r208511469"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/2922"}},"in_reply_to_id":208202217},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/2922","id":203529033,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTI5MDMz","html_url":"https://github.com/ceph/ceph-ansible/pull/2922","diff_url":"https://github.com/ceph/ceph-ansible/pull/2922.diff","patch_url":"https://github.com/ceph/ceph-ansible/pull/2922.patch","issue_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/2922","number":2922,"state":"open","locked":false,"title":"[skip ci] infrastructure-playbooks: playbooks for BI partitioning on NVMe","user":{"login":"alimaredia","id":4624480,"node_id":"MDQ6VXNlcjQ2MjQ0ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/4624480?v=4","gravatar_id":"","url":"https://api.github.com/users/alimaredia","html_url":"https://github.com/alimaredia","followers_url":"https://api.github.com/users/alimaredia/followers","following_url":"https://api.github.com/users/alimaredia/following{/other_user}","gists_url":"https://api.github.com/users/alimaredia/gists{/gist_id}","starred_url":"https://api.github.com/users/alimaredia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alimaredia/subscriptions","organizations_url":"https://api.github.com/users/alimaredia/orgs","repos_url":"https://api.github.com/users/alimaredia/repos","events_url":"https://api.github.com/users/alimaredia/events{/privacy}","received_events_url":"https://api.github.com/users/alimaredia/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Ali Maredia <amaredia@redhat.com>","created_at":"2018-07-24T13:35:49Z","updated_at":"2018-08-08T09:14:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fa1fc1ac477be76659bdd78a8774cf1bddcb44d","assignee":{"login":"alfredodeza","id":317847,"node_id":"MDQ6VXNlcjMxNzg0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/317847?v=4","gravatar_id":"","url":"https://api.github.com/users/alfredodeza","html_url":"https://github.com/alfredodeza","followers_url":"https://api.github.com/users/alfredodeza/followers","following_url":"https://api.github.com/users/alfredodeza/following{/other_user}","gists_url":"https://api.github.com/users/alfredodeza/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredodeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredodeza/subscriptions","organizations_url":"https://api.github.com/users/alfredodeza/orgs","repos_url":"https://api.github.com/users/alfredodeza/repos","events_url":"https://api.github.com/users/alfredodeza/events{/privacy}","received_events_url":"https://api.github.com/users/alfredodeza/received_events","type":"User","site_admin":false},"assignees":[{"login":"alfredodeza","id":317847,"node_id":"MDQ6VXNlcjMxNzg0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/317847?v=4","gravatar_id":"","url":"https://api.github.com/users/alfredodeza","html_url":"https://github.com/alfredodeza","followers_url":"https://api.github.com/users/alfredodeza/followers","following_url":"https://api.github.com/users/alfredodeza/following{/other_user}","gists_url":"https://api.github.com/users/alfredodeza/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredodeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredodeza/subscriptions","organizations_url":"https://api.github.com/users/alfredodeza/orgs","repos_url":"https://api.github.com/users/alfredodeza/repos","events_url":"https://api.github.com/users/alfredodeza/events{/privacy}","received_events_url":"https://api.github.com/users/alfredodeza/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":974825238,"node_id":"MDU6TGFiZWw5NzQ4MjUyMzg=","url":"https://api.github.com/repos/ceph/ceph-ansible/labels/DNM","name":"DNM","color":"e85a93","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/2922/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/2922/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/2922/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/5ad607e4f0dbfb235316b8e2550c9e1157c62a87","head":{"label":"ceph:wip-bucket-index-nvme-partition","ref":"wip-bucket-index-nvme-partition","sha":"5ad607e4f0dbfb235316b8e2550c9e1157c62a87","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":17373313,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3MzMxMw==","name":"ceph-ansible","full_name":"ceph/ceph-ansible","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-ansible","description":"Ansible playbooks to deploy Ceph, the distributed filesystem.","fork":false,"url":"https://api.github.com/repos/ceph/ceph-ansible","forks_url":"https://api.github.com/repos/ceph/ceph-ansible/forks","keys_url":"https://api.github.com/repos/ceph/ceph-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-ansible/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-ansible/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-ansible/events","assignees_url":"https://api.github.com/repos/ceph/ceph-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-ansible/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-ansible/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-ansible/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-ansible/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-ansible/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-ansible/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-ansible/merges","archive_url":"https://api.github.com/repos/ceph/ceph-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-ansible/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-ansible/deployments","created_at":"2014-03-03T17:12:09Z","updated_at":"2018-08-08T05:47:58Z","pushed_at":"2018-08-07T21:32:12Z","git_url":"git://github.com/ceph/ceph-ansible.git","ssh_url":"git@github.com:ceph/ceph-ansible.git","clone_url":"https://github.com/ceph/ceph-ansible.git","svn_url":"https://github.com/ceph/ceph-ansible","homepage":"","size":5058,"stargazers_count":691,"watchers_count":691,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":471,"mirror_url":null,"archived":false,"open_issues_count":151,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":471,"open_issues":151,"watchers":691,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"77d4023fbe2d8a57affb65ba05d1a987308a576e","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":17373313,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3MzMxMw==","name":"ceph-ansible","full_name":"ceph/ceph-ansible","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-ansible","description":"Ansible playbooks to deploy Ceph, the distributed filesystem.","fork":false,"url":"https://api.github.com/repos/ceph/ceph-ansible","forks_url":"https://api.github.com/repos/ceph/ceph-ansible/forks","keys_url":"https://api.github.com/repos/ceph/ceph-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-ansible/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-ansible/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-ansible/events","assignees_url":"https://api.github.com/repos/ceph/ceph-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-ansible/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-ansible/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-ansible/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-ansible/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-ansible/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-ansible/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-ansible/merges","archive_url":"https://api.github.com/repos/ceph/ceph-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-ansible/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-ansible/deployments","created_at":"2014-03-03T17:12:09Z","updated_at":"2018-08-08T05:47:58Z","pushed_at":"2018-08-07T21:32:12Z","git_url":"git://github.com/ceph/ceph-ansible.git","ssh_url":"git@github.com:ceph/ceph-ansible.git","clone_url":"https://github.com/ceph/ceph-ansible.git","svn_url":"https://github.com/ceph/ceph-ansible","homepage":"","size":5058,"stargazers_count":691,"watchers_count":691,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":471,"mirror_url":null,"archived":false,"open_issues_count":151,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":471,"open_issues":151,"watchers":691,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/2922"},"html":{"href":"https://github.com/ceph/ceph-ansible/pull/2922"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-ansible/issues/2922"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-ansible/issues/2922/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/2922/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/2922/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-ansible/statuses/5ad607e4f0dbfb235316b8e2550c9e1157c62a87"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"leseb"}}