{"push_id":3085148977,"size":38,"distinct_size":38,"ref":"refs/heads/1798659-style-cleanup","head":"b2a1d06acc79f4767c91502db166aa7f3eca3182","before":"97bac7c8976104f5bb932be2135b66b7940080e8","commits":[{"sha":"ab11c3b3b1b8f4e05751509d3ed0af5010c3aadb","author":{"name":"Max Filippov","email":"8c5ea195856807f4f02a6e0749c87ea6b7375f38@gmail.com"},"message":"target/xtensa: gdbstub fix register counting\n\nIn order to communicate correctly with gdb xtensa gdbstub must provide\nexpected number of registers in 'g' packet response. xtensa-elf-gdb\nexpects both nonprivileged and privileged registers. xtensa-linux-gdb\nonly expects nonprivileged registers. gdb only counts one contiguous\nstretch of registers, do the same for the core registers in the\nxtensa_count_regs.\n\nWith this change qemu-system-xtensa is able to communicate with all\nxtensa-elf-gdb versions (versions prior to 8.2 require overlay fixup),\nand qemu-xtensa is able to communicate with all xtensa-linux-gdb\nversions, except 8.2.\n\nSigned-off-by: Max Filippov <jcmvbkbc@gmail.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/ab11c3b3b1b8f4e05751509d3ed0af5010c3aadb"},{"sha":"6c14962711de107d3c61ee5ed67e7b5dc7c7fb87","author":{"name":"Max Filippov","email":"8c5ea195856807f4f02a6e0749c87ea6b7375f38@gmail.com"},"message":"target/xtensa: drop num_[core_]regs from dc232b/dc233c configs\n\nNow that xtensa_count_regs does the right thing, remove manual\ninitialization of these fields from the affected configurations and let\nxtensa_finalize_config initialize them. Add XTREG_END to terminate\nregister lists.\n\nSigned-off-by: Max Filippov <jcmvbkbc@gmail.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/6c14962711de107d3c61ee5ed67e7b5dc7c7fb87"},{"sha":"0ef9a558c2ddbbafedf2cc6f528eb05a36ff1621","author":{"name":"Kevin Wolf","email":"b75d81c03bd01637475de8fdfe57bd6e8b41a08d@redhat.com"},"message":"iotests: Replace time.clock() with Timeout\n\ntime.clock() is deprecated since Python 3.3. Current Python versions\nwarn that the function will be removed in Python 3.8, and those warnings\nmake the test case 118 fail.\n\nReplace it with the Timeout mechanism that is compatible with both\nPython 2 and 3, and makes the code even a little nicer.\n\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>\nReviewed-by: John Snow <jsnow@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/0ef9a558c2ddbbafedf2cc6f528eb05a36ff1621"},{"sha":"9518911ca3790667c88f61203186efde9c8776fa","author":{"name":"Kevin Wolf","email":"b75d81c03bd01637475de8fdfe57bd6e8b41a08d@redhat.com"},"message":"iotests: Replace assertEquals() with assertEqual()\n\nTestCase.assertEquals() is deprecated since Python 2.7. Recent Python\nversions print a warning when the function is called, which makes test\ncases fail.\n\nReplace it with the preferred spelling assertEqual().\n\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>\nReviewed-by: John Snow <jsnow@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/9518911ca3790667c88f61203186efde9c8776fa"},{"sha":"bb1d3dc5907e653a92d6b9b8d7922ac204b747c3","author":{"name":"Zhang Chen","email":"55f0acf27bcdb33c2732d367c7bb72afd68ba6ef@gmail.com"},"message":"migration/colo.c: Fix compilation issue when disable replication\n\nThis compilation issue will occur when user use --disable-replication\nto config Qemu.\n\nReported-by: Thomas Huth <thuth@redhat.com>\nSigned-off-by: Zhang Chen <zhangckid@gmail.com>\nMessage-Id: <20181101021226.6353-1-zhangckid@gmail.com>\nTested-by: Thomas Huth <thuth@redhat.com>\nSigned-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/bb1d3dc5907e653a92d6b9b8d7922ac204b747c3"},{"sha":"4709da7e0519b56fad2bd3aaed13414c518b8bdf","author":{"name":"Zhang Chen","email":"83f6bbfaa21c6de43885acff7e0bc746c7f41beb@intel.com"},"message":"migration/migration.c: Add COLO dependency checks\n\nCurrent COLO mode(independent disk mode) need replication module work\ntogether. Suggested by Dr. David Alan Gilbert <dgilbert@redhat.com>.\n\nSigned-off-by: Zhang Chen <chen.zhang@intel.com>\nMessage-Id: <20181114190912.7242-1-chen.zhang@intel.com>\nReviewed-by: Peter Xu <peterx@redhat.com>\nSigned-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/4709da7e0519b56fad2bd3aaed13414c518b8bdf"},{"sha":"4a730fea98e1ed8cb1c7e7d92f05b088c24a4ba4","author":{"name":"Eric Blake","email":"a9da18479c871fe903d9590822cfe2629c6a4d11@redhat.com"},"message":"iotests: Skip 233 if certtool not installed\n\nThe use of TLS while building qemu is optional. While the\n'certtool' binary should be available on every platform that\nsupports building against TLS, that does not imply that the\ndeveloper has installed it.  Make the test gracefully skip\nin that case.\n\nReported-by: Kevin Wolf <kwolf@redhat.com>\nSigned-off-by: Eric Blake <eblake@redhat.com>\nReviewed-by: John Snow <jsnow@redhat.com>\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nReviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/4a730fea98e1ed8cb1c7e7d92f05b088c24a4ba4"},{"sha":"0b147be321873bb7e1da4e41cc40ff0e94c23e47","author":{"name":"Max Reitz","email":"6779b6f8ab957befe3afd965a2c13eebbdd5a946@redhat.com"},"message":"qemu-img: Fix typo\n\nFixes: d402b6a21a825a5c07aac9251990860723d49f5d\nReported-by: Kevin Wolf <kwolf@redhat.com>\nCc: qemu-stable@nongnu.org\nSigned-off-by: Max Reitz <mreitz@redhat.com>\nReviewed-by: John Snow <jsnow@redhat.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/0b147be321873bb7e1da4e41cc40ff0e94c23e47"},{"sha":"5840fcba1eb22903022f4d4afd86aad92dd37023","author":{"name":"Max Reitz","email":"6779b6f8ab957befe3afd965a2c13eebbdd5a946@redhat.com"},"message":"qemu-img: Fix leak\n\ncreate_opts was leaked here.  This is not too bad since the process is\nabout to exit anyway, but relying on that does not make the code nicer\nto read.\n\nFixes: d402b6a21a825a5c07aac9251990860723d49f5d\nReported-by: Kevin Wolf <kwolf@redhat.com>\nCc: qemu-stable@nongnu.org\nSigned-off-by: Max Reitz <mreitz@redhat.com>\nReviewed-by: John Snow <jsnow@redhat.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/5840fcba1eb22903022f4d4afd86aad92dd37023"},{"sha":"67b27c9eb42e6849615acee1557df7005570286a","author":{"name":"Max Filippov","email":"8c5ea195856807f4f02a6e0749c87ea6b7375f38@gmail.com"},"message":"target/xtensa: xtfpga: provide default memory sizes\n\nProvide default RAM sizes for all XTFPGA boards, so that when started\nwithout -m option they do the right thing.\n\nSigned-off-by: Max Filippov <jcmvbkbc@gmail.com>\nReviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/67b27c9eb42e6849615acee1557df7005570286a"},{"sha":"949308388e0d8c2a07e617bcfaf2a0814cf8f3ee","author":{"name":"Richard W.M. Jones","email":"d9c0c1814229c9d7f78a7e860ff9791c82a22dba@redhat.com"},"message":"scsi-disk: Fix crash if underlying host file or disk returns error\n\nCommit 40dce4ee6 \"scsi-disk: fix rerror/werror=ignore\" introduced a\nbug which causes qemu to crash with the assertion error below if the\nhost file or disk returns an error:\n\n  qemu-system-x86_64: hw/scsi/scsi-bus.c:1374: scsi_req_complete:\n  Assertion `req->status == -1' failed.\n\nKevin Wolf suggested this fix:\n\n  < kwolf> Hm, should the final return false; in that patch\n           actually be a return true?\n  < kwolf> Because I think he didn't intend to change anything\n           except BLOCK_ERROR_ACTION_IGNORE\n\nBuglink: https://bugs.launchpad.net/qemu/+bug/1804323\nFixes: 40dce4ee61c68395f6d463fae792f61b7c003bce\nSigned-off-by: Richard W.M. Jones <rjones@redhat.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/949308388e0d8c2a07e617bcfaf2a0814cf8f3ee"},{"sha":"b38754cf6b768ea2339c9df23e53e41b1aa8490e","author":{"name":"Alberto Garcia","email":"e9db499e13ac90573163837d2fb1fc9f85402d6d@igalia.com"},"message":"block: Fix update of BDRV_O_AUTO_RDONLY in update_flags_from_options()\n\nCommit e35bdc123a4ace9f4d3fcca added the auto-read-only option and the\ncode to update its corresponding flag in update_flags_from_options(),\nbut forgot to clear the flag if auto-read-only is false.\n\nSigned-off-by: Alberto Garcia <berto@igalia.com>\nReported-by: Max Reitz <mreitz@redhat.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/b38754cf6b768ea2339c9df23e53e41b1aa8490e"},{"sha":"a198633f53f817a7750240d74fc32288323752c0","author":{"name":"Daniel P. Berrangé","email":"bb938cf255e055ff3507f2627d214e8e62118fcf@redhat.com"},"message":"iotests: fix nbd test 233 to work correctly with raw images\n\nThe first qemu-io command must honour the $IMGFMT that is set rather\nthan hardcoding qcow2. The qemu-nbd commands should also set $IMGFMT\nto avoid the insecure format probe warning.\n\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>\nReviewed-by: Eric Blake <eblake@redhat.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/a198633f53f817a7750240d74fc32288323752c0"},{"sha":"b146457092d1c186435fea41726a21459c5adc8a","author":{"name":"Igor Druzhinin","email":"784725034387df2329b632f671cc72728f84f887@citrix.com"},"message":"nvme: call blk_drain in NVMe reset code to avoid lockups\n\nWhen blk_flush called in NVMe reset path S/C queues are already freed\nwhich means that re-entering AIO handling loop having some IO requests\nunfinished will lockup or crash as their SG structures being potentially\nreused. Call blk_drain before freeing the queues to avoid this nasty\nscenario.\n\nSigned-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>\nAcked-by: Paolo Bonzini <pbonzini@redhat.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/b146457092d1c186435fea41726a21459c5adc8a"},{"sha":"41ae84e85ff22254c5b6b9a5ddcd01bbef2eb568","author":{"name":"Paolo Bonzini","email":"69d3ebcf5ee4e7f05a50dc23cd96655b730804b4@redhat.com"},"message":"nvme: fix out-of-bounds access to the CMB\n\nBecause the CMB BAR has a min_access_size of 2, if you read the last\nbyte it will try to memcpy *2* bytes from n->cmbuf, causing an off-by-one\nerror.  This is CVE-2018-16847.\n\nAnother way to fix this might be to register the CMB as a RAM memory\nregion, which would also be more efficient.  However, that might be a\nchange for big-endian machines; I didn't think this through and I don't\nknow how real hardware works.  Add a basic testcase for the CMB in case\nsomebody does this change later on.\n\nCc: Keith Busch <keith.busch@intel.com>\nCc: qemu-block@nongnu.org\nReported-by: Li Qiang <liq3ea@gmail.com>\nReviewed-by: Li Qiang <liq3ea@gmail.com>\nTested-by: Li Qiang <liq3ea@gmail.com>\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>\nTested-by: Philippe Mathieu-Daudé <philmd@redhat.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/41ae84e85ff22254c5b6b9a5ddcd01bbef2eb568"},{"sha":"b7555d7cb4cb72078bd6384707834c24f4649b26","author":{"name":"Kevin Wolf","email":"b75d81c03bd01637475de8fdfe57bd6e8b41a08d@redhat.com"},"message":"Revert \"nvme: fix oob access issue(CVE-2018-16847)\"\n\nThis reverts commit 5e3c0220d7e4f0361c4d36c697a8842f2b583402.\nWe have a better fix commited for this now.\n\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/b7555d7cb4cb72078bd6384707834c24f4649b26"},{"sha":"fc0d954aa011b232ec8cd8a006190c8b21a40f31","author":{"name":"Paolo Bonzini","email":"69d3ebcf5ee4e7f05a50dc23cd96655b730804b4@redhat.com"},"message":"nvme: fix CMB endianness confusion\n\nThe CMB is marked as DEVICE_LITTLE_ENDIAN, so the data must be\nread/written as if it was little-endian output (in the case of\nbig endian, we get two swaps, one in the memory core and one\nin nvme.c).\n\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\nTested-by: Peter Maydell <peter.maydell@linaro.org>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/fc0d954aa011b232ec8cd8a006190c8b21a40f31"},{"sha":"44c8ebe941c750c24642cb00045c4d38140d0d4e","author":{"name":"Logan Gunthorpe","email":"a78d21ab03eaf4c93041deb5a9100494a8d5d5c7@deltatee.com"},"message":"nvme: fix bug with PCI IRQ pins on teardown\n\nWhen the submission and completion queues are being torn down\nthe IRQ will be asserted for the completion queue when the\nsubmsission queue is deleted. Then when the completion queue\nis deleted it stays asserted. Thus, on systems that do\nnot use MSI, no further interrupts can be triggered on the host.\n\nLinux sees this as a long delay when unbinding the nvme device.\nEventually the interrupt timeout occurs and it continues.\n\nTo fix this we ensure we deassert the IRQ for a CQ when it is\ndeleted.\n\nSigned-off-by: Logan Gunthorpe <logang@deltatee.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/44c8ebe941c750c24642cb00045c4d38140d0d4e"},{"sha":"beeb9cdd0d333070ee67c7b7ec9f8bfd4b67b678","author":{"name":"Eric Blake","email":"a9da18479c871fe903d9590822cfe2629c6a4d11@redhat.com"},"message":"iotests: Enhance 223 to cover multiple bitmap granularities\n\nTesting granularity at the same size as the cluster isn't quite\nas fun as what happens when it is larger or smaller.  This\nenhancement also shows that qemu's nbd server can serve the\nsame disk over multiple exports simultaneously.\n\nSigned-off-by: Eric Blake <eblake@redhat.com>\nTested-by: John Snow <jsnow@redhat.com>\nReviewed-by: John Snow <jsnow@redhat.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/beeb9cdd0d333070ee67c7b7ec9f8bfd4b67b678"},{"sha":"795eab620a3daefc787f0fe9021c6d7be4c83e3f","author":{"name":"Alberto Garcia","email":"e9db499e13ac90573163837d2fb1fc9f85402d6d@igalia.com"},"message":"block: Update BlockDriverState.inherits_from on bdrv_set_backing_hd()\n\nWhen a BlockDriverState's child is opened (be it a backing file, the\nprotocol layer, or any other) inherits_from is set to point to the\nparent node. Children opened separately and then attached to a parent\ndon't have this pointer set.\n\nbdrv_reopen_queue_child() uses this to determine whether a node's\nchildren must also be reopened inheriting the options from the parent\nor not. If inherits_from points to the parent then the child is\nreopened and its options can be changed, like in this example:\n\n   $ qemu-img create -f qcow2 hd0.qcow2 1M\n   $ qemu-img create -f qcow2 hd1.qcow2 1M\n   $ $QEMU -drive if=none,node-name=hd0,file=hd0.qcow2,\\\n                  backing.driver=qcow2,backing.file.filename=hd1.qcow2\n   (qemu) qemu-io hd0 \"reopen -o backing.l2-cache-size=2M\"\n\nIf the child does not inherit from the parent then it does not get\nreopened and its options cannot be changed:\n\n   $ $QEMU -drive if=none,node-name=hd1,file=hd1.qcow2\n           -drive if=none,node-name=hd0,file=hd0.qcow2,backing=hd1\n   (qemu) qemu-io hd0 \"reopen -o backing.l2-cache-size=2M\"\n   Cannot change the option 'backing.l2-cache-size'\n\nIf a disk image has a chain of backing files then all of them are also\nconnected through their inherits_from pointers (i.e. it's possible to\nwalk the chain in reverse order from base to top).\n\nHowever this is broken if the intermediate nodes are removed using\ne.g. block-stream because the inherits_from pointer from the base node\nbecomes NULL:\n\n   $ qemu-img create -f qcow2 hd0.qcow2 1M\n   $ qemu-img create -f qcow2 -b hd0.qcow2 hd1.qcow2\n   $ qemu-img create -f qcow2 -b hd1.qcow2 hd2.qcow2\n   $ $QEMU -drive if=none,file=hd2.qcow2\n   (qemu) qemu-io none0 \"reopen -o backing.l2-cache-size=2M\"\n   (qemu) block_stream none0 0 hd0.qcow2\n   (qemu) qemu-io none0 \"reopen -o backing.l2-cache-size=2M\"\n   Cannot change the option 'backing.l2-cache-size'\n\nThis patch updates the inherits_from pointer if the intermediate nodes\nof a backing chain are removed using bdrv_set_backing_hd(), and adds a\ntest case for this scenario.\n\nSigned-off-by: Alberto Garcia <berto@igalia.com>\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ldeweysuse/qemu/commits/795eab620a3daefc787f0fe9021c6d7be4c83e3f"}]}
{"actor":{"display_login":"ldeweysuse"}}