{"action":"created","comment":{"url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/pulls/comments/237051496","pull_request_review_id":179255977,"id":237051496,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzA1MTQ5Ng==","diff_hunk":"@@ -29,7 +29,10 @@\n     \"ember-cli-babel\": \"^7.1.3\",\n     \"ember-cli-htmlbars\": \"^3.0.1\",\n     \"ember-cli-sass\": \"^8.0.1\",\n-    \"uniplaces-uniq\": \"^2.5.3\"\n+    \"ember-progress-bar\": \"^1.0.0\",","path":"package.json","position":5,"original_position":5,"commit_id":"6c869696cd00a1ad87f087493914eb4c5f439a68","original_commit_id":"6c869696cd00a1ad87f087493914eb4c5f439a68","user":{"login":"migueldemoura","id":9093796,"node_id":"MDQ6VXNlcjkwOTM3OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/9093796?v=4","gravatar_id":"","url":"https://api.github.com/users/migueldemoura","html_url":"https://github.com/migueldemoura","followers_url":"https://api.github.com/users/migueldemoura/followers","following_url":"https://api.github.com/users/migueldemoura/following{/other_user}","gists_url":"https://api.github.com/users/migueldemoura/gists{/gist_id}","starred_url":"https://api.github.com/users/migueldemoura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/migueldemoura/subscriptions","organizations_url":"https://api.github.com/users/migueldemoura/orgs","repos_url":"https://api.github.com/users/migueldemoura/repos","events_url":"https://api.github.com/users/migueldemoura/events{/privacy}","received_events_url":"https://api.github.com/users/migueldemoura/received_events","type":"User","site_admin":false},"body":"That is true but also applies to other dependencies. I think this should be addressed by https://github.com/uniplaces/ember-cli-uniq/issues/279 instead, especially given your own comment at https://github.com/uniplaces/ember-cli-uniq/issues/208.","created_at":"2018-11-28T11:53:53Z","updated_at":"2018-11-28T11:53:53Z","html_url":"https://github.com/uniplaces/ember-cli-uniq/pull/295#discussion_r237051496","pull_request_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/pulls/295","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/uniplaces/ember-cli-uniq/pulls/comments/237051496"},"html":{"href":"https://github.com/uniplaces/ember-cli-uniq/pull/295#discussion_r237051496"},"pull_request":{"href":"https://api.github.com/repos/uniplaces/ember-cli-uniq/pulls/295"}},"in_reply_to_id":236735752},"pull_request":{"url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/pulls/295","id":233895429,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzODk1NDI5","html_url":"https://github.com/uniplaces/ember-cli-uniq/pull/295","diff_url":"https://github.com/uniplaces/ember-cli-uniq/pull/295.diff","patch_url":"https://github.com/uniplaces/ember-cli-uniq/pull/295.patch","issue_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/issues/295","number":295,"state":"open","locked":false,"title":"[RFC][UN-15257] Bundle ember-cli-uniq dependencies inside package","user":{"login":"migueldemoura","id":9093796,"node_id":"MDQ6VXNlcjkwOTM3OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/9093796?v=4","gravatar_id":"","url":"https://api.github.com/users/migueldemoura","html_url":"https://github.com/migueldemoura","followers_url":"https://api.github.com/users/migueldemoura/followers","following_url":"https://api.github.com/users/migueldemoura/following{/other_user}","gists_url":"https://api.github.com/users/migueldemoura/gists{/gist_id}","starred_url":"https://api.github.com/users/migueldemoura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/migueldemoura/subscriptions","organizations_url":"https://api.github.com/users/migueldemoura/orgs","repos_url":"https://api.github.com/users/migueldemoura/repos","events_url":"https://api.github.com/users/migueldemoura/events{/privacy}","received_events_url":"https://api.github.com/users/migueldemoura/received_events","type":"User","site_admin":false},"body":"We could also have these on a blueprint so they get added on ember install, but since this project is under active development I think this is easier. Thoughts?\r\n\r\nFixes:\r\nhttps://github.com/uniplaces/ember-cli-uniq/issues/208\r\nhttps://github.com/uniplaces/ember-cli-uniq/issues/265\r\n","created_at":"2018-11-27T12:37:43Z","updated_at":"2018-11-28T11:53:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34c7ee96b4607f1f1a22b5f5f2a425ea9304a817","assignee":null,"assignees":[],"requested_reviewers":[{"login":"niceoutput","id":1120141,"node_id":"MDQ6VXNlcjExMjAxNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1120141?v=4","gravatar_id":"","url":"https://api.github.com/users/niceoutput","html_url":"https://github.com/niceoutput","followers_url":"https://api.github.com/users/niceoutput/followers","following_url":"https://api.github.com/users/niceoutput/following{/other_user}","gists_url":"https://api.github.com/users/niceoutput/gists{/gist_id}","starred_url":"https://api.github.com/users/niceoutput/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niceoutput/subscriptions","organizations_url":"https://api.github.com/users/niceoutput/orgs","repos_url":"https://api.github.com/users/niceoutput/repos","events_url":"https://api.github.com/users/niceoutput/events{/privacy}","received_events_url":"https://api.github.com/users/niceoutput/received_events","type":"User","site_admin":false},{"login":"sardyy","id":12813036,"node_id":"MDQ6VXNlcjEyODEzMDM2","avatar_url":"https://avatars0.githubusercontent.com/u/12813036?v=4","gravatar_id":"","url":"https://api.github.com/users/sardyy","html_url":"https://github.com/sardyy","followers_url":"https://api.github.com/users/sardyy/followers","following_url":"https://api.github.com/users/sardyy/following{/other_user}","gists_url":"https://api.github.com/users/sardyy/gists{/gist_id}","starred_url":"https://api.github.com/users/sardyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sardyy/subscriptions","organizations_url":"https://api.github.com/users/sardyy/orgs","repos_url":"https://api.github.com/users/sardyy/repos","events_url":"https://api.github.com/users/sardyy/events{/privacy}","received_events_url":"https://api.github.com/users/sardyy/received_events","type":"User","site_admin":false},{"login":"DaniFrancisco","id":17492799,"node_id":"MDQ6VXNlcjE3NDkyNzk5","avatar_url":"https://avatars3.githubusercontent.com/u/17492799?v=4","gravatar_id":"","url":"https://api.github.com/users/DaniFrancisco","html_url":"https://github.com/DaniFrancisco","followers_url":"https://api.github.com/users/DaniFrancisco/followers","following_url":"https://api.github.com/users/DaniFrancisco/following{/other_user}","gists_url":"https://api.github.com/users/DaniFrancisco/gists{/gist_id}","starred_url":"https://api.github.com/users/DaniFrancisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaniFrancisco/subscriptions","organizations_url":"https://api.github.com/users/DaniFrancisco/orgs","repos_url":"https://api.github.com/users/DaniFrancisco/repos","events_url":"https://api.github.com/users/DaniFrancisco/events{/privacy}","received_events_url":"https://api.github.com/users/DaniFrancisco/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/pulls/295/commits","review_comments_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/pulls/295/comments","review_comment_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/issues/295/comments","statuses_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/statuses/6c869696cd00a1ad87f087493914eb4c5f439a68","head":{"label":"uniplaces:UN-15257/Bundle-ember-cli-uniq-dependencies-inside-package","ref":"UN-15257/Bundle-ember-cli-uniq-dependencies-inside-package","sha":"6c869696cd00a1ad87f087493914eb4c5f439a68","user":{"login":"uniplaces","id":1397679,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTc2Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1397679?v=4","gravatar_id":"","url":"https://api.github.com/users/uniplaces","html_url":"https://github.com/uniplaces","followers_url":"https://api.github.com/users/uniplaces/followers","following_url":"https://api.github.com/users/uniplaces/following{/other_user}","gists_url":"https://api.github.com/users/uniplaces/gists{/gist_id}","starred_url":"https://api.github.com/users/uniplaces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uniplaces/subscriptions","organizations_url":"https://api.github.com/users/uniplaces/orgs","repos_url":"https://api.github.com/users/uniplaces/repos","events_url":"https://api.github.com/users/uniplaces/events{/privacy}","received_events_url":"https://api.github.com/users/uniplaces/received_events","type":"Organization","site_admin":false},"repo":{"id":71513751,"node_id":"MDEwOlJlcG9zaXRvcnk3MTUxMzc1MQ==","name":"ember-cli-uniq","full_name":"uniplaces/ember-cli-uniq","private":false,"owner":{"login":"uniplaces","id":1397679,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTc2Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1397679?v=4","gravatar_id":"","url":"https://api.github.com/users/uniplaces","html_url":"https://github.com/uniplaces","followers_url":"https://api.github.com/users/uniplaces/followers","following_url":"https://api.github.com/users/uniplaces/following{/other_user}","gists_url":"https://api.github.com/users/uniplaces/gists{/gist_id}","starred_url":"https://api.github.com/users/uniplaces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uniplaces/subscriptions","organizations_url":"https://api.github.com/users/uniplaces/orgs","repos_url":"https://api.github.com/users/uniplaces/repos","events_url":"https://api.github.com/users/uniplaces/events{/privacy}","received_events_url":"https://api.github.com/users/uniplaces/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uniplaces/ember-cli-uniq","description":"Default components for Ember.js that implement the Uniplaces Design System","fork":false,"url":"https://api.github.com/repos/uniplaces/ember-cli-uniq","forks_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/forks","keys_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/teams","hooks_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/hooks","issue_events_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/issues/events{/number}","events_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/events","assignees_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/assignees{/user}","branches_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/branches{/branch}","tags_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/tags","blobs_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/git/refs{/sha}","trees_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/statuses/{sha}","languages_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/languages","stargazers_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/stargazers","contributors_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/contributors","subscribers_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/subscribers","subscription_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/subscription","commits_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/commits{/sha}","git_commits_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/git/commits{/sha}","comments_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/comments{/number}","issue_comment_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/issues/comments{/number}","contents_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/contents/{+path}","compare_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/merges","archive_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/downloads","issues_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/issues{/number}","pulls_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/pulls{/number}","milestones_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/milestones{/number}","notifications_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/labels{/name}","releases_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/releases{/id}","deployments_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/deployments","created_at":"2016-10-20T23:55:41Z","updated_at":"2018-11-27T16:07:22Z","pushed_at":"2018-11-27T16:57:17Z","git_url":"git://github.com/uniplaces/ember-cli-uniq.git","ssh_url":"git@github.com:uniplaces/ember-cli-uniq.git","clone_url":"https://github.com/uniplaces/ember-cli-uniq.git","svn_url":"https://github.com/uniplaces/ember-cli-uniq","homepage":"","size":5831,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":11,"watchers":4,"default_branch":"master"}},"base":{"label":"uniplaces:master","ref":"master","sha":"b8b4629ab4d564ece9c9ac4e5814a663a2ad67ea","user":{"login":"uniplaces","id":1397679,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTc2Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1397679?v=4","gravatar_id":"","url":"https://api.github.com/users/uniplaces","html_url":"https://github.com/uniplaces","followers_url":"https://api.github.com/users/uniplaces/followers","following_url":"https://api.github.com/users/uniplaces/following{/other_user}","gists_url":"https://api.github.com/users/uniplaces/gists{/gist_id}","starred_url":"https://api.github.com/users/uniplaces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uniplaces/subscriptions","organizations_url":"https://api.github.com/users/uniplaces/orgs","repos_url":"https://api.github.com/users/uniplaces/repos","events_url":"https://api.github.com/users/uniplaces/events{/privacy}","received_events_url":"https://api.github.com/users/uniplaces/received_events","type":"Organization","site_admin":false},"repo":{"id":71513751,"node_id":"MDEwOlJlcG9zaXRvcnk3MTUxMzc1MQ==","name":"ember-cli-uniq","full_name":"uniplaces/ember-cli-uniq","private":false,"owner":{"login":"uniplaces","id":1397679,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTc2Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1397679?v=4","gravatar_id":"","url":"https://api.github.com/users/uniplaces","html_url":"https://github.com/uniplaces","followers_url":"https://api.github.com/users/uniplaces/followers","following_url":"https://api.github.com/users/uniplaces/following{/other_user}","gists_url":"https://api.github.com/users/uniplaces/gists{/gist_id}","starred_url":"https://api.github.com/users/uniplaces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uniplaces/subscriptions","organizations_url":"https://api.github.com/users/uniplaces/orgs","repos_url":"https://api.github.com/users/uniplaces/repos","events_url":"https://api.github.com/users/uniplaces/events{/privacy}","received_events_url":"https://api.github.com/users/uniplaces/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uniplaces/ember-cli-uniq","description":"Default components for Ember.js that implement the Uniplaces Design System","fork":false,"url":"https://api.github.com/repos/uniplaces/ember-cli-uniq","forks_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/forks","keys_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/teams","hooks_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/hooks","issue_events_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/issues/events{/number}","events_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/events","assignees_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/assignees{/user}","branches_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/branches{/branch}","tags_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/tags","blobs_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/git/refs{/sha}","trees_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/statuses/{sha}","languages_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/languages","stargazers_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/stargazers","contributors_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/contributors","subscribers_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/subscribers","subscription_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/subscription","commits_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/commits{/sha}","git_commits_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/git/commits{/sha}","comments_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/comments{/number}","issue_comment_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/issues/comments{/number}","contents_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/contents/{+path}","compare_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/merges","archive_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/downloads","issues_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/issues{/number}","pulls_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/pulls{/number}","milestones_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/milestones{/number}","notifications_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/labels{/name}","releases_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/releases{/id}","deployments_url":"https://api.github.com/repos/uniplaces/ember-cli-uniq/deployments","created_at":"2016-10-20T23:55:41Z","updated_at":"2018-11-27T16:07:22Z","pushed_at":"2018-11-27T16:57:17Z","git_url":"git://github.com/uniplaces/ember-cli-uniq.git","ssh_url":"git@github.com:uniplaces/ember-cli-uniq.git","clone_url":"https://github.com/uniplaces/ember-cli-uniq.git","svn_url":"https://github.com/uniplaces/ember-cli-uniq","homepage":"","size":5831,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":11,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uniplaces/ember-cli-uniq/pulls/295"},"html":{"href":"https://github.com/uniplaces/ember-cli-uniq/pull/295"},"issue":{"href":"https://api.github.com/repos/uniplaces/ember-cli-uniq/issues/295"},"comments":{"href":"https://api.github.com/repos/uniplaces/ember-cli-uniq/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/uniplaces/ember-cli-uniq/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/uniplaces/ember-cli-uniq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uniplaces/ember-cli-uniq/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/uniplaces/ember-cli-uniq/statuses/6c869696cd00a1ad87f087493914eb4c5f439a68"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"migueldemoura"}}