{"action":"created","issue":{"url":"https://api.github.com/repos/spinnaker/spinnaker/issues/2659","repository_url":"https://api.github.com/repos/spinnaker/spinnaker","labels_url":"https://api.github.com/repos/spinnaker/spinnaker/issues/2659/labels{/name}","comments_url":"https://api.github.com/repos/spinnaker/spinnaker/issues/2659/comments","events_url":"https://api.github.com/repos/spinnaker/spinnaker/issues/2659/events","html_url":"https://github.com/spinnaker/spinnaker/issues/2659","id":314255062,"node_id":"MDU6SXNzdWUzMTQyNTUwNjI=","number":2659,"title":"Improved deployment configuration for halyard","user":{"login":"Leftbrained","id":1720071,"node_id":"MDQ6VXNlcjE3MjAwNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1720071?v=4","gravatar_id":"","url":"https://api.github.com/users/Leftbrained","html_url":"https://github.com/Leftbrained","followers_url":"https://api.github.com/users/Leftbrained/followers","following_url":"https://api.github.com/users/Leftbrained/following{/other_user}","gists_url":"https://api.github.com/users/Leftbrained/gists{/gist_id}","starred_url":"https://api.github.com/users/Leftbrained/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leftbrained/subscriptions","organizations_url":"https://api.github.com/users/Leftbrained/orgs","repos_url":"https://api.github.com/users/Leftbrained/repos","events_url":"https://api.github.com/users/Leftbrained/events{/privacy}","received_events_url":"https://api.github.com/users/Leftbrained/received_events","type":"User","site_admin":false},"labels":[{"id":675893188,"node_id":"MDU6TGFiZWw2NzU4OTMxODg=","url":"https://api.github.com/repos/spinnaker/spinnaker/labels/component/halyard","name":"component/halyard","color":"c7def8","default":false},{"id":111166989,"node_id":"MDU6TGFiZWwxMTExNjY5ODk=","url":"https://api.github.com/repos/spinnaker/spinnaker/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":936546350,"node_id":"MDU6TGFiZWw5MzY1NDYzNTA=","url":"https://api.github.com/repos/spinnaker/spinnaker/labels/stale","name":"stale","color":"000000","default":false},{"id":1025177299,"node_id":"MDU6TGFiZWwxMDI1MTc3Mjk5","url":"https://api.github.com/repos/spinnaker/spinnaker/labels/to-be-closed","name":"to-be-closed","color":"000000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-13T21:25:52Z","updated_at":"2018-11-13T14:56:46Z","closed_at":null,"author_association":"NONE","body":"In an effort to ease the difficulties in the varieties of ways spinnaker can deploy I am requesting a change to halyard to separate the deploy types into their own separate sub sections of the config (similar to the storage config), I'm calling out some config options which seem like they can be moved (not talking about the ones outside my understanding). \r\n\r\nI've had some specific [issues](https://community.spinnaker.io/t/how-to-setup-ingress-on-gke/262/13) in trying to understand what was happening that I hope these changes would address:\r\n\r\n1. Failures in distributed deployment caused by lack of resources resulted in timeout errors and generally odd behavior. If the resource requests and/or limits were defined by default I think I would have gotten some very clear unschedulable message from Kubernetes\r\n2. Setting up an Ingress manually seems unnecessary, as that ingress could be maintained by halyard. (it was confusing the issues I had)\r\n\r\nHere is what I think the options might look like:\r\n- `hal config deploy edit`\r\n  - `--type`\r\n- `hal config deploy type distributed edit`\r\n  - `--namespace`\r\n  - `--account-name`\r\n  - `--ingress`: If true would create Ingress routing both gate and deck through one external IP address. (Using /gate/* to route requests to gate?)\r\n  - `--ingress-tls=my-cert-tls`\r\n- `hal config deploy type distributed service {service-name} edit`\r\n  - `--resource-requests-cpu`: Defaults to a sane minimal value\r\n  - `--resource-requests-memory`: Defaults to a sane minimal value\r\n  - `--resource-limit-cpu`: Defaults to a sane minimal value\r\n  - `--resource-limit-memory`: Defaults to a sane minimal value\r\n- `hal config deploy type localdebian edit`\r\n  - Would there be any config for a localdebian install? \r\n- `hal config deploy type localgit edit`\r\n  - `--git-origin-user`\r\n  - `--git-upstream-user`\r\n  - `--apps-dir`"},"comment":{"url":"https://api.github.com/repos/spinnaker/spinnaker/issues/comments/438295027","html_url":"https://github.com/spinnaker/spinnaker/issues/2659#issuecomment-438295027","issue_url":"https://api.github.com/repos/spinnaker/spinnaker/issues/2659","id":438295027,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODI5NTAyNw==","user":{"login":"spinnakerbot","id":39309875,"node_id":"MDQ6VXNlcjM5MzA5ODc1","avatar_url":"https://avatars2.githubusercontent.com/u/39309875?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnakerbot","html_url":"https://github.com/spinnakerbot","followers_url":"https://api.github.com/users/spinnakerbot/followers","following_url":"https://api.github.com/users/spinnakerbot/following{/other_user}","gists_url":"https://api.github.com/users/spinnakerbot/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnakerbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnakerbot/subscriptions","organizations_url":"https://api.github.com/users/spinnakerbot/orgs","repos_url":"https://api.github.com/users/spinnakerbot/repos","events_url":"https://api.github.com/users/spinnakerbot/events{/privacy}","received_events_url":"https://api.github.com/users/spinnakerbot/received_events","type":"User","site_admin":false},"created_at":"2018-11-13T14:56:46Z","updated_at":"2018-11-13T14:56:46Z","author_association":"NONE","body":"This issue is tagged as 'to-be-closed' and hasn't been updated  in 45 days, so we are closing it. You can always reopen this issue if needed."}}
{"actor":{"display_login":"spinnakerbot"}}