{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/verify-hub/pulls/comments/220206845","pull_request_review_id":158560166,"id":220206845,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDIwNjg0NQ==","diff_hunk":"@@ -73,7 +74,6 @@ protected void configure() {\n         bind(new TypeLiteral<ConfigEntityDataRepository<CountriesConfigEntityData>>(){}).asEagerSingleton();\n         bind(new TypeLiteral<ConfigEntityDataRepository<MatchingServiceConfigEntityData>>(){}).asEagerSingleton();\n         bind(new TypeLiteral<ConfigEntityDataRepository<IdentityProviderConfigEntityData>>(){}).asEagerSingleton();\n-        bind(ObjectMapper.class).toInstance(new ObjectMapper().registerModule(new GuavaModule()));","path":"hub/config/src/main/java/uk/gov/ida/hub/config/ConfigModule.java","position":26,"original_position":26,"commit_id":"2c8209889d7a93002a220e77e60833a28a32ec1e","original_commit_id":"2c8209889d7a93002a220e77e60833a28a32ec1e","user":{"login":"adityapahuja","id":19972046,"node_id":"MDQ6VXNlcjE5OTcyMDQ2","avatar_url":"https://avatars2.githubusercontent.com/u/19972046?v=4","gravatar_id":"","url":"https://api.github.com/users/adityapahuja","html_url":"https://github.com/adityapahuja","followers_url":"https://api.github.com/users/adityapahuja/followers","following_url":"https://api.github.com/users/adityapahuja/following{/other_user}","gists_url":"https://api.github.com/users/adityapahuja/gists{/gist_id}","starred_url":"https://api.github.com/users/adityapahuja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityapahuja/subscriptions","organizations_url":"https://api.github.com/users/adityapahuja/orgs","repos_url":"https://api.github.com/users/adityapahuja/repos","events_url":"https://api.github.com/users/adityapahuja/events{/privacy}","received_events_url":"https://api.github.com/users/adityapahuja/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2018-09-25T14:06:12Z","updated_at":"2018-09-25T14:06:12Z","html_url":"https://github.com/alphagov/verify-hub/pull/145#discussion_r220206845","pull_request_url":"https://api.github.com/repos/alphagov/verify-hub/pulls/145","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/verify-hub/pulls/comments/220206845"},"html":{"href":"https://github.com/alphagov/verify-hub/pull/145#discussion_r220206845"},"pull_request":{"href":"https://api.github.com/repos/alphagov/verify-hub/pulls/145"}},"in_reply_to_id":219814504},"pull_request":{"url":"https://api.github.com/repos/alphagov/verify-hub/pulls/145","id":216300464,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MzAwNDY0","html_url":"https://github.com/alphagov/verify-hub/pull/145","diff_url":"https://github.com/alphagov/verify-hub/pull/145.diff","patch_url":"https://github.com/alphagov/verify-hub/pull/145.patch","issue_url":"https://api.github.com/repos/alphagov/verify-hub/issues/145","number":145,"state":"open","locked":false,"title":"BAU: Update to use ObjectMapper provided by DropWizard","user":{"login":"adityapahuja","id":19972046,"node_id":"MDQ6VXNlcjE5OTcyMDQ2","avatar_url":"https://avatars2.githubusercontent.com/u/19972046?v=4","gravatar_id":"","url":"https://api.github.com/users/adityapahuja","html_url":"https://github.com/adityapahuja","followers_url":"https://api.github.com/users/adityapahuja/followers","following_url":"https://api.github.com/users/adityapahuja/following{/other_user}","gists_url":"https://api.github.com/users/adityapahuja/gists{/gist_id}","starred_url":"https://api.github.com/users/adityapahuja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityapahuja/subscriptions","organizations_url":"https://api.github.com/users/adityapahuja/orgs","repos_url":"https://api.github.com/users/adityapahuja/repos","events_url":"https://api.github.com/users/adityapahuja/events{/privacy}","received_events_url":"https://api.github.com/users/adityapahuja/received_events","type":"User","site_admin":false},"body":"Modules classes create a new instance of ObjectMapper that is not same as the instance of ObjectMapper provided by DropWizard. This results in logging timestamp not following the ISO8601DateFormat. The fix is to get Modules classes to use the existing ObjectMapper provided by the DropWizard instead of a new instance of ObjectMapper. This will allow applications to log timestamp in the ISO8601DateFormat.\r\n\r\nI ran pre-commit and hub acceptance test. They passed.\r\n\r\nAuthors: @adityapahuja","created_at":"2018-09-18T13:05:43Z","updated_at":"2018-09-25T14:06:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fa57a0f045d0226fbef770c77e8065c0752f0c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/verify-hub/pulls/145/commits","review_comments_url":"https://api.github.com/repos/alphagov/verify-hub/pulls/145/comments","review_comment_url":"https://api.github.com/repos/alphagov/verify-hub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/verify-hub/issues/145/comments","statuses_url":"https://api.github.com/repos/alphagov/verify-hub/statuses/2c8209889d7a93002a220e77e60833a28a32ec1e","head":{"label":"alphagov:bau-use-object-mapper-provided-by-dropwizard","ref":"bau-use-object-mapper-provided-by-dropwizard","sha":"2c8209889d7a93002a220e77e60833a28a32ec1e","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":113597154,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM1OTcxNTQ=","name":"verify-hub","full_name":"alphagov/verify-hub","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/verify-hub","description":"Verify Hub Microservices","fork":false,"url":"https://api.github.com/repos/alphagov/verify-hub","forks_url":"https://api.github.com/repos/alphagov/verify-hub/forks","keys_url":"https://api.github.com/repos/alphagov/verify-hub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/verify-hub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/verify-hub/teams","hooks_url":"https://api.github.com/repos/alphagov/verify-hub/hooks","issue_events_url":"https://api.github.com/repos/alphagov/verify-hub/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/verify-hub/events","assignees_url":"https://api.github.com/repos/alphagov/verify-hub/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/verify-hub/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/verify-hub/tags","blobs_url":"https://api.github.com/repos/alphagov/verify-hub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/verify-hub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/verify-hub/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/verify-hub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/verify-hub/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/verify-hub/languages","stargazers_url":"https://api.github.com/repos/alphagov/verify-hub/stargazers","contributors_url":"https://api.github.com/repos/alphagov/verify-hub/contributors","subscribers_url":"https://api.github.com/repos/alphagov/verify-hub/subscribers","subscription_url":"https://api.github.com/repos/alphagov/verify-hub/subscription","commits_url":"https://api.github.com/repos/alphagov/verify-hub/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/verify-hub/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/verify-hub/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/verify-hub/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/verify-hub/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/verify-hub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/verify-hub/merges","archive_url":"https://api.github.com/repos/alphagov/verify-hub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/verify-hub/downloads","issues_url":"https://api.github.com/repos/alphagov/verify-hub/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/verify-hub/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/verify-hub/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/verify-hub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/verify-hub/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/verify-hub/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/verify-hub/deployments","created_at":"2017-12-08T16:53:55Z","updated_at":"2018-09-25T12:57:56Z","pushed_at":"2018-09-25T13:53:52Z","git_url":"git://github.com/alphagov/verify-hub.git","ssh_url":"git@github.com:alphagov/verify-hub.git","clone_url":"https://github.com/alphagov/verify-hub.git","svn_url":"https://github.com/alphagov/verify-hub","homepage":"","size":2173,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"13e3d1e30e89337f12a905fcd410fd1cc734b57e","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":113597154,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM1OTcxNTQ=","name":"verify-hub","full_name":"alphagov/verify-hub","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/verify-hub","description":"Verify Hub Microservices","fork":false,"url":"https://api.github.com/repos/alphagov/verify-hub","forks_url":"https://api.github.com/repos/alphagov/verify-hub/forks","keys_url":"https://api.github.com/repos/alphagov/verify-hub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/verify-hub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/verify-hub/teams","hooks_url":"https://api.github.com/repos/alphagov/verify-hub/hooks","issue_events_url":"https://api.github.com/repos/alphagov/verify-hub/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/verify-hub/events","assignees_url":"https://api.github.com/repos/alphagov/verify-hub/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/verify-hub/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/verify-hub/tags","blobs_url":"https://api.github.com/repos/alphagov/verify-hub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/verify-hub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/verify-hub/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/verify-hub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/verify-hub/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/verify-hub/languages","stargazers_url":"https://api.github.com/repos/alphagov/verify-hub/stargazers","contributors_url":"https://api.github.com/repos/alphagov/verify-hub/contributors","subscribers_url":"https://api.github.com/repos/alphagov/verify-hub/subscribers","subscription_url":"https://api.github.com/repos/alphagov/verify-hub/subscription","commits_url":"https://api.github.com/repos/alphagov/verify-hub/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/verify-hub/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/verify-hub/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/verify-hub/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/verify-hub/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/verify-hub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/verify-hub/merges","archive_url":"https://api.github.com/repos/alphagov/verify-hub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/verify-hub/downloads","issues_url":"https://api.github.com/repos/alphagov/verify-hub/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/verify-hub/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/verify-hub/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/verify-hub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/verify-hub/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/verify-hub/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/verify-hub/deployments","created_at":"2017-12-08T16:53:55Z","updated_at":"2018-09-25T12:57:56Z","pushed_at":"2018-09-25T13:53:52Z","git_url":"git://github.com/alphagov/verify-hub.git","ssh_url":"git@github.com:alphagov/verify-hub.git","clone_url":"https://github.com/alphagov/verify-hub.git","svn_url":"https://github.com/alphagov/verify-hub","homepage":"","size":2173,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/verify-hub/pulls/145"},"html":{"href":"https://github.com/alphagov/verify-hub/pull/145"},"issue":{"href":"https://api.github.com/repos/alphagov/verify-hub/issues/145"},"comments":{"href":"https://api.github.com/repos/alphagov/verify-hub/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/verify-hub/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/verify-hub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/verify-hub/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/verify-hub/statuses/2c8209889d7a93002a220e77e60833a28a32ec1e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"adityapahuja"}}