{"action":"closed","issue":{"url":"https://api.github.com/repos/tidyverse/readr/issues/637","repository_url":"https://api.github.com/repos/tidyverse/readr","labels_url":"https://api.github.com/repos/tidyverse/readr/issues/637/labels{/name}","comments_url":"https://api.github.com/repos/tidyverse/readr/issues/637/comments","events_url":"https://api.github.com/repos/tidyverse/readr/issues/637/events","html_url":"https://github.com/tidyverse/readr/issues/637","id":214499115,"node_id":"MDU6SXNzdWUyMTQ0OTkxMTU=","number":637,"title":"accept PRs to enhance read_fwf to deal with decimal places and overlaping  columns","user":{"login":"lucasmation","id":1426312,"node_id":"MDQ6VXNlcjE0MjYzMTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1426312?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasmation","html_url":"https://github.com/lucasmation","followers_url":"https://api.github.com/users/lucasmation/followers","following_url":"https://api.github.com/users/lucasmation/following{/other_user}","gists_url":"https://api.github.com/users/lucasmation/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasmation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasmation/subscriptions","organizations_url":"https://api.github.com/users/lucasmation/orgs","repos_url":"https://api.github.com/users/lucasmation/repos","events_url":"https://api.github.com/users/lucasmation/events{/privacy}","received_events_url":"https://api.github.com/users/lucasmation/received_events","type":"User","site_admin":false},"labels":[{"id":49349397,"node_id":"MDU6TGFiZWw0OTM0OTM5Nw==","url":"https://api.github.com/repos/tidyverse/readr/labels/feature","name":"feature","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-03-15T19:24:09Z","updated_at":"2018-11-16T15:43:56Z","closed_at":"2018-11-16T15:43:56Z","author_association":"NONE","body":"as requested, following up on #534 in a new issue\r\n\r\n@hadley,\r\nwe have been working on PRs to fix the two limitations of read_fwf\r\n\r\nCan't deal with decimal places (issue #399). Proposed solution: add a new argument decimal_positions to fwf_positions, modifying the main read_fwf function (pull request #632, implemented in Rcpp, tks to @gutorc92)\r\n\r\nCan't deal with overlapping columns (current issue). Proposed solution: parse the import dictionary into a list of dictionaries with no overlapping variables. Then import the data based on each dictionary and cbind the results (pull request #634, implemented in R, tks to @daniellima123). We implemented this as a separate function read_fwf2 (in the same spirit of how read.cvs2 is related to read.cvs), to avoid recursive calls. We could make the changes directly to read_fwf, defining it recursively. What do you think?\r\n\r\nPlease let us know if these suggestions are acceptable. We have been using them in our forked repos and they seem to work fine."}}
{"actor":{"display_login":"jimhester"}}