{"action":"opened","issue":{"url":"https://api.github.com/repos/rust-num/num-complex/issues/21","repository_url":"https://api.github.com/repos/rust-num/num-complex","labels_url":"https://api.github.com/repos/rust-num/num-complex/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/rust-num/num-complex/issues/21/comments","events_url":"https://api.github.com/repos/rust-num/num-complex/issues/21/events","html_url":"https://github.com/rust-num/num-complex/issues/21","id":312390490,"number":21,"title":"type alias","user":{"login":"JohnBSmith","id":16754229,"avatar_url":"https://avatars3.githubusercontent.com/u/16754229?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnBSmith","html_url":"https://github.com/JohnBSmith","followers_url":"https://api.github.com/users/JohnBSmith/followers","following_url":"https://api.github.com/users/JohnBSmith/following{/other_user}","gists_url":"https://api.github.com/users/JohnBSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnBSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnBSmith/subscriptions","organizations_url":"https://api.github.com/users/JohnBSmith/orgs","repos_url":"https://api.github.com/users/JohnBSmith/repos","events_url":"https://api.github.com/users/JohnBSmith/events{/privacy}","received_events_url":"https://api.github.com/users/JohnBSmith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-09T04:36:23Z","updated_at":"2018-04-09T04:36:23Z","closed_at":null,"author_association":"NONE","body":"\r\nConsider to remove:\r\n```rust\r\npub type Complex32 = Complex<f32>;\r\npub type Complex64 = Complex<f64>;\r\n```\r\nin favor of:\r\n```rust\r\n#[allow(non_camel_case_types)]\r\npub type c32 = Complex<f32>;\r\n\r\n#[allow(non_camel_case_types)]\r\npub type c64 = Complex<f64>;\r\n```\r\nIt might seem controversial, but:\r\n* from import one can already see: this is about complex numbers,\r\n* perfectly fits in the scheme `u64 i64 f64 c64`,\r\n* to me it feels more ergonomic,\r\n* `c64::new(1.0,2.0)` is a already a pain compared to `1+2i`,\r\n* stuff will actually fit into the 80 columns limit.\r\n\r\nAnother reason is that rustc could start to lint against\r\n```rust\r\nuse num::complex::Complex64 as c64;\r\n```\r\nbecause of a non camel case type. It would be an ergonomic disaster if one needs to turn that off explicitly. "}}
{"actor":{"display_login":"JohnBSmith"}}