{"action":"opened","number":19259,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/19259","id":231740634,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzQwNjM0","html_url":"https://github.com/magento/magento2/pull/19259","diff_url":"https://github.com/magento/magento2/pull/19259.diff","patch_url":"https://github.com/magento/magento2/pull/19259.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/19259","number":19259,"state":"open","locked":false,"title":"do not force toolbar to be child of product list block (fixes #7253)","user":{"login":"fritzmg","id":4970961,"node_id":"MDQ6VXNlcjQ5NzA5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4970961?v=4","gravatar_id":"","url":"https://api.github.com/users/fritzmg","html_url":"https://github.com/fritzmg","followers_url":"https://api.github.com/users/fritzmg/followers","following_url":"https://api.github.com/users/fritzmg/following{/other_user}","gists_url":"https://api.github.com/users/fritzmg/gists{/gist_id}","starred_url":"https://api.github.com/users/fritzmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fritzmg/subscriptions","organizations_url":"https://api.github.com/users/fritzmg/orgs","repos_url":"https://api.github.com/users/fritzmg/repos","events_url":"https://api.github.com/users/fritzmg/events{/privacy}","received_events_url":"https://api.github.com/users/fritzmg/received_events","type":"User","site_admin":false},"body":"### Description (*)\r\nThis should finally fix #7253. The current implementation forces the toolbar block (when defined via `setToolbarBlockName`) to __always__ be a child block of the product list block, even though there is no reason for it anymore. My guess is those lines of code were simply overlooked in the last attempt to fix the toolbar/product list relationship.\r\n\r\nThis PR simply removes the `setChild` call and instead uses\r\n```php\r\n$this->getToolbarBlock()->toHtml();\r\n```\r\nwithin `getToolbarHtml` instead of the old `$this->getChildHtml('toolbar');`.\r\n\r\n### Fixed Issues (if relevant)\r\nmagento/magento2/#7253: I cannot move the block\r\n\r\n### Manual testing scenarios (*)\r\nSimply create a `catalog_category_view.xml` with the following content for example:\r\n```xml\r\n<?xml version=\"1.0\"?>\r\n<page xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" layout=\"3columns\" xsi:noNamespaceSchemaLocation=\"urn:magento:framework:View/Layout/etc/page_configuration.xsd\">\r\n    <body>\r\n        <move element=\"product_list_toolbar\" destination=\"content\" />\r\n    </body>\r\n</page>\r\n```\r\nThis will successfully move the toolbar into the \"content\" container.\r\n\r\n### Contribution checklist (*)\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2018-11-17T17:40:09Z","updated_at":"2018-11-17T17:40:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/19259/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/19259/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/19259/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/32a5ef48e9db58985cf4b0a38997f2853b5dc458","head":{"label":"fritzmg:patch-1","ref":"patch-1","sha":"32a5ef48e9db58985cf4b0a38997f2853b5dc458","user":{"login":"fritzmg","id":4970961,"node_id":"MDQ6VXNlcjQ5NzA5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4970961?v=4","gravatar_id":"","url":"https://api.github.com/users/fritzmg","html_url":"https://github.com/fritzmg","followers_url":"https://api.github.com/users/fritzmg/followers","following_url":"https://api.github.com/users/fritzmg/following{/other_user}","gists_url":"https://api.github.com/users/fritzmg/gists{/gist_id}","starred_url":"https://api.github.com/users/fritzmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fritzmg/subscriptions","organizations_url":"https://api.github.com/users/fritzmg/orgs","repos_url":"https://api.github.com/users/fritzmg/repos","events_url":"https://api.github.com/users/fritzmg/events{/privacy}","received_events_url":"https://api.github.com/users/fritzmg/received_events","type":"User","site_admin":false},"repo":{"id":158008101,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgwMDgxMDE=","name":"magento2","full_name":"fritzmg/magento2","private":false,"owner":{"login":"fritzmg","id":4970961,"node_id":"MDQ6VXNlcjQ5NzA5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4970961?v=4","gravatar_id":"","url":"https://api.github.com/users/fritzmg","html_url":"https://github.com/fritzmg","followers_url":"https://api.github.com/users/fritzmg/followers","following_url":"https://api.github.com/users/fritzmg/following{/other_user}","gists_url":"https://api.github.com/users/fritzmg/gists{/gist_id}","starred_url":"https://api.github.com/users/fritzmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fritzmg/subscriptions","organizations_url":"https://api.github.com/users/fritzmg/orgs","repos_url":"https://api.github.com/users/fritzmg/repos","events_url":"https://api.github.com/users/fritzmg/events{/privacy}","received_events_url":"https://api.github.com/users/fritzmg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fritzmg/magento2","description":"All Submissions you make to Magento Inc. (\"Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/fritzmg/magento2","forks_url":"https://api.github.com/repos/fritzmg/magento2/forks","keys_url":"https://api.github.com/repos/fritzmg/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fritzmg/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fritzmg/magento2/teams","hooks_url":"https://api.github.com/repos/fritzmg/magento2/hooks","issue_events_url":"https://api.github.com/repos/fritzmg/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/fritzmg/magento2/events","assignees_url":"https://api.github.com/repos/fritzmg/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/fritzmg/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/fritzmg/magento2/tags","blobs_url":"https://api.github.com/repos/fritzmg/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fritzmg/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fritzmg/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/fritzmg/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fritzmg/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/fritzmg/magento2/languages","stargazers_url":"https://api.github.com/repos/fritzmg/magento2/stargazers","contributors_url":"https://api.github.com/repos/fritzmg/magento2/contributors","subscribers_url":"https://api.github.com/repos/fritzmg/magento2/subscribers","subscription_url":"https://api.github.com/repos/fritzmg/magento2/subscription","commits_url":"https://api.github.com/repos/fritzmg/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/fritzmg/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/fritzmg/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/fritzmg/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/fritzmg/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/fritzmg/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fritzmg/magento2/merges","archive_url":"https://api.github.com/repos/fritzmg/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fritzmg/magento2/downloads","issues_url":"https://api.github.com/repos/fritzmg/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/fritzmg/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/fritzmg/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/fritzmg/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fritzmg/magento2/labels{/name}","releases_url":"https://api.github.com/repos/fritzmg/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/fritzmg/magento2/deployments","created_at":"2018-11-17T17:28:00Z","updated_at":"2018-11-17T17:29:12Z","pushed_at":"2018-11-17T17:32:43Z","git_url":"git://github.com/fritzmg/magento2.git","ssh_url":"git@github.com:fritzmg/magento2.git","clone_url":"https://github.com/fritzmg/magento2.git","svn_url":"https://github.com/fritzmg/magento2","homepage":"http://www.magento.com","size":492095,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3-develop"}},"base":{"label":"magento:2.2-develop","ref":"2.2-develop","sha":"d14510fe428a7915b83ea14cf2c0fe15d98b0323","user":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"node_id":"MDEwOlJlcG9zaXRvcnkyODg0MTEx","name":"magento2","full_name":"magento/magento2","private":false,"owner":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (\"Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2018-11-17T17:03:29Z","pushed_at":"2018-11-17T04:35:06Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":492095,"stargazers_count":6369,"watchers_count":6369,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5548,"mirror_url":null,"archived":false,"open_issues_count":1346,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5548,"open_issues":1346,"watchers":6369,"default_branch":"2.3-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/19259"},"html":{"href":"https://github.com/magento/magento2/pull/19259"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/19259"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/19259/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/19259/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/19259/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/32a5ef48e9db58985cf4b0a38997f2853b5dc458"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"fritzmg"}}