{"action":"created","comment":{"url":"https://api.github.com/repos/dssg/triage/pulls/comments/165779879","pull_request_review_id":93779572,"id":165779879,"diff_hunk":"@@ -154,7 +154,7 @@ def _save_feature_importances(self, model_id, feature_importances, feature_names\n                 model_id=model_id,\n                 feature_importance=0,\n                 feature='Algorithm does not support a standard way' +\n-                        'to calculate feature importance.',\n+                        ' to calculate feature importance.',","path":"src/triage/component/catwalk/model_trainers.py","position":5,"original_position":5,"commit_id":"4f5030f59b15e5735a21e0a315bd9c83f30289b7","original_commit_id":"4f5030f59b15e5735a21e0a315bd9c83f30289b7","user":{"login":"thcrock","id":1649545,"avatar_url":"https://avatars2.githubusercontent.com/u/1649545?v=4","gravatar_id":"","url":"https://api.github.com/users/thcrock","html_url":"https://github.com/thcrock","followers_url":"https://api.github.com/users/thcrock/followers","following_url":"https://api.github.com/users/thcrock/following{/other_user}","gists_url":"https://api.github.com/users/thcrock/gists{/gist_id}","starred_url":"https://api.github.com/users/thcrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thcrock/subscriptions","organizations_url":"https://api.github.com/users/thcrock/orgs","repos_url":"https://api.github.com/users/thcrock/repos","events_url":"https://api.github.com/users/thcrock/events{/privacy}","received_events_url":"https://api.github.com/users/thcrock/received_events","type":"User","site_admin":false},"body":"We should probably define this as a constant in one of the files and import it from the other. It would be way too easy for somebody to come in and reformat this line or add a word and break the other check.","created_at":"2018-02-02T22:43:48Z","updated_at":"2018-02-02T22:44:53Z","html_url":"https://github.com/dssg/triage/pull/379#discussion_r165779879","pull_request_url":"https://api.github.com/repos/dssg/triage/pulls/379","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dssg/triage/pulls/comments/165779879"},"html":{"href":"https://github.com/dssg/triage/pull/379#discussion_r165779879"},"pull_request":{"href":"https://api.github.com/repos/dssg/triage/pulls/379"}}},"pull_request":{"url":"https://api.github.com/repos/dssg/triage/pulls/379","id":166881040,"html_url":"https://github.com/dssg/triage/pull/379","diff_url":"https://github.com/dssg/triage/pull/379.diff","patch_url":"https://github.com/dssg/triage/pull/379.patch","issue_url":"https://api.github.com/repos/dssg/triage/issues/379","number":379,"state":"open","locked":false,"title":"inserting NULLs for individual feature importance - #361","user":{"login":"hakoenig","id":21229015,"avatar_url":"https://avatars2.githubusercontent.com/u/21229015?v=4","gravatar_id":"","url":"https://api.github.com/users/hakoenig","html_url":"https://github.com/hakoenig","followers_url":"https://api.github.com/users/hakoenig/followers","following_url":"https://api.github.com/users/hakoenig/following{/other_user}","gists_url":"https://api.github.com/users/hakoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/hakoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakoenig/subscriptions","organizations_url":"https://api.github.com/users/hakoenig/orgs","repos_url":"https://api.github.com/users/hakoenig/repos","events_url":"https://api.github.com/users/hakoenig/events{/privacy}","received_events_url":"https://api.github.com/users/hakoenig/received_events","type":"User","site_admin":false},"body":"Some classifiers do not support feature importance. For them, we write \r\n`Algorithm does not support a standard way to calculate feature importance.` into results.feature_importance as feature_name. This leads to problems when trying to write individual feature importance because the feature does not exist in the matrix. This PR checks for the fake feature name and sets the individual importances to Nulls. ","created_at":"2018-02-02T19:13:06Z","updated_at":"2018-02-02T22:44:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6dbe9cc9577c2f43aed00051d76032fd8df84f2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nanounanue","id":494528,"avatar_url":"https://avatars1.githubusercontent.com/u/494528?v=4","gravatar_id":"","url":"https://api.github.com/users/nanounanue","html_url":"https://github.com/nanounanue","followers_url":"https://api.github.com/users/nanounanue/followers","following_url":"https://api.github.com/users/nanounanue/following{/other_user}","gists_url":"https://api.github.com/users/nanounanue/gists{/gist_id}","starred_url":"https://api.github.com/users/nanounanue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanounanue/subscriptions","organizations_url":"https://api.github.com/users/nanounanue/orgs","repos_url":"https://api.github.com/users/nanounanue/repos","events_url":"https://api.github.com/users/nanounanue/events{/privacy}","received_events_url":"https://api.github.com/users/nanounanue/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/dssg/triage/pulls/379/commits","review_comments_url":"https://api.github.com/repos/dssg/triage/pulls/379/comments","review_comment_url":"https://api.github.com/repos/dssg/triage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dssg/triage/issues/379/comments","statuses_url":"https://api.github.com/repos/dssg/triage/statuses/4f5030f59b15e5735a21e0a315bd9c83f30289b7","head":{"label":"dssg:individual_feature_importance","ref":"individual_feature_importance","sha":"4f5030f59b15e5735a21e0a315bd9c83f30289b7","user":{"login":"dssg","id":3827384,"avatar_url":"https://avatars1.githubusercontent.com/u/3827384?v=4","gravatar_id":"","url":"https://api.github.com/users/dssg","html_url":"https://github.com/dssg","followers_url":"https://api.github.com/users/dssg/followers","following_url":"https://api.github.com/users/dssg/following{/other_user}","gists_url":"https://api.github.com/users/dssg/gists{/gist_id}","starred_url":"https://api.github.com/users/dssg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dssg/subscriptions","organizations_url":"https://api.github.com/users/dssg/orgs","repos_url":"https://api.github.com/users/dssg/repos","events_url":"https://api.github.com/users/dssg/events{/privacy}","received_events_url":"https://api.github.com/users/dssg/received_events","type":"Organization","site_admin":false},"repo":{"id":71394134,"name":"triage","full_name":"dssg/triage","owner":{"login":"dssg","id":3827384,"avatar_url":"https://avatars1.githubusercontent.com/u/3827384?v=4","gravatar_id":"","url":"https://api.github.com/users/dssg","html_url":"https://github.com/dssg","followers_url":"https://api.github.com/users/dssg/followers","following_url":"https://api.github.com/users/dssg/following{/other_user}","gists_url":"https://api.github.com/users/dssg/gists{/gist_id}","starred_url":"https://api.github.com/users/dssg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dssg/subscriptions","organizations_url":"https://api.github.com/users/dssg/orgs","repos_url":"https://api.github.com/users/dssg/repos","events_url":"https://api.github.com/users/dssg/events{/privacy}","received_events_url":"https://api.github.com/users/dssg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dssg/triage","description":"Risk modeling and prediction","fork":false,"url":"https://api.github.com/repos/dssg/triage","forks_url":"https://api.github.com/repos/dssg/triage/forks","keys_url":"https://api.github.com/repos/dssg/triage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dssg/triage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dssg/triage/teams","hooks_url":"https://api.github.com/repos/dssg/triage/hooks","issue_events_url":"https://api.github.com/repos/dssg/triage/issues/events{/number}","events_url":"https://api.github.com/repos/dssg/triage/events","assignees_url":"https://api.github.com/repos/dssg/triage/assignees{/user}","branches_url":"https://api.github.com/repos/dssg/triage/branches{/branch}","tags_url":"https://api.github.com/repos/dssg/triage/tags","blobs_url":"https://api.github.com/repos/dssg/triage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dssg/triage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dssg/triage/git/refs{/sha}","trees_url":"https://api.github.com/repos/dssg/triage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dssg/triage/statuses/{sha}","languages_url":"https://api.github.com/repos/dssg/triage/languages","stargazers_url":"https://api.github.com/repos/dssg/triage/stargazers","contributors_url":"https://api.github.com/repos/dssg/triage/contributors","subscribers_url":"https://api.github.com/repos/dssg/triage/subscribers","subscription_url":"https://api.github.com/repos/dssg/triage/subscription","commits_url":"https://api.github.com/repos/dssg/triage/commits{/sha}","git_commits_url":"https://api.github.com/repos/dssg/triage/git/commits{/sha}","comments_url":"https://api.github.com/repos/dssg/triage/comments{/number}","issue_comment_url":"https://api.github.com/repos/dssg/triage/issues/comments{/number}","contents_url":"https://api.github.com/repos/dssg/triage/contents/{+path}","compare_url":"https://api.github.com/repos/dssg/triage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dssg/triage/merges","archive_url":"https://api.github.com/repos/dssg/triage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dssg/triage/downloads","issues_url":"https://api.github.com/repos/dssg/triage/issues{/number}","pulls_url":"https://api.github.com/repos/dssg/triage/pulls{/number}","milestones_url":"https://api.github.com/repos/dssg/triage/milestones{/number}","notifications_url":"https://api.github.com/repos/dssg/triage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dssg/triage/labels{/name}","releases_url":"https://api.github.com/repos/dssg/triage/releases{/id}","deployments_url":"https://api.github.com/repos/dssg/triage/deployments","created_at":"2016-10-19T19:55:46Z","updated_at":"2018-02-01T22:31:40Z","pushed_at":"2018-02-02T19:13:07Z","git_url":"git://github.com/dssg/triage.git","ssh_url":"git@github.com:dssg/triage.git","clone_url":"https://github.com/dssg/triage.git","svn_url":"https://github.com/dssg/triage","homepage":null,"size":2417,"stargazers_count":5,"watchers_count":5,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":132,"watchers":5,"default_branch":"master"}},"base":{"label":"dssg:master","ref":"master","sha":"7bfaf85be9448635e5ff7a0b4ab054640f102eaf","user":{"login":"dssg","id":3827384,"avatar_url":"https://avatars1.githubusercontent.com/u/3827384?v=4","gravatar_id":"","url":"https://api.github.com/users/dssg","html_url":"https://github.com/dssg","followers_url":"https://api.github.com/users/dssg/followers","following_url":"https://api.github.com/users/dssg/following{/other_user}","gists_url":"https://api.github.com/users/dssg/gists{/gist_id}","starred_url":"https://api.github.com/users/dssg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dssg/subscriptions","organizations_url":"https://api.github.com/users/dssg/orgs","repos_url":"https://api.github.com/users/dssg/repos","events_url":"https://api.github.com/users/dssg/events{/privacy}","received_events_url":"https://api.github.com/users/dssg/received_events","type":"Organization","site_admin":false},"repo":{"id":71394134,"name":"triage","full_name":"dssg/triage","owner":{"login":"dssg","id":3827384,"avatar_url":"https://avatars1.githubusercontent.com/u/3827384?v=4","gravatar_id":"","url":"https://api.github.com/users/dssg","html_url":"https://github.com/dssg","followers_url":"https://api.github.com/users/dssg/followers","following_url":"https://api.github.com/users/dssg/following{/other_user}","gists_url":"https://api.github.com/users/dssg/gists{/gist_id}","starred_url":"https://api.github.com/users/dssg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dssg/subscriptions","organizations_url":"https://api.github.com/users/dssg/orgs","repos_url":"https://api.github.com/users/dssg/repos","events_url":"https://api.github.com/users/dssg/events{/privacy}","received_events_url":"https://api.github.com/users/dssg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dssg/triage","description":"Risk modeling and prediction","fork":false,"url":"https://api.github.com/repos/dssg/triage","forks_url":"https://api.github.com/repos/dssg/triage/forks","keys_url":"https://api.github.com/repos/dssg/triage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dssg/triage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dssg/triage/teams","hooks_url":"https://api.github.com/repos/dssg/triage/hooks","issue_events_url":"https://api.github.com/repos/dssg/triage/issues/events{/number}","events_url":"https://api.github.com/repos/dssg/triage/events","assignees_url":"https://api.github.com/repos/dssg/triage/assignees{/user}","branches_url":"https://api.github.com/repos/dssg/triage/branches{/branch}","tags_url":"https://api.github.com/repos/dssg/triage/tags","blobs_url":"https://api.github.com/repos/dssg/triage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dssg/triage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dssg/triage/git/refs{/sha}","trees_url":"https://api.github.com/repos/dssg/triage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dssg/triage/statuses/{sha}","languages_url":"https://api.github.com/repos/dssg/triage/languages","stargazers_url":"https://api.github.com/repos/dssg/triage/stargazers","contributors_url":"https://api.github.com/repos/dssg/triage/contributors","subscribers_url":"https://api.github.com/repos/dssg/triage/subscribers","subscription_url":"https://api.github.com/repos/dssg/triage/subscription","commits_url":"https://api.github.com/repos/dssg/triage/commits{/sha}","git_commits_url":"https://api.github.com/repos/dssg/triage/git/commits{/sha}","comments_url":"https://api.github.com/repos/dssg/triage/comments{/number}","issue_comment_url":"https://api.github.com/repos/dssg/triage/issues/comments{/number}","contents_url":"https://api.github.com/repos/dssg/triage/contents/{+path}","compare_url":"https://api.github.com/repos/dssg/triage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dssg/triage/merges","archive_url":"https://api.github.com/repos/dssg/triage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dssg/triage/downloads","issues_url":"https://api.github.com/repos/dssg/triage/issues{/number}","pulls_url":"https://api.github.com/repos/dssg/triage/pulls{/number}","milestones_url":"https://api.github.com/repos/dssg/triage/milestones{/number}","notifications_url":"https://api.github.com/repos/dssg/triage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dssg/triage/labels{/name}","releases_url":"https://api.github.com/repos/dssg/triage/releases{/id}","deployments_url":"https://api.github.com/repos/dssg/triage/deployments","created_at":"2016-10-19T19:55:46Z","updated_at":"2018-02-01T22:31:40Z","pushed_at":"2018-02-02T19:13:07Z","git_url":"git://github.com/dssg/triage.git","ssh_url":"git@github.com:dssg/triage.git","clone_url":"https://github.com/dssg/triage.git","svn_url":"https://github.com/dssg/triage","homepage":null,"size":2417,"stargazers_count":5,"watchers_count":5,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":132,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dssg/triage/pulls/379"},"html":{"href":"https://github.com/dssg/triage/pull/379"},"issue":{"href":"https://api.github.com/repos/dssg/triage/issues/379"},"comments":{"href":"https://api.github.com/repos/dssg/triage/issues/379/comments"},"review_comments":{"href":"https://api.github.com/repos/dssg/triage/pulls/379/comments"},"review_comment":{"href":"https://api.github.com/repos/dssg/triage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dssg/triage/pulls/379/commits"},"statuses":{"href":"https://api.github.com/repos/dssg/triage/statuses/4f5030f59b15e5735a21e0a315bd9c83f30289b7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"thcrock"}}