{"action":"created","comment":{"url":"https://api.github.com/repos/jenkins-x/jx/pulls/comments/237436188","pull_request_review_id":179731422,"id":237436188,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzQzNjE4OA==","diff_hunk":"@@ -0,0 +1,102 @@\n+package vault\n+\n+import (\n+\t\"github.com/hashicorp/vault/api\"\n+\t\"github.com/jenkins-x/jx/pkg/util\"\n+\t\"github.com/pkg/errors\"\n+\t\"gopkg.in/yaml.v2\"\n+)\n+\n+type VaultClient interface {\n+\t// Write writes a named secret to the vault\n+\tWrite(secretName string, data map[string]interface{}) (map[string]interface{}, error)\n+\n+\t// WriteObject writes a generic named object to the vault. The secret _must_ be serializable to JSON\n+\tWriteObject(secretName string, secret interface{}) (map[string]interface{}, error)\n+\n+\t// WriteYaml writes a yaml object to a named secret\n+\tWriteYaml(secretName string, yamlstring string) (map[string]interface{}, error)\n+\n+\t// List lists the secrets under the specified path\n+\tList(path string) ([]string, error)\n+\n+\t// Read reads a named secret from the vault\n+\tRead(secretName string) (map[string]interface{}, error)\n+}\n+\n+// VaultClient is a hand wrapper around the official Vault API to save shit in the way we want\n+type VaultClientImpl struct {\n+\tclient *api.Client\n+}\n+\n+// NewVaultClient creates a new Vault Client wrapping the api.client\n+func NewVaultClient(client *api.Client) VaultClient {\n+\treturn &VaultClientImpl{client: client}\n+}\n+\n+// Write writes a named secret to the vault with the data provided. Data can be a generic map of stuff, but at all points\n+// in the map, keys _must_ be strings (not bool, int or even interface{}) otherwise you'll get an error\n+func (v *VaultClientImpl) Write(secretName string, data map[string]interface{}) (map[string]interface{}, error) {\n+\tsecret, err := v.client.Logical().Write(secretPath(secretName), data)\n+\tif secret != nil {\n+\t\treturn secret.Data, err\n+\t}\n+\treturn nil, err\n+}\n+\n+// WriteObject writes a generic named object to the vault. The secret _must_ be serializable to JSON\n+func (v *VaultClientImpl) WriteObject(secretName string, secret interface{}) (map[string]interface{}, error) {\n+\t// Convert the secret into a saveable map[string]interface{} format\n+\tm, err := util.ToMapStringInterfaceFromStruct(&secret)\n+\tif err != nil {\n+\t\treturn nil, errors.Wrapf(err, \"Could not serialize secret '%s' object for saving to vault\", secretName)\n+\t}\n+\treturn v.Write(secretName, m)\n+}\n+\n+// WriteYaml writes a yaml object to a named secret\n+func (v *VaultClientImpl) WriteYaml(secretName string, y string) (map[string]interface{}, error) {\n+\t// Unmarshal to a generic map\n+\tm := make(map[string]interface{})\n+\terr := yaml.Unmarshal([]byte(y), &m)\n+\tif err != nil {\n+\t\treturn nil, errors.Wrapf(err, \"Could not unmarshal YAML %v\", y)\n+\t}\n+\n+\t// We can't just call v.client.save on this. Although it is a map[string]interface{}, a sub-item in the may _may_\n+\t// be a map[interface{}]interface rather than map[string]interface{}. This will cause the vault Write action to fail\n+\t// Instead we need to marshall to a struct and back\n+\tout := util.ConvertAllMapKeysToString(m)\n+\treturn v.Write(secretName, out.(map[string]interface{}))\n+}\n+\n+func (v *VaultClientImpl) List(path string) ([]string, error) {","path":"pkg/vault/vault_client.go","position":73,"original_position":73,"commit_id":"c920974dc26967dc0b6da4da7b215b5388fd5a42","original_commit_id":"c920974dc26967dc0b6da4da7b215b5388fd5a42","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"exported method VaultClientImpl.List should have comment or be unexported","created_at":"2018-11-29T10:48:46Z","updated_at":"2018-11-29T10:48:48Z","html_url":"https://github.com/jenkins-x/jx/pull/2363#discussion_r237436188","pull_request_url":"https://api.github.com/repos/jenkins-x/jx/pulls/2363","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jenkins-x/jx/pulls/comments/237436188"},"html":{"href":"https://github.com/jenkins-x/jx/pull/2363#discussion_r237436188"},"pull_request":{"href":"https://api.github.com/repos/jenkins-x/jx/pulls/2363"}}},"pull_request":{"url":"https://api.github.com/repos/jenkins-x/jx/pulls/2363","id":234589907,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NTg5OTA3","html_url":"https://github.com/jenkins-x/jx/pull/2363","diff_url":"https://github.com/jenkins-x/jx/pull/2363.diff","patch_url":"https://github.com/jenkins-x/jx/pull/2363.patch","issue_url":"https://api.github.com/repos/jenkins-x/jx/issues/2363","number":2363,"state":"open","locked":false,"title":"Vault install secrets yaml","user":{"login":"agentgonzo","id":1652511,"node_id":"MDQ6VXNlcjE2NTI1MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1652511?v=4","gravatar_id":"","url":"https://api.github.com/users/agentgonzo","html_url":"https://github.com/agentgonzo","followers_url":"https://api.github.com/users/agentgonzo/followers","following_url":"https://api.github.com/users/agentgonzo/following{/other_user}","gists_url":"https://api.github.com/users/agentgonzo/gists{/gist_id}","starred_url":"https://api.github.com/users/agentgonzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentgonzo/subscriptions","organizations_url":"https://api.github.com/users/agentgonzo/orgs","repos_url":"https://api.github.com/users/agentgonzo/repos","events_url":"https://api.github.com/users/agentgonzo/events{/privacy}","received_events_url":"https://api.github.com/users/agentgonzo/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first PR, read our contributor guidelines https://jenkins-x.io/contribute/\r\n2. Follow these instructions to write commit messages http://karma-runner.github.io/3.0/dev/git-commit-msg.html\r\n3. Follow these instructions to write tests https://jenkins-x.io/contribute/development/#testing\r\n4. You can trigger the tests for your PR with /test bdd\r\n5. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n#### Submitter checklist\r\n\r\n- [ ] Change is code complete and matches issue description.\r\n- [ ] Change is covered by existing or new tests.\r\n\r\n#### Description\r\n\r\n\r\n#### Special notes for the reviewer(s)\r\nSummary of changes:\r\n* Installs the vault cli for the user if not installed already\r\n* Extracted a `VaultClient` interface rather than using `api.Client`\r\n* Secrets created with `--gitops` in the `jenkins-x-dev-enviromnent` will be stored in vault (under `/secrets/install-secrets/`) as separate secrets (which are still yaml)\r\n* When doing `jx step helm apply`, if the `secrets.yaml` file does not exist, it will be populated from the above stored secrets. After helm is applied, it will securely delete the files\r\n* secrets are now (more) securely deleted from the filesystem instead of just unlinking them.\r\n\r\n#### Which issue this PR fixes\r\n\r\nfixes #\r\n\r\n<!--\r\noptional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged\r\n-->\r\n","created_at":"2018-11-29T10:48:32Z","updated_at":"2018-11-29T10:48:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f807b2970d9809aa779c4fefb516ff5baeff124","assignee":{"login":"ccojocar","id":591127,"node_id":"MDQ6VXNlcjU5MTEyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/591127?v=4","gravatar_id":"","url":"https://api.github.com/users/ccojocar","html_url":"https://github.com/ccojocar","followers_url":"https://api.github.com/users/ccojocar/followers","following_url":"https://api.github.com/users/ccojocar/following{/other_user}","gists_url":"https://api.github.com/users/ccojocar/gists{/gist_id}","starred_url":"https://api.github.com/users/ccojocar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccojocar/subscriptions","organizations_url":"https://api.github.com/users/ccojocar/orgs","repos_url":"https://api.github.com/users/ccojocar/repos","events_url":"https://api.github.com/users/ccojocar/events{/privacy}","received_events_url":"https://api.github.com/users/ccojocar/received_events","type":"User","site_admin":false},"assignees":[{"login":"ccojocar","id":591127,"node_id":"MDQ6VXNlcjU5MTEyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/591127?v=4","gravatar_id":"","url":"https://api.github.com/users/ccojocar","html_url":"https://github.com/ccojocar","followers_url":"https://api.github.com/users/ccojocar/followers","following_url":"https://api.github.com/users/ccojocar/following{/other_user}","gists_url":"https://api.github.com/users/ccojocar/gists{/gist_id}","starred_url":"https://api.github.com/users/ccojocar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccojocar/subscriptions","organizations_url":"https://api.github.com/users/ccojocar/orgs","repos_url":"https://api.github.com/users/ccojocar/repos","events_url":"https://api.github.com/users/ccojocar/events{/privacy}","received_events_url":"https://api.github.com/users/ccojocar/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"i0n","id":56937,"node_id":"MDQ6VXNlcjU2OTM3","avatar_url":"https://avatars3.githubusercontent.com/u/56937?v=4","gravatar_id":"","url":"https://api.github.com/users/i0n","html_url":"https://github.com/i0n","followers_url":"https://api.github.com/users/i0n/followers","following_url":"https://api.github.com/users/i0n/following{/other_user}","gists_url":"https://api.github.com/users/i0n/gists{/gist_id}","starred_url":"https://api.github.com/users/i0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i0n/subscriptions","organizations_url":"https://api.github.com/users/i0n/orgs","repos_url":"https://api.github.com/users/i0n/repos","events_url":"https://api.github.com/users/i0n/events{/privacy}","received_events_url":"https://api.github.com/users/i0n/received_events","type":"User","site_admin":false},{"login":"rajdavies","id":174392,"node_id":"MDQ6VXNlcjE3NDM5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/174392?v=4","gravatar_id":"","url":"https://api.github.com/users/rajdavies","html_url":"https://github.com/rajdavies","followers_url":"https://api.github.com/users/rajdavies/followers","following_url":"https://api.github.com/users/rajdavies/following{/other_user}","gists_url":"https://api.github.com/users/rajdavies/gists{/gist_id}","starred_url":"https://api.github.com/users/rajdavies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajdavies/subscriptions","organizations_url":"https://api.github.com/users/rajdavies/orgs","repos_url":"https://api.github.com/users/rajdavies/repos","events_url":"https://api.github.com/users/rajdavies/events{/privacy}","received_events_url":"https://api.github.com/users/rajdavies/received_events","type":"User","site_admin":false},{"login":"ccojocar","id":591127,"node_id":"MDQ6VXNlcjU5MTEyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/591127?v=4","gravatar_id":"","url":"https://api.github.com/users/ccojocar","html_url":"https://github.com/ccojocar","followers_url":"https://api.github.com/users/ccojocar/followers","following_url":"https://api.github.com/users/ccojocar/following{/other_user}","gists_url":"https://api.github.com/users/ccojocar/gists{/gist_id}","starred_url":"https://api.github.com/users/ccojocar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccojocar/subscriptions","organizations_url":"https://api.github.com/users/ccojocar/orgs","repos_url":"https://api.github.com/users/ccojocar/repos","events_url":"https://api.github.com/users/ccojocar/events{/privacy}","received_events_url":"https://api.github.com/users/ccojocar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1031083330,"node_id":"MDU6TGFiZWwxMDMxMDgzMzMw","url":"https://api.github.com/repos/jenkins-x/jx/labels/size/XL","name":"size/XL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jenkins-x/jx/pulls/2363/commits","review_comments_url":"https://api.github.com/repos/jenkins-x/jx/pulls/2363/comments","review_comment_url":"https://api.github.com/repos/jenkins-x/jx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkins-x/jx/issues/2363/comments","statuses_url":"https://api.github.com/repos/jenkins-x/jx/statuses/c920974dc26967dc0b6da4da7b215b5388fd5a42","head":{"label":"agentgonzo:vault-install-secrets-yaml","ref":"vault-install-secrets-yaml","sha":"c920974dc26967dc0b6da4da7b215b5388fd5a42","user":{"login":"agentgonzo","id":1652511,"node_id":"MDQ6VXNlcjE2NTI1MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1652511?v=4","gravatar_id":"","url":"https://api.github.com/users/agentgonzo","html_url":"https://github.com/agentgonzo","followers_url":"https://api.github.com/users/agentgonzo/followers","following_url":"https://api.github.com/users/agentgonzo/following{/other_user}","gists_url":"https://api.github.com/users/agentgonzo/gists{/gist_id}","starred_url":"https://api.github.com/users/agentgonzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentgonzo/subscriptions","organizations_url":"https://api.github.com/users/agentgonzo/orgs","repos_url":"https://api.github.com/users/agentgonzo/repos","events_url":"https://api.github.com/users/agentgonzo/events{/privacy}","received_events_url":"https://api.github.com/users/agentgonzo/received_events","type":"User","site_admin":false},"repo":{"id":154358426,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQzNTg0MjY=","name":"jx","full_name":"agentgonzo/jx","private":false,"owner":{"login":"agentgonzo","id":1652511,"node_id":"MDQ6VXNlcjE2NTI1MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1652511?v=4","gravatar_id":"","url":"https://api.github.com/users/agentgonzo","html_url":"https://github.com/agentgonzo","followers_url":"https://api.github.com/users/agentgonzo/followers","following_url":"https://api.github.com/users/agentgonzo/following{/other_user}","gists_url":"https://api.github.com/users/agentgonzo/gists{/gist_id}","starred_url":"https://api.github.com/users/agentgonzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentgonzo/subscriptions","organizations_url":"https://api.github.com/users/agentgonzo/orgs","repos_url":"https://api.github.com/users/agentgonzo/repos","events_url":"https://api.github.com/users/agentgonzo/events{/privacy}","received_events_url":"https://api.github.com/users/agentgonzo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/agentgonzo/jx","description":"jx is a command line tool for working with Jenkins X: automated CI/CD for Kubernetes","fork":true,"url":"https://api.github.com/repos/agentgonzo/jx","forks_url":"https://api.github.com/repos/agentgonzo/jx/forks","keys_url":"https://api.github.com/repos/agentgonzo/jx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agentgonzo/jx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agentgonzo/jx/teams","hooks_url":"https://api.github.com/repos/agentgonzo/jx/hooks","issue_events_url":"https://api.github.com/repos/agentgonzo/jx/issues/events{/number}","events_url":"https://api.github.com/repos/agentgonzo/jx/events","assignees_url":"https://api.github.com/repos/agentgonzo/jx/assignees{/user}","branches_url":"https://api.github.com/repos/agentgonzo/jx/branches{/branch}","tags_url":"https://api.github.com/repos/agentgonzo/jx/tags","blobs_url":"https://api.github.com/repos/agentgonzo/jx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agentgonzo/jx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agentgonzo/jx/git/refs{/sha}","trees_url":"https://api.github.com/repos/agentgonzo/jx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agentgonzo/jx/statuses/{sha}","languages_url":"https://api.github.com/repos/agentgonzo/jx/languages","stargazers_url":"https://api.github.com/repos/agentgonzo/jx/stargazers","contributors_url":"https://api.github.com/repos/agentgonzo/jx/contributors","subscribers_url":"https://api.github.com/repos/agentgonzo/jx/subscribers","subscription_url":"https://api.github.com/repos/agentgonzo/jx/subscription","commits_url":"https://api.github.com/repos/agentgonzo/jx/commits{/sha}","git_commits_url":"https://api.github.com/repos/agentgonzo/jx/git/commits{/sha}","comments_url":"https://api.github.com/repos/agentgonzo/jx/comments{/number}","issue_comment_url":"https://api.github.com/repos/agentgonzo/jx/issues/comments{/number}","contents_url":"https://api.github.com/repos/agentgonzo/jx/contents/{+path}","compare_url":"https://api.github.com/repos/agentgonzo/jx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agentgonzo/jx/merges","archive_url":"https://api.github.com/repos/agentgonzo/jx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agentgonzo/jx/downloads","issues_url":"https://api.github.com/repos/agentgonzo/jx/issues{/number}","pulls_url":"https://api.github.com/repos/agentgonzo/jx/pulls{/number}","milestones_url":"https://api.github.com/repos/agentgonzo/jx/milestones{/number}","notifications_url":"https://api.github.com/repos/agentgonzo/jx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agentgonzo/jx/labels{/name}","releases_url":"https://api.github.com/repos/agentgonzo/jx/releases{/id}","deployments_url":"https://api.github.com/repos/agentgonzo/jx/deployments","created_at":"2018-10-23T16:07:12Z","updated_at":"2018-10-23T16:07:17Z","pushed_at":"2018-11-29T10:44:11Z","git_url":"git://github.com/agentgonzo/jx.git","ssh_url":"git@github.com:agentgonzo/jx.git","clone_url":"https://github.com/agentgonzo/jx.git","svn_url":"https://github.com/agentgonzo/jx","homepage":"https://jenkins-x.io/","size":41665,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkins-x:master","ref":"master","sha":"1502d9a7e9f221525431dcc532c44cf69e8d8cfe","user":{"login":"jenkins-x","id":34566050,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTY2MDUw","avatar_url":"https://avatars0.githubusercontent.com/u/34566050?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkins-x","html_url":"https://github.com/jenkins-x","followers_url":"https://api.github.com/users/jenkins-x/followers","following_url":"https://api.github.com/users/jenkins-x/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-x/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-x/subscriptions","organizations_url":"https://api.github.com/users/jenkins-x/orgs","repos_url":"https://api.github.com/users/jenkins-x/repos","events_url":"https://api.github.com/users/jenkins-x/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-x/received_events","type":"Organization","site_admin":false},"repo":{"id":116400734,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY0MDA3MzQ=","name":"jx","full_name":"jenkins-x/jx","private":false,"owner":{"login":"jenkins-x","id":34566050,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTY2MDUw","avatar_url":"https://avatars0.githubusercontent.com/u/34566050?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkins-x","html_url":"https://github.com/jenkins-x","followers_url":"https://api.github.com/users/jenkins-x/followers","following_url":"https://api.github.com/users/jenkins-x/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-x/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-x/subscriptions","organizations_url":"https://api.github.com/users/jenkins-x/orgs","repos_url":"https://api.github.com/users/jenkins-x/repos","events_url":"https://api.github.com/users/jenkins-x/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-x/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jenkins-x/jx","description":"Jenkins X provides automated CI+CD for Kubernetes with Preview Environments on Pull Requests using Jenkins, Knative Build, Prow, Skaffold and Helm","fork":false,"url":"https://api.github.com/repos/jenkins-x/jx","forks_url":"https://api.github.com/repos/jenkins-x/jx/forks","keys_url":"https://api.github.com/repos/jenkins-x/jx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkins-x/jx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkins-x/jx/teams","hooks_url":"https://api.github.com/repos/jenkins-x/jx/hooks","issue_events_url":"https://api.github.com/repos/jenkins-x/jx/issues/events{/number}","events_url":"https://api.github.com/repos/jenkins-x/jx/events","assignees_url":"https://api.github.com/repos/jenkins-x/jx/assignees{/user}","branches_url":"https://api.github.com/repos/jenkins-x/jx/branches{/branch}","tags_url":"https://api.github.com/repos/jenkins-x/jx/tags","blobs_url":"https://api.github.com/repos/jenkins-x/jx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkins-x/jx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkins-x/jx/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkins-x/jx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkins-x/jx/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkins-x/jx/languages","stargazers_url":"https://api.github.com/repos/jenkins-x/jx/stargazers","contributors_url":"https://api.github.com/repos/jenkins-x/jx/contributors","subscribers_url":"https://api.github.com/repos/jenkins-x/jx/subscribers","subscription_url":"https://api.github.com/repos/jenkins-x/jx/subscription","commits_url":"https://api.github.com/repos/jenkins-x/jx/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkins-x/jx/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkins-x/jx/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkins-x/jx/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkins-x/jx/contents/{+path}","compare_url":"https://api.github.com/repos/jenkins-x/jx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkins-x/jx/merges","archive_url":"https://api.github.com/repos/jenkins-x/jx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkins-x/jx/downloads","issues_url":"https://api.github.com/repos/jenkins-x/jx/issues{/number}","pulls_url":"https://api.github.com/repos/jenkins-x/jx/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkins-x/jx/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkins-x/jx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkins-x/jx/labels{/name}","releases_url":"https://api.github.com/repos/jenkins-x/jx/releases{/id}","deployments_url":"https://api.github.com/repos/jenkins-x/jx/deployments","created_at":"2018-01-05T15:46:09Z","updated_at":"2018-11-29T10:48:46Z","pushed_at":"2018-11-29T10:48:43Z","git_url":"git://github.com/jenkins-x/jx.git","ssh_url":"git@github.com:jenkins-x/jx.git","clone_url":"https://github.com/jenkins-x/jx.git","svn_url":"https://github.com/jenkins-x/jx","homepage":"https://jenkins-x.io/","size":41663,"stargazers_count":1769,"watchers_count":1769,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":303,"mirror_url":null,"archived":false,"open_issues_count":476,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":303,"open_issues":476,"watchers":1769,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkins-x/jx/pulls/2363"},"html":{"href":"https://github.com/jenkins-x/jx/pull/2363"},"issue":{"href":"https://api.github.com/repos/jenkins-x/jx/issues/2363"},"comments":{"href":"https://api.github.com/repos/jenkins-x/jx/issues/2363/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkins-x/jx/pulls/2363/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkins-x/jx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkins-x/jx/pulls/2363/commits"},"statuses":{"href":"https://api.github.com/repos/jenkins-x/jx/statuses/c920974dc26967dc0b6da4da7b215b5388fd5a42"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"houndci-bot"}}