{"action":"created","comment":{"url":"https://api.github.com/repos/naver/arcus-memcached/pulls/comments/184582330","pull_request_review_id":115808819,"id":184582330,"diff_hunk":"@@ -0,0 +1,29 @@\n+#!/usr/bin/perl\n+use strict;\n+use Cwd;\n+\n+my $engine_name = shift;\n+my $script_type = shift;\n+my @engine_list = (\"default\");\n+my $opt = '--job 5'; # --job N : run N test jobs in parallel\n+my $srcdir = getcwd;\n+my $ext = \".t\";\n+\n+if ($script_type eq \"big\") {\n+    $ext = \"t\";\n+}\n+\n+# default engine specific test script : ./t/default\n+# common engine test script : ./t\n+\n+if (grep $_ eq $engine_name, @engine_list) {\n+    #system(\"prove $opt --ext '$ext' $srcdir/t/$engine_name $srcdir/t :: $engine_name\");\n+    system(\"prove $opt --ext '$ext' $srcdir/t :: $engine_name\");","path":"run_test.pl","position":21,"original_position":21,"commit_id":"de054cb6acf4c7e38fe3dd88a0578aeeb8411c61","original_commit_id":"de054cb6acf4c7e38fe3dd88a0578aeeb8411c61","user":{"login":"jooho812","id":24535164,"avatar_url":"https://avatars1.githubusercontent.com/u/24535164?v=4","gravatar_id":"","url":"https://api.github.com/users/jooho812","html_url":"https://github.com/jooho812","followers_url":"https://api.github.com/users/jooho812/followers","following_url":"https://api.github.com/users/jooho812/following{/other_user}","gists_url":"https://api.github.com/users/jooho812/gists{/gist_id}","starred_url":"https://api.github.com/users/jooho812/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jooho812/subscriptions","organizations_url":"https://api.github.com/users/jooho812/orgs","repos_url":"https://api.github.com/users/jooho812/repos","events_url":"https://api.github.com/users/jooho812/events{/privacy}","received_events_url":"https://api.github.com/users/jooho812/received_events","type":"User","site_admin":false},"body":"./t/default 디렉토리내에 아직 테스트 스크립트 분류를 하지 않아 해당 디렉토리가 비어 있는 상태로 디렉토리 생성이 되지 않아 travis ci 테스트가 제대로 동작하지 않아서 임시적으로 변경해두었습니다.","created_at":"2018-04-27T03:05:51Z","updated_at":"2018-04-27T03:05:51Z","html_url":"https://github.com/naver/arcus-memcached/pull/149#discussion_r184582330","pull_request_url":"https://api.github.com/repos/naver/arcus-memcached/pulls/149","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/naver/arcus-memcached/pulls/comments/184582330"},"html":{"href":"https://github.com/naver/arcus-memcached/pull/149#discussion_r184582330"},"pull_request":{"href":"https://api.github.com/repos/naver/arcus-memcached/pulls/149"}}},"pull_request":{"url":"https://api.github.com/repos/naver/arcus-memcached/pulls/149","id":184272482,"html_url":"https://github.com/naver/arcus-memcached/pull/149","diff_url":"https://github.com/naver/arcus-memcached/pull/149.diff","patch_url":"https://github.com/naver/arcus-memcached/pull/149.patch","issue_url":"https://api.github.com/repos/naver/arcus-memcached/issues/149","number":149,"state":"open","locked":false,"title":"TEST : change the test structure so that it can be tested for each individual engine","user":{"login":"jooho812","id":24535164,"avatar_url":"https://avatars1.githubusercontent.com/u/24535164?v=4","gravatar_id":"","url":"https://api.github.com/users/jooho812","html_url":"https://github.com/jooho812","followers_url":"https://api.github.com/users/jooho812/followers","following_url":"https://api.github.com/users/jooho812/following{/other_user}","gists_url":"https://api.github.com/users/jooho812/gists{/gist_id}","starred_url":"https://api.github.com/users/jooho812/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jooho812/subscriptions","organizations_url":"https://api.github.com/users/jooho812/orgs","repos_url":"https://api.github.com/users/jooho812/repos","events_url":"https://api.github.com/users/jooho812/events{/privacy}","received_events_url":"https://api.github.com/users/jooho812/received_events","type":"User","site_admin":false},"body":"@jhpark816 \r\nengine, test type별로 prove 명령 수행할 수 있게만 변경하고 파일 분류는 아직 하지 않았습니다.\r\n파일 분류는 다음 PR에 반영하겠습니다.\r\n\r\nenterprise version의 내용을 지우면서 MemcachedTest의 껍데기 부분만 작성하다보니\r\nrelease_memcached와 get_scriptname이 현재는 아무런 필요가 없는 상태인데 각 테스트 스크립트에는 수행되고 있는 상태인데 지우는게 나을까요?","created_at":"2018-04-26T09:07:01Z","updated_at":"2018-04-27T03:05:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"217f34f39f1becf3cb530c99cdba6c1178f83a36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/naver/arcus-memcached/pulls/149/commits","review_comments_url":"https://api.github.com/repos/naver/arcus-memcached/pulls/149/comments","review_comment_url":"https://api.github.com/repos/naver/arcus-memcached/pulls/comments{/number}","comments_url":"https://api.github.com/repos/naver/arcus-memcached/issues/149/comments","statuses_url":"https://api.github.com/repos/naver/arcus-memcached/statuses/de054cb6acf4c7e38fe3dd88a0578aeeb8411c61","head":{"label":"jooho812:task/maketest","ref":"task/maketest","sha":"de054cb6acf4c7e38fe3dd88a0578aeeb8411c61","user":{"login":"jooho812","id":24535164,"avatar_url":"https://avatars1.githubusercontent.com/u/24535164?v=4","gravatar_id":"","url":"https://api.github.com/users/jooho812","html_url":"https://github.com/jooho812","followers_url":"https://api.github.com/users/jooho812/followers","following_url":"https://api.github.com/users/jooho812/following{/other_user}","gists_url":"https://api.github.com/users/jooho812/gists{/gist_id}","starred_url":"https://api.github.com/users/jooho812/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jooho812/subscriptions","organizations_url":"https://api.github.com/users/jooho812/orgs","repos_url":"https://api.github.com/users/jooho812/repos","events_url":"https://api.github.com/users/jooho812/events{/privacy}","received_events_url":"https://api.github.com/users/jooho812/received_events","type":"User","site_admin":false},"repo":{"id":91535874,"name":"arcus-memcached-naver","full_name":"jooho812/arcus-memcached-naver","owner":{"login":"jooho812","id":24535164,"avatar_url":"https://avatars1.githubusercontent.com/u/24535164?v=4","gravatar_id":"","url":"https://api.github.com/users/jooho812","html_url":"https://github.com/jooho812","followers_url":"https://api.github.com/users/jooho812/followers","following_url":"https://api.github.com/users/jooho812/following{/other_user}","gists_url":"https://api.github.com/users/jooho812/gists{/gist_id}","starred_url":"https://api.github.com/users/jooho812/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jooho812/subscriptions","organizations_url":"https://api.github.com/users/jooho812/orgs","repos_url":"https://api.github.com/users/jooho812/repos","events_url":"https://api.github.com/users/jooho812/events{/privacy}","received_events_url":"https://api.github.com/users/jooho812/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jooho812/arcus-memcached-naver","description":"Arcus memory cache server","fork":true,"url":"https://api.github.com/repos/jooho812/arcus-memcached-naver","forks_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/forks","keys_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/teams","hooks_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/hooks","issue_events_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/issues/events{/number}","events_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/events","assignees_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/assignees{/user}","branches_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/branches{/branch}","tags_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/tags","blobs_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/git/refs{/sha}","trees_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/statuses/{sha}","languages_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/languages","stargazers_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/stargazers","contributors_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/contributors","subscribers_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/subscribers","subscription_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/subscription","commits_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/commits{/sha}","git_commits_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/git/commits{/sha}","comments_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/comments{/number}","issue_comment_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/issues/comments{/number}","contents_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/contents/{+path}","compare_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/merges","archive_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/downloads","issues_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/issues{/number}","pulls_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/pulls{/number}","milestones_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/milestones{/number}","notifications_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/labels{/name}","releases_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/releases{/id}","deployments_url":"https://api.github.com/repos/jooho812/arcus-memcached-naver/deployments","created_at":"2017-05-17T05:10:25Z","updated_at":"2018-04-25T06:07:17Z","pushed_at":"2018-04-27T03:01:30Z","git_url":"git://github.com/jooho812/arcus-memcached-naver.git","ssh_url":"git@github.com:jooho812/arcus-memcached-naver.git","clone_url":"https://github.com/jooho812/arcus-memcached-naver.git","svn_url":"https://github.com/jooho812/arcus-memcached-naver","homepage":null,"size":3215,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"naver:develop","ref":"develop","sha":"5bf07f3791878b53d5fe67b9373efd38f25b48c6","user":{"login":"naver","id":6589568,"avatar_url":"https://avatars0.githubusercontent.com/u/6589568?v=4","gravatar_id":"","url":"https://api.github.com/users/naver","html_url":"https://github.com/naver","followers_url":"https://api.github.com/users/naver/followers","following_url":"https://api.github.com/users/naver/following{/other_user}","gists_url":"https://api.github.com/users/naver/gists{/gist_id}","starred_url":"https://api.github.com/users/naver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naver/subscriptions","organizations_url":"https://api.github.com/users/naver/orgs","repos_url":"https://api.github.com/users/naver/repos","events_url":"https://api.github.com/users/naver/events{/privacy}","received_events_url":"https://api.github.com/users/naver/received_events","type":"Organization","site_admin":false},"repo":{"id":19269792,"name":"arcus-memcached","full_name":"naver/arcus-memcached","owner":{"login":"naver","id":6589568,"avatar_url":"https://avatars0.githubusercontent.com/u/6589568?v=4","gravatar_id":"","url":"https://api.github.com/users/naver","html_url":"https://github.com/naver","followers_url":"https://api.github.com/users/naver/followers","following_url":"https://api.github.com/users/naver/following{/other_user}","gists_url":"https://api.github.com/users/naver/gists{/gist_id}","starred_url":"https://api.github.com/users/naver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naver/subscriptions","organizations_url":"https://api.github.com/users/naver/orgs","repos_url":"https://api.github.com/users/naver/repos","events_url":"https://api.github.com/users/naver/events{/privacy}","received_events_url":"https://api.github.com/users/naver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/naver/arcus-memcached","description":"Arcus memory cache server","fork":false,"url":"https://api.github.com/repos/naver/arcus-memcached","forks_url":"https://api.github.com/repos/naver/arcus-memcached/forks","keys_url":"https://api.github.com/repos/naver/arcus-memcached/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naver/arcus-memcached/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naver/arcus-memcached/teams","hooks_url":"https://api.github.com/repos/naver/arcus-memcached/hooks","issue_events_url":"https://api.github.com/repos/naver/arcus-memcached/issues/events{/number}","events_url":"https://api.github.com/repos/naver/arcus-memcached/events","assignees_url":"https://api.github.com/repos/naver/arcus-memcached/assignees{/user}","branches_url":"https://api.github.com/repos/naver/arcus-memcached/branches{/branch}","tags_url":"https://api.github.com/repos/naver/arcus-memcached/tags","blobs_url":"https://api.github.com/repos/naver/arcus-memcached/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naver/arcus-memcached/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naver/arcus-memcached/git/refs{/sha}","trees_url":"https://api.github.com/repos/naver/arcus-memcached/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naver/arcus-memcached/statuses/{sha}","languages_url":"https://api.github.com/repos/naver/arcus-memcached/languages","stargazers_url":"https://api.github.com/repos/naver/arcus-memcached/stargazers","contributors_url":"https://api.github.com/repos/naver/arcus-memcached/contributors","subscribers_url":"https://api.github.com/repos/naver/arcus-memcached/subscribers","subscription_url":"https://api.github.com/repos/naver/arcus-memcached/subscription","commits_url":"https://api.github.com/repos/naver/arcus-memcached/commits{/sha}","git_commits_url":"https://api.github.com/repos/naver/arcus-memcached/git/commits{/sha}","comments_url":"https://api.github.com/repos/naver/arcus-memcached/comments{/number}","issue_comment_url":"https://api.github.com/repos/naver/arcus-memcached/issues/comments{/number}","contents_url":"https://api.github.com/repos/naver/arcus-memcached/contents/{+path}","compare_url":"https://api.github.com/repos/naver/arcus-memcached/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naver/arcus-memcached/merges","archive_url":"https://api.github.com/repos/naver/arcus-memcached/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naver/arcus-memcached/downloads","issues_url":"https://api.github.com/repos/naver/arcus-memcached/issues{/number}","pulls_url":"https://api.github.com/repos/naver/arcus-memcached/pulls{/number}","milestones_url":"https://api.github.com/repos/naver/arcus-memcached/milestones{/number}","notifications_url":"https://api.github.com/repos/naver/arcus-memcached/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naver/arcus-memcached/labels{/name}","releases_url":"https://api.github.com/repos/naver/arcus-memcached/releases{/id}","deployments_url":"https://api.github.com/repos/naver/arcus-memcached/deployments","created_at":"2014-04-29T08:47:43Z","updated_at":"2018-03-15T03:40:22Z","pushed_at":"2018-04-27T03:01:32Z","git_url":"git://github.com/naver/arcus-memcached.git","ssh_url":"git@github.com:naver/arcus-memcached.git","clone_url":"https://github.com/naver/arcus-memcached.git","svn_url":"https://github.com/naver/arcus-memcached","homepage":null,"size":3263,"stargazers_count":27,"watchers_count":27,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":33,"open_issues":5,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/naver/arcus-memcached/pulls/149"},"html":{"href":"https://github.com/naver/arcus-memcached/pull/149"},"issue":{"href":"https://api.github.com/repos/naver/arcus-memcached/issues/149"},"comments":{"href":"https://api.github.com/repos/naver/arcus-memcached/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/naver/arcus-memcached/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/naver/arcus-memcached/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/naver/arcus-memcached/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/naver/arcus-memcached/statuses/de054cb6acf4c7e38fe3dd88a0578aeeb8411c61"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jooho812"}}