{"action":"created","comment":{"url":"https://api.github.com/repos/domenkozar/hie-nix/pulls/comments/245077562","pull_request_review_id":189112665,"id":245077562,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTA3NzU2Mg==","diff_hunk":"@@ -52,19 +52,45 @@ let\n     };\n   };\n   jse = pkgs.haskell.lib.justStaticExecutables;\n-in with pkgs; rec {\n- stack2nix = pkgs.stack2nix;\n- hies = runCommandNoCC \"hies\" {\n-   buildInputs = [ makeWrapper ];\n- } ''\n-   mkdir -p $out/bin\n-   ln -s ${hie82}/bin/hie $out/bin/hie-8.2\n-   ln -s ${hie84}/bin/hie $out/bin/hie-8.4\n-   ln -s ${hie86}/bin/hie $out/bin/hie-8.6\n-   makeWrapper ${hie84}/bin/hie-wrapper $out/bin/hie-wrapper \\\n-     --prefix PATH : $out/bin\n- '';\n- hie82 = jse (import ./ghc-8.2.nix { inherit pkgs; }).haskell-ide-engine;\n- hie84 = jse hie84Pkgs.haskell-ide-engine;\n- hie86 = jse hie86Pkgs.haskell-ide-engine;\n+\n+  wrapWithGHC = ghc: hie: xtra:\n+    pkgs.runCommandNoCC \"hie${ghc.version}-wrapped\" { buildInputs = [ pkgs.makeWrapper ]; } ''\n+      mkdir -p $out/bin\n+      makeWrapper ${hie}/bin/hie $out/bin/hie \\\n+        --prefix PATH : ${ghc}/bin\n+\n+      ${xtra}\n+    '';\n+\n+in\n+\n+rec {\n+\n+  stack2nix = pkgs.stack2nix;\n+\n+  hies = pkgs.runCommandNoCC \"hies\" {\n+    buildInputs = [ pkgs.makeWrapper ];\n+  } ''\n+    mkdir -p $out/bin\n+\n+    ln -s ${hie82}/bin/hie $out/bin/hie-8.2\n+    ln -s ${hie84}/bin/hie $out/bin/hie-8.4\n+    ln -s ${hie86}/bin/hie $out/bin/hie-8.6\n+\n+    makeWrapper ${hie84}/bin/hie-wrapper $out/bin/hie-wrapper \\\n+      --prefix PATH : $out/bin \\\n+      --prefix PATH : ${pkgs.haskell.compiler.ghc844}/bin","path":"default.nix","position":46,"original_position":46,"commit_id":"5b19875ca26537e66ac515e358a20f3e6b7a3cc1","original_commit_id":"5b19875ca26537e66ac515e358a20f3e6b7a3cc1","user":{"login":"ixmatus","id":30714,"node_id":"MDQ6VXNlcjMwNzE0","avatar_url":"https://avatars0.githubusercontent.com/u/30714?v=4","gravatar_id":"","url":"https://api.github.com/users/ixmatus","html_url":"https://github.com/ixmatus","followers_url":"https://api.github.com/users/ixmatus/followers","following_url":"https://api.github.com/users/ixmatus/following{/other_user}","gists_url":"https://api.github.com/users/ixmatus/gists{/gist_id}","starred_url":"https://api.github.com/users/ixmatus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixmatus/subscriptions","organizations_url":"https://api.github.com/users/ixmatus/orgs","repos_url":"https://api.github.com/users/ixmatus/repos","events_url":"https://api.github.com/users/ixmatus/events{/privacy}","received_events_url":"https://api.github.com/users/ixmatus/received_events","type":"User","site_admin":false},"body":"Hmm, when I remove the GHC wrapper it complains it cannot find GHC; I haven't looked to see why it depends on it so when I have some free-time I'll look at why but I think it's necessary.","created_at":"2019-01-03T17:42:17Z","updated_at":"2019-01-03T17:42:17Z","html_url":"https://github.com/domenkozar/hie-nix/pull/39#discussion_r245077562","pull_request_url":"https://api.github.com/repos/domenkozar/hie-nix/pulls/39","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/domenkozar/hie-nix/pulls/comments/245077562"},"html":{"href":"https://github.com/domenkozar/hie-nix/pull/39#discussion_r245077562"},"pull_request":{"href":"https://api.github.com/repos/domenkozar/hie-nix/pulls/39"}},"in_reply_to_id":244778306},"pull_request":{"url":"https://api.github.com/repos/domenkozar/hie-nix/pulls/39","id":241401772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDAxNzcy","html_url":"https://github.com/domenkozar/hie-nix/pull/39","diff_url":"https://github.com/domenkozar/hie-nix/pull/39.diff","patch_url":"https://github.com/domenkozar/hie-nix/pull/39.patch","issue_url":"https://api.github.com/repos/domenkozar/hie-nix/issues/39","number":39,"state":"open","locked":false,"title":"Wrap each hie executable with the ghc it was built with","user":{"login":"ixmatus","id":30714,"node_id":"MDQ6VXNlcjMwNzE0","avatar_url":"https://avatars0.githubusercontent.com/u/30714?v=4","gravatar_id":"","url":"https://api.github.com/users/ixmatus","html_url":"https://github.com/ixmatus","followers_url":"https://api.github.com/users/ixmatus/followers","following_url":"https://api.github.com/users/ixmatus/following{/other_user}","gists_url":"https://api.github.com/users/ixmatus/gists{/gist_id}","starred_url":"https://api.github.com/users/ixmatus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixmatus/subscriptions","organizations_url":"https://api.github.com/users/ixmatus/orgs","repos_url":"https://api.github.com/users/ixmatus/repos","events_url":"https://api.github.com/users/ixmatus/events{/privacy}","received_events_url":"https://api.github.com/users/ixmatus/received_events","type":"User","site_admin":false},"body":"This change wraps each HIE executable with the GHC version it was built with so that the HIE server can run without a globally installed GHC.","created_at":"2018-12-28T21:57:40Z","updated_at":"2019-01-03T17:42:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8398e59438fe9e9d8a1785c31c2a9b4b53e38861","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/domenkozar/hie-nix/pulls/39/commits","review_comments_url":"https://api.github.com/repos/domenkozar/hie-nix/pulls/39/comments","review_comment_url":"https://api.github.com/repos/domenkozar/hie-nix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/domenkozar/hie-nix/issues/39/comments","statuses_url":"https://api.github.com/repos/domenkozar/hie-nix/statuses/5b19875ca26537e66ac515e358a20f3e6b7a3cc1","head":{"label":"ixmatus:parnell/wrap-with-ghc","ref":"parnell/wrap-with-ghc","sha":"5b19875ca26537e66ac515e358a20f3e6b7a3cc1","user":{"login":"ixmatus","id":30714,"node_id":"MDQ6VXNlcjMwNzE0","avatar_url":"https://avatars0.githubusercontent.com/u/30714?v=4","gravatar_id":"","url":"https://api.github.com/users/ixmatus","html_url":"https://github.com/ixmatus","followers_url":"https://api.github.com/users/ixmatus/followers","following_url":"https://api.github.com/users/ixmatus/following{/other_user}","gists_url":"https://api.github.com/users/ixmatus/gists{/gist_id}","starred_url":"https://api.github.com/users/ixmatus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixmatus/subscriptions","organizations_url":"https://api.github.com/users/ixmatus/orgs","repos_url":"https://api.github.com/users/ixmatus/repos","events_url":"https://api.github.com/users/ixmatus/events{/privacy}","received_events_url":"https://api.github.com/users/ixmatus/received_events","type":"User","site_admin":false},"repo":{"id":163452466,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM0NTI0NjY=","name":"hie-nix","full_name":"ixmatus/hie-nix","private":false,"owner":{"login":"ixmatus","id":30714,"node_id":"MDQ6VXNlcjMwNzE0","avatar_url":"https://avatars0.githubusercontent.com/u/30714?v=4","gravatar_id":"","url":"https://api.github.com/users/ixmatus","html_url":"https://github.com/ixmatus","followers_url":"https://api.github.com/users/ixmatus/followers","following_url":"https://api.github.com/users/ixmatus/following{/other_user}","gists_url":"https://api.github.com/users/ixmatus/gists{/gist_id}","starred_url":"https://api.github.com/users/ixmatus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixmatus/subscriptions","organizations_url":"https://api.github.com/users/ixmatus/orgs","repos_url":"https://api.github.com/users/ixmatus/repos","events_url":"https://api.github.com/users/ixmatus/events{/privacy}","received_events_url":"https://api.github.com/users/ixmatus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ixmatus/hie-nix","description":"Nix packages for Haskell IDE Engine","fork":true,"url":"https://api.github.com/repos/ixmatus/hie-nix","forks_url":"https://api.github.com/repos/ixmatus/hie-nix/forks","keys_url":"https://api.github.com/repos/ixmatus/hie-nix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ixmatus/hie-nix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ixmatus/hie-nix/teams","hooks_url":"https://api.github.com/repos/ixmatus/hie-nix/hooks","issue_events_url":"https://api.github.com/repos/ixmatus/hie-nix/issues/events{/number}","events_url":"https://api.github.com/repos/ixmatus/hie-nix/events","assignees_url":"https://api.github.com/repos/ixmatus/hie-nix/assignees{/user}","branches_url":"https://api.github.com/repos/ixmatus/hie-nix/branches{/branch}","tags_url":"https://api.github.com/repos/ixmatus/hie-nix/tags","blobs_url":"https://api.github.com/repos/ixmatus/hie-nix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ixmatus/hie-nix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ixmatus/hie-nix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ixmatus/hie-nix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ixmatus/hie-nix/statuses/{sha}","languages_url":"https://api.github.com/repos/ixmatus/hie-nix/languages","stargazers_url":"https://api.github.com/repos/ixmatus/hie-nix/stargazers","contributors_url":"https://api.github.com/repos/ixmatus/hie-nix/contributors","subscribers_url":"https://api.github.com/repos/ixmatus/hie-nix/subscribers","subscription_url":"https://api.github.com/repos/ixmatus/hie-nix/subscription","commits_url":"https://api.github.com/repos/ixmatus/hie-nix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ixmatus/hie-nix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ixmatus/hie-nix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ixmatus/hie-nix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ixmatus/hie-nix/contents/{+path}","compare_url":"https://api.github.com/repos/ixmatus/hie-nix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ixmatus/hie-nix/merges","archive_url":"https://api.github.com/repos/ixmatus/hie-nix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ixmatus/hie-nix/downloads","issues_url":"https://api.github.com/repos/ixmatus/hie-nix/issues{/number}","pulls_url":"https://api.github.com/repos/ixmatus/hie-nix/pulls{/number}","milestones_url":"https://api.github.com/repos/ixmatus/hie-nix/milestones{/number}","notifications_url":"https://api.github.com/repos/ixmatus/hie-nix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ixmatus/hie-nix/labels{/name}","releases_url":"https://api.github.com/repos/ixmatus/hie-nix/releases{/id}","deployments_url":"https://api.github.com/repos/ixmatus/hie-nix/deployments","created_at":"2018-12-28T21:51:45Z","updated_at":"2018-12-28T21:51:47Z","pushed_at":"2018-12-28T21:56:01Z","git_url":"git://github.com/ixmatus/hie-nix.git","ssh_url":"git@github.com:ixmatus/hie-nix.git","clone_url":"https://github.com/ixmatus/hie-nix.git","svn_url":"https://github.com/ixmatus/hie-nix","homepage":"","size":1958,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"domenkozar:master","ref":"master","sha":"a7ef4c4ceef1dbf46aabff68a4b9bd86d41d0886","user":{"login":"domenkozar","id":126339,"node_id":"MDQ6VXNlcjEyNjMzOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/126339?v=4","gravatar_id":"","url":"https://api.github.com/users/domenkozar","html_url":"https://github.com/domenkozar","followers_url":"https://api.github.com/users/domenkozar/followers","following_url":"https://api.github.com/users/domenkozar/following{/other_user}","gists_url":"https://api.github.com/users/domenkozar/gists{/gist_id}","starred_url":"https://api.github.com/users/domenkozar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenkozar/subscriptions","organizations_url":"https://api.github.com/users/domenkozar/orgs","repos_url":"https://api.github.com/users/domenkozar/repos","events_url":"https://api.github.com/users/domenkozar/events{/privacy}","received_events_url":"https://api.github.com/users/domenkozar/received_events","type":"User","site_admin":false},"repo":{"id":119688846,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk2ODg4NDY=","name":"hie-nix","full_name":"domenkozar/hie-nix","private":false,"owner":{"login":"domenkozar","id":126339,"node_id":"MDQ6VXNlcjEyNjMzOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/126339?v=4","gravatar_id":"","url":"https://api.github.com/users/domenkozar","html_url":"https://github.com/domenkozar","followers_url":"https://api.github.com/users/domenkozar/followers","following_url":"https://api.github.com/users/domenkozar/following{/other_user}","gists_url":"https://api.github.com/users/domenkozar/gists{/gist_id}","starred_url":"https://api.github.com/users/domenkozar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenkozar/subscriptions","organizations_url":"https://api.github.com/users/domenkozar/orgs","repos_url":"https://api.github.com/users/domenkozar/repos","events_url":"https://api.github.com/users/domenkozar/events{/privacy}","received_events_url":"https://api.github.com/users/domenkozar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/domenkozar/hie-nix","description":"Nix packages for Haskell IDE Engine","fork":false,"url":"https://api.github.com/repos/domenkozar/hie-nix","forks_url":"https://api.github.com/repos/domenkozar/hie-nix/forks","keys_url":"https://api.github.com/repos/domenkozar/hie-nix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/domenkozar/hie-nix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/domenkozar/hie-nix/teams","hooks_url":"https://api.github.com/repos/domenkozar/hie-nix/hooks","issue_events_url":"https://api.github.com/repos/domenkozar/hie-nix/issues/events{/number}","events_url":"https://api.github.com/repos/domenkozar/hie-nix/events","assignees_url":"https://api.github.com/repos/domenkozar/hie-nix/assignees{/user}","branches_url":"https://api.github.com/repos/domenkozar/hie-nix/branches{/branch}","tags_url":"https://api.github.com/repos/domenkozar/hie-nix/tags","blobs_url":"https://api.github.com/repos/domenkozar/hie-nix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/domenkozar/hie-nix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/domenkozar/hie-nix/git/refs{/sha}","trees_url":"https://api.github.com/repos/domenkozar/hie-nix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/domenkozar/hie-nix/statuses/{sha}","languages_url":"https://api.github.com/repos/domenkozar/hie-nix/languages","stargazers_url":"https://api.github.com/repos/domenkozar/hie-nix/stargazers","contributors_url":"https://api.github.com/repos/domenkozar/hie-nix/contributors","subscribers_url":"https://api.github.com/repos/domenkozar/hie-nix/subscribers","subscription_url":"https://api.github.com/repos/domenkozar/hie-nix/subscription","commits_url":"https://api.github.com/repos/domenkozar/hie-nix/commits{/sha}","git_commits_url":"https://api.github.com/repos/domenkozar/hie-nix/git/commits{/sha}","comments_url":"https://api.github.com/repos/domenkozar/hie-nix/comments{/number}","issue_comment_url":"https://api.github.com/repos/domenkozar/hie-nix/issues/comments{/number}","contents_url":"https://api.github.com/repos/domenkozar/hie-nix/contents/{+path}","compare_url":"https://api.github.com/repos/domenkozar/hie-nix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/domenkozar/hie-nix/merges","archive_url":"https://api.github.com/repos/domenkozar/hie-nix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/domenkozar/hie-nix/downloads","issues_url":"https://api.github.com/repos/domenkozar/hie-nix/issues{/number}","pulls_url":"https://api.github.com/repos/domenkozar/hie-nix/pulls{/number}","milestones_url":"https://api.github.com/repos/domenkozar/hie-nix/milestones{/number}","notifications_url":"https://api.github.com/repos/domenkozar/hie-nix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/domenkozar/hie-nix/labels{/name}","releases_url":"https://api.github.com/repos/domenkozar/hie-nix/releases{/id}","deployments_url":"https://api.github.com/repos/domenkozar/hie-nix/deployments","created_at":"2018-01-31T13:12:21Z","updated_at":"2019-01-02T17:40:25Z","pushed_at":"2019-01-02T17:40:23Z","git_url":"git://github.com/domenkozar/hie-nix.git","ssh_url":"git@github.com:domenkozar/hie-nix.git","clone_url":"https://github.com/domenkozar/hie-nix.git","svn_url":"https://github.com/domenkozar/hie-nix","homepage":"","size":1994,"stargazers_count":85,"watchers_count":85,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":17,"open_issues":9,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/domenkozar/hie-nix/pulls/39"},"html":{"href":"https://github.com/domenkozar/hie-nix/pull/39"},"issue":{"href":"https://api.github.com/repos/domenkozar/hie-nix/issues/39"},"comments":{"href":"https://api.github.com/repos/domenkozar/hie-nix/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/domenkozar/hie-nix/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/domenkozar/hie-nix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/domenkozar/hie-nix/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/domenkozar/hie-nix/statuses/5b19875ca26537e66ac515e358a20f3e6b7a3cc1"}},"author_association":"NONE"}}
{"actor":{"display_login":"ixmatus"}}