{"action":"created","comment":{"url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/comments/204871480","pull_request_review_id":140030567,"id":204871480,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDg3MTQ4MA==","diff_hunk":"@@ -226,12 +304,6 @@ def setup(self, session_expiration=30):\n         #\n         self.driver.implicitly_wait(15)\n \n-\n-        # Set window size and position explicitly to avoid potential bugs due\n-        # to discrepancies between environments.\n-        #self.driver.set_window_position(0, 0)","path":"securedrop/tests/functional/functional_test.py","position":263,"original_position":263,"commit_id":"1c4750943ade3e5ae661e84d8e751f76b674636e","original_commit_id":"c9751b30b5c964b72ee500925f61902efdf07e3c","user":{"login":"kushaldas","id":272303,"node_id":"MDQ6VXNlcjI3MjMwMw==","avatar_url":"https://avatars3.githubusercontent.com/u/272303?v=4","gravatar_id":"","url":"https://api.github.com/users/kushaldas","html_url":"https://github.com/kushaldas","followers_url":"https://api.github.com/users/kushaldas/followers","following_url":"https://api.github.com/users/kushaldas/following{/other_user}","gists_url":"https://api.github.com/users/kushaldas/gists{/gist_id}","starred_url":"https://api.github.com/users/kushaldas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kushaldas/subscriptions","organizations_url":"https://api.github.com/users/kushaldas/orgs","repos_url":"https://api.github.com/users/kushaldas/repos","events_url":"https://api.github.com/users/kushaldas/events{/privacy}","received_events_url":"https://api.github.com/users/kushaldas/received_events","type":"User","site_admin":false},"body":"I finally figured out why i had to comment that out. https://github.com/mozilla/geckodriver/issues/676 is causing the trouble as we have to test against the `firefox 52esr` in this branch. None of those position calls are working in this. @redshiftzero ","created_at":"2018-07-24T18:50:11Z","updated_at":"2018-07-24T18:50:11Z","html_url":"https://github.com/freedomofpress/securedrop/pull/3628#discussion_r204871480","pull_request_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3628","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/comments/204871480"},"html":{"href":"https://github.com/freedomofpress/securedrop/pull/3628#discussion_r204871480"},"pull_request":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3628"}},"in_reply_to_id":203524748},"pull_request":{"url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3628","id":201029129,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDI5MTI5","html_url":"https://github.com/freedomofpress/securedrop/pull/3628","diff_url":"https://github.com/freedomofpress/securedrop/pull/3628.diff","patch_url":"https://github.com/freedomofpress/securedrop/pull/3628.patch","issue_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3628","number":3628,"state":"open","locked":false,"title":"Tests against a local instance in the container","user":{"login":"kushaldas","id":272303,"node_id":"MDQ6VXNlcjI3MjMwMw==","avatar_url":"https://avatars3.githubusercontent.com/u/272303?v=4","gravatar_id":"","url":"https://api.github.com/users/kushaldas","html_url":"https://github.com/kushaldas","followers_url":"https://api.github.com/users/kushaldas/followers","following_url":"https://api.github.com/users/kushaldas/following{/other_user}","gists_url":"https://api.github.com/users/kushaldas/gists{/gist_id}","starred_url":"https://api.github.com/users/kushaldas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kushaldas/subscriptions","organizations_url":"https://api.github.com/users/kushaldas/orgs","repos_url":"https://api.github.com/users/kushaldas/repos","events_url":"https://api.github.com/users/kushaldas/events{/privacy}","received_events_url":"https://api.github.com/users/kushaldas/received_events","type":"User","site_admin":false},"body":"## Status\r\n\r\nReady for review. \r\n\r\n## Description of Changes\r\n\r\nFixes #3483 and #3487 \r\n\r\nIf the `instance_information.json` file does not exists, it starts a local servers and tests against them using Tor Browser.\r\n\r\nThis PR is on top of  #3592 PR, so that has to get in first.\r\n\r\n## Testing\r\n\r\nYou can run the functional tests like:\r\n\r\n```\r\n./bin/dev-shell ./bin/run-test --capture=no -v tests/functional/test_submit_and_retrieve_message.py\r\n```\r\n\r\n## Deployment\r\n\r\nAny special considerations for deployment? Consider both:\r\n\r\n1. Upgrading existing production instances.\r\n2. New installs.\r\n\r\n## Checklist\r\n\r\n### If you made changes to the server application code:\r\n\r\n- [ ] Linting (`make ci-lint`) and tests (`make -C securedrop test`) pass in the development container\r\n\r\n### If you made changes to `securedrop-admin`:\r\n\r\n- [ ] Linting and tests (`make -C admin test`) pass in the admin development container\r\n\r\n### If you made changes to the system configuration:\r\n\r\n- [ ] [Configuration tests](https://docs.securedrop.org/en/latest/development/testing_configuration_tests.html) pass\r\n\r\n### If you made non-trivial code changes:\r\n\r\n- [ ] I have written a test plan and validated it for this PR\r\n\r\n### If you made changes to documentation:\r\n\r\n- [ ] Doc linting (`make docs-lint`) passed locally\r\n","created_at":"2018-07-12T14:54:43Z","updated_at":"2018-07-24T18:50:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"230477093b7b7486035c97f2fca5457cae68a3e0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dachary","id":433594,"node_id":"MDQ6VXNlcjQzMzU5NA==","avatar_url":"https://avatars0.githubusercontent.com/u/433594?v=4","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false},{"login":"heartsucker","id":3998464,"node_id":"MDQ6VXNlcjM5OTg0NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3998464?v=4","gravatar_id":"","url":"https://api.github.com/users/heartsucker","html_url":"https://github.com/heartsucker","followers_url":"https://api.github.com/users/heartsucker/followers","following_url":"https://api.github.com/users/heartsucker/following{/other_user}","gists_url":"https://api.github.com/users/heartsucker/gists{/gist_id}","starred_url":"https://api.github.com/users/heartsucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heartsucker/subscriptions","organizations_url":"https://api.github.com/users/heartsucker/orgs","repos_url":"https://api.github.com/users/heartsucker/repos","events_url":"https://api.github.com/users/heartsucker/events{/privacy}","received_events_url":"https://api.github.com/users/heartsucker/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3628/commits","review_comments_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3628/comments","review_comment_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3628/comments","statuses_url":"https://api.github.com/repos/freedomofpress/securedrop/statuses/1c4750943ade3e5ae661e84d8e751f76b674636e","head":{"label":"kushaldas:local_tests","ref":"local_tests","sha":"1c4750943ade3e5ae661e84d8e751f76b674636e","user":{"login":"kushaldas","id":272303,"node_id":"MDQ6VXNlcjI3MjMwMw==","avatar_url":"https://avatars3.githubusercontent.com/u/272303?v=4","gravatar_id":"","url":"https://api.github.com/users/kushaldas","html_url":"https://github.com/kushaldas","followers_url":"https://api.github.com/users/kushaldas/followers","following_url":"https://api.github.com/users/kushaldas/following{/other_user}","gists_url":"https://api.github.com/users/kushaldas/gists{/gist_id}","starred_url":"https://api.github.com/users/kushaldas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kushaldas/subscriptions","organizations_url":"https://api.github.com/users/kushaldas/orgs","repos_url":"https://api.github.com/users/kushaldas/repos","events_url":"https://api.github.com/users/kushaldas/events{/privacy}","received_events_url":"https://api.github.com/users/kushaldas/received_events","type":"User","site_admin":false},"repo":{"id":103963096,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM5NjMwOTY=","name":"securedrop","full_name":"kushaldas/securedrop","owner":{"login":"kushaldas","id":272303,"node_id":"MDQ6VXNlcjI3MjMwMw==","avatar_url":"https://avatars3.githubusercontent.com/u/272303?v=4","gravatar_id":"","url":"https://api.github.com/users/kushaldas","html_url":"https://github.com/kushaldas","followers_url":"https://api.github.com/users/kushaldas/followers","following_url":"https://api.github.com/users/kushaldas/following{/other_user}","gists_url":"https://api.github.com/users/kushaldas/gists{/gist_id}","starred_url":"https://api.github.com/users/kushaldas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kushaldas/subscriptions","organizations_url":"https://api.github.com/users/kushaldas/orgs","repos_url":"https://api.github.com/users/kushaldas/repos","events_url":"https://api.github.com/users/kushaldas/events{/privacy}","received_events_url":"https://api.github.com/users/kushaldas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kushaldas/securedrop","description":"GitHub repository for the SecureDrop whistleblower platform. Do not submit tips here!","fork":true,"url":"https://api.github.com/repos/kushaldas/securedrop","forks_url":"https://api.github.com/repos/kushaldas/securedrop/forks","keys_url":"https://api.github.com/repos/kushaldas/securedrop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kushaldas/securedrop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kushaldas/securedrop/teams","hooks_url":"https://api.github.com/repos/kushaldas/securedrop/hooks","issue_events_url":"https://api.github.com/repos/kushaldas/securedrop/issues/events{/number}","events_url":"https://api.github.com/repos/kushaldas/securedrop/events","assignees_url":"https://api.github.com/repos/kushaldas/securedrop/assignees{/user}","branches_url":"https://api.github.com/repos/kushaldas/securedrop/branches{/branch}","tags_url":"https://api.github.com/repos/kushaldas/securedrop/tags","blobs_url":"https://api.github.com/repos/kushaldas/securedrop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kushaldas/securedrop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kushaldas/securedrop/git/refs{/sha}","trees_url":"https://api.github.com/repos/kushaldas/securedrop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kushaldas/securedrop/statuses/{sha}","languages_url":"https://api.github.com/repos/kushaldas/securedrop/languages","stargazers_url":"https://api.github.com/repos/kushaldas/securedrop/stargazers","contributors_url":"https://api.github.com/repos/kushaldas/securedrop/contributors","subscribers_url":"https://api.github.com/repos/kushaldas/securedrop/subscribers","subscription_url":"https://api.github.com/repos/kushaldas/securedrop/subscription","commits_url":"https://api.github.com/repos/kushaldas/securedrop/commits{/sha}","git_commits_url":"https://api.github.com/repos/kushaldas/securedrop/git/commits{/sha}","comments_url":"https://api.github.com/repos/kushaldas/securedrop/comments{/number}","issue_comment_url":"https://api.github.com/repos/kushaldas/securedrop/issues/comments{/number}","contents_url":"https://api.github.com/repos/kushaldas/securedrop/contents/{+path}","compare_url":"https://api.github.com/repos/kushaldas/securedrop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kushaldas/securedrop/merges","archive_url":"https://api.github.com/repos/kushaldas/securedrop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kushaldas/securedrop/downloads","issues_url":"https://api.github.com/repos/kushaldas/securedrop/issues{/number}","pulls_url":"https://api.github.com/repos/kushaldas/securedrop/pulls{/number}","milestones_url":"https://api.github.com/repos/kushaldas/securedrop/milestones{/number}","notifications_url":"https://api.github.com/repos/kushaldas/securedrop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kushaldas/securedrop/labels{/name}","releases_url":"https://api.github.com/repos/kushaldas/securedrop/releases{/id}","deployments_url":"https://api.github.com/repos/kushaldas/securedrop/deployments","created_at":"2017-09-18T16:20:24Z","updated_at":"2017-09-18T16:20:27Z","pushed_at":"2018-07-20T18:52:48Z","git_url":"git://github.com/kushaldas/securedrop.git","ssh_url":"git@github.com:kushaldas/securedrop.git","clone_url":"https://github.com/kushaldas/securedrop.git","svn_url":"https://github.com/kushaldas/securedrop","homepage":"https://securedrop.org/","size":70667,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"freedomofpress:tbb-0.9.0","ref":"tbb-0.9.0","sha":"955053d637ae04f20c0af7ca1b76abeeb0ec1ebc","user":{"login":"freedomofpress","id":5388147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODgxNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/5388147?v=4","gravatar_id":"","url":"https://api.github.com/users/freedomofpress","html_url":"https://github.com/freedomofpress","followers_url":"https://api.github.com/users/freedomofpress/followers","following_url":"https://api.github.com/users/freedomofpress/following{/other_user}","gists_url":"https://api.github.com/users/freedomofpress/gists{/gist_id}","starred_url":"https://api.github.com/users/freedomofpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freedomofpress/subscriptions","organizations_url":"https://api.github.com/users/freedomofpress/orgs","repos_url":"https://api.github.com/users/freedomofpress/repos","events_url":"https://api.github.com/users/freedomofpress/events{/privacy}","received_events_url":"https://api.github.com/users/freedomofpress/received_events","type":"Organization","site_admin":false},"repo":{"id":3156820,"node_id":"MDEwOlJlcG9zaXRvcnkzMTU2ODIw","name":"securedrop","full_name":"freedomofpress/securedrop","owner":{"login":"freedomofpress","id":5388147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODgxNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/5388147?v=4","gravatar_id":"","url":"https://api.github.com/users/freedomofpress","html_url":"https://github.com/freedomofpress","followers_url":"https://api.github.com/users/freedomofpress/followers","following_url":"https://api.github.com/users/freedomofpress/following{/other_user}","gists_url":"https://api.github.com/users/freedomofpress/gists{/gist_id}","starred_url":"https://api.github.com/users/freedomofpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freedomofpress/subscriptions","organizations_url":"https://api.github.com/users/freedomofpress/orgs","repos_url":"https://api.github.com/users/freedomofpress/repos","events_url":"https://api.github.com/users/freedomofpress/events{/privacy}","received_events_url":"https://api.github.com/users/freedomofpress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freedomofpress/securedrop","description":"GitHub repository for the SecureDrop whistleblower platform. Do not submit tips here!","fork":false,"url":"https://api.github.com/repos/freedomofpress/securedrop","forks_url":"https://api.github.com/repos/freedomofpress/securedrop/forks","keys_url":"https://api.github.com/repos/freedomofpress/securedrop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freedomofpress/securedrop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freedomofpress/securedrop/teams","hooks_url":"https://api.github.com/repos/freedomofpress/securedrop/hooks","issue_events_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/events{/number}","events_url":"https://api.github.com/repos/freedomofpress/securedrop/events","assignees_url":"https://api.github.com/repos/freedomofpress/securedrop/assignees{/user}","branches_url":"https://api.github.com/repos/freedomofpress/securedrop/branches{/branch}","tags_url":"https://api.github.com/repos/freedomofpress/securedrop/tags","blobs_url":"https://api.github.com/repos/freedomofpress/securedrop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freedomofpress/securedrop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freedomofpress/securedrop/git/refs{/sha}","trees_url":"https://api.github.com/repos/freedomofpress/securedrop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freedomofpress/securedrop/statuses/{sha}","languages_url":"https://api.github.com/repos/freedomofpress/securedrop/languages","stargazers_url":"https://api.github.com/repos/freedomofpress/securedrop/stargazers","contributors_url":"https://api.github.com/repos/freedomofpress/securedrop/contributors","subscribers_url":"https://api.github.com/repos/freedomofpress/securedrop/subscribers","subscription_url":"https://api.github.com/repos/freedomofpress/securedrop/subscription","commits_url":"https://api.github.com/repos/freedomofpress/securedrop/commits{/sha}","git_commits_url":"https://api.github.com/repos/freedomofpress/securedrop/git/commits{/sha}","comments_url":"https://api.github.com/repos/freedomofpress/securedrop/comments{/number}","issue_comment_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/comments{/number}","contents_url":"https://api.github.com/repos/freedomofpress/securedrop/contents/{+path}","compare_url":"https://api.github.com/repos/freedomofpress/securedrop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freedomofpress/securedrop/merges","archive_url":"https://api.github.com/repos/freedomofpress/securedrop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freedomofpress/securedrop/downloads","issues_url":"https://api.github.com/repos/freedomofpress/securedrop/issues{/number}","pulls_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls{/number}","milestones_url":"https://api.github.com/repos/freedomofpress/securedrop/milestones{/number}","notifications_url":"https://api.github.com/repos/freedomofpress/securedrop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freedomofpress/securedrop/labels{/name}","releases_url":"https://api.github.com/repos/freedomofpress/securedrop/releases{/id}","deployments_url":"https://api.github.com/repos/freedomofpress/securedrop/deployments","created_at":"2012-01-11T19:57:55Z","updated_at":"2018-07-24T17:16:09Z","pushed_at":"2018-07-24T18:49:30Z","git_url":"git://github.com/freedomofpress/securedrop.git","ssh_url":"git@github.com:freedomofpress/securedrop.git","clone_url":"https://github.com/freedomofpress/securedrop.git","svn_url":"https://github.com/freedomofpress/securedrop","homepage":"https://securedrop.org/","size":72763,"stargazers_count":2436,"watchers_count":2436,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":480,"mirror_url":null,"archived":false,"open_issues_count":395,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":480,"open_issues":395,"watchers":2436,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3628"},"html":{"href":"https://github.com/freedomofpress/securedrop/pull/3628"},"issue":{"href":"https://api.github.com/repos/freedomofpress/securedrop/issues/3628"},"comments":{"href":"https://api.github.com/repos/freedomofpress/securedrop/issues/3628/comments"},"review_comments":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3628/comments"},"review_comment":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3628/commits"},"statuses":{"href":"https://api.github.com/repos/freedomofpress/securedrop/statuses/1c4750943ade3e5ae661e84d8e751f76b674636e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kushaldas"}}