{"action":"created","issue":{"url":"https://api.github.com/repos/michpalm/TestFiles/issues/3","repository_url":"https://api.github.com/repos/michpalm/TestFiles","labels_url":"https://api.github.com/repos/michpalm/TestFiles/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/michpalm/TestFiles/issues/3/comments","events_url":"https://api.github.com/repos/michpalm/TestFiles/issues/3/events","html_url":"https://github.com/michpalm/TestFiles/pull/3","id":349546019,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NjM2MTUw","number":3,"title":"Test PR for demo of PR Template","user":{"login":"michpalm","id":18511803,"node_id":"MDQ6VXNlcjE4NTExODAz","avatar_url":"https://avatars0.githubusercontent.com/u/18511803?v=4","gravatar_id":"","url":"https://api.github.com/users/michpalm","html_url":"https://github.com/michpalm","followers_url":"https://api.github.com/users/michpalm/followers","following_url":"https://api.github.com/users/michpalm/following{/other_user}","gists_url":"https://api.github.com/users/michpalm/gists{/gist_id}","starred_url":"https://api.github.com/users/michpalm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michpalm/subscriptions","organizations_url":"https://api.github.com/users/michpalm/orgs","repos_url":"https://api.github.com/users/michpalm/repos","events_url":"https://api.github.com/users/michpalm/events{/privacy}","received_events_url":"https://api.github.com/users/michpalm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-10T14:51:32Z","updated_at":"2018-08-13T09:44:21Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/michpalm/TestFiles/pulls/3","html_url":"https://github.com/michpalm/TestFiles/pull/3","diff_url":"https://github.com/michpalm/TestFiles/pull/3.diff","patch_url":"https://github.com/michpalm/TestFiles/pull/3.patch"},"body":"## Changes this Pull Request Introduces\r\n<!---Describe the big picture of your changes here to communicate to the reviewers why they should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to the trello card (if available).--->\r\n\r\nAdd `Demo` file to Repository.\r\n\r\n## Types of changes\r\n\r\nWhat types of changes does your code introduce to Aggregation?  \r\n_Put an `x` in the boxes that applies_ \r\n\r\n- [ ] Bugfix (change which fixes an issue)\r\n- [x] New feature (change which adds functionality)\r\n- [ ] Logging purpose (change which adds logging for errors or data)\r\n- [ ] Refactoring (change which does not change external behaviour yet improves internal structure)\r\n- [ ] Style (change that do not affect the meaning of the code: white-space, formatting, missing semi-colons, etc) \r\n\r\n## Reviewer's Checklist\r\n\r\nThis is a guideline for the reviewer on what to check to ensure that the quality of the code is kept at a Tink standard.  \r\n\r\n_Put an `x` in the boxes that have been checked and fullfiled_ \r\n\r\n- [x] The code packages follow the [Tink structure](https://docs.google.com/document/d/18pSzbRPlHYbKJtCDntMYE_4TqNWFdyTFuETq6lyNZBk/edit#heading=h.f3ao0xse8vu5)\r\n- [ ] The code is clean from `development-only` code (setDebugOutput, println) \r\n- [ ] The known errors are being handled and unknown logged\r\n- [x] The `JSON/XML` values are sanitized (Not hardcoded from string concatenation of input values; Use `Jackson`!) \r\n- [x] The code uses a [`Constants Class`](https://docs.google.com/document/d/18pSzbRPlHYbKJtCDntMYE_4TqNWFdyTFuETq6lyNZBk/edit#heading=h.6tr2fkwudh2m) for constants \r\n- [ ] The code uses `Catalog` for translatable strings\r\n- [ ] The code follows the style, formatting and naming conventions of [Tink](https://docs.google.com/document/d/18pSzbRPlHYbKJtCDntMYE_4TqNWFdyTFuETq6lyNZBk/edit#heading=h.hxfhn3yt7me0)\r\n- [ ] Follow the code for logical errors\r\n\r\n## Further comments\r\n<!---If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...--->\r\n\r\nNone."},"comment":{"url":"https://api.github.com/repos/michpalm/TestFiles/issues/comments/412464287","html_url":"https://github.com/michpalm/TestFiles/pull/3#issuecomment-412464287","issue_url":"https://api.github.com/repos/michpalm/TestFiles/issues/3","id":412464287,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjQ2NDI4Nw==","user":{"login":"Sebelino","id":837775,"node_id":"MDQ6VXNlcjgzNzc3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/837775?v=4","gravatar_id":"","url":"https://api.github.com/users/Sebelino","html_url":"https://github.com/Sebelino","followers_url":"https://api.github.com/users/Sebelino/followers","following_url":"https://api.github.com/users/Sebelino/following{/other_user}","gists_url":"https://api.github.com/users/Sebelino/gists{/gist_id}","starred_url":"https://api.github.com/users/Sebelino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sebelino/subscriptions","organizations_url":"https://api.github.com/users/Sebelino/orgs","repos_url":"https://api.github.com/users/Sebelino/repos","events_url":"https://api.github.com/users/Sebelino/events{/privacy}","received_events_url":"https://api.github.com/users/Sebelino/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T09:44:21Z","updated_at":"2018-08-13T09:44:21Z","author_association":"NONE","body":"* Consider trimming strings that may have trailing whitespaces\r\n* No newlines at the end of files\r\n* Remove unused classes\r\n* Aim to prevent variables to be set to null. If a resource may be absent, consider making it Optional<>. Use annotations like @Nonnull to clarify the contracts of your methods and throw fatal null-originating exceptions as early as possible using Precondition.checkNotNull\r\n* Try not to return null from methods; if you need to return a potentially absent resource, use Optional<>\r\n* Consider squashing (some of) your commits (rebase -i) and try to make sure they use the appropriate commit label [link to Good To Know Commands (or Playbook (or Integration/Development onboarding document))]\r\n* s/The code uses a Constants Class for constants/Check that you do not have duplicates of constants defined in both the Constant class and other places/\r\n* Make sure Amounts have the correct sign (positive/negative)\r\n* Make sure identifiers are understandable (e.g. socialSecurityNumber instead of ssn)\r\n*  d/ The known errors are being handled and unknown logged\r\n* * Make sure the Authenticator throws an AuthenticationException if the password is incorrect\r\n* * Make sure the Authenticator throws an AuthorizationException if the user attempts to access a resource it does not have privileges to (e.g. if the account has been blocked). You may want to throw this exception if the http status code is 401/403\r\n* Consider not exposing Entities to non-RPC classes"}}
{"actor":{"display_login":"Sebelino"}}