{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/beats/pulls/comments/236795718","pull_request_review_id":178946856,"id":236795718,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjc5NTcxOA==","diff_hunk":"@@ -33,6 +33,8 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha1...master[Check the HEAD d\n \n *Affecting all Beats*\n \n+- Keep a mapping of autodiscover instances and deployed configs. {pull}8851[8851]","path":"CHANGELOG.asciidoc","position":4,"original_position":4,"commit_id":"c44d1f452deeefcfc49bf409c8fd8d60e947da8f","original_commit_id":"c44d1f452deeefcfc49bf409c8fd8d60e947da8f","user":{"login":"andrewvc","id":131427,"node_id":"MDQ6VXNlcjEzMTQyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/131427?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"Maybe this could be a bit more clear? What effect will users notice? If none, we should mention that this is an internal refactor to add new features later.","created_at":"2018-11-27T18:42:35Z","updated_at":"2018-11-27T18:42:35Z","html_url":"https://github.com/elastic/beats/pull/8851#discussion_r236795718","pull_request_url":"https://api.github.com/repos/elastic/beats/pulls/8851","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments/236795718"},"html":{"href":"https://github.com/elastic/beats/pull/8851#discussion_r236795718"},"pull_request":{"href":"https://api.github.com/repos/elastic/beats/pulls/8851"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/beats/pulls/8851","id":227337195,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MzM3MTk1","html_url":"https://github.com/elastic/beats/pull/8851","diff_url":"https://github.com/elastic/beats/pull/8851.diff","patch_url":"https://github.com/elastic/beats/pull/8851.patch","issue_url":"https://api.github.com/repos/elastic/beats/issues/8851","number":8851,"state":"open","locked":false,"title":"Keep a mapping of autodiscover instances and deployed configs","user":{"login":"exekias","id":299804,"node_id":"MDQ6VXNlcjI5OTgwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/299804?v=4","gravatar_id":"","url":"https://api.github.com/users/exekias","html_url":"https://github.com/exekias","followers_url":"https://api.github.com/users/exekias/followers","following_url":"https://api.github.com/users/exekias/following{/other_user}","gists_url":"https://api.github.com/users/exekias/gists{/gist_id}","starred_url":"https://api.github.com/users/exekias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exekias/subscriptions","organizations_url":"https://api.github.com/users/exekias/orgs","repos_url":"https://api.github.com/users/exekias/repos","events_url":"https://api.github.com/users/exekias/events{/privacy}","received_events_url":"https://api.github.com/users/exekias/received_events","type":"User","site_admin":false},"body":"This changes stop behavior, sometimes not all metadata is available in\r\nthe stop event, this results in some configs not being stopped because\r\nof that.\r\n\r\nAfter this change, we only rely on instance id from the event to decide\r\nwhat configs to delete, as we'll keep a map of instance id -> deployed\r\nconfigs.\r\n\r\nFixes #8535","created_at":"2018-10-31T15:40:46Z","updated_at":"2018-11-27T18:42:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5e92222a6e355433aaf873f089c5fb8aac55ee6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1135227315,"node_id":"MDU6TGFiZWwxMTM1MjI3MzE1","url":"https://api.github.com/repos/elastic/beats/labels/:infrastructure","name":":infrastructure","color":"47e8a5","default":false},{"id":78874872,"node_id":"MDU6TGFiZWw3ODg3NDg3Mg==","url":"https://api.github.com/repos/elastic/beats/labels/bug","name":"bug","color":"fc2929","default":true},{"id":872233445,"node_id":"MDU6TGFiZWw4NzIyMzM0NDU=","url":"https://api.github.com/repos/elastic/beats/labels/containers","name":"containers","color":"2f99ce","default":false},{"id":294278853,"node_id":"MDU6TGFiZWwyOTQyNzg4NTM=","url":"https://api.github.com/repos/elastic/beats/labels/libbeat","name":"libbeat","color":"008000","default":false},{"id":360592718,"node_id":"MDU6TGFiZWwzNjA1OTI3MTg=","url":"https://api.github.com/repos/elastic/beats/labels/needs_backport","name":"needs_backport","color":"1d76db","default":false},{"id":1104784048,"node_id":"MDU6TGFiZWwxMTA0Nzg0MDQ4","url":"https://api.github.com/repos/elastic/beats/labels/v6.6.0","name":"v6.6.0","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/beats/pulls/8851/commits","review_comments_url":"https://api.github.com/repos/elastic/beats/pulls/8851/comments","review_comment_url":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/beats/issues/8851/comments","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/c44d1f452deeefcfc49bf409c8fd8d60e947da8f","head":{"label":"exekias:autodiscover-instance-id","ref":"autodiscover-instance-id","sha":"c44d1f452deeefcfc49bf409c8fd8d60e947da8f","user":{"login":"exekias","id":299804,"node_id":"MDQ6VXNlcjI5OTgwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/299804?v=4","gravatar_id":"","url":"https://api.github.com/users/exekias","html_url":"https://github.com/exekias","followers_url":"https://api.github.com/users/exekias/followers","following_url":"https://api.github.com/users/exekias/following{/other_user}","gists_url":"https://api.github.com/users/exekias/gists{/gist_id}","starred_url":"https://api.github.com/users/exekias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exekias/subscriptions","organizations_url":"https://api.github.com/users/exekias/orgs","repos_url":"https://api.github.com/users/exekias/repos","events_url":"https://api.github.com/users/exekias/events{/privacy}","received_events_url":"https://api.github.com/users/exekias/received_events","type":"User","site_admin":false},"repo":{"id":84233728,"node_id":"MDEwOlJlcG9zaXRvcnk4NDIzMzcyOA==","name":"beats","full_name":"exekias/beats","private":false,"owner":{"login":"exekias","id":299804,"node_id":"MDQ6VXNlcjI5OTgwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/299804?v=4","gravatar_id":"","url":"https://api.github.com/users/exekias","html_url":"https://github.com/exekias","followers_url":"https://api.github.com/users/exekias/followers","following_url":"https://api.github.com/users/exekias/following{/other_user}","gists_url":"https://api.github.com/users/exekias/gists{/gist_id}","starred_url":"https://api.github.com/users/exekias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exekias/subscriptions","organizations_url":"https://api.github.com/users/exekias/orgs","repos_url":"https://api.github.com/users/exekias/repos","events_url":"https://api.github.com/users/exekias/events{/privacy}","received_events_url":"https://api.github.com/users/exekias/received_events","type":"User","site_admin":false},"html_url":"https://github.com/exekias/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":true,"url":"https://api.github.com/repos/exekias/beats","forks_url":"https://api.github.com/repos/exekias/beats/forks","keys_url":"https://api.github.com/repos/exekias/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exekias/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exekias/beats/teams","hooks_url":"https://api.github.com/repos/exekias/beats/hooks","issue_events_url":"https://api.github.com/repos/exekias/beats/issues/events{/number}","events_url":"https://api.github.com/repos/exekias/beats/events","assignees_url":"https://api.github.com/repos/exekias/beats/assignees{/user}","branches_url":"https://api.github.com/repos/exekias/beats/branches{/branch}","tags_url":"https://api.github.com/repos/exekias/beats/tags","blobs_url":"https://api.github.com/repos/exekias/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exekias/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exekias/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/exekias/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exekias/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/exekias/beats/languages","stargazers_url":"https://api.github.com/repos/exekias/beats/stargazers","contributors_url":"https://api.github.com/repos/exekias/beats/contributors","subscribers_url":"https://api.github.com/repos/exekias/beats/subscribers","subscription_url":"https://api.github.com/repos/exekias/beats/subscription","commits_url":"https://api.github.com/repos/exekias/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/exekias/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/exekias/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/exekias/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/exekias/beats/contents/{+path}","compare_url":"https://api.github.com/repos/exekias/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exekias/beats/merges","archive_url":"https://api.github.com/repos/exekias/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exekias/beats/downloads","issues_url":"https://api.github.com/repos/exekias/beats/issues{/number}","pulls_url":"https://api.github.com/repos/exekias/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/exekias/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/exekias/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exekias/beats/labels{/name}","releases_url":"https://api.github.com/repos/exekias/beats/releases{/id}","deployments_url":"https://api.github.com/repos/exekias/beats/deployments","created_at":"2017-03-07T18:42:42Z","updated_at":"2017-03-07T18:42:47Z","pushed_at":"2018-11-27T17:34:40Z","git_url":"git://github.com/exekias/beats.git","ssh_url":"git@github.com:exekias/beats.git","clone_url":"https://github.com/exekias/beats.git","svn_url":"https://github.com/exekias/beats","homepage":"https://www.elastic.co/products/beats","size":97677,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"1411852c9d934ed0bea869efb78b00e5bde97658","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":16554739,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU1NDczOQ==","name":"beats","full_name":"elastic/beats","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":false,"url":"https://api.github.com/repos/elastic/beats","forks_url":"https://api.github.com/repos/elastic/beats/forks","keys_url":"https://api.github.com/repos/elastic/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/beats/teams","hooks_url":"https://api.github.com/repos/elastic/beats/hooks","issue_events_url":"https://api.github.com/repos/elastic/beats/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/beats/events","assignees_url":"https://api.github.com/repos/elastic/beats/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/beats/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/beats/tags","blobs_url":"https://api.github.com/repos/elastic/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/beats/languages","stargazers_url":"https://api.github.com/repos/elastic/beats/stargazers","contributors_url":"https://api.github.com/repos/elastic/beats/contributors","subscribers_url":"https://api.github.com/repos/elastic/beats/subscribers","subscription_url":"https://api.github.com/repos/elastic/beats/subscription","commits_url":"https://api.github.com/repos/elastic/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/beats/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/beats/merges","archive_url":"https://api.github.com/repos/elastic/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/beats/downloads","issues_url":"https://api.github.com/repos/elastic/beats/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/beats/labels{/name}","releases_url":"https://api.github.com/repos/elastic/beats/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/beats/deployments","created_at":"2014-02-05T19:01:02Z","updated_at":"2018-11-27T17:21:53Z","pushed_at":"2018-11-27T18:37:55Z","git_url":"git://github.com/elastic/beats.git","ssh_url":"git@github.com:elastic/beats.git","clone_url":"https://github.com/elastic/beats.git","svn_url":"https://github.com/elastic/beats","homepage":"https://www.elastic.co/products/beats","size":105286,"stargazers_count":6452,"watchers_count":6452,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2048,"mirror_url":null,"archived":false,"open_issues_count":1065,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2048,"open_issues":1065,"watchers":6452,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/8851"},"html":{"href":"https://github.com/elastic/beats/pull/8851"},"issue":{"href":"https://api.github.com/repos/elastic/beats/issues/8851"},"comments":{"href":"https://api.github.com/repos/elastic/beats/issues/8851/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/beats/pulls/8851/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/beats/pulls/8851/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/beats/statuses/c44d1f452deeefcfc49bf409c8fd8d60e947da8f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"andrewvc"}}