{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-r10k/pulls/comments/183757898","pull_request_review_id":114816499,"id":183757898,"diff_hunk":"@@ -205,7 +205,7 @@ class Server < Sinatra::Base\n       return 200\n     else\n       $logger.info(\"Deploying environment #{env}\")\n-      deploy(env, deleted)\n+      Process.detach(fork { deploy(env, deleted) })","path":"templates/webhook.bin.erb","position":14,"original_position":14,"commit_id":"90da3cf74f88dd28a61a013d5efac1a4ca010c01","original_commit_id":"90da3cf74f88dd28a61a013d5efac1a4ca010c01","user":{"login":"dhollinger","id":2914211,"avatar_url":"https://avatars1.githubusercontent.com/u/2914211?v=4","gravatar_id":"","url":"https://api.github.com/users/dhollinger","html_url":"https://github.com/dhollinger","followers_url":"https://api.github.com/users/dhollinger/followers","following_url":"https://api.github.com/users/dhollinger/following{/other_user}","gists_url":"https://api.github.com/users/dhollinger/gists{/gist_id}","starred_url":"https://api.github.com/users/dhollinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhollinger/subscriptions","organizations_url":"https://api.github.com/users/dhollinger/orgs","repos_url":"https://api.github.com/users/dhollinger/repos","events_url":"https://api.github.com/users/dhollinger/events{/privacy}","received_events_url":"https://api.github.com/users/dhollinger/received_events","type":"User","site_admin":false},"body":"I removed the forking of the process inside the run_command method. Any potential API calls (like the MCO ruby client) also need to be forked or there will be issues with Gitlab/Github Webhook timeouts.","created_at":"2018-04-24T14:41:57Z","updated_at":"2018-04-24T14:41:57Z","html_url":"https://github.com/voxpupuli/puppet-r10k/pull/425#discussion_r183757898","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/pulls/425","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-r10k/pulls/comments/183757898"},"html":{"href":"https://github.com/voxpupuli/puppet-r10k/pull/425#discussion_r183757898"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-r10k/pulls/425"}},"in_reply_to_id":183726214},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-r10k/pulls/425","id":183624899,"html_url":"https://github.com/voxpupuli/puppet-r10k/pull/425","diff_url":"https://github.com/voxpupuli/puppet-r10k/pull/425.diff","patch_url":"https://github.com/voxpupuli/puppet-r10k/pull/425.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/issues/425","number":425,"state":"open","locked":false,"title":"Remove Open3 and move process forks","user":{"login":"dhollinger","id":2914211,"avatar_url":"https://avatars1.githubusercontent.com/u/2914211?v=4","gravatar_id":"","url":"https://api.github.com/users/dhollinger","html_url":"https://github.com/dhollinger","followers_url":"https://api.github.com/users/dhollinger/followers","following_url":"https://api.github.com/users/dhollinger/following{/other_user}","gists_url":"https://api.github.com/users/dhollinger/gists{/gist_id}","starred_url":"https://api.github.com/users/dhollinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhollinger/subscriptions","organizations_url":"https://api.github.com/users/dhollinger/orgs","repos_url":"https://api.github.com/users/dhollinger/repos","events_url":"https://api.github.com/users/dhollinger/events{/privacy}","received_events_url":"https://api.github.com/users/dhollinger/received_events","type":"User","site_admin":false},"body":"Due to issues with the webhook script hitting Gitlab and Github webhook\r\ntimeout limits waiting for r10k or mco to complete, the Open3 calls\r\nhave been removed entirely from the run_command method. \r\n\r\nAdditionally, to ensure that all commands/APIs run asynchronously, the Process.detach() has been\r\nmoved into the method calls in each POST endpoint.\r\n","created_at":"2018-04-24T05:32:57Z","updated_at":"2018-04-24T14:41:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bce8e1ad7fa96be992f93bad56b071632a10b0c1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bastelfreak","id":341866,"avatar_url":"https://avatars0.githubusercontent.com/u/341866?v=4","gravatar_id":"","url":"https://api.github.com/users/bastelfreak","html_url":"https://github.com/bastelfreak","followers_url":"https://api.github.com/users/bastelfreak/followers","following_url":"https://api.github.com/users/bastelfreak/following{/other_user}","gists_url":"https://api.github.com/users/bastelfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/bastelfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastelfreak/subscriptions","organizations_url":"https://api.github.com/users/bastelfreak/orgs","repos_url":"https://api.github.com/users/bastelfreak/repos","events_url":"https://api.github.com/users/bastelfreak/events{/privacy}","received_events_url":"https://api.github.com/users/bastelfreak/received_events","type":"User","site_admin":false},{"login":"binford2k","id":1392917,"avatar_url":"https://avatars0.githubusercontent.com/u/1392917?v=4","gravatar_id":"","url":"https://api.github.com/users/binford2k","html_url":"https://github.com/binford2k","followers_url":"https://api.github.com/users/binford2k/followers","following_url":"https://api.github.com/users/binford2k/following{/other_user}","gists_url":"https://api.github.com/users/binford2k/gists{/gist_id}","starred_url":"https://api.github.com/users/binford2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binford2k/subscriptions","organizations_url":"https://api.github.com/users/binford2k/orgs","repos_url":"https://api.github.com/users/binford2k/repos","events_url":"https://api.github.com/users/binford2k/events{/privacy}","received_events_url":"https://api.github.com/users/binford2k/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/pulls/425/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/pulls/425/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/issues/425/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/statuses/90da3cf74f88dd28a61a013d5efac1a4ca010c01","head":{"label":"dhollinger:webhook_async","ref":"webhook_async","sha":"90da3cf74f88dd28a61a013d5efac1a4ca010c01","user":{"login":"dhollinger","id":2914211,"avatar_url":"https://avatars1.githubusercontent.com/u/2914211?v=4","gravatar_id":"","url":"https://api.github.com/users/dhollinger","html_url":"https://github.com/dhollinger","followers_url":"https://api.github.com/users/dhollinger/followers","following_url":"https://api.github.com/users/dhollinger/following{/other_user}","gists_url":"https://api.github.com/users/dhollinger/gists{/gist_id}","starred_url":"https://api.github.com/users/dhollinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhollinger/subscriptions","organizations_url":"https://api.github.com/users/dhollinger/orgs","repos_url":"https://api.github.com/users/dhollinger/repos","events_url":"https://api.github.com/users/dhollinger/events{/privacy}","received_events_url":"https://api.github.com/users/dhollinger/received_events","type":"User","site_admin":false},"repo":{"id":80971966,"name":"puppet-r10k","full_name":"dhollinger/puppet-r10k","owner":{"login":"dhollinger","id":2914211,"avatar_url":"https://avatars1.githubusercontent.com/u/2914211?v=4","gravatar_id":"","url":"https://api.github.com/users/dhollinger","html_url":"https://github.com/dhollinger","followers_url":"https://api.github.com/users/dhollinger/followers","following_url":"https://api.github.com/users/dhollinger/following{/other_user}","gists_url":"https://api.github.com/users/dhollinger/gists{/gist_id}","starred_url":"https://api.github.com/users/dhollinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhollinger/subscriptions","organizations_url":"https://api.github.com/users/dhollinger/orgs","repos_url":"https://api.github.com/users/dhollinger/repos","events_url":"https://api.github.com/users/dhollinger/events{/privacy}","received_events_url":"https://api.github.com/users/dhollinger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhollinger/puppet-r10k","description":"Setup and configure r10k for use with git based environments in puppet","fork":true,"url":"https://api.github.com/repos/dhollinger/puppet-r10k","forks_url":"https://api.github.com/repos/dhollinger/puppet-r10k/forks","keys_url":"https://api.github.com/repos/dhollinger/puppet-r10k/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhollinger/puppet-r10k/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhollinger/puppet-r10k/teams","hooks_url":"https://api.github.com/repos/dhollinger/puppet-r10k/hooks","issue_events_url":"https://api.github.com/repos/dhollinger/puppet-r10k/issues/events{/number}","events_url":"https://api.github.com/repos/dhollinger/puppet-r10k/events","assignees_url":"https://api.github.com/repos/dhollinger/puppet-r10k/assignees{/user}","branches_url":"https://api.github.com/repos/dhollinger/puppet-r10k/branches{/branch}","tags_url":"https://api.github.com/repos/dhollinger/puppet-r10k/tags","blobs_url":"https://api.github.com/repos/dhollinger/puppet-r10k/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhollinger/puppet-r10k/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhollinger/puppet-r10k/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhollinger/puppet-r10k/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhollinger/puppet-r10k/statuses/{sha}","languages_url":"https://api.github.com/repos/dhollinger/puppet-r10k/languages","stargazers_url":"https://api.github.com/repos/dhollinger/puppet-r10k/stargazers","contributors_url":"https://api.github.com/repos/dhollinger/puppet-r10k/contributors","subscribers_url":"https://api.github.com/repos/dhollinger/puppet-r10k/subscribers","subscription_url":"https://api.github.com/repos/dhollinger/puppet-r10k/subscription","commits_url":"https://api.github.com/repos/dhollinger/puppet-r10k/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhollinger/puppet-r10k/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhollinger/puppet-r10k/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhollinger/puppet-r10k/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhollinger/puppet-r10k/contents/{+path}","compare_url":"https://api.github.com/repos/dhollinger/puppet-r10k/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhollinger/puppet-r10k/merges","archive_url":"https://api.github.com/repos/dhollinger/puppet-r10k/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhollinger/puppet-r10k/downloads","issues_url":"https://api.github.com/repos/dhollinger/puppet-r10k/issues{/number}","pulls_url":"https://api.github.com/repos/dhollinger/puppet-r10k/pulls{/number}","milestones_url":"https://api.github.com/repos/dhollinger/puppet-r10k/milestones{/number}","notifications_url":"https://api.github.com/repos/dhollinger/puppet-r10k/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhollinger/puppet-r10k/labels{/name}","releases_url":"https://api.github.com/repos/dhollinger/puppet-r10k/releases{/id}","deployments_url":"https://api.github.com/repos/dhollinger/puppet-r10k/deployments","created_at":"2017-02-05T05:47:23Z","updated_at":"2018-04-24T05:24:15Z","pushed_at":"2018-04-24T05:32:29Z","git_url":"git://github.com/dhollinger/puppet-r10k.git","ssh_url":"git@github.com:dhollinger/puppet-r10k.git","clone_url":"https://github.com/dhollinger/puppet-r10k.git","svn_url":"https://github.com/dhollinger/puppet-r10k","homepage":"https://forge.puppet.com/puppet/r10k","size":1015,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"3c477340c3b3a8328d8f1af8a0d21d60976f14b0","user":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":9922918,"name":"puppet-r10k","full_name":"voxpupuli/puppet-r10k","owner":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voxpupuli/puppet-r10k","description":"Setup and configure r10k for use with git based environments in puppet","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-r10k","forks_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-r10k/deployments","created_at":"2013-05-07T22:18:04Z","updated_at":"2018-04-19T22:51:41Z","pushed_at":"2018-04-24T05:32:58Z","git_url":"git://github.com/voxpupuli/puppet-r10k.git","ssh_url":"git@github.com:voxpupuli/puppet-r10k.git","clone_url":"https://github.com/voxpupuli/puppet-r10k.git","svn_url":"https://github.com/voxpupuli/puppet-r10k","homepage":"https://forge.puppet.com/puppet/r10k","size":1007,"stargazers_count":88,"watchers_count":88,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":147,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":147,"open_issues":26,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-r10k/pulls/425"},"html":{"href":"https://github.com/voxpupuli/puppet-r10k/pull/425"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-r10k/issues/425"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-r10k/issues/425/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-r10k/pulls/425/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-r10k/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-r10k/pulls/425/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-r10k/statuses/90da3cf74f88dd28a61a013d5efac1a4ca010c01"}},"author_association":"OWNER"}}
{"actor":{"display_login":"dhollinger"}}