{"action":"created","comment":{"url":"https://api.github.com/repos/kubic-project/salt/pulls/comments/189235214","pull_request_review_id":121376615,"id":189235214,"diff_hunk":"@@ -98,3 +98,7 @@ docker-reload-config:\n     - reload: True\n     - onchanges:\n       - file: /etc/docker/daemon.json\n+  {% for cert_tuple in certs.items() %}\n+    {% set name, _cert = cert_tuple %}\n+      - file: /etc/docker/certs.d/{{ name }}/ca.crt","path":"salt/docker/init.sls","position":6,"original_position":6,"commit_id":"b5a6432afa710a4a276fe3afd26b029edebfa882","original_commit_id":"b5a6432afa710a4a276fe3afd26b029edebfa882","user":{"login":"inercia","id":1841612,"avatar_url":"https://avatars2.githubusercontent.com/u/1841612?v=4","gravatar_id":"","url":"https://api.github.com/users/inercia","html_url":"https://github.com/inercia","followers_url":"https://api.github.com/users/inercia/followers","following_url":"https://api.github.com/users/inercia/following{/other_user}","gists_url":"https://api.github.com/users/inercia/gists{/gist_id}","starred_url":"https://api.github.com/users/inercia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inercia/subscriptions","organizations_url":"https://api.github.com/users/inercia/orgs","repos_url":"https://api.github.com/users/inercia/repos","events_url":"https://api.github.com/users/inercia/events{/privacy}","received_events_url":"https://api.github.com/users/inercia/received_events","type":"User","site_admin":false},"body":"Please make sure if that is the case and we will report it upstream to the Salt developers.","created_at":"2018-05-18T11:06:05Z","updated_at":"2018-05-18T11:06:05Z","html_url":"https://github.com/kubic-project/salt/pull/537#discussion_r189235214","pull_request_url":"https://api.github.com/repos/kubic-project/salt/pulls/537","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubic-project/salt/pulls/comments/189235214"},"html":{"href":"https://github.com/kubic-project/salt/pull/537#discussion_r189235214"},"pull_request":{"href":"https://api.github.com/repos/kubic-project/salt/pulls/537"}},"in_reply_to_id":189206888},"pull_request":{"url":"https://api.github.com/repos/kubic-project/salt/pulls/537","id":188362272,"html_url":"https://github.com/kubic-project/salt/pull/537","diff_url":"https://github.com/kubic-project/salt/pull/537.diff","patch_url":"https://github.com/kubic-project/salt/pull/537.patch","issue_url":"https://api.github.com/repos/kubic-project/salt/issues/537","number":537,"state":"open","locked":false,"title":"also reload docker when certificates change","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars0.githubusercontent.com/u/5364817?v=4","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"body":"fix#reload-certs\r\n\r\nSigned-off-by: Maximilian Meister <mmeister@suse.de>","created_at":"2018-05-16T08:58:16Z","updated_at":"2018-05-18T11:06:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76d1477c804afbc3a85ae44807ce7a005fa23dbd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ereslibre","id":8706,"avatar_url":"https://avatars2.githubusercontent.com/u/8706?v=4","gravatar_id":"","url":"https://api.github.com/users/ereslibre","html_url":"https://github.com/ereslibre","followers_url":"https://api.github.com/users/ereslibre/followers","following_url":"https://api.github.com/users/ereslibre/following{/other_user}","gists_url":"https://api.github.com/users/ereslibre/gists{/gist_id}","starred_url":"https://api.github.com/users/ereslibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ereslibre/subscriptions","organizations_url":"https://api.github.com/users/ereslibre/orgs","repos_url":"https://api.github.com/users/ereslibre/repos","events_url":"https://api.github.com/users/ereslibre/events{/privacy}","received_events_url":"https://api.github.com/users/ereslibre/received_events","type":"User","site_admin":false},{"login":"ellisab","id":1402047,"avatar_url":"https://avatars2.githubusercontent.com/u/1402047?v=4","gravatar_id":"","url":"https://api.github.com/users/ellisab","html_url":"https://github.com/ellisab","followers_url":"https://api.github.com/users/ellisab/followers","following_url":"https://api.github.com/users/ellisab/following{/other_user}","gists_url":"https://api.github.com/users/ellisab/gists{/gist_id}","starred_url":"https://api.github.com/users/ellisab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellisab/subscriptions","organizations_url":"https://api.github.com/users/ellisab/orgs","repos_url":"https://api.github.com/users/ellisab/repos","events_url":"https://api.github.com/users/ellisab/events{/privacy}","received_events_url":"https://api.github.com/users/ellisab/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":926596245,"url":"https://api.github.com/repos/kubic-project/salt/labels/release-3.0-candidate","name":"release-3.0-candidate","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubic-project/salt/pulls/537/commits","review_comments_url":"https://api.github.com/repos/kubic-project/salt/pulls/537/comments","review_comment_url":"https://api.github.com/repos/kubic-project/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubic-project/salt/issues/537/comments","statuses_url":"https://api.github.com/repos/kubic-project/salt/statuses/b5a6432afa710a4a276fe3afd26b029edebfa882","head":{"label":"MaximilianMeister:reload-certs","ref":"reload-certs","sha":"b5a6432afa710a4a276fe3afd26b029edebfa882","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars0.githubusercontent.com/u/5364817?v=4","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"repo":{"id":83651882,"name":"salt","full_name":"MaximilianMeister/salt","owner":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars0.githubusercontent.com/u/5364817?v=4","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaximilianMeister/salt","description":"A collection of salt states used to provision a kubernetes cluster","fork":true,"url":"https://api.github.com/repos/MaximilianMeister/salt","forks_url":"https://api.github.com/repos/MaximilianMeister/salt/forks","keys_url":"https://api.github.com/repos/MaximilianMeister/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaximilianMeister/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaximilianMeister/salt/teams","hooks_url":"https://api.github.com/repos/MaximilianMeister/salt/hooks","issue_events_url":"https://api.github.com/repos/MaximilianMeister/salt/issues/events{/number}","events_url":"https://api.github.com/repos/MaximilianMeister/salt/events","assignees_url":"https://api.github.com/repos/MaximilianMeister/salt/assignees{/user}","branches_url":"https://api.github.com/repos/MaximilianMeister/salt/branches{/branch}","tags_url":"https://api.github.com/repos/MaximilianMeister/salt/tags","blobs_url":"https://api.github.com/repos/MaximilianMeister/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaximilianMeister/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaximilianMeister/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaximilianMeister/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaximilianMeister/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/MaximilianMeister/salt/languages","stargazers_url":"https://api.github.com/repos/MaximilianMeister/salt/stargazers","contributors_url":"https://api.github.com/repos/MaximilianMeister/salt/contributors","subscribers_url":"https://api.github.com/repos/MaximilianMeister/salt/subscribers","subscription_url":"https://api.github.com/repos/MaximilianMeister/salt/subscription","commits_url":"https://api.github.com/repos/MaximilianMeister/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaximilianMeister/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaximilianMeister/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaximilianMeister/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaximilianMeister/salt/contents/{+path}","compare_url":"https://api.github.com/repos/MaximilianMeister/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaximilianMeister/salt/merges","archive_url":"https://api.github.com/repos/MaximilianMeister/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaximilianMeister/salt/downloads","issues_url":"https://api.github.com/repos/MaximilianMeister/salt/issues{/number}","pulls_url":"https://api.github.com/repos/MaximilianMeister/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/MaximilianMeister/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/MaximilianMeister/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaximilianMeister/salt/labels{/name}","releases_url":"https://api.github.com/repos/MaximilianMeister/salt/releases{/id}","deployments_url":"https://api.github.com/repos/MaximilianMeister/salt/deployments","created_at":"2017-03-02T08:09:35Z","updated_at":"2017-03-02T08:09:36Z","pushed_at":"2018-05-18T08:56:56Z","git_url":"git://github.com/MaximilianMeister/salt.git","ssh_url":"git@github.com:MaximilianMeister/salt.git","clone_url":"https://github.com/MaximilianMeister/salt.git","svn_url":"https://github.com/MaximilianMeister/salt","homepage":null,"size":1025,"stargazers_count":0,"watchers_count":0,"language":"SaltStack","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubic-project:master","ref":"master","sha":"4e92eac6c9f6b0c8bd6b36cc3f164cee43029e14","user":{"login":"kubic-project","id":25507587,"avatar_url":"https://avatars2.githubusercontent.com/u/25507587?v=4","gravatar_id":"","url":"https://api.github.com/users/kubic-project","html_url":"https://github.com/kubic-project","followers_url":"https://api.github.com/users/kubic-project/followers","following_url":"https://api.github.com/users/kubic-project/following{/other_user}","gists_url":"https://api.github.com/users/kubic-project/gists{/gist_id}","starred_url":"https://api.github.com/users/kubic-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubic-project/subscriptions","organizations_url":"https://api.github.com/users/kubic-project/orgs","repos_url":"https://api.github.com/users/kubic-project/repos","events_url":"https://api.github.com/users/kubic-project/events{/privacy}","received_events_url":"https://api.github.com/users/kubic-project/received_events","type":"Organization","site_admin":false},"repo":{"id":83561000,"name":"salt","full_name":"kubic-project/salt","owner":{"login":"kubic-project","id":25507587,"avatar_url":"https://avatars2.githubusercontent.com/u/25507587?v=4","gravatar_id":"","url":"https://api.github.com/users/kubic-project","html_url":"https://github.com/kubic-project","followers_url":"https://api.github.com/users/kubic-project/followers","following_url":"https://api.github.com/users/kubic-project/following{/other_user}","gists_url":"https://api.github.com/users/kubic-project/gists{/gist_id}","starred_url":"https://api.github.com/users/kubic-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubic-project/subscriptions","organizations_url":"https://api.github.com/users/kubic-project/orgs","repos_url":"https://api.github.com/users/kubic-project/repos","events_url":"https://api.github.com/users/kubic-project/events{/privacy}","received_events_url":"https://api.github.com/users/kubic-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubic-project/salt","description":"A collection of salt states used to provision a kubernetes cluster","fork":false,"url":"https://api.github.com/repos/kubic-project/salt","forks_url":"https://api.github.com/repos/kubic-project/salt/forks","keys_url":"https://api.github.com/repos/kubic-project/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubic-project/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubic-project/salt/teams","hooks_url":"https://api.github.com/repos/kubic-project/salt/hooks","issue_events_url":"https://api.github.com/repos/kubic-project/salt/issues/events{/number}","events_url":"https://api.github.com/repos/kubic-project/salt/events","assignees_url":"https://api.github.com/repos/kubic-project/salt/assignees{/user}","branches_url":"https://api.github.com/repos/kubic-project/salt/branches{/branch}","tags_url":"https://api.github.com/repos/kubic-project/salt/tags","blobs_url":"https://api.github.com/repos/kubic-project/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubic-project/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubic-project/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubic-project/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubic-project/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/kubic-project/salt/languages","stargazers_url":"https://api.github.com/repos/kubic-project/salt/stargazers","contributors_url":"https://api.github.com/repos/kubic-project/salt/contributors","subscribers_url":"https://api.github.com/repos/kubic-project/salt/subscribers","subscription_url":"https://api.github.com/repos/kubic-project/salt/subscription","commits_url":"https://api.github.com/repos/kubic-project/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubic-project/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubic-project/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubic-project/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubic-project/salt/contents/{+path}","compare_url":"https://api.github.com/repos/kubic-project/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubic-project/salt/merges","archive_url":"https://api.github.com/repos/kubic-project/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubic-project/salt/downloads","issues_url":"https://api.github.com/repos/kubic-project/salt/issues{/number}","pulls_url":"https://api.github.com/repos/kubic-project/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/kubic-project/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/kubic-project/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubic-project/salt/labels{/name}","releases_url":"https://api.github.com/repos/kubic-project/salt/releases{/id}","deployments_url":"https://api.github.com/repos/kubic-project/salt/deployments","created_at":"2017-03-01T14:04:14Z","updated_at":"2018-05-18T07:42:18Z","pushed_at":"2018-05-18T08:56:58Z","git_url":"git://github.com/kubic-project/salt.git","ssh_url":"git@github.com:kubic-project/salt.git","clone_url":"https://github.com/kubic-project/salt.git","svn_url":"https://github.com/kubic-project/salt","homepage":null,"size":2713,"stargazers_count":51,"watchers_count":51,"language":"SaltStack","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":22,"open_issues":19,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubic-project/salt/pulls/537"},"html":{"href":"https://github.com/kubic-project/salt/pull/537"},"issue":{"href":"https://api.github.com/repos/kubic-project/salt/issues/537"},"comments":{"href":"https://api.github.com/repos/kubic-project/salt/issues/537/comments"},"review_comments":{"href":"https://api.github.com/repos/kubic-project/salt/pulls/537/comments"},"review_comment":{"href":"https://api.github.com/repos/kubic-project/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubic-project/salt/pulls/537/commits"},"statuses":{"href":"https://api.github.com/repos/kubic-project/salt/statuses/b5a6432afa710a4a276fe3afd26b029edebfa882"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"inercia"}}