{"action":"created","comment":{"url":"https://api.github.com/repos/SpineEventEngine/base/pulls/comments/242901452","pull_request_review_id":186517548,"id":242901452,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjkwMTQ1Mg==","diff_hunk":"@@ -0,0 +1,34 @@\n+/*\n+ * Copyright 2018, TeamDev. All rights reserved.\n+ *\n+ * Redistribution and use in source and/or binary forms, with or without\n+ * modification, must retain the above copyright notice and the following\n+ * disclaimer.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+package io.spine.js.generate;\n+\n+/**\n+ * A snippet of the code.\n+ */\n+public interface CodeSnippet {","path":"tools/proto-js-plugin/src/main/java/io/spine/js/generate/CodeSnippet.java","position":26,"original_position":26,"commit_id":"6091d7a38ce9f33d0d1b1fbc15851d6126afe931","original_commit_id":"6091d7a38ce9f33d0d1b1fbc15851d6126afe931","user":{"login":"dmdashenkov","id":18305364,"node_id":"MDQ6VXNlcjE4MzA1MzY0","avatar_url":"https://avatars1.githubusercontent.com/u/18305364?v=4","gravatar_id":"","url":"https://api.github.com/users/dmdashenkov","html_url":"https://github.com/dmdashenkov","followers_url":"https://api.github.com/users/dmdashenkov/followers","following_url":"https://api.github.com/users/dmdashenkov/following{/other_user}","gists_url":"https://api.github.com/users/dmdashenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmdashenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmdashenkov/subscriptions","organizations_url":"https://api.github.com/users/dmdashenkov/orgs","repos_url":"https://api.github.com/users/dmdashenkov/repos","events_url":"https://api.github.com/users/dmdashenkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmdashenkov/received_events","type":"User","site_admin":false},"body":"```suggestion\r\npublic interface Snippet {\r\n```","created_at":"2018-12-19T12:41:22Z","updated_at":"2018-12-19T12:43:56Z","html_url":"https://github.com/SpineEventEngine/base/pull/255#discussion_r242901452","pull_request_url":"https://api.github.com/repos/SpineEventEngine/base/pulls/255","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/base/pulls/comments/242901452"},"html":{"href":"https://github.com/SpineEventEngine/base/pull/255#discussion_r242901452"},"pull_request":{"href":"https://api.github.com/repos/SpineEventEngine/base/pulls/255"}}},"pull_request":{"url":"https://api.github.com/repos/SpineEventEngine/base/pulls/255","id":239145466,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MTQ1NDY2","html_url":"https://github.com/SpineEventEngine/base/pull/255","diff_url":"https://github.com/SpineEventEngine/base/pull/255.diff","patch_url":"https://github.com/SpineEventEngine/base/pull/255.patch","issue_url":"https://api.github.com/repos/SpineEventEngine/base/issues/255","number":255,"state":"open","locked":false,"title":"Generate a method providing `TypeUrl` for Protobuf types compiled to JS","user":{"login":"dmytro-grankin","id":25301769,"node_id":"MDQ6VXNlcjI1MzAxNzY5","avatar_url":"https://avatars2.githubusercontent.com/u/25301769?v=4","gravatar_id":"","url":"https://api.github.com/users/dmytro-grankin","html_url":"https://github.com/dmytro-grankin","followers_url":"https://api.github.com/users/dmytro-grankin/followers","following_url":"https://api.github.com/users/dmytro-grankin/following{/other_user}","gists_url":"https://api.github.com/users/dmytro-grankin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmytro-grankin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmytro-grankin/subscriptions","organizations_url":"https://api.github.com/users/dmytro-grankin/orgs","repos_url":"https://api.github.com/users/dmytro-grankin/repos","events_url":"https://api.github.com/users/dmytro-grankin/events{/privacy}","received_events_url":"https://api.github.com/users/dmytro-grankin/received_events","type":"User","site_admin":false},"body":"A possibility to obtain a `TypeUrl` for a message is convenient, but Protobuf definitions compiled to JS don't provide such a possibility.\r\n\r\nSo, to allow convenient obtaining of `TypeUrl`, this PR enhances `ProtoJsPlugin`. The plugin now generates the static `typeUrl()` method for every message and enum type.\r\n\r\nOther changes:\r\n- The naming of classes related to JS code-generation was improved.\r\n- The package structure for `ProtoJsPlugin` was changed to keep related classes in a single package.\r\n- `JsType` was introduced as a facility to work with generated JS types.\r\n- `CodeSnippet` was introduced as a replacement of `JsCodeGenerator`. The `CodeSnippet` has no side effects as the generator does.","created_at":"2018-12-17T13:31:56Z","updated_at":"2018-12-19T12:43:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"baabbf4c38e1cbc9d45fa60a8dfcafa40b1fc8e1","assignee":{"login":"dmytro-grankin","id":25301769,"node_id":"MDQ6VXNlcjI1MzAxNzY5","avatar_url":"https://avatars2.githubusercontent.com/u/25301769?v=4","gravatar_id":"","url":"https://api.github.com/users/dmytro-grankin","html_url":"https://github.com/dmytro-grankin","followers_url":"https://api.github.com/users/dmytro-grankin/followers","following_url":"https://api.github.com/users/dmytro-grankin/following{/other_user}","gists_url":"https://api.github.com/users/dmytro-grankin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmytro-grankin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmytro-grankin/subscriptions","organizations_url":"https://api.github.com/users/dmytro-grankin/orgs","repos_url":"https://api.github.com/users/dmytro-grankin/repos","events_url":"https://api.github.com/users/dmytro-grankin/events{/privacy}","received_events_url":"https://api.github.com/users/dmytro-grankin/received_events","type":"User","site_admin":false},"assignees":[{"login":"dmytro-grankin","id":25301769,"node_id":"MDQ6VXNlcjI1MzAxNzY5","avatar_url":"https://avatars2.githubusercontent.com/u/25301769?v=4","gravatar_id":"","url":"https://api.github.com/users/dmytro-grankin","html_url":"https://github.com/dmytro-grankin","followers_url":"https://api.github.com/users/dmytro-grankin/followers","following_url":"https://api.github.com/users/dmytro-grankin/following{/other_user}","gists_url":"https://api.github.com/users/dmytro-grankin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmytro-grankin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmytro-grankin/subscriptions","organizations_url":"https://api.github.com/users/dmytro-grankin/orgs","repos_url":"https://api.github.com/users/dmytro-grankin/repos","events_url":"https://api.github.com/users/dmytro-grankin/events{/privacy}","received_events_url":"https://api.github.com/users/dmytro-grankin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpineEventEngine/base/pulls/255/commits","review_comments_url":"https://api.github.com/repos/SpineEventEngine/base/pulls/255/comments","review_comment_url":"https://api.github.com/repos/SpineEventEngine/base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpineEventEngine/base/issues/255/comments","statuses_url":"https://api.github.com/repos/SpineEventEngine/base/statuses/6091d7a38ce9f33d0d1b1fbc15851d6126afe931","head":{"label":"SpineEventEngine:generate-type-url-for-js-messages","ref":"generate-type-url-for-js-messages","sha":"6091d7a38ce9f33d0d1b1fbc15851d6126afe931","user":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":94763465,"node_id":"MDEwOlJlcG9zaXRvcnk5NDc2MzQ2NQ==","name":"base","full_name":"SpineEventEngine/base","private":false,"owner":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SpineEventEngine/base","description":"The framework's base data types, tools, and utilities","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/base","forks_url":"https://api.github.com/repos/SpineEventEngine/base/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/base/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/base/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/base/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/base/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/base/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/base/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/base/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/base/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/base/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/base/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/base/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/base/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/base/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/base/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/base/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/base/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/base/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/base/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/base/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/base/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/base/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/base/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/base/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/base/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/base/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/base/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/base/deployments","created_at":"2017-06-19T10:08:29Z","updated_at":"2018-12-13T13:25:04Z","pushed_at":"2018-12-19T10:43:14Z","git_url":"git://github.com/SpineEventEngine/base.git","ssh_url":"git@github.com:SpineEventEngine/base.git","clone_url":"https://github.com/SpineEventEngine/base.git","svn_url":"https://github.com/SpineEventEngine/base","homepage":"","size":11502,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":44,"watchers":3,"default_branch":"master"}},"base":{"label":"SpineEventEngine:master","ref":"master","sha":"79335ea6da8cc798d2b06fdf9dcebd54393eb8ef","user":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":94763465,"node_id":"MDEwOlJlcG9zaXRvcnk5NDc2MzQ2NQ==","name":"base","full_name":"SpineEventEngine/base","private":false,"owner":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SpineEventEngine/base","description":"The framework's base data types, tools, and utilities","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/base","forks_url":"https://api.github.com/repos/SpineEventEngine/base/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/base/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/base/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/base/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/base/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/base/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/base/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/base/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/base/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/base/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/base/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/base/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/base/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/base/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/base/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/base/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/base/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/base/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/base/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/base/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/base/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/base/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/base/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/base/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/base/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/base/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/base/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/base/deployments","created_at":"2017-06-19T10:08:29Z","updated_at":"2018-12-13T13:25:04Z","pushed_at":"2018-12-19T10:43:14Z","git_url":"git://github.com/SpineEventEngine/base.git","ssh_url":"git@github.com:SpineEventEngine/base.git","clone_url":"https://github.com/SpineEventEngine/base.git","svn_url":"https://github.com/SpineEventEngine/base","homepage":"","size":11502,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":44,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/base/pulls/255"},"html":{"href":"https://github.com/SpineEventEngine/base/pull/255"},"issue":{"href":"https://api.github.com/repos/SpineEventEngine/base/issues/255"},"comments":{"href":"https://api.github.com/repos/SpineEventEngine/base/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/SpineEventEngine/base/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/SpineEventEngine/base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpineEventEngine/base/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/SpineEventEngine/base/statuses/6091d7a38ce9f33d0d1b1fbc15851d6126afe931"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dmdashenkov"}}