{"action":"created","comment":{"url":"https://api.github.com/repos/INL/BlackLab/pulls/comments/178255393","pull_request_review_id":108289194,"id":178255393,"diff_hunk":"@@ -29,15 +29,20 @@\n import com.ximpleware.XPathParseException;\n \n import nl.inl.blacklab.index.Indexer;\n+import static nl.inl.blacklab.index.config.DocIndexerConfig.replaceDollarRefs;\n import nl.inl.blacklab.index.config.InlineObject.InlineObjectType;\n import nl.inl.util.ExUtil;\n import nl.inl.util.StringUtil;\n import nl.inl.util.XmlUtil;\n+import org.apache.logging.log4j.LogManager;\n+import org.apache.logging.log4j.Logger;\n \n /**\n  * An indexer configured using full XPath 1.0 expressions.\n  */\n public class DocIndexerXPath extends DocIndexerConfig {\n+    \n+    private static final Logger LOGGER = LogManager.getLogger(DocIndexerXPath.class);","path":"core/src/main/java/nl/inl/blacklab/index/config/DocIndexerXPath.java","position":17,"original_position":17,"commit_id":"2599d43f935c079a9aa7f1d53589627130566b40","original_commit_id":"2599d43f935c079a9aa7f1d53589627130566b40","user":{"login":"eduarddrenth","id":10200360,"avatar_url":"https://avatars2.githubusercontent.com/u/10200360?v=4","gravatar_id":"","url":"https://api.github.com/users/eduarddrenth","html_url":"https://github.com/eduarddrenth","followers_url":"https://api.github.com/users/eduarddrenth/followers","following_url":"https://api.github.com/users/eduarddrenth/following{/other_user}","gists_url":"https://api.github.com/users/eduarddrenth/gists{/gist_id}","starred_url":"https://api.github.com/users/eduarddrenth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduarddrenth/subscriptions","organizations_url":"https://api.github.com/users/eduarddrenth/orgs","repos_url":"https://api.github.com/users/eduarddrenth/repos","events_url":"https://api.github.com/users/eduarddrenth/events{/privacy}","received_events_url":"https://api.github.com/users/eduarddrenth/received_events","type":"User","site_admin":false},"body":"fine","created_at":"2018-03-30T08:39:29Z","updated_at":"2018-03-30T08:39:29Z","html_url":"https://github.com/INL/BlackLab/pull/56#discussion_r178255393","pull_request_url":"https://api.github.com/repos/INL/BlackLab/pulls/56","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/INL/BlackLab/pulls/comments/178255393"},"html":{"href":"https://github.com/INL/BlackLab/pull/56#discussion_r178255393"},"pull_request":{"href":"https://api.github.com/repos/INL/BlackLab/pulls/56"}},"in_reply_to_id":178251023},"pull_request":{"url":"https://api.github.com/repos/INL/BlackLab/pulls/56","id":176793691,"html_url":"https://github.com/INL/BlackLab/pull/56","diff_url":"https://github.com/INL/BlackLab/pull/56.diff","patch_url":"https://github.com/INL/BlackLab/pull/56.patch","issue_url":"https://api.github.com/repos/INL/BlackLab/issues/56","number":56,"state":"open","locked":false,"title":"fix autocomplete and captureValuePaths #57","user":{"login":"eduarddrenth","id":10200360,"avatar_url":"https://avatars2.githubusercontent.com/u/10200360?v=4","gravatar_id":"","url":"https://api.github.com/users/eduarddrenth","html_url":"https://github.com/eduarddrenth","followers_url":"https://api.github.com/users/eduarddrenth/followers","following_url":"https://api.github.com/users/eduarddrenth/following{/other_user}","gists_url":"https://api.github.com/users/eduarddrenth/gists{/gist_id}","starred_url":"https://api.github.com/users/eduarddrenth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduarddrenth/subscriptions","organizations_url":"https://api.github.com/users/eduarddrenth/orgs","repos_url":"https://api.github.com/users/eduarddrenth/repos","events_url":"https://api.github.com/users/eduarddrenth/events{/privacy}","received_events_url":"https://api.github.com/users/eduarddrenth/received_events","type":"User","site_admin":false},"body":"fix #55: now autocomplete realy does what it should\r\nalso fix #57 and with that makes a solution possible for #46 ","created_at":"2018-03-22T14:20:55Z","updated_at":"2018-03-30T08:39:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc834073dd0bd45c4b01d702c28e30d1245b86a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/INL/BlackLab/pulls/56/commits","review_comments_url":"https://api.github.com/repos/INL/BlackLab/pulls/56/comments","review_comment_url":"https://api.github.com/repos/INL/BlackLab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/INL/BlackLab/issues/56/comments","statuses_url":"https://api.github.com/repos/INL/BlackLab/statuses/2599d43f935c079a9aa7f1d53589627130566b40","head":{"label":"fryske-akademy:dev","ref":"dev","sha":"2599d43f935c079a9aa7f1d53589627130566b40","user":{"login":"fryske-akademy","id":37328147,"avatar_url":"https://avatars1.githubusercontent.com/u/37328147?v=4","gravatar_id":"","url":"https://api.github.com/users/fryske-akademy","html_url":"https://github.com/fryske-akademy","followers_url":"https://api.github.com/users/fryske-akademy/followers","following_url":"https://api.github.com/users/fryske-akademy/following{/other_user}","gists_url":"https://api.github.com/users/fryske-akademy/gists{/gist_id}","starred_url":"https://api.github.com/users/fryske-akademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fryske-akademy/subscriptions","organizations_url":"https://api.github.com/users/fryske-akademy/orgs","repos_url":"https://api.github.com/users/fryske-akademy/repos","events_url":"https://api.github.com/users/fryske-akademy/events{/privacy}","received_events_url":"https://api.github.com/users/fryske-akademy/received_events","type":"Organization","site_admin":false},"repo":{"id":125197254,"name":"BlackLab","full_name":"fryske-akademy/BlackLab","owner":{"login":"fryske-akademy","id":37328147,"avatar_url":"https://avatars1.githubusercontent.com/u/37328147?v=4","gravatar_id":"","url":"https://api.github.com/users/fryske-akademy","html_url":"https://github.com/fryske-akademy","followers_url":"https://api.github.com/users/fryske-akademy/followers","following_url":"https://api.github.com/users/fryske-akademy/following{/other_user}","gists_url":"https://api.github.com/users/fryske-akademy/gists{/gist_id}","starred_url":"https://api.github.com/users/fryske-akademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fryske-akademy/subscriptions","organizations_url":"https://api.github.com/users/fryske-akademy/orgs","repos_url":"https://api.github.com/users/fryske-akademy/repos","events_url":"https://api.github.com/users/fryske-akademy/events{/privacy}","received_events_url":"https://api.github.com/users/fryske-akademy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fryske-akademy/BlackLab","description":"A corpus retrieval engine based on Apache Lucene","fork":true,"url":"https://api.github.com/repos/fryske-akademy/BlackLab","forks_url":"https://api.github.com/repos/fryske-akademy/BlackLab/forks","keys_url":"https://api.github.com/repos/fryske-akademy/BlackLab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fryske-akademy/BlackLab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fryske-akademy/BlackLab/teams","hooks_url":"https://api.github.com/repos/fryske-akademy/BlackLab/hooks","issue_events_url":"https://api.github.com/repos/fryske-akademy/BlackLab/issues/events{/number}","events_url":"https://api.github.com/repos/fryske-akademy/BlackLab/events","assignees_url":"https://api.github.com/repos/fryske-akademy/BlackLab/assignees{/user}","branches_url":"https://api.github.com/repos/fryske-akademy/BlackLab/branches{/branch}","tags_url":"https://api.github.com/repos/fryske-akademy/BlackLab/tags","blobs_url":"https://api.github.com/repos/fryske-akademy/BlackLab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fryske-akademy/BlackLab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fryske-akademy/BlackLab/git/refs{/sha}","trees_url":"https://api.github.com/repos/fryske-akademy/BlackLab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fryske-akademy/BlackLab/statuses/{sha}","languages_url":"https://api.github.com/repos/fryske-akademy/BlackLab/languages","stargazers_url":"https://api.github.com/repos/fryske-akademy/BlackLab/stargazers","contributors_url":"https://api.github.com/repos/fryske-akademy/BlackLab/contributors","subscribers_url":"https://api.github.com/repos/fryske-akademy/BlackLab/subscribers","subscription_url":"https://api.github.com/repos/fryske-akademy/BlackLab/subscription","commits_url":"https://api.github.com/repos/fryske-akademy/BlackLab/commits{/sha}","git_commits_url":"https://api.github.com/repos/fryske-akademy/BlackLab/git/commits{/sha}","comments_url":"https://api.github.com/repos/fryske-akademy/BlackLab/comments{/number}","issue_comment_url":"https://api.github.com/repos/fryske-akademy/BlackLab/issues/comments{/number}","contents_url":"https://api.github.com/repos/fryske-akademy/BlackLab/contents/{+path}","compare_url":"https://api.github.com/repos/fryske-akademy/BlackLab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fryske-akademy/BlackLab/merges","archive_url":"https://api.github.com/repos/fryske-akademy/BlackLab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fryske-akademy/BlackLab/downloads","issues_url":"https://api.github.com/repos/fryske-akademy/BlackLab/issues{/number}","pulls_url":"https://api.github.com/repos/fryske-akademy/BlackLab/pulls{/number}","milestones_url":"https://api.github.com/repos/fryske-akademy/BlackLab/milestones{/number}","notifications_url":"https://api.github.com/repos/fryske-akademy/BlackLab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fryske-akademy/BlackLab/labels{/name}","releases_url":"https://api.github.com/repos/fryske-akademy/BlackLab/releases{/id}","deployments_url":"https://api.github.com/repos/fryske-akademy/BlackLab/deployments","created_at":"2018-03-14T10:43:34Z","updated_at":"2018-03-14T10:43:38Z","pushed_at":"2018-03-28T12:25:59Z","git_url":"git://github.com/fryske-akademy/BlackLab.git","ssh_url":"git@github.com:fryske-akademy/BlackLab.git","clone_url":"https://github.com/fryske-akademy/BlackLab.git","svn_url":"https://github.com/fryske-akademy/BlackLab","homepage":"http://inl.github.io/BlackLab/","size":31183,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"INL:dev","ref":"dev","sha":"a440d114be2ea75dcfad60287299109bf17b25b0","user":{"login":"INL","id":2195496,"avatar_url":"https://avatars0.githubusercontent.com/u/2195496?v=4","gravatar_id":"","url":"https://api.github.com/users/INL","html_url":"https://github.com/INL","followers_url":"https://api.github.com/users/INL/followers","following_url":"https://api.github.com/users/INL/following{/other_user}","gists_url":"https://api.github.com/users/INL/gists{/gist_id}","starred_url":"https://api.github.com/users/INL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INL/subscriptions","organizations_url":"https://api.github.com/users/INL/orgs","repos_url":"https://api.github.com/users/INL/repos","events_url":"https://api.github.com/users/INL/events{/privacy}","received_events_url":"https://api.github.com/users/INL/received_events","type":"Organization","site_admin":false},"repo":{"id":6074181,"name":"BlackLab","full_name":"INL/BlackLab","owner":{"login":"INL","id":2195496,"avatar_url":"https://avatars0.githubusercontent.com/u/2195496?v=4","gravatar_id":"","url":"https://api.github.com/users/INL","html_url":"https://github.com/INL","followers_url":"https://api.github.com/users/INL/followers","following_url":"https://api.github.com/users/INL/following{/other_user}","gists_url":"https://api.github.com/users/INL/gists{/gist_id}","starred_url":"https://api.github.com/users/INL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INL/subscriptions","organizations_url":"https://api.github.com/users/INL/orgs","repos_url":"https://api.github.com/users/INL/repos","events_url":"https://api.github.com/users/INL/events{/privacy}","received_events_url":"https://api.github.com/users/INL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/INL/BlackLab","description":"A corpus retrieval engine based on Apache Lucene","fork":false,"url":"https://api.github.com/repos/INL/BlackLab","forks_url":"https://api.github.com/repos/INL/BlackLab/forks","keys_url":"https://api.github.com/repos/INL/BlackLab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/INL/BlackLab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/INL/BlackLab/teams","hooks_url":"https://api.github.com/repos/INL/BlackLab/hooks","issue_events_url":"https://api.github.com/repos/INL/BlackLab/issues/events{/number}","events_url":"https://api.github.com/repos/INL/BlackLab/events","assignees_url":"https://api.github.com/repos/INL/BlackLab/assignees{/user}","branches_url":"https://api.github.com/repos/INL/BlackLab/branches{/branch}","tags_url":"https://api.github.com/repos/INL/BlackLab/tags","blobs_url":"https://api.github.com/repos/INL/BlackLab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/INL/BlackLab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/INL/BlackLab/git/refs{/sha}","trees_url":"https://api.github.com/repos/INL/BlackLab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/INL/BlackLab/statuses/{sha}","languages_url":"https://api.github.com/repos/INL/BlackLab/languages","stargazers_url":"https://api.github.com/repos/INL/BlackLab/stargazers","contributors_url":"https://api.github.com/repos/INL/BlackLab/contributors","subscribers_url":"https://api.github.com/repos/INL/BlackLab/subscribers","subscription_url":"https://api.github.com/repos/INL/BlackLab/subscription","commits_url":"https://api.github.com/repos/INL/BlackLab/commits{/sha}","git_commits_url":"https://api.github.com/repos/INL/BlackLab/git/commits{/sha}","comments_url":"https://api.github.com/repos/INL/BlackLab/comments{/number}","issue_comment_url":"https://api.github.com/repos/INL/BlackLab/issues/comments{/number}","contents_url":"https://api.github.com/repos/INL/BlackLab/contents/{+path}","compare_url":"https://api.github.com/repos/INL/BlackLab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/INL/BlackLab/merges","archive_url":"https://api.github.com/repos/INL/BlackLab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/INL/BlackLab/downloads","issues_url":"https://api.github.com/repos/INL/BlackLab/issues{/number}","pulls_url":"https://api.github.com/repos/INL/BlackLab/pulls{/number}","milestones_url":"https://api.github.com/repos/INL/BlackLab/milestones{/number}","notifications_url":"https://api.github.com/repos/INL/BlackLab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/INL/BlackLab/labels{/name}","releases_url":"https://api.github.com/repos/INL/BlackLab/releases{/id}","deployments_url":"https://api.github.com/repos/INL/BlackLab/deployments","created_at":"2012-10-04T10:59:42Z","updated_at":"2018-03-17T18:01:59Z","pushed_at":"2018-03-28T08:32:47Z","git_url":"git://github.com/INL/BlackLab.git","ssh_url":"git@github.com:INL/BlackLab.git","clone_url":"https://github.com/INL/BlackLab.git","svn_url":"https://github.com/INL/BlackLab","homepage":"http://inl.github.io/BlackLab/","size":31107,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":35,"open_issues":12,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/INL/BlackLab/pulls/56"},"html":{"href":"https://github.com/INL/BlackLab/pull/56"},"issue":{"href":"https://api.github.com/repos/INL/BlackLab/issues/56"},"comments":{"href":"https://api.github.com/repos/INL/BlackLab/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/INL/BlackLab/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/INL/BlackLab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/INL/BlackLab/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/INL/BlackLab/statuses/2599d43f935c079a9aa7f1d53589627130566b40"}},"author_association":"NONE"}}
{"actor":{"display_login":"eduarddrenth"}}