{"action":"created","comment":{"url":"https://api.github.com/repos/ocadotechnology/bbq/pulls/comments/226305435","pull_request_review_id":166094090,"id":226305435,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjMwNTQzNQ==","diff_hunk":"@@ -14,13 +14,19 @@ def get(self):\n \n     @staticmethod\n     def create_slo_recalculation_tasks():\n-        return [\n+        tasks = [\n+          Tasks.create(method='POST',\n+                       url='/sli/latency_for_x_days',\n+                       params={'x_days': x_days})\n+          for x_days in [0, 3, 4, 5, 7]\n+        ]\n+        tasks.append(\n             Tasks.create(\n                 method='POST',\n-                url='/sli/latency_for_x_days',\n-                params={'x_days': x_days})\n-            for x_days in [0, 3, 4, 5, 7]\n-        ]\n+                url='/sli/quality',\n+                params={}))","path":"src/slo/sli_handlers.py","position":19,"original_position":19,"commit_id":"c54279f22d60e80bf6f64beb016fe0e0838038fb","original_commit_id":"c54279f22d60e80bf6f64beb016fe0e0838038fb","user":{"login":"jarekdrabek","id":8550104,"node_id":"MDQ6VXNlcjg1NTAxMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8550104?v=4","gravatar_id":"","url":"https://api.github.com/users/jarekdrabek","html_url":"https://github.com/jarekdrabek","followers_url":"https://api.github.com/users/jarekdrabek/followers","following_url":"https://api.github.com/users/jarekdrabek/following{/other_user}","gists_url":"https://api.github.com/users/jarekdrabek/gists{/gist_id}","starred_url":"https://api.github.com/users/jarekdrabek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarekdrabek/subscriptions","organizations_url":"https://api.github.com/users/jarekdrabek/orgs","repos_url":"https://api.github.com/users/jarekdrabek/repos","events_url":"https://api.github.com/users/jarekdrabek/events{/privacy}","received_events_url":"https://api.github.com/users/jarekdrabek/received_events","type":"User","site_admin":false},"body":"I believe, you don't need to provide params if its empty","created_at":"2018-10-18T13:33:01Z","updated_at":"2018-10-18T13:33:01Z","html_url":"https://github.com/ocadotechnology/bbq/pull/82#discussion_r226305435","pull_request_url":"https://api.github.com/repos/ocadotechnology/bbq/pulls/82","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ocadotechnology/bbq/pulls/comments/226305435"},"html":{"href":"https://github.com/ocadotechnology/bbq/pull/82#discussion_r226305435"},"pull_request":{"href":"https://api.github.com/repos/ocadotechnology/bbq/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/ocadotechnology/bbq/pulls/82","id":223889297,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzODg5Mjk3","html_url":"https://github.com/ocadotechnology/bbq/pull/82","diff_url":"https://github.com/ocadotechnology/bbq/pull/82.diff","patch_url":"https://github.com/ocadotechnology/bbq/pull/82.patch","issue_url":"https://api.github.com/repos/ocadotechnology/bbq/issues/82","number":82,"state":"open","locked":false,"title":"YACHT-1054: Introducing filtering for tables which are modified till …","user":{"login":"radkomateusz","id":3711948,"node_id":"MDQ6VXNlcjM3MTE5NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/3711948?v=4","gravatar_id":"","url":"https://api.github.com/users/radkomateusz","html_url":"https://github.com/radkomateusz","followers_url":"https://api.github.com/users/radkomateusz/followers","following_url":"https://api.github.com/users/radkomateusz/following{/other_user}","gists_url":"https://api.github.com/users/radkomateusz/gists{/gist_id}","starred_url":"https://api.github.com/users/radkomateusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radkomateusz/subscriptions","organizations_url":"https://api.github.com/users/radkomateusz/orgs","repos_url":"https://api.github.com/users/radkomateusz/repos","events_url":"https://api.github.com/users/radkomateusz/events{/privacy}","received_events_url":"https://api.github.com/users/radkomateusz/received_events","type":"User","site_admin":false},"body":"…last census snapshot. Saving Backup Quality SLI history.","created_at":"2018-10-18T09:42:49Z","updated_at":"2018-10-18T13:33:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b144545a4309f464acb64369fbd70a127875e9d4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"marcin-kolda","id":1093772,"node_id":"MDQ6VXNlcjEwOTM3NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1093772?v=4","gravatar_id":"","url":"https://api.github.com/users/marcin-kolda","html_url":"https://github.com/marcin-kolda","followers_url":"https://api.github.com/users/marcin-kolda/followers","following_url":"https://api.github.com/users/marcin-kolda/following{/other_user}","gists_url":"https://api.github.com/users/marcin-kolda/gists{/gist_id}","starred_url":"https://api.github.com/users/marcin-kolda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcin-kolda/subscriptions","organizations_url":"https://api.github.com/users/marcin-kolda/orgs","repos_url":"https://api.github.com/users/marcin-kolda/repos","events_url":"https://api.github.com/users/marcin-kolda/events{/privacy}","received_events_url":"https://api.github.com/users/marcin-kolda/received_events","type":"User","site_admin":false},{"login":"MZatorski","id":22035565,"node_id":"MDQ6VXNlcjIyMDM1NTY1","avatar_url":"https://avatars1.githubusercontent.com/u/22035565?v=4","gravatar_id":"","url":"https://api.github.com/users/MZatorski","html_url":"https://github.com/MZatorski","followers_url":"https://api.github.com/users/MZatorski/followers","following_url":"https://api.github.com/users/MZatorski/following{/other_user}","gists_url":"https://api.github.com/users/MZatorski/gists{/gist_id}","starred_url":"https://api.github.com/users/MZatorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MZatorski/subscriptions","organizations_url":"https://api.github.com/users/MZatorski/orgs","repos_url":"https://api.github.com/users/MZatorski/repos","events_url":"https://api.github.com/users/MZatorski/events{/privacy}","received_events_url":"https://api.github.com/users/MZatorski/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocadotechnology/bbq/pulls/82/commits","review_comments_url":"https://api.github.com/repos/ocadotechnology/bbq/pulls/82/comments","review_comment_url":"https://api.github.com/repos/ocadotechnology/bbq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocadotechnology/bbq/issues/82/comments","statuses_url":"https://api.github.com/repos/ocadotechnology/bbq/statuses/c54279f22d60e80bf6f64beb016fe0e0838038fb","head":{"label":"ocadotechnology:YACHT-1054","ref":"YACHT-1054","sha":"c54279f22d60e80bf6f64beb016fe0e0838038fb","user":{"login":"ocadotechnology","id":2088731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODg3MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/2088731?v=4","gravatar_id":"","url":"https://api.github.com/users/ocadotechnology","html_url":"https://github.com/ocadotechnology","followers_url":"https://api.github.com/users/ocadotechnology/followers","following_url":"https://api.github.com/users/ocadotechnology/following{/other_user}","gists_url":"https://api.github.com/users/ocadotechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/ocadotechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocadotechnology/subscriptions","organizations_url":"https://api.github.com/users/ocadotechnology/orgs","repos_url":"https://api.github.com/users/ocadotechnology/repos","events_url":"https://api.github.com/users/ocadotechnology/events{/privacy}","received_events_url":"https://api.github.com/users/ocadotechnology/received_events","type":"Organization","site_admin":false},"repo":{"id":131827490,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE4Mjc0OTA=","name":"bbq","full_name":"ocadotechnology/bbq","private":false,"owner":{"login":"ocadotechnology","id":2088731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODg3MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/2088731?v=4","gravatar_id":"","url":"https://api.github.com/users/ocadotechnology","html_url":"https://github.com/ocadotechnology","followers_url":"https://api.github.com/users/ocadotechnology/followers","following_url":"https://api.github.com/users/ocadotechnology/following{/other_user}","gists_url":"https://api.github.com/users/ocadotechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/ocadotechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocadotechnology/subscriptions","organizations_url":"https://api.github.com/users/ocadotechnology/orgs","repos_url":"https://api.github.com/users/ocadotechnology/repos","events_url":"https://api.github.com/users/ocadotechnology/events{/privacy}","received_events_url":"https://api.github.com/users/ocadotechnology/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ocadotechnology/bbq","description":"Create backups of BigQuery datasets/tables","fork":false,"url":"https://api.github.com/repos/ocadotechnology/bbq","forks_url":"https://api.github.com/repos/ocadotechnology/bbq/forks","keys_url":"https://api.github.com/repos/ocadotechnology/bbq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocadotechnology/bbq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocadotechnology/bbq/teams","hooks_url":"https://api.github.com/repos/ocadotechnology/bbq/hooks","issue_events_url":"https://api.github.com/repos/ocadotechnology/bbq/issues/events{/number}","events_url":"https://api.github.com/repos/ocadotechnology/bbq/events","assignees_url":"https://api.github.com/repos/ocadotechnology/bbq/assignees{/user}","branches_url":"https://api.github.com/repos/ocadotechnology/bbq/branches{/branch}","tags_url":"https://api.github.com/repos/ocadotechnology/bbq/tags","blobs_url":"https://api.github.com/repos/ocadotechnology/bbq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocadotechnology/bbq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocadotechnology/bbq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocadotechnology/bbq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocadotechnology/bbq/statuses/{sha}","languages_url":"https://api.github.com/repos/ocadotechnology/bbq/languages","stargazers_url":"https://api.github.com/repos/ocadotechnology/bbq/stargazers","contributors_url":"https://api.github.com/repos/ocadotechnology/bbq/contributors","subscribers_url":"https://api.github.com/repos/ocadotechnology/bbq/subscribers","subscription_url":"https://api.github.com/repos/ocadotechnology/bbq/subscription","commits_url":"https://api.github.com/repos/ocadotechnology/bbq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocadotechnology/bbq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocadotechnology/bbq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocadotechnology/bbq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocadotechnology/bbq/contents/{+path}","compare_url":"https://api.github.com/repos/ocadotechnology/bbq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocadotechnology/bbq/merges","archive_url":"https://api.github.com/repos/ocadotechnology/bbq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocadotechnology/bbq/downloads","issues_url":"https://api.github.com/repos/ocadotechnology/bbq/issues{/number}","pulls_url":"https://api.github.com/repos/ocadotechnology/bbq/pulls{/number}","milestones_url":"https://api.github.com/repos/ocadotechnology/bbq/milestones{/number}","notifications_url":"https://api.github.com/repos/ocadotechnology/bbq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocadotechnology/bbq/labels{/name}","releases_url":"https://api.github.com/repos/ocadotechnology/bbq/releases{/id}","deployments_url":"https://api.github.com/repos/ocadotechnology/bbq/deployments","created_at":"2018-05-02T09:20:18Z","updated_at":"2018-10-17T13:03:10Z","pushed_at":"2018-10-18T09:56:19Z","git_url":"git://github.com/ocadotechnology/bbq.git","ssh_url":"git@github.com:ocadotechnology/bbq.git","clone_url":"https://github.com/ocadotechnology/bbq.git","svn_url":"https://github.com/ocadotechnology/bbq","homepage":null,"size":2030,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"ocadotechnology:master","ref":"master","sha":"94bdc70fd79f3a507f889fbd98ae12189be3e281","user":{"login":"ocadotechnology","id":2088731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODg3MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/2088731?v=4","gravatar_id":"","url":"https://api.github.com/users/ocadotechnology","html_url":"https://github.com/ocadotechnology","followers_url":"https://api.github.com/users/ocadotechnology/followers","following_url":"https://api.github.com/users/ocadotechnology/following{/other_user}","gists_url":"https://api.github.com/users/ocadotechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/ocadotechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocadotechnology/subscriptions","organizations_url":"https://api.github.com/users/ocadotechnology/orgs","repos_url":"https://api.github.com/users/ocadotechnology/repos","events_url":"https://api.github.com/users/ocadotechnology/events{/privacy}","received_events_url":"https://api.github.com/users/ocadotechnology/received_events","type":"Organization","site_admin":false},"repo":{"id":131827490,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE4Mjc0OTA=","name":"bbq","full_name":"ocadotechnology/bbq","private":false,"owner":{"login":"ocadotechnology","id":2088731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODg3MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/2088731?v=4","gravatar_id":"","url":"https://api.github.com/users/ocadotechnology","html_url":"https://github.com/ocadotechnology","followers_url":"https://api.github.com/users/ocadotechnology/followers","following_url":"https://api.github.com/users/ocadotechnology/following{/other_user}","gists_url":"https://api.github.com/users/ocadotechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/ocadotechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocadotechnology/subscriptions","organizations_url":"https://api.github.com/users/ocadotechnology/orgs","repos_url":"https://api.github.com/users/ocadotechnology/repos","events_url":"https://api.github.com/users/ocadotechnology/events{/privacy}","received_events_url":"https://api.github.com/users/ocadotechnology/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ocadotechnology/bbq","description":"Create backups of BigQuery datasets/tables","fork":false,"url":"https://api.github.com/repos/ocadotechnology/bbq","forks_url":"https://api.github.com/repos/ocadotechnology/bbq/forks","keys_url":"https://api.github.com/repos/ocadotechnology/bbq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocadotechnology/bbq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocadotechnology/bbq/teams","hooks_url":"https://api.github.com/repos/ocadotechnology/bbq/hooks","issue_events_url":"https://api.github.com/repos/ocadotechnology/bbq/issues/events{/number}","events_url":"https://api.github.com/repos/ocadotechnology/bbq/events","assignees_url":"https://api.github.com/repos/ocadotechnology/bbq/assignees{/user}","branches_url":"https://api.github.com/repos/ocadotechnology/bbq/branches{/branch}","tags_url":"https://api.github.com/repos/ocadotechnology/bbq/tags","blobs_url":"https://api.github.com/repos/ocadotechnology/bbq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocadotechnology/bbq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocadotechnology/bbq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocadotechnology/bbq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocadotechnology/bbq/statuses/{sha}","languages_url":"https://api.github.com/repos/ocadotechnology/bbq/languages","stargazers_url":"https://api.github.com/repos/ocadotechnology/bbq/stargazers","contributors_url":"https://api.github.com/repos/ocadotechnology/bbq/contributors","subscribers_url":"https://api.github.com/repos/ocadotechnology/bbq/subscribers","subscription_url":"https://api.github.com/repos/ocadotechnology/bbq/subscription","commits_url":"https://api.github.com/repos/ocadotechnology/bbq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocadotechnology/bbq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocadotechnology/bbq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocadotechnology/bbq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocadotechnology/bbq/contents/{+path}","compare_url":"https://api.github.com/repos/ocadotechnology/bbq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocadotechnology/bbq/merges","archive_url":"https://api.github.com/repos/ocadotechnology/bbq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocadotechnology/bbq/downloads","issues_url":"https://api.github.com/repos/ocadotechnology/bbq/issues{/number}","pulls_url":"https://api.github.com/repos/ocadotechnology/bbq/pulls{/number}","milestones_url":"https://api.github.com/repos/ocadotechnology/bbq/milestones{/number}","notifications_url":"https://api.github.com/repos/ocadotechnology/bbq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocadotechnology/bbq/labels{/name}","releases_url":"https://api.github.com/repos/ocadotechnology/bbq/releases{/id}","deployments_url":"https://api.github.com/repos/ocadotechnology/bbq/deployments","created_at":"2018-05-02T09:20:18Z","updated_at":"2018-10-17T13:03:10Z","pushed_at":"2018-10-18T09:56:19Z","git_url":"git://github.com/ocadotechnology/bbq.git","ssh_url":"git@github.com:ocadotechnology/bbq.git","clone_url":"https://github.com/ocadotechnology/bbq.git","svn_url":"https://github.com/ocadotechnology/bbq","homepage":null,"size":2030,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocadotechnology/bbq/pulls/82"},"html":{"href":"https://github.com/ocadotechnology/bbq/pull/82"},"issue":{"href":"https://api.github.com/repos/ocadotechnology/bbq/issues/82"},"comments":{"href":"https://api.github.com/repos/ocadotechnology/bbq/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/ocadotechnology/bbq/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/ocadotechnology/bbq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocadotechnology/bbq/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/ocadotechnology/bbq/statuses/c54279f22d60e80bf6f64beb016fe0e0838038fb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jarekdrabek"}}