{"action":"created","issue":{"url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/724","repository_url":"https://api.github.com/repos/cta-observatory/ctapipe","labels_url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/724/labels{/name}","comments_url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/724/comments","events_url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/724/events","html_url":"https://github.com/cta-observatory/ctapipe/pull/724","id":317387763,"number":724,"title":"add script to execute all the ipynbs in the examples/notebooks folder","user":{"login":"dneise","id":8200858,"avatar_url":"https://avatars2.githubusercontent.com/u/8200858?v=4","gravatar_id":"","url":"https://api.github.com/users/dneise","html_url":"https://github.com/dneise","followers_url":"https://api.github.com/users/dneise/followers","following_url":"https://api.github.com/users/dneise/following{/other_user}","gists_url":"https://api.github.com/users/dneise/gists{/gist_id}","starred_url":"https://api.github.com/users/dneise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneise/subscriptions","organizations_url":"https://api.github.com/users/dneise/orgs","repos_url":"https://api.github.com/users/dneise/repos","events_url":"https://api.github.com/users/dneise/events{/privacy}","received_events_url":"https://api.github.com/users/dneise/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-04-24T20:43:27Z","updated_at":"2018-04-25T11:10:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cta-observatory/ctapipe/pulls/724","html_url":"https://github.com/cta-observatory/ctapipe/pull/724","diff_url":"https://github.com/cta-observatory/ctapipe/pull/724.diff","patch_url":"https://github.com/cta-observatory/ctapipe/pull/724.patch"},"body":"reading the discussion in #716 made me want to test our jupyter notebooks.\r\n\r\nIn this PR I make a first proposal, I do not like it myself too much, but I thought maybe this sparks a discussion. \r\n\r\nWhat I propose to do is, convert the ipynb files to python scripts and then simply execute them and see if the return value is zero or not.\r\n\r\nIn this first version I swallow all the stderr and stdout, since all of the scripts are very verbose. And I saw no nice way to get some overview. \r\n\r\nI assume one could still catch the stderr and in case the return value is not zero, I could still try to find the last traceback and print it ...\r\n\r\nThe main problem is, `%matplotlib inline`, which is not working in a ipython session. So all our ipynbs which to `%matplotlib inline` fail this test of mine, even when they are perfectly valid.\r\n\r\n----\r\n\r\nA much better alternative might be this:  https://github.com/zonca/pytest-ipynb\r\nbut it needs us to rewrite our notebooks a little... \r\n\r\nAnyway I'm curious what you think?"},"comment":{"url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/comments/384250253","html_url":"https://github.com/cta-observatory/ctapipe/pull/724#issuecomment-384250253","issue_url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/724","id":384250253,"user":{"login":"kosack","id":11677812,"avatar_url":"https://avatars2.githubusercontent.com/u/11677812?v=4","gravatar_id":"","url":"https://api.github.com/users/kosack","html_url":"https://github.com/kosack","followers_url":"https://api.github.com/users/kosack/followers","following_url":"https://api.github.com/users/kosack/following{/other_user}","gists_url":"https://api.github.com/users/kosack/gists{/gist_id}","starred_url":"https://api.github.com/users/kosack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kosack/subscriptions","organizations_url":"https://api.github.com/users/kosack/orgs","repos_url":"https://api.github.com/users/kosack/repos","events_url":"https://api.github.com/users/kosack/events{/privacy}","received_events_url":"https://api.github.com/users/kosack/received_events","type":"User","site_admin":false},"created_at":"2018-04-25T11:10:52Z","updated_at":"2018-04-25T11:10:52Z","author_association":"CONTRIBUTOR","body":"> I have no idea what codacy is whining about again ...\r\n\r\nIt thinks ctapipe is a python2.7 project, so always complains about syntax with error 999... I can't find anywhere in their docs where you can set the python version, except one place where you set it for pyflakes, and I did that, but nothing changed. \r\n\r\n So far, I've been disappointed in landscape.io (constantly failed to process pull requests), and codacy is better but has these problems.   ANyhow, this PR looks fine"}}
{"actor":{"display_login":"kosack"}}