{"action":"created","comment":{"url":"https://api.github.com/repos/curoverse/arvados-workbench2/pulls/comments/209156097","pull_request_review_id":145116470,"id":209156097,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTE1NjA5Nw==","diff_hunk":"@@ -43,48 +60,62 @@ interface DataExplorerDataProps<T> {\n     extractKey?: (item: T) => React.Key;\n }\n \n-type DataExplorerProps<T> = DataExplorerDataProps<T> & WithStyles<CssRules>;\n+type DataExplorerProps<T> = DataExplorerDataProps<T> & DataExplorerActionProps<T> & WithStyles<CssRules>;\n \n export const DataExplorer = withStyles(styles)(\n     class DataExplorerGeneric<T> extends React.Component<DataExplorerProps<T>> {\n         render() {\n-            return <Paper>\n-                <Toolbar className={this.props.classes.toolbar}>\n-                    <Grid container justify=\"space-between\" wrap=\"nowrap\" alignItems=\"center\">\n-                        <div className={this.props.classes.searchBox}>\n-                            <SearchInput\n-                                value={this.props.searchValue}\n-                                onSearch={this.props.onSearch}/>\n-                        </div>\n-                        <ColumnSelector\n-                            columns={this.props.columns}\n-                            onColumnToggle={this.props.onColumnToggle}/>\n-                    </Grid>\n-                </Toolbar>\n-                <DataTable\n-                    columns={[...this.props.columns, this.contextMenuColumn]}\n-                    items={this.props.items}\n-                    onRowClick={(_, item: T) => this.props.onRowClick(item)}\n-                    onContextMenu={this.props.onContextMenu}\n-                    onRowDoubleClick={(_, item: T) => this.props.onRowDoubleClick(item)}\n-                    onFiltersChange={this.props.onFiltersChange}\n-                    onSortToggle={this.props.onSortToggle}\n-                    extractKey={this.props.extractKey}/>\n-                <Toolbar>\n-                    {this.props.items.length > 0 &&\n-                    <Grid container justify=\"flex-end\">\n-                        <TablePagination\n-                            count={this.props.itemsAvailable}\n-                            rowsPerPage={this.props.rowsPerPage}\n-                            rowsPerPageOptions={this.props.rowsPerPageOptions}\n-                            page={this.props.page}\n-                            onChangePage={this.changePage}\n-                            onChangeRowsPerPage={this.changeRowsPerPage}\n-                            component=\"div\"\n-                        />\n-                    </Grid>}\n-                </Toolbar>\n-            </Paper>;\n+            const { \n+                columns, onContextMenu, onFiltersChange, onSortToggle, extractKey, \n+                rowsPerPage, rowsPerPageOptions, onColumnToggle, searchValue, onSearch, \n+                items, itemsAvailable, onRowClick, onRowDoubleClick, classes \n+            } = this.props;\n+            return <div>\n+                { items.length > 0 ? (\n+                    <Paper>\n+                        <Toolbar className={classes.toolbar}>\n+                            <Grid container justify=\"space-between\" wrap=\"nowrap\" alignItems=\"center\">\n+                                <div className={classes.searchBox}>\n+                                    <SearchInput\n+                                        value={searchValue}\n+                                        onSearch={onSearch}/>\n+                                </div>\n+                                <ColumnSelector\n+                                    columns={columns}\n+                                    onColumnToggle={onColumnToggle}/>\n+                            </Grid>\n+                        </Toolbar>\n+                        <DataTable\n+                            columns={[...columns, this.contextMenuColumn]}\n+                            items={items}\n+                            onRowClick={(_, item: T) => onRowClick(item)}\n+                            onContextMenu={onContextMenu}\n+                            onRowDoubleClick={(_, item: T) => onRowDoubleClick(item)}\n+                            onFiltersChange={onFiltersChange}\n+                            onSortToggle={onSortToggle}\n+                            extractKey={extractKey}/>\n+                        <Toolbar>\n+                            <Grid container justify=\"flex-end\">\n+                                <TablePagination\n+                                    count={itemsAvailable}\n+                                    rowsPerPage={rowsPerPage}\n+                                    rowsPerPageOptions={rowsPerPageOptions}\n+                                    page={this.props.page}\n+                                    onChangePage={this.changePage}\n+                                    onChangeRowsPerPage={this.changeRowsPerPage}\n+                                    component=\"div\" />\n+                            </Grid>\n+                        </Toolbar>\n+                    </Paper>\n+                ) : (\n+                    <DefaultView \n+                        classRoot={classes.defaultRoot}\n+                        icon={ProjectIcon}\n+                        classIcon={classes.defaultIcon}\n+                        messages={['Your project is empty. Please create a project', 'or create a collection and upload a data.']}","path":"src/components/data-explorer/data-explorer.tsx","position":135,"original_position":135,"commit_id":"08f35d9b26a06b70da6e54533782276617c5bed1","original_commit_id":"08f35d9b26a06b70da6e54533782276617c5bed1","user":{"login":"janicka1","id":13416778,"node_id":"MDQ6VXNlcjEzNDE2Nzc4","avatar_url":"https://avatars3.githubusercontent.com/u/13416778?v=4","gravatar_id":"","url":"https://api.github.com/users/janicka1","html_url":"https://github.com/janicka1","followers_url":"https://api.github.com/users/janicka1/followers","following_url":"https://api.github.com/users/janicka1/following{/other_user}","gists_url":"https://api.github.com/users/janicka1/gists{/gist_id}","starred_url":"https://api.github.com/users/janicka1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicka1/subscriptions","organizations_url":"https://api.github.com/users/janicka1/orgs","repos_url":"https://api.github.com/users/janicka1/repos","events_url":"https://api.github.com/users/janicka1/events{/privacy}","received_events_url":"https://api.github.com/users/janicka1/received_events","type":"User","site_admin":false},"body":"Please correct me if I am wrong but you mean pass messages and icon? Because we should display default view every time when we have empty data. ","created_at":"2018-08-10T06:29:14Z","updated_at":"2018-08-10T06:29:14Z","html_url":"https://github.com/curoverse/arvados-workbench2/pull/43#discussion_r209156097","pull_request_url":"https://api.github.com/repos/curoverse/arvados-workbench2/pulls/43","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/curoverse/arvados-workbench2/pulls/comments/209156097"},"html":{"href":"https://github.com/curoverse/arvados-workbench2/pull/43#discussion_r209156097"},"pull_request":{"href":"https://api.github.com/repos/curoverse/arvados-workbench2/pulls/43"}},"in_reply_to_id":209154832},"pull_request":{"url":"https://api.github.com/repos/curoverse/arvados-workbench2/pulls/43","id":207377077,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3Mzc3MDc3","html_url":"https://github.com/curoverse/arvados-workbench2/pull/43","diff_url":"https://github.com/curoverse/arvados-workbench2/pull/43.diff","patch_url":"https://github.com/curoverse/arvados-workbench2/pull/43.patch","issue_url":"https://api.github.com/repos/curoverse/arvados-workbench2/issues/43","number":43,"state":"open","locked":false,"title":"add default view component and use inside project and details panel","user":{"login":"janicka1","id":13416778,"node_id":"MDQ6VXNlcjEzNDE2Nzc4","avatar_url":"https://avatars3.githubusercontent.com/u/13416778?v=4","gravatar_id":"","url":"https://api.github.com/users/janicka1","html_url":"https://github.com/janicka1","followers_url":"https://api.github.com/users/janicka1/followers","following_url":"https://api.github.com/users/janicka1/following{/other_user}","gists_url":"https://api.github.com/users/janicka1/gists{/gist_id}","starred_url":"https://api.github.com/users/janicka1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicka1/subscriptions","organizations_url":"https://api.github.com/users/janicka1/orgs","repos_url":"https://api.github.com/users/janicka1/repos","events_url":"https://api.github.com/users/janicka1/events{/privacy}","received_events_url":"https://api.github.com/users/janicka1/received_events","type":"User","site_admin":false},"body":"Feature #13894\r\n\r\nArvados-DCO-1.1-Signed-off-by: Janicki Artur <artur.janicki@contractors.roche.com>","created_at":"2018-08-09T16:41:43Z","updated_at":"2018-08-10T06:29:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b97f067c110b9fd3eea6d41d24140b1924461062","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/curoverse/arvados-workbench2/pulls/43/commits","review_comments_url":"https://api.github.com/repos/curoverse/arvados-workbench2/pulls/43/comments","review_comment_url":"https://api.github.com/repos/curoverse/arvados-workbench2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/curoverse/arvados-workbench2/issues/43/comments","statuses_url":"https://api.github.com/repos/curoverse/arvados-workbench2/statuses/08f35d9b26a06b70da6e54533782276617c5bed1","head":{"label":"curoverse:13894-default-view-component","ref":"13894-default-view-component","sha":"08f35d9b26a06b70da6e54533782276617c5bed1","user":{"login":"curoverse","id":2304206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDQyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2304206?v=4","gravatar_id":"","url":"https://api.github.com/users/curoverse","html_url":"https://github.com/curoverse","followers_url":"https://api.github.com/users/curoverse/followers","following_url":"https://api.github.com/users/curoverse/following{/other_user}","gists_url":"https://api.github.com/users/curoverse/gists{/gist_id}","starred_url":"https://api.github.com/users/curoverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curoverse/subscriptions","organizations_url":"https://api.github.com/users/curoverse/orgs","repos_url":"https://api.github.com/users/curoverse/repos","events_url":"https://api.github.com/users/curoverse/events{/privacy}","received_events_url":"https://api.github.com/users/curoverse/received_events","type":"Organization","site_admin":false},"repo":{"id":134474025,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NzQwMjU=","name":"arvados-workbench2","full_name":"curoverse/arvados-workbench2","owner":{"login":"curoverse","id":2304206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDQyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2304206?v=4","gravatar_id":"","url":"https://api.github.com/users/curoverse","html_url":"https://github.com/curoverse","followers_url":"https://api.github.com/users/curoverse/followers","following_url":"https://api.github.com/users/curoverse/following{/other_user}","gists_url":"https://api.github.com/users/curoverse/gists{/gist_id}","starred_url":"https://api.github.com/users/curoverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curoverse/subscriptions","organizations_url":"https://api.github.com/users/curoverse/orgs","repos_url":"https://api.github.com/users/curoverse/repos","events_url":"https://api.github.com/users/curoverse/events{/privacy}","received_events_url":"https://api.github.com/users/curoverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/curoverse/arvados-workbench2","description":null,"fork":false,"url":"https://api.github.com/repos/curoverse/arvados-workbench2","forks_url":"https://api.github.com/repos/curoverse/arvados-workbench2/forks","keys_url":"https://api.github.com/repos/curoverse/arvados-workbench2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/curoverse/arvados-workbench2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/curoverse/arvados-workbench2/teams","hooks_url":"https://api.github.com/repos/curoverse/arvados-workbench2/hooks","issue_events_url":"https://api.github.com/repos/curoverse/arvados-workbench2/issues/events{/number}","events_url":"https://api.github.com/repos/curoverse/arvados-workbench2/events","assignees_url":"https://api.github.com/repos/curoverse/arvados-workbench2/assignees{/user}","branches_url":"https://api.github.com/repos/curoverse/arvados-workbench2/branches{/branch}","tags_url":"https://api.github.com/repos/curoverse/arvados-workbench2/tags","blobs_url":"https://api.github.com/repos/curoverse/arvados-workbench2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/curoverse/arvados-workbench2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/curoverse/arvados-workbench2/git/refs{/sha}","trees_url":"https://api.github.com/repos/curoverse/arvados-workbench2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/curoverse/arvados-workbench2/statuses/{sha}","languages_url":"https://api.github.com/repos/curoverse/arvados-workbench2/languages","stargazers_url":"https://api.github.com/repos/curoverse/arvados-workbench2/stargazers","contributors_url":"https://api.github.com/repos/curoverse/arvados-workbench2/contributors","subscribers_url":"https://api.github.com/repos/curoverse/arvados-workbench2/subscribers","subscription_url":"https://api.github.com/repos/curoverse/arvados-workbench2/subscription","commits_url":"https://api.github.com/repos/curoverse/arvados-workbench2/commits{/sha}","git_commits_url":"https://api.github.com/repos/curoverse/arvados-workbench2/git/commits{/sha}","comments_url":"https://api.github.com/repos/curoverse/arvados-workbench2/comments{/number}","issue_comment_url":"https://api.github.com/repos/curoverse/arvados-workbench2/issues/comments{/number}","contents_url":"https://api.github.com/repos/curoverse/arvados-workbench2/contents/{+path}","compare_url":"https://api.github.com/repos/curoverse/arvados-workbench2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/curoverse/arvados-workbench2/merges","archive_url":"https://api.github.com/repos/curoverse/arvados-workbench2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/curoverse/arvados-workbench2/downloads","issues_url":"https://api.github.com/repos/curoverse/arvados-workbench2/issues{/number}","pulls_url":"https://api.github.com/repos/curoverse/arvados-workbench2/pulls{/number}","milestones_url":"https://api.github.com/repos/curoverse/arvados-workbench2/milestones{/number}","notifications_url":"https://api.github.com/repos/curoverse/arvados-workbench2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/curoverse/arvados-workbench2/labels{/name}","releases_url":"https://api.github.com/repos/curoverse/arvados-workbench2/releases{/id}","deployments_url":"https://api.github.com/repos/curoverse/arvados-workbench2/deployments","created_at":"2018-05-22T20:46:59Z","updated_at":"2018-08-09T14:37:26Z","pushed_at":"2018-08-09T16:41:43Z","git_url":"git://github.com/curoverse/arvados-workbench2.git","ssh_url":"git@github.com:curoverse/arvados-workbench2.git","clone_url":"https://github.com/curoverse/arvados-workbench2.git","svn_url":"https://github.com/curoverse/arvados-workbench2","homepage":null,"size":922,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"curoverse:master","ref":"master","sha":"0f2d05eeb8a5fbacead1a6c9e9f8403109d8aae2","user":{"login":"curoverse","id":2304206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDQyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2304206?v=4","gravatar_id":"","url":"https://api.github.com/users/curoverse","html_url":"https://github.com/curoverse","followers_url":"https://api.github.com/users/curoverse/followers","following_url":"https://api.github.com/users/curoverse/following{/other_user}","gists_url":"https://api.github.com/users/curoverse/gists{/gist_id}","starred_url":"https://api.github.com/users/curoverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curoverse/subscriptions","organizations_url":"https://api.github.com/users/curoverse/orgs","repos_url":"https://api.github.com/users/curoverse/repos","events_url":"https://api.github.com/users/curoverse/events{/privacy}","received_events_url":"https://api.github.com/users/curoverse/received_events","type":"Organization","site_admin":false},"repo":{"id":134474025,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NzQwMjU=","name":"arvados-workbench2","full_name":"curoverse/arvados-workbench2","owner":{"login":"curoverse","id":2304206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDQyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2304206?v=4","gravatar_id":"","url":"https://api.github.com/users/curoverse","html_url":"https://github.com/curoverse","followers_url":"https://api.github.com/users/curoverse/followers","following_url":"https://api.github.com/users/curoverse/following{/other_user}","gists_url":"https://api.github.com/users/curoverse/gists{/gist_id}","starred_url":"https://api.github.com/users/curoverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curoverse/subscriptions","organizations_url":"https://api.github.com/users/curoverse/orgs","repos_url":"https://api.github.com/users/curoverse/repos","events_url":"https://api.github.com/users/curoverse/events{/privacy}","received_events_url":"https://api.github.com/users/curoverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/curoverse/arvados-workbench2","description":null,"fork":false,"url":"https://api.github.com/repos/curoverse/arvados-workbench2","forks_url":"https://api.github.com/repos/curoverse/arvados-workbench2/forks","keys_url":"https://api.github.com/repos/curoverse/arvados-workbench2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/curoverse/arvados-workbench2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/curoverse/arvados-workbench2/teams","hooks_url":"https://api.github.com/repos/curoverse/arvados-workbench2/hooks","issue_events_url":"https://api.github.com/repos/curoverse/arvados-workbench2/issues/events{/number}","events_url":"https://api.github.com/repos/curoverse/arvados-workbench2/events","assignees_url":"https://api.github.com/repos/curoverse/arvados-workbench2/assignees{/user}","branches_url":"https://api.github.com/repos/curoverse/arvados-workbench2/branches{/branch}","tags_url":"https://api.github.com/repos/curoverse/arvados-workbench2/tags","blobs_url":"https://api.github.com/repos/curoverse/arvados-workbench2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/curoverse/arvados-workbench2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/curoverse/arvados-workbench2/git/refs{/sha}","trees_url":"https://api.github.com/repos/curoverse/arvados-workbench2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/curoverse/arvados-workbench2/statuses/{sha}","languages_url":"https://api.github.com/repos/curoverse/arvados-workbench2/languages","stargazers_url":"https://api.github.com/repos/curoverse/arvados-workbench2/stargazers","contributors_url":"https://api.github.com/repos/curoverse/arvados-workbench2/contributors","subscribers_url":"https://api.github.com/repos/curoverse/arvados-workbench2/subscribers","subscription_url":"https://api.github.com/repos/curoverse/arvados-workbench2/subscription","commits_url":"https://api.github.com/repos/curoverse/arvados-workbench2/commits{/sha}","git_commits_url":"https://api.github.com/repos/curoverse/arvados-workbench2/git/commits{/sha}","comments_url":"https://api.github.com/repos/curoverse/arvados-workbench2/comments{/number}","issue_comment_url":"https://api.github.com/repos/curoverse/arvados-workbench2/issues/comments{/number}","contents_url":"https://api.github.com/repos/curoverse/arvados-workbench2/contents/{+path}","compare_url":"https://api.github.com/repos/curoverse/arvados-workbench2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/curoverse/arvados-workbench2/merges","archive_url":"https://api.github.com/repos/curoverse/arvados-workbench2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/curoverse/arvados-workbench2/downloads","issues_url":"https://api.github.com/repos/curoverse/arvados-workbench2/issues{/number}","pulls_url":"https://api.github.com/repos/curoverse/arvados-workbench2/pulls{/number}","milestones_url":"https://api.github.com/repos/curoverse/arvados-workbench2/milestones{/number}","notifications_url":"https://api.github.com/repos/curoverse/arvados-workbench2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/curoverse/arvados-workbench2/labels{/name}","releases_url":"https://api.github.com/repos/curoverse/arvados-workbench2/releases{/id}","deployments_url":"https://api.github.com/repos/curoverse/arvados-workbench2/deployments","created_at":"2018-05-22T20:46:59Z","updated_at":"2018-08-09T14:37:26Z","pushed_at":"2018-08-09T16:41:43Z","git_url":"git://github.com/curoverse/arvados-workbench2.git","ssh_url":"git@github.com:curoverse/arvados-workbench2.git","clone_url":"https://github.com/curoverse/arvados-workbench2.git","svn_url":"https://github.com/curoverse/arvados-workbench2","homepage":null,"size":922,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/curoverse/arvados-workbench2/pulls/43"},"html":{"href":"https://github.com/curoverse/arvados-workbench2/pull/43"},"issue":{"href":"https://api.github.com/repos/curoverse/arvados-workbench2/issues/43"},"comments":{"href":"https://api.github.com/repos/curoverse/arvados-workbench2/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/curoverse/arvados-workbench2/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/curoverse/arvados-workbench2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/curoverse/arvados-workbench2/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/curoverse/arvados-workbench2/statuses/08f35d9b26a06b70da6e54533782276617c5bed1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"janicka1"}}