{"action":"created","comment":{"url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/pulls/comments/181010781","pull_request_review_id":111534062,"id":181010781,"diff_hunk":"@@ -880,6 +1049,22 @@ class Gap {\n         return BLE_ERROR_NOT_IMPLEMENTED;\n     }\n \n+    /**\n+     * Return the type of a random address.\n+     *\n+     * @param[in] address The random address to retrieve the type from. The #\n+     * address must be ordered in little endian.\n+     *\n+     * @param[out] addressType Type of the address to fill.\n+     *\n+     * @return BLE_ERROR_NONE in case of success or BLE_ERROR_INVALID_PARAM if\n+     * the address in input was not identifiable as a random address.\n+     */\n+    static ble_error_t getRandomAddressType(\n+        BLEProtocol::AddressBytes_t address,\n+        RandomAddressType_t& addressType","path":"features/FEATURE_BLE/ble/Gap.h","position":273,"original_position":273,"commit_id":"1f02913a2c6d7b880de5c82599a03e865ce6a015","original_commit_id":"1f02913a2c6d7b880de5c82599a03e865ce6a015","user":{"login":"paul-szczepanek-arm","id":33840200,"avatar_url":"https://avatars0.githubusercontent.com/u/33840200?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-szczepanek-arm","html_url":"https://github.com/paul-szczepanek-arm","followers_url":"https://api.github.com/users/paul-szczepanek-arm/followers","following_url":"https://api.github.com/users/paul-szczepanek-arm/following{/other_user}","gists_url":"https://api.github.com/users/paul-szczepanek-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-szczepanek-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-szczepanek-arm/subscriptions","organizations_url":"https://api.github.com/users/paul-szczepanek-arm/orgs","repos_url":"https://api.github.com/users/paul-szczepanek-arm/repos","events_url":"https://api.github.com/users/paul-szczepanek-arm/events{/privacy}","received_events_url":"https://api.github.com/users/paul-szczepanek-arm/received_events","type":"User","site_admin":false},"body":"in user facing APIs we use pointers not refs for [out], including in this file, so for consistency this and the ones below should be pointers too","created_at":"2018-04-12T08:59:42Z","updated_at":"2018-04-12T08:59:42Z","html_url":"https://github.com/paul-szczepanek-arm/mbed-os/pull/30#discussion_r181010781","pull_request_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/pulls/30","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/pulls/comments/181010781"},"html":{"href":"https://github.com/paul-szczepanek-arm/mbed-os/pull/30#discussion_r181010781"},"pull_request":{"href":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/pulls/30","id":180901001,"html_url":"https://github.com/paul-szczepanek-arm/mbed-os/pull/30","diff_url":"https://github.com/paul-szczepanek-arm/mbed-os/pull/30.diff","patch_url":"https://github.com/paul-szczepanek-arm/mbed-os/pull/30.patch","issue_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/issues/30","number":30,"state":"open","locked":false,"title":"BLE: Add Gap privacy interfaces.","user":{"login":"pan-","id":409941,"avatar_url":"https://avatars3.githubusercontent.com/u/409941?v=4","gravatar_id":"","url":"https://api.github.com/users/pan-","html_url":"https://github.com/pan-","followers_url":"https://api.github.com/users/pan-/followers","following_url":"https://api.github.com/users/pan-/following{/other_user}","gists_url":"https://api.github.com/users/pan-/gists{/gist_id}","starred_url":"https://api.github.com/users/pan-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pan-/subscriptions","organizations_url":"https://api.github.com/users/pan-/orgs","repos_url":"https://api.github.com/users/pan-/repos","events_url":"https://api.github.com/users/pan-/events{/privacy}","received_events_url":"https://api.github.com/users/pan-/received_events","type":"User","site_admin":false},"body":"This commit adds API to enable and configure the device privacy.\r\nIt deprecates address random types present in Gap::AddressType as these types are not appropriate for scan reports, connection initiation and the connection event. Now user should use the function Gap::getRandomAddressType to find the type of a random address.\r\nThe function gap::setAddress is deprecated as it is not portable and can colide with privacy.\r\n","created_at":"2018-04-11T13:19:56Z","updated_at":"2018-04-12T08:59:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1de196acb9dcee23304b3eec428c3a66846ceff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/pulls/30/commits","review_comments_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/pulls/30/comments","review_comment_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/issues/30/comments","statuses_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/statuses/1f02913a2c6d7b880de5c82599a03e865ce6a015","head":{"label":"pan-:sm-privacy","ref":"sm-privacy","sha":"1f02913a2c6d7b880de5c82599a03e865ce6a015","user":{"login":"pan-","id":409941,"avatar_url":"https://avatars3.githubusercontent.com/u/409941?v=4","gravatar_id":"","url":"https://api.github.com/users/pan-","html_url":"https://github.com/pan-","followers_url":"https://api.github.com/users/pan-/followers","following_url":"https://api.github.com/users/pan-/following{/other_user}","gists_url":"https://api.github.com/users/pan-/gists{/gist_id}","starred_url":"https://api.github.com/users/pan-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pan-/subscriptions","organizations_url":"https://api.github.com/users/pan-/orgs","repos_url":"https://api.github.com/users/pan-/repos","events_url":"https://api.github.com/users/pan-/events{/privacy}","received_events_url":"https://api.github.com/users/pan-/received_events","type":"User","site_admin":false},"repo":{"id":59667574,"name":"mbed","full_name":"pan-/mbed","owner":{"login":"pan-","id":409941,"avatar_url":"https://avatars3.githubusercontent.com/u/409941?v=4","gravatar_id":"","url":"https://api.github.com/users/pan-","html_url":"https://github.com/pan-","followers_url":"https://api.github.com/users/pan-/followers","following_url":"https://api.github.com/users/pan-/following{/other_user}","gists_url":"https://api.github.com/users/pan-/gists{/gist_id}","starred_url":"https://api.github.com/users/pan-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pan-/subscriptions","organizations_url":"https://api.github.com/users/pan-/orgs","repos_url":"https://api.github.com/users/pan-/repos","events_url":"https://api.github.com/users/pan-/events{/privacy}","received_events_url":"https://api.github.com/users/pan-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pan-/mbed","description":"mbed libraries and tools (Classic). For mbed OS, look here: https://www.mbed.com/en/development/software/mbed-os/","fork":true,"url":"https://api.github.com/repos/pan-/mbed","forks_url":"https://api.github.com/repos/pan-/mbed/forks","keys_url":"https://api.github.com/repos/pan-/mbed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pan-/mbed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pan-/mbed/teams","hooks_url":"https://api.github.com/repos/pan-/mbed/hooks","issue_events_url":"https://api.github.com/repos/pan-/mbed/issues/events{/number}","events_url":"https://api.github.com/repos/pan-/mbed/events","assignees_url":"https://api.github.com/repos/pan-/mbed/assignees{/user}","branches_url":"https://api.github.com/repos/pan-/mbed/branches{/branch}","tags_url":"https://api.github.com/repos/pan-/mbed/tags","blobs_url":"https://api.github.com/repos/pan-/mbed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pan-/mbed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pan-/mbed/git/refs{/sha}","trees_url":"https://api.github.com/repos/pan-/mbed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pan-/mbed/statuses/{sha}","languages_url":"https://api.github.com/repos/pan-/mbed/languages","stargazers_url":"https://api.github.com/repos/pan-/mbed/stargazers","contributors_url":"https://api.github.com/repos/pan-/mbed/contributors","subscribers_url":"https://api.github.com/repos/pan-/mbed/subscribers","subscription_url":"https://api.github.com/repos/pan-/mbed/subscription","commits_url":"https://api.github.com/repos/pan-/mbed/commits{/sha}","git_commits_url":"https://api.github.com/repos/pan-/mbed/git/commits{/sha}","comments_url":"https://api.github.com/repos/pan-/mbed/comments{/number}","issue_comment_url":"https://api.github.com/repos/pan-/mbed/issues/comments{/number}","contents_url":"https://api.github.com/repos/pan-/mbed/contents/{+path}","compare_url":"https://api.github.com/repos/pan-/mbed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pan-/mbed/merges","archive_url":"https://api.github.com/repos/pan-/mbed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pan-/mbed/downloads","issues_url":"https://api.github.com/repos/pan-/mbed/issues{/number}","pulls_url":"https://api.github.com/repos/pan-/mbed/pulls{/number}","milestones_url":"https://api.github.com/repos/pan-/mbed/milestones{/number}","notifications_url":"https://api.github.com/repos/pan-/mbed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pan-/mbed/labels{/name}","releases_url":"https://api.github.com/repos/pan-/mbed/releases{/id}","deployments_url":"https://api.github.com/repos/pan-/mbed/deployments","created_at":"2016-05-25T13:56:37Z","updated_at":"2016-05-25T13:57:34Z","pushed_at":"2018-04-11T13:24:58Z","git_url":"git://github.com/pan-/mbed.git","ssh_url":"git@github.com:pan-/mbed.git","clone_url":"https://github.com/pan-/mbed.git","svn_url":"https://github.com/pan-/mbed","homepage":"","size":195453,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paul-szczepanek-arm:security-manager-dev","ref":"security-manager-dev","sha":"3aaedf6f48c772296b8e56fb0828be49b8ac2881","user":{"login":"paul-szczepanek-arm","id":33840200,"avatar_url":"https://avatars0.githubusercontent.com/u/33840200?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-szczepanek-arm","html_url":"https://github.com/paul-szczepanek-arm","followers_url":"https://api.github.com/users/paul-szczepanek-arm/followers","following_url":"https://api.github.com/users/paul-szczepanek-arm/following{/other_user}","gists_url":"https://api.github.com/users/paul-szczepanek-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-szczepanek-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-szczepanek-arm/subscriptions","organizations_url":"https://api.github.com/users/paul-szczepanek-arm/orgs","repos_url":"https://api.github.com/users/paul-szczepanek-arm/repos","events_url":"https://api.github.com/users/paul-szczepanek-arm/events{/privacy}","received_events_url":"https://api.github.com/users/paul-szczepanek-arm/received_events","type":"User","site_admin":false},"repo":{"id":112753124,"name":"mbed-os","full_name":"paul-szczepanek-arm/mbed-os","owner":{"login":"paul-szczepanek-arm","id":33840200,"avatar_url":"https://avatars0.githubusercontent.com/u/33840200?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-szczepanek-arm","html_url":"https://github.com/paul-szczepanek-arm","followers_url":"https://api.github.com/users/paul-szczepanek-arm/followers","following_url":"https://api.github.com/users/paul-szczepanek-arm/following{/other_user}","gists_url":"https://api.github.com/users/paul-szczepanek-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-szczepanek-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-szczepanek-arm/subscriptions","organizations_url":"https://api.github.com/users/paul-szczepanek-arm/orgs","repos_url":"https://api.github.com/users/paul-szczepanek-arm/repos","events_url":"https://api.github.com/users/paul-szczepanek-arm/events{/privacy}","received_events_url":"https://api.github.com/users/paul-szczepanek-arm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paul-szczepanek-arm/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os","forks_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/forks","keys_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/teams","hooks_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/events","assignees_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/tags","blobs_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/languages","stargazers_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/subscription","commits_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/merges","archive_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/downloads","issues_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/deployments","created_at":"2017-12-01T15:07:30Z","updated_at":"2018-04-11T14:51:06Z","pushed_at":"2018-04-11T14:51:03Z","git_url":"git://github.com/paul-szczepanek-arm/mbed-os.git","ssh_url":"git@github.com:paul-szczepanek-arm/mbed-os.git","clone_url":"https://github.com/paul-szczepanek-arm/mbed-os.git","svn_url":"https://github.com/paul-szczepanek-arm/mbed-os","homepage":"https://mbed.com","size":200398,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":2,"watchers":0,"default_branch":"security-manager-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/pulls/30"},"html":{"href":"https://github.com/paul-szczepanek-arm/mbed-os/pull/30"},"issue":{"href":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/issues/30"},"comments":{"href":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/statuses/1f02913a2c6d7b880de5c82599a03e865ce6a015"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"paul-szczepanek-arm"}}