{"action":"created","issue":{"url":"https://api.github.com/repos/busyorg/busy/issues/2099","repository_url":"https://api.github.com/repos/busyorg/busy","labels_url":"https://api.github.com/repos/busyorg/busy/issues/2099/labels{/name}","comments_url":"https://api.github.com/repos/busyorg/busy/issues/2099/comments","events_url":"https://api.github.com/repos/busyorg/busy/issues/2099/events","html_url":"https://github.com/busyorg/busy/issues/2099","id":351504260,"node_id":"MDU6SXNzdWUzNTE1MDQyNjA=","number":2099,"title":"formatter.vestToSteem is used a lot to set variables called vestsToSP, which doesn't make sense","user":{"login":"lopugit","id":13629190,"node_id":"MDQ6VXNlcjEzNjI5MTkw","avatar_url":"https://avatars0.githubusercontent.com/u/13629190?v=4","gravatar_id":"","url":"https://api.github.com/users/lopugit","html_url":"https://github.com/lopugit","followers_url":"https://api.github.com/users/lopugit/followers","following_url":"https://api.github.com/users/lopugit/following{/other_user}","gists_url":"https://api.github.com/users/lopugit/gists{/gist_id}","starred_url":"https://api.github.com/users/lopugit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lopugit/subscriptions","organizations_url":"https://api.github.com/users/lopugit/orgs","repos_url":"https://api.github.com/users/lopugit/repos","events_url":"https://api.github.com/users/lopugit/events{/privacy}","received_events_url":"https://api.github.com/users/lopugit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-17T08:31:06Z","updated_at":"2018-08-17T09:36:37Z","closed_at":null,"author_association":"NONE","body":"<!--\r\nThanks for opening an issue! To help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you. \r\n-->\r\n\r\n#### Expected behavior\r\nThat ```formatter.vestToSteem()``` would return a STEEM ammount equal to the fraction of the reward vests to the total vests times the current STEEM vesting fund, which I think it does according to it's definition\r\n\r\n```javascript\r\nvestToSteem(vestingShares, totalVestingShares, totalVestingFundSteem) {\r\n      return (\r\n        parseFloat(totalVestingFundSteem) *\r\n        (parseFloat(vestingShares) / parseFloat(totalVestingShares))\r\n      );\r\n    },\r\n```\r\n<!-- What do you think should happen? -->\r\n\r\n#### Actual behavior\r\n\r\nThis function is used nearly solely to generate numbers that represent ```SP``` amounts, but this formula generates an amount of ```STEEM```\r\n\r\n<!-- What actually happens? -->\r\n\r\n#### How to reproduce\r\ngo here\r\nhttps://github.com/busyorg/busy/blob/1bbd8c952e8fc5085b70aca9c65e8ea3256c14ad/src/client/activity/AuthorRewardMessage.js#L23-L32\r\nhttps://github.com/busyorg/busy/blob/1bbd8c952e8fc5085b70aca9c65e8ea3256c14ad/src/client/activity/UserActionMessage.js#L113-L124\r\nhttps://github.com/busyorg/busy/blob/1bbd8c952e8fc5085b70aca9c65e8ea3256c14ad/src/client/helpers/steemitFormatter.js#L162-L167<!-- For bugs, provide an URL that demos the problem -->\r\n\r\n* Browser: Chrome idk what version it doesn't matter\r\n* Operating system: myob\r\n"},"comment":{"url":"https://api.github.com/repos/busyorg/busy/issues/comments/413812754","html_url":"https://github.com/busyorg/busy/issues/2099#issuecomment-413812754","issue_url":"https://api.github.com/repos/busyorg/busy/issues/2099","id":413812754,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzgxMjc1NA==","user":{"login":"Sekhmet","id":1968722,"node_id":"MDQ6VXNlcjE5Njg3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1968722?v=4","gravatar_id":"","url":"https://api.github.com/users/Sekhmet","html_url":"https://github.com/Sekhmet","followers_url":"https://api.github.com/users/Sekhmet/followers","following_url":"https://api.github.com/users/Sekhmet/following{/other_user}","gists_url":"https://api.github.com/users/Sekhmet/gists{/gist_id}","starred_url":"https://api.github.com/users/Sekhmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sekhmet/subscriptions","organizations_url":"https://api.github.com/users/Sekhmet/orgs","repos_url":"https://api.github.com/users/Sekhmet/repos","events_url":"https://api.github.com/users/Sekhmet/events{/privacy}","received_events_url":"https://api.github.com/users/Sekhmet/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T09:36:37Z","updated_at":"2018-08-17T09:36:37Z","author_association":"MEMBER","body":"We display shares in user friendly format (Steem Power). If you need more detailed format you can use steemd.com"}}
{"actor":{"display_login":"Sekhmet"}}