{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/240960646","pull_request_review_id":184110063,"id":240960646,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDk2MDY0Ng==","diff_hunk":"@@ -47,25 +47,31 @@\n         }\n     }\n \n-    public static void assertResultSets(ResultSet expected, ResultSet actual) throws SQLException {\n-        assertResultSets(expected, actual, null);\n+    public static void assertResultSets(ResultSet expected, ResultSet actual, boolean lenientFloatingNumbers) throws SQLException {\n+        assertResultSets(expected, actual, null, lenientFloatingNumbers);\n     }\n \n-    public static void assertResultSets(ResultSet expected, ResultSet actual, Logger logger) throws SQLException {\n-        assertResultSets(expected, actual, logger, false);\n+    public static void assertResultSets(ResultSet expected, ResultSet actual, Logger logger, boolean lenientFloatingNumbers) \n+           throws SQLException {\n+        assertResultSets(expected, actual, logger, false, lenientFloatingNumbers);\n     }\n \n     /**\n      * Assert the given result sets, potentially in a lenient way.\n-     * When lenient is specified, the type comparison of a column is widden to reach a common, compatible ground.\n+     * When lenientDataType is specified, the type comparison of a column is widden to reach a common, compatible ground.\n      * This means promoting integer types to long and floating types to double and comparing their values.\n-     * For example in a non-lenient, strict case a comparison between an int and a tinyint would fail, with lenient it will succeed as\n-     * long as the actual value is the same.\n+     * For example in a non-lenient, strict case a comparison between an int and a tinyint would fail, with lenientDataType it will succeed\n+     * as long as the actual value is the same.\n+     * Also, has the option of treating the numeric results for floating point numbers in a leninent way, if chosen to. Usually,\n+     * we would want lening treatment for floating point numbers in sql-spec tests where the comparison is being made with H2.","path":"x-pack/plugin/sql/qa/src/main/java/org/elasticsearch/xpack/sql/qa/jdbc/JdbcAssert.java","position":27,"original_position":27,"commit_id":"e0f847a1beb2bdcf6769c2c26d7a328a44803a1d","original_commit_id":"e0f847a1beb2bdcf6769c2c26d7a328a44803a1d","user":{"login":"astefan","id":893749,"node_id":"MDQ6VXNlcjg5Mzc0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/893749?v=4","gravatar_id":"","url":"https://api.github.com/users/astefan","html_url":"https://github.com/astefan","followers_url":"https://api.github.com/users/astefan/followers","following_url":"https://api.github.com/users/astefan/following{/other_user}","gists_url":"https://api.github.com/users/astefan/gists{/gist_id}","starred_url":"https://api.github.com/users/astefan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astefan/subscriptions","organizations_url":"https://api.github.com/users/astefan/orgs","repos_url":"https://api.github.com/users/astefan/repos","events_url":"https://api.github.com/users/astefan/events{/privacy}","received_events_url":"https://api.github.com/users/astefan/received_events","type":"User","site_admin":false},"body":"Yes. Should be `lenient`. Thanks.","created_at":"2018-12-12T10:36:23Z","updated_at":"2018-12-12T10:36:23Z","html_url":"https://github.com/elastic/elasticsearch/pull/36498#discussion_r240960646","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/36498","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/240960646"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/36498#discussion_r240960646"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/36498"}},"in_reply_to_id":240931361},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/36498","id":237760247,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NzYwMjQ3","html_url":"https://github.com/elastic/elasticsearch/pull/36498","diff_url":"https://github.com/elastic/elasticsearch/pull/36498.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/36498.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/36498","number":36498,"state":"open","locked":false,"title":"SQL: be lenient for tests involving comparison to H2 but strict for csv spec tests","user":{"login":"astefan","id":893749,"node_id":"MDQ6VXNlcjg5Mzc0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/893749?v=4","gravatar_id":"","url":"https://api.github.com/users/astefan","html_url":"https://github.com/astefan","followers_url":"https://api.github.com/users/astefan/followers","following_url":"https://api.github.com/users/astefan/following{/other_user}","gists_url":"https://api.github.com/users/astefan/gists{/gist_id}","starred_url":"https://api.github.com/users/astefan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astefan/subscriptions","organizations_url":"https://api.github.com/users/astefan/orgs","repos_url":"https://api.github.com/users/astefan/repos","events_url":"https://api.github.com/users/astefan/events{/privacy}","received_events_url":"https://api.github.com/users/astefan/received_events","type":"User","site_admin":false},"body":"This PR addresses https://github.com/elastic/elasticsearch/issues/36483 by adding a new boolean lenient parameter for tests to round or not the floating point numbers in tests. Relates to https://github.com/elastic/elasticsearch/pull/36431/files#r240219710.","created_at":"2018-12-11T17:13:42Z","updated_at":"2018-12-12T10:36:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56bda98c2cd41e54d2b501ad9f90544a2285265d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"costin","id":76245,"node_id":"MDQ6VXNlcjc2MjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/76245?v=4","gravatar_id":"","url":"https://api.github.com/users/costin","html_url":"https://github.com/costin","followers_url":"https://api.github.com/users/costin/followers","following_url":"https://api.github.com/users/costin/following{/other_user}","gists_url":"https://api.github.com/users/costin/gists{/gist_id}","starred_url":"https://api.github.com/users/costin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costin/subscriptions","organizations_url":"https://api.github.com/users/costin/orgs","repos_url":"https://api.github.com/users/costin/repos","events_url":"https://api.github.com/users/costin/events{/privacy}","received_events_url":"https://api.github.com/users/costin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":912794284,"node_id":"MDU6TGFiZWw5MTI3OTQyODQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Search/SQL","name":":Search/SQL","color":"0e8a16","default":false},{"id":23173,"node_id":"MDU6TGFiZWwyMzE3Mw==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Ebug","name":">bug","color":"b60205","default":false},{"id":1102494662,"node_id":"MDU6TGFiZWwxMTAyNDk0NjYy","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v6.6.0","name":"v6.6.0","color":"dddddd","default":false},{"id":484855464,"node_id":"MDU6TGFiZWw0ODQ4NTU0NjQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/36498/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/36498/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/36498/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/e0f847a1beb2bdcf6769c2c26d7a328a44803a1d","head":{"label":"astefan:36483_fix","ref":"36483_fix","sha":"e0f847a1beb2bdcf6769c2c26d7a328a44803a1d","user":{"login":"astefan","id":893749,"node_id":"MDQ6VXNlcjg5Mzc0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/893749?v=4","gravatar_id":"","url":"https://api.github.com/users/astefan","html_url":"https://github.com/astefan","followers_url":"https://api.github.com/users/astefan/followers","following_url":"https://api.github.com/users/astefan/following{/other_user}","gists_url":"https://api.github.com/users/astefan/gists{/gist_id}","starred_url":"https://api.github.com/users/astefan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astefan/subscriptions","organizations_url":"https://api.github.com/users/astefan/orgs","repos_url":"https://api.github.com/users/astefan/repos","events_url":"https://api.github.com/users/astefan/events{/privacy}","received_events_url":"https://api.github.com/users/astefan/received_events","type":"User","site_admin":false},"repo":{"id":133608956,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM2MDg5NTY=","name":"elasticsearch","full_name":"astefan/elasticsearch","private":false,"owner":{"login":"astefan","id":893749,"node_id":"MDQ6VXNlcjg5Mzc0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/893749?v=4","gravatar_id":"","url":"https://api.github.com/users/astefan","html_url":"https://github.com/astefan","followers_url":"https://api.github.com/users/astefan/followers","following_url":"https://api.github.com/users/astefan/following{/other_user}","gists_url":"https://api.github.com/users/astefan/gists{/gist_id}","starred_url":"https://api.github.com/users/astefan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astefan/subscriptions","organizations_url":"https://api.github.com/users/astefan/orgs","repos_url":"https://api.github.com/users/astefan/repos","events_url":"https://api.github.com/users/astefan/events{/privacy}","received_events_url":"https://api.github.com/users/astefan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/astefan/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/astefan/elasticsearch","forks_url":"https://api.github.com/repos/astefan/elasticsearch/forks","keys_url":"https://api.github.com/repos/astefan/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astefan/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astefan/elasticsearch/teams","hooks_url":"https://api.github.com/repos/astefan/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/astefan/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/astefan/elasticsearch/events","assignees_url":"https://api.github.com/repos/astefan/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/astefan/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/astefan/elasticsearch/tags","blobs_url":"https://api.github.com/repos/astefan/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astefan/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astefan/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/astefan/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astefan/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/astefan/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/astefan/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/astefan/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/astefan/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/astefan/elasticsearch/subscription","commits_url":"https://api.github.com/repos/astefan/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/astefan/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/astefan/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/astefan/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/astefan/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/astefan/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astefan/elasticsearch/merges","archive_url":"https://api.github.com/repos/astefan/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astefan/elasticsearch/downloads","issues_url":"https://api.github.com/repos/astefan/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/astefan/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/astefan/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/astefan/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astefan/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/astefan/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/astefan/elasticsearch/deployments","created_at":"2018-05-16T04:08:17Z","updated_at":"2018-06-04T10:33:41Z","pushed_at":"2018-12-12T00:20:11Z","git_url":"git://github.com/astefan/elasticsearch.git","ssh_url":"git@github.com:astefan/elasticsearch.git","clone_url":"https://github.com/astefan/elasticsearch.git","svn_url":"https://github.com/astefan/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":533042,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"c1e3bdd42d710838722919ae07ab75d246791ee5","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"node_id":"MDEwOlJlcG9zaXRvcnk1MDc3NzU=","name":"elasticsearch","full_name":"elastic/elasticsearch","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2018-12-12T10:35:53Z","pushed_at":"2018-12-12T10:35:57Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":541337,"stargazers_count":36724,"watchers_count":36724,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12392,"mirror_url":null,"archived":false,"open_issues_count":1832,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12392,"open_issues":1832,"watchers":36724,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/36498"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/36498"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/36498"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/36498/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/36498/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/36498/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/e0f847a1beb2bdcf6769c2c26d7a328a44803a1d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"astefan"}}