{"action":"created","comment":{"url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/comments/167890108","pull_request_review_id":96171651,"id":167890108,"diff_hunk":"@@ -293,7 +293,7 @@ type Renter interface {\n \n \t// Download performs a download according to the parameters passed, including\n \t// downloads of `offset` and `length` type.\n-\tDownload(params RenterDownloadParameters) error\n+\tDownload(params RenterDownloadParameters) chan error","path":"modules/renter.go","position":5,"original_position":5,"commit_id":"a13c122f5351f8ddb62d4859df45fcf957651e30","original_commit_id":"a13c122f5351f8ddb62d4859df45fcf957651e30","user":{"login":"ChrisSchinnerl","id":3903476,"avatar_url":"https://avatars0.githubusercontent.com/u/3903476?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisSchinnerl","html_url":"https://github.com/ChrisSchinnerl","followers_url":"https://api.github.com/users/ChrisSchinnerl/followers","following_url":"https://api.github.com/users/ChrisSchinnerl/following{/other_user}","gists_url":"https://api.github.com/users/ChrisSchinnerl/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisSchinnerl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisSchinnerl/subscriptions","organizations_url":"https://api.github.com/users/ChrisSchinnerl/orgs","repos_url":"https://api.github.com/users/ChrisSchinnerl/repos","events_url":"https://api.github.com/users/ChrisSchinnerl/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisSchinnerl/received_events","type":"User","site_admin":false},"body":"Yes, without this change there is a race condition between the Download api call and the downloadqueue api call. Previously if you called Download, there was no guarantee that the download actually made it into the downloadqueue before the next call to downloadqueue. That's because we only waited for a fixed time of 100ms instead of returning a channel.","created_at":"2018-02-13T15:01:06Z","updated_at":"2018-02-13T15:01:07Z","html_url":"https://github.com/NebulousLabs/Sia/pull/2737#discussion_r167890108","pull_request_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/2737","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/comments/167890108"},"html":{"href":"https://github.com/NebulousLabs/Sia/pull/2737#discussion_r167890108"},"pull_request":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/2737"}},"in_reply_to_id":167786414},"pull_request":{"url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/2737","id":167477568,"html_url":"https://github.com/NebulousLabs/Sia/pull/2737","diff_url":"https://github.com/NebulousLabs/Sia/pull/2737.diff","patch_url":"https://github.com/NebulousLabs/Sia/pull/2737.patch","issue_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/2737","number":2737,"state":"open","locked":false,"title":"Add upload and download helpers to siatest package","user":{"login":"ChrisSchinnerl","id":3903476,"avatar_url":"https://avatars0.githubusercontent.com/u/3903476?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisSchinnerl","html_url":"https://github.com/ChrisSchinnerl","followers_url":"https://api.github.com/users/ChrisSchinnerl/followers","following_url":"https://api.github.com/users/ChrisSchinnerl/following{/other_user}","gists_url":"https://api.github.com/users/ChrisSchinnerl/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisSchinnerl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisSchinnerl/subscriptions","organizations_url":"https://api.github.com/users/ChrisSchinnerl/orgs","repos_url":"https://api.github.com/users/ChrisSchinnerl/repos","events_url":"https://api.github.com/users/ChrisSchinnerl/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisSchinnerl/received_events","type":"User","site_admin":false},"body":"This PR extends the siatest package to be able to easily create TestFiles and upload/download them to/from hosts.","created_at":"2018-02-06T17:20:55Z","updated_at":"2018-02-13T15:01:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1c7d468516b88dbf30fda742af9287b7ab4f21b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/2737/commits","review_comments_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/2737/comments","review_comment_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/2737/comments","statuses_url":"https://api.github.com/repos/NebulousLabs/Sia/statuses/a13c122f5351f8ddb62d4859df45fcf957651e30","head":{"label":"NebulousLabs:siatest-upload-download","ref":"siatest-upload-download","sha":"a13c122f5351f8ddb62d4859df45fcf957651e30","user":{"login":"NebulousLabs","id":7471422,"avatar_url":"https://avatars1.githubusercontent.com/u/7471422?v=4","gravatar_id":"","url":"https://api.github.com/users/NebulousLabs","html_url":"https://github.com/NebulousLabs","followers_url":"https://api.github.com/users/NebulousLabs/followers","following_url":"https://api.github.com/users/NebulousLabs/following{/other_user}","gists_url":"https://api.github.com/users/NebulousLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NebulousLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebulousLabs/subscriptions","organizations_url":"https://api.github.com/users/NebulousLabs/orgs","repos_url":"https://api.github.com/users/NebulousLabs/repos","events_url":"https://api.github.com/users/NebulousLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NebulousLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":25370072,"name":"Sia","full_name":"NebulousLabs/Sia","owner":{"login":"NebulousLabs","id":7471422,"avatar_url":"https://avatars1.githubusercontent.com/u/7471422?v=4","gravatar_id":"","url":"https://api.github.com/users/NebulousLabs","html_url":"https://github.com/NebulousLabs","followers_url":"https://api.github.com/users/NebulousLabs/followers","following_url":"https://api.github.com/users/NebulousLabs/following{/other_user}","gists_url":"https://api.github.com/users/NebulousLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NebulousLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebulousLabs/subscriptions","organizations_url":"https://api.github.com/users/NebulousLabs/orgs","repos_url":"https://api.github.com/users/NebulousLabs/repos","events_url":"https://api.github.com/users/NebulousLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NebulousLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NebulousLabs/Sia","description":"Blockchain-based marketplace for file storage","fork":false,"url":"https://api.github.com/repos/NebulousLabs/Sia","forks_url":"https://api.github.com/repos/NebulousLabs/Sia/forks","keys_url":"https://api.github.com/repos/NebulousLabs/Sia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NebulousLabs/Sia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NebulousLabs/Sia/teams","hooks_url":"https://api.github.com/repos/NebulousLabs/Sia/hooks","issue_events_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/events{/number}","events_url":"https://api.github.com/repos/NebulousLabs/Sia/events","assignees_url":"https://api.github.com/repos/NebulousLabs/Sia/assignees{/user}","branches_url":"https://api.github.com/repos/NebulousLabs/Sia/branches{/branch}","tags_url":"https://api.github.com/repos/NebulousLabs/Sia/tags","blobs_url":"https://api.github.com/repos/NebulousLabs/Sia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NebulousLabs/Sia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NebulousLabs/Sia/git/refs{/sha}","trees_url":"https://api.github.com/repos/NebulousLabs/Sia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NebulousLabs/Sia/statuses/{sha}","languages_url":"https://api.github.com/repos/NebulousLabs/Sia/languages","stargazers_url":"https://api.github.com/repos/NebulousLabs/Sia/stargazers","contributors_url":"https://api.github.com/repos/NebulousLabs/Sia/contributors","subscribers_url":"https://api.github.com/repos/NebulousLabs/Sia/subscribers","subscription_url":"https://api.github.com/repos/NebulousLabs/Sia/subscription","commits_url":"https://api.github.com/repos/NebulousLabs/Sia/commits{/sha}","git_commits_url":"https://api.github.com/repos/NebulousLabs/Sia/git/commits{/sha}","comments_url":"https://api.github.com/repos/NebulousLabs/Sia/comments{/number}","issue_comment_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/comments{/number}","contents_url":"https://api.github.com/repos/NebulousLabs/Sia/contents/{+path}","compare_url":"https://api.github.com/repos/NebulousLabs/Sia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NebulousLabs/Sia/merges","archive_url":"https://api.github.com/repos/NebulousLabs/Sia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NebulousLabs/Sia/downloads","issues_url":"https://api.github.com/repos/NebulousLabs/Sia/issues{/number}","pulls_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls{/number}","milestones_url":"https://api.github.com/repos/NebulousLabs/Sia/milestones{/number}","notifications_url":"https://api.github.com/repos/NebulousLabs/Sia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NebulousLabs/Sia/labels{/name}","releases_url":"https://api.github.com/repos/NebulousLabs/Sia/releases{/id}","deployments_url":"https://api.github.com/repos/NebulousLabs/Sia/deployments","created_at":"2014-10-17T17:50:25Z","updated_at":"2018-02-13T09:37:55Z","pushed_at":"2018-02-13T13:35:59Z","git_url":"git://github.com/NebulousLabs/Sia.git","ssh_url":"git@github.com:NebulousLabs/Sia.git","clone_url":"https://github.com/NebulousLabs/Sia.git","svn_url":"https://github.com/NebulousLabs/Sia","homepage":"https://sia.tech","size":20626,"stargazers_count":2358,"watchers_count":2358,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":337,"mirror_url":null,"archived":false,"open_issues_count":160,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":337,"open_issues":160,"watchers":2358,"default_branch":"master"}},"base":{"label":"NebulousLabs:master","ref":"master","sha":"77bc1a0ac5a00a83e3cabc6ad788625a71966c52","user":{"login":"NebulousLabs","id":7471422,"avatar_url":"https://avatars1.githubusercontent.com/u/7471422?v=4","gravatar_id":"","url":"https://api.github.com/users/NebulousLabs","html_url":"https://github.com/NebulousLabs","followers_url":"https://api.github.com/users/NebulousLabs/followers","following_url":"https://api.github.com/users/NebulousLabs/following{/other_user}","gists_url":"https://api.github.com/users/NebulousLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NebulousLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebulousLabs/subscriptions","organizations_url":"https://api.github.com/users/NebulousLabs/orgs","repos_url":"https://api.github.com/users/NebulousLabs/repos","events_url":"https://api.github.com/users/NebulousLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NebulousLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":25370072,"name":"Sia","full_name":"NebulousLabs/Sia","owner":{"login":"NebulousLabs","id":7471422,"avatar_url":"https://avatars1.githubusercontent.com/u/7471422?v=4","gravatar_id":"","url":"https://api.github.com/users/NebulousLabs","html_url":"https://github.com/NebulousLabs","followers_url":"https://api.github.com/users/NebulousLabs/followers","following_url":"https://api.github.com/users/NebulousLabs/following{/other_user}","gists_url":"https://api.github.com/users/NebulousLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NebulousLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebulousLabs/subscriptions","organizations_url":"https://api.github.com/users/NebulousLabs/orgs","repos_url":"https://api.github.com/users/NebulousLabs/repos","events_url":"https://api.github.com/users/NebulousLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NebulousLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NebulousLabs/Sia","description":"Blockchain-based marketplace for file storage","fork":false,"url":"https://api.github.com/repos/NebulousLabs/Sia","forks_url":"https://api.github.com/repos/NebulousLabs/Sia/forks","keys_url":"https://api.github.com/repos/NebulousLabs/Sia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NebulousLabs/Sia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NebulousLabs/Sia/teams","hooks_url":"https://api.github.com/repos/NebulousLabs/Sia/hooks","issue_events_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/events{/number}","events_url":"https://api.github.com/repos/NebulousLabs/Sia/events","assignees_url":"https://api.github.com/repos/NebulousLabs/Sia/assignees{/user}","branches_url":"https://api.github.com/repos/NebulousLabs/Sia/branches{/branch}","tags_url":"https://api.github.com/repos/NebulousLabs/Sia/tags","blobs_url":"https://api.github.com/repos/NebulousLabs/Sia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NebulousLabs/Sia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NebulousLabs/Sia/git/refs{/sha}","trees_url":"https://api.github.com/repos/NebulousLabs/Sia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NebulousLabs/Sia/statuses/{sha}","languages_url":"https://api.github.com/repos/NebulousLabs/Sia/languages","stargazers_url":"https://api.github.com/repos/NebulousLabs/Sia/stargazers","contributors_url":"https://api.github.com/repos/NebulousLabs/Sia/contributors","subscribers_url":"https://api.github.com/repos/NebulousLabs/Sia/subscribers","subscription_url":"https://api.github.com/repos/NebulousLabs/Sia/subscription","commits_url":"https://api.github.com/repos/NebulousLabs/Sia/commits{/sha}","git_commits_url":"https://api.github.com/repos/NebulousLabs/Sia/git/commits{/sha}","comments_url":"https://api.github.com/repos/NebulousLabs/Sia/comments{/number}","issue_comment_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/comments{/number}","contents_url":"https://api.github.com/repos/NebulousLabs/Sia/contents/{+path}","compare_url":"https://api.github.com/repos/NebulousLabs/Sia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NebulousLabs/Sia/merges","archive_url":"https://api.github.com/repos/NebulousLabs/Sia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NebulousLabs/Sia/downloads","issues_url":"https://api.github.com/repos/NebulousLabs/Sia/issues{/number}","pulls_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls{/number}","milestones_url":"https://api.github.com/repos/NebulousLabs/Sia/milestones{/number}","notifications_url":"https://api.github.com/repos/NebulousLabs/Sia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NebulousLabs/Sia/labels{/name}","releases_url":"https://api.github.com/repos/NebulousLabs/Sia/releases{/id}","deployments_url":"https://api.github.com/repos/NebulousLabs/Sia/deployments","created_at":"2014-10-17T17:50:25Z","updated_at":"2018-02-13T09:37:55Z","pushed_at":"2018-02-13T13:35:59Z","git_url":"git://github.com/NebulousLabs/Sia.git","ssh_url":"git@github.com:NebulousLabs/Sia.git","clone_url":"https://github.com/NebulousLabs/Sia.git","svn_url":"https://github.com/NebulousLabs/Sia","homepage":"https://sia.tech","size":20626,"stargazers_count":2358,"watchers_count":2358,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":337,"mirror_url":null,"archived":false,"open_issues_count":160,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":337,"open_issues":160,"watchers":2358,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/2737"},"html":{"href":"https://github.com/NebulousLabs/Sia/pull/2737"},"issue":{"href":"https://api.github.com/repos/NebulousLabs/Sia/issues/2737"},"comments":{"href":"https://api.github.com/repos/NebulousLabs/Sia/issues/2737/comments"},"review_comments":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/2737/comments"},"review_comment":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/2737/commits"},"statuses":{"href":"https://api.github.com/repos/NebulousLabs/Sia/statuses/a13c122f5351f8ddb62d4859df45fcf957651e30"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ChrisSchinnerl"}}