{"action":"created","issue":{"url":"https://api.github.com/repos/bluesat/arduino-backup/issues/3","repository_url":"https://api.github.com/repos/bluesat/arduino-backup","labels_url":"https://api.github.com/repos/bluesat/arduino-backup/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/bluesat/arduino-backup/issues/3/comments","events_url":"https://api.github.com/repos/bluesat/arduino-backup/issues/3/events","html_url":"https://github.com/bluesat/arduino-backup/pull/3","id":358890718,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NTE1MDMz","number":3,"title":"Lidar nuc comms","user":{"login":"sajidanower23","id":20970821,"node_id":"MDQ6VXNlcjIwOTcwODIx","avatar_url":"https://avatars0.githubusercontent.com/u/20970821?v=4","gravatar_id":"","url":"https://api.github.com/users/sajidanower23","html_url":"https://github.com/sajidanower23","followers_url":"https://api.github.com/users/sajidanower23/followers","following_url":"https://api.github.com/users/sajidanower23/following{/other_user}","gists_url":"https://api.github.com/users/sajidanower23/gists{/gist_id}","starred_url":"https://api.github.com/users/sajidanower23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sajidanower23/subscriptions","organizations_url":"https://api.github.com/users/sajidanower23/orgs","repos_url":"https://api.github.com/users/sajidanower23/repos","events_url":"https://api.github.com/users/sajidanower23/events{/privacy}","received_events_url":"https://api.github.com/users/sajidanower23/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"sajidanower23","id":20970821,"node_id":"MDQ6VXNlcjIwOTcwODIx","avatar_url":"https://avatars0.githubusercontent.com/u/20970821?v=4","gravatar_id":"","url":"https://api.github.com/users/sajidanower23","html_url":"https://github.com/sajidanower23","followers_url":"https://api.github.com/users/sajidanower23/followers","following_url":"https://api.github.com/users/sajidanower23/following{/other_user}","gists_url":"https://api.github.com/users/sajidanower23/gists{/gist_id}","starred_url":"https://api.github.com/users/sajidanower23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sajidanower23/subscriptions","organizations_url":"https://api.github.com/users/sajidanower23/orgs","repos_url":"https://api.github.com/users/sajidanower23/repos","events_url":"https://api.github.com/users/sajidanower23/events{/privacy}","received_events_url":"https://api.github.com/users/sajidanower23/received_events","type":"User","site_admin":false},"assignees":[{"login":"sajidanower23","id":20970821,"node_id":"MDQ6VXNlcjIwOTcwODIx","avatar_url":"https://avatars0.githubusercontent.com/u/20970821?v=4","gravatar_id":"","url":"https://api.github.com/users/sajidanower23","html_url":"https://github.com/sajidanower23","followers_url":"https://api.github.com/users/sajidanower23/followers","following_url":"https://api.github.com/users/sajidanower23/following{/other_user}","gists_url":"https://api.github.com/users/sajidanower23/gists{/gist_id}","starred_url":"https://api.github.com/users/sajidanower23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sajidanower23/subscriptions","organizations_url":"https://api.github.com/users/sajidanower23/orgs","repos_url":"https://api.github.com/users/sajidanower23/repos","events_url":"https://api.github.com/users/sajidanower23/events{/privacy}","received_events_url":"https://api.github.com/users/sajidanower23/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-09-11T05:22:32Z","updated_at":"2018-09-11T09:03:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bluesat/arduino-backup/pulls/3","html_url":"https://github.com/bluesat/arduino-backup/pull/3","diff_url":"https://github.com/bluesat/arduino-backup/pull/3.diff","patch_url":"https://github.com/bluesat/arduino-backup/pull/3.patch"},"body":"- Adds a way for the NUC to communicate with the servo that moves the LIDAR.\r\n- Cleans up redundant dirs, adds some style tweaks\r\n- [ ]  Has been tested on the rover"},"comment":{"url":"https://api.github.com/repos/bluesat/arduino-backup/issues/comments/420201596","html_url":"https://github.com/bluesat/arduino-backup/pull/3#issuecomment-420201596","issue_url":"https://api.github.com/repos/bluesat/arduino-backup/issues/3","id":420201596,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDIwMTU5Ng==","user":{"login":"hjed","id":6956262,"node_id":"MDQ6VXNlcjY5NTYyNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6956262?v=4","gravatar_id":"","url":"https://api.github.com/users/hjed","html_url":"https://github.com/hjed","followers_url":"https://api.github.com/users/hjed/followers","following_url":"https://api.github.com/users/hjed/following{/other_user}","gists_url":"https://api.github.com/users/hjed/gists{/gist_id}","starred_url":"https://api.github.com/users/hjed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjed/subscriptions","organizations_url":"https://api.github.com/users/hjed/orgs","repos_url":"https://api.github.com/users/hjed/repos","events_url":"https://api.github.com/users/hjed/events{/privacy}","received_events_url":"https://api.github.com/users/hjed/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T09:03:40Z","updated_at":"2018-09-11T09:03:40Z","author_association":"MEMBER","body":"There is already code that produces the same result as this using the existing arduino code (sweepLidar.py).\r\n\r\nThe way you're doing it won't be compatible with the localisation system as it needs to get the current position of the servo (which board ctrl does). The existing code that communicates with the arduino also allows you to switch between tilting and none tilting versions of the gimbal so you can use it as a camera gimble in the other tasks. \r\n\r\nI would also recommend getting slam, etc working without tilting first. Most likely you'll just have it on a specific angle for the competition as tilt is hard to get the acurate transforms for (crosbot can be configured to account for this though).  \r\n\r\n Its also worth noting with this that the code that communicates with the arduino (board control) publishes join_states for all of the servos. This will conflict with the jointGuess code used in the localisation. "}}
{"actor":{"display_login":"hjed"}}