{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Blazor/pulls/comments/190670828","pull_request_review_id":123098233,"id":190670828,"diff_hunk":"@@ -6,14 +6,50 @@\n     <!-- Local alternative to <RunArguments>blazor serve</RunArguments> -->\n     <RunCommand>dotnet</RunCommand>\n     <RunArguments>run --project ../../../src/Microsoft.AspNetCore.Blazor.Cli serve --pathbase /subdir</RunArguments>\n+    <TypeScriptToolsVersion>2.8</TypeScriptToolsVersion>\n   </PropertyGroup>\n \n   <!-- Local alternative to <PackageReference Include=\"Microsoft.AspNetCore.Blazor.Build\" /> -->\n   <Import Project=\"..\\..\\..\\src\\Microsoft.AspNetCore.Blazor.Build\\ReferenceFromSource.props\" />\n+  <ItemGroup>\n+    <BlazorGenerate Remove=\"InteropTest\\InteropComponent.cshtml\" />\n+    <BlazorGenerate Remove=\"InteropTest\\TreeNode.cshtml\" />\n+  </ItemGroup>\n+  <ItemGroup>\n+    <Content Remove=\"wwwroot\\js\\interopTests.ts\" />\n+  </ItemGroup>\n   <ItemGroup>\n     <ProjectReference Include=\"..\\..\\..\\src\\Microsoft.AspNetCore.Blazor.Browser\\Microsoft.AspNetCore.Blazor.Browser.csproj\" />\n     <ProjectReference Include=\"..\\..\\..\\src\\Microsoft.AspNetCore.Blazor\\Microsoft.AspNetCore.Blazor.csproj\" />\n     <ProjectReference Include=\"..\\TestContentPackage\\TestContentPackage.csproj\" />\n   </ItemGroup>\n+  <ItemGroup>\n+    <TypeScriptCompile Include=\"wwwroot\\js\\interopTests.ts\" />\n+  </ItemGroup>\n+  <ItemGroup>\n+    <Content Update=\"InteropTest\\TreeNode.cshtml\">\n+      <Pack>$(IncludeRazorContentInPack)</Pack>\n+    </Content>\n+    <Content Update=\"InteropComponent.cshtml\">\n+      <Pack>$(IncludeRazorContentInPack)</Pack>\n+    </Content>\n+  </ItemGroup>\n+  <PropertyGroup>\n+    <TypeScriptTarget>ES5</TypeScriptTarget>\n+    <TypeScriptDownlevelIteration>True</TypeScriptDownlevelIteration>\n+    <TypeScriptLib>es2015,dom</TypeScriptLib>\n+    <TypeScriptJSXEmit>None</TypeScriptJSXEmit>\n+    <TypeScriptModuleKind>None</TypeScriptModuleKind>\n+    <TypeScriptCompileOnSaveEnabled>True</TypeScriptCompileOnSaveEnabled>\n+    <TypeScriptNoImplicitAny>False</TypeScriptNoImplicitAny>\n+    <TypeScriptRemoveComments>False</TypeScriptRemoveComments>\n+    <TypeScriptOutFile />\n+    <TypeScriptOutDir />\n+    <TypeScriptGeneratesDeclarations>False</TypeScriptGeneratesDeclarations>\n+    <TypeScriptNoEmitOnError>True</TypeScriptNoEmitOnError>\n+    <TypeScriptSourceMap>True</TypeScriptSourceMap>\n+    <TypeScriptMapRoot />\n+    <TypeScriptSourceRoot />","path":"test/testapps/BasicTestApp/BasicTestApp.csproj","position":47,"original_position":47,"commit_id":"a43da55044c1d888892797ecccdd66edd50eb0ce","original_commit_id":"a43da55044c1d888892797ecccdd66edd50eb0ce","user":{"login":"javiercn","id":6995051,"avatar_url":"https://avatars2.githubusercontent.com/u/6995051?v=4","gravatar_id":"","url":"https://api.github.com/users/javiercn","html_url":"https://github.com/javiercn","followers_url":"https://api.github.com/users/javiercn/followers","following_url":"https://api.github.com/users/javiercn/following{/other_user}","gists_url":"https://api.github.com/users/javiercn/gists{/gist_id}","starred_url":"https://api.github.com/users/javiercn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiercn/subscriptions","organizations_url":"https://api.github.com/users/javiercn/orgs","repos_url":"https://api.github.com/users/javiercn/repos","events_url":"https://api.github.com/users/javiercn/events{/privacy}","received_events_url":"https://api.github.com/users/javiercn/received_events","type":"User","site_admin":false},"body":"Yeah, this needs cleanup. I'll webpackify all these things","created_at":"2018-05-24T17:36:54Z","updated_at":"2018-05-24T17:36:54Z","html_url":"https://github.com/aspnet/Blazor/pull/880#discussion_r190670828","pull_request_url":"https://api.github.com/repos/aspnet/Blazor/pulls/880","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/comments/190670828"},"html":{"href":"https://github.com/aspnet/Blazor/pull/880#discussion_r190670828"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/880"}},"in_reply_to_id":190552965},"pull_request":{"url":"https://api.github.com/repos/aspnet/Blazor/pulls/880","id":190110904,"html_url":"https://github.com/aspnet/Blazor/pull/880","diff_url":"https://github.com/aspnet/Blazor/pull/880.diff","patch_url":"https://github.com/aspnet/Blazor/pull/880.patch","issue_url":"https://api.github.com/repos/aspnet/Blazor/issues/880","number":880,"state":"open","locked":false,"title":"[WIP] Interop","user":{"login":"javiercn","id":6995051,"avatar_url":"https://avatars2.githubusercontent.com/u/6995051?v=4","gravatar_id":"","url":"https://api.github.com/users/javiercn","html_url":"https://github.com/javiercn","followers_url":"https://api.github.com/users/javiercn/followers","following_url":"https://api.github.com/users/javiercn/following{/other_user}","gists_url":"https://api.github.com/users/javiercn/gists{/gist_id}","starred_url":"https://api.github.com/users/javiercn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiercn/subscriptions","organizations_url":"https://api.github.com/users/javiercn/orgs","repos_url":"https://api.github.com/users/javiercn/repos","events_url":"https://api.github.com/users/javiercn/events{/privacy}","received_events_url":"https://api.github.com/users/javiercn/received_events","type":"User","site_admin":false},"body":"## Goals\r\n* Introduces improved interop from calling .NET methods from JavaScript\r\n* Introduces support for calling asynchronous methods from JavaScript\r\n* Introduces support for calling asynchronous JavaScript functions from .NET\r\n## Remaining points\r\n* API cleanup.\r\n* Protocol/Implementation cleanup.\r\n* Exception handling.\r\n* More unit tests.","created_at":"2018-05-23T21:31:03Z","updated_at":"2018-05-24T17:36:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"938d764e6238b7681416e3c46ff8772487193cb5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Blazor/pulls/880/commits","review_comments_url":"https://api.github.com/repos/aspnet/Blazor/pulls/880/comments","review_comment_url":"https://api.github.com/repos/aspnet/Blazor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Blazor/issues/880/comments","statuses_url":"https://api.github.com/repos/aspnet/Blazor/statuses/a43da55044c1d888892797ecccdd66edd50eb0ce","head":{"label":"aspnet:javiercn/interop-cleanup","ref":"javiercn/interop-cleanup","sha":"a43da55044c1d888892797ecccdd66edd50eb0ce","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":116160755,"name":"Blazor","full_name":"aspnet/Blazor","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Blazor","description":"Blazor is an experimental .NET web framework using C#/Razor and HTML that runs in the browser with WebAssembly","fork":false,"url":"https://api.github.com/repos/aspnet/Blazor","forks_url":"https://api.github.com/repos/aspnet/Blazor/forks","keys_url":"https://api.github.com/repos/aspnet/Blazor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Blazor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Blazor/teams","hooks_url":"https://api.github.com/repos/aspnet/Blazor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Blazor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Blazor/events","assignees_url":"https://api.github.com/repos/aspnet/Blazor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Blazor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Blazor/tags","blobs_url":"https://api.github.com/repos/aspnet/Blazor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Blazor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Blazor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Blazor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Blazor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Blazor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Blazor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Blazor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Blazor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Blazor/subscription","commits_url":"https://api.github.com/repos/aspnet/Blazor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Blazor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Blazor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Blazor/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Blazor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Blazor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Blazor/merges","archive_url":"https://api.github.com/repos/aspnet/Blazor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Blazor/downloads","issues_url":"https://api.github.com/repos/aspnet/Blazor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Blazor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Blazor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Blazor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Blazor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Blazor/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Blazor/deployments","created_at":"2018-01-03T16:53:27Z","updated_at":"2018-05-24T17:23:59Z","pushed_at":"2018-05-24T14:55:09Z","git_url":"git://github.com/aspnet/Blazor.git","ssh_url":"git@github.com:aspnet/Blazor.git","clone_url":"https://github.com/aspnet/Blazor.git","svn_url":"https://github.com/aspnet/Blazor","homepage":"","size":131195,"stargazers_count":5018,"watchers_count":5018,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":425,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":425,"open_issues":111,"watchers":5018,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"9a90b3538b97c0629c048d9bbf527d7f70166591","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":116160755,"name":"Blazor","full_name":"aspnet/Blazor","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Blazor","description":"Blazor is an experimental .NET web framework using C#/Razor and HTML that runs in the browser with WebAssembly","fork":false,"url":"https://api.github.com/repos/aspnet/Blazor","forks_url":"https://api.github.com/repos/aspnet/Blazor/forks","keys_url":"https://api.github.com/repos/aspnet/Blazor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Blazor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Blazor/teams","hooks_url":"https://api.github.com/repos/aspnet/Blazor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Blazor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Blazor/events","assignees_url":"https://api.github.com/repos/aspnet/Blazor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Blazor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Blazor/tags","blobs_url":"https://api.github.com/repos/aspnet/Blazor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Blazor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Blazor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Blazor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Blazor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Blazor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Blazor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Blazor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Blazor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Blazor/subscription","commits_url":"https://api.github.com/repos/aspnet/Blazor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Blazor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Blazor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Blazor/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Blazor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Blazor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Blazor/merges","archive_url":"https://api.github.com/repos/aspnet/Blazor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Blazor/downloads","issues_url":"https://api.github.com/repos/aspnet/Blazor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Blazor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Blazor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Blazor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Blazor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Blazor/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Blazor/deployments","created_at":"2018-01-03T16:53:27Z","updated_at":"2018-05-24T17:23:59Z","pushed_at":"2018-05-24T14:55:09Z","git_url":"git://github.com/aspnet/Blazor.git","ssh_url":"git@github.com:aspnet/Blazor.git","clone_url":"https://github.com/aspnet/Blazor.git","svn_url":"https://github.com/aspnet/Blazor","homepage":"","size":131195,"stargazers_count":5018,"watchers_count":5018,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":425,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":425,"open_issues":111,"watchers":5018,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/880"},"html":{"href":"https://github.com/aspnet/Blazor/pull/880"},"issue":{"href":"https://api.github.com/repos/aspnet/Blazor/issues/880"},"comments":{"href":"https://api.github.com/repos/aspnet/Blazor/issues/880/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/880/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/880/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Blazor/statuses/a43da55044c1d888892797ecccdd66edd50eb0ce"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"javiercn"}}