{"action":"created","issue":{"url":"https://api.github.com/repos/transitland/transitland-datastore/issues/1241","repository_url":"https://api.github.com/repos/transitland/transitland-datastore","labels_url":"https://api.github.com/repos/transitland/transitland-datastore/issues/1241/labels{/name}","comments_url":"https://api.github.com/repos/transitland/transitland-datastore/issues/1241/comments","events_url":"https://api.github.com/repos/transitland/transitland-datastore/issues/1241/events","html_url":"https://github.com/transitland/transitland-datastore/issues/1241","id":347549226,"node_id":"MDU6SXNzdWUzNDc1NDkyMjY=","number":1241,"title":"Bug when service exceptions are outside service dates?","user":{"login":"josiekre","id":5776153,"node_id":"MDQ6VXNlcjU3NzYxNTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5776153?v=4","gravatar_id":"","url":"https://api.github.com/users/josiekre","html_url":"https://github.com/josiekre","followers_url":"https://api.github.com/users/josiekre/followers","following_url":"https://api.github.com/users/josiekre/following{/other_user}","gists_url":"https://api.github.com/users/josiekre/gists{/gist_id}","starred_url":"https://api.github.com/users/josiekre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josiekre/subscriptions","organizations_url":"https://api.github.com/users/josiekre/orgs","repos_url":"https://api.github.com/users/josiekre/repos","events_url":"https://api.github.com/users/josiekre/events{/privacy}","received_events_url":"https://api.github.com/users/josiekre/received_events","type":"User","site_admin":false},"labels":[{"id":136675293,"node_id":"MDU6TGFiZWwxMzY2NzUyOTM=","url":"https://api.github.com/repos/transitland/transitland-datastore/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-03T22:05:49Z","updated_at":"2018-08-24T20:58:38Z","closed_at":null,"author_association":"NONE","body":"I might be missing something, but I'm almost certain I've found a discrepancy between the original GTFS and the resulting schedules from `schedule_stop_pairs`.\r\n\r\nFor example, from SHA1 `ff834518ff5728fc178966b3465c5057c3ade019`, route `r-dqcjp-nm` for trips `47` and `48` have a service end date of `2018-12-25` but they should be `2018-03-31`. \r\n\r\nThere's a service exception on `2018-12-25` for this service ID (in GTFS `Red_Winter_Monday_Friday`), which is invalid because it is past the service end date. This might be what has caused the service end date in the API to span past its actual service date. \r\n\r\nI caught this because there are repetitive services for this route between `2018-03-31` until `2018-12-25` now when pulling data from the API."},"comment":{"url":"https://api.github.com/repos/transitland/transitland-datastore/issues/comments/415880817","html_url":"https://github.com/transitland/transitland-datastore/issues/1241#issuecomment-415880817","issue_url":"https://api.github.com/repos/transitland/transitland-datastore/issues/1241","id":415880817,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTg4MDgxNw==","user":{"login":"drewda","id":212369,"node_id":"MDQ6VXNlcjIxMjM2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/212369?v=4","gravatar_id":"","url":"https://api.github.com/users/drewda","html_url":"https://github.com/drewda","followers_url":"https://api.github.com/users/drewda/followers","following_url":"https://api.github.com/users/drewda/following{/other_user}","gists_url":"https://api.github.com/users/drewda/gists{/gist_id}","starred_url":"https://api.github.com/users/drewda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewda/subscriptions","organizations_url":"https://api.github.com/users/drewda/orgs","repos_url":"https://api.github.com/users/drewda/repos","events_url":"https://api.github.com/users/drewda/events{/privacy}","received_events_url":"https://api.github.com/users/drewda/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T20:58:38Z","updated_at":"2018-08-24T20:58:38Z","author_association":"MEMBER","body":"@josiekre you're right, this is likely a different issue than feed extension.\r\n\r\nFWIW, we do have a test to catch situations of service exceptions that are provided outside of actual service windows: https://github.com/transitland/transitland-datastore/blob/master/spec/models/schedule_stop_pair_spec.rb#L306-L322\r\n\r\nWe'll see if there are any other explanations for this behavior."}}
{"actor":{"display_login":"drewda"}}