{"action":"closed","number":117,"pull_request":{"url":"https://api.github.com/repos/mageplaza/magento-2-blog/pulls/117","id":169645622,"html_url":"https://github.com/mageplaza/magento-2-blog/pull/117","diff_url":"https://github.com/mageplaza/magento-2-blog/pull/117.diff","patch_url":"https://github.com/mageplaza/magento-2-blog/pull/117.patch","issue_url":"https://api.github.com/repos/mageplaza/magento-2-blog/issues/117","number":117,"state":"closed","locked":false,"title":"Update Collection.php","user":{"login":"ryantfowler","id":2093288,"avatar_url":"https://avatars3.githubusercontent.com/u/2093288?v=4","gravatar_id":"","url":"https://api.github.com/users/ryantfowler","html_url":"https://github.com/ryantfowler","followers_url":"https://api.github.com/users/ryantfowler/followers","following_url":"https://api.github.com/users/ryantfowler/following{/other_user}","gists_url":"https://api.github.com/users/ryantfowler/gists{/gist_id}","starred_url":"https://api.github.com/users/ryantfowler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryantfowler/subscriptions","organizations_url":"https://api.github.com/users/ryantfowler/orgs","repos_url":"https://api.github.com/users/ryantfowler/repos","events_url":"https://api.github.com/users/ryantfowler/events{/privacy}","received_events_url":"https://api.github.com/users/ryantfowler/received_events","type":"User","site_admin":false},"body":"### Description\r\nPropose removing class property $mainTable, as it's not required for anything. The only thing that was required for di compilation to work properly, was to define the type for the constructor parameter $mainTable within the phpdoc ... I have already tested out di compilation with m2.2.1 without the class property $mainTable, and it works.\r\n\r\n### Fixed Issues\r\n1. https://github.com/mageplaza/magento-2-blog/issues/116: Blog version 2.6.0 compile error\r\n\r\n### Manual testing scenarios\r\n1. git checkout tags/v2.6.0\r\n2. Edit constructor phpdoc in \\Mageplaza\\Blog\\Model\\ResourceModel\\Comment\\Grid\\Collection so that it contains the following: `@param string $mainTable`\r\n3. Run the following CLI command: `php bin/magento setup:di:compile`\r\n4. Verify that di compilation is successful and does *not* produce any errors, nor fails to complete.\r\n\r\n### Contribution checklist\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n","created_at":"2018-02-16T15:02:14Z","updated_at":"2018-02-16T15:11:36Z","closed_at":"2018-02-16T15:11:36Z","merged_at":"2018-02-16T15:11:35Z","merge_commit_sha":"100b196fe8aeb047ff10d015c7a5eab351ff6c08","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mageplaza/magento-2-blog/pulls/117/commits","review_comments_url":"https://api.github.com/repos/mageplaza/magento-2-blog/pulls/117/comments","review_comment_url":"https://api.github.com/repos/mageplaza/magento-2-blog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mageplaza/magento-2-blog/issues/117/comments","statuses_url":"https://api.github.com/repos/mageplaza/magento-2-blog/statuses/36ffa9fcb85d2d477a4e2d0d5e31de01f8958f1a","head":{"label":"ryantfowler:patch-1","ref":"patch-1","sha":"36ffa9fcb85d2d477a4e2d0d5e31de01f8958f1a","user":{"login":"ryantfowler","id":2093288,"avatar_url":"https://avatars3.githubusercontent.com/u/2093288?v=4","gravatar_id":"","url":"https://api.github.com/users/ryantfowler","html_url":"https://github.com/ryantfowler","followers_url":"https://api.github.com/users/ryantfowler/followers","following_url":"https://api.github.com/users/ryantfowler/following{/other_user}","gists_url":"https://api.github.com/users/ryantfowler/gists{/gist_id}","starred_url":"https://api.github.com/users/ryantfowler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryantfowler/subscriptions","organizations_url":"https://api.github.com/users/ryantfowler/orgs","repos_url":"https://api.github.com/users/ryantfowler/repos","events_url":"https://api.github.com/users/ryantfowler/events{/privacy}","received_events_url":"https://api.github.com/users/ryantfowler/received_events","type":"User","site_admin":false},"repo":{"id":121762392,"name":"magento-2-blog","full_name":"ryantfowler/magento-2-blog","owner":{"login":"ryantfowler","id":2093288,"avatar_url":"https://avatars3.githubusercontent.com/u/2093288?v=4","gravatar_id":"","url":"https://api.github.com/users/ryantfowler","html_url":"https://github.com/ryantfowler","followers_url":"https://api.github.com/users/ryantfowler/followers","following_url":"https://api.github.com/users/ryantfowler/following{/other_user}","gists_url":"https://api.github.com/users/ryantfowler/gists{/gist_id}","starred_url":"https://api.github.com/users/ryantfowler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryantfowler/subscriptions","organizations_url":"https://api.github.com/users/ryantfowler/orgs","repos_url":"https://api.github.com/users/ryantfowler/repos","events_url":"https://api.github.com/users/ryantfowler/events{/privacy}","received_events_url":"https://api.github.com/users/ryantfowler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryantfowler/magento-2-blog","description":"Magento 2 Blog Extension is a better blog extension for Magento 2 platform. These include all useful features of Wordpress CMS","fork":true,"url":"https://api.github.com/repos/ryantfowler/magento-2-blog","forks_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/forks","keys_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/teams","hooks_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/hooks","issue_events_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/issues/events{/number}","events_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/events","assignees_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/assignees{/user}","branches_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/branches{/branch}","tags_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/tags","blobs_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/statuses/{sha}","languages_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/languages","stargazers_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/stargazers","contributors_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/contributors","subscribers_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/subscribers","subscription_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/subscription","commits_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/contents/{+path}","compare_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/merges","archive_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/downloads","issues_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/issues{/number}","pulls_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/pulls{/number}","milestones_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/milestones{/number}","notifications_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/labels{/name}","releases_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/releases{/id}","deployments_url":"https://api.github.com/repos/ryantfowler/magento-2-blog/deployments","created_at":"2018-02-16T14:51:50Z","updated_at":"2018-02-16T14:51:52Z","pushed_at":"2018-02-16T14:55:44Z","git_url":"git://github.com/ryantfowler/magento-2-blog.git","ssh_url":"git@github.com:ryantfowler/magento-2-blog.git","clone_url":"https://github.com/ryantfowler/magento-2-blog.git","svn_url":"https://github.com/ryantfowler/magento-2-blog","homepage":"https://www.mageplaza.com/magento-2-blog-extension/","size":2364,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mageplaza:develop","ref":"develop","sha":"18bc38ae1f9b2e0f31ee3ed0145132d0c8142e15","user":{"login":"mageplaza","id":17243247,"avatar_url":"https://avatars1.githubusercontent.com/u/17243247?v=4","gravatar_id":"","url":"https://api.github.com/users/mageplaza","html_url":"https://github.com/mageplaza","followers_url":"https://api.github.com/users/mageplaza/followers","following_url":"https://api.github.com/users/mageplaza/following{/other_user}","gists_url":"https://api.github.com/users/mageplaza/gists{/gist_id}","starred_url":"https://api.github.com/users/mageplaza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mageplaza/subscriptions","organizations_url":"https://api.github.com/users/mageplaza/orgs","repos_url":"https://api.github.com/users/mageplaza/repos","events_url":"https://api.github.com/users/mageplaza/events{/privacy}","received_events_url":"https://api.github.com/users/mageplaza/received_events","type":"Organization","site_admin":false},"repo":{"id":57097263,"name":"magento-2-blog","full_name":"mageplaza/magento-2-blog","owner":{"login":"mageplaza","id":17243247,"avatar_url":"https://avatars1.githubusercontent.com/u/17243247?v=4","gravatar_id":"","url":"https://api.github.com/users/mageplaza","html_url":"https://github.com/mageplaza","followers_url":"https://api.github.com/users/mageplaza/followers","following_url":"https://api.github.com/users/mageplaza/following{/other_user}","gists_url":"https://api.github.com/users/mageplaza/gists{/gist_id}","starred_url":"https://api.github.com/users/mageplaza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mageplaza/subscriptions","organizations_url":"https://api.github.com/users/mageplaza/orgs","repos_url":"https://api.github.com/users/mageplaza/repos","events_url":"https://api.github.com/users/mageplaza/events{/privacy}","received_events_url":"https://api.github.com/users/mageplaza/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mageplaza/magento-2-blog","description":"Magento 2 Blog Extension is a better blog extension for Magento 2 platform. These include all useful features of Wordpress CMS","fork":false,"url":"https://api.github.com/repos/mageplaza/magento-2-blog","forks_url":"https://api.github.com/repos/mageplaza/magento-2-blog/forks","keys_url":"https://api.github.com/repos/mageplaza/magento-2-blog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mageplaza/magento-2-blog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mageplaza/magento-2-blog/teams","hooks_url":"https://api.github.com/repos/mageplaza/magento-2-blog/hooks","issue_events_url":"https://api.github.com/repos/mageplaza/magento-2-blog/issues/events{/number}","events_url":"https://api.github.com/repos/mageplaza/magento-2-blog/events","assignees_url":"https://api.github.com/repos/mageplaza/magento-2-blog/assignees{/user}","branches_url":"https://api.github.com/repos/mageplaza/magento-2-blog/branches{/branch}","tags_url":"https://api.github.com/repos/mageplaza/magento-2-blog/tags","blobs_url":"https://api.github.com/repos/mageplaza/magento-2-blog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mageplaza/magento-2-blog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mageplaza/magento-2-blog/git/refs{/sha}","trees_url":"https://api.github.com/repos/mageplaza/magento-2-blog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mageplaza/magento-2-blog/statuses/{sha}","languages_url":"https://api.github.com/repos/mageplaza/magento-2-blog/languages","stargazers_url":"https://api.github.com/repos/mageplaza/magento-2-blog/stargazers","contributors_url":"https://api.github.com/repos/mageplaza/magento-2-blog/contributors","subscribers_url":"https://api.github.com/repos/mageplaza/magento-2-blog/subscribers","subscription_url":"https://api.github.com/repos/mageplaza/magento-2-blog/subscription","commits_url":"https://api.github.com/repos/mageplaza/magento-2-blog/commits{/sha}","git_commits_url":"https://api.github.com/repos/mageplaza/magento-2-blog/git/commits{/sha}","comments_url":"https://api.github.com/repos/mageplaza/magento-2-blog/comments{/number}","issue_comment_url":"https://api.github.com/repos/mageplaza/magento-2-blog/issues/comments{/number}","contents_url":"https://api.github.com/repos/mageplaza/magento-2-blog/contents/{+path}","compare_url":"https://api.github.com/repos/mageplaza/magento-2-blog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mageplaza/magento-2-blog/merges","archive_url":"https://api.github.com/repos/mageplaza/magento-2-blog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mageplaza/magento-2-blog/downloads","issues_url":"https://api.github.com/repos/mageplaza/magento-2-blog/issues{/number}","pulls_url":"https://api.github.com/repos/mageplaza/magento-2-blog/pulls{/number}","milestones_url":"https://api.github.com/repos/mageplaza/magento-2-blog/milestones{/number}","notifications_url":"https://api.github.com/repos/mageplaza/magento-2-blog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mageplaza/magento-2-blog/labels{/name}","releases_url":"https://api.github.com/repos/mageplaza/magento-2-blog/releases{/id}","deployments_url":"https://api.github.com/repos/mageplaza/magento-2-blog/deployments","created_at":"2016-04-26T04:15:39Z","updated_at":"2018-01-19T18:55:20Z","pushed_at":"2018-02-16T15:11:35Z","git_url":"git://github.com/mageplaza/magento-2-blog.git","ssh_url":"git@github.com:mageplaza/magento-2-blog.git","clone_url":"https://github.com/mageplaza/magento-2-blog.git","svn_url":"https://github.com/mageplaza/magento-2-blog","homepage":"https://www.mageplaza.com/magento-2-blog-extension/","size":2364,"stargazers_count":40,"watchers_count":40,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":30,"open_issues":17,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mageplaza/magento-2-blog/pulls/117"},"html":{"href":"https://github.com/mageplaza/magento-2-blog/pull/117"},"issue":{"href":"https://api.github.com/repos/mageplaza/magento-2-blog/issues/117"},"comments":{"href":"https://api.github.com/repos/mageplaza/magento-2-blog/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/mageplaza/magento-2-blog/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/mageplaza/magento-2-blog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mageplaza/magento-2-blog/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/mageplaza/magento-2-blog/statuses/36ffa9fcb85d2d477a4e2d0d5e31de01f8958f1a"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Kenny1994","id":26645811,"avatar_url":"https://avatars1.githubusercontent.com/u/26645811?v=4","gravatar_id":"","url":"https://api.github.com/users/Kenny1994","html_url":"https://github.com/Kenny1994","followers_url":"https://api.github.com/users/Kenny1994/followers","following_url":"https://api.github.com/users/Kenny1994/following{/other_user}","gists_url":"https://api.github.com/users/Kenny1994/gists{/gist_id}","starred_url":"https://api.github.com/users/Kenny1994/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kenny1994/subscriptions","organizations_url":"https://api.github.com/users/Kenny1994/orgs","repos_url":"https://api.github.com/users/Kenny1994/repos","events_url":"https://api.github.com/users/Kenny1994/events{/privacy}","received_events_url":"https://api.github.com/users/Kenny1994/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"Kenny1994"}}