{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28187","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28187/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28187/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28187/events","html_url":"https://github.com/Automattic/wp-calypso/pull/28187","id":375937788,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MjY2MTQx","number":28187,"title":"Gutenberg: Catch any Publicize API request errors","user":{"login":"tyxla","id":8436925,"node_id":"MDQ6VXNlcjg0MzY5MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/8436925?v=4","gravatar_id":"","url":"https://api.github.com/users/tyxla","html_url":"https://github.com/tyxla","followers_url":"https://api.github.com/users/tyxla/followers","following_url":"https://api.github.com/users/tyxla/following{/other_user}","gists_url":"https://api.github.com/users/tyxla/gists{/gist_id}","starred_url":"https://api.github.com/users/tyxla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyxla/subscriptions","organizations_url":"https://api.github.com/users/tyxla/orgs","repos_url":"https://api.github.com/users/tyxla/repos","events_url":"https://api.github.com/users/tyxla/events{/privacy}","received_events_url":"https://api.github.com/users/tyxla/received_events","type":"User","site_admin":false},"labels":[{"id":285009991,"node_id":"MDU6TGFiZWwyODUwMDk5OTE=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Jetpack","name":"Jetpack","color":"006b75","default":false},{"id":967391996,"node_id":"MDU6TGFiZWw5NjczOTE5OTY=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Goal]%20Gutenberg","name":"[Goal] Gutenberg","color":"97f4d2","default":false},{"id":285010018,"node_id":"MDU6TGFiZWwyODUwMTAwMTg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":285009976,"node_id":"MDU6TGFiZWwyODUwMDk5NzY=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":{"login":"tyxla","id":8436925,"node_id":"MDQ6VXNlcjg0MzY5MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/8436925?v=4","gravatar_id":"","url":"https://api.github.com/users/tyxla","html_url":"https://github.com/tyxla","followers_url":"https://api.github.com/users/tyxla/followers","following_url":"https://api.github.com/users/tyxla/following{/other_user}","gists_url":"https://api.github.com/users/tyxla/gists{/gist_id}","starred_url":"https://api.github.com/users/tyxla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyxla/subscriptions","organizations_url":"https://api.github.com/users/tyxla/orgs","repos_url":"https://api.github.com/users/tyxla/repos","events_url":"https://api.github.com/users/tyxla/events{/privacy}","received_events_url":"https://api.github.com/users/tyxla/received_events","type":"User","site_admin":false},"assignees":[{"login":"tyxla","id":8436925,"node_id":"MDQ6VXNlcjg0MzY5MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/8436925?v=4","gravatar_id":"","url":"https://api.github.com/users/tyxla","html_url":"https://github.com/tyxla","followers_url":"https://api.github.com/users/tyxla/followers","following_url":"https://api.github.com/users/tyxla/following{/other_user}","gists_url":"https://api.github.com/users/tyxla/gists{/gist_id}","starred_url":"https://api.github.com/users/tyxla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyxla/subscriptions","organizations_url":"https://api.github.com/users/tyxla/orgs","repos_url":"https://api.github.com/users/tyxla/repos","events_url":"https://api.github.com/users/tyxla/events{/privacy}","received_events_url":"https://api.github.com/users/tyxla/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-10-31T12:26:14Z","updated_at":"2018-11-01T12:34:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/28187","html_url":"https://github.com/Automattic/wp-calypso/pull/28187","diff_url":"https://github.com/Automattic/wp-calypso/pull/28187.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/28187.patch"},"body":"#### Changes proposed in this Pull Request\r\n\r\n* Catch any of the Publicize API request errors. While we could be more informative or helpful in some cases, this should do for now.\r\n* Add Publicize to the Jetpack stable preset to allow easier testing. We can always remove it before shipping a new `jetpack-blocks` version.\r\n\r\n#### Testing instructions\r\n\r\n* Spin up a site with this branch and the `add/publicize-rest-api` JP branch - https://jurassic.ninja/create?shortlived&gutenpack&gutenberg&calypsobranch=gutenberg/tighten-publicize-api-requests&branch=add/publicize-rest-api\r\n* Write a new post.\r\n* Attempt to publish the post.\r\n* Verify the Publicize block works like it did before in the pre-publish panel:\r\n  * Try with one or more connections, verify they load properly.\r\n  * Try with no connections, verify you can properly see the list of services available for connecting.\r\n    * Try connecting a service from the list, verify it leads you to the settings page for connecting a service.\r\n  * Try refreshing connections when you have and when you don't have connections.\r\n* Spin up a site with this branch and JP master - https://jurassic.ninja/create?shortlived&gutenpack&gutenberg&calypsobranch=gutenberg/tighten-publicize-api-requests\r\n  * Note that this branch will 404 on all Publicize API requests\r\n* Write a new post.\r\n* Attempt to publish the post.\r\n* Play with Publicize in the same cases and verify that although endpoints return 404s, that doesn't break the block or throw errors.\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/435026979","html_url":"https://github.com/Automattic/wp-calypso/pull/28187#issuecomment-435026979","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28187","id":435026979,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTAyNjk3OQ==","user":{"login":"tyxla","id":8436925,"node_id":"MDQ6VXNlcjg0MzY5MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/8436925?v=4","gravatar_id":"","url":"https://api.github.com/users/tyxla","html_url":"https://github.com/tyxla","followers_url":"https://api.github.com/users/tyxla/followers","following_url":"https://api.github.com/users/tyxla/following{/other_user}","gists_url":"https://api.github.com/users/tyxla/gists{/gist_id}","starred_url":"https://api.github.com/users/tyxla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyxla/subscriptions","organizations_url":"https://api.github.com/users/tyxla/orgs","repos_url":"https://api.github.com/users/tyxla/repos","events_url":"https://api.github.com/users/tyxla/events{/privacy}","received_events_url":"https://api.github.com/users/tyxla/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T12:34:35Z","updated_at":"2018-11-01T12:34:35Z","author_association":"MEMBER","body":"> Seems like failure states still need some further work to reflect in the UI? \r\n\r\nYup, eventually material for another PR though.\r\n\r\nThanks!"}}
{"actor":{"display_login":"tyxla"}}