{"action":"created","issue":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/514","repository_url":"https://api.github.com/repos/StrikeNP/trac_test","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/514/labels{/name}","comments_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/514/comments","events_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/514/events","html_url":"https://github.com/StrikeNP/trac_test/issues/514","id":330448149,"node_id":"MDU6SXNzdWUzMzA0NDgxNDk=","number":514,"title":"Implement diagnosis of correlations in CLUBB with later comments on: the KK code refactoring, the creation of the setup_pdf_parameters code and convergence of SILHS to KK (Trac #514)","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"labels":[{"id":958019852,"node_id":"MDU6TGFiZWw5NTgwMTk4NTI=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/Migrated%20from%20Trac","name":"Migrated from Trac","color":"FFFFFF","default":false},{"id":958042830,"node_id":"MDU6TGFiZWw5NTgwNDI4MzA=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/clubb_src","name":"clubb_src","color":"FFFFFF","default":false},{"id":958123000,"node_id":"MDU6TGFiZWw5NTgxMjMwMDA=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/janhft@uwm.edu","name":"janhft@uwm.edu","color":"FFFFFF","default":false},{"id":958042692,"node_id":"MDU6TGFiZWw5NTgwNDI2OTI=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/task","name":"task","color":"FFFFFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/22","html_url":"https://github.com/StrikeNP/trac_test/milestone/22","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/22/labels","id":3409159,"node_id":"MDk6TWlsZXN0b25lMzQwOTE1OQ==","number":22,"title":"Diagnose correlations in CLUBB","description":null,"creator":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2018-06-07T21:49:09Z","updated_at":"2018-06-07T23:12:21Z","due_on":null,"closed_at":null},"comments":118,"created_at":"2018-06-07T21:49:12Z","updated_at":"2018-06-09T07:35:36Z","closed_at":null,"author_association":"OWNER","body":"\nRight now, both the analytic KK microphysics and the SILHS code used prescribed correlation arrays.  Rather, we'd like to diagnose these using the algorithm in Larson et al. (2011).  Let's implement this algorithm in CLUBB.\n\nLet's think of a test matrix on which to test the new code.\n\nAttachments:\n\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/larson_et_al_2011_correlations.pdf\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/PDF_comp_multivariateNL.png\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/corr_rrNr_n-t25.png\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/corr_rrNr_n_fij_wo_sign.png\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/corr_rrNr_n_Sij_1.png\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/corr_rrNr_n_Sij_1_fij_with_sign.png\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/plotgenout_120312.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/dycoms2_rf02_ds.case\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/rico.case\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/plotgenout_local.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/plotgenout_system.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/plotgenout_combined.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/plotgenout_wcorr_fixed_01.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/plotgenout_wcorr_fixed_05_1.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/plotgenout_wcorr_fixed_mixed.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/po_fij_changed.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/po_fij_changed3.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/po_fij2.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/po_comp3_05.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/po_comp4_05.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/po_compare2_calc.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/diagnose_corr_status_quo.pdf\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/corr_compare_05.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/diagnose_corr_planned.pdf\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/compare_r6297_r6298fixed.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/compare_r6297_r6299_current3.maff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/diagnose_corr_20130610.pdf\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/plotgen_diag_vs_pre\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/diagnose_corr_20130702.pdf\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/r6470.diff\nhttp://carson.math.uwm.edu/trac/clubb/attachment/ticket/514/r6470_new_1.maff\n\nMigrated from http://carson.math.uwm.edu/trac/clubb/ticket/514\n```json\n{\n    \"status\": \"closed\", \n    \"changetime\": \"2013-09-30T21:38:35\", \n    \"description\": \"\\nRight now, both the analytic KK microphysics and the SILHS code used prescribed correlation arrays.  Rather, we'd like to diagnose these using the algorithm in Larson et al. (2011).  Let's implement this algorithm in CLUBB.\\n\\nLet's think of a test matrix on which to test the new code.\", \n    \"reporter\": \"vlarson@uwm.edu\", \n    \"cc\": \"vlarson@uwm.edu, dschanen@uwm.edu, bmg2@uwm.edu, raut@uwm.edu\", \n    \"resolution\": \"invalid\", \n    \"_ts\": \"1380577115624609\", \n    \"component\": \"clubb_src\", \n    \"summary\": \"Implement diagnosis of correlations in CLUBB with later comments on: the KK code refactoring, the creation of the setup_pdf_parameters code and convergence of SILHS to KK\", \n    \"priority\": \"major\", \n    \"keywords\": \"\", \n    \"time\": \"2012-07-16T20:12:36\", \n    \"milestone\": \"Diagnose correlations in CLUBB\", \n    \"owner\": \"janhft@uwm.edu\", \n    \"type\": \"task\"\n}\n```\n"},"comment":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/comments/395948037","html_url":"https://github.com/StrikeNP/trac_test/issues/514#issuecomment-395948037","issue_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/514","id":395948037,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTk0ODAzNw==","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"created_at":"2018-06-09T07:35:36Z","updated_at":"2018-06-09T07:35:36Z","author_association":"OWNER","body":"Trac update at 2013/06/04 at 23:24\n\njanhft@uwm.edu commented:\n\nReplying to [comment:94 bmg2@…]:\n> The problem is that until the correlation arrays and PDF parameters are passed throughout the code, the above subroutine call is also made from KK_upscaled_micro_driver.  The ```.false.``` above is the l_stats_samp flag.  From KK_upscaled_micro_driver, the l_stats_samp flag is simply passed in.  However, at this point, we don't want to sample the same stats twice, so ```.false.``` is hard-wired in the call from l_use_modified_corr.  Right now, if we passed in l_stats_samp in both places we could cause a run-time error when l_use_modified_corr is enabled and upscaled KK is used.  When the corr_arrays, etc. are passed through the code to KK, the call to subroutine setup_pdf_parameters will be removed from KK_upscaled_micro_driver, and l_stats_samp should replace ```.false.``` in the call to setup_pdf_parameters that is found in clubb_driver.\n> \n> My thought was just to leave it until the time comes when the arrays, etc. are passed, the call to setup_pdf_parameters can be removed from upscaled KK, and then ```.false.``` can be changed to l_stats_samp.  Otherwise, we could name ```.false.``` something for now, but then we'll have to remember to change it to l_stats_samp when the time comes.\n\n\nThe correlations and hydrometeor PDF parameter are now fed through the code. I replaced the magic flag with ```l_stats_samp```. I tested the refactored version vs r6296 for the cases rico and dycoms2_rf02_ds. The results were bit-by-bit identical. The refactored version is commited in r6298.\n\n"}}
{"actor":{"display_login":"StrikeNP"}}