{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/17504","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/17504/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/17504/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/17504/events","html_url":"https://github.com/joomla/joomla-cms/pull/17504","id":249800023,"number":17504,"title":"Success message on successful Article Save","user":{"login":"LivioCavallo","id":13764478,"avatar_url":"https://avatars1.githubusercontent.com/u/13764478?v=4","gravatar_id":"","url":"https://api.github.com/users/LivioCavallo","html_url":"https://github.com/LivioCavallo","followers_url":"https://api.github.com/users/LivioCavallo/followers","following_url":"https://api.github.com/users/LivioCavallo/following{/other_user}","gists_url":"https://api.github.com/users/LivioCavallo/gists{/gist_id}","starred_url":"https://api.github.com/users/LivioCavallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LivioCavallo/subscriptions","organizations_url":"https://api.github.com/users/LivioCavallo/orgs","repos_url":"https://api.github.com/users/LivioCavallo/repos","events_url":"https://api.github.com/users/LivioCavallo/events{/privacy}","received_events_url":"https://api.github.com/users/LivioCavallo/received_events","type":"User","site_admin":false},"labels":[{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-08-12T09:16:39Z","updated_at":"2018-05-08T21:56:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/17504","html_url":"https://github.com/joomla/joomla-cms/pull/17504","diff_url":"https://github.com/joomla/joomla-cms/pull/17504.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/17504.patch"},"body":"When an article is successfully saved we expect, especially in frontend, that a success message is displayed.\r\nJ!3.7.4 shows a neutral message of type 'message', not of type 'success'.\r\nThis becomes evident if you customize the css styles.\r\nThe problem cannot be solved with a template override because the message is not emitted in a templatable file; so the problem will remain and can be even worst in custom templates.\r\nThe reason is that the code showing the message relies on a default parameter that leads to a message of type 'message'.\r\n\r\n### Summary of Changes\r\nModify a line in libraries/legacy/controller/form.php (now in libraries/src/controller/form.php) adding 'success' parameter.\r\n\r\n### Testing Instructions\r\nIn J!3.7.4.\r\nCreate a menuitem of type \"Submit new article\".\r\nSet default template to beez3 (protostar has a layout override that assimilates all 'message' type system messages to 'success' type).\r\nCustomize beez3 personal.css (templates->templates->beez3->editor->css->personal.css) with something like:\r\n#system-message [class*=\"success\"] {  background-color: green; }\r\n#system-message [class*=\"message\"] {  background-color: blue; }\r\n\r\n### Expected result\r\nWhen you successfully save an article you'll expect a green background (success).\r\n\r\n### Actual result\r\nYou'll get a blue background (message).\r\n\r\n### Documentation Changes Required\r\nnone"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/387555031","html_url":"https://github.com/joomla/joomla-cms/pull/17504#issuecomment-387555031","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/17504","id":387555031,"user":{"login":"carlitorweb","id":3956472,"avatar_url":"https://avatars3.githubusercontent.com/u/3956472?v=4","gravatar_id":"","url":"https://api.github.com/users/carlitorweb","html_url":"https://github.com/carlitorweb","followers_url":"https://api.github.com/users/carlitorweb/followers","following_url":"https://api.github.com/users/carlitorweb/following{/other_user}","gists_url":"https://api.github.com/users/carlitorweb/gists{/gist_id}","starred_url":"https://api.github.com/users/carlitorweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlitorweb/subscriptions","organizations_url":"https://api.github.com/users/carlitorweb/orgs","repos_url":"https://api.github.com/users/carlitorweb/repos","events_url":"https://api.github.com/users/carlitorweb/events{/privacy}","received_events_url":"https://api.github.com/users/carlitorweb/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T21:56:06Z","updated_at":"2018-05-08T21:56:06Z","author_association":"NONE","body":"Not sure right now, but I think this happens for other scenarios. In my opinion, this can wait for J4 for the correct handle of messages. "}}
{"actor":{"display_login":"carlitorweb"}}