{"action":"created","comment":{"url":"https://api.github.com/repos/textileio/textile-mobile/pulls/comments/187241414","pull_request_review_id":118980229,"id":187241414,"diff_hunk":"@@ -259,7 +259,7 @@ - (NSString *)_getHashRequest:(NSString *)hash error:(NSError**)error {\n   return token;\n }\n \n-- (NSString *)_getPhoto:(NSString *)hashPath error:(NSError**)error {\n+- (NSString *)_getHashData:(NSString *)hashPath error:(NSError**)error {","path":"ios/NativeModules/TextileIPFS.m","position":76,"original_position":76,"commit_id":"bf4287598bcb57a337a523b1adff7f36a4c90b23","original_commit_id":"bf4287598bcb57a337a523b1adff7f36a4c90b23","user":{"login":"carsonfarmer","id":1220613,"avatar_url":"https://avatars3.githubusercontent.com/u/1220613?v=4","gravatar_id":"","url":"https://api.github.com/users/carsonfarmer","html_url":"https://github.com/carsonfarmer","followers_url":"https://api.github.com/users/carsonfarmer/followers","following_url":"https://api.github.com/users/carsonfarmer/following{/other_user}","gists_url":"https://api.github.com/users/carsonfarmer/gists{/gist_id}","starred_url":"https://api.github.com/users/carsonfarmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carsonfarmer/subscriptions","organizations_url":"https://api.github.com/users/carsonfarmer/orgs","repos_url":"https://api.github.com/users/carsonfarmer/repos","events_url":"https://api.github.com/users/carsonfarmer/events{/privacy}","received_events_url":"https://api.github.com/users/carsonfarmer/received_events","type":"User","site_admin":false},"body":"as with all the others, i think this is a good move: renaming to be more generic","created_at":"2018-05-10T05:12:55Z","updated_at":"2018-05-10T05:12:55Z","html_url":"https://github.com/textileio/textile-mobile/pull/56#discussion_r187241414","pull_request_url":"https://api.github.com/repos/textileio/textile-mobile/pulls/56","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/textileio/textile-mobile/pulls/comments/187241414"},"html":{"href":"https://github.com/textileio/textile-mobile/pull/56#discussion_r187241414"},"pull_request":{"href":"https://api.github.com/repos/textileio/textile-mobile/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/textileio/textile-mobile/pulls/56","id":187070995,"html_url":"https://github.com/textileio/textile-mobile/pull/56","diff_url":"https://github.com/textileio/textile-mobile/pull/56.diff","patch_url":"https://github.com/textileio/textile-mobile/pull/56.patch","issue_url":"https://api.github.com/repos/textileio/textile-mobile/issues/56","number":56,"state":"open","locked":false,"title":"Captions on shares and logging updates","user":{"login":"carsonfarmer","id":1220613,"avatar_url":"https://avatars3.githubusercontent.com/u/1220613?v=4","gravatar_id":"","url":"https://api.github.com/users/carsonfarmer","html_url":"https://github.com/carsonfarmer","followers_url":"https://api.github.com/users/carsonfarmer/followers","following_url":"https://api.github.com/users/carsonfarmer/following{/other_user}","gists_url":"https://api.github.com/users/carsonfarmer/gists{/gist_id}","starred_url":"https://api.github.com/users/carsonfarmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carsonfarmer/subscriptions","organizations_url":"https://api.github.com/users/carsonfarmer/orgs","repos_url":"https://api.github.com/users/carsonfarmer/repos","events_url":"https://api.github.com/users/carsonfarmer/events{/privacy}","received_events_url":"https://api.github.com/users/carsonfarmer/received_events","type":"User","site_admin":false},"body":"So when creating a `newNode` from RN, this PR means no code changes on the RN/Javascript side... and we just get the debug state from the OS... is this a nice dev UX, or would it be preferable to have more fine-grained control from RN? (edited)\r\nI guess if we leave it up to RN/Javascript, we could more easily play around with different `logLevels`?\r\nopinions?","created_at":"2018-05-10T00:08:04Z","updated_at":"2018-05-10T05:12:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3e686ff6b3f99588abb1f0817114941c2318297","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/textileio/textile-mobile/pulls/56/commits","review_comments_url":"https://api.github.com/repos/textileio/textile-mobile/pulls/56/comments","review_comment_url":"https://api.github.com/repos/textileio/textile-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/textileio/textile-mobile/issues/56/comments","statuses_url":"https://api.github.com/repos/textileio/textile-mobile/statuses/bf4287598bcb57a337a523b1adff7f36a4c90b23","head":{"label":"textileio:carson/mobile-captions","ref":"carson/mobile-captions","sha":"bf4287598bcb57a337a523b1adff7f36a4c90b23","user":{"login":"textileio","id":35050041,"avatar_url":"https://avatars3.githubusercontent.com/u/35050041?v=4","gravatar_id":"","url":"https://api.github.com/users/textileio","html_url":"https://github.com/textileio","followers_url":"https://api.github.com/users/textileio/followers","following_url":"https://api.github.com/users/textileio/following{/other_user}","gists_url":"https://api.github.com/users/textileio/gists{/gist_id}","starred_url":"https://api.github.com/users/textileio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textileio/subscriptions","organizations_url":"https://api.github.com/users/textileio/orgs","repos_url":"https://api.github.com/users/textileio/repos","events_url":"https://api.github.com/users/textileio/events{/privacy}","received_events_url":"https://api.github.com/users/textileio/received_events","type":"Organization","site_admin":false},"repo":{"id":128835983,"name":"textile-mobile","full_name":"textileio/textile-mobile","owner":{"login":"textileio","id":35050041,"avatar_url":"https://avatars3.githubusercontent.com/u/35050041?v=4","gravatar_id":"","url":"https://api.github.com/users/textileio","html_url":"https://github.com/textileio","followers_url":"https://api.github.com/users/textileio/followers","following_url":"https://api.github.com/users/textileio/following{/other_user}","gists_url":"https://api.github.com/users/textileio/gists{/gist_id}","starred_url":"https://api.github.com/users/textileio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textileio/subscriptions","organizations_url":"https://api.github.com/users/textileio/orgs","repos_url":"https://api.github.com/users/textileio/repos","events_url":"https://api.github.com/users/textileio/events{/privacy}","received_events_url":"https://api.github.com/users/textileio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/textileio/textile-mobile","description":"Encrypted, secure, decentralized personal data wallet -- technology behind textile.photos","fork":false,"url":"https://api.github.com/repos/textileio/textile-mobile","forks_url":"https://api.github.com/repos/textileio/textile-mobile/forks","keys_url":"https://api.github.com/repos/textileio/textile-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/textileio/textile-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/textileio/textile-mobile/teams","hooks_url":"https://api.github.com/repos/textileio/textile-mobile/hooks","issue_events_url":"https://api.github.com/repos/textileio/textile-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/textileio/textile-mobile/events","assignees_url":"https://api.github.com/repos/textileio/textile-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/textileio/textile-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/textileio/textile-mobile/tags","blobs_url":"https://api.github.com/repos/textileio/textile-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/textileio/textile-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/textileio/textile-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/textileio/textile-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/textileio/textile-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/textileio/textile-mobile/languages","stargazers_url":"https://api.github.com/repos/textileio/textile-mobile/stargazers","contributors_url":"https://api.github.com/repos/textileio/textile-mobile/contributors","subscribers_url":"https://api.github.com/repos/textileio/textile-mobile/subscribers","subscription_url":"https://api.github.com/repos/textileio/textile-mobile/subscription","commits_url":"https://api.github.com/repos/textileio/textile-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/textileio/textile-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/textileio/textile-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/textileio/textile-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/textileio/textile-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/textileio/textile-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/textileio/textile-mobile/merges","archive_url":"https://api.github.com/repos/textileio/textile-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/textileio/textile-mobile/downloads","issues_url":"https://api.github.com/repos/textileio/textile-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/textileio/textile-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/textileio/textile-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/textileio/textile-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/textileio/textile-mobile/labels{/name}","releases_url":"https://api.github.com/repos/textileio/textile-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/textileio/textile-mobile/deployments","created_at":"2018-04-09T21:28:41Z","updated_at":"2018-05-10T02:12:31Z","pushed_at":"2018-05-10T04:55:18Z","git_url":"git://github.com/textileio/textile-mobile.git","ssh_url":"git@github.com:textileio/textile-mobile.git","clone_url":"https://github.com/textileio/textile-mobile.git","svn_url":"https://github.com/textileio/textile-mobile","homepage":"https://www.textile.photos/","size":1465150,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":4,"watchers":5,"default_branch":"master"}},"base":{"label":"textileio:master","ref":"master","sha":"9b9c6190a511c6c91abb2be662faa9836f96b3de","user":{"login":"textileio","id":35050041,"avatar_url":"https://avatars3.githubusercontent.com/u/35050041?v=4","gravatar_id":"","url":"https://api.github.com/users/textileio","html_url":"https://github.com/textileio","followers_url":"https://api.github.com/users/textileio/followers","following_url":"https://api.github.com/users/textileio/following{/other_user}","gists_url":"https://api.github.com/users/textileio/gists{/gist_id}","starred_url":"https://api.github.com/users/textileio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textileio/subscriptions","organizations_url":"https://api.github.com/users/textileio/orgs","repos_url":"https://api.github.com/users/textileio/repos","events_url":"https://api.github.com/users/textileio/events{/privacy}","received_events_url":"https://api.github.com/users/textileio/received_events","type":"Organization","site_admin":false},"repo":{"id":128835983,"name":"textile-mobile","full_name":"textileio/textile-mobile","owner":{"login":"textileio","id":35050041,"avatar_url":"https://avatars3.githubusercontent.com/u/35050041?v=4","gravatar_id":"","url":"https://api.github.com/users/textileio","html_url":"https://github.com/textileio","followers_url":"https://api.github.com/users/textileio/followers","following_url":"https://api.github.com/users/textileio/following{/other_user}","gists_url":"https://api.github.com/users/textileio/gists{/gist_id}","starred_url":"https://api.github.com/users/textileio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textileio/subscriptions","organizations_url":"https://api.github.com/users/textileio/orgs","repos_url":"https://api.github.com/users/textileio/repos","events_url":"https://api.github.com/users/textileio/events{/privacy}","received_events_url":"https://api.github.com/users/textileio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/textileio/textile-mobile","description":"Encrypted, secure, decentralized personal data wallet -- technology behind textile.photos","fork":false,"url":"https://api.github.com/repos/textileio/textile-mobile","forks_url":"https://api.github.com/repos/textileio/textile-mobile/forks","keys_url":"https://api.github.com/repos/textileio/textile-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/textileio/textile-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/textileio/textile-mobile/teams","hooks_url":"https://api.github.com/repos/textileio/textile-mobile/hooks","issue_events_url":"https://api.github.com/repos/textileio/textile-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/textileio/textile-mobile/events","assignees_url":"https://api.github.com/repos/textileio/textile-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/textileio/textile-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/textileio/textile-mobile/tags","blobs_url":"https://api.github.com/repos/textileio/textile-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/textileio/textile-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/textileio/textile-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/textileio/textile-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/textileio/textile-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/textileio/textile-mobile/languages","stargazers_url":"https://api.github.com/repos/textileio/textile-mobile/stargazers","contributors_url":"https://api.github.com/repos/textileio/textile-mobile/contributors","subscribers_url":"https://api.github.com/repos/textileio/textile-mobile/subscribers","subscription_url":"https://api.github.com/repos/textileio/textile-mobile/subscription","commits_url":"https://api.github.com/repos/textileio/textile-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/textileio/textile-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/textileio/textile-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/textileio/textile-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/textileio/textile-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/textileio/textile-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/textileio/textile-mobile/merges","archive_url":"https://api.github.com/repos/textileio/textile-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/textileio/textile-mobile/downloads","issues_url":"https://api.github.com/repos/textileio/textile-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/textileio/textile-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/textileio/textile-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/textileio/textile-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/textileio/textile-mobile/labels{/name}","releases_url":"https://api.github.com/repos/textileio/textile-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/textileio/textile-mobile/deployments","created_at":"2018-04-09T21:28:41Z","updated_at":"2018-05-10T02:12:31Z","pushed_at":"2018-05-10T04:55:18Z","git_url":"git://github.com/textileio/textile-mobile.git","ssh_url":"git@github.com:textileio/textile-mobile.git","clone_url":"https://github.com/textileio/textile-mobile.git","svn_url":"https://github.com/textileio/textile-mobile","homepage":"https://www.textile.photos/","size":1465150,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/textileio/textile-mobile/pulls/56"},"html":{"href":"https://github.com/textileio/textile-mobile/pull/56"},"issue":{"href":"https://api.github.com/repos/textileio/textile-mobile/issues/56"},"comments":{"href":"https://api.github.com/repos/textileio/textile-mobile/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/textileio/textile-mobile/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/textileio/textile-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/textileio/textile-mobile/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/textileio/textile-mobile/statuses/bf4287598bcb57a337a523b1adff7f36a4c90b23"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"carsonfarmer"}}