{"action":"created","comment":{"url":"https://api.github.com/repos/code-squad/swift-jsonparser/pulls/comments/175991476","pull_request_review_id":105614458,"id":175991476,"diff_hunk":"@@ -8,14 +8,16 @@\n \n import Foundation\n \n-\n while true {\n     let message = \"분석할 JSON 데이터를 입력하세요.\"\n     let inputView = InputView()\n-    let input = inputView.readInput(message)\n-    let inputData = inputView.separateByComma(input)\n-    let data = inputView.dropBrackets(inputData)\n-    let dataValue = inputView.removeWhiteSpace(data)\n-    let dataType = inputView.makeDataArray(dataValue)\n-    ResultView().resultMessage(dataType.number, dataType.string, dataType.bool, dataValue)\n+    let inputData = inputView.readInput(message)\n+    guard GrammarChecker().isValidInput(inputData) else { print(\"정확한 데이터 값으로 다시 입력하세요\"); continue }\n+    let checkData = inputView.checkBrackets(inputData)","path":"JSONParser/JSONParser/main.swift","position":16,"original_position":16,"commit_id":"97559251039efe7aba8fedb76a4c82dcb633a727","original_commit_id":"97559251039efe7aba8fedb76a4c82dcb633a727","user":{"login":"godrm","id":278988,"avatar_url":"https://avatars1.githubusercontent.com/u/278988?v=4","gravatar_id":"","url":"https://api.github.com/users/godrm","html_url":"https://github.com/godrm","followers_url":"https://api.github.com/users/godrm/followers","following_url":"https://api.github.com/users/godrm/following{/other_user}","gists_url":"https://api.github.com/users/godrm/gists{/gist_id}","starred_url":"https://api.github.com/users/godrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godrm/subscriptions","organizations_url":"https://api.github.com/users/godrm/orgs","repos_url":"https://api.github.com/users/godrm/repos","events_url":"https://api.github.com/users/godrm/events{/privacy}","received_events_url":"https://api.github.com/users/godrm/received_events","type":"User","site_admin":false},"body":"InputView 에서 inputData를 받았으면 (일단 InputView의 역할이 끝나고)\r\ncheckBrackers() 기능은 다른 객체에 있는게 어떨까요?\r\nMyJsonParser 가 그 역할을 대신해 줄 것으로 예상했는데 특이하게 배열은 그대로 두고 사전만 처리하고 있네요?\r\n이게 더 헷갈리지 않나요? MyJsonParser가 inputData를 받아서 Array인지 Dictionary 인지 알아서 처리하고 출력할 수 있는 데이터를 리턴해주면 어떨까요?\r\nResultView를 활용하는 방법도 checkData.bool 처럼 판단하지 않고 좌표계산기에서 처럼 객체에 분산해서 처리할 수는 없을까 고민해보세요.","created_at":"2018-03-21T06:21:48Z","updated_at":"2018-03-21T06:21:48Z","html_url":"https://github.com/code-squad/swift-jsonparser/pull/53#discussion_r175991476","pull_request_url":"https://api.github.com/repos/code-squad/swift-jsonparser/pulls/53","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/code-squad/swift-jsonparser/pulls/comments/175991476"},"html":{"href":"https://github.com/code-squad/swift-jsonparser/pull/53#discussion_r175991476"},"pull_request":{"href":"https://api.github.com/repos/code-squad/swift-jsonparser/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/code-squad/swift-jsonparser/pulls/53","id":176085975,"html_url":"https://github.com/code-squad/swift-jsonparser/pull/53","diff_url":"https://github.com/code-squad/swift-jsonparser/pull/53.diff","patch_url":"https://github.com/code-squad/swift-jsonparser/pull/53.patch","issue_url":"https://api.github.com/repos/code-squad/swift-jsonparser/issues/53","number":53,"state":"open","locked":false,"title":"[hyun] Jsonparser step2","user":{"login":"cocomilktea","id":31604961,"avatar_url":"https://avatars3.githubusercontent.com/u/31604961?v=4","gravatar_id":"","url":"https://api.github.com/users/cocomilktea","html_url":"https://github.com/cocomilktea","followers_url":"https://api.github.com/users/cocomilktea/followers","following_url":"https://api.github.com/users/cocomilktea/following{/other_user}","gists_url":"https://api.github.com/users/cocomilktea/gists{/gist_id}","starred_url":"https://api.github.com/users/cocomilktea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocomilktea/subscriptions","organizations_url":"https://api.github.com/users/cocomilktea/orgs","repos_url":"https://api.github.com/users/cocomilktea/repos","events_url":"https://api.github.com/users/cocomilktea/events{/privacy}","received_events_url":"https://api.github.com/users/cocomilktea/received_events","type":"User","site_admin":false},"body":"step2 PR 보냅니다 ","created_at":"2018-03-20T04:23:09Z","updated_at":"2018-03-21T06:21:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31aa94cd206c594273ba0746be8f18e22374723e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/code-squad/swift-jsonparser/pulls/53/commits","review_comments_url":"https://api.github.com/repos/code-squad/swift-jsonparser/pulls/53/comments","review_comment_url":"https://api.github.com/repos/code-squad/swift-jsonparser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-squad/swift-jsonparser/issues/53/comments","statuses_url":"https://api.github.com/repos/code-squad/swift-jsonparser/statuses/97559251039efe7aba8fedb76a4c82dcb633a727","head":{"label":"cocomilktea:jsonparser-step2","ref":"jsonparser-step2","sha":"97559251039efe7aba8fedb76a4c82dcb633a727","user":{"login":"cocomilktea","id":31604961,"avatar_url":"https://avatars3.githubusercontent.com/u/31604961?v=4","gravatar_id":"","url":"https://api.github.com/users/cocomilktea","html_url":"https://github.com/cocomilktea","followers_url":"https://api.github.com/users/cocomilktea/followers","following_url":"https://api.github.com/users/cocomilktea/following{/other_user}","gists_url":"https://api.github.com/users/cocomilktea/gists{/gist_id}","starred_url":"https://api.github.com/users/cocomilktea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocomilktea/subscriptions","organizations_url":"https://api.github.com/users/cocomilktea/orgs","repos_url":"https://api.github.com/users/cocomilktea/repos","events_url":"https://api.github.com/users/cocomilktea/events{/privacy}","received_events_url":"https://api.github.com/users/cocomilktea/received_events","type":"User","site_admin":false},"repo":{"id":124820078,"name":"swift-jsonparser","full_name":"cocomilktea/swift-jsonparser","owner":{"login":"cocomilktea","id":31604961,"avatar_url":"https://avatars3.githubusercontent.com/u/31604961?v=4","gravatar_id":"","url":"https://api.github.com/users/cocomilktea","html_url":"https://github.com/cocomilktea","followers_url":"https://api.github.com/users/cocomilktea/followers","following_url":"https://api.github.com/users/cocomilktea/following{/other_user}","gists_url":"https://api.github.com/users/cocomilktea/gists{/gist_id}","starred_url":"https://api.github.com/users/cocomilktea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocomilktea/subscriptions","organizations_url":"https://api.github.com/users/cocomilktea/orgs","repos_url":"https://api.github.com/users/cocomilktea/repos","events_url":"https://api.github.com/users/cocomilktea/events{/privacy}","received_events_url":"https://api.github.com/users/cocomilktea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cocomilktea/swift-jsonparser","description":"JSON문자열 분석기 저장소","fork":true,"url":"https://api.github.com/repos/cocomilktea/swift-jsonparser","forks_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/forks","keys_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/teams","hooks_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/hooks","issue_events_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/issues/events{/number}","events_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/events","assignees_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/assignees{/user}","branches_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/branches{/branch}","tags_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/tags","blobs_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/statuses/{sha}","languages_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/languages","stargazers_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/stargazers","contributors_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/contributors","subscribers_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/subscribers","subscription_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/subscription","commits_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/contents/{+path}","compare_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/merges","archive_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/downloads","issues_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/issues{/number}","pulls_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/pulls{/number}","milestones_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/milestones{/number}","notifications_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/labels{/name}","releases_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/releases{/id}","deployments_url":"https://api.github.com/repos/cocomilktea/swift-jsonparser/deployments","created_at":"2018-03-12T02:00:21Z","updated_at":"2018-03-12T02:00:22Z","pushed_at":"2018-03-21T05:50:33Z","git_url":"git://github.com/cocomilktea/swift-jsonparser.git","ssh_url":"git@github.com:cocomilktea/swift-jsonparser.git","clone_url":"https://github.com/cocomilktea/swift-jsonparser.git","svn_url":"https://github.com/cocomilktea/swift-jsonparser","homepage":null,"size":720,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"code-squad:cocomilktea","ref":"cocomilktea","sha":"3c97b4ef08373c07ccbf14841140a55c7fc92c96","user":{"login":"code-squad","id":22832280,"avatar_url":"https://avatars2.githubusercontent.com/u/22832280?v=4","gravatar_id":"","url":"https://api.github.com/users/code-squad","html_url":"https://github.com/code-squad","followers_url":"https://api.github.com/users/code-squad/followers","following_url":"https://api.github.com/users/code-squad/following{/other_user}","gists_url":"https://api.github.com/users/code-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/code-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-squad/subscriptions","organizations_url":"https://api.github.com/users/code-squad/orgs","repos_url":"https://api.github.com/users/code-squad/repos","events_url":"https://api.github.com/users/code-squad/events{/privacy}","received_events_url":"https://api.github.com/users/code-squad/received_events","type":"Organization","site_admin":false},"repo":{"id":106374447,"name":"swift-jsonparser","full_name":"code-squad/swift-jsonparser","owner":{"login":"code-squad","id":22832280,"avatar_url":"https://avatars2.githubusercontent.com/u/22832280?v=4","gravatar_id":"","url":"https://api.github.com/users/code-squad","html_url":"https://github.com/code-squad","followers_url":"https://api.github.com/users/code-squad/followers","following_url":"https://api.github.com/users/code-squad/following{/other_user}","gists_url":"https://api.github.com/users/code-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/code-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-squad/subscriptions","organizations_url":"https://api.github.com/users/code-squad/orgs","repos_url":"https://api.github.com/users/code-squad/repos","events_url":"https://api.github.com/users/code-squad/events{/privacy}","received_events_url":"https://api.github.com/users/code-squad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-squad/swift-jsonparser","description":"JSON문자열 분석기 저장소","fork":false,"url":"https://api.github.com/repos/code-squad/swift-jsonparser","forks_url":"https://api.github.com/repos/code-squad/swift-jsonparser/forks","keys_url":"https://api.github.com/repos/code-squad/swift-jsonparser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-squad/swift-jsonparser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-squad/swift-jsonparser/teams","hooks_url":"https://api.github.com/repos/code-squad/swift-jsonparser/hooks","issue_events_url":"https://api.github.com/repos/code-squad/swift-jsonparser/issues/events{/number}","events_url":"https://api.github.com/repos/code-squad/swift-jsonparser/events","assignees_url":"https://api.github.com/repos/code-squad/swift-jsonparser/assignees{/user}","branches_url":"https://api.github.com/repos/code-squad/swift-jsonparser/branches{/branch}","tags_url":"https://api.github.com/repos/code-squad/swift-jsonparser/tags","blobs_url":"https://api.github.com/repos/code-squad/swift-jsonparser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-squad/swift-jsonparser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-squad/swift-jsonparser/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-squad/swift-jsonparser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-squad/swift-jsonparser/statuses/{sha}","languages_url":"https://api.github.com/repos/code-squad/swift-jsonparser/languages","stargazers_url":"https://api.github.com/repos/code-squad/swift-jsonparser/stargazers","contributors_url":"https://api.github.com/repos/code-squad/swift-jsonparser/contributors","subscribers_url":"https://api.github.com/repos/code-squad/swift-jsonparser/subscribers","subscription_url":"https://api.github.com/repos/code-squad/swift-jsonparser/subscription","commits_url":"https://api.github.com/repos/code-squad/swift-jsonparser/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-squad/swift-jsonparser/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-squad/swift-jsonparser/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-squad/swift-jsonparser/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-squad/swift-jsonparser/contents/{+path}","compare_url":"https://api.github.com/repos/code-squad/swift-jsonparser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-squad/swift-jsonparser/merges","archive_url":"https://api.github.com/repos/code-squad/swift-jsonparser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-squad/swift-jsonparser/downloads","issues_url":"https://api.github.com/repos/code-squad/swift-jsonparser/issues{/number}","pulls_url":"https://api.github.com/repos/code-squad/swift-jsonparser/pulls{/number}","milestones_url":"https://api.github.com/repos/code-squad/swift-jsonparser/milestones{/number}","notifications_url":"https://api.github.com/repos/code-squad/swift-jsonparser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-squad/swift-jsonparser/labels{/name}","releases_url":"https://api.github.com/repos/code-squad/swift-jsonparser/releases{/id}","deployments_url":"https://api.github.com/repos/code-squad/swift-jsonparser/deployments","created_at":"2017-10-10T06:00:00Z","updated_at":"2017-12-19T14:37:17Z","pushed_at":"2018-03-21T05:50:33Z","git_url":"git://github.com/code-squad/swift-jsonparser.git","ssh_url":"git@github.com:code-squad/swift-jsonparser.git","clone_url":"https://github.com/code-squad/swift-jsonparser.git","svn_url":"https://github.com/code-squad/swift-jsonparser","homepage":null,"size":717,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":10,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/code-squad/swift-jsonparser/pulls/53"},"html":{"href":"https://github.com/code-squad/swift-jsonparser/pull/53"},"issue":{"href":"https://api.github.com/repos/code-squad/swift-jsonparser/issues/53"},"comments":{"href":"https://api.github.com/repos/code-squad/swift-jsonparser/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/code-squad/swift-jsonparser/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/code-squad/swift-jsonparser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-squad/swift-jsonparser/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/code-squad/swift-jsonparser/statuses/97559251039efe7aba8fedb76a4c82dcb633a727"}},"author_association":"NONE"}}
{"actor":{"display_login":"godrm"}}