{"action":"created","comment":{"url":"https://api.github.com/repos/datadotworld/excel-add-in/pulls/comments/239632901","pull_request_review_id":182470520,"id":239632901,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTYzMjkwMQ==","diff_hunk":"@@ -195,3 +195,25 @@ export function hasDuplicateName({ name, dataset }, array) {\n \n   return withSameName > 0;\n }\n+\n+export function createWorkspaceLink(dataset) {\n+  return `https://data.world/${dataset.owner}/${dataset.id}/workspace/`;\n+}\n+\n+export function createItemLink(dataset, item, isQuery) {\n+  const base = `https://data.world/${dataset.owner}/${\n+    dataset.id\n+  }/workspace/query?`;\n+\n+  if (isQuery) {\n+    return `${base}queryid=${item.id}`;\n+  }\n+\n+  const query = `newQueryContent=${encodeURIComponent(\n+    `SELECT * FROM ${item.name}`\n+  )}`;\n+\n+  const queryType = 'newQueryType=SQL';\n+\n+  return `${base}${query}&&${queryType}`;","path":"src/util.js","position":24,"original_position":24,"commit_id":"7236539c43ecdde31a20d2c5ef51065634075993","original_commit_id":"7236539c43ecdde31a20d2c5ef51065634075993","user":{"login":"markmarkoh","id":11268,"node_id":"MDQ6VXNlcjExMjY4","avatar_url":"https://avatars2.githubusercontent.com/u/11268?v=4","gravatar_id":"","url":"https://api.github.com/users/markmarkoh","html_url":"https://github.com/markmarkoh","followers_url":"https://api.github.com/users/markmarkoh/followers","following_url":"https://api.github.com/users/markmarkoh/following{/other_user}","gists_url":"https://api.github.com/users/markmarkoh/gists{/gist_id}","starred_url":"https://api.github.com/users/markmarkoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markmarkoh/subscriptions","organizations_url":"https://api.github.com/users/markmarkoh/orgs","repos_url":"https://api.github.com/users/markmarkoh/repos","events_url":"https://api.github.com/users/markmarkoh/events{/privacy}","received_events_url":"https://api.github.com/users/markmarkoh/received_events","type":"User","site_admin":false},"body":"Add https://www.npmjs.com/package/query-string as a dependency and use that, it's a great little library for handling query params that removes a lot of the issues with the `?` vs `&` string concat'ing.","created_at":"2018-12-06T22:06:40Z","updated_at":"2018-12-06T22:10:03Z","html_url":"https://github.com/datadotworld/excel-add-in/pull/98#discussion_r239632901","pull_request_url":"https://api.github.com/repos/datadotworld/excel-add-in/pulls/98","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/datadotworld/excel-add-in/pulls/comments/239632901"},"html":{"href":"https://github.com/datadotworld/excel-add-in/pull/98#discussion_r239632901"},"pull_request":{"href":"https://api.github.com/repos/datadotworld/excel-add-in/pulls/98"}},"in_reply_to_id":239632387},"pull_request":{"url":"https://api.github.com/repos/datadotworld/excel-add-in/pulls/98","id":236590185,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NTkwMTg1","html_url":"https://github.com/datadotworld/excel-add-in/pull/98","diff_url":"https://github.com/datadotworld/excel-add-in/pull/98.diff","patch_url":"https://github.com/datadotworld/excel-add-in/pull/98.patch","issue_url":"https://api.github.com/repos/datadotworld/excel-add-in/issues/98","number":98,"state":"open","locked":false,"title":"Link to workspace, table and query","user":{"login":"kndungu","id":17295379,"node_id":"MDQ6VXNlcjE3Mjk1Mzc5","avatar_url":"https://avatars2.githubusercontent.com/u/17295379?v=4","gravatar_id":"","url":"https://api.github.com/users/kndungu","html_url":"https://github.com/kndungu","followers_url":"https://api.github.com/users/kndungu/followers","following_url":"https://api.github.com/users/kndungu/following{/other_user}","gists_url":"https://api.github.com/users/kndungu/gists{/gist_id}","starred_url":"https://api.github.com/users/kndungu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kndungu/subscriptions","organizations_url":"https://api.github.com/users/kndungu/orgs","repos_url":"https://api.github.com/users/kndungu/repos","events_url":"https://api.github.com/users/kndungu/events{/privacy}","received_events_url":"https://api.github.com/users/kndungu/received_events","type":"User","site_admin":false},"body":"On the recent imports screen:\r\n\r\n<img width=\"359\" alt=\"screen shot 2018-12-06 at 19 20 15\" src=\"https://user-images.githubusercontent.com/17295379/49596719-089c5180-f98c-11e8-8511-1b138b91f352.png\">\r\n\r\nThe table/query name links to:\r\n  * table: the dataset workspace pre-filled with a `SELECT * FROM ${table}` query\r\n  * query: the dataset workspace with the query pre-filled\r\n\r\nThe dataset (`owner/id`) links to the dataset workspace\r\n","created_at":"2018-12-06T16:24:22Z","updated_at":"2018-12-06T22:10:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c47191bc6b1a5debd889f3a542db6690b7138b90","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/datadotworld/excel-add-in/pulls/98/commits","review_comments_url":"https://api.github.com/repos/datadotworld/excel-add-in/pulls/98/comments","review_comment_url":"https://api.github.com/repos/datadotworld/excel-add-in/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datadotworld/excel-add-in/issues/98/comments","statuses_url":"https://api.github.com/repos/datadotworld/excel-add-in/statuses/7236539c43ecdde31a20d2c5ef51065634075993","head":{"label":"datadotworld:recents-links","ref":"recents-links","sha":"7236539c43ecdde31a20d2c5ef51065634075993","user":{"login":"datadotworld","id":14143948,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTQzOTQ4","avatar_url":"https://avatars0.githubusercontent.com/u/14143948?v=4","gravatar_id":"","url":"https://api.github.com/users/datadotworld","html_url":"https://github.com/datadotworld","followers_url":"https://api.github.com/users/datadotworld/followers","following_url":"https://api.github.com/users/datadotworld/following{/other_user}","gists_url":"https://api.github.com/users/datadotworld/gists{/gist_id}","starred_url":"https://api.github.com/users/datadotworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datadotworld/subscriptions","organizations_url":"https://api.github.com/users/datadotworld/orgs","repos_url":"https://api.github.com/users/datadotworld/repos","events_url":"https://api.github.com/users/datadotworld/events{/privacy}","received_events_url":"https://api.github.com/users/datadotworld/received_events","type":"Organization","site_admin":false},"repo":{"id":98214848,"node_id":"MDEwOlJlcG9zaXRvcnk5ODIxNDg0OA==","name":"excel-add-in","full_name":"datadotworld/excel-add-in","private":false,"owner":{"login":"datadotworld","id":14143948,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTQzOTQ4","avatar_url":"https://avatars0.githubusercontent.com/u/14143948?v=4","gravatar_id":"","url":"https://api.github.com/users/datadotworld","html_url":"https://github.com/datadotworld","followers_url":"https://api.github.com/users/datadotworld/followers","following_url":"https://api.github.com/users/datadotworld/following{/other_user}","gists_url":"https://api.github.com/users/datadotworld/gists{/gist_id}","starred_url":"https://api.github.com/users/datadotworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datadotworld/subscriptions","organizations_url":"https://api.github.com/users/datadotworld/orgs","repos_url":"https://api.github.com/users/datadotworld/repos","events_url":"https://api.github.com/users/datadotworld/events{/privacy}","received_events_url":"https://api.github.com/users/datadotworld/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/datadotworld/excel-add-in","description":"Excel add-in for data.world","fork":false,"url":"https://api.github.com/repos/datadotworld/excel-add-in","forks_url":"https://api.github.com/repos/datadotworld/excel-add-in/forks","keys_url":"https://api.github.com/repos/datadotworld/excel-add-in/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datadotworld/excel-add-in/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datadotworld/excel-add-in/teams","hooks_url":"https://api.github.com/repos/datadotworld/excel-add-in/hooks","issue_events_url":"https://api.github.com/repos/datadotworld/excel-add-in/issues/events{/number}","events_url":"https://api.github.com/repos/datadotworld/excel-add-in/events","assignees_url":"https://api.github.com/repos/datadotworld/excel-add-in/assignees{/user}","branches_url":"https://api.github.com/repos/datadotworld/excel-add-in/branches{/branch}","tags_url":"https://api.github.com/repos/datadotworld/excel-add-in/tags","blobs_url":"https://api.github.com/repos/datadotworld/excel-add-in/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datadotworld/excel-add-in/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datadotworld/excel-add-in/git/refs{/sha}","trees_url":"https://api.github.com/repos/datadotworld/excel-add-in/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datadotworld/excel-add-in/statuses/{sha}","languages_url":"https://api.github.com/repos/datadotworld/excel-add-in/languages","stargazers_url":"https://api.github.com/repos/datadotworld/excel-add-in/stargazers","contributors_url":"https://api.github.com/repos/datadotworld/excel-add-in/contributors","subscribers_url":"https://api.github.com/repos/datadotworld/excel-add-in/subscribers","subscription_url":"https://api.github.com/repos/datadotworld/excel-add-in/subscription","commits_url":"https://api.github.com/repos/datadotworld/excel-add-in/commits{/sha}","git_commits_url":"https://api.github.com/repos/datadotworld/excel-add-in/git/commits{/sha}","comments_url":"https://api.github.com/repos/datadotworld/excel-add-in/comments{/number}","issue_comment_url":"https://api.github.com/repos/datadotworld/excel-add-in/issues/comments{/number}","contents_url":"https://api.github.com/repos/datadotworld/excel-add-in/contents/{+path}","compare_url":"https://api.github.com/repos/datadotworld/excel-add-in/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datadotworld/excel-add-in/merges","archive_url":"https://api.github.com/repos/datadotworld/excel-add-in/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datadotworld/excel-add-in/downloads","issues_url":"https://api.github.com/repos/datadotworld/excel-add-in/issues{/number}","pulls_url":"https://api.github.com/repos/datadotworld/excel-add-in/pulls{/number}","milestones_url":"https://api.github.com/repos/datadotworld/excel-add-in/milestones{/number}","notifications_url":"https://api.github.com/repos/datadotworld/excel-add-in/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datadotworld/excel-add-in/labels{/name}","releases_url":"https://api.github.com/repos/datadotworld/excel-add-in/releases{/id}","deployments_url":"https://api.github.com/repos/datadotworld/excel-add-in/deployments","created_at":"2017-07-24T17:08:14Z","updated_at":"2018-12-05T21:03:06Z","pushed_at":"2018-12-06T17:22:02Z","git_url":"git://github.com/datadotworld/excel-add-in.git","ssh_url":"git@github.com:datadotworld/excel-add-in.git","clone_url":"https://github.com/datadotworld/excel-add-in.git","svn_url":"https://github.com/datadotworld/excel-add-in","homepage":"https://data.world/integrations/excel","size":1692,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":10,"watchers":6,"default_branch":"master"}},"base":{"label":"datadotworld:master","ref":"master","sha":"e1829783a8f968a52b2cbdb20e653df2af829cfb","user":{"login":"datadotworld","id":14143948,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTQzOTQ4","avatar_url":"https://avatars0.githubusercontent.com/u/14143948?v=4","gravatar_id":"","url":"https://api.github.com/users/datadotworld","html_url":"https://github.com/datadotworld","followers_url":"https://api.github.com/users/datadotworld/followers","following_url":"https://api.github.com/users/datadotworld/following{/other_user}","gists_url":"https://api.github.com/users/datadotworld/gists{/gist_id}","starred_url":"https://api.github.com/users/datadotworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datadotworld/subscriptions","organizations_url":"https://api.github.com/users/datadotworld/orgs","repos_url":"https://api.github.com/users/datadotworld/repos","events_url":"https://api.github.com/users/datadotworld/events{/privacy}","received_events_url":"https://api.github.com/users/datadotworld/received_events","type":"Organization","site_admin":false},"repo":{"id":98214848,"node_id":"MDEwOlJlcG9zaXRvcnk5ODIxNDg0OA==","name":"excel-add-in","full_name":"datadotworld/excel-add-in","private":false,"owner":{"login":"datadotworld","id":14143948,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTQzOTQ4","avatar_url":"https://avatars0.githubusercontent.com/u/14143948?v=4","gravatar_id":"","url":"https://api.github.com/users/datadotworld","html_url":"https://github.com/datadotworld","followers_url":"https://api.github.com/users/datadotworld/followers","following_url":"https://api.github.com/users/datadotworld/following{/other_user}","gists_url":"https://api.github.com/users/datadotworld/gists{/gist_id}","starred_url":"https://api.github.com/users/datadotworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datadotworld/subscriptions","organizations_url":"https://api.github.com/users/datadotworld/orgs","repos_url":"https://api.github.com/users/datadotworld/repos","events_url":"https://api.github.com/users/datadotworld/events{/privacy}","received_events_url":"https://api.github.com/users/datadotworld/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/datadotworld/excel-add-in","description":"Excel add-in for data.world","fork":false,"url":"https://api.github.com/repos/datadotworld/excel-add-in","forks_url":"https://api.github.com/repos/datadotworld/excel-add-in/forks","keys_url":"https://api.github.com/repos/datadotworld/excel-add-in/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datadotworld/excel-add-in/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datadotworld/excel-add-in/teams","hooks_url":"https://api.github.com/repos/datadotworld/excel-add-in/hooks","issue_events_url":"https://api.github.com/repos/datadotworld/excel-add-in/issues/events{/number}","events_url":"https://api.github.com/repos/datadotworld/excel-add-in/events","assignees_url":"https://api.github.com/repos/datadotworld/excel-add-in/assignees{/user}","branches_url":"https://api.github.com/repos/datadotworld/excel-add-in/branches{/branch}","tags_url":"https://api.github.com/repos/datadotworld/excel-add-in/tags","blobs_url":"https://api.github.com/repos/datadotworld/excel-add-in/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datadotworld/excel-add-in/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datadotworld/excel-add-in/git/refs{/sha}","trees_url":"https://api.github.com/repos/datadotworld/excel-add-in/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datadotworld/excel-add-in/statuses/{sha}","languages_url":"https://api.github.com/repos/datadotworld/excel-add-in/languages","stargazers_url":"https://api.github.com/repos/datadotworld/excel-add-in/stargazers","contributors_url":"https://api.github.com/repos/datadotworld/excel-add-in/contributors","subscribers_url":"https://api.github.com/repos/datadotworld/excel-add-in/subscribers","subscription_url":"https://api.github.com/repos/datadotworld/excel-add-in/subscription","commits_url":"https://api.github.com/repos/datadotworld/excel-add-in/commits{/sha}","git_commits_url":"https://api.github.com/repos/datadotworld/excel-add-in/git/commits{/sha}","comments_url":"https://api.github.com/repos/datadotworld/excel-add-in/comments{/number}","issue_comment_url":"https://api.github.com/repos/datadotworld/excel-add-in/issues/comments{/number}","contents_url":"https://api.github.com/repos/datadotworld/excel-add-in/contents/{+path}","compare_url":"https://api.github.com/repos/datadotworld/excel-add-in/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datadotworld/excel-add-in/merges","archive_url":"https://api.github.com/repos/datadotworld/excel-add-in/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datadotworld/excel-add-in/downloads","issues_url":"https://api.github.com/repos/datadotworld/excel-add-in/issues{/number}","pulls_url":"https://api.github.com/repos/datadotworld/excel-add-in/pulls{/number}","milestones_url":"https://api.github.com/repos/datadotworld/excel-add-in/milestones{/number}","notifications_url":"https://api.github.com/repos/datadotworld/excel-add-in/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datadotworld/excel-add-in/labels{/name}","releases_url":"https://api.github.com/repos/datadotworld/excel-add-in/releases{/id}","deployments_url":"https://api.github.com/repos/datadotworld/excel-add-in/deployments","created_at":"2017-07-24T17:08:14Z","updated_at":"2018-12-05T21:03:06Z","pushed_at":"2018-12-06T17:22:02Z","git_url":"git://github.com/datadotworld/excel-add-in.git","ssh_url":"git@github.com:datadotworld/excel-add-in.git","clone_url":"https://github.com/datadotworld/excel-add-in.git","svn_url":"https://github.com/datadotworld/excel-add-in","homepage":"https://data.world/integrations/excel","size":1692,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":10,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datadotworld/excel-add-in/pulls/98"},"html":{"href":"https://github.com/datadotworld/excel-add-in/pull/98"},"issue":{"href":"https://api.github.com/repos/datadotworld/excel-add-in/issues/98"},"comments":{"href":"https://api.github.com/repos/datadotworld/excel-add-in/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/datadotworld/excel-add-in/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/datadotworld/excel-add-in/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datadotworld/excel-add-in/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/datadotworld/excel-add-in/statuses/7236539c43ecdde31a20d2c5ef51065634075993"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"markmarkoh"}}