{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/183607817","pull_request_review_id":114635685,"id":183607817,"diff_hunk":"@@ -109,7 +109,7 @@ func Main(ctx context.Context, loggingEndpoint, controlEndpoint string) error {\n \t\t\tlog.Debugf(ctx, \"RECV: %v\", proto.MarshalTextString(req))\n \t\t\trecordInstructionRequest(req)\n \n-\t\t\thooks.RunRequestHooks(ctx, req)\n+\t\t\tctx = hooks.RunRequestHooks(ctx, req)","path":"sdks/go/pkg/beam/core/runtime/harness/harness.go","position":5,"original_position":5,"commit_id":"37d00d363a2903081da582f82cdf422ef99b35f4","original_commit_id":"37d00d363a2903081da582f82cdf422ef99b35f4","user":{"login":"herohde","id":14226387,"avatar_url":"https://avatars1.githubusercontent.com/u/14226387?v=4","gravatar_id":"","url":"https://api.github.com/users/herohde","html_url":"https://github.com/herohde","followers_url":"https://api.github.com/users/herohde/followers","following_url":"https://api.github.com/users/herohde/following{/other_user}","gists_url":"https://api.github.com/users/herohde/gists{/gist_id}","starred_url":"https://api.github.com/users/herohde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herohde/subscriptions","organizations_url":"https://api.github.com/users/herohde/orgs","repos_url":"https://api.github.com/users/herohde/repos","events_url":"https://api.github.com/users/herohde/events{/privacy}","received_events_url":"https://api.github.com/users/herohde/received_events","type":"User","site_admin":false},"body":"We should use a local variable for the returned context to limit the scope to just the present request/response.","created_at":"2018-04-24T05:23:41Z","updated_at":"2018-04-24T05:27:21Z","html_url":"https://github.com/apache/beam/pull/5204#discussion_r183607817","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/5204","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/183607817"},"html":{"href":"https://github.com/apache/beam/pull/5204#discussion_r183607817"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/5204"}}},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/5204","id":183594265,"html_url":"https://github.com/apache/beam/pull/5204","diff_url":"https://github.com/apache/beam/pull/5204.diff","patch_url":"https://github.com/apache/beam/pull/5204.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/5204","number":5204,"state":"open","locked":false,"title":"Allow request hooks to update the context.","user":{"login":"wcn3","id":4626810,"avatar_url":"https://avatars1.githubusercontent.com/u/4626810?v=4","gravatar_id":"","url":"https://api.github.com/users/wcn3","html_url":"https://github.com/wcn3","followers_url":"https://api.github.com/users/wcn3/followers","following_url":"https://api.github.com/users/wcn3/following{/other_user}","gists_url":"https://api.github.com/users/wcn3/gists{/gist_id}","starred_url":"https://api.github.com/users/wcn3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wcn3/subscriptions","organizations_url":"https://api.github.com/users/wcn3/orgs","repos_url":"https://api.github.com/users/wcn3/repos","events_url":"https://api.github.com/users/wcn3/events{/privacy}","received_events_url":"https://api.github.com/users/wcn3/received_events","type":"User","site_admin":false},"body":"It's useful for a request hook to enrich the context with information,\r\nso it can pass values to downstream processing. The hook should return the\r\noriginally provided context if no modifications are made.\r\n","created_at":"2018-04-24T00:54:04Z","updated_at":"2018-04-24T05:27:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63e24cc40e65b25f9d586488d2e318f4e427f117","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/5204/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/5204/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/5204/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/37d00d363a2903081da582f82cdf422ef99b35f4","head":{"label":"wcn3:request_hook_context_propagation","ref":"request_hook_context_propagation","sha":"37d00d363a2903081da582f82cdf422ef99b35f4","user":{"login":"wcn3","id":4626810,"avatar_url":"https://avatars1.githubusercontent.com/u/4626810?v=4","gravatar_id":"","url":"https://api.github.com/users/wcn3","html_url":"https://github.com/wcn3","followers_url":"https://api.github.com/users/wcn3/followers","following_url":"https://api.github.com/users/wcn3/following{/other_user}","gists_url":"https://api.github.com/users/wcn3/gists{/gist_id}","starred_url":"https://api.github.com/users/wcn3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wcn3/subscriptions","organizations_url":"https://api.github.com/users/wcn3/orgs","repos_url":"https://api.github.com/users/wcn3/repos","events_url":"https://api.github.com/users/wcn3/events{/privacy}","received_events_url":"https://api.github.com/users/wcn3/received_events","type":"User","site_admin":false},"repo":{"id":109756517,"name":"beam","full_name":"wcn3/beam","owner":{"login":"wcn3","id":4626810,"avatar_url":"https://avatars1.githubusercontent.com/u/4626810?v=4","gravatar_id":"","url":"https://api.github.com/users/wcn3","html_url":"https://github.com/wcn3","followers_url":"https://api.github.com/users/wcn3/followers","following_url":"https://api.github.com/users/wcn3/following{/other_user}","gists_url":"https://api.github.com/users/wcn3/gists{/gist_id}","starred_url":"https://api.github.com/users/wcn3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wcn3/subscriptions","organizations_url":"https://api.github.com/users/wcn3/orgs","repos_url":"https://api.github.com/users/wcn3/repos","events_url":"https://api.github.com/users/wcn3/events{/privacy}","received_events_url":"https://api.github.com/users/wcn3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wcn3/beam","description":"Mirror of Apache Beam","fork":true,"url":"https://api.github.com/repos/wcn3/beam","forks_url":"https://api.github.com/repos/wcn3/beam/forks","keys_url":"https://api.github.com/repos/wcn3/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wcn3/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wcn3/beam/teams","hooks_url":"https://api.github.com/repos/wcn3/beam/hooks","issue_events_url":"https://api.github.com/repos/wcn3/beam/issues/events{/number}","events_url":"https://api.github.com/repos/wcn3/beam/events","assignees_url":"https://api.github.com/repos/wcn3/beam/assignees{/user}","branches_url":"https://api.github.com/repos/wcn3/beam/branches{/branch}","tags_url":"https://api.github.com/repos/wcn3/beam/tags","blobs_url":"https://api.github.com/repos/wcn3/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wcn3/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wcn3/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/wcn3/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wcn3/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/wcn3/beam/languages","stargazers_url":"https://api.github.com/repos/wcn3/beam/stargazers","contributors_url":"https://api.github.com/repos/wcn3/beam/contributors","subscribers_url":"https://api.github.com/repos/wcn3/beam/subscribers","subscription_url":"https://api.github.com/repos/wcn3/beam/subscription","commits_url":"https://api.github.com/repos/wcn3/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/wcn3/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/wcn3/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/wcn3/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/wcn3/beam/contents/{+path}","compare_url":"https://api.github.com/repos/wcn3/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wcn3/beam/merges","archive_url":"https://api.github.com/repos/wcn3/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wcn3/beam/downloads","issues_url":"https://api.github.com/repos/wcn3/beam/issues{/number}","pulls_url":"https://api.github.com/repos/wcn3/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/wcn3/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/wcn3/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wcn3/beam/labels{/name}","releases_url":"https://api.github.com/repos/wcn3/beam/releases{/id}","deployments_url":"https://api.github.com/repos/wcn3/beam/deployments","created_at":"2017-11-06T22:17:00Z","updated_at":"2018-04-19T16:33:56Z","pushed_at":"2018-04-24T01:14:58Z","git_url":"git://github.com/wcn3/beam.git","ssh_url":"git@github.com:wcn3/beam.git","clone_url":"https://github.com/wcn3/beam.git","svn_url":"https://github.com/wcn3/beam","homepage":"","size":57944,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"0f2ba71e1b6db88ed79744e363586a8ff16dcb08","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"beam","full_name":"apache/beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2018-04-24T03:58:13Z","pushed_at":"2018-04-24T03:57:53Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"","size":57348,"stargazers_count":1828,"watchers_count":1828,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1117,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1117,"open_issues":118,"watchers":1828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/5204"},"html":{"href":"https://github.com/apache/beam/pull/5204"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/5204"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/5204/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/5204/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/5204/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/37d00d363a2903081da582f82cdf422ef99b35f4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"herohde"}}