{"action":"closed","number":657,"pull_request":{"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/657","id":195032248,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MDMyMjQ4","html_url":"https://github.com/Microsoft/botbuilder-dotnet/pull/657","diff_url":"https://github.com/Microsoft/botbuilder-dotnet/pull/657.diff","patch_url":"https://github.com/Microsoft/botbuilder-dotnet/pull/657.patch","issue_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/657","number":657,"state":"closed","locked":false,"title":"Made OnTurn in TranslationMiddleware virtual so it can be overridden.","user":{"login":"gabog","id":12264946,"node_id":"MDQ6VXNlcjEyMjY0OTQ2","avatar_url":"https://avatars2.githubusercontent.com/u/12264946?v=4","gravatar_id":"","url":"https://api.github.com/users/gabog","html_url":"https://github.com/gabog","followers_url":"https://api.github.com/users/gabog/followers","following_url":"https://api.github.com/users/gabog/following{/other_user}","gists_url":"https://api.github.com/users/gabog/gists{/gist_id}","starred_url":"https://api.github.com/users/gabog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabog/subscriptions","organizations_url":"https://api.github.com/users/gabog/orgs","repos_url":"https://api.github.com/users/gabog/repos","events_url":"https://api.github.com/users/gabog/events{/privacy}","received_events_url":"https://api.github.com/users/gabog/received_events","type":"User","site_admin":false},"body":"Added test to ensure public member are virtual in the class and be overridden and also a specialized test class to check the overridden value in the new middleware.","created_at":"2018-06-14T22:13:49Z","updated_at":"2018-06-15T03:38:49Z","closed_at":"2018-06-15T03:38:49Z","merged_at":"2018-06-15T03:38:49Z","merge_commit_sha":"e11c635558f44e6814a3ec23ee55999c939157a1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/657/commits","review_comments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/657/comments","review_comment_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/657/comments","statuses_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/statuses/a559198a18c53b88621efa4c4f2278a65805b977","head":{"label":"Microsoft:gabog/overridableTranslator","ref":"gabog/overridableTranslator","sha":"a559198a18c53b88621efa4c4f2278a65805b977","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":117021670,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcwMjE2NzA=","name":"botbuilder-dotnet","full_name":"Microsoft/botbuilder-dotnet","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/botbuilder-dotnet","description":"The Microsoft Bot Framework provides what you need to build and connect intelligent bots that interact naturally wherever your users are talking, from text/sms to Skype, Slack, Office 365 mail and other popular services.","fork":false,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet","forks_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/forks","keys_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/teams","hooks_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/events","assignees_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/tags","blobs_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/languages","stargazers_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/subscription","commits_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/merges","archive_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/downloads","issues_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/deployments","created_at":"2018-01-10T23:03:16Z","updated_at":"2018-06-13T01:14:16Z","pushed_at":"2018-06-15T03:38:49Z","git_url":"git://github.com/Microsoft/botbuilder-dotnet.git","ssh_url":"git@github.com:Microsoft/botbuilder-dotnet.git","clone_url":"https://github.com/Microsoft/botbuilder-dotnet.git","svn_url":"https://github.com/Microsoft/botbuilder-dotnet","homepage":"http://botframework.com","size":4387,"stargazers_count":141,"watchers_count":141,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":72,"open_issues":61,"watchers":141,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"441138c433e44ffefa296385c2d30c53bdf6db5a","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":117021670,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcwMjE2NzA=","name":"botbuilder-dotnet","full_name":"Microsoft/botbuilder-dotnet","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/botbuilder-dotnet","description":"The Microsoft Bot Framework provides what you need to build and connect intelligent bots that interact naturally wherever your users are talking, from text/sms to Skype, Slack, Office 365 mail and other popular services.","fork":false,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet","forks_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/forks","keys_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/teams","hooks_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/events","assignees_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/tags","blobs_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/languages","stargazers_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/subscription","commits_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/merges","archive_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/downloads","issues_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/deployments","created_at":"2018-01-10T23:03:16Z","updated_at":"2018-06-13T01:14:16Z","pushed_at":"2018-06-15T03:38:49Z","git_url":"git://github.com/Microsoft/botbuilder-dotnet.git","ssh_url":"git@github.com:Microsoft/botbuilder-dotnet.git","clone_url":"https://github.com/Microsoft/botbuilder-dotnet.git","svn_url":"https://github.com/Microsoft/botbuilder-dotnet","homepage":"http://botframework.com","size":4387,"stargazers_count":141,"watchers_count":141,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":72,"open_issues":61,"watchers":141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/657"},"html":{"href":"https://github.com/Microsoft/botbuilder-dotnet/pull/657"},"issue":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/657"},"comments":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/657/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/657/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/657/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/statuses/a559198a18c53b88621efa4c4f2278a65805b977"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cleemullins","id":1165321,"node_id":"MDQ6VXNlcjExNjUzMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1165321?v=4","gravatar_id":"","url":"https://api.github.com/users/cleemullins","html_url":"https://github.com/cleemullins","followers_url":"https://api.github.com/users/cleemullins/followers","following_url":"https://api.github.com/users/cleemullins/following{/other_user}","gists_url":"https://api.github.com/users/cleemullins/gists{/gist_id}","starred_url":"https://api.github.com/users/cleemullins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleemullins/subscriptions","organizations_url":"https://api.github.com/users/cleemullins/orgs","repos_url":"https://api.github.com/users/cleemullins/repos","events_url":"https://api.github.com/users/cleemullins/events{/privacy}","received_events_url":"https://api.github.com/users/cleemullins/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":110,"deletions":39,"changed_files":2}}
{"actor":{"display_login":"cleemullins"}}