{"action":"created","comment":{"url":"https://api.github.com/repos/haitch/azure-powershell/pulls/comments/236428457","pull_request_review_id":178502801,"id":236428457,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjQyODQ1Nw==","diff_hunk":"@@ -31,30 +31,31 @@ public class GetAzureRMBlueprint : BlueprintCmdletBase\n     {\n         #region Class Constants\n         // Parameter Set names\n-        const string ParameterSetDefault = \"Default\";\n-        const string ParameterSetByVersion = \"ByVersion\";\n-        const string ParameterSetLatestPublished = \"LatestPublished\";\n+        const string ManagementGroupScope = \"ManagementGroupScope\";\n+        const string BlueprintDefinitionByName = \"BlueprintDefinitionByName\";\n+        const string BlueprintDefinitionByVersion = \"BlueprintDefinitionScopeByVersion\";\n+        //TODO: Add subscription scope for subscription scope up top.\n         #endregion Class Constants\n \n         #region Parameters\n-        [Parameter(Mandatory = false, Position = 0, ValueFromPipeline = true, ParameterSetName = ParameterSetDefault)]\n-        [Parameter(Mandatory = true, Position = 0, ValueFromPipeline = true, ParameterSetName = ParameterSetByVersion)]\n-        [Parameter(Mandatory = true, Position = 0, ValueFromPipeline = true, ParameterSetName = ParameterSetLatestPublished)]\n+        //[Parameter(ParameterSetName = BlueprintDefinitionLatestPublished, Mandatory = false, HelpMessage = \"Blueprint definition's latest published version.\")]\n+        [Parameter(ParameterSetName = BlueprintDefinitionByVersion, Position = 0, Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = \"Blueprint definition version.\")]\n+        [Parameter(ParameterSetName = BlueprintDefinitionByName, Position = 0, Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = \"Blueprint definition name.\")]\n+        [Parameter(ParameterSetName = ManagementGroupScope, Position = 0, Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = \"Management group name.\")]\n         [ValidateNotNullOrEmpty]\n-        public string[] Name { get; set; }\n+        public string ManagementGroupName { get; set; }\n \n-        [Parameter(Mandatory = false, ParameterSetName = ParameterSetDefault)]\n-        [Parameter(Mandatory = true, ParameterSetName = ParameterSetByVersion)]\n-        [Parameter(Mandatory = true, ParameterSetName = ParameterSetLatestPublished)]\n+        [Parameter(ParameterSetName = BlueprintDefinitionByVersion, Position = 2, Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = \"Blueprint definition version.\")]\n+        [Parameter(ParameterSetName = BlueprintDefinitionByName, Position = 1, Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = \"Blueprint definition name.\")]\n         [ValidateNotNullOrEmpty]\n-        public string[] ManagementGroupName { get; set; }\n+        public string BlueprintDefinitionName { get; set; }","path":"src/ResourceManager/Blueprint/Commands.Blueprint/Cmdlets/GetAzureRMBlueprint.cs","position":32,"original_position":32,"commit_id":"fd0fd9b154ea0d5f675b53d6e33362db879ee805","original_commit_id":"fd0fd9b154ea0d5f675b53d6e33362db879ee805","user":{"login":"haitch","id":1167635,"node_id":"MDQ6VXNlcjExNjc2MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1167635?v=4","gravatar_id":"","url":"https://api.github.com/users/haitch","html_url":"https://github.com/haitch","followers_url":"https://api.github.com/users/haitch/followers","following_url":"https://api.github.com/users/haitch/following{/other_user}","gists_url":"https://api.github.com/users/haitch/gists{/gist_id}","starred_url":"https://api.github.com/users/haitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haitch/subscriptions","organizations_url":"https://api.github.com/users/haitch/orgs","repos_url":"https://api.github.com/users/haitch/repos","events_url":"https://api.github.com/users/haitch/events{/privacy}","received_events_url":"https://api.github.com/users/haitch/received_events","type":"User","site_admin":false},"body":"I would keep use Name.\r\n\r\nimage you are typing a cmdlet, -Name is definitely better than -BlueprintDefinitionName.","created_at":"2018-11-26T21:12:53Z","updated_at":"2018-11-26T21:12:54Z","html_url":"https://github.com/haitch/azure-powershell/pull/2#discussion_r236428457","pull_request_url":"https://api.github.com/repos/haitch/azure-powershell/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/haitch/azure-powershell/pulls/comments/236428457"},"html":{"href":"https://github.com/haitch/azure-powershell/pull/2#discussion_r236428457"},"pull_request":{"href":"https://api.github.com/repos/haitch/azure-powershell/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/haitch/azure-powershell/pulls/2","id":233695340,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjk1MzQw","html_url":"https://github.com/haitch/azure-powershell/pull/2","diff_url":"https://github.com/haitch/azure-powershell/pull/2.diff","patch_url":"https://github.com/haitch/azure-powershell/pull/2.patch","issue_url":"https://api.github.com/repos/haitch/azure-powershell/issues/2","number":2,"state":"open","locked":false,"title":"Powershell updates","user":{"login":"filizt","id":22536765,"node_id":"MDQ6VXNlcjIyNTM2NzY1","avatar_url":"https://avatars3.githubusercontent.com/u/22536765?v=4","gravatar_id":"","url":"https://api.github.com/users/filizt","html_url":"https://github.com/filizt","followers_url":"https://api.github.com/users/filizt/followers","following_url":"https://api.github.com/users/filizt/following{/other_user}","gists_url":"https://api.github.com/users/filizt/gists{/gist_id}","starred_url":"https://api.github.com/users/filizt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filizt/subscriptions","organizations_url":"https://api.github.com/users/filizt/orgs","repos_url":"https://api.github.com/users/filizt/repos","events_url":"https://api.github.com/users/filizt/events{/privacy}","received_events_url":"https://api.github.com/users/filizt/received_events","type":"User","site_admin":false},"body":"<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\n\r\n<!-- Please add a brief description of the changes made in this PR -->\r\n\r\n## Checklist\r\n\r\n- [ ] I have read the [_Submitting Changes_](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#submitting-changes) section of [`CONTRIBUTING.md`](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md)\r\n- [ ] The title of the PR is clear and informative\r\n- [ ] The appropriate [change log has been updated](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#updating-the-change-log)\r\n- [ ] The PR does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/preview/documentation/breaking-changes/breaking-changes-definition.md)\r\n- [ ] If applicable, the changes made in the PR have proper test coverage\r\n- [ ] For public API changes to cmdlets:\r\n    - [ ] the changes have gone through a [cmdlet design review](https://github.com/Azure/azure-powershell-cmdlet-review-pr) (Microsoft internal partners only)\r\n    - [ ] the cmdlet markdown files were [generated using the `platyPS` module](https://github.com/Azure/azure-powershell/blob/preview/documentation/development-docs/help-generation.md)\r\n","created_at":"2018-11-26T21:02:02Z","updated_at":"2018-11-26T21:12:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4408fdf48fb6a6f3b5404cc64d227789fa23da67","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/haitch/azure-powershell/pulls/2/commits","review_comments_url":"https://api.github.com/repos/haitch/azure-powershell/pulls/2/comments","review_comment_url":"https://api.github.com/repos/haitch/azure-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haitch/azure-powershell/issues/2/comments","statuses_url":"https://api.github.com/repos/haitch/azure-powershell/statuses/fd0fd9b154ea0d5f675b53d6e33362db879ee805","head":{"label":"filizt:PowershellUpdates","ref":"PowershellUpdates","sha":"fd0fd9b154ea0d5f675b53d6e33362db879ee805","user":{"login":"filizt","id":22536765,"node_id":"MDQ6VXNlcjIyNTM2NzY1","avatar_url":"https://avatars3.githubusercontent.com/u/22536765?v=4","gravatar_id":"","url":"https://api.github.com/users/filizt","html_url":"https://github.com/filizt","followers_url":"https://api.github.com/users/filizt/followers","following_url":"https://api.github.com/users/filizt/following{/other_user}","gists_url":"https://api.github.com/users/filizt/gists{/gist_id}","starred_url":"https://api.github.com/users/filizt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filizt/subscriptions","organizations_url":"https://api.github.com/users/filizt/orgs","repos_url":"https://api.github.com/users/filizt/repos","events_url":"https://api.github.com/users/filizt/events{/privacy}","received_events_url":"https://api.github.com/users/filizt/received_events","type":"User","site_admin":false},"repo":{"id":159178478,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkxNzg0Nzg=","name":"azure-powershell","full_name":"filizt/azure-powershell","private":false,"owner":{"login":"filizt","id":22536765,"node_id":"MDQ6VXNlcjIyNTM2NzY1","avatar_url":"https://avatars3.githubusercontent.com/u/22536765?v=4","gravatar_id":"","url":"https://api.github.com/users/filizt","html_url":"https://github.com/filizt","followers_url":"https://api.github.com/users/filizt/followers","following_url":"https://api.github.com/users/filizt/following{/other_user}","gists_url":"https://api.github.com/users/filizt/gists{/gist_id}","starred_url":"https://api.github.com/users/filizt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filizt/subscriptions","organizations_url":"https://api.github.com/users/filizt/orgs","repos_url":"https://api.github.com/users/filizt/repos","events_url":"https://api.github.com/users/filizt/events{/privacy}","received_events_url":"https://api.github.com/users/filizt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/filizt/azure-powershell","description":"Microsoft Azure PowerShell","fork":true,"url":"https://api.github.com/repos/filizt/azure-powershell","forks_url":"https://api.github.com/repos/filizt/azure-powershell/forks","keys_url":"https://api.github.com/repos/filizt/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filizt/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filizt/azure-powershell/teams","hooks_url":"https://api.github.com/repos/filizt/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/filizt/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/filizt/azure-powershell/events","assignees_url":"https://api.github.com/repos/filizt/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/filizt/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/filizt/azure-powershell/tags","blobs_url":"https://api.github.com/repos/filizt/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filizt/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filizt/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/filizt/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filizt/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/filizt/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/filizt/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/filizt/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/filizt/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/filizt/azure-powershell/subscription","commits_url":"https://api.github.com/repos/filizt/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/filizt/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/filizt/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/filizt/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/filizt/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/filizt/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filizt/azure-powershell/merges","archive_url":"https://api.github.com/repos/filizt/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filizt/azure-powershell/downloads","issues_url":"https://api.github.com/repos/filizt/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/filizt/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/filizt/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/filizt/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filizt/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/filizt/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/filizt/azure-powershell/deployments","created_at":"2018-11-26T14:00:35Z","updated_at":"2018-11-26T14:02:03Z","pushed_at":"2018-11-26T20:59:56Z","git_url":"git://github.com/filizt/azure-powershell.git","ssh_url":"git@github.com:filizt/azure-powershell.git","clone_url":"https://github.com/filizt/azure-powershell.git","svn_url":"https://github.com/filizt/azure-powershell","homepage":null,"size":627900,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"preview"}},"base":{"label":"haitch:preview","ref":"preview","sha":"2f8bf6dc6ecf5fb807c6b9d0b1cbe86e06fe2066","user":{"login":"haitch","id":1167635,"node_id":"MDQ6VXNlcjExNjc2MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1167635?v=4","gravatar_id":"","url":"https://api.github.com/users/haitch","html_url":"https://github.com/haitch","followers_url":"https://api.github.com/users/haitch/followers","following_url":"https://api.github.com/users/haitch/following{/other_user}","gists_url":"https://api.github.com/users/haitch/gists{/gist_id}","starred_url":"https://api.github.com/users/haitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haitch/subscriptions","organizations_url":"https://api.github.com/users/haitch/orgs","repos_url":"https://api.github.com/users/haitch/repos","events_url":"https://api.github.com/users/haitch/events{/privacy}","received_events_url":"https://api.github.com/users/haitch/received_events","type":"User","site_admin":false},"repo":{"id":152653347,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI2NTMzNDc=","name":"azure-powershell","full_name":"haitch/azure-powershell","private":false,"owner":{"login":"haitch","id":1167635,"node_id":"MDQ6VXNlcjExNjc2MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1167635?v=4","gravatar_id":"","url":"https://api.github.com/users/haitch","html_url":"https://github.com/haitch","followers_url":"https://api.github.com/users/haitch/followers","following_url":"https://api.github.com/users/haitch/following{/other_user}","gists_url":"https://api.github.com/users/haitch/gists{/gist_id}","starred_url":"https://api.github.com/users/haitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haitch/subscriptions","organizations_url":"https://api.github.com/users/haitch/orgs","repos_url":"https://api.github.com/users/haitch/repos","events_url":"https://api.github.com/users/haitch/events{/privacy}","received_events_url":"https://api.github.com/users/haitch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/haitch/azure-powershell","description":"Microsoft Azure PowerShell","fork":true,"url":"https://api.github.com/repos/haitch/azure-powershell","forks_url":"https://api.github.com/repos/haitch/azure-powershell/forks","keys_url":"https://api.github.com/repos/haitch/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haitch/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haitch/azure-powershell/teams","hooks_url":"https://api.github.com/repos/haitch/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/haitch/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/haitch/azure-powershell/events","assignees_url":"https://api.github.com/repos/haitch/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/haitch/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/haitch/azure-powershell/tags","blobs_url":"https://api.github.com/repos/haitch/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haitch/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haitch/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/haitch/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haitch/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/haitch/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/haitch/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/haitch/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/haitch/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/haitch/azure-powershell/subscription","commits_url":"https://api.github.com/repos/haitch/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/haitch/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/haitch/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/haitch/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/haitch/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/haitch/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haitch/azure-powershell/merges","archive_url":"https://api.github.com/repos/haitch/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haitch/azure-powershell/downloads","issues_url":"https://api.github.com/repos/haitch/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/haitch/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/haitch/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/haitch/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haitch/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/haitch/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/haitch/azure-powershell/deployments","created_at":"2018-10-11T20:42:53Z","updated_at":"2018-11-13T22:13:22Z","pushed_at":"2018-11-26T21:02:03Z","git_url":"git://github.com/haitch/azure-powershell.git","ssh_url":"git@github.com:haitch/azure-powershell.git","clone_url":"https://github.com/haitch/azure-powershell.git","svn_url":"https://github.com/haitch/azure-powershell","homepage":null,"size":627900,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"preview"}},"_links":{"self":{"href":"https://api.github.com/repos/haitch/azure-powershell/pulls/2"},"html":{"href":"https://github.com/haitch/azure-powershell/pull/2"},"issue":{"href":"https://api.github.com/repos/haitch/azure-powershell/issues/2"},"comments":{"href":"https://api.github.com/repos/haitch/azure-powershell/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/haitch/azure-powershell/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/haitch/azure-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haitch/azure-powershell/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/haitch/azure-powershell/statuses/fd0fd9b154ea0d5f675b53d6e33362db879ee805"}},"author_association":"NONE"}}
{"actor":{"display_login":"haitch"}}