{"action":"created","issue":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/4895","repository_url":"https://api.github.com/repos/MetaMask/metamask-extension","labels_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/4895/labels{/name}","comments_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/4895/comments","events_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/4895/events","html_url":"https://github.com/MetaMask/metamask-extension/pull/4895","id":344974037,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjQyMjI1","number":4895,"title":"Add rounding to large exponential numbers. Fix overflows","user":{"login":"alextsg","id":8051479,"node_id":"MDQ6VXNlcjgwNTE0Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8051479?v=4","gravatar_id":"","url":"https://api.github.com/users/alextsg","html_url":"https://github.com/alextsg","followers_url":"https://api.github.com/users/alextsg/followers","following_url":"https://api.github.com/users/alextsg/following{/other_user}","gists_url":"https://api.github.com/users/alextsg/gists{/gist_id}","starred_url":"https://api.github.com/users/alextsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alextsg/subscriptions","organizations_url":"https://api.github.com/users/alextsg/orgs","repos_url":"https://api.github.com/users/alextsg/repos","events_url":"https://api.github.com/users/alextsg/events{/privacy}","received_events_url":"https://api.github.com/users/alextsg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"whymarrh","id":1623628,"node_id":"MDQ6VXNlcjE2MjM2Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1623628?v=4","gravatar_id":"","url":"https://api.github.com/users/whymarrh","html_url":"https://github.com/whymarrh","followers_url":"https://api.github.com/users/whymarrh/followers","following_url":"https://api.github.com/users/whymarrh/following{/other_user}","gists_url":"https://api.github.com/users/whymarrh/gists{/gist_id}","starred_url":"https://api.github.com/users/whymarrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whymarrh/subscriptions","organizations_url":"https://api.github.com/users/whymarrh/orgs","repos_url":"https://api.github.com/users/whymarrh/repos","events_url":"https://api.github.com/users/whymarrh/events{/privacy}","received_events_url":"https://api.github.com/users/whymarrh/received_events","type":"User","site_admin":false},"assignees":[{"login":"whymarrh","id":1623628,"node_id":"MDQ6VXNlcjE2MjM2Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1623628?v=4","gravatar_id":"","url":"https://api.github.com/users/whymarrh","html_url":"https://github.com/whymarrh","followers_url":"https://api.github.com/users/whymarrh/followers","following_url":"https://api.github.com/users/whymarrh/following{/other_user}","gists_url":"https://api.github.com/users/whymarrh/gists{/gist_id}","starred_url":"https://api.github.com/users/whymarrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whymarrh/subscriptions","organizations_url":"https://api.github.com/users/whymarrh/orgs","repos_url":"https://api.github.com/users/whymarrh/repos","events_url":"https://api.github.com/users/whymarrh/events{/privacy}","received_events_url":"https://api.github.com/users/whymarrh/received_events","type":"User","site_admin":false},{"login":"danjm","id":7499938,"node_id":"MDQ6VXNlcjc0OTk5Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/7499938?v=4","gravatar_id":"","url":"https://api.github.com/users/danjm","html_url":"https://github.com/danjm","followers_url":"https://api.github.com/users/danjm/followers","following_url":"https://api.github.com/users/danjm/following{/other_user}","gists_url":"https://api.github.com/users/danjm/gists{/gist_id}","starred_url":"https://api.github.com/users/danjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danjm/subscriptions","organizations_url":"https://api.github.com/users/danjm/orgs","repos_url":"https://api.github.com/users/danjm/repos","events_url":"https://api.github.com/users/danjm/events{/privacy}","received_events_url":"https://api.github.com/users/danjm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-07-26T19:23:58Z","updated_at":"2018-07-27T17:47:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/4895","html_url":"https://github.com/MetaMask/metamask-extension/pull/4895","diff_url":"https://github.com/MetaMask/metamask-extension/pull/4895.diff","patch_url":"https://github.com/MetaMask/metamask-extension/pull/4895.patch"},"body":"Fixes #4886\r\n\r\n<details>\r\n<summary>Screenshot</summary>\r\n<img width=\"372\" src=\"https://user-images.githubusercontent.com/8051479/43283789-ad87ff54-90ce-11e8-9d58-d55af2cd8a26.png\">\r\n</details>\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/comments/408491176","html_url":"https://github.com/MetaMask/metamask-extension/pull/4895#issuecomment-408491176","issue_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/4895","id":408491176,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODQ5MTE3Ng==","user":{"login":"Maayu2415","id":40852375,"node_id":"MDQ6VXNlcjQwODUyMzc1","avatar_url":"https://avatars0.githubusercontent.com/u/40852375?v=4","gravatar_id":"","url":"https://api.github.com/users/Maayu2415","html_url":"https://github.com/Maayu2415","followers_url":"https://api.github.com/users/Maayu2415/followers","following_url":"https://api.github.com/users/Maayu2415/following{/other_user}","gists_url":"https://api.github.com/users/Maayu2415/gists{/gist_id}","starred_url":"https://api.github.com/users/Maayu2415/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maayu2415/subscriptions","organizations_url":"https://api.github.com/users/Maayu2415/orgs","repos_url":"https://api.github.com/users/Maayu2415/repos","events_url":"https://api.github.com/users/Maayu2415/events{/privacy}","received_events_url":"https://api.github.com/users/Maayu2415/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T17:47:14Z","updated_at":"2018-07-27T17:47:14Z","author_association":"NONE","body":"\nWhat happen?\n\nส่งจากสมาร์ทโฟน Samsung Galaxy ของฉัน\n-------- ข้อความดั้งเดิม --------จาก: Whymarrh Whitby <notifications@github.com> วัน​ที่: 28/7/18  00:35  (GMT+07:00) ถึง: MetaMask/metamask-extension <metamask-extension@noreply.github.com> Cc: mjaniam2415@gmail.com, Comment <comment@noreply.github.com> เรื่อง: Re: [MetaMask/metamask-extension] Add rounding to large exponential numbers. Fix overflows (#4895) \n@whymarrh commented on this pull request.\n\n\n\nIn ui/app/helpers/confirm-transaction/util.js:\n> @@ -137,3 +138,11 @@ export function convertTokenToFiat ({\n export function hasUnconfirmedTransactions (state) {\n   return unconfirmedTransactionsCountSelector(state) > 0\n }\n+\n+export function roundExponential (value) {\n+  const PRECISION = 4\n+  const valueBN = new BigNumber(value)\n\n\nso that it's clear it is not a BN.js object\n\nIt's not?\n\n—\nYou are receiving this because you commented.\nReply to this email directly, view it on GitHub, or mute the thread.\n{\"api_version\":\"1.0\",\"publisher\":{\"api_key\":\"05dde50f1d1a384dd78767c55493e4bb\",\"name\":\"GitHub\"},\"entity\":{\"external_key\":\"github/MetaMask/metamask-extension\",\"title\":\"MetaMask/metamask-extension\",\"subtitle\":\"GitHub repository\",\"main_image_url\":\"https://assets-cdn.github.com/images/email/message_cards/header.png\",\"avatar_image_url\":\"https://assets-cdn.github.com/images/email/message_cards/avatar.png\",\"action\":{\"name\":\"Open in GitHub\",\"url\":\"https://github.com/MetaMask/metamask-extension\"}},\"updates\":{\"snippets\":[{\"icon\":\"PERSON\",\"message\":\"@whymarrh commented on #4895\"}],\"action\":{\"name\":\"View Pull Request\",\"url\":\"https://github.com/MetaMask/metamask-extension/pull/4895#discussion_r205847442\"}}}\n[\n{\n\"@context\": \"http://schema.org\",\n\"@type\": \"EmailMessage\",\n\"potentialAction\": {\n\"@type\": \"ViewAction\",\n\"target\": \"https://github.com/MetaMask/metamask-extension/pull/4895#discussion_r205847442\",\n\"url\": \"https://github.com/MetaMask/metamask-extension/pull/4895#discussion_r205847442\",\n\"name\": \"View Pull Request\"\n},\n\"description\": \"View this Pull Request on GitHub\",\n\"publisher\": {\n\"@type\": \"Organization\",\n\"name\": \"GitHub\",\n\"url\": \"https://github.com\"\n}\n},\n{\n\"@type\": \"MessageCard\",\n\"@context\": \"http://schema.org/extensions\",\n\"hideOriginalBody\": \"false\",\n\"originator\": \"AF6C5A86-E920-430C-9C59-A73278B5EFEB\",\n\"title\": \"@whymarrh commented on 4895\",\n\"sections\": [\n{\n\"text\": \"\",\n\"activityTitle\": \"**Whymarrh Whitby**\",\n\"activityImage\": \"https://assets-cdn.github.com/images/email/message_cards/avatar.png\",\n\"activitySubtitle\": \"@whymarrh\",\n\"facts\": [\n\n]\n}\n],\n\"potentialAction\": [\n{\n\"targets\": [\n{\n\"os\": \"default\",\n\"uri\": \"https://github.com/MetaMask/metamask-extension/pull/4895#discussion_r205847442\"\n}\n],\n\"@type\": \"OpenUri\",\n\"name\": \"View on GitHub\"\n},\n{\n\"name\": \"Unsubscribe\",\n\"@type\": \"HttpPOST\",\n\"target\": \"https://api.github.com\",\n\"body\": \"{\\n\\\"commandName\\\": \\\"MuteNotification\\\",\\n\\\"threadId\\\": 361342167\\n}\"\n}\n],\n\"themeColor\": \"26292E\"\n}\n]"}}
{"actor":{"display_login":"Maayu2415"}}