{"action":"created","comment":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments/198999800","pull_request_review_id":133037380,"id":198999800,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODk5OTgwMA==","diff_hunk":"@@ -319,6 +319,18 @@ public TaskResult getTaskResultFromIncarnation(JobId jobId, String taskName, int\n         return uischeduler.getTaskResultFromIncarnation(jobId, taskName, inc);\n     }\n \n+    @Override\n+    public List<TaskResult> getTaskResultAllIncarnations(JobId jobId, String taskName)\n+            throws NotConnectedException, UnknownJobException, UnknownTaskException, PermissionException {\n+        return uischeduler.getTaskResultAllIncarnations(jobId, taskName);\n+    }\n+\n+    @Override\n+    public List<TaskResult> getTaskResultAllIncarnations(String jobId, String taskName)\n+            throws NotConnectedException, UnknownJobException, UnknownTaskException, PermissionException {\n+        return uischeduler.getTaskResultAllIncarnations(jobId, taskName);\n+    }\n+\n     @Override\n     public TaskResult getTaskResultFromIncarnation(String jobId, String taskName, int inc)\n             throws NotConnectedException, UnknownJobException, UnknownTaskException, PermissionException {","path":"scheduler/scheduler-client/src/main/java/org/ow2/proactive/scheduler/common/util/SchedulerProxyUserInterface.java","position":18,"original_position":18,"commit_id":"79a7fa09e92040f97ade87bbf8df24ce82b28a28","original_commit_id":"79a7fa09e92040f97ade87bbf8df24ce82b28a28","user":{"login":"sonarqube-activeeon","id":14940028,"node_id":"MDQ6VXNlcjE0OTQwMDI4","avatar_url":"https://avatars1.githubusercontent.com/u/14940028?v=4","gravatar_id":"","url":"https://api.github.com/users/sonarqube-activeeon","html_url":"https://github.com/sonarqube-activeeon","followers_url":"https://api.github.com/users/sonarqube-activeeon/followers","following_url":"https://api.github.com/users/sonarqube-activeeon/following{/other_user}","gists_url":"https://api.github.com/users/sonarqube-activeeon/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarqube-activeeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarqube-activeeon/subscriptions","organizations_url":"https://api.github.com/users/sonarqube-activeeon/orgs","repos_url":"https://api.github.com/users/sonarqube-activeeon/repos","events_url":"https://api.github.com/users/sonarqube-activeeon/events{/privacy}","received_events_url":"https://api.github.com/users/sonarqube-activeeon/received_events","type":"User","site_admin":false},"body":"![MINOR](https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR') Remove the redundant '!unknownSymbol!' thrown exception declaration(s). [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3ARedundantThrowsDeclarationCheck)\n","created_at":"2018-06-28T22:00:02Z","updated_at":"2018-06-28T22:00:03Z","html_url":"https://github.com/ow2-proactive/scheduling/pull/3249#discussion_r198999800","pull_request_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3249","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments/198999800"},"html":{"href":"https://github.com/ow2-proactive/scheduling/pull/3249#discussion_r198999800"},"pull_request":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3249"}}},"pull_request":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3249","id":198135944,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTM1OTQ0","html_url":"https://github.com/ow2-proactive/scheduling/pull/3249","diff_url":"https://github.com/ow2-proactive/scheduling/pull/3249.diff","patch_url":"https://github.com/ow2-proactive/scheduling/pull/3249.patch","issue_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/3249","number":3249,"state":"open","locked":false,"title":"fix for #2783 Unable to retrieve logs from an in-error task","user":{"login":"fviale","id":3063713,"node_id":"MDQ6VXNlcjMwNjM3MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/3063713?v=4","gravatar_id":"","url":"https://api.github.com/users/fviale","html_url":"https://github.com/fviale","followers_url":"https://api.github.com/users/fviale/followers","following_url":"https://api.github.com/users/fviale/following{/other_user}","gists_url":"https://api.github.com/users/fviale/gists{/gist_id}","starred_url":"https://api.github.com/users/fviale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fviale/subscriptions","organizations_url":"https://api.github.com/users/fviale/orgs","repos_url":"https://api.github.com/users/fviale/repos","events_url":"https://api.github.com/users/fviale/events{/privacy}","received_events_url":"https://api.github.com/users/fviale/received_events","type":"User","site_admin":false},"body":" - Scheduler: add methods to load all task result incarnations for a given task\r\n - add corresponding methods in SchedulerDBManager\r\n - modified SchedulerStateRest to use appropriate methods to consider all task incarnations\r\n - TaskLauncher : copy previous task incarnation log file in case of preciousLogs=true. New logs will be appended to the previous incarnation(s) file.\r\n - TaskResultData : add a new unit test\r\n - TestPreciousLogs : improve functional test to check that precious logs contain multiple task execution attempts","created_at":"2018-06-28T19:55:02Z","updated_at":"2018-06-28T22:00:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e59df9eb84167084c2c3bfec17fd666cf57aa05c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"marcocast","id":706746,"node_id":"MDQ6VXNlcjcwNjc0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/706746?v=4","gravatar_id":"","url":"https://api.github.com/users/marcocast","html_url":"https://github.com/marcocast","followers_url":"https://api.github.com/users/marcocast/followers","following_url":"https://api.github.com/users/marcocast/following{/other_user}","gists_url":"https://api.github.com/users/marcocast/gists{/gist_id}","starred_url":"https://api.github.com/users/marcocast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcocast/subscriptions","organizations_url":"https://api.github.com/users/marcocast/orgs","repos_url":"https://api.github.com/users/marcocast/repos","events_url":"https://api.github.com/users/marcocast/events{/privacy}","received_events_url":"https://api.github.com/users/marcocast/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3249/commits","review_comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3249/comments","review_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/3249/comments","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/79a7fa09e92040f97ade87bbf8df24ce82b28a28","head":{"label":"fviale:master","ref":"master","sha":"79a7fa09e92040f97ade87bbf8df24ce82b28a28","user":{"login":"fviale","id":3063713,"node_id":"MDQ6VXNlcjMwNjM3MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/3063713?v=4","gravatar_id":"","url":"https://api.github.com/users/fviale","html_url":"https://github.com/fviale","followers_url":"https://api.github.com/users/fviale/followers","following_url":"https://api.github.com/users/fviale/following{/other_user}","gists_url":"https://api.github.com/users/fviale/gists{/gist_id}","starred_url":"https://api.github.com/users/fviale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fviale/subscriptions","organizations_url":"https://api.github.com/users/fviale/orgs","repos_url":"https://api.github.com/users/fviale/repos","events_url":"https://api.github.com/users/fviale/events{/privacy}","received_events_url":"https://api.github.com/users/fviale/received_events","type":"User","site_admin":false},"repo":{"id":78038357,"node_id":"MDEwOlJlcG9zaXRvcnk3ODAzODM1Nw==","name":"scheduling","full_name":"fviale/scheduling","owner":{"login":"fviale","id":3063713,"node_id":"MDQ6VXNlcjMwNjM3MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/3063713?v=4","gravatar_id":"","url":"https://api.github.com/users/fviale","html_url":"https://github.com/fviale","followers_url":"https://api.github.com/users/fviale/followers","following_url":"https://api.github.com/users/fviale/following{/other_user}","gists_url":"https://api.github.com/users/fviale/gists{/gist_id}","starred_url":"https://api.github.com/users/fviale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fviale/subscriptions","organizations_url":"https://api.github.com/users/fviale/orgs","repos_url":"https://api.github.com/users/fviale/repos","events_url":"https://api.github.com/users/fviale/events{/privacy}","received_events_url":"https://api.github.com/users/fviale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fviale/scheduling","description":"Multi-platform Scheduling and Workflows Engine","fork":true,"url":"https://api.github.com/repos/fviale/scheduling","forks_url":"https://api.github.com/repos/fviale/scheduling/forks","keys_url":"https://api.github.com/repos/fviale/scheduling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fviale/scheduling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fviale/scheduling/teams","hooks_url":"https://api.github.com/repos/fviale/scheduling/hooks","issue_events_url":"https://api.github.com/repos/fviale/scheduling/issues/events{/number}","events_url":"https://api.github.com/repos/fviale/scheduling/events","assignees_url":"https://api.github.com/repos/fviale/scheduling/assignees{/user}","branches_url":"https://api.github.com/repos/fviale/scheduling/branches{/branch}","tags_url":"https://api.github.com/repos/fviale/scheduling/tags","blobs_url":"https://api.github.com/repos/fviale/scheduling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fviale/scheduling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fviale/scheduling/git/refs{/sha}","trees_url":"https://api.github.com/repos/fviale/scheduling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fviale/scheduling/statuses/{sha}","languages_url":"https://api.github.com/repos/fviale/scheduling/languages","stargazers_url":"https://api.github.com/repos/fviale/scheduling/stargazers","contributors_url":"https://api.github.com/repos/fviale/scheduling/contributors","subscribers_url":"https://api.github.com/repos/fviale/scheduling/subscribers","subscription_url":"https://api.github.com/repos/fviale/scheduling/subscription","commits_url":"https://api.github.com/repos/fviale/scheduling/commits{/sha}","git_commits_url":"https://api.github.com/repos/fviale/scheduling/git/commits{/sha}","comments_url":"https://api.github.com/repos/fviale/scheduling/comments{/number}","issue_comment_url":"https://api.github.com/repos/fviale/scheduling/issues/comments{/number}","contents_url":"https://api.github.com/repos/fviale/scheduling/contents/{+path}","compare_url":"https://api.github.com/repos/fviale/scheduling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fviale/scheduling/merges","archive_url":"https://api.github.com/repos/fviale/scheduling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fviale/scheduling/downloads","issues_url":"https://api.github.com/repos/fviale/scheduling/issues{/number}","pulls_url":"https://api.github.com/repos/fviale/scheduling/pulls{/number}","milestones_url":"https://api.github.com/repos/fviale/scheduling/milestones{/number}","notifications_url":"https://api.github.com/repos/fviale/scheduling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fviale/scheduling/labels{/name}","releases_url":"https://api.github.com/repos/fviale/scheduling/releases{/id}","deployments_url":"https://api.github.com/repos/fviale/scheduling/deployments","created_at":"2017-01-04T17:41:08Z","updated_at":"2018-06-28T19:53:40Z","pushed_at":"2018-06-28T19:53:38Z","git_url":"git://github.com/fviale/scheduling.git","ssh_url":"git@github.com:fviale/scheduling.git","clone_url":"https://github.com/fviale/scheduling.git","svn_url":"https://github.com/fviale/scheduling","homepage":"http://www.activeeon.com/workflows-scheduling","size":72702,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ow2-proactive:master","ref":"master","sha":"26aaab0246bda0d3a68dbfe7070d1ddc6bd92567","user":{"login":"ow2-proactive","id":11553998,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTUzOTk4","avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"repo":{"id":35725079,"node_id":"MDEwOlJlcG9zaXRvcnkzNTcyNTA3OQ==","name":"scheduling","full_name":"ow2-proactive/scheduling","owner":{"login":"ow2-proactive","id":11553998,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTUzOTk4","avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ow2-proactive/scheduling","description":"Multi-platform Scheduling and Workflows Engine","fork":false,"url":"https://api.github.com/repos/ow2-proactive/scheduling","forks_url":"https://api.github.com/repos/ow2-proactive/scheduling/forks","keys_url":"https://api.github.com/repos/ow2-proactive/scheduling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ow2-proactive/scheduling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ow2-proactive/scheduling/teams","hooks_url":"https://api.github.com/repos/ow2-proactive/scheduling/hooks","issue_events_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/events{/number}","events_url":"https://api.github.com/repos/ow2-proactive/scheduling/events","assignees_url":"https://api.github.com/repos/ow2-proactive/scheduling/assignees{/user}","branches_url":"https://api.github.com/repos/ow2-proactive/scheduling/branches{/branch}","tags_url":"https://api.github.com/repos/ow2-proactive/scheduling/tags","blobs_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/refs{/sha}","trees_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/{sha}","languages_url":"https://api.github.com/repos/ow2-proactive/scheduling/languages","stargazers_url":"https://api.github.com/repos/ow2-proactive/scheduling/stargazers","contributors_url":"https://api.github.com/repos/ow2-proactive/scheduling/contributors","subscribers_url":"https://api.github.com/repos/ow2-proactive/scheduling/subscribers","subscription_url":"https://api.github.com/repos/ow2-proactive/scheduling/subscription","commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/commits{/sha}","git_commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/commits{/sha}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/comments{/number}","issue_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/comments{/number}","contents_url":"https://api.github.com/repos/ow2-proactive/scheduling/contents/{+path}","compare_url":"https://api.github.com/repos/ow2-proactive/scheduling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ow2-proactive/scheduling/merges","archive_url":"https://api.github.com/repos/ow2-proactive/scheduling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ow2-proactive/scheduling/downloads","issues_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues{/number}","pulls_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls{/number}","milestones_url":"https://api.github.com/repos/ow2-proactive/scheduling/milestones{/number}","notifications_url":"https://api.github.com/repos/ow2-proactive/scheduling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ow2-proactive/scheduling/labels{/name}","releases_url":"https://api.github.com/repos/ow2-proactive/scheduling/releases{/id}","deployments_url":"https://api.github.com/repos/ow2-proactive/scheduling/deployments","created_at":"2015-05-16T13:38:55Z","updated_at":"2018-06-26T12:52:40Z","pushed_at":"2018-06-28T19:55:02Z","git_url":"git://github.com/ow2-proactive/scheduling.git","ssh_url":"git@github.com:ow2-proactive/scheduling.git","clone_url":"https://github.com/ow2-proactive/scheduling.git","svn_url":"https://github.com/ow2-proactive/scheduling","homepage":"http://www.activeeon.com/workflows-scheduling","size":73885,"stargazers_count":27,"watchers_count":27,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":175,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":40,"open_issues":175,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3249"},"html":{"href":"https://github.com/ow2-proactive/scheduling/pull/3249"},"issue":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/issues/3249"},"comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/issues/3249/comments"},"review_comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3249/comments"},"review_comment":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3249/commits"},"statuses":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/79a7fa09e92040f97ade87bbf8df24ce82b28a28"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sonarqube-activeeon"}}