{"action":"created","comment":{"url":"https://api.github.com/repos/S2E/s2e-env/pulls/comments/232493008","pull_request_review_id":173703290,"id":232493008,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQ5MzAwOA==","diff_hunk":"@@ -300,7 +301,18 @@ def add_arguments(self, parser):\n                                  'exists, replace it')\n \n     def handle(self, *args, **options):\n-        if options['target']:\n-            _handle_with_file(*args, **options)\n+        # The 'project' option is not exposed as a command-line argument: it is\n+        # typically used when creating a custom project programatically. It\n+        # provides a class that is instantiated with the current command-line\n+        # arguments and options\n+        proj_class = options.get('project')","path":"s2e_env/commands/new_project.py","position":293,"original_position":18,"commit_id":"8e1550c011a5bf5cff1f9867e869e411bd79b059","original_commit_id":"5acb3a86f764161afab54791611f596776cce09a","user":{"login":"vitalych","id":2332715,"node_id":"MDQ6VXNlcjIzMzI3MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2332715?v=4","gravatar_id":"","url":"https://api.github.com/users/vitalych","html_url":"https://github.com/vitalych","followers_url":"https://api.github.com/users/vitalych/followers","following_url":"https://api.github.com/users/vitalych/following{/other_user}","gists_url":"https://api.github.com/users/vitalych/gists{/gist_id}","starred_url":"https://api.github.com/users/vitalych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitalych/subscriptions","organizations_url":"https://api.github.com/users/vitalych/orgs","repos_url":"https://api.github.com/users/vitalych/repos","events_url":"https://api.github.com/users/vitalych/events{/privacy}","received_events_url":"https://api.github.com/users/vitalych/received_events","type":"User","site_admin":false},"body":"It's not clear to me how I can use this feature. A note in the readme would help.","created_at":"2018-11-11T15:47:31Z","updated_at":"2018-11-11T15:47:31Z","html_url":"https://github.com/S2E/s2e-env/pull/216#discussion_r232493008","pull_request_url":"https://api.github.com/repos/S2E/s2e-env/pulls/216","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/S2E/s2e-env/pulls/comments/232493008"},"html":{"href":"https://github.com/S2E/s2e-env/pull/216#discussion_r232493008"},"pull_request":{"href":"https://api.github.com/repos/S2E/s2e-env/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/S2E/s2e-env/pulls/216","id":228168748,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTY4NzQ4","html_url":"https://github.com/S2E/s2e-env/pull/216","diff_url":"https://github.com/S2E/s2e-env/pull/216.diff","patch_url":"https://github.com/S2E/s2e-env/pull/216.patch","issue_url":"https://api.github.com/repos/S2E/s2e-env/issues/216","number":216,"state":"open","locked":false,"title":"Improvement/custom project creation","user":{"login":"adrianherrera","id":8626578,"node_id":"MDQ6VXNlcjg2MjY1Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/8626578?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianherrera","html_url":"https://github.com/adrianherrera","followers_url":"https://api.github.com/users/adrianherrera/followers","following_url":"https://api.github.com/users/adrianherrera/following{/other_user}","gists_url":"https://api.github.com/users/adrianherrera/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianherrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianherrera/subscriptions","organizations_url":"https://api.github.com/users/adrianherrera/orgs","repos_url":"https://api.github.com/users/adrianherrera/repos","events_url":"https://api.github.com/users/adrianherrera/events{/privacy}","received_events_url":"https://api.github.com/users/adrianherrera/received_events","type":"User","site_admin":false},"body":"refactoring of project creation (again 🙂). I want/need the ability to create \"custom projects\" that are outside the standard S2E Windows/Linux/CGC project, and the current project + config class made this a bit clunky.\r\n\r\nI think the new structure simplifies this (mainly because it removes the config classes) and it has the bonus of less mutable state (which I like as an occasional functional programmer 🙂).\r\n\r\nLet me know what you think","created_at":"2018-11-04T10:30:28Z","updated_at":"2018-11-11T15:47:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"860c686aaf910b189e6b43e09d877b8568d3367e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":578998706,"node_id":"MDU6TGFiZWw1Nzg5OTg3MDY=","url":"https://api.github.com/repos/S2E/s2e-env/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/S2E/s2e-env/pulls/216/commits","review_comments_url":"https://api.github.com/repos/S2E/s2e-env/pulls/216/comments","review_comment_url":"https://api.github.com/repos/S2E/s2e-env/pulls/comments{/number}","comments_url":"https://api.github.com/repos/S2E/s2e-env/issues/216/comments","statuses_url":"https://api.github.com/repos/S2E/s2e-env/statuses/8e1550c011a5bf5cff1f9867e869e411bd79b059","head":{"label":"S2E:improvement/custom-project-creation","ref":"improvement/custom-project-creation","sha":"8e1550c011a5bf5cff1f9867e869e411bd79b059","user":{"login":"S2E","id":7384376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODQzNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7384376?v=4","gravatar_id":"","url":"https://api.github.com/users/S2E","html_url":"https://github.com/S2E","followers_url":"https://api.github.com/users/S2E/followers","following_url":"https://api.github.com/users/S2E/following{/other_user}","gists_url":"https://api.github.com/users/S2E/gists{/gist_id}","starred_url":"https://api.github.com/users/S2E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2E/subscriptions","organizations_url":"https://api.github.com/users/S2E/orgs","repos_url":"https://api.github.com/users/S2E/repos","events_url":"https://api.github.com/users/S2E/events{/privacy}","received_events_url":"https://api.github.com/users/S2E/received_events","type":"Organization","site_admin":false},"repo":{"id":87578023,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU3ODAyMw==","name":"s2e-env","full_name":"S2E/s2e-env","private":false,"owner":{"login":"S2E","id":7384376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODQzNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7384376?v=4","gravatar_id":"","url":"https://api.github.com/users/S2E","html_url":"https://github.com/S2E","followers_url":"https://api.github.com/users/S2E/followers","following_url":"https://api.github.com/users/S2E/following{/other_user}","gists_url":"https://api.github.com/users/S2E/gists{/gist_id}","starred_url":"https://api.github.com/users/S2E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2E/subscriptions","organizations_url":"https://api.github.com/users/S2E/orgs","repos_url":"https://api.github.com/users/S2E/repos","events_url":"https://api.github.com/users/S2E/events{/privacy}","received_events_url":"https://api.github.com/users/S2E/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/S2E/s2e-env","description":"Your S2E project management tools","fork":false,"url":"https://api.github.com/repos/S2E/s2e-env","forks_url":"https://api.github.com/repos/S2E/s2e-env/forks","keys_url":"https://api.github.com/repos/S2E/s2e-env/keys{/key_id}","collaborators_url":"https://api.github.com/repos/S2E/s2e-env/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/S2E/s2e-env/teams","hooks_url":"https://api.github.com/repos/S2E/s2e-env/hooks","issue_events_url":"https://api.github.com/repos/S2E/s2e-env/issues/events{/number}","events_url":"https://api.github.com/repos/S2E/s2e-env/events","assignees_url":"https://api.github.com/repos/S2E/s2e-env/assignees{/user}","branches_url":"https://api.github.com/repos/S2E/s2e-env/branches{/branch}","tags_url":"https://api.github.com/repos/S2E/s2e-env/tags","blobs_url":"https://api.github.com/repos/S2E/s2e-env/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/S2E/s2e-env/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/S2E/s2e-env/git/refs{/sha}","trees_url":"https://api.github.com/repos/S2E/s2e-env/git/trees{/sha}","statuses_url":"https://api.github.com/repos/S2E/s2e-env/statuses/{sha}","languages_url":"https://api.github.com/repos/S2E/s2e-env/languages","stargazers_url":"https://api.github.com/repos/S2E/s2e-env/stargazers","contributors_url":"https://api.github.com/repos/S2E/s2e-env/contributors","subscribers_url":"https://api.github.com/repos/S2E/s2e-env/subscribers","subscription_url":"https://api.github.com/repos/S2E/s2e-env/subscription","commits_url":"https://api.github.com/repos/S2E/s2e-env/commits{/sha}","git_commits_url":"https://api.github.com/repos/S2E/s2e-env/git/commits{/sha}","comments_url":"https://api.github.com/repos/S2E/s2e-env/comments{/number}","issue_comment_url":"https://api.github.com/repos/S2E/s2e-env/issues/comments{/number}","contents_url":"https://api.github.com/repos/S2E/s2e-env/contents/{+path}","compare_url":"https://api.github.com/repos/S2E/s2e-env/compare/{base}...{head}","merges_url":"https://api.github.com/repos/S2E/s2e-env/merges","archive_url":"https://api.github.com/repos/S2E/s2e-env/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/S2E/s2e-env/downloads","issues_url":"https://api.github.com/repos/S2E/s2e-env/issues{/number}","pulls_url":"https://api.github.com/repos/S2E/s2e-env/pulls{/number}","milestones_url":"https://api.github.com/repos/S2E/s2e-env/milestones{/number}","notifications_url":"https://api.github.com/repos/S2E/s2e-env/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/S2E/s2e-env/labels{/name}","releases_url":"https://api.github.com/repos/S2E/s2e-env/releases{/id}","deployments_url":"https://api.github.com/repos/S2E/s2e-env/deployments","created_at":"2017-04-07T19:01:34Z","updated_at":"2018-11-10T04:26:10Z","pushed_at":"2018-11-11T11:02:26Z","git_url":"git://github.com/S2E/s2e-env.git","ssh_url":"git@github.com:S2E/s2e-env.git","clone_url":"https://github.com/S2E/s2e-env.git","svn_url":"https://github.com/S2E/s2e-env","homepage":null,"size":524,"stargazers_count":35,"watchers_count":35,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":62,"watchers":35,"default_branch":"master"}},"base":{"label":"S2E:master","ref":"master","sha":"0bc26331aad20a6a1b2f3a88a9a5549f82632038","user":{"login":"S2E","id":7384376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODQzNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7384376?v=4","gravatar_id":"","url":"https://api.github.com/users/S2E","html_url":"https://github.com/S2E","followers_url":"https://api.github.com/users/S2E/followers","following_url":"https://api.github.com/users/S2E/following{/other_user}","gists_url":"https://api.github.com/users/S2E/gists{/gist_id}","starred_url":"https://api.github.com/users/S2E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2E/subscriptions","organizations_url":"https://api.github.com/users/S2E/orgs","repos_url":"https://api.github.com/users/S2E/repos","events_url":"https://api.github.com/users/S2E/events{/privacy}","received_events_url":"https://api.github.com/users/S2E/received_events","type":"Organization","site_admin":false},"repo":{"id":87578023,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU3ODAyMw==","name":"s2e-env","full_name":"S2E/s2e-env","private":false,"owner":{"login":"S2E","id":7384376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODQzNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7384376?v=4","gravatar_id":"","url":"https://api.github.com/users/S2E","html_url":"https://github.com/S2E","followers_url":"https://api.github.com/users/S2E/followers","following_url":"https://api.github.com/users/S2E/following{/other_user}","gists_url":"https://api.github.com/users/S2E/gists{/gist_id}","starred_url":"https://api.github.com/users/S2E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2E/subscriptions","organizations_url":"https://api.github.com/users/S2E/orgs","repos_url":"https://api.github.com/users/S2E/repos","events_url":"https://api.github.com/users/S2E/events{/privacy}","received_events_url":"https://api.github.com/users/S2E/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/S2E/s2e-env","description":"Your S2E project management tools","fork":false,"url":"https://api.github.com/repos/S2E/s2e-env","forks_url":"https://api.github.com/repos/S2E/s2e-env/forks","keys_url":"https://api.github.com/repos/S2E/s2e-env/keys{/key_id}","collaborators_url":"https://api.github.com/repos/S2E/s2e-env/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/S2E/s2e-env/teams","hooks_url":"https://api.github.com/repos/S2E/s2e-env/hooks","issue_events_url":"https://api.github.com/repos/S2E/s2e-env/issues/events{/number}","events_url":"https://api.github.com/repos/S2E/s2e-env/events","assignees_url":"https://api.github.com/repos/S2E/s2e-env/assignees{/user}","branches_url":"https://api.github.com/repos/S2E/s2e-env/branches{/branch}","tags_url":"https://api.github.com/repos/S2E/s2e-env/tags","blobs_url":"https://api.github.com/repos/S2E/s2e-env/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/S2E/s2e-env/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/S2E/s2e-env/git/refs{/sha}","trees_url":"https://api.github.com/repos/S2E/s2e-env/git/trees{/sha}","statuses_url":"https://api.github.com/repos/S2E/s2e-env/statuses/{sha}","languages_url":"https://api.github.com/repos/S2E/s2e-env/languages","stargazers_url":"https://api.github.com/repos/S2E/s2e-env/stargazers","contributors_url":"https://api.github.com/repos/S2E/s2e-env/contributors","subscribers_url":"https://api.github.com/repos/S2E/s2e-env/subscribers","subscription_url":"https://api.github.com/repos/S2E/s2e-env/subscription","commits_url":"https://api.github.com/repos/S2E/s2e-env/commits{/sha}","git_commits_url":"https://api.github.com/repos/S2E/s2e-env/git/commits{/sha}","comments_url":"https://api.github.com/repos/S2E/s2e-env/comments{/number}","issue_comment_url":"https://api.github.com/repos/S2E/s2e-env/issues/comments{/number}","contents_url":"https://api.github.com/repos/S2E/s2e-env/contents/{+path}","compare_url":"https://api.github.com/repos/S2E/s2e-env/compare/{base}...{head}","merges_url":"https://api.github.com/repos/S2E/s2e-env/merges","archive_url":"https://api.github.com/repos/S2E/s2e-env/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/S2E/s2e-env/downloads","issues_url":"https://api.github.com/repos/S2E/s2e-env/issues{/number}","pulls_url":"https://api.github.com/repos/S2E/s2e-env/pulls{/number}","milestones_url":"https://api.github.com/repos/S2E/s2e-env/milestones{/number}","notifications_url":"https://api.github.com/repos/S2E/s2e-env/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/S2E/s2e-env/labels{/name}","releases_url":"https://api.github.com/repos/S2E/s2e-env/releases{/id}","deployments_url":"https://api.github.com/repos/S2E/s2e-env/deployments","created_at":"2017-04-07T19:01:34Z","updated_at":"2018-11-10T04:26:10Z","pushed_at":"2018-11-11T11:02:26Z","git_url":"git://github.com/S2E/s2e-env.git","ssh_url":"git@github.com:S2E/s2e-env.git","clone_url":"https://github.com/S2E/s2e-env.git","svn_url":"https://github.com/S2E/s2e-env","homepage":null,"size":524,"stargazers_count":35,"watchers_count":35,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":62,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/S2E/s2e-env/pulls/216"},"html":{"href":"https://github.com/S2E/s2e-env/pull/216"},"issue":{"href":"https://api.github.com/repos/S2E/s2e-env/issues/216"},"comments":{"href":"https://api.github.com/repos/S2E/s2e-env/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/S2E/s2e-env/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/S2E/s2e-env/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/S2E/s2e-env/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/S2E/s2e-env/statuses/8e1550c011a5bf5cff1f9867e869e411bd79b059"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vitalych"}}