{"action":"created","issue":{"url":"https://api.github.com/repos/LSSTDESC/imSim/issues/102","repository_url":"https://api.github.com/repos/LSSTDESC/imSim","labels_url":"https://api.github.com/repos/LSSTDESC/imSim/issues/102/labels{/name}","comments_url":"https://api.github.com/repos/LSSTDESC/imSim/issues/102/comments","events_url":"https://api.github.com/repos/LSSTDESC/imSim/issues/102/events","html_url":"https://github.com/LSSTDESC/imSim/pull/102","id":308668844,"number":102,"title":"Perturbed optics model","user":{"login":"djperrefort","id":17324691,"avatar_url":"https://avatars1.githubusercontent.com/u/17324691?v=4","gravatar_id":"","url":"https://api.github.com/users/djperrefort","html_url":"https://github.com/djperrefort","followers_url":"https://api.github.com/users/djperrefort/followers","following_url":"https://api.github.com/users/djperrefort/following{/other_user}","gists_url":"https://api.github.com/users/djperrefort/gists{/gist_id}","starred_url":"https://api.github.com/users/djperrefort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djperrefort/subscriptions","organizations_url":"https://api.github.com/users/djperrefort/orgs","repos_url":"https://api.github.com/users/djperrefort/repos","events_url":"https://api.github.com/users/djperrefort/events{/privacy}","received_events_url":"https://api.github.com/users/djperrefort/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-03-26T17:39:24Z","updated_at":"2018-04-23T17:00:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/LSSTDESC/imSim/pulls/102","html_url":"https://github.com/LSSTDESC/imSim/pull/102","diff_url":"https://github.com/LSSTDESC/imSim/pull/102.diff","patch_url":"https://github.com/LSSTDESC/imSim/pull/102.patch"},"body":"This pull request addresses issue #9. It adds code for simulating residual optical deviations uncorrected by the AOS wavefront control system and calculating the corresponding Zernike coefficients at a given focal plane coordinate.\r\n\r\nThis pull request includes adding a new `optical_system` module and related tests to the test suite. A full background and outline of the added code is attached [here](https://github.com/LSSTDESC/imSim/files/1848815/code_outline.pdf). Some quick notes:\r\n\r\n  - Simulations do not include residual errors left uncorrected by the AOS lookup table\r\n  - Calculating the Zernike coefficients for zero residual deviations returns the nominal Zernike coefficients as expected.\r\n  - Simulations are performed by the `optical_system.OpticalZernikes` class. Average performance times over 100 runs are as follows:\r\n\r\n    **OpticalZernikes Init time:** 0.433 s\r\n    **Calculating coefficients at 1000 cartesian coords:** 0.010 s\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/LSSTDESC/imSim/issues/comments/383647810","html_url":"https://github.com/LSSTDESC/imSim/pull/102#issuecomment-383647810","issue_url":"https://api.github.com/repos/LSSTDESC/imSim/issues/102","id":383647810,"user":{"login":"jmeyers314","id":3650485,"avatar_url":"https://avatars0.githubusercontent.com/u/3650485?v=4","gravatar_id":"","url":"https://api.github.com/users/jmeyers314","html_url":"https://github.com/jmeyers314","followers_url":"https://api.github.com/users/jmeyers314/followers","following_url":"https://api.github.com/users/jmeyers314/following{/other_user}","gists_url":"https://api.github.com/users/jmeyers314/gists{/gist_id}","starred_url":"https://api.github.com/users/jmeyers314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmeyers314/subscriptions","organizations_url":"https://api.github.com/users/jmeyers314/orgs","repos_url":"https://api.github.com/users/jmeyers314/repos","events_url":"https://api.github.com/users/jmeyers314/events{/privacy}","received_events_url":"https://api.github.com/users/jmeyers314/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T17:00:20Z","updated_at":"2018-04-23T17:00:20Z","author_association":"MEMBER","body":"> @jmeyers314 you have already made this code from Daniel work with your code (in #101) correct?\r\n\r\nYup.  Appears to work just fine."}}
{"actor":{"display_login":"jmeyers314"}}