{"action":"created","comment":{"url":"https://api.github.com/repos/galterlibrary/digital-repository/pulls/comments/189660594","pull_request_review_id":121883350,"id":189660594,"diff_hunk":"@@ -20,13 +20,20 @@ def get_results(subject, search)\n     lcsh_base_uri = \"http://id.loc.gov/authorities/subjects/suggest/?q=\"\n     # can increase limit to max 20 with '&rows=20'\n     fast_geo_uri = \"http://fast.oclc.org/searchfast/fastsuggest?fl=suggest51&wt=json&query=\"\n+    \n     if subject == 'lcsh'\n       result = JSON.parse(HTTParty.get(\n         lcsh_base_uri + \"#{search.gsub(/\\s/,'*')}*\"\n-      ))[1]\n+      ))\n+      result = result[1] ? result[1] : [\"Error Searching\"]\n     elsif subject == 'subject_geographic'\n-      result = HTTParty.get(fast_geo_uri + search)[\"response\"][\"docs\"]\n-      result.map!{ |x| x[\"suggest51\"] }\n+      result = HTTParty.get(fast_geo_uri + search)\n+      if result[\"response\"][\"docs\"]","path":"app/controllers/authorities_controller.rb","position":null,"original_position":15,"commit_id":"c30ea0b990f0c849df20c3ff6646468ae548be74","original_commit_id":"ec42c7597c3dee6f03fbe09530d9bf1a09befcd3","user":{"login":"phebal","id":3236815,"avatar_url":"https://avatars3.githubusercontent.com/u/3236815?v=4","gravatar_id":"","url":"https://api.github.com/users/phebal","html_url":"https://github.com/phebal","followers_url":"https://api.github.com/users/phebal/followers","following_url":"https://api.github.com/users/phebal/following{/other_user}","gists_url":"https://api.github.com/users/phebal/gists{/gist_id}","starred_url":"https://api.github.com/users/phebal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phebal/subscriptions","organizations_url":"https://api.github.com/users/phebal/orgs","repos_url":"https://api.github.com/users/phebal/repos","events_url":"https://api.github.com/users/phebal/events{/privacy}","received_events_url":"https://api.github.com/users/phebal/received_events","type":"User","site_admin":false},"body":"it's up to you","created_at":"2018-05-21T17:39:17Z","updated_at":"2018-05-21T17:39:18Z","html_url":"https://github.com/galterlibrary/digital-repository/pull/615#discussion_r189660594","pull_request_url":"https://api.github.com/repos/galterlibrary/digital-repository/pulls/615","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/galterlibrary/digital-repository/pulls/comments/189660594"},"html":{"href":"https://github.com/galterlibrary/digital-repository/pull/615#discussion_r189660594"},"pull_request":{"href":"https://api.github.com/repos/galterlibrary/digital-repository/pulls/615"}},"in_reply_to_id":189646856},"pull_request":{"url":"https://api.github.com/repos/galterlibrary/digital-repository/pulls/615","id":186483823,"html_url":"https://github.com/galterlibrary/digital-repository/pull/615","diff_url":"https://github.com/galterlibrary/digital-repository/pull/615.diff","patch_url":"https://github.com/galterlibrary/digital-repository/pull/615.patch","issue_url":"https://api.github.com/repos/galterlibrary/digital-repository/issues/615","number":615,"state":"open","locked":false,"title":"608 switch lcsh lcnaf source","user":{"login":"sharpattack","id":8138663,"avatar_url":"https://avatars3.githubusercontent.com/u/8138663?v=4","gravatar_id":"","url":"https://api.github.com/users/sharpattack","html_url":"https://github.com/sharpattack","followers_url":"https://api.github.com/users/sharpattack/followers","following_url":"https://api.github.com/users/sharpattack/following{/other_user}","gists_url":"https://api.github.com/users/sharpattack/gists{/gist_id}","starred_url":"https://api.github.com/users/sharpattack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharpattack/subscriptions","organizations_url":"https://api.github.com/users/sharpattack/orgs","repos_url":"https://api.github.com/users/sharpattack/repos","events_url":"https://api.github.com/users/sharpattack/events{/privacy}","received_events_url":"https://api.github.com/users/sharpattack/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-07T22:41:33Z","updated_at":"2018-05-21T17:39:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39963196c3c4f66853e1d1342dd361a0ce4785f5","assignee":{"login":"sharpattack","id":8138663,"avatar_url":"https://avatars3.githubusercontent.com/u/8138663?v=4","gravatar_id":"","url":"https://api.github.com/users/sharpattack","html_url":"https://github.com/sharpattack","followers_url":"https://api.github.com/users/sharpattack/followers","following_url":"https://api.github.com/users/sharpattack/following{/other_user}","gists_url":"https://api.github.com/users/sharpattack/gists{/gist_id}","starred_url":"https://api.github.com/users/sharpattack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharpattack/subscriptions","organizations_url":"https://api.github.com/users/sharpattack/orgs","repos_url":"https://api.github.com/users/sharpattack/repos","events_url":"https://api.github.com/users/sharpattack/events{/privacy}","received_events_url":"https://api.github.com/users/sharpattack/received_events","type":"User","site_admin":false},"assignees":[{"login":"sharpattack","id":8138663,"avatar_url":"https://avatars3.githubusercontent.com/u/8138663?v=4","gravatar_id":"","url":"https://api.github.com/users/sharpattack","html_url":"https://github.com/sharpattack","followers_url":"https://api.github.com/users/sharpattack/followers","following_url":"https://api.github.com/users/sharpattack/following{/other_user}","gists_url":"https://api.github.com/users/sharpattack/gists{/gist_id}","starred_url":"https://api.github.com/users/sharpattack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharpattack/subscriptions","organizations_url":"https://api.github.com/users/sharpattack/orgs","repos_url":"https://api.github.com/users/sharpattack/repos","events_url":"https://api.github.com/users/sharpattack/events{/privacy}","received_events_url":"https://api.github.com/users/sharpattack/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/galterlibrary/digital-repository/pulls/615/commits","review_comments_url":"https://api.github.com/repos/galterlibrary/digital-repository/pulls/615/comments","review_comment_url":"https://api.github.com/repos/galterlibrary/digital-repository/pulls/comments{/number}","comments_url":"https://api.github.com/repos/galterlibrary/digital-repository/issues/615/comments","statuses_url":"https://api.github.com/repos/galterlibrary/digital-repository/statuses/c30ea0b990f0c849df20c3ff6646468ae548be74","head":{"label":"galterlibrary:608-switch-lcsh-lcnaf-source","ref":"608-switch-lcsh-lcnaf-source","sha":"c30ea0b990f0c849df20c3ff6646468ae548be74","user":{"login":"galterlibrary","id":3300294,"avatar_url":"https://avatars0.githubusercontent.com/u/3300294?v=4","gravatar_id":"","url":"https://api.github.com/users/galterlibrary","html_url":"https://github.com/galterlibrary","followers_url":"https://api.github.com/users/galterlibrary/followers","following_url":"https://api.github.com/users/galterlibrary/following{/other_user}","gists_url":"https://api.github.com/users/galterlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/galterlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galterlibrary/subscriptions","organizations_url":"https://api.github.com/users/galterlibrary/orgs","repos_url":"https://api.github.com/users/galterlibrary/repos","events_url":"https://api.github.com/users/galterlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/galterlibrary/received_events","type":"User","site_admin":false},"repo":{"id":29741510,"name":"digital-repository","full_name":"galterlibrary/digital-repository","owner":{"login":"galterlibrary","id":3300294,"avatar_url":"https://avatars0.githubusercontent.com/u/3300294?v=4","gravatar_id":"","url":"https://api.github.com/users/galterlibrary","html_url":"https://github.com/galterlibrary","followers_url":"https://api.github.com/users/galterlibrary/followers","following_url":"https://api.github.com/users/galterlibrary/following{/other_user}","gists_url":"https://api.github.com/users/galterlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/galterlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galterlibrary/subscriptions","organizations_url":"https://api.github.com/users/galterlibrary/orgs","repos_url":"https://api.github.com/users/galterlibrary/repos","events_url":"https://api.github.com/users/galterlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/galterlibrary/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/galterlibrary/digital-repository","description":"DigitalHub - Institutional Repository for Galter Health Sciences ","fork":false,"url":"https://api.github.com/repos/galterlibrary/digital-repository","forks_url":"https://api.github.com/repos/galterlibrary/digital-repository/forks","keys_url":"https://api.github.com/repos/galterlibrary/digital-repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galterlibrary/digital-repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galterlibrary/digital-repository/teams","hooks_url":"https://api.github.com/repos/galterlibrary/digital-repository/hooks","issue_events_url":"https://api.github.com/repos/galterlibrary/digital-repository/issues/events{/number}","events_url":"https://api.github.com/repos/galterlibrary/digital-repository/events","assignees_url":"https://api.github.com/repos/galterlibrary/digital-repository/assignees{/user}","branches_url":"https://api.github.com/repos/galterlibrary/digital-repository/branches{/branch}","tags_url":"https://api.github.com/repos/galterlibrary/digital-repository/tags","blobs_url":"https://api.github.com/repos/galterlibrary/digital-repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galterlibrary/digital-repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galterlibrary/digital-repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/galterlibrary/digital-repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galterlibrary/digital-repository/statuses/{sha}","languages_url":"https://api.github.com/repos/galterlibrary/digital-repository/languages","stargazers_url":"https://api.github.com/repos/galterlibrary/digital-repository/stargazers","contributors_url":"https://api.github.com/repos/galterlibrary/digital-repository/contributors","subscribers_url":"https://api.github.com/repos/galterlibrary/digital-repository/subscribers","subscription_url":"https://api.github.com/repos/galterlibrary/digital-repository/subscription","commits_url":"https://api.github.com/repos/galterlibrary/digital-repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/galterlibrary/digital-repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/galterlibrary/digital-repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/galterlibrary/digital-repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/galterlibrary/digital-repository/contents/{+path}","compare_url":"https://api.github.com/repos/galterlibrary/digital-repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galterlibrary/digital-repository/merges","archive_url":"https://api.github.com/repos/galterlibrary/digital-repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galterlibrary/digital-repository/downloads","issues_url":"https://api.github.com/repos/galterlibrary/digital-repository/issues{/number}","pulls_url":"https://api.github.com/repos/galterlibrary/digital-repository/pulls{/number}","milestones_url":"https://api.github.com/repos/galterlibrary/digital-repository/milestones{/number}","notifications_url":"https://api.github.com/repos/galterlibrary/digital-repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galterlibrary/digital-repository/labels{/name}","releases_url":"https://api.github.com/repos/galterlibrary/digital-repository/releases{/id}","deployments_url":"https://api.github.com/repos/galterlibrary/digital-repository/deployments","created_at":"2015-01-23T16:30:58Z","updated_at":"2018-05-07T14:22:41Z","pushed_at":"2018-05-21T15:52:04Z","git_url":"git://github.com/galterlibrary/digital-repository.git","ssh_url":"git@github.com:galterlibrary/digital-repository.git","clone_url":"https://github.com/galterlibrary/digital-repository.git","svn_url":"https://github.com/galterlibrary/digital-repository","homepage":"https://digitalhub.northwestern.edu/","size":28809,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":102,"license":null,"forks":0,"open_issues":102,"watchers":2,"default_branch":"master"}},"base":{"label":"galterlibrary:master","ref":"master","sha":"ea33a3bcc4845445e1e76c827393ffd0b41b7646","user":{"login":"galterlibrary","id":3300294,"avatar_url":"https://avatars0.githubusercontent.com/u/3300294?v=4","gravatar_id":"","url":"https://api.github.com/users/galterlibrary","html_url":"https://github.com/galterlibrary","followers_url":"https://api.github.com/users/galterlibrary/followers","following_url":"https://api.github.com/users/galterlibrary/following{/other_user}","gists_url":"https://api.github.com/users/galterlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/galterlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galterlibrary/subscriptions","organizations_url":"https://api.github.com/users/galterlibrary/orgs","repos_url":"https://api.github.com/users/galterlibrary/repos","events_url":"https://api.github.com/users/galterlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/galterlibrary/received_events","type":"User","site_admin":false},"repo":{"id":29741510,"name":"digital-repository","full_name":"galterlibrary/digital-repository","owner":{"login":"galterlibrary","id":3300294,"avatar_url":"https://avatars0.githubusercontent.com/u/3300294?v=4","gravatar_id":"","url":"https://api.github.com/users/galterlibrary","html_url":"https://github.com/galterlibrary","followers_url":"https://api.github.com/users/galterlibrary/followers","following_url":"https://api.github.com/users/galterlibrary/following{/other_user}","gists_url":"https://api.github.com/users/galterlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/galterlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galterlibrary/subscriptions","organizations_url":"https://api.github.com/users/galterlibrary/orgs","repos_url":"https://api.github.com/users/galterlibrary/repos","events_url":"https://api.github.com/users/galterlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/galterlibrary/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/galterlibrary/digital-repository","description":"DigitalHub - Institutional Repository for Galter Health Sciences ","fork":false,"url":"https://api.github.com/repos/galterlibrary/digital-repository","forks_url":"https://api.github.com/repos/galterlibrary/digital-repository/forks","keys_url":"https://api.github.com/repos/galterlibrary/digital-repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galterlibrary/digital-repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galterlibrary/digital-repository/teams","hooks_url":"https://api.github.com/repos/galterlibrary/digital-repository/hooks","issue_events_url":"https://api.github.com/repos/galterlibrary/digital-repository/issues/events{/number}","events_url":"https://api.github.com/repos/galterlibrary/digital-repository/events","assignees_url":"https://api.github.com/repos/galterlibrary/digital-repository/assignees{/user}","branches_url":"https://api.github.com/repos/galterlibrary/digital-repository/branches{/branch}","tags_url":"https://api.github.com/repos/galterlibrary/digital-repository/tags","blobs_url":"https://api.github.com/repos/galterlibrary/digital-repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galterlibrary/digital-repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galterlibrary/digital-repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/galterlibrary/digital-repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galterlibrary/digital-repository/statuses/{sha}","languages_url":"https://api.github.com/repos/galterlibrary/digital-repository/languages","stargazers_url":"https://api.github.com/repos/galterlibrary/digital-repository/stargazers","contributors_url":"https://api.github.com/repos/galterlibrary/digital-repository/contributors","subscribers_url":"https://api.github.com/repos/galterlibrary/digital-repository/subscribers","subscription_url":"https://api.github.com/repos/galterlibrary/digital-repository/subscription","commits_url":"https://api.github.com/repos/galterlibrary/digital-repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/galterlibrary/digital-repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/galterlibrary/digital-repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/galterlibrary/digital-repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/galterlibrary/digital-repository/contents/{+path}","compare_url":"https://api.github.com/repos/galterlibrary/digital-repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galterlibrary/digital-repository/merges","archive_url":"https://api.github.com/repos/galterlibrary/digital-repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galterlibrary/digital-repository/downloads","issues_url":"https://api.github.com/repos/galterlibrary/digital-repository/issues{/number}","pulls_url":"https://api.github.com/repos/galterlibrary/digital-repository/pulls{/number}","milestones_url":"https://api.github.com/repos/galterlibrary/digital-repository/milestones{/number}","notifications_url":"https://api.github.com/repos/galterlibrary/digital-repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galterlibrary/digital-repository/labels{/name}","releases_url":"https://api.github.com/repos/galterlibrary/digital-repository/releases{/id}","deployments_url":"https://api.github.com/repos/galterlibrary/digital-repository/deployments","created_at":"2015-01-23T16:30:58Z","updated_at":"2018-05-07T14:22:41Z","pushed_at":"2018-05-21T15:52:04Z","git_url":"git://github.com/galterlibrary/digital-repository.git","ssh_url":"git@github.com:galterlibrary/digital-repository.git","clone_url":"https://github.com/galterlibrary/digital-repository.git","svn_url":"https://github.com/galterlibrary/digital-repository","homepage":"https://digitalhub.northwestern.edu/","size":28809,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":102,"license":null,"forks":0,"open_issues":102,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/galterlibrary/digital-repository/pulls/615"},"html":{"href":"https://github.com/galterlibrary/digital-repository/pull/615"},"issue":{"href":"https://api.github.com/repos/galterlibrary/digital-repository/issues/615"},"comments":{"href":"https://api.github.com/repos/galterlibrary/digital-repository/issues/615/comments"},"review_comments":{"href":"https://api.github.com/repos/galterlibrary/digital-repository/pulls/615/comments"},"review_comment":{"href":"https://api.github.com/repos/galterlibrary/digital-repository/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/galterlibrary/digital-repository/pulls/615/commits"},"statuses":{"href":"https://api.github.com/repos/galterlibrary/digital-repository/statuses/c30ea0b990f0c849df20c3ff6646468ae548be74"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"phebal"}}