{"action":"opened","number":834,"pull_request":{"url":"https://api.github.com/repos/freechipsproject/firrtl/pulls/834","id":197529869,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTI5ODY5","html_url":"https://github.com/freechipsproject/firrtl/pull/834","diff_url":"https://github.com/freechipsproject/firrtl/pull/834.diff","patch_url":"https://github.com/freechipsproject/firrtl/pull/834.patch","issue_url":"https://api.github.com/repos/freechipsproject/firrtl/issues/834","number":834,"state":"open","locked":false,"title":"Improve code generation for smem RW-port wmode port","user":{"login":"aswaterman","id":1031106,"node_id":"MDQ6VXNlcjEwMzExMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1031106?v=4","gravatar_id":"","url":"https://api.github.com/users/aswaterman","html_url":"https://github.com/aswaterman","followers_url":"https://api.github.com/users/aswaterman/followers","following_url":"https://api.github.com/users/aswaterman/following{/other_user}","gists_url":"https://api.github.com/users/aswaterman/gists{/gist_id}","starred_url":"https://api.github.com/users/aswaterman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aswaterman/subscriptions","organizations_url":"https://api.github.com/users/aswaterman/orgs","repos_url":"https://api.github.com/users/aswaterman/repos","events_url":"https://api.github.com/users/aswaterman/events{/privacy}","received_events_url":"https://api.github.com/users/aswaterman/received_events","type":"User","site_admin":false},"body":"A common case for these port-enables is\r\n\r\n    wen = valid & write\r\n    ren = valid & !write\r\n\r\nwhich the RW-port transform currently turns into\r\n\r\n    en = (valid & write) | (valid & !write)\r\n    wmode = valid & write\r\n\r\nbecause it proved `wen` and `ren` are mutually exclusive via `write`.\r\n\r\nSynthesis tools can trivially optimize `en` to `valid`, so that's not a problem, but the wmode field can't be optimized if going into a black box. This PR instead sets `wmode` to whatever node was used to prove mutual exclusion, which is always a simpler expression.  In this case:\r\n\r\n    en = (valid & write) | (valid & !write)\r\n    wmode = write","created_at":"2018-06-26T19:40:45Z","updated_at":"2018-06-26T19:40:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/freechipsproject/firrtl/pulls/834/commits","review_comments_url":"https://api.github.com/repos/freechipsproject/firrtl/pulls/834/comments","review_comment_url":"https://api.github.com/repos/freechipsproject/firrtl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freechipsproject/firrtl/issues/834/comments","statuses_url":"https://api.github.com/repos/freechipsproject/firrtl/statuses/22175e27aeb01f9a24b03f18b6bff91fc372bd53","head":{"label":"freechipsproject:improve-rw-wmode","ref":"improve-rw-wmode","sha":"22175e27aeb01f9a24b03f18b6bff91fc372bd53","user":{"login":"freechipsproject","id":25232510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjMyNTEw","avatar_url":"https://avatars2.githubusercontent.com/u/25232510?v=4","gravatar_id":"","url":"https://api.github.com/users/freechipsproject","html_url":"https://github.com/freechipsproject","followers_url":"https://api.github.com/users/freechipsproject/followers","following_url":"https://api.github.com/users/freechipsproject/following{/other_user}","gists_url":"https://api.github.com/users/freechipsproject/gists{/gist_id}","starred_url":"https://api.github.com/users/freechipsproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freechipsproject/subscriptions","organizations_url":"https://api.github.com/users/freechipsproject/orgs","repos_url":"https://api.github.com/users/freechipsproject/repos","events_url":"https://api.github.com/users/freechipsproject/events{/privacy}","received_events_url":"https://api.github.com/users/freechipsproject/received_events","type":"Organization","site_admin":false},"repo":{"id":30780129,"node_id":"MDEwOlJlcG9zaXRvcnkzMDc4MDEyOQ==","name":"firrtl","full_name":"freechipsproject/firrtl","owner":{"login":"freechipsproject","id":25232510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjMyNTEw","avatar_url":"https://avatars2.githubusercontent.com/u/25232510?v=4","gravatar_id":"","url":"https://api.github.com/users/freechipsproject","html_url":"https://github.com/freechipsproject","followers_url":"https://api.github.com/users/freechipsproject/followers","following_url":"https://api.github.com/users/freechipsproject/following{/other_user}","gists_url":"https://api.github.com/users/freechipsproject/gists{/gist_id}","starred_url":"https://api.github.com/users/freechipsproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freechipsproject/subscriptions","organizations_url":"https://api.github.com/users/freechipsproject/orgs","repos_url":"https://api.github.com/users/freechipsproject/repos","events_url":"https://api.github.com/users/freechipsproject/events{/privacy}","received_events_url":"https://api.github.com/users/freechipsproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freechipsproject/firrtl","description":"Flexible Intermediate Representation for RTL","fork":false,"url":"https://api.github.com/repos/freechipsproject/firrtl","forks_url":"https://api.github.com/repos/freechipsproject/firrtl/forks","keys_url":"https://api.github.com/repos/freechipsproject/firrtl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freechipsproject/firrtl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freechipsproject/firrtl/teams","hooks_url":"https://api.github.com/repos/freechipsproject/firrtl/hooks","issue_events_url":"https://api.github.com/repos/freechipsproject/firrtl/issues/events{/number}","events_url":"https://api.github.com/repos/freechipsproject/firrtl/events","assignees_url":"https://api.github.com/repos/freechipsproject/firrtl/assignees{/user}","branches_url":"https://api.github.com/repos/freechipsproject/firrtl/branches{/branch}","tags_url":"https://api.github.com/repos/freechipsproject/firrtl/tags","blobs_url":"https://api.github.com/repos/freechipsproject/firrtl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freechipsproject/firrtl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freechipsproject/firrtl/git/refs{/sha}","trees_url":"https://api.github.com/repos/freechipsproject/firrtl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freechipsproject/firrtl/statuses/{sha}","languages_url":"https://api.github.com/repos/freechipsproject/firrtl/languages","stargazers_url":"https://api.github.com/repos/freechipsproject/firrtl/stargazers","contributors_url":"https://api.github.com/repos/freechipsproject/firrtl/contributors","subscribers_url":"https://api.github.com/repos/freechipsproject/firrtl/subscribers","subscription_url":"https://api.github.com/repos/freechipsproject/firrtl/subscription","commits_url":"https://api.github.com/repos/freechipsproject/firrtl/commits{/sha}","git_commits_url":"https://api.github.com/repos/freechipsproject/firrtl/git/commits{/sha}","comments_url":"https://api.github.com/repos/freechipsproject/firrtl/comments{/number}","issue_comment_url":"https://api.github.com/repos/freechipsproject/firrtl/issues/comments{/number}","contents_url":"https://api.github.com/repos/freechipsproject/firrtl/contents/{+path}","compare_url":"https://api.github.com/repos/freechipsproject/firrtl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freechipsproject/firrtl/merges","archive_url":"https://api.github.com/repos/freechipsproject/firrtl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freechipsproject/firrtl/downloads","issues_url":"https://api.github.com/repos/freechipsproject/firrtl/issues{/number}","pulls_url":"https://api.github.com/repos/freechipsproject/firrtl/pulls{/number}","milestones_url":"https://api.github.com/repos/freechipsproject/firrtl/milestones{/number}","notifications_url":"https://api.github.com/repos/freechipsproject/firrtl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freechipsproject/firrtl/labels{/name}","releases_url":"https://api.github.com/repos/freechipsproject/firrtl/releases{/id}","deployments_url":"https://api.github.com/repos/freechipsproject/firrtl/deployments","created_at":"2015-02-13T23:04:44Z","updated_at":"2018-06-23T12:40:41Z","pushed_at":"2018-06-26T19:40:16Z","git_url":"git://github.com/freechipsproject/firrtl.git","ssh_url":"git@github.com:freechipsproject/firrtl.git","clone_url":"https://github.com/freechipsproject/firrtl.git","svn_url":"https://github.com/freechipsproject/firrtl","homepage":"http://freechipsproject.github.io/firrtl/","size":47235,"stargazers_count":97,"watchers_count":97,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":119,"license":null,"forks":45,"open_issues":119,"watchers":97,"default_branch":"master"}},"base":{"label":"freechipsproject:master","ref":"master","sha":"991dba31b751f26d05835094ea49eea83f81247e","user":{"login":"freechipsproject","id":25232510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjMyNTEw","avatar_url":"https://avatars2.githubusercontent.com/u/25232510?v=4","gravatar_id":"","url":"https://api.github.com/users/freechipsproject","html_url":"https://github.com/freechipsproject","followers_url":"https://api.github.com/users/freechipsproject/followers","following_url":"https://api.github.com/users/freechipsproject/following{/other_user}","gists_url":"https://api.github.com/users/freechipsproject/gists{/gist_id}","starred_url":"https://api.github.com/users/freechipsproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freechipsproject/subscriptions","organizations_url":"https://api.github.com/users/freechipsproject/orgs","repos_url":"https://api.github.com/users/freechipsproject/repos","events_url":"https://api.github.com/users/freechipsproject/events{/privacy}","received_events_url":"https://api.github.com/users/freechipsproject/received_events","type":"Organization","site_admin":false},"repo":{"id":30780129,"node_id":"MDEwOlJlcG9zaXRvcnkzMDc4MDEyOQ==","name":"firrtl","full_name":"freechipsproject/firrtl","owner":{"login":"freechipsproject","id":25232510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjMyNTEw","avatar_url":"https://avatars2.githubusercontent.com/u/25232510?v=4","gravatar_id":"","url":"https://api.github.com/users/freechipsproject","html_url":"https://github.com/freechipsproject","followers_url":"https://api.github.com/users/freechipsproject/followers","following_url":"https://api.github.com/users/freechipsproject/following{/other_user}","gists_url":"https://api.github.com/users/freechipsproject/gists{/gist_id}","starred_url":"https://api.github.com/users/freechipsproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freechipsproject/subscriptions","organizations_url":"https://api.github.com/users/freechipsproject/orgs","repos_url":"https://api.github.com/users/freechipsproject/repos","events_url":"https://api.github.com/users/freechipsproject/events{/privacy}","received_events_url":"https://api.github.com/users/freechipsproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freechipsproject/firrtl","description":"Flexible Intermediate Representation for RTL","fork":false,"url":"https://api.github.com/repos/freechipsproject/firrtl","forks_url":"https://api.github.com/repos/freechipsproject/firrtl/forks","keys_url":"https://api.github.com/repos/freechipsproject/firrtl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freechipsproject/firrtl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freechipsproject/firrtl/teams","hooks_url":"https://api.github.com/repos/freechipsproject/firrtl/hooks","issue_events_url":"https://api.github.com/repos/freechipsproject/firrtl/issues/events{/number}","events_url":"https://api.github.com/repos/freechipsproject/firrtl/events","assignees_url":"https://api.github.com/repos/freechipsproject/firrtl/assignees{/user}","branches_url":"https://api.github.com/repos/freechipsproject/firrtl/branches{/branch}","tags_url":"https://api.github.com/repos/freechipsproject/firrtl/tags","blobs_url":"https://api.github.com/repos/freechipsproject/firrtl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freechipsproject/firrtl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freechipsproject/firrtl/git/refs{/sha}","trees_url":"https://api.github.com/repos/freechipsproject/firrtl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freechipsproject/firrtl/statuses/{sha}","languages_url":"https://api.github.com/repos/freechipsproject/firrtl/languages","stargazers_url":"https://api.github.com/repos/freechipsproject/firrtl/stargazers","contributors_url":"https://api.github.com/repos/freechipsproject/firrtl/contributors","subscribers_url":"https://api.github.com/repos/freechipsproject/firrtl/subscribers","subscription_url":"https://api.github.com/repos/freechipsproject/firrtl/subscription","commits_url":"https://api.github.com/repos/freechipsproject/firrtl/commits{/sha}","git_commits_url":"https://api.github.com/repos/freechipsproject/firrtl/git/commits{/sha}","comments_url":"https://api.github.com/repos/freechipsproject/firrtl/comments{/number}","issue_comment_url":"https://api.github.com/repos/freechipsproject/firrtl/issues/comments{/number}","contents_url":"https://api.github.com/repos/freechipsproject/firrtl/contents/{+path}","compare_url":"https://api.github.com/repos/freechipsproject/firrtl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freechipsproject/firrtl/merges","archive_url":"https://api.github.com/repos/freechipsproject/firrtl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freechipsproject/firrtl/downloads","issues_url":"https://api.github.com/repos/freechipsproject/firrtl/issues{/number}","pulls_url":"https://api.github.com/repos/freechipsproject/firrtl/pulls{/number}","milestones_url":"https://api.github.com/repos/freechipsproject/firrtl/milestones{/number}","notifications_url":"https://api.github.com/repos/freechipsproject/firrtl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freechipsproject/firrtl/labels{/name}","releases_url":"https://api.github.com/repos/freechipsproject/firrtl/releases{/id}","deployments_url":"https://api.github.com/repos/freechipsproject/firrtl/deployments","created_at":"2015-02-13T23:04:44Z","updated_at":"2018-06-23T12:40:41Z","pushed_at":"2018-06-26T19:40:16Z","git_url":"git://github.com/freechipsproject/firrtl.git","ssh_url":"git@github.com:freechipsproject/firrtl.git","clone_url":"https://github.com/freechipsproject/firrtl.git","svn_url":"https://github.com/freechipsproject/firrtl","homepage":"http://freechipsproject.github.io/firrtl/","size":47235,"stargazers_count":97,"watchers_count":97,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":119,"license":null,"forks":45,"open_issues":119,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freechipsproject/firrtl/pulls/834"},"html":{"href":"https://github.com/freechipsproject/firrtl/pull/834"},"issue":{"href":"https://api.github.com/repos/freechipsproject/firrtl/issues/834"},"comments":{"href":"https://api.github.com/repos/freechipsproject/firrtl/issues/834/comments"},"review_comments":{"href":"https://api.github.com/repos/freechipsproject/firrtl/pulls/834/comments"},"review_comment":{"href":"https://api.github.com/repos/freechipsproject/firrtl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freechipsproject/firrtl/pulls/834/commits"},"statuses":{"href":"https://api.github.com/repos/freechipsproject/firrtl/statuses/22175e27aeb01f9a24b03f18b6bff91fc372bd53"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"aswaterman"}}