{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab-core/pulls/comments/194610700","pull_request_review_id":127814207,"id":194610700,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDYxMDcwMA==","diff_hunk":"@@ -38,9 +38,10 @@ public void validateItemType(String itemType, String bindingConfig) throws Bindi\n         try {\n             reader.validateItemType(getOpenHABItem(itemType), bindingConfig);\n         } catch (org.openhab.model.item.binding.BindingConfigParseException e) {\n-            throw new BindingConfigParseException(e.getMessage());","path":"bundles/org.openhab.core.compat1x/src/main/java/org/openhab/core/binding/internal/BindingConfigReaderDelegate.java","position":4,"original_position":4,"commit_id":"5285a6fa8de051b40a59f3a0f3ba69892b084796","original_commit_id":"5285a6fa8de051b40a59f3a0f3ba69892b084796","user":{"login":"martinvw","id":2625279,"node_id":"MDQ6VXNlcjI2MjUyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2625279?v=4","gravatar_id":"","url":"https://api.github.com/users/martinvw","html_url":"https://github.com/martinvw","followers_url":"https://api.github.com/users/martinvw/followers","following_url":"https://api.github.com/users/martinvw/following{/other_user}","gists_url":"https://api.github.com/users/martinvw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvw/subscriptions","organizations_url":"https://api.github.com/users/martinvw/orgs","repos_url":"https://api.github.com/users/martinvw/repos","events_url":"https://api.github.com/users/martinvw/events{/privacy}","received_events_url":"https://api.github.com/users/martinvw/received_events","type":"User","site_admin":false},"body":"Why not just something like `throw new BindingConfigParseException(e.getMessage(), e);` it looks more standard to me.","created_at":"2018-06-12T04:17:04Z","updated_at":"2018-06-12T04:17:05Z","html_url":"https://github.com/openhab/openhab-core/pull/359#discussion_r194610700","pull_request_url":"https://api.github.com/repos/openhab/openhab-core/pulls/359","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/comments/194610700"},"html":{"href":"https://github.com/openhab/openhab-core/pull/359#discussion_r194610700"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/359"}}},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab-core/pulls/359","id":194156192,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTU2MTky","html_url":"https://github.com/openhab/openhab-core/pull/359","diff_url":"https://github.com/openhab/openhab-core/pull/359.diff","patch_url":"https://github.com/openhab/openhab-core/pull/359.patch","issue_url":"https://api.github.com/repos/openhab/openhab-core/issues/359","number":359,"state":"open","locked":false,"title":"Don't lose stacktrace when rethrowing","user":{"login":"9037568","id":9916473,"node_id":"MDQ6VXNlcjk5MTY0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/9916473?v=4","gravatar_id":"","url":"https://api.github.com/users/9037568","html_url":"https://github.com/9037568","followers_url":"https://api.github.com/users/9037568/followers","following_url":"https://api.github.com/users/9037568/following{/other_user}","gists_url":"https://api.github.com/users/9037568/gists{/gist_id}","starred_url":"https://api.github.com/users/9037568/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9037568/subscriptions","organizations_url":"https://api.github.com/users/9037568/orgs","repos_url":"https://api.github.com/users/9037568/repos","events_url":"https://api.github.com/users/9037568/events{/privacy}","received_events_url":"https://api.github.com/users/9037568/received_events","type":"User","site_admin":false},"body":"Don't destroy the stacktrace information of a caught exception that's about to be rethrown.\r\n\r\nThis arises from my attempts to debug [OH1-Addons issue 5537](https://github.com/openhab/openhab1-addons/issues/5597), where the source of the error is getting lost...\r\n\r\nSigned-off-by: Chris Carman <namraccr@gmail.com> (github: 9037568)\r\n","created_at":"2018-06-12T03:20:21Z","updated_at":"2018-06-12T04:17:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15526757c55d8a6165d6f369485adb5ae6fb8b1e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab-core/pulls/359/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab-core/pulls/359/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab-core/issues/359/comments","statuses_url":"https://api.github.com/repos/openhab/openhab-core/statuses/5285a6fa8de051b40a59f3a0f3ba69892b084796","head":{"label":"9037568:patch-1","ref":"patch-1","sha":"5285a6fa8de051b40a59f3a0f3ba69892b084796","user":{"login":"9037568","id":9916473,"node_id":"MDQ6VXNlcjk5MTY0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/9916473?v=4","gravatar_id":"","url":"https://api.github.com/users/9037568","html_url":"https://github.com/9037568","followers_url":"https://api.github.com/users/9037568/followers","following_url":"https://api.github.com/users/9037568/following{/other_user}","gists_url":"https://api.github.com/users/9037568/gists{/gist_id}","starred_url":"https://api.github.com/users/9037568/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9037568/subscriptions","organizations_url":"https://api.github.com/users/9037568/orgs","repos_url":"https://api.github.com/users/9037568/repos","events_url":"https://api.github.com/users/9037568/events{/privacy}","received_events_url":"https://api.github.com/users/9037568/received_events","type":"User","site_admin":false},"repo":{"id":137009788,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwMDk3ODg=","name":"openhab-core","full_name":"9037568/openhab-core","owner":{"login":"9037568","id":9916473,"node_id":"MDQ6VXNlcjk5MTY0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/9916473?v=4","gravatar_id":"","url":"https://api.github.com/users/9037568","html_url":"https://github.com/9037568","followers_url":"https://api.github.com/users/9037568/followers","following_url":"https://api.github.com/users/9037568/following{/other_user}","gists_url":"https://api.github.com/users/9037568/gists{/gist_id}","starred_url":"https://api.github.com/users/9037568/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9037568/subscriptions","organizations_url":"https://api.github.com/users/9037568/orgs","repos_url":"https://api.github.com/users/9037568/repos","events_url":"https://api.github.com/users/9037568/events{/privacy}","received_events_url":"https://api.github.com/users/9037568/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/9037568/openhab-core","description":null,"fork":true,"url":"https://api.github.com/repos/9037568/openhab-core","forks_url":"https://api.github.com/repos/9037568/openhab-core/forks","keys_url":"https://api.github.com/repos/9037568/openhab-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/9037568/openhab-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/9037568/openhab-core/teams","hooks_url":"https://api.github.com/repos/9037568/openhab-core/hooks","issue_events_url":"https://api.github.com/repos/9037568/openhab-core/issues/events{/number}","events_url":"https://api.github.com/repos/9037568/openhab-core/events","assignees_url":"https://api.github.com/repos/9037568/openhab-core/assignees{/user}","branches_url":"https://api.github.com/repos/9037568/openhab-core/branches{/branch}","tags_url":"https://api.github.com/repos/9037568/openhab-core/tags","blobs_url":"https://api.github.com/repos/9037568/openhab-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/9037568/openhab-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/9037568/openhab-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/9037568/openhab-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/9037568/openhab-core/statuses/{sha}","languages_url":"https://api.github.com/repos/9037568/openhab-core/languages","stargazers_url":"https://api.github.com/repos/9037568/openhab-core/stargazers","contributors_url":"https://api.github.com/repos/9037568/openhab-core/contributors","subscribers_url":"https://api.github.com/repos/9037568/openhab-core/subscribers","subscription_url":"https://api.github.com/repos/9037568/openhab-core/subscription","commits_url":"https://api.github.com/repos/9037568/openhab-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/9037568/openhab-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/9037568/openhab-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/9037568/openhab-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/9037568/openhab-core/contents/{+path}","compare_url":"https://api.github.com/repos/9037568/openhab-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/9037568/openhab-core/merges","archive_url":"https://api.github.com/repos/9037568/openhab-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/9037568/openhab-core/downloads","issues_url":"https://api.github.com/repos/9037568/openhab-core/issues{/number}","pulls_url":"https://api.github.com/repos/9037568/openhab-core/pulls{/number}","milestones_url":"https://api.github.com/repos/9037568/openhab-core/milestones{/number}","notifications_url":"https://api.github.com/repos/9037568/openhab-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/9037568/openhab-core/labels{/name}","releases_url":"https://api.github.com/repos/9037568/openhab-core/releases{/id}","deployments_url":"https://api.github.com/repos/9037568/openhab-core/deployments","created_at":"2018-06-12T03:04:04Z","updated_at":"2018-06-12T03:04:06Z","pushed_at":"2018-06-12T03:16:34Z","git_url":"git://github.com/9037568/openhab-core.git","ssh_url":"git@github.com:9037568/openhab-core.git","clone_url":"https://github.com/9037568/openhab-core.git","svn_url":"https://github.com/9037568/openhab-core","homepage":null,"size":11399,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"0eec30045ea62d408850b6646453867fda20b92f","user":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":48337670,"node_id":"MDEwOlJlcG9zaXRvcnk0ODMzNzY3MA==","name":"openhab-core","full_name":"openhab/openhab-core","owner":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab-core","description":null,"fork":false,"url":"https://api.github.com/repos/openhab/openhab-core","forks_url":"https://api.github.com/repos/openhab/openhab-core/forks","keys_url":"https://api.github.com/repos/openhab/openhab-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab-core/teams","hooks_url":"https://api.github.com/repos/openhab/openhab-core/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab-core/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab-core/events","assignees_url":"https://api.github.com/repos/openhab/openhab-core/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab-core/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab-core/tags","blobs_url":"https://api.github.com/repos/openhab/openhab-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab-core/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab-core/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab-core/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab-core/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab-core/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab-core/subscription","commits_url":"https://api.github.com/repos/openhab/openhab-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab-core/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab-core/merges","archive_url":"https://api.github.com/repos/openhab/openhab-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab-core/downloads","issues_url":"https://api.github.com/repos/openhab/openhab-core/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab-core/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab-core/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab-core/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab-core/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab-core/deployments","created_at":"2015-12-20T21:23:20Z","updated_at":"2018-06-09T18:46:10Z","pushed_at":"2018-06-12T03:20:21Z","git_url":"git://github.com/openhab/openhab-core.git","ssh_url":"git@github.com:openhab/openhab-core.git","clone_url":"https://github.com/openhab/openhab-core.git","svn_url":"https://github.com/openhab/openhab-core","homepage":null,"size":11396,"stargazers_count":52,"watchers_count":52,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":99,"open_issues":33,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/359"},"html":{"href":"https://github.com/openhab/openhab-core/pull/359"},"issue":{"href":"https://api.github.com/repos/openhab/openhab-core/issues/359"},"comments":{"href":"https://api.github.com/repos/openhab/openhab-core/issues/359/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/359/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/359/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab-core/statuses/5285a6fa8de051b40a59f3a0f3ba69892b084796"}},"author_association":"NONE"}}
{"actor":{"display_login":"martinvw"}}