{"action":"created","issue":{"url":"https://api.github.com/repos/kripken/emscripten/issues/6177","repository_url":"https://api.github.com/repos/kripken/emscripten","labels_url":"https://api.github.com/repos/kripken/emscripten/issues/6177/labels{/name}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/6177/comments","events_url":"https://api.github.com/repos/kripken/emscripten/issues/6177/events","html_url":"https://github.com/kripken/emscripten/pull/6177","id":293728243,"number":6177,"title":"fix_IGNORE_CLOSURE_COMPILER_ERRORS_on_Windows","user":{"login":"juj","id":225351,"avatar_url":"https://avatars2.githubusercontent.com/u/225351?v=4","gravatar_id":"","url":"https://api.github.com/users/juj","html_url":"https://github.com/juj","followers_url":"https://api.github.com/users/juj/followers","following_url":"https://api.github.com/users/juj/following{/other_user}","gists_url":"https://api.github.com/users/juj/gists{/gist_id}","starred_url":"https://api.github.com/users/juj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juj/subscriptions","organizations_url":"https://api.github.com/users/juj/orgs","repos_url":"https://api.github.com/users/juj/repos","events_url":"https://api.github.com/users/juj/events{/privacy}","received_events_url":"https://api.github.com/users/juj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-02T00:04:15Z","updated_at":"2018-02-02T01:22:11Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/6177","html_url":"https://github.com/kripken/emscripten/pull/6177","diff_url":"https://github.com/kripken/emscripten/pull/6177.diff","patch_url":"https://github.com/kripken/emscripten/pull/6177.patch"},"body":"Fix Closure parameter -s IGNORE_CLOSURE_COMPILER_ERRORS=1 to work on Windows. Fixes other.test_IGNORE_CLOSURE_COMPILER_ERRORS on Windows.\r\n\r\nOn Windows command line, a standalone `*` gets expanded out to all files in the current directory, and as result, the first form of command line would fail the test with the following error\r\n\r\n```\r\nDEBUG:root:java.lang.NullPointerException: No warning class for name: a.out.js.mem\r\n        at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:864)\r\n        at com.google.javascript.jscomp.DiagnosticGroups.setWarningLevel(DiagnosticGroups.java:732)\r\n        at com.google.javascript.jscomp.AbstractCommandLineRunner.setWarningGuardOptions(AbstractCommandLineRunner.java:321)\r\n        at com.google.javascript.jscomp.AbstractCommandLineRunner.setRunOptions(AbstractCommandLineRunner.java:336)\r\n        at com.google.javascript.jscomp.AbstractCommandLineRunner.doRun(AbstractCommandLineRunner.java:1046)\r\n        at com.google.javascript.jscomp.AbstractCommandLineRunner.run(AbstractCommandLineRunner.java:499)\r\n        at com.google.javascript.jscomp.CommandLineRunner.main(CommandLineRunner.java:1968)\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kripken/emscripten/issues/comments/362456258","html_url":"https://github.com/kripken/emscripten/pull/6177#issuecomment-362456258","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/6177","id":362456258,"user":{"login":"kripken","id":173661,"avatar_url":"https://avatars0.githubusercontent.com/u/173661?v=4","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"created_at":"2018-02-02T01:22:11Z","updated_at":"2018-02-02T01:22:11Z","author_association":"OWNER","body":"lgtm. Interesting, I didn't know windows did that even when issuing a command from python."}}
{"actor":{"display_login":"kripken"}}