{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/pulls/comments/237536239","pull_request_review_id":179858015,"id":237536239,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzUzNjIzOQ==","diff_hunk":"@@ -64,8 +64,8 @@ public String getCloudSdkVersion() {\n     return cloudSdkVersion;\n   }\n \n-  public File getServiceAccountKeyFile() {\n-    return serviceAccountKeyFile;\n+  public Path getServiceAccountKeyFile() {","path":"src/main/java/com/google/cloud/tools/maven/cloudsdk/CloudSdkMojo.java","position":15,"original_position":15,"commit_id":"07b6e39abe95899dc7d27b424f34893ddedbeb75","original_commit_id":"07b6e39abe95899dc7d27b424f34893ddedbeb75","user":{"login":"chanseokoh","id":10523105,"node_id":"MDQ6VXNlcjEwNTIzMTA1","avatar_url":"https://avatars2.githubusercontent.com/u/10523105?v=4","gravatar_id":"","url":"https://api.github.com/users/chanseokoh","html_url":"https://github.com/chanseokoh","followers_url":"https://api.github.com/users/chanseokoh/followers","following_url":"https://api.github.com/users/chanseokoh/following{/other_user}","gists_url":"https://api.github.com/users/chanseokoh/gists{/gist_id}","starred_url":"https://api.github.com/users/chanseokoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanseokoh/subscriptions","organizations_url":"https://api.github.com/users/chanseokoh/orgs","repos_url":"https://api.github.com/users/chanseokoh/repos","events_url":"https://api.github.com/users/chanseokoh/events{/privacy}","received_events_url":"https://api.github.com/users/chanseokoh/received_events","type":"User","site_admin":false},"body":"Could it be that there was a reason to use `File` instead of `Path`? I vaguely remember Maven did not support `File` somewhere, but that may be irrelevant here.","created_at":"2018-11-29T15:35:15Z","updated_at":"2018-11-29T15:50:56Z","html_url":"https://github.com/GoogleCloudPlatform/app-maven-plugin/pull/343#discussion_r237536239","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/pulls/343","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/pulls/comments/237536239"},"html":{"href":"https://github.com/GoogleCloudPlatform/app-maven-plugin/pull/343#discussion_r237536239"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/pulls/343"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/pulls/343","id":234442914,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDQyOTE0","html_url":"https://github.com/GoogleCloudPlatform/app-maven-plugin/pull/343","diff_url":"https://github.com/GoogleCloudPlatform/app-maven-plugin/pull/343.diff","patch_url":"https://github.com/GoogleCloudPlatform/app-maven-plugin/pull/343.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/issues/343","number":343,"state":"open","locked":false,"title":"Update to plugins-core 0.7.0","user":{"login":"loosebazooka","id":1304826,"node_id":"MDQ6VXNlcjEzMDQ4MjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1304826?v=4","gravatar_id":"","url":"https://api.github.com/users/loosebazooka","html_url":"https://github.com/loosebazooka","followers_url":"https://api.github.com/users/loosebazooka/followers","following_url":"https://api.github.com/users/loosebazooka/following{/other_user}","gists_url":"https://api.github.com/users/loosebazooka/gists{/gist_id}","starred_url":"https://api.github.com/users/loosebazooka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loosebazooka/subscriptions","organizations_url":"https://api.github.com/users/loosebazooka/orgs","repos_url":"https://api.github.com/users/loosebazooka/repos","events_url":"https://api.github.com/users/loosebazooka/events{/privacy}","received_events_url":"https://api.github.com/users/loosebazooka/received_events","type":"User","site_admin":false},"body":"Sorry this is the most giant PR, I think it touches every file.\r\n- Restructured the packages a little so files are better organized\r\n- Plugins core no longer exposes the config interfaces so we have to convert Mojo -> Config object.\r\n- Had to rewrite a lot of the tests.\r\n- Integeration tests pass without touching!","created_at":"2018-11-28T22:17:27Z","updated_at":"2018-11-29T15:50:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e331850305a701464d96db0409b2cebe059d1c9b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"coollog","id":4852522,"node_id":"MDQ6VXNlcjQ4NTI1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4852522?v=4","gravatar_id":"","url":"https://api.github.com/users/coollog","html_url":"https://github.com/coollog","followers_url":"https://api.github.com/users/coollog/followers","following_url":"https://api.github.com/users/coollog/following{/other_user}","gists_url":"https://api.github.com/users/coollog/gists{/gist_id}","starred_url":"https://api.github.com/users/coollog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coollog/subscriptions","organizations_url":"https://api.github.com/users/coollog/orgs","repos_url":"https://api.github.com/users/coollog/repos","events_url":"https://api.github.com/users/coollog/events{/privacy}","received_events_url":"https://api.github.com/users/coollog/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/pulls/343/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/pulls/343/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/issues/343/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/statuses/07b6e39abe95899dc7d27b424f34893ddedbeb75","head":{"label":"GoogleCloudPlatform:update-pluginscore-070","ref":"update-pluginscore-070","sha":"07b6e39abe95899dc7d27b424f34893ddedbeb75","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":54131052,"node_id":"MDEwOlJlcG9zaXRvcnk1NDEzMTA1Mg==","name":"app-maven-plugin","full_name":"GoogleCloudPlatform/app-maven-plugin","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/app-maven-plugin","description":"Maven plugin to build and deploy Google App Engine applications.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/deployments","created_at":"2016-03-17T15:48:48Z","updated_at":"2018-11-14T17:08:09Z","pushed_at":"2018-11-29T00:15:04Z","git_url":"git://github.com/GoogleCloudPlatform/app-maven-plugin.git","ssh_url":"git@github.com:GoogleCloudPlatform/app-maven-plugin.git","clone_url":"https://github.com/GoogleCloudPlatform/app-maven-plugin.git","svn_url":"https://github.com/GoogleCloudPlatform/app-maven-plugin","homepage":"https://cloud.google.com/appengine/docs/java/tools/maven-reference","size":496,"stargazers_count":53,"watchers_count":53,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":28,"open_issues":23,"watchers":53,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"86dc06ba6301431fef31200c0b1ccd88f7c82031","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":54131052,"node_id":"MDEwOlJlcG9zaXRvcnk1NDEzMTA1Mg==","name":"app-maven-plugin","full_name":"GoogleCloudPlatform/app-maven-plugin","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/app-maven-plugin","description":"Maven plugin to build and deploy Google App Engine applications.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/deployments","created_at":"2016-03-17T15:48:48Z","updated_at":"2018-11-14T17:08:09Z","pushed_at":"2018-11-29T00:15:04Z","git_url":"git://github.com/GoogleCloudPlatform/app-maven-plugin.git","ssh_url":"git@github.com:GoogleCloudPlatform/app-maven-plugin.git","clone_url":"https://github.com/GoogleCloudPlatform/app-maven-plugin.git","svn_url":"https://github.com/GoogleCloudPlatform/app-maven-plugin","homepage":"https://cloud.google.com/appengine/docs/java/tools/maven-reference","size":496,"stargazers_count":53,"watchers_count":53,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":28,"open_issues":23,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/pulls/343"},"html":{"href":"https://github.com/GoogleCloudPlatform/app-maven-plugin/pull/343"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/issues/343"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/issues/343/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/pulls/343/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/pulls/343/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-maven-plugin/statuses/07b6e39abe95899dc7d27b424f34893ddedbeb75"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chanseokoh"}}