{"action":"created","comment":{"url":"https://api.github.com/repos/redox-os/relibc/pulls/comments/182096131","pull_request_review_id":112839485,"id":182096131,"diff_hunk":"@@ -53,47 +53,52 @@ BINS=\\\n \tgetid \\\n \tsetid\n \n+FORCE:\n+.PHONY: all clean run gen_expected verify FORCE\n+\n all: $(BINS)\n \n clean:\n-\trm -f $(BINS) *.out\n+\t@$(RM) -v $(BINS) *.out\n+\t@$(RM) -rv gen/\n+run: $(BINS:%=%.run)","path":"tests/Makefile","position":13,"original_position":13,"commit_id":"0dc6048dcfab57daa89ce06985ff3bf2e2bb1abb","original_commit_id":"0dc6048dcfab57daa89ce06985ff3bf2e2bb1abb","user":{"login":"LeonardKoenig","id":7831843,"avatar_url":"https://avatars2.githubusercontent.com/u/7831843?v=4","gravatar_id":"","url":"https://api.github.com/users/LeonardKoenig","html_url":"https://github.com/LeonardKoenig","followers_url":"https://api.github.com/users/LeonardKoenig/followers","following_url":"https://api.github.com/users/LeonardKoenig/following{/other_user}","gists_url":"https://api.github.com/users/LeonardKoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonardKoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonardKoenig/subscriptions","organizations_url":"https://api.github.com/users/LeonardKoenig/orgs","repos_url":"https://api.github.com/users/LeonardKoenig/repos","events_url":"https://api.github.com/users/LeonardKoenig/events{/privacy}","received_events_url":"https://api.github.com/users/LeonardKoenig/received_events","type":"User","site_admin":false},"body":"Why, this would trigger a rebuild before compiling, ie. ifI aborted compilation and want to clean up, I first need to recompile in order to delete the just created files.","created_at":"2018-04-17T14:37:00Z","updated_at":"2018-04-17T14:37:00Z","html_url":"https://github.com/redox-os/relibc/pull/117#discussion_r182096131","pull_request_url":"https://api.github.com/repos/redox-os/relibc/pulls/117","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/redox-os/relibc/pulls/comments/182096131"},"html":{"href":"https://github.com/redox-os/relibc/pull/117#discussion_r182096131"},"pull_request":{"href":"https://api.github.com/repos/redox-os/relibc/pulls/117"}},"in_reply_to_id":182095112},"pull_request":{"url":"https://api.github.com/repos/redox-os/relibc/pulls/117","id":180112133,"html_url":"https://github.com/redox-os/relibc/pull/117","diff_url":"https://github.com/redox-os/relibc/pull/117.diff","patch_url":"https://github.com/redox-os/relibc/pull/117.patch","issue_url":"https://api.github.com/repos/redox-os/relibc/issues/117","number":117,"state":"open","locked":false,"title":"tests/Makefile: Remove loops and simplify recipes","user":{"login":"LeonardKoenig","id":7831843,"avatar_url":"https://avatars2.githubusercontent.com/u/7831843?v=4","gravatar_id":"","url":"https://api.github.com/users/LeonardKoenig","html_url":"https://github.com/LeonardKoenig","followers_url":"https://api.github.com/users/LeonardKoenig/followers","following_url":"https://api.github.com/users/LeonardKoenig/following{/other_user}","gists_url":"https://api.github.com/users/LeonardKoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonardKoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonardKoenig/subscriptions","organizations_url":"https://api.github.com/users/LeonardKoenig/orgs","repos_url":"https://api.github.com/users/LeonardKoenig/repos","events_url":"https://api.github.com/users/LeonardKoenig/events{/privacy}","received_events_url":"https://api.github.com/users/LeonardKoenig/received_events","type":"User","site_admin":false},"body":" - Make non-file targets .PHONY\r\n - Turn loops into Make-Dependencies, this also enables checking each test independently\r\n - Split CFLAGS into CPPFLAGS,CFLAGS and LDFLAGS and adapt rule\r\n\r\nI suppose one should remove `getid` from either `BINS` or `EXPECT_BINS` where it's currently listed twice.","created_at":"2018-04-07T16:03:16Z","updated_at":"2018-04-17T14:37:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba3d04a62ed7c6a5255741c34fd3aec6cc9a9157","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/redox-os/relibc/pulls/117/commits","review_comments_url":"https://api.github.com/repos/redox-os/relibc/pulls/117/comments","review_comment_url":"https://api.github.com/repos/redox-os/relibc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redox-os/relibc/issues/117/comments","statuses_url":"https://api.github.com/repos/redox-os/relibc/statuses/0dc6048dcfab57daa89ce06985ff3bf2e2bb1abb","head":{"label":"LeonardKoenig:prq/makefiles","ref":"prq/makefiles","sha":"0dc6048dcfab57daa89ce06985ff3bf2e2bb1abb","user":{"login":"LeonardKoenig","id":7831843,"avatar_url":"https://avatars2.githubusercontent.com/u/7831843?v=4","gravatar_id":"","url":"https://api.github.com/users/LeonardKoenig","html_url":"https://github.com/LeonardKoenig","followers_url":"https://api.github.com/users/LeonardKoenig/followers","following_url":"https://api.github.com/users/LeonardKoenig/following{/other_user}","gists_url":"https://api.github.com/users/LeonardKoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonardKoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonardKoenig/subscriptions","organizations_url":"https://api.github.com/users/LeonardKoenig/orgs","repos_url":"https://api.github.com/users/LeonardKoenig/repos","events_url":"https://api.github.com/users/LeonardKoenig/events{/privacy}","received_events_url":"https://api.github.com/users/LeonardKoenig/received_events","type":"User","site_admin":false},"repo":{"id":128540644,"name":"relibc","full_name":"LeonardKoenig/relibc","owner":{"login":"LeonardKoenig","id":7831843,"avatar_url":"https://avatars2.githubusercontent.com/u/7831843?v=4","gravatar_id":"","url":"https://api.github.com/users/LeonardKoenig","html_url":"https://github.com/LeonardKoenig","followers_url":"https://api.github.com/users/LeonardKoenig/followers","following_url":"https://api.github.com/users/LeonardKoenig/following{/other_user}","gists_url":"https://api.github.com/users/LeonardKoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonardKoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonardKoenig/subscriptions","organizations_url":"https://api.github.com/users/LeonardKoenig/orgs","repos_url":"https://api.github.com/users/LeonardKoenig/repos","events_url":"https://api.github.com/users/LeonardKoenig/events{/privacy}","received_events_url":"https://api.github.com/users/LeonardKoenig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LeonardKoenig/relibc","description":"C Library in Rust for Redox and Linux (WIP)","fork":true,"url":"https://api.github.com/repos/LeonardKoenig/relibc","forks_url":"https://api.github.com/repos/LeonardKoenig/relibc/forks","keys_url":"https://api.github.com/repos/LeonardKoenig/relibc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LeonardKoenig/relibc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LeonardKoenig/relibc/teams","hooks_url":"https://api.github.com/repos/LeonardKoenig/relibc/hooks","issue_events_url":"https://api.github.com/repos/LeonardKoenig/relibc/issues/events{/number}","events_url":"https://api.github.com/repos/LeonardKoenig/relibc/events","assignees_url":"https://api.github.com/repos/LeonardKoenig/relibc/assignees{/user}","branches_url":"https://api.github.com/repos/LeonardKoenig/relibc/branches{/branch}","tags_url":"https://api.github.com/repos/LeonardKoenig/relibc/tags","blobs_url":"https://api.github.com/repos/LeonardKoenig/relibc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LeonardKoenig/relibc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LeonardKoenig/relibc/git/refs{/sha}","trees_url":"https://api.github.com/repos/LeonardKoenig/relibc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LeonardKoenig/relibc/statuses/{sha}","languages_url":"https://api.github.com/repos/LeonardKoenig/relibc/languages","stargazers_url":"https://api.github.com/repos/LeonardKoenig/relibc/stargazers","contributors_url":"https://api.github.com/repos/LeonardKoenig/relibc/contributors","subscribers_url":"https://api.github.com/repos/LeonardKoenig/relibc/subscribers","subscription_url":"https://api.github.com/repos/LeonardKoenig/relibc/subscription","commits_url":"https://api.github.com/repos/LeonardKoenig/relibc/commits{/sha}","git_commits_url":"https://api.github.com/repos/LeonardKoenig/relibc/git/commits{/sha}","comments_url":"https://api.github.com/repos/LeonardKoenig/relibc/comments{/number}","issue_comment_url":"https://api.github.com/repos/LeonardKoenig/relibc/issues/comments{/number}","contents_url":"https://api.github.com/repos/LeonardKoenig/relibc/contents/{+path}","compare_url":"https://api.github.com/repos/LeonardKoenig/relibc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LeonardKoenig/relibc/merges","archive_url":"https://api.github.com/repos/LeonardKoenig/relibc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LeonardKoenig/relibc/downloads","issues_url":"https://api.github.com/repos/LeonardKoenig/relibc/issues{/number}","pulls_url":"https://api.github.com/repos/LeonardKoenig/relibc/pulls{/number}","milestones_url":"https://api.github.com/repos/LeonardKoenig/relibc/milestones{/number}","notifications_url":"https://api.github.com/repos/LeonardKoenig/relibc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LeonardKoenig/relibc/labels{/name}","releases_url":"https://api.github.com/repos/LeonardKoenig/relibc/releases{/id}","deployments_url":"https://api.github.com/repos/LeonardKoenig/relibc/deployments","created_at":"2018-04-07T15:16:32Z","updated_at":"2018-04-07T15:16:35Z","pushed_at":"2018-04-15T13:49:51Z","git_url":"git://github.com/LeonardKoenig/relibc.git","ssh_url":"git@github.com:LeonardKoenig/relibc.git","clone_url":"https://github.com/LeonardKoenig/relibc.git","svn_url":"https://github.com/LeonardKoenig/relibc","homepage":"","size":961,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redox-os:master","ref":"master","sha":"93e2e16077a9fb935dd5e12bacd3b163f6f43b8b","user":{"login":"redox-os","id":14909902,"avatar_url":"https://avatars3.githubusercontent.com/u/14909902?v=4","gravatar_id":"","url":"https://api.github.com/users/redox-os","html_url":"https://github.com/redox-os","followers_url":"https://api.github.com/users/redox-os/followers","following_url":"https://api.github.com/users/redox-os/following{/other_user}","gists_url":"https://api.github.com/users/redox-os/gists{/gist_id}","starred_url":"https://api.github.com/users/redox-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redox-os/subscriptions","organizations_url":"https://api.github.com/users/redox-os/orgs","repos_url":"https://api.github.com/users/redox-os/repos","events_url":"https://api.github.com/users/redox-os/events{/privacy}","received_events_url":"https://api.github.com/users/redox-os/received_events","type":"Organization","site_admin":false},"repo":{"id":123522329,"name":"relibc","full_name":"redox-os/relibc","owner":{"login":"redox-os","id":14909902,"avatar_url":"https://avatars3.githubusercontent.com/u/14909902?v=4","gravatar_id":"","url":"https://api.github.com/users/redox-os","html_url":"https://github.com/redox-os","followers_url":"https://api.github.com/users/redox-os/followers","following_url":"https://api.github.com/users/redox-os/following{/other_user}","gists_url":"https://api.github.com/users/redox-os/gists{/gist_id}","starred_url":"https://api.github.com/users/redox-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redox-os/subscriptions","organizations_url":"https://api.github.com/users/redox-os/orgs","repos_url":"https://api.github.com/users/redox-os/repos","events_url":"https://api.github.com/users/redox-os/events{/privacy}","received_events_url":"https://api.github.com/users/redox-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redox-os/relibc","description":"C Library in Rust for Redox and Linux (WIP)","fork":false,"url":"https://api.github.com/repos/redox-os/relibc","forks_url":"https://api.github.com/repos/redox-os/relibc/forks","keys_url":"https://api.github.com/repos/redox-os/relibc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redox-os/relibc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redox-os/relibc/teams","hooks_url":"https://api.github.com/repos/redox-os/relibc/hooks","issue_events_url":"https://api.github.com/repos/redox-os/relibc/issues/events{/number}","events_url":"https://api.github.com/repos/redox-os/relibc/events","assignees_url":"https://api.github.com/repos/redox-os/relibc/assignees{/user}","branches_url":"https://api.github.com/repos/redox-os/relibc/branches{/branch}","tags_url":"https://api.github.com/repos/redox-os/relibc/tags","blobs_url":"https://api.github.com/repos/redox-os/relibc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redox-os/relibc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redox-os/relibc/git/refs{/sha}","trees_url":"https://api.github.com/repos/redox-os/relibc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redox-os/relibc/statuses/{sha}","languages_url":"https://api.github.com/repos/redox-os/relibc/languages","stargazers_url":"https://api.github.com/repos/redox-os/relibc/stargazers","contributors_url":"https://api.github.com/repos/redox-os/relibc/contributors","subscribers_url":"https://api.github.com/repos/redox-os/relibc/subscribers","subscription_url":"https://api.github.com/repos/redox-os/relibc/subscription","commits_url":"https://api.github.com/repos/redox-os/relibc/commits{/sha}","git_commits_url":"https://api.github.com/repos/redox-os/relibc/git/commits{/sha}","comments_url":"https://api.github.com/repos/redox-os/relibc/comments{/number}","issue_comment_url":"https://api.github.com/repos/redox-os/relibc/issues/comments{/number}","contents_url":"https://api.github.com/repos/redox-os/relibc/contents/{+path}","compare_url":"https://api.github.com/repos/redox-os/relibc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redox-os/relibc/merges","archive_url":"https://api.github.com/repos/redox-os/relibc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redox-os/relibc/downloads","issues_url":"https://api.github.com/repos/redox-os/relibc/issues{/number}","pulls_url":"https://api.github.com/repos/redox-os/relibc/pulls{/number}","milestones_url":"https://api.github.com/repos/redox-os/relibc/milestones{/number}","notifications_url":"https://api.github.com/repos/redox-os/relibc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redox-os/relibc/labels{/name}","releases_url":"https://api.github.com/repos/redox-os/relibc/releases{/id}","deployments_url":"https://api.github.com/repos/redox-os/relibc/deployments","created_at":"2018-03-02T02:58:07Z","updated_at":"2018-04-13T06:56:28Z","pushed_at":"2018-04-15T13:49:53Z","git_url":"git://github.com/redox-os/relibc.git","ssh_url":"git@github.com:redox-os/relibc.git","clone_url":"https://github.com/redox-os/relibc.git","svn_url":"https://github.com/redox-os/relibc","homepage":"","size":953,"stargazers_count":473,"watchers_count":473,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":33,"open_issues":31,"watchers":473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redox-os/relibc/pulls/117"},"html":{"href":"https://github.com/redox-os/relibc/pull/117"},"issue":{"href":"https://api.github.com/repos/redox-os/relibc/issues/117"},"comments":{"href":"https://api.github.com/repos/redox-os/relibc/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/redox-os/relibc/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/redox-os/relibc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redox-os/relibc/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/redox-os/relibc/statuses/0dc6048dcfab57daa89ce06985ff3bf2e2bb1abb"}},"author_association":"NONE"}}
{"actor":{"display_login":"LeonardKoenig"}}