{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/jetty.project/issues/2719","repository_url":"https://api.github.com/repos/eclipse/jetty.project","labels_url":"https://api.github.com/repos/eclipse/jetty.project/issues/2719/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/issues/2719/comments","events_url":"https://api.github.com/repos/eclipse/jetty.project/issues/2719/events","html_url":"https://github.com/eclipse/jetty.project/issues/2719","id":341410517,"node_id":"MDU6SXNzdWUzNDE0MTA1MTc=","number":2719,"title":"property file passed to start.jar is not read","user":{"login":"jscheible-tpgroup","id":41281438,"node_id":"MDQ6VXNlcjQxMjgxNDM4","avatar_url":"https://avatars0.githubusercontent.com/u/41281438?v=4","gravatar_id":"","url":"https://api.github.com/users/jscheible-tpgroup","html_url":"https://github.com/jscheible-tpgroup","followers_url":"https://api.github.com/users/jscheible-tpgroup/followers","following_url":"https://api.github.com/users/jscheible-tpgroup/following{/other_user}","gists_url":"https://api.github.com/users/jscheible-tpgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/jscheible-tpgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscheible-tpgroup/subscriptions","organizations_url":"https://api.github.com/users/jscheible-tpgroup/orgs","repos_url":"https://api.github.com/users/jscheible-tpgroup/repos","events_url":"https://api.github.com/users/jscheible-tpgroup/events{/privacy}","received_events_url":"https://api.github.com/users/jscheible-tpgroup/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-16T07:10:49Z","updated_at":"2018-07-16T11:45:52Z","closed_at":null,"author_association":"NONE","body":"When passing a property file to start.jar like\r\n```\r\njava -jar start.jar externalized.properties --list-config\r\n```\r\nthe existence of the file is check (a not existing file causes an error) but the properties are not read (file containts a property named `foo`):\r\n```\r\nProperties:\r\n-----------\r\n java.version = 1.8.0_131\r\n java.version.major = 1\r\n java.version.micro = 0\r\n java.version.minor = 8\r\n java.version.platform = 8\r\n jetty.base = E:\\jetty-9.4\r\n jetty.base.uri = file:///E:/jetty-9.4\r\n jetty.home = E:\\jetty-9.4\r\n jetty.home.uri = file:///E:/jetty-9.4\r\n```\r\n\r\nThe odd thing is that passing a key-value pair directly (`java -jar start.jar foo=bar --list-config`) or placing a ini-file in `start.d` folder works:\r\n```\r\nProperties:\r\n-----------\r\n foo = bar\r\n java.version = 1.8.0_131\r\n ...\r\n ```"},"comment":{"url":"https://api.github.com/repos/eclipse/jetty.project/issues/comments/405221450","html_url":"https://github.com/eclipse/jetty.project/issues/2719#issuecomment-405221450","issue_url":"https://api.github.com/repos/eclipse/jetty.project/issues/2719","id":405221450,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTIyMTQ1MA==","user":{"login":"jscheible-tpgroup","id":41281438,"node_id":"MDQ6VXNlcjQxMjgxNDM4","avatar_url":"https://avatars0.githubusercontent.com/u/41281438?v=4","gravatar_id":"","url":"https://api.github.com/users/jscheible-tpgroup","html_url":"https://github.com/jscheible-tpgroup","followers_url":"https://api.github.com/users/jscheible-tpgroup/followers","following_url":"https://api.github.com/users/jscheible-tpgroup/following{/other_user}","gists_url":"https://api.github.com/users/jscheible-tpgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/jscheible-tpgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscheible-tpgroup/subscriptions","organizations_url":"https://api.github.com/users/jscheible-tpgroup/orgs","repos_url":"https://api.github.com/users/jscheible-tpgroup/repos","events_url":"https://api.github.com/users/jscheible-tpgroup/events{/privacy}","received_events_url":"https://api.github.com/users/jscheible-tpgroup/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T11:45:52Z","updated_at":"2018-07-16T11:45:52Z","author_association":"NONE","body":"Oh, okay. You're right. Thanks for the quick answer.\r\nI re-read the output of `start.jar --help` and property files are indeed not mentioned there.\r\n\r\nI guess what brought me on the wrong track was some debugging and the observations that `StartArgs#propertyFileRefs` and `StartArgs#propertyFiles` are containing the passed property file. But as already mentioned it is not read...\r\n\r\nThen this is perhaps a potential improvement that can build on the already available foundation in `StartArgs`? Because as far as I can tell the only thing missing is that the property file is read and the properties are added to `StartArgs#properties`, right?"}}
{"actor":{"display_login":"jscheible-tpgroup"}}