{"action":"closed","issue":{"url":"https://api.github.com/repos/serverless/serverless/issues/5564","repository_url":"https://api.github.com/repos/serverless/serverless","labels_url":"https://api.github.com/repos/serverless/serverless/issues/5564/labels{/name}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/5564/comments","events_url":"https://api.github.com/repos/serverless/serverless/issues/5564/events","html_url":"https://github.com/serverless/serverless/issues/5564","id":387780162,"node_id":"MDU6SXNzdWUzODc3ODAxNjI=","number":5564,"title":"Add support for AWS x-ray on AWS API Gateway","user":{"login":"mikeblakeney","id":2646906,"node_id":"MDQ6VXNlcjI2NDY5MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/2646906?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeblakeney","html_url":"https://github.com/mikeblakeney","followers_url":"https://api.github.com/users/mikeblakeney/followers","following_url":"https://api.github.com/users/mikeblakeney/following{/other_user}","gists_url":"https://api.github.com/users/mikeblakeney/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeblakeney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeblakeney/subscriptions","organizations_url":"https://api.github.com/users/mikeblakeney/orgs","repos_url":"https://api.github.com/users/mikeblakeney/repos","events_url":"https://api.github.com/users/mikeblakeney/events{/privacy}","received_events_url":"https://api.github.com/users/mikeblakeney/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-05T14:24:32Z","updated_at":"2018-12-19T22:03:24Z","closed_at":"2018-12-19T22:03:24Z","author_association":"NONE","body":"# This is a Feature Proposal\r\n\r\n## Description\r\nAdding support for enabling tracing on an API Gateway would help enrich the information returned when using API Gateway with lambdas leveraging X-ray.  Particularly because when enabling tracing through the CloudFormation template it is done on the API Gateway Deployment object which is not easy to override due to the random string appended to the object name by the serverless framework.  \r\n\r\nOne particular useful gain with using x-ray with API Gateway is that it resolves issues of x-ray returning successes when API Gateway fails but a lambda responding to the gateway event doesn't.  This happens in instances when the lambda may return a malformed response to the Gateway.\r\n\r\nAdditionally, as a side note, using X-ray with lambdas and serverless could be done by overriding the function with the appropriate configuration for x-ray.  This could be a work around until x-ray is supported in serverless.\r\n\r\nEnabling X-ray for gateway would be done with a `stageDescription` object \r\n```\r\nstageDescription:\r\n   tracingEnabled: boolean\r\n```\r\nThe idea is to allow for extending the `stageDescription` with additional properties in future pull requests.\r\n  \r\nReferences:\r\n* API Gateway Deployment CFT Spec: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-deployment.html\r\n* API Gateway Stage Description CFT Spec: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apigateway-deployment-stagedescription.html\r\n\r\n\r\nSimilar or dependent issues:\r\n* Support for x-ray with Lambdas #3495, PR #3742 \r\n* Different proposal for adding stage description in stage property: #5400"}}
{"actor":{"display_login":"dschep"}}