{"action":"created","comment":{"url":"https://api.github.com/repos/gtk-rs/gir/pulls/comments/178704019","pull_request_review_id":108804431,"id":178704019,"diff_hunk":"@@ -265,29 +244,11 @@ fn generate_constants(w: &mut Write, env: &Env, constants: &[Constant]) -> Resul\n             }\n         }\n \n-        if env.library\n-            .type_(constant.typ)\n-            .maybe_ref_as::<Bitfield>()\n-            .is_some()\n-        {\n-            try!(writeln!(\n-                w,\n-                \"{}pub const {}: {} = {2} {{ bits: {} }};\",\n-                comment,\n-                constant.c_identifier,\n-                type_,\n-                value\n-            ));\n-        } else {\n-            try!(writeln!(\n-                w,\n-                \"{}pub const {}: {} = {};\",\n-                comment,\n-                constant.c_identifier,\n-                type_,\n-                value\n-            ));\n-        }\n+        try!(writeln!(\n+            w,\n+            \"{}pub const {}: {} = {};\",\n+            comment, constant.c_identifier, type_, value\n+        ));","path":"src/codegen/sys/lib_.rs","position":80,"original_position":80,"commit_id":"0b146e2ab0dbbb568e780990848c05c97d080f82","original_commit_id":"0b146e2ab0dbbb568e780990848c05c97d080f82","user":{"login":"EPashkin","id":584258,"avatar_url":"https://avatars2.githubusercontent.com/u/584258?v=4","gravatar_id":"","url":"https://api.github.com/users/EPashkin","html_url":"https://github.com/EPashkin","followers_url":"https://api.github.com/users/EPashkin/followers","following_url":"https://api.github.com/users/EPashkin/following{/other_user}","gists_url":"https://api.github.com/users/EPashkin/gists{/gist_id}","starred_url":"https://api.github.com/users/EPashkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EPashkin/subscriptions","organizations_url":"https://api.github.com/users/EPashkin/orgs","repos_url":"https://api.github.com/users/EPashkin/repos","events_url":"https://api.github.com/users/EPashkin/events{/privacy}","received_events_url":"https://api.github.com/users/EPashkin/received_events","type":"User","site_admin":false},"body":"There will be problem with this for negative const's like `G_LOG_LEVEL_MASK`,\r\nso maybe better restore special case for `Bitfield` with same action as in bitfield generation?","created_at":"2018-04-03T03:17:15Z","updated_at":"2018-04-03T03:17:15Z","html_url":"https://github.com/gtk-rs/gir/pull/577#discussion_r178704019","pull_request_url":"https://api.github.com/repos/gtk-rs/gir/pulls/577","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gtk-rs/gir/pulls/comments/178704019"},"html":{"href":"https://github.com/gtk-rs/gir/pull/577#discussion_r178704019"},"pull_request":{"href":"https://api.github.com/repos/gtk-rs/gir/pulls/577"}}},"pull_request":{"url":"https://api.github.com/repos/gtk-rs/gir/pulls/577","id":178912766,"html_url":"https://github.com/gtk-rs/gir/pull/577","diff_url":"https://github.com/gtk-rs/gir/pull/577.diff","patch_url":"https://github.com/gtk-rs/gir/pull/577.patch","issue_url":"https://api.github.com/repos/gtk-rs/gir/issues/577","number":577,"state":"open","locked":false,"title":"Uint flags in sys","user":{"login":"EPashkin","id":584258,"avatar_url":"https://avatars2.githubusercontent.com/u/584258?v=4","gravatar_id":"","url":"https://api.github.com/users/EPashkin","html_url":"https://github.com/EPashkin","followers_url":"https://api.github.com/users/EPashkin/followers","following_url":"https://api.github.com/users/EPashkin/following{/other_user}","gists_url":"https://api.github.com/users/EPashkin/gists{/gist_id}","starred_url":"https://api.github.com/users/EPashkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EPashkin/subscriptions","organizations_url":"https://api.github.com/users/EPashkin/orgs","repos_url":"https://api.github.com/users/EPashkin/repos","events_url":"https://api.github.com/users/EPashkin/events{/privacy}","received_events_url":"https://api.github.com/users/EPashkin/received_events","type":"User","site_admin":false},"body":"Part of https://github.com/gtk-rs/gir/issues/575\r\n\r\n@sdroege Please, check changes in gstreamer, especially in GST_BUFFER_COPY_ALL and other constants based on flags\r\n\r\ncc @GuillaumeGomez,, @tmiasko\r\n","created_at":"2018-04-02T19:35:22Z","updated_at":"2018-04-03T03:17:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8e1deb3c2068777ea3180d587e0578a79e9d57f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gtk-rs/gir/pulls/577/commits","review_comments_url":"https://api.github.com/repos/gtk-rs/gir/pulls/577/comments","review_comment_url":"https://api.github.com/repos/gtk-rs/gir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gtk-rs/gir/issues/577/comments","statuses_url":"https://api.github.com/repos/gtk-rs/gir/statuses/0b146e2ab0dbbb568e780990848c05c97d080f82","head":{"label":"EPashkin:uint_flags_in_sys","ref":"uint_flags_in_sys","sha":"0b146e2ab0dbbb568e780990848c05c97d080f82","user":{"login":"EPashkin","id":584258,"avatar_url":"https://avatars2.githubusercontent.com/u/584258?v=4","gravatar_id":"","url":"https://api.github.com/users/EPashkin","html_url":"https://github.com/EPashkin","followers_url":"https://api.github.com/users/EPashkin/followers","following_url":"https://api.github.com/users/EPashkin/following{/other_user}","gists_url":"https://api.github.com/users/EPashkin/gists{/gist_id}","starred_url":"https://api.github.com/users/EPashkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EPashkin/subscriptions","organizations_url":"https://api.github.com/users/EPashkin/orgs","repos_url":"https://api.github.com/users/EPashkin/repos","events_url":"https://api.github.com/users/EPashkin/events{/privacy}","received_events_url":"https://api.github.com/users/EPashkin/received_events","type":"User","site_admin":false},"repo":{"id":37834474,"name":"gir","full_name":"EPashkin/gir","owner":{"login":"EPashkin","id":584258,"avatar_url":"https://avatars2.githubusercontent.com/u/584258?v=4","gravatar_id":"","url":"https://api.github.com/users/EPashkin","html_url":"https://github.com/EPashkin","followers_url":"https://api.github.com/users/EPashkin/followers","following_url":"https://api.github.com/users/EPashkin/following{/other_user}","gists_url":"https://api.github.com/users/EPashkin/gists{/gist_id}","starred_url":"https://api.github.com/users/EPashkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EPashkin/subscriptions","organizations_url":"https://api.github.com/users/EPashkin/orgs","repos_url":"https://api.github.com/users/EPashkin/repos","events_url":"https://api.github.com/users/EPashkin/events{/privacy}","received_events_url":"https://api.github.com/users/EPashkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EPashkin/gir","description":null,"fork":true,"url":"https://api.github.com/repos/EPashkin/gir","forks_url":"https://api.github.com/repos/EPashkin/gir/forks","keys_url":"https://api.github.com/repos/EPashkin/gir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EPashkin/gir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EPashkin/gir/teams","hooks_url":"https://api.github.com/repos/EPashkin/gir/hooks","issue_events_url":"https://api.github.com/repos/EPashkin/gir/issues/events{/number}","events_url":"https://api.github.com/repos/EPashkin/gir/events","assignees_url":"https://api.github.com/repos/EPashkin/gir/assignees{/user}","branches_url":"https://api.github.com/repos/EPashkin/gir/branches{/branch}","tags_url":"https://api.github.com/repos/EPashkin/gir/tags","blobs_url":"https://api.github.com/repos/EPashkin/gir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EPashkin/gir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EPashkin/gir/git/refs{/sha}","trees_url":"https://api.github.com/repos/EPashkin/gir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EPashkin/gir/statuses/{sha}","languages_url":"https://api.github.com/repos/EPashkin/gir/languages","stargazers_url":"https://api.github.com/repos/EPashkin/gir/stargazers","contributors_url":"https://api.github.com/repos/EPashkin/gir/contributors","subscribers_url":"https://api.github.com/repos/EPashkin/gir/subscribers","subscription_url":"https://api.github.com/repos/EPashkin/gir/subscription","commits_url":"https://api.github.com/repos/EPashkin/gir/commits{/sha}","git_commits_url":"https://api.github.com/repos/EPashkin/gir/git/commits{/sha}","comments_url":"https://api.github.com/repos/EPashkin/gir/comments{/number}","issue_comment_url":"https://api.github.com/repos/EPashkin/gir/issues/comments{/number}","contents_url":"https://api.github.com/repos/EPashkin/gir/contents/{+path}","compare_url":"https://api.github.com/repos/EPashkin/gir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EPashkin/gir/merges","archive_url":"https://api.github.com/repos/EPashkin/gir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EPashkin/gir/downloads","issues_url":"https://api.github.com/repos/EPashkin/gir/issues{/number}","pulls_url":"https://api.github.com/repos/EPashkin/gir/pulls{/number}","milestones_url":"https://api.github.com/repos/EPashkin/gir/milestones{/number}","notifications_url":"https://api.github.com/repos/EPashkin/gir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EPashkin/gir/labels{/name}","releases_url":"https://api.github.com/repos/EPashkin/gir/releases{/id}","deployments_url":"https://api.github.com/repos/EPashkin/gir/deployments","created_at":"2015-06-22T02:31:02Z","updated_at":"2018-03-22T18:47:26Z","pushed_at":"2018-04-02T19:31:50Z","git_url":"git://github.com/EPashkin/gir.git","ssh_url":"git@github.com:EPashkin/gir.git","clone_url":"https://github.com/EPashkin/gir.git","svn_url":"https://github.com/EPashkin/gir","homepage":"","size":1533,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gtk-rs:master","ref":"master","sha":"74a37af3419659e3d1dbe6c430d461cc15f0296c","user":{"login":"gtk-rs","id":11757045,"avatar_url":"https://avatars2.githubusercontent.com/u/11757045?v=4","gravatar_id":"","url":"https://api.github.com/users/gtk-rs","html_url":"https://github.com/gtk-rs","followers_url":"https://api.github.com/users/gtk-rs/followers","following_url":"https://api.github.com/users/gtk-rs/following{/other_user}","gists_url":"https://api.github.com/users/gtk-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gtk-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtk-rs/subscriptions","organizations_url":"https://api.github.com/users/gtk-rs/orgs","repos_url":"https://api.github.com/users/gtk-rs/repos","events_url":"https://api.github.com/users/gtk-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gtk-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":37824715,"name":"gir","full_name":"gtk-rs/gir","owner":{"login":"gtk-rs","id":11757045,"avatar_url":"https://avatars2.githubusercontent.com/u/11757045?v=4","gravatar_id":"","url":"https://api.github.com/users/gtk-rs","html_url":"https://github.com/gtk-rs","followers_url":"https://api.github.com/users/gtk-rs/followers","following_url":"https://api.github.com/users/gtk-rs/following{/other_user}","gists_url":"https://api.github.com/users/gtk-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gtk-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtk-rs/subscriptions","organizations_url":"https://api.github.com/users/gtk-rs/orgs","repos_url":"https://api.github.com/users/gtk-rs/repos","events_url":"https://api.github.com/users/gtk-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gtk-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gtk-rs/gir","description":"Tool to generate rust bindings and user API for glib-based libraries","fork":false,"url":"https://api.github.com/repos/gtk-rs/gir","forks_url":"https://api.github.com/repos/gtk-rs/gir/forks","keys_url":"https://api.github.com/repos/gtk-rs/gir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gtk-rs/gir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gtk-rs/gir/teams","hooks_url":"https://api.github.com/repos/gtk-rs/gir/hooks","issue_events_url":"https://api.github.com/repos/gtk-rs/gir/issues/events{/number}","events_url":"https://api.github.com/repos/gtk-rs/gir/events","assignees_url":"https://api.github.com/repos/gtk-rs/gir/assignees{/user}","branches_url":"https://api.github.com/repos/gtk-rs/gir/branches{/branch}","tags_url":"https://api.github.com/repos/gtk-rs/gir/tags","blobs_url":"https://api.github.com/repos/gtk-rs/gir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gtk-rs/gir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gtk-rs/gir/git/refs{/sha}","trees_url":"https://api.github.com/repos/gtk-rs/gir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gtk-rs/gir/statuses/{sha}","languages_url":"https://api.github.com/repos/gtk-rs/gir/languages","stargazers_url":"https://api.github.com/repos/gtk-rs/gir/stargazers","contributors_url":"https://api.github.com/repos/gtk-rs/gir/contributors","subscribers_url":"https://api.github.com/repos/gtk-rs/gir/subscribers","subscription_url":"https://api.github.com/repos/gtk-rs/gir/subscription","commits_url":"https://api.github.com/repos/gtk-rs/gir/commits{/sha}","git_commits_url":"https://api.github.com/repos/gtk-rs/gir/git/commits{/sha}","comments_url":"https://api.github.com/repos/gtk-rs/gir/comments{/number}","issue_comment_url":"https://api.github.com/repos/gtk-rs/gir/issues/comments{/number}","contents_url":"https://api.github.com/repos/gtk-rs/gir/contents/{+path}","compare_url":"https://api.github.com/repos/gtk-rs/gir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gtk-rs/gir/merges","archive_url":"https://api.github.com/repos/gtk-rs/gir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gtk-rs/gir/downloads","issues_url":"https://api.github.com/repos/gtk-rs/gir/issues{/number}","pulls_url":"https://api.github.com/repos/gtk-rs/gir/pulls{/number}","milestones_url":"https://api.github.com/repos/gtk-rs/gir/milestones{/number}","notifications_url":"https://api.github.com/repos/gtk-rs/gir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gtk-rs/gir/labels{/name}","releases_url":"https://api.github.com/repos/gtk-rs/gir/releases{/id}","deployments_url":"https://api.github.com/repos/gtk-rs/gir/deployments","created_at":"2015-06-21T20:29:55Z","updated_at":"2018-04-01T09:49:24Z","pushed_at":"2018-04-02T19:35:24Z","git_url":"git://github.com/gtk-rs/gir.git","ssh_url":"git@github.com:gtk-rs/gir.git","clone_url":"https://github.com/gtk-rs/gir.git","svn_url":"https://github.com/gtk-rs/gir","homepage":"","size":1531,"stargazers_count":37,"watchers_count":37,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":21,"open_issues":60,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gtk-rs/gir/pulls/577"},"html":{"href":"https://github.com/gtk-rs/gir/pull/577"},"issue":{"href":"https://api.github.com/repos/gtk-rs/gir/issues/577"},"comments":{"href":"https://api.github.com/repos/gtk-rs/gir/issues/577/comments"},"review_comments":{"href":"https://api.github.com/repos/gtk-rs/gir/pulls/577/comments"},"review_comment":{"href":"https://api.github.com/repos/gtk-rs/gir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gtk-rs/gir/pulls/577/commits"},"statuses":{"href":"https://api.github.com/repos/gtk-rs/gir/statuses/0b146e2ab0dbbb568e780990848c05c97d080f82"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"EPashkin"}}