{"action":"created","comment":{"url":"https://api.github.com/repos/CanonicalLtd/multipass/pulls/comments/182132982","pull_request_review_id":112877083,"id":182132982,"diff_hunk":"@@ -1,4 +1,10 @@\n-#!/bin/sh -e\n+#!/bin/bash -e\n \n-# Just a placeholder, however validation of the proxy.{http,https}\n-# configuration could be made here\n+vm_backend=\"$(snapctl get vm-backend)\"\n+\n+if [[ -n $vm_backend && ! $vm_backend =~ (libvirt|qemu) ]]; then\n+    echo \"\\\"$vm_backend\\\" is not a supported VM backend\"\n+    exit 1\n+fi\n+\n+snapctl restart $SNAP_NAME","path":"snap/hooks/configure","position":13,"original_position":13,"commit_id":"8cdcad2099b0e1d42bcb7df1fbb6f58a42aa5dc0","original_commit_id":"8cdcad2099b0e1d42bcb7df1fbb6f58a42aa5dc0","user":{"login":"Saviq","id":231077,"avatar_url":"https://avatars1.githubusercontent.com/u/231077?v=4","gravatar_id":"","url":"https://api.github.com/users/Saviq","html_url":"https://github.com/Saviq","followers_url":"https://api.github.com/users/Saviq/followers","following_url":"https://api.github.com/users/Saviq/following{/other_user}","gists_url":"https://api.github.com/users/Saviq/gists{/gist_id}","starred_url":"https://api.github.com/users/Saviq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Saviq/subscriptions","organizations_url":"https://api.github.com/users/Saviq/orgs","repos_url":"https://api.github.com/users/Saviq/repos","events_url":"https://api.github.com/users/Saviq/events{/privacy}","received_events_url":"https://api.github.com/users/Saviq/received_events","type":"User","site_admin":false},"body":"Restart seems brutal, but I suppose there's nothing better we can do.","created_at":"2018-04-17T15:57:48Z","updated_at":"2018-04-17T16:03:33Z","html_url":"https://github.com/CanonicalLtd/multipass/pull/212#discussion_r182132982","pull_request_url":"https://api.github.com/repos/CanonicalLtd/multipass/pulls/212","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/CanonicalLtd/multipass/pulls/comments/182132982"},"html":{"href":"https://github.com/CanonicalLtd/multipass/pull/212#discussion_r182132982"},"pull_request":{"href":"https://api.github.com/repos/CanonicalLtd/multipass/pulls/212"}}},"pull_request":{"url":"https://api.github.com/repos/CanonicalLtd/multipass/pulls/212","id":182208030,"html_url":"https://github.com/CanonicalLtd/multipass/pull/212","diff_url":"https://github.com/CanonicalLtd/multipass/pull/212.diff","patch_url":"https://github.com/CanonicalLtd/multipass/pull/212.patch","issue_url":"https://api.github.com/repos/CanonicalLtd/multipass/issues/212","number":212,"state":"open","locked":false,"title":"Support libvirt backend","user":{"login":"townsend2010","id":12715814,"avatar_url":"https://avatars2.githubusercontent.com/u/12715814?v=4","gravatar_id":"","url":"https://api.github.com/users/townsend2010","html_url":"https://github.com/townsend2010","followers_url":"https://api.github.com/users/townsend2010/followers","following_url":"https://api.github.com/users/townsend2010/following{/other_user}","gists_url":"https://api.github.com/users/townsend2010/gists{/gist_id}","starred_url":"https://api.github.com/users/townsend2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/townsend2010/subscriptions","organizations_url":"https://api.github.com/users/townsend2010/orgs","repos_url":"https://api.github.com/users/townsend2010/repos","events_url":"https://api.github.com/users/townsend2010/events{/privacy}","received_events_url":"https://api.github.com/users/townsend2010/received_events","type":"User","site_admin":false},"body":"To test with a local build:\r\n`$ MULTIPASS_VM_BACKEND=LIBVIRT ./multipassd`\r\n\r\nFor a snap, after installing it, do:\r\n`$ sudo snap set multipass vm-backend=libvirt`\r\n\r\nAlso, when installed as a snap, `multipass.virsh` also works for administering the VM via virsh.","created_at":"2018-04-17T15:38:01Z","updated_at":"2018-04-17T16:03:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c0c202c4dd0ec3f7721f2e0c3e7c3dd7233860a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CanonicalLtd/multipass/pulls/212/commits","review_comments_url":"https://api.github.com/repos/CanonicalLtd/multipass/pulls/212/comments","review_comment_url":"https://api.github.com/repos/CanonicalLtd/multipass/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanonicalLtd/multipass/issues/212/comments","statuses_url":"https://api.github.com/repos/CanonicalLtd/multipass/statuses/8cdcad2099b0e1d42bcb7df1fbb6f58a42aa5dc0","head":{"label":"townsend2010:support-libvirt-backend","ref":"support-libvirt-backend","sha":"8cdcad2099b0e1d42bcb7df1fbb6f58a42aa5dc0","user":{"login":"townsend2010","id":12715814,"avatar_url":"https://avatars2.githubusercontent.com/u/12715814?v=4","gravatar_id":"","url":"https://api.github.com/users/townsend2010","html_url":"https://github.com/townsend2010","followers_url":"https://api.github.com/users/townsend2010/followers","following_url":"https://api.github.com/users/townsend2010/following{/other_user}","gists_url":"https://api.github.com/users/townsend2010/gists{/gist_id}","starred_url":"https://api.github.com/users/townsend2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/townsend2010/subscriptions","organizations_url":"https://api.github.com/users/townsend2010/orgs","repos_url":"https://api.github.com/users/townsend2010/repos","events_url":"https://api.github.com/users/townsend2010/events{/privacy}","received_events_url":"https://api.github.com/users/townsend2010/received_events","type":"User","site_admin":false},"repo":{"id":120343768,"name":"multipass","full_name":"townsend2010/multipass","owner":{"login":"townsend2010","id":12715814,"avatar_url":"https://avatars2.githubusercontent.com/u/12715814?v=4","gravatar_id":"","url":"https://api.github.com/users/townsend2010","html_url":"https://github.com/townsend2010","followers_url":"https://api.github.com/users/townsend2010/followers","following_url":"https://api.github.com/users/townsend2010/following{/other_user}","gists_url":"https://api.github.com/users/townsend2010/gists{/gist_id}","starred_url":"https://api.github.com/users/townsend2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/townsend2010/subscriptions","organizations_url":"https://api.github.com/users/townsend2010/orgs","repos_url":"https://api.github.com/users/townsend2010/repos","events_url":"https://api.github.com/users/townsend2010/events{/privacy}","received_events_url":"https://api.github.com/users/townsend2010/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/townsend2010/multipass","description":"Multipass orchestrates virtual Ubuntu instances","fork":true,"url":"https://api.github.com/repos/townsend2010/multipass","forks_url":"https://api.github.com/repos/townsend2010/multipass/forks","keys_url":"https://api.github.com/repos/townsend2010/multipass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/townsend2010/multipass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/townsend2010/multipass/teams","hooks_url":"https://api.github.com/repos/townsend2010/multipass/hooks","issue_events_url":"https://api.github.com/repos/townsend2010/multipass/issues/events{/number}","events_url":"https://api.github.com/repos/townsend2010/multipass/events","assignees_url":"https://api.github.com/repos/townsend2010/multipass/assignees{/user}","branches_url":"https://api.github.com/repos/townsend2010/multipass/branches{/branch}","tags_url":"https://api.github.com/repos/townsend2010/multipass/tags","blobs_url":"https://api.github.com/repos/townsend2010/multipass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/townsend2010/multipass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/townsend2010/multipass/git/refs{/sha}","trees_url":"https://api.github.com/repos/townsend2010/multipass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/townsend2010/multipass/statuses/{sha}","languages_url":"https://api.github.com/repos/townsend2010/multipass/languages","stargazers_url":"https://api.github.com/repos/townsend2010/multipass/stargazers","contributors_url":"https://api.github.com/repos/townsend2010/multipass/contributors","subscribers_url":"https://api.github.com/repos/townsend2010/multipass/subscribers","subscription_url":"https://api.github.com/repos/townsend2010/multipass/subscription","commits_url":"https://api.github.com/repos/townsend2010/multipass/commits{/sha}","git_commits_url":"https://api.github.com/repos/townsend2010/multipass/git/commits{/sha}","comments_url":"https://api.github.com/repos/townsend2010/multipass/comments{/number}","issue_comment_url":"https://api.github.com/repos/townsend2010/multipass/issues/comments{/number}","contents_url":"https://api.github.com/repos/townsend2010/multipass/contents/{+path}","compare_url":"https://api.github.com/repos/townsend2010/multipass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/townsend2010/multipass/merges","archive_url":"https://api.github.com/repos/townsend2010/multipass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/townsend2010/multipass/downloads","issues_url":"https://api.github.com/repos/townsend2010/multipass/issues{/number}","pulls_url":"https://api.github.com/repos/townsend2010/multipass/pulls{/number}","milestones_url":"https://api.github.com/repos/townsend2010/multipass/milestones{/number}","notifications_url":"https://api.github.com/repos/townsend2010/multipass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/townsend2010/multipass/labels{/name}","releases_url":"https://api.github.com/repos/townsend2010/multipass/releases{/id}","deployments_url":"https://api.github.com/repos/townsend2010/multipass/deployments","created_at":"2018-02-05T18:23:18Z","updated_at":"2018-03-30T16:18:12Z","pushed_at":"2018-04-17T15:36:57Z","git_url":"git://github.com/townsend2010/multipass.git","ssh_url":"git@github.com:townsend2010/multipass.git","clone_url":"https://github.com/townsend2010/multipass.git","svn_url":"https://github.com/townsend2010/multipass","homepage":"","size":498,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CanonicalLtd:master","ref":"master","sha":"3df2e9d3ad57337300e13b2231da512b398a17fd","user":{"login":"CanonicalLtd","id":7490288,"avatar_url":"https://avatars0.githubusercontent.com/u/7490288?v=4","gravatar_id":"","url":"https://api.github.com/users/CanonicalLtd","html_url":"https://github.com/CanonicalLtd","followers_url":"https://api.github.com/users/CanonicalLtd/followers","following_url":"https://api.github.com/users/CanonicalLtd/following{/other_user}","gists_url":"https://api.github.com/users/CanonicalLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/CanonicalLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanonicalLtd/subscriptions","organizations_url":"https://api.github.com/users/CanonicalLtd/orgs","repos_url":"https://api.github.com/users/CanonicalLtd/repos","events_url":"https://api.github.com/users/CanonicalLtd/events{/privacy}","received_events_url":"https://api.github.com/users/CanonicalLtd/received_events","type":"Organization","site_admin":false},"repo":{"id":114128199,"name":"multipass","full_name":"CanonicalLtd/multipass","owner":{"login":"CanonicalLtd","id":7490288,"avatar_url":"https://avatars0.githubusercontent.com/u/7490288?v=4","gravatar_id":"","url":"https://api.github.com/users/CanonicalLtd","html_url":"https://github.com/CanonicalLtd","followers_url":"https://api.github.com/users/CanonicalLtd/followers","following_url":"https://api.github.com/users/CanonicalLtd/following{/other_user}","gists_url":"https://api.github.com/users/CanonicalLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/CanonicalLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanonicalLtd/subscriptions","organizations_url":"https://api.github.com/users/CanonicalLtd/orgs","repos_url":"https://api.github.com/users/CanonicalLtd/repos","events_url":"https://api.github.com/users/CanonicalLtd/events{/privacy}","received_events_url":"https://api.github.com/users/CanonicalLtd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanonicalLtd/multipass","description":"Multipass orchestrates virtual Ubuntu instances","fork":false,"url":"https://api.github.com/repos/CanonicalLtd/multipass","forks_url":"https://api.github.com/repos/CanonicalLtd/multipass/forks","keys_url":"https://api.github.com/repos/CanonicalLtd/multipass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanonicalLtd/multipass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanonicalLtd/multipass/teams","hooks_url":"https://api.github.com/repos/CanonicalLtd/multipass/hooks","issue_events_url":"https://api.github.com/repos/CanonicalLtd/multipass/issues/events{/number}","events_url":"https://api.github.com/repos/CanonicalLtd/multipass/events","assignees_url":"https://api.github.com/repos/CanonicalLtd/multipass/assignees{/user}","branches_url":"https://api.github.com/repos/CanonicalLtd/multipass/branches{/branch}","tags_url":"https://api.github.com/repos/CanonicalLtd/multipass/tags","blobs_url":"https://api.github.com/repos/CanonicalLtd/multipass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanonicalLtd/multipass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanonicalLtd/multipass/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanonicalLtd/multipass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanonicalLtd/multipass/statuses/{sha}","languages_url":"https://api.github.com/repos/CanonicalLtd/multipass/languages","stargazers_url":"https://api.github.com/repos/CanonicalLtd/multipass/stargazers","contributors_url":"https://api.github.com/repos/CanonicalLtd/multipass/contributors","subscribers_url":"https://api.github.com/repos/CanonicalLtd/multipass/subscribers","subscription_url":"https://api.github.com/repos/CanonicalLtd/multipass/subscription","commits_url":"https://api.github.com/repos/CanonicalLtd/multipass/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanonicalLtd/multipass/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanonicalLtd/multipass/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanonicalLtd/multipass/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanonicalLtd/multipass/contents/{+path}","compare_url":"https://api.github.com/repos/CanonicalLtd/multipass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanonicalLtd/multipass/merges","archive_url":"https://api.github.com/repos/CanonicalLtd/multipass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanonicalLtd/multipass/downloads","issues_url":"https://api.github.com/repos/CanonicalLtd/multipass/issues{/number}","pulls_url":"https://api.github.com/repos/CanonicalLtd/multipass/pulls{/number}","milestones_url":"https://api.github.com/repos/CanonicalLtd/multipass/milestones{/number}","notifications_url":"https://api.github.com/repos/CanonicalLtd/multipass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanonicalLtd/multipass/labels{/name}","releases_url":"https://api.github.com/repos/CanonicalLtd/multipass/releases{/id}","deployments_url":"https://api.github.com/repos/CanonicalLtd/multipass/deployments","created_at":"2017-12-13T14:05:21Z","updated_at":"2018-04-12T10:14:02Z","pushed_at":"2018-04-17T15:38:02Z","git_url":"git://github.com/CanonicalLtd/multipass.git","ssh_url":"git@github.com:CanonicalLtd/multipass.git","clone_url":"https://github.com/CanonicalLtd/multipass.git","svn_url":"https://github.com/CanonicalLtd/multipass","homepage":"","size":508,"stargazers_count":34,"watchers_count":34,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":33,"license":null,"forks":9,"open_issues":33,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CanonicalLtd/multipass/pulls/212"},"html":{"href":"https://github.com/CanonicalLtd/multipass/pull/212"},"issue":{"href":"https://api.github.com/repos/CanonicalLtd/multipass/issues/212"},"comments":{"href":"https://api.github.com/repos/CanonicalLtd/multipass/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/CanonicalLtd/multipass/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/CanonicalLtd/multipass/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanonicalLtd/multipass/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/CanonicalLtd/multipass/statuses/8cdcad2099b0e1d42bcb7df1fbb6f58a42aa5dc0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Saviq"}}