{"action":"created","comment":{"url":"https://api.github.com/repos/zalando/zally/pulls/comments/191043826","pull_request_review_id":123551820,"id":191043826,"diff_hunk":"@@ -87,26 +87,22 @@ static boolean isGenericContainer(Object o) {\n         throw new MethodCallRecorderException(m.getReturnType().toString());\n     }\n \n-    static String toPointer(String s) {\n-        return \"/\".concat(rfc6901Encode(getterNameToPointer(s)));\n-    }\n-\n-    static String toPointer(Method m, Object... arguments) {\n+    static JsonPointer toPointer(Method m, Object... arguments) {\n         String s = m.getName();\n         if (arguments.length > 0) {\n             s = s.concat(Objects.toString(arguments[0]));\n         }\n-        return toPointer(s);\n+        return JsonPointers.escape(getterNameToPointer(s));\n     }\n \n     private final T proxy;\n-    private String currentPointer;\n+    private JsonPointer currentPointer;","path":"server/src/main/java/de/zalando/zally/util/ast/MethodCallRecorder.java","position":35,"original_position":35,"commit_id":"d87d3a082a17117f048cd54a4f25b4006162872e","original_commit_id":"d87d3a082a17117f048cd54a4f25b4006162872e","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.](https://app.codacy.com/app/api-infrastructure/zally/pullRequest?prid=1699599)","created_at":"2018-05-26T08:59:04Z","updated_at":"2018-05-26T08:59:04Z","html_url":"https://github.com/zalando/zally/pull/721#discussion_r191043826","pull_request_url":"https://api.github.com/repos/zalando/zally/pulls/721","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/zalando/zally/pulls/comments/191043826"},"html":{"href":"https://github.com/zalando/zally/pull/721#discussion_r191043826"},"pull_request":{"href":"https://api.github.com/repos/zalando/zally/pulls/721"}}},"pull_request":{"url":"https://api.github.com/repos/zalando/zally/pulls/721","id":190729723,"html_url":"https://github.com/zalando/zally/pull/721","diff_url":"https://github.com/zalando/zally/pull/721.diff","patch_url":"https://github.com/zalando/zally/pull/721.patch","issue_url":"https://api.github.com/repos/zalando/zally/issues/721","number":721,"state":"open","locked":false,"title":"Use Jackson's JsonPointer to represent violation locations ","user":{"login":"roxspring","id":783694,"avatar_url":"https://avatars3.githubusercontent.com/u/783694?v=4","gravatar_id":"","url":"https://api.github.com/users/roxspring","html_url":"https://github.com/roxspring","followers_url":"https://api.github.com/users/roxspring/followers","following_url":"https://api.github.com/users/roxspring/following{/other_user}","gists_url":"https://api.github.com/users/roxspring/gists{/gist_id}","starred_url":"https://api.github.com/users/roxspring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roxspring/subscriptions","organizations_url":"https://api.github.com/users/roxspring/orgs","repos_url":"https://api.github.com/users/roxspring/repos","events_url":"https://api.github.com/users/roxspring/events{/privacy}","received_events_url":"https://api.github.com/users/roxspring/received_events","type":"User","site_admin":false},"body":"- Represent paths and pointers using String rather than URI Fragment representation (Basically stripped \"#\" prefix from pointers, knowing that `JsonPointer` doesn't use the prefix)\r\n- Stop assuming that first path might be a pointer, only set pointer explicitly\r\n- Switched from `String` to `JsonPointer` throughout\r\n  - Also switched `JsonSchemaValidator` to report `List<Violation>` rather than it's own `ValidationResult`\r\n- Simplified Violation creation: \r\n  - `context.violation(\"API Audience must be provided\")` creates a `Violation` pointing at the current location\r\n  - `context.violation(\"Operations should use specific HTTP status codes\", response)` creates a `Violation` pointing at `response`, falling back to the current location.\r\n","created_at":"2018-05-26T07:12:53Z","updated_at":"2018-05-26T08:59:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68a16e086140726a3eb670d260352a18d72f9881","assignee":null,"assignees":[],"requested_reviewers":[{"login":"netme","id":96552,"avatar_url":"https://avatars2.githubusercontent.com/u/96552?v=4","gravatar_id":"","url":"https://api.github.com/users/netme","html_url":"https://github.com/netme","followers_url":"https://api.github.com/users/netme/followers","following_url":"https://api.github.com/users/netme/following{/other_user}","gists_url":"https://api.github.com/users/netme/gists{/gist_id}","starred_url":"https://api.github.com/users/netme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netme/subscriptions","organizations_url":"https://api.github.com/users/netme/orgs","repos_url":"https://api.github.com/users/netme/repos","events_url":"https://api.github.com/users/netme/events{/privacy}","received_events_url":"https://api.github.com/users/netme/received_events","type":"User","site_admin":false},{"login":"maxim-tschumak","id":4802353,"avatar_url":"https://avatars2.githubusercontent.com/u/4802353?v=4","gravatar_id":"","url":"https://api.github.com/users/maxim-tschumak","html_url":"https://github.com/maxim-tschumak","followers_url":"https://api.github.com/users/maxim-tschumak/followers","following_url":"https://api.github.com/users/maxim-tschumak/following{/other_user}","gists_url":"https://api.github.com/users/maxim-tschumak/gists{/gist_id}","starred_url":"https://api.github.com/users/maxim-tschumak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxim-tschumak/subscriptions","organizations_url":"https://api.github.com/users/maxim-tschumak/orgs","repos_url":"https://api.github.com/users/maxim-tschumak/repos","events_url":"https://api.github.com/users/maxim-tschumak/events{/privacy}","received_events_url":"https://api.github.com/users/maxim-tschumak/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando/zally/pulls/721/commits","review_comments_url":"https://api.github.com/repos/zalando/zally/pulls/721/comments","review_comment_url":"https://api.github.com/repos/zalando/zally/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando/zally/issues/721/comments","statuses_url":"https://api.github.com/repos/zalando/zally/statuses/d87d3a082a17117f048cd54a4f25b4006162872e","head":{"label":"roxspring:feature/gh-715-typed-jsonpointer","ref":"feature/gh-715-typed-jsonpointer","sha":"d87d3a082a17117f048cd54a4f25b4006162872e","user":{"login":"roxspring","id":783694,"avatar_url":"https://avatars3.githubusercontent.com/u/783694?v=4","gravatar_id":"","url":"https://api.github.com/users/roxspring","html_url":"https://github.com/roxspring","followers_url":"https://api.github.com/users/roxspring/followers","following_url":"https://api.github.com/users/roxspring/following{/other_user}","gists_url":"https://api.github.com/users/roxspring/gists{/gist_id}","starred_url":"https://api.github.com/users/roxspring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roxspring/subscriptions","organizations_url":"https://api.github.com/users/roxspring/orgs","repos_url":"https://api.github.com/users/roxspring/repos","events_url":"https://api.github.com/users/roxspring/events{/privacy}","received_events_url":"https://api.github.com/users/roxspring/received_events","type":"User","site_admin":false},"repo":{"id":104755604,"name":"zally","full_name":"roxspring/zally","owner":{"login":"roxspring","id":783694,"avatar_url":"https://avatars3.githubusercontent.com/u/783694?v=4","gravatar_id":"","url":"https://api.github.com/users/roxspring","html_url":"https://github.com/roxspring","followers_url":"https://api.github.com/users/roxspring/followers","following_url":"https://api.github.com/users/roxspring/following{/other_user}","gists_url":"https://api.github.com/users/roxspring/gists{/gist_id}","starred_url":"https://api.github.com/users/roxspring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roxspring/subscriptions","organizations_url":"https://api.github.com/users/roxspring/orgs","repos_url":"https://api.github.com/users/roxspring/repos","events_url":"https://api.github.com/users/roxspring/events{/privacy}","received_events_url":"https://api.github.com/users/roxspring/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roxspring/zally","description":"Linter for RESTful APIs","fork":true,"url":"https://api.github.com/repos/roxspring/zally","forks_url":"https://api.github.com/repos/roxspring/zally/forks","keys_url":"https://api.github.com/repos/roxspring/zally/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roxspring/zally/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roxspring/zally/teams","hooks_url":"https://api.github.com/repos/roxspring/zally/hooks","issue_events_url":"https://api.github.com/repos/roxspring/zally/issues/events{/number}","events_url":"https://api.github.com/repos/roxspring/zally/events","assignees_url":"https://api.github.com/repos/roxspring/zally/assignees{/user}","branches_url":"https://api.github.com/repos/roxspring/zally/branches{/branch}","tags_url":"https://api.github.com/repos/roxspring/zally/tags","blobs_url":"https://api.github.com/repos/roxspring/zally/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roxspring/zally/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roxspring/zally/git/refs{/sha}","trees_url":"https://api.github.com/repos/roxspring/zally/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roxspring/zally/statuses/{sha}","languages_url":"https://api.github.com/repos/roxspring/zally/languages","stargazers_url":"https://api.github.com/repos/roxspring/zally/stargazers","contributors_url":"https://api.github.com/repos/roxspring/zally/contributors","subscribers_url":"https://api.github.com/repos/roxspring/zally/subscribers","subscription_url":"https://api.github.com/repos/roxspring/zally/subscription","commits_url":"https://api.github.com/repos/roxspring/zally/commits{/sha}","git_commits_url":"https://api.github.com/repos/roxspring/zally/git/commits{/sha}","comments_url":"https://api.github.com/repos/roxspring/zally/comments{/number}","issue_comment_url":"https://api.github.com/repos/roxspring/zally/issues/comments{/number}","contents_url":"https://api.github.com/repos/roxspring/zally/contents/{+path}","compare_url":"https://api.github.com/repos/roxspring/zally/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roxspring/zally/merges","archive_url":"https://api.github.com/repos/roxspring/zally/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roxspring/zally/downloads","issues_url":"https://api.github.com/repos/roxspring/zally/issues{/number}","pulls_url":"https://api.github.com/repos/roxspring/zally/pulls{/number}","milestones_url":"https://api.github.com/repos/roxspring/zally/milestones{/number}","notifications_url":"https://api.github.com/repos/roxspring/zally/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roxspring/zally/labels{/name}","releases_url":"https://api.github.com/repos/roxspring/zally/releases{/id}","deployments_url":"https://api.github.com/repos/roxspring/zally/deployments","created_at":"2017-09-25T13:46:55Z","updated_at":"2018-04-10T15:03:48Z","pushed_at":"2018-05-26T08:57:17Z","git_url":"git://github.com/roxspring/zally.git","ssh_url":"git@github.com:roxspring/zally.git","clone_url":"https://github.com/roxspring/zally.git","svn_url":"https://github.com/roxspring/zally","homepage":"https://zalando-incubator.github.io/zally","size":7995,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zalando:master","ref":"master","sha":"ed8672454dfba770d68ccfdc167acf1f0ea2c675","user":{"login":"zalando","id":1564818,"avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":76853145,"name":"zally","full_name":"zalando/zally","owner":{"login":"zalando","id":1564818,"avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando/zally","description":"A minimalistic, simple-to-use API linter","fork":false,"url":"https://api.github.com/repos/zalando/zally","forks_url":"https://api.github.com/repos/zalando/zally/forks","keys_url":"https://api.github.com/repos/zalando/zally/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/zally/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/zally/teams","hooks_url":"https://api.github.com/repos/zalando/zally/hooks","issue_events_url":"https://api.github.com/repos/zalando/zally/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/zally/events","assignees_url":"https://api.github.com/repos/zalando/zally/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/zally/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/zally/tags","blobs_url":"https://api.github.com/repos/zalando/zally/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/zally/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/zally/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/zally/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/zally/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/zally/languages","stargazers_url":"https://api.github.com/repos/zalando/zally/stargazers","contributors_url":"https://api.github.com/repos/zalando/zally/contributors","subscribers_url":"https://api.github.com/repos/zalando/zally/subscribers","subscription_url":"https://api.github.com/repos/zalando/zally/subscription","commits_url":"https://api.github.com/repos/zalando/zally/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/zally/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/zally/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/zally/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/zally/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/zally/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/zally/merges","archive_url":"https://api.github.com/repos/zalando/zally/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/zally/downloads","issues_url":"https://api.github.com/repos/zalando/zally/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/zally/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/zally/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/zally/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/zally/labels{/name}","releases_url":"https://api.github.com/repos/zalando/zally/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/zally/deployments","created_at":"2016-12-19T10:38:18Z","updated_at":"2018-05-25T17:14:14Z","pushed_at":"2018-05-26T08:57:19Z","git_url":"git://github.com/zalando/zally.git","ssh_url":"git@github.com:zalando/zally.git","clone_url":"https://github.com/zalando/zally.git","svn_url":"https://github.com/zalando/zally","homepage":"https://zalando.github.io/zally","size":6686,"stargazers_count":148,"watchers_count":148,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":25,"open_issues":40,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando/zally/pulls/721"},"html":{"href":"https://github.com/zalando/zally/pull/721"},"issue":{"href":"https://api.github.com/repos/zalando/zally/issues/721"},"comments":{"href":"https://api.github.com/repos/zalando/zally/issues/721/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando/zally/pulls/721/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando/zally/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando/zally/pulls/721/commits"},"statuses":{"href":"https://api.github.com/repos/zalando/zally/statuses/d87d3a082a17117f048cd54a4f25b4006162872e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"codacy-bot"}}