{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/23003","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/23003/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/23003/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/23003/events","html_url":"https://github.com/mantidproject/mantid/pull/23003","id":342429612,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzMxNTM3","number":23003,"title":"Fix RPATH issues on Ubuntu 18.04","user":{"login":"quantumsteve","id":5920552,"node_id":"MDQ6VXNlcjU5MjA1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/5920552?v=4","gravatar_id":"","url":"https://api.github.com/users/quantumsteve","html_url":"https://github.com/quantumsteve","followers_url":"https://api.github.com/users/quantumsteve/followers","following_url":"https://api.github.com/users/quantumsteve/following{/other_user}","gists_url":"https://api.github.com/users/quantumsteve/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumsteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumsteve/subscriptions","organizations_url":"https://api.github.com/users/quantumsteve/orgs","repos_url":"https://api.github.com/users/quantumsteve/repos","events_url":"https://api.github.com/users/quantumsteve/events{/privacy}","received_events_url":"https://api.github.com/users/quantumsteve/received_events","type":"User","site_admin":false},"labels":[{"id":35408850,"node_id":"MDU6TGFiZWwzNTQwODg1MA==","url":"https://api.github.com/repos/mantidproject/mantid/labels/Priority:%20High","name":"Priority: High","color":"e11d21","default":false},{"id":154208631,"node_id":"MDU6TGFiZWwxNTQyMDg2MzE=","url":"https://api.github.com/repos/mantidproject/mantid/labels/State:%20In%20Progress","name":"State: In Progress","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/67","html_url":"https://github.com/mantidproject/mantid/milestone/67","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/67/labels","id":3113719,"node_id":"MDk6TWlsZXN0b25lMzExMzcxOQ==","number":67,"title":"Release 3.13","description":"Code Freeze: 29th June\r\nBeta Test: 3rd-17th July","creator":{"login":"NickDraper","id":1017173,"node_id":"MDQ6VXNlcjEwMTcxNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":662,"state":"open","created_at":"2018-02-13T15:37:12Z","updated_at":"2018-07-19T09:23:58Z","due_on":"2018-07-23T07:00:00Z","closed_at":null},"comments":3,"created_at":"2018-07-18T17:51:20Z","updated_at":"2018-07-19T12:39:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/23003","html_url":"https://github.com/mantidproject/mantid/pull/23003","diff_url":"https://github.com/mantidproject/mantid/pull/23003.diff","patch_url":"https://github.com/mantidproject/mantid/pull/23003.patch"},"body":"**Description of work.**\r\n\r\nThis changes the `LINUX_INSTALL_RPATH` to match the library's location. For reasons I don't understand, the location of the executable isn't being used on Ubuntu 18.04.\r\n\r\n**Report to:** [user name]/[nobody]. <!--If the original issue was raised by a user they should be named here.-->\r\n\r\n**To test:**\r\n\r\n<!-- Instructions for testing. -->\r\n\r\n1. Build or obtain a .deb package with these changes.\r\n1. Install .deb package on an Ubuntu 18.04 machine\r\n1. Start up MantidPlot and verify there are no warnings about missing libraries\r\n1. Use `ldd` to verify that all shared libraries are found. \r\n\r\nThere is no GitHub issue associated with this pull request.\r\n\r\nDoes this update require release notes?\r\n- [ ] Yes\r\n- [ ] No\r\n<!--\r\nIf yes, edit the file docs/source/release/... \r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [ ] Are the unit tests small and test the class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] Do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/406261998","html_url":"https://github.com/mantidproject/mantid/pull/23003#issuecomment-406261998","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/23003","id":406261998,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjI2MTk5OA==","user":{"login":"peterfpeterson","id":404003,"node_id":"MDQ6VXNlcjQwNDAwMw==","avatar_url":"https://avatars3.githubusercontent.com/u/404003?v=4","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"created_at":"2018-07-19T12:39:57Z","updated_at":"2018-07-19T12:39:57Z","author_association":"MEMBER","body":"We're configuring cmake's `LINUX_INSTALL_RPATH` which looks like the right thing according to [the docs](https://cmake.org/cmake/help/v3.5/variable/CMAKE_INSTALL_RPATH.html)."}}
{"actor":{"display_login":"peterfpeterson"}}