{"action":"created","comment":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/189420039","pull_request_review_id":121603765,"id":189420039,"diff_hunk":"@@ -76,7 +98,7 @@ fn mark_for_change_detection(path: PathBuf) -> PathBuf {\n   path\n }\n \n-fn make_flags(env_script_path: &Path) -> Result<Vec<String>> {\n+fn make_flags(env_script_path: PathBuf) -> Result<Vec<String>> {","path":"src/rust/engine/src/cffi_build.rs","position":57,"original_position":57,"commit_id":"86ffcab7ce1fcefeaa6c9f1aad30c1c15c3460bf","original_commit_id":"86ffcab7ce1fcefeaa6c9f1aad30c1c15c3460bf","user":{"login":"jsirois","id":157586,"avatar_url":"https://avatars1.githubusercontent.com/u/157586?v=4","gravatar_id":"","url":"https://api.github.com/users/jsirois","html_url":"https://github.com/jsirois","followers_url":"https://api.github.com/users/jsirois/followers","following_url":"https://api.github.com/users/jsirois/following{/other_user}","gists_url":"https://api.github.com/users/jsirois/gists{/gist_id}","starred_url":"https://api.github.com/users/jsirois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsirois/subscriptions","organizations_url":"https://api.github.com/users/jsirois/orgs","repos_url":"https://api.github.com/users/jsirois/repos","events_url":"https://api.github.com/users/jsirois/events{/privacy}","received_events_url":"https://api.github.com/users/jsirois/received_events","type":"User","site_admin":false},"body":"Agreed, reverted.","created_at":"2018-05-19T01:03:56Z","updated_at":"2018-05-19T01:03:56Z","html_url":"https://github.com/pantsbuild/pants/pull/5742#discussion_r189420039","pull_request_url":"https://api.github.com/repos/pantsbuild/pants/pulls/5742","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/189420039"},"html":{"href":"https://github.com/pantsbuild/pants/pull/5742#discussion_r189420039"},"pull_request":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5742"}},"in_reply_to_id":185741121},"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/5742","id":183853664,"html_url":"https://github.com/pantsbuild/pants/pull/5742","diff_url":"https://github.com/pantsbuild/pants/pull/5742.diff","patch_url":"https://github.com/pantsbuild/pants/pull/5742.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/5742","number":5742,"state":"open","locked":false,"title":"Hermeticize cargo build.","user":{"login":"jsirois","id":157586,"avatar_url":"https://avatars1.githubusercontent.com/u/157586?v=4","gravatar_id":"","url":"https://api.github.com/users/jsirois","html_url":"https://github.com/jsirois","followers_url":"https://api.github.com/users/jsirois/followers","following_url":"https://api.github.com/users/jsirois/following{/other_user}","gists_url":"https://api.github.com/users/jsirois/gists{/gist_id}","starred_url":"https://api.github.com/users/jsirois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsirois/subscriptions","organizations_url":"https://api.github.com/users/jsirois/orgs","repos_url":"https://api.github.com/users/jsirois/repos","events_url":"https://api.github.com/users/jsirois/events{/privacy}","received_events_url":"https://api.github.com/users/jsirois/received_events","type":"User","site_admin":false},"body":"The cargo build is now hermetic in order to be transparent to\r\nbuild tools like IDEA. Using the links in `build-support/bin/native`\r\nlike `cargo`, `rustdoc` and `rustfmt` to operate directly on the\r\nmodules in `src/rust/engine` works as one would expect of the\r\ncorresponding cargo tools.","created_at":"2018-04-24T20:24:49Z","updated_at":"2018-05-19T01:03:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a14694ca0e0a4ef5f0f3b87c18d2416516f2cac","assignee":null,"assignees":[],"requested_reviewers":[{"login":"baroquebobcat","id":7378,"avatar_url":"https://avatars0.githubusercontent.com/u/7378?v=4","gravatar_id":"","url":"https://api.github.com/users/baroquebobcat","html_url":"https://github.com/baroquebobcat","followers_url":"https://api.github.com/users/baroquebobcat/followers","following_url":"https://api.github.com/users/baroquebobcat/following{/other_user}","gists_url":"https://api.github.com/users/baroquebobcat/gists{/gist_id}","starred_url":"https://api.github.com/users/baroquebobcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baroquebobcat/subscriptions","organizations_url":"https://api.github.com/users/baroquebobcat/orgs","repos_url":"https://api.github.com/users/baroquebobcat/repos","events_url":"https://api.github.com/users/baroquebobcat/events{/privacy}","received_events_url":"https://api.github.com/users/baroquebobcat/received_events","type":"User","site_admin":false},{"login":"ity","id":1278541,"avatar_url":"https://avatars3.githubusercontent.com/u/1278541?v=4","gravatar_id":"","url":"https://api.github.com/users/ity","html_url":"https://github.com/ity","followers_url":"https://api.github.com/users/ity/followers","following_url":"https://api.github.com/users/ity/following{/other_user}","gists_url":"https://api.github.com/users/ity/gists{/gist_id}","starred_url":"https://api.github.com/users/ity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ity/subscriptions","organizations_url":"https://api.github.com/users/ity/orgs","repos_url":"https://api.github.com/users/ity/repos","events_url":"https://api.github.com/users/ity/events{/privacy}","received_events_url":"https://api.github.com/users/ity/received_events","type":"User","site_admin":false},{"login":"cosmicexplorer","id":1305167,"avatar_url":"https://avatars1.githubusercontent.com/u/1305167?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmicexplorer","html_url":"https://github.com/cosmicexplorer","followers_url":"https://api.github.com/users/cosmicexplorer/followers","following_url":"https://api.github.com/users/cosmicexplorer/following{/other_user}","gists_url":"https://api.github.com/users/cosmicexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmicexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmicexplorer/subscriptions","organizations_url":"https://api.github.com/users/cosmicexplorer/orgs","repos_url":"https://api.github.com/users/cosmicexplorer/repos","events_url":"https://api.github.com/users/cosmicexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/cosmicexplorer/received_events","type":"User","site_admin":false},{"login":"dotordogh","id":28027359,"avatar_url":"https://avatars2.githubusercontent.com/u/28027359?v=4","gravatar_id":"","url":"https://api.github.com/users/dotordogh","html_url":"https://github.com/dotordogh","followers_url":"https://api.github.com/users/dotordogh/followers","following_url":"https://api.github.com/users/dotordogh/following{/other_user}","gists_url":"https://api.github.com/users/dotordogh/gists{/gist_id}","starred_url":"https://api.github.com/users/dotordogh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotordogh/subscriptions","organizations_url":"https://api.github.com/users/dotordogh/orgs","repos_url":"https://api.github.com/users/dotordogh/repos","events_url":"https://api.github.com/users/dotordogh/events{/privacy}","received_events_url":"https://api.github.com/users/dotordogh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/5742/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/5742/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/5742/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/86ffcab7ce1fcefeaa6c9f1aad30c1c15c3460bf","head":{"label":"jsirois:issues/4558/rust_toolchain","ref":"issues/4558/rust_toolchain","sha":"86ffcab7ce1fcefeaa6c9f1aad30c1c15c3460bf","user":{"login":"jsirois","id":157586,"avatar_url":"https://avatars1.githubusercontent.com/u/157586?v=4","gravatar_id":"","url":"https://api.github.com/users/jsirois","html_url":"https://github.com/jsirois","followers_url":"https://api.github.com/users/jsirois/followers","following_url":"https://api.github.com/users/jsirois/following{/other_user}","gists_url":"https://api.github.com/users/jsirois/gists{/gist_id}","starred_url":"https://api.github.com/users/jsirois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsirois/subscriptions","organizations_url":"https://api.github.com/users/jsirois/orgs","repos_url":"https://api.github.com/users/jsirois/repos","events_url":"https://api.github.com/users/jsirois/events{/privacy}","received_events_url":"https://api.github.com/users/jsirois/received_events","type":"User","site_admin":false},"repo":{"id":19150258,"name":"pants","full_name":"jsirois/pants","owner":{"login":"jsirois","id":157586,"avatar_url":"https://avatars1.githubusercontent.com/u/157586?v=4","gravatar_id":"","url":"https://api.github.com/users/jsirois","html_url":"https://github.com/jsirois","followers_url":"https://api.github.com/users/jsirois/followers","following_url":"https://api.github.com/users/jsirois/following{/other_user}","gists_url":"https://api.github.com/users/jsirois/gists{/gist_id}","starred_url":"https://api.github.com/users/jsirois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsirois/subscriptions","organizations_url":"https://api.github.com/users/jsirois/orgs","repos_url":"https://api.github.com/users/jsirois/repos","events_url":"https://api.github.com/users/jsirois/events{/privacy}","received_events_url":"https://api.github.com/users/jsirois/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsirois/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/jsirois/pants","forks_url":"https://api.github.com/repos/jsirois/pants/forks","keys_url":"https://api.github.com/repos/jsirois/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsirois/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsirois/pants/teams","hooks_url":"https://api.github.com/repos/jsirois/pants/hooks","issue_events_url":"https://api.github.com/repos/jsirois/pants/issues/events{/number}","events_url":"https://api.github.com/repos/jsirois/pants/events","assignees_url":"https://api.github.com/repos/jsirois/pants/assignees{/user}","branches_url":"https://api.github.com/repos/jsirois/pants/branches{/branch}","tags_url":"https://api.github.com/repos/jsirois/pants/tags","blobs_url":"https://api.github.com/repos/jsirois/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsirois/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsirois/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsirois/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsirois/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/jsirois/pants/languages","stargazers_url":"https://api.github.com/repos/jsirois/pants/stargazers","contributors_url":"https://api.github.com/repos/jsirois/pants/contributors","subscribers_url":"https://api.github.com/repos/jsirois/pants/subscribers","subscription_url":"https://api.github.com/repos/jsirois/pants/subscription","commits_url":"https://api.github.com/repos/jsirois/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsirois/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsirois/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsirois/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsirois/pants/contents/{+path}","compare_url":"https://api.github.com/repos/jsirois/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsirois/pants/merges","archive_url":"https://api.github.com/repos/jsirois/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsirois/pants/downloads","issues_url":"https://api.github.com/repos/jsirois/pants/issues{/number}","pulls_url":"https://api.github.com/repos/jsirois/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/jsirois/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/jsirois/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsirois/pants/labels{/name}","releases_url":"https://api.github.com/repos/jsirois/pants/releases{/id}","deployments_url":"https://api.github.com/repos/jsirois/pants/deployments","created_at":"2014-04-25T15:11:53Z","updated_at":"2018-05-16T18:48:47Z","pushed_at":"2018-05-19T00:28:42Z","git_url":"git://github.com/jsirois/pants.git","ssh_url":"git@github.com:jsirois/pants.git","clone_url":"https://github.com/jsirois/pants.git","svn_url":"https://github.com/jsirois/pants","homepage":"http://pantsbuild.github.io/","size":83814,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"9e2fdb591a3540fb04350fe5548a4068208f9c82","user":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"name":"pants","full_name":"pantsbuild/pants","owner":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantsbuild/pants","description":"The Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","deployments_url":"https://api.github.com/repos/pantsbuild/pants/deployments","created_at":"2012-12-17T17:39:04Z","updated_at":"2018-05-19T00:19:39Z","pushed_at":"2018-05-19T00:28:44Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"git@github.com:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.org/","size":83999,"stargazers_count":953,"watchers_count":953,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":614,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":273,"open_issues":614,"watchers":953,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5742"},"html":{"href":"https://github.com/pantsbuild/pants/pull/5742"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/5742"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/5742/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5742/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5742/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/86ffcab7ce1fcefeaa6c9f1aad30c1c15c3460bf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jsirois"}}