{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/212276718","pull_request_review_id":148870573,"id":212276718,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjI3NjcxOA==","diff_hunk":"@@ -113,5 +114,5 @@ def test_compare_scalar(self, data, all_compare_operators):\n     def test_compare_array(self, data, all_compare_operators):\n         op_name = all_compare_operators\n         s = pd.Series(data)\n-        other = [0] * len(data)\n+        other = pd.Series([data[0]] * len(data))","path":"pandas/tests/extension/base/ops.py","position":27,"original_position":27,"commit_id":"edcb3dad0e116b81396f29fbb0bacc77c3e6c710","original_commit_id":"edcb3dad0e116b81396f29fbb0bacc77c3e6c710","user":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"body":"In addition, I change here also `[0]` to `[data[0]]`, because `0` is not necessarily valid for all extension arrays","created_at":"2018-08-23T11:43:37Z","updated_at":"2018-08-23T11:51:34Z","html_url":"https://github.com/pandas-dev/pandas/pull/22026#discussion_r212276718","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22026","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/212276718"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/22026#discussion_r212276718"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22026"}},"in_reply_to_id":212253565},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22026","id":203247958,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMjQ3OTU4","html_url":"https://github.com/pandas-dev/pandas/pull/22026","diff_url":"https://github.com/pandas-dev/pandas/pull/22026.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/22026.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22026","number":22026,"state":"open","locked":false,"title":"TST: restructure internal extension arrays tests (split between /arrays and /extension)","user":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"body":"Pull request to discuss what to do with the tests for internal EAs (and one of the comments I still had in https://github.com/pandas-dev/pandas/pull/21160)\r\n\r\nBasically, I would keep the `tests/extension/..` only for subclassing the base extension array test suite, and any array-specific functionality is tested in `tests/arrays/..` (eg closed attribute for IntervalArray, specific arithmetic behaviour for IntegerArray, ...)\r\n\r\nThis means that when adding a test related to EAs, we need to think about: is this testing something that is applicable to all EAs? (-> add a base test to `tests/extension/base` so this is tested for all internal and external EAs) or is this testing something specific to a particular EA? (-> add a test in `tests/array/EAtype/..`) \r\nOf course often there can be some ambiguity here.\r\n\r\nMain reason that I would split them is that over time, we probably add a lot of EA-type-specific tests, and then keeping the general ones mixed with the specific ones will make it only confusing / hard to see what is going on. Drawback is of course that it is tested in two places. \r\nIn practice what I propose in this PR, is also what we already do for Categorical at the moment: Categorical has its own tests in `tests/arrays/categorical` (and probably also some in `indexes` and `frame`, ..), but we also run the base extension tests for Categorical in `tests/extension/`","created_at":"2018-07-23T14:59:48Z","updated_at":"2018-08-23T11:51:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e227c4b1b93667c2a16b28ec293fecf24e8a43f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":849023693,"node_id":"MDU6TGFiZWw4NDkwMjM2OTM=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/ExtensionArray","name":"ExtensionArray","color":"6138b5","default":false},{"id":127685,"node_id":"MDU6TGFiZWwxMjc2ODU=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Testing","name":"Testing","color":"C4A000","default":false}],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/55","html_url":"https://github.com/pandas-dev/pandas/milestone/55","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/55/labels","id":3228419,"node_id":"MDk6TWlsZXN0b25lMzIyODQxOQ==","number":55,"title":"0.24.0","description":"","creator":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"open_issues":144,"closed_issues":543,"state":"open","created_at":"2018-03-29T12:00:12Z","updated_at":"2018-08-23T10:53:44Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22026/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22026/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22026/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/edcb3dad0e116b81396f29fbb0bacc77c3e6c710","head":{"label":"jorisvandenbossche:restructure-array-testing","ref":"restructure-array-testing","sha":"edcb3dad0e116b81396f29fbb0bacc77c3e6c710","user":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"repo":{"id":9969996,"node_id":"MDEwOlJlcG9zaXRvcnk5OTY5OTk2","name":"pandas","full_name":"jorisvandenbossche/pandas","owner":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jorisvandenbossche/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/jorisvandenbossche/pandas","forks_url":"https://api.github.com/repos/jorisvandenbossche/pandas/forks","keys_url":"https://api.github.com/repos/jorisvandenbossche/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jorisvandenbossche/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jorisvandenbossche/pandas/teams","hooks_url":"https://api.github.com/repos/jorisvandenbossche/pandas/hooks","issue_events_url":"https://api.github.com/repos/jorisvandenbossche/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/jorisvandenbossche/pandas/events","assignees_url":"https://api.github.com/repos/jorisvandenbossche/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/jorisvandenbossche/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/jorisvandenbossche/pandas/tags","blobs_url":"https://api.github.com/repos/jorisvandenbossche/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jorisvandenbossche/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jorisvandenbossche/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/jorisvandenbossche/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jorisvandenbossche/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/jorisvandenbossche/pandas/languages","stargazers_url":"https://api.github.com/repos/jorisvandenbossche/pandas/stargazers","contributors_url":"https://api.github.com/repos/jorisvandenbossche/pandas/contributors","subscribers_url":"https://api.github.com/repos/jorisvandenbossche/pandas/subscribers","subscription_url":"https://api.github.com/repos/jorisvandenbossche/pandas/subscription","commits_url":"https://api.github.com/repos/jorisvandenbossche/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/jorisvandenbossche/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/jorisvandenbossche/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/jorisvandenbossche/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/jorisvandenbossche/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/jorisvandenbossche/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jorisvandenbossche/pandas/merges","archive_url":"https://api.github.com/repos/jorisvandenbossche/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jorisvandenbossche/pandas/downloads","issues_url":"https://api.github.com/repos/jorisvandenbossche/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/jorisvandenbossche/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/jorisvandenbossche/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/jorisvandenbossche/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jorisvandenbossche/pandas/labels{/name}","releases_url":"https://api.github.com/repos/jorisvandenbossche/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/jorisvandenbossche/pandas/deployments","created_at":"2013-05-09T22:38:31Z","updated_at":"2018-07-29T10:36:36Z","pushed_at":"2018-08-23T08:38:12Z","git_url":"git://github.com/jorisvandenbossche/pandas.git","ssh_url":"git@github.com:jorisvandenbossche/pandas.git","clone_url":"https://github.com/jorisvandenbossche/pandas.git","svn_url":"https://github.com/jorisvandenbossche/pandas","homepage":"http://pandas.pydata.org","size":129514,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"2be2ba570453ab09f0c8da46dfd8e1a179771fee","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-08-23T11:08:01Z","pushed_at":"2018-08-23T10:51:50Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":129793,"stargazers_count":15694,"watchers_count":15694,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6314,"mirror_url":null,"archived":false,"open_issues_count":2736,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6314,"open_issues":2736,"watchers":15694,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22026"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/22026"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/22026"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/22026/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22026/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22026/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/edcb3dad0e116b81396f29fbb0bacc77c3e6c710"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jorisvandenbossche"}}