{"action":"closed","number":629,"pull_request":{"url":"https://api.github.com/repos/hughsie/fwupd/pulls/629","id":206967708,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2OTY3NzA4","html_url":"https://github.com/hughsie/fwupd/pull/629","diff_url":"https://github.com/hughsie/fwupd/pull/629.diff","patch_url":"https://github.com/hughsie/fwupd/pull/629.patch","issue_url":"https://api.github.com/repos/hughsie/fwupd/issues/629","number":629,"state":"closed","locked":false,"title":"uefi: Check the user-supplied ESP path","user":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"body":"Additionally, if the user specified something invalid, do not autodetect the\r\nESP but return with a journal error. It seems wrong to ignore what the user\r\nexplicitly set and perhaps do something dangerous.\r\n\r\nAlternative to https://github.com/hughsie/fwupd/pull/599","created_at":"2018-08-08T10:52:45Z","updated_at":"2018-08-08T19:35:05Z","closed_at":"2018-08-08T19:35:05Z","merged_at":"2018-08-08T19:35:05Z","merge_commit_sha":"03aead9fe7dfd1bae90467f7ec2c724a017bbdba","assignee":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"assignees":[{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hughsie/fwupd/pulls/629/commits","review_comments_url":"https://api.github.com/repos/hughsie/fwupd/pulls/629/comments","review_comment_url":"https://api.github.com/repos/hughsie/fwupd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hughsie/fwupd/issues/629/comments","statuses_url":"https://api.github.com/repos/hughsie/fwupd/statuses/86dc3ab7107c8e6da5efbd8a991b02fd5201552a","head":{"label":"hughsie:wip/hughsie/check-user-supplied-esp-path","ref":"wip/hughsie/check-user-supplied-esp-path","sha":"86dc3ab7107c8e6da5efbd8a991b02fd5201552a","user":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"repo":{"id":31374735,"node_id":"MDEwOlJlcG9zaXRvcnkzMTM3NDczNQ==","name":"fwupd","full_name":"hughsie/fwupd","owner":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hughsie/fwupd","description":"A simple daemon to allow session software to update firmware","fork":false,"url":"https://api.github.com/repos/hughsie/fwupd","forks_url":"https://api.github.com/repos/hughsie/fwupd/forks","keys_url":"https://api.github.com/repos/hughsie/fwupd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughsie/fwupd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughsie/fwupd/teams","hooks_url":"https://api.github.com/repos/hughsie/fwupd/hooks","issue_events_url":"https://api.github.com/repos/hughsie/fwupd/issues/events{/number}","events_url":"https://api.github.com/repos/hughsie/fwupd/events","assignees_url":"https://api.github.com/repos/hughsie/fwupd/assignees{/user}","branches_url":"https://api.github.com/repos/hughsie/fwupd/branches{/branch}","tags_url":"https://api.github.com/repos/hughsie/fwupd/tags","blobs_url":"https://api.github.com/repos/hughsie/fwupd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughsie/fwupd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughsie/fwupd/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughsie/fwupd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughsie/fwupd/statuses/{sha}","languages_url":"https://api.github.com/repos/hughsie/fwupd/languages","stargazers_url":"https://api.github.com/repos/hughsie/fwupd/stargazers","contributors_url":"https://api.github.com/repos/hughsie/fwupd/contributors","subscribers_url":"https://api.github.com/repos/hughsie/fwupd/subscribers","subscription_url":"https://api.github.com/repos/hughsie/fwupd/subscription","commits_url":"https://api.github.com/repos/hughsie/fwupd/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughsie/fwupd/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughsie/fwupd/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughsie/fwupd/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughsie/fwupd/contents/{+path}","compare_url":"https://api.github.com/repos/hughsie/fwupd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughsie/fwupd/merges","archive_url":"https://api.github.com/repos/hughsie/fwupd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughsie/fwupd/downloads","issues_url":"https://api.github.com/repos/hughsie/fwupd/issues{/number}","pulls_url":"https://api.github.com/repos/hughsie/fwupd/pulls{/number}","milestones_url":"https://api.github.com/repos/hughsie/fwupd/milestones{/number}","notifications_url":"https://api.github.com/repos/hughsie/fwupd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughsie/fwupd/labels{/name}","releases_url":"https://api.github.com/repos/hughsie/fwupd/releases{/id}","deployments_url":"https://api.github.com/repos/hughsie/fwupd/deployments","created_at":"2015-02-26T15:52:25Z","updated_at":"2018-08-08T19:16:57Z","pushed_at":"2018-08-08T19:35:05Z","git_url":"git://github.com/hughsie/fwupd.git","ssh_url":"git@github.com:hughsie/fwupd.git","clone_url":"https://github.com/hughsie/fwupd.git","svn_url":"https://github.com/hughsie/fwupd","homepage":"","size":7978,"stargazers_count":345,"watchers_count":345,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":75,"open_issues":27,"watchers":345,"default_branch":"master"}},"base":{"label":"hughsie:master","ref":"master","sha":"69a5f3587be647971f4b4001205bee053f28f00f","user":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"repo":{"id":31374735,"node_id":"MDEwOlJlcG9zaXRvcnkzMTM3NDczNQ==","name":"fwupd","full_name":"hughsie/fwupd","owner":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hughsie/fwupd","description":"A simple daemon to allow session software to update firmware","fork":false,"url":"https://api.github.com/repos/hughsie/fwupd","forks_url":"https://api.github.com/repos/hughsie/fwupd/forks","keys_url":"https://api.github.com/repos/hughsie/fwupd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughsie/fwupd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughsie/fwupd/teams","hooks_url":"https://api.github.com/repos/hughsie/fwupd/hooks","issue_events_url":"https://api.github.com/repos/hughsie/fwupd/issues/events{/number}","events_url":"https://api.github.com/repos/hughsie/fwupd/events","assignees_url":"https://api.github.com/repos/hughsie/fwupd/assignees{/user}","branches_url":"https://api.github.com/repos/hughsie/fwupd/branches{/branch}","tags_url":"https://api.github.com/repos/hughsie/fwupd/tags","blobs_url":"https://api.github.com/repos/hughsie/fwupd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughsie/fwupd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughsie/fwupd/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughsie/fwupd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughsie/fwupd/statuses/{sha}","languages_url":"https://api.github.com/repos/hughsie/fwupd/languages","stargazers_url":"https://api.github.com/repos/hughsie/fwupd/stargazers","contributors_url":"https://api.github.com/repos/hughsie/fwupd/contributors","subscribers_url":"https://api.github.com/repos/hughsie/fwupd/subscribers","subscription_url":"https://api.github.com/repos/hughsie/fwupd/subscription","commits_url":"https://api.github.com/repos/hughsie/fwupd/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughsie/fwupd/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughsie/fwupd/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughsie/fwupd/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughsie/fwupd/contents/{+path}","compare_url":"https://api.github.com/repos/hughsie/fwupd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughsie/fwupd/merges","archive_url":"https://api.github.com/repos/hughsie/fwupd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughsie/fwupd/downloads","issues_url":"https://api.github.com/repos/hughsie/fwupd/issues{/number}","pulls_url":"https://api.github.com/repos/hughsie/fwupd/pulls{/number}","milestones_url":"https://api.github.com/repos/hughsie/fwupd/milestones{/number}","notifications_url":"https://api.github.com/repos/hughsie/fwupd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughsie/fwupd/labels{/name}","releases_url":"https://api.github.com/repos/hughsie/fwupd/releases{/id}","deployments_url":"https://api.github.com/repos/hughsie/fwupd/deployments","created_at":"2015-02-26T15:52:25Z","updated_at":"2018-08-08T19:16:57Z","pushed_at":"2018-08-08T19:35:05Z","git_url":"git://github.com/hughsie/fwupd.git","ssh_url":"git@github.com:hughsie/fwupd.git","clone_url":"https://github.com/hughsie/fwupd.git","svn_url":"https://github.com/hughsie/fwupd","homepage":"","size":7978,"stargazers_count":345,"watchers_count":345,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":75,"open_issues":27,"watchers":345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hughsie/fwupd/pulls/629"},"html":{"href":"https://github.com/hughsie/fwupd/pull/629"},"issue":{"href":"https://api.github.com/repos/hughsie/fwupd/issues/629"},"comments":{"href":"https://api.github.com/repos/hughsie/fwupd/issues/629/comments"},"review_comments":{"href":"https://api.github.com/repos/hughsie/fwupd/pulls/629/comments"},"review_comment":{"href":"https://api.github.com/repos/hughsie/fwupd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hughsie/fwupd/pulls/629/commits"},"statuses":{"href":"https://api.github.com/repos/hughsie/fwupd/statuses/86dc3ab7107c8e6da5efbd8a991b02fd5201552a"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hughsie","id":151380,"node_id":"MDQ6VXNlcjE1MTM4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"comments":7,"review_comments":4,"maintainer_can_modify":false,"commits":2,"additions":56,"deletions":16,"changed_files":4}}
{"actor":{"display_login":"hughsie"}}