{"action":"created","issue":{"url":"https://api.github.com/repos/jjxtra/ExchangeSharp/issues/196","repository_url":"https://api.github.com/repos/jjxtra/ExchangeSharp","labels_url":"https://api.github.com/repos/jjxtra/ExchangeSharp/issues/196/labels{/name}","comments_url":"https://api.github.com/repos/jjxtra/ExchangeSharp/issues/196/comments","events_url":"https://api.github.com/repos/jjxtra/ExchangeSharp/issues/196/events","html_url":"https://github.com/jjxtra/ExchangeSharp/pull/196","id":336785969,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTU3OTM3","number":196,"title":"Implement order book delta socket for Bittrex","user":{"login":"bichuga","id":9372553,"node_id":"MDQ6VXNlcjkzNzI1NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9372553?v=4","gravatar_id":"","url":"https://api.github.com/users/bichuga","html_url":"https://github.com/bichuga","followers_url":"https://api.github.com/users/bichuga/followers","following_url":"https://api.github.com/users/bichuga/following{/other_user}","gists_url":"https://api.github.com/users/bichuga/gists{/gist_id}","starred_url":"https://api.github.com/users/bichuga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bichuga/subscriptions","organizations_url":"https://api.github.com/users/bichuga/orgs","repos_url":"https://api.github.com/users/bichuga/repos","events_url":"https://api.github.com/users/bichuga/events{/privacy}","received_events_url":"https://api.github.com/users/bichuga/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-28T21:26:38Z","updated_at":"2018-06-28T22:09:07Z","closed_at":"2018-06-28T21:32:20Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jjxtra/ExchangeSharp/pulls/196","html_url":"https://github.com/jjxtra/ExchangeSharp/pull/196","diff_url":"https://github.com/jjxtra/ExchangeSharp/pull/196.diff","patch_url":"https://github.com/jjxtra/ExchangeSharp/pull/196.patch"},"body":"Since this is a very high traffic websocket, I wanted real objects to parse the JSON into. I borrowed these from [bittrex.net](https://github.com/JKorf/Bittrex.Net).\r\n\r\nA couple notes: I don't love that these model object classes are all in one giant file. It was also confusing to navigate the ExchangeBittrexApi.cs file that has the exchange implementation classes as well as the various websocket classes. Please accept my vote to split each of these classes out into their own files or reorganize this in some way. \r\n\r\nRelated: I approve of the refactoring you did around GetExchangeOrderBookDeltas. Including the symbol and sequence number in the order book itself makes things way cleaner. 👍"},"comment":{"url":"https://api.github.com/repos/jjxtra/ExchangeSharp/issues/comments/401188376","html_url":"https://github.com/jjxtra/ExchangeSharp/pull/196#issuecomment-401188376","issue_url":"https://api.github.com/repos/jjxtra/ExchangeSharp/issues/196","id":401188376,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTE4ODM3Ng==","user":{"login":"jjxtra","id":1271832,"node_id":"MDQ6VXNlcjEyNzE4MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/1271832?v=4","gravatar_id":"","url":"https://api.github.com/users/jjxtra","html_url":"https://github.com/jjxtra","followers_url":"https://api.github.com/users/jjxtra/followers","following_url":"https://api.github.com/users/jjxtra/following{/other_user}","gists_url":"https://api.github.com/users/jjxtra/gists{/gist_id}","starred_url":"https://api.github.com/users/jjxtra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjxtra/subscriptions","organizations_url":"https://api.github.com/users/jjxtra/orgs","repos_url":"https://api.github.com/users/jjxtra/repos","events_url":"https://api.github.com/users/jjxtra/events{/privacy}","received_events_url":"https://api.github.com/users/jjxtra/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T22:09:07Z","updated_at":"2018-06-28T22:09:07Z","author_association":"OWNER","body":"I re-organized the files and did some code cleanup. Each exchange is in their own folder, with model objects and helper classes underneath a partial class for the exchange class. Let me know what you think."}}
{"actor":{"display_login":"jjxtra"}}