{"action":"created","issue":{"url":"https://api.github.com/repos/gcp/leela-zero/issues/968","repository_url":"https://api.github.com/repos/gcp/leela-zero","labels_url":"https://api.github.com/repos/gcp/leela-zero/issues/968/labels{/name}","comments_url":"https://api.github.com/repos/gcp/leela-zero/issues/968/comments","events_url":"https://api.github.com/repos/gcp/leela-zero/issues/968/events","html_url":"https://github.com/gcp/leela-zero/pull/968","id":302019174,"number":968,"title":"Stop visiting doomed root children","user":{"login":"TFiFiE","id":20996278,"avatar_url":"https://avatars1.githubusercontent.com/u/20996278?v=4","gravatar_id":"","url":"https://api.github.com/users/TFiFiE","html_url":"https://github.com/TFiFiE","followers_url":"https://api.github.com/users/TFiFiE/followers","following_url":"https://api.github.com/users/TFiFiE/following{/other_user}","gists_url":"https://api.github.com/users/TFiFiE/gists{/gist_id}","starred_url":"https://api.github.com/users/TFiFiE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TFiFiE/subscriptions","organizations_url":"https://api.github.com/users/TFiFiE/orgs","repos_url":"https://api.github.com/users/TFiFiE/repos","events_url":"https://api.github.com/users/TFiFiE/events{/privacy}","received_events_url":"https://api.github.com/users/TFiFiE/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-03T18:06:37Z","updated_at":"2018-03-04T00:28:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gcp/leela-zero/pulls/968","html_url":"https://github.com/gcp/leela-zero/pull/968","diff_url":"https://github.com/gcp/leela-zero/pull/968.diff","patch_url":"https://github.com/gcp/leela-zero/pull/968.patch"},"body":"This generalizes the time management code such that it stops visiting any root child the moment it can no longer overtake the current best. Might provide a slight speed and/or performance boost."},"comment":{"url":"https://api.github.com/repos/gcp/leela-zero/issues/comments/370191439","html_url":"https://github.com/gcp/leela-zero/pull/968#issuecomment-370191439","issue_url":"https://api.github.com/repos/gcp/leela-zero/issues/968","id":370191439,"user":{"login":"wctgit","id":35663187,"avatar_url":"https://avatars1.githubusercontent.com/u/35663187?v=4","gravatar_id":"","url":"https://api.github.com/users/wctgit","html_url":"https://github.com/wctgit","followers_url":"https://api.github.com/users/wctgit/followers","following_url":"https://api.github.com/users/wctgit/following{/other_user}","gists_url":"https://api.github.com/users/wctgit/gists{/gist_id}","starred_url":"https://api.github.com/users/wctgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wctgit/subscriptions","organizations_url":"https://api.github.com/users/wctgit/orgs","repos_url":"https://api.github.com/users/wctgit/repos","events_url":"https://api.github.com/users/wctgit/events{/privacy}","received_events_url":"https://api.github.com/users/wctgit/received_events","type":"User","site_admin":false},"created_at":"2018-03-04T00:28:24Z","updated_at":"2018-03-04T00:28:24Z","author_association":"NONE","body":"Nice. Does it work solely based on time (via playout_rate) or can it also work with -p 8000 or -v 80000? In other words, if you specify -v 80000, with no time controls, will it always (by default) use all 80000 visits, or do time controls have to be in place first? I read through the changes, but I'm not familiar enough with the codebase to draw this particular conclusion. It looks to me like it only works when time controls are set, and only takes those time controls into consideration, without considering -v 80000 or whatever. [The key game which caused me to suggest this was https://online-go.com/game/11845631 (from https://github.com/gcp/leela-zero/issues/946#issue-300802223), which seemed like LZ had lots of extra time available, but simply wouldn't use up all 80,000 visits which were specified with the -v option. Just want to know if this change would 'fix' that kind of game or if it only comes into play when time is running low.]"}}
{"actor":{"display_login":"wctgit"}}