{"push_id":2486663532,"size":21,"distinct_size":20,"ref":"refs/heads/master","head":"e76acf3384aca13cd2dd850568317c0ce44458ed","before":"39439e5ab4195bb1abebd2c8b1ac702bc33c2e60","commits":[{"sha":"cba2800e8c4e73c2eddff76880b55d930c5010f6","author":{"name":"practicalswift","email":"4a57785b02e7b752fc2eb7d1c97db94302a41bf7@users.noreply.github.com"},"message":"Increase signal-to-noise ratio in debug.log by adjusting log level when logging failed non-manual connect():s\n\nBefore this patch:\n\n```\n$ src/bitcoind -printtoconsole\n…\n2018-02-28 18:42:51 UpdateTip: new best=0000000000005448b10a219683d34b770a28044e1cc421032dea1a79ff548948 height=1286903 version=0x20000000 log2_work=69.791313 tx=17408546 date='2018-02-28 18:42:46' progress=1.000000 cache=0.0MiB(173txo)\n2018-02-28T18:37:52Z connect() 10.11.21.34:18333 failed after select(): Connection refused (111)\n2018-02-28 18:43:22 connect() to 10.11.43.14:18333 failed after select(): Network is unreachable (101)\n2018-02-28 18:44:49 UpdateTip: new best=000000000000029a521ff2803e1441b09413b876accff5084a4cccf7747d798b height=1286904 version=0x20000000 log2_work=69.791345 tx=17408559 date='2018-02-28 18:44:51' progress=1.000000 cache=0.1MiB(502txo)\n2018-02-28 18:46:54 connect() to [2001:0:9d38:78ff:1234:1234:1234:1234]:18333 failed: Network is unreachable (101)\n2018-02-28 18:48:56 connect() to [2001:0:9d38:6aff:1234:1234:1234:1234]:18333 failed: Network is unreachable (101)\n2018-02-28 18:49:11 UpdateTip: new best=000000000000000206b79eb235e5dd907b6369de0e5d764330bf40ec0d460311 height=1286905 version=0x20000000 log2_work=69.791377 tx=17408577 date='2018-02-28 18:49:12' progress=1.000000 cache=1.0MiB(5245txo)\n```\n\nAfter this patch:\n\n```\n$ src/bitcoind -printtoconsole\n…\n2018-02-28 18:42:51 UpdateTip: new best=0000000000005448b10a219683d34b770a28044e1cc421032dea1a79ff548948 height=1286903 version=0x20000000 log2_work=69.791313 tx=17408546 date='2018-02-28 18:42:46' progress=1.000000 cache=0.0MiB(173txo)\n2018-02-28 18:44:49 UpdateTip: new best=000000000000029a521ff2803e1441b09413b876accff5084a4cccf7747d798b height=1286904 version=0x20000000 log2_work=69.791345 tx=17408559 date='2018-02-28 18:44:51' progress=1.000000 cache=0.1MiB(502txo)\n2018-02-28 18:49:11 UpdateTip: new best=000000000000000206b79eb235e5dd907b6369de0e5d764330bf40ec0d460311 height=1286905 version=0x20000000 log2_work=69.791377 tx=17408577 date='2018-02-28 18:49:12' progress=1.000000 cache=1.0MiB(5245txo)\n```\n\nPlease note that \"manual connect():s\" (invoked via `-connect`, `-proxy` or `addnode`) are still reported as usual:\n\n```\n$ src/bitcoind -printtoconsole -connect=10.11.12.13\n…\n2018-02-28 18:33:13 connect() to 10.11.12.13:18333 failed after select(): Connection refused (111)\n$ src/bitcoind -printtoconsole -proxy=10.11.12.13\n…\n2018-02-28 18:32:32 connect() to 10.11.12.13:9050 failed after select(): Connection refused (111)\n$ src/bitcoind -printtoconsole &\n$ src/bitcoin-cli addnode \"10.11.12.13\" onetry\n…\n2018-02-28 18:34:40 connect() to 10.11.12.13:18333 failed after select(): Connection refused (111)\n```","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/cba2800e8c4e73c2eddff76880b55d930c5010f6"},{"sha":"45dd13503918e75a45ce33eb5c934b998790fdc8","author":{"name":"Pieter Wuille","email":"c1fe694431f9243042d0eb4561d822ec1200493d@gmail.com"},"message":"Fix csBestBlock/cvBlockChange waiting in rpc/mining","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/45dd13503918e75a45ce33eb5c934b998790fdc8"},{"sha":"4a6c0e3dcfdca98270cb96b73db4c3d4446dba50","author":{"name":"Pieter Wuille","email":"c1fe694431f9243042d0eb4561d822ec1200493d@gmail.com"},"message":"Modernize best block mutex/cv/hash variable naming","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/4a6c0e3dcfdca98270cb96b73db4c3d4446dba50"},{"sha":"190b8d2dcf2f977b57298cc19be9974bfa83a071","author":{"name":"Pieter Wuille","email":"c1fe694431f9243042d0eb4561d822ec1200493d@gmail.com"},"message":"Make BaseSignatureCreator a pure interface","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/190b8d2dcf2f977b57298cc19be9974bfa83a071"},{"sha":"be678312102ed9bee66738c4721df1343518e3ea","author":{"name":"Pieter Wuille","email":"c1fe694431f9243042d0eb4561d822ec1200493d@gmail.com"},"message":"Make DummySignatureCreator a singleton","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/be678312102ed9bee66738c4721df1343518e3ea"},{"sha":"5b4fc3eca429456628a5db4e4090da294eb1eba1","author":{"name":"fanquake","email":"78ff849752a435bd5688936d67be1806ea7cbd08@gmail.com"},"message":"depends: Fix Qt build with XCode 9.3","distinct":false,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/5b4fc3eca429456628a5db4e4090da294eb1eba1"},{"sha":"fa72f34c644da681bd55ebb8097a32fe5ce35510","author":{"name":"MarcoFalke","email":"94662c316543fb349a23cc41ada52e5549f80958@gmail.com"},"message":"bitcoin-tx: Remove unused for loop","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/fa72f34c644da681bd55ebb8097a32fe5ce35510"},{"sha":"8480d41e0f9d466447f49bf5dd7c17c5337af77a","author":{"name":"Wladimir J. van der Laan","email":"bbc07dc96bb50bf6868a2ddfc4dae14fbed703d9@gmail.com"},"message":"Merge #12803: Make BaseSignatureCreator a pure interface\n\nbe67831 Make DummySignatureCreator a singleton (Pieter Wuille)\n190b8d2 Make BaseSignatureCreator a pure interface (Pieter Wuille)\n\nPull request description:\n\n  * Removes the `m_provider` field from `BaseSignatureCreator`. Instead both a `SigningProvider` (which provides keys and scripts) and a `BaseSignatureCreator` (which implements the transaction-specific (or other) signing logic) are passed into and down in `ProduceSignature`, making the two concepts orthogonal.\n  * Makes `BaseSignatureCreator` a pure interface without constructor, making it easier to implement new derivations of it (for example for message signing).\n  * As `DummySignatureCreator` now becomes a stateless object, turn it into a singleton `DUMMY_SIGNATURE_CREATOR`.\n\nTree-SHA512: 5f1f4512e4ea7d02a31df7b9ede55008efa716c5b74a2630ca1c2fc6599584d8bf5f5641487266127f4b3788033803539fbd22b03ef1219c83c10da2d3da3dcd","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/8480d41e0f9d466447f49bf5dd7c17c5337af77a"},{"sha":"69b01e6f8b3aca781da7f049909ad75de73a804a","author":{"name":"Andrew Chow","email":"9ef92abc9bcc0292887b9c9cd2be76de0f344b83@achow101.com"},"message":"Add cancel button to rescan progress dialog\n\nAdds a cancel button to the rescan progress dialog. When it is clicked,\nAbortRescan is called to abort a rescan","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/69b01e6f8b3aca781da7f049909ad75de73a804a"},{"sha":"ae1d2b0308d7fe9df7fc18699c69e9587e6154bd","author":{"name":"Andrew Chow","email":"9ef92abc9bcc0292887b9c9cd2be76de0f344b83@achow101.com"},"message":"Give an error when rescan is aborted by the user","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/ae1d2b0308d7fe9df7fc18699c69e9587e6154bd"},{"sha":"339730a6d84a3a90ae23d732fbfc1c81af88d435","author":{"name":"Cory Fields","email":"61cf9882af6c4e2c416ab72b36548ddf5fbe5c83@coryfields.com"},"message":"logging: bypass timestamp formatting when not logging\n\nThis leads to massive speedups under Wine.","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/339730a6d84a3a90ae23d732fbfc1c81af88d435"},{"sha":"4ba6da55743a55189164e29e45ac9e73a074d808","author":{"name":"Pieter Wuille","email":"c1fe694431f9243042d0eb4561d822ec1200493d@gmail.com"},"message":"Merge #12743: Fix csBestBlock/cvBlockChange waiting in rpc/mining\n\n4a6c0e3dcf Modernize best block mutex/cv/hash variable naming (Pieter Wuille)\n45dd135039 Fix csBestBlock/cvBlockChange waiting in rpc/mining (Pieter Wuille)\n\nPull request description:\n\n  This is an alternative to #11694.\n\n  It reintroduces a uint256 variable with the best block hash, protected by csBestBlock, and only updated while holding it.\n\n  Also rename the involved variable to modern guidelines, as there are very few uses.\n\nTree-SHA512: 826a86c7d3cee7fe49f99f4398ae99e81cb0563197eaeba77306a3ca6072b67cdb932bc35720fc0f99c2a57b218efa029d0b8bdfb240591a629b2e90efa3199d","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/4ba6da55743a55189164e29e45ac9e73a074d808"},{"sha":"5df84de583c900e00fef63bedaef32786f205a33","author":{"name":"Pieter Wuille","email":"c1fe694431f9243042d0eb4561d822ec1200493d@gmail.com"},"message":"Merge #12970: logging: bypass timestamp formatting when not logging\n\n339730a6d8 logging: bypass timestamp formatting when not logging (Cory Fields)\n\nPull request description:\n\n  As suggested by @laanwj on IRC:\n  ```\n  <cfields> whoa\n  <cfields> Leaving test case \"knapsack_solver_test\"; testing time: 358694ms\n  <cfields> i386 + old wine ^^\n  <cfields> Leaving test case \"knapsack_solver_test\"; testing time: 6781ms\n  <cfields> ^^ same, but with the LogPrint commented out\n  ...\n  <wumpus> if both log-to-file and log-to-console is disabled, it should probably bypass all logging\n  ```\n  Edit: The painful line commented out being the LogPrintf in CWallet::AddToWallet.\n\nTree-SHA512: bc6da67dcdf05e9164fff7a7e9980de897e6f1b0d3f6e1ebde2162cbcba7d54a6ec94283534eb5a1ebde7134533d7fe7e496aa35ea3128c567ed6483eae5212c","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/5df84de583c900e00fef63bedaef32786f205a33"},{"sha":"8cbc5c4be4be22aca228074f087a374a7ec38be8","author":{"name":"Ben Woosley","email":"3df0af5b774b3387e3ad4650a6c28cf09923a05a@gmail.com"},"message":"Drop dead code CScript::Find\n\nLast use removed in 922e8e2929a2e78270868385aa46f96002fbcff3 (2012!)","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/8cbc5c4be4be22aca228074f087a374a7ec38be8"},{"sha":"152701568159915828613fa131e94e21337c0c2d","author":{"name":"Pieter Wuille","email":"c1fe694431f9243042d0eb4561d822ec1200493d@gmail.com"},"message":"Avoid std::locale/imbue in DateTimeStrFormat","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/152701568159915828613fa131e94e21337c0c2d"},{"sha":"94deb093499ca72154b794b3005d5cdaa6d97de9","author":{"name":"Wladimir J. van der Laan","email":"bbc07dc96bb50bf6868a2ddfc4dae14fbed703d9@gmail.com"},"message":"Merge #12969: Drop dead code CScript::Find\n\n8cbc5c4 Drop dead code CScript::Find (Ben Woosley)\n\nPull request description:\n\n  Last use removed in 922e8e2 (2012!)\n\nTree-SHA512: d62daf2fc340a04c5f68990aa450d6738fadf4df6c50507fe02ecb62ae329b77db401719bf556a69f747408efdea5bc98af5e41ba82650b2f6d8b2d5489625e4","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/94deb093499ca72154b794b3005d5cdaa6d97de9"},{"sha":"e625548e7cae119ce555783a7a546f0039fc431b","author":{"name":"Wladimir J. van der Laan","email":"bbc07dc96bb50bf6868a2ddfc4dae14fbed703d9@gmail.com"},"message":"Merge #12950: bitcoin-tx: Flatten for loop over one element\n\nfa72f34 bitcoin-tx: Remove unused for loop (MarcoFalke)\n\nPull request description:\n\n  This flattens out a for loop and gets rid of the then unused vector `txVariants`.\n\nTree-SHA512: 68081b313d846ce235a97a642c9d0097c3641350e819d6254001f332b053e41fa63ce49faca68120f5aaf5d5f4bfda104662eae781e2956d76a8915770344045","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/e625548e7cae119ce555783a7a546f0039fc431b"},{"sha":"23e7fe8be827cdcdcace2a77ecc683074b97f8a2","author":{"name":"Wladimir J. van der Laan","email":"bbc07dc96bb50bf6868a2ddfc4dae14fbed703d9@gmail.com"},"message":"Merge #12569: net: Increase signal-to-noise ratio in debug.log by adjusting log level when logging failed non-manual connect():s\n\ncba2800 Increase signal-to-noise ratio in debug.log by adjusting log level when logging failed non-manual connect():s (practicalswift)\n\nPull request description:\n\n  Increase signal-to-noise ratio in `debug.log` by adjusting log level when logging failed non-manual `connect()`:s.\n\n  Before this patch:\n\n  ```\n  $ src/bitcoind -printtoconsole\n  …\n  2018-02-28 18:42:51 UpdateTip: new best=0000000000005448b10a219683d34b770a28044e1cc421032dea1a79ff548948 height=1286903 version=0x20000000 log2_work=69.791313 tx=17408546 date='2018-02-28 18:42:46' progress=1.000000 cache=0.0MiB(173txo)\n  2018-02-28 18:37:52 connect() 10.11.21.34:18333 failed after select(): Connection refused (111)\n  2018-02-28 18:43:22 connect() to 10.11.43.14:18333 failed after select(): Network is unreachable (101)\n  2018-02-28 18:44:49 UpdateTip: new best=000000000000029a521ff2803e1441b09413b876accff5084a4cccf7747d798b height=1286904 version=0x20000000 log2_work=69.791345 tx=17408559 date='2018-02-28 18:44:51' progress=1.000000 cache=0.1MiB(502txo)\n  2018-02-28 18:46:54 connect() to [2001:0:9d38:78ff:1234:1234:1234:1234]:18333 failed: Network is unreachable (101)\n  2018-02-28 18:48:56 connect() to [2001:0:9d38:6aff:1234:1234:1234:1234]:18333 failed: Network is unreachable (101)\n  2018-02-28 18:49:11 UpdateTip: new best=000000000000000206b79eb235e5dd907b6369de0e5d764330bf40ec0d460311 height=1286905 version=0x20000000 log2_work=69.791377 tx=17408577 date='2018-02-28 18:49:12' progress=1.000000 cache=1.0MiB(5245txo)\n  ```\n\n  After this patch:\n\n  ```\n  $ src/bitcoind -printtoconsole\n  …\n  2018-02-28 18:42:51 UpdateTip: new best=0000000000005448b10a219683d34b770a28044e1cc421032dea1a79ff548948 height=1286903 version=0x20000000 log2_work=69.791313 tx=17408546 date='2018-02-28 18:42:46' progress=1.000000 cache=0.0MiB(173txo)\n  2018-02-28 18:44:49 UpdateTip: new best=000000000000029a521ff2803e1441b09413b876accff5084a4cccf7747d798b height=1286904 version=0x20000000 log2_work=69.791345 tx=17408559 date='2018-02-28 18:44:51' progress=1.000000 cache=0.1MiB(502txo)\n  2018-02-28 18:49:11 UpdateTip: new best=000000000000000206b79eb235e5dd907b6369de0e5d764330bf40ec0d460311 height=1286905 version=0x20000000 log2_work=69.791377 tx=17408577 date='2018-02-28 18:49:12' progress=1.000000 cache=1.0MiB(5245txo)\n  ```\n\n  Please note that \"manual `connect()`:s\" (invoked via `-connect`, `-proxy` or `addnode`) are still reported at the default log level as these messages are likely to be relevant to end-users:\n\n  ```\n  $ src/bitcoind -printtoconsole -connect=127.0.0.1:1234\n  …\n  2018-02-28 18:31:13 connect() to 127.0.0.1:1234 failed after select(): Connection refused (111)\n\n  $ src/bitcoind -printtoconsole -proxy=127.0.0.1:1234\n  …\n  2018-02-28 18:32:32 connect() to 127.0.0.1:1234 failed after select(): Connection refused (111)\n\n  $ src/bitcoind -printtoconsole &\n  $ src/bitcoin-cli addnode 127.0.0.1:1234 onetry\n  …\n  2018-02-28 18:33:40 connect() to 127.0.0.1:1234 failed after select(): Connection refused (111)\n  ```\n\nTree-SHA512: 92e3c1e4b54ce8ccdd7ec31de147c8505710cd799ceb2bbc8576a086709967802403c9184df364b3cfa59bd98859f6ac8feb27fb09b9324194c6c47a042fc6d3","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/23e7fe8be827cdcdcace2a77ecc683074b97f8a2"},{"sha":"5f2a39946fd42535038e0143cbd289d3070b9f07","author":{"name":"Jonas Schnelli","email":"34c6fceca75e456f25e7e99531e2425c6c1de443@jonasschnelli.ch"},"message":"Merge #11200: Allow for aborting rescans in the GUI\n\nae1d2b030 Give an error when rescan is aborted by the user (Andrew Chow)\n69b01e6f8 Add cancel button to rescan progress dialog (Andrew Chow)\n\nPull request description:\n\n  A cancel button is added to the `showProgress` dialog that is used only for rescans. When clicked, `AbortRescan` is called directly to cancel the rescan.\n\n  Rescans triggered from the debug console will now be cancelable by clicking the cancel button.\n\n  Rescans triggered by a command (e.g. `importmulti`) will now give an error indicating that the rescan was aborted by the user (either by the `abortrescan` command or by clicking cancel).\n\nTree-SHA512: 4bb14998766de686e2318fbc9805758eccf5dbe628a7257d072c9ae2fb4f61303a0876f49988d6e5eddb261969b8a307c81c0c2df0a42ae909a43d738af3dc1b","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/5f2a39946fd42535038e0143cbd289d3070b9f07"},{"sha":"dec61152d6cc711d627d5dee497156d4a19c2499","author":{"name":"Wladimir J. van der Laan","email":"bbc07dc96bb50bf6868a2ddfc4dae14fbed703d9@gmail.com"},"message":"Merge #12973: Avoid std::locale/imbue madness in DateTimeStrFormat\n\n1527015 Avoid std::locale/imbue in DateTimeStrFormat (Pieter Wuille)\n\nPull request description:\n\n  And replace them with just hardcoded ISO8601 strings and `gmtime_r`.\n\n  Pointed out by @laanwj here: https://github.com/bitcoin/bitcoin/pull/12970#issuecomment-380962488\n\nTree-SHA512: a459758b42ca56f8462115aefe8e6377c1319fce509ea64dbb767f3f087c9b848335954cb684e5896c38008847684045505a3e1559fb3e83b8e80e10b003d1e7","distinct":true,"url":"https://api.github.com/repos/fanquake/bitcoin/commits/dec61152d6cc711d627d5dee497156d4a19c2499"}]}
{"actor":{"display_login":"fanquake"}}