{"action":"created","issue":{"url":"https://api.github.com/repos/operator-framework/operator-sdk/issues/802","repository_url":"https://api.github.com/repos/operator-framework/operator-sdk","labels_url":"https://api.github.com/repos/operator-framework/operator-sdk/issues/802/labels{/name}","comments_url":"https://api.github.com/repos/operator-framework/operator-sdk/issues/802/comments","events_url":"https://api.github.com/repos/operator-framework/operator-sdk/issues/802/events","html_url":"https://github.com/operator-framework/operator-sdk/pull/802","id":386533186,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjQxODI2","number":802,"title":"Fix validation check for when API version is missed","user":{"login":"nak3","id":2138339,"node_id":"MDQ6VXNlcjIxMzgzMzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2138339?v=4","gravatar_id":"","url":"https://api.github.com/users/nak3","html_url":"https://github.com/nak3","followers_url":"https://api.github.com/users/nak3/followers","following_url":"https://api.github.com/users/nak3/following{/other_user}","gists_url":"https://api.github.com/users/nak3/gists{/gist_id}","starred_url":"https://api.github.com/users/nak3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nak3/subscriptions","organizations_url":"https://api.github.com/users/nak3/orgs","repos_url":"https://api.github.com/users/nak3/repos","events_url":"https://api.github.com/users/nak3/events{/privacy}","received_events_url":"https://api.github.com/users/nak3/received_events","type":"User","site_admin":false},"labels":[{"id":1064653286,"node_id":"MDU6TGFiZWwxMDY0NjUzMjg2","url":"https://api.github.com/repos/operator-framework/operator-sdk/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"ededed","default":false},{"id":1064653228,"node_id":"MDU6TGFiZWwxMDY0NjUzMjI4","url":"https://api.github.com/repos/operator-framework/operator-sdk/labels/size/XS","name":"size/XS","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-02T06:50:55Z","updated_at":"2018-12-02T06:51:08Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/operator-framework/operator-sdk/pulls/802","html_url":"https://github.com/operator-framework/operator-sdk/pull/802","diff_url":"https://github.com/operator-framework/operator-sdk/pull/802.diff","patch_url":"https://github.com/operator-framework/operator-sdk/pull/802.patch"},"body":"In the the validation code it causes go panic when the version was\r\nmissed. This patch changes to check the length of splitted API by\r\n\"/\". Then, output produce error message if version was missed.\r\n\r\nAfter this patch:\r\n~~~\r\n$ operator-sdk add api --api-version=foo  --kind=AppService\r\nINFO[0000] Generating api version foo for kind AppService.\r\nFATA[0000] version cannot be empty\r\n~~~\r\n\r\nFix https://github.com/operator-framework/operator-sdk/issues/801\r\n"},"comment":{"url":"https://api.github.com/repos/operator-framework/operator-sdk/issues/comments/443486067","html_url":"https://github.com/operator-framework/operator-sdk/pull/802#issuecomment-443486067","issue_url":"https://api.github.com/repos/operator-framework/operator-sdk/issues/802","id":443486067,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzQ4NjA2Nw==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-12-02T06:51:08Z","updated_at":"2018-12-02T06:51:08Z","author_association":"NONE","body":"Hi @nak3. Thanks for your PR.\n\nI'm waiting for a [operator-framework](https://github.com/orgs/operator-framework/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://github.com/orgs/operator-framework/people) to skip this step.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"openshift-ci-robot"}}