{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/31754","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/31754/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/31754/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/31754/events","html_url":"https://github.com/cockroachdb/cockroach/pull/31754","id":373102605,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MTE2MDg3","number":31754,"title":"opt: fix issue with GroupBy not using input ordering in some cases","user":{"login":"RaduBerinde","id":16544120,"node_id":"MDQ6VXNlcjE2NTQ0MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/16544120?v=4","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"labels":[{"id":1045391694,"node_id":"MDU6TGFiZWwxMDQ1MzkxNjk0","url":"https://api.github.com/repos/cockroachdb/cockroach/labels/backport-2.1.x","name":"backport-2.1.x","color":"593f9b","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-10-23T17:01:50Z","updated_at":"2018-10-25T04:54:44Z","closed_at":"2018-10-23T20:35:58Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31754","html_url":"https://github.com/cockroachdb/cockroach/pull/31754","diff_url":"https://github.com/cockroachdb/cockroach/pull/31754.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/31754.patch"},"body":"Similar to Project, the FDs of the input aren't in general reflected\r\nby the GroupBy expression. We need to reduce a required ordering\r\naccording to the input FDs.\r\n\r\nThis fixes some cases where GroupBy wasn't using an input ordering.\r\n\r\nRelease note (bug fix): fixed a bug in the optimizer that prevented\r\npassing through ordering requirements through aggregations (in some\r\ncases)."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/432914396","html_url":"https://github.com/cockroachdb/cockroach/pull/31754#issuecomment-432914396","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/31754","id":432914396,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjkxNDM5Ng==","user":{"login":"andy-kimball","id":32096062,"node_id":"MDQ6VXNlcjMyMDk2MDYy","avatar_url":"https://avatars0.githubusercontent.com/u/32096062?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-kimball","html_url":"https://github.com/andy-kimball","followers_url":"https://api.github.com/users/andy-kimball/followers","following_url":"https://api.github.com/users/andy-kimball/following{/other_user}","gists_url":"https://api.github.com/users/andy-kimball/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-kimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-kimball/subscriptions","organizations_url":"https://api.github.com/users/andy-kimball/orgs","repos_url":"https://api.github.com/users/andy-kimball/repos","events_url":"https://api.github.com/users/andy-kimball/events{/privacy}","received_events_url":"https://api.github.com/users/andy-kimball/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T04:54:44Z","updated_at":"2018-10-25T04:54:44Z","author_association":"CONTRIBUTOR","body":"I think we probably still want that, because it modifies the actual ordering, which could make it cheaper to walk the tree. This change recomputes the ordering on-the-fly, which is more expensive. Also, `SimplifyGroupByOrdering` will show up as an `optstep`, and will also change the `opt` output, which makes for easier debugging.\n\n\n\n\n\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"andy-kimball"}}