{"action":"created","issue":{"url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/1389","repository_url":"https://api.github.com/repos/firebase/FirebaseUI-Android","labels_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/1389/labels{/name}","comments_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/1389/comments","events_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/1389/events","html_url":"https://github.com/firebase/FirebaseUI-Android/issues/1389","id":339269712,"node_id":"MDU6SXNzdWUzMzkyNjk3MTI=","number":1389,"title":"CHANGE-ME link appears in system settings","user":{"login":"javmarina","id":2737599,"node_id":"MDQ6VXNlcjI3Mzc1OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2737599?v=4","gravatar_id":"","url":"https://api.github.com/users/javmarina","html_url":"https://github.com/javmarina","followers_url":"https://api.github.com/users/javmarina/followers","following_url":"https://api.github.com/users/javmarina/following{/other_user}","gists_url":"https://api.github.com/users/javmarina/gists{/gist_id}","starred_url":"https://api.github.com/users/javmarina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javmarina/subscriptions","organizations_url":"https://api.github.com/users/javmarina/orgs","repos_url":"https://api.github.com/users/javmarina/repos","events_url":"https://api.github.com/users/javmarina/events{/privacy}","received_events_url":"https://api.github.com/users/javmarina/received_events","type":"User","site_admin":false},"labels":[{"id":417993157,"node_id":"MDU6TGFiZWw0MTc5OTMxNTc=","url":"https://api.github.com/repos/firebase/FirebaseUI-Android/labels/auth","name":"auth","color":"d4c5f9","default":false},{"id":234429615,"node_id":"MDU6TGFiZWwyMzQ0Mjk2MTU=","url":"https://api.github.com/repos/firebase/FirebaseUI-Android/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-08T23:58:46Z","updated_at":"2018-08-20T19:56:33Z","closed_at":null,"author_association":"NONE","body":"### Step 2: Describe your environment\r\n\r\n  * Android device: Nokia 7 plus\r\n  * Android OS version: 8.1.0\r\n  * Google Play Services version: 15.0.1 - 16.0.0\r\n  * Firebase/Play Services SDK version: 16.0.0\r\n  * FirebaseUI version: 4.1.0\r\n  \r\n### Step 3: Describe the problem:\r\n\r\n#### Steps to reproduce:\r\n\r\n  1. Include FirebaseUI (auth) in a project\r\n  2. Build and install\r\n  3. Go to Settings > Apps > installed testing app > Open by default\r\n  \r\n#### Observed Results:\r\n\r\n  * What happened?\r\nIn the \"Supported links\" line, you can see CHANGE-ME as a link. This is because Firebase UI includes this in the manifest. CHANGE-ME  is used for Github sign in, I think.\r\n  \r\n#### Expected Results:\r\n\r\n  * What did you expect to happen?\r\nI didn't expect this to appear, as it is a string related to a part of the library that I don't use. Moreover, users can see it too.\r\n  \r\n![screenshot_20180709-015538](https://user-images.githubusercontent.com/2737599/42425300-97d892ce-831b-11e8-8660-6affebc08dd7.png)\r\n"},"comment":{"url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/comments/414442671","html_url":"https://github.com/firebase/FirebaseUI-Android/issues/1389#issuecomment-414442671","issue_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/1389","id":414442671,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDQ0MjY3MQ==","user":{"login":"noelmansour","id":327631,"node_id":"MDQ6VXNlcjMyNzYzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/327631?v=4","gravatar_id":"","url":"https://api.github.com/users/noelmansour","html_url":"https://github.com/noelmansour","followers_url":"https://api.github.com/users/noelmansour/followers","following_url":"https://api.github.com/users/noelmansour/following{/other_user}","gists_url":"https://api.github.com/users/noelmansour/gists{/gist_id}","starred_url":"https://api.github.com/users/noelmansour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noelmansour/subscriptions","organizations_url":"https://api.github.com/users/noelmansour/orgs","repos_url":"https://api.github.com/users/noelmansour/repos","events_url":"https://api.github.com/users/noelmansour/events{/privacy}","received_events_url":"https://api.github.com/users/noelmansour/received_events","type":"User","site_admin":false},"created_at":"2018-08-20T19:56:33Z","updated_at":"2018-08-20T19:56:33Z","author_association":"NONE","body":"I'm not sure if this affects priority at all, but this bug breaks app links (like those used for passwordless sign up).\r\n\r\nAlso, I had to put the fully qualified activity name for the workaround to work:\r\n\r\n```\r\n<activity\r\n    android:name=\"com.firebase.ui.auth.ui.provider.GitHubLoginActivity\"\r\n    tools:node=\"remove\" />\r\n```"}}
{"actor":{"display_login":"noelmansour"}}