{"action":"closed","number":552,"pull_request":{"url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/552","id":239020593,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MDIwNTkz","html_url":"https://github.com/dnadesign/silverstripe-elemental/pull/552","diff_url":"https://github.com/dnadesign/silverstripe-elemental/pull/552.diff","patch_url":"https://github.com/dnadesign/silverstripe-elemental/pull/552.patch","issue_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/552","number":552,"state":"closed","locked":false,"title":"feat(BaseElement): canView on a per element basis","user":{"login":"JoshuaCarter","id":8869081,"node_id":"MDQ6VXNlcjg4NjkwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/8869081?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshuaCarter","html_url":"https://github.com/JoshuaCarter","followers_url":"https://api.github.com/users/JoshuaCarter/followers","following_url":"https://api.github.com/users/JoshuaCarter/following{/other_user}","gists_url":"https://api.github.com/users/JoshuaCarter/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshuaCarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshuaCarter/subscriptions","organizations_url":"https://api.github.com/users/JoshuaCarter/orgs","repos_url":"https://api.github.com/users/JoshuaCarter/repos","events_url":"https://api.github.com/users/JoshuaCarter/events{/privacy}","received_events_url":"https://api.github.com/users/JoshuaCarter/received_events","type":"User","site_admin":false},"body":"@robbieaverill This is a replacement for https://github.com/dnadesign/silverstripe-elemental/pull/289 (as I re-forked directly from this repo, etc).\r\n\r\n#### BaseElement:\r\n- Extends with InheritedPermissionsExtension\r\n- Adds man_many ViewerGroups\r\n- Adds CMS fields for selecting viewer permissions and viewer groups\r\n- Changes canView logic\r\n- Removes 'EditorGroups' and 'CanEditType' from CMS (brought in with InheritedPermissionsExtension).\r\n\r\nThe only real question I have about these changes is whether the 'Anyone' option serves a purpose given that the default is to use the page's canView(). Happy to remove this if you think it best.","created_at":"2018-12-17T03:55:47Z","updated_at":"2018-12-21T00:40:25Z","closed_at":"2018-12-21T00:40:25Z","merged_at":"2018-12-21T00:40:25Z","merge_commit_sha":"99a46c637969843e752c410506805dfeb432d4ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":730187402,"node_id":"MDU6TGFiZWw3MzAxODc0MDI=","url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/labels/affects/v4","name":"affects/v4","color":"5319e7","default":false},{"id":730187451,"node_id":"MDU6TGFiZWw3MzAxODc0NTE=","url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/labels/change/minor","name":"change/minor","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/552/commits","review_comments_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/552/comments","review_comment_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/552/comments","statuses_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/statuses/a7b87d29939bdf67064fe1d71388e31fc29cb02b","head":{"label":"JoshuaCarter:3.0","ref":"3.0","sha":"a7b87d29939bdf67064fe1d71388e31fc29cb02b","user":{"login":"JoshuaCarter","id":8869081,"node_id":"MDQ6VXNlcjg4NjkwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/8869081?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshuaCarter","html_url":"https://github.com/JoshuaCarter","followers_url":"https://api.github.com/users/JoshuaCarter/followers","following_url":"https://api.github.com/users/JoshuaCarter/following{/other_user}","gists_url":"https://api.github.com/users/JoshuaCarter/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshuaCarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshuaCarter/subscriptions","organizations_url":"https://api.github.com/users/JoshuaCarter/orgs","repos_url":"https://api.github.com/users/JoshuaCarter/repos","events_url":"https://api.github.com/users/JoshuaCarter/events{/privacy}","received_events_url":"https://api.github.com/users/JoshuaCarter/received_events","type":"User","site_admin":false},"repo":{"id":161726256,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE3MjYyNTY=","name":"silverstripe-elemental","full_name":"JoshuaCarter/silverstripe-elemental","private":false,"owner":{"login":"JoshuaCarter","id":8869081,"node_id":"MDQ6VXNlcjg4NjkwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/8869081?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshuaCarter","html_url":"https://github.com/JoshuaCarter","followers_url":"https://api.github.com/users/JoshuaCarter/followers","following_url":"https://api.github.com/users/JoshuaCarter/following{/other_user}","gists_url":"https://api.github.com/users/JoshuaCarter/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshuaCarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshuaCarter/subscriptions","organizations_url":"https://api.github.com/users/JoshuaCarter/orgs","repos_url":"https://api.github.com/users/JoshuaCarter/repos","events_url":"https://api.github.com/users/JoshuaCarter/events{/privacy}","received_events_url":"https://api.github.com/users/JoshuaCarter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JoshuaCarter/silverstripe-elemental","description":"Create pages in SilverStripe using content blocks","fork":true,"url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental","forks_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/forks","keys_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/teams","hooks_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/hooks","issue_events_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/issues/events{/number}","events_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/events","assignees_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/assignees{/user}","branches_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/branches{/branch}","tags_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/tags","blobs_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/statuses/{sha}","languages_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/languages","stargazers_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/stargazers","contributors_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/contributors","subscribers_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/subscribers","subscription_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/subscription","commits_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/contents/{+path}","compare_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/merges","archive_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/downloads","issues_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/issues{/number}","pulls_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/pulls{/number}","milestones_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/milestones{/number}","notifications_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/labels{/name}","releases_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/releases{/id}","deployments_url":"https://api.github.com/repos/JoshuaCarter/silverstripe-elemental/deployments","created_at":"2018-12-14T03:22:55Z","updated_at":"2018-12-20T22:10:27Z","pushed_at":"2018-12-20T23:30:41Z","git_url":"git://github.com/JoshuaCarter/silverstripe-elemental.git","ssh_url":"git@github.com:JoshuaCarter/silverstripe-elemental.git","clone_url":"https://github.com/JoshuaCarter/silverstripe-elemental.git","svn_url":"https://github.com/JoshuaCarter/silverstripe-elemental","homepage":"http://dna.co.nz","size":3556,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"3"}},"base":{"label":"dnadesign:3","ref":"3","sha":"f489e81c58515707b1b8f0bbfb31a5a8c5dc997d","user":{"login":"dnadesign","id":2148312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNDgzMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2148312?v=4","gravatar_id":"","url":"https://api.github.com/users/dnadesign","html_url":"https://github.com/dnadesign","followers_url":"https://api.github.com/users/dnadesign/followers","following_url":"https://api.github.com/users/dnadesign/following{/other_user}","gists_url":"https://api.github.com/users/dnadesign/gists{/gist_id}","starred_url":"https://api.github.com/users/dnadesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnadesign/subscriptions","organizations_url":"https://api.github.com/users/dnadesign/orgs","repos_url":"https://api.github.com/users/dnadesign/repos","events_url":"https://api.github.com/users/dnadesign/events{/privacy}","received_events_url":"https://api.github.com/users/dnadesign/received_events","type":"Organization","site_admin":false},"repo":{"id":23339883,"node_id":"MDEwOlJlcG9zaXRvcnkyMzMzOTg4Mw==","name":"silverstripe-elemental","full_name":"dnadesign/silverstripe-elemental","private":false,"owner":{"login":"dnadesign","id":2148312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNDgzMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2148312?v=4","gravatar_id":"","url":"https://api.github.com/users/dnadesign","html_url":"https://github.com/dnadesign","followers_url":"https://api.github.com/users/dnadesign/followers","following_url":"https://api.github.com/users/dnadesign/following{/other_user}","gists_url":"https://api.github.com/users/dnadesign/gists{/gist_id}","starred_url":"https://api.github.com/users/dnadesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnadesign/subscriptions","organizations_url":"https://api.github.com/users/dnadesign/orgs","repos_url":"https://api.github.com/users/dnadesign/repos","events_url":"https://api.github.com/users/dnadesign/events{/privacy}","received_events_url":"https://api.github.com/users/dnadesign/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dnadesign/silverstripe-elemental","description":"Create pages in SilverStripe using content blocks","fork":false,"url":"https://api.github.com/repos/dnadesign/silverstripe-elemental","forks_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/forks","keys_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/teams","hooks_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/hooks","issue_events_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/events{/number}","events_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/events","assignees_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/assignees{/user}","branches_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/branches{/branch}","tags_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/tags","blobs_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/statuses/{sha}","languages_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/languages","stargazers_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/stargazers","contributors_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/contributors","subscribers_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/subscribers","subscription_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/subscription","commits_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/contents/{+path}","compare_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/merges","archive_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/downloads","issues_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues{/number}","pulls_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls{/number}","milestones_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/milestones{/number}","notifications_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/labels{/name}","releases_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/releases{/id}","deployments_url":"https://api.github.com/repos/dnadesign/silverstripe-elemental/deployments","created_at":"2014-08-26T05:27:34Z","updated_at":"2018-12-11T15:48:03Z","pushed_at":"2018-12-21T00:40:25Z","git_url":"git://github.com/dnadesign/silverstripe-elemental.git","ssh_url":"git@github.com:dnadesign/silverstripe-elemental.git","clone_url":"https://github.com/dnadesign/silverstripe-elemental.git","svn_url":"https://github.com/dnadesign/silverstripe-elemental","homepage":"http://dna.co.nz","size":3570,"stargazers_count":70,"watchers_count":70,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":65,"open_issues":61,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/552"},"html":{"href":"https://github.com/dnadesign/silverstripe-elemental/pull/552"},"issue":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/552"},"comments":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/issues/552/comments"},"review_comments":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/552/comments"},"review_comment":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/pulls/552/commits"},"statuses":{"href":"https://api.github.com/repos/dnadesign/silverstripe-elemental/statuses/a7b87d29939bdf67064fe1d71388e31fc29cb02b"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ScopeyNZ","id":3260989,"node_id":"MDQ6VXNlcjMyNjA5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/3260989?v=4","gravatar_id":"","url":"https://api.github.com/users/ScopeyNZ","html_url":"https://github.com/ScopeyNZ","followers_url":"https://api.github.com/users/ScopeyNZ/followers","following_url":"https://api.github.com/users/ScopeyNZ/following{/other_user}","gists_url":"https://api.github.com/users/ScopeyNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/ScopeyNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScopeyNZ/subscriptions","organizations_url":"https://api.github.com/users/ScopeyNZ/orgs","repos_url":"https://api.github.com/users/ScopeyNZ/repos","events_url":"https://api.github.com/users/ScopeyNZ/events{/privacy}","received_events_url":"https://api.github.com/users/ScopeyNZ/received_events","type":"User","site_admin":false},"comments":13,"review_comments":6,"maintainer_can_modify":false,"commits":1,"additions":105,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"ScopeyNZ"}}