{"action":"created","comment":{"url":"https://api.github.com/repos/ferd/pobox/pulls/comments/235233207","pull_request_review_id":177052576,"id":235233207,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTIzMzIwNw==","diff_hunk":"@@ -0,0 +1,88 @@\n+-module(pobox_give_away_SUITE).\n+-include_lib(\"common_test/include/ct.hrl\").\n+-compile(export_all).\n+\n+all() -> [\n+  owner_gives_away_ownership,\n+  owner_gives_away_ownership_with_data,\n+  owner_gives_away_ownership_to_dead_process,\n+  foreign_process_tries_to_gives_away_ownership,\n+  give_away_does_not_change_heir\n+].\n+\n+owner_gives_away_ownership(_Config) ->\n+    {ok, Box} = pobox:start_link([]),\n+    Self = self(),\n+    Func = fun() ->\n+      Fn = fun(F) -> receive X -> Self ! X end, F(F) end,\n+      Fn(Fn)\n+    end,\n+    H = erlang:spawn(Func),\n+    true = pobox:give_away(Box, H, 5000),\n+    true = receive\n+        {pobox_transfer, Box, Self, undefined, give_away} -> true;\n+        Other -> Other\n+    after\n+      5000 -> false\n+    end.","path":"test/pobox_give_away_SUITE.erl","position":27,"original_position":27,"commit_id":"db326dd75220d8ca8292a90ff1fdbb9ee3d9c810","original_commit_id":"01e83bfb52ee0022eca389e1a004b0bf030bcf4e","user":{"login":"edescourtis","id":2200365,"node_id":"MDQ6VXNlcjIyMDAzNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/2200365?v=4","gravatar_id":"","url":"https://api.github.com/users/edescourtis","html_url":"https://github.com/edescourtis","followers_url":"https://api.github.com/users/edescourtis/followers","following_url":"https://api.github.com/users/edescourtis/following{/other_user}","gists_url":"https://api.github.com/users/edescourtis/gists{/gist_id}","starred_url":"https://api.github.com/users/edescourtis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edescourtis/subscriptions","organizations_url":"https://api.github.com/users/edescourtis/orgs","repos_url":"https://api.github.com/users/edescourtis/repos","events_url":"https://api.github.com/users/edescourtis/events{/privacy}","received_events_url":"https://api.github.com/users/edescourtis/received_events","type":"User","site_admin":false},"body":"Thanks for the tip. I will make the change.","created_at":"2018-11-21T02:11:07Z","updated_at":"2018-11-21T02:11:07Z","html_url":"https://github.com/ferd/pobox/pull/13#discussion_r235233207","pull_request_url":"https://api.github.com/repos/ferd/pobox/pulls/13","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ferd/pobox/pulls/comments/235233207"},"html":{"href":"https://github.com/ferd/pobox/pull/13#discussion_r235233207"},"pull_request":{"href":"https://api.github.com/repos/ferd/pobox/pulls/13"}},"in_reply_to_id":234391885},"pull_request":{"url":"https://api.github.com/repos/ferd/pobox/pulls/13","id":231027106,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMDI3MTA2","html_url":"https://github.com/ferd/pobox/pull/13","diff_url":"https://github.com/ferd/pobox/pull/13.diff","patch_url":"https://github.com/ferd/pobox/pull/13.patch","issue_url":"https://api.github.com/repos/ferd/pobox/issues/13","number":13,"state":"open","locked":false,"title":"Added ets style heir, heir data and give_away feature (work in progress more changes to come)","user":{"login":"edescourtis","id":2200365,"node_id":"MDQ6VXNlcjIyMDAzNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/2200365?v=4","gravatar_id":"","url":"https://api.github.com/users/edescourtis","html_url":"https://github.com/edescourtis","followers_url":"https://api.github.com/users/edescourtis/followers","following_url":"https://api.github.com/users/edescourtis/following{/other_user}","gists_url":"https://api.github.com/users/edescourtis/gists{/gist_id}","starred_url":"https://api.github.com/users/edescourtis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edescourtis/subscriptions","organizations_url":"https://api.github.com/users/edescourtis/orgs","repos_url":"https://api.github.com/users/edescourtis/repos","events_url":"https://api.github.com/users/edescourtis/events{/privacy}","received_events_url":"https://api.github.com/users/edescourtis/received_events","type":"User","site_admin":false},"body":"Details:\r\n-  improved support for process registries (local, global, via)\r\n-  test suites for heir and give_away functionality\r\n-  applied DRY principal to guards (used macros for this)\r\n-  new map syntax for start_link\r\n-  change init arguments to record instead of a tuple (it was too long)\r\n\r\nThis is just for **review purposes only** the commit is not ready yet.","created_at":"2018-11-15T00:17:05Z","updated_at":"2018-11-21T02:11:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a975e1e912e62f4b5731e0a84ea1ad4cf4793d38","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ferd/pobox/pulls/13/commits","review_comments_url":"https://api.github.com/repos/ferd/pobox/pulls/13/comments","review_comment_url":"https://api.github.com/repos/ferd/pobox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ferd/pobox/issues/13/comments","statuses_url":"https://api.github.com/repos/ferd/pobox/statuses/db326dd75220d8ca8292a90ff1fdbb9ee3d9c810","head":{"label":"edescourtis:master","ref":"master","sha":"db326dd75220d8ca8292a90ff1fdbb9ee3d9c810","user":{"login":"edescourtis","id":2200365,"node_id":"MDQ6VXNlcjIyMDAzNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/2200365?v=4","gravatar_id":"","url":"https://api.github.com/users/edescourtis","html_url":"https://github.com/edescourtis","followers_url":"https://api.github.com/users/edescourtis/followers","following_url":"https://api.github.com/users/edescourtis/following{/other_user}","gists_url":"https://api.github.com/users/edescourtis/gists{/gist_id}","starred_url":"https://api.github.com/users/edescourtis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edescourtis/subscriptions","organizations_url":"https://api.github.com/users/edescourtis/orgs","repos_url":"https://api.github.com/users/edescourtis/repos","events_url":"https://api.github.com/users/edescourtis/events{/privacy}","received_events_url":"https://api.github.com/users/edescourtis/received_events","type":"User","site_admin":false},"repo":{"id":132148789,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIxNDg3ODk=","name":"pobox","full_name":"edescourtis/pobox","private":false,"owner":{"login":"edescourtis","id":2200365,"node_id":"MDQ6VXNlcjIyMDAzNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/2200365?v=4","gravatar_id":"","url":"https://api.github.com/users/edescourtis","html_url":"https://github.com/edescourtis","followers_url":"https://api.github.com/users/edescourtis/followers","following_url":"https://api.github.com/users/edescourtis/following{/other_user}","gists_url":"https://api.github.com/users/edescourtis/gists{/gist_id}","starred_url":"https://api.github.com/users/edescourtis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edescourtis/subscriptions","organizations_url":"https://api.github.com/users/edescourtis/orgs","repos_url":"https://api.github.com/users/edescourtis/repos","events_url":"https://api.github.com/users/edescourtis/events{/privacy}","received_events_url":"https://api.github.com/users/edescourtis/received_events","type":"User","site_admin":false},"html_url":"https://github.com/edescourtis/pobox","description":"External buffer processes to protect against mailbox overflow in Erlang","fork":true,"url":"https://api.github.com/repos/edescourtis/pobox","forks_url":"https://api.github.com/repos/edescourtis/pobox/forks","keys_url":"https://api.github.com/repos/edescourtis/pobox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edescourtis/pobox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edescourtis/pobox/teams","hooks_url":"https://api.github.com/repos/edescourtis/pobox/hooks","issue_events_url":"https://api.github.com/repos/edescourtis/pobox/issues/events{/number}","events_url":"https://api.github.com/repos/edescourtis/pobox/events","assignees_url":"https://api.github.com/repos/edescourtis/pobox/assignees{/user}","branches_url":"https://api.github.com/repos/edescourtis/pobox/branches{/branch}","tags_url":"https://api.github.com/repos/edescourtis/pobox/tags","blobs_url":"https://api.github.com/repos/edescourtis/pobox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edescourtis/pobox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edescourtis/pobox/git/refs{/sha}","trees_url":"https://api.github.com/repos/edescourtis/pobox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edescourtis/pobox/statuses/{sha}","languages_url":"https://api.github.com/repos/edescourtis/pobox/languages","stargazers_url":"https://api.github.com/repos/edescourtis/pobox/stargazers","contributors_url":"https://api.github.com/repos/edescourtis/pobox/contributors","subscribers_url":"https://api.github.com/repos/edescourtis/pobox/subscribers","subscription_url":"https://api.github.com/repos/edescourtis/pobox/subscription","commits_url":"https://api.github.com/repos/edescourtis/pobox/commits{/sha}","git_commits_url":"https://api.github.com/repos/edescourtis/pobox/git/commits{/sha}","comments_url":"https://api.github.com/repos/edescourtis/pobox/comments{/number}","issue_comment_url":"https://api.github.com/repos/edescourtis/pobox/issues/comments{/number}","contents_url":"https://api.github.com/repos/edescourtis/pobox/contents/{+path}","compare_url":"https://api.github.com/repos/edescourtis/pobox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edescourtis/pobox/merges","archive_url":"https://api.github.com/repos/edescourtis/pobox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edescourtis/pobox/downloads","issues_url":"https://api.github.com/repos/edescourtis/pobox/issues{/number}","pulls_url":"https://api.github.com/repos/edescourtis/pobox/pulls{/number}","milestones_url":"https://api.github.com/repos/edescourtis/pobox/milestones{/number}","notifications_url":"https://api.github.com/repos/edescourtis/pobox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edescourtis/pobox/labels{/name}","releases_url":"https://api.github.com/repos/edescourtis/pobox/releases{/id}","deployments_url":"https://api.github.com/repos/edescourtis/pobox/deployments","created_at":"2018-05-04T14:12:59Z","updated_at":"2018-11-18T21:46:43Z","pushed_at":"2018-11-18T21:46:40Z","git_url":"git://github.com/edescourtis/pobox.git","ssh_url":"git@github.com:edescourtis/pobox.git","clone_url":"https://github.com/edescourtis/pobox.git","svn_url":"https://github.com/edescourtis/pobox","homepage":null,"size":200,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ferd:master","ref":"master","sha":"3fff88ce221caa82be84c9df96d297ce4a45e446","user":{"login":"ferd","id":111141,"node_id":"MDQ6VXNlcjExMTE0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/111141?v=4","gravatar_id":"","url":"https://api.github.com/users/ferd","html_url":"https://github.com/ferd","followers_url":"https://api.github.com/users/ferd/followers","following_url":"https://api.github.com/users/ferd/following{/other_user}","gists_url":"https://api.github.com/users/ferd/gists{/gist_id}","starred_url":"https://api.github.com/users/ferd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferd/subscriptions","organizations_url":"https://api.github.com/users/ferd/orgs","repos_url":"https://api.github.com/users/ferd/repos","events_url":"https://api.github.com/users/ferd/events{/privacy}","received_events_url":"https://api.github.com/users/ferd/received_events","type":"User","site_admin":false},"repo":{"id":10592818,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU5MjgxOA==","name":"pobox","full_name":"ferd/pobox","private":false,"owner":{"login":"ferd","id":111141,"node_id":"MDQ6VXNlcjExMTE0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/111141?v=4","gravatar_id":"","url":"https://api.github.com/users/ferd","html_url":"https://github.com/ferd","followers_url":"https://api.github.com/users/ferd/followers","following_url":"https://api.github.com/users/ferd/following{/other_user}","gists_url":"https://api.github.com/users/ferd/gists{/gist_id}","starred_url":"https://api.github.com/users/ferd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferd/subscriptions","organizations_url":"https://api.github.com/users/ferd/orgs","repos_url":"https://api.github.com/users/ferd/repos","events_url":"https://api.github.com/users/ferd/events{/privacy}","received_events_url":"https://api.github.com/users/ferd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ferd/pobox","description":"External buffer processes to protect against mailbox overflow in Erlang","fork":false,"url":"https://api.github.com/repos/ferd/pobox","forks_url":"https://api.github.com/repos/ferd/pobox/forks","keys_url":"https://api.github.com/repos/ferd/pobox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferd/pobox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferd/pobox/teams","hooks_url":"https://api.github.com/repos/ferd/pobox/hooks","issue_events_url":"https://api.github.com/repos/ferd/pobox/issues/events{/number}","events_url":"https://api.github.com/repos/ferd/pobox/events","assignees_url":"https://api.github.com/repos/ferd/pobox/assignees{/user}","branches_url":"https://api.github.com/repos/ferd/pobox/branches{/branch}","tags_url":"https://api.github.com/repos/ferd/pobox/tags","blobs_url":"https://api.github.com/repos/ferd/pobox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferd/pobox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferd/pobox/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferd/pobox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferd/pobox/statuses/{sha}","languages_url":"https://api.github.com/repos/ferd/pobox/languages","stargazers_url":"https://api.github.com/repos/ferd/pobox/stargazers","contributors_url":"https://api.github.com/repos/ferd/pobox/contributors","subscribers_url":"https://api.github.com/repos/ferd/pobox/subscribers","subscription_url":"https://api.github.com/repos/ferd/pobox/subscription","commits_url":"https://api.github.com/repos/ferd/pobox/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferd/pobox/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferd/pobox/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferd/pobox/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferd/pobox/contents/{+path}","compare_url":"https://api.github.com/repos/ferd/pobox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferd/pobox/merges","archive_url":"https://api.github.com/repos/ferd/pobox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferd/pobox/downloads","issues_url":"https://api.github.com/repos/ferd/pobox/issues{/number}","pulls_url":"https://api.github.com/repos/ferd/pobox/pulls{/number}","milestones_url":"https://api.github.com/repos/ferd/pobox/milestones{/number}","notifications_url":"https://api.github.com/repos/ferd/pobox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferd/pobox/labels{/name}","releases_url":"https://api.github.com/repos/ferd/pobox/releases{/id}","deployments_url":"https://api.github.com/repos/ferd/pobox/deployments","created_at":"2013-06-10T03:06:33Z","updated_at":"2018-11-10T16:19:24Z","pushed_at":"2018-11-18T21:46:42Z","git_url":"git://github.com/ferd/pobox.git","ssh_url":"git@github.com:ferd/pobox.git","clone_url":"https://github.com/ferd/pobox.git","svn_url":"https://github.com/ferd/pobox","homepage":null,"size":201,"stargazers_count":252,"watchers_count":252,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":32,"open_issues":4,"watchers":252,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ferd/pobox/pulls/13"},"html":{"href":"https://github.com/ferd/pobox/pull/13"},"issue":{"href":"https://api.github.com/repos/ferd/pobox/issues/13"},"comments":{"href":"https://api.github.com/repos/ferd/pobox/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/ferd/pobox/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/ferd/pobox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ferd/pobox/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/ferd/pobox/statuses/db326dd75220d8ca8292a90ff1fdbb9ee3d9c810"}},"author_association":"NONE"}}
{"actor":{"display_login":"edescourtis"}}