{"action":"created","comment":{"url":"https://api.github.com/repos/kiali/kiali/pulls/comments/220434436","pull_request_review_id":158840880,"id":220434436,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDQzNDQzNg==","diff_hunk":"@@ -89,10 +93,15 @@ spec:\n         volumeMounts:\n         - name: kiali-configuration\n           mountPath: \"/kiali-configuration\"\n+        - name: kiali-cert","path":"deploy/openshift/kiali.yaml","position":22,"original_position":22,"commit_id":"e40b7841fd60d927a62d03d02e2e775f06198d2c","original_commit_id":"e40b7841fd60d927a62d03d02e2e775f06198d2c","user":{"login":"pilhuhn","id":208246,"node_id":"MDQ6VXNlcjIwODI0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/208246?v=4","gravatar_id":"","url":"https://api.github.com/users/pilhuhn","html_url":"https://github.com/pilhuhn","followers_url":"https://api.github.com/users/pilhuhn/followers","following_url":"https://api.github.com/users/pilhuhn/following{/other_user}","gists_url":"https://api.github.com/users/pilhuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/pilhuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilhuhn/subscriptions","organizations_url":"https://api.github.com/users/pilhuhn/orgs","repos_url":"https://api.github.com/users/pilhuhn/repos","events_url":"https://api.github.com/users/pilhuhn/events{/privacy}","received_events_url":"https://api.github.com/users/pilhuhn/received_events","type":"User","site_admin":false},"body":"Should we make this `optional=true`?","created_at":"2018-09-26T06:01:38Z","updated_at":"2018-09-26T06:01:38Z","html_url":"https://github.com/kiali/kiali/pull/469#discussion_r220434436","pull_request_url":"https://api.github.com/repos/kiali/kiali/pulls/469","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali/pulls/comments/220434436"},"html":{"href":"https://github.com/kiali/kiali/pull/469#discussion_r220434436"},"pull_request":{"href":"https://api.github.com/repos/kiali/kiali/pulls/469"}}},"pull_request":{"url":"https://api.github.com/repos/kiali/kiali/pulls/469","id":211702124,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNzAyMTI0","html_url":"https://github.com/kiali/kiali/pull/469","diff_url":"https://github.com/kiali/kiali/pull/469.diff","patch_url":"https://github.com/kiali/kiali/pull/469.patch","issue_url":"https://api.github.com/repos/kiali/kiali/issues/469","number":469,"state":"closed","locked":false,"title":"KIALI-665 Support SSl","user":{"login":"aljesusg","id":3019213,"node_id":"MDQ6VXNlcjMwMTkyMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3019213?v=4","gravatar_id":"","url":"https://api.github.com/users/aljesusg","html_url":"https://github.com/aljesusg","followers_url":"https://api.github.com/users/aljesusg/followers","following_url":"https://api.github.com/users/aljesusg/following{/other_user}","gists_url":"https://api.github.com/users/aljesusg/gists{/gist_id}","starred_url":"https://api.github.com/users/aljesusg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljesusg/subscriptions","organizations_url":"https://api.github.com/users/aljesusg/orgs","repos_url":"https://api.github.com/users/aljesusg/repos","events_url":"https://api.github.com/users/aljesusg/events{/privacy}","received_events_url":"https://api.github.com/users/aljesusg/received_events","type":"User","site_admin":false},"body":"Continue @jotak work in https://github.com/kiali/kiali/pull/376\r\n\r\nSSL is working\r\n![screenshot from 2018-08-29 12-33-58](https://user-images.githubusercontent.com/3019213/44782549-db1f5b00-ab87-11e8-97ca-9dc05a2ca707.png)\r\n\r\nGif with SSL and Jaeger\r\n\r\n![ssl_kiali](https://user-images.githubusercontent.com/3019213/44783850-f8eebf00-ab8b-11e8-966c-89a957d428c1.gif)\r\n\r\nIt was  practically done by @jotak ^^","created_at":"2018-08-29T10:21:28Z","updated_at":"2018-09-26T06:01:38Z","closed_at":"2018-08-29T14:39:22Z","merged_at":"2018-08-29T14:39:22Z","merge_commit_sha":"6d6bca08b79502568fd8d30aa1851932193f6089","assignee":{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"assignees":[{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"xeviknal","id":613814,"node_id":"MDQ6VXNlcjYxMzgxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/613814?v=4","gravatar_id":"","url":"https://api.github.com/users/xeviknal","html_url":"https://github.com/xeviknal","followers_url":"https://api.github.com/users/xeviknal/followers","following_url":"https://api.github.com/users/xeviknal/following{/other_user}","gists_url":"https://api.github.com/users/xeviknal/gists{/gist_id}","starred_url":"https://api.github.com/users/xeviknal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeviknal/subscriptions","organizations_url":"https://api.github.com/users/xeviknal/orgs","repos_url":"https://api.github.com/users/xeviknal/repos","events_url":"https://api.github.com/users/xeviknal/events{/privacy}","received_events_url":"https://api.github.com/users/xeviknal/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali/pulls/469/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali/pulls/469/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali/issues/469/comments","statuses_url":"https://api.github.com/repos/kiali/kiali/statuses/e40b7841fd60d927a62d03d02e2e775f06198d2c","head":{"label":"aljesusg:k_665","ref":"k_665","sha":"e40b7841fd60d927a62d03d02e2e775f06198d2c","user":{"login":"aljesusg","id":3019213,"node_id":"MDQ6VXNlcjMwMTkyMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3019213?v=4","gravatar_id":"","url":"https://api.github.com/users/aljesusg","html_url":"https://github.com/aljesusg","followers_url":"https://api.github.com/users/aljesusg/followers","following_url":"https://api.github.com/users/aljesusg/following{/other_user}","gists_url":"https://api.github.com/users/aljesusg/gists{/gist_id}","starred_url":"https://api.github.com/users/aljesusg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljesusg/subscriptions","organizations_url":"https://api.github.com/users/aljesusg/orgs","repos_url":"https://api.github.com/users/aljesusg/repos","events_url":"https://api.github.com/users/aljesusg/events{/privacy}","received_events_url":"https://api.github.com/users/aljesusg/received_events","type":"User","site_admin":false},"repo":{"id":120182669,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAxODI2Njk=","name":"kiali","full_name":"aljesusg/kiali","private":false,"owner":{"login":"aljesusg","id":3019213,"node_id":"MDQ6VXNlcjMwMTkyMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3019213?v=4","gravatar_id":"","url":"https://api.github.com/users/aljesusg","html_url":"https://github.com/aljesusg","followers_url":"https://api.github.com/users/aljesusg/followers","following_url":"https://api.github.com/users/aljesusg/following{/other_user}","gists_url":"https://api.github.com/users/aljesusg/gists{/gist_id}","starred_url":"https://api.github.com/users/aljesusg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljesusg/subscriptions","organizations_url":"https://api.github.com/users/aljesusg/orgs","repos_url":"https://api.github.com/users/aljesusg/repos","events_url":"https://api.github.com/users/aljesusg/events{/privacy}","received_events_url":"https://api.github.com/users/aljesusg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aljesusg/kiali","description":"https://aljesusg.github.io/kiali/","fork":true,"url":"https://api.github.com/repos/aljesusg/kiali","forks_url":"https://api.github.com/repos/aljesusg/kiali/forks","keys_url":"https://api.github.com/repos/aljesusg/kiali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aljesusg/kiali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aljesusg/kiali/teams","hooks_url":"https://api.github.com/repos/aljesusg/kiali/hooks","issue_events_url":"https://api.github.com/repos/aljesusg/kiali/issues/events{/number}","events_url":"https://api.github.com/repos/aljesusg/kiali/events","assignees_url":"https://api.github.com/repos/aljesusg/kiali/assignees{/user}","branches_url":"https://api.github.com/repos/aljesusg/kiali/branches{/branch}","tags_url":"https://api.github.com/repos/aljesusg/kiali/tags","blobs_url":"https://api.github.com/repos/aljesusg/kiali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aljesusg/kiali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aljesusg/kiali/git/refs{/sha}","trees_url":"https://api.github.com/repos/aljesusg/kiali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aljesusg/kiali/statuses/{sha}","languages_url":"https://api.github.com/repos/aljesusg/kiali/languages","stargazers_url":"https://api.github.com/repos/aljesusg/kiali/stargazers","contributors_url":"https://api.github.com/repos/aljesusg/kiali/contributors","subscribers_url":"https://api.github.com/repos/aljesusg/kiali/subscribers","subscription_url":"https://api.github.com/repos/aljesusg/kiali/subscription","commits_url":"https://api.github.com/repos/aljesusg/kiali/commits{/sha}","git_commits_url":"https://api.github.com/repos/aljesusg/kiali/git/commits{/sha}","comments_url":"https://api.github.com/repos/aljesusg/kiali/comments{/number}","issue_comment_url":"https://api.github.com/repos/aljesusg/kiali/issues/comments{/number}","contents_url":"https://api.github.com/repos/aljesusg/kiali/contents/{+path}","compare_url":"https://api.github.com/repos/aljesusg/kiali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aljesusg/kiali/merges","archive_url":"https://api.github.com/repos/aljesusg/kiali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aljesusg/kiali/downloads","issues_url":"https://api.github.com/repos/aljesusg/kiali/issues{/number}","pulls_url":"https://api.github.com/repos/aljesusg/kiali/pulls{/number}","milestones_url":"https://api.github.com/repos/aljesusg/kiali/milestones{/number}","notifications_url":"https://api.github.com/repos/aljesusg/kiali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aljesusg/kiali/labels{/name}","releases_url":"https://api.github.com/repos/aljesusg/kiali/releases{/id}","deployments_url":"https://api.github.com/repos/aljesusg/kiali/deployments","created_at":"2018-02-04T12:24:38Z","updated_at":"2018-09-09T09:11:15Z","pushed_at":"2018-09-09T09:11:14Z","git_url":"git://github.com/aljesusg/kiali.git","ssh_url":"git@github.com:aljesusg/kiali.git","clone_url":"https://github.com/aljesusg/kiali.git","svn_url":"https://github.com/aljesusg/kiali","homepage":"https://aljesusg.github.io/kiali/","size":27198,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kiali:master","ref":"master","sha":"dd7bb126e27b89ce118621a85b9753de249a378f","user":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":120181748,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAxODE3NDg=","name":"kiali","full_name":"kiali/kiali","private":false,"owner":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kiali/kiali","description":"Kiali project, observability for the Istio service mesh","fork":false,"url":"https://api.github.com/repos/kiali/kiali","forks_url":"https://api.github.com/repos/kiali/kiali/forks","keys_url":"https://api.github.com/repos/kiali/kiali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali/teams","hooks_url":"https://api.github.com/repos/kiali/kiali/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali/events","assignees_url":"https://api.github.com/repos/kiali/kiali/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali/tags","blobs_url":"https://api.github.com/repos/kiali/kiali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali/subscription","commits_url":"https://api.github.com/repos/kiali/kiali/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali/merges","archive_url":"https://api.github.com/repos/kiali/kiali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali/downloads","issues_url":"https://api.github.com/repos/kiali/kiali/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali/deployments","created_at":"2018-02-04T12:11:57Z","updated_at":"2018-09-25T23:56:21Z","pushed_at":"2018-09-25T20:43:56Z","git_url":"git://github.com/kiali/kiali.git","ssh_url":"git@github.com:kiali/kiali.git","clone_url":"https://github.com/kiali/kiali.git","svn_url":"https://github.com/kiali/kiali","homepage":"https://kiali.io","size":12032,"stargazers_count":324,"watchers_count":324,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":55,"open_issues":24,"watchers":324,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali/pulls/469"},"html":{"href":"https://github.com/kiali/kiali/pull/469"},"issue":{"href":"https://api.github.com/repos/kiali/kiali/issues/469"},"comments":{"href":"https://api.github.com/repos/kiali/kiali/issues/469/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali/pulls/469/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali/pulls/469/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali/statuses/e40b7841fd60d927a62d03d02e2e775f06198d2c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pilhuhn"}}