{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/25166","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/25166/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/25166/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/25166/events","html_url":"https://github.com/nodejs/node/pull/25166","id":393503104,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNTA4NzA1","number":25166,"title":"build: fix Windows shared lib build","user":{"login":"richardlau","id":5445507,"node_id":"MDQ6VXNlcjU0NDU1MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/5445507?v=4","gravatar_id":"","url":"https://api.github.com/users/richardlau","html_url":"https://github.com/richardlau","followers_url":"https://api.github.com/users/richardlau/followers","following_url":"https://api.github.com/users/richardlau/following{/other_user}","gists_url":"https://api.github.com/users/richardlau/gists{/gist_id}","starred_url":"https://api.github.com/users/richardlau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardlau/subscriptions","organizations_url":"https://api.github.com/users/richardlau/orgs","repos_url":"https://api.github.com/users/richardlau/repos","events_url":"https://api.github.com/users/richardlau/events{/privacy}","received_events_url":"https://api.github.com/users/richardlau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-21T15:45:27Z","updated_at":"2018-12-21T15:45:29Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/25166","html_url":"https://github.com/nodejs/node/pull/25166","diff_url":"https://github.com/nodejs/node/pull/25166.diff","patch_url":"https://github.com/nodejs/node/pull/25166.patch"},"body":"Fixes the following error running `vcbuild.bat dll release openssl-no-asm`:\r\n```\r\n...\r\n  Finished generating code\r\n  node.vcxproj -> C:\\work\\node\\github\\node\\Release\\\\node-win.exe\r\n  rename_node_bin_win\r\n  'mv' is not recognized as an internal or external command,\r\n  operable program or batch file.\r\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Professional\\Common7\\IDE\\VC\\VCTargets\\Microsoft.CppCommon.targets(209,5): error MSB6006: \"cmd.exe\" exited with code 1. [C:\\work\\node\\github\\node\\rename_node_bin_win.vcxproj]\r\n```\r\n[Full build log](https://gist.github.com/richardlau/5347274123e92a6cecd0bd536fa9d935).\r\n\r\ncc @BethGriggs @rubys \r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/449422398","html_url":"https://github.com/nodejs/node/pull/25166#issuecomment-449422398","issue_url":"https://api.github.com/repos/nodejs/node/issues/25166","id":449422398,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTQyMjM5OA==","user":{"login":"nodejs-github-bot","id":18269663,"node_id":"MDQ6VXNlcjE4MjY5NjYz","avatar_url":"https://avatars1.githubusercontent.com/u/18269663?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs-github-bot","html_url":"https://github.com/nodejs-github-bot","followers_url":"https://api.github.com/users/nodejs-github-bot/followers","following_url":"https://api.github.com/users/nodejs-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/nodejs-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs-github-bot/subscriptions","organizations_url":"https://api.github.com/users/nodejs-github-bot/orgs","repos_url":"https://api.github.com/users/nodejs-github-bot/repos","events_url":"https://api.github.com/users/nodejs-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs-github-bot/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T15:45:29Z","updated_at":"2018-12-21T15:45:29Z","author_association":"NONE","body":"@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2026/pipeline"}}
{"actor":{"display_login":"nodejs-github-bot"}}