{"push_id":2818109658,"size":105,"distinct_size":105,"ref":"refs/heads/master","head":"17978719e4f1d3de6e3d1a00e4cd7a2116802f53","before":"977d77e9e250a323f64785042d9ad8412368c19a","commits":[{"sha":"6e1a536ad46fcd26f90ce2c0c47c66df45e67012","author":{"name":"emaxi","email":"e50cd7903a63eb404941ad1fe34498cff2c1a053@gmail.com"},"message":"Add missing documentation options to number_to_currency [ci skip]","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/6e1a536ad46fcd26f90ce2c0c47c66df45e67012"},{"sha":"87b6e6aa4328f16edd68978079f473169cceecbd","author":{"name":"Ana María Martínez Gómez","email":"fe1da491a6b9343f6ad9ed43a561384379dcbc49@gmail.com"},"message":"Use public_send in value_for_collection\n\nAvoid exposing private methods in view's helpers.\n\nFixes https://github.com/rails/rails/issues/33546","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/87b6e6aa4328f16edd68978079f473169cceecbd"},{"sha":"a9764dcc07cf9d6280b313da734d98e096b7d122","author":{"name":"Ana María Martínez Gómez","email":"d0adf700b21a04cf7eaef98223361344d0894e80@suse.de"},"message":"Use public_send in extract_values_from_collection\n\nAvoid exposing private methods in view's helpers. However, as\n`extract_values_from_collection` is only called from\n`options_from_collection_for_select` where `value_for_collection` is\npreviously called, this case was already covered. The change makes\nanyway sense for consistency and in case the code changes in the\nfuture.","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/a9764dcc07cf9d6280b313da734d98e096b7d122"},{"sha":"0c62e141a3fc9b2d00935bb99d2d5f465e1a4fb4","author":{"name":"Ana María Martínez Gómez","email":"d0adf700b21a04cf7eaef98223361344d0894e80@suse.de"},"message":"Add one more method affected in CHANGELOG","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/0c62e141a3fc9b2d00935bb99d2d5f465e1a4fb4"},{"sha":"4ca9fa11f9a9b5604371f260515c28a0f29cd921","author":{"name":"Ana María Martínez Gómez","email":"d0adf700b21a04cf7eaef98223361344d0894e80@suse.de"},"message":"Deprecate use of private methods in view's helpers\n\nInstead of dropping it completely in case someone is relying (probably\ninadvertenly) on it.","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/4ca9fa11f9a9b5604371f260515c28a0f29cd921"},{"sha":"0853cdffa2f09f02e854baed35c3323b6b35006f","author":{"name":"Ana María Martínez Gómez","email":"d0adf700b21a04cf7eaef98223361344d0894e80@suse.de"},"message":"Add tests for privates methods in view's helpers\n\nTest that using private methods in `options_from_collection_for_select`\nis deprecated.\n\nMake the unused `secret` paramether in the `Post` Struct private to use\nit in the test.","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/0853cdffa2f09f02e854baed35c3323b6b35006f"},{"sha":"33ce73edf1d1b02f4f50fc5d7565590468167d76","author":{"name":"Yasuo Honda","email":"815806a5fcba2cb411d0f70b662adf0091c5dee5@gmail.com"},"message":"SQLite3 adapter `alter_table` method restores foreign keys\nRelated to #33520","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/33ce73edf1d1b02f4f50fc5d7565590468167d76"},{"sha":"bef6c8bbe8faf2cf3538e9611eaddc0b2da4d038","author":{"name":"utilum","email":"526c6e03564b03e802becb61054ccdd90fe21861@utilum.com"},"message":"Stub with Minitest and test with MethodCallAssertions","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/bef6c8bbe8faf2cf3538e9611eaddc0b2da4d038"},{"sha":"a72bca82301bc4851f40945f85711f5cefd10178","author":{"name":"utilum","email":"526c6e03564b03e802becb61054ccdd90fe21861@utilum.com"},"message":"Add method_call_assertions and use them instead of Mocha\n\nSix Mocha calls prove quite resistant to Minitestification. For example,\nif we replace\n\n```\n  ActiveRecord::Associations::HasManyAssociation\n    .any_instance\n    .expects(:reader)\n    .never\n```\n\nwith `assert_not_called`, Minitest wisely raises\n\n```\nNameError: undefined method `reader' for class `ActiveRecord::Associations::HasManyAssociation'\n```\n\nas `:reader` comes from a deeply embedded abstract class,\n`ActiveRecord::Associations::CollectionAssociation`.\n\nThis patch tackles this difficulty by adding\n`ActiveSupport::Testing::MethodCallAsserts#assert_called_on_instance_of`\nwhich injects a stubbed method into `klass`, and verifies the number of\ntimes it is called, similar to `assert_called`. It also adds  a convenience\nmethod, `assert_not_called_on_instance_of`, mirroring\n`assert_not_called`.\n\nIt uses the new method_call_assertions to replace the remaining Mocha\ncalls in `ActiveRecord` tests.\n\n[utilum + bogdanvlviv + kspath]","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/a72bca82301bc4851f40945f85711f5cefd10178"},{"sha":"7d13e9de50e10ab49342ecff429d21d677560826","author":{"name":"utilum","email":"526c6e03564b03e802becb61054ccdd90fe21861@utilum.com"},"message":"Remove Mocha from Gemfile\n\n_Q.E.F._","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/7d13e9de50e10ab49342ecff429d21d677560826"},{"sha":"2fece9036d8ea778fca63a0d5df9a9dfc330dfa5","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Fix numericality validator not to be affected by custom getter\n\nSince fe9547b6, numericality validator would parse raw value only when a\nvalue came from user to work type casting to a value from database.\n\nBut that was caused a regression that the validator would work against\ngetter value instead of parsed raw value, a getter is sometimes\ncustomized by people. #33550\n\nThere we never guarantees that the value before type cast was going to\nthe used in this validation (actually here is only place that getter\nvalue might not be used), but we should not change the behavior unless\nthere is some particular reason.\n\nThe purpose of fe9547b6 is to work type casting to a value from\ndatabase. We could achieve the purpose by using `read_attribute`,\nwithout using getter value.\n\nFixes #33550.","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/2fece9036d8ea778fca63a0d5df9a9dfc330dfa5"},{"sha":"cdabcc2bd530af4184c2592619ea3fe0ddb2d9af","author":{"name":"Prem Sichanugrist","email":"a0f1490a20d0211c997b44bc357e1972deab8ae3@sikac.hu"},"message":"Update guide to mention code linters available\n\nContributors can run RuboCop locally to catch code style error in Ruby\ncode and npm lint task for `rails-ujs` CoffeeScript and JavaScript code.\n\n[skip ci]","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/cdabcc2bd530af4184c2592619ea3fe0ddb2d9af"},{"sha":"ec1630148853c46a1e3b35cd48bf85aa0e049d81","author":{"name":"Kevin Deisz","email":"600e94fb06921802751c4b237a82be9ef8e1c0c9@gmail.com"},"message":"Allow `perform_enqueued_jobs` to be called without a block.\n\nPerforms all of the jobs that have been enqueued up to this point in the test.","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/ec1630148853c46a1e3b35cd48bf85aa0e049d81"},{"sha":"0e0261b52e54ffcf9757819d41c85a314d64770c","author":{"name":"Vitor Oliveira","email":"5cb0eae4705d456c50efd146005d7b13804e8cb5@gmail.com"},"message":"Fix obsoleted method URI.unescape in activesupport/test","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/0e0261b52e54ffcf9757819d41c85a314d64770c"},{"sha":"c710ffa37ea57812c49b900b40ba66311f699dd5","author":{"name":"yuuji.yaginuma","email":"16356534c1589fe78070f5640bedf8614007153c@gmail.com"},"message":"Do not show deprecate task in the task list","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/c710ffa37ea57812c49b900b40ba66311f699dd5"},{"sha":"f6bbbb9f29dfdc36cef25ae911041eb01bd4369e","author":{"name":"Guillermo Iguaran","email":"5282eb8a112e0c62fe591e7e5c0a8d029936dc09@gmail.com"},"message":"Merge pull request #33626 from kddeisz/perform-enqueued-jobs-no-block\n\nAllow `perform_enqueued_jobs` to be called without a block.","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/f6bbbb9f29dfdc36cef25ae911041eb01bd4369e"},{"sha":"239a5af29f57330f468b19e1a8cb7b2c14836116","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Merge pull request #33627 from vbrazo/fixtures/fix-obsolete-methods\n\nFix obsoleted method URI.unescape in activesupport/test","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/239a5af29f57330f468b19e1a8cb7b2c14836116"},{"sha":"51bdbc2d0198c666cd62d1404c18da477e5cbfbc","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Enable Lint/UriEscapeUnescape cop not to allow using obsolete methods in the future\n\nFollow up #33627.","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/51bdbc2d0198c666cd62d1404c18da477e5cbfbc"},{"sha":"e33c3cd8ccbecaca6c6af0438956431b02cb3fb2","author":{"name":"George Claghorn","email":"f8b057b45279f5cf5e056a79e479e4c5c7e6ce59@gmail.com"},"message":"Extract ActiveStorage::SetCurrent\n\nProvide a handy concern for custom Active Storage controllers that can't inherit from ActiveStorage::BaseController.","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/e33c3cd8ccbecaca6c6af0438956431b02cb3fb2"},{"sha":"f169752163f3e2abfead4963751989d8cdea370c","author":{"name":"bogdanvlviv","email":"0432f6e91c72b299590585bdcfd70d05278d8041@gmail.com"},"message":"Add example `perform_enqueued_jobs` without block to api docs [ci skip]\n\nFollow up #33626","distinct":true,"url":"https://api.github.com/repos/kddeisz/rails/commits/f169752163f3e2abfead4963751989d8cdea370c"}]}
{"actor":{"display_login":"kddeisz"}}