{"action":"created","comment":{"url":"https://api.github.com/repos/pubnative/docker-images/pulls/comments/245003426","pull_request_review_id":189015633,"id":245003426,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTAwMzQyNg==","diff_hunk":"@@ -34,3 +34,6 @@ druid.storage.storageDirectory=var/druid/segments\n # For local disk (only viable in a cluster if this is a network mount):\n druid.indexer.logs.type=file\n druid.indexer.logs.directory=/tmp/druid/indexing-logs\n+\n+# Add extensions\n+druid.extensions.loadList=[\"druid-datasketches\"]","path":"druid/hadoop/common.runtime.properties","position":6,"original_position":6,"commit_id":"53cd32f467f262bb0c3c703c09a231b74815b6cf","original_commit_id":"53cd32f467f262bb0c3c703c09a231b74815b6cf","user":{"login":"jamedge","id":23177640,"node_id":"MDQ6VXNlcjIzMTc3NjQw","avatar_url":"https://avatars0.githubusercontent.com/u/23177640?v=4","gravatar_id":"","url":"https://api.github.com/users/jamedge","html_url":"https://github.com/jamedge","followers_url":"https://api.github.com/users/jamedge/followers","following_url":"https://api.github.com/users/jamedge/following{/other_user}","gists_url":"https://api.github.com/users/jamedge/gists{/gist_id}","starred_url":"https://api.github.com/users/jamedge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamedge/subscriptions","organizations_url":"https://api.github.com/users/jamedge/orgs","repos_url":"https://api.github.com/users/jamedge/repos","events_url":"https://api.github.com/users/jamedge/events{/privacy}","received_events_url":"https://api.github.com/users/jamedge/received_events","type":"User","site_admin":false},"body":"👍 I just confirmed that we use `druid-base` images for middle managers and `manager-hot`, so I'll add this extension there.","created_at":"2019-01-03T13:45:56Z","updated_at":"2019-01-03T13:45:56Z","html_url":"https://github.com/pubnative/docker-images/pull/58#discussion_r245003426","pull_request_url":"https://api.github.com/repos/pubnative/docker-images/pulls/58","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pubnative/docker-images/pulls/comments/245003426"},"html":{"href":"https://github.com/pubnative/docker-images/pull/58#discussion_r245003426"},"pull_request":{"href":"https://api.github.com/repos/pubnative/docker-images/pulls/58"}},"in_reply_to_id":245001515},"pull_request":{"url":"https://api.github.com/repos/pubnative/docker-images/pulls/58","id":241996389,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxOTk2Mzg5","html_url":"https://github.com/pubnative/docker-images/pull/58","diff_url":"https://github.com/pubnative/docker-images/pull/58.diff","patch_url":"https://github.com/pubnative/docker-images/pull/58.patch","issue_url":"https://api.github.com/repos/pubnative/docker-images/issues/58","number":58,"state":"open","locked":false,"title":"[DAT-664] add datasketches extension for druid","user":{"login":"jamedge","id":23177640,"node_id":"MDQ6VXNlcjIzMTc3NjQw","avatar_url":"https://avatars0.githubusercontent.com/u/23177640?v=4","gravatar_id":"","url":"https://api.github.com/users/jamedge","html_url":"https://github.com/jamedge","followers_url":"https://api.github.com/users/jamedge/followers","following_url":"https://api.github.com/users/jamedge/following{/other_user}","gists_url":"https://api.github.com/users/jamedge/gists{/gist_id}","starred_url":"https://api.github.com/users/jamedge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamedge/subscriptions","organizations_url":"https://api.github.com/users/jamedge/orgs","repos_url":"https://api.github.com/users/jamedge/repos","events_url":"https://api.github.com/users/jamedge/events{/privacy}","received_events_url":"https://api.github.com/users/jamedge/received_events","type":"User","site_admin":false},"body":"Add `druid-datasketches` extension based on http://druid.io/docs/latest/development/extensions-core/datasketches-theta.html.","created_at":"2019-01-03T13:35:18Z","updated_at":"2019-01-03T13:45:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bcd5ec44becbbfa80dc1b8b28b7e99195f39863","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pubnative/docker-images/pulls/58/commits","review_comments_url":"https://api.github.com/repos/pubnative/docker-images/pulls/58/comments","review_comment_url":"https://api.github.com/repos/pubnative/docker-images/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pubnative/docker-images/issues/58/comments","statuses_url":"https://api.github.com/repos/pubnative/docker-images/statuses/53cd32f467f262bb0c3c703c09a231b74815b6cf","head":{"label":"pubnative:DAT-664-add-theta-schetches-to-druid","ref":"DAT-664-add-theta-schetches-to-druid","sha":"53cd32f467f262bb0c3c703c09a231b74815b6cf","user":{"login":"pubnative","id":7806659,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDY2NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7806659?v=4","gravatar_id":"","url":"https://api.github.com/users/pubnative","html_url":"https://github.com/pubnative","followers_url":"https://api.github.com/users/pubnative/followers","following_url":"https://api.github.com/users/pubnative/following{/other_user}","gists_url":"https://api.github.com/users/pubnative/gists{/gist_id}","starred_url":"https://api.github.com/users/pubnative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pubnative/subscriptions","organizations_url":"https://api.github.com/users/pubnative/orgs","repos_url":"https://api.github.com/users/pubnative/repos","events_url":"https://api.github.com/users/pubnative/events{/privacy}","received_events_url":"https://api.github.com/users/pubnative/received_events","type":"Organization","site_admin":false},"repo":{"id":48115903,"node_id":"MDEwOlJlcG9zaXRvcnk0ODExNTkwMw==","name":"docker-images","full_name":"pubnative/docker-images","private":false,"owner":{"login":"pubnative","id":7806659,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDY2NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7806659?v=4","gravatar_id":"","url":"https://api.github.com/users/pubnative","html_url":"https://github.com/pubnative","followers_url":"https://api.github.com/users/pubnative/followers","following_url":"https://api.github.com/users/pubnative/following{/other_user}","gists_url":"https://api.github.com/users/pubnative/gists{/gist_id}","starred_url":"https://api.github.com/users/pubnative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pubnative/subscriptions","organizations_url":"https://api.github.com/users/pubnative/orgs","repos_url":"https://api.github.com/users/pubnative/repos","events_url":"https://api.github.com/users/pubnative/events{/privacy}","received_events_url":"https://api.github.com/users/pubnative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pubnative/docker-images","description":"Simple Docker Recipes to be modern and in trend ","fork":false,"url":"https://api.github.com/repos/pubnative/docker-images","forks_url":"https://api.github.com/repos/pubnative/docker-images/forks","keys_url":"https://api.github.com/repos/pubnative/docker-images/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pubnative/docker-images/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pubnative/docker-images/teams","hooks_url":"https://api.github.com/repos/pubnative/docker-images/hooks","issue_events_url":"https://api.github.com/repos/pubnative/docker-images/issues/events{/number}","events_url":"https://api.github.com/repos/pubnative/docker-images/events","assignees_url":"https://api.github.com/repos/pubnative/docker-images/assignees{/user}","branches_url":"https://api.github.com/repos/pubnative/docker-images/branches{/branch}","tags_url":"https://api.github.com/repos/pubnative/docker-images/tags","blobs_url":"https://api.github.com/repos/pubnative/docker-images/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pubnative/docker-images/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pubnative/docker-images/git/refs{/sha}","trees_url":"https://api.github.com/repos/pubnative/docker-images/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pubnative/docker-images/statuses/{sha}","languages_url":"https://api.github.com/repos/pubnative/docker-images/languages","stargazers_url":"https://api.github.com/repos/pubnative/docker-images/stargazers","contributors_url":"https://api.github.com/repos/pubnative/docker-images/contributors","subscribers_url":"https://api.github.com/repos/pubnative/docker-images/subscribers","subscription_url":"https://api.github.com/repos/pubnative/docker-images/subscription","commits_url":"https://api.github.com/repos/pubnative/docker-images/commits{/sha}","git_commits_url":"https://api.github.com/repos/pubnative/docker-images/git/commits{/sha}","comments_url":"https://api.github.com/repos/pubnative/docker-images/comments{/number}","issue_comment_url":"https://api.github.com/repos/pubnative/docker-images/issues/comments{/number}","contents_url":"https://api.github.com/repos/pubnative/docker-images/contents/{+path}","compare_url":"https://api.github.com/repos/pubnative/docker-images/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pubnative/docker-images/merges","archive_url":"https://api.github.com/repos/pubnative/docker-images/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pubnative/docker-images/downloads","issues_url":"https://api.github.com/repos/pubnative/docker-images/issues{/number}","pulls_url":"https://api.github.com/repos/pubnative/docker-images/pulls{/number}","milestones_url":"https://api.github.com/repos/pubnative/docker-images/milestones{/number}","notifications_url":"https://api.github.com/repos/pubnative/docker-images/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pubnative/docker-images/labels{/name}","releases_url":"https://api.github.com/repos/pubnative/docker-images/releases{/id}","deployments_url":"https://api.github.com/repos/pubnative/docker-images/deployments","created_at":"2015-12-16T14:42:35Z","updated_at":"2018-11-20T14:48:07Z","pushed_at":"2019-01-03T13:35:18Z","git_url":"git://github.com/pubnative/docker-images.git","ssh_url":"git@github.com:pubnative/docker-images.git","clone_url":"https://github.com/pubnative/docker-images.git","svn_url":"https://github.com/pubnative/docker-images","homepage":null,"size":160,"stargazers_count":9,"watchers_count":9,"language":"Dockerfile","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":3,"watchers":9,"default_branch":"master"}},"base":{"label":"pubnative:master","ref":"master","sha":"67238ffcb69a4f80be68600c1014cc86f185358b","user":{"login":"pubnative","id":7806659,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDY2NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7806659?v=4","gravatar_id":"","url":"https://api.github.com/users/pubnative","html_url":"https://github.com/pubnative","followers_url":"https://api.github.com/users/pubnative/followers","following_url":"https://api.github.com/users/pubnative/following{/other_user}","gists_url":"https://api.github.com/users/pubnative/gists{/gist_id}","starred_url":"https://api.github.com/users/pubnative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pubnative/subscriptions","organizations_url":"https://api.github.com/users/pubnative/orgs","repos_url":"https://api.github.com/users/pubnative/repos","events_url":"https://api.github.com/users/pubnative/events{/privacy}","received_events_url":"https://api.github.com/users/pubnative/received_events","type":"Organization","site_admin":false},"repo":{"id":48115903,"node_id":"MDEwOlJlcG9zaXRvcnk0ODExNTkwMw==","name":"docker-images","full_name":"pubnative/docker-images","private":false,"owner":{"login":"pubnative","id":7806659,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDY2NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7806659?v=4","gravatar_id":"","url":"https://api.github.com/users/pubnative","html_url":"https://github.com/pubnative","followers_url":"https://api.github.com/users/pubnative/followers","following_url":"https://api.github.com/users/pubnative/following{/other_user}","gists_url":"https://api.github.com/users/pubnative/gists{/gist_id}","starred_url":"https://api.github.com/users/pubnative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pubnative/subscriptions","organizations_url":"https://api.github.com/users/pubnative/orgs","repos_url":"https://api.github.com/users/pubnative/repos","events_url":"https://api.github.com/users/pubnative/events{/privacy}","received_events_url":"https://api.github.com/users/pubnative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pubnative/docker-images","description":"Simple Docker Recipes to be modern and in trend ","fork":false,"url":"https://api.github.com/repos/pubnative/docker-images","forks_url":"https://api.github.com/repos/pubnative/docker-images/forks","keys_url":"https://api.github.com/repos/pubnative/docker-images/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pubnative/docker-images/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pubnative/docker-images/teams","hooks_url":"https://api.github.com/repos/pubnative/docker-images/hooks","issue_events_url":"https://api.github.com/repos/pubnative/docker-images/issues/events{/number}","events_url":"https://api.github.com/repos/pubnative/docker-images/events","assignees_url":"https://api.github.com/repos/pubnative/docker-images/assignees{/user}","branches_url":"https://api.github.com/repos/pubnative/docker-images/branches{/branch}","tags_url":"https://api.github.com/repos/pubnative/docker-images/tags","blobs_url":"https://api.github.com/repos/pubnative/docker-images/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pubnative/docker-images/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pubnative/docker-images/git/refs{/sha}","trees_url":"https://api.github.com/repos/pubnative/docker-images/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pubnative/docker-images/statuses/{sha}","languages_url":"https://api.github.com/repos/pubnative/docker-images/languages","stargazers_url":"https://api.github.com/repos/pubnative/docker-images/stargazers","contributors_url":"https://api.github.com/repos/pubnative/docker-images/contributors","subscribers_url":"https://api.github.com/repos/pubnative/docker-images/subscribers","subscription_url":"https://api.github.com/repos/pubnative/docker-images/subscription","commits_url":"https://api.github.com/repos/pubnative/docker-images/commits{/sha}","git_commits_url":"https://api.github.com/repos/pubnative/docker-images/git/commits{/sha}","comments_url":"https://api.github.com/repos/pubnative/docker-images/comments{/number}","issue_comment_url":"https://api.github.com/repos/pubnative/docker-images/issues/comments{/number}","contents_url":"https://api.github.com/repos/pubnative/docker-images/contents/{+path}","compare_url":"https://api.github.com/repos/pubnative/docker-images/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pubnative/docker-images/merges","archive_url":"https://api.github.com/repos/pubnative/docker-images/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pubnative/docker-images/downloads","issues_url":"https://api.github.com/repos/pubnative/docker-images/issues{/number}","pulls_url":"https://api.github.com/repos/pubnative/docker-images/pulls{/number}","milestones_url":"https://api.github.com/repos/pubnative/docker-images/milestones{/number}","notifications_url":"https://api.github.com/repos/pubnative/docker-images/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pubnative/docker-images/labels{/name}","releases_url":"https://api.github.com/repos/pubnative/docker-images/releases{/id}","deployments_url":"https://api.github.com/repos/pubnative/docker-images/deployments","created_at":"2015-12-16T14:42:35Z","updated_at":"2018-11-20T14:48:07Z","pushed_at":"2019-01-03T13:35:18Z","git_url":"git://github.com/pubnative/docker-images.git","ssh_url":"git@github.com:pubnative/docker-images.git","clone_url":"https://github.com/pubnative/docker-images.git","svn_url":"https://github.com/pubnative/docker-images","homepage":null,"size":160,"stargazers_count":9,"watchers_count":9,"language":"Dockerfile","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pubnative/docker-images/pulls/58"},"html":{"href":"https://github.com/pubnative/docker-images/pull/58"},"issue":{"href":"https://api.github.com/repos/pubnative/docker-images/issues/58"},"comments":{"href":"https://api.github.com/repos/pubnative/docker-images/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/pubnative/docker-images/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/pubnative/docker-images/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pubnative/docker-images/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/pubnative/docker-images/statuses/53cd32f467f262bb0c3c703c09a231b74815b6cf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jamedge"}}