{"action":"created","issue":{"url":"https://api.github.com/repos/python/cpython/issues/11159","repository_url":"https://api.github.com/repos/python/cpython","labels_url":"https://api.github.com/repos/python/cpython/issues/11159/labels{/name}","comments_url":"https://api.github.com/repos/python/cpython/issues/11159/comments","events_url":"https://api.github.com/repos/python/cpython/issues/11159/events","html_url":"https://github.com/python/cpython/pull/11159","id":391092485,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NzA2Nzk4","number":11159,"title":"bpo-35348: Fix platform.architecture()","user":{"login":"vstinner","id":194129,"node_id":"MDQ6VXNlcjE5NDEyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/194129?v=4","gravatar_id":"","url":"https://api.github.com/users/vstinner","html_url":"https://github.com/vstinner","followers_url":"https://api.github.com/users/vstinner/followers","following_url":"https://api.github.com/users/vstinner/following{/other_user}","gists_url":"https://api.github.com/users/vstinner/gists{/gist_id}","starred_url":"https://api.github.com/users/vstinner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vstinner/subscriptions","organizations_url":"https://api.github.com/users/vstinner/orgs","repos_url":"https://api.github.com/users/vstinner/repos","events_url":"https://api.github.com/users/vstinner/events{/privacy}","received_events_url":"https://api.github.com/users/vstinner/received_events","type":"User","site_admin":false},"labels":[{"id":536945472,"node_id":"MDU6TGFiZWw1MzY5NDU0NzI=","url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666980059,"node_id":"MDU6TGFiZWw2NjY5ODAwNTk=","url":"https://api.github.com/repos/python/cpython/labels/awaiting%20merge","name":"awaiting merge","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-14T12:29:40Z","updated_at":"2018-12-17T09:59:00Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/11159","html_url":"https://github.com/python/cpython/pull/11159","diff_url":"https://github.com/python/cpython/pull/11159.diff","patch_url":"https://github.com/python/cpython/pull/11159.patch"},"body":"Fix platform.architecture(): add the -b option to the \"file\" command.\n\n<!-- issue-number: [bpo-35348](https://bugs.python.org/issue35348) -->\nhttps://bugs.python.org/issue35348\n<!-- /issue-number -->\n"},"comment":{"url":"https://api.github.com/repos/python/cpython/issues/comments/447786558","html_url":"https://github.com/python/cpython/pull/11159#issuecomment-447786558","issue_url":"https://api.github.com/repos/python/cpython/issues/11159","id":447786558,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzc4NjU1OA==","user":{"login":"vstinner","id":194129,"node_id":"MDQ6VXNlcjE5NDEyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/194129?v=4","gravatar_id":"","url":"https://api.github.com/users/vstinner","html_url":"https://github.com/vstinner","followers_url":"https://api.github.com/users/vstinner/followers","following_url":"https://api.github.com/users/vstinner/following{/other_user}","gists_url":"https://api.github.com/users/vstinner/gists{/gist_id}","starred_url":"https://api.github.com/users/vstinner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vstinner/subscriptions","organizations_url":"https://api.github.com/users/vstinner/orgs","repos_url":"https://api.github.com/users/vstinner/repos","events_url":"https://api.github.com/users/vstinner/events{/privacy}","received_events_url":"https://api.github.com/users/vstinner/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T09:59:00Z","updated_at":"2018-12-17T09:59:00Z","author_association":"MEMBER","body":"I removed \"--\" from \"file -b -- target\". If target starts with \"-\", file will fail since the filename miss. Example:\r\n\r\n```\r\n$ file -b -b\r\nUsage: file [-bcCdEhikLlNnprsvzZ0] [--apple] [--extension] [--mime-encoding]\r\n            [--mime-type] [-e <testname>] [-F <separator>]  [-f <namefile>]\r\n            [-m <magicfiles>] [-P <parameter=value>] <file> ...\r\n       file -C [-m <magicfiles>]\r\n       file [--help]\r\n\r\n$ echo $?\r\n1\r\n```\r\n\r\nThis change should prevent portability issue.\r\n\r\n> Could you then borrow other changes from #11160?\r\n\r\nSure. I picked your changes into my PR and I credited you.\r\n\r\nI replaced env={'LC_ALL': 'C'} with env=dict(os.environ, LC_ALL='C'). Few programs like to run in an (almost) empty environment.\r\n\r\nI wasn't sure if you preferred to push your changes separately or not. "}}
{"actor":{"display_login":"vstinner"}}