{"action":"opened","number":688,"pull_request":{"url":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/688","id":192987441,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyOTg3NDQx","html_url":"https://github.com/appium/appium-xcuitest-driver/pull/688","diff_url":"https://github.com/appium/appium-xcuitest-driver/pull/688.diff","patch_url":"https://github.com/appium/appium-xcuitest-driver/pull/688.patch","issue_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues/688","number":688,"state":"open","locked":false,"title":"throw NoAlertOpenError when getAlertText fails not in web context","user":{"login":"studuffy","id":7681479,"node_id":"MDQ6VXNlcjc2ODE0Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7681479?v=4","gravatar_id":"","url":"https://api.github.com/users/studuffy","html_url":"https://github.com/studuffy","followers_url":"https://api.github.com/users/studuffy/followers","following_url":"https://api.github.com/users/studuffy/following{/other_user}","gists_url":"https://api.github.com/users/studuffy/gists{/gist_id}","starred_url":"https://api.github.com/users/studuffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studuffy/subscriptions","organizations_url":"https://api.github.com/users/studuffy/orgs","repos_url":"https://api.github.com/users/studuffy/repos","events_url":"https://api.github.com/users/studuffy/events{/privacy}","received_events_url":"https://api.github.com/users/studuffy/received_events","type":"User","site_admin":false},"body":"We encountered an issue running the latest appium version on iOS when attempting to wait for an alert to appear in the appium java client. The wait step would fail immediately regardless of the time given since the exception returned was not of type `NoAlertPresentException`. The expected condition `alertIsPresent` in Selenium uses `getAlertText` under the hood to check for its presence.\r\n\r\nAfter spending some time debugging, I found the `getAlertText` command was throwing an error of no specific class (not one of those defined in [here](https://github.com/appium/appium-base-driver/blob/master/lib/protocol/errors.js#L682)), which when parsed was resulting in an unknown error (status 13) being returned to the client.\r\n\r\nIt looked like many of the other alert commands here throw the NoAlertOpenError class in the non web context case, so I couldn't see a reason why not to do that for getAlertText too. It certainly solved the problem I was seeing.\r\n\r\nHope this change is fine to merge - if not maybe it will start a discussion of a better solution to the problem.","created_at":"2018-06-06T11:49:57Z","updated_at":"2018-06-06T11:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/688/commits","review_comments_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/688/comments","review_comment_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues/688/comments","statuses_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/statuses/ebc8ac8d74b1edd7073b1623a17ada17a5a1d0f9","head":{"label":"studuffy:throw_no_alert_open_error","ref":"throw_no_alert_open_error","sha":"ebc8ac8d74b1edd7073b1623a17ada17a5a1d0f9","user":{"login":"studuffy","id":7681479,"node_id":"MDQ6VXNlcjc2ODE0Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7681479?v=4","gravatar_id":"","url":"https://api.github.com/users/studuffy","html_url":"https://github.com/studuffy","followers_url":"https://api.github.com/users/studuffy/followers","following_url":"https://api.github.com/users/studuffy/following{/other_user}","gists_url":"https://api.github.com/users/studuffy/gists{/gist_id}","starred_url":"https://api.github.com/users/studuffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studuffy/subscriptions","organizations_url":"https://api.github.com/users/studuffy/orgs","repos_url":"https://api.github.com/users/studuffy/repos","events_url":"https://api.github.com/users/studuffy/events{/privacy}","received_events_url":"https://api.github.com/users/studuffy/received_events","type":"User","site_admin":false},"repo":{"id":136317828,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzMTc4Mjg=","name":"appium-xcuitest-driver","full_name":"studuffy/appium-xcuitest-driver","owner":{"login":"studuffy","id":7681479,"node_id":"MDQ6VXNlcjc2ODE0Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7681479?v=4","gravatar_id":"","url":"https://api.github.com/users/studuffy","html_url":"https://github.com/studuffy","followers_url":"https://api.github.com/users/studuffy/followers","following_url":"https://api.github.com/users/studuffy/following{/other_user}","gists_url":"https://api.github.com/users/studuffy/gists{/gist_id}","starred_url":"https://api.github.com/users/studuffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studuffy/subscriptions","organizations_url":"https://api.github.com/users/studuffy/orgs","repos_url":"https://api.github.com/users/studuffy/repos","events_url":"https://api.github.com/users/studuffy/events{/privacy}","received_events_url":"https://api.github.com/users/studuffy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/studuffy/appium-xcuitest-driver","description":"Appium iOS driver, backed by Apple XCUITest ","fork":true,"url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver","forks_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/forks","keys_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/teams","hooks_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/hooks","issue_events_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/issues/events{/number}","events_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/events","assignees_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/assignees{/user}","branches_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/branches{/branch}","tags_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/tags","blobs_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/languages","stargazers_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/stargazers","contributors_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/contributors","subscribers_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/subscribers","subscription_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/subscription","commits_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/contents/{+path}","compare_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/merges","archive_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/downloads","issues_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/issues{/number}","pulls_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/labels{/name}","releases_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/releases{/id}","deployments_url":"https://api.github.com/repos/studuffy/appium-xcuitest-driver/deployments","created_at":"2018-06-06T11:16:02Z","updated_at":"2018-06-06T11:16:05Z","pushed_at":"2018-06-06T11:26:38Z","git_url":"git://github.com/studuffy/appium-xcuitest-driver.git","ssh_url":"git@github.com:studuffy/appium-xcuitest-driver.git","clone_url":"https://github.com/studuffy/appium-xcuitest-driver.git","svn_url":"https://github.com/studuffy/appium-xcuitest-driver","homepage":null,"size":25656,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"29e0aedefc71e534f1a1e69c55f1b56256ce2c36","user":{"login":"appium","id":3221291,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjEyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":47652761,"node_id":"MDEwOlJlcG9zaXRvcnk0NzY1Mjc2MQ==","name":"appium-xcuitest-driver","full_name":"appium/appium-xcuitest-driver","owner":{"login":"appium","id":3221291,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjEyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/appium-xcuitest-driver","description":"Appium iOS driver, backed by Apple XCUITest ","fork":false,"url":"https://api.github.com/repos/appium/appium-xcuitest-driver","forks_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/forks","keys_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/teams","hooks_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/events","assignees_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/tags","blobs_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/languages","stargazers_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/subscription","commits_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/merges","archive_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/downloads","issues_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/releases{/id}","deployments_url":"https://api.github.com/repos/appium/appium-xcuitest-driver/deployments","created_at":"2015-12-08T22:11:37Z","updated_at":"2018-06-04T16:24:55Z","pushed_at":"2018-06-06T11:09:04Z","git_url":"git://github.com/appium/appium-xcuitest-driver.git","ssh_url":"git@github.com:appium/appium-xcuitest-driver.git","clone_url":"https://github.com/appium/appium-xcuitest-driver.git","svn_url":"https://github.com/appium/appium-xcuitest-driver","homepage":null,"size":25656,"stargazers_count":211,"watchers_count":211,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":164,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":164,"open_issues":3,"watchers":211,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/688"},"html":{"href":"https://github.com/appium/appium-xcuitest-driver/pull/688"},"issue":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues/688"},"comments":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/issues/688/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/688/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/pulls/688/commits"},"statuses":{"href":"https://api.github.com/repos/appium/appium-xcuitest-driver/statuses/ebc8ac8d74b1edd7073b1623a17ada17a5a1d0f9"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"studuffy"}}