{"push_id":2705251225,"size":8,"distinct_size":1,"ref":"refs/heads/qemu_memory_dynamicOwnership","head":"6c238e8b7a1ff62722ff5b8df4161e0280809f0c","before":"f89b07d306a08e1c80911b63cb82f1a86649d8c7","commits":[{"sha":"87d80b50c6a3235704c4b1a91742e1978dfdbbaa","author":{"name":"Michal Privoznik","email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com"},"message":"qemuBuildSCSIiSCSIHostdevDrvStr: Don't leak @netsource and @srcprops\n\nAfter 6b770f9a3bdabb1 both @netsource and @srcprops are leaked\nbecause of early return introduced in the commit.\n\n==1812== 644 bytes in 4 blocks are definitely lost in loss record 835 of 885\n==1812==    at 0x4C2F12F: realloc (vg_replace_malloc.c:785)\n==1812==    by 0x8846393: xmlSaveUriRealloc (in /usr/lib64/libxml2.so.2.9.8)\n==1812==    by 0x8846B1C: xmlSaveUri (in /usr/lib64/libxml2.so.2.9.8)\n==1812==    by 0x5DDA619: virURIFormat (viruri.c:256)\n==1812==    by 0x56E941B: qemuBuildNetworkDriveURI (qemu_command.c:781)\n==1812==    by 0x56E979A: qemuBuildNetworkDriveStr (qemu_command.c:859)\n==1812==    by 0x56F3A0B: qemuBuildSCSIiSCSIHostdevDrvStr (qemu_command.c:4664)\n==1812==    by 0x56F3D1F: qemuBuildSCSIHostdevDrvStr (qemu_command.c:4732)\n==1812==    by 0x56F57F7: qemuBuildHostdevCommandLine (qemu_command.c:5337)\n==1812==    by 0x570303A: qemuBuildCommandLine (qemu_command.c:10376)\n==1812==    by 0x57604EE: qemuProcessCreatePretendCmd (qemu_process.c:6649)\n==1812==    by 0x11352A: testCompareXMLToArgv (qemuxml2argvtest.c:566)\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/87d80b50c6a3235704c4b1a91742e1978dfdbbaa"},{"sha":"3087b27cffdd46ad0e953e061d6f3c519aefd5d8","author":{"name":"Michal Privoznik","email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com"},"message":"domain_nwfilter: Return early if net has no name in virDomainConfNWFilterTeardownImpl\n\nThis function is called from various clean up paths (e.g.\nfrom qemuBuildInterfaceCommandLine). However, depending on the\nstage the interface creation process failed at, net->ifname might\nstill be not filled in when control jumps to cleanup label. If\nthat is the case return early (avoiding useless error message\nproduced in virNWFilterBindingLookupByPortDev) as there is no\nNWFilter to tear down anyway.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>\nReviewed-by: Erik Skultety <eskultet@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/3087b27cffdd46ad0e953e061d6f3c519aefd5d8"},{"sha":"1e65d35b047959af7a033aad4cc364e4cf87b17b","author":{"name":"Peter Krempa","email":"2cf5c04c61aa466e4a47bfedc747d17279c72ffc@redhat.com"},"message":"qemu: monitor: Remove qemuMonitorJSONExtractCPUArchInfo wrapper\n\nThe wraper is quite pointless and also the 'arch' field may depend on\nwhether query-cpus-fast is used.\n\nSigned-off-by: Peter Krempa <pkrempa@redhat.com>\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/1e65d35b047959af7a033aad4cc364e4cf87b17b"},{"sha":"902f4bce098d68c48899fc1c42ec1552f2104995","author":{"name":"Peter Krempa","email":"2cf5c04c61aa466e4a47bfedc747d17279c72ffc@redhat.com"},"message":"qemu: monitor: Use 'target' instead of 'arch' in reply of 'query-cpus-fast'\n\nqemu changed the output field name for the architecture from 'arch' to\n'target'. Note the change and fix the code so that the arch-specific\nextraction works.\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1598829\n\nSigned-off-by: Peter Krempa <pkrempa@redhat.com>\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/902f4bce098d68c48899fc1c42ec1552f2104995"},{"sha":"78eb8895ebdeb7fe31940fbcd789cf30da0508ef","author":{"name":"Boris Fiuczynski","email":"2648abdd55bfebf313fd324b464b047e6eea300e@linux.ibm.com"},"message":"qemu: Fix typo in qemu_command.c\n\nRename qemuBulildFloppyCommandLineOptions into\nqemuBuildFloppyCommandLineOptions.\n\nSigned-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/78eb8895ebdeb7fe31940fbcd789cf30da0508ef"},{"sha":"31cd4dd8e7b1aef1384b94b70bbb0cc262f3d3a5","author":{"name":"Han Han","email":"2f3eec96101b6aa65baff01c5b79fa5c74aa8195@redhat.com"},"message":"virsh: usb support for virsh attach-disk --address\n\nAdding usb bus address support to the optional address parameter\nof virsh attach-disk. The address is used as bus:port. e.g. usb:1:1.\n\nSigned-off-by: Han Han <hhan@redhat.com>\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/31cd4dd8e7b1aef1384b94b70bbb0cc262f3d3a5"},{"sha":"e11515ef8d77bb93b2c830c716e3b7ce65386907","author":{"name":"Han Han","email":"2f3eec96101b6aa65baff01c5b79fa5c74aa8195@redhat.com"},"message":"virsh: sata support for virsh attach-disk --address\n\nAdding sata bus address support to the optional address parameter of virsh\nattach-disk. The address is used as controller.bus.unit. e.g.\nsata:0.0.0\n\nSigned-off-by: Han Han <hhan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/e11515ef8d77bb93b2c830c716e3b7ce65386907"},{"sha":"6c238e8b7a1ff62722ff5b8df4161e0280809f0c","author":{"name":"Michal Privoznik","email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com"},"message":"qemuDomainSaveMemory: Don't enforce dynamicOwnership\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1589115\n\nWhen doing a memory snapshot qemuOpenFile() is used. This means\nthat the file where memory is saved is firstly attempted to be\ncreated under root:root (because that's what libvirtd is running\nunder) and if this fails the second attempt is done under\ndomain's uid:gid. This does not make much sense - qemu is given\nopened FD so it does not need to access the file. Moreover, if\ndynamicOwnership is set in qemu.conf and the file lives on a\nsquashed NFS this is deadly combination and very likely to fail.\n\nThe fix consists of using:\n\n  qemuOpenFileAs(fallback_uid = cfg->user,\n                 fallback_gid = cfg->group,\n                 dynamicOwnership = false)\n\nIn other words, dynamicOwnership is turned off for memory\nsnapshot (chown() will still be attempted if the file does not\nlive on NFS) and instead of using domain DAC label, configured\nuser:group is set as fallback.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/zippy2/libvirt/commits/6c238e8b7a1ff62722ff5b8df4161e0280809f0c"}]}
{"actor":{"display_login":"zippy2"}}