{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments/205864309","pull_request_review_id":141224797,"id":205864309,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTg2NDMwOQ==","diff_hunk":"@@ -0,0 +1,222 @@\n+package addons\n+\n+import (\n+\t\"reflect\"\n+\t\"testing\"\n+\n+\t\"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured\"\n+)\n+\n+func TestClean(t *testing.T) {\n+\ttests := []struct {","path":"pkg/addons/clean_test.go","position":16,"original_position":11,"commit_id":"11efc4ae0672eeb6e46e3f667a702f1cfe79b28e","original_commit_id":"5c4dae7df4543d52e44b35172203ba6572f70a90","user":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"body":"not really - take a look at https://github.com/jim-minter/openshift-azure/commit/tests for what I had in mind","created_at":"2018-07-27T18:36:50Z","updated_at":"2018-07-27T18:36:50Z","html_url":"https://github.com/openshift/openshift-azure/pull/109#discussion_r205864309","pull_request_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/109","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments/205864309"},"html":{"href":"https://github.com/openshift/openshift-azure/pull/109#discussion_r205864309"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/109"}},"in_reply_to_id":205620516},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-azure/pulls/109","id":204106823,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTA2ODIz","html_url":"https://github.com/openshift/openshift-azure/pull/109","diff_url":"https://github.com/openshift/openshift-azure/pull/109.diff","patch_url":"https://github.com/openshift/openshift-azure/pull/109.patch","issue_url":"https://api.github.com/repos/openshift/openshift-azure/issues/109","number":109,"state":"open","locked":false,"title":"add unit tests (1)","user":{"login":"mjudeikis","id":3225744,"node_id":"MDQ6VXNlcjMyMjU3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3225744?v=4","gravatar_id":"","url":"https://api.github.com/users/mjudeikis","html_url":"https://github.com/mjudeikis","followers_url":"https://api.github.com/users/mjudeikis/followers","following_url":"https://api.github.com/users/mjudeikis/following{/other_user}","gists_url":"https://api.github.com/users/mjudeikis/gists{/gist_id}","starred_url":"https://api.github.com/users/mjudeikis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjudeikis/subscriptions","organizations_url":"https://api.github.com/users/mjudeikis/orgs","repos_url":"https://api.github.com/users/mjudeikis/repos","events_url":"https://api.github.com/users/mjudeikis/events{/privacy}","received_events_url":"https://api.github.com/users/mjudeikis/received_events","type":"User","site_admin":false},"body":"We need to start at some point... ","created_at":"2018-07-26T11:07:49Z","updated_at":"2018-07-27T18:36:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23daebad4a703fd795b731f2ca906aa6c6a3e41c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":984233114,"node_id":"MDU6TGFiZWw5ODQyMzMxMTQ=","url":"https://api.github.com/repos/openshift/openshift-azure/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":1006517260,"node_id":"MDU6TGFiZWwxMDA2NTE3MjYw","url":"https://api.github.com/repos/openshift/openshift-azure/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/109/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/109/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-azure/issues/109/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-azure/statuses/11efc4ae0672eeb6e46e3f667a702f1cfe79b28e","head":{"label":"mjudeikis:tests","ref":"tests","sha":"11efc4ae0672eeb6e46e3f667a702f1cfe79b28e","user":{"login":"mjudeikis","id":3225744,"node_id":"MDQ6VXNlcjMyMjU3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3225744?v=4","gravatar_id":"","url":"https://api.github.com/users/mjudeikis","html_url":"https://github.com/mjudeikis","followers_url":"https://api.github.com/users/mjudeikis/followers","following_url":"https://api.github.com/users/mjudeikis/following{/other_user}","gists_url":"https://api.github.com/users/mjudeikis/gists{/gist_id}","starred_url":"https://api.github.com/users/mjudeikis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjudeikis/subscriptions","organizations_url":"https://api.github.com/users/mjudeikis/orgs","repos_url":"https://api.github.com/users/mjudeikis/repos","events_url":"https://api.github.com/users/mjudeikis/events{/privacy}","received_events_url":"https://api.github.com/users/mjudeikis/received_events","type":"User","site_admin":false},"repo":{"id":139452008,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0NTIwMDg=","name":"openshift-azure","full_name":"mjudeikis/openshift-azure","owner":{"login":"mjudeikis","id":3225744,"node_id":"MDQ6VXNlcjMyMjU3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3225744?v=4","gravatar_id":"","url":"https://api.github.com/users/mjudeikis","html_url":"https://github.com/mjudeikis","followers_url":"https://api.github.com/users/mjudeikis/followers","following_url":"https://api.github.com/users/mjudeikis/following{/other_user}","gists_url":"https://api.github.com/users/mjudeikis/gists{/gist_id}","starred_url":"https://api.github.com/users/mjudeikis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjudeikis/subscriptions","organizations_url":"https://api.github.com/users/mjudeikis/orgs","repos_url":"https://api.github.com/users/mjudeikis/repos","events_url":"https://api.github.com/users/mjudeikis/events{/privacy}","received_events_url":"https://api.github.com/users/mjudeikis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjudeikis/openshift-azure","description":null,"fork":true,"url":"https://api.github.com/repos/mjudeikis/openshift-azure","forks_url":"https://api.github.com/repos/mjudeikis/openshift-azure/forks","keys_url":"https://api.github.com/repos/mjudeikis/openshift-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjudeikis/openshift-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjudeikis/openshift-azure/teams","hooks_url":"https://api.github.com/repos/mjudeikis/openshift-azure/hooks","issue_events_url":"https://api.github.com/repos/mjudeikis/openshift-azure/issues/events{/number}","events_url":"https://api.github.com/repos/mjudeikis/openshift-azure/events","assignees_url":"https://api.github.com/repos/mjudeikis/openshift-azure/assignees{/user}","branches_url":"https://api.github.com/repos/mjudeikis/openshift-azure/branches{/branch}","tags_url":"https://api.github.com/repos/mjudeikis/openshift-azure/tags","blobs_url":"https://api.github.com/repos/mjudeikis/openshift-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjudeikis/openshift-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjudeikis/openshift-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjudeikis/openshift-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjudeikis/openshift-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/mjudeikis/openshift-azure/languages","stargazers_url":"https://api.github.com/repos/mjudeikis/openshift-azure/stargazers","contributors_url":"https://api.github.com/repos/mjudeikis/openshift-azure/contributors","subscribers_url":"https://api.github.com/repos/mjudeikis/openshift-azure/subscribers","subscription_url":"https://api.github.com/repos/mjudeikis/openshift-azure/subscription","commits_url":"https://api.github.com/repos/mjudeikis/openshift-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjudeikis/openshift-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjudeikis/openshift-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjudeikis/openshift-azure/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjudeikis/openshift-azure/contents/{+path}","compare_url":"https://api.github.com/repos/mjudeikis/openshift-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjudeikis/openshift-azure/merges","archive_url":"https://api.github.com/repos/mjudeikis/openshift-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjudeikis/openshift-azure/downloads","issues_url":"https://api.github.com/repos/mjudeikis/openshift-azure/issues{/number}","pulls_url":"https://api.github.com/repos/mjudeikis/openshift-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/mjudeikis/openshift-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/mjudeikis/openshift-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjudeikis/openshift-azure/labels{/name}","releases_url":"https://api.github.com/repos/mjudeikis/openshift-azure/releases{/id}","deployments_url":"https://api.github.com/repos/mjudeikis/openshift-azure/deployments","created_at":"2018-07-02T14:06:38Z","updated_at":"2018-07-27T08:31:21Z","pushed_at":"2018-07-27T13:48:12Z","git_url":"git://github.com/mjudeikis/openshift-azure.git","ssh_url":"git@github.com:mjudeikis/openshift-azure.git","clone_url":"https://github.com/mjudeikis/openshift-azure.git","svn_url":"https://github.com/mjudeikis/openshift-azure","homepage":null,"size":19411,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"204f69a348d6430e8ff5710853333ff4f58a6794","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":137828518,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4Mjg1MTg=","name":"openshift-azure","full_name":"openshift/openshift-azure","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-azure","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/openshift-azure","forks_url":"https://api.github.com/repos/openshift/openshift-azure/forks","keys_url":"https://api.github.com/repos/openshift/openshift-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-azure/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-azure/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-azure/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-azure/events","assignees_url":"https://api.github.com/repos/openshift/openshift-azure/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-azure/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-azure/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-azure/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-azure/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-azure/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-azure/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-azure/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-azure/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-azure/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-azure/merges","archive_url":"https://api.github.com/repos/openshift/openshift-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-azure/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-azure/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-azure/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-azure/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-azure/deployments","created_at":"2018-06-19T02:11:07Z","updated_at":"2018-07-27T18:01:39Z","pushed_at":"2018-07-27T18:01:38Z","git_url":"git://github.com/openshift/openshift-azure.git","ssh_url":"git@github.com:openshift/openshift-azure.git","clone_url":"https://github.com/openshift/openshift-azure.git","svn_url":"https://github.com/openshift/openshift-azure","homepage":null,"size":19248,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/109"},"html":{"href":"https://github.com/openshift/openshift-azure/pull/109"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-azure/issues/109"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-azure/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-azure/statuses/11efc4ae0672eeb6e46e3f667a702f1cfe79b28e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jim-minter"}}