{"action":"created","issue":{"url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/942","repository_url":"https://api.github.com/repos/fluentassertions/fluentassertions","labels_url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/942/labels{/name}","comments_url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/942/comments","events_url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/942/events","html_url":"https://github.com/fluentassertions/fluentassertions/pull/942","id":367929125,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjI0NzQy","number":942,"title":"Add Should().NotThrowAfter assertion for actions","user":{"login":"frederik-h","id":22046314,"node_id":"MDQ6VXNlcjIyMDQ2MzE0","avatar_url":"https://avatars1.githubusercontent.com/u/22046314?v=4","gravatar_id":"","url":"https://api.github.com/users/frederik-h","html_url":"https://github.com/frederik-h","followers_url":"https://api.github.com/users/frederik-h/followers","following_url":"https://api.github.com/users/frederik-h/following{/other_user}","gists_url":"https://api.github.com/users/frederik-h/gists{/gist_id}","starred_url":"https://api.github.com/users/frederik-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frederik-h/subscriptions","organizations_url":"https://api.github.com/users/frederik-h/orgs","repos_url":"https://api.github.com/users/frederik-h/repos","events_url":"https://api.github.com/users/frederik-h/events{/privacy}","received_events_url":"https://api.github.com/users/frederik-h/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-10-08T19:49:43Z","updated_at":"2018-11-20T15:20:29Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/fluentassertions/fluentassertions/pulls/942","html_url":"https://github.com/fluentassertions/fluentassertions/pull/942","diff_url":"https://github.com/fluentassertions/fluentassertions/pull/942.diff","patch_url":"https://github.com/fluentassertions/fluentassertions/pull/942.patch"},"body":" This adds a `Should().NotThrowAfter` assertion for Actions which is a variant of `Should().NotThrow`\r\n which asserts that the Action should stop throwing exceptions after a given wait time. See issue #940 for a discussion of this feature.\r\n\r\nIf this gets merged, it should probably also be considered to add corresponding methods for the other action assertions such as `ThrowAfter` etc.\r\n\r\n## IMPORTANT \r\n\r\n* [x] The [Pull Request](https://help.github.com/articles/using-pull-requests) is targeted at the `master` branch.\r\n* [ ] The code complies with the [Coding Guidelines for C# 3.0, 4.0 and 5.0](http://www.csharpcodingguidelines.com/).\r\n* [x] The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used [in this example](https://github.com/fluentassertions/fluentassertions/blob/daaf35b9b59b622c96d0c034e8972a020b2bee55/Tests/FluentAssertions.Shared.Specs/BasicEquivalencySpecs.cs#L33).\r\n* [ ] If the contribution affects the documentation, please include your changes to [**documentation.md**](https://github.com/fluentassertions/fluentassertions/blob/master/docs/documentation.md) in this pull request so the documentation will appear on the [website](http://fluentassertions.com/documentation.html).\r\n\r\n- Regarding compliance to the guidelines: I was unable to run the CSharpGuidelinesAnalyzer, since I do not have access to Windows/VisualStudio at home.\r\n-  Regarding the documentation: I am not sure where to put this right now; I think we can add it later.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/comments/440310580","html_url":"https://github.com/fluentassertions/fluentassertions/pull/942#issuecomment-440310580","issue_url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/942","id":440310580,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDMxMDU4MA==","user":{"login":"dennisdoomen","id":572734,"node_id":"MDQ6VXNlcjU3MjczNA==","avatar_url":"https://avatars3.githubusercontent.com/u/572734?v=4","gravatar_id":"","url":"https://api.github.com/users/dennisdoomen","html_url":"https://github.com/dennisdoomen","followers_url":"https://api.github.com/users/dennisdoomen/followers","following_url":"https://api.github.com/users/dennisdoomen/following{/other_user}","gists_url":"https://api.github.com/users/dennisdoomen/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisdoomen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisdoomen/subscriptions","organizations_url":"https://api.github.com/users/dennisdoomen/orgs","repos_url":"https://api.github.com/users/dennisdoomen/repos","events_url":"https://api.github.com/users/dennisdoomen/events{/privacy}","received_events_url":"https://api.github.com/users/dennisdoomen/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T15:20:29Z","updated_at":"2018-11-20T15:20:29Z","author_association":"MEMBER","body":"> I don't think that my changes have caused the test failure in the test from\r\n\r\nNo, that one is unstable. "}}
{"actor":{"display_login":"dennisdoomen"}}