{"action":"created","issue":{"url":"https://api.github.com/repos/ruby-grape/grape/issues/1774","repository_url":"https://api.github.com/repos/ruby-grape/grape","labels_url":"https://api.github.com/repos/ruby-grape/grape/issues/1774/labels{/name}","comments_url":"https://api.github.com/repos/ruby-grape/grape/issues/1774/comments","events_url":"https://api.github.com/repos/ruby-grape/grape/issues/1774/events","html_url":"https://github.com/ruby-grape/grape/pull/1774","id":344234171,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjc4NjY1","number":1774,"title":"Change HTTP DELETE status code and body logic, use nil for HTTP 204","user":{"login":"basjanssen","id":1922823,"node_id":"MDQ6VXNlcjE5MjI4MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1922823?v=4","gravatar_id":"","url":"https://api.github.com/users/basjanssen","html_url":"https://github.com/basjanssen","followers_url":"https://api.github.com/users/basjanssen/followers","following_url":"https://api.github.com/users/basjanssen/following{/other_user}","gists_url":"https://api.github.com/users/basjanssen/gists{/gist_id}","starred_url":"https://api.github.com/users/basjanssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basjanssen/subscriptions","organizations_url":"https://api.github.com/users/basjanssen/orgs","repos_url":"https://api.github.com/users/basjanssen/repos","events_url":"https://api.github.com/users/basjanssen/events{/privacy}","received_events_url":"https://api.github.com/users/basjanssen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-24T23:04:24Z","updated_at":"2018-07-25T18:15:23Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ruby-grape/grape/pulls/1774","html_url":"https://github.com/ruby-grape/grape/pull/1774","diff_url":"https://github.com/ruby-grape/grape/pull/1774.diff","patch_url":"https://github.com/ruby-grape/grape/pull/1774.patch"},"body":"This PR has two goals:\r\n- Change HTTP DELETE status code and body logic\r\npresenting {}. [], false will be regarded as content and will use HTTP status code 200. The content body will be presented with the set content.\r\n\r\n- Change using nil to set NO_CONTENT\r\nUsing nil will be more consistent with the way the content is regarded in the previous point. \r\n\r\nFixes #1768 \r\n\r\n- [ ] Receive and process first round of feedback\r\n- [ ] Need to fix the spec at spec/grape/dsl/inside_route_spec.rb:144 (I do not understand the reason of failure).\r\n"},"comment":{"url":"https://api.github.com/repos/ruby-grape/grape/issues/comments/407847458","html_url":"https://github.com/ruby-grape/grape/pull/1774#issuecomment-407847458","issue_url":"https://api.github.com/repos/ruby-grape/grape/issues/1774","id":407847458,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzg0NzQ1OA==","user":{"login":"dblock","id":542335,"node_id":"MDQ6VXNlcjU0MjMzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/542335?v=4","gravatar_id":"","url":"https://api.github.com/users/dblock","html_url":"https://github.com/dblock","followers_url":"https://api.github.com/users/dblock/followers","following_url":"https://api.github.com/users/dblock/following{/other_user}","gists_url":"https://api.github.com/users/dblock/gists{/gist_id}","starred_url":"https://api.github.com/users/dblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblock/subscriptions","organizations_url":"https://api.github.com/users/dblock/orgs","repos_url":"https://api.github.com/users/dblock/repos","events_url":"https://api.github.com/users/dblock/events{/privacy}","received_events_url":"https://api.github.com/users/dblock/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T18:15:23Z","updated_at":"2018-07-25T18:15:23Z","author_association":"MEMBER","body":"definitely would need a good UPGRADING.md change to understand all that's changing and will take a look at the details in code, too.\r\n\r\n@namusyaka would appreciate another pair of eyes"}}
{"actor":{"display_login":"dblock"}}