{"action":"created","comment":{"url":"https://api.github.com/repos/apache/geode-native/pulls/comments/191029216","pull_request_review_id":123535066,"id":191029216,"diff_hunk":"@@ -231,7 +231,7 @@ protected TVal createIpdxInstance()\n             pif.WriteByteArray(\"m_byte253\", pt.Byte253);\n             pif.WriteByteArray(\"m_byte65535\", pt.Byte65535);\n             pif.WriteByteArray(\"m_byte65536\", pt.Byte65536);\n-            pif.WriteObject(\"m_pdxEnum\", pt.PdxEnum);\n+            //pif.WriteObject(\"m_pdxEnum\", pt.PdxEnum);","path":"tests/cli/NewFwkLib/PdxTest/PdxTests.cs","position":5,"original_position":5,"commit_id":"1742ba1da0d419da7a7f1a679d06361804fc9441","original_commit_id":"1742ba1da0d419da7a7f1a679d06361804fc9441","user":{"login":"moleske","id":12620096,"avatar_url":"https://avatars3.githubusercontent.com/u/12620096?v=4","gravatar_id":"","url":"https://api.github.com/users/moleske","html_url":"https://github.com/moleske","followers_url":"https://api.github.com/users/moleske/followers","following_url":"https://api.github.com/users/moleske/following{/other_user}","gists_url":"https://api.github.com/users/moleske/gists{/gist_id}","starred_url":"https://api.github.com/users/moleske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moleske/subscriptions","organizations_url":"https://api.github.com/users/moleske/orgs","repos_url":"https://api.github.com/users/moleske/repos","events_url":"https://api.github.com/users/moleske/events{/privacy}","received_events_url":"https://api.github.com/users/moleske/received_events","type":"User","site_admin":false},"body":"just delete?","created_at":"2018-05-25T23:24:48Z","updated_at":"2018-05-25T23:39:18Z","html_url":"https://github.com/apache/geode-native/pull/303#discussion_r191029216","pull_request_url":"https://api.github.com/repos/apache/geode-native/pulls/303","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/geode-native/pulls/comments/191029216"},"html":{"href":"https://github.com/apache/geode-native/pull/303#discussion_r191029216"},"pull_request":{"href":"https://api.github.com/repos/apache/geode-native/pulls/303"}}},"pull_request":{"url":"https://api.github.com/repos/apache/geode-native/pulls/303","id":190699130,"html_url":"https://github.com/apache/geode-native/pull/303","diff_url":"https://github.com/apache/geode-native/pull/303.diff","patch_url":"https://github.com/apache/geode-native/pull/303.patch","issue_url":"https://api.github.com/repos/apache/geode-native/issues/303","number":303,"state":"open","locked":false,"title":"GEODE-5190: Refactor Serializable into separate interfaces","user":{"login":"pivotal-jbarrett","id":6800791,"avatar_url":"https://avatars2.githubusercontent.com/u/6800791?v=4","gravatar_id":"","url":"https://api.github.com/users/pivotal-jbarrett","html_url":"https://github.com/pivotal-jbarrett","followers_url":"https://api.github.com/users/pivotal-jbarrett/followers","following_url":"https://api.github.com/users/pivotal-jbarrett/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-jbarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-jbarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-jbarrett/subscriptions","organizations_url":"https://api.github.com/users/pivotal-jbarrett/orgs","repos_url":"https://api.github.com/users/pivotal-jbarrett/repos","events_url":"https://api.github.com/users/pivotal-jbarrett/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-jbarrett/received_events","type":"User","site_admin":false},"body":"- Added DataSerializable\r\n- Added DataSerializableFixeId\r\n- Added DataSerializablePrimitive\r\n- Added DataSerializableInternal\r\n\r\n- Added IDataSerializable\r\n- Added IDataSerializableFixeId\r\n- Added IDataSerializablePrimitive\r\n- Added IDataSerializableInternal\r\n- Renamed IGeodeSerializable to ISerializable\r\n- Renamed IGeodeDelta to IDelta\r\n\r\nCo-authored-by: Ivan Godwin <igodwin@pivotal.io>","created_at":"2018-05-25T21:36:46Z","updated_at":"2018-05-25T23:39:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"baa0d195eecbe998eafd83bd762645e60e0aba78","assignee":null,"assignees":[],"requested_reviewers":[{"login":"echobravopapa","id":18683012,"avatar_url":"https://avatars3.githubusercontent.com/u/18683012?v=4","gravatar_id":"","url":"https://api.github.com/users/echobravopapa","html_url":"https://github.com/echobravopapa","followers_url":"https://api.github.com/users/echobravopapa/followers","following_url":"https://api.github.com/users/echobravopapa/following{/other_user}","gists_url":"https://api.github.com/users/echobravopapa/gists{/gist_id}","starred_url":"https://api.github.com/users/echobravopapa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echobravopapa/subscriptions","organizations_url":"https://api.github.com/users/echobravopapa/orgs","repos_url":"https://api.github.com/users/echobravopapa/repos","events_url":"https://api.github.com/users/echobravopapa/events{/privacy}","received_events_url":"https://api.github.com/users/echobravopapa/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode-native/pulls/303/commits","review_comments_url":"https://api.github.com/repos/apache/geode-native/pulls/303/comments","review_comment_url":"https://api.github.com/repos/apache/geode-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode-native/issues/303/comments","statuses_url":"https://api.github.com/repos/apache/geode-native/statuses/1742ba1da0d419da7a7f1a679d06361804fc9441","head":{"label":"pivotal-jbarrett:wip/serializable-4","ref":"wip/serializable-4","sha":"1742ba1da0d419da7a7f1a679d06361804fc9441","user":{"login":"pivotal-jbarrett","id":6800791,"avatar_url":"https://avatars2.githubusercontent.com/u/6800791?v=4","gravatar_id":"","url":"https://api.github.com/users/pivotal-jbarrett","html_url":"https://github.com/pivotal-jbarrett","followers_url":"https://api.github.com/users/pivotal-jbarrett/followers","following_url":"https://api.github.com/users/pivotal-jbarrett/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-jbarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-jbarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-jbarrett/subscriptions","organizations_url":"https://api.github.com/users/pivotal-jbarrett/orgs","repos_url":"https://api.github.com/users/pivotal-jbarrett/repos","events_url":"https://api.github.com/users/pivotal-jbarrett/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-jbarrett/received_events","type":"User","site_admin":false},"repo":{"id":81874345,"name":"geode-native","full_name":"pivotal-jbarrett/geode-native","owner":{"login":"pivotal-jbarrett","id":6800791,"avatar_url":"https://avatars2.githubusercontent.com/u/6800791?v=4","gravatar_id":"","url":"https://api.github.com/users/pivotal-jbarrett","html_url":"https://github.com/pivotal-jbarrett","followers_url":"https://api.github.com/users/pivotal-jbarrett/followers","following_url":"https://api.github.com/users/pivotal-jbarrett/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-jbarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-jbarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-jbarrett/subscriptions","organizations_url":"https://api.github.com/users/pivotal-jbarrett/orgs","repos_url":"https://api.github.com/users/pivotal-jbarrett/repos","events_url":"https://api.github.com/users/pivotal-jbarrett/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-jbarrett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pivotal-jbarrett/geode-native","description":"Mirror of Apache Geode native components","fork":true,"url":"https://api.github.com/repos/pivotal-jbarrett/geode-native","forks_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/forks","keys_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/teams","hooks_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/hooks","issue_events_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/issues/events{/number}","events_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/events","assignees_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/assignees{/user}","branches_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/branches{/branch}","tags_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/tags","blobs_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/statuses/{sha}","languages_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/languages","stargazers_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/stargazers","contributors_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/contributors","subscribers_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/subscribers","subscription_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/subscription","commits_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/contents/{+path}","compare_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/merges","archive_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/downloads","issues_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/issues{/number}","pulls_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/pulls{/number}","milestones_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/milestones{/number}","notifications_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/labels{/name}","releases_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/releases{/id}","deployments_url":"https://api.github.com/repos/pivotal-jbarrett/geode-native/deployments","created_at":"2017-02-13T21:35:33Z","updated_at":"2018-05-25T20:54:46Z","pushed_at":"2018-05-25T21:31:43Z","git_url":"git://github.com/pivotal-jbarrett/geode-native.git","ssh_url":"git@github.com:pivotal-jbarrett/geode-native.git","clone_url":"https://github.com/pivotal-jbarrett/geode-native.git","svn_url":"https://github.com/pivotal-jbarrett/geode-native","homepage":null,"size":19314,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"4181755bd09a5936fd15ec38c628c4ea985a125d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":80904111,"name":"geode-native","full_name":"apache/geode-native","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/geode-native","description":"Apache Geode native components","fork":false,"url":"https://api.github.com/repos/apache/geode-native","forks_url":"https://api.github.com/repos/apache/geode-native/forks","keys_url":"https://api.github.com/repos/apache/geode-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode-native/teams","hooks_url":"https://api.github.com/repos/apache/geode-native/hooks","issue_events_url":"https://api.github.com/repos/apache/geode-native/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode-native/events","assignees_url":"https://api.github.com/repos/apache/geode-native/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode-native/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode-native/tags","blobs_url":"https://api.github.com/repos/apache/geode-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode-native/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode-native/languages","stargazers_url":"https://api.github.com/repos/apache/geode-native/stargazers","contributors_url":"https://api.github.com/repos/apache/geode-native/contributors","subscribers_url":"https://api.github.com/repos/apache/geode-native/subscribers","subscription_url":"https://api.github.com/repos/apache/geode-native/subscription","commits_url":"https://api.github.com/repos/apache/geode-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode-native/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode-native/merges","archive_url":"https://api.github.com/repos/apache/geode-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode-native/downloads","issues_url":"https://api.github.com/repos/apache/geode-native/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode-native/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode-native/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode-native/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode-native/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode-native/deployments","created_at":"2017-02-04T08:00:06Z","updated_at":"2018-05-25T21:15:22Z","pushed_at":"2018-05-25T21:36:47Z","git_url":"git://github.com/apache/geode-native.git","ssh_url":"git@github.com:apache/geode-native.git","clone_url":"https://github.com/apache/geode-native.git","svn_url":"https://github.com/apache/geode-native","homepage":"","size":18291,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":28,"open_issues":2,"watchers":19,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode-native/pulls/303"},"html":{"href":"https://github.com/apache/geode-native/pull/303"},"issue":{"href":"https://api.github.com/repos/apache/geode-native/issues/303"},"comments":{"href":"https://api.github.com/repos/apache/geode-native/issues/303/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode-native/pulls/303/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode-native/pulls/303/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode-native/statuses/1742ba1da0d419da7a7f1a679d06361804fc9441"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"moleske"}}