{"action":"closed","number":343,"pull_request":{"url":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/343","id":215577664,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTc3NjY0","html_url":"https://github.com/OpenModelica/OMSimulator/pull/343","diff_url":"https://github.com/OpenModelica/OMSimulator/pull/343.diff","patch_url":"https://github.com/OpenModelica/OMSimulator/pull/343.patch","issue_url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/343","number":343,"state":"closed","locked":false,"title":"New API version: oms3","user":{"login":"lochel","id":8457302,"node_id":"MDQ6VXNlcjg0NTczMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8457302?v=4","gravatar_id":"","url":"https://api.github.com/users/lochel","html_url":"https://github.com/lochel","followers_url":"https://api.github.com/users/lochel/followers","following_url":"https://api.github.com/users/lochel/following{/other_user}","gists_url":"https://api.github.com/users/lochel/gists{/gist_id}","starred_url":"https://api.github.com/users/lochel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lochel/subscriptions","organizations_url":"https://api.github.com/users/lochel/orgs","repos_url":"https://api.github.com/users/lochel/repos","events_url":"https://api.github.com/users/lochel/events{/privacy}","received_events_url":"https://api.github.com/users/lochel/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nBetter separation of strongly and weakly coupled systems.\r\n\r\n### Approach\r\n\r\nReimplementation of the current oms2 API, including most of the underlying code base. To keep the current functionality during the transition, everything is implemented within a new namespace: oms3.\r\n\r\n### Type of Change\r\n\r\n<!--- Please delete options that are not relevant. -->\r\n\r\n- Code refactoring (non-breaking change which improves maintainability)\r\n- Bug fix (non-breaking change which fixes an issue)\r\n- New feature (non-breaking change which adds functionality)\r\n- This change requires a documentation update","created_at":"2018-09-14T12:25:47Z","updated_at":"2018-09-19T07:18:22Z","closed_at":"2018-09-19T07:18:22Z","merged_at":null,"merge_commit_sha":"e74effa83f4e51b92b6270c2f97a2a1879afaf03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/343/commits","review_comments_url":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/343/comments","review_comment_url":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/343/comments","statuses_url":"https://api.github.com/repos/OpenModelica/OMSimulator/statuses/0cae375eb92534ad177707ee92e0eb2cf7ac3330","head":{"label":"lochel:oms3","ref":"oms3","sha":"0cae375eb92534ad177707ee92e0eb2cf7ac3330","user":{"login":"lochel","id":8457302,"node_id":"MDQ6VXNlcjg0NTczMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8457302?v=4","gravatar_id":"","url":"https://api.github.com/users/lochel","html_url":"https://github.com/lochel","followers_url":"https://api.github.com/users/lochel/followers","following_url":"https://api.github.com/users/lochel/following{/other_user}","gists_url":"https://api.github.com/users/lochel/gists{/gist_id}","starred_url":"https://api.github.com/users/lochel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lochel/subscriptions","organizations_url":"https://api.github.com/users/lochel/orgs","repos_url":"https://api.github.com/users/lochel/repos","events_url":"https://api.github.com/users/lochel/events{/privacy}","received_events_url":"https://api.github.com/users/lochel/received_events","type":"User","site_admin":false},"repo":{"id":111418238,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE0MTgyMzg=","name":"OMSimulator","full_name":"lochel/OMSimulator","private":false,"owner":{"login":"lochel","id":8457302,"node_id":"MDQ6VXNlcjg0NTczMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8457302?v=4","gravatar_id":"","url":"https://api.github.com/users/lochel","html_url":"https://github.com/lochel","followers_url":"https://api.github.com/users/lochel/followers","following_url":"https://api.github.com/users/lochel/following{/other_user}","gists_url":"https://api.github.com/users/lochel/gists{/gist_id}","starred_url":"https://api.github.com/users/lochel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lochel/subscriptions","organizations_url":"https://api.github.com/users/lochel/orgs","repos_url":"https://api.github.com/users/lochel/repos","events_url":"https://api.github.com/users/lochel/events{/privacy}","received_events_url":"https://api.github.com/users/lochel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lochel/OMSimulator","description":"OpenModelica FMI & TLM based simulator","fork":true,"url":"https://api.github.com/repos/lochel/OMSimulator","forks_url":"https://api.github.com/repos/lochel/OMSimulator/forks","keys_url":"https://api.github.com/repos/lochel/OMSimulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lochel/OMSimulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lochel/OMSimulator/teams","hooks_url":"https://api.github.com/repos/lochel/OMSimulator/hooks","issue_events_url":"https://api.github.com/repos/lochel/OMSimulator/issues/events{/number}","events_url":"https://api.github.com/repos/lochel/OMSimulator/events","assignees_url":"https://api.github.com/repos/lochel/OMSimulator/assignees{/user}","branches_url":"https://api.github.com/repos/lochel/OMSimulator/branches{/branch}","tags_url":"https://api.github.com/repos/lochel/OMSimulator/tags","blobs_url":"https://api.github.com/repos/lochel/OMSimulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lochel/OMSimulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lochel/OMSimulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/lochel/OMSimulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lochel/OMSimulator/statuses/{sha}","languages_url":"https://api.github.com/repos/lochel/OMSimulator/languages","stargazers_url":"https://api.github.com/repos/lochel/OMSimulator/stargazers","contributors_url":"https://api.github.com/repos/lochel/OMSimulator/contributors","subscribers_url":"https://api.github.com/repos/lochel/OMSimulator/subscribers","subscription_url":"https://api.github.com/repos/lochel/OMSimulator/subscription","commits_url":"https://api.github.com/repos/lochel/OMSimulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/lochel/OMSimulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/lochel/OMSimulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/lochel/OMSimulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/lochel/OMSimulator/contents/{+path}","compare_url":"https://api.github.com/repos/lochel/OMSimulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lochel/OMSimulator/merges","archive_url":"https://api.github.com/repos/lochel/OMSimulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lochel/OMSimulator/downloads","issues_url":"https://api.github.com/repos/lochel/OMSimulator/issues{/number}","pulls_url":"https://api.github.com/repos/lochel/OMSimulator/pulls{/number}","milestones_url":"https://api.github.com/repos/lochel/OMSimulator/milestones{/number}","notifications_url":"https://api.github.com/repos/lochel/OMSimulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lochel/OMSimulator/labels{/name}","releases_url":"https://api.github.com/repos/lochel/OMSimulator/releases{/id}","deployments_url":"https://api.github.com/repos/lochel/OMSimulator/deployments","created_at":"2017-11-20T14:06:02Z","updated_at":"2018-08-27T11:08:53Z","pushed_at":"2018-09-18T19:01:48Z","git_url":"git://github.com/lochel/OMSimulator.git","ssh_url":"git@github.com:lochel/OMSimulator.git","clone_url":"https://github.com/lochel/OMSimulator.git","svn_url":"https://github.com/lochel/OMSimulator","homepage":null,"size":1318,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenModelica:master","ref":"master","sha":"de76271de3fad51c118d84a5cb838c502b7e6dd7","user":{"login":"OpenModelica","id":4006504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMDY1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4006504?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenModelica","html_url":"https://github.com/OpenModelica","followers_url":"https://api.github.com/users/OpenModelica/followers","following_url":"https://api.github.com/users/OpenModelica/following{/other_user}","gists_url":"https://api.github.com/users/OpenModelica/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenModelica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenModelica/subscriptions","organizations_url":"https://api.github.com/users/OpenModelica/orgs","repos_url":"https://api.github.com/users/OpenModelica/repos","events_url":"https://api.github.com/users/OpenModelica/events{/privacy}","received_events_url":"https://api.github.com/users/OpenModelica/received_events","type":"Organization","site_admin":false},"repo":{"id":111417328,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE0MTczMjg=","name":"OMSimulator","full_name":"OpenModelica/OMSimulator","private":false,"owner":{"login":"OpenModelica","id":4006504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMDY1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4006504?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenModelica","html_url":"https://github.com/OpenModelica","followers_url":"https://api.github.com/users/OpenModelica/followers","following_url":"https://api.github.com/users/OpenModelica/following{/other_user}","gists_url":"https://api.github.com/users/OpenModelica/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenModelica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenModelica/subscriptions","organizations_url":"https://api.github.com/users/OpenModelica/orgs","repos_url":"https://api.github.com/users/OpenModelica/repos","events_url":"https://api.github.com/users/OpenModelica/events{/privacy}","received_events_url":"https://api.github.com/users/OpenModelica/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenModelica/OMSimulator","description":"OpenModelica FMI & TLM based simulator","fork":false,"url":"https://api.github.com/repos/OpenModelica/OMSimulator","forks_url":"https://api.github.com/repos/OpenModelica/OMSimulator/forks","keys_url":"https://api.github.com/repos/OpenModelica/OMSimulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenModelica/OMSimulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenModelica/OMSimulator/teams","hooks_url":"https://api.github.com/repos/OpenModelica/OMSimulator/hooks","issue_events_url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/events{/number}","events_url":"https://api.github.com/repos/OpenModelica/OMSimulator/events","assignees_url":"https://api.github.com/repos/OpenModelica/OMSimulator/assignees{/user}","branches_url":"https://api.github.com/repos/OpenModelica/OMSimulator/branches{/branch}","tags_url":"https://api.github.com/repos/OpenModelica/OMSimulator/tags","blobs_url":"https://api.github.com/repos/OpenModelica/OMSimulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenModelica/OMSimulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenModelica/OMSimulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenModelica/OMSimulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenModelica/OMSimulator/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenModelica/OMSimulator/languages","stargazers_url":"https://api.github.com/repos/OpenModelica/OMSimulator/stargazers","contributors_url":"https://api.github.com/repos/OpenModelica/OMSimulator/contributors","subscribers_url":"https://api.github.com/repos/OpenModelica/OMSimulator/subscribers","subscription_url":"https://api.github.com/repos/OpenModelica/OMSimulator/subscription","commits_url":"https://api.github.com/repos/OpenModelica/OMSimulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenModelica/OMSimulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenModelica/OMSimulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenModelica/OMSimulator/contents/{+path}","compare_url":"https://api.github.com/repos/OpenModelica/OMSimulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenModelica/OMSimulator/merges","archive_url":"https://api.github.com/repos/OpenModelica/OMSimulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenModelica/OMSimulator/downloads","issues_url":"https://api.github.com/repos/OpenModelica/OMSimulator/issues{/number}","pulls_url":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenModelica/OMSimulator/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenModelica/OMSimulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenModelica/OMSimulator/labels{/name}","releases_url":"https://api.github.com/repos/OpenModelica/OMSimulator/releases{/id}","deployments_url":"https://api.github.com/repos/OpenModelica/OMSimulator/deployments","created_at":"2017-11-20T13:58:42Z","updated_at":"2018-09-12T09:55:35Z","pushed_at":"2018-09-19T07:17:14Z","git_url":"git://github.com/OpenModelica/OMSimulator.git","ssh_url":"git@github.com:OpenModelica/OMSimulator.git","clone_url":"https://github.com/OpenModelica/OMSimulator.git","svn_url":"https://github.com/OpenModelica/OMSimulator","homepage":null,"size":1255,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14,"open_issues":34,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/343"},"html":{"href":"https://github.com/OpenModelica/OMSimulator/pull/343"},"issue":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/343"},"comments":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/issues/343/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/343/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/pulls/343/commits"},"statuses":{"href":"https://api.github.com/repos/OpenModelica/OMSimulator/statuses/0cae375eb92534ad177707ee92e0eb2cf7ac3330"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":5,"maintainer_can_modify":false,"commits":11,"additions":2226,"deletions":28,"changed_files":31}}
{"actor":{"display_login":"lochel"}}