{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments/198240760","pull_request_review_id":132134971,"id":198240760,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODI0MDc2MA==","diff_hunk":"@@ -0,0 +1,17 @@\n+---\n+kind: ClusterRole","path":"apb/templates/broker-user-auth.yaml","position":2,"original_position":2,"commit_id":"a85d2a365ac1fb293dae0951ee61320038649523","original_commit_id":"a85d2a365ac1fb293dae0951ee61320038649523","user":{"login":"djzager","id":569754,"node_id":"MDQ6VXNlcjU2OTc1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/569754?v=4","gravatar_id":"","url":"https://api.github.com/users/djzager","html_url":"https://github.com/djzager","followers_url":"https://api.github.com/users/djzager/followers","following_url":"https://api.github.com/users/djzager/following{/other_user}","gists_url":"https://api.github.com/users/djzager/gists{/gist_id}","starred_url":"https://api.github.com/users/djzager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djzager/subscriptions","organizations_url":"https://api.github.com/users/djzager/orgs","repos_url":"https://api.github.com/users/djzager/repos","events_url":"https://api.github.com/users/djzager/events{/privacy}","received_events_url":"https://api.github.com/users/djzager/received_events","type":"User","site_admin":false},"body":"The only thing I don't see is this template being used in deployment.","created_at":"2018-06-26T17:52:00Z","updated_at":"2018-06-26T17:55:34Z","html_url":"https://github.com/openshift/ansible-service-broker/pull/995#discussion_r198240760","pull_request_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/995","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments/198240760"},"html":{"href":"https://github.com/openshift/ansible-service-broker/pull/995#discussion_r198240760"},"pull_request":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/995"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/995","id":196562584,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTYyNTg0","html_url":"https://github.com/openshift/ansible-service-broker/pull/995","diff_url":"https://github.com/openshift/ansible-service-broker/pull/995.diff","patch_url":"https://github.com/openshift/ansible-service-broker/pull/995.patch","issue_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/995","number":995,"state":"open","locked":false,"title":"removing subject rules review auth and using aggregated rules.","user":{"login":"shawn-hurley","id":1891063,"node_id":"MDQ6VXNlcjE4OTEwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1891063?v=4","gravatar_id":"","url":"https://api.github.com/users/shawn-hurley","html_url":"https://github.com/shawn-hurley","followers_url":"https://api.github.com/users/shawn-hurley/followers","following_url":"https://api.github.com/users/shawn-hurley/following{/other_user}","gists_url":"https://api.github.com/users/shawn-hurley/gists{/gist_id}","starred_url":"https://api.github.com/users/shawn-hurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawn-hurley/subscriptions","organizations_url":"https://api.github.com/users/shawn-hurley/orgs","repos_url":"https://api.github.com/users/shawn-hurley/repos","events_url":"https://api.github.com/users/shawn-hurley/events{/privacy}","received_events_url":"https://api.github.com/users/shawn-hurley/received_events","type":"User","site_admin":false},"body":"#### Describe what this PR does and why we need it:\r\nImplementation of https://trello.com/c/fiOSsq1Q\r\n#### Changes proposed in this pull request\r\n - remove origin package\r\n - remove rules review\r\n - use bundle-lib authorizer to determine if user  ca\r\n\r\n#### Does this PR depend on another PR (Use this to track when PRs should be merged)\r\ndepends-on <PR>\r\nhttps://github.com/automationbroker/bundle-lib/pull/112\r\n\r\n","created_at":"2018-06-21T20:12:42Z","updated_at":"2018-06-26T17:55:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d7fb50c85c622bfbef3bf0fe40b1cb83fa77abc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":724844177,"node_id":"MDU6TGFiZWw3MjQ4NDQxNzc=","url":"https://api.github.com/repos/openshift/ansible-service-broker/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/995/commits","review_comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/995/comments","review_comment_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/995/comments","statuses_url":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/a85d2a365ac1fb293dae0951ee61320038649523","head":{"label":"shawn-hurley:remove-subjectrulesreview-auth","ref":"remove-subjectrulesreview-auth","sha":"a85d2a365ac1fb293dae0951ee61320038649523","user":{"login":"shawn-hurley","id":1891063,"node_id":"MDQ6VXNlcjE4OTEwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1891063?v=4","gravatar_id":"","url":"https://api.github.com/users/shawn-hurley","html_url":"https://github.com/shawn-hurley","followers_url":"https://api.github.com/users/shawn-hurley/followers","following_url":"https://api.github.com/users/shawn-hurley/following{/other_user}","gists_url":"https://api.github.com/users/shawn-hurley/gists{/gist_id}","starred_url":"https://api.github.com/users/shawn-hurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawn-hurley/subscriptions","organizations_url":"https://api.github.com/users/shawn-hurley/orgs","repos_url":"https://api.github.com/users/shawn-hurley/repos","events_url":"https://api.github.com/users/shawn-hurley/events{/privacy}","received_events_url":"https://api.github.com/users/shawn-hurley/received_events","type":"User","site_admin":false},"repo":{"id":94127278,"node_id":"MDEwOlJlcG9zaXRvcnk5NDEyNzI3OA==","name":"ansible-service-broker","full_name":"shawn-hurley/ansible-service-broker","owner":{"login":"shawn-hurley","id":1891063,"node_id":"MDQ6VXNlcjE4OTEwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1891063?v=4","gravatar_id":"","url":"https://api.github.com/users/shawn-hurley","html_url":"https://github.com/shawn-hurley","followers_url":"https://api.github.com/users/shawn-hurley/followers","following_url":"https://api.github.com/users/shawn-hurley/following{/other_user}","gists_url":"https://api.github.com/users/shawn-hurley/gists{/gist_id}","starred_url":"https://api.github.com/users/shawn-hurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawn-hurley/subscriptions","organizations_url":"https://api.github.com/users/shawn-hurley/orgs","repos_url":"https://api.github.com/users/shawn-hurley/repos","events_url":"https://api.github.com/users/shawn-hurley/events{/privacy}","received_events_url":"https://api.github.com/users/shawn-hurley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shawn-hurley/ansible-service-broker","description":"Ansible Service Broker","fork":true,"url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker","forks_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/forks","keys_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/teams","hooks_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/hooks","issue_events_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/events","assignees_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/tags","blobs_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/languages","stargazers_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/stargazers","contributors_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/contributors","subscribers_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/subscribers","subscription_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/subscription","commits_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/merges","archive_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/downloads","issues_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/releases{/id}","deployments_url":"https://api.github.com/repos/shawn-hurley/ansible-service-broker/deployments","created_at":"2017-06-12T18:22:54Z","updated_at":"2017-06-12T18:22:55Z","pushed_at":"2018-06-21T20:09:23Z","git_url":"git://github.com/shawn-hurley/ansible-service-broker.git","ssh_url":"git@github.com:shawn-hurley/ansible-service-broker.git","clone_url":"https://github.com/shawn-hurley/ansible-service-broker.git","svn_url":"https://github.com/shawn-hurley/ansible-service-broker","homepage":null,"size":107971,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"8ff6be90363c905debca43fb4ed32db8d37b6e32","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":79371528,"node_id":"MDEwOlJlcG9zaXRvcnk3OTM3MTUyOA==","name":"ansible-service-broker","full_name":"openshift/ansible-service-broker","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/ansible-service-broker","description":"Ansible Service Broker","fork":false,"url":"https://api.github.com/repos/openshift/ansible-service-broker","forks_url":"https://api.github.com/repos/openshift/ansible-service-broker/forks","keys_url":"https://api.github.com/repos/openshift/ansible-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/ansible-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/ansible-service-broker/teams","hooks_url":"https://api.github.com/repos/openshift/ansible-service-broker/hooks","issue_events_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/ansible-service-broker/events","assignees_url":"https://api.github.com/repos/openshift/ansible-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/ansible-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/ansible-service-broker/tags","blobs_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/ansible-service-broker/languages","stargazers_url":"https://api.github.com/repos/openshift/ansible-service-broker/stargazers","contributors_url":"https://api.github.com/repos/openshift/ansible-service-broker/contributors","subscribers_url":"https://api.github.com/repos/openshift/ansible-service-broker/subscribers","subscription_url":"https://api.github.com/repos/openshift/ansible-service-broker/subscription","commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/ansible-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/ansible-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/ansible-service-broker/merges","archive_url":"https://api.github.com/repos/openshift/ansible-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/ansible-service-broker/downloads","issues_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/ansible-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/ansible-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/ansible-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/openshift/ansible-service-broker/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/ansible-service-broker/deployments","created_at":"2017-01-18T18:40:49Z","updated_at":"2018-06-20T17:22:48Z","pushed_at":"2018-06-26T15:41:26Z","git_url":"git://github.com/openshift/ansible-service-broker.git","ssh_url":"git@github.com:openshift/ansible-service-broker.git","clone_url":"https://github.com/openshift/ansible-service-broker.git","svn_url":"https://github.com/openshift/ansible-service-broker","homepage":null,"size":102615,"stargazers_count":118,"watchers_count":118,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":61,"open_issues":51,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/995"},"html":{"href":"https://github.com/openshift/ansible-service-broker/pull/995"},"issue":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/issues/995"},"comments":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/issues/995/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/995/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/995/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/a85d2a365ac1fb293dae0951ee61320038649523"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"djzager"}}