{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/213094904","pull_request_review_id":149859509,"id":213094904,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzA5NDkwNA==","diff_hunk":"@@ -48,48 +48,67 @@ using namespace PlatformAgnostic::ICUHelpers;\n \n #endif // INTL_ICU\n \n-// NOTE(jahorto): Keep these enums in sync with those by the same name in Intl.js\n-// These enums are used by both WinGlob- and ICU-backed Intl\n-enum class NumberFormatStyle\n-{\n-    Decimal, // Intl.NumberFormat(locale, { style: \"decimal\" }); // aka in our code as \"number\"","path":"lib/Runtime/Library/IntlEngineInterfaceExtensionObject.cpp","position":8,"original_position":8,"commit_id":"b8c68078156e510b1e122163a64bf777d7baaafd","original_commit_id":"b8c68078156e510b1e122163a64bf777d7baaafd","user":{"login":"MSLaguana","id":14098340,"node_id":"MDQ6VXNlcjE0MDk4MzQw","avatar_url":"https://avatars0.githubusercontent.com/u/14098340?v=4","gravatar_id":"","url":"https://api.github.com/users/MSLaguana","html_url":"https://github.com/MSLaguana","followers_url":"https://api.github.com/users/MSLaguana/followers","following_url":"https://api.github.com/users/MSLaguana/following{/other_user}","gists_url":"https://api.github.com/users/MSLaguana/gists{/gist_id}","starred_url":"https://api.github.com/users/MSLaguana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSLaguana/subscriptions","organizations_url":"https://api.github.com/users/MSLaguana/orgs","repos_url":"https://api.github.com/users/MSLaguana/repos","events_url":"https://api.github.com/users/MSLaguana/events{/privacy}","received_events_url":"https://api.github.com/users/MSLaguana/received_events","type":"User","site_admin":false},"body":"Is it worth preserving these comments about the meaning/usage of the value?","created_at":"2018-08-27T19:56:04Z","updated_at":"2018-08-27T19:56:04Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/5645#discussion_r213094904","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5645","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/213094904"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/5645#discussion_r213094904"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5645"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5645","id":211194829,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMTk0ODI5","html_url":"https://github.com/Microsoft/ChakraCore/pull/5645","diff_url":"https://github.com/Microsoft/ChakraCore/pull/5645.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/5645.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/5645","number":5645,"state":"open","locked":false,"title":"Automatically keep Intl enums in sync","user":{"login":"jackhorton","id":4370013,"node_id":"MDQ6VXNlcjQzNzAwMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/4370013?v=4","gravatar_id":"","url":"https://api.github.com/users/jackhorton","html_url":"https://github.com/jackhorton","followers_url":"https://api.github.com/users/jackhorton/followers","following_url":"https://api.github.com/users/jackhorton/following{/other_user}","gists_url":"https://api.github.com/users/jackhorton/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhorton/subscriptions","organizations_url":"https://api.github.com/users/jackhorton/orgs","repos_url":"https://api.github.com/users/jackhorton/repos","events_url":"https://api.github.com/users/jackhorton/events{/privacy}","received_events_url":"https://api.github.com/users/jackhorton/received_events","type":"User","site_admin":false},"body":"Went down a bit of a macro rabbit hole while investigating another bug in Intl; this approach is a (theoretically) safer version of what we were already doing. Also, I just _really_ wanted yet another bytecode-format-changing PR opened.","created_at":"2018-08-27T18:43:52Z","updated_at":"2018-08-27T19:56:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f94398dfdd15ac2060e1b667d3d32f43ce244567","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Penguinwizzard","id":69503,"node_id":"MDQ6VXNlcjY5NTAz","avatar_url":"https://avatars0.githubusercontent.com/u/69503?v=4","gravatar_id":"","url":"https://api.github.com/users/Penguinwizzard","html_url":"https://github.com/Penguinwizzard","followers_url":"https://api.github.com/users/Penguinwizzard/followers","following_url":"https://api.github.com/users/Penguinwizzard/following{/other_user}","gists_url":"https://api.github.com/users/Penguinwizzard/gists{/gist_id}","starred_url":"https://api.github.com/users/Penguinwizzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Penguinwizzard/subscriptions","organizations_url":"https://api.github.com/users/Penguinwizzard/orgs","repos_url":"https://api.github.com/users/Penguinwizzard/repos","events_url":"https://api.github.com/users/Penguinwizzard/events{/privacy}","received_events_url":"https://api.github.com/users/Penguinwizzard/received_events","type":"User","site_admin":false},{"login":"dilijev","id":494055,"node_id":"MDQ6VXNlcjQ5NDA1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/494055?v=4","gravatar_id":"","url":"https://api.github.com/users/dilijev","html_url":"https://github.com/dilijev","followers_url":"https://api.github.com/users/dilijev/followers","following_url":"https://api.github.com/users/dilijev/following{/other_user}","gists_url":"https://api.github.com/users/dilijev/gists{/gist_id}","starred_url":"https://api.github.com/users/dilijev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilijev/subscriptions","organizations_url":"https://api.github.com/users/dilijev/orgs","repos_url":"https://api.github.com/users/dilijev/repos","events_url":"https://api.github.com/users/dilijev/events{/privacy}","received_events_url":"https://api.github.com/users/dilijev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1034800413,"node_id":"MDU6TGFiZWwxMDM0ODAwNDEz","url":"https://api.github.com/repos/Microsoft/ChakraCore/labels/Bytecode-Update","name":"Bytecode-Update","color":"ffee99","default":false},{"id":685330770,"node_id":"MDU6TGFiZWw2ODUzMzA3NzA=","url":"https://api.github.com/repos/Microsoft/ChakraCore/labels/Intl-ICU","name":"Intl-ICU","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5645/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5645/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/5645/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/b8c68078156e510b1e122163a64bf777d7baaafd","head":{"label":"jackhorton:intl/projected-enums","ref":"intl/projected-enums","sha":"b8c68078156e510b1e122163a64bf777d7baaafd","user":{"login":"jackhorton","id":4370013,"node_id":"MDQ6VXNlcjQzNzAwMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/4370013?v=4","gravatar_id":"","url":"https://api.github.com/users/jackhorton","html_url":"https://github.com/jackhorton","followers_url":"https://api.github.com/users/jackhorton/followers","following_url":"https://api.github.com/users/jackhorton/following{/other_user}","gists_url":"https://api.github.com/users/jackhorton/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhorton/subscriptions","organizations_url":"https://api.github.com/users/jackhorton/orgs","repos_url":"https://api.github.com/users/jackhorton/repos","events_url":"https://api.github.com/users/jackhorton/events{/privacy}","received_events_url":"https://api.github.com/users/jackhorton/received_events","type":"User","site_admin":false},"repo":{"id":96947022,"node_id":"MDEwOlJlcG9zaXRvcnk5Njk0NzAyMg==","name":"ChakraCore","full_name":"jackhorton/ChakraCore","owner":{"login":"jackhorton","id":4370013,"node_id":"MDQ6VXNlcjQzNzAwMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/4370013?v=4","gravatar_id":"","url":"https://api.github.com/users/jackhorton","html_url":"https://github.com/jackhorton","followers_url":"https://api.github.com/users/jackhorton/followers","following_url":"https://api.github.com/users/jackhorton/following{/other_user}","gists_url":"https://api.github.com/users/jackhorton/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhorton/subscriptions","organizations_url":"https://api.github.com/users/jackhorton/orgs","repos_url":"https://api.github.com/users/jackhorton/repos","events_url":"https://api.github.com/users/jackhorton/events{/privacy}","received_events_url":"https://api.github.com/users/jackhorton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackhorton/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/jackhorton/ChakraCore","forks_url":"https://api.github.com/repos/jackhorton/ChakraCore/forks","keys_url":"https://api.github.com/repos/jackhorton/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackhorton/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackhorton/ChakraCore/teams","hooks_url":"https://api.github.com/repos/jackhorton/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/jackhorton/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/jackhorton/ChakraCore/events","assignees_url":"https://api.github.com/repos/jackhorton/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/jackhorton/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/jackhorton/ChakraCore/tags","blobs_url":"https://api.github.com/repos/jackhorton/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackhorton/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackhorton/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackhorton/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackhorton/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/jackhorton/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/jackhorton/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/jackhorton/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/jackhorton/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/jackhorton/ChakraCore/subscription","commits_url":"https://api.github.com/repos/jackhorton/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackhorton/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackhorton/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackhorton/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackhorton/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/jackhorton/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackhorton/ChakraCore/merges","archive_url":"https://api.github.com/repos/jackhorton/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackhorton/ChakraCore/downloads","issues_url":"https://api.github.com/repos/jackhorton/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/jackhorton/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/jackhorton/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/jackhorton/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackhorton/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/jackhorton/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/jackhorton/ChakraCore/deployments","created_at":"2017-07-12T00:01:08Z","updated_at":"2017-07-12T02:25:53Z","pushed_at":"2018-08-27T18:41:49Z","git_url":"git://github.com/jackhorton/ChakraCore.git","ssh_url":"git@github.com:jackhorton/ChakraCore.git","clone_url":"https://github.com/jackhorton/ChakraCore.git","svn_url":"https://github.com/jackhorton/ChakraCore","homepage":"","size":143566,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"84b553f8012ca83a7cbf99a70ba883944472ae58","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"node_id":"MDEwOlJlcG9zaXRvcnk0OTA4NjUxMw==","name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2018-08-27T18:33:59Z","pushed_at":"2018-08-27T18:43:53Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":"","size":148722,"stargazers_count":7321,"watchers_count":7321,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":973,"mirror_url":null,"archived":false,"open_issues_count":355,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":973,"open_issues":355,"watchers":7321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5645"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/5645"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/5645"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/5645/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5645/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5645/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/b8c68078156e510b1e122163a64bf777d7baaafd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MSLaguana"}}