{"action":"created","comment":{"url":"https://api.github.com/repos/slamdata/quasar/pulls/comments/212022910","pull_request_review_id":148566568,"id":212022910,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjAyMjkxMA==","diff_hunk":"@@ -92,7 +100,7 @@ final class EquiJoinPlanner[\n \n         // identify full-cross and avoid cogroup\n         resultAndSort <- {\n-          if (keys.isEmpty) {\n+          if (cartesian) {","path":"mimir/src/main/scala/quasar/mimir/EquiJoinPlanner.scala","position":49,"original_position":49,"commit_id":"2b9a0709eece3b88f17c7e485363a2f0bda958fb","original_commit_id":"2b9a0709eece3b88f17c7e485363a2f0bda958fb","user":{"login":"alissapajer","id":1088100,"node_id":"MDQ6VXNlcjEwODgxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1088100?v=4","gravatar_id":"","url":"https://api.github.com/users/alissapajer","html_url":"https://github.com/alissapajer","followers_url":"https://api.github.com/users/alissapajer/followers","following_url":"https://api.github.com/users/alissapajer/following{/other_user}","gists_url":"https://api.github.com/users/alissapajer/gists{/gist_id}","starred_url":"https://api.github.com/users/alissapajer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alissapajer/subscriptions","organizations_url":"https://api.github.com/users/alissapajer/orgs","repos_url":"https://api.github.com/users/alissapajer/repos","events_url":"https://api.github.com/users/alissapajer/events{/privacy}","received_events_url":"https://api.github.com/users/alissapajer/received_events","type":"User","site_admin":false},"body":":+1: \r\n","created_at":"2018-08-22T16:31:29Z","updated_at":"2018-08-22T16:31:30Z","html_url":"https://github.com/slamdata/quasar/pull/3766#discussion_r212022910","pull_request_url":"https://api.github.com/repos/slamdata/quasar/pulls/3766","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/comments/212022910"},"html":{"href":"https://github.com/slamdata/quasar/pull/3766#discussion_r212022910"},"pull_request":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/3766"}}},"pull_request":{"url":"https://api.github.com/repos/slamdata/quasar/pulls/3766","id":209981711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5OTgxNzEx","html_url":"https://github.com/slamdata/quasar/pull/3766","diff_url":"https://github.com/slamdata/quasar/pull/3766.diff","patch_url":"https://github.com/slamdata/quasar/pull/3766.patch","issue_url":"https://api.github.com/repos/slamdata/quasar/issues/3766","number":3766,"state":"open","locked":false,"title":"Cache holes in branching nodes","user":{"login":"djspiewak","id":752,"node_id":"MDQ6VXNlcjc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/752?v=4","gravatar_id":"","url":"https://api.github.com/users/djspiewak","html_url":"https://github.com/djspiewak","followers_url":"https://api.github.com/users/djspiewak/followers","following_url":"https://api.github.com/users/djspiewak/following{/other_user}","gists_url":"https://api.github.com/users/djspiewak/gists{/gist_id}","starred_url":"https://api.github.com/users/djspiewak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djspiewak/subscriptions","organizations_url":"https://api.github.com/users/djspiewak/orgs","repos_url":"https://api.github.com/users/djspiewak/repos","events_url":"https://api.github.com/users/djspiewak/events{/privacy}","received_events_url":"https://api.github.com/users/djspiewak/received_events","type":"User","site_admin":false},"body":"Verified pretty well by the integration tests (though the cartesian case is apparently never hit with large datasets; perhaps for the best).\r\n\r\n[ch158]","created_at":"2018-08-21T23:18:56Z","updated_at":"2018-08-22T16:31:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe4233a4e9dd3a92da11cd7852b6007fb6ca6906","assignee":{"login":"alissapajer","id":1088100,"node_id":"MDQ6VXNlcjEwODgxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1088100?v=4","gravatar_id":"","url":"https://api.github.com/users/alissapajer","html_url":"https://github.com/alissapajer","followers_url":"https://api.github.com/users/alissapajer/followers","following_url":"https://api.github.com/users/alissapajer/following{/other_user}","gists_url":"https://api.github.com/users/alissapajer/gists{/gist_id}","starred_url":"https://api.github.com/users/alissapajer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alissapajer/subscriptions","organizations_url":"https://api.github.com/users/alissapajer/orgs","repos_url":"https://api.github.com/users/alissapajer/repos","events_url":"https://api.github.com/users/alissapajer/events{/privacy}","received_events_url":"https://api.github.com/users/alissapajer/received_events","type":"User","site_admin":false},"assignees":[{"login":"alissapajer","id":1088100,"node_id":"MDQ6VXNlcjEwODgxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1088100?v=4","gravatar_id":"","url":"https://api.github.com/users/alissapajer","html_url":"https://github.com/alissapajer","followers_url":"https://api.github.com/users/alissapajer/followers","following_url":"https://api.github.com/users/alissapajer/following{/other_user}","gists_url":"https://api.github.com/users/alissapajer/gists{/gist_id}","starred_url":"https://api.github.com/users/alissapajer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alissapajer/subscriptions","organizations_url":"https://api.github.com/users/alissapajer/orgs","repos_url":"https://api.github.com/users/alissapajer/repos","events_url":"https://api.github.com/users/alissapajer/events{/privacy}","received_events_url":"https://api.github.com/users/alissapajer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":513640878,"node_id":"MDU6TGFiZWw1MTM2NDA4Nzg=","url":"https://api.github.com/repos/slamdata/quasar/labels/version:%20feature","name":"version: feature","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/slamdata/quasar/pulls/3766/commits","review_comments_url":"https://api.github.com/repos/slamdata/quasar/pulls/3766/comments","review_comment_url":"https://api.github.com/repos/slamdata/quasar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slamdata/quasar/issues/3766/comments","statuses_url":"https://api.github.com/repos/slamdata/quasar/statuses/2b9a0709eece3b88f17c7e485363a2f0bda958fb","head":{"label":"djspiewak:feature/mimir-hole-caching","ref":"feature/mimir-hole-caching","sha":"2b9a0709eece3b88f17c7e485363a2f0bda958fb","user":{"login":"djspiewak","id":752,"node_id":"MDQ6VXNlcjc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/752?v=4","gravatar_id":"","url":"https://api.github.com/users/djspiewak","html_url":"https://github.com/djspiewak","followers_url":"https://api.github.com/users/djspiewak/followers","following_url":"https://api.github.com/users/djspiewak/following{/other_user}","gists_url":"https://api.github.com/users/djspiewak/gists{/gist_id}","starred_url":"https://api.github.com/users/djspiewak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djspiewak/subscriptions","organizations_url":"https://api.github.com/users/djspiewak/orgs","repos_url":"https://api.github.com/users/djspiewak/repos","events_url":"https://api.github.com/users/djspiewak/events{/privacy}","received_events_url":"https://api.github.com/users/djspiewak/received_events","type":"User","site_admin":false},"repo":{"id":83488997,"node_id":"MDEwOlJlcG9zaXRvcnk4MzQ4ODk5Nw==","name":"quasar","full_name":"djspiewak/quasar","owner":{"login":"djspiewak","id":752,"node_id":"MDQ6VXNlcjc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/752?v=4","gravatar_id":"","url":"https://api.github.com/users/djspiewak","html_url":"https://github.com/djspiewak","followers_url":"https://api.github.com/users/djspiewak/followers","following_url":"https://api.github.com/users/djspiewak/following{/other_user}","gists_url":"https://api.github.com/users/djspiewak/gists{/gist_id}","starred_url":"https://api.github.com/users/djspiewak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djspiewak/subscriptions","organizations_url":"https://api.github.com/users/djspiewak/orgs","repos_url":"https://api.github.com/users/djspiewak/repos","events_url":"https://api.github.com/users/djspiewak/events{/privacy}","received_events_url":"https://api.github.com/users/djspiewak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djspiewak/quasar","description":"A NoSQL analytics engine that embraces post-relational analytics and pushes computation to the data.","fork":true,"url":"https://api.github.com/repos/djspiewak/quasar","forks_url":"https://api.github.com/repos/djspiewak/quasar/forks","keys_url":"https://api.github.com/repos/djspiewak/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djspiewak/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djspiewak/quasar/teams","hooks_url":"https://api.github.com/repos/djspiewak/quasar/hooks","issue_events_url":"https://api.github.com/repos/djspiewak/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/djspiewak/quasar/events","assignees_url":"https://api.github.com/repos/djspiewak/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/djspiewak/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/djspiewak/quasar/tags","blobs_url":"https://api.github.com/repos/djspiewak/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djspiewak/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djspiewak/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/djspiewak/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djspiewak/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/djspiewak/quasar/languages","stargazers_url":"https://api.github.com/repos/djspiewak/quasar/stargazers","contributors_url":"https://api.github.com/repos/djspiewak/quasar/contributors","subscribers_url":"https://api.github.com/repos/djspiewak/quasar/subscribers","subscription_url":"https://api.github.com/repos/djspiewak/quasar/subscription","commits_url":"https://api.github.com/repos/djspiewak/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/djspiewak/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/djspiewak/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/djspiewak/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/djspiewak/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/djspiewak/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djspiewak/quasar/merges","archive_url":"https://api.github.com/repos/djspiewak/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djspiewak/quasar/downloads","issues_url":"https://api.github.com/repos/djspiewak/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/djspiewak/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/djspiewak/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/djspiewak/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djspiewak/quasar/labels{/name}","releases_url":"https://api.github.com/repos/djspiewak/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/djspiewak/quasar/deployments","created_at":"2017-02-28T23:16:24Z","updated_at":"2018-08-21T23:17:25Z","pushed_at":"2018-08-22T16:18:41Z","git_url":"git://github.com/djspiewak/quasar.git","ssh_url":"git@github.com:djspiewak/quasar.git","clone_url":"https://github.com/djspiewak/quasar.git","svn_url":"https://github.com/djspiewak/quasar","homepage":"http://quasar-analytics.org","size":74317,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slamdata:master","ref":"master","sha":"432d001c7db7930ccdea2c50dc4f33480dd4defc","user":{"login":"slamdata","id":5385602,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODU2MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/5385602?v=4","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUxNTA1OA==","name":"quasar","full_name":"slamdata/quasar","owner":{"login":"slamdata","id":5385602,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODU2MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/5385602?v=4","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slamdata/quasar","description":"A compiler and columnar analytics engine for a SQL dialect with support for heterogeneous structured data","fork":false,"url":"https://api.github.com/repos/slamdata/quasar","forks_url":"https://api.github.com/repos/slamdata/quasar/forks","keys_url":"https://api.github.com/repos/slamdata/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slamdata/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slamdata/quasar/teams","hooks_url":"https://api.github.com/repos/slamdata/quasar/hooks","issue_events_url":"https://api.github.com/repos/slamdata/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/slamdata/quasar/events","assignees_url":"https://api.github.com/repos/slamdata/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/slamdata/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/slamdata/quasar/tags","blobs_url":"https://api.github.com/repos/slamdata/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slamdata/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slamdata/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/slamdata/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slamdata/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/slamdata/quasar/languages","stargazers_url":"https://api.github.com/repos/slamdata/quasar/stargazers","contributors_url":"https://api.github.com/repos/slamdata/quasar/contributors","subscribers_url":"https://api.github.com/repos/slamdata/quasar/subscribers","subscription_url":"https://api.github.com/repos/slamdata/quasar/subscription","commits_url":"https://api.github.com/repos/slamdata/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/slamdata/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/slamdata/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/slamdata/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/slamdata/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/slamdata/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slamdata/quasar/merges","archive_url":"https://api.github.com/repos/slamdata/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slamdata/quasar/downloads","issues_url":"https://api.github.com/repos/slamdata/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/slamdata/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/slamdata/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/slamdata/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slamdata/quasar/labels{/name}","releases_url":"https://api.github.com/repos/slamdata/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/slamdata/quasar/deployments","created_at":"2014-02-04T15:01:27Z","updated_at":"2018-08-21T22:02:48Z","pushed_at":"2018-08-22T16:18:43Z","git_url":"git://github.com/slamdata/quasar.git","ssh_url":"git@github.com:slamdata/quasar.git","clone_url":"https://github.com/slamdata/quasar.git","svn_url":"https://github.com/slamdata/quasar","homepage":"","size":73856,"stargazers_count":671,"watchers_count":671,"language":"Scala","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"open_issues_count":396,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":99,"open_issues":396,"watchers":671,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/3766"},"html":{"href":"https://github.com/slamdata/quasar/pull/3766"},"issue":{"href":"https://api.github.com/repos/slamdata/quasar/issues/3766"},"comments":{"href":"https://api.github.com/repos/slamdata/quasar/issues/3766/comments"},"review_comments":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/3766/comments"},"review_comment":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/3766/commits"},"statuses":{"href":"https://api.github.com/repos/slamdata/quasar/statuses/2b9a0709eece3b88f17c7e485363a2f0bda958fb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alissapajer"}}