{"action":"created","comment":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments/176599078","pull_request_review_id":106333692,"id":176599078,"diff_hunk":"@@ -108,7 +78,7 @@\n \n <script>\n \n-  import coreTable from 'kolibri.coreVue.components.coreTable';\n+  import userTable from '../user-table';","path":"kolibri/plugins/facility_management/assets/src/views/user-page/index.vue","position":70,"original_position":70,"commit_id":"5a3ea61773b71fffc47ead5df7b3068e075030e2","original_commit_id":"5a3ea61773b71fffc47ead5df7b3068e075030e2","user":{"login":"jonboiser","id":10248067,"avatar_url":"https://avatars2.githubusercontent.com/u/10248067?v=4","gravatar_id":"","url":"https://api.github.com/users/jonboiser","html_url":"https://github.com/jonboiser","followers_url":"https://api.github.com/users/jonboiser/followers","following_url":"https://api.github.com/users/jonboiser/following{/other_user}","gists_url":"https://api.github.com/users/jonboiser/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboiser/subscriptions","organizations_url":"https://api.github.com/users/jonboiser/orgs","repos_url":"https://api.github.com/users/jonboiser/repos","events_url":"https://api.github.com/users/jonboiser/events{/privacy}","received_events_url":"https://api.github.com/users/jonboiser/received_events","type":"User","site_admin":false},"body":"Could you fix the thing where Class Coaches are not being included when \"Coaches\" filter is selected?","created_at":"2018-03-22T23:12:22Z","updated_at":"2018-03-22T23:12:22Z","html_url":"https://github.com/learningequality/kolibri/pull/3397#discussion_r176599078","pull_request_url":"https://api.github.com/repos/learningequality/kolibri/pulls/3397","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments/176599078"},"html":{"href":"https://github.com/learningequality/kolibri/pull/3397#discussion_r176599078"},"pull_request":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3397"}}},"pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/3397","id":176661315,"html_url":"https://github.com/learningequality/kolibri/pull/3397","diff_url":"https://github.com/learningequality/kolibri/pull/3397.diff","patch_url":"https://github.com/learningequality/kolibri/pull/3397.patch","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/3397","number":3397,"state":"open","locked":false,"title":"Class coach  nice-to-haves and fixes","user":{"login":"DXCanas","id":9877852,"avatar_url":"https://avatars2.githubusercontent.com/u/9877852?v=4","gravatar_id":"","url":"https://api.github.com/users/DXCanas","html_url":"https://github.com/DXCanas","followers_url":"https://api.github.com/users/DXCanas/followers","following_url":"https://api.github.com/users/DXCanas/following{/other_user}","gists_url":"https://api.github.com/users/DXCanas/gists{/gist_id}","starred_url":"https://api.github.com/users/DXCanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DXCanas/subscriptions","organizations_url":"https://api.github.com/users/DXCanas/orgs","repos_url":"https://api.github.com/users/DXCanas/repos","events_url":"https://api.github.com/users/DXCanas/events{/privacy}","received_events_url":"https://api.github.com/users/DXCanas/received_events","type":"User","site_admin":false},"body":"<!--\r\n 1. Following guidance below, replace …'s with your own words\r\n 2. After saving the PR, tick of completed checklist items\r\n 3. Skip checklist items that are not applicable or not necessary\r\n 4. Delete instruction/comment blocks\r\n-->\r\n\r\n### Summary\r\n<!--\r\n * description of the change\r\n * manual verification steps performed\r\n * screenshots if the PR affects the UI\r\n-->\r\n\r\nContinued iteration on pieces related to class-coaches feature.\r\n\r\n### Reviewer guidance\r\n<!--\r\n * how can a reviewer test these changes?\r\n * are there any risky areas that deserve extra testing\r\n-->\r\n\r\nNo earth-shattering changes. Mostly nice-to-haves that were saved until the end. \r\n\r\nSome fixes from the march 22nd bug bash, requested by @khangmach \r\n#### Before:\r\n![before](https://user-images.githubusercontent.com/9877852/37803283-2a17426a-2deb-11e8-94dc-fca046af656c.png)\r\n#### After\r\n![after](https://user-images.githubusercontent.com/9877852/37803274-1d7f3526-2deb-11e8-8341-cc7e1cbc1640.png)\r\n\r\n\r\n### References\r\n<!--\r\n * references to related issues and PRs\r\n * links to mockups or specs for new features\r\n * links to the diffs for any dependency updates, e.g. in iceqube or the perseus plugin\r\n-->\r\n\r\n\r\n- #3340 \r\n- #3307\r\n----\r\n\r\n### Contributor Checklist\r\n\r\n- [x] Contributor has fully tested the PR manually\r\n- [x] PR has the correct target branch and milestone\r\n- [x] PR has 'needs review' or 'work-in-progress' label\r\n- [x] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')\r\n- [x] If there are any front-end changes, before/after screenshots are included\r\n- [x] If this is an important user-facing change, PR or related issue has a 'changelog' label\r\n\r\n### Reviewer Checklist\r\n\r\n- [ ] Automated test coverage is satisfactory\r\n- [ ] Reviewer has fully tested the PR manually\r\n- [ ] PR has been tested for [accessibility regressions](http://kolibri-dev.readthedocs.io/en/develop/manual_testing.html#accessibility-a11y-testing)\r\n- [ ] External dependencies files were updated (`yarn` and `pip`)\r\n- [ ] Documentation is updated\r\n- [ ] Link to diff of internal dependency change is included\r\n- [ ] CHANGELOG.rst is updated for high-level changes\r\n- [ ] Contributor is in AUTHORS.rst\r\n","created_at":"2018-03-22T02:44:56Z","updated_at":"2018-03-22T23:12:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"442c73d128f190efd1bee77eca1485baa67339da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":492821376,"url":"https://api.github.com/repos/learningequality/kolibri/labels/DEV:%20frontend","name":"DEV: frontend","color":"DFDFDF","default":false},{"id":667034823,"url":"https://api.github.com/repos/learningequality/kolibri/labels/P1%20-%20important","name":"P1 - important","color":"ff8400","default":false},{"id":410338552,"url":"https://api.github.com/repos/learningequality/kolibri/labels/PR:%20needs%20review","name":"PR: needs review","color":"1f6ad6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/learningequality/kolibri/pulls/3397/commits","review_comments_url":"https://api.github.com/repos/learningequality/kolibri/pulls/3397/comments","review_comment_url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/3397/comments","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/5a3ea61773b71fffc47ead5df7b3068e075030e2","head":{"label":"DXCanas:class-coaches","ref":"class-coaches","sha":"5a3ea61773b71fffc47ead5df7b3068e075030e2","user":{"login":"DXCanas","id":9877852,"avatar_url":"https://avatars2.githubusercontent.com/u/9877852?v=4","gravatar_id":"","url":"https://api.github.com/users/DXCanas","html_url":"https://github.com/DXCanas","followers_url":"https://api.github.com/users/DXCanas/followers","following_url":"https://api.github.com/users/DXCanas/following{/other_user}","gists_url":"https://api.github.com/users/DXCanas/gists{/gist_id}","starred_url":"https://api.github.com/users/DXCanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DXCanas/subscriptions","organizations_url":"https://api.github.com/users/DXCanas/orgs","repos_url":"https://api.github.com/users/DXCanas/repos","events_url":"https://api.github.com/users/DXCanas/events{/privacy}","received_events_url":"https://api.github.com/users/DXCanas/received_events","type":"User","site_admin":false},"repo":{"id":54430150,"name":"kolibri","full_name":"DXCanas/kolibri","owner":{"login":"DXCanas","id":9877852,"avatar_url":"https://avatars2.githubusercontent.com/u/9877852?v=4","gravatar_id":"","url":"https://api.github.com/users/DXCanas","html_url":"https://github.com/DXCanas","followers_url":"https://api.github.com/users/DXCanas/followers","following_url":"https://api.github.com/users/DXCanas/following{/other_user}","gists_url":"https://api.github.com/users/DXCanas/gists{/gist_id}","starred_url":"https://api.github.com/users/DXCanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DXCanas/subscriptions","organizations_url":"https://api.github.com/users/DXCanas/orgs","repos_url":"https://api.github.com/users/DXCanas/repos","events_url":"https://api.github.com/users/DXCanas/events{/privacy}","received_events_url":"https://api.github.com/users/DXCanas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DXCanas/kolibri","description":"This is where Kolibri shall be born, watch and participate!","fork":true,"url":"https://api.github.com/repos/DXCanas/kolibri","forks_url":"https://api.github.com/repos/DXCanas/kolibri/forks","keys_url":"https://api.github.com/repos/DXCanas/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DXCanas/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DXCanas/kolibri/teams","hooks_url":"https://api.github.com/repos/DXCanas/kolibri/hooks","issue_events_url":"https://api.github.com/repos/DXCanas/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/DXCanas/kolibri/events","assignees_url":"https://api.github.com/repos/DXCanas/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/DXCanas/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/DXCanas/kolibri/tags","blobs_url":"https://api.github.com/repos/DXCanas/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DXCanas/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DXCanas/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/DXCanas/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DXCanas/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/DXCanas/kolibri/languages","stargazers_url":"https://api.github.com/repos/DXCanas/kolibri/stargazers","contributors_url":"https://api.github.com/repos/DXCanas/kolibri/contributors","subscribers_url":"https://api.github.com/repos/DXCanas/kolibri/subscribers","subscription_url":"https://api.github.com/repos/DXCanas/kolibri/subscription","commits_url":"https://api.github.com/repos/DXCanas/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/DXCanas/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/DXCanas/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/DXCanas/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/DXCanas/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/DXCanas/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DXCanas/kolibri/merges","archive_url":"https://api.github.com/repos/DXCanas/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DXCanas/kolibri/downloads","issues_url":"https://api.github.com/repos/DXCanas/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/DXCanas/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/DXCanas/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/DXCanas/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DXCanas/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/DXCanas/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/DXCanas/kolibri/deployments","created_at":"2016-03-21T23:25:49Z","updated_at":"2016-03-21T23:25:50Z","pushed_at":"2018-03-22T22:54:53Z","git_url":"git://github.com/DXCanas/kolibri.git","ssh_url":"git@github.com:DXCanas/kolibri.git","clone_url":"https://github.com/DXCanas/kolibri.git","svn_url":"https://github.com/DXCanas/kolibri","homepage":"http://learningequality.org/kolibri/","size":36647,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"learningequality:release-v0.9.x","ref":"release-v0.9.x","sha":"0e7ee1689c1edfbb1a6e27343e9c5a7993b3b371","user":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":49976939,"name":"kolibri","full_name":"learningequality/kolibri","owner":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/kolibri","description":"Kolibri: the offline app for universal education","fork":false,"url":"https://api.github.com/repos/learningequality/kolibri","forks_url":"https://api.github.com/repos/learningequality/kolibri/forks","keys_url":"https://api.github.com/repos/learningequality/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/kolibri/teams","hooks_url":"https://api.github.com/repos/learningequality/kolibri/hooks","issue_events_url":"https://api.github.com/repos/learningequality/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/kolibri/events","assignees_url":"https://api.github.com/repos/learningequality/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/kolibri/tags","blobs_url":"https://api.github.com/repos/learningequality/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/kolibri/languages","stargazers_url":"https://api.github.com/repos/learningequality/kolibri/stargazers","contributors_url":"https://api.github.com/repos/learningequality/kolibri/contributors","subscribers_url":"https://api.github.com/repos/learningequality/kolibri/subscribers","subscription_url":"https://api.github.com/repos/learningequality/kolibri/subscription","commits_url":"https://api.github.com/repos/learningequality/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/learningequality/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/kolibri/merges","archive_url":"https://api.github.com/repos/learningequality/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/kolibri/downloads","issues_url":"https://api.github.com/repos/learningequality/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/learningequality/kolibri/deployments","created_at":"2016-01-19T19:22:07Z","updated_at":"2018-03-22T09:13:47Z","pushed_at":"2018-03-22T23:05:44Z","git_url":"git://github.com/learningequality/kolibri.git","ssh_url":"git@github.com:learningequality/kolibri.git","clone_url":"https://github.com/learningequality/kolibri.git","svn_url":"https://github.com/learningequality/kolibri","homepage":"http://learningequality.org/kolibri/","size":36694,"stargazers_count":158,"watchers_count":158,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":116,"mirror_url":null,"archived":false,"open_issues_count":226,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":116,"open_issues":226,"watchers":158,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3397"},"html":{"href":"https://github.com/learningequality/kolibri/pull/3397"},"issue":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/3397"},"comments":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/3397/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3397/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3397/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/kolibri/statuses/5a3ea61773b71fffc47ead5df7b3068e075030e2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jonboiser"}}