{"action":"created","comment":{"url":"https://api.github.com/repos/simgrid/simgrid/pulls/comments/234991739","pull_request_review_id":176752315,"id":234991739,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDk5MTczOQ==","diff_hunk":"@@ -14,10 +14,11 @@ XBT_LOG_NEW_DEFAULT_CATEGORY(sampi_load_balancer_test, \"Messages specific for th\n \n int main(int argc, char* argv[])\n {\n+  /* Commenting this test, for now...","path":"examples/smpi/load_balancer_replay/load_balancer_replay.cpp","position":4,"original_position":4,"commit_id":"edf4ba2d71101efd73e0f358ab7bd3b8568a2201","original_commit_id":"edf4ba2d71101efd73e0f358ab7bd3b8568a2201","user":{"login":"mpoquet","id":3502831,"node_id":"MDQ6VXNlcjM1MDI4MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3502831?v=4","gravatar_id":"","url":"https://api.github.com/users/mpoquet","html_url":"https://github.com/mpoquet","followers_url":"https://api.github.com/users/mpoquet/followers","following_url":"https://api.github.com/users/mpoquet/following{/other_user}","gists_url":"https://api.github.com/users/mpoquet/gists{/gist_id}","starred_url":"https://api.github.com/users/mpoquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpoquet/subscriptions","organizations_url":"https://api.github.com/users/mpoquet/orgs","repos_url":"https://api.github.com/users/mpoquet/repos","events_url":"https://api.github.com/users/mpoquet/events{/privacy}","received_events_url":"https://api.github.com/users/mpoquet/received_events","type":"User","site_admin":false},"body":"If I remember correctly the test was just compiled before, not executed at all. I'm asking @Shurakai about it.","created_at":"2018-11-20T12:59:49Z","updated_at":"2018-11-20T12:59:50Z","html_url":"https://github.com/simgrid/simgrid/pull/314#discussion_r234991739","pull_request_url":"https://api.github.com/repos/simgrid/simgrid/pulls/314","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/simgrid/simgrid/pulls/comments/234991739"},"html":{"href":"https://github.com/simgrid/simgrid/pull/314#discussion_r234991739"},"pull_request":{"href":"https://api.github.com/repos/simgrid/simgrid/pulls/314"}},"in_reply_to_id":234935026},"pull_request":{"url":"https://api.github.com/repos/simgrid/simgrid/pulls/314","id":231585854,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNTg1ODU0","html_url":"https://github.com/simgrid/simgrid/pull/314","diff_url":"https://github.com/simgrid/simgrid/pull/314.diff","patch_url":"https://github.com/simgrid/simgrid/pull/314.patch","issue_url":"https://api.github.com/repos/simgrid/simgrid/issues/314","number":314,"state":"open","locked":false,"title":"SMPI args cleanup","user":{"login":"mpoquet","id":3502831,"node_id":"MDQ6VXNlcjM1MDI4MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/3502831?v=4","gravatar_id":"","url":"https://api.github.com/users/mpoquet","html_url":"https://github.com/mpoquet","followers_url":"https://api.github.com/users/mpoquet/followers","following_url":"https://api.github.com/users/mpoquet/following{/other_user}","gists_url":"https://api.github.com/users/mpoquet/gists{/gist_id}","starred_url":"https://api.github.com/users/mpoquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpoquet/subscriptions","organizations_url":"https://api.github.com/users/mpoquet/orgs","repos_url":"https://api.github.com/users/mpoquet/repos","events_url":"https://api.github.com/users/mpoquet/events{/privacy}","received_events_url":"https://api.github.com/users/mpoquet/received_events","type":"User","site_admin":false},"body":"This is another SMPI clean-up attempt after #311.\r\n\r\nAll SMPI tests pass on my machine (including FORTRAN and test suites disabled by default).\r\nNo warning under clang-7.0.0 nor g++-8.2.1.\r\n\r\n#### Main changes\r\n- use actor properties instead of args for instance_id and rank\r\n- remove argc/argv from several functions\r\n  - either by making the desired arguments explicit (replay/offline)\r\n  - or by using the actor properties (online)\r\n- set usual argv[0] for online processes (value is the path of the executed binary)","created_at":"2018-11-16T16:27:54Z","updated_at":"2018-11-20T12:59:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e46e11f6827a95b9634d0227405fef4e405cc75","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":205173924,"node_id":"MDU6TGFiZWwyMDUxNzM5MjQ=","url":"https://api.github.com/repos/simgrid/simgrid/labels/smpi","name":"smpi","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/simgrid/simgrid/pulls/314/commits","review_comments_url":"https://api.github.com/repos/simgrid/simgrid/pulls/314/comments","review_comment_url":"https://api.github.com/repos/simgrid/simgrid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simgrid/simgrid/issues/314/comments","statuses_url":"https://api.github.com/repos/simgrid/simgrid/statuses/edf4ba2d71101efd73e0f358ab7bd3b8568a2201","head":{"label":"simgrid:smpi-args-cleanup","ref":"smpi-args-cleanup","sha":"edf4ba2d71101efd73e0f358ab7bd3b8568a2201","user":{"login":"simgrid","id":19318675,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzE4Njc1","avatar_url":"https://avatars1.githubusercontent.com/u/19318675?v=4","gravatar_id":"","url":"https://api.github.com/users/simgrid","html_url":"https://github.com/simgrid","followers_url":"https://api.github.com/users/simgrid/followers","following_url":"https://api.github.com/users/simgrid/following{/other_user}","gists_url":"https://api.github.com/users/simgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/simgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simgrid/subscriptions","organizations_url":"https://api.github.com/users/simgrid/orgs","repos_url":"https://api.github.com/users/simgrid/repos","events_url":"https://api.github.com/users/simgrid/events{/privacy}","received_events_url":"https://api.github.com/users/simgrid/received_events","type":"Organization","site_admin":false},"repo":{"id":3389701,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg5NzAx","name":"simgrid","full_name":"simgrid/simgrid","private":false,"owner":{"login":"simgrid","id":19318675,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzE4Njc1","avatar_url":"https://avatars1.githubusercontent.com/u/19318675?v=4","gravatar_id":"","url":"https://api.github.com/users/simgrid","html_url":"https://github.com/simgrid","followers_url":"https://api.github.com/users/simgrid/followers","following_url":"https://api.github.com/users/simgrid/following{/other_user}","gists_url":"https://api.github.com/users/simgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/simgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simgrid/subscriptions","organizations_url":"https://api.github.com/users/simgrid/orgs","repos_url":"https://api.github.com/users/simgrid/repos","events_url":"https://api.github.com/users/simgrid/events{/privacy}","received_events_url":"https://api.github.com/users/simgrid/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/simgrid/simgrid","description":"Framework for the simulation of distributed applications (Clouds, HPC, Grids, IoT and others)","fork":false,"url":"https://api.github.com/repos/simgrid/simgrid","forks_url":"https://api.github.com/repos/simgrid/simgrid/forks","keys_url":"https://api.github.com/repos/simgrid/simgrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simgrid/simgrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simgrid/simgrid/teams","hooks_url":"https://api.github.com/repos/simgrid/simgrid/hooks","issue_events_url":"https://api.github.com/repos/simgrid/simgrid/issues/events{/number}","events_url":"https://api.github.com/repos/simgrid/simgrid/events","assignees_url":"https://api.github.com/repos/simgrid/simgrid/assignees{/user}","branches_url":"https://api.github.com/repos/simgrid/simgrid/branches{/branch}","tags_url":"https://api.github.com/repos/simgrid/simgrid/tags","blobs_url":"https://api.github.com/repos/simgrid/simgrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simgrid/simgrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simgrid/simgrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/simgrid/simgrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simgrid/simgrid/statuses/{sha}","languages_url":"https://api.github.com/repos/simgrid/simgrid/languages","stargazers_url":"https://api.github.com/repos/simgrid/simgrid/stargazers","contributors_url":"https://api.github.com/repos/simgrid/simgrid/contributors","subscribers_url":"https://api.github.com/repos/simgrid/simgrid/subscribers","subscription_url":"https://api.github.com/repos/simgrid/simgrid/subscription","commits_url":"https://api.github.com/repos/simgrid/simgrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/simgrid/simgrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/simgrid/simgrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/simgrid/simgrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/simgrid/simgrid/contents/{+path}","compare_url":"https://api.github.com/repos/simgrid/simgrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simgrid/simgrid/merges","archive_url":"https://api.github.com/repos/simgrid/simgrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simgrid/simgrid/downloads","issues_url":"https://api.github.com/repos/simgrid/simgrid/issues{/number}","pulls_url":"https://api.github.com/repos/simgrid/simgrid/pulls{/number}","milestones_url":"https://api.github.com/repos/simgrid/simgrid/milestones{/number}","notifications_url":"https://api.github.com/repos/simgrid/simgrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simgrid/simgrid/labels{/name}","releases_url":"https://api.github.com/repos/simgrid/simgrid/releases{/id}","deployments_url":"https://api.github.com/repos/simgrid/simgrid/deployments","created_at":"2012-02-08T17:59:38Z","updated_at":"2018-11-20T06:05:52Z","pushed_at":"2018-11-20T09:25:18Z","git_url":"git://github.com/simgrid/simgrid.git","ssh_url":"git@github.com:simgrid/simgrid.git","clone_url":"https://github.com/simgrid/simgrid.git","svn_url":"https://github.com/simgrid/simgrid","homepage":"http://simgrid.org/","size":89769,"stargazers_count":62,"watchers_count":62,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":47,"open_issues":41,"watchers":62,"default_branch":"master"}},"base":{"label":"simgrid:master","ref":"master","sha":"9dec3b0501e4464e246196d29dce6d03a6cbd2d7","user":{"login":"simgrid","id":19318675,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzE4Njc1","avatar_url":"https://avatars1.githubusercontent.com/u/19318675?v=4","gravatar_id":"","url":"https://api.github.com/users/simgrid","html_url":"https://github.com/simgrid","followers_url":"https://api.github.com/users/simgrid/followers","following_url":"https://api.github.com/users/simgrid/following{/other_user}","gists_url":"https://api.github.com/users/simgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/simgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simgrid/subscriptions","organizations_url":"https://api.github.com/users/simgrid/orgs","repos_url":"https://api.github.com/users/simgrid/repos","events_url":"https://api.github.com/users/simgrid/events{/privacy}","received_events_url":"https://api.github.com/users/simgrid/received_events","type":"Organization","site_admin":false},"repo":{"id":3389701,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg5NzAx","name":"simgrid","full_name":"simgrid/simgrid","private":false,"owner":{"login":"simgrid","id":19318675,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzE4Njc1","avatar_url":"https://avatars1.githubusercontent.com/u/19318675?v=4","gravatar_id":"","url":"https://api.github.com/users/simgrid","html_url":"https://github.com/simgrid","followers_url":"https://api.github.com/users/simgrid/followers","following_url":"https://api.github.com/users/simgrid/following{/other_user}","gists_url":"https://api.github.com/users/simgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/simgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simgrid/subscriptions","organizations_url":"https://api.github.com/users/simgrid/orgs","repos_url":"https://api.github.com/users/simgrid/repos","events_url":"https://api.github.com/users/simgrid/events{/privacy}","received_events_url":"https://api.github.com/users/simgrid/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/simgrid/simgrid","description":"Framework for the simulation of distributed applications (Clouds, HPC, Grids, IoT and others)","fork":false,"url":"https://api.github.com/repos/simgrid/simgrid","forks_url":"https://api.github.com/repos/simgrid/simgrid/forks","keys_url":"https://api.github.com/repos/simgrid/simgrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simgrid/simgrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simgrid/simgrid/teams","hooks_url":"https://api.github.com/repos/simgrid/simgrid/hooks","issue_events_url":"https://api.github.com/repos/simgrid/simgrid/issues/events{/number}","events_url":"https://api.github.com/repos/simgrid/simgrid/events","assignees_url":"https://api.github.com/repos/simgrid/simgrid/assignees{/user}","branches_url":"https://api.github.com/repos/simgrid/simgrid/branches{/branch}","tags_url":"https://api.github.com/repos/simgrid/simgrid/tags","blobs_url":"https://api.github.com/repos/simgrid/simgrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simgrid/simgrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simgrid/simgrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/simgrid/simgrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simgrid/simgrid/statuses/{sha}","languages_url":"https://api.github.com/repos/simgrid/simgrid/languages","stargazers_url":"https://api.github.com/repos/simgrid/simgrid/stargazers","contributors_url":"https://api.github.com/repos/simgrid/simgrid/contributors","subscribers_url":"https://api.github.com/repos/simgrid/simgrid/subscribers","subscription_url":"https://api.github.com/repos/simgrid/simgrid/subscription","commits_url":"https://api.github.com/repos/simgrid/simgrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/simgrid/simgrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/simgrid/simgrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/simgrid/simgrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/simgrid/simgrid/contents/{+path}","compare_url":"https://api.github.com/repos/simgrid/simgrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simgrid/simgrid/merges","archive_url":"https://api.github.com/repos/simgrid/simgrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simgrid/simgrid/downloads","issues_url":"https://api.github.com/repos/simgrid/simgrid/issues{/number}","pulls_url":"https://api.github.com/repos/simgrid/simgrid/pulls{/number}","milestones_url":"https://api.github.com/repos/simgrid/simgrid/milestones{/number}","notifications_url":"https://api.github.com/repos/simgrid/simgrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simgrid/simgrid/labels{/name}","releases_url":"https://api.github.com/repos/simgrid/simgrid/releases{/id}","deployments_url":"https://api.github.com/repos/simgrid/simgrid/deployments","created_at":"2012-02-08T17:59:38Z","updated_at":"2018-11-20T06:05:52Z","pushed_at":"2018-11-20T09:25:18Z","git_url":"git://github.com/simgrid/simgrid.git","ssh_url":"git@github.com:simgrid/simgrid.git","clone_url":"https://github.com/simgrid/simgrid.git","svn_url":"https://github.com/simgrid/simgrid","homepage":"http://simgrid.org/","size":89769,"stargazers_count":62,"watchers_count":62,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":47,"open_issues":41,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simgrid/simgrid/pulls/314"},"html":{"href":"https://github.com/simgrid/simgrid/pull/314"},"issue":{"href":"https://api.github.com/repos/simgrid/simgrid/issues/314"},"comments":{"href":"https://api.github.com/repos/simgrid/simgrid/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/simgrid/simgrid/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/simgrid/simgrid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simgrid/simgrid/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/simgrid/simgrid/statuses/edf4ba2d71101efd73e0f358ab7bd3b8568a2201"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mpoquet"}}