{"action":"closed","number":396,"pull_request":{"url":"https://api.github.com/repos/paypal/downshift/pulls/396","id":177185967,"html_url":"https://github.com/paypal/downshift/pull/396","diff_url":"https://github.com/paypal/downshift/pull/396.diff","patch_url":"https://github.com/paypal/downshift/pull/396.patch","issue_url":"https://api.github.com/repos/paypal/downshift/issues/396","number":396,"state":"closed","locked":false,"title":"fix(aria): improve WAI-ARIA compliance","user":{"login":"kentcdodds","id":1500684,"avatar_url":"https://avatars0.githubusercontent.com/u/1500684?v=4","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"body":"**What**: Make some changes to the aria attributes\r\n\r\n<!-- Why are these changes necessary? -->\r\n\r\n**Why**: Improve our compliance to WAI-ARIA, thanks to feedback from @1Copenut in https://github.com/paypal/downshift/pull/285 :clap:\r\n\r\n<!-- How were these changes implemented? -->\r\n\r\n**How**: Followed the feedback to edit the aria attributes and added a test for some logic around `aria-label` for `getMenuProps`\r\n\r\n**Checklist**:\r\n\r\n<!-- add \"N/A\" to the end of each line that's irrelevant to your changes -->\r\n\r\n<!-- to check an item, place an \"x\" in the box like so: \"- [x] Documentation\" -->\r\n\r\n* [x] Documentation\r\n* [x] Tests\r\n* [x] Ready to be merged\r\n      <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->\r\n* [x] Added contributors to contributors table\r\n      <!-- this is optional, see the contributing guidelines for instructions -->\r\n","created_at":"2018-03-23T21:15:39Z","updated_at":"2018-03-23T21:31:30Z","closed_at":"2018-03-23T21:31:30Z","merged_at":"2018-03-23T21:31:30Z","merge_commit_sha":"3952c7bb078f7fe9b2403ca31fc9fce85d97c216","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/paypal/downshift/pulls/396/commits","review_comments_url":"https://api.github.com/repos/paypal/downshift/pulls/396/comments","review_comment_url":"https://api.github.com/repos/paypal/downshift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paypal/downshift/issues/396/comments","statuses_url":"https://api.github.com/repos/paypal/downshift/statuses/7f66c4e143a9e0b5155d973469d3c1f953be4f87","head":{"label":"paypal:pr/aria-improvements-2","ref":"pr/aria-improvements-2","sha":"7f66c4e143a9e0b5155d973469d3c1f953be4f87","user":{"login":"paypal","id":476675,"avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"repo":{"id":98315735,"name":"downshift","full_name":"paypal/downshift","owner":{"login":"paypal","id":476675,"avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paypal/downshift","description":"🏎 Primitives to build simple, flexible, WAI-ARIA compliant enhanced input React components","fork":false,"url":"https://api.github.com/repos/paypal/downshift","forks_url":"https://api.github.com/repos/paypal/downshift/forks","keys_url":"https://api.github.com/repos/paypal/downshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paypal/downshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paypal/downshift/teams","hooks_url":"https://api.github.com/repos/paypal/downshift/hooks","issue_events_url":"https://api.github.com/repos/paypal/downshift/issues/events{/number}","events_url":"https://api.github.com/repos/paypal/downshift/events","assignees_url":"https://api.github.com/repos/paypal/downshift/assignees{/user}","branches_url":"https://api.github.com/repos/paypal/downshift/branches{/branch}","tags_url":"https://api.github.com/repos/paypal/downshift/tags","blobs_url":"https://api.github.com/repos/paypal/downshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paypal/downshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paypal/downshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/paypal/downshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paypal/downshift/statuses/{sha}","languages_url":"https://api.github.com/repos/paypal/downshift/languages","stargazers_url":"https://api.github.com/repos/paypal/downshift/stargazers","contributors_url":"https://api.github.com/repos/paypal/downshift/contributors","subscribers_url":"https://api.github.com/repos/paypal/downshift/subscribers","subscription_url":"https://api.github.com/repos/paypal/downshift/subscription","commits_url":"https://api.github.com/repos/paypal/downshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/paypal/downshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/paypal/downshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/paypal/downshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/paypal/downshift/contents/{+path}","compare_url":"https://api.github.com/repos/paypal/downshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paypal/downshift/merges","archive_url":"https://api.github.com/repos/paypal/downshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paypal/downshift/downloads","issues_url":"https://api.github.com/repos/paypal/downshift/issues{/number}","pulls_url":"https://api.github.com/repos/paypal/downshift/pulls{/number}","milestones_url":"https://api.github.com/repos/paypal/downshift/milestones{/number}","notifications_url":"https://api.github.com/repos/paypal/downshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paypal/downshift/labels{/name}","releases_url":"https://api.github.com/repos/paypal/downshift/releases{/id}","deployments_url":"https://api.github.com/repos/paypal/downshift/deployments","created_at":"2017-07-25T14:31:42Z","updated_at":"2018-03-23T21:05:35Z","pushed_at":"2018-03-23T21:31:30Z","git_url":"git://github.com/paypal/downshift.git","ssh_url":"git@github.com:paypal/downshift.git","clone_url":"https://github.com/paypal/downshift.git","svn_url":"https://github.com/paypal/downshift","homepage":"http://downshift.netlify.com/","size":634,"stargazers_count":3691,"watchers_count":3691,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":231,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":231,"open_issues":10,"watchers":3691,"default_branch":"master"}},"base":{"label":"paypal:next","ref":"next","sha":"1dcf82cf3af4215d583b077f7299db343b6440ce","user":{"login":"paypal","id":476675,"avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"repo":{"id":98315735,"name":"downshift","full_name":"paypal/downshift","owner":{"login":"paypal","id":476675,"avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paypal/downshift","description":"🏎 Primitives to build simple, flexible, WAI-ARIA compliant enhanced input React components","fork":false,"url":"https://api.github.com/repos/paypal/downshift","forks_url":"https://api.github.com/repos/paypal/downshift/forks","keys_url":"https://api.github.com/repos/paypal/downshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paypal/downshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paypal/downshift/teams","hooks_url":"https://api.github.com/repos/paypal/downshift/hooks","issue_events_url":"https://api.github.com/repos/paypal/downshift/issues/events{/number}","events_url":"https://api.github.com/repos/paypal/downshift/events","assignees_url":"https://api.github.com/repos/paypal/downshift/assignees{/user}","branches_url":"https://api.github.com/repos/paypal/downshift/branches{/branch}","tags_url":"https://api.github.com/repos/paypal/downshift/tags","blobs_url":"https://api.github.com/repos/paypal/downshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paypal/downshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paypal/downshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/paypal/downshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paypal/downshift/statuses/{sha}","languages_url":"https://api.github.com/repos/paypal/downshift/languages","stargazers_url":"https://api.github.com/repos/paypal/downshift/stargazers","contributors_url":"https://api.github.com/repos/paypal/downshift/contributors","subscribers_url":"https://api.github.com/repos/paypal/downshift/subscribers","subscription_url":"https://api.github.com/repos/paypal/downshift/subscription","commits_url":"https://api.github.com/repos/paypal/downshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/paypal/downshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/paypal/downshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/paypal/downshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/paypal/downshift/contents/{+path}","compare_url":"https://api.github.com/repos/paypal/downshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paypal/downshift/merges","archive_url":"https://api.github.com/repos/paypal/downshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paypal/downshift/downloads","issues_url":"https://api.github.com/repos/paypal/downshift/issues{/number}","pulls_url":"https://api.github.com/repos/paypal/downshift/pulls{/number}","milestones_url":"https://api.github.com/repos/paypal/downshift/milestones{/number}","notifications_url":"https://api.github.com/repos/paypal/downshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paypal/downshift/labels{/name}","releases_url":"https://api.github.com/repos/paypal/downshift/releases{/id}","deployments_url":"https://api.github.com/repos/paypal/downshift/deployments","created_at":"2017-07-25T14:31:42Z","updated_at":"2018-03-23T21:05:35Z","pushed_at":"2018-03-23T21:31:30Z","git_url":"git://github.com/paypal/downshift.git","ssh_url":"git@github.com:paypal/downshift.git","clone_url":"https://github.com/paypal/downshift.git","svn_url":"https://github.com/paypal/downshift","homepage":"http://downshift.netlify.com/","size":634,"stargazers_count":3691,"watchers_count":3691,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":231,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":231,"open_issues":10,"watchers":3691,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paypal/downshift/pulls/396"},"html":{"href":"https://github.com/paypal/downshift/pull/396"},"issue":{"href":"https://api.github.com/repos/paypal/downshift/issues/396"},"comments":{"href":"https://api.github.com/repos/paypal/downshift/issues/396/comments"},"review_comments":{"href":"https://api.github.com/repos/paypal/downshift/pulls/396/comments"},"review_comment":{"href":"https://api.github.com/repos/paypal/downshift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paypal/downshift/pulls/396/commits"},"statuses":{"href":"https://api.github.com/repos/paypal/downshift/statuses/7f66c4e143a9e0b5155d973469d3c1f953be4f87"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kentcdodds","id":1500684,"avatar_url":"https://avatars0.githubusercontent.com/u/1500684?v=4","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":1,"additions":59,"deletions":44,"changed_files":7}}
{"actor":{"display_login":"kentcdodds"}}