{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/prepack/pulls/comments/221389060","pull_request_review_id":160034250,"id":221389060,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTM4OTA2MA==","diff_hunk":"@@ -160,7 +160,7 @@ function materializeObject(realm: Realm, object: ObjectValue, getCachingHeapInsp\n                 descriptor.configurable !== targetDescriptor.configurable\n               ) {\n                 generator.emitDefineProperty(object, name, descriptor);\n-              } else {\n+              } else if (!object.$IsClassPrototype) {","path":"src/utils/leak.js","position":5,"original_position":5,"commit_id":"194a0eb21f638b8ce1c8206863b9d3b1c490c8ed","original_commit_id":"194a0eb21f638b8ce1c8206863b9d3b1c490c8ed","user":{"login":"NTillmann","id":6457462,"node_id":"MDQ6VXNlcjY0NTc0NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6457462?v=4","gravatar_id":"","url":"https://api.github.com/users/NTillmann","html_url":"https://github.com/NTillmann","followers_url":"https://api.github.com/users/NTillmann/followers","following_url":"https://api.github.com/users/NTillmann/following{/other_user}","gists_url":"https://api.github.com/users/NTillmann/gists{/gist_id}","starred_url":"https://api.github.com/users/NTillmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NTillmann/subscriptions","organizations_url":"https://api.github.com/users/NTillmann/orgs","repos_url":"https://api.github.com/users/NTillmann/repos","events_url":"https://api.github.com/users/NTillmann/events{/privacy}","received_events_url":"https://api.github.com/users/NTillmann/received_events","type":"User","site_admin":false},"body":"I am a bit surprised about this check here deeply nested on `object`. I don't understand why only normal properties of class properties should not be emitted?","created_at":"2018-09-28T21:46:19Z","updated_at":"2018-09-28T21:46:19Z","html_url":"https://github.com/facebook/prepack/pull/2578#discussion_r221389060","pull_request_url":"https://api.github.com/repos/facebook/prepack/pulls/2578","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/prepack/pulls/comments/221389060"},"html":{"href":"https://github.com/facebook/prepack/pull/2578#discussion_r221389060"},"pull_request":{"href":"https://api.github.com/repos/facebook/prepack/pulls/2578"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/prepack/pulls/2578","id":218949816,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4OTQ5ODE2","html_url":"https://github.com/facebook/prepack/pull/2578","diff_url":"https://github.com/facebook/prepack/pull/2578.diff","patch_url":"https://github.com/facebook/prepack/pull/2578.patch","issue_url":"https://api.github.com/repos/facebook/prepack/issues/2578","number":2578,"state":"open","locked":false,"title":"Adds React js-framework-benchmark test and fixes ES2015 class serialization issue","user":{"login":"trueadm","id":1519870,"node_id":"MDQ6VXNlcjE1MTk4NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1519870?v=4","gravatar_id":"","url":"https://api.github.com/users/trueadm","html_url":"https://github.com/trueadm","followers_url":"https://api.github.com/users/trueadm/followers","following_url":"https://api.github.com/users/trueadm/following{/other_user}","gists_url":"https://api.github.com/users/trueadm/gists{/gist_id}","starred_url":"https://api.github.com/users/trueadm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trueadm/subscriptions","organizations_url":"https://api.github.com/users/trueadm/orgs","repos_url":"https://api.github.com/users/trueadm/repos","events_url":"https://api.github.com/users/trueadm/events{/privacy}","received_events_url":"https://api.github.com/users/trueadm/received_events","type":"User","site_admin":false},"body":"Release notes: none\r\n\r\nAdds a simple common React benchmarks case from the popular open-source benchmark suite: `js-framework-benchmark`. This doesn't test performance, more that we are able to optimize parts of the benchmark. Upon trying this, I stumbled across some ES2015 class serialization bugs that I also fixed.","created_at":"2018-09-28T12:20:07Z","updated_at":"2018-09-28T21:46:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd8b61858633aeec18cc4343c6e6af18d62d24fb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sb98052","id":205478,"node_id":"MDQ6VXNlcjIwNTQ3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/205478?v=4","gravatar_id":"","url":"https://api.github.com/users/sb98052","html_url":"https://github.com/sb98052","followers_url":"https://api.github.com/users/sb98052/followers","following_url":"https://api.github.com/users/sb98052/following{/other_user}","gists_url":"https://api.github.com/users/sb98052/gists{/gist_id}","starred_url":"https://api.github.com/users/sb98052/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sb98052/subscriptions","organizations_url":"https://api.github.com/users/sb98052/orgs","repos_url":"https://api.github.com/users/sb98052/repos","events_url":"https://api.github.com/users/sb98052/events{/privacy}","received_events_url":"https://api.github.com/users/sb98052/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":279345275,"node_id":"MDU6TGFiZWwyNzkzNDUyNzU=","url":"https://api.github.com/repos/facebook/prepack/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/prepack/pulls/2578/commits","review_comments_url":"https://api.github.com/repos/facebook/prepack/pulls/2578/comments","review_comment_url":"https://api.github.com/repos/facebook/prepack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/prepack/issues/2578/comments","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/194a0eb21f638b8ce1c8206863b9d3b1c490c8ed","head":{"label":"trueadm:add-js-framework-benchmark","ref":"add-js-framework-benchmark","sha":"194a0eb21f638b8ce1c8206863b9d3b1c490c8ed","user":{"login":"trueadm","id":1519870,"node_id":"MDQ6VXNlcjE1MTk4NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1519870?v=4","gravatar_id":"","url":"https://api.github.com/users/trueadm","html_url":"https://github.com/trueadm","followers_url":"https://api.github.com/users/trueadm/followers","following_url":"https://api.github.com/users/trueadm/following{/other_user}","gists_url":"https://api.github.com/users/trueadm/gists{/gist_id}","starred_url":"https://api.github.com/users/trueadm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trueadm/subscriptions","organizations_url":"https://api.github.com/users/trueadm/orgs","repos_url":"https://api.github.com/users/trueadm/repos","events_url":"https://api.github.com/users/trueadm/events{/privacy}","received_events_url":"https://api.github.com/users/trueadm/received_events","type":"User","site_admin":false},"repo":{"id":101437011,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MzcwMTE=","name":"prepack","full_name":"trueadm/prepack","private":false,"owner":{"login":"trueadm","id":1519870,"node_id":"MDQ6VXNlcjE1MTk4NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1519870?v=4","gravatar_id":"","url":"https://api.github.com/users/trueadm","html_url":"https://github.com/trueadm","followers_url":"https://api.github.com/users/trueadm/followers","following_url":"https://api.github.com/users/trueadm/following{/other_user}","gists_url":"https://api.github.com/users/trueadm/gists{/gist_id}","starred_url":"https://api.github.com/users/trueadm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trueadm/subscriptions","organizations_url":"https://api.github.com/users/trueadm/orgs","repos_url":"https://api.github.com/users/trueadm/repos","events_url":"https://api.github.com/users/trueadm/events{/privacy}","received_events_url":"https://api.github.com/users/trueadm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/trueadm/prepack","description":"Prepack is a partial evaluator for JavaScript. Prepack rewrites a JavaScript bundle, resulting in JavaScript code that executes more efficiently.","fork":true,"url":"https://api.github.com/repos/trueadm/prepack","forks_url":"https://api.github.com/repos/trueadm/prepack/forks","keys_url":"https://api.github.com/repos/trueadm/prepack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trueadm/prepack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trueadm/prepack/teams","hooks_url":"https://api.github.com/repos/trueadm/prepack/hooks","issue_events_url":"https://api.github.com/repos/trueadm/prepack/issues/events{/number}","events_url":"https://api.github.com/repos/trueadm/prepack/events","assignees_url":"https://api.github.com/repos/trueadm/prepack/assignees{/user}","branches_url":"https://api.github.com/repos/trueadm/prepack/branches{/branch}","tags_url":"https://api.github.com/repos/trueadm/prepack/tags","blobs_url":"https://api.github.com/repos/trueadm/prepack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trueadm/prepack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trueadm/prepack/git/refs{/sha}","trees_url":"https://api.github.com/repos/trueadm/prepack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trueadm/prepack/statuses/{sha}","languages_url":"https://api.github.com/repos/trueadm/prepack/languages","stargazers_url":"https://api.github.com/repos/trueadm/prepack/stargazers","contributors_url":"https://api.github.com/repos/trueadm/prepack/contributors","subscribers_url":"https://api.github.com/repos/trueadm/prepack/subscribers","subscription_url":"https://api.github.com/repos/trueadm/prepack/subscription","commits_url":"https://api.github.com/repos/trueadm/prepack/commits{/sha}","git_commits_url":"https://api.github.com/repos/trueadm/prepack/git/commits{/sha}","comments_url":"https://api.github.com/repos/trueadm/prepack/comments{/number}","issue_comment_url":"https://api.github.com/repos/trueadm/prepack/issues/comments{/number}","contents_url":"https://api.github.com/repos/trueadm/prepack/contents/{+path}","compare_url":"https://api.github.com/repos/trueadm/prepack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trueadm/prepack/merges","archive_url":"https://api.github.com/repos/trueadm/prepack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trueadm/prepack/downloads","issues_url":"https://api.github.com/repos/trueadm/prepack/issues{/number}","pulls_url":"https://api.github.com/repos/trueadm/prepack/pulls{/number}","milestones_url":"https://api.github.com/repos/trueadm/prepack/milestones{/number}","notifications_url":"https://api.github.com/repos/trueadm/prepack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trueadm/prepack/labels{/name}","releases_url":"https://api.github.com/repos/trueadm/prepack/releases{/id}","deployments_url":"https://api.github.com/repos/trueadm/prepack/deployments","created_at":"2017-08-25T19:46:20Z","updated_at":"2018-09-27T08:22:40Z","pushed_at":"2018-09-28T12:32:11Z","git_url":"git://github.com/trueadm/prepack.git","ssh_url":"git@github.com:trueadm/prepack.git","clone_url":"https://github.com/trueadm/prepack.git","svn_url":"https://github.com/trueadm/prepack","homepage":"https://prepack.io","size":14211,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"0ef3c435635ed745641991fb82e464894ee9112f","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":45147841,"node_id":"MDEwOlJlcG9zaXRvcnk0NTE0Nzg0MQ==","name":"prepack","full_name":"facebook/prepack","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/prepack","description":"A JavaScript bundle optimizer.","fork":false,"url":"https://api.github.com/repos/facebook/prepack","forks_url":"https://api.github.com/repos/facebook/prepack/forks","keys_url":"https://api.github.com/repos/facebook/prepack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/prepack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/prepack/teams","hooks_url":"https://api.github.com/repos/facebook/prepack/hooks","issue_events_url":"https://api.github.com/repos/facebook/prepack/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/prepack/events","assignees_url":"https://api.github.com/repos/facebook/prepack/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/prepack/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/prepack/tags","blobs_url":"https://api.github.com/repos/facebook/prepack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/prepack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/prepack/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/prepack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/prepack/languages","stargazers_url":"https://api.github.com/repos/facebook/prepack/stargazers","contributors_url":"https://api.github.com/repos/facebook/prepack/contributors","subscribers_url":"https://api.github.com/repos/facebook/prepack/subscribers","subscription_url":"https://api.github.com/repos/facebook/prepack/subscription","commits_url":"https://api.github.com/repos/facebook/prepack/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/prepack/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/prepack/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/prepack/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/prepack/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/prepack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/prepack/merges","archive_url":"https://api.github.com/repos/facebook/prepack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/prepack/downloads","issues_url":"https://api.github.com/repos/facebook/prepack/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/prepack/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/prepack/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/prepack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/prepack/labels{/name}","releases_url":"https://api.github.com/repos/facebook/prepack/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/prepack/deployments","created_at":"2015-10-28T23:25:08Z","updated_at":"2018-09-28T18:51:08Z","pushed_at":"2018-09-28T20:02:53Z","git_url":"git://github.com/facebook/prepack.git","ssh_url":"git@github.com:facebook/prepack.git","clone_url":"https://github.com/facebook/prepack.git","svn_url":"https://github.com/facebook/prepack","homepage":"prepack.io","size":17767,"stargazers_count":12877,"watchers_count":12877,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":421,"mirror_url":null,"archived":false,"open_issues_count":227,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":421,"open_issues":227,"watchers":12877,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/prepack/pulls/2578"},"html":{"href":"https://github.com/facebook/prepack/pull/2578"},"issue":{"href":"https://api.github.com/repos/facebook/prepack/issues/2578"},"comments":{"href":"https://api.github.com/repos/facebook/prepack/issues/2578/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/prepack/pulls/2578/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/prepack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/prepack/pulls/2578/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/prepack/statuses/194a0eb21f638b8ce1c8206863b9d3b1c490c8ed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"NTillmann"}}