{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/pulls/comments/207003712","pull_request_review_id":142528386,"id":207003712,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzAwMzcxMg==","diff_hunk":"@@ -174,12 +174,17 @@ HomeAssistantClimate.prototype = {\n         break;\n     }\n \n-    serviceData.operation_mode = mode;\n-    this.log(`Setting Current Heating Cooling state on the '${this.name}' to ${mode}`);\n+    // get list of supported operations and map our mode to supported one\n+    var operation_mode = this.data.attributes.operation_list.find(element => {","path":"accessories/climate.js","position":25,"original_position":25,"commit_id":"4a25c4e18df0071b76b238a3fe108b8b25edcd45","original_commit_id":"4a25c4e18df0071b76b238a3fe108b8b25edcd45","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Identifier 'operation_mode' is not in camel case                                                       camelcase<br>Expected parentheses around arrow function argument having a body with curly braces                    arrow-parens<br>Unexpected block statement surrounding arrow body; move the returned value immediately after the `=>`  arrow-body-style","created_at":"2018-08-01T19:27:47Z","updated_at":"2018-08-01T19:27:47Z","html_url":"https://github.com/home-assistant/homebridge-homeassistant/pull/324#discussion_r207003712","pull_request_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/pulls/324","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/pulls/comments/207003712"},"html":{"href":"https://github.com/home-assistant/homebridge-homeassistant/pull/324#discussion_r207003712"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/pulls/324"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/pulls/324","id":205528285,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTI4Mjg1","html_url":"https://github.com/home-assistant/homebridge-homeassistant/pull/324","diff_url":"https://github.com/home-assistant/homebridge-homeassistant/pull/324.diff","patch_url":"https://github.com/home-assistant/homebridge-homeassistant/pull/324.patch","issue_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/issues/324","number":324,"state":"open","locked":false,"title":"Climate operation modes fix","user":{"login":"sergeymaysak","id":11465932,"node_id":"MDQ6VXNlcjExNDY1OTMy","avatar_url":"https://avatars2.githubusercontent.com/u/11465932?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeymaysak","html_url":"https://github.com/sergeymaysak","followers_url":"https://api.github.com/users/sergeymaysak/followers","following_url":"https://api.github.com/users/sergeymaysak/following{/other_user}","gists_url":"https://api.github.com/users/sergeymaysak/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeymaysak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeymaysak/subscriptions","organizations_url":"https://api.github.com/users/sergeymaysak/orgs","repos_url":"https://api.github.com/users/sergeymaysak/repos","events_url":"https://api.github.com/users/sergeymaysak/events{/privacy}","received_events_url":"https://api.github.com/users/sergeymaysak/received_events","type":"User","site_admin":false},"body":"Guys, \r\nI've noticed that zwave climate I use exposed to homebridge is not able to change operation mode as well as not reflects changes of operation mode from home assistant UI.\r\n\r\nSo climate.js logic assumes that names of states are lowercased as 'off', 'heat', 'cool', 'auto', while home assistant (v. 72, 74 for example) uses 'Off' and 'Heat' etc.\r\n\r\nSo this pull requests adds corresponding changes to make sure climate shown at homekit is able to change actual operation mode and reflects device changes correctly as well.\r\n\r\nI'm not sure if 'Heat'/'Off' pattern is used always for any other types of thermostats, so I've tried to add changes not broking previous (lowercase always) way of mode naming.\r\n\r\nCheers )\r\n","created_at":"2018-08-01T19:27:36Z","updated_at":"2018-08-01T19:27:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"009337c3812df70af0c3fbec89c86aa64d1013ac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":528252438,"node_id":"MDU6TGFiZWw1MjgyNTI0Mzg=","url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/pulls/324/commits","review_comments_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/pulls/324/comments","review_comment_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/issues/324/comments","statuses_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/statuses/4a25c4e18df0071b76b238a3fe108b8b25edcd45","head":{"label":"sergeymaysak:climate_operation_modes_fix","ref":"climate_operation_modes_fix","sha":"4a25c4e18df0071b76b238a3fe108b8b25edcd45","user":{"login":"sergeymaysak","id":11465932,"node_id":"MDQ6VXNlcjExNDY1OTMy","avatar_url":"https://avatars2.githubusercontent.com/u/11465932?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeymaysak","html_url":"https://github.com/sergeymaysak","followers_url":"https://api.github.com/users/sergeymaysak/followers","following_url":"https://api.github.com/users/sergeymaysak/following{/other_user}","gists_url":"https://api.github.com/users/sergeymaysak/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeymaysak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeymaysak/subscriptions","organizations_url":"https://api.github.com/users/sergeymaysak/orgs","repos_url":"https://api.github.com/users/sergeymaysak/repos","events_url":"https://api.github.com/users/sergeymaysak/events{/privacy}","received_events_url":"https://api.github.com/users/sergeymaysak/received_events","type":"User","site_admin":false},"repo":{"id":143185795,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxODU3OTU=","name":"homebridge-homeassistant","full_name":"sergeymaysak/homebridge-homeassistant","owner":{"login":"sergeymaysak","id":11465932,"node_id":"MDQ6VXNlcjExNDY1OTMy","avatar_url":"https://avatars2.githubusercontent.com/u/11465932?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeymaysak","html_url":"https://github.com/sergeymaysak","followers_url":"https://api.github.com/users/sergeymaysak/followers","following_url":"https://api.github.com/users/sergeymaysak/following{/other_user}","gists_url":"https://api.github.com/users/sergeymaysak/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeymaysak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeymaysak/subscriptions","organizations_url":"https://api.github.com/users/sergeymaysak/orgs","repos_url":"https://api.github.com/users/sergeymaysak/repos","events_url":"https://api.github.com/users/sergeymaysak/events{/privacy}","received_events_url":"https://api.github.com/users/sergeymaysak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sergeymaysak/homebridge-homeassistant","description":" Homebridge plugin for Home Assistant","fork":true,"url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant","forks_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/forks","keys_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/teams","hooks_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/hooks","issue_events_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/issues/events{/number}","events_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/events","assignees_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/assignees{/user}","branches_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/branches{/branch}","tags_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/tags","blobs_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/statuses/{sha}","languages_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/languages","stargazers_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/stargazers","contributors_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/contributors","subscribers_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/subscribers","subscription_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/subscription","commits_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/contents/{+path}","compare_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/merges","archive_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/downloads","issues_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/issues{/number}","pulls_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/pulls{/number}","milestones_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/milestones{/number}","notifications_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/labels{/name}","releases_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/releases{/id}","deployments_url":"https://api.github.com/repos/sergeymaysak/homebridge-homeassistant/deployments","created_at":"2018-08-01T17:10:54Z","updated_at":"2018-08-01T17:10:56Z","pushed_at":"2018-08-01T18:26:51Z","git_url":"git://github.com/sergeymaysak/homebridge-homeassistant.git","ssh_url":"git@github.com:sergeymaysak/homebridge-homeassistant.git","clone_url":"https://github.com/sergeymaysak/homebridge-homeassistant.git","svn_url":"https://github.com/sergeymaysak/homebridge-homeassistant","homepage":"","size":265,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"home-assistant:master","ref":"master","sha":"8f7d14b47be89955ce08091e8ef9388261afe994","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":53466975,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ2Njk3NQ==","name":"homebridge-homeassistant","full_name":"home-assistant/homebridge-homeassistant","owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/homebridge-homeassistant","description":" Homebridge plugin for Home Assistant","fork":false,"url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant","forks_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/forks","keys_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/events","assignees_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/merges","archive_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/deployments","created_at":"2016-03-09T04:02:55Z","updated_at":"2018-07-31T16:03:22Z","pushed_at":"2018-08-01T19:27:36Z","git_url":"git://github.com/home-assistant/homebridge-homeassistant.git","ssh_url":"git@github.com:home-assistant/homebridge-homeassistant.git","clone_url":"https://github.com/home-assistant/homebridge-homeassistant.git","svn_url":"https://github.com/home-assistant/homebridge-homeassistant","homepage":"","size":266,"stargazers_count":676,"watchers_count":676,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":133,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":133,"open_issues":51,"watchers":676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/pulls/324"},"html":{"href":"https://github.com/home-assistant/homebridge-homeassistant/pull/324"},"issue":{"href":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/issues/324"},"comments":{"href":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/issues/324/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/pulls/324/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/pulls/324/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/homebridge-homeassistant/statuses/4a25c4e18df0071b76b238a3fe108b8b25edcd45"}},"author_association":"NONE"}}
{"actor":{"display_login":"houndci-bot"}}