{"action":"created","issue":{"url":"https://api.github.com/repos/tornadoweb/tornado/issues/2422","repository_url":"https://api.github.com/repos/tornadoweb/tornado","labels_url":"https://api.github.com/repos/tornadoweb/tornado/issues/2422/labels{/name}","comments_url":"https://api.github.com/repos/tornadoweb/tornado/issues/2422/comments","events_url":"https://api.github.com/repos/tornadoweb/tornado/issues/2422/events","html_url":"https://github.com/tornadoweb/tornado/pull/2422","id":332377633,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0ODc0NDA4","number":2422,"title":"Make SSLIOStream and HTTPServerRequest configurable","user":{"login":"chaen","id":3728211,"node_id":"MDQ6VXNlcjM3MjgyMTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3728211?v=4","gravatar_id":"","url":"https://api.github.com/users/chaen","html_url":"https://github.com/chaen","followers_url":"https://api.github.com/users/chaen/followers","following_url":"https://api.github.com/users/chaen/following{/other_user}","gists_url":"https://api.github.com/users/chaen/gists{/gist_id}","starred_url":"https://api.github.com/users/chaen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaen/subscriptions","organizations_url":"https://api.github.com/users/chaen/orgs","repos_url":"https://api.github.com/users/chaen/repos","events_url":"https://api.github.com/users/chaen/events{/privacy}","received_events_url":"https://api.github.com/users/chaen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-14T12:20:27Z","updated_at":"2018-06-15T07:45:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/tornadoweb/tornado/pulls/2422","html_url":"https://github.com/tornadoweb/tornado/pull/2422","diff_url":"https://github.com/tornadoweb/tornado/pull/2422.diff","patch_url":"https://github.com/tornadoweb/tornado/pull/2422.patch"},"body":"This PR just makes SSLIOStream and HTTPServerRequest inherit from Configurable to address https://github.com/tornadoweb/tornado/issues/2364\r\n\r\nAs far as I can tell, all the tests are still passing. \r\n\r\nOne drawback though is that there is some monkey patching needed, despite the Configurable, because TCPServer directly uses `netutil.ssl_wrap_socket`"},"comment":{"url":"https://api.github.com/repos/tornadoweb/tornado/issues/comments/397541536","html_url":"https://github.com/tornadoweb/tornado/pull/2422#issuecomment-397541536","issue_url":"https://api.github.com/repos/tornadoweb/tornado/issues/2422","id":397541536,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzU0MTUzNg==","user":{"login":"ploxiln","id":649835,"node_id":"MDQ6VXNlcjY0OTgzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/649835?v=4","gravatar_id":"","url":"https://api.github.com/users/ploxiln","html_url":"https://github.com/ploxiln","followers_url":"https://api.github.com/users/ploxiln/followers","following_url":"https://api.github.com/users/ploxiln/following{/other_user}","gists_url":"https://api.github.com/users/ploxiln/gists{/gist_id}","starred_url":"https://api.github.com/users/ploxiln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ploxiln/subscriptions","organizations_url":"https://api.github.com/users/ploxiln/orgs","repos_url":"https://api.github.com/users/ploxiln/repos","events_url":"https://api.github.com/users/ploxiln/events{/privacy}","received_events_url":"https://api.github.com/users/ploxiln/received_events","type":"User","site_admin":false},"created_at":"2018-06-15T07:45:54Z","updated_at":"2018-06-15T07:45:54Z","author_association":"CONTRIBUTOR","body":"code style checks:\r\n\r\n```\r\n./tornado/httputil.py:354:7: E111 indentation is not a multiple of four\r\n./tornado/httputil.py:365:18: E128 continuation line under-indented for visual indent\r\n./tornado/httputil.py:366:18: E128 continuation line under-indented for visual indent\r\n./tornado/iostream.py:1469:7: E111 indentation is not a multiple of four\r\n./tornado/iostream.py:1472:5: E303 too many blank lines (2)\r\n./tornado/iostream.py:1505:5: E303 too many blank lines (2)\r\n```"}}
{"actor":{"display_login":"ploxiln"}}