{"action":"created","comment":{"url":"https://api.github.com/repos/DSpace/DSpace/pulls/comments/241310086","pull_request_review_id":184547941,"id":241310086,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTMxMDA4Ng==","diff_hunk":"@@ -1356,9 +1354,8 @@ websvc.opensearch.samplequery = photosynthesis\n # tags used to describe search service\n websvc.opensearch.tags = IR DSpace\n # result formats offered - use 1 or more comma-separated from: html,atom,rss\n-# NB: html is required for autodiscovery in browsers to function,\n-# and must be the first in the list if present\n-websvc.opensearch.formats = html,atom,rss\n+# NB: html is not supported in DSpace7, use normal search m,odule instead","path":"dspace/config/dspace.cfg","position":null,"original_position":16,"commit_id":"67046598c1578c52600f7ef27c58d9dac3be9fae","original_commit_id":"e53af97a31a647e800afec8d1e714f4c439bff80","user":{"login":"olli-gold","id":1461291,"node_id":"MDQ6VXNlcjE0NjEyOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1461291?v=4","gravatar_id":"","url":"https://api.github.com/users/olli-gold","html_url":"https://github.com/olli-gold","followers_url":"https://api.github.com/users/olli-gold/followers","following_url":"https://api.github.com/users/olli-gold/following{/other_user}","gists_url":"https://api.github.com/users/olli-gold/gists{/gist_id}","starred_url":"https://api.github.com/users/olli-gold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olli-gold/subscriptions","organizations_url":"https://api.github.com/users/olli-gold/orgs","repos_url":"https://api.github.com/users/olli-gold/repos","events_url":"https://api.github.com/users/olli-gold/events{/privacy}","received_events_url":"https://api.github.com/users/olli-gold/received_events","type":"User","site_admin":false},"body":"Thanks for catching that, I've corrected it","created_at":"2018-12-13T08:37:47Z","updated_at":"2018-12-13T08:37:47Z","html_url":"https://github.com/DSpace/DSpace/pull/2128#discussion_r241310086","pull_request_url":"https://api.github.com/repos/DSpace/DSpace/pulls/2128","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DSpace/DSpace/pulls/comments/241310086"},"html":{"href":"https://github.com/DSpace/DSpace/pull/2128#discussion_r241310086"},"pull_request":{"href":"https://api.github.com/repos/DSpace/DSpace/pulls/2128"}},"in_reply_to_id":241306999},"pull_request":{"url":"https://api.github.com/repos/DSpace/DSpace/pulls/2128","id":202915667,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTE1NjY3","html_url":"https://github.com/DSpace/DSpace/pull/2128","diff_url":"https://github.com/DSpace/DSpace/pull/2128.diff","patch_url":"https://github.com/DSpace/DSpace/pull/2128.patch","issue_url":"https://api.github.com/repos/DSpace/DSpace/issues/2128","number":2128,"state":"open","locked":false,"title":"Dspace7 opensearch","user":{"login":"olli-gold","id":1461291,"node_id":"MDQ6VXNlcjE0NjEyOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1461291?v=4","gravatar_id":"","url":"https://api.github.com/users/olli-gold","html_url":"https://github.com/olli-gold","followers_url":"https://api.github.com/users/olli-gold/followers","following_url":"https://api.github.com/users/olli-gold/following{/other_user}","gists_url":"https://api.github.com/users/olli-gold/gists{/gist_id}","starred_url":"https://api.github.com/users/olli-gold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olli-gold/subscriptions","organizations_url":"https://api.github.com/users/olli-gold/orgs","repos_url":"https://api.github.com/users/olli-gold/repos","events_url":"https://api.github.com/users/olli-gold/events{/privacy}","received_events_url":"https://api.github.com/users/olli-gold/received_events","type":"User","site_admin":false},"body":"This is the first draft of the DSpace OpenSearch Controller. Basically it only adds one file. I'm sure it can be improved and there are still some TODOs, but it works for me.\r\n\r\nTodos:\r\n[x] Add Urls to OpenSearch description file\r\n[x] Support enable/disable of the Controller from config file (there is already a config option in dspace.cfg, but it is ignored by the controller currently)\r\n[x] Improve error handling for bad requests (invalid or unsupported format)\r\n[x] Introduce message for the user when OpenSearch is disabled instead of showing a blank page\r\n[x] correct comments in dspace.cfg/local.cfg configuration file\r\n[x] Write tests\r\n[ ] Handle HTML responses in OpenSearchController or correct link options in dspace.cfg and/or https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/app/util/OpenSearchServiceImpl.java to redirect requests to basic search module of the UI\r\n\r\n[-] Display the OpenSearch description file instead of downloading it\r\n[-] Improve zero-result page\r\n[-] Handle Collection or Community hits (currently these hits are found, but not displayed)\r\n[-] Introduce a model for OpenSearch and divide code into model and controller\r\n\r\nThe tasks marked with [x] are done. For the tasks marked with [o] I guess I will need some help or more input. The tasks marked with [-] I have dropped from the Todo list after I thought about them again. In my opinion they are not required as the existing OpenSearch module for DSpace 6 does not do them as well, so these might be improvements that can still be added later.","created_at":"2018-07-20T17:50:59Z","updated_at":"2018-12-13T08:37:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"949386b803d82ca9a4b6568ae4d775a75c78f536","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":646370662,"node_id":"MDU6TGFiZWw2NDYzNzA2NjI=","url":"https://api.github.com/repos/DSpace/DSpace/labels/REST%20API%20v7","name":"REST API v7","color":"92C644","default":false},{"id":1080419158,"node_id":"MDU6TGFiZWwxMDgwNDE5MTU4","url":"https://api.github.com/repos/DSpace/DSpace/labels/community-sprint","name":"community-sprint","color":"95edbf","default":false}],"milestone":{"url":"https://api.github.com/repos/DSpace/DSpace/milestones/21","html_url":"https://github.com/DSpace/DSpace/milestone/21","labels_url":"https://api.github.com/repos/DSpace/DSpace/milestones/21/labels","id":2107125,"node_id":"MDk6TWlsZXN0b25lMjEwNzEyNQ==","number":21,"title":"7.0","description":null,"creator":{"login":"helix84","id":201026,"node_id":"MDQ6VXNlcjIwMTAyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/201026?v=4","gravatar_id":"","url":"https://api.github.com/users/helix84","html_url":"https://github.com/helix84","followers_url":"https://api.github.com/users/helix84/followers","following_url":"https://api.github.com/users/helix84/following{/other_user}","gists_url":"https://api.github.com/users/helix84/gists{/gist_id}","starred_url":"https://api.github.com/users/helix84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helix84/subscriptions","organizations_url":"https://api.github.com/users/helix84/orgs","repos_url":"https://api.github.com/users/helix84/repos","events_url":"https://api.github.com/users/helix84/events{/privacy}","received_events_url":"https://api.github.com/users/helix84/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":157,"state":"open","created_at":"2016-11-01T15:14:10Z","updated_at":"2018-12-12T22:55:40Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DSpace/DSpace/pulls/2128/commits","review_comments_url":"https://api.github.com/repos/DSpace/DSpace/pulls/2128/comments","review_comment_url":"https://api.github.com/repos/DSpace/DSpace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DSpace/DSpace/issues/2128/comments","statuses_url":"https://api.github.com/repos/DSpace/DSpace/statuses/67046598c1578c52600f7ef27c58d9dac3be9fae","head":{"label":"tubhh:dspace7_opensearch","ref":"dspace7_opensearch","sha":"67046598c1578c52600f7ef27c58d9dac3be9fae","user":{"login":"tubhh","id":20906310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTA2MzEw","avatar_url":"https://avatars2.githubusercontent.com/u/20906310?v=4","gravatar_id":"","url":"https://api.github.com/users/tubhh","html_url":"https://github.com/tubhh","followers_url":"https://api.github.com/users/tubhh/followers","following_url":"https://api.github.com/users/tubhh/following{/other_user}","gists_url":"https://api.github.com/users/tubhh/gists{/gist_id}","starred_url":"https://api.github.com/users/tubhh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tubhh/subscriptions","organizations_url":"https://api.github.com/users/tubhh/orgs","repos_url":"https://api.github.com/users/tubhh/repos","events_url":"https://api.github.com/users/tubhh/events{/privacy}","received_events_url":"https://api.github.com/users/tubhh/received_events","type":"Organization","site_admin":false},"repo":{"id":66443655,"node_id":"MDEwOlJlcG9zaXRvcnk2NjQ0MzY1NQ==","name":"DSpace","full_name":"tubhh/DSpace","private":false,"owner":{"login":"tubhh","id":20906310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTA2MzEw","avatar_url":"https://avatars2.githubusercontent.com/u/20906310?v=4","gravatar_id":"","url":"https://api.github.com/users/tubhh","html_url":"https://github.com/tubhh","followers_url":"https://api.github.com/users/tubhh/followers","following_url":"https://api.github.com/users/tubhh/following{/other_user}","gists_url":"https://api.github.com/users/tubhh/gists{/gist_id}","starred_url":"https://api.github.com/users/tubhh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tubhh/subscriptions","organizations_url":"https://api.github.com/users/tubhh/orgs","repos_url":"https://api.github.com/users/tubhh/repos","events_url":"https://api.github.com/users/tubhh/events{/privacy}","received_events_url":"https://api.github.com/users/tubhh/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tubhh/DSpace","description":"(Official) The DSpace digital asset management system that powers your Institutional Repository","fork":true,"url":"https://api.github.com/repos/tubhh/DSpace","forks_url":"https://api.github.com/repos/tubhh/DSpace/forks","keys_url":"https://api.github.com/repos/tubhh/DSpace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tubhh/DSpace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tubhh/DSpace/teams","hooks_url":"https://api.github.com/repos/tubhh/DSpace/hooks","issue_events_url":"https://api.github.com/repos/tubhh/DSpace/issues/events{/number}","events_url":"https://api.github.com/repos/tubhh/DSpace/events","assignees_url":"https://api.github.com/repos/tubhh/DSpace/assignees{/user}","branches_url":"https://api.github.com/repos/tubhh/DSpace/branches{/branch}","tags_url":"https://api.github.com/repos/tubhh/DSpace/tags","blobs_url":"https://api.github.com/repos/tubhh/DSpace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tubhh/DSpace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tubhh/DSpace/git/refs{/sha}","trees_url":"https://api.github.com/repos/tubhh/DSpace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tubhh/DSpace/statuses/{sha}","languages_url":"https://api.github.com/repos/tubhh/DSpace/languages","stargazers_url":"https://api.github.com/repos/tubhh/DSpace/stargazers","contributors_url":"https://api.github.com/repos/tubhh/DSpace/contributors","subscribers_url":"https://api.github.com/repos/tubhh/DSpace/subscribers","subscription_url":"https://api.github.com/repos/tubhh/DSpace/subscription","commits_url":"https://api.github.com/repos/tubhh/DSpace/commits{/sha}","git_commits_url":"https://api.github.com/repos/tubhh/DSpace/git/commits{/sha}","comments_url":"https://api.github.com/repos/tubhh/DSpace/comments{/number}","issue_comment_url":"https://api.github.com/repos/tubhh/DSpace/issues/comments{/number}","contents_url":"https://api.github.com/repos/tubhh/DSpace/contents/{+path}","compare_url":"https://api.github.com/repos/tubhh/DSpace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tubhh/DSpace/merges","archive_url":"https://api.github.com/repos/tubhh/DSpace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tubhh/DSpace/downloads","issues_url":"https://api.github.com/repos/tubhh/DSpace/issues{/number}","pulls_url":"https://api.github.com/repos/tubhh/DSpace/pulls{/number}","milestones_url":"https://api.github.com/repos/tubhh/DSpace/milestones{/number}","notifications_url":"https://api.github.com/repos/tubhh/DSpace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tubhh/DSpace/labels{/name}","releases_url":"https://api.github.com/repos/tubhh/DSpace/releases{/id}","deployments_url":"https://api.github.com/repos/tubhh/DSpace/deployments","created_at":"2016-08-24T07:58:15Z","updated_at":"2016-08-24T07:58:26Z","pushed_at":"2018-12-13T08:35:02Z","git_url":"git://github.com/tubhh/DSpace.git","ssh_url":"git@github.com:tubhh/DSpace.git","clone_url":"https://github.com/tubhh/DSpace.git","svn_url":"https://github.com/tubhh/DSpace","homepage":"https://wiki.duraspace.org/display/DSDOC5x/Introduction","size":142645,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"tubdok-5_x_x-cris"}},"base":{"label":"DSpace:master","ref":"master","sha":"7ccd99c97cff87d95a98993659cfd0937e2b9afe","user":{"login":"DSpace","id":428620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyODYyMA==","avatar_url":"https://avatars3.githubusercontent.com/u/428620?v=4","gravatar_id":"","url":"https://api.github.com/users/DSpace","html_url":"https://github.com/DSpace","followers_url":"https://api.github.com/users/DSpace/followers","following_url":"https://api.github.com/users/DSpace/following{/other_user}","gists_url":"https://api.github.com/users/DSpace/gists{/gist_id}","starred_url":"https://api.github.com/users/DSpace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSpace/subscriptions","organizations_url":"https://api.github.com/users/DSpace/orgs","repos_url":"https://api.github.com/users/DSpace/repos","events_url":"https://api.github.com/users/DSpace/events{/privacy}","received_events_url":"https://api.github.com/users/DSpace/received_events","type":"Organization","site_admin":false},"repo":{"id":3743376,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQzMzc2","name":"DSpace","full_name":"DSpace/DSpace","private":false,"owner":{"login":"DSpace","id":428620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyODYyMA==","avatar_url":"https://avatars3.githubusercontent.com/u/428620?v=4","gravatar_id":"","url":"https://api.github.com/users/DSpace","html_url":"https://github.com/DSpace","followers_url":"https://api.github.com/users/DSpace/followers","following_url":"https://api.github.com/users/DSpace/following{/other_user}","gists_url":"https://api.github.com/users/DSpace/gists{/gist_id}","starred_url":"https://api.github.com/users/DSpace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSpace/subscriptions","organizations_url":"https://api.github.com/users/DSpace/orgs","repos_url":"https://api.github.com/users/DSpace/repos","events_url":"https://api.github.com/users/DSpace/events{/privacy}","received_events_url":"https://api.github.com/users/DSpace/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DSpace/DSpace","description":"(Official) The DSpace digital asset management system that powers your Institutional Repository","fork":false,"url":"https://api.github.com/repos/DSpace/DSpace","forks_url":"https://api.github.com/repos/DSpace/DSpace/forks","keys_url":"https://api.github.com/repos/DSpace/DSpace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DSpace/DSpace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DSpace/DSpace/teams","hooks_url":"https://api.github.com/repos/DSpace/DSpace/hooks","issue_events_url":"https://api.github.com/repos/DSpace/DSpace/issues/events{/number}","events_url":"https://api.github.com/repos/DSpace/DSpace/events","assignees_url":"https://api.github.com/repos/DSpace/DSpace/assignees{/user}","branches_url":"https://api.github.com/repos/DSpace/DSpace/branches{/branch}","tags_url":"https://api.github.com/repos/DSpace/DSpace/tags","blobs_url":"https://api.github.com/repos/DSpace/DSpace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DSpace/DSpace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DSpace/DSpace/git/refs{/sha}","trees_url":"https://api.github.com/repos/DSpace/DSpace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DSpace/DSpace/statuses/{sha}","languages_url":"https://api.github.com/repos/DSpace/DSpace/languages","stargazers_url":"https://api.github.com/repos/DSpace/DSpace/stargazers","contributors_url":"https://api.github.com/repos/DSpace/DSpace/contributors","subscribers_url":"https://api.github.com/repos/DSpace/DSpace/subscribers","subscription_url":"https://api.github.com/repos/DSpace/DSpace/subscription","commits_url":"https://api.github.com/repos/DSpace/DSpace/commits{/sha}","git_commits_url":"https://api.github.com/repos/DSpace/DSpace/git/commits{/sha}","comments_url":"https://api.github.com/repos/DSpace/DSpace/comments{/number}","issue_comment_url":"https://api.github.com/repos/DSpace/DSpace/issues/comments{/number}","contents_url":"https://api.github.com/repos/DSpace/DSpace/contents/{+path}","compare_url":"https://api.github.com/repos/DSpace/DSpace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DSpace/DSpace/merges","archive_url":"https://api.github.com/repos/DSpace/DSpace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DSpace/DSpace/downloads","issues_url":"https://api.github.com/repos/DSpace/DSpace/issues{/number}","pulls_url":"https://api.github.com/repos/DSpace/DSpace/pulls{/number}","milestones_url":"https://api.github.com/repos/DSpace/DSpace/milestones{/number}","notifications_url":"https://api.github.com/repos/DSpace/DSpace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DSpace/DSpace/labels{/name}","releases_url":"https://api.github.com/repos/DSpace/DSpace/releases{/id}","deployments_url":"https://api.github.com/repos/DSpace/DSpace/deployments","created_at":"2012-03-16T21:44:52Z","updated_at":"2018-12-12T21:52:58Z","pushed_at":"2018-12-13T08:35:04Z","git_url":"git://github.com/DSpace/DSpace.git","ssh_url":"git@github.com:DSpace/DSpace.git","clone_url":"https://github.com/DSpace/DSpace.git","svn_url":"https://github.com/DSpace/DSpace","homepage":"https://wiki.duraspace.org/display/DSDOC6x/Introduction","size":134503,"stargazers_count":408,"watchers_count":408,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":833,"mirror_url":null,"archived":false,"open_issues_count":188,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":833,"open_issues":188,"watchers":408,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DSpace/DSpace/pulls/2128"},"html":{"href":"https://github.com/DSpace/DSpace/pull/2128"},"issue":{"href":"https://api.github.com/repos/DSpace/DSpace/issues/2128"},"comments":{"href":"https://api.github.com/repos/DSpace/DSpace/issues/2128/comments"},"review_comments":{"href":"https://api.github.com/repos/DSpace/DSpace/pulls/2128/comments"},"review_comment":{"href":"https://api.github.com/repos/DSpace/DSpace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DSpace/DSpace/pulls/2128/commits"},"statuses":{"href":"https://api.github.com/repos/DSpace/DSpace/statuses/67046598c1578c52600f7ef27c58d9dac3be9fae"}},"author_association":"NONE"}}
{"actor":{"display_login":"olli-gold"}}