{"action":"created","issue":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/3332","repository_url":"https://api.github.com/repos/Cockatrice/Cockatrice","labels_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/3332/labels{/name}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/3332/comments","events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/3332/events","html_url":"https://github.com/Cockatrice/Cockatrice/pull/3332","id":341524764,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNjQyMDA4","number":3332,"title":"[DO NOT MERGE] CMake: minimum requirements","user":{"login":"tooomm","id":9874850,"node_id":"MDQ6VXNlcjk4NzQ4NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/9874850?v=4","gravatar_id":"","url":"https://api.github.com/users/tooomm","html_url":"https://github.com/tooomm","followers_url":"https://api.github.com/users/tooomm/followers","following_url":"https://api.github.com/users/tooomm/following{/other_user}","gists_url":"https://api.github.com/users/tooomm/gists{/gist_id}","starred_url":"https://api.github.com/users/tooomm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tooomm/subscriptions","organizations_url":"https://api.github.com/users/tooomm/orgs","repos_url":"https://api.github.com/users/tooomm/repos","events_url":"https://api.github.com/users/tooomm/events{/privacy}","received_events_url":"https://api.github.com/users/tooomm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-16T13:44:00Z","updated_at":"2018-07-17T05:53:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/3332","html_url":"https://github.com/Cockatrice/Cockatrice/pull/3332","diff_url":"https://github.com/Cockatrice/Cockatrice/pull/3332.diff","patch_url":"https://github.com/Cockatrice/Cockatrice/pull/3332.patch"},"body":"## Related Ticket(s)\r\n- Fixes #3259\r\n- Related https://github.com/Cockatrice/Cockatrice/pull/3328\r\n\r\n## Short roundup of the initial problem\r\nAs mentioned in https://github.com/Cockatrice/Cockatrice/pull/3258#issue-189923329:\r\n>Switched to the new methods. I'm unsure whether this will work on on ancient Qt version.\r\n**EDIT:** it works with CMake >= 2.8.11 and Qt >= 5.1, so we should be fine.\r\nIn CMakeLists.txt we require Qt 5.0.3, so we should probably raise that number, but i have no way to test all the old Qt versions on linux right now.\r\n\r\n## What will change with this Pull Request?\r\n- Qt min req: 5.5.0\r\n(Xenial has our lowest Qt version currently @ 5.5.1 / mac @ 5.11.1 / win @ 5.9.5 [5.11.1 possible])\r\n\r\n- list (and maintain!) Qt and CMake (others too?) min. req. in README\r\n**That's up for discussion**\r\n\r\n---\r\n\r\nThis needs tests on older Qt versions!"},"comment":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/comments/405467809","html_url":"https://github.com/Cockatrice/Cockatrice/pull/3332#issuecomment-405467809","issue_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/3332","id":405467809,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTQ2NzgwOQ==","user":{"login":"tooomm","id":9874850,"node_id":"MDQ6VXNlcjk4NzQ4NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/9874850?v=4","gravatar_id":"","url":"https://api.github.com/users/tooomm","html_url":"https://github.com/tooomm","followers_url":"https://api.github.com/users/tooomm/followers","following_url":"https://api.github.com/users/tooomm/following{/other_user}","gists_url":"https://api.github.com/users/tooomm/gists{/gist_id}","starred_url":"https://api.github.com/users/tooomm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tooomm/subscriptions","organizations_url":"https://api.github.com/users/tooomm/orgs","repos_url":"https://api.github.com/users/tooomm/repos","events_url":"https://api.github.com/users/tooomm/events{/privacy}","received_events_url":"https://api.github.com/users/tooomm/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T05:53:55Z","updated_at":"2018-07-17T05:53:55Z","author_association":"CONTRIBUTOR","body":">Not sure what you're asking\r\n\r\nDo we want to put these min requirement hints in the README at all?\r\n\r\n- We didn't have such an info before\r\n- We need to maintain them which people will forget, and we end up with old/wrong info there again\r\n- CMake tells the user at compilation time already what they need if they don't match it"}}
{"actor":{"display_login":"tooomm"}}