{"action":"created","comment":{"url":"https://api.github.com/repos/expo/expo/pulls/comments/237722434","pull_request_review_id":180090048,"id":237722434,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzcyMjQzNA==","diff_hunk":"@@ -25,20 +44,36 @@ public String developmentUrl() {\n     return DetachBuildConstants.DEVELOPMENT_URL;\n   }\n \n-  @Override\n-  public List<String> sdkVersions() {\n-    return new ArrayList<>(Arrays.asList(\"31.0.0\"));\n-  }\n-\n   @Override\n   public List<ReactPackage> reactPackages() {\n     return ((MainApplication) getApplication()).getPackages();\n   }\n \n   @Override\n   public List<Package> expoPackages() {\n-    // Here you can add your own packages.\n-    return super.expoPackages();\n+    return Arrays.<Package>asList(\n+        new CameraPackage(),\n+        new ConstantsPackage(),\n+        new SensorsPackage(),\n+        new FileSystemPackage(),\n+        new FaceDetectorPackage(),\n+        new GLPackage(),\n+        new GoogleSignInPackage(),\n+        new PermissionsPackage(),\n+        new SMSPackage(),\n+        new PrintPackage(),\n+        new ConstantsPackage(),\n+        new MediaLibraryPackage(),\n+        new SegmentPackage(),\n+        new FontLoaderPackage(),\n+        new LocationPackage(),\n+        new ContactsPackage(),\n+        new BarCodeScannerPackage(),\n+        new AdMobPackage(),\n+        new StripePackage(),\n+        new LocalAuthenticationPackage(),\n+        new LocalizationPackage()","path":"android/app/src/main/java/host/exp/exponent/MainActivity.java","position":73,"original_position":73,"commit_id":"0b652d98c802d1bd72e7b905c0abd2df65901326","original_commit_id":"0b652d98c802d1bd72e7b905c0abd2df65901326","user":{"login":"esamelson","id":19958240,"node_id":"MDQ6VXNlcjE5OTU4MjQw","avatar_url":"https://avatars1.githubusercontent.com/u/19958240?v=4","gravatar_id":"","url":"https://api.github.com/users/esamelson","html_url":"https://github.com/esamelson","followers_url":"https://api.github.com/users/esamelson/followers","following_url":"https://api.github.com/users/esamelson/following{/other_user}","gists_url":"https://api.github.com/users/esamelson/gists{/gist_id}","starred_url":"https://api.github.com/users/esamelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esamelson/subscriptions","organizations_url":"https://api.github.com/users/esamelson/orgs","repos_url":"https://api.github.com/users/esamelson/repos","events_url":"https://api.github.com/users/esamelson/events{/privacy}","received_events_url":"https://api.github.com/users/esamelson/received_events","type":"User","site_admin":false},"body":"it would be nice not to have to maintain two separate lists here and in ExperiencePackagePicker, but I see why you did this. Let's just make sure to document this well for when people add new unimodules","created_at":"2018-11-30T01:47:17Z","updated_at":"2018-11-30T01:56:51Z","html_url":"https://github.com/expo/expo/pull/2836#discussion_r237722434","pull_request_url":"https://api.github.com/repos/expo/expo/pulls/2836","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/expo/expo/pulls/comments/237722434"},"html":{"href":"https://github.com/expo/expo/pull/2836#discussion_r237722434"},"pull_request":{"href":"https://api.github.com/repos/expo/expo/pulls/2836"}}},"pull_request":{"url":"https://api.github.com/repos/expo/expo/pulls/2836","id":234277220,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Mjc3MjIw","html_url":"https://github.com/expo/expo/pull/2836","diff_url":"https://github.com/expo/expo/pull/2836.diff","patch_url":"https://github.com/expo/expo/pull/2836.patch","issue_url":"https://api.github.com/repos/expo/expo/issues/2836","number":2836,"state":"open","locked":false,"title":"[android] Unify shell app and ejected apps, pave the way for optional modules","user":{"login":"sjchmiela","id":1151041,"node_id":"MDQ6VXNlcjExNTEwNDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1151041?v=4","gravatar_id":"","url":"https://api.github.com/users/sjchmiela","html_url":"https://github.com/sjchmiela","followers_url":"https://api.github.com/users/sjchmiela/followers","following_url":"https://api.github.com/users/sjchmiela/following{/other_user}","gists_url":"https://api.github.com/users/sjchmiela/gists{/gist_id}","starred_url":"https://api.github.com/users/sjchmiela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjchmiela/subscriptions","organizations_url":"https://api.github.com/users/sjchmiela/orgs","repos_url":"https://api.github.com/users/sjchmiela/repos","events_url":"https://api.github.com/users/sjchmiela/events{/privacy}","received_events_url":"https://api.github.com/users/sjchmiela/received_events","type":"User","site_admin":false},"body":"# Why\r\n\r\nFixes https://github.com/expo/expo/issues/2621.\r\n\r\n# How\r\n\r\n- removed `ShellAppActivity` in favor of `MainActivity`\r\n- moved real requirement for universal modules to `app`, not `expoview`\r\n- fixed Turtle behavior\r\n- [x] review `IS_DETACHED` use\r\n- renamed `isShellApp()` to `isStandaloneApp()` (which in this case will mean that it's either ejected or built by Turtle, not scoped like Expo Client).\r\n\r\n# Test Plan\r\n\r\nAn APK built with changes from https://github.com/expo/expo-cli/pull/220 in `expo-cli` and these changes runs properly. Tested by regenerating `expokit-npm-package` for SDK31, creating a shell app, using in Turtle as SDK31 app with new XDL and deploying to staging.","created_at":"2018-11-28T13:31:30Z","updated_at":"2018-11-30T01:56:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8276458bdb337b7c622e8f13f73ce9b69bd3291c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":663925725,"node_id":"MDU6TGFiZWw2NjM5MjU3MjU=","url":"https://api.github.com/repos/expo/expo/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/expo/expo/pulls/2836/commits","review_comments_url":"https://api.github.com/repos/expo/expo/pulls/2836/comments","review_comment_url":"https://api.github.com/repos/expo/expo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/expo/expo/issues/2836/comments","statuses_url":"https://api.github.com/repos/expo/expo/statuses/0b652d98c802d1bd72e7b905c0abd2df65901326","head":{"label":"expo:@sjchmiela/optional_modules_android","ref":"@sjchmiela/optional_modules_android","sha":"0b652d98c802d1bd72e7b905c0abd2df65901326","user":{"login":"expo","id":12504344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA0MzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/12504344?v=4","gravatar_id":"","url":"https://api.github.com/users/expo","html_url":"https://github.com/expo","followers_url":"https://api.github.com/users/expo/followers","following_url":"https://api.github.com/users/expo/following{/other_user}","gists_url":"https://api.github.com/users/expo/gists{/gist_id}","starred_url":"https://api.github.com/users/expo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expo/subscriptions","organizations_url":"https://api.github.com/users/expo/orgs","repos_url":"https://api.github.com/users/expo/repos","events_url":"https://api.github.com/users/expo/events{/privacy}","received_events_url":"https://api.github.com/users/expo/received_events","type":"Organization","site_admin":false},"repo":{"id":65750241,"node_id":"MDEwOlJlcG9zaXRvcnk2NTc1MDI0MQ==","name":"expo","full_name":"expo/expo","private":false,"owner":{"login":"expo","id":12504344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA0MzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/12504344?v=4","gravatar_id":"","url":"https://api.github.com/users/expo","html_url":"https://github.com/expo","followers_url":"https://api.github.com/users/expo/followers","following_url":"https://api.github.com/users/expo/following{/other_user}","gists_url":"https://api.github.com/users/expo/gists{/gist_id}","starred_url":"https://api.github.com/users/expo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expo/subscriptions","organizations_url":"https://api.github.com/users/expo/orgs","repos_url":"https://api.github.com/users/expo/repos","events_url":"https://api.github.com/users/expo/events{/privacy}","received_events_url":"https://api.github.com/users/expo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/expo/expo","description":"The Expo platform for making cross-platform mobile apps","fork":false,"url":"https://api.github.com/repos/expo/expo","forks_url":"https://api.github.com/repos/expo/expo/forks","keys_url":"https://api.github.com/repos/expo/expo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/expo/expo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/expo/expo/teams","hooks_url":"https://api.github.com/repos/expo/expo/hooks","issue_events_url":"https://api.github.com/repos/expo/expo/issues/events{/number}","events_url":"https://api.github.com/repos/expo/expo/events","assignees_url":"https://api.github.com/repos/expo/expo/assignees{/user}","branches_url":"https://api.github.com/repos/expo/expo/branches{/branch}","tags_url":"https://api.github.com/repos/expo/expo/tags","blobs_url":"https://api.github.com/repos/expo/expo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/expo/expo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/expo/expo/git/refs{/sha}","trees_url":"https://api.github.com/repos/expo/expo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/expo/expo/statuses/{sha}","languages_url":"https://api.github.com/repos/expo/expo/languages","stargazers_url":"https://api.github.com/repos/expo/expo/stargazers","contributors_url":"https://api.github.com/repos/expo/expo/contributors","subscribers_url":"https://api.github.com/repos/expo/expo/subscribers","subscription_url":"https://api.github.com/repos/expo/expo/subscription","commits_url":"https://api.github.com/repos/expo/expo/commits{/sha}","git_commits_url":"https://api.github.com/repos/expo/expo/git/commits{/sha}","comments_url":"https://api.github.com/repos/expo/expo/comments{/number}","issue_comment_url":"https://api.github.com/repos/expo/expo/issues/comments{/number}","contents_url":"https://api.github.com/repos/expo/expo/contents/{+path}","compare_url":"https://api.github.com/repos/expo/expo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/expo/expo/merges","archive_url":"https://api.github.com/repos/expo/expo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/expo/expo/downloads","issues_url":"https://api.github.com/repos/expo/expo/issues{/number}","pulls_url":"https://api.github.com/repos/expo/expo/pulls{/number}","milestones_url":"https://api.github.com/repos/expo/expo/milestones{/number}","notifications_url":"https://api.github.com/repos/expo/expo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/expo/expo/labels{/name}","releases_url":"https://api.github.com/repos/expo/expo/releases{/id}","deployments_url":"https://api.github.com/repos/expo/expo/deployments","created_at":"2016-08-15T17:14:25Z","updated_at":"2018-11-30T01:49:01Z","pushed_at":"2018-11-30T01:48:53Z","git_url":"git://github.com/expo/expo.git","ssh_url":"git@github.com:expo/expo.git","clone_url":"https://github.com/expo/expo.git","svn_url":"https://github.com/expo/expo","homepage":"https://docs.expo.io/","size":818532,"stargazers_count":4624,"watchers_count":4624,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":394,"mirror_url":null,"archived":false,"open_issues_count":451,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":394,"open_issues":451,"watchers":4624,"default_branch":"master"}},"base":{"label":"expo:master","ref":"master","sha":"be296e614a373ebb09455df72a632c4ab3644c5a","user":{"login":"expo","id":12504344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA0MzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/12504344?v=4","gravatar_id":"","url":"https://api.github.com/users/expo","html_url":"https://github.com/expo","followers_url":"https://api.github.com/users/expo/followers","following_url":"https://api.github.com/users/expo/following{/other_user}","gists_url":"https://api.github.com/users/expo/gists{/gist_id}","starred_url":"https://api.github.com/users/expo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expo/subscriptions","organizations_url":"https://api.github.com/users/expo/orgs","repos_url":"https://api.github.com/users/expo/repos","events_url":"https://api.github.com/users/expo/events{/privacy}","received_events_url":"https://api.github.com/users/expo/received_events","type":"Organization","site_admin":false},"repo":{"id":65750241,"node_id":"MDEwOlJlcG9zaXRvcnk2NTc1MDI0MQ==","name":"expo","full_name":"expo/expo","private":false,"owner":{"login":"expo","id":12504344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA0MzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/12504344?v=4","gravatar_id":"","url":"https://api.github.com/users/expo","html_url":"https://github.com/expo","followers_url":"https://api.github.com/users/expo/followers","following_url":"https://api.github.com/users/expo/following{/other_user}","gists_url":"https://api.github.com/users/expo/gists{/gist_id}","starred_url":"https://api.github.com/users/expo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expo/subscriptions","organizations_url":"https://api.github.com/users/expo/orgs","repos_url":"https://api.github.com/users/expo/repos","events_url":"https://api.github.com/users/expo/events{/privacy}","received_events_url":"https://api.github.com/users/expo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/expo/expo","description":"The Expo platform for making cross-platform mobile apps","fork":false,"url":"https://api.github.com/repos/expo/expo","forks_url":"https://api.github.com/repos/expo/expo/forks","keys_url":"https://api.github.com/repos/expo/expo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/expo/expo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/expo/expo/teams","hooks_url":"https://api.github.com/repos/expo/expo/hooks","issue_events_url":"https://api.github.com/repos/expo/expo/issues/events{/number}","events_url":"https://api.github.com/repos/expo/expo/events","assignees_url":"https://api.github.com/repos/expo/expo/assignees{/user}","branches_url":"https://api.github.com/repos/expo/expo/branches{/branch}","tags_url":"https://api.github.com/repos/expo/expo/tags","blobs_url":"https://api.github.com/repos/expo/expo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/expo/expo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/expo/expo/git/refs{/sha}","trees_url":"https://api.github.com/repos/expo/expo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/expo/expo/statuses/{sha}","languages_url":"https://api.github.com/repos/expo/expo/languages","stargazers_url":"https://api.github.com/repos/expo/expo/stargazers","contributors_url":"https://api.github.com/repos/expo/expo/contributors","subscribers_url":"https://api.github.com/repos/expo/expo/subscribers","subscription_url":"https://api.github.com/repos/expo/expo/subscription","commits_url":"https://api.github.com/repos/expo/expo/commits{/sha}","git_commits_url":"https://api.github.com/repos/expo/expo/git/commits{/sha}","comments_url":"https://api.github.com/repos/expo/expo/comments{/number}","issue_comment_url":"https://api.github.com/repos/expo/expo/issues/comments{/number}","contents_url":"https://api.github.com/repos/expo/expo/contents/{+path}","compare_url":"https://api.github.com/repos/expo/expo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/expo/expo/merges","archive_url":"https://api.github.com/repos/expo/expo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/expo/expo/downloads","issues_url":"https://api.github.com/repos/expo/expo/issues{/number}","pulls_url":"https://api.github.com/repos/expo/expo/pulls{/number}","milestones_url":"https://api.github.com/repos/expo/expo/milestones{/number}","notifications_url":"https://api.github.com/repos/expo/expo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/expo/expo/labels{/name}","releases_url":"https://api.github.com/repos/expo/expo/releases{/id}","deployments_url":"https://api.github.com/repos/expo/expo/deployments","created_at":"2016-08-15T17:14:25Z","updated_at":"2018-11-30T01:49:01Z","pushed_at":"2018-11-30T01:48:53Z","git_url":"git://github.com/expo/expo.git","ssh_url":"git@github.com:expo/expo.git","clone_url":"https://github.com/expo/expo.git","svn_url":"https://github.com/expo/expo","homepage":"https://docs.expo.io/","size":818532,"stargazers_count":4624,"watchers_count":4624,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":394,"mirror_url":null,"archived":false,"open_issues_count":451,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":394,"open_issues":451,"watchers":4624,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/expo/expo/pulls/2836"},"html":{"href":"https://github.com/expo/expo/pull/2836"},"issue":{"href":"https://api.github.com/repos/expo/expo/issues/2836"},"comments":{"href":"https://api.github.com/repos/expo/expo/issues/2836/comments"},"review_comments":{"href":"https://api.github.com/repos/expo/expo/pulls/2836/comments"},"review_comment":{"href":"https://api.github.com/repos/expo/expo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/expo/expo/pulls/2836/commits"},"statuses":{"href":"https://api.github.com/repos/expo/expo/statuses/0b652d98c802d1bd72e7b905c0abd2df65901326"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"esamelson"}}