{"action":"created","issue":{"url":"https://api.github.com/repos/ticketmaster/aurora/issues/262","repository_url":"https://api.github.com/repos/ticketmaster/aurora","labels_url":"https://api.github.com/repos/ticketmaster/aurora/issues/262/labels{/name}","comments_url":"https://api.github.com/repos/ticketmaster/aurora/issues/262/comments","events_url":"https://api.github.com/repos/ticketmaster/aurora/issues/262/events","html_url":"https://github.com/ticketmaster/aurora/pull/262","id":371156067,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjY1OTIx","number":262,"title":"fix(PopOver): add animation on open and close","user":{"login":"nyonchev","id":973830,"node_id":"MDQ6VXNlcjk3MzgzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/973830?v=4","gravatar_id":"","url":"https://api.github.com/users/nyonchev","html_url":"https://github.com/nyonchev","followers_url":"https://api.github.com/users/nyonchev/followers","following_url":"https://api.github.com/users/nyonchev/following{/other_user}","gists_url":"https://api.github.com/users/nyonchev/gists{/gist_id}","starred_url":"https://api.github.com/users/nyonchev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyonchev/subscriptions","organizations_url":"https://api.github.com/users/nyonchev/orgs","repos_url":"https://api.github.com/users/nyonchev/repos","events_url":"https://api.github.com/users/nyonchev/events{/privacy}","received_events_url":"https://api.github.com/users/nyonchev/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-17T16:10:14Z","updated_at":"2018-10-17T17:05:55Z","closed_at":"2018-10-17T17:01:02Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ticketmaster/aurora/pulls/262","html_url":"https://github.com/ticketmaster/aurora/pull/262","diff_url":"https://github.com/ticketmaster/aurora/pull/262.diff","patch_url":"https://github.com/ticketmaster/aurora/pull/262.patch"},"body":"**What**:\r\n\r\nAdd animation on popover open/close. Add 100% test coverage. Refactor not to use state for changing PopOver dimensions and position. The last part is for reducing calls in render method and improve performance.\r\n\r\n**Why**:\r\n\r\nAnimations are required\r\n\r\n**How**:\r\n\r\nUsing CSSTransition from react-transition-group library. Save dimensions in class property instead of the state. Every time popover appears calculate position and set the position.\r\n\r\n**Checklist**:\r\n\r\n* [n/a] Documentation\r\n* [x] Tests\r\n* [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->\r\n"},"comment":{"url":"https://api.github.com/repos/ticketmaster/aurora/issues/comments/430709820","html_url":"https://github.com/ticketmaster/aurora/pull/262#issuecomment-430709820","issue_url":"https://api.github.com/repos/ticketmaster/aurora/issues/262","id":430709820,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDcwOTgyMA==","user":{"login":"tm-github-bot","id":39978244,"node_id":"MDQ6VXNlcjM5OTc4MjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/39978244?v=4","gravatar_id":"","url":"https://api.github.com/users/tm-github-bot","html_url":"https://github.com/tm-github-bot","followers_url":"https://api.github.com/users/tm-github-bot/followers","following_url":"https://api.github.com/users/tm-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/tm-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/tm-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tm-github-bot/subscriptions","organizations_url":"https://api.github.com/users/tm-github-bot/orgs","repos_url":"https://api.github.com/users/tm-github-bot/repos","events_url":"https://api.github.com/users/tm-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/tm-github-bot/received_events","type":"User","site_admin":false},"created_at":"2018-10-17T17:05:55Z","updated_at":"2018-10-17T17:05:55Z","author_association":"COLLABORATOR","body":":tada: This PR is included in version 3.34.7 :tada:\n\nThe release is available on:\n- `npm package (@latest dist-tag)`\n- [GitHub release](https://github.com/ticketmaster/aurora/releases/tag/v3.34.7)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:"}}
{"actor":{"display_login":"tm-github-bot"}}