{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/190330898","pull_request_review_id":122685177,"id":190330898,"diff_hunk":"@@ -926,7 +926,18 @@ message HeaderMatcher {\n     // * For range [-10,0), route will match for header value -1, but not for 0, \"somestring\", 10.9,\n     //   \"-1somestring\"\n     envoy.type.Int64Range range_match = 6;\n+\n+    // If specified, header match will be be performed based on whether the header is in the request.\n+    bool present_match = 7;","path":"api/envoy/api/v2/route/route.proto","position":6,"original_position":6,"commit_id":"7536ed7cf0d15cf07e0f6daa5f3edb6f6a171e6d","original_commit_id":"7536ed7cf0d15cf07e0f6daa5f3edb6f6a171e6d","user":{"login":"zuercher","id":53179,"avatar_url":"https://avatars3.githubusercontent.com/u/53179?v=4","gravatar_id":"","url":"https://api.github.com/users/zuercher","html_url":"https://github.com/zuercher","followers_url":"https://api.github.com/users/zuercher/followers","following_url":"https://api.github.com/users/zuercher/following{/other_user}","gists_url":"https://api.github.com/users/zuercher/gists{/gist_id}","starred_url":"https://api.github.com/users/zuercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuercher/subscriptions","organizations_url":"https://api.github.com/users/zuercher/orgs","repos_url":"https://api.github.com/users/zuercher/repos","events_url":"https://api.github.com/users/zuercher/events{/privacy}","received_events_url":"https://api.github.com/users/zuercher/received_events","type":"User","site_admin":false},"body":"The docs read as if the default behavior when `header_match_specifier` is missing is to act as if `present_match` is true, but really the behavior is to act as if `exact_match` is the empty string, which still makes using `invert_match` confusing: an empty `exact_match` and `invert_match` enabled will never match any request (by my reading).\r\n\r\nI think we could fix this either by changing the default behavior -- no one can be using `invert_match` now and `present_match` should behave like empty `exact_match`. Then going forward `invert_match` works sensibly. (Changing the default after invert_match is in the wild could break someone.)","created_at":"2018-05-23T17:17:46Z","updated_at":"2018-05-23T17:22:52Z","html_url":"https://github.com/envoyproxy/envoy/pull/3443#discussion_r190330898","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3443","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/190330898"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3443#discussion_r190330898"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3443"}}},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3443","id":189190231,"html_url":"https://github.com/envoyproxy/envoy/pull/3443","diff_url":"https://github.com/envoyproxy/envoy/pull/3443.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/3443.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3443","number":3443,"state":"open","locked":false,"title":"router: add support for inverse header matching","user":{"login":"gumpt","id":640289,"avatar_url":"https://avatars1.githubusercontent.com/u/640289?v=4","gravatar_id":"","url":"https://api.github.com/users/gumpt","html_url":"https://github.com/gumpt","followers_url":"https://api.github.com/users/gumpt/followers","following_url":"https://api.github.com/users/gumpt/following{/other_user}","gists_url":"https://api.github.com/users/gumpt/gists{/gist_id}","starred_url":"https://api.github.com/users/gumpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gumpt/subscriptions","organizations_url":"https://api.github.com/users/gumpt/orgs","repos_url":"https://api.github.com/users/gumpt/repos","events_url":"https://api.github.com/users/gumpt/events{/privacy}","received_events_url":"https://api.github.com/users/gumpt/received_events","type":"User","site_admin":false},"body":"*Description*:\r\nThis adds an `invert_match` config option for header matching to match on headers which are not a specific value or which are not set in a given request.\r\n\r\n*Risk Level*: Medium\r\n\r\n*Testing*:\r\nNew unit tests, added to existing tests.\r\n\r\n*Docs Changes*:\r\nInline with the proto change.\r\n\r\n*Release Notes*:\r\nNoted the new option.\r\n\r\nFixes #2101 \r\n","created_at":"2018-05-19T14:22:24Z","updated_at":"2018-05-23T17:22:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c29e2427b3c199e65150cd93a7d2bd8e72836f93","assignee":{"login":"zuercher","id":53179,"avatar_url":"https://avatars3.githubusercontent.com/u/53179?v=4","gravatar_id":"","url":"https://api.github.com/users/zuercher","html_url":"https://github.com/zuercher","followers_url":"https://api.github.com/users/zuercher/followers","following_url":"https://api.github.com/users/zuercher/following{/other_user}","gists_url":"https://api.github.com/users/zuercher/gists{/gist_id}","starred_url":"https://api.github.com/users/zuercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuercher/subscriptions","organizations_url":"https://api.github.com/users/zuercher/orgs","repos_url":"https://api.github.com/users/zuercher/repos","events_url":"https://api.github.com/users/zuercher/events{/privacy}","received_events_url":"https://api.github.com/users/zuercher/received_events","type":"User","site_admin":false},"assignees":[{"login":"zuercher","id":53179,"avatar_url":"https://avatars3.githubusercontent.com/u/53179?v=4","gravatar_id":"","url":"https://api.github.com/users/zuercher","html_url":"https://github.com/zuercher","followers_url":"https://api.github.com/users/zuercher/followers","following_url":"https://api.github.com/users/zuercher/following{/other_user}","gists_url":"https://api.github.com/users/zuercher/gists{/gist_id}","starred_url":"https://api.github.com/users/zuercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuercher/subscriptions","organizations_url":"https://api.github.com/users/zuercher/orgs","repos_url":"https://api.github.com/users/zuercher/repos","events_url":"https://api.github.com/users/zuercher/events{/privacy}","received_events_url":"https://api.github.com/users/zuercher/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3443/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3443/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3443/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/7536ed7cf0d15cf07e0f6daa5f3edb6f6a171e6d","head":{"label":"gumpt:master","ref":"master","sha":"7536ed7cf0d15cf07e0f6daa5f3edb6f6a171e6d","user":{"login":"gumpt","id":640289,"avatar_url":"https://avatars1.githubusercontent.com/u/640289?v=4","gravatar_id":"","url":"https://api.github.com/users/gumpt","html_url":"https://github.com/gumpt","followers_url":"https://api.github.com/users/gumpt/followers","following_url":"https://api.github.com/users/gumpt/following{/other_user}","gists_url":"https://api.github.com/users/gumpt/gists{/gist_id}","starred_url":"https://api.github.com/users/gumpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gumpt/subscriptions","organizations_url":"https://api.github.com/users/gumpt/orgs","repos_url":"https://api.github.com/users/gumpt/repos","events_url":"https://api.github.com/users/gumpt/events{/privacy}","received_events_url":"https://api.github.com/users/gumpt/received_events","type":"User","site_admin":false},"repo":{"id":129328928,"name":"envoy","full_name":"gumpt/envoy","owner":{"login":"gumpt","id":640289,"avatar_url":"https://avatars1.githubusercontent.com/u/640289?v=4","gravatar_id":"","url":"https://api.github.com/users/gumpt","html_url":"https://github.com/gumpt","followers_url":"https://api.github.com/users/gumpt/followers","following_url":"https://api.github.com/users/gumpt/following{/other_user}","gists_url":"https://api.github.com/users/gumpt/gists{/gist_id}","starred_url":"https://api.github.com/users/gumpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gumpt/subscriptions","organizations_url":"https://api.github.com/users/gumpt/orgs","repos_url":"https://api.github.com/users/gumpt/repos","events_url":"https://api.github.com/users/gumpt/events{/privacy}","received_events_url":"https://api.github.com/users/gumpt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gumpt/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/gumpt/envoy","forks_url":"https://api.github.com/repos/gumpt/envoy/forks","keys_url":"https://api.github.com/repos/gumpt/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gumpt/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gumpt/envoy/teams","hooks_url":"https://api.github.com/repos/gumpt/envoy/hooks","issue_events_url":"https://api.github.com/repos/gumpt/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/gumpt/envoy/events","assignees_url":"https://api.github.com/repos/gumpt/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/gumpt/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/gumpt/envoy/tags","blobs_url":"https://api.github.com/repos/gumpt/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gumpt/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gumpt/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gumpt/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gumpt/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/gumpt/envoy/languages","stargazers_url":"https://api.github.com/repos/gumpt/envoy/stargazers","contributors_url":"https://api.github.com/repos/gumpt/envoy/contributors","subscribers_url":"https://api.github.com/repos/gumpt/envoy/subscribers","subscription_url":"https://api.github.com/repos/gumpt/envoy/subscription","commits_url":"https://api.github.com/repos/gumpt/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gumpt/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gumpt/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gumpt/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gumpt/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/gumpt/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gumpt/envoy/merges","archive_url":"https://api.github.com/repos/gumpt/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gumpt/envoy/downloads","issues_url":"https://api.github.com/repos/gumpt/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/gumpt/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/gumpt/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/gumpt/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gumpt/envoy/labels{/name}","releases_url":"https://api.github.com/repos/gumpt/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/gumpt/envoy/deployments","created_at":"2018-04-13T01:07:44Z","updated_at":"2018-05-23T00:54:07Z","pushed_at":"2018-05-23T00:54:05Z","git_url":"git://github.com/gumpt/envoy.git","ssh_url":"git@github.com:gumpt/envoy.git","clone_url":"https://github.com/gumpt/envoy.git","svn_url":"https://github.com/gumpt/envoy","homepage":"https://www.envoyproxy.io","size":15805,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"f9c0cf86fc94dae4204f22387e5793ad83c3f012","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-05-23T16:42:15Z","pushed_at":"2018-05-23T16:47:24Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":15779,"stargazers_count":5002,"watchers_count":5002,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":639,"mirror_url":null,"archived":false,"open_issues_count":309,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":639,"open_issues":309,"watchers":5002,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3443"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3443"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3443"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3443/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3443/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3443/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/7536ed7cf0d15cf07e0f6daa5f3edb6f6a171e6d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zuercher"}}