{"action":"closed","number":4748,"pull_request":{"url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/4748","id":222233276,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjMzMjc2","html_url":"https://github.com/rtfd/readthedocs.org/pull/4748","diff_url":"https://github.com/rtfd/readthedocs.org/pull/4748.diff","patch_url":"https://github.com/rtfd/readthedocs.org/pull/4748.patch","issue_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/4748","number":4748,"state":"closed","locked":false,"title":"Fixes an OSX issue with the test suite","user":{"login":"davidfischer","id":185043,"node_id":"MDQ6VXNlcjE4NTA0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/185043?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfischer","html_url":"https://github.com/davidfischer","followers_url":"https://api.github.com/users/davidfischer/followers","following_url":"https://api.github.com/users/davidfischer/following{/other_user}","gists_url":"https://api.github.com/users/davidfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfischer/subscriptions","organizations_url":"https://api.github.com/users/davidfischer/orgs","repos_url":"https://api.github.com/users/davidfischer/repos","events_url":"https://api.github.com/users/davidfischer/events{/privacy}","received_events_url":"https://api.github.com/users/davidfischer/received_events","type":"User","site_admin":false},"body":"There was a [change](https://github.com/rtfd/readthedocs.org/commit/ef6a05916c440916fba9755388b36ba95e98b0e4#diff-31a1317fe6aaf4de559c18d25fd89323L68) which causes the symlink test suite to fail on OSX.\r\n\r\nThe problem is caused by:\r\n* `tempfile.mkdtemp` returns a path under `/var/folders`\r\n* By default on OSX `/var` is a symlink to `/private/var`\r\n* As a result, `os.path.realpath(TEMP_SITE_ROOT) != TEMP_SITE_ROOT` and the expected paths don't match [here](https://github.com/rtfd/readthedocs.org/blob/9d6aabb760d870288494d3ef665323a11912dbe4/readthedocs/rtd_tests/tests/test_project_symlinks.py#L42)\r\n\r\nI'm running OSX 10.13.16.","created_at":"2018-10-11T18:19:58Z","updated_at":"2018-10-12T08:02:09Z","closed_at":"2018-10-12T08:02:09Z","merged_at":"2018-10-12T08:02:09Z","merge_commit_sha":"ab2b0c67e70d09a5e4a84de2a0c1e79d737f4ed2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/4748/commits","review_comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/4748/comments","review_comment_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/4748/comments","statuses_url":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/9d6aabb760d870288494d3ef665323a11912dbe4","head":{"label":"rtfd:davidfischer/fix-osx-realpath","ref":"davidfischer/fix-osx-realpath","sha":"9d6aabb760d870288494d3ef665323a11912dbe4","user":{"login":"rtfd","id":366329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjMyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/366329?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfd","html_url":"https://github.com/rtfd","followers_url":"https://api.github.com/users/rtfd/followers","following_url":"https://api.github.com/users/rtfd/following{/other_user}","gists_url":"https://api.github.com/users/rtfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfd/subscriptions","organizations_url":"https://api.github.com/users/rtfd/orgs","repos_url":"https://api.github.com/users/rtfd/repos","events_url":"https://api.github.com/users/rtfd/events{/privacy}","received_events_url":"https://api.github.com/users/rtfd/received_events","type":"Organization","site_admin":false},"repo":{"id":841835,"node_id":"MDEwOlJlcG9zaXRvcnk4NDE4MzU=","name":"readthedocs.org","full_name":"rtfd/readthedocs.org","private":false,"owner":{"login":"rtfd","id":366329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjMyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/366329?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfd","html_url":"https://github.com/rtfd","followers_url":"https://api.github.com/users/rtfd/followers","following_url":"https://api.github.com/users/rtfd/following{/other_user}","gists_url":"https://api.github.com/users/rtfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfd/subscriptions","organizations_url":"https://api.github.com/users/rtfd/orgs","repos_url":"https://api.github.com/users/rtfd/repos","events_url":"https://api.github.com/users/rtfd/events{/privacy}","received_events_url":"https://api.github.com/users/rtfd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rtfd/readthedocs.org","description":"The source code that powers readthedocs.org","fork":false,"url":"https://api.github.com/repos/rtfd/readthedocs.org","forks_url":"https://api.github.com/repos/rtfd/readthedocs.org/forks","keys_url":"https://api.github.com/repos/rtfd/readthedocs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtfd/readthedocs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtfd/readthedocs.org/teams","hooks_url":"https://api.github.com/repos/rtfd/readthedocs.org/hooks","issue_events_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/events{/number}","events_url":"https://api.github.com/repos/rtfd/readthedocs.org/events","assignees_url":"https://api.github.com/repos/rtfd/readthedocs.org/assignees{/user}","branches_url":"https://api.github.com/repos/rtfd/readthedocs.org/branches{/branch}","tags_url":"https://api.github.com/repos/rtfd/readthedocs.org/tags","blobs_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/rtfd/readthedocs.org/languages","stargazers_url":"https://api.github.com/repos/rtfd/readthedocs.org/stargazers","contributors_url":"https://api.github.com/repos/rtfd/readthedocs.org/contributors","subscribers_url":"https://api.github.com/repos/rtfd/readthedocs.org/subscribers","subscription_url":"https://api.github.com/repos/rtfd/readthedocs.org/subscription","commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtfd/readthedocs.org/contents/{+path}","compare_url":"https://api.github.com/repos/rtfd/readthedocs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtfd/readthedocs.org/merges","archive_url":"https://api.github.com/repos/rtfd/readthedocs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtfd/readthedocs.org/downloads","issues_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues{/number}","pulls_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/rtfd/readthedocs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/rtfd/readthedocs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtfd/readthedocs.org/labels{/name}","releases_url":"https://api.github.com/repos/rtfd/readthedocs.org/releases{/id}","deployments_url":"https://api.github.com/repos/rtfd/readthedocs.org/deployments","created_at":"2010-08-16T19:18:06Z","updated_at":"2018-10-11T18:45:08Z","pushed_at":"2018-10-12T08:02:09Z","git_url":"git://github.com/rtfd/readthedocs.org.git","ssh_url":"git@github.com:rtfd/readthedocs.org.git","clone_url":"https://github.com/rtfd/readthedocs.org.git","svn_url":"https://github.com/rtfd/readthedocs.org","homepage":"https://readthedocs.org/","size":53887,"stargazers_count":4687,"watchers_count":4687,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2561,"mirror_url":null,"archived":false,"open_issues_count":389,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2561,"open_issues":389,"watchers":4687,"default_branch":"master"}},"base":{"label":"rtfd:master","ref":"master","sha":"c01e8eb15e6c630e6f999bcd46cd78cb9109141c","user":{"login":"rtfd","id":366329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjMyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/366329?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfd","html_url":"https://github.com/rtfd","followers_url":"https://api.github.com/users/rtfd/followers","following_url":"https://api.github.com/users/rtfd/following{/other_user}","gists_url":"https://api.github.com/users/rtfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfd/subscriptions","organizations_url":"https://api.github.com/users/rtfd/orgs","repos_url":"https://api.github.com/users/rtfd/repos","events_url":"https://api.github.com/users/rtfd/events{/privacy}","received_events_url":"https://api.github.com/users/rtfd/received_events","type":"Organization","site_admin":false},"repo":{"id":841835,"node_id":"MDEwOlJlcG9zaXRvcnk4NDE4MzU=","name":"readthedocs.org","full_name":"rtfd/readthedocs.org","private":false,"owner":{"login":"rtfd","id":366329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjMyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/366329?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfd","html_url":"https://github.com/rtfd","followers_url":"https://api.github.com/users/rtfd/followers","following_url":"https://api.github.com/users/rtfd/following{/other_user}","gists_url":"https://api.github.com/users/rtfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfd/subscriptions","organizations_url":"https://api.github.com/users/rtfd/orgs","repos_url":"https://api.github.com/users/rtfd/repos","events_url":"https://api.github.com/users/rtfd/events{/privacy}","received_events_url":"https://api.github.com/users/rtfd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rtfd/readthedocs.org","description":"The source code that powers readthedocs.org","fork":false,"url":"https://api.github.com/repos/rtfd/readthedocs.org","forks_url":"https://api.github.com/repos/rtfd/readthedocs.org/forks","keys_url":"https://api.github.com/repos/rtfd/readthedocs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtfd/readthedocs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtfd/readthedocs.org/teams","hooks_url":"https://api.github.com/repos/rtfd/readthedocs.org/hooks","issue_events_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/events{/number}","events_url":"https://api.github.com/repos/rtfd/readthedocs.org/events","assignees_url":"https://api.github.com/repos/rtfd/readthedocs.org/assignees{/user}","branches_url":"https://api.github.com/repos/rtfd/readthedocs.org/branches{/branch}","tags_url":"https://api.github.com/repos/rtfd/readthedocs.org/tags","blobs_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/rtfd/readthedocs.org/languages","stargazers_url":"https://api.github.com/repos/rtfd/readthedocs.org/stargazers","contributors_url":"https://api.github.com/repos/rtfd/readthedocs.org/contributors","subscribers_url":"https://api.github.com/repos/rtfd/readthedocs.org/subscribers","subscription_url":"https://api.github.com/repos/rtfd/readthedocs.org/subscription","commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtfd/readthedocs.org/contents/{+path}","compare_url":"https://api.github.com/repos/rtfd/readthedocs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtfd/readthedocs.org/merges","archive_url":"https://api.github.com/repos/rtfd/readthedocs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtfd/readthedocs.org/downloads","issues_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues{/number}","pulls_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/rtfd/readthedocs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/rtfd/readthedocs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtfd/readthedocs.org/labels{/name}","releases_url":"https://api.github.com/repos/rtfd/readthedocs.org/releases{/id}","deployments_url":"https://api.github.com/repos/rtfd/readthedocs.org/deployments","created_at":"2010-08-16T19:18:06Z","updated_at":"2018-10-11T18:45:08Z","pushed_at":"2018-10-12T08:02:09Z","git_url":"git://github.com/rtfd/readthedocs.org.git","ssh_url":"git@github.com:rtfd/readthedocs.org.git","clone_url":"https://github.com/rtfd/readthedocs.org.git","svn_url":"https://github.com/rtfd/readthedocs.org","homepage":"https://readthedocs.org/","size":53887,"stargazers_count":4687,"watchers_count":4687,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2561,"mirror_url":null,"archived":false,"open_issues_count":389,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2561,"open_issues":389,"watchers":4687,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/4748"},"html":{"href":"https://github.com/rtfd/readthedocs.org/pull/4748"},"issue":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/issues/4748"},"comments":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/issues/4748/comments"},"review_comments":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/4748/comments"},"review_comment":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/4748/commits"},"statuses":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/9d6aabb760d870288494d3ef665323a11912dbe4"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"humitos","id":244656,"node_id":"MDQ6VXNlcjI0NDY1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/244656?v=4","gravatar_id":"","url":"https://api.github.com/users/humitos","html_url":"https://github.com/humitos","followers_url":"https://api.github.com/users/humitos/followers","following_url":"https://api.github.com/users/humitos/following{/other_user}","gists_url":"https://api.github.com/users/humitos/gists{/gist_id}","starred_url":"https://api.github.com/users/humitos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humitos/subscriptions","organizations_url":"https://api.github.com/users/humitos/orgs","repos_url":"https://api.github.com/users/humitos/repos","events_url":"https://api.github.com/users/humitos/events{/privacy}","received_events_url":"https://api.github.com/users/humitos/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"humitos"}}