{"action":"created","comment":{"url":"https://api.github.com/repos/apache/lucene-solr/pulls/comments/233517397","pull_request_review_id":174949612,"id":233517397,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzUxNzM5Nw==","diff_hunk":"@@ -100,13 +109,156 @@ public CacheHelper getCoreCacheHelper() {\n \n   }\n \n+  /**\n+   * Wrapper class for another PointValues implementation that is used by ExitableFields.\n+   */\n+  public static class ExitablePointValues extends PointValues {\n+\n+    private final PointValues in;\n+    private final QueryTimeout queryTimeout;\n+\n+    public ExitablePointValues(PointValues in, QueryTimeout queryTimeout) {","path":"lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java","position":28,"original_position":28,"commit_id":"7835ef40be2fb699471fc176f4479ac793e5e3b2","original_commit_id":"7835ef40be2fb699471fc176f4479ac793e5e3b2","user":{"login":"cbismuth","id":21545602,"node_id":"MDQ6VXNlcjIxNTQ1NjAy","avatar_url":"https://avatars1.githubusercontent.com/u/21545602?v=4","gravatar_id":"","url":"https://api.github.com/users/cbismuth","html_url":"https://github.com/cbismuth","followers_url":"https://api.github.com/users/cbismuth/followers","following_url":"https://api.github.com/users/cbismuth/following{/other_user}","gists_url":"https://api.github.com/users/cbismuth/gists{/gist_id}","starred_url":"https://api.github.com/users/cbismuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbismuth/subscriptions","organizations_url":"https://api.github.com/users/cbismuth/orgs","repos_url":"https://api.github.com/users/cbismuth/repos","events_url":"https://api.github.com/users/cbismuth/events{/privacy}","received_events_url":"https://api.github.com/users/cbismuth/received_events","type":"User","site_admin":false},"body":"Issue found: I forgot to add a `set -e` statement in my tiny bash script below to stop on first failure.\r\n\r\nLet me run another `precommit` Ant task and push.\r\n\r\n```bash\r\n#!/usr/bin/env bash\r\n\r\nset -e\r\n\r\ncd ${HOME}/git/lucene-solr\r\nfind . -name \"*.lck\" -delete\r\nant clean compile precommit\r\nant -f lucene/build.xml test\r\n```","created_at":"2018-11-14T16:20:31Z","updated_at":"2018-11-14T16:20:31Z","html_url":"https://github.com/apache/lucene-solr/pull/497#discussion_r233517397","pull_request_url":"https://api.github.com/repos/apache/lucene-solr/pulls/497","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/comments/233517397"},"html":{"href":"https://github.com/apache/lucene-solr/pull/497#discussion_r233517397"},"pull_request":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/497"}},"in_reply_to_id":233506349},"pull_request":{"url":"https://api.github.com/repos/apache/lucene-solr/pulls/497","id":230124996,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTI0OTk2","html_url":"https://github.com/apache/lucene-solr/pull/497","diff_url":"https://github.com/apache/lucene-solr/pull/497.diff","patch_url":"https://github.com/apache/lucene-solr/pull/497.patch","issue_url":"https://api.github.com/repos/apache/lucene-solr/issues/497","number":497,"state":"open","locked":false,"title":"LUCENE-8026: ExitableDirectoryReader does not instrument points","user":{"login":"cbismuth","id":21545602,"node_id":"MDQ6VXNlcjIxNTQ1NjAy","avatar_url":"https://avatars1.githubusercontent.com/u/21545602?v=4","gravatar_id":"","url":"https://api.github.com/users/cbismuth","html_url":"https://github.com/cbismuth","followers_url":"https://api.github.com/users/cbismuth/followers","following_url":"https://api.github.com/users/cbismuth/following{/other_user}","gists_url":"https://api.github.com/users/cbismuth/gists{/gist_id}","starred_url":"https://api.github.com/users/cbismuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbismuth/subscriptions","organizations_url":"https://api.github.com/users/cbismuth/orgs","repos_url":"https://api.github.com/users/cbismuth/repos","events_url":"https://api.github.com/users/cbismuth/events{/privacy}","received_events_url":"https://api.github.com/users/cbismuth/received_events","type":"User","site_admin":false},"body":"> This means it cannot interrupt range or geo queries.\r\n\r\nSee [LUCENE-8026](https://issues.apache.org/jira/browse/LUCENE-8026).","created_at":"2018-11-12T12:55:27Z","updated_at":"2018-11-14T16:20:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b72de36545b218cd8677a95bf8a7e41837974a5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/lucene-solr/pulls/497/commits","review_comments_url":"https://api.github.com/repos/apache/lucene-solr/pulls/497/comments","review_comment_url":"https://api.github.com/repos/apache/lucene-solr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/lucene-solr/issues/497/comments","statuses_url":"https://api.github.com/repos/apache/lucene-solr/statuses/7835ef40be2fb699471fc176f4479ac793e5e3b2","head":{"label":"cbismuth:LUCENE-8026","ref":"LUCENE-8026","sha":"7835ef40be2fb699471fc176f4479ac793e5e3b2","user":{"login":"cbismuth","id":21545602,"node_id":"MDQ6VXNlcjIxNTQ1NjAy","avatar_url":"https://avatars1.githubusercontent.com/u/21545602?v=4","gravatar_id":"","url":"https://api.github.com/users/cbismuth","html_url":"https://github.com/cbismuth","followers_url":"https://api.github.com/users/cbismuth/followers","following_url":"https://api.github.com/users/cbismuth/following{/other_user}","gists_url":"https://api.github.com/users/cbismuth/gists{/gist_id}","starred_url":"https://api.github.com/users/cbismuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbismuth/subscriptions","organizations_url":"https://api.github.com/users/cbismuth/orgs","repos_url":"https://api.github.com/users/cbismuth/repos","events_url":"https://api.github.com/users/cbismuth/events{/privacy}","received_events_url":"https://api.github.com/users/cbismuth/received_events","type":"User","site_admin":false},"repo":{"id":156353873,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYzNTM4NzM=","name":"lucene-solr","full_name":"cbismuth/lucene-solr","private":false,"owner":{"login":"cbismuth","id":21545602,"node_id":"MDQ6VXNlcjIxNTQ1NjAy","avatar_url":"https://avatars1.githubusercontent.com/u/21545602?v=4","gravatar_id":"","url":"https://api.github.com/users/cbismuth","html_url":"https://github.com/cbismuth","followers_url":"https://api.github.com/users/cbismuth/followers","following_url":"https://api.github.com/users/cbismuth/following{/other_user}","gists_url":"https://api.github.com/users/cbismuth/gists{/gist_id}","starred_url":"https://api.github.com/users/cbismuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbismuth/subscriptions","organizations_url":"https://api.github.com/users/cbismuth/orgs","repos_url":"https://api.github.com/users/cbismuth/repos","events_url":"https://api.github.com/users/cbismuth/events{/privacy}","received_events_url":"https://api.github.com/users/cbismuth/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cbismuth/lucene-solr","description":"Mirror of Apache Lucene + Solr","fork":true,"url":"https://api.github.com/repos/cbismuth/lucene-solr","forks_url":"https://api.github.com/repos/cbismuth/lucene-solr/forks","keys_url":"https://api.github.com/repos/cbismuth/lucene-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbismuth/lucene-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbismuth/lucene-solr/teams","hooks_url":"https://api.github.com/repos/cbismuth/lucene-solr/hooks","issue_events_url":"https://api.github.com/repos/cbismuth/lucene-solr/issues/events{/number}","events_url":"https://api.github.com/repos/cbismuth/lucene-solr/events","assignees_url":"https://api.github.com/repos/cbismuth/lucene-solr/assignees{/user}","branches_url":"https://api.github.com/repos/cbismuth/lucene-solr/branches{/branch}","tags_url":"https://api.github.com/repos/cbismuth/lucene-solr/tags","blobs_url":"https://api.github.com/repos/cbismuth/lucene-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbismuth/lucene-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbismuth/lucene-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbismuth/lucene-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbismuth/lucene-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/cbismuth/lucene-solr/languages","stargazers_url":"https://api.github.com/repos/cbismuth/lucene-solr/stargazers","contributors_url":"https://api.github.com/repos/cbismuth/lucene-solr/contributors","subscribers_url":"https://api.github.com/repos/cbismuth/lucene-solr/subscribers","subscription_url":"https://api.github.com/repos/cbismuth/lucene-solr/subscription","commits_url":"https://api.github.com/repos/cbismuth/lucene-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbismuth/lucene-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbismuth/lucene-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbismuth/lucene-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbismuth/lucene-solr/contents/{+path}","compare_url":"https://api.github.com/repos/cbismuth/lucene-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbismuth/lucene-solr/merges","archive_url":"https://api.github.com/repos/cbismuth/lucene-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbismuth/lucene-solr/downloads","issues_url":"https://api.github.com/repos/cbismuth/lucene-solr/issues{/number}","pulls_url":"https://api.github.com/repos/cbismuth/lucene-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/cbismuth/lucene-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/cbismuth/lucene-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbismuth/lucene-solr/labels{/name}","releases_url":"https://api.github.com/repos/cbismuth/lucene-solr/releases{/id}","deployments_url":"https://api.github.com/repos/cbismuth/lucene-solr/deployments","created_at":"2018-11-06T08:50:42Z","updated_at":"2018-11-14T07:46:11Z","pushed_at":"2018-11-14T14:23:12Z","git_url":"git://github.com/cbismuth/lucene-solr.git","ssh_url":"git@github.com:cbismuth/lucene-solr.git","clone_url":"https://github.com/cbismuth/lucene-solr.git","svn_url":"https://github.com/cbismuth/lucene-solr","homepage":null,"size":374790,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"95d01c6583b825b6b87591e4f27002c285ea25fb","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50229487,"node_id":"MDEwOlJlcG9zaXRvcnk1MDIyOTQ4Nw==","name":"lucene-solr","full_name":"apache/lucene-solr","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/lucene-solr","description":"Mirror of Apache Lucene + Solr","fork":false,"url":"https://api.github.com/repos/apache/lucene-solr","forks_url":"https://api.github.com/repos/apache/lucene-solr/forks","keys_url":"https://api.github.com/repos/apache/lucene-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/lucene-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/lucene-solr/teams","hooks_url":"https://api.github.com/repos/apache/lucene-solr/hooks","issue_events_url":"https://api.github.com/repos/apache/lucene-solr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/lucene-solr/events","assignees_url":"https://api.github.com/repos/apache/lucene-solr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/lucene-solr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/lucene-solr/tags","blobs_url":"https://api.github.com/repos/apache/lucene-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/lucene-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/lucene-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/lucene-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/lucene-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/lucene-solr/languages","stargazers_url":"https://api.github.com/repos/apache/lucene-solr/stargazers","contributors_url":"https://api.github.com/repos/apache/lucene-solr/contributors","subscribers_url":"https://api.github.com/repos/apache/lucene-solr/subscribers","subscription_url":"https://api.github.com/repos/apache/lucene-solr/subscription","commits_url":"https://api.github.com/repos/apache/lucene-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/lucene-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/lucene-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/lucene-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/lucene-solr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/lucene-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/lucene-solr/merges","archive_url":"https://api.github.com/repos/apache/lucene-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/lucene-solr/downloads","issues_url":"https://api.github.com/repos/apache/lucene-solr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/lucene-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/lucene-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/lucene-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/lucene-solr/labels{/name}","releases_url":"https://api.github.com/repos/apache/lucene-solr/releases{/id}","deployments_url":"https://api.github.com/repos/apache/lucene-solr/deployments","created_at":"2016-01-23T08:00:06Z","updated_at":"2018-11-14T15:40:08Z","pushed_at":"2018-11-14T15:13:45Z","git_url":"git://github.com/apache/lucene-solr.git","ssh_url":"git@github.com:apache/lucene-solr.git","clone_url":"https://github.com/apache/lucene-solr.git","svn_url":"https://github.com/apache/lucene-solr","homepage":null,"size":374897,"stargazers_count":2062,"watchers_count":2062,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1602,"mirror_url":null,"archived":false,"open_issues_count":262,"license":null,"forks":1602,"open_issues":262,"watchers":2062,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/497"},"html":{"href":"https://github.com/apache/lucene-solr/pull/497"},"issue":{"href":"https://api.github.com/repos/apache/lucene-solr/issues/497"},"comments":{"href":"https://api.github.com/repos/apache/lucene-solr/issues/497/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/497/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/497/commits"},"statuses":{"href":"https://api.github.com/repos/apache/lucene-solr/statuses/7835ef40be2fb699471fc176f4479ac793e5e3b2"}},"author_association":"NONE"}}
{"actor":{"display_login":"cbismuth"}}