{"action":"created","issue":{"url":"https://api.github.com/repos/angular/tsickle/issues/759","repository_url":"https://api.github.com/repos/angular/tsickle","labels_url":"https://api.github.com/repos/angular/tsickle/issues/759/labels{/name}","comments_url":"https://api.github.com/repos/angular/tsickle/issues/759/comments","events_url":"https://api.github.com/repos/angular/tsickle/issues/759/events","html_url":"https://github.com/angular/tsickle/pull/759","id":302937037,"number":759,"title":"fix(externs): add SymbolConstructor.","user":{"login":"bowenni","id":2364438,"avatar_url":"https://avatars1.githubusercontent.com/u/2364438?v=4","gravatar_id":"","url":"https://api.github.com/users/bowenni","html_url":"https://github.com/bowenni","followers_url":"https://api.github.com/users/bowenni/followers","following_url":"https://api.github.com/users/bowenni/following{/other_user}","gists_url":"https://api.github.com/users/bowenni/gists{/gist_id}","starred_url":"https://api.github.com/users/bowenni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowenni/subscriptions","organizations_url":"https://api.github.com/users/bowenni/orgs","repos_url":"https://api.github.com/users/bowenni/repos","events_url":"https://api.github.com/users/bowenni/events{/privacy}","received_events_url":"https://api.github.com/users/bowenni/received_events","type":"User","site_admin":false},"labels":[{"id":308083292,"url":"https://api.github.com/repos/angular/tsickle/labels/cla:%20yes","name":"cla: yes","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-07T02:01:25Z","updated_at":"2018-03-07T09:52:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/angular/tsickle/pulls/759","html_url":"https://github.com/angular/tsickle/pull/759","diff_url":"https://github.com/angular/tsickle/pull/759.diff","patch_url":"https://github.com/angular/tsickle/pull/759.patch"},"body":"https://github.com/Microsoft/TypeScript/blob/v2.6.2/lib/lib.es2015.symbol.d.ts#L29"},"comment":{"url":"https://api.github.com/repos/angular/tsickle/issues/comments/371084326","html_url":"https://github.com/angular/tsickle/pull/759#issuecomment-371084326","issue_url":"https://api.github.com/repos/angular/tsickle/issues/759","id":371084326,"user":{"login":"mprobst","id":7208,"avatar_url":"https://avatars0.githubusercontent.com/u/7208?v=4","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T09:52:04Z","updated_at":"2018-03-07T09:52:04Z","author_association":"CONTRIBUTOR","body":"The e2e test should have all externs available, that's how it also has `Promise` and so on from this file. I believe the `isInTestMode` is a red herring here, we're running JSCompiler in a regular execution mode for our tests, and that flag is only for JSCompiler internal testing.\r\n\r\nAre you maybe confusing `Symbol` (uppercase) and `symbol` lowercase? `Symbol` in `es3.js` is only a function, whereas `symbol` is the typedef. Maybe you just need to use `symbol` (lower case) in your CL?\r\n\r\nThough if that's the case, I wonder what `Symbol` (upper) emits as, and what JSCompiler makes out of it. Could you consider adding a bit of TypeScript code that uses `Symbol` and `SymbolConstructor` so we can see this working in action?\r\n"}}
{"actor":{"display_login":"mprobst"}}