{"action":"created","comment":{"url":"https://api.github.com/repos/root-project/rootbench/pulls/comments/170452813","pull_request_review_id":99142825,"id":170452813,"diff_hunk":"@@ -0,0 +1,179 @@\n+#include \"ROOT/TDataFrame.hxx\"\n+#include \"TROOT.h\"   // ROOT::EnableImplicitMT\n+#include \"TSystem.h\" // TSystem::Unlink\n+#include \"benchmark/benchmark.h\"\n+#include <string>\n+#include <vector>\n+using namespace ROOT::Experimental;\n+\n+// TODO change hardcoded path with env variable or equivalent\n+const std::string scratchDir = \"/tmp/tmpfs\";\n+\n+static void TDF_CreateEmpty(benchmark::State &state)\n+{\n+   for (auto _ : state)\n+      TDataFrame(0);\n+}\n+BENCHMARK(TDF_CreateEmpty)->Unit(benchmark::kMicrosecond);\n+\n+static void TDF_CreateFromFile(benchmark::State &state)\n+{\n+   const auto fname = scratchDir + \"/tdf_createfromfile.root\";\n+   const auto treeName = \"t\";\n+   TDataFrame(0).Snapshot<>(\"t\", fname, {});\n+\n+   for (auto _ : state)\n+      TDataFrame(\"t\", fname);\n+\n+   gSystem->Unlink(fname.c_str());\n+}\n+BENCHMARK(TDF_CreateFromFile)->Unit(benchmark::kMicrosecond);\n+\n+int Zero()","path":"root/tree/treeplayer/TDataFrameBenchmarks.cxx","position":null,"original_position":32,"commit_id":"f0b76bde2c1533a3a1781979380c232a62121f6c","original_commit_id":"c83c15eae0deb69bb9c5c20b0ead63c7cb38b5a9","user":{"login":"vgvassilev","id":6516307,"avatar_url":"https://avatars1.githubusercontent.com/u/6516307?v=4","gravatar_id":"","url":"https://api.github.com/users/vgvassilev","html_url":"https://github.com/vgvassilev","followers_url":"https://api.github.com/users/vgvassilev/followers","following_url":"https://api.github.com/users/vgvassilev/following{/other_user}","gists_url":"https://api.github.com/users/vgvassilev/gists{/gist_id}","starred_url":"https://api.github.com/users/vgvassilev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgvassilev/subscriptions","organizations_url":"https://api.github.com/users/vgvassilev/orgs","repos_url":"https://api.github.com/users/vgvassilev/repos","events_url":"https://api.github.com/users/vgvassilev/events{/privacy}","received_events_url":"https://api.github.com/users/vgvassilev/received_events","type":"User","site_admin":false},"body":"Ah, ok. Wasn't obvious to me but makes sense now!","created_at":"2018-02-25T13:23:40Z","updated_at":"2018-02-25T13:23:40Z","html_url":"https://github.com/root-project/rootbench/pull/45#discussion_r170452813","pull_request_url":"https://api.github.com/repos/root-project/rootbench/pulls/45","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/root-project/rootbench/pulls/comments/170452813"},"html":{"href":"https://github.com/root-project/rootbench/pull/45#discussion_r170452813"},"pull_request":{"href":"https://api.github.com/repos/root-project/rootbench/pulls/45"}},"in_reply_to_id":170447354},"pull_request":{"url":"https://api.github.com/repos/root-project/rootbench/pulls/45","id":171185740,"html_url":"https://github.com/root-project/rootbench/pull/45","diff_url":"https://github.com/root-project/rootbench/pull/45.diff","patch_url":"https://github.com/root-project/rootbench/pull/45.patch","issue_url":"https://api.github.com/repos/root-project/rootbench/issues/45","number":45,"state":"open","locked":false,"title":"[TDF] Add first round of benchmarks","user":{"login":"bluehood","id":10999034,"avatar_url":"https://avatars3.githubusercontent.com/u/10999034?v=4","gravatar_id":"","url":"https://api.github.com/users/bluehood","html_url":"https://github.com/bluehood","followers_url":"https://api.github.com/users/bluehood/followers","following_url":"https://api.github.com/users/bluehood/following{/other_user}","gists_url":"https://api.github.com/users/bluehood/gists{/gist_id}","starred_url":"https://api.github.com/users/bluehood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluehood/subscriptions","organizations_url":"https://api.github.com/users/bluehood/orgs","repos_url":"https://api.github.com/users/bluehood/repos","events_url":"https://api.github.com/users/bluehood/events{/privacy}","received_events_url":"https://api.github.com/users/bluehood/received_events","type":"User","site_admin":false},"body":"Scaling benchmarks will be added later in a different PR.\r\n\r\nOutstanding issue: using `->ThreadPerCpu()` causes a crash (not a huge problem since this option is undocumented anyway -- I wanted to try it out because it's used in `TBufferMerger`'s benchmarks).","created_at":"2018-02-24T16:29:29Z","updated_at":"2018-02-25T13:23:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"450b6cd08b5b9df21a835702f5a87409392e3c46","assignee":{"login":"bluehood","id":10999034,"avatar_url":"https://avatars3.githubusercontent.com/u/10999034?v=4","gravatar_id":"","url":"https://api.github.com/users/bluehood","html_url":"https://github.com/bluehood","followers_url":"https://api.github.com/users/bluehood/followers","following_url":"https://api.github.com/users/bluehood/following{/other_user}","gists_url":"https://api.github.com/users/bluehood/gists{/gist_id}","starred_url":"https://api.github.com/users/bluehood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluehood/subscriptions","organizations_url":"https://api.github.com/users/bluehood/orgs","repos_url":"https://api.github.com/users/bluehood/repos","events_url":"https://api.github.com/users/bluehood/events{/privacy}","received_events_url":"https://api.github.com/users/bluehood/received_events","type":"User","site_admin":false},"assignees":[{"login":"bluehood","id":10999034,"avatar_url":"https://avatars3.githubusercontent.com/u/10999034?v=4","gravatar_id":"","url":"https://api.github.com/users/bluehood","html_url":"https://github.com/bluehood","followers_url":"https://api.github.com/users/bluehood/followers","following_url":"https://api.github.com/users/bluehood/following{/other_user}","gists_url":"https://api.github.com/users/bluehood/gists{/gist_id}","starred_url":"https://api.github.com/users/bluehood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluehood/subscriptions","organizations_url":"https://api.github.com/users/bluehood/orgs","repos_url":"https://api.github.com/users/bluehood/repos","events_url":"https://api.github.com/users/bluehood/events{/privacy}","received_events_url":"https://api.github.com/users/bluehood/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Axel-Naumann","id":144675,"avatar_url":"https://avatars1.githubusercontent.com/u/144675?v=4","gravatar_id":"","url":"https://api.github.com/users/Axel-Naumann","html_url":"https://github.com/Axel-Naumann","followers_url":"https://api.github.com/users/Axel-Naumann/followers","following_url":"https://api.github.com/users/Axel-Naumann/following{/other_user}","gists_url":"https://api.github.com/users/Axel-Naumann/gists{/gist_id}","starred_url":"https://api.github.com/users/Axel-Naumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Axel-Naumann/subscriptions","organizations_url":"https://api.github.com/users/Axel-Naumann/orgs","repos_url":"https://api.github.com/users/Axel-Naumann/repos","events_url":"https://api.github.com/users/Axel-Naumann/events{/privacy}","received_events_url":"https://api.github.com/users/Axel-Naumann/received_events","type":"User","site_admin":false},{"login":"dpiparo","id":7850302,"avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/root-project/rootbench/pulls/45/commits","review_comments_url":"https://api.github.com/repos/root-project/rootbench/pulls/45/comments","review_comment_url":"https://api.github.com/repos/root-project/rootbench/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-project/rootbench/issues/45/comments","statuses_url":"https://api.github.com/repos/root-project/rootbench/statuses/f0b76bde2c1533a3a1781979380c232a62121f6c","head":{"label":"bluehood:tdf_bench","ref":"tdf_bench","sha":"f0b76bde2c1533a3a1781979380c232a62121f6c","user":{"login":"bluehood","id":10999034,"avatar_url":"https://avatars3.githubusercontent.com/u/10999034?v=4","gravatar_id":"","url":"https://api.github.com/users/bluehood","html_url":"https://github.com/bluehood","followers_url":"https://api.github.com/users/bluehood/followers","following_url":"https://api.github.com/users/bluehood/following{/other_user}","gists_url":"https://api.github.com/users/bluehood/gists{/gist_id}","starred_url":"https://api.github.com/users/bluehood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluehood/subscriptions","organizations_url":"https://api.github.com/users/bluehood/orgs","repos_url":"https://api.github.com/users/bluehood/repos","events_url":"https://api.github.com/users/bluehood/events{/privacy}","received_events_url":"https://api.github.com/users/bluehood/received_events","type":"User","site_admin":false},"repo":{"id":122599088,"name":"rootbench","full_name":"bluehood/rootbench","owner":{"login":"bluehood","id":10999034,"avatar_url":"https://avatars3.githubusercontent.com/u/10999034?v=4","gravatar_id":"","url":"https://api.github.com/users/bluehood","html_url":"https://github.com/bluehood","followers_url":"https://api.github.com/users/bluehood/followers","following_url":"https://api.github.com/users/bluehood/following{/other_user}","gists_url":"https://api.github.com/users/bluehood/gists{/gist_id}","starred_url":"https://api.github.com/users/bluehood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluehood/subscriptions","organizations_url":"https://api.github.com/users/bluehood/orgs","repos_url":"https://api.github.com/users/bluehood/repos","events_url":"https://api.github.com/users/bluehood/events{/privacy}","received_events_url":"https://api.github.com/users/bluehood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bluehood/rootbench","description":"Collection of benchmarks and performance monitoring applications","fork":true,"url":"https://api.github.com/repos/bluehood/rootbench","forks_url":"https://api.github.com/repos/bluehood/rootbench/forks","keys_url":"https://api.github.com/repos/bluehood/rootbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bluehood/rootbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bluehood/rootbench/teams","hooks_url":"https://api.github.com/repos/bluehood/rootbench/hooks","issue_events_url":"https://api.github.com/repos/bluehood/rootbench/issues/events{/number}","events_url":"https://api.github.com/repos/bluehood/rootbench/events","assignees_url":"https://api.github.com/repos/bluehood/rootbench/assignees{/user}","branches_url":"https://api.github.com/repos/bluehood/rootbench/branches{/branch}","tags_url":"https://api.github.com/repos/bluehood/rootbench/tags","blobs_url":"https://api.github.com/repos/bluehood/rootbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bluehood/rootbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bluehood/rootbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/bluehood/rootbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bluehood/rootbench/statuses/{sha}","languages_url":"https://api.github.com/repos/bluehood/rootbench/languages","stargazers_url":"https://api.github.com/repos/bluehood/rootbench/stargazers","contributors_url":"https://api.github.com/repos/bluehood/rootbench/contributors","subscribers_url":"https://api.github.com/repos/bluehood/rootbench/subscribers","subscription_url":"https://api.github.com/repos/bluehood/rootbench/subscription","commits_url":"https://api.github.com/repos/bluehood/rootbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/bluehood/rootbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/bluehood/rootbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/bluehood/rootbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/bluehood/rootbench/contents/{+path}","compare_url":"https://api.github.com/repos/bluehood/rootbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bluehood/rootbench/merges","archive_url":"https://api.github.com/repos/bluehood/rootbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bluehood/rootbench/downloads","issues_url":"https://api.github.com/repos/bluehood/rootbench/issues{/number}","pulls_url":"https://api.github.com/repos/bluehood/rootbench/pulls{/number}","milestones_url":"https://api.github.com/repos/bluehood/rootbench/milestones{/number}","notifications_url":"https://api.github.com/repos/bluehood/rootbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bluehood/rootbench/labels{/name}","releases_url":"https://api.github.com/repos/bluehood/rootbench/releases{/id}","deployments_url":"https://api.github.com/repos/bluehood/rootbench/deployments","created_at":"2018-02-23T09:16:00Z","updated_at":"2018-02-23T09:16:02Z","pushed_at":"2018-02-25T12:04:07Z","git_url":"git://github.com/bluehood/rootbench.git","ssh_url":"git@github.com:bluehood/rootbench.git","clone_url":"https://github.com/bluehood/rootbench.git","svn_url":"https://github.com/bluehood/rootbench","homepage":null,"size":112,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-project:master","ref":"master","sha":"e9ebbe49f71554191fed05f315e8588eadc9f57d","user":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"repo":{"id":100357329,"name":"rootbench","full_name":"root-project/rootbench","owner":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root-project/rootbench","description":"Collection of benchmarks and performance monitoring applications","fork":false,"url":"https://api.github.com/repos/root-project/rootbench","forks_url":"https://api.github.com/repos/root-project/rootbench/forks","keys_url":"https://api.github.com/repos/root-project/rootbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-project/rootbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-project/rootbench/teams","hooks_url":"https://api.github.com/repos/root-project/rootbench/hooks","issue_events_url":"https://api.github.com/repos/root-project/rootbench/issues/events{/number}","events_url":"https://api.github.com/repos/root-project/rootbench/events","assignees_url":"https://api.github.com/repos/root-project/rootbench/assignees{/user}","branches_url":"https://api.github.com/repos/root-project/rootbench/branches{/branch}","tags_url":"https://api.github.com/repos/root-project/rootbench/tags","blobs_url":"https://api.github.com/repos/root-project/rootbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-project/rootbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-project/rootbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-project/rootbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-project/rootbench/statuses/{sha}","languages_url":"https://api.github.com/repos/root-project/rootbench/languages","stargazers_url":"https://api.github.com/repos/root-project/rootbench/stargazers","contributors_url":"https://api.github.com/repos/root-project/rootbench/contributors","subscribers_url":"https://api.github.com/repos/root-project/rootbench/subscribers","subscription_url":"https://api.github.com/repos/root-project/rootbench/subscription","commits_url":"https://api.github.com/repos/root-project/rootbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-project/rootbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-project/rootbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-project/rootbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-project/rootbench/contents/{+path}","compare_url":"https://api.github.com/repos/root-project/rootbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-project/rootbench/merges","archive_url":"https://api.github.com/repos/root-project/rootbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-project/rootbench/downloads","issues_url":"https://api.github.com/repos/root-project/rootbench/issues{/number}","pulls_url":"https://api.github.com/repos/root-project/rootbench/pulls{/number}","milestones_url":"https://api.github.com/repos/root-project/rootbench/milestones{/number}","notifications_url":"https://api.github.com/repos/root-project/rootbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-project/rootbench/labels{/name}","releases_url":"https://api.github.com/repos/root-project/rootbench/releases{/id}","deployments_url":"https://api.github.com/repos/root-project/rootbench/deployments","created_at":"2017-08-15T08:39:45Z","updated_at":"2017-11-06T00:14:08Z","pushed_at":"2018-02-25T12:04:09Z","git_url":"git://github.com/root-project/rootbench.git","ssh_url":"git@github.com:root-project/rootbench.git","clone_url":"https://github.com/root-project/rootbench.git","svn_url":"https://github.com/root-project/rootbench","homepage":null,"size":104,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":8,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-project/rootbench/pulls/45"},"html":{"href":"https://github.com/root-project/rootbench/pull/45"},"issue":{"href":"https://api.github.com/repos/root-project/rootbench/issues/45"},"comments":{"href":"https://api.github.com/repos/root-project/rootbench/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/root-project/rootbench/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/root-project/rootbench/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-project/rootbench/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/root-project/rootbench/statuses/f0b76bde2c1533a3a1781979380c232a62121f6c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vgvassilev"}}