{"action":"created","comment":{"url":"https://api.github.com/repos/salesforce/TransmogrifAI/pulls/comments/217251313","pull_request_review_id":154918256,"id":217251313,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzI1MTMxMw==","diff_hunk":"@@ -93,7 +94,8 @@ class RawFeatureFilter[T]\n   val correlationType: CorrelationType = CorrelationType.Pearson,\n   val jsDivergenceProtectedFeatures: Set[String] = Set.empty,\n   val protectedFeatures: Set[String] = Set.empty,\n-  val textBinsFormula: (Summary, Int) => Int = RawFeatureFilter.textBinsFormula\n+  val textBinsFormula: (Summary, Int) => Int = RawFeatureFilter.textBinsFormula,\n+  val timePeriod: Option[TimePeriod] = None","path":"core/src/main/scala/com/salesforce/op/filters/RawFeatureFilter.scala","position":14,"original_position":14,"commit_id":"f62c38d642a533ec6b5c0e00cec9953f7d17e9cc","original_commit_id":"f62c38d642a533ec6b5c0e00cec9953f7d17e9cc","user":{"login":"tovbinm","id":629845,"node_id":"MDQ6VXNlcjYyOTg0NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/629845?v=4","gravatar_id":"","url":"https://api.github.com/users/tovbinm","html_url":"https://github.com/tovbinm","followers_url":"https://api.github.com/users/tovbinm/followers","following_url":"https://api.github.com/users/tovbinm/following{/other_user}","gists_url":"https://api.github.com/users/tovbinm/gists{/gist_id}","starred_url":"https://api.github.com/users/tovbinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tovbinm/subscriptions","organizations_url":"https://api.github.com/users/tovbinm/orgs","repos_url":"https://api.github.com/users/tovbinm/repos","events_url":"https://api.github.com/users/tovbinm/events{/privacy}","received_events_url":"https://api.github.com/users/tovbinm/received_events","type":"User","site_admin":false},"body":"also, please add `timePeriod` to `OpWorkflow.withRawFeatureFilter` as well","created_at":"2018-09-13T03:32:29Z","updated_at":"2018-09-13T03:32:29Z","html_url":"https://github.com/salesforce/TransmogrifAI/pull/130#discussion_r217251313","pull_request_url":"https://api.github.com/repos/salesforce/TransmogrifAI/pulls/130","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/salesforce/TransmogrifAI/pulls/comments/217251313"},"html":{"href":"https://github.com/salesforce/TransmogrifAI/pull/130#discussion_r217251313"},"pull_request":{"href":"https://api.github.com/repos/salesforce/TransmogrifAI/pulls/130"}},"in_reply_to_id":217251218},"pull_request":{"url":"https://api.github.com/repos/salesforce/TransmogrifAI/pulls/130","id":215135063,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTM1MDYz","html_url":"https://github.com/salesforce/TransmogrifAI/pull/130","diff_url":"https://github.com/salesforce/TransmogrifAI/pull/130.diff","patch_url":"https://github.com/salesforce/TransmogrifAI/pull/130.patch","issue_url":"https://api.github.com/repos/salesforce/TransmogrifAI/issues/130","number":130,"state":"open","locked":false,"title":"Apply DateToUnitCircleTransformer logic in raw feature transformations.","user":{"login":"marcovivero","id":8545381,"node_id":"MDQ6VXNlcjg1NDUzODE=","avatar_url":"https://avatars2.githubusercontent.com/u/8545381?v=4","gravatar_id":"","url":"https://api.github.com/users/marcovivero","html_url":"https://github.com/marcovivero","followers_url":"https://api.github.com/users/marcovivero/followers","following_url":"https://api.github.com/users/marcovivero/following{/other_user}","gists_url":"https://api.github.com/users/marcovivero/gists{/gist_id}","starred_url":"https://api.github.com/users/marcovivero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcovivero/subscriptions","organizations_url":"https://api.github.com/users/marcovivero/orgs","repos_url":"https://api.github.com/users/marcovivero/repos","events_url":"https://api.github.com/users/marcovivero/events{/privacy}","received_events_url":"https://api.github.com/users/marcovivero/received_events","type":"User","site_admin":false},"body":"**Related issues**\r\nThere is currently no related issue open for this, this is an enhancement.\r\n\r\n**Describe the proposed solution**\r\nAdd the option to apply circular date time transformer in `RawFeatureFilter` to any `Date`, `DateTime`, `DateList`, or `DateMap` feature type. This is the same logic utilized for `DateToUnitCircleTransformer`:\r\n\r\nhttps://github.com/salesforce/TransmogrifAI/blob/master/core/src/main/scala/com/salesforce/op/stages/impl/feature/DateToUnitCircleTransformer.scala\r\n\r\nThis is currently turned off by default and should be up to user to turn on in their respective workflows.\r\n\r\n**Describe alternatives you've considered**\r\nWe currently use the standard approach to processing `Numeric` types, i.e. just mapping these to doubles. This may lead to issues when comparing different distributions over time.\r\n\r\n**Additional context**\r\nAdd any other context about the changes here.\r\n","created_at":"2018-09-13T00:49:54Z","updated_at":"2018-09-13T03:32:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"176560b5ee472b3e48ef832de6d6a7e564ab2f2b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"leahmcguire","id":9258550,"node_id":"MDQ6VXNlcjkyNTg1NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/9258550?v=4","gravatar_id":"","url":"https://api.github.com/users/leahmcguire","html_url":"https://github.com/leahmcguire","followers_url":"https://api.github.com/users/leahmcguire/followers","following_url":"https://api.github.com/users/leahmcguire/following{/other_user}","gists_url":"https://api.github.com/users/leahmcguire/gists{/gist_id}","starred_url":"https://api.github.com/users/leahmcguire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leahmcguire/subscriptions","organizations_url":"https://api.github.com/users/leahmcguire/orgs","repos_url":"https://api.github.com/users/leahmcguire/repos","events_url":"https://api.github.com/users/leahmcguire/events{/privacy}","received_events_url":"https://api.github.com/users/leahmcguire/received_events","type":"User","site_admin":false},{"login":"kinfaikan","id":14301435,"node_id":"MDQ6VXNlcjE0MzAxNDM1","avatar_url":"https://avatars1.githubusercontent.com/u/14301435?v=4","gravatar_id":"","url":"https://api.github.com/users/kinfaikan","html_url":"https://github.com/kinfaikan","followers_url":"https://api.github.com/users/kinfaikan/followers","following_url":"https://api.github.com/users/kinfaikan/following{/other_user}","gists_url":"https://api.github.com/users/kinfaikan/gists{/gist_id}","starred_url":"https://api.github.com/users/kinfaikan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinfaikan/subscriptions","organizations_url":"https://api.github.com/users/kinfaikan/orgs","repos_url":"https://api.github.com/users/kinfaikan/repos","events_url":"https://api.github.com/users/kinfaikan/events{/privacy}","received_events_url":"https://api.github.com/users/kinfaikan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1015076088,"node_id":"MDU6TGFiZWwxMDE1MDc2MDg4","url":"https://api.github.com/repos/salesforce/TransmogrifAI/labels/cla:signed","name":"cla:signed","color":"5ebc41","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/salesforce/TransmogrifAI/pulls/130/commits","review_comments_url":"https://api.github.com/repos/salesforce/TransmogrifAI/pulls/130/comments","review_comment_url":"https://api.github.com/repos/salesforce/TransmogrifAI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salesforce/TransmogrifAI/issues/130/comments","statuses_url":"https://api.github.com/repos/salesforce/TransmogrifAI/statuses/f62c38d642a533ec6b5c0e00cec9953f7d17e9cc","head":{"label":"marcovivero:mv/datetime-rff","ref":"mv/datetime-rff","sha":"f62c38d642a533ec6b5c0e00cec9953f7d17e9cc","user":{"login":"marcovivero","id":8545381,"node_id":"MDQ6VXNlcjg1NDUzODE=","avatar_url":"https://avatars2.githubusercontent.com/u/8545381?v=4","gravatar_id":"","url":"https://api.github.com/users/marcovivero","html_url":"https://github.com/marcovivero","followers_url":"https://api.github.com/users/marcovivero/followers","following_url":"https://api.github.com/users/marcovivero/following{/other_user}","gists_url":"https://api.github.com/users/marcovivero/gists{/gist_id}","starred_url":"https://api.github.com/users/marcovivero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcovivero/subscriptions","organizations_url":"https://api.github.com/users/marcovivero/orgs","repos_url":"https://api.github.com/users/marcovivero/repos","events_url":"https://api.github.com/users/marcovivero/events{/privacy}","received_events_url":"https://api.github.com/users/marcovivero/received_events","type":"User","site_admin":false},"repo":{"id":146700604,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY3MDA2MDQ=","name":"TransmogrifAI-1","full_name":"marcovivero/TransmogrifAI-1","owner":{"login":"marcovivero","id":8545381,"node_id":"MDQ6VXNlcjg1NDUzODE=","avatar_url":"https://avatars2.githubusercontent.com/u/8545381?v=4","gravatar_id":"","url":"https://api.github.com/users/marcovivero","html_url":"https://github.com/marcovivero","followers_url":"https://api.github.com/users/marcovivero/followers","following_url":"https://api.github.com/users/marcovivero/following{/other_user}","gists_url":"https://api.github.com/users/marcovivero/gists{/gist_id}","starred_url":"https://api.github.com/users/marcovivero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcovivero/subscriptions","organizations_url":"https://api.github.com/users/marcovivero/orgs","repos_url":"https://api.github.com/users/marcovivero/repos","events_url":"https://api.github.com/users/marcovivero/events{/privacy}","received_events_url":"https://api.github.com/users/marcovivero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcovivero/TransmogrifAI-1","description":"TransmogrifAI (pronounced trăns-mŏgˈrə-fī) is an AutoML library for building modular, reusable, strongly typed machine learning workflows on Spark with minimal hand tuning","fork":true,"url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1","forks_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/forks","keys_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/teams","hooks_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/hooks","issue_events_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/issues/events{/number}","events_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/events","assignees_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/assignees{/user}","branches_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/branches{/branch}","tags_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/tags","blobs_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/statuses/{sha}","languages_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/languages","stargazers_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/stargazers","contributors_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/contributors","subscribers_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/subscribers","subscription_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/subscription","commits_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/contents/{+path}","compare_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/merges","archive_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/downloads","issues_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/issues{/number}","pulls_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/pulls{/number}","milestones_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/milestones{/number}","notifications_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/labels{/name}","releases_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/releases{/id}","deployments_url":"https://api.github.com/repos/marcovivero/TransmogrifAI-1/deployments","created_at":"2018-08-30T05:37:47Z","updated_at":"2018-09-06T20:24:03Z","pushed_at":"2018-09-13T00:04:34Z","git_url":"git://github.com/marcovivero/TransmogrifAI-1.git","ssh_url":"git@github.com:marcovivero/TransmogrifAI-1.git","clone_url":"https://github.com/marcovivero/TransmogrifAI-1.git","svn_url":"https://github.com/marcovivero/TransmogrifAI-1","homepage":"https://transmogrif.ai","size":111727,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"salesforce:master","ref":"master","sha":"078ea62e924c46e0a2118764c3c239669075a7dc","user":{"login":"salesforce","id":453694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MzY5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/453694?v=4","gravatar_id":"","url":"https://api.github.com/users/salesforce","html_url":"https://github.com/salesforce","followers_url":"https://api.github.com/users/salesforce/followers","following_url":"https://api.github.com/users/salesforce/following{/other_user}","gists_url":"https://api.github.com/users/salesforce/gists{/gist_id}","starred_url":"https://api.github.com/users/salesforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesforce/subscriptions","organizations_url":"https://api.github.com/users/salesforce/orgs","repos_url":"https://api.github.com/users/salesforce/repos","events_url":"https://api.github.com/users/salesforce/events{/privacy}","received_events_url":"https://api.github.com/users/salesforce/received_events","type":"Organization","site_admin":false},"repo":{"id":109289451,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkyODk0NTE=","name":"TransmogrifAI","full_name":"salesforce/TransmogrifAI","owner":{"login":"salesforce","id":453694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MzY5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/453694?v=4","gravatar_id":"","url":"https://api.github.com/users/salesforce","html_url":"https://github.com/salesforce","followers_url":"https://api.github.com/users/salesforce/followers","following_url":"https://api.github.com/users/salesforce/following{/other_user}","gists_url":"https://api.github.com/users/salesforce/gists{/gist_id}","starred_url":"https://api.github.com/users/salesforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesforce/subscriptions","organizations_url":"https://api.github.com/users/salesforce/orgs","repos_url":"https://api.github.com/users/salesforce/repos","events_url":"https://api.github.com/users/salesforce/events{/privacy}","received_events_url":"https://api.github.com/users/salesforce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salesforce/TransmogrifAI","description":"TransmogrifAI (pronounced trăns-mŏgˈrə-fī) is an AutoML library for building modular, reusable, strongly typed machine learning workflows on Spark with minimal hand tuning","fork":false,"url":"https://api.github.com/repos/salesforce/TransmogrifAI","forks_url":"https://api.github.com/repos/salesforce/TransmogrifAI/forks","keys_url":"https://api.github.com/repos/salesforce/TransmogrifAI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesforce/TransmogrifAI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesforce/TransmogrifAI/teams","hooks_url":"https://api.github.com/repos/salesforce/TransmogrifAI/hooks","issue_events_url":"https://api.github.com/repos/salesforce/TransmogrifAI/issues/events{/number}","events_url":"https://api.github.com/repos/salesforce/TransmogrifAI/events","assignees_url":"https://api.github.com/repos/salesforce/TransmogrifAI/assignees{/user}","branches_url":"https://api.github.com/repos/salesforce/TransmogrifAI/branches{/branch}","tags_url":"https://api.github.com/repos/salesforce/TransmogrifAI/tags","blobs_url":"https://api.github.com/repos/salesforce/TransmogrifAI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesforce/TransmogrifAI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesforce/TransmogrifAI/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesforce/TransmogrifAI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesforce/TransmogrifAI/statuses/{sha}","languages_url":"https://api.github.com/repos/salesforce/TransmogrifAI/languages","stargazers_url":"https://api.github.com/repos/salesforce/TransmogrifAI/stargazers","contributors_url":"https://api.github.com/repos/salesforce/TransmogrifAI/contributors","subscribers_url":"https://api.github.com/repos/salesforce/TransmogrifAI/subscribers","subscription_url":"https://api.github.com/repos/salesforce/TransmogrifAI/subscription","commits_url":"https://api.github.com/repos/salesforce/TransmogrifAI/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesforce/TransmogrifAI/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesforce/TransmogrifAI/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesforce/TransmogrifAI/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesforce/TransmogrifAI/contents/{+path}","compare_url":"https://api.github.com/repos/salesforce/TransmogrifAI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesforce/TransmogrifAI/merges","archive_url":"https://api.github.com/repos/salesforce/TransmogrifAI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesforce/TransmogrifAI/downloads","issues_url":"https://api.github.com/repos/salesforce/TransmogrifAI/issues{/number}","pulls_url":"https://api.github.com/repos/salesforce/TransmogrifAI/pulls{/number}","milestones_url":"https://api.github.com/repos/salesforce/TransmogrifAI/milestones{/number}","notifications_url":"https://api.github.com/repos/salesforce/TransmogrifAI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesforce/TransmogrifAI/labels{/name}","releases_url":"https://api.github.com/repos/salesforce/TransmogrifAI/releases{/id}","deployments_url":"https://api.github.com/repos/salesforce/TransmogrifAI/deployments","created_at":"2017-11-02T16:15:15Z","updated_at":"2018-09-13T03:07:01Z","pushed_at":"2018-09-13T03:07:01Z","git_url":"git://github.com/salesforce/TransmogrifAI.git","ssh_url":"git@github.com:salesforce/TransmogrifAI.git","clone_url":"https://github.com/salesforce/TransmogrifAI.git","svn_url":"https://github.com/salesforce/TransmogrifAI","homepage":"https://transmogrif.ai","size":111792,"stargazers_count":827,"watchers_count":827,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":112,"open_issues":17,"watchers":827,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salesforce/TransmogrifAI/pulls/130"},"html":{"href":"https://github.com/salesforce/TransmogrifAI/pull/130"},"issue":{"href":"https://api.github.com/repos/salesforce/TransmogrifAI/issues/130"},"comments":{"href":"https://api.github.com/repos/salesforce/TransmogrifAI/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/salesforce/TransmogrifAI/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/salesforce/TransmogrifAI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salesforce/TransmogrifAI/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/salesforce/TransmogrifAI/statuses/f62c38d642a533ec6b5c0e00cec9953f7d17e9cc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tovbinm"}}