{"action":"opened","number":18312,"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/18312","id":180113801,"html_url":"https://github.com/tensorflow/tensorflow/pull/18312","diff_url":"https://github.com/tensorflow/tensorflow/pull/18312.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/18312.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/18312","number":18312,"state":"open","locked":false,"title":"Support CMake options to use external package providers like zlib, GRPC, Eigen","user":{"login":"imsheridan","id":1680977,"avatar_url":"https://avatars3.githubusercontent.com/u/1680977?v=4","gravatar_id":"","url":"https://api.github.com/users/imsheridan","html_url":"https://github.com/imsheridan","followers_url":"https://api.github.com/users/imsheridan/followers","following_url":"https://api.github.com/users/imsheridan/following{/other_user}","gists_url":"https://api.github.com/users/imsheridan/gists{/gist_id}","starred_url":"https://api.github.com/users/imsheridan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imsheridan/subscriptions","organizations_url":"https://api.github.com/users/imsheridan/orgs","repos_url":"https://api.github.com/users/imsheridan/repos","events_url":"https://api.github.com/users/imsheridan/events{/privacy}","received_events_url":"https://api.github.com/users/imsheridan/received_events","type":"User","site_admin":false},"body":"This PR is to add the ability to use external package providers like GRPC, zlib, Eigen .etc. It is not possible to compile project using two different versions of protobuf right now.\r\n\r\nThis is a continuous work of PR #16210. As discussed [there](https://github.com/tensorflow/tensorflow/pull/13867#issuecomment-339789050), it did something similar to GRPC package whether you specify tensorflow__PROVIDER variable. It will determine if tensorflow needs to download dependency and use it as a module or use find_package() to find package.\r\n> Add ability to use external GRPC, zlib, Eigen and mb some other packages. Because right now it is impossible to compile your project with tensorflow if you're using different version of GRPC. I did something similar to GRPC package whether you specify tensorflow__PROVIDER variable. It will determine if tensorflow needs to download dependency and use it as a module or use find_package() to find package.","created_at":"2018-04-07T16:41:32Z","updated_at":"2018-04-07T16:41:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/18312/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/18312/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/18312/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/caaad05e5a3308b280a425be920a48fd8e54dcf8","head":{"label":"imsheridan:support_external_providers","ref":"support_external_providers","sha":"caaad05e5a3308b280a425be920a48fd8e54dcf8","user":{"login":"imsheridan","id":1680977,"avatar_url":"https://avatars3.githubusercontent.com/u/1680977?v=4","gravatar_id":"","url":"https://api.github.com/users/imsheridan","html_url":"https://github.com/imsheridan","followers_url":"https://api.github.com/users/imsheridan/followers","following_url":"https://api.github.com/users/imsheridan/following{/other_user}","gists_url":"https://api.github.com/users/imsheridan/gists{/gist_id}","starred_url":"https://api.github.com/users/imsheridan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imsheridan/subscriptions","organizations_url":"https://api.github.com/users/imsheridan/orgs","repos_url":"https://api.github.com/users/imsheridan/repos","events_url":"https://api.github.com/users/imsheridan/events{/privacy}","received_events_url":"https://api.github.com/users/imsheridan/received_events","type":"User","site_admin":false},"repo":{"id":119723239,"name":"tensorflow","full_name":"imsheridan/tensorflow","owner":{"login":"imsheridan","id":1680977,"avatar_url":"https://avatars3.githubusercontent.com/u/1680977?v=4","gravatar_id":"","url":"https://api.github.com/users/imsheridan","html_url":"https://github.com/imsheridan","followers_url":"https://api.github.com/users/imsheridan/followers","following_url":"https://api.github.com/users/imsheridan/following{/other_user}","gists_url":"https://api.github.com/users/imsheridan/gists{/gist_id}","starred_url":"https://api.github.com/users/imsheridan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imsheridan/subscriptions","organizations_url":"https://api.github.com/users/imsheridan/orgs","repos_url":"https://api.github.com/users/imsheridan/repos","events_url":"https://api.github.com/users/imsheridan/events{/privacy}","received_events_url":"https://api.github.com/users/imsheridan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imsheridan/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/imsheridan/tensorflow","forks_url":"https://api.github.com/repos/imsheridan/tensorflow/forks","keys_url":"https://api.github.com/repos/imsheridan/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imsheridan/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imsheridan/tensorflow/teams","hooks_url":"https://api.github.com/repos/imsheridan/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/imsheridan/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/imsheridan/tensorflow/events","assignees_url":"https://api.github.com/repos/imsheridan/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/imsheridan/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/imsheridan/tensorflow/tags","blobs_url":"https://api.github.com/repos/imsheridan/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imsheridan/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imsheridan/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/imsheridan/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imsheridan/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/imsheridan/tensorflow/languages","stargazers_url":"https://api.github.com/repos/imsheridan/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/imsheridan/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/imsheridan/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/imsheridan/tensorflow/subscription","commits_url":"https://api.github.com/repos/imsheridan/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/imsheridan/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/imsheridan/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/imsheridan/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/imsheridan/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/imsheridan/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imsheridan/tensorflow/merges","archive_url":"https://api.github.com/repos/imsheridan/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imsheridan/tensorflow/downloads","issues_url":"https://api.github.com/repos/imsheridan/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/imsheridan/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/imsheridan/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/imsheridan/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imsheridan/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/imsheridan/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/imsheridan/tensorflow/deployments","created_at":"2018-01-31T18:00:18Z","updated_at":"2018-04-03T09:19:16Z","pushed_at":"2018-04-07T16:27:15Z","git_url":"git://github.com/imsheridan/tensorflow.git","ssh_url":"git@github.com:imsheridan/tensorflow.git","clone_url":"https://github.com/imsheridan/tensorflow.git","svn_url":"https://github.com/imsheridan/tensorflow","homepage":"https://tensorflow.org","size":158671,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"b874783ccdf4cc36cb3546e6b6a998cb8f3470bb","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"name":"tensorflow","full_name":"tensorflow/tensorflow","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2018-04-07T16:34:25Z","pushed_at":"2018-04-07T13:42:22Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"https://tensorflow.org","size":159344,"stargazers_count":95337,"watchers_count":95337,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60864,"mirror_url":null,"archived":false,"open_issues_count":1488,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":60864,"open_issues":1488,"watchers":95337,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/18312"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/18312"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/18312"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/18312/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/18312/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/18312/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/caaad05e5a3308b280a425be920a48fd8e54dcf8"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":531,"deletions":344,"changed_files":15}}
{"actor":{"display_login":"imsheridan"}}