{"action":"created","issue":{"url":"https://api.github.com/repos/pantsbuild/pants/issues/4867","repository_url":"https://api.github.com/repos/pantsbuild/pants","labels_url":"https://api.github.com/repos/pantsbuild/pants/issues/4867/labels{/name}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/4867/comments","events_url":"https://api.github.com/repos/pantsbuild/pants/issues/4867/events","html_url":"https://github.com/pantsbuild/pants/pull/4867","id":257516470,"number":4867,"title":"Port BaseTest to v2 engine","user":{"login":"stuhood","id":46740,"avatar_url":"https://avatars1.githubusercontent.com/u/46740?v=4","gravatar_id":"","url":"https://api.github.com/users/stuhood","html_url":"https://github.com/stuhood","followers_url":"https://api.github.com/users/stuhood/followers","following_url":"https://api.github.com/users/stuhood/following{/other_user}","gists_url":"https://api.github.com/users/stuhood/gists{/gist_id}","starred_url":"https://api.github.com/users/stuhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuhood/subscriptions","organizations_url":"https://api.github.com/users/stuhood/orgs","repos_url":"https://api.github.com/users/stuhood/repos","events_url":"https://api.github.com/users/stuhood/events{/privacy}","received_events_url":"https://api.github.com/users/stuhood/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-09-13T20:48:47Z","updated_at":"2018-03-07T08:16:04Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/4867","html_url":"https://github.com/pantsbuild/pants/pull/4867","diff_url":"https://github.com/pantsbuild/pants/pull/4867.diff","patch_url":"https://github.com/pantsbuild/pants/pull/4867.patch"},"body":"### Problem\r\n\r\nThe `v2` engine is now enabled by default as the backend for `BUILD` file parsing and file fingerprinting, but due to test-specific setup referencing legacy code paths, all unit tests still use `v1`.\r\n\r\nAdditionally, there has been a longstanding TODO about renaming `BaseTest` to `TestBase`.\r\n\r\n### Solution\r\n\r\nAdd `TestBase` which uses `v2` code paths, deprecate `BaseTest` (which continues to use `v1`), and migrate the vast majority of tests to `TestBase`.\r\n\r\n### Result\r\n\r\nUsers will have a deprecation cycle to port from `BaseTest` to `TestBase` and take on the relatively minor behaviour changes that come along with that."},"comment":{"url":"https://api.github.com/repos/pantsbuild/pants/issues/comments/371058741","html_url":"https://github.com/pantsbuild/pants/pull/4867#issuecomment-371058741","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/4867","id":371058741,"user":{"login":"stuhood","id":46740,"avatar_url":"https://avatars1.githubusercontent.com/u/46740?v=4","gravatar_id":"","url":"https://api.github.com/users/stuhood","html_url":"https://github.com/stuhood","followers_url":"https://api.github.com/users/stuhood/followers","following_url":"https://api.github.com/users/stuhood/following{/other_user}","gists_url":"https://api.github.com/users/stuhood/gists{/gist_id}","starred_url":"https://api.github.com/users/stuhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuhood/subscriptions","organizations_url":"https://api.github.com/users/stuhood/orgs","repos_url":"https://api.github.com/users/stuhood/repos","events_url":"https://api.github.com/users/stuhood/events{/privacy}","received_events_url":"https://api.github.com/users/stuhood/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T08:16:04Z","updated_at":"2018-03-07T08:16:04Z","author_association":"OWNER","body":"Fixed title."}}
{"actor":{"display_login":"stuhood"}}