{"action":"created","issue":{"url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/695","repository_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet","labels_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/695/labels{/name}","comments_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/695/comments","events_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/695/events","html_url":"https://github.com/ArkEcosystem/desktop-wallet/pull/695","id":389228779,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MjYzNzk3","number":695,"title":"Bug: Fix sorting of Wallet Transactions","user":{"login":"kalgoop","id":17824093,"node_id":"MDQ6VXNlcjE3ODI0MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/17824093?v=4","gravatar_id":"","url":"https://api.github.com/users/kalgoop","html_url":"https://github.com/kalgoop","followers_url":"https://api.github.com/users/kalgoop/followers","following_url":"https://api.github.com/users/kalgoop/following{/other_user}","gists_url":"https://api.github.com/users/kalgoop/gists{/gist_id}","starred_url":"https://api.github.com/users/kalgoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalgoop/subscriptions","organizations_url":"https://api.github.com/users/kalgoop/orgs","repos_url":"https://api.github.com/users/kalgoop/repos","events_url":"https://api.github.com/users/kalgoop/events{/privacy}","received_events_url":"https://api.github.com/users/kalgoop/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-10T10:14:08Z","updated_at":"2018-12-10T10:30:25Z","closed_at":"2018-12-10T10:26:28Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/pulls/695","html_url":"https://github.com/ArkEcosystem/desktop-wallet/pull/695","diff_url":"https://github.com/ArkEcosystem/desktop-wallet/pull/695.diff","patch_url":"https://github.com/ArkEcosystem/desktop-wallet/pull/695.patch"},"body":"Sorting by different columns wasn't working correctly earlier.\r\nThis PR fixes the same.\r\n\r\n## Proposed changes\r\n<!--\r\nDescribe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.\r\n-->\r\n- arguments have been corrected for the onSortChange\r\n- __sortTransaction function added\r\n- __sortTransaction called from fetchTransactions\r\n\r\n## Types of changes\r\n<!--\r\nWhat types of changes does your code introduce?\r\n_Put an `x` in the boxes that apply and remove the rest of them: keep this PR as concise, but descriptive, as possible.._\r\n-->\r\n\r\n- [x] Bugfix (non-breaking change which fixes an issue)\r\n\r\n## Checklist\r\n<!--\r\n_Put an `x` in the boxes that apply and remove this text and the rest of them. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._\r\n-->\r\n\r\n- [x] I have read the [CONTRIBUTING](https://docs.ark.io/guidebook/contribution-guidelines/contributing.html) documentation\r\n- [x] Lint and unit tests pass locally with my changes\r\n<!--\r\n\r\n## Further comments\r\n\r\nIf this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/comments/445766650","html_url":"https://github.com/ArkEcosystem/desktop-wallet/pull/695#issuecomment-445766650","issue_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/695","id":445766650,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTc2NjY1MA==","user":{"login":"kalgoop","id":17824093,"node_id":"MDQ6VXNlcjE3ODI0MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/17824093?v=4","gravatar_id":"","url":"https://api.github.com/users/kalgoop","html_url":"https://github.com/kalgoop","followers_url":"https://api.github.com/users/kalgoop/followers","following_url":"https://api.github.com/users/kalgoop/following{/other_user}","gists_url":"https://api.github.com/users/kalgoop/gists{/gist_id}","starred_url":"https://api.github.com/users/kalgoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalgoop/subscriptions","organizations_url":"https://api.github.com/users/kalgoop/orgs","repos_url":"https://api.github.com/users/kalgoop/repos","events_url":"https://api.github.com/users/kalgoop/events{/privacy}","received_events_url":"https://api.github.com/users/kalgoop/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T10:30:25Z","updated_at":"2018-12-10T10:30:25Z","author_association":"NONE","body":"1. Oh. Didn't know about it.\r\n2. Didn't realize earlier that transaction table too had the same problem. (when I made PR for delegate table)"}}
{"actor":{"display_login":"kalgoop"}}