{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/182796519","pull_request_review_id":113668550,"id":182796519,"diff_hunk":"@@ -37,7 +37,7 @@ def UnStre(self, request, context):\n         if _application_common.UNARY_STREAM_REQUEST != request:\n             context.set_code(grpc.StatusCode.INVALID_ARGUMENT)\n             context.set_details('Something is wrong with your request!')\n-        return\n+            return","path":"src/python/grpcio_tests/tests/testing/_server_application.py","position":5,"original_position":5,"commit_id":"d121f802fe8990a3390e9974b413a9b218ad1b22","original_commit_id":"d121f802fe8990a3390e9974b413a9b218ad1b22","user":{"login":"mehrdada","id":900411,"avatar_url":"https://avatars3.githubusercontent.com/u/900411?v=4","gravatar_id":"","url":"https://api.github.com/users/mehrdada","html_url":"https://github.com/mehrdada","followers_url":"https://api.github.com/users/mehrdada/followers","following_url":"https://api.github.com/users/mehrdada/following{/other_user}","gists_url":"https://api.github.com/users/mehrdada/gists{/gist_id}","starred_url":"https://api.github.com/users/mehrdada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehrdada/subscriptions","organizations_url":"https://api.github.com/users/mehrdada/orgs","repos_url":"https://api.github.com/users/mehrdada/repos","events_url":"https://api.github.com/users/mehrdada/events{/privacy}","received_events_url":"https://api.github.com/users/mehrdada/received_events","type":"User","site_admin":false},"body":"Yes, it does change the behavior of the test. My sense is the new behavior is the intended one, i.e. the test was buggy before. Don't you agree?","created_at":"2018-04-19T15:52:33Z","updated_at":"2018-04-19T15:52:33Z","html_url":"https://github.com/grpc/grpc/pull/15113#discussion_r182796519","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/15113","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/182796519"},"html":{"href":"https://github.com/grpc/grpc/pull/15113#discussion_r182796519"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/15113"}},"in_reply_to_id":182783216},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/15113","id":182644361,"html_url":"https://github.com/grpc/grpc/pull/15113","diff_url":"https://github.com/grpc/grpc/pull/15113.diff","patch_url":"https://github.com/grpc/grpc/pull/15113.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/15113","number":15113,"state":"open","locked":false,"title":"Eliminate some of the more esoteric pylint suppressions for tests","user":{"login":"mehrdada","id":900411,"avatar_url":"https://avatars3.githubusercontent.com/u/900411?v=4","gravatar_id":"","url":"https://api.github.com/users/mehrdada","html_url":"https://github.com/mehrdada","followers_url":"https://api.github.com/users/mehrdada/followers","following_url":"https://api.github.com/users/mehrdada/following{/other_user}","gists_url":"https://api.github.com/users/mehrdada/gists{/gist_id}","starred_url":"https://api.github.com/users/mehrdada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehrdada/subscriptions","organizations_url":"https://api.github.com/users/mehrdada/orgs","repos_url":"https://api.github.com/users/mehrdada/repos","events_url":"https://api.github.com/users/mehrdada/events{/privacy}","received_events_url":"https://api.github.com/users/mehrdada/received_events","type":"User","site_admin":false},"body":"Progress toward #261 on `grpc-tests` package starting by the most dangerous and rare suppressions. PR contains actual bugfixes.","created_at":"2018-04-19T01:36:20Z","updated_at":"2018-04-19T15:52:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e95682a35a9a7ec94e91d2e659a480eda4b64c3d","assignee":{"login":"nathanielmanistaatgoogle","id":10131044,"avatar_url":"https://avatars0.githubusercontent.com/u/10131044?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanielmanistaatgoogle","html_url":"https://github.com/nathanielmanistaatgoogle","followers_url":"https://api.github.com/users/nathanielmanistaatgoogle/followers","following_url":"https://api.github.com/users/nathanielmanistaatgoogle/following{/other_user}","gists_url":"https://api.github.com/users/nathanielmanistaatgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielmanistaatgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielmanistaatgoogle/subscriptions","organizations_url":"https://api.github.com/users/nathanielmanistaatgoogle/orgs","repos_url":"https://api.github.com/users/nathanielmanistaatgoogle/repos","events_url":"https://api.github.com/users/nathanielmanistaatgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielmanistaatgoogle/received_events","type":"User","site_admin":false},"assignees":[{"login":"nathanielmanistaatgoogle","id":10131044,"avatar_url":"https://avatars0.githubusercontent.com/u/10131044?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanielmanistaatgoogle","html_url":"https://github.com/nathanielmanistaatgoogle","followers_url":"https://api.github.com/users/nathanielmanistaatgoogle/followers","following_url":"https://api.github.com/users/nathanielmanistaatgoogle/following{/other_user}","gists_url":"https://api.github.com/users/nathanielmanistaatgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielmanistaatgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielmanistaatgoogle/subscriptions","organizations_url":"https://api.github.com/users/nathanielmanistaatgoogle/orgs","repos_url":"https://api.github.com/users/nathanielmanistaatgoogle/repos","events_url":"https://api.github.com/users/nathanielmanistaatgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielmanistaatgoogle/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":218696110,"url":"https://api.github.com/repos/grpc/grpc/labels/area/test","name":"area/test","color":"efdb40","default":false},{"id":168238186,"url":"https://api.github.com/repos/grpc/grpc/labels/lang/Python","name":"lang/Python","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/15113/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/15113/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/15113/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/d121f802fe8990a3390e9974b413a9b218ad1b22","head":{"label":"mehrdada:pylint-tests-1","ref":"pylint-tests-1","sha":"d121f802fe8990a3390e9974b413a9b218ad1b22","user":{"login":"mehrdada","id":900411,"avatar_url":"https://avatars3.githubusercontent.com/u/900411?v=4","gravatar_id":"","url":"https://api.github.com/users/mehrdada","html_url":"https://github.com/mehrdada","followers_url":"https://api.github.com/users/mehrdada/followers","following_url":"https://api.github.com/users/mehrdada/following{/other_user}","gists_url":"https://api.github.com/users/mehrdada/gists{/gist_id}","starred_url":"https://api.github.com/users/mehrdada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehrdada/subscriptions","organizations_url":"https://api.github.com/users/mehrdada/orgs","repos_url":"https://api.github.com/users/mehrdada/repos","events_url":"https://api.github.com/users/mehrdada/events{/privacy}","received_events_url":"https://api.github.com/users/mehrdada/received_events","type":"User","site_admin":false},"repo":{"id":85543644,"name":"grpc","full_name":"mehrdada/grpc","owner":{"login":"mehrdada","id":900411,"avatar_url":"https://avatars3.githubusercontent.com/u/900411?v=4","gravatar_id":"","url":"https://api.github.com/users/mehrdada","html_url":"https://github.com/mehrdada","followers_url":"https://api.github.com/users/mehrdada/followers","following_url":"https://api.github.com/users/mehrdada/following{/other_user}","gists_url":"https://api.github.com/users/mehrdada/gists{/gist_id}","starred_url":"https://api.github.com/users/mehrdada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehrdada/subscriptions","organizations_url":"https://api.github.com/users/mehrdada/orgs","repos_url":"https://api.github.com/users/mehrdada/repos","events_url":"https://api.github.com/users/mehrdada/events{/privacy}","received_events_url":"https://api.github.com/users/mehrdada/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mehrdada/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/mehrdada/grpc","forks_url":"https://api.github.com/repos/mehrdada/grpc/forks","keys_url":"https://api.github.com/repos/mehrdada/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mehrdada/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mehrdada/grpc/teams","hooks_url":"https://api.github.com/repos/mehrdada/grpc/hooks","issue_events_url":"https://api.github.com/repos/mehrdada/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/mehrdada/grpc/events","assignees_url":"https://api.github.com/repos/mehrdada/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/mehrdada/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/mehrdada/grpc/tags","blobs_url":"https://api.github.com/repos/mehrdada/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mehrdada/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mehrdada/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mehrdada/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mehrdada/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/mehrdada/grpc/languages","stargazers_url":"https://api.github.com/repos/mehrdada/grpc/stargazers","contributors_url":"https://api.github.com/repos/mehrdada/grpc/contributors","subscribers_url":"https://api.github.com/repos/mehrdada/grpc/subscribers","subscription_url":"https://api.github.com/repos/mehrdada/grpc/subscription","commits_url":"https://api.github.com/repos/mehrdada/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mehrdada/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mehrdada/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mehrdada/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mehrdada/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/mehrdada/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mehrdada/grpc/merges","archive_url":"https://api.github.com/repos/mehrdada/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mehrdada/grpc/downloads","issues_url":"https://api.github.com/repos/mehrdada/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/mehrdada/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/mehrdada/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/mehrdada/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mehrdada/grpc/labels{/name}","releases_url":"https://api.github.com/repos/mehrdada/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/mehrdada/grpc/deployments","created_at":"2017-03-20T06:42:28Z","updated_at":"2017-10-05T21:08:08Z","pushed_at":"2018-04-19T14:57:41Z","git_url":"git://github.com/mehrdada/grpc.git","ssh_url":"git@github.com:mehrdada/grpc.git","clone_url":"https://github.com/mehrdada/grpc.git","svn_url":"https://github.com/mehrdada/grpc","homepage":"","size":154624,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"66fc0b578ef3ed1b5c8ec0459faeed2e54f1c231","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2018-04-19T14:58:36Z","pushed_at":"2018-04-19T15:23:06Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"https://grpc.io","size":176984,"stargazers_count":14830,"watchers_count":14830,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":3301,"mirror_url":null,"archived":false,"open_issues_count":1224,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3301,"open_issues":1224,"watchers":14830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/15113"},"html":{"href":"https://github.com/grpc/grpc/pull/15113"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/15113"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/15113/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/15113/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/15113/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/d121f802fe8990a3390e9974b413a9b218ad1b22"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mehrdada"}}