{"action":"opened","number":244,"pull_request":{"url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/244","id":213403179,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDAzMTc5","html_url":"https://github.com/Microsoft/VFSForGit/pull/244","diff_url":"https://github.com/Microsoft/VFSForGit/pull/244.diff","patch_url":"https://github.com/Microsoft/VFSForGit/pull/244.patch","issue_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/244","number":244,"state":"open","locked":false,"title":"Mac: Fixed a SocketException that was preventing clone from running prefetch and mount","user":{"login":"sanoursa","id":8729434,"node_id":"MDQ6VXNlcjg3Mjk0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8729434?v=4","gravatar_id":"","url":"https://api.github.com/users/sanoursa","html_url":"https://github.com/sanoursa","followers_url":"https://api.github.com/users/sanoursa/followers","following_url":"https://api.github.com/users/sanoursa/following{/other_user}","gists_url":"https://api.github.com/users/sanoursa/gists{/gist_id}","starred_url":"https://api.github.com/users/sanoursa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanoursa/subscriptions","organizations_url":"https://api.github.com/users/sanoursa/orgs","repos_url":"https://api.github.com/users/sanoursa/repos","events_url":"https://api.github.com/users/sanoursa/events{/privacy}","received_events_url":"https://api.github.com/users/sanoursa/received_events","type":"User","site_admin":false},"body":"It turns out there are two underlying bugs here:\r\n* When we dispose a `NamedPipeServerStream`, it immediately calls our callback, and then calling `EndWaitForConnection` seems to throw different exceptions on Windows than on Mac.\r\n* The `SocketException` that gets thrown on Mac triggers the unhandled exception handler, however this was happening after the tracer was already disposed, and so our attempt to log the exception was a noop, making it easier for this exception to hide.\r\n\r\nI updated the tracer to throw if you write to it after it is disposed, and also updated the callback to early exit if we've already disposed the `NamedPipeServer`.\r\n\r\nStill TBD:\r\n* Can we now remove the `ObjectDisposedException` handler that was previously there to handle this scenario on Windows?\r\n* Why are no functional tests failing? Our functional tests always call clone with `--no-prefetch --no-mount` flags, but even so clone should have been failing with a non-zero error code.","created_at":"2018-09-05T19:30:37Z","updated_at":"2018-09-05T19:30:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/244/commits","review_comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/244/comments","review_comment_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/244/comments","statuses_url":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/dc4a5f6075f2b23a4c4b0091e85c26b6bafb387f","head":{"label":"sanoursa:socketexception","ref":"socketexception","sha":"dc4a5f6075f2b23a4c4b0091e85c26b6bafb387f","user":{"login":"sanoursa","id":8729434,"node_id":"MDQ6VXNlcjg3Mjk0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8729434?v=4","gravatar_id":"","url":"https://api.github.com/users/sanoursa","html_url":"https://github.com/sanoursa","followers_url":"https://api.github.com/users/sanoursa/followers","following_url":"https://api.github.com/users/sanoursa/following{/other_user}","gists_url":"https://api.github.com/users/sanoursa/gists{/gist_id}","starred_url":"https://api.github.com/users/sanoursa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanoursa/subscriptions","organizations_url":"https://api.github.com/users/sanoursa/orgs","repos_url":"https://api.github.com/users/sanoursa/repos","events_url":"https://api.github.com/users/sanoursa/events{/privacy}","received_events_url":"https://api.github.com/users/sanoursa/received_events","type":"User","site_admin":false},"repo":{"id":142062302,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwNjIzMDI=","name":"VFSForGit","full_name":"sanoursa/VFSForGit","owner":{"login":"sanoursa","id":8729434,"node_id":"MDQ6VXNlcjg3Mjk0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8729434?v=4","gravatar_id":"","url":"https://api.github.com/users/sanoursa","html_url":"https://github.com/sanoursa","followers_url":"https://api.github.com/users/sanoursa/followers","following_url":"https://api.github.com/users/sanoursa/following{/other_user}","gists_url":"https://api.github.com/users/sanoursa/gists{/gist_id}","starred_url":"https://api.github.com/users/sanoursa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanoursa/subscriptions","organizations_url":"https://api.github.com/users/sanoursa/orgs","repos_url":"https://api.github.com/users/sanoursa/repos","events_url":"https://api.github.com/users/sanoursa/events{/privacy}","received_events_url":"https://api.github.com/users/sanoursa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sanoursa/VFSForGit","description":"Virtual File System for Git: Enable Git at Enterprise Scale","fork":true,"url":"https://api.github.com/repos/sanoursa/VFSForGit","forks_url":"https://api.github.com/repos/sanoursa/VFSForGit/forks","keys_url":"https://api.github.com/repos/sanoursa/VFSForGit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sanoursa/VFSForGit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sanoursa/VFSForGit/teams","hooks_url":"https://api.github.com/repos/sanoursa/VFSForGit/hooks","issue_events_url":"https://api.github.com/repos/sanoursa/VFSForGit/issues/events{/number}","events_url":"https://api.github.com/repos/sanoursa/VFSForGit/events","assignees_url":"https://api.github.com/repos/sanoursa/VFSForGit/assignees{/user}","branches_url":"https://api.github.com/repos/sanoursa/VFSForGit/branches{/branch}","tags_url":"https://api.github.com/repos/sanoursa/VFSForGit/tags","blobs_url":"https://api.github.com/repos/sanoursa/VFSForGit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sanoursa/VFSForGit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sanoursa/VFSForGit/git/refs{/sha}","trees_url":"https://api.github.com/repos/sanoursa/VFSForGit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sanoursa/VFSForGit/statuses/{sha}","languages_url":"https://api.github.com/repos/sanoursa/VFSForGit/languages","stargazers_url":"https://api.github.com/repos/sanoursa/VFSForGit/stargazers","contributors_url":"https://api.github.com/repos/sanoursa/VFSForGit/contributors","subscribers_url":"https://api.github.com/repos/sanoursa/VFSForGit/subscribers","subscription_url":"https://api.github.com/repos/sanoursa/VFSForGit/subscription","commits_url":"https://api.github.com/repos/sanoursa/VFSForGit/commits{/sha}","git_commits_url":"https://api.github.com/repos/sanoursa/VFSForGit/git/commits{/sha}","comments_url":"https://api.github.com/repos/sanoursa/VFSForGit/comments{/number}","issue_comment_url":"https://api.github.com/repos/sanoursa/VFSForGit/issues/comments{/number}","contents_url":"https://api.github.com/repos/sanoursa/VFSForGit/contents/{+path}","compare_url":"https://api.github.com/repos/sanoursa/VFSForGit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sanoursa/VFSForGit/merges","archive_url":"https://api.github.com/repos/sanoursa/VFSForGit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sanoursa/VFSForGit/downloads","issues_url":"https://api.github.com/repos/sanoursa/VFSForGit/issues{/number}","pulls_url":"https://api.github.com/repos/sanoursa/VFSForGit/pulls{/number}","milestones_url":"https://api.github.com/repos/sanoursa/VFSForGit/milestones{/number}","notifications_url":"https://api.github.com/repos/sanoursa/VFSForGit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sanoursa/VFSForGit/labels{/name}","releases_url":"https://api.github.com/repos/sanoursa/VFSForGit/releases{/id}","deployments_url":"https://api.github.com/repos/sanoursa/VFSForGit/deployments","created_at":"2018-07-23T19:52:26Z","updated_at":"2018-09-05T19:24:44Z","pushed_at":"2018-09-05T19:24:43Z","git_url":"git://github.com/sanoursa/VFSForGit.git","ssh_url":"git@github.com:sanoursa/VFSForGit.git","clone_url":"https://github.com/sanoursa/VFSForGit.git","svn_url":"https://github.com/sanoursa/VFSForGit","homepage":"https://gvfs.io/","size":2521,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"69c36fda3e70371d671e7cfad5f28e178885f174","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":80058269,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA1ODI2OQ==","name":"VFSForGit","full_name":"Microsoft/VFSForGit","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/VFSForGit","description":"Virtual File System for Git: Enable Git at Enterprise Scale","fork":false,"url":"https://api.github.com/repos/Microsoft/VFSForGit","forks_url":"https://api.github.com/repos/Microsoft/VFSForGit/forks","keys_url":"https://api.github.com/repos/Microsoft/VFSForGit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/VFSForGit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/VFSForGit/teams","hooks_url":"https://api.github.com/repos/Microsoft/VFSForGit/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/VFSForGit/events","assignees_url":"https://api.github.com/repos/Microsoft/VFSForGit/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/VFSForGit/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/VFSForGit/tags","blobs_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/VFSForGit/languages","stargazers_url":"https://api.github.com/repos/Microsoft/VFSForGit/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/VFSForGit/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/VFSForGit/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/VFSForGit/subscription","commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/VFSForGit/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/VFSForGit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/VFSForGit/merges","archive_url":"https://api.github.com/repos/Microsoft/VFSForGit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/VFSForGit/downloads","issues_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/VFSForGit/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/VFSForGit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/VFSForGit/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/VFSForGit/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/VFSForGit/deployments","created_at":"2017-01-25T21:10:29Z","updated_at":"2018-09-05T17:51:55Z","pushed_at":"2018-09-05T17:20:53Z","git_url":"git://github.com/Microsoft/VFSForGit.git","ssh_url":"git@github.com:Microsoft/VFSForGit.git","clone_url":"https://github.com/Microsoft/VFSForGit.git","svn_url":"https://github.com/Microsoft/VFSForGit","homepage":"https://gvfs.io/","size":2647,"stargazers_count":4315,"watchers_count":4315,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":273,"open_issues":76,"watchers":4315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/244"},"html":{"href":"https://github.com/Microsoft/VFSForGit/pull/244"},"issue":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/issues/244"},"comments":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/dc4a5f6075f2b23a4c4b0091e85c26b6bafb387f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":19,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"sanoursa"}}