{"action":"created","comment":{"url":"https://api.github.com/repos/SpareBank1/designsystem/pulls/comments/232644983","pull_request_review_id":173884065,"id":232644983,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjY0NDk4Mw==","diff_hunk":"@@ -0,0 +1,49 @@\n+Ikonkort er kort med en gitt maksbredde og et venstrestilt ikon.\n+Den tilbyr alle underkomponenter (CardName, Title, Subtext og Text) og plasserer dem i\n+gitt rekkefølge nedover i kortet, med teksten venstrestilt, til høyere for ikonet.\n+\n+```jsx\n+const { GrafOppIkon } = require('../../../ffe-icons-react');\n+\n+<React.Fragment>\n+    <IconCard icon={<GrafOppIkon />}>\n+        {({ CardName, Title, Subtext, Text }) => (\n+            <React.Fragment>\n+                <CardName>Kortnavn</CardName>\n+                <Title>Tittel</Title>\n+                <Subtext>En liten undertekst</Subtext>\n+                <Text>Her kan man ha tekst</Text>\n+            </React.Fragment>\n+        )}\n+    </IconCard>\n+</React.Fragment>;\n+```","path":"packages/ffe-cards-react/src/IconCard/IconCard.md","position":18,"original_position":20,"commit_id":"1e37065ae63562d83726657edb891009473e8258","original_commit_id":"8233b11be33f6152d19874ad28cfb2fecc3eebeb","user":{"login":"selbekk","id":1307267,"node_id":"MDQ6VXNlcjEzMDcyNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1307267?v=4","gravatar_id":"","url":"https://api.github.com/users/selbekk","html_url":"https://github.com/selbekk","followers_url":"https://api.github.com/users/selbekk/followers","following_url":"https://api.github.com/users/selbekk/following{/other_user}","gists_url":"https://api.github.com/users/selbekk/gists{/gist_id}","starred_url":"https://api.github.com/users/selbekk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selbekk/subscriptions","organizations_url":"https://api.github.com/users/selbekk/orgs","repos_url":"https://api.github.com/users/selbekk/repos","events_url":"https://api.github.com/users/selbekk/events{/privacy}","received_events_url":"https://api.github.com/users/selbekk/received_events","type":"User","site_admin":false},"body":"Ta en runde på alle eksemplene, var et par steder til det kunne blitt fjerna :) ","created_at":"2018-11-12T12:49:47Z","updated_at":"2018-11-12T12:49:47Z","html_url":"https://github.com/SpareBank1/designsystem/pull/505#discussion_r232644983","pull_request_url":"https://api.github.com/repos/SpareBank1/designsystem/pulls/505","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SpareBank1/designsystem/pulls/comments/232644983"},"html":{"href":"https://github.com/SpareBank1/designsystem/pull/505#discussion_r232644983"},"pull_request":{"href":"https://api.github.com/repos/SpareBank1/designsystem/pulls/505"}},"in_reply_to_id":232642038},"pull_request":{"url":"https://api.github.com/repos/SpareBank1/designsystem/pulls/505","id":230116865,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTE2ODY1","html_url":"https://github.com/SpareBank1/designsystem/pull/505","diff_url":"https://github.com/SpareBank1/designsystem/pull/505.diff","patch_url":"https://github.com/SpareBank1/designsystem/pull/505.patch","issue_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/505","number":505,"state":"open","locked":false,"title":"Feature/some kind of card","user":{"login":"henrikhermansen","id":435037,"node_id":"MDQ6VXNlcjQzNTAzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/435037?v=4","gravatar_id":"","url":"https://api.github.com/users/henrikhermansen","html_url":"https://github.com/henrikhermansen","followers_url":"https://api.github.com/users/henrikhermansen/followers","following_url":"https://api.github.com/users/henrikhermansen/following{/other_user}","gists_url":"https://api.github.com/users/henrikhermansen/gists{/gist_id}","starred_url":"https://api.github.com/users/henrikhermansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrikhermansen/subscriptions","organizations_url":"https://api.github.com/users/henrikhermansen/orgs","repos_url":"https://api.github.com/users/henrikhermansen/repos","events_url":"https://api.github.com/users/henrikhermansen/events{/privacy}","received_events_url":"https://api.github.com/users/henrikhermansen/received_events","type":"User","site_admin":false},"body":"I wanted to reopen #262 , but because I replaced my previous commits with new ones, I wasn't allowed to do that.\r\n\r\nI've taken comments, opinions and issues raised in the previous PR into consideration when I reworked the styling and components for the new cards. With this, I hope we can come a lot closer to being able to merge this.\r\n\r\nI've also taken the liberty of naming them. While these are mere suggestions, I do feel they make sense, as they reflect what's significant about each card.\r\nSpeaking of names, I have controversially named the base class and component Card Base. My thought behind this is that it's not really a card - it's a base. This also distinguishes it more clearly from the actual card components. Thoughts?\r\n\r\nCloses #260 ","created_at":"2018-11-12T12:24:44Z","updated_at":"2018-11-12T12:49:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5571a9e6466a312d5c82018b4917f39c2d8c8f1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"antidecaf","id":463847,"node_id":"MDQ6VXNlcjQ2Mzg0Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/463847?v=4","gravatar_id":"","url":"https://api.github.com/users/antidecaf","html_url":"https://github.com/antidecaf","followers_url":"https://api.github.com/users/antidecaf/followers","following_url":"https://api.github.com/users/antidecaf/following{/other_user}","gists_url":"https://api.github.com/users/antidecaf/gists{/gist_id}","starred_url":"https://api.github.com/users/antidecaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antidecaf/subscriptions","organizations_url":"https://api.github.com/users/antidecaf/orgs","repos_url":"https://api.github.com/users/antidecaf/repos","events_url":"https://api.github.com/users/antidecaf/events{/privacy}","received_events_url":"https://api.github.com/users/antidecaf/received_events","type":"User","site_admin":false},{"login":"kjabbe","id":6663743,"node_id":"MDQ6VXNlcjY2NjM3NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/6663743?v=4","gravatar_id":"","url":"https://api.github.com/users/kjabbe","html_url":"https://github.com/kjabbe","followers_url":"https://api.github.com/users/kjabbe/followers","following_url":"https://api.github.com/users/kjabbe/following{/other_user}","gists_url":"https://api.github.com/users/kjabbe/gists{/gist_id}","starred_url":"https://api.github.com/users/kjabbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjabbe/subscriptions","organizations_url":"https://api.github.com/users/kjabbe/orgs","repos_url":"https://api.github.com/users/kjabbe/repos","events_url":"https://api.github.com/users/kjabbe/events{/privacy}","received_events_url":"https://api.github.com/users/kjabbe/received_events","type":"User","site_admin":false},{"login":"adidick","id":8871429,"node_id":"MDQ6VXNlcjg4NzE0Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/8871429?v=4","gravatar_id":"","url":"https://api.github.com/users/adidick","html_url":"https://github.com/adidick","followers_url":"https://api.github.com/users/adidick/followers","following_url":"https://api.github.com/users/adidick/following{/other_user}","gists_url":"https://api.github.com/users/adidick/gists{/gist_id}","starred_url":"https://api.github.com/users/adidick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adidick/subscriptions","organizations_url":"https://api.github.com/users/adidick/orgs","repos_url":"https://api.github.com/users/adidick/repos","events_url":"https://api.github.com/users/adidick/events{/privacy}","received_events_url":"https://api.github.com/users/adidick/received_events","type":"User","site_admin":false},{"login":"hodoea","id":8971560,"node_id":"MDQ6VXNlcjg5NzE1NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/8971560?v=4","gravatar_id":"","url":"https://api.github.com/users/hodoea","html_url":"https://github.com/hodoea","followers_url":"https://api.github.com/users/hodoea/followers","following_url":"https://api.github.com/users/hodoea/following{/other_user}","gists_url":"https://api.github.com/users/hodoea/gists{/gist_id}","starred_url":"https://api.github.com/users/hodoea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hodoea/subscriptions","organizations_url":"https://api.github.com/users/hodoea/orgs","repos_url":"https://api.github.com/users/hodoea/repos","events_url":"https://api.github.com/users/hodoea/events{/privacy}","received_events_url":"https://api.github.com/users/hodoea/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpareBank1/designsystem/pulls/505/commits","review_comments_url":"https://api.github.com/repos/SpareBank1/designsystem/pulls/505/comments","review_comment_url":"https://api.github.com/repos/SpareBank1/designsystem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/505/comments","statuses_url":"https://api.github.com/repos/SpareBank1/designsystem/statuses/1e37065ae63562d83726657edb891009473e8258","head":{"label":"SpareBank1:feature/some-kind-of-card","ref":"feature/some-kind-of-card","sha":"1e37065ae63562d83726657edb891009473e8258","user":{"login":"SpareBank1","id":12732343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzMyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/12732343?v=4","gravatar_id":"","url":"https://api.github.com/users/SpareBank1","html_url":"https://github.com/SpareBank1","followers_url":"https://api.github.com/users/SpareBank1/followers","following_url":"https://api.github.com/users/SpareBank1/following{/other_user}","gists_url":"https://api.github.com/users/SpareBank1/gists{/gist_id}","starred_url":"https://api.github.com/users/SpareBank1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpareBank1/subscriptions","organizations_url":"https://api.github.com/users/SpareBank1/orgs","repos_url":"https://api.github.com/users/SpareBank1/repos","events_url":"https://api.github.com/users/SpareBank1/events{/privacy}","received_events_url":"https://api.github.com/users/SpareBank1/received_events","type":"Organization","site_admin":false},"repo":{"id":122945940,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI5NDU5NDA=","name":"designsystem","full_name":"SpareBank1/designsystem","private":false,"owner":{"login":"SpareBank1","id":12732343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzMyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/12732343?v=4","gravatar_id":"","url":"https://api.github.com/users/SpareBank1","html_url":"https://github.com/SpareBank1","followers_url":"https://api.github.com/users/SpareBank1/followers","following_url":"https://api.github.com/users/SpareBank1/following{/other_user}","gists_url":"https://api.github.com/users/SpareBank1/gists{/gist_id}","starred_url":"https://api.github.com/users/SpareBank1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpareBank1/subscriptions","organizations_url":"https://api.github.com/users/SpareBank1/orgs","repos_url":"https://api.github.com/users/SpareBank1/repos","events_url":"https://api.github.com/users/SpareBank1/events{/privacy}","received_events_url":"https://api.github.com/users/SpareBank1/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SpareBank1/designsystem","description":"SpareBank 1's design system and component library.","fork":false,"url":"https://api.github.com/repos/SpareBank1/designsystem","forks_url":"https://api.github.com/repos/SpareBank1/designsystem/forks","keys_url":"https://api.github.com/repos/SpareBank1/designsystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpareBank1/designsystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpareBank1/designsystem/teams","hooks_url":"https://api.github.com/repos/SpareBank1/designsystem/hooks","issue_events_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/events{/number}","events_url":"https://api.github.com/repos/SpareBank1/designsystem/events","assignees_url":"https://api.github.com/repos/SpareBank1/designsystem/assignees{/user}","branches_url":"https://api.github.com/repos/SpareBank1/designsystem/branches{/branch}","tags_url":"https://api.github.com/repos/SpareBank1/designsystem/tags","blobs_url":"https://api.github.com/repos/SpareBank1/designsystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpareBank1/designsystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpareBank1/designsystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpareBank1/designsystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpareBank1/designsystem/statuses/{sha}","languages_url":"https://api.github.com/repos/SpareBank1/designsystem/languages","stargazers_url":"https://api.github.com/repos/SpareBank1/designsystem/stargazers","contributors_url":"https://api.github.com/repos/SpareBank1/designsystem/contributors","subscribers_url":"https://api.github.com/repos/SpareBank1/designsystem/subscribers","subscription_url":"https://api.github.com/repos/SpareBank1/designsystem/subscription","commits_url":"https://api.github.com/repos/SpareBank1/designsystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpareBank1/designsystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpareBank1/designsystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpareBank1/designsystem/contents/{+path}","compare_url":"https://api.github.com/repos/SpareBank1/designsystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpareBank1/designsystem/merges","archive_url":"https://api.github.com/repos/SpareBank1/designsystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpareBank1/designsystem/downloads","issues_url":"https://api.github.com/repos/SpareBank1/designsystem/issues{/number}","pulls_url":"https://api.github.com/repos/SpareBank1/designsystem/pulls{/number}","milestones_url":"https://api.github.com/repos/SpareBank1/designsystem/milestones{/number}","notifications_url":"https://api.github.com/repos/SpareBank1/designsystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpareBank1/designsystem/labels{/name}","releases_url":"https://api.github.com/repos/SpareBank1/designsystem/releases{/id}","deployments_url":"https://api.github.com/repos/SpareBank1/designsystem/deployments","created_at":"2018-02-26T09:29:13Z","updated_at":"2018-11-09T15:02:29Z","pushed_at":"2018-11-12T12:43:13Z","git_url":"git://github.com/SpareBank1/designsystem.git","ssh_url":"git@github.com:SpareBank1/designsystem.git","clone_url":"https://github.com/SpareBank1/designsystem.git","svn_url":"https://github.com/SpareBank1/designsystem","homepage":"https://design.sparebank1.no/","size":92975,"stargazers_count":57,"watchers_count":57,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":54,"watchers":57,"default_branch":"develop"}},"base":{"label":"SpareBank1:develop","ref":"develop","sha":"33013b02befb47798c38b60c02c2a1c379ac511e","user":{"login":"SpareBank1","id":12732343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzMyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/12732343?v=4","gravatar_id":"","url":"https://api.github.com/users/SpareBank1","html_url":"https://github.com/SpareBank1","followers_url":"https://api.github.com/users/SpareBank1/followers","following_url":"https://api.github.com/users/SpareBank1/following{/other_user}","gists_url":"https://api.github.com/users/SpareBank1/gists{/gist_id}","starred_url":"https://api.github.com/users/SpareBank1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpareBank1/subscriptions","organizations_url":"https://api.github.com/users/SpareBank1/orgs","repos_url":"https://api.github.com/users/SpareBank1/repos","events_url":"https://api.github.com/users/SpareBank1/events{/privacy}","received_events_url":"https://api.github.com/users/SpareBank1/received_events","type":"Organization","site_admin":false},"repo":{"id":122945940,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI5NDU5NDA=","name":"designsystem","full_name":"SpareBank1/designsystem","private":false,"owner":{"login":"SpareBank1","id":12732343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzMyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/12732343?v=4","gravatar_id":"","url":"https://api.github.com/users/SpareBank1","html_url":"https://github.com/SpareBank1","followers_url":"https://api.github.com/users/SpareBank1/followers","following_url":"https://api.github.com/users/SpareBank1/following{/other_user}","gists_url":"https://api.github.com/users/SpareBank1/gists{/gist_id}","starred_url":"https://api.github.com/users/SpareBank1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpareBank1/subscriptions","organizations_url":"https://api.github.com/users/SpareBank1/orgs","repos_url":"https://api.github.com/users/SpareBank1/repos","events_url":"https://api.github.com/users/SpareBank1/events{/privacy}","received_events_url":"https://api.github.com/users/SpareBank1/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SpareBank1/designsystem","description":"SpareBank 1's design system and component library.","fork":false,"url":"https://api.github.com/repos/SpareBank1/designsystem","forks_url":"https://api.github.com/repos/SpareBank1/designsystem/forks","keys_url":"https://api.github.com/repos/SpareBank1/designsystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpareBank1/designsystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpareBank1/designsystem/teams","hooks_url":"https://api.github.com/repos/SpareBank1/designsystem/hooks","issue_events_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/events{/number}","events_url":"https://api.github.com/repos/SpareBank1/designsystem/events","assignees_url":"https://api.github.com/repos/SpareBank1/designsystem/assignees{/user}","branches_url":"https://api.github.com/repos/SpareBank1/designsystem/branches{/branch}","tags_url":"https://api.github.com/repos/SpareBank1/designsystem/tags","blobs_url":"https://api.github.com/repos/SpareBank1/designsystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpareBank1/designsystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpareBank1/designsystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpareBank1/designsystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpareBank1/designsystem/statuses/{sha}","languages_url":"https://api.github.com/repos/SpareBank1/designsystem/languages","stargazers_url":"https://api.github.com/repos/SpareBank1/designsystem/stargazers","contributors_url":"https://api.github.com/repos/SpareBank1/designsystem/contributors","subscribers_url":"https://api.github.com/repos/SpareBank1/designsystem/subscribers","subscription_url":"https://api.github.com/repos/SpareBank1/designsystem/subscription","commits_url":"https://api.github.com/repos/SpareBank1/designsystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpareBank1/designsystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpareBank1/designsystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpareBank1/designsystem/contents/{+path}","compare_url":"https://api.github.com/repos/SpareBank1/designsystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpareBank1/designsystem/merges","archive_url":"https://api.github.com/repos/SpareBank1/designsystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpareBank1/designsystem/downloads","issues_url":"https://api.github.com/repos/SpareBank1/designsystem/issues{/number}","pulls_url":"https://api.github.com/repos/SpareBank1/designsystem/pulls{/number}","milestones_url":"https://api.github.com/repos/SpareBank1/designsystem/milestones{/number}","notifications_url":"https://api.github.com/repos/SpareBank1/designsystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpareBank1/designsystem/labels{/name}","releases_url":"https://api.github.com/repos/SpareBank1/designsystem/releases{/id}","deployments_url":"https://api.github.com/repos/SpareBank1/designsystem/deployments","created_at":"2018-02-26T09:29:13Z","updated_at":"2018-11-09T15:02:29Z","pushed_at":"2018-11-12T12:43:13Z","git_url":"git://github.com/SpareBank1/designsystem.git","ssh_url":"git@github.com:SpareBank1/designsystem.git","clone_url":"https://github.com/SpareBank1/designsystem.git","svn_url":"https://github.com/SpareBank1/designsystem","homepage":"https://design.sparebank1.no/","size":92975,"stargazers_count":57,"watchers_count":57,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":54,"watchers":57,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SpareBank1/designsystem/pulls/505"},"html":{"href":"https://github.com/SpareBank1/designsystem/pull/505"},"issue":{"href":"https://api.github.com/repos/SpareBank1/designsystem/issues/505"},"comments":{"href":"https://api.github.com/repos/SpareBank1/designsystem/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/SpareBank1/designsystem/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/SpareBank1/designsystem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpareBank1/designsystem/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/SpareBank1/designsystem/statuses/1e37065ae63562d83726657edb891009473e8258"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"selbekk"}}