{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-ui/pulls/comments/205356960","pull_request_review_id":140600377,"id":205356960,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTM1Njk2MA==","diff_hunk":"@@ -100,6 +150,35 @@\n             vm.nodesUpgrade.totalNodes = response.data.upgraded_nodes + response.data.remaining_nodes;\n             vm.nodesUpgrade.currentNodes = response.data.current_nodes;\n             vm.nodesUpgrade.currentAction = response.data.current_node_action;\n+            vm.nodesUpgrade.computeNodesPostponedFlag = response.data.compute_nodes_postponed;\n+\n+            // check for the case of postpone upgrade of compute nodes, after controller nodes were\n+            // upgraded, step status would still be 'running' while substep status would be 'finished'\n+            vm.nodesUpgrade.subStep = response.data.current_substep;\n+            vm.nodesUpgrade.subStepStatus = response.data.current_substep_status;\n+            if (vm.nodesUpgrade.subStep === 'controller_nodes' && vm.nodesUpgrade.subStepStatus === 'finished'\n+                && response.data.nodes_selected_for_upgrade === 'controllers') {\n+                vm.nodesUpgrade.running = false;\n+\n+                // show partially upgrade message\n+                vm.nodesUpgrade.upgradeControllersDone = true;","path":"assets/app/features/upgrade/controllers/upgrade-nodes.controller.js","position":128,"original_position":128,"commit_id":"45aff2bdab55ad20edceab0dbcc934017e54212f","original_commit_id":"45aff2bdab55ad20edceab0dbcc934017e54212f","user":{"login":"skazi0","id":2458112,"node_id":"MDQ6VXNlcjI0NTgxMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2458112?v=4","gravatar_id":"","url":"https://api.github.com/users/skazi0","html_url":"https://github.com/skazi0","followers_url":"https://api.github.com/users/skazi0/followers","following_url":"https://api.github.com/users/skazi0/following{/other_user}","gists_url":"https://api.github.com/users/skazi0/gists{/gist_id}","starred_url":"https://api.github.com/users/skazi0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skazi0/subscriptions","organizations_url":"https://api.github.com/users/skazi0/orgs","repos_url":"https://api.github.com/users/skazi0/repos","events_url":"https://api.github.com/users/skazi0/events{/privacy}","received_events_url":"https://api.github.com/users/skazi0/received_events","type":"User","site_admin":false},"body":"`upgradeStepsFactory.getUpgradeStep() === NODE_UPGRADE_STEP.compute` seems to match `vm.nodesUpgrade.upgradeControllersDone`. You can use the value from `upgradeStepsFactory` everywhere and remove `upgradeControllersDone`.","created_at":"2018-07-26T07:34:39Z","updated_at":"2018-07-26T07:52:16Z","html_url":"https://github.com/crowbar/crowbar-ui/pull/179#discussion_r205356960","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-ui/pulls/179","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-ui/pulls/comments/205356960"},"html":{"href":"https://github.com/crowbar/crowbar-ui/pull/179#discussion_r205356960"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-ui/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-ui/pulls/179","id":198100055,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTAwMDU1","html_url":"https://github.com/crowbar/crowbar-ui/pull/179","diff_url":"https://github.com/crowbar/crowbar-ui/pull/179.diff","patch_url":"https://github.com/crowbar/crowbar-ui/pull/179.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-ui/issues/179","number":179,"state":"open","locked":false,"title":"upgrade: Add ability to postpone upgrade","user":{"login":"jgravel","id":26905799,"node_id":"MDQ6VXNlcjI2OTA1Nzk5","avatar_url":"https://avatars1.githubusercontent.com/u/26905799?v=4","gravatar_id":"","url":"https://api.github.com/users/jgravel","html_url":"https://github.com/jgravel","followers_url":"https://api.github.com/users/jgravel/followers","following_url":"https://api.github.com/users/jgravel/following{/other_user}","gists_url":"https://api.github.com/users/jgravel/gists{/gist_id}","starred_url":"https://api.github.com/users/jgravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgravel/subscriptions","organizations_url":"https://api.github.com/users/jgravel/orgs","repos_url":"https://api.github.com/users/jgravel/repos","events_url":"https://api.github.com/users/jgravel/events{/privacy}","received_events_url":"https://api.github.com/users/jgravel/received_events","type":"User","site_admin":false},"body":"First draft of UI change for the postpone upgrade story. ** WIP **","created_at":"2018-06-28T17:28:16Z","updated_at":"2018-07-26T07:52:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d83d53302c2e5d383fceb697defd989a5df97a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":484232440,"node_id":"MDU6TGFiZWw0ODQyMzI0NDA=","url":"https://api.github.com/repos/crowbar/crowbar-ui/labels/upgrade","name":"upgrade","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-ui/pulls/179/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-ui/pulls/179/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-ui/issues/179/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-ui/statuses/45aff2bdab55ad20edceab0dbcc934017e54212f","head":{"label":"jgravel:postpone-upgrade","ref":"postpone-upgrade","sha":"45aff2bdab55ad20edceab0dbcc934017e54212f","user":{"login":"jgravel","id":26905799,"node_id":"MDQ6VXNlcjI2OTA1Nzk5","avatar_url":"https://avatars1.githubusercontent.com/u/26905799?v=4","gravatar_id":"","url":"https://api.github.com/users/jgravel","html_url":"https://github.com/jgravel","followers_url":"https://api.github.com/users/jgravel/followers","following_url":"https://api.github.com/users/jgravel/following{/other_user}","gists_url":"https://api.github.com/users/jgravel/gists{/gist_id}","starred_url":"https://api.github.com/users/jgravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgravel/subscriptions","organizations_url":"https://api.github.com/users/jgravel/orgs","repos_url":"https://api.github.com/users/jgravel/repos","events_url":"https://api.github.com/users/jgravel/events{/privacy}","received_events_url":"https://api.github.com/users/jgravel/received_events","type":"User","site_admin":false},"repo":{"id":133979741,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5Nzk3NDE=","name":"crowbar-ui","full_name":"jgravel/crowbar-ui","owner":{"login":"jgravel","id":26905799,"node_id":"MDQ6VXNlcjI2OTA1Nzk5","avatar_url":"https://avatars1.githubusercontent.com/u/26905799?v=4","gravatar_id":"","url":"https://api.github.com/users/jgravel","html_url":"https://github.com/jgravel","followers_url":"https://api.github.com/users/jgravel/followers","following_url":"https://api.github.com/users/jgravel/following{/other_user}","gists_url":"https://api.github.com/users/jgravel/gists{/gist_id}","starred_url":"https://api.github.com/users/jgravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgravel/subscriptions","organizations_url":"https://api.github.com/users/jgravel/orgs","repos_url":"https://api.github.com/users/jgravel/repos","events_url":"https://api.github.com/users/jgravel/events{/privacy}","received_events_url":"https://api.github.com/users/jgravel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgravel/crowbar-ui","description":"Crowbar Web UI based on Angular","fork":true,"url":"https://api.github.com/repos/jgravel/crowbar-ui","forks_url":"https://api.github.com/repos/jgravel/crowbar-ui/forks","keys_url":"https://api.github.com/repos/jgravel/crowbar-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgravel/crowbar-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgravel/crowbar-ui/teams","hooks_url":"https://api.github.com/repos/jgravel/crowbar-ui/hooks","issue_events_url":"https://api.github.com/repos/jgravel/crowbar-ui/issues/events{/number}","events_url":"https://api.github.com/repos/jgravel/crowbar-ui/events","assignees_url":"https://api.github.com/repos/jgravel/crowbar-ui/assignees{/user}","branches_url":"https://api.github.com/repos/jgravel/crowbar-ui/branches{/branch}","tags_url":"https://api.github.com/repos/jgravel/crowbar-ui/tags","blobs_url":"https://api.github.com/repos/jgravel/crowbar-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgravel/crowbar-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgravel/crowbar-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgravel/crowbar-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgravel/crowbar-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jgravel/crowbar-ui/languages","stargazers_url":"https://api.github.com/repos/jgravel/crowbar-ui/stargazers","contributors_url":"https://api.github.com/repos/jgravel/crowbar-ui/contributors","subscribers_url":"https://api.github.com/repos/jgravel/crowbar-ui/subscribers","subscription_url":"https://api.github.com/repos/jgravel/crowbar-ui/subscription","commits_url":"https://api.github.com/repos/jgravel/crowbar-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgravel/crowbar-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgravel/crowbar-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgravel/crowbar-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgravel/crowbar-ui/contents/{+path}","compare_url":"https://api.github.com/repos/jgravel/crowbar-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgravel/crowbar-ui/merges","archive_url":"https://api.github.com/repos/jgravel/crowbar-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgravel/crowbar-ui/downloads","issues_url":"https://api.github.com/repos/jgravel/crowbar-ui/issues{/number}","pulls_url":"https://api.github.com/repos/jgravel/crowbar-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jgravel/crowbar-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jgravel/crowbar-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgravel/crowbar-ui/labels{/name}","releases_url":"https://api.github.com/repos/jgravel/crowbar-ui/releases{/id}","deployments_url":"https://api.github.com/repos/jgravel/crowbar-ui/deployments","created_at":"2018-05-18T16:36:47Z","updated_at":"2018-06-28T17:11:47Z","pushed_at":"2018-07-25T16:44:08Z","git_url":"git://github.com/jgravel/crowbar-ui.git","ssh_url":"git@github.com:jgravel/crowbar-ui.git","clone_url":"https://github.com/jgravel/crowbar-ui.git","svn_url":"https://github.com/jgravel/crowbar-ui","homepage":"","size":26060,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"83beaafda50d43049a64898f2c37b7c02ff61515","user":{"login":"crowbar","id":2910205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTAyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":63954363,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzk1NDM2Mw==","name":"crowbar-ui","full_name":"crowbar/crowbar-ui","owner":{"login":"crowbar","id":2910205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTAyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-ui","description":"Crowbar Web UI based on Angular","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-ui","forks_url":"https://api.github.com/repos/crowbar/crowbar-ui/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-ui/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-ui/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-ui/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-ui/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-ui/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-ui/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-ui/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-ui/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-ui/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-ui/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-ui/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-ui/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-ui/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-ui/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-ui/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-ui/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-ui/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-ui/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-ui/deployments","created_at":"2016-07-22T13:11:54Z","updated_at":"2018-06-20T12:12:32Z","pushed_at":"2018-07-25T16:44:09Z","git_url":"git://github.com/crowbar/crowbar-ui.git","ssh_url":"git@github.com:crowbar/crowbar-ui.git","clone_url":"https://github.com/crowbar/crowbar-ui.git","svn_url":"https://github.com/crowbar/crowbar-ui","homepage":"","size":26040,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-ui/pulls/179"},"html":{"href":"https://github.com/crowbar/crowbar-ui/pull/179"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-ui/issues/179"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-ui/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-ui/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-ui/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-ui/statuses/45aff2bdab55ad20edceab0dbcc934017e54212f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"skazi0"}}