{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10478","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10478/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10478/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10478/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/10478","id":288877736,"number":10478,"title":"[MRG] Fixes #10470: FeatureHasher ordered feature list","user":{"login":"maykulkarni","id":4528636,"avatar_url":"https://avatars2.githubusercontent.com/u/4528636?v=4","gravatar_id":"","url":"https://api.github.com/users/maykulkarni","html_url":"https://github.com/maykulkarni","followers_url":"https://api.github.com/users/maykulkarni/followers","following_url":"https://api.github.com/users/maykulkarni/following{/other_user}","gists_url":"https://api.github.com/users/maykulkarni/gists{/gist_id}","starred_url":"https://api.github.com/users/maykulkarni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maykulkarni/subscriptions","organizations_url":"https://api.github.com/users/maykulkarni/orgs","repos_url":"https://api.github.com/users/maykulkarni/repos","events_url":"https://api.github.com/users/maykulkarni/events{/privacy}","received_events_url":"https://api.github.com/users/maykulkarni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2018-01-16T11:43:53Z","updated_at":"2018-02-16T08:53:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10478","html_url":"https://github.com/scikit-learn/scikit-learn/pull/10478","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/10478.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/10478.patch"},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist\r\n-->\r\n\r\n#### Reference Issues/PRs\r\nFixes #10470 \r\n<!--\r\nExample: Fixes #1234. See also #3456.\r\nPlease use keywords (e.g., Fixes) to create link to the issues or pull requests\r\nyou resolved, so that they will automatically be closed when your pull request\r\nis merged. See https://github.com/blog/1506-closing-issues-via-pull-requests\r\n-->\r\n\r\n\r\n#### What does this implement/fix? Explain your changes.\r\n- [x] Make FeatureHasher provide get_feature_names\r\n- [x] Test changes\r\n#### Any other comments?\r\n\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/366177159","html_url":"https://github.com/scikit-learn/scikit-learn/pull/10478#issuecomment-366177159","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10478","id":366177159,"user":{"login":"maykulkarni","id":4528636,"avatar_url":"https://avatars2.githubusercontent.com/u/4528636?v=4","gravatar_id":"","url":"https://api.github.com/users/maykulkarni","html_url":"https://github.com/maykulkarni","followers_url":"https://api.github.com/users/maykulkarni/followers","following_url":"https://api.github.com/users/maykulkarni/following{/other_user}","gists_url":"https://api.github.com/users/maykulkarni/gists{/gist_id}","starred_url":"https://api.github.com/users/maykulkarni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maykulkarni/subscriptions","organizations_url":"https://api.github.com/users/maykulkarni/orgs","repos_url":"https://api.github.com/users/maykulkarni/repos","events_url":"https://api.github.com/users/maykulkarni/events{/privacy}","received_events_url":"https://api.github.com/users/maykulkarni/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T08:53:12Z","updated_at":"2018-02-16T08:53:12Z","author_association":"CONTRIBUTOR","body":"@jnothman review please. "}}
{"actor":{"display_login":"maykulkarni"}}