{"action":"created","comment":{"url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/pulls/comments/207985567","pull_request_review_id":143699692,"id":207985567,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzk4NTU2Nw==","diff_hunk":"@@ -63,12 +63,26 @@ type SSHConfig struct {\n \tSecretName string `json:\"secretName\"`\n }\n \n+type SSHMachineStatus string\n+\n+const (\n+\tMachineCreated SSHMachineStatus = \"MachineCreated\"\n+)\n+\n // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object\n type SSHMachineProviderStatus struct {\n \tmetav1.TypeMeta `json:\",inline\"`\n+\tstatus          SSHMachineStatus `json:\"status,omitempty\"`\n }\n \n+type SSHClusterStatus string\n+\n+const (\n+\tClusterCreated SSHClusterStatus = \"ClusterCreated\"\n+)\n+\n // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object\n type SSHClusterProviderStatus struct {\n \tmetav1.TypeMeta `json:\",inline\"`\n+\tstatus          SSHMachineStatus `json:\"status,omitempty\"`","path":"cloud/ssh/providerconfig/types.go","position":25,"original_position":25,"commit_id":"878ccef15c9731f7c5ac0333a71d95aac7eac1fc","original_commit_id":"878ccef15c9731f7c5ac0333a71d95aac7eac1fc","user":{"login":"davidewatson","id":11819015,"node_id":"MDQ6VXNlcjExODE5MDE1","avatar_url":"https://avatars2.githubusercontent.com/u/11819015?v=4","gravatar_id":"","url":"https://api.github.com/users/davidewatson","html_url":"https://github.com/davidewatson","followers_url":"https://api.github.com/users/davidewatson/followers","following_url":"https://api.github.com/users/davidewatson/following{/other_user}","gists_url":"https://api.github.com/users/davidewatson/gists{/gist_id}","starred_url":"https://api.github.com/users/davidewatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidewatson/subscriptions","organizations_url":"https://api.github.com/users/davidewatson/orgs","repos_url":"https://api.github.com/users/davidewatson/repos","events_url":"https://api.github.com/users/davidewatson/events{/privacy}","received_events_url":"https://api.github.com/users/davidewatson/received_events","type":"User","site_admin":false},"body":"Why is this sub-status needed? Isn't the data already stored in `Machine.Annotations`? Having nested status is confusing to me, especially since the name of each status is almost the same.","created_at":"2018-08-06T18:21:46Z","updated_at":"2018-08-06T18:46:38Z","html_url":"https://github.com/samsung-cnct/cluster-api-provider-ssh/pull/39#discussion_r207985567","pull_request_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/pulls/39","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/pulls/comments/207985567"},"html":{"href":"https://github.com/samsung-cnct/cluster-api-provider-ssh/pull/39#discussion_r207985567"},"pull_request":{"href":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/pulls/39","id":206285869,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2Mjg1ODY5","html_url":"https://github.com/samsung-cnct/cluster-api-provider-ssh/pull/39","diff_url":"https://github.com/samsung-cnct/cluster-api-provider-ssh/pull/39.diff","patch_url":"https://github.com/samsung-cnct/cluster-api-provider-ssh/pull/39.patch","issue_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/issues/39","number":39,"state":"open","locked":false,"title":"Implemented SSHProviderStatus object, into machine status","user":{"login":"alejandroEsc","id":20777618,"node_id":"MDQ6VXNlcjIwNzc3NjE4","avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"body":"Also removed a lot of annotation code as we are loosening our reliance on it and potentially want to move away from using annotations.","created_at":"2018-08-06T04:24:32Z","updated_at":"2018-08-06T18:46:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a884c5fc84166bc3a61eb2bc610cdb34c4ee6f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/pulls/39/commits","review_comments_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/pulls/39/comments","review_comment_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/issues/39/comments","statuses_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/statuses/878ccef15c9731f7c5ac0333a71d95aac7eac1fc","head":{"label":"alejandroEsc:ae/annotations/delete","ref":"ae/annotations/delete","sha":"878ccef15c9731f7c5ac0333a71d95aac7eac1fc","user":{"login":"alejandroEsc","id":20777618,"node_id":"MDQ6VXNlcjIwNzc3NjE4","avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"repo":{"id":141327360,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzMjczNjA=","name":"cluster-api-provider-ssh","full_name":"alejandroEsc/cluster-api-provider-ssh","owner":{"login":"alejandroEsc","id":20777618,"node_id":"MDQ6VXNlcjIwNzc3NjE4","avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alejandroEsc/cluster-api-provider-ssh","description":"A simple Cluster API provisioner using SSH","fork":true,"url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh","forks_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/forks","keys_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/teams","hooks_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/hooks","issue_events_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/issues/events{/number}","events_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/events","assignees_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/assignees{/user}","branches_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/branches{/branch}","tags_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/tags","blobs_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/git/refs{/sha}","trees_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/statuses/{sha}","languages_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/languages","stargazers_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/stargazers","contributors_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/contributors","subscribers_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/subscribers","subscription_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/subscription","commits_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/commits{/sha}","git_commits_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/git/commits{/sha}","comments_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/comments{/number}","issue_comment_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/issues/comments{/number}","contents_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/contents/{+path}","compare_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/merges","archive_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/downloads","issues_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/issues{/number}","pulls_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/pulls{/number}","milestones_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/milestones{/number}","notifications_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/labels{/name}","releases_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/releases{/id}","deployments_url":"https://api.github.com/repos/alejandroEsc/cluster-api-provider-ssh/deployments","created_at":"2018-07-17T18:19:00Z","updated_at":"2018-08-06T17:01:45Z","pushed_at":"2018-08-06T17:01:44Z","git_url":"git://github.com/alejandroEsc/cluster-api-provider-ssh.git","ssh_url":"git@github.com:alejandroEsc/cluster-api-provider-ssh.git","clone_url":"https://github.com/alejandroEsc/cluster-api-provider-ssh.git","svn_url":"https://github.com/alejandroEsc/cluster-api-provider-ssh","homepage":"","size":35484,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samsung-cnct:master","ref":"master","sha":"5cef13c982cc87ee65d7983162a1b39426ea016f","user":{"login":"samsung-cnct","id":11511065,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTExMDY1","avatar_url":"https://avatars3.githubusercontent.com/u/11511065?v=4","gravatar_id":"","url":"https://api.github.com/users/samsung-cnct","html_url":"https://github.com/samsung-cnct","followers_url":"https://api.github.com/users/samsung-cnct/followers","following_url":"https://api.github.com/users/samsung-cnct/following{/other_user}","gists_url":"https://api.github.com/users/samsung-cnct/gists{/gist_id}","starred_url":"https://api.github.com/users/samsung-cnct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsung-cnct/subscriptions","organizations_url":"https://api.github.com/users/samsung-cnct/orgs","repos_url":"https://api.github.com/users/samsung-cnct/repos","events_url":"https://api.github.com/users/samsung-cnct/events{/privacy}","received_events_url":"https://api.github.com/users/samsung-cnct/received_events","type":"Organization","site_admin":false},"repo":{"id":140671361,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA2NzEzNjE=","name":"cluster-api-provider-ssh","full_name":"samsung-cnct/cluster-api-provider-ssh","owner":{"login":"samsung-cnct","id":11511065,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTExMDY1","avatar_url":"https://avatars3.githubusercontent.com/u/11511065?v=4","gravatar_id":"","url":"https://api.github.com/users/samsung-cnct","html_url":"https://github.com/samsung-cnct","followers_url":"https://api.github.com/users/samsung-cnct/followers","following_url":"https://api.github.com/users/samsung-cnct/following{/other_user}","gists_url":"https://api.github.com/users/samsung-cnct/gists{/gist_id}","starred_url":"https://api.github.com/users/samsung-cnct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsung-cnct/subscriptions","organizations_url":"https://api.github.com/users/samsung-cnct/orgs","repos_url":"https://api.github.com/users/samsung-cnct/repos","events_url":"https://api.github.com/users/samsung-cnct/events{/privacy}","received_events_url":"https://api.github.com/users/samsung-cnct/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/samsung-cnct/cluster-api-provider-ssh","description":"A simple Cluster API provisioner using SSH","fork":true,"url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh","forks_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/forks","keys_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/teams","hooks_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/hooks","issue_events_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/issues/events{/number}","events_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/events","assignees_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/assignees{/user}","branches_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/branches{/branch}","tags_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/tags","blobs_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/git/refs{/sha}","trees_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/statuses/{sha}","languages_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/languages","stargazers_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/stargazers","contributors_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/contributors","subscribers_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/subscribers","subscription_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/subscription","commits_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/commits{/sha}","git_commits_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/git/commits{/sha}","comments_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/comments{/number}","issue_comment_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/issues/comments{/number}","contents_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/contents/{+path}","compare_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/merges","archive_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/downloads","issues_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/issues{/number}","pulls_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/pulls{/number}","milestones_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/milestones{/number}","notifications_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/labels{/name}","releases_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/releases{/id}","deployments_url":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/deployments","created_at":"2018-07-12T06:34:03Z","updated_at":"2018-08-06T16:56:08Z","pushed_at":"2018-08-06T16:56:06Z","git_url":"git://github.com/samsung-cnct/cluster-api-provider-ssh.git","ssh_url":"git@github.com:samsung-cnct/cluster-api-provider-ssh.git","clone_url":"https://github.com/samsung-cnct/cluster-api-provider-ssh.git","svn_url":"https://github.com/samsung-cnct/cluster-api-provider-ssh","homepage":"","size":35466,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/pulls/39"},"html":{"href":"https://github.com/samsung-cnct/cluster-api-provider-ssh/pull/39"},"issue":{"href":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/issues/39"},"comments":{"href":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/samsung-cnct/cluster-api-provider-ssh/statuses/878ccef15c9731f7c5ac0333a71d95aac7eac1fc"}},"author_association":"NONE"}}
{"actor":{"display_login":"davidewatson"}}