{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/lafriks/gitea/pulls/2","id":186223829,"html_url":"https://github.com/lafriks/gitea/pull/2","diff_url":"https://github.com/lafriks/gitea/pull/2.diff","patch_url":"https://github.com/lafriks/gitea/pull/2.patch","issue_url":"https://api.github.com/repos/lafriks/gitea/issues/2","number":2,"state":"closed","locked":false,"title":"Reviews and Pull Request comments","user":{"login":"JonasFranzDEV","id":5757182,"avatar_url":"https://avatars3.githubusercontent.com/u/5757182?v=4","gravatar_id":"","url":"https://api.github.com/users/JonasFranzDEV","html_url":"https://github.com/JonasFranzDEV","followers_url":"https://api.github.com/users/JonasFranzDEV/followers","following_url":"https://api.github.com/users/JonasFranzDEV/following{/other_user}","gists_url":"https://api.github.com/users/JonasFranzDEV/gists{/gist_id}","starred_url":"https://api.github.com/users/JonasFranzDEV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonasFranzDEV/subscriptions","organizations_url":"https://api.github.com/users/JonasFranzDEV/orgs","repos_url":"https://api.github.com/users/JonasFranzDEV/repos","events_url":"https://api.github.com/users/JonasFranzDEV/events{/privacy}","received_events_url":"https://api.github.com/users/JonasFranzDEV/received_events","type":"User","site_admin":false},"body":"This should contribute to go-gitea/gitea#3748.\r\n\r\n* Resolve conflicts\r\n* Add review model\r\n* Add comment types\r\n\r\nThis is WIP.\r\n\r\n## Reviews\r\nReviews should bundle all code comments created for the initial review. All code comments created for this review are linked to the review model.\r\n\r\n## Comment types\r\n`CommentTypeCode`: A comment at a line of a code of a PR (UI not implemented)\r\n`CommentTypeReview`: Notifies the participants about the review. (UI not implemented)\r\n\r\n## TODO\r\n- [x] Render code comments on the right place\r\n- [x] Add support for comments on both sides\r\n- [ ] Show code comments in the \"conversation\" after a review got submitted\r\n- [ ] Show single code comment in the \"conversation\"\r\n- [ ] Remove dummy data from \"code comment form\" (line, path, side)\r\n- [x] Add support for \"Add single comments\"\r\n- [ ] Order/Separate code comments by thread/review\r\n- [x] ~~Blocked by go-gitea/git#116~~\r\n","created_at":"2018-05-06T20:07:46Z","updated_at":"2018-05-13T20:09:01Z","closed_at":"2018-05-13T20:09:01Z","merged_at":"2018-05-13T20:09:00Z","merge_commit_sha":"2f466132cc095b7ef88f81a312560184674243b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lafriks/gitea/pulls/2/commits","review_comments_url":"https://api.github.com/repos/lafriks/gitea/pulls/2/comments","review_comment_url":"https://api.github.com/repos/lafriks/gitea/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lafriks/gitea/issues/2/comments","statuses_url":"https://api.github.com/repos/lafriks/gitea/statuses/cbdd8c9da73e6f3c866cb418e0d6cd301a4b46cb","head":{"label":"JonasFranzDEV:feat/approval","ref":"feat/approval","sha":"cbdd8c9da73e6f3c866cb418e0d6cd301a4b46cb","user":{"login":"JonasFranzDEV","id":5757182,"avatar_url":"https://avatars3.githubusercontent.com/u/5757182?v=4","gravatar_id":"","url":"https://api.github.com/users/JonasFranzDEV","html_url":"https://github.com/JonasFranzDEV","followers_url":"https://api.github.com/users/JonasFranzDEV/followers","following_url":"https://api.github.com/users/JonasFranzDEV/following{/other_user}","gists_url":"https://api.github.com/users/JonasFranzDEV/gists{/gist_id}","starred_url":"https://api.github.com/users/JonasFranzDEV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonasFranzDEV/subscriptions","organizations_url":"https://api.github.com/users/JonasFranzDEV/orgs","repos_url":"https://api.github.com/users/JonasFranzDEV/repos","events_url":"https://api.github.com/users/JonasFranzDEV/events{/privacy}","received_events_url":"https://api.github.com/users/JonasFranzDEV/received_events","type":"User","site_admin":false},"repo":{"id":90271516,"name":"gitea","full_name":"JonasFranzDEV/gitea","owner":{"login":"JonasFranzDEV","id":5757182,"avatar_url":"https://avatars3.githubusercontent.com/u/5757182?v=4","gravatar_id":"","url":"https://api.github.com/users/JonasFranzDEV","html_url":"https://github.com/JonasFranzDEV","followers_url":"https://api.github.com/users/JonasFranzDEV/followers","following_url":"https://api.github.com/users/JonasFranzDEV/following{/other_user}","gists_url":"https://api.github.com/users/JonasFranzDEV/gists{/gist_id}","starred_url":"https://api.github.com/users/JonasFranzDEV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonasFranzDEV/subscriptions","organizations_url":"https://api.github.com/users/JonasFranzDEV/orgs","repos_url":"https://api.github.com/users/JonasFranzDEV/repos","events_url":"https://api.github.com/users/JonasFranzDEV/events{/privacy}","received_events_url":"https://api.github.com/users/JonasFranzDEV/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JonasFranzDEV/gitea","description":"Gitea: Git with a cup of tea","fork":true,"url":"https://api.github.com/repos/JonasFranzDEV/gitea","forks_url":"https://api.github.com/repos/JonasFranzDEV/gitea/forks","keys_url":"https://api.github.com/repos/JonasFranzDEV/gitea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JonasFranzDEV/gitea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JonasFranzDEV/gitea/teams","hooks_url":"https://api.github.com/repos/JonasFranzDEV/gitea/hooks","issue_events_url":"https://api.github.com/repos/JonasFranzDEV/gitea/issues/events{/number}","events_url":"https://api.github.com/repos/JonasFranzDEV/gitea/events","assignees_url":"https://api.github.com/repos/JonasFranzDEV/gitea/assignees{/user}","branches_url":"https://api.github.com/repos/JonasFranzDEV/gitea/branches{/branch}","tags_url":"https://api.github.com/repos/JonasFranzDEV/gitea/tags","blobs_url":"https://api.github.com/repos/JonasFranzDEV/gitea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JonasFranzDEV/gitea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JonasFranzDEV/gitea/git/refs{/sha}","trees_url":"https://api.github.com/repos/JonasFranzDEV/gitea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JonasFranzDEV/gitea/statuses/{sha}","languages_url":"https://api.github.com/repos/JonasFranzDEV/gitea/languages","stargazers_url":"https://api.github.com/repos/JonasFranzDEV/gitea/stargazers","contributors_url":"https://api.github.com/repos/JonasFranzDEV/gitea/contributors","subscribers_url":"https://api.github.com/repos/JonasFranzDEV/gitea/subscribers","subscription_url":"https://api.github.com/repos/JonasFranzDEV/gitea/subscription","commits_url":"https://api.github.com/repos/JonasFranzDEV/gitea/commits{/sha}","git_commits_url":"https://api.github.com/repos/JonasFranzDEV/gitea/git/commits{/sha}","comments_url":"https://api.github.com/repos/JonasFranzDEV/gitea/comments{/number}","issue_comment_url":"https://api.github.com/repos/JonasFranzDEV/gitea/issues/comments{/number}","contents_url":"https://api.github.com/repos/JonasFranzDEV/gitea/contents/{+path}","compare_url":"https://api.github.com/repos/JonasFranzDEV/gitea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JonasFranzDEV/gitea/merges","archive_url":"https://api.github.com/repos/JonasFranzDEV/gitea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JonasFranzDEV/gitea/downloads","issues_url":"https://api.github.com/repos/JonasFranzDEV/gitea/issues{/number}","pulls_url":"https://api.github.com/repos/JonasFranzDEV/gitea/pulls{/number}","milestones_url":"https://api.github.com/repos/JonasFranzDEV/gitea/milestones{/number}","notifications_url":"https://api.github.com/repos/JonasFranzDEV/gitea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JonasFranzDEV/gitea/labels{/name}","releases_url":"https://api.github.com/repos/JonasFranzDEV/gitea/releases{/id}","deployments_url":"https://api.github.com/repos/JonasFranzDEV/gitea/deployments","created_at":"2017-05-04T14:15:03Z","updated_at":"2017-05-04T14:15:06Z","pushed_at":"2018-05-13T14:14:31Z","git_url":"git://github.com/JonasFranzDEV/gitea.git","ssh_url":"git@github.com:JonasFranzDEV/gitea.git","clone_url":"https://github.com/JonasFranzDEV/gitea.git","svn_url":"https://github.com/JonasFranzDEV/gitea","homepage":"http://gitea.io","size":113517,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lafriks:feat/approval","ref":"feat/approval","sha":"85e1ad593af5683a6b06db5b11a174b14308eff4","user":{"login":"lafriks","id":165205,"avatar_url":"https://avatars2.githubusercontent.com/u/165205?v=4","gravatar_id":"","url":"https://api.github.com/users/lafriks","html_url":"https://github.com/lafriks","followers_url":"https://api.github.com/users/lafriks/followers","following_url":"https://api.github.com/users/lafriks/following{/other_user}","gists_url":"https://api.github.com/users/lafriks/gists{/gist_id}","starred_url":"https://api.github.com/users/lafriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lafriks/subscriptions","organizations_url":"https://api.github.com/users/lafriks/orgs","repos_url":"https://api.github.com/users/lafriks/repos","events_url":"https://api.github.com/users/lafriks/events{/privacy}","received_events_url":"https://api.github.com/users/lafriks/received_events","type":"User","site_admin":false},"repo":{"id":87738532,"name":"gitea","full_name":"lafriks/gitea","owner":{"login":"lafriks","id":165205,"avatar_url":"https://avatars2.githubusercontent.com/u/165205?v=4","gravatar_id":"","url":"https://api.github.com/users/lafriks","html_url":"https://github.com/lafriks","followers_url":"https://api.github.com/users/lafriks/followers","following_url":"https://api.github.com/users/lafriks/following{/other_user}","gists_url":"https://api.github.com/users/lafriks/gists{/gist_id}","starred_url":"https://api.github.com/users/lafriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lafriks/subscriptions","organizations_url":"https://api.github.com/users/lafriks/orgs","repos_url":"https://api.github.com/users/lafriks/repos","events_url":"https://api.github.com/users/lafriks/events{/privacy}","received_events_url":"https://api.github.com/users/lafriks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lafriks/gitea","description":"Gitea: Git with a cup of tea","fork":true,"url":"https://api.github.com/repos/lafriks/gitea","forks_url":"https://api.github.com/repos/lafriks/gitea/forks","keys_url":"https://api.github.com/repos/lafriks/gitea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lafriks/gitea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lafriks/gitea/teams","hooks_url":"https://api.github.com/repos/lafriks/gitea/hooks","issue_events_url":"https://api.github.com/repos/lafriks/gitea/issues/events{/number}","events_url":"https://api.github.com/repos/lafriks/gitea/events","assignees_url":"https://api.github.com/repos/lafriks/gitea/assignees{/user}","branches_url":"https://api.github.com/repos/lafriks/gitea/branches{/branch}","tags_url":"https://api.github.com/repos/lafriks/gitea/tags","blobs_url":"https://api.github.com/repos/lafriks/gitea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lafriks/gitea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lafriks/gitea/git/refs{/sha}","trees_url":"https://api.github.com/repos/lafriks/gitea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lafriks/gitea/statuses/{sha}","languages_url":"https://api.github.com/repos/lafriks/gitea/languages","stargazers_url":"https://api.github.com/repos/lafriks/gitea/stargazers","contributors_url":"https://api.github.com/repos/lafriks/gitea/contributors","subscribers_url":"https://api.github.com/repos/lafriks/gitea/subscribers","subscription_url":"https://api.github.com/repos/lafriks/gitea/subscription","commits_url":"https://api.github.com/repos/lafriks/gitea/commits{/sha}","git_commits_url":"https://api.github.com/repos/lafriks/gitea/git/commits{/sha}","comments_url":"https://api.github.com/repos/lafriks/gitea/comments{/number}","issue_comment_url":"https://api.github.com/repos/lafriks/gitea/issues/comments{/number}","contents_url":"https://api.github.com/repos/lafriks/gitea/contents/{+path}","compare_url":"https://api.github.com/repos/lafriks/gitea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lafriks/gitea/merges","archive_url":"https://api.github.com/repos/lafriks/gitea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lafriks/gitea/downloads","issues_url":"https://api.github.com/repos/lafriks/gitea/issues{/number}","pulls_url":"https://api.github.com/repos/lafriks/gitea/pulls{/number}","milestones_url":"https://api.github.com/repos/lafriks/gitea/milestones{/number}","notifications_url":"https://api.github.com/repos/lafriks/gitea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lafriks/gitea/labels{/name}","releases_url":"https://api.github.com/repos/lafriks/gitea/releases{/id}","deployments_url":"https://api.github.com/repos/lafriks/gitea/deployments","created_at":"2017-04-09T20:57:47Z","updated_at":"2018-05-12T18:02:14Z","pushed_at":"2018-05-13T20:09:00Z","git_url":"git://github.com/lafriks/gitea.git","ssh_url":"git@github.com:lafriks/gitea.git","clone_url":"https://github.com/lafriks/gitea.git","svn_url":"https://github.com/lafriks/gitea","homepage":"http://gitea.io","size":114263,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lafriks/gitea/pulls/2"},"html":{"href":"https://github.com/lafriks/gitea/pull/2"},"issue":{"href":"https://api.github.com/repos/lafriks/gitea/issues/2"},"comments":{"href":"https://api.github.com/repos/lafriks/gitea/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/lafriks/gitea/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/lafriks/gitea/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lafriks/gitea/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/lafriks/gitea/statuses/cbdd8c9da73e6f3c866cb418e0d6cd301a4b46cb"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lafriks","id":165205,"avatar_url":"https://avatars2.githubusercontent.com/u/165205?v=4","gravatar_id":"","url":"https://api.github.com/users/lafriks","html_url":"https://github.com/lafriks","followers_url":"https://api.github.com/users/lafriks/followers","following_url":"https://api.github.com/users/lafriks/following{/other_user}","gists_url":"https://api.github.com/users/lafriks/gists{/gist_id}","starred_url":"https://api.github.com/users/lafriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lafriks/subscriptions","organizations_url":"https://api.github.com/users/lafriks/orgs","repos_url":"https://api.github.com/users/lafriks/repos","events_url":"https://api.github.com/users/lafriks/events{/privacy}","received_events_url":"https://api.github.com/users/lafriks/received_events","type":"User","site_admin":false},"comments":4,"review_comments":4,"maintainer_can_modify":false,"commits":18,"additions":1148,"deletions":62,"changed_files":33}}
{"actor":{"display_login":"lafriks"}}