{"action":"created","issue":{"url":"https://api.github.com/repos/pypa/pip/issues/4857","repository_url":"https://api.github.com/repos/pypa/pip","labels_url":"https://api.github.com/repos/pypa/pip/issues/4857/labels{/name}","comments_url":"https://api.github.com/repos/pypa/pip/issues/4857/comments","events_url":"https://api.github.com/repos/pypa/pip/issues/4857/events","html_url":"https://github.com/pypa/pip/pull/4857","id":273174310,"node_id":"MDExOlB1bGxSZXF1ZXN0MTUyMDczOTIw","number":4857,"title":"Add Perforce as supported VCS","user":{"login":"barneygale","id":960340,"node_id":"MDQ6VXNlcjk2MDM0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/960340?v=4","gravatar_id":"","url":"https://api.github.com/users/barneygale","html_url":"https://github.com/barneygale","followers_url":"https://api.github.com/users/barneygale/followers","following_url":"https://api.github.com/users/barneygale/following{/other_user}","gists_url":"https://api.github.com/users/barneygale/gists{/gist_id}","starred_url":"https://api.github.com/users/barneygale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barneygale/subscriptions","organizations_url":"https://api.github.com/users/barneygale/orgs","repos_url":"https://api.github.com/users/barneygale/repos","events_url":"https://api.github.com/users/barneygale/events{/privacy}","received_events_url":"https://api.github.com/users/barneygale/received_events","type":"User","site_admin":false},"labels":[{"id":51169082,"node_id":"MDU6TGFiZWw1MTE2OTA4Mg==","url":"https://api.github.com/repos/pypa/pip/labels/C:%20vcs","name":"C: vcs","color":"0052cc","default":false},{"id":729243948,"node_id":"MDU6TGFiZWw3MjkyNDM5NDg=","url":"https://api.github.com/repos/pypa/pip/labels/T:%20feature%20request","name":"T: feature request","color":"f4e23d","default":false},{"id":574088290,"node_id":"MDU6TGFiZWw1NzQwODgyOTA=","url":"https://api.github.com/repos/pypa/pip/labels/needs%20rebase%20or%20merge","name":"needs rebase or merge","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/pypa/pip/milestones/26","html_url":"https://github.com/pypa/pip/milestone/26","labels_url":"https://api.github.com/repos/pypa/pip/milestones/26/labels","id":3232863,"node_id":"MDk6TWlsZXN0b25lMzIzMjg2Mw==","number":26,"title":"18.0","description":"","creator":{"login":"dstufft","id":145979,"node_id":"MDQ6VXNlcjE0NTk3OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/145979?v=4","gravatar_id":"","url":"https://api.github.com/users/dstufft","html_url":"https://github.com/dstufft","followers_url":"https://api.github.com/users/dstufft/followers","following_url":"https://api.github.com/users/dstufft/following{/other_user}","gists_url":"https://api.github.com/users/dstufft/gists{/gist_id}","starred_url":"https://api.github.com/users/dstufft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstufft/subscriptions","organizations_url":"https://api.github.com/users/dstufft/orgs","repos_url":"https://api.github.com/users/dstufft/repos","events_url":"https://api.github.com/users/dstufft/events{/privacy}","received_events_url":"https://api.github.com/users/dstufft/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":14,"state":"open","created_at":"2018-03-31T19:35:56Z","updated_at":"2018-06-21T17:30:21Z","due_on":"2018-07-02T07:00:00Z","closed_at":null},"comments":43,"created_at":"2017-11-11T20:36:13Z","updated_at":"2018-06-22T21:11:24Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/pypa/pip/pulls/4857","html_url":"https://github.com/pypa/pip/pull/4857","diff_url":"https://github.com/pypa/pip/pull/4857.diff","patch_url":"https://github.com/pypa/pip/pull/4857.patch"},"body":"This PR is a first pass on supporting the Perforce VCS, as described in #2754.\r\n\r\nStill to-do:\r\n\r\n- [x] Better client name generation\r\n- [x] Testing on Windows and Mac\r\n- [x] Automated tests\r\n\r\nNotes:\r\n\r\n- `controls_location()` always returns `False`, and hence installations from the local filesystem are impossible. As such every installation is a fresh sync from the remote depot. I *think* this makes sense for perforce - keen to hear usecases for anything else.\r\n- `p4 client` won't accept a client specification using a command-line argument. It *can* accept one on stdin, but `pip`'s command-runner doesn't currently support passing data to stdin. For the timebeing I've worked around this by writing the client spec to a temporary file, and then setting `P4EDITOR` to copy that file. Happy to consider other approaches.\r\n\r\nI hope this is along the right lines?"},"comment":{"url":"https://api.github.com/repos/pypa/pip/issues/comments/399583342","html_url":"https://github.com/pypa/pip/pull/4857#issuecomment-399583342","issue_url":"https://api.github.com/repos/pypa/pip/issues/4857","id":399583342,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTU4MzM0Mg==","user":{"login":"barneygale","id":960340,"node_id":"MDQ6VXNlcjk2MDM0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/960340?v=4","gravatar_id":"","url":"https://api.github.com/users/barneygale","html_url":"https://github.com/barneygale","followers_url":"https://api.github.com/users/barneygale/followers","following_url":"https://api.github.com/users/barneygale/following{/other_user}","gists_url":"https://api.github.com/users/barneygale/gists{/gist_id}","starred_url":"https://api.github.com/users/barneygale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barneygale/subscriptions","organizations_url":"https://api.github.com/users/barneygale/orgs","repos_url":"https://api.github.com/users/barneygale/repos","events_url":"https://api.github.com/users/barneygale/events{/privacy}","received_events_url":"https://api.github.com/users/barneygale/received_events","type":"User","site_admin":false},"created_at":"2018-06-22T21:11:24Z","updated_at":"2018-06-22T21:11:24Z","author_association":"NONE","body":"I got to know some of the VCS code while writing this patch, so I might be useful as a collaborator or reviewer for a VCS entry point proposal/patch. \r\n\r\nIt's worth considering whether the current API (`update()`, `export()` etc) is suitable - the SVN code is fine but the git code has plenty of special cases. The abstractions (`VersionControl`, `RevOption`) are a bit wonky and it looks like things have been tacked on for backwards compatibility - which isn't in itself a bad thing. *If* the entry points proposal would make breaking changes, but if it did I reckon it's worth taking another look at the API rather than simply wrapping what's there."}}
{"actor":{"display_login":"barneygale"}}