{"action":"created","comment":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/comments/172396479","pull_request_review_id":101404881,"id":172396479,"diff_hunk":"@@ -39,6 +39,10 @@ type Options struct {\n \t// For example, http://localhost:14268.\n \tEndpoint string\n \n+\t// LocalAgentHostPort instructs exporter to send spans to jaeger-agent at this address.\n+\t// For example, localhost:6831.\n+\tLocalAgentHostPort string","path":"exporter/jaeger/jaeger.go","position":6,"original_position":6,"commit_id":"cacaca22227da1536d6a3e8571115c4d56c4ee9d","original_commit_id":"cacaca22227da1536d6a3e8571115c4d56c4ee9d","user":{"login":"rakyll","id":108380,"avatar_url":"https://avatars0.githubusercontent.com/u/108380?v=4","gravatar_id":"","url":"https://api.github.com/users/rakyll","html_url":"https://github.com/rakyll","followers_url":"https://api.github.com/users/rakyll/followers","following_url":"https://api.github.com/users/rakyll/following{/other_user}","gists_url":"https://api.github.com/users/rakyll/gists{/gist_id}","starred_url":"https://api.github.com/users/rakyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakyll/subscriptions","organizations_url":"https://api.github.com/users/rakyll/orgs","repos_url":"https://api.github.com/users/rakyll/repos","events_url":"https://api.github.com/users/rakyll/events{/privacy}","received_events_url":"https://api.github.com/users/rakyll/received_events","type":"User","site_admin":false},"body":"Can we call this AgentEndpoint? As far as, I can understand, agent can work on UDP and TCP. Don't we need to give options to the user? \r\n\r\nMaybe it might make sense to have a net.Conn field.\r\n\r\n// ...\r\nAgentConn *net.Conn\r\n\r\nThen, user can dial it themselves:\r\n\r\nconn, err := net.Dial(\"tcp\", \"endpoint:port\")\r\n\r\nand we can type cast conn to see whether we should use the UDP or TCP endpoint.","created_at":"2018-03-06T02:53:58Z","updated_at":"2018-03-06T02:55:29Z","html_url":"https://github.com/census-instrumentation/opencensus-go/pull/518#discussion_r172396479","pull_request_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/518","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/comments/172396479"},"html":{"href":"https://github.com/census-instrumentation/opencensus-go/pull/518#discussion_r172396479"},"pull_request":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/518"}}},"pull_request":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/518","id":172821901,"html_url":"https://github.com/census-instrumentation/opencensus-go/pull/518","diff_url":"https://github.com/census-instrumentation/opencensus-go/pull/518.diff","patch_url":"https://github.com/census-instrumentation/opencensus-go/pull/518.patch","issue_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/issues/518","number":518,"state":"open","locked":false,"title":"support jaeger agent export","user":{"login":"oiooj","id":2253095,"avatar_url":"https://avatars3.githubusercontent.com/u/2253095?v=4","gravatar_id":"","url":"https://api.github.com/users/oiooj","html_url":"https://github.com/oiooj","followers_url":"https://api.github.com/users/oiooj/followers","following_url":"https://api.github.com/users/oiooj/following{/other_user}","gists_url":"https://api.github.com/users/oiooj/gists{/gist_id}","starred_url":"https://api.github.com/users/oiooj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oiooj/subscriptions","organizations_url":"https://api.github.com/users/oiooj/orgs","repos_url":"https://api.github.com/users/oiooj/repos","events_url":"https://api.github.com/users/oiooj/events{/privacy}","received_events_url":"https://api.github.com/users/oiooj/received_events","type":"User","site_admin":false},"body":"Almost users use jaeger agent to report trace data.","created_at":"2018-03-05T10:05:34Z","updated_at":"2018-03-06T02:55:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af820b798f2f2696b2b7a876c0211005abcc4534","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/518/commits","review_comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/518/comments","review_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/issues/518/comments","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/statuses/cacaca22227da1536d6a3e8571115c4d56c4ee9d","head":{"label":"oiooj:pr-jaeger-client","ref":"pr-jaeger-client","sha":"cacaca22227da1536d6a3e8571115c4d56c4ee9d","user":{"login":"oiooj","id":2253095,"avatar_url":"https://avatars3.githubusercontent.com/u/2253095?v=4","gravatar_id":"","url":"https://api.github.com/users/oiooj","html_url":"https://github.com/oiooj","followers_url":"https://api.github.com/users/oiooj/followers","following_url":"https://api.github.com/users/oiooj/following{/other_user}","gists_url":"https://api.github.com/users/oiooj/gists{/gist_id}","starred_url":"https://api.github.com/users/oiooj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oiooj/subscriptions","organizations_url":"https://api.github.com/users/oiooj/orgs","repos_url":"https://api.github.com/users/oiooj/repos","events_url":"https://api.github.com/users/oiooj/events{/privacy}","received_events_url":"https://api.github.com/users/oiooj/received_events","type":"User","site_admin":false},"repo":{"id":123890751,"name":"opencensus-go","full_name":"oiooj/opencensus-go","owner":{"login":"oiooj","id":2253095,"avatar_url":"https://avatars3.githubusercontent.com/u/2253095?v=4","gravatar_id":"","url":"https://api.github.com/users/oiooj","html_url":"https://github.com/oiooj","followers_url":"https://api.github.com/users/oiooj/followers","following_url":"https://api.github.com/users/oiooj/following{/other_user}","gists_url":"https://api.github.com/users/oiooj/gists{/gist_id}","starred_url":"https://api.github.com/users/oiooj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oiooj/subscriptions","organizations_url":"https://api.github.com/users/oiooj/orgs","repos_url":"https://api.github.com/users/oiooj/repos","events_url":"https://api.github.com/users/oiooj/events{/privacy}","received_events_url":"https://api.github.com/users/oiooj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oiooj/opencensus-go","description":"A stats collection and distributed tracing framework","fork":true,"url":"https://api.github.com/repos/oiooj/opencensus-go","forks_url":"https://api.github.com/repos/oiooj/opencensus-go/forks","keys_url":"https://api.github.com/repos/oiooj/opencensus-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oiooj/opencensus-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oiooj/opencensus-go/teams","hooks_url":"https://api.github.com/repos/oiooj/opencensus-go/hooks","issue_events_url":"https://api.github.com/repos/oiooj/opencensus-go/issues/events{/number}","events_url":"https://api.github.com/repos/oiooj/opencensus-go/events","assignees_url":"https://api.github.com/repos/oiooj/opencensus-go/assignees{/user}","branches_url":"https://api.github.com/repos/oiooj/opencensus-go/branches{/branch}","tags_url":"https://api.github.com/repos/oiooj/opencensus-go/tags","blobs_url":"https://api.github.com/repos/oiooj/opencensus-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oiooj/opencensus-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oiooj/opencensus-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/oiooj/opencensus-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oiooj/opencensus-go/statuses/{sha}","languages_url":"https://api.github.com/repos/oiooj/opencensus-go/languages","stargazers_url":"https://api.github.com/repos/oiooj/opencensus-go/stargazers","contributors_url":"https://api.github.com/repos/oiooj/opencensus-go/contributors","subscribers_url":"https://api.github.com/repos/oiooj/opencensus-go/subscribers","subscription_url":"https://api.github.com/repos/oiooj/opencensus-go/subscription","commits_url":"https://api.github.com/repos/oiooj/opencensus-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/oiooj/opencensus-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/oiooj/opencensus-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/oiooj/opencensus-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/oiooj/opencensus-go/contents/{+path}","compare_url":"https://api.github.com/repos/oiooj/opencensus-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oiooj/opencensus-go/merges","archive_url":"https://api.github.com/repos/oiooj/opencensus-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oiooj/opencensus-go/downloads","issues_url":"https://api.github.com/repos/oiooj/opencensus-go/issues{/number}","pulls_url":"https://api.github.com/repos/oiooj/opencensus-go/pulls{/number}","milestones_url":"https://api.github.com/repos/oiooj/opencensus-go/milestones{/number}","notifications_url":"https://api.github.com/repos/oiooj/opencensus-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oiooj/opencensus-go/labels{/name}","releases_url":"https://api.github.com/repos/oiooj/opencensus-go/releases{/id}","deployments_url":"https://api.github.com/repos/oiooj/opencensus-go/deployments","created_at":"2018-03-05T08:46:25Z","updated_at":"2018-03-05T08:46:27Z","pushed_at":"2018-03-05T10:03:04Z","git_url":"git://github.com/oiooj/opencensus-go.git","ssh_url":"git@github.com:oiooj/opencensus-go.git","clone_url":"https://github.com/oiooj/opencensus-go.git","svn_url":"https://github.com/oiooj/opencensus-go","homepage":"http://opencensus.io","size":947,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"census-instrumentation:master","ref":"master","sha":"7f60c3679c2abfc3533f509355f2fc1d177be8d0","user":{"login":"census-instrumentation","id":26944525,"avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"repo":{"id":81387692,"name":"opencensus-go","full_name":"census-instrumentation/opencensus-go","owner":{"login":"census-instrumentation","id":26944525,"avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/census-instrumentation/opencensus-go","description":"A stats collection and distributed tracing framework","fork":false,"url":"https://api.github.com/repos/census-instrumentation/opencensus-go","forks_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/forks","keys_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/teams","hooks_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/hooks","issue_events_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/issues/events{/number}","events_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/events","assignees_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/assignees{/user}","branches_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/branches{/branch}","tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/tags","blobs_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/statuses/{sha}","languages_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/languages","stargazers_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/stargazers","contributors_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/contributors","subscribers_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/subscribers","subscription_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/subscription","commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/contents/{+path}","compare_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/merges","archive_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/downloads","issues_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/issues{/number}","pulls_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls{/number}","milestones_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/milestones{/number}","notifications_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/labels{/name}","releases_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/releases{/id}","deployments_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/deployments","created_at":"2017-02-08T23:40:07Z","updated_at":"2018-03-05T22:00:37Z","pushed_at":"2018-03-06T01:46:07Z","git_url":"git://github.com/census-instrumentation/opencensus-go.git","ssh_url":"git@github.com:census-instrumentation/opencensus-go.git","clone_url":"https://github.com/census-instrumentation/opencensus-go.git","svn_url":"https://github.com/census-instrumentation/opencensus-go","homepage":"http://opencensus.io","size":944,"stargazers_count":622,"watchers_count":622,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":62,"open_issues":49,"watchers":622,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/518"},"html":{"href":"https://github.com/census-instrumentation/opencensus-go/pull/518"},"issue":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/issues/518"},"comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/issues/518/comments"},"review_comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/518/comments"},"review_comment":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/518/commits"},"statuses":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/statuses/cacaca22227da1536d6a3e8571115c4d56c4ee9d"}},"author_association":"NONE"}}
{"actor":{"display_login":"rakyll"}}