{"action":"created","comment":{"url":"https://api.github.com/repos/commercetools/ui-kit/pulls/comments/240245112","pull_request_review_id":183229164,"id":240245112,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDI0NTExMg==","diff_hunk":"@@ -26,6 +26,7 @@ Wraps the given text in the given HTML header `size`.\n | `children`    | `PropTypes.node` |    ✅    | -                    | -       | -                                                              |\n | `title`       | `String`         |    -     | -                    | -       | Text to show in a tooltip on hover over the element            |\n | `truncate`    | `Bool`           |    -     | -                    | `false` | Option for truncate content in case the screen has small width |\n+| `dataTest`    | `String`         |    -     | -                    | -       | Prop for E2E testing                                           |","path":"src/components/typography/text/README.md","position":4,"original_position":4,"commit_id":"00e3e8209d14969aea578750b049576691a3ccbc","original_commit_id":"00e3e8209d14969aea578750b049576691a3ccbc","user":{"login":"montezume","id":2425013,"node_id":"MDQ6VXNlcjI0MjUwMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2425013?v=4","gravatar_id":"","url":"https://api.github.com/users/montezume","html_url":"https://github.com/montezume","followers_url":"https://api.github.com/users/montezume/followers","following_url":"https://api.github.com/users/montezume/following{/other_user}","gists_url":"https://api.github.com/users/montezume/gists{/gist_id}","starred_url":"https://api.github.com/users/montezume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montezume/subscriptions","organizations_url":"https://api.github.com/users/montezume/orgs","repos_url":"https://api.github.com/users/montezume/repos","events_url":"https://api.github.com/users/montezume/events{/privacy}","received_events_url":"https://api.github.com/users/montezume/received_events","type":"User","site_admin":false},"body":"instead of making a new prop, can you follow how it's done [here](https://github.com/commercetools/ui-kit/tree/master/src/components/inputs/text-input) in text-input?\r\n\r\nDon't add it to the table instead add \r\n```\r\nThe component further forwards all data- attributes to the underlying component.\r\n```","created_at":"2018-12-10T15:04:10Z","updated_at":"2018-12-10T15:05:26Z","html_url":"https://github.com/commercetools/ui-kit/pull/304#discussion_r240245112","pull_request_url":"https://api.github.com/repos/commercetools/ui-kit/pulls/304","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/commercetools/ui-kit/pulls/comments/240245112"},"html":{"href":"https://github.com/commercetools/ui-kit/pull/304#discussion_r240245112"},"pull_request":{"href":"https://api.github.com/repos/commercetools/ui-kit/pulls/304"}}},"pull_request":{"url":"https://api.github.com/repos/commercetools/ui-kit/pulls/304","id":237346571,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MzQ2NTcx","html_url":"https://github.com/commercetools/ui-kit/pull/304","diff_url":"https://github.com/commercetools/ui-kit/pull/304.diff","patch_url":"https://github.com/commercetools/ui-kit/pull/304.patch","issue_url":"https://api.github.com/repos/commercetools/ui-kit/issues/304","number":304,"state":"open","locked":false,"title":"Typography (Text): adding data test prop to text components","user":{"login":"NickDevG","id":29254006,"node_id":"MDQ6VXNlcjI5MjU0MDA2","avatar_url":"https://avatars2.githubusercontent.com/u/29254006?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDevG","html_url":"https://github.com/NickDevG","followers_url":"https://api.github.com/users/NickDevG/followers","following_url":"https://api.github.com/users/NickDevG/following{/other_user}","gists_url":"https://api.github.com/users/NickDevG/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDevG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDevG/subscriptions","organizations_url":"https://api.github.com/users/NickDevG/orgs","repos_url":"https://api.github.com/users/NickDevG/repos","events_url":"https://api.github.com/users/NickDevG/events{/privacy}","received_events_url":"https://api.github.com/users/NickDevG/received_events","type":"User","site_admin":false},"body":"#### Summary\r\nAdding `data-test` prop to every `Text` component.\r\n\r\n#### Description\r\nAdding `data-test` prop to avoid wrapping `Text` components for E2E tests ","created_at":"2018-12-10T14:48:50Z","updated_at":"2018-12-10T15:05:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c4ca306705a50115cfe9727f7d10b8f0188a411","assignee":{"login":"NickDevG","id":29254006,"node_id":"MDQ6VXNlcjI5MjU0MDA2","avatar_url":"https://avatars2.githubusercontent.com/u/29254006?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDevG","html_url":"https://github.com/NickDevG","followers_url":"https://api.github.com/users/NickDevG/followers","following_url":"https://api.github.com/users/NickDevG/following{/other_user}","gists_url":"https://api.github.com/users/NickDevG/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDevG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDevG/subscriptions","organizations_url":"https://api.github.com/users/NickDevG/orgs","repos_url":"https://api.github.com/users/NickDevG/repos","events_url":"https://api.github.com/users/NickDevG/events{/privacy}","received_events_url":"https://api.github.com/users/NickDevG/received_events","type":"User","site_admin":false},"assignees":[{"login":"NickDevG","id":29254006,"node_id":"MDQ6VXNlcjI5MjU0MDA2","avatar_url":"https://avatars2.githubusercontent.com/u/29254006?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDevG","html_url":"https://github.com/NickDevG","followers_url":"https://api.github.com/users/NickDevG/followers","following_url":"https://api.github.com/users/NickDevG/following{/other_user}","gists_url":"https://api.github.com/users/NickDevG/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDevG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDevG/subscriptions","organizations_url":"https://api.github.com/users/NickDevG/orgs","repos_url":"https://api.github.com/users/NickDevG/repos","events_url":"https://api.github.com/users/NickDevG/events{/privacy}","received_events_url":"https://api.github.com/users/NickDevG/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dferber90","id":1765075,"node_id":"MDQ6VXNlcjE3NjUwNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1765075?v=4","gravatar_id":"","url":"https://api.github.com/users/dferber90","html_url":"https://github.com/dferber90","followers_url":"https://api.github.com/users/dferber90/followers","following_url":"https://api.github.com/users/dferber90/following{/other_user}","gists_url":"https://api.github.com/users/dferber90/gists{/gist_id}","starred_url":"https://api.github.com/users/dferber90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dferber90/subscriptions","organizations_url":"https://api.github.com/users/dferber90/orgs","repos_url":"https://api.github.com/users/dferber90/repos","events_url":"https://api.github.com/users/dferber90/events{/privacy}","received_events_url":"https://api.github.com/users/dferber90/received_events","type":"User","site_admin":false},{"login":"tdeekens","id":1877073,"node_id":"MDQ6VXNlcjE4NzcwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1877073?v=4","gravatar_id":"","url":"https://api.github.com/users/tdeekens","html_url":"https://github.com/tdeekens","followers_url":"https://api.github.com/users/tdeekens/followers","following_url":"https://api.github.com/users/tdeekens/following{/other_user}","gists_url":"https://api.github.com/users/tdeekens/gists{/gist_id}","starred_url":"https://api.github.com/users/tdeekens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdeekens/subscriptions","organizations_url":"https://api.github.com/users/tdeekens/orgs","repos_url":"https://api.github.com/users/tdeekens/repos","events_url":"https://api.github.com/users/tdeekens/events{/privacy}","received_events_url":"https://api.github.com/users/tdeekens/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1045018183,"node_id":"MDU6TGFiZWwxMDQ1MDE4MTgz","url":"https://api.github.com/repos/commercetools/ui-kit/labels/%F0%9F%91%A8%E2%80%8D%F0%9F%91%A9%E2%80%8D%F0%9F%91%A6%E2%80%8D%F0%9F%91%A6%20Status:%20Dev%20Review","name":"👨‍👩‍👦‍👦 Status: Dev Review","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/commercetools/ui-kit/pulls/304/commits","review_comments_url":"https://api.github.com/repos/commercetools/ui-kit/pulls/304/comments","review_comment_url":"https://api.github.com/repos/commercetools/ui-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/commercetools/ui-kit/issues/304/comments","statuses_url":"https://api.github.com/repos/commercetools/ui-kit/statuses/00e3e8209d14969aea578750b049576691a3ccbc","head":{"label":"commercetools:nl-adding-data-test-prop-for-text-components","ref":"nl-adding-data-test-prop-for-text-components","sha":"00e3e8209d14969aea578750b049576691a3ccbc","user":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":146916092,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5MTYwOTI=","name":"ui-kit","full_name":"commercetools/ui-kit","private":false,"owner":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/commercetools/ui-kit","description":"Component library 💅","fork":false,"url":"https://api.github.com/repos/commercetools/ui-kit","forks_url":"https://api.github.com/repos/commercetools/ui-kit/forks","keys_url":"https://api.github.com/repos/commercetools/ui-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/ui-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/ui-kit/teams","hooks_url":"https://api.github.com/repos/commercetools/ui-kit/hooks","issue_events_url":"https://api.github.com/repos/commercetools/ui-kit/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/ui-kit/events","assignees_url":"https://api.github.com/repos/commercetools/ui-kit/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/ui-kit/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/ui-kit/tags","blobs_url":"https://api.github.com/repos/commercetools/ui-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/ui-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/ui-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/ui-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/ui-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/ui-kit/languages","stargazers_url":"https://api.github.com/repos/commercetools/ui-kit/stargazers","contributors_url":"https://api.github.com/repos/commercetools/ui-kit/contributors","subscribers_url":"https://api.github.com/repos/commercetools/ui-kit/subscribers","subscription_url":"https://api.github.com/repos/commercetools/ui-kit/subscription","commits_url":"https://api.github.com/repos/commercetools/ui-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/ui-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/ui-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/ui-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/ui-kit/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/ui-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/ui-kit/merges","archive_url":"https://api.github.com/repos/commercetools/ui-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/ui-kit/downloads","issues_url":"https://api.github.com/repos/commercetools/ui-kit/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/ui-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/ui-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/ui-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/ui-kit/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/ui-kit/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/ui-kit/deployments","created_at":"2018-08-31T16:20:21Z","updated_at":"2018-12-10T12:38:14Z","pushed_at":"2018-12-10T14:48:50Z","git_url":"git://github.com/commercetools/ui-kit.git","ssh_url":"git@github.com:commercetools/ui-kit.git","clone_url":"https://github.com/commercetools/ui-kit.git","svn_url":"https://github.com/commercetools/ui-kit","homepage":"https://uikit.commercetools.com","size":3629,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":14,"watchers":7,"default_branch":"master"}},"base":{"label":"commercetools:master","ref":"master","sha":"a0229f27c001dae91912d54811106eb55db5838b","user":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":146916092,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5MTYwOTI=","name":"ui-kit","full_name":"commercetools/ui-kit","private":false,"owner":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/commercetools/ui-kit","description":"Component library 💅","fork":false,"url":"https://api.github.com/repos/commercetools/ui-kit","forks_url":"https://api.github.com/repos/commercetools/ui-kit/forks","keys_url":"https://api.github.com/repos/commercetools/ui-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/ui-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/ui-kit/teams","hooks_url":"https://api.github.com/repos/commercetools/ui-kit/hooks","issue_events_url":"https://api.github.com/repos/commercetools/ui-kit/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/ui-kit/events","assignees_url":"https://api.github.com/repos/commercetools/ui-kit/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/ui-kit/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/ui-kit/tags","blobs_url":"https://api.github.com/repos/commercetools/ui-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/ui-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/ui-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/ui-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/ui-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/ui-kit/languages","stargazers_url":"https://api.github.com/repos/commercetools/ui-kit/stargazers","contributors_url":"https://api.github.com/repos/commercetools/ui-kit/contributors","subscribers_url":"https://api.github.com/repos/commercetools/ui-kit/subscribers","subscription_url":"https://api.github.com/repos/commercetools/ui-kit/subscription","commits_url":"https://api.github.com/repos/commercetools/ui-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/ui-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/ui-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/ui-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/ui-kit/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/ui-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/ui-kit/merges","archive_url":"https://api.github.com/repos/commercetools/ui-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/ui-kit/downloads","issues_url":"https://api.github.com/repos/commercetools/ui-kit/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/ui-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/ui-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/ui-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/ui-kit/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/ui-kit/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/ui-kit/deployments","created_at":"2018-08-31T16:20:21Z","updated_at":"2018-12-10T12:38:14Z","pushed_at":"2018-12-10T14:48:50Z","git_url":"git://github.com/commercetools/ui-kit.git","ssh_url":"git@github.com:commercetools/ui-kit.git","clone_url":"https://github.com/commercetools/ui-kit.git","svn_url":"https://github.com/commercetools/ui-kit","homepage":"https://uikit.commercetools.com","size":3629,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":14,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/commercetools/ui-kit/pulls/304"},"html":{"href":"https://github.com/commercetools/ui-kit/pull/304"},"issue":{"href":"https://api.github.com/repos/commercetools/ui-kit/issues/304"},"comments":{"href":"https://api.github.com/repos/commercetools/ui-kit/issues/304/comments"},"review_comments":{"href":"https://api.github.com/repos/commercetools/ui-kit/pulls/304/comments"},"review_comment":{"href":"https://api.github.com/repos/commercetools/ui-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/commercetools/ui-kit/pulls/304/commits"},"statuses":{"href":"https://api.github.com/repos/commercetools/ui-kit/statuses/00e3e8209d14969aea578750b049576691a3ccbc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"montezume"}}