{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/help-to-save-api/pulls/comments/233386825","pull_request_review_id":174785629,"id":233386825,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzM4NjgyNQ==","diff_hunk":"@@ -141,24 +141,34 @@ class HelpToSaveApiServiceImpl @Inject() (val helpToSaveConnector:       HelpToS\n       case CreateAccountRequest(header, body) ⇒\n \n         if (retrievedNINO.forall(_ === body.nino)) {\n-          validateCorrelationId(header.requestCorrelationId, body.nino).flatMap {\n+\n+          val eligibilityCheckResponseFuture = validateCorrelationId(header.requestCorrelationId, body.nino)\n+          val validateBankDetailsFuture = validateBankDetails(body.nino, body.bankDetails)","path":"app/uk/gov/hmrc/helptosaveapi/services/HelpToSaveApiService.scala","position":31,"original_position":31,"commit_id":"9655022c610b7c30f96b80f9378a64785c049d4d","original_commit_id":"9655022c610b7c30f96b80f9378a64785c049d4d","user":{"login":"sureshhmrc","id":27204388,"node_id":"MDQ6VXNlcjI3MjA0Mzg4","avatar_url":"https://avatars2.githubusercontent.com/u/27204388?v=4","gravatar_id":"","url":"https://api.github.com/users/sureshhmrc","html_url":"https://github.com/sureshhmrc","followers_url":"https://api.github.com/users/sureshhmrc/followers","following_url":"https://api.github.com/users/sureshhmrc/following{/other_user}","gists_url":"https://api.github.com/users/sureshhmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/sureshhmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sureshhmrc/subscriptions","organizations_url":"https://api.github.com/users/sureshhmrc/orgs","repos_url":"https://api.github.com/users/sureshhmrc/repos","events_url":"https://api.github.com/users/sureshhmrc/events{/privacy}","received_events_url":"https://api.github.com/users/sureshhmrc/received_events","type":"User","site_admin":false},"body":"yes, i thought about it but those error cases are very low compared to happy path cases - so firing two Futures independently here is efficient instead of firing them one after another inside during happy path flow ? what do you suggest ? ","created_at":"2018-11-14T10:17:13Z","updated_at":"2018-11-14T10:17:14Z","html_url":"https://github.com/hmrc/help-to-save-api/pull/125#discussion_r233386825","pull_request_url":"https://api.github.com/repos/hmrc/help-to-save-api/pulls/125","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmrc/help-to-save-api/pulls/comments/233386825"},"html":{"href":"https://github.com/hmrc/help-to-save-api/pull/125#discussion_r233386825"},"pull_request":{"href":"https://api.github.com/repos/hmrc/help-to-save-api/pulls/125"}},"in_reply_to_id":233385114},"pull_request":{"url":"https://api.github.com/repos/hmrc/help-to-save-api/pulls/125","id":230076123,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMDc2MTIz","html_url":"https://github.com/hmrc/help-to-save-api/pull/125","diff_url":"https://github.com/hmrc/help-to-save-api/pull/125.diff","patch_url":"https://github.com/hmrc/help-to-save-api/pull/125.patch","issue_url":"https://api.github.com/repos/hmrc/help-to-save-api/issues/125","number":125,"state":"open","locked":false,"title":"HTS-1334: Added BankDetails Validation during create account","user":{"login":"sureshhmrc","id":27204388,"node_id":"MDQ6VXNlcjI3MjA0Mzg4","avatar_url":"https://avatars2.githubusercontent.com/u/27204388?v=4","gravatar_id":"","url":"https://api.github.com/users/sureshhmrc","html_url":"https://github.com/sureshhmrc","followers_url":"https://api.github.com/users/sureshhmrc/followers","following_url":"https://api.github.com/users/sureshhmrc/following{/other_user}","gists_url":"https://api.github.com/users/sureshhmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/sureshhmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sureshhmrc/subscriptions","organizations_url":"https://api.github.com/users/sureshhmrc/orgs","repos_url":"https://api.github.com/users/sureshhmrc/repos","events_url":"https://api.github.com/users/sureshhmrc/events{/privacy}","received_events_url":"https://api.github.com/users/sureshhmrc/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-12T09:59:13Z","updated_at":"2018-11-14T10:17:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ccbc541efb27ec54da5d937c005f523567a6de3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/help-to-save-api/pulls/125/commits","review_comments_url":"https://api.github.com/repos/hmrc/help-to-save-api/pulls/125/comments","review_comment_url":"https://api.github.com/repos/hmrc/help-to-save-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/help-to-save-api/issues/125/comments","statuses_url":"https://api.github.com/repos/hmrc/help-to-save-api/statuses/9655022c610b7c30f96b80f9378a64785c049d4d","head":{"label":"hmrc:hts-1334","ref":"hts-1334","sha":"9655022c610b7c30f96b80f9378a64785c049d4d","user":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":117255489,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcyNTU0ODk=","name":"help-to-save-api","full_name":"hmrc/help-to-save-api","private":false,"owner":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmrc/help-to-save-api","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/help-to-save-api","forks_url":"https://api.github.com/repos/hmrc/help-to-save-api/forks","keys_url":"https://api.github.com/repos/hmrc/help-to-save-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/help-to-save-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/help-to-save-api/teams","hooks_url":"https://api.github.com/repos/hmrc/help-to-save-api/hooks","issue_events_url":"https://api.github.com/repos/hmrc/help-to-save-api/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/help-to-save-api/events","assignees_url":"https://api.github.com/repos/hmrc/help-to-save-api/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/help-to-save-api/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/help-to-save-api/tags","blobs_url":"https://api.github.com/repos/hmrc/help-to-save-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/help-to-save-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/help-to-save-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/help-to-save-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/help-to-save-api/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/help-to-save-api/languages","stargazers_url":"https://api.github.com/repos/hmrc/help-to-save-api/stargazers","contributors_url":"https://api.github.com/repos/hmrc/help-to-save-api/contributors","subscribers_url":"https://api.github.com/repos/hmrc/help-to-save-api/subscribers","subscription_url":"https://api.github.com/repos/hmrc/help-to-save-api/subscription","commits_url":"https://api.github.com/repos/hmrc/help-to-save-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/help-to-save-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/help-to-save-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/help-to-save-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/help-to-save-api/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/help-to-save-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/help-to-save-api/merges","archive_url":"https://api.github.com/repos/hmrc/help-to-save-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/help-to-save-api/downloads","issues_url":"https://api.github.com/repos/hmrc/help-to-save-api/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/help-to-save-api/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/help-to-save-api/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/help-to-save-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/help-to-save-api/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/help-to-save-api/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/help-to-save-api/deployments","created_at":"2018-01-12T15:13:32Z","updated_at":"2018-10-30T16:41:38Z","pushed_at":"2018-11-13T12:06:52Z","git_url":"git://github.com/hmrc/help-to-save-api.git","ssh_url":"git@github.com:hmrc/help-to-save-api.git","clone_url":"https://github.com/hmrc/help-to-save-api.git","svn_url":"https://github.com/hmrc/help-to-save-api","homepage":"","size":398,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"698cfca1a3de3890b2756bd38b26dfdfbc517b29","user":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":117255489,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcyNTU0ODk=","name":"help-to-save-api","full_name":"hmrc/help-to-save-api","private":false,"owner":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmrc/help-to-save-api","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/help-to-save-api","forks_url":"https://api.github.com/repos/hmrc/help-to-save-api/forks","keys_url":"https://api.github.com/repos/hmrc/help-to-save-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/help-to-save-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/help-to-save-api/teams","hooks_url":"https://api.github.com/repos/hmrc/help-to-save-api/hooks","issue_events_url":"https://api.github.com/repos/hmrc/help-to-save-api/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/help-to-save-api/events","assignees_url":"https://api.github.com/repos/hmrc/help-to-save-api/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/help-to-save-api/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/help-to-save-api/tags","blobs_url":"https://api.github.com/repos/hmrc/help-to-save-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/help-to-save-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/help-to-save-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/help-to-save-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/help-to-save-api/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/help-to-save-api/languages","stargazers_url":"https://api.github.com/repos/hmrc/help-to-save-api/stargazers","contributors_url":"https://api.github.com/repos/hmrc/help-to-save-api/contributors","subscribers_url":"https://api.github.com/repos/hmrc/help-to-save-api/subscribers","subscription_url":"https://api.github.com/repos/hmrc/help-to-save-api/subscription","commits_url":"https://api.github.com/repos/hmrc/help-to-save-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/help-to-save-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/help-to-save-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/help-to-save-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/help-to-save-api/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/help-to-save-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/help-to-save-api/merges","archive_url":"https://api.github.com/repos/hmrc/help-to-save-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/help-to-save-api/downloads","issues_url":"https://api.github.com/repos/hmrc/help-to-save-api/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/help-to-save-api/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/help-to-save-api/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/help-to-save-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/help-to-save-api/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/help-to-save-api/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/help-to-save-api/deployments","created_at":"2018-01-12T15:13:32Z","updated_at":"2018-10-30T16:41:38Z","pushed_at":"2018-11-13T12:06:52Z","git_url":"git://github.com/hmrc/help-to-save-api.git","ssh_url":"git@github.com:hmrc/help-to-save-api.git","clone_url":"https://github.com/hmrc/help-to-save-api.git","svn_url":"https://github.com/hmrc/help-to-save-api","homepage":"","size":398,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/help-to-save-api/pulls/125"},"html":{"href":"https://github.com/hmrc/help-to-save-api/pull/125"},"issue":{"href":"https://api.github.com/repos/hmrc/help-to-save-api/issues/125"},"comments":{"href":"https://api.github.com/repos/hmrc/help-to-save-api/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/help-to-save-api/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/help-to-save-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/help-to-save-api/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/help-to-save-api/statuses/9655022c610b7c30f96b80f9378a64785c049d4d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sureshhmrc"}}