{"action":"created","issue":{"url":"https://api.github.com/repos/Hammerspoon/hammerspoon/issues/1953","repository_url":"https://api.github.com/repos/Hammerspoon/hammerspoon","labels_url":"https://api.github.com/repos/Hammerspoon/hammerspoon/issues/1953/labels{/name}","comments_url":"https://api.github.com/repos/Hammerspoon/hammerspoon/issues/1953/comments","events_url":"https://api.github.com/repos/Hammerspoon/hammerspoon/issues/1953/events","html_url":"https://github.com/Hammerspoon/hammerspoon/pull/1953","id":365740249,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTg1MTUx","number":1953,"title":"wrap cstring->NSString shortcuts to prevent compile errors in Xcode 10","user":{"login":"asmagill","id":8139480,"node_id":"MDQ6VXNlcjgxMzk0ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/8139480?v=4","gravatar_id":"","url":"https://api.github.com/users/asmagill","html_url":"https://github.com/asmagill","followers_url":"https://api.github.com/users/asmagill/followers","following_url":"https://api.github.com/users/asmagill/following{/other_user}","gists_url":"https://api.github.com/users/asmagill/gists{/gist_id}","starred_url":"https://api.github.com/users/asmagill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmagill/subscriptions","organizations_url":"https://api.github.com/users/asmagill/orgs","repos_url":"https://api.github.com/users/asmagill/repos","events_url":"https://api.github.com/users/asmagill/events{/privacy}","received_events_url":"https://api.github.com/users/asmagill/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-02T04:51:33Z","updated_at":"2018-10-16T16:49:05Z","closed_at":"2018-10-16T16:49:05Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Hammerspoon/hammerspoon/pulls/1953","html_url":"https://github.com/Hammerspoon/hammerspoon/pull/1953","diff_url":"https://github.com/Hammerspoon/hammerspoon/pull/1953.diff","patch_url":"https://github.com/Hammerspoon/hammerspoon/pull/1953.patch"},"body":"The use of `@(cstring)` as a shortcut to converting a c style string to an objective-c one is considered nullable in Xcode 10 which prevents its use where non-nullable is required (e.g. as NSDictionary keys). This corrects that.\r\n\r\nTo compile under Xcode 10, you will also need to apply #1941 to the master branch.\r\n\r\nI have not really tested this -- my setup loads and I haven't noticed any new warnings or loss of functionality, but that's not really a formal testing methodology 😜\r\n\r\nOther Xcode 10/Mojave tweaks may follow, but I wanted to get this out to address #1944 so others can continue testing and working."},"comment":{"url":"https://api.github.com/repos/Hammerspoon/hammerspoon/issues/comments/430311926","html_url":"https://github.com/Hammerspoon/hammerspoon/pull/1953#issuecomment-430311926","issue_url":"https://api.github.com/repos/Hammerspoon/hammerspoon/issues/1953","id":430311926,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDMxMTkyNg==","user":{"login":"cmsj","id":353427,"node_id":"MDQ6VXNlcjM1MzQyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/353427?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsj","html_url":"https://github.com/cmsj","followers_url":"https://api.github.com/users/cmsj/followers","following_url":"https://api.github.com/users/cmsj/following{/other_user}","gists_url":"https://api.github.com/users/cmsj/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsj/subscriptions","organizations_url":"https://api.github.com/users/cmsj/orgs","repos_url":"https://api.github.com/users/cmsj/repos","events_url":"https://api.github.com/users/cmsj/events{/privacy}","received_events_url":"https://api.github.com/users/cmsj/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T16:49:05Z","updated_at":"2018-10-16T16:49:05Z","author_association":"MEMBER","body":"Apologies, I fixed this without realising you'd already pushed a PR :/"}}
{"actor":{"display_login":"cmsj"}}