{"action":"created","comment":{"url":"https://api.github.com/repos/learndot/eks-cfn/pulls/comments/241300493","pull_request_review_id":184536264,"id":241300493,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTMwMDQ5Mw==","diff_hunk":"@@ -129,7 +129,7 @@ Parameters:\n \n   BootstrapArguments:\n     Description: Arguments to pass to the bootstrap script. See files/bootstrap.sh in https://github.com/awslabs/amazon-eks-ami\n-    Default: \"\"\n+    Default: \"--kubelet-extra-args --feature-gates=PodShareProcessNamespace=true\"","path":"infrastructure/amazon-eks-nodegroup.yaml","position":5,"original_position":5,"commit_id":"e5e7e9c6a793cef261592439484638669305fb9f","original_commit_id":"e5e7e9c6a793cef261592439484638669305fb9f","user":{"login":"naiduarvind","id":6829472,"node_id":"MDQ6VXNlcjY4Mjk0NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/6829472?v=4","gravatar_id":"","url":"https://api.github.com/users/naiduarvind","html_url":"https://github.com/naiduarvind","followers_url":"https://api.github.com/users/naiduarvind/followers","following_url":"https://api.github.com/users/naiduarvind/following{/other_user}","gists_url":"https://api.github.com/users/naiduarvind/gists{/gist_id}","starred_url":"https://api.github.com/users/naiduarvind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naiduarvind/subscriptions","organizations_url":"https://api.github.com/users/naiduarvind/orgs","repos_url":"https://api.github.com/users/naiduarvind/repos","events_url":"https://api.github.com/users/naiduarvind/events{/privacy}","received_events_url":"https://api.github.com/users/naiduarvind/received_events","type":"User","site_admin":false},"body":"To enable process sharing between containers in a pod. :)","created_at":"2018-12-13T07:57:47Z","updated_at":"2018-12-13T07:57:47Z","html_url":"https://github.com/learndot/eks-cfn/pull/17#discussion_r241300493","pull_request_url":"https://api.github.com/repos/learndot/eks-cfn/pulls/17","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/learndot/eks-cfn/pulls/comments/241300493"},"html":{"href":"https://github.com/learndot/eks-cfn/pull/17#discussion_r241300493"},"pull_request":{"href":"https://api.github.com/repos/learndot/eks-cfn/pulls/17"}},"in_reply_to_id":241300140},"pull_request":{"url":"https://api.github.com/repos/learndot/eks-cfn/pulls/17","id":238294663,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4Mjk0NjYz","html_url":"https://github.com/learndot/eks-cfn/pull/17","diff_url":"https://github.com/learndot/eks-cfn/pull/17.diff","patch_url":"https://github.com/learndot/eks-cfn/pull/17.patch","issue_url":"https://api.github.com/repos/learndot/eks-cfn/issues/17","number":17,"state":"open","locked":false,"title":"LD-5704 Enable JVM debugging using jcmd","user":{"login":"naiduarvind","id":6829472,"node_id":"MDQ6VXNlcjY4Mjk0NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/6829472?v=4","gravatar_id":"","url":"https://api.github.com/users/naiduarvind","html_url":"https://github.com/naiduarvind","followers_url":"https://api.github.com/users/naiduarvind/followers","following_url":"https://api.github.com/users/naiduarvind/following{/other_user}","gists_url":"https://api.github.com/users/naiduarvind/gists{/gist_id}","starred_url":"https://api.github.com/users/naiduarvind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naiduarvind/subscriptions","organizations_url":"https://api.github.com/users/naiduarvind/orgs","repos_url":"https://api.github.com/users/naiduarvind/repos","events_url":"https://api.github.com/users/naiduarvind/events{/privacy}","received_events_url":"https://api.github.com/users/naiduarvind/received_events","type":"User","site_admin":false},"body":"Sharing Java's PID for sidecar container to perform analysis using jcmd as eigen image does not include java development tools.","created_at":"2018-12-13T07:53:10Z","updated_at":"2018-12-13T07:57:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1404d19f1522d067ffb155584fd7730ffb81d0f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/learndot/eks-cfn/pulls/17/commits","review_comments_url":"https://api.github.com/repos/learndot/eks-cfn/pulls/17/comments","review_comment_url":"https://api.github.com/repos/learndot/eks-cfn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learndot/eks-cfn/issues/17/comments","statuses_url":"https://api.github.com/repos/learndot/eks-cfn/statuses/e5e7e9c6a793cef261592439484638669305fb9f","head":{"label":"learndot:LD-5704-enable-process-sharing-on-kubelet","ref":"LD-5704-enable-process-sharing-on-kubelet","sha":"e5e7e9c6a793cef261592439484638669305fb9f","user":{"login":"learndot","id":2752615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTI2MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2752615?v=4","gravatar_id":"","url":"https://api.github.com/users/learndot","html_url":"https://github.com/learndot","followers_url":"https://api.github.com/users/learndot/followers","following_url":"https://api.github.com/users/learndot/following{/other_user}","gists_url":"https://api.github.com/users/learndot/gists{/gist_id}","starred_url":"https://api.github.com/users/learndot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learndot/subscriptions","organizations_url":"https://api.github.com/users/learndot/orgs","repos_url":"https://api.github.com/users/learndot/repos","events_url":"https://api.github.com/users/learndot/events{/privacy}","received_events_url":"https://api.github.com/users/learndot/received_events","type":"Organization","site_admin":false},"repo":{"id":137235849,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU4NDk=","name":"eks-cfn","full_name":"learndot/eks-cfn","private":false,"owner":{"login":"learndot","id":2752615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTI2MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2752615?v=4","gravatar_id":"","url":"https://api.github.com/users/learndot","html_url":"https://github.com/learndot","followers_url":"https://api.github.com/users/learndot/followers","following_url":"https://api.github.com/users/learndot/following{/other_user}","gists_url":"https://api.github.com/users/learndot/gists{/gist_id}","starred_url":"https://api.github.com/users/learndot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learndot/subscriptions","organizations_url":"https://api.github.com/users/learndot/orgs","repos_url":"https://api.github.com/users/learndot/repos","events_url":"https://api.github.com/users/learndot/events{/privacy}","received_events_url":"https://api.github.com/users/learndot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/learndot/eks-cfn","description":"CloudFormation stack to provision EKS","fork":false,"url":"https://api.github.com/repos/learndot/eks-cfn","forks_url":"https://api.github.com/repos/learndot/eks-cfn/forks","keys_url":"https://api.github.com/repos/learndot/eks-cfn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learndot/eks-cfn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learndot/eks-cfn/teams","hooks_url":"https://api.github.com/repos/learndot/eks-cfn/hooks","issue_events_url":"https://api.github.com/repos/learndot/eks-cfn/issues/events{/number}","events_url":"https://api.github.com/repos/learndot/eks-cfn/events","assignees_url":"https://api.github.com/repos/learndot/eks-cfn/assignees{/user}","branches_url":"https://api.github.com/repos/learndot/eks-cfn/branches{/branch}","tags_url":"https://api.github.com/repos/learndot/eks-cfn/tags","blobs_url":"https://api.github.com/repos/learndot/eks-cfn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learndot/eks-cfn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learndot/eks-cfn/git/refs{/sha}","trees_url":"https://api.github.com/repos/learndot/eks-cfn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learndot/eks-cfn/statuses/{sha}","languages_url":"https://api.github.com/repos/learndot/eks-cfn/languages","stargazers_url":"https://api.github.com/repos/learndot/eks-cfn/stargazers","contributors_url":"https://api.github.com/repos/learndot/eks-cfn/contributors","subscribers_url":"https://api.github.com/repos/learndot/eks-cfn/subscribers","subscription_url":"https://api.github.com/repos/learndot/eks-cfn/subscription","commits_url":"https://api.github.com/repos/learndot/eks-cfn/commits{/sha}","git_commits_url":"https://api.github.com/repos/learndot/eks-cfn/git/commits{/sha}","comments_url":"https://api.github.com/repos/learndot/eks-cfn/comments{/number}","issue_comment_url":"https://api.github.com/repos/learndot/eks-cfn/issues/comments{/number}","contents_url":"https://api.github.com/repos/learndot/eks-cfn/contents/{+path}","compare_url":"https://api.github.com/repos/learndot/eks-cfn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learndot/eks-cfn/merges","archive_url":"https://api.github.com/repos/learndot/eks-cfn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learndot/eks-cfn/downloads","issues_url":"https://api.github.com/repos/learndot/eks-cfn/issues{/number}","pulls_url":"https://api.github.com/repos/learndot/eks-cfn/pulls{/number}","milestones_url":"https://api.github.com/repos/learndot/eks-cfn/milestones{/number}","notifications_url":"https://api.github.com/repos/learndot/eks-cfn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learndot/eks-cfn/labels{/name}","releases_url":"https://api.github.com/repos/learndot/eks-cfn/releases{/id}","deployments_url":"https://api.github.com/repos/learndot/eks-cfn/deployments","created_at":"2018-06-13T15:36:41Z","updated_at":"2018-12-13T07:56:25Z","pushed_at":"2018-12-13T07:56:32Z","git_url":"git://github.com/learndot/eks-cfn.git","ssh_url":"git@github.com:learndot/eks-cfn.git","clone_url":"https://github.com/learndot/eks-cfn.git","svn_url":"https://github.com/learndot/eks-cfn","homepage":null,"size":40,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"learndot:master","ref":"master","sha":"edfe28954276f88a5f43ebc95c3896a2b60eba4d","user":{"login":"learndot","id":2752615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTI2MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2752615?v=4","gravatar_id":"","url":"https://api.github.com/users/learndot","html_url":"https://github.com/learndot","followers_url":"https://api.github.com/users/learndot/followers","following_url":"https://api.github.com/users/learndot/following{/other_user}","gists_url":"https://api.github.com/users/learndot/gists{/gist_id}","starred_url":"https://api.github.com/users/learndot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learndot/subscriptions","organizations_url":"https://api.github.com/users/learndot/orgs","repos_url":"https://api.github.com/users/learndot/repos","events_url":"https://api.github.com/users/learndot/events{/privacy}","received_events_url":"https://api.github.com/users/learndot/received_events","type":"Organization","site_admin":false},"repo":{"id":137235849,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU4NDk=","name":"eks-cfn","full_name":"learndot/eks-cfn","private":false,"owner":{"login":"learndot","id":2752615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTI2MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2752615?v=4","gravatar_id":"","url":"https://api.github.com/users/learndot","html_url":"https://github.com/learndot","followers_url":"https://api.github.com/users/learndot/followers","following_url":"https://api.github.com/users/learndot/following{/other_user}","gists_url":"https://api.github.com/users/learndot/gists{/gist_id}","starred_url":"https://api.github.com/users/learndot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learndot/subscriptions","organizations_url":"https://api.github.com/users/learndot/orgs","repos_url":"https://api.github.com/users/learndot/repos","events_url":"https://api.github.com/users/learndot/events{/privacy}","received_events_url":"https://api.github.com/users/learndot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/learndot/eks-cfn","description":"CloudFormation stack to provision EKS","fork":false,"url":"https://api.github.com/repos/learndot/eks-cfn","forks_url":"https://api.github.com/repos/learndot/eks-cfn/forks","keys_url":"https://api.github.com/repos/learndot/eks-cfn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learndot/eks-cfn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learndot/eks-cfn/teams","hooks_url":"https://api.github.com/repos/learndot/eks-cfn/hooks","issue_events_url":"https://api.github.com/repos/learndot/eks-cfn/issues/events{/number}","events_url":"https://api.github.com/repos/learndot/eks-cfn/events","assignees_url":"https://api.github.com/repos/learndot/eks-cfn/assignees{/user}","branches_url":"https://api.github.com/repos/learndot/eks-cfn/branches{/branch}","tags_url":"https://api.github.com/repos/learndot/eks-cfn/tags","blobs_url":"https://api.github.com/repos/learndot/eks-cfn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learndot/eks-cfn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learndot/eks-cfn/git/refs{/sha}","trees_url":"https://api.github.com/repos/learndot/eks-cfn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learndot/eks-cfn/statuses/{sha}","languages_url":"https://api.github.com/repos/learndot/eks-cfn/languages","stargazers_url":"https://api.github.com/repos/learndot/eks-cfn/stargazers","contributors_url":"https://api.github.com/repos/learndot/eks-cfn/contributors","subscribers_url":"https://api.github.com/repos/learndot/eks-cfn/subscribers","subscription_url":"https://api.github.com/repos/learndot/eks-cfn/subscription","commits_url":"https://api.github.com/repos/learndot/eks-cfn/commits{/sha}","git_commits_url":"https://api.github.com/repos/learndot/eks-cfn/git/commits{/sha}","comments_url":"https://api.github.com/repos/learndot/eks-cfn/comments{/number}","issue_comment_url":"https://api.github.com/repos/learndot/eks-cfn/issues/comments{/number}","contents_url":"https://api.github.com/repos/learndot/eks-cfn/contents/{+path}","compare_url":"https://api.github.com/repos/learndot/eks-cfn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learndot/eks-cfn/merges","archive_url":"https://api.github.com/repos/learndot/eks-cfn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learndot/eks-cfn/downloads","issues_url":"https://api.github.com/repos/learndot/eks-cfn/issues{/number}","pulls_url":"https://api.github.com/repos/learndot/eks-cfn/pulls{/number}","milestones_url":"https://api.github.com/repos/learndot/eks-cfn/milestones{/number}","notifications_url":"https://api.github.com/repos/learndot/eks-cfn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learndot/eks-cfn/labels{/name}","releases_url":"https://api.github.com/repos/learndot/eks-cfn/releases{/id}","deployments_url":"https://api.github.com/repos/learndot/eks-cfn/deployments","created_at":"2018-06-13T15:36:41Z","updated_at":"2018-12-13T07:56:25Z","pushed_at":"2018-12-13T07:56:32Z","git_url":"git://github.com/learndot/eks-cfn.git","ssh_url":"git@github.com:learndot/eks-cfn.git","clone_url":"https://github.com/learndot/eks-cfn.git","svn_url":"https://github.com/learndot/eks-cfn","homepage":null,"size":40,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/learndot/eks-cfn/pulls/17"},"html":{"href":"https://github.com/learndot/eks-cfn/pull/17"},"issue":{"href":"https://api.github.com/repos/learndot/eks-cfn/issues/17"},"comments":{"href":"https://api.github.com/repos/learndot/eks-cfn/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/learndot/eks-cfn/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/learndot/eks-cfn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learndot/eks-cfn/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/learndot/eks-cfn/statuses/e5e7e9c6a793cef261592439484638669305fb9f"}},"author_association":"NONE"}}
{"actor":{"display_login":"naiduarvind"}}