{"action":"created","issue":{"url":"https://api.github.com/repos/stripe/veneur/issues/415","repository_url":"https://api.github.com/repos/stripe/veneur","labels_url":"https://api.github.com/repos/stripe/veneur/issues/415/labels{/name}","comments_url":"https://api.github.com/repos/stripe/veneur/issues/415/comments","events_url":"https://api.github.com/repos/stripe/veneur/issues/415/events","html_url":"https://github.com/stripe/veneur/pull/415","id":305935974,"number":415,"title":"Strengthen some asserts, instrument TestReconnectBufferedUNIX better","user":{"login":"asf-stripe","id":23062936,"avatar_url":"https://avatars0.githubusercontent.com/u/23062936?v=4","gravatar_id":"","url":"https://api.github.com/users/asf-stripe","html_url":"https://github.com/asf-stripe","followers_url":"https://api.github.com/users/asf-stripe/followers","following_url":"https://api.github.com/users/asf-stripe/following{/other_user}","gists_url":"https://api.github.com/users/asf-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/asf-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asf-stripe/subscriptions","organizations_url":"https://api.github.com/users/asf-stripe/orgs","repos_url":"https://api.github.com/users/asf-stripe/repos","events_url":"https://api.github.com/users/asf-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/asf-stripe/received_events","type":"User","site_admin":false},"labels":[{"id":379316375,"url":"https://api.github.com/repos/stripe/veneur/labels/approved","name":"approved","color":"2DA239","default":false}],"state":"open","locked":false,"assignee":{"login":"asf-stripe","id":23062936,"avatar_url":"https://avatars0.githubusercontent.com/u/23062936?v=4","gravatar_id":"","url":"https://api.github.com/users/asf-stripe","html_url":"https://github.com/asf-stripe","followers_url":"https://api.github.com/users/asf-stripe/followers","following_url":"https://api.github.com/users/asf-stripe/following{/other_user}","gists_url":"https://api.github.com/users/asf-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/asf-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asf-stripe/subscriptions","organizations_url":"https://api.github.com/users/asf-stripe/orgs","repos_url":"https://api.github.com/users/asf-stripe/repos","events_url":"https://api.github.com/users/asf-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/asf-stripe/received_events","type":"User","site_admin":false},"assignees":[{"login":"asf-stripe","id":23062936,"avatar_url":"https://avatars0.githubusercontent.com/u/23062936?v=4","gravatar_id":"","url":"https://api.github.com/users/asf-stripe","html_url":"https://github.com/asf-stripe","followers_url":"https://api.github.com/users/asf-stripe/followers","following_url":"https://api.github.com/users/asf-stripe/following{/other_user}","gists_url":"https://api.github.com/users/asf-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/asf-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asf-stripe/subscriptions","organizations_url":"https://api.github.com/users/asf-stripe/orgs","repos_url":"https://api.github.com/users/asf-stripe/repos","events_url":"https://api.github.com/users/asf-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/asf-stripe/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-03-16T13:53:36Z","updated_at":"2018-03-16T13:55:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/stripe/veneur/pulls/415","html_url":"https://github.com/stripe/veneur/pull/415","diff_url":"https://github.com/stripe/veneur/pull/415.diff","patch_url":"https://github.com/stripe/veneur/pull/415.patch"},"body":"<!-- Checklist For PRs\n\n* Ensure you've written tests where applicable\n* Add a CHANGELOG.md entry describing your change, thank yourself!\n* Document any changes to metrics or configuration\n-->\n\n\n#### Summary\n\nThis PR makes sure TestReconnectBufferedUNIX fails without throwing away its buffered test log output, which I will need to debug the deadlocks we'd been seeing.\n\nAlso, this attempts to strengthen some asserts without which we can't continue the test into requires. Maybe we'll get lucky and travis will tell us what is happening!\n\n\n#### Motivation\n\nHad another test timeout due to a deadlock.\n\n#### Test plan\n\nIt doesn't seem to make the test worse at least.\n\n\n#### Rollout/monitoring/revert plan\n\nJust merge. Test-only."},"comment":{"url":"https://api.github.com/repos/stripe/veneur/issues/comments/373720214","html_url":"https://github.com/stripe/veneur/pull/415#issuecomment-373720214","issue_url":"https://api.github.com/repos/stripe/veneur/issues/415","id":373720214,"user":{"login":"sdboyer-stripe","id":35501011,"avatar_url":"https://avatars1.githubusercontent.com/u/35501011?v=4","gravatar_id":"","url":"https://api.github.com/users/sdboyer-stripe","html_url":"https://github.com/sdboyer-stripe","followers_url":"https://api.github.com/users/sdboyer-stripe/followers","following_url":"https://api.github.com/users/sdboyer-stripe/following{/other_user}","gists_url":"https://api.github.com/users/sdboyer-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/sdboyer-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdboyer-stripe/subscriptions","organizations_url":"https://api.github.com/users/sdboyer-stripe/orgs","repos_url":"https://api.github.com/users/sdboyer-stripe/repos","events_url":"https://api.github.com/users/sdboyer-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/sdboyer-stripe/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T13:55:14Z","updated_at":"2018-03-16T13:55:14Z","author_association":"CONTRIBUTOR","body":"LGTM!"}}
{"actor":{"display_login":"sdboyer-stripe"}}