{"action":"opened","number":1132,"pull_request":{"url":"https://api.github.com/repos/pytorch/glow/pulls/1132","id":194472611,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NDcyNjEx","html_url":"https://github.com/pytorch/glow/pull/1132","diff_url":"https://github.com/pytorch/glow/pull/1132.diff","patch_url":"https://github.com/pytorch/glow/pull/1132.patch","issue_url":"https://api.github.com/repos/pytorch/glow/issues/1132","number":1132,"state":"open","locked":false,"title":"[mltest] Set batchSize where it makes sense","user":{"login":"bertmaher","id":4441820,"node_id":"MDQ6VXNlcjQ0NDE4MjA=","avatar_url":"https://avatars1.githubusercontent.com/u/4441820?v=4","gravatar_id":"","url":"https://api.github.com/users/bertmaher","html_url":"https://github.com/bertmaher","followers_url":"https://api.github.com/users/bertmaher/followers","following_url":"https://api.github.com/users/bertmaher/following{/other_user}","gists_url":"https://api.github.com/users/bertmaher/gists{/gist_id}","starred_url":"https://api.github.com/users/bertmaher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertmaher/subscriptions","organizations_url":"https://api.github.com/users/bertmaher/orgs","repos_url":"https://api.github.com/users/bertmaher/repos","events_url":"https://api.github.com/users/bertmaher/events{/privacy}","received_events_url":"https://api.github.com/users/bertmaher/received_events","type":"User","site_admin":false},"body":"If I understand correctly, we should always set EE's batchSize equal to the batch dimension of the training tensors, so that SGD is done \"properly\".  (If I don't understand correctly, this diff is a good opportunity to correct me :-D ).  I guess this doesn't really \"matter\", but it makes the test code easier to understand for folks like me who are learning ML while trying to write a test case.","created_at":"2018-06-13T05:13:30Z","updated_at":"2018-06-13T05:13:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/glow/pulls/1132/commits","review_comments_url":"https://api.github.com/repos/pytorch/glow/pulls/1132/comments","review_comment_url":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/glow/issues/1132/comments","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/5a18bdc2f99786309779d839815357568635fb6c","head":{"label":"bertmaher:batchsize","ref":"batchsize","sha":"5a18bdc2f99786309779d839815357568635fb6c","user":{"login":"bertmaher","id":4441820,"node_id":"MDQ6VXNlcjQ0NDE4MjA=","avatar_url":"https://avatars1.githubusercontent.com/u/4441820?v=4","gravatar_id":"","url":"https://api.github.com/users/bertmaher","html_url":"https://github.com/bertmaher","followers_url":"https://api.github.com/users/bertmaher/followers","following_url":"https://api.github.com/users/bertmaher/following{/other_user}","gists_url":"https://api.github.com/users/bertmaher/gists{/gist_id}","starred_url":"https://api.github.com/users/bertmaher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertmaher/subscriptions","organizations_url":"https://api.github.com/users/bertmaher/orgs","repos_url":"https://api.github.com/users/bertmaher/repos","events_url":"https://api.github.com/users/bertmaher/events{/privacy}","received_events_url":"https://api.github.com/users/bertmaher/received_events","type":"User","site_admin":false},"repo":{"id":131883010,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE4ODMwMTA=","name":"glow","full_name":"bertmaher/glow","owner":{"login":"bertmaher","id":4441820,"node_id":"MDQ6VXNlcjQ0NDE4MjA=","avatar_url":"https://avatars1.githubusercontent.com/u/4441820?v=4","gravatar_id":"","url":"https://api.github.com/users/bertmaher","html_url":"https://github.com/bertmaher","followers_url":"https://api.github.com/users/bertmaher/followers","following_url":"https://api.github.com/users/bertmaher/following{/other_user}","gists_url":"https://api.github.com/users/bertmaher/gists{/gist_id}","starred_url":"https://api.github.com/users/bertmaher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertmaher/subscriptions","organizations_url":"https://api.github.com/users/bertmaher/orgs","repos_url":"https://api.github.com/users/bertmaher/repos","events_url":"https://api.github.com/users/bertmaher/events{/privacy}","received_events_url":"https://api.github.com/users/bertmaher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bertmaher/glow","description":"Compiler for Neural Network hardware accelerators","fork":true,"url":"https://api.github.com/repos/bertmaher/glow","forks_url":"https://api.github.com/repos/bertmaher/glow/forks","keys_url":"https://api.github.com/repos/bertmaher/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bertmaher/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bertmaher/glow/teams","hooks_url":"https://api.github.com/repos/bertmaher/glow/hooks","issue_events_url":"https://api.github.com/repos/bertmaher/glow/issues/events{/number}","events_url":"https://api.github.com/repos/bertmaher/glow/events","assignees_url":"https://api.github.com/repos/bertmaher/glow/assignees{/user}","branches_url":"https://api.github.com/repos/bertmaher/glow/branches{/branch}","tags_url":"https://api.github.com/repos/bertmaher/glow/tags","blobs_url":"https://api.github.com/repos/bertmaher/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bertmaher/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bertmaher/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/bertmaher/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bertmaher/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/bertmaher/glow/languages","stargazers_url":"https://api.github.com/repos/bertmaher/glow/stargazers","contributors_url":"https://api.github.com/repos/bertmaher/glow/contributors","subscribers_url":"https://api.github.com/repos/bertmaher/glow/subscribers","subscription_url":"https://api.github.com/repos/bertmaher/glow/subscription","commits_url":"https://api.github.com/repos/bertmaher/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/bertmaher/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/bertmaher/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/bertmaher/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/bertmaher/glow/contents/{+path}","compare_url":"https://api.github.com/repos/bertmaher/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bertmaher/glow/merges","archive_url":"https://api.github.com/repos/bertmaher/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bertmaher/glow/downloads","issues_url":"https://api.github.com/repos/bertmaher/glow/issues{/number}","pulls_url":"https://api.github.com/repos/bertmaher/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/bertmaher/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/bertmaher/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bertmaher/glow/labels{/name}","releases_url":"https://api.github.com/repos/bertmaher/glow/releases{/id}","deployments_url":"https://api.github.com/repos/bertmaher/glow/deployments","created_at":"2018-05-02T17:17:15Z","updated_at":"2018-05-02T17:20:28Z","pushed_at":"2018-06-13T05:11:24Z","git_url":"git://github.com/bertmaher/glow.git","ssh_url":"git@github.com:bertmaher/glow.git","clone_url":"https://github.com/bertmaher/glow.git","svn_url":"https://github.com/bertmaher/glow","homepage":null,"size":6303,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"a6a00a4e2662e29724a0cc18e2e136247d9c6b4a","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":105281531,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyODE1MzE=","name":"glow","full_name":"pytorch/glow","owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/glow","description":"Compiler for Neural Network hardware accelerators","fork":false,"url":"https://api.github.com/repos/pytorch/glow","forks_url":"https://api.github.com/repos/pytorch/glow/forks","keys_url":"https://api.github.com/repos/pytorch/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/glow/teams","hooks_url":"https://api.github.com/repos/pytorch/glow/hooks","issue_events_url":"https://api.github.com/repos/pytorch/glow/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/glow/events","assignees_url":"https://api.github.com/repos/pytorch/glow/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/glow/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/glow/tags","blobs_url":"https://api.github.com/repos/pytorch/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/glow/languages","stargazers_url":"https://api.github.com/repos/pytorch/glow/stargazers","contributors_url":"https://api.github.com/repos/pytorch/glow/contributors","subscribers_url":"https://api.github.com/repos/pytorch/glow/subscribers","subscription_url":"https://api.github.com/repos/pytorch/glow/subscription","commits_url":"https://api.github.com/repos/pytorch/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/glow/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/glow/merges","archive_url":"https://api.github.com/repos/pytorch/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/glow/downloads","issues_url":"https://api.github.com/repos/pytorch/glow/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/glow/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/glow/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/glow/deployments","created_at":"2017-09-29T14:28:18Z","updated_at":"2018-06-13T03:52:14Z","pushed_at":"2018-06-13T03:52:12Z","git_url":"git://github.com/pytorch/glow.git","ssh_url":"git@github.com:pytorch/glow.git","clone_url":"https://github.com/pytorch/glow.git","svn_url":"https://github.com/pytorch/glow","homepage":null,"size":6305,"stargazers_count":596,"watchers_count":596,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":60,"open_issues":13,"watchers":596,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1132"},"html":{"href":"https://github.com/pytorch/glow/pull/1132"},"issue":{"href":"https://api.github.com/repos/pytorch/glow/issues/1132"},"comments":{"href":"https://api.github.com/repos/pytorch/glow/issues/1132/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1132/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1132/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/glow/statuses/5a18bdc2f99786309779d839815357568635fb6c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":9,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"bertmaher"}}