{"push_id":2843924256,"size":11,"distinct_size":4,"ref":"refs/heads/generate-git-repo","head":"de7eff8a065014e8f6b4ef7b9d0a58a309a58d73","before":"df36a81bd9d917344005e556b6ef8d825b182986","commits":[{"sha":"667fb534218c7cfa10ac4b5274dd47aed1149f7a","author":{"name":"Netanel Gilad","email":"ca823c8fd57040644c0b7a06b1c917b3453b72c6@wix.com"},"message":"validate yoshi config before running command (#535)\n\n<!---\r\nThanks for submitting a pull request 😄 !\r\n-->\r\n\r\n<!--- If you're changing public APIs make sure to document them (README, FAQ) -->\r\n\r\n<!--- Be as descriptive as possible when explaining what was changed. Link to an issue if one exists -->\r\n### 🔦 Summary\r\nThis PR adds configuration validation before running yoshi commands. Fixes #500. This initial implementation is using `ajv` to validate the configuration object against a JSON schema. Then the errors are printed using `YoshiOptionsValidationError` which is a copied implementation from the webpack-cli repository. (The default errors text from `ajv` are not great, so the webpack way seems a good way to go).\r\n\r\nPlease look carefully at the JSON schema. I created it based on the API docs, but maybe you'll know better. And if there are old deprecated fields, we can print deprecation warning for them, I just didn't know if there are any.\r\n\r\n<!--- Describe how the proposed changes are tested -->\r\n### 🗺️ Test Plan\r\nSo this part is still is open for discussion. What testing strategy do you see for this if at all? I can add unit tests for the copied webpack code for generating the error messages, but maybe it won't add too much, and a full e2e test may be an overkill. Thoughts?","distinct":false,"url":"https://api.github.com/repos/wix/yoshi/commits/667fb534218c7cfa10ac4b5274dd47aed1149f7a"},{"sha":"d4f8341583bb1054413ef2f277d27ac78eb1ddeb","author":{"name":"Ronen Amiel","email":"d855f59dd31ec3fe76db9c821aebe6a020ed8ee7@wix.com"},"message":"Use files from /src only during test (#545)","distinct":false,"url":"https://api.github.com/repos/wix/yoshi/commits/d4f8341583bb1054413ef2f277d27ac78eb1ddeb"},{"sha":"daf8a6f2e603c7502e0f3c82cdfbe8cc4c2384e8","author":{"name":"Ronen Amiel","email":"5bef009aa56735bb5a8064369526a3b196ddb52d@gmail.com"},"message":"changelog for version 3.8.1","distinct":false,"url":"https://api.github.com/repos/wix/yoshi/commits/daf8a6f2e603c7502e0f3c82cdfbe8cc4c2384e8"},{"sha":"44fb8c44116ff1de078cd49c4b7d83d84fa928d2","author":{"name":"Ronen Amiel","email":"5bef009aa56735bb5a8064369526a3b196ddb52d@gmail.com"},"message":"v3.8.1","distinct":false,"url":"https://api.github.com/repos/wix/yoshi/commits/44fb8c44116ff1de078cd49c4b7d83d84fa928d2"},{"sha":"fabb8c7ee8f5b43ebc9d321cf7d3794a4d602f05","author":{"name":"Ronen Amiel","email":"d855f59dd31ec3fe76db9c821aebe6a020ed8ee7@wix.com"},"message":"Use template var instead of 'package.json' to prevent Lerna from analyzing them (#548)\n\n### 🔦 Summary\r\n\r\nCurrently, Lerna analyzes the `package.json` files of generator templates. We can add the templates folder to Lerna's ignore glob but changing its name looks better as other tools might look for a `package.json` file.","distinct":false,"url":"https://api.github.com/repos/wix/yoshi/commits/fabb8c7ee8f5b43ebc9d321cf7d3794a4d602f05"},{"sha":"29945c80b756b1a7a8de289272ebed30d9708878","author":{"name":"Amit Dahan","email":"3b7436b05587a32647f88a1ba9801c61faee75d8@gmail.com"},"message":"yoshi: Lock wallaby's babel version (#550)\n\n### 🔦 Summary\r\nMake sure yoshi's wallaby config is using yoshi's version of babel (6.X as of now).\r\nThis solves issues that were caused by a dependency that installed @babel/core and made wallaby \"prefer\" 7.X.\r\n\r\n### 🗺️ Test Plan\r\nWorks for me ¯\\_(ツ)_/¯","distinct":false,"url":"https://api.github.com/repos/wix/yoshi/commits/29945c80b756b1a7a8de289272ebed30d9708878"},{"sha":"988d12aee02494ea9cf2e907bbd1811597b59b19","author":{"name":"Ran Yitzhaki","email":"0fdaa62205b4c9e62eb4f05190813fa5fa42e7f8@users.noreply.github.com"},"message":"add unit tests for the generateProject function (#551)","distinct":false,"url":"https://api.github.com/repos/wix/yoshi/commits/988d12aee02494ea9cf2e907bbd1811597b59b19"},{"sha":"bc9e516f92d1b95b1e12740b45efd56c7b10c136","author":{"name":"Netanel Gilad","email":"ca823c8fd57040644c0b7a06b1c917b3453b72c6@wix.com"},"message":"failing test for generating a git repo","distinct":true,"url":"https://api.github.com/repos/wix/yoshi/commits/bc9e516f92d1b95b1e12740b45efd56c7b10c136"},{"sha":"657b69a768e10dea91c9288833bd037dd4011f91","author":{"name":"Netanel Gilad","email":"ca823c8fd57040644c0b7a06b1c917b3453b72c6@wix.com"},"message":"git init when creating app","distinct":true,"url":"https://api.github.com/repos/wix/yoshi/commits/657b69a768e10dea91c9288833bd037dd4011f91"},{"sha":"5b613a80d1a2af1eb88b855e8fc983ee40797edd","author":{"name":"Netanel Gilad","email":"ca823c8fd57040644c0b7a06b1c917b3453b72c6@wix.com"},"message":"don't ask about git repo and auto detect existing repo","distinct":true,"url":"https://api.github.com/repos/wix/yoshi/commits/5b613a80d1a2af1eb88b855e8fc983ee40797edd"},{"sha":"de7eff8a065014e8f6b4ef7b9d0a58a309a58d73","author":{"name":"Netanel Gilad","email":"ca823c8fd57040644c0b7a06b1c917b3453b72c6@wix.com"},"message":"Merge branch 'generate-git-repo' of github.com:wix/yoshi into generate-git-repo","distinct":true,"url":"https://api.github.com/repos/wix/yoshi/commits/de7eff8a065014e8f6b4ef7b9d0a58a309a58d73"}]}
{"actor":{"display_login":"netanelgilad"}}