{"action":"created","comment":{"url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/comments/210007209","pull_request_review_id":146133469,"id":210007209,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDAwNzIwOQ==","diff_hunk":"@@ -1261,7 +1263,52 @@ MatrixHandler.prototype._sendIrcAction = Promise.coroutine(\n         return;\n     }\n \n+    /**\n+     * Cache events in here so we can refer to them for replies.\n+     * We deliberately avoid fetching events from the homeserver due to speed concerns.\n+     */\n+    this._eventCache.set(event.event_id, { body: event.content.body, sender: event.sender });","path":"lib/bridge/MatrixHandler.js","position":24,"original_position":24,"commit_id":"6e0ac53ca578b1bf353e97a2d75f624b8612377a","original_commit_id":"6e0ac53ca578b1bf353e97a2d75f624b8612377a","user":{"login":"Half-Shot","id":2072976,"node_id":"MDQ6VXNlcjIwNzI5NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2072976?v=4","gravatar_id":"","url":"https://api.github.com/users/Half-Shot","html_url":"https://github.com/Half-Shot","followers_url":"https://api.github.com/users/Half-Shot/followers","following_url":"https://api.github.com/users/Half-Shot/following{/other_user}","gists_url":"https://api.github.com/users/Half-Shot/gists{/gist_id}","starred_url":"https://api.github.com/users/Half-Shot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Half-Shot/subscriptions","organizations_url":"https://api.github.com/users/Half-Shot/orgs","repos_url":"https://api.github.com/users/Half-Shot/repos","events_url":"https://api.github.com/users/Half-Shot/events{/privacy}","received_events_url":"https://api.github.com/users/Half-Shot/received_events","type":"User","site_admin":false},"body":"True, we should trim this to how much of the body we actually need.","created_at":"2018-08-14T15:55:34Z","updated_at":"2018-08-14T15:55:34Z","html_url":"https://github.com/matrix-org/matrix-appservice-irc/pull/647#discussion_r210007209","pull_request_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/647","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/comments/210007209"},"html":{"href":"https://github.com/matrix-org/matrix-appservice-irc/pull/647#discussion_r210007209"},"pull_request":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/647"}},"in_reply_to_id":209975050},"pull_request":{"url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/647","id":208052070,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDUyMDcw","html_url":"https://github.com/matrix-org/matrix-appservice-irc/pull/647","diff_url":"https://github.com/matrix-org/matrix-appservice-irc/pull/647.diff","patch_url":"https://github.com/matrix-org/matrix-appservice-irc/pull/647.patch","issue_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues/647","number":647,"state":"open","locked":false,"title":"Formatting of replies","user":{"login":"Half-Shot","id":2072976,"node_id":"MDQ6VXNlcjIwNzI5NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2072976?v=4","gravatar_id":"","url":"https://api.github.com/users/Half-Shot","html_url":"https://github.com/Half-Shot","followers_url":"https://api.github.com/users/Half-Shot/followers","following_url":"https://api.github.com/users/Half-Shot/following{/other_user}","gists_url":"https://api.github.com/users/Half-Shot/gists{/gist_id}","starred_url":"https://api.github.com/users/Half-Shot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Half-Shot/subscriptions","organizations_url":"https://api.github.com/users/Half-Shot/orgs","repos_url":"https://api.github.com/users/Half-Shot/repos","events_url":"https://api.github.com/users/Half-Shot/events{/privacy}","received_events_url":"https://api.github.com/users/Half-Shot/received_events","type":"User","site_admin":false},"body":"Fixes #636\r\n\r\nThe format turns it into something like `<source sender \"source text\"> reply text`","created_at":"2018-08-13T17:42:56Z","updated_at":"2018-08-14T15:55:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6a448ce07e4ad67868b64cb81e80764f7d2c1fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/647/commits","review_comments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/647/comments","review_comment_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues/647/comments","statuses_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/statuses/6e0ac53ca578b1bf353e97a2d75f624b8612377a","head":{"label":"Half-Shot:hs/replies","ref":"hs/replies","sha":"6e0ac53ca578b1bf353e97a2d75f624b8612377a","user":{"login":"Half-Shot","id":2072976,"node_id":"MDQ6VXNlcjIwNzI5NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2072976?v=4","gravatar_id":"","url":"https://api.github.com/users/Half-Shot","html_url":"https://github.com/Half-Shot","followers_url":"https://api.github.com/users/Half-Shot/followers","following_url":"https://api.github.com/users/Half-Shot/following{/other_user}","gists_url":"https://api.github.com/users/Half-Shot/gists{/gist_id}","starred_url":"https://api.github.com/users/Half-Shot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Half-Shot/subscriptions","organizations_url":"https://api.github.com/users/Half-Shot/orgs","repos_url":"https://api.github.com/users/Half-Shot/repos","events_url":"https://api.github.com/users/Half-Shot/events{/privacy}","received_events_url":"https://api.github.com/users/Half-Shot/received_events","type":"User","site_admin":false},"repo":{"id":136031440,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwMzE0NDA=","name":"matrix-appservice-irc","full_name":"Half-Shot/matrix-appservice-irc","owner":{"login":"Half-Shot","id":2072976,"node_id":"MDQ6VXNlcjIwNzI5NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2072976?v=4","gravatar_id":"","url":"https://api.github.com/users/Half-Shot","html_url":"https://github.com/Half-Shot","followers_url":"https://api.github.com/users/Half-Shot/followers","following_url":"https://api.github.com/users/Half-Shot/following{/other_user}","gists_url":"https://api.github.com/users/Half-Shot/gists{/gist_id}","starred_url":"https://api.github.com/users/Half-Shot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Half-Shot/subscriptions","organizations_url":"https://api.github.com/users/Half-Shot/orgs","repos_url":"https://api.github.com/users/Half-Shot/repos","events_url":"https://api.github.com/users/Half-Shot/events{/privacy}","received_events_url":"https://api.github.com/users/Half-Shot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Half-Shot/matrix-appservice-irc","description":"Node.js IRC bridge for Matrix","fork":true,"url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc","forks_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/forks","keys_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/teams","hooks_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/hooks","issue_events_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/issues/events{/number}","events_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/events","assignees_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/assignees{/user}","branches_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/branches{/branch}","tags_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/tags","blobs_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/statuses/{sha}","languages_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/languages","stargazers_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/stargazers","contributors_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/contributors","subscribers_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/subscribers","subscription_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/subscription","commits_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/contents/{+path}","compare_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/merges","archive_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/downloads","issues_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/issues{/number}","pulls_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/pulls{/number}","milestones_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/milestones{/number}","notifications_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/labels{/name}","releases_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/releases{/id}","deployments_url":"https://api.github.com/repos/Half-Shot/matrix-appservice-irc/deployments","created_at":"2018-06-04T13:45:02Z","updated_at":"2018-07-02T13:49:09Z","pushed_at":"2018-08-14T15:40:52Z","git_url":"git://github.com/Half-Shot/matrix-appservice-irc.git","ssh_url":"git@github.com:Half-Shot/matrix-appservice-irc.git","clone_url":"https://github.com/Half-Shot/matrix-appservice-irc.git","svn_url":"https://github.com/Half-Shot/matrix-appservice-irc","homepage":null,"size":2475,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matrix-org:develop","ref":"develop","sha":"56569f14ec80142a3ad8f52e4d10165dbbdc4f1e","user":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":31962644,"node_id":"MDEwOlJlcG9zaXRvcnkzMTk2MjY0NA==","name":"matrix-appservice-irc","full_name":"matrix-org/matrix-appservice-irc","owner":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/matrix-appservice-irc","description":"Node.js IRC bridge for Matrix","fork":false,"url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc","forks_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/forks","keys_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/teams","hooks_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/events","assignees_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/tags","blobs_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/languages","stargazers_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/subscription","commits_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/merges","archive_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/downloads","issues_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/deployments","created_at":"2015-03-10T14:42:06Z","updated_at":"2018-08-14T14:51:38Z","pushed_at":"2018-08-14T15:42:21Z","git_url":"git://github.com/matrix-org/matrix-appservice-irc.git","ssh_url":"git@github.com:matrix-org/matrix-appservice-irc.git","clone_url":"https://github.com/matrix-org/matrix-appservice-irc.git","svn_url":"https://github.com/matrix-org/matrix-appservice-irc","homepage":null,"size":2471,"stargazers_count":129,"watchers_count":129,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":211,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":42,"open_issues":211,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/647"},"html":{"href":"https://github.com/matrix-org/matrix-appservice-irc/pull/647"},"issue":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues/647"},"comments":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues/647/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/647/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/647/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/statuses/6e0ac53ca578b1bf353e97a2d75f624b8612377a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Half-Shot"}}