{"action":"created","issue":{"url":"https://api.github.com/repos/HazyResearch/metal/issues/105","repository_url":"https://api.github.com/repos/HazyResearch/metal","labels_url":"https://api.github.com/repos/HazyResearch/metal/issues/105/labels{/name}","comments_url":"https://api.github.com/repos/HazyResearch/metal/issues/105/comments","events_url":"https://api.github.com/repos/HazyResearch/metal/issues/105/events","html_url":"https://github.com/HazyResearch/metal/pull/105","id":386495501,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjE3MTM2","number":105,"title":"Adds deterministic seeding for EndModel, submodules; adds hyperparam search over submodules","user":{"login":"ajratner","id":1585405,"node_id":"MDQ6VXNlcjE1ODU0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1585405?v=4","gravatar_id":"","url":"https://api.github.com/users/ajratner","html_url":"https://github.com/ajratner","followers_url":"https://api.github.com/users/ajratner/followers","following_url":"https://api.github.com/users/ajratner/following{/other_user}","gists_url":"https://api.github.com/users/ajratner/gists{/gist_id}","starred_url":"https://api.github.com/users/ajratner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajratner/subscriptions","organizations_url":"https://api.github.com/users/ajratner/orgs","repos_url":"https://api.github.com/users/ajratner/repos","events_url":"https://api.github.com/users/ajratner/events{/privacy}","received_events_url":"https://api.github.com/users/ajratner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-01T20:38:18Z","updated_at":"2018-12-02T03:32:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/HazyResearch/metal/pulls/105","html_url":"https://github.com/HazyResearch/metal/pull/105","diff_url":"https://github.com/HazyResearch/metal/pull/105.diff","patch_url":"https://github.com/HazyResearch/metal/pull/105.patch"},"body":"Major changes:\r\n- Adds tests to ensure that given a random seed, `EndModel` is deterministic, including with submodules, e.g. `LSTMModule` as input layer\r\n- Adds support to `Tuner` classes to search over the submodule hyperparameters\r\n- Sets seed in `LSTMModule` random embeddings initialization\r\n\r\nMinor things to check:\r\n- Gets rid of unnamed pass-through hyperparameters in `LSTMModule` (to `nn.LSTM`); this was prompted by making things work in the `Tuner`, but seems much cleaner? Can always just add more explicitly named pass-through kwargs...\r\n- Gets rid of cycling through random seeds in `Tuner` class during model search. The `Tuner` already has a global seed, and the models have seeds, so this just seems unnecessary, unless I am missing something?  It seems natural to expect that if two configs in the search space have the same hyperparams, the models should output the same results.\r\n\r\nOther todos:\r\n- [x] Add option to use different `validation_metric` in `Tuner`\r\n- [x] Fix handling of `model.eval` and `model.train`; default to the former, except for in `self._train_model`\r\n- [x] Make sure correct validation metric passed through to dev checkpointer in `Tuner`\r\n- [x] Stop the `Tuner` from double-printing scores when dev checkpointer on"},"comment":{"url":"https://api.github.com/repos/HazyResearch/metal/issues/comments/443478202","html_url":"https://github.com/HazyResearch/metal/pull/105#issuecomment-443478202","issue_url":"https://api.github.com/repos/HazyResearch/metal/issues/105","id":443478202,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzQ3ODIwMg==","user":{"login":"ajratner","id":1585405,"node_id":"MDQ6VXNlcjE1ODU0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1585405?v=4","gravatar_id":"","url":"https://api.github.com/users/ajratner","html_url":"https://github.com/ajratner","followers_url":"https://api.github.com/users/ajratner/followers","following_url":"https://api.github.com/users/ajratner/following{/other_user}","gists_url":"https://api.github.com/users/ajratner/gists{/gist_id}","starred_url":"https://api.github.com/users/ajratner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajratner/subscriptions","organizations_url":"https://api.github.com/users/ajratner/orgs","repos_url":"https://api.github.com/users/ajratner/repos","events_url":"https://api.github.com/users/ajratner/events{/privacy}","received_events_url":"https://api.github.com/users/ajratner/received_events","type":"User","site_admin":false},"created_at":"2018-12-02T03:32:11Z","updated_at":"2018-12-02T03:32:11Z","author_association":"CONTRIBUTOR","body":"@jason-fries @jdunnmon @bhancock8 ready for review :)!"}}
{"actor":{"display_login":"ajratner"}}