{"action":"created","comment":{"url":"https://api.github.com/repos/google/go-tpm/pulls/comments/231640483","pull_request_review_id":172653910,"id":231640483,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTY0MDQ4Mw==","diff_hunk":"@@ -11,6 +11,14 @@ import (\n \t\"github.com/google/go-tpm/tpm2\"\n )\n \n+func mustDecodeBase64(in string) []byte {\n+\td, err := base64.StdEncoding.DecodeString(in)\n+\tif err != nil {\n+\t\tpanic(err)","path":"tpm2/credactivation/credential_activation_test.go","position":null,"original_position":7,"commit_id":"69d46fbc7aa31865bfed6c518ec3ce411cd4b67e","original_commit_id":"6e6980315fcb6549ed21c2712f5dcf6d32aee400","user":{"login":"twitchy-jsonp","id":40675700,"node_id":"MDQ6VXNlcjQwNjc1NzAw","avatar_url":"https://avatars3.githubusercontent.com/u/40675700?v=4","gravatar_id":"","url":"https://api.github.com/users/twitchy-jsonp","html_url":"https://github.com/twitchy-jsonp","followers_url":"https://api.github.com/users/twitchy-jsonp/followers","following_url":"https://api.github.com/users/twitchy-jsonp/following{/other_user}","gists_url":"https://api.github.com/users/twitchy-jsonp/gists{/gist_id}","starred_url":"https://api.github.com/users/twitchy-jsonp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitchy-jsonp/subscriptions","organizations_url":"https://api.github.com/users/twitchy-jsonp/orgs","repos_url":"https://api.github.com/users/twitchy-jsonp/repos","events_url":"https://api.github.com/users/twitchy-jsonp/events{/privacy}","received_events_url":"https://api.github.com/users/twitchy-jsonp/received_events","type":"User","site_admin":false},"body":"Done :)","created_at":"2018-11-07T19:14:41Z","updated_at":"2018-11-07T19:14:41Z","html_url":"https://github.com/google/go-tpm/pull/44#discussion_r231640483","pull_request_url":"https://api.github.com/repos/google/go-tpm/pulls/44","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/go-tpm/pulls/comments/231640483"},"html":{"href":"https://github.com/google/go-tpm/pull/44#discussion_r231640483"},"pull_request":{"href":"https://api.github.com/repos/google/go-tpm/pulls/44"}},"in_reply_to_id":231633389},"pull_request":{"url":"https://api.github.com/repos/google/go-tpm/pulls/44","id":227471867,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDcxODY3","html_url":"https://github.com/google/go-tpm/pull/44","diff_url":"https://github.com/google/go-tpm/pull/44.diff","patch_url":"https://github.com/google/go-tpm/pull/44.patch","issue_url":"https://api.github.com/repos/google/go-tpm/issues/44","number":44,"state":"open","locked":false,"title":"Implement generation of blob for Credential Activation /w RSA EKs compliant with the TCG 2.0 EK Credential Profile","user":{"login":"twitchy-jsonp","id":40675700,"node_id":"MDQ6VXNlcjQwNjc1NzAw","avatar_url":"https://avatars3.githubusercontent.com/u/40675700?v=4","gravatar_id":"","url":"https://api.github.com/users/twitchy-jsonp","html_url":"https://github.com/twitchy-jsonp","followers_url":"https://api.github.com/users/twitchy-jsonp/followers","following_url":"https://api.github.com/users/twitchy-jsonp/following{/other_user}","gists_url":"https://api.github.com/users/twitchy-jsonp/gists{/gist_id}","starred_url":"https://api.github.com/users/twitchy-jsonp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitchy-jsonp/subscriptions","organizations_url":"https://api.github.com/users/twitchy-jsonp/orgs","repos_url":"https://api.github.com/users/twitchy-jsonp/repos","events_url":"https://api.github.com/users/twitchy-jsonp/events{/privacy}","received_events_url":"https://api.github.com/users/twitchy-jsonp/received_events","type":"User","site_admin":false},"body":"DO NOT SUBMIT till the KDFa() PR is submitted, this is based on that. Please review `tpm2/credential_activation*` files in the meantime (ignore the KDF stuff)\r\n\r\nGenerateCredentialActivation creates a wrapped secret for use in credential activation. This function implements the minimum necessary to compute activations for RSA EKs compliant with TCG 2.0 EK Credential Profile specification, revision 14.\r\n\r\nCredential Protection is defined in section 24 of the TPM specification revision 2 part 1.\r\n\r\nThis should support TPM2 RSA EKs on all Windows8+ compliant hardware. The test data was derived from real hardware.\r\n\r\nThe GenerateCredentialActivation function has more parameters than necessary ATM: This is to allow us to support credential activation with different EK parameters in the future, without changing the function signature.\r\n","created_at":"2018-10-31T23:28:01Z","updated_at":"2018-11-07T19:14:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc08a295292822c0a49242f80218d63f5156590e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/go-tpm/pulls/44/commits","review_comments_url":"https://api.github.com/repos/google/go-tpm/pulls/44/comments","review_comment_url":"https://api.github.com/repos/google/go-tpm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/go-tpm/issues/44/comments","statuses_url":"https://api.github.com/repos/google/go-tpm/statuses/69d46fbc7aa31865bfed6c518ec3ce411cd4b67e","head":{"label":"twitchy-jsonp:credactivation","ref":"credactivation","sha":"69d46fbc7aa31865bfed6c518ec3ce411cd4b67e","user":{"login":"twitchy-jsonp","id":40675700,"node_id":"MDQ6VXNlcjQwNjc1NzAw","avatar_url":"https://avatars3.githubusercontent.com/u/40675700?v=4","gravatar_id":"","url":"https://api.github.com/users/twitchy-jsonp","html_url":"https://github.com/twitchy-jsonp","followers_url":"https://api.github.com/users/twitchy-jsonp/followers","following_url":"https://api.github.com/users/twitchy-jsonp/following{/other_user}","gists_url":"https://api.github.com/users/twitchy-jsonp/gists{/gist_id}","starred_url":"https://api.github.com/users/twitchy-jsonp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitchy-jsonp/subscriptions","organizations_url":"https://api.github.com/users/twitchy-jsonp/orgs","repos_url":"https://api.github.com/users/twitchy-jsonp/repos","events_url":"https://api.github.com/users/twitchy-jsonp/events{/privacy}","received_events_url":"https://api.github.com/users/twitchy-jsonp/received_events","type":"User","site_admin":false},"repo":{"id":154224199,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQyMjQxOTk=","name":"go-tpm","full_name":"twitchy-jsonp/go-tpm","private":false,"owner":{"login":"twitchy-jsonp","id":40675700,"node_id":"MDQ6VXNlcjQwNjc1NzAw","avatar_url":"https://avatars3.githubusercontent.com/u/40675700?v=4","gravatar_id":"","url":"https://api.github.com/users/twitchy-jsonp","html_url":"https://github.com/twitchy-jsonp","followers_url":"https://api.github.com/users/twitchy-jsonp/followers","following_url":"https://api.github.com/users/twitchy-jsonp/following{/other_user}","gists_url":"https://api.github.com/users/twitchy-jsonp/gists{/gist_id}","starred_url":"https://api.github.com/users/twitchy-jsonp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitchy-jsonp/subscriptions","organizations_url":"https://api.github.com/users/twitchy-jsonp/orgs","repos_url":"https://api.github.com/users/twitchy-jsonp/repos","events_url":"https://api.github.com/users/twitchy-jsonp/events{/privacy}","received_events_url":"https://api.github.com/users/twitchy-jsonp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/twitchy-jsonp/go-tpm","description":null,"fork":true,"url":"https://api.github.com/repos/twitchy-jsonp/go-tpm","forks_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/forks","keys_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/teams","hooks_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/hooks","issue_events_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/issues/events{/number}","events_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/events","assignees_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/assignees{/user}","branches_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/branches{/branch}","tags_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/tags","blobs_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/statuses/{sha}","languages_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/languages","stargazers_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/stargazers","contributors_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/contributors","subscribers_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/subscribers","subscription_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/subscription","commits_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/contents/{+path}","compare_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/merges","archive_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/downloads","issues_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/issues{/number}","pulls_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/pulls{/number}","milestones_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/milestones{/number}","notifications_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/labels{/name}","releases_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/releases{/id}","deployments_url":"https://api.github.com/repos/twitchy-jsonp/go-tpm/deployments","created_at":"2018-10-22T22:12:23Z","updated_at":"2018-11-06T22:05:46Z","pushed_at":"2018-11-07T19:14:24Z","git_url":"git://github.com/twitchy-jsonp/go-tpm.git","ssh_url":"git@github.com:twitchy-jsonp/go-tpm.git","clone_url":"https://github.com/twitchy-jsonp/go-tpm.git","svn_url":"https://github.com/twitchy-jsonp/go-tpm","homepage":null,"size":287,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"505380536ff72d4a1c175068b6f791d731634011","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":22929140,"node_id":"MDEwOlJlcG9zaXRvcnkyMjkyOTE0MA==","name":"go-tpm","full_name":"google/go-tpm","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/go-tpm","description":null,"fork":false,"url":"https://api.github.com/repos/google/go-tpm","forks_url":"https://api.github.com/repos/google/go-tpm/forks","keys_url":"https://api.github.com/repos/google/go-tpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/go-tpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/go-tpm/teams","hooks_url":"https://api.github.com/repos/google/go-tpm/hooks","issue_events_url":"https://api.github.com/repos/google/go-tpm/issues/events{/number}","events_url":"https://api.github.com/repos/google/go-tpm/events","assignees_url":"https://api.github.com/repos/google/go-tpm/assignees{/user}","branches_url":"https://api.github.com/repos/google/go-tpm/branches{/branch}","tags_url":"https://api.github.com/repos/google/go-tpm/tags","blobs_url":"https://api.github.com/repos/google/go-tpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/go-tpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/go-tpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/go-tpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/go-tpm/statuses/{sha}","languages_url":"https://api.github.com/repos/google/go-tpm/languages","stargazers_url":"https://api.github.com/repos/google/go-tpm/stargazers","contributors_url":"https://api.github.com/repos/google/go-tpm/contributors","subscribers_url":"https://api.github.com/repos/google/go-tpm/subscribers","subscription_url":"https://api.github.com/repos/google/go-tpm/subscription","commits_url":"https://api.github.com/repos/google/go-tpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/go-tpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/go-tpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/go-tpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/go-tpm/contents/{+path}","compare_url":"https://api.github.com/repos/google/go-tpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/go-tpm/merges","archive_url":"https://api.github.com/repos/google/go-tpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/go-tpm/downloads","issues_url":"https://api.github.com/repos/google/go-tpm/issues{/number}","pulls_url":"https://api.github.com/repos/google/go-tpm/pulls{/number}","milestones_url":"https://api.github.com/repos/google/go-tpm/milestones{/number}","notifications_url":"https://api.github.com/repos/google/go-tpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/go-tpm/labels{/name}","releases_url":"https://api.github.com/repos/google/go-tpm/releases{/id}","deployments_url":"https://api.github.com/repos/google/go-tpm/deployments","created_at":"2014-08-13T19:53:34Z","updated_at":"2018-11-06T23:48:14Z","pushed_at":"2018-11-07T19:14:26Z","git_url":"git://github.com/google/go-tpm.git","ssh_url":"git@github.com:google/go-tpm.git","clone_url":"https://github.com/google/go-tpm.git","svn_url":"https://github.com/google/go-tpm","homepage":null,"size":248,"stargazers_count":142,"watchers_count":142,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":42,"open_issues":4,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/go-tpm/pulls/44"},"html":{"href":"https://github.com/google/go-tpm/pull/44"},"issue":{"href":"https://api.github.com/repos/google/go-tpm/issues/44"},"comments":{"href":"https://api.github.com/repos/google/go-tpm/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/google/go-tpm/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/google/go-tpm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/go-tpm/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/google/go-tpm/statuses/69d46fbc7aa31865bfed6c518ec3ce411cd4b67e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"twitchy-jsonp"}}