{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/174656432","pull_request_review_id":104052541,"id":174656432,"diff_hunk":"@@ -0,0 +1,106 @@\n+/*","path":"cmd/kubeadm/app/phases/upgrade/postupgrade_v18_19.go","position":1,"original_position":1,"commit_id":"d65716ca600e1818b9a6a5f89259e7323fb37650","original_commit_id":"d65716ca600e1818b9a6a5f89259e7323fb37650","user":{"login":"dixudx","id":5449021,"avatar_url":"https://avatars3.githubusercontent.com/u/5449021?v=4","gravatar_id":"","url":"https://api.github.com/users/dixudx","html_url":"https://github.com/dixudx","followers_url":"https://api.github.com/users/dixudx/followers","following_url":"https://api.github.com/users/dixudx/following{/other_user}","gists_url":"https://api.github.com/users/dixudx/gists{/gist_id}","starred_url":"https://api.github.com/users/dixudx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dixudx/subscriptions","organizations_url":"https://api.github.com/users/dixudx/orgs","repos_url":"https://api.github.com/users/dixudx/repos","events_url":"https://api.github.com/users/dixudx/events{/privacy}","received_events_url":"https://api.github.com/users/dixudx/received_events","type":"User","site_admin":false},"body":"This file does not belong to this PR.","created_at":"2018-03-15T01:31:38Z","updated_at":"2018-03-15T01:31:43Z","html_url":"https://github.com/kubernetes/kubernetes/pull/61026#discussion_r174656432","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61026","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/174656432"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/61026#discussion_r174656432"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61026"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61026","id":174269023,"html_url":"https://github.com/kubernetes/kubernetes/pull/61026","diff_url":"https://github.com/kubernetes/kubernetes/pull/61026.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/61026.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61026","number":61026,"state":"open","locked":false,"title":"fix grammar error: return should be returns.","user":{"login":"liangwenguo","id":31908085,"avatar_url":"https://avatars2.githubusercontent.com/u/31908085?v=4","gravatar_id":"","url":"https://api.github.com/users/liangwenguo","html_url":"https://github.com/liangwenguo","followers_url":"https://api.github.com/users/liangwenguo/followers","following_url":"https://api.github.com/users/liangwenguo/following{/other_user}","gists_url":"https://api.github.com/users/liangwenguo/gists{/gist_id}","starred_url":"https://api.github.com/users/liangwenguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangwenguo/subscriptions","organizations_url":"https://api.github.com/users/liangwenguo/orgs","repos_url":"https://api.github.com/users/liangwenguo/repos","events_url":"https://api.github.com/users/liangwenguo/events{/privacy}","received_events_url":"https://api.github.com/users/liangwenguo/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n\r\n```\r\n","created_at":"2018-03-12T04:13:13Z","updated_at":"2018-03-15T01:31:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"077944f16e4560afd30d91584366fa8c925d4d25","assignee":{"login":"jamiehannaford","id":1867202,"avatar_url":"https://avatars1.githubusercontent.com/u/1867202?v=4","gravatar_id":"","url":"https://api.github.com/users/jamiehannaford","html_url":"https://github.com/jamiehannaford","followers_url":"https://api.github.com/users/jamiehannaford/followers","following_url":"https://api.github.com/users/jamiehannaford/following{/other_user}","gists_url":"https://api.github.com/users/jamiehannaford/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiehannaford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiehannaford/subscriptions","organizations_url":"https://api.github.com/users/jamiehannaford/orgs","repos_url":"https://api.github.com/users/jamiehannaford/repos","events_url":"https://api.github.com/users/jamiehannaford/events{/privacy}","received_events_url":"https://api.github.com/users/jamiehannaford/received_events","type":"User","site_admin":true},"assignees":[{"login":"jamiehannaford","id":1867202,"avatar_url":"https://avatars1.githubusercontent.com/u/1867202?v=4","gravatar_id":"","url":"https://api.github.com/users/jamiehannaford","html_url":"https://github.com/jamiehannaford","followers_url":"https://api.github.com/users/jamiehannaford/followers","following_url":"https://api.github.com/users/jamiehannaford/following{/other_user}","gists_url":"https://api.github.com/users/jamiehannaford/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiehannaford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiehannaford/subscriptions","organizations_url":"https://api.github.com/users/jamiehannaford/orgs","repos_url":"https://api.github.com/users/jamiehannaford/repos","events_url":"https://api.github.com/users/jamiehannaford/events{/privacy}","received_events_url":"https://api.github.com/users/jamiehannaford/received_events","type":"User","site_admin":true},{"login":"dixudx","id":5449021,"avatar_url":"https://avatars3.githubusercontent.com/u/5449021?v=4","gravatar_id":"","url":"https://api.github.com/users/dixudx","html_url":"https://github.com/dixudx","followers_url":"https://api.github.com/users/dixudx/followers","following_url":"https://api.github.com/users/dixudx/following{/other_user}","gists_url":"https://api.github.com/users/dixudx/gists{/gist_id}","starred_url":"https://api.github.com/users/dixudx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dixudx/subscriptions","organizations_url":"https://api.github.com/users/dixudx/orgs","repos_url":"https://api.github.com/users/dixudx/repos","events_url":"https://api.github.com/users/dixudx/events{/privacy}","received_events_url":"https://api.github.com/users/dixudx/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"timothysc","id":169553,"avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61026/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61026/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61026/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d65716ca600e1818b9a6a5f89259e7323fb37650","head":{"label":"liangwenguo:spelling_check1","ref":"spelling_check1","sha":"d65716ca600e1818b9a6a5f89259e7323fb37650","user":{"login":"liangwenguo","id":31908085,"avatar_url":"https://avatars2.githubusercontent.com/u/31908085?v=4","gravatar_id":"","url":"https://api.github.com/users/liangwenguo","html_url":"https://github.com/liangwenguo","followers_url":"https://api.github.com/users/liangwenguo/followers","following_url":"https://api.github.com/users/liangwenguo/following{/other_user}","gists_url":"https://api.github.com/users/liangwenguo/gists{/gist_id}","starred_url":"https://api.github.com/users/liangwenguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangwenguo/subscriptions","organizations_url":"https://api.github.com/users/liangwenguo/orgs","repos_url":"https://api.github.com/users/liangwenguo/repos","events_url":"https://api.github.com/users/liangwenguo/events{/privacy}","received_events_url":"https://api.github.com/users/liangwenguo/received_events","type":"User","site_admin":false},"repo":{"id":106225034,"name":"kubernetes","full_name":"liangwenguo/kubernetes","owner":{"login":"liangwenguo","id":31908085,"avatar_url":"https://avatars2.githubusercontent.com/u/31908085?v=4","gravatar_id":"","url":"https://api.github.com/users/liangwenguo","html_url":"https://github.com/liangwenguo","followers_url":"https://api.github.com/users/liangwenguo/followers","following_url":"https://api.github.com/users/liangwenguo/following{/other_user}","gists_url":"https://api.github.com/users/liangwenguo/gists{/gist_id}","starred_url":"https://api.github.com/users/liangwenguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangwenguo/subscriptions","organizations_url":"https://api.github.com/users/liangwenguo/orgs","repos_url":"https://api.github.com/users/liangwenguo/repos","events_url":"https://api.github.com/users/liangwenguo/events{/privacy}","received_events_url":"https://api.github.com/users/liangwenguo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liangwenguo/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/liangwenguo/kubernetes","forks_url":"https://api.github.com/repos/liangwenguo/kubernetes/forks","keys_url":"https://api.github.com/repos/liangwenguo/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liangwenguo/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liangwenguo/kubernetes/teams","hooks_url":"https://api.github.com/repos/liangwenguo/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/liangwenguo/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/liangwenguo/kubernetes/events","assignees_url":"https://api.github.com/repos/liangwenguo/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/liangwenguo/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/liangwenguo/kubernetes/tags","blobs_url":"https://api.github.com/repos/liangwenguo/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liangwenguo/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liangwenguo/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/liangwenguo/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liangwenguo/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/liangwenguo/kubernetes/languages","stargazers_url":"https://api.github.com/repos/liangwenguo/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/liangwenguo/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/liangwenguo/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/liangwenguo/kubernetes/subscription","commits_url":"https://api.github.com/repos/liangwenguo/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/liangwenguo/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/liangwenguo/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/liangwenguo/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/liangwenguo/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/liangwenguo/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liangwenguo/kubernetes/merges","archive_url":"https://api.github.com/repos/liangwenguo/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liangwenguo/kubernetes/downloads","issues_url":"https://api.github.com/repos/liangwenguo/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/liangwenguo/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/liangwenguo/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/liangwenguo/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liangwenguo/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/liangwenguo/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/liangwenguo/kubernetes/deployments","created_at":"2017-10-09T01:50:44Z","updated_at":"2017-10-09T01:51:28Z","pushed_at":"2018-03-15T00:51:35Z","git_url":"git://github.com/liangwenguo/kubernetes.git","ssh_url":"git@github.com:liangwenguo/kubernetes.git","clone_url":"https://github.com/liangwenguo/kubernetes.git","svn_url":"https://github.com/liangwenguo/kubernetes","homepage":"http://kubernetes.io","size":539410,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"02611149c181f7fd9ab116c40d7ee32fb5934b7c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-03-15T01:15:08Z","pushed_at":"2018-03-15T00:51:41Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":764790,"stargazers_count":33738,"watchers_count":33738,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11968,"mirror_url":null,"archived":false,"open_issues_count":3533,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11968,"open_issues":3533,"watchers":33738,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61026"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/61026"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/61026"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/61026/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61026/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61026/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d65716ca600e1818b9a6a5f89259e7323fb37650"}},"author_association":"NONE"}}
{"actor":{"display_login":"dixudx"}}