{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/198473333","pull_request_review_id":132407931,"id":198473333,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODQ3MzMzMw==","diff_hunk":"@@ -17,4 +17,5 @@\n  * under the License.\n  */\n \n-export * from './loader';\n+export * from './visualize_loader';\n+export * from './visualization_loader';","path":"src/ui/public/visualize/loader/index.js","position":6,"original_position":6,"commit_id":"ef2a59900d0306e31cbc6e97ae8ea1a5ef092e68","original_commit_id":"ef2a59900d0306e31cbc6e97ae8ea1a5ef092e68","user":{"login":"timroes","id":877229,"node_id":"MDQ6VXNlcjg3NzIyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/877229?v=4","gravatar_id":"","url":"https://api.github.com/users/timroes","html_url":"https://github.com/timroes","followers_url":"https://api.github.com/users/timroes/followers","following_url":"https://api.github.com/users/timroes/following{/other_user}","gists_url":"https://api.github.com/users/timroes/gists{/gist_id}","starred_url":"https://api.github.com/users/timroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timroes/subscriptions","organizations_url":"https://api.github.com/users/timroes/orgs","repos_url":"https://api.github.com/users/timroes/repos","events_url":"https://api.github.com/users/timroes/events{/privacy}","received_events_url":"https://api.github.com/users/timroes/received_events","type":"User","site_admin":false},"body":"Since we don't want to make this a public API and rather remove it soon by the pipeline loader, could we perhaps not export this via the `index.js` file, so that we rather import from `ui/visualize/loader/visualization_loader`, and not having it in the same file that users import the visualize loader from, which we consider public?","created_at":"2018-06-27T12:22:59Z","updated_at":"2018-06-27T12:22:59Z","html_url":"https://github.com/elastic/kibana/pull/16425#discussion_r198473333","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/16425","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/198473333"},"html":{"href":"https://github.com/elastic/kibana/pull/16425#discussion_r198473333"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/16425"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/16425","id":166196590,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY2MTk2NTkw","html_url":"https://github.com/elastic/kibana/pull/16425","diff_url":"https://github.com/elastic/kibana/pull/16425.diff","patch_url":"https://github.com/elastic/kibana/pull/16425.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/16425","number":16425,"state":"open","locked":false,"title":"reactifying visualization","user":{"login":"ppisljar","id":13629809,"node_id":"MDQ6VXNlcjEzNjI5ODA5","avatar_url":"https://avatars2.githubusercontent.com/u/13629809?v=4","gravatar_id":"","url":"https://api.github.com/users/ppisljar","html_url":"https://github.com/ppisljar","followers_url":"https://api.github.com/users/ppisljar/followers","following_url":"https://api.github.com/users/ppisljar/following{/other_user}","gists_url":"https://api.github.com/users/ppisljar/gists{/gist_id}","starred_url":"https://api.github.com/users/ppisljar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppisljar/subscriptions","organizations_url":"https://api.github.com/users/ppisljar/orgs","repos_url":"https://api.github.com/users/ppisljar/repos","events_url":"https://api.github.com/users/ppisljar/events{/privacy}","received_events_url":"https://api.github.com/users/ppisljar/received_events","type":"User","site_admin":false},"body":"moves <visualization> from angular to react\r\n\r\nthis is based on top of #16249 and requires the new inspector panel (spy panel replacement) @timroes is working on before it can be merged\r\n\r\nhuge thanks to @timroes for helping me out with this :+1: \r\n\r\n","created_at":"2018-01-31T08:44:17Z","updated_at":"2018-06-27T12:22:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b6e8426cc5679c04f5c6f2e047805e4957221b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":462161355,"node_id":"MDU6TGFiZWw0NjIxNjEzNTU=","url":"https://api.github.com/repos/elastic/kibana/labels/:Visualizations","name":":Visualizations","color":"fef2c0","default":false},{"id":135307740,"node_id":"MDU6TGFiZWwxMzUzMDc3NDA=","url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"0052cc","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/16425/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/16425/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/16425/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/ef2a59900d0306e31cbc6e97ae8ea1a5ef092e68","head":{"label":"ppisljar:fix/visualizationReact","ref":"fix/visualizationReact","sha":"ef2a59900d0306e31cbc6e97ae8ea1a5ef092e68","user":{"login":"ppisljar","id":13629809,"node_id":"MDQ6VXNlcjEzNjI5ODA5","avatar_url":"https://avatars2.githubusercontent.com/u/13629809?v=4","gravatar_id":"","url":"https://api.github.com/users/ppisljar","html_url":"https://github.com/ppisljar","followers_url":"https://api.github.com/users/ppisljar/followers","following_url":"https://api.github.com/users/ppisljar/following{/other_user}","gists_url":"https://api.github.com/users/ppisljar/gists{/gist_id}","starred_url":"https://api.github.com/users/ppisljar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppisljar/subscriptions","organizations_url":"https://api.github.com/users/ppisljar/orgs","repos_url":"https://api.github.com/users/ppisljar/repos","events_url":"https://api.github.com/users/ppisljar/events{/privacy}","received_events_url":"https://api.github.com/users/ppisljar/received_events","type":"User","site_admin":false},"repo":{"id":62579218,"node_id":"MDEwOlJlcG9zaXRvcnk2MjU3OTIxOA==","name":"kibana","full_name":"ppisljar/kibana","owner":{"login":"ppisljar","id":13629809,"node_id":"MDQ6VXNlcjEzNjI5ODA5","avatar_url":"https://avatars2.githubusercontent.com/u/13629809?v=4","gravatar_id":"","url":"https://api.github.com/users/ppisljar","html_url":"https://github.com/ppisljar","followers_url":"https://api.github.com/users/ppisljar/followers","following_url":"https://api.github.com/users/ppisljar/following{/other_user}","gists_url":"https://api.github.com/users/ppisljar/gists{/gist_id}","starred_url":"https://api.github.com/users/ppisljar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppisljar/subscriptions","organizations_url":"https://api.github.com/users/ppisljar/orgs","repos_url":"https://api.github.com/users/ppisljar/repos","events_url":"https://api.github.com/users/ppisljar/events{/privacy}","received_events_url":"https://api.github.com/users/ppisljar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ppisljar/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/ppisljar/kibana","forks_url":"https://api.github.com/repos/ppisljar/kibana/forks","keys_url":"https://api.github.com/repos/ppisljar/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppisljar/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppisljar/kibana/teams","hooks_url":"https://api.github.com/repos/ppisljar/kibana/hooks","issue_events_url":"https://api.github.com/repos/ppisljar/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/ppisljar/kibana/events","assignees_url":"https://api.github.com/repos/ppisljar/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/ppisljar/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/ppisljar/kibana/tags","blobs_url":"https://api.github.com/repos/ppisljar/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppisljar/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppisljar/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppisljar/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppisljar/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/ppisljar/kibana/languages","stargazers_url":"https://api.github.com/repos/ppisljar/kibana/stargazers","contributors_url":"https://api.github.com/repos/ppisljar/kibana/contributors","subscribers_url":"https://api.github.com/repos/ppisljar/kibana/subscribers","subscription_url":"https://api.github.com/repos/ppisljar/kibana/subscription","commits_url":"https://api.github.com/repos/ppisljar/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppisljar/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppisljar/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppisljar/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppisljar/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/ppisljar/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppisljar/kibana/merges","archive_url":"https://api.github.com/repos/ppisljar/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppisljar/kibana/downloads","issues_url":"https://api.github.com/repos/ppisljar/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/ppisljar/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/ppisljar/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/ppisljar/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppisljar/kibana/labels{/name}","releases_url":"https://api.github.com/repos/ppisljar/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/ppisljar/kibana/deployments","created_at":"2016-07-04T17:45:16Z","updated_at":"2018-05-07T20:17:33Z","pushed_at":"2018-06-27T05:53:33Z","git_url":"git://github.com/ppisljar/kibana.git","ssh_url":"git@github.com:ppisljar/kibana.git","clone_url":"https://github.com/ppisljar/kibana.git","svn_url":"https://github.com/ppisljar/kibana","homepage":"https://www.elastic.co/products/kibana","size":412943,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"2b27fb1c5f43660e9f723594ae1489e68577530a","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-06-27T11:32:22Z","pushed_at":"2018-06-27T11:57:29Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":419039,"stargazers_count":9573,"watchers_count":9573,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3725,"mirror_url":null,"archived":false,"open_issues_count":3217,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3725,"open_issues":3217,"watchers":9573,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/16425"},"html":{"href":"https://github.com/elastic/kibana/pull/16425"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/16425"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/16425/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/16425/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/16425/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/ef2a59900d0306e31cbc6e97ae8ea1a5ef092e68"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"timroes"}}