{"action":"created","issue":{"url":"https://api.github.com/repos/Tradeshift/tradeshift-ui/issues/586","repository_url":"https://api.github.com/repos/Tradeshift/tradeshift-ui","labels_url":"https://api.github.com/repos/Tradeshift/tradeshift-ui/issues/586/labels{/name}","comments_url":"https://api.github.com/repos/Tradeshift/tradeshift-ui/issues/586/comments","events_url":"https://api.github.com/repos/Tradeshift/tradeshift-ui/issues/586/events","html_url":"https://github.com/Tradeshift/tradeshift-ui/issues/586","id":310770502,"number":586,"title":"Tradeshift UI versus Angular 1.5","user":{"login":"wiredearp","id":213869,"avatar_url":"https://avatars1.githubusercontent.com/u/213869?v=4","gravatar_id":"","url":"https://api.github.com/users/wiredearp","html_url":"https://github.com/wiredearp","followers_url":"https://api.github.com/users/wiredearp/followers","following_url":"https://api.github.com/users/wiredearp/following{/other_user}","gists_url":"https://api.github.com/users/wiredearp/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredearp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredearp/subscriptions","organizations_url":"https://api.github.com/users/wiredearp/orgs","repos_url":"https://api.github.com/users/wiredearp/repos","events_url":"https://api.github.com/users/wiredearp/events{/privacy}","received_events_url":"https://api.github.com/users/wiredearp/received_events","type":"User","site_admin":false},"labels":[{"id":441095402,"url":"https://api.github.com/repos/Tradeshift/tradeshift-ui/labels/issue:%20bug","name":"issue: bug","color":"fc2929","default":false},{"id":441095407,"url":"https://api.github.com/repos/Tradeshift/tradeshift-ui/labels/issue:%20question","name":"issue: question","color":"cc317c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-03T09:59:38Z","updated_at":"2018-04-03T10:04:09Z","closed_at":null,"author_association":"COLLABORATOR","body":"Inspired by this (Tradeshift internal) thread in Slack: https://tradeshift.slack.com/archives/C02TX8JJ7/p1522655604000193\r\n\r\n1. UI components initialize as soon as the associated element gets appended to the page DOM.\r\n2. It appears that Angular 1.5 now always compiles DOM structures in the page DOM, where before they did it in a detached DOM, inside a DocumentFragment, for performance reasons.\r\n3. This causes some UI components to behave differently in Angular 1.5, so we will have to adapt.\r\n4. The problem is know to affect (at least) the Switch in Forms.\r\n\r\nThe Angular guys probably did this for the same reason that we do it: Because a directive that needs information about the elements width or height or padding or margin (or just about any CSS property you can think of) requires for the element to be positioned in the DOM when you measure the property, or otherwise these lookups will return misleading values (such as zero for the width and height)."},"comment":{"url":"https://api.github.com/repos/Tradeshift/tradeshift-ui/issues/comments/378197549","html_url":"https://github.com/Tradeshift/tradeshift-ui/issues/586#issuecomment-378197549","issue_url":"https://api.github.com/repos/Tradeshift/tradeshift-ui/issues/586","id":378197549,"user":{"login":"n-srg","id":22394106,"avatar_url":"https://avatars0.githubusercontent.com/u/22394106?v=4","gravatar_id":"","url":"https://api.github.com/users/n-srg","html_url":"https://github.com/n-srg","followers_url":"https://api.github.com/users/n-srg/followers","following_url":"https://api.github.com/users/n-srg/following{/other_user}","gists_url":"https://api.github.com/users/n-srg/gists{/gist_id}","starred_url":"https://api.github.com/users/n-srg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n-srg/subscriptions","organizations_url":"https://api.github.com/users/n-srg/orgs","repos_url":"https://api.github.com/users/n-srg/repos","events_url":"https://api.github.com/users/n-srg/events{/privacy}","received_events_url":"https://api.github.com/users/n-srg/received_events","type":"User","site_admin":false},"created_at":"2018-04-03T10:04:09Z","updated_at":"2018-04-03T10:04:09Z","author_association":"NONE","body":"Thank you, I can share my pr, where you can check what is going on https://github.com/Tradeshift/Apps/pull/7168"}}
{"actor":{"display_login":"n-srg"}}