{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/paknahad/jsonapi-bundle/pulls/7","id":221429576,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNDI5NTc2","html_url":"https://github.com/paknahad/jsonapi-bundle/pull/7","diff_url":"https://github.com/paknahad/jsonapi-bundle/pull/7.diff","patch_url":"https://github.com/paknahad/jsonapi-bundle/pull/7.patch","issue_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/issues/7","number":7,"state":"closed","locked":false,"title":" Support more advanced filtering in query #5","user":{"login":"mnugter","id":1712411,"node_id":"MDQ6VXNlcjE3MTI0MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1712411?v=4","gravatar_id":"","url":"https://api.github.com/users/mnugter","html_url":"https://github.com/mnugter","followers_url":"https://api.github.com/users/mnugter/followers","following_url":"https://api.github.com/users/mnugter/following{/other_user}","gists_url":"https://api.github.com/users/mnugter/gists{/gist_id}","starred_url":"https://api.github.com/users/mnugter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnugter/subscriptions","organizations_url":"https://api.github.com/users/mnugter/orgs","repos_url":"https://api.github.com/users/mnugter/repos","events_url":"https://api.github.com/users/mnugter/events{/privacy}","received_events_url":"https://api.github.com/users/mnugter/received_events","type":"User","site_admin":false},"body":"I changed the Finder implementation to use a tag based discovery pattern.\r\n\r\nThe controller works via a FinderCollection and this class iterates over all services with the tag 'paknahad.json_api.finder'. Each Finder can add filtering to the Querybuilder.\r\n\r\nA lot of code changed / was added to make it use tag based discovery. I also moved some code to the FinderCollection and I removed the specific $request->get('filter', []) from the generated Controllers.","created_at":"2018-10-09T13:00:10Z","updated_at":"2018-10-10T12:17:24Z","closed_at":"2018-10-10T12:17:24Z","merged_at":null,"merge_commit_sha":"6156b0356e7b9aa3774cdf3e744be11346b07916","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/pulls/7/commits","review_comments_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/pulls/7/comments","review_comment_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/issues/7/comments","statuses_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/statuses/168e6546e58a6b4286d981fd52fa50e1dfe4cf47","head":{"label":"mnugter:master","ref":"master","sha":"168e6546e58a6b4286d981fd52fa50e1dfe4cf47","user":{"login":"mnugter","id":1712411,"node_id":"MDQ6VXNlcjE3MTI0MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1712411?v=4","gravatar_id":"","url":"https://api.github.com/users/mnugter","html_url":"https://github.com/mnugter","followers_url":"https://api.github.com/users/mnugter/followers","following_url":"https://api.github.com/users/mnugter/following{/other_user}","gists_url":"https://api.github.com/users/mnugter/gists{/gist_id}","starred_url":"https://api.github.com/users/mnugter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnugter/subscriptions","organizations_url":"https://api.github.com/users/mnugter/orgs","repos_url":"https://api.github.com/users/mnugter/repos","events_url":"https://api.github.com/users/mnugter/events{/privacy}","received_events_url":"https://api.github.com/users/mnugter/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"paknahad:master","ref":"master","sha":"d9d551f1da7811e12f4ccf05ab43f6c448773101","user":{"login":"paknahad","id":1970573,"node_id":"MDQ6VXNlcjE5NzA1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1970573?v=4","gravatar_id":"","url":"https://api.github.com/users/paknahad","html_url":"https://github.com/paknahad","followers_url":"https://api.github.com/users/paknahad/followers","following_url":"https://api.github.com/users/paknahad/following{/other_user}","gists_url":"https://api.github.com/users/paknahad/gists{/gist_id}","starred_url":"https://api.github.com/users/paknahad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paknahad/subscriptions","organizations_url":"https://api.github.com/users/paknahad/orgs","repos_url":"https://api.github.com/users/paknahad/repos","events_url":"https://api.github.com/users/paknahad/events{/privacy}","received_events_url":"https://api.github.com/users/paknahad/received_events","type":"User","site_admin":false},"repo":{"id":143162137,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxNjIxMzc=","name":"jsonapi-bundle","full_name":"paknahad/jsonapi-bundle","private":false,"owner":{"login":"paknahad","id":1970573,"node_id":"MDQ6VXNlcjE5NzA1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1970573?v=4","gravatar_id":"","url":"https://api.github.com/users/paknahad","html_url":"https://github.com/paknahad","followers_url":"https://api.github.com/users/paknahad/followers","following_url":"https://api.github.com/users/paknahad/following{/other_user}","gists_url":"https://api.github.com/users/paknahad/gists{/gist_id}","starred_url":"https://api.github.com/users/paknahad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paknahad/subscriptions","organizations_url":"https://api.github.com/users/paknahad/orgs","repos_url":"https://api.github.com/users/paknahad/repos","events_url":"https://api.github.com/users/paknahad/events{/privacy}","received_events_url":"https://api.github.com/users/paknahad/received_events","type":"User","site_admin":false},"html_url":"https://github.com/paknahad/jsonapi-bundle","description":"the fastest way to generate API based on jsonapi.org  using woohoolabs/yin","fork":false,"url":"https://api.github.com/repos/paknahad/jsonapi-bundle","forks_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/forks","keys_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/teams","hooks_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/hooks","issue_events_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/events","assignees_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/tags","blobs_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/languages","stargazers_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/stargazers","contributors_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/contributors","subscribers_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/subscribers","subscription_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/subscription","commits_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/merges","archive_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/downloads","issues_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/labels{/name}","releases_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/paknahad/jsonapi-bundle/deployments","created_at":"2018-08-01T13:47:04Z","updated_at":"2018-10-10T08:12:50Z","pushed_at":"2018-10-09T13:00:11Z","git_url":"git://github.com/paknahad/jsonapi-bundle.git","ssh_url":"git@github.com:paknahad/jsonapi-bundle.git","clone_url":"https://github.com/paknahad/jsonapi-bundle.git","svn_url":"https://github.com/paknahad/jsonapi-bundle","homepage":null,"size":54,"stargazers_count":18,"watchers_count":18,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":2,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paknahad/jsonapi-bundle/pulls/7"},"html":{"href":"https://github.com/paknahad/jsonapi-bundle/pull/7"},"issue":{"href":"https://api.github.com/repos/paknahad/jsonapi-bundle/issues/7"},"comments":{"href":"https://api.github.com/repos/paknahad/jsonapi-bundle/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/paknahad/jsonapi-bundle/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/paknahad/jsonapi-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paknahad/jsonapi-bundle/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/paknahad/jsonapi-bundle/statuses/168e6546e58a6b4286d981fd52fa50e1dfe4cf47"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":0,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"mnugter"}}