{"action":"created","comment":{"url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/comments/166011731","pull_request_review_id":94034936,"id":166011731,"diff_hunk":"@@ -49,23 +45,10 @@\n public class MoveObjectsController {\n     private static final Logger log = LoggerFactory.getLogger(MoveObjectsController.class);\n \n-//    @Autowired\n-//    private TripleStoreQueryService tripleStoreQueryService;\n-//    @Autowired\n-//    private DigitalObjectManager digitalObjectManager;\n-\n-    private final Long TIME_TO_LIVE_AFTER_FINISH = 12000L;\n-\n-    private final Map<String, MoveRequest> moveRequests;\n-\n-    @Autowired\n-    private ExecutorService moveExecutor;\n-\n     @Autowired\n-    private ActivityMetricsClient operationMetrics;\n+    private MoveObjectsService moveObjectsService;\n \n     public MoveObjectsController() {\n-        moveRequests = new HashMap<>();\n     }\n \n     @RequestMapping(value = \"edit/move\", method = RequestMethod.POST)","path":"services/src/main/java/edu/unc/lib/dl/cdr/services/rest/modify/MoveObjectsController.java","position":54,"original_position":54,"commit_id":"88ed2c5a4955b5960449140055ea92f82a42074a","original_commit_id":"88ed2c5a4955b5960449140055ea92f82a42074a","user":{"login":"harringj","id":21954788,"avatar_url":"https://avatars2.githubusercontent.com/u/21954788?v=4","gravatar_id":"","url":"https://api.github.com/users/harringj","html_url":"https://github.com/harringj","followers_url":"https://api.github.com/users/harringj/followers","following_url":"https://api.github.com/users/harringj/following{/other_user}","gists_url":"https://api.github.com/users/harringj/gists{/gist_id}","starred_url":"https://api.github.com/users/harringj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harringj/subscriptions","organizations_url":"https://api.github.com/users/harringj/orgs","repos_url":"https://api.github.com/users/harringj/repos","events_url":"https://api.github.com/users/harringj/events{/privacy}","received_events_url":"https://api.github.com/users/harringj/received_events","type":"User","site_admin":false},"body":"i think it might be a good idea to have this controller's organization match what we've been doing with our other controllers recently. so, e.g., moveObjects() should call a private method within the controller that would itself return a ResponseEntity. also, at line 60 there is an opening '{' that never gets closed. and while we're at it, maybe remove the unnecessary default constructor for MoveRequest at line 94","created_at":"2018-02-05T15:44:07Z","updated_at":"2018-02-05T15:44:07Z","html_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository/pull/705#discussion_r166011731","pull_request_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/705","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/comments/166011731"},"html":{"href":"https://github.com/UNC-Libraries/Carolina-Digital-Repository/pull/705#discussion_r166011731"},"pull_request":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/705"}}},"pull_request":{"url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/705","id":166392723,"html_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository/pull/705","diff_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository/pull/705.diff","patch_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository/pull/705.patch","issue_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/705","number":705,"state":"open","locked":false,"title":"Cdr-1902 Implement Move Operation","user":{"login":"bbpennel","id":969810,"avatar_url":"https://avatars2.githubusercontent.com/u/969810?v=4","gravatar_id":"","url":"https://api.github.com/users/bbpennel","html_url":"https://github.com/bbpennel","followers_url":"https://api.github.com/users/bbpennel/followers","following_url":"https://api.github.com/users/bbpennel/following{/other_user}","gists_url":"https://api.github.com/users/bbpennel/gists{/gist_id}","starred_url":"https://api.github.com/users/bbpennel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbpennel/subscriptions","organizations_url":"https://api.github.com/users/bbpennel/orgs","repos_url":"https://api.github.com/users/bbpennel/repos","events_url":"https://api.github.com/users/bbpennel/events{/privacy}","received_events_url":"https://api.github.com/users/bbpennel/received_events","type":"User","site_admin":false},"body":"* Updates move workflow to work against fcrepo4\r\n  * Adds unit and integration tests\r\n  * Adds move log\r\n  * Currently removes reporting on move operations to users\r\n* Adds helper methods to ObjectPathFactory and ObjectPath classes to make them more usable, adds unit test\r\n* Removes getGroups method from AgentPrincipal class in favor of getPrincipals","created_at":"2018-01-31T22:21:46Z","updated_at":"2018-02-05T15:44:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"742401733d9f89a83bffaa468228eebd2040e292","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/705/commits","review_comments_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/705/comments","review_comment_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/705/comments","statuses_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/statuses/88ed2c5a4955b5960449140055ea92f82a42074a","head":{"label":"UNC-Libraries:cdr1902-move","ref":"cdr1902-move","sha":"88ed2c5a4955b5960449140055ea92f82a42074a","user":{"login":"UNC-Libraries","id":552066,"avatar_url":"https://avatars0.githubusercontent.com/u/552066?v=4","gravatar_id":"","url":"https://api.github.com/users/UNC-Libraries","html_url":"https://github.com/UNC-Libraries","followers_url":"https://api.github.com/users/UNC-Libraries/followers","following_url":"https://api.github.com/users/UNC-Libraries/following{/other_user}","gists_url":"https://api.github.com/users/UNC-Libraries/gists{/gist_id}","starred_url":"https://api.github.com/users/UNC-Libraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNC-Libraries/subscriptions","organizations_url":"https://api.github.com/users/UNC-Libraries/orgs","repos_url":"https://api.github.com/users/UNC-Libraries/repos","events_url":"https://api.github.com/users/UNC-Libraries/events{/privacy}","received_events_url":"https://api.github.com/users/UNC-Libraries/received_events","type":"Organization","site_admin":false},"repo":{"id":2357859,"name":"Carolina-Digital-Repository","full_name":"UNC-Libraries/Carolina-Digital-Repository","owner":{"login":"UNC-Libraries","id":552066,"avatar_url":"https://avatars0.githubusercontent.com/u/552066?v=4","gravatar_id":"","url":"https://api.github.com/users/UNC-Libraries","html_url":"https://github.com/UNC-Libraries","followers_url":"https://api.github.com/users/UNC-Libraries/followers","following_url":"https://api.github.com/users/UNC-Libraries/following{/other_user}","gists_url":"https://api.github.com/users/UNC-Libraries/gists{/gist_id}","starred_url":"https://api.github.com/users/UNC-Libraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNC-Libraries/subscriptions","organizations_url":"https://api.github.com/users/UNC-Libraries/orgs","repos_url":"https://api.github.com/users/UNC-Libraries/repos","events_url":"https://api.github.com/users/UNC-Libraries/events{/privacy}","received_events_url":"https://api.github.com/users/UNC-Libraries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository","description":"Carolina Digital Repository","fork":false,"url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository","forks_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/forks","keys_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/teams","hooks_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/hooks","issue_events_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/events{/number}","events_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/events","assignees_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/assignees{/user}","branches_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/branches{/branch}","tags_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/tags","blobs_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/statuses/{sha}","languages_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/languages","stargazers_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/stargazers","contributors_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/contributors","subscribers_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/subscribers","subscription_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/subscription","commits_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/contents/{+path}","compare_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/merges","archive_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/downloads","issues_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues{/number}","pulls_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls{/number}","milestones_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/milestones{/number}","notifications_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/labels{/name}","releases_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/releases{/id}","deployments_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/deployments","created_at":"2011-09-09T20:22:21Z","updated_at":"2017-04-15T00:55:02Z","pushed_at":"2018-02-02T22:11:52Z","git_url":"git://github.com/UNC-Libraries/Carolina-Digital-Repository.git","ssh_url":"git@github.com:UNC-Libraries/Carolina-Digital-Repository.git","clone_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository.git","svn_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository","homepage":"http://www.lib.unc.edu/blogs/cdr/index.php/about/","size":104253,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":10,"open_issues":2,"watchers":9,"default_branch":"fcrepo4"}},"base":{"label":"UNC-Libraries:fcrepo4","ref":"fcrepo4","sha":"3e24122af59be71144392587082966f53aa84e8e","user":{"login":"UNC-Libraries","id":552066,"avatar_url":"https://avatars0.githubusercontent.com/u/552066?v=4","gravatar_id":"","url":"https://api.github.com/users/UNC-Libraries","html_url":"https://github.com/UNC-Libraries","followers_url":"https://api.github.com/users/UNC-Libraries/followers","following_url":"https://api.github.com/users/UNC-Libraries/following{/other_user}","gists_url":"https://api.github.com/users/UNC-Libraries/gists{/gist_id}","starred_url":"https://api.github.com/users/UNC-Libraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNC-Libraries/subscriptions","organizations_url":"https://api.github.com/users/UNC-Libraries/orgs","repos_url":"https://api.github.com/users/UNC-Libraries/repos","events_url":"https://api.github.com/users/UNC-Libraries/events{/privacy}","received_events_url":"https://api.github.com/users/UNC-Libraries/received_events","type":"Organization","site_admin":false},"repo":{"id":2357859,"name":"Carolina-Digital-Repository","full_name":"UNC-Libraries/Carolina-Digital-Repository","owner":{"login":"UNC-Libraries","id":552066,"avatar_url":"https://avatars0.githubusercontent.com/u/552066?v=4","gravatar_id":"","url":"https://api.github.com/users/UNC-Libraries","html_url":"https://github.com/UNC-Libraries","followers_url":"https://api.github.com/users/UNC-Libraries/followers","following_url":"https://api.github.com/users/UNC-Libraries/following{/other_user}","gists_url":"https://api.github.com/users/UNC-Libraries/gists{/gist_id}","starred_url":"https://api.github.com/users/UNC-Libraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNC-Libraries/subscriptions","organizations_url":"https://api.github.com/users/UNC-Libraries/orgs","repos_url":"https://api.github.com/users/UNC-Libraries/repos","events_url":"https://api.github.com/users/UNC-Libraries/events{/privacy}","received_events_url":"https://api.github.com/users/UNC-Libraries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository","description":"Carolina Digital Repository","fork":false,"url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository","forks_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/forks","keys_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/teams","hooks_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/hooks","issue_events_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/events{/number}","events_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/events","assignees_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/assignees{/user}","branches_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/branches{/branch}","tags_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/tags","blobs_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/statuses/{sha}","languages_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/languages","stargazers_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/stargazers","contributors_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/contributors","subscribers_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/subscribers","subscription_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/subscription","commits_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/contents/{+path}","compare_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/merges","archive_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/downloads","issues_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues{/number}","pulls_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls{/number}","milestones_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/milestones{/number}","notifications_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/labels{/name}","releases_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/releases{/id}","deployments_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/deployments","created_at":"2011-09-09T20:22:21Z","updated_at":"2017-04-15T00:55:02Z","pushed_at":"2018-02-02T22:11:52Z","git_url":"git://github.com/UNC-Libraries/Carolina-Digital-Repository.git","ssh_url":"git@github.com:UNC-Libraries/Carolina-Digital-Repository.git","clone_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository.git","svn_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository","homepage":"http://www.lib.unc.edu/blogs/cdr/index.php/about/","size":104253,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":10,"open_issues":2,"watchers":9,"default_branch":"fcrepo4"}},"_links":{"self":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/705"},"html":{"href":"https://github.com/UNC-Libraries/Carolina-Digital-Repository/pull/705"},"issue":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/705"},"comments":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/705/comments"},"review_comments":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/705/comments"},"review_comment":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/705/commits"},"statuses":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/statuses/88ed2c5a4955b5960449140055ea92f82a42074a"}},"author_association":"OWNER"}}
{"actor":{"display_login":"harringj"}}