{"action":"closed","number":3111,"pull_request":{"url":"https://api.github.com/repos/servo/webrender/pulls/3111","id":217620238,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NjIwMjM4","html_url":"https://github.com/servo/webrender/pull/3111","diff_url":"https://github.com/servo/webrender/pull/3111.diff","patch_url":"https://github.com/servo/webrender/pull/3111.patch","issue_url":"https://api.github.com/repos/servo/webrender/issues/3111","number":3111,"state":"closed","locked":false,"title":"Store a queue of rasterized blobs instead for non-tiled images (take two)","user":{"login":"nical","id":264854,"node_id":"MDQ6VXNlcjI2NDg1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/264854?v=4","gravatar_id":"","url":"https://api.github.com/users/nical","html_url":"https://github.com/nical","followers_url":"https://api.github.com/users/nical/followers","following_url":"https://api.github.com/users/nical/following{/other_user}","gists_url":"https://api.github.com/users/nical/gists{/gist_id}","starred_url":"https://api.github.com/users/nical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nical/subscriptions","organizations_url":"https://api.github.com/users/nical/orgs","repos_url":"https://api.github.com/users/nical/repos","events_url":"https://api.github.com/users/nical/events{/privacy}","received_events_url":"https://api.github.com/users/nical/received_events","type":"User","site_admin":false},"body":"The 3 commits from #3079 which were reverted in #3108 plus a commit that fixes the crash that motivated the backout.\r\n\r\nBugzilla entry: https://bugzilla.mozilla.org/show_bug.cgi?id=1493177\r\n\r\n\r\nIn the texture cache we have an automatic and a manual eviction policy. The manual eviction policy ensures blob images don't get automatically evicted from the cache which could otherwise race with the asynchronous rasterization. The Texture cache was missing a tiny piece of code to ensure the eviction policy was respected in for shared cache entries (it does work for normal cache entries). I bet border images make uses of these shared entries. While scrolling the image eventually gets discarded and next time we see it we request the image. The problem is that when we decide whether a blob image is missing, we only look at whether there is an entry in the rasterized_blob_image map, but we don't check whether that entry contains any actual data to upload in its queue.\r\n\r\nBefore the regressing commit, the bug would occur without crashing, but we wouldn't necessary upload all of the image (only the last available dirty region). With that commit we end up requesting something we think we have but don't have and later panic with an empty handed upload request.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/webrender/3111)\n<!-- Reviewable:end -->\n","created_at":"2018-09-24T11:05:26Z","updated_at":"2018-09-25T18:56:25Z","closed_at":"2018-09-25T18:56:25Z","merged_at":"2018-09-25T18:56:25Z","merge_commit_sha":"cc61e45c0a652b1573212d15ff61c6834023adb3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/servo/webrender/pulls/3111/commits","review_comments_url":"https://api.github.com/repos/servo/webrender/pulls/3111/comments","review_comment_url":"https://api.github.com/repos/servo/webrender/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/webrender/issues/3111/comments","statuses_url":"https://api.github.com/repos/servo/webrender/statuses/cc61e45c0a652b1573212d15ff61c6834023adb3","head":{"label":"nical:blob-update-queue","ref":"blob-update-queue","sha":"cc61e45c0a652b1573212d15ff61c6834023adb3","user":{"login":"nical","id":264854,"node_id":"MDQ6VXNlcjI2NDg1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/264854?v=4","gravatar_id":"","url":"https://api.github.com/users/nical","html_url":"https://github.com/nical","followers_url":"https://api.github.com/users/nical/followers","following_url":"https://api.github.com/users/nical/following{/other_user}","gists_url":"https://api.github.com/users/nical/gists{/gist_id}","starred_url":"https://api.github.com/users/nical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nical/subscriptions","organizations_url":"https://api.github.com/users/nical/orgs","repos_url":"https://api.github.com/users/nical/repos","events_url":"https://api.github.com/users/nical/events{/privacy}","received_events_url":"https://api.github.com/users/nical/received_events","type":"User","site_admin":false},"repo":{"id":65930655,"node_id":"MDEwOlJlcG9zaXRvcnk2NTkzMDY1NQ==","name":"webrender","full_name":"nical/webrender","private":false,"owner":{"login":"nical","id":264854,"node_id":"MDQ6VXNlcjI2NDg1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/264854?v=4","gravatar_id":"","url":"https://api.github.com/users/nical","html_url":"https://github.com/nical","followers_url":"https://api.github.com/users/nical/followers","following_url":"https://api.github.com/users/nical/following{/other_user}","gists_url":"https://api.github.com/users/nical/gists{/gist_id}","starred_url":"https://api.github.com/users/nical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nical/subscriptions","organizations_url":"https://api.github.com/users/nical/orgs","repos_url":"https://api.github.com/users/nical/repos","events_url":"https://api.github.com/users/nical/events{/privacy}","received_events_url":"https://api.github.com/users/nical/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nical/webrender","description":"A very incomplete proof of concept GPU renderer for Servo","fork":true,"url":"https://api.github.com/repos/nical/webrender","forks_url":"https://api.github.com/repos/nical/webrender/forks","keys_url":"https://api.github.com/repos/nical/webrender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nical/webrender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nical/webrender/teams","hooks_url":"https://api.github.com/repos/nical/webrender/hooks","issue_events_url":"https://api.github.com/repos/nical/webrender/issues/events{/number}","events_url":"https://api.github.com/repos/nical/webrender/events","assignees_url":"https://api.github.com/repos/nical/webrender/assignees{/user}","branches_url":"https://api.github.com/repos/nical/webrender/branches{/branch}","tags_url":"https://api.github.com/repos/nical/webrender/tags","blobs_url":"https://api.github.com/repos/nical/webrender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nical/webrender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nical/webrender/git/refs{/sha}","trees_url":"https://api.github.com/repos/nical/webrender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nical/webrender/statuses/{sha}","languages_url":"https://api.github.com/repos/nical/webrender/languages","stargazers_url":"https://api.github.com/repos/nical/webrender/stargazers","contributors_url":"https://api.github.com/repos/nical/webrender/contributors","subscribers_url":"https://api.github.com/repos/nical/webrender/subscribers","subscription_url":"https://api.github.com/repos/nical/webrender/subscription","commits_url":"https://api.github.com/repos/nical/webrender/commits{/sha}","git_commits_url":"https://api.github.com/repos/nical/webrender/git/commits{/sha}","comments_url":"https://api.github.com/repos/nical/webrender/comments{/number}","issue_comment_url":"https://api.github.com/repos/nical/webrender/issues/comments{/number}","contents_url":"https://api.github.com/repos/nical/webrender/contents/{+path}","compare_url":"https://api.github.com/repos/nical/webrender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nical/webrender/merges","archive_url":"https://api.github.com/repos/nical/webrender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nical/webrender/downloads","issues_url":"https://api.github.com/repos/nical/webrender/issues{/number}","pulls_url":"https://api.github.com/repos/nical/webrender/pulls{/number}","milestones_url":"https://api.github.com/repos/nical/webrender/milestones{/number}","notifications_url":"https://api.github.com/repos/nical/webrender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nical/webrender/labels{/name}","releases_url":"https://api.github.com/repos/nical/webrender/releases{/id}","deployments_url":"https://api.github.com/repos/nical/webrender/deployments","created_at":"2016-08-17T18:05:18Z","updated_at":"2018-04-09T10:29:13Z","pushed_at":"2018-09-25T14:36:09Z","git_url":"git://github.com/nical/webrender.git","ssh_url":"git@github.com:nical/webrender.git","clone_url":"https://github.com/nical/webrender.git","svn_url":"https://github.com/nical/webrender","homepage":"https://doc.servo.org/webrender/","size":30770,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"a0230e4bd18d9b30cde0b6ce07d8d9a8985323dd","user":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":42894575,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjg5NDU3NQ==","name":"webrender","full_name":"servo/webrender","private":false,"owner":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/servo/webrender","description":"A GPU-based renderer for the web","fork":false,"url":"https://api.github.com/repos/servo/webrender","forks_url":"https://api.github.com/repos/servo/webrender/forks","keys_url":"https://api.github.com/repos/servo/webrender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/webrender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/webrender/teams","hooks_url":"https://api.github.com/repos/servo/webrender/hooks","issue_events_url":"https://api.github.com/repos/servo/webrender/issues/events{/number}","events_url":"https://api.github.com/repos/servo/webrender/events","assignees_url":"https://api.github.com/repos/servo/webrender/assignees{/user}","branches_url":"https://api.github.com/repos/servo/webrender/branches{/branch}","tags_url":"https://api.github.com/repos/servo/webrender/tags","blobs_url":"https://api.github.com/repos/servo/webrender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/webrender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/webrender/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/webrender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/webrender/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/webrender/languages","stargazers_url":"https://api.github.com/repos/servo/webrender/stargazers","contributors_url":"https://api.github.com/repos/servo/webrender/contributors","subscribers_url":"https://api.github.com/repos/servo/webrender/subscribers","subscription_url":"https://api.github.com/repos/servo/webrender/subscription","commits_url":"https://api.github.com/repos/servo/webrender/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/webrender/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/webrender/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/webrender/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/webrender/contents/{+path}","compare_url":"https://api.github.com/repos/servo/webrender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/webrender/merges","archive_url":"https://api.github.com/repos/servo/webrender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/webrender/downloads","issues_url":"https://api.github.com/repos/servo/webrender/issues{/number}","pulls_url":"https://api.github.com/repos/servo/webrender/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/webrender/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/webrender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/webrender/labels{/name}","releases_url":"https://api.github.com/repos/servo/webrender/releases{/id}","deployments_url":"https://api.github.com/repos/servo/webrender/deployments","created_at":"2015-09-21T21:27:30Z","updated_at":"2018-09-25T17:59:20Z","pushed_at":"2018-09-25T18:56:23Z","git_url":"git://github.com/servo/webrender.git","ssh_url":"git@github.com:servo/webrender.git","clone_url":"https://github.com/servo/webrender.git","svn_url":"https://github.com/servo/webrender","homepage":"https://doc.servo.org/webrender/","size":35495,"stargazers_count":1245,"watchers_count":1245,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":183,"mirror_url":null,"archived":false,"open_issues_count":197,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":183,"open_issues":197,"watchers":1245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/webrender/pulls/3111"},"html":{"href":"https://github.com/servo/webrender/pull/3111"},"issue":{"href":"https://api.github.com/repos/servo/webrender/issues/3111"},"comments":{"href":"https://api.github.com/repos/servo/webrender/issues/3111/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/webrender/pulls/3111/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/webrender/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/webrender/pulls/3111/commits"},"statuses":{"href":"https://api.github.com/repos/servo/webrender/statuses/cc61e45c0a652b1573212d15ff61c6834023adb3"}},"author_association":"COLLABORATOR","merged":true,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":{"login":"bors-servo","id":4368172,"node_id":"MDQ6VXNlcjQzNjgxNzI=","avatar_url":"https://avatars1.githubusercontent.com/u/4368172?v=4","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"comments":12,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":177,"deletions":126,"changed_files":2}}
{"actor":{"display_login":"bors-servo"}}