{"action":"created","comment":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/222918512","pull_request_review_id":161922777,"id":222918512,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjkxODUxMg==","diff_hunk":"@@ -1821,6 +1821,80 @@ namespace aspect\n   }\n \n \n+  template <int dim>\n+  void\n+  Simulator<dim>::replace_outflow_boundary_ids(const unsigned int offset)\n+  {\n+    const QGauss<dim-1> quadrature_formula (finite_element.base_element(introspection.base_elements.temperature).degree+1);\n+\n+    FEFaceValues<dim> fe_face_values (*mapping,\n+                                      finite_element,\n+                                      quadrature_formula,\n+                                      update_gradients      | update_values |\n+                                      update_normal_vectors |\n+                                      update_q_points       | update_JxW_values);\n+\n+    std::vector<Tensor<1,dim> > face_current_velocity_values (fe_face_values.n_quadrature_points);\n+\n+    // Loop over all of the boundary faces, ...\n+    typename DoFHandler<dim>::active_cell_iterator\n+    cell = dof_handler.begin_active(),\n+    endc = dof_handler.end();\n+\n+    for (; cell!=endc; ++cell)\n+      if (!cell->is_artificial())\n+        for (unsigned int face_number=0; face_number<GeometryInfo<dim>::faces_per_cell; ++face_number)\n+          {\n+            typename DoFHandler<dim>::face_iterator face = cell->face(face_number);\n+            if (face->at_boundary())\n+              {\n+                Assert(face->boundary_id() <= offset,\n+                       ExcMessage(\"You can not use more than 10000 boundary indicators!\"));","path":"source/simulator/helper_functions.cc","position":32,"original_position":32,"commit_id":"16c0ce8ee4521790d1e5702755d3b04b65442f56","original_commit_id":"16c0ce8ee4521790d1e5702755d3b04b65442f56","user":{"login":"tjhei","id":1531285,"node_id":"MDQ6VXNlcjE1MzEyODU=","avatar_url":"https://avatars0.githubusercontent.com/u/1531285?v=4","gravatar_id":"","url":"https://api.github.com/users/tjhei","html_url":"https://github.com/tjhei","followers_url":"https://api.github.com/users/tjhei/followers","following_url":"https://api.github.com/users/tjhei/following{/other_user}","gists_url":"https://api.github.com/users/tjhei/gists{/gist_id}","starred_url":"https://api.github.com/users/tjhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjhei/subscriptions","organizations_url":"https://api.github.com/users/tjhei/orgs","repos_url":"https://api.github.com/users/tjhei/repos","events_url":"https://api.github.com/users/tjhei/events{/privacy}","received_events_url":"https://api.github.com/users/tjhei/received_events","type":"User","site_admin":false},"body":"Yes, the error should be something like \"To allow 'Allow fixed composition on outflow boundaries' you are only allowed to use boundary ids between 0 and <offset>\".","created_at":"2018-10-05T07:48:26Z","updated_at":"2018-10-05T07:48:27Z","html_url":"https://github.com/geodynamics/aspect/pull/2419#discussion_r222918512","pull_request_url":"https://api.github.com/repos/geodynamics/aspect/pulls/2419","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/222918512"},"html":{"href":"https://github.com/geodynamics/aspect/pull/2419#discussion_r222918512"},"pull_request":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2419"}},"in_reply_to_id":222766997},"pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/2419","id":196963722,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTYzNzIy","html_url":"https://github.com/geodynamics/aspect/pull/2419","diff_url":"https://github.com/geodynamics/aspect/pull/2419.diff","patch_url":"https://github.com/geodynamics/aspect/pull/2419.patch","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/2419","number":2419,"state":"open","locked":false,"title":"[Bugfix] add an option that fixes temperature/composition only on inflow/close…","user":{"login":"jdannberg","id":7517347,"node_id":"MDQ6VXNlcjc1MTczNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7517347?v=4","gravatar_id":"","url":"https://api.github.com/users/jdannberg","html_url":"https://github.com/jdannberg","followers_url":"https://api.github.com/users/jdannberg/followers","following_url":"https://api.github.com/users/jdannberg/following{/other_user}","gists_url":"https://api.github.com/users/jdannberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jdannberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdannberg/subscriptions","organizations_url":"https://api.github.com/users/jdannberg/orgs","repos_url":"https://api.github.com/users/jdannberg/repos","events_url":"https://api.github.com/users/jdannberg/events{/privacy}","received_events_url":"https://api.github.com/users/jdannberg/received_events","type":"User","site_admin":false},"body":"…d boundaries, but not on outflow boundaries. \r\n\r\nFixes #903.\r\n\r\nWe can discuss what the default for the temperature equation should be. \r\n\r\nAnd I still have to add a changelog entry (which I will do after we've agreed on a the default for the temperature). ","created_at":"2018-06-24T18:44:38Z","updated_at":"2018-10-05T07:48:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c12dbec17f21c848315048cc38fdd6da413bc391","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/geodynamics/aspect/pulls/2419/commits","review_comments_url":"https://api.github.com/repos/geodynamics/aspect/pulls/2419/comments","review_comment_url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/2419/comments","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/16c0ce8ee4521790d1e5702755d3b04b65442f56","head":{"label":"jdannberg:no_dirichlet_on_outflow","ref":"no_dirichlet_on_outflow","sha":"16c0ce8ee4521790d1e5702755d3b04b65442f56","user":{"login":"jdannberg","id":7517347,"node_id":"MDQ6VXNlcjc1MTczNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7517347?v=4","gravatar_id":"","url":"https://api.github.com/users/jdannberg","html_url":"https://github.com/jdannberg","followers_url":"https://api.github.com/users/jdannberg/followers","following_url":"https://api.github.com/users/jdannberg/following{/other_user}","gists_url":"https://api.github.com/users/jdannberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jdannberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdannberg/subscriptions","organizations_url":"https://api.github.com/users/jdannberg/orgs","repos_url":"https://api.github.com/users/jdannberg/repos","events_url":"https://api.github.com/users/jdannberg/events{/privacy}","received_events_url":"https://api.github.com/users/jdannberg/received_events","type":"User","site_admin":false},"repo":{"id":19785028,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc4NTAyOA==","name":"aspect","full_name":"jdannberg/aspect","private":false,"owner":{"login":"jdannberg","id":7517347,"node_id":"MDQ6VXNlcjc1MTczNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7517347?v=4","gravatar_id":"","url":"https://api.github.com/users/jdannberg","html_url":"https://github.com/jdannberg","followers_url":"https://api.github.com/users/jdannberg/followers","following_url":"https://api.github.com/users/jdannberg/following{/other_user}","gists_url":"https://api.github.com/users/jdannberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jdannberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdannberg/subscriptions","organizations_url":"https://api.github.com/users/jdannberg/orgs","repos_url":"https://api.github.com/users/jdannberg/repos","events_url":"https://api.github.com/users/jdannberg/events{/privacy}","received_events_url":"https://api.github.com/users/jdannberg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jdannberg/aspect","description":"Finite element parallel code to simulate problems in thermal convection in both 2D and 3D models.","fork":true,"url":"https://api.github.com/repos/jdannberg/aspect","forks_url":"https://api.github.com/repos/jdannberg/aspect/forks","keys_url":"https://api.github.com/repos/jdannberg/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdannberg/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdannberg/aspect/teams","hooks_url":"https://api.github.com/repos/jdannberg/aspect/hooks","issue_events_url":"https://api.github.com/repos/jdannberg/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/jdannberg/aspect/events","assignees_url":"https://api.github.com/repos/jdannberg/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/jdannberg/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/jdannberg/aspect/tags","blobs_url":"https://api.github.com/repos/jdannberg/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdannberg/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdannberg/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdannberg/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdannberg/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/jdannberg/aspect/languages","stargazers_url":"https://api.github.com/repos/jdannberg/aspect/stargazers","contributors_url":"https://api.github.com/repos/jdannberg/aspect/contributors","subscribers_url":"https://api.github.com/repos/jdannberg/aspect/subscribers","subscription_url":"https://api.github.com/repos/jdannberg/aspect/subscription","commits_url":"https://api.github.com/repos/jdannberg/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdannberg/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdannberg/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdannberg/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdannberg/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/jdannberg/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdannberg/aspect/merges","archive_url":"https://api.github.com/repos/jdannberg/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdannberg/aspect/downloads","issues_url":"https://api.github.com/repos/jdannberg/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/jdannberg/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/jdannberg/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/jdannberg/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdannberg/aspect/labels{/name}","releases_url":"https://api.github.com/repos/jdannberg/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/jdannberg/aspect/deployments","created_at":"2014-05-14T15:28:24Z","updated_at":"2015-09-22T19:25:32Z","pushed_at":"2018-10-04T22:31:12Z","git_url":"git://github.com/jdannberg/aspect.git","ssh_url":"git@github.com:jdannberg/aspect.git","clone_url":"https://github.com/jdannberg/aspect.git","svn_url":"https://github.com/jdannberg/aspect","homepage":null,"size":173787,"stargazers_count":0,"watchers_count":0,"language":"Gnuplot","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"geodynamics:master","ref":"master","sha":"1c5ae15dbf0831b1bf314600c7e982e3dacd7ce6","user":{"login":"geodynamics","id":4052461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTI0NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4052461?v=4","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"repo":{"id":19502452,"node_id":"MDEwOlJlcG9zaXRvcnkxOTUwMjQ1Mg==","name":"aspect","full_name":"geodynamics/aspect","private":false,"owner":{"login":"geodynamics","id":4052461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTI0NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4052461?v=4","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/geodynamics/aspect","description":"A parallel, extensible finite element code to simulate convection in both 2D and 3D models.","fork":false,"url":"https://api.github.com/repos/geodynamics/aspect","forks_url":"https://api.github.com/repos/geodynamics/aspect/forks","keys_url":"https://api.github.com/repos/geodynamics/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geodynamics/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geodynamics/aspect/teams","hooks_url":"https://api.github.com/repos/geodynamics/aspect/hooks","issue_events_url":"https://api.github.com/repos/geodynamics/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/geodynamics/aspect/events","assignees_url":"https://api.github.com/repos/geodynamics/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/geodynamics/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/geodynamics/aspect/tags","blobs_url":"https://api.github.com/repos/geodynamics/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geodynamics/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geodynamics/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/geodynamics/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/geodynamics/aspect/languages","stargazers_url":"https://api.github.com/repos/geodynamics/aspect/stargazers","contributors_url":"https://api.github.com/repos/geodynamics/aspect/contributors","subscribers_url":"https://api.github.com/repos/geodynamics/aspect/subscribers","subscription_url":"https://api.github.com/repos/geodynamics/aspect/subscription","commits_url":"https://api.github.com/repos/geodynamics/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/geodynamics/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/geodynamics/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/geodynamics/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/geodynamics/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/geodynamics/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geodynamics/aspect/merges","archive_url":"https://api.github.com/repos/geodynamics/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geodynamics/aspect/downloads","issues_url":"https://api.github.com/repos/geodynamics/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/geodynamics/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/geodynamics/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/geodynamics/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geodynamics/aspect/labels{/name}","releases_url":"https://api.github.com/repos/geodynamics/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/geodynamics/aspect/deployments","created_at":"2014-05-06T16:47:18Z","updated_at":"2018-10-04T18:00:11Z","pushed_at":"2018-10-04T22:31:14Z","git_url":"git://github.com/geodynamics/aspect.git","ssh_url":"git@github.com:geodynamics/aspect.git","clone_url":"https://github.com/geodynamics/aspect.git","svn_url":"https://github.com/geodynamics/aspect","homepage":"https://aspect.geodynamics.org/","size":180147,"stargazers_count":55,"watchers_count":55,"language":"Gnuplot","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":216,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":105,"open_issues":216,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2419"},"html":{"href":"https://github.com/geodynamics/aspect/pull/2419"},"issue":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/2419"},"comments":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/2419/comments"},"review_comments":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2419/comments"},"review_comment":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2419/commits"},"statuses":{"href":"https://api.github.com/repos/geodynamics/aspect/statuses/16c0ce8ee4521790d1e5702755d3b04b65442f56"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tjhei"}}